date:20161223

[GitHub] cloudstack issue #1828: CLOUDSTACK-9676 Start instance fails after reverting...

2016-12-23 Thread sateesh-chodapuneedi

Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1828
  
@rhtyd Travis is green for this PR. 
Can this be merged based on LGTMs and integration test results?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1854: 4.9 multiplex testing

2016-12-23 Thread borisstoyanov

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1854
  
@rhtyd I'm on the Xen failures and just re-run the snapshots one and it 
passed. So I guess there was something wrong with the environment at that point 

```
Test Snapshot Root Disk ... === TestName: test_01_snapshot_root_disk | 
Status : SUCCESS ===
ok

--
Ran 1 test in 241.647s

OK
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSS] 4.9.2.0 with XenServer7 support, and 4.10.0.0 RM

2016-12-23 Thread Rohit Yadav

All,


4.9.1.0 was voted recently but did not receive a lot of attention in terms of 
testing/voting, and several users reports on the list and privately that they 
would want to have XenServer7 support. I agree with Marty and other users that 
it would be a great holiday present to release another minor 4.9.2.0 release 
that bundles few bugfixes and support for XenServer7.


I'm planning to work towards 4.9.2.0 so as to at least cut 4.9.2.0-rc1 
on/before 1st Jan, and currently working towards stabilizing 4.9.


Given the current holiday period and to avoid competing voting threads -- if 
there are no objections, I'm pushing the freeze date for 4.10/master to 30th 
January? I would also like to invite anyone who wants to take over as RM for 
the 4.10.0.0 release, thanks.


Master will be open to accept bugfixes and PRs that can be reviewed/merged. 
There are several good PRs we can review/merge such as Wido's PR on ipv6 
support for basic zone/network, and Jayapal's/Will's Strongswan VPN. I would be 
willing to accept PRs that don't break any smoke tests on xen/vmware/kvm (as 
covered by Travis, Trillian, BVT and others) and growing list of component 
tests that have been added in Travis and some of which we've started running in 
Trillian.


Happy holidays.


Regards.

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
@blueorangutan test centos7 kvm-centos6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos6) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1854: 4.9 multiplex testing

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1854
  
Thanks @borisstoyanov I re ran that test too. I'm re-running failed tests 
and with Murali's fix. Most tests are green on KVM now, currently investigation 
vmware and xenserver environments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread nitin-maharana

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1859

CLOUDSTACK - 8672 : NCC Integration with CloudStack 

Feature Specification Link :


https://cwiki.apache.org/confluence/display/CLOUDSTACK/NCC+Integration+With+Auto+Provision+VPX+in+CloudStack

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-8672

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1859.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1859


commit 73ece624c2595f8c9cd7ba75fd8fa978e80c0ecf
Author: Rajesh Battala 
Date:   2015-07-23T08:44:07Z

Schema changes for NCC support. 1. netscaler service pacages, netscaler 
control center tables.Modified network offering table to hold service package

commit 8062e3dcdbf346ef3fca2d3642a6bd2113a982a2
Author: Rajesh Battala 
Date:   2015-07-23T08:45:24Z

Added Support for Adding/Registering Netscaler Control Center Service 
Packages to CloudStack

commit ee0587994862178069ee33290f888e5c0f26cd4c
Author: Rajesh Battala 
Date:   2015-07-23T08:49:45Z

Added Support for the Registering Netscaler Control Center, Added 
associated VO's Dao's DaoImpl's

commit 85fd68ebd7304665d7c45a18902f3c7b1becbb1b
Author: Rajesh Battala 
Date:   2015-07-23T08:52:48Z

Modified Network offering to include the Netscaler Service pacakge

commit 57db30f948c982a51ea3b5fb32f21b70767eccdb
Author: Rajesh Battala 
Date:   2015-07-23T08:54:39Z

Modified Netscaler Plugin to support Netscaler Control Center Changes

commit 9bfb98aa2fb4b29edd3fed102b4e631687d01b0a
Author: Rajesh Battala 
Date:   2015-07-23T08:57:08Z

Added NetscalerControlCenter Resource supporte and Change State Support

commit 1ebb6eda7e8bce9208ffd88ef380e0b4623901f6
Author: Rajesh Battala 
Date:   2015-07-23T08:58:20Z

Added json libaray mvn dependency in the Netscaler Plugin

commit ef06739713766027c05c004fcd9e421743808ad0
Author: Rajesh Battala 
Date:   2015-07-31T08:44:33Z

CLOUDSTACK-8673: Created NCC CommandTimeout param which is configurable to 
poll the AsyncJobs send to NCC

commit 053ec527e0ef585a8df6fcf277fa1a781cfe67c1
Author: Rajesh Battala 
Date:   2015-08-06T16:13:31Z

 CLOUDSTACK-8672: Implemented, implement the network with NCC as Service 
Provider.
 NCC will allocate the device to network, configures guest vlan and SNIP in 
the NS Device

commit 06a943cb4ed998fb51e69e05277879bf0e9baa93
Author: Rajesh Battala 
Date:   2015-08-06T16:16:56Z

CLOUDSTACK-8672: Implemented NetscalerControlResource to manage and 
delegate the calls to NCC Device

commit db202b7a682b0580a61373dcd542457eeff38c28
Author: Rajesh Battala 
Date:   2015-08-06T16:18:31Z

CLOUDSTACK-8672 Modified LoadBalancerTO to hold network id and public ip 
Vlan

commit 4f081bd5d9eb2743b7c74845099ac4083f1161c0
Author: Priyank Parihar 
Date:   2015-08-07T11:10:00Z

CLOUDSTACK-8672: Added ListRegisteredServicePackage Command.

commit 1b72dbed1d033dd51891a78fc3398b5bb25d4f5b
Author: Priyank Parihar 
Date:   2015-08-07T11:29:54Z

CLOUDSTACK-8672: Added DeleteServicePackageOffering Command.

commit 9a600ce63bfc5311ceb5974870529cad94306795
Author: Nitin Kumar Maharana 
Date:   2015-08-07T11:40:13Z

CLOUDSTACK-8672: Added ListNetscalerControlCenter command.

commit d68ee0ebf27da2cd50ae0534ab147ed05cf33fd7
Author: Priyank Parihar 
Date:   2015-08-07T11:42:26Z

CLOUDSTACK-8672: Added DeleteNetscalerControlCenter Command.

commit 7be6fab98c146a1f548a90307c8c08b70f53a900
Author: Nitin Kumar Maharana 
Date:   2016-12-18T18:13:23Z

LOUDSTACK-8672: Modified NCC Controlcenter Table

commit 6c583c20424f8d240010f8f126d98e4cad5fdcfa
Author: Nitin Kumar Maharana 
Date:   2015-08-24T11:15:49Z

CLOUDSTACK-8672 Added UI Support for the SSL Termination

1. UI Support for account to upload SSL Certificate.
2. UI Support for assigning SSL Certificate to a LB Rule.
3. Modified LB Rule creation UI to show LB Protocol and to show SSL based 
on LB Service provider capability.

commit 9c32d7ca4b30b1d47a57c5badda25258daeb819f
Author: Nitin Kumar Maharana 
Date:   2015-08-24T11:31:46Z

CLOUDSTACK-8672 New Dialog to assign a SSL certificate to LB Rule.

commit e0735fdc79d4abb3d8ac572f089bfa636d489f29
Author: Nitin Kumar Maharana 
Date:   2015-08-25T10:55:30Z

CLOUDSTACK-8672 Added UI Support for selecting Netscaler service packages 
when creating network offering with LB provier as Netscaler.

commit b5a868b60a27a24d270a1a1806152e75413f9702
Author: Priyank Parihar 
Date:   2015-08-26T11:18:14Z

CLOUDSTACK-8672: Added Acquire Pod Ip Command.

commit f76efa274c8ae36bf67e10bcd1e2ff5853771d78
Author: Priyank Parihar 
Date:   2015-08-26T11:20:31Z

CLOUDSTACK-8672: Added Release Pod Ip Command

Edit page permission in cwiki.

2016-12-23 Thread Nitin Kumar Maharana

Hi,

I don’t have permission to edit a page in cwiki.
Even I don’t have permission to assign issues to myself in JIRA.

Can you please give me these accesses.
Username : nitin.maharana


Thanks,
Nitin





DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack issue #1828: CLOUDSTACK-9676 Start instance fails after reverting...

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1828
  
Sure @sateesh-chodapuneedi I've included your fix in 
https://github.com/apache/cloudstack/pull/1854


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93747834
  
--- Diff: server/src/com/cloud/hypervisor/HypervisorGuruBase.java ---
@@ -132,7 +133,12 @@ protected VirtualMachineTO 
toVirtualMachineTO(VirtualMachineProfile vmProfile) {
 NicTO[] nics = new NicTO[nicProfiles.size()];
 int i = 0;
 for (NicProfile nicProfile : nicProfiles) {
-nics[i++] = toNicTO(nicProfile);
+if(vm.getType() == VirtualMachine.Type.NetScalerVm) {
+//if(i == 0){
--- End diff --

Remove unused code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93746500
  
--- Diff: 
engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java ---
@@ -177,6 +177,22 @@ public void releaseIpAddress(long nicId, String 
reservationId) {
 }
 
 @Override
+public void releasePodIpAddress(long id) {
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("Releasing ip address for ID=" + id);
+}
+//SearchCriteria sc = 
AllFieldsSearch.create();
--- End diff --

Remove this unused code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93746542
  
--- Diff: 
engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java ---
@@ -177,6 +177,22 @@ public void releaseIpAddress(long nicId, String 
reservationId) {
 }
 
 @Override
+public void releasePodIpAddress(long id) {
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("Releasing ip address for ID=" + id);
+}
+//SearchCriteria sc = 
AllFieldsSearch.create();
+//sc.setParameters("id", id);
+
+DataCenterIpAddressVO vo = this.findById(id);
+vo.setTakenAt(null);
+vo.setInstanceId(null);
+vo.setReservationId(null);
+persist(vo);
+//update(vo, sc);
--- End diff --

Remove unused code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93748252
  
--- Diff: ui/scripts/configuration.js ---
@@ -2640,12 +2640,30 @@
 }
 
 //show LB Isolation dropdown only 
when (1)LB Service is checked (2)Service Provider is Netscaler OR F5
-if 
((args.$form.find('.form-item[rel=\"service.Lb.isEnabled\"]').find('input[type=checkbox]').is(':checked')
 == true) && 
(args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val()
 == 'Netscaler' || 
args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val() 
== 'F5BigIp')) {
+/*if 
((args.$form.find('.form-item[rel=\"service.Lb.isEnabled\"]').find('input[type=checkbox]').is(':checked')
 == true) && 
(args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val()
 == 'Netscaler' || 
args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val() 
== 'F5BigIp')) {
--- End diff --

Remove unused code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93747629
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerLoadBalancerElementService.java
 ---
@@ -71,4 +121,29 @@
  * @return NetscalerLoadBalancerResponse
  */
 public NetscalerLoadBalancerResponse 
createNetscalerLoadBalancerResponse(ExternalLoadBalancerDeviceVO lbDeviceVO);
-}
+
+/**
+ * creates API response object for netscaler load balancers
+ * @param lbDeviceVO external load balancer VO object
+ * @return NetscalerLoadBalancerResponse
+ */
+public NetScalerServicePackageResponse 
registerNetscalerServicePackage(RegisterServicePackageCmd cmd);
+
+public NetscalerControlCenterResponse 
createNetscalerControlCenterResponse(NetScalerControlCenterVO lncCentersVO);
+
+public NetScalerServicePackageResponse 
createRegisteredServicePackageResponse(NetScalerServicePackageVO lrsPackageVO);
+
+public NetScalerServicePackageResponse 
deleteNetscalerServicePackage(RegisterServicePackageCmd cmd);
+
+public NetScalerServicePackageResponse 
listNetscalerServicePackage(RegisterServicePackageCmd cmd);
+
+public NetScalerServicePackageResponse 
createNetscalerServicePackageResponse(NetScalerServicePackageVO 
servicePackageVO);
+
+public NetScalerControlCenterVO 
registerNetscalerControlCenter(RegisterNetscalerControlCenterCmd 
registerNetscalerControlCenterCmd);
+
+//public VirtualMachine deployNetscalerServiceVm(DeployNetscalerVpxCmd 
deployNetscalerVpxCmd);
--- End diff --

Remove unused code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93747870
  
--- Diff: 
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java ---
@@ -900,6 +945,17 @@ public boolean applyLoadBalancerRules(Network network, 
List l
 String algorithm = rule.getAlgorithm();
 String uuid = rule.getUuid();
 String srcIp = rule.getSourceIp().addr();
+String srcIpVlan = null;
+String srcIpGateway = null;
+String srcIpNetmask = null;
+//IpAddress ipAddress =  
_networkModel.getPublicIpAddress(rule.getSourceIp().addr(), 
network.getDataCenterId()).getVlanId();
--- End diff --

Remove unused code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93747795
  
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java 
---
@@ -4781,6 +4818,12 @@ public boolean deleteNetworkOffering(final 
DeleteNetworkOfferingCmd cmd) {
 + "To make the network offering unavaiable, disable 
it");
 }
 
+//if (offering.getServicePackage() != null) {
--- End diff --

Remove unused code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93747692
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/vm/NetScalerVMManager.java
 ---
@@ -0,0 +1,86 @@
+//Licensed to the Apache Software Foundation (ASF) under one
+//or more contributor license agreements.  See the NOTICE file
+//distributed with this work for additional information
+//regarding copyright ownership.  The ASF licenses this file
+//to you under the Apache License, Version 2.0 (the
+//"License"); you may not use this file except in compliance
+//with the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+//Unless required by applicable law or agreed to in writing,
+//software distributed under the License is distributed on an
+//"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+//KIND, either express or implied.  See the License for the
+//specific language governing permissions and limitations
+//under the License.
+package com.cloud.network.vm;
+import java.util.Map;
+
+import com.cloud.api.commands.DeployNetscalerVpxCmd;
+import com.cloud.deploy.DeployDestination;
+import com.cloud.deploy.DeploymentPlan;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.router.VirtualRouter;
+import com.cloud.user.Account;
+
+public interface NetScalerVMManager {
+
+//RAM/CPU for the system offering used by Internal LB VMs
+ public static final int DEFAULT_NETSCALER_VM_RAMSIZE = 2048;
// 2048 MB
+ public static final int DEFAULT_NETSCALER_VM_CPU_MHZ = 1024;
// 1024 MHz
+
+/* *//**
+  * Destroys Internal LB vm instance
+  * @param vmId
+  * @param caller
+  * @param callerUserId
+  * @return
+  * @throws ResourceUnavailableException
+  * @throws ConcurrentOperationException
+  *//*
+ boolean destroyInternalLbVm(long vmId, Account caller, Long callerUserId) 
throws ResourceUnavailableException, ConcurrentOperationException;
+
+ *//**
+  * Deploys internal lb vm
+  * @param guestNetwork
+  * @param requestedGuestIp
+  * @param dest
+  * @param owner
+  * @param params
+  * @return
+  * @throws InsufficientCapacityException
+  * @throws ConcurrentOperationException
+  * @throws ResourceUnavailableException
+  *//*
+ List deployInternalLbVm(Network guestNetwork, Ip 
requestedGuestIp, DeployDestination dest, Account owner, Map 
params)
+ throws InsufficientCapacityException, ConcurrentOperationException, 
ResourceUnavailableException;
+
+ *//**
+  *
+  * @param network
+  * @param rules
+  * @param internalLbVms
+  * @return
+  * @throws ResourceUnavailableException
+  *//*
+ boolean applyLoadBalancingRules(Network network, List 
rules, List internalLbVms) throws 
ResourceUnavailableException;
+
+ *//**
+  * Returns existing Internal Load Balancer elements based on 
guestNetworkId (required) and requestedIp (optional)
+  * @param guestNetworkId
+  * @param requestedGuestIp
+  * @return
+  *//*
+ List findInternalLbVms(long guestNetworkId, Ip 
requestedGuestIp);
+*/
+
+ public Map deployNetscalerServiceVm(DeployNetscalerVpxCmd 
cmd);
+
+ public VirtualRouter stopNetscalerServiceVm(Long id, boolean forced, 
Account callingAccount, long callingUserId) throws 
ConcurrentOperationException, ResourceUnavailableException;
+ public Map deployNsVpx(Account owner, DeployDestination 
dest, DeploymentPlan plan, long svcOffId, long templateId) throws 
InsufficientCapacityException;
+
+public VirtualRouter stopNetScalerVm(Long id, boolean forced, Account 
callingAccount, long callingUserId);
+}
--- End diff --

what is this extra character ("theta") at the end of this file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93746847
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/api/commands/DeleteNetscalerControlCenterCmd.java
 ---
@@ -0,0 +1,98 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.api.commands;
+
+import javax.inject.Inject;
+import javax.persistence.EntityExistsException;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.api.response.NetscalerControlCenterResponse;
+import com.cloud.exception.ConcurrentOperationException;
+//import com.cloud.exception.InvalidParameterValueException;
--- End diff --

Remove this unused code 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93747566
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerServicePackageDaoImpl.java
 ---
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.network.dao;
+
+import java.util.List;
+
+import javax.ejb.Local;
+
+import org.springframework.stereotype.Component;
+
+import com.cloud.network.NetScalerServicePackageVO;
+import com.cloud.utils.db.DB;
+import com.cloud.utils.db.GenericDaoBase;
+import com.cloud.utils.db.SearchBuilder;
+import com.cloud.utils.db.SearchCriteria;
+
+@Component
+@Local(value = NetScalerServicePackageDao.class)
+@DB
+public class NetScalerServicePackageDaoImpl extends 
GenericDaoBase implements 
NetScalerServicePackageDao {
+
+final SearchBuilder podIdSearch;
+final SearchBuilder deviceIdSearch;
+
+protected NetScalerServicePackageDaoImpl() {
+super();
+
+podIdSearch = createSearchBuilder();
+//podIdSearch.and("pod_id", podIdSearch.entity().getPodId(), 
Op.EQ);
--- End diff --

Remove unused code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93746916
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/api/commands/DeleteServicePackageOfferingCmd.java
 ---
@@ -0,0 +1,95 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.api.commands;
+
+import javax.inject.Inject;
+import javax.persistence.EntityExistsException;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.context.CallContext;
+
+import org.apache.cloudstack.api.response.SuccessResponse;
+
+import com.cloud.api.response.NetScalerServicePackageResponse;
+import com.cloud.exception.ConcurrentOperationException;
+//import com.cloud.exception.InvalidParameterValueException;
--- End diff --

Remove this unused code 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93746791
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixStartCommandWrapper.java
 ---
@@ -87,7 +87,15 @@ public Answer execute(final StartCommand command, final 
CitrixResourceBase citri
 
 final Host host = Host.getByUuid(conn, 
citrixResourceBase.getHost().getUuid());
 vm = citrixResourceBase.createVmFromTemplate(conn, vmSpec, 
host);
-
+//Add xenstore data for the NetscalerVM
+/*if(vmSpec.getType()== VirtualMachine.Type.NetScalerVm) {
--- End diff --

Remove this unused/commented code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93747990
  
--- Diff: 
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java ---
@@ -1157,14 +1222,28 @@ protected IpDeployer 
getIpDeployerForInlineMode(Network network) {
 return null;
 }
 
-ExternalLoadBalancerDeviceVO lbDeviceVO = 
getExternalLoadBalancerForNetwork(network);
+HostVO externalLoadBalancer = null;
+
+if(isNccServiceProvider(network)) {
+externalLoadBalancer  = 
getNetScalerControlCenterForNetwork(network);
+} else {
+ExternalLoadBalancerDeviceVO lbDeviceVO = 
getExternalLoadBalancerForNetwork(network);
+if (lbDeviceVO == null) {
+s_logger.warn("There is no external load balancer device 
assigned to this network either network is not implement are already shutdown 
so just returning");
+return null;
+} else {
+externalLoadBalancer = 
_hostDao.findById(lbDeviceVO.getHostId());
+}
+}
+
+/*ExternalLoadBalancerDeviceVO lbDeviceVO = 
getExternalLoadBalancerForNetwork(network);
--- End diff --

Remove unused code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93747579
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerServicePackageDaoImpl.java
 ---
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.network.dao;
+
+import java.util.List;
+
+import javax.ejb.Local;
+
+import org.springframework.stereotype.Component;
+
+import com.cloud.network.NetScalerServicePackageVO;
+import com.cloud.utils.db.DB;
+import com.cloud.utils.db.GenericDaoBase;
+import com.cloud.utils.db.SearchBuilder;
+import com.cloud.utils.db.SearchCriteria;
+
+@Component
+@Local(value = NetScalerServicePackageDao.class)
+@DB
+public class NetScalerServicePackageDaoImpl extends 
GenericDaoBase implements 
NetScalerServicePackageDao {
+
+final SearchBuilder podIdSearch;
+final SearchBuilder deviceIdSearch;
+
+protected NetScalerServicePackageDaoImpl() {
+super();
+
+podIdSearch = createSearchBuilder();
+//podIdSearch.and("pod_id", podIdSearch.entity().getPodId(), 
Op.EQ);
+podIdSearch.done();
+
+deviceIdSearch = createSearchBuilder();
+//deviceIdSearch.and("netscalerDeviceId", 
deviceIdSearch.entity().getNetscalerDeviceId(), Op.EQ);
--- End diff --

Remove unused code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93747510
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/NetScalerControlCenterVO.java
 ---
@@ -0,0 +1,129 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.network;
+
+import java.util.UUID;
+
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.GeneratedValue;
+import javax.persistence.GenerationType;
+import javax.persistence.Id;
+import javax.persistence.Table;
+
+import org.apache.cloudstack.api.InternalIdentity;
+
+
+/**
+ * NetScalerPodVO contains information about a EIP deployment where on 
datacenter L3 router a PBR (policy
--- End diff --

Remove this description and re-write it matching to the current file


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala

Github user rajesh-battala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93747256
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/api/commands/DeployNetscalerVpxCmd.java
 ---
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.cloud.api.commands;
+
+import java.util.List;
+import java.util.Map;
+
+import javax.inject.Inject;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.NetworkResponse;
+import org.apache.cloudstack.api.response.ServiceOfferingResponse;
+import org.apache.cloudstack.api.response.SystemVmResponse;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.api.response.NetscalerLoadBalancerResponse;
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.element.NetscalerLoadBalancerElementService;
+import com.cloud.user.Account;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.vm.VirtualMachine;
+
+@APICommand(name = "deployNetscalerVpx", responseObject = 
NetscalerLoadBalancerResponse.class, description = "Creates new NS Vpx",
+requestHasSensitiveInfo = true, responseHasSensitiveInfo = false)
+public class DeployNetscalerVpxCmd extends BaseAsyncCmd {
+
+public static final Logger s_logger = 
Logger.getLogger(DeployNetscalerVpxCmd.class.getName());
+private static final String s_name = "deployNetscalerVpx";
+@Inject
+NetscalerLoadBalancerElementService _netsclarLbService;
+
+/
+ API parameters /
+/
+
+@Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID, 
entityType = ZoneResponse.class, required = true, description = "availability 
zone for the virtual machine")
+private Long zoneId;
+
+@ACL
+@Parameter(name = ApiConstants.SERVICE_OFFERING_ID, type = 
CommandType.UUID, entityType = ServiceOfferingResponse.class, required = true, 
description = "the ID of the service offering for the virtual machine")
+private Long serviceOfferingId;
+
+@ACL
+@Parameter(name = ApiConstants.TEMPLATE_ID, type = CommandType.UUID, 
entityType = TemplateResponse.class, required = true, description = "the ID of 
the template for the virtual machine")
+private Long templateId;
+
+@Parameter(name = ApiConstants.NETWORK_ID,
+type = CommandType.UUID,
+entityType = NetworkResponse.class, required=false,
+description = "The network this ip address should be 
associated to.")
+private Long networkId;
+/
+/// Accessors ///
+/
+
+
+
+/
+/// API Implementation///
+/
+
+@Override
+public void execute() throws ResourceUnavailableException, 
InsufficientCapaci

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread nitin-maharana

Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93749580
  
--- Diff: ui/scripts/configuration.js ---
@@ -2640,12 +2640,30 @@
 }
 
 //show LB Isolation dropdown only 
when (1)LB Service is checked (2)Service Provider is Netscaler OR F5
-if 
((args.$form.find('.form-item[rel=\"service.Lb.isEnabled\"]').find('input[type=checkbox]').is(':checked')
 == true) && 
(args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val()
 == 'Netscaler' || 
args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val() 
== 'F5BigIp')) {
+/*if 
((args.$form.find('.form-item[rel=\"service.Lb.isEnabled\"]').find('input[type=checkbox]').is(':checked')
 == true) && 
(args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val()
 == 'Netscaler' || 
args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val() 
== 'F5BigIp')) {
--- End diff --

@rajesh-battala : I will make required changes. Thanks for quick reivew.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Edit page permission in cwiki.

2016-12-23 Thread Rajani K

you are in

~ Rajani

On December 23, 2016 at 3:33 PM, Nitin Kumar Maharana
(nitinkumar.mahar...@accelerite.com) wrote:

Hi,

I don’t have permission to edit a page in cwiki.
Even I don’t have permission to assign issues to myself in JIRA.

Can you please give me these accesses.
Username : nitin.maharana

Thanks,
Nitin

DISCLAIMER
==
This e-mail may contain privileged and confidential information
which is the property of Accelerite, a Persistent Systems
business. It is intended only for the use of the individual or
entity to which it is addressed. If you are not the intended
recipient, you are not authorized to read, retain, copy, print,
distribute or use this message. If you have received this
communication in error, please notify the sender and delete all
copies of this message. Accelerite, a Persistent Systems business
does not accept any liability for virus infected mails.

Re: Request for Jira access - ticket assignment permissions

2016-12-23 Thread Rajani Karuturi

you are in

~ Rajani

http://cloudplatform.accelerite.com/

On December 21, 2016 at 4:14 PM, Adwait Patankar
(adwait_patan...@accelerite.com) wrote:

Hi,

I'm trying to assign a bug in Jira to myself. However, it
doesn't look like I have the appropriate permissions.

Can someone please grant the assignment permissions to me? My
username is "adwaitpatankar".

Regards,

Adwait

Adwait Patankar

Principal Product Engineer | CloudPlatform |
www.accelerite.com

DISCLAIMER
==
This e-mail may contain privileged and confidential information
which is the property of Accelerite, a Persistent Systems
business. It is intended only for the use of the individual or
entity to which it is addressed. If you are not the intended
recipient, you are not authorized to read, retain, copy, print,
distribute or use this message. If you have received this
communication in error, please notify the sender and delete all
copies of this message. Accelerite, a Persistent Systems business
does not accept any liability for virus infected mails.

[GitHub] cloudstack pull request #1860: CLOUDSTACK-9703: Fixed Start VM does not hono...

2016-12-23 Thread anshul1886

GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/1860

CLOUDSTACK-9703: Fixed Start VM does not honor 
cluster.cpu.allocated.capacity.disablethreshold if the vm is startting on last 
host



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9703

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1860.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1860


commit 4d398b893991f6e94222489fe26cc32c37ca099f
Author: Anshul Gangwar 
Date:   2016-06-22T08:05:11Z

CLOUDSTACK-9703: Fixed Start VM does not honor 
cluster.cpu.allocated.capacity.disablethreshold if the vm is startting on last 
host




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1794: added more guest os

2016-12-23 Thread sateesh-chodapuneedi

Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1794
  
@karuturi Can you please resolve the conflicts and rebase this branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1854: 4.9 multiplex testing

2016-12-23 Thread borisstoyanov

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1854
  
Hi @mike-tutkowski @syed,  
I've been investigating the test failure from test_primary_storage.py: 
test_01_primary_storage_iscsi, and we came to a conclusion that iscsi attaches 
but it's not writeable. 

By any chance do you recall any change that might cause this? 


Here's the management log failing to create a hearbeat volume: 

```
2016-12-23 11:30:58,826 DEBUG [c.c.h.x.r.CitrixResourceBase] 
(DirectAgent-404:ctx-c95759e3) (logid:f96038aa) Setting up the heartbeat sr for 
host 10.2.2.33 and sr ca748d82-3668-9559-07ba-19ff94844ed0
2016-12-23 11:30:59,104 WARN  
[c.c.h.x.r.w.x.CitrixModifyStoragePoolCommandWrapper] 
(DirectAgent-404:ctx-c95759e3) (logid:f96038aa) ModifyStoragePoolCommand add 
XenAPIException:Unable to setup heartbeat
 sr on SR ca748d82-3668-9559-07ba-19ff94844ed0 due to #6# Unable to create 
heartbeat volume hb-db2a4468-ef57-4936-9ccd-7b8f4c06d822 
host:db2a4468-ef57-4936-9ccd-7b8f4c06d822 pool: 10.5.0.4/iqn.2016-10.l
ocal.marvin:tgt1/0
com.cloud.utils.exception.CloudRuntimeException: Unable to setup heartbeat 
sr on SR ca748d82-3668-9559-07ba-19ff94844ed0 due to #6# Unable to create 
heartbeat volume hb-db2a4468-ef57-4936-9ccd-7b8f4c06d
822
at 
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.setupHeartbeatSr(CitrixResourceBase.java:4596)
at 
com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixModifyStoragePoolCommandWrapper.execute(CitrixModifyStoragePoolCommandWrapper.java:54)
at 
com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixModifyStoragePoolCommandWrapper.execute(CitrixModifyStoragePoolCommandWrapper.java:40)
at 
com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
at 
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1687)
at 
com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
2016-12-23 11:30:59,111 DEBUG [c.c.a.m.DirectAgentAttache] 
(DirectAgent-404:ctx-c95759e3) (logid:f96038aa) Seq 1-4225502350380368681: 
Response Received:
2016-12-23 11:30:59,111 DEBUG [c.c.a.t.Request] 
(DirectAgent-404:ctx-c95759e3) (logid:f96038aa) Seq 1-4225502350380368681: 
Processing:  { Ans: , MgmtId: 7003044906821, via: 1(pr1854-t722-xenserver-65sp1
-xs1), Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.Answer":{"result":false,"details":"ModifyStoragePoolCommand
 add XenAPIException:Unable to setup heartbeat sr on SR 
ca748d82-3668-9559-07ba-19ff94844ed0
due to #6# Unable to create heartbeat volume 
hb-db2a4468-ef57-4936-9ccd-7b8f4c06d822 
host:db2a4468-ef57-4936-9ccd-7b8f4c06d822 pool: 
10.5.0.4/iqn.2016-10.local.marvin:tgt1/0","wait":0}}] }
2016-12-23 11:30:59,111 DEBUG [c.c.a.t.Request] 
(catalina-exec-18:ctx-ecf415b7 ctx-29dead47 ctx-1fd26575) (logid:f96038aa) Seq 
1-4225502350380368681: Received:  { Ans: , MgmtId: 7003044906821, via: 1(pr
1854-t722-xenserver-65sp1-xs1), Ver: v1, Flags: 10, { Answer } }
2016-12-23 11:30:59,111 DEBUG [c.c.a.m.AgentManagerImpl] 
(catalina-exec-18:ctx-ecf415b7 ctx-29dead47 ctx-1fd26575) (logid:f96038aa) 
Details from executing class com.cloud.agent.api.ModifyStoragePoolComm
and: ModifyStoragePoolCommand add XenAPIException:Unable to setup heartbeat 
sr on SR ca748d82-3668-9559-07ba-19ff94844ed0 due to #6# Unable to create 
heartbeat volume hb-db2a4468-ef57-4936-9ccd-7b8f4c06
d822 host:db2a4468-ef57-4936-9ccd-7b8f4c06d822 pool: 
10.5.0.4/iqn.2016-10.local.marvin:tgt1/0
20

[GitHub] cloudstack issue #1854: 4.9 multiplex testing

2016-12-23 Thread borisstoyanov

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1854
  
I've just re-run the test_templates failures and it has passed.
```
Test create public & private template ... === TestName: 
test_01_create_template | Status : SUCCESS ===
ok
Test when createTemplate is used to create templates having the same name 
all of them get ... === TestName: test_CreateTemplateWithDuplicateName | Status 
: SUCCESS ===
ok
Test Edit template ... === TestName: test_02_edit_template | Status : 
SUCCESS ===
ok
Test delete template ... === TestName: test_03_delete_template | Status : 
SUCCESS ===
ok
Test for extract template ... === TestName: test_04_extract_template | 
Status : SUCCESS ===
ok
Update & Test for template permissions ... === TestName: 
test_05_template_permissions | Status : SUCCESS ===
ok
Test for copy template from one zone to another ... SKIP: Not enough zones 
available to perform copy template
Test only public templates are visible to normal user ... === TestName: 
test_07_list_public_templates | Status : SUCCESS ===
ok
Test System templates are not visible to normal user ... === TestName: 
test_08_list_system_templates | Status : SUCCESS ===
ok

--
Ran 9 tests in 847.599s

OK (SKIP=1)
```

I guess XenServer test results are looking good, except from the iscsi 
issue listed up. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1854: 4.9 multiplex testing

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1854
  
I re-ran all tests, most of them are passing except for rvr/vpc related and 
the one iscsi/xenserver related:

Xenserver:
Test create public & private template ... === TestName: 
test_01_create_template | Status : SUCCESS ===
ok
Test when createTemplate is used to create templates having the same name 
all of them get ... === TestName: test_CreateTemplateWithDuplicateName | Status 
: SUCCESS ===
ok
Test Edit template ... === TestName: test_02_edit_template | Status : 
SUCCESS ===
ok
Test delete template ... === TestName: test_03_delete_template | Status : 
SUCCESS ===
ok
Test for extract template ... === TestName: test_04_extract_template | 
Status : SUCCESS ===
ok
Update & Test for template permissions ... === TestName: 
test_05_template_permissions | Status : SUCCESS ===
ok
Test for copy template from one zone to another ... SKIP: Not enough zones 
available to perform copy template
Test only public templates are visible to normal user ... === TestName: 
test_07_list_public_templates | Status : SUCCESS ===
ok
Test System templates are not visible to normal user ... === TestName: 
test_08_list_system_templates | Status : SUCCESS ===
ok
Test Snapshot Root Disk ... === TestName: test_01_snapshot_root_disk | 
Status : SUCCESS ===
ok
Test primary storage pools - XEN. Not Supported for kvm,hyperv,vmware ... 
=== TestName: test_01_primary_storage_iscsi | Status : EXCEPTION ===
ERROR
Test primary storage pools - XEN, KVM, VMWare. Not Supported for hyperv ... 
=== TestName: test_01_primary_storage_nfs | Status : SUCCESS ===
ok


Vmware:
Test List secondary storage VMs ... === TestName: 
test_01_list_sec_storage_vm | Status : SUCCESS ===
ok
Test List console proxy VMs ... === TestName: test_02_list_cpvm_vm | Status 
: SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test create public & private template ... === TestName: 
test_01_create_template | Status : SUCCESS ===
ok
Test when createTemplate is used to create templates having the same name 
all of them get ... === TestName: test_CreateTemplateWithDuplicateName | Status 
: SUCCESS ===
ok
Test Edit template ... === TestName: test_02_edit_template | Status : 
SUCCESS ===
ok
Test delete template ... === TestName: test_03_delete_template | Status : 
SUCCESS ===
ok
Test for extract template ... === TestName: test_04_extract_template | 
Status : SUCCESS ===
ok
Update & Test for template permissions ... === TestName: 
test_05_template_permissions | Status : SUCCESS ===
ok
Test for copy template from one zone to another ... SKIP: Not enough zones 
available to perform copy template
Test only public templates are visible to normal user ... === TestName: 
test_07_list_public_templates | Status : SUCCESS ===
ok
Test System templates are not visible to normal user ... === TestName: 
test_08_list_system_templates | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Test Volume creation for all Disk Offerings (incl. custom) ... === 
TestName: test_01_create_volume | Status : SUCCESS ===
ok
Attach a created Volume to a Running VM ... === TestName: 
test_02_attach_volume | Status : SUCCESS ===
ok
Download a Volume attached to a VM ... === TestName: 
test_03_download_attached_volume | Status : SUCCESS ===
ok
Delete a Volume attached to a VM ... === TestName: 
test_04_delete_attached_volume | Status : SUCCESS ===
ok
Detach a Volume attached to a VM ... === TestName: test_05_detach_volume | 
Status : SUCCESS ===
ok
Download a Volume unattached to an VM ... === TestName: 
test_06_download_detached_volume | Status : SUCCESS ===
ok
Test resize (negative) non-existent volume ... SKIP: Resize Volume is 
unsupported on VmWare and Hyper-V
Test resize a volume ... SKIP: Resize Volume is unsupported on VmWare and 
Hyper-V
Delete a Volume unattached to an VM ... === TestName: 
test_09_delete_detached_volume | Status : SUCCESS ===
ok
Test Site 2 Site V

[GitHub] cloudstack issue #1854: 4.9 multiplex testing

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1854
  
Based on test results, I'll proceed with merging this.

I don't see any regressions, let's work on the iscsi issue in a separate 
PR? /cc @syed @murali-reddy @abhinandanprateek @borisstoyanov @mike-tutkowski 
@PaulAngus 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1811: CLOUDSTACK-9649: In the management server log...

2016-12-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1811


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1783: CLOUDSTACK-9615: Fixd applying ingress rules ...

2016-12-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1783


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1782: CLOUDSTACK-9617: Fixed enabling remote access...

2016-12-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1782


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1828: CLOUDSTACK-9676 Start instance fails after re...

2016-12-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1828


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1804: CLOUDSTACK-9639: Unable to create shared netw...

2016-12-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1804


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1764: CLOUDSTACK-9597: Should not fetch resource co...

2016-12-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1764


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1854: 4.9 multiplex testing

2016-12-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1854


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1781: CLOUDSTACK-9612: Fixed issue in restarting re...

2016-12-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1781


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1827: CLOUDSTACK-9673 : Exception occured while cre...

2016-12-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1827


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1856
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1856
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1700: CLOUDSTACK-9359: IPv6 for Basic Networking

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1700
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1700: CLOUDSTACK-9359: IPv6 for Basic Networking

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1700
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] 4.9.2.0 with XenServer7 support, and 4.10.0.0 RM

2016-12-23 Thread Wido den Hollander


> Op 23 december 2016 om 9:51 schreef Rohit Yadav :
> 
> 
> All,
> 
> 
> 4.9.1.0 was voted recently but did not receive a lot of attention in terms of 
> testing/voting, and several users reports on the list and privately that they 
> would want to have XenServer7 support. I agree with Marty and other users 
> that it would be a great holiday present to release another minor 4.9.2.0 
> release that bundles few bugfixes and support for XenServer7.
> 
> 
> I'm planning to work towards 4.9.2.0 so as to at least cut 4.9.2.0-rc1 
> on/before 1st Jan, and currently working towards stabilizing 4.9.
> 

How big is the XS7 support patch? Technically, isn't that a feature?

I know very little about XS7 and I wouldn't be against. But when you talk about 
a Holiday present means you want to release it at least tomorrow? But you also 
say Jan 1st?

> 
> Given the current holiday period and to avoid competing voting threads -- if 
> there are no objections, I'm pushing the freeze date for 4.10/master to 30th 
> January? I would also like to invite anyone who wants to take over as RM for 
> the 4.10.0.0 release, thanks.
> 

No objections against that.

> 
> Master will be open to accept bugfixes and PRs that can be reviewed/merged. 
> There are several good PRs we can review/merge such as Wido's PR on ipv6 
> support for basic zone/network, and Jayapal's/Will's Strongswan VPN. I would 
> be willing to accept PRs that don't break any smoke tests on xen/vmware/kvm 
> (as covered by Travis, Trillian, BVT and others) and growing list of 
> component tests that have been added in Travis and some of which we've 
> started running in Trillian.
> 

I would really like #1700 and my additional Ipv6 stuff to be merged in to 4.10 
:)

Wido

> 
> Happy holidays.
> 
> 
> Regards.
> 
> rohit.ya...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>   
>  
>

[DISCUSS][BUG] iscsi being attached but it's not writable

2016-12-23 Thread Boris Stoyanov

Hi all,

I’m moving this conversation here, to be picked up by a separate PR since we’ve 
merged the original 1854.

Pasting original content from github:


@mike-tutkowski 
@syed,
I've been investigating the test failure from test_primary_storage.py: 
test_01_primary_storage_iscsi, and we came to a conclusion that iscsi attaches 
but it's not writeable.

By any chance do you recall any change that might cause this?

Here's the management log failing to create a hearbeat volume:

2016-12-23 11:30:58,826 DEBUG [c.c.h.x.r.CitrixResourceBase] 
(DirectAgent-404:ctx-c95759e3) (logid:f96038aa) Setting up the heartbeat sr for 
host 10.2.2.33 and sr ca748d82-3668-9559-07ba-19ff94844ed0
2016-12-23 11:30:59,104 WARN  
[c.c.h.x.r.w.x.CitrixModifyStoragePoolCommandWrapper] 
(DirectAgent-404:ctx-c95759e3) (logid:f96038aa) ModifyStoragePoolCommand add 
XenAPIException:Unable to setup heartbeat
 sr on SR ca748d82-3668-9559-07ba-19ff94844ed0 due to #6# Unable to create 
heartbeat volume hb-db2a4468-ef57-4936-9ccd-7b8f4c06d822 
host:db2a4468-ef57-4936-9ccd-7b8f4c06d822 pool: 10.5.0.4/iqn.2016-10.l
ocal.marvin:tgt1/0
com.cloud.utils.exception.CloudRuntimeException: Unable to setup heartbeat sr 
on SR ca748d82-3668-9559-07ba-19ff94844ed0 due to #6# Unable to create 
heartbeat volume hb-db2a4468-ef57-4936-9ccd-7b8f4c06d
822
at 
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.setupHeartbeatSr(CitrixResourceBase.java:4596)
at 
com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixModifyStoragePoolCommandWrapper.execute(CitrixModifyStoragePoolCommandWrapper.java:54)
at 
com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixModifyStoragePoolCommandWrapper.execute(CitrixModifyStoragePoolCommandWrapper.java:40)
at 
com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
at 
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1687)
at 
com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
2016-12-23 11:30:59,111 DEBUG [c.c.a.m.DirectAgentAttache] 
(DirectAgent-404:ctx-c95759e3) (logid:f96038aa) Seq 1-4225502350380368681: 
Response Received:
2016-12-23 11:30:59,111 DEBUG [c.c.a.t.Request] (DirectAgent-404:ctx-c95759e3) 
(logid:f96038aa) Seq 1-4225502350380368681: Processing:  { Ans: , MgmtId: 
7003044906821, via: 1(pr1854-t722-xenserver-65sp1
-xs1), Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.Answer":{"result":false,"details":"ModifyStoragePoolCommand
 add XenAPIException:Unable to setup heartbeat sr on SR 
ca748d82-3668-9559-07ba-19ff94844ed0
due to #6# Unable to create heartbeat volume 
hb-db2a4468-ef57-4936-9ccd-7b8f4c06d822 
host:db2a4468-ef57-4936-9ccd-7b8f4c06d822 pool: 
10.5.0.4/iqn.2016-10.local.marvin:tgt1/0","wait":0}}] }
2016-12-23 11:30:59,111 DEBUG [c.c.a.t.Request] (catalina-exec-18:ctx-ecf415b7 
ctx-29dead47 ctx-1fd26575) (logid:f96038aa) Seq 1-4225502350380368681: 
Received:  { Ans: , MgmtId: 7003044906821, via: 1(pr
1854-t722-xenserver-65sp1-xs1), Ver: v1, Flags: 10, { Answer } }
2016-12-23 11:30:59,111 DEBUG [c.c.a.m.AgentManagerImpl] 
(catalina-exec-18:ctx-ecf415b7 ctx-29dead47 ctx-1fd26575) (logid:f96038aa) 
Details from executing class com.cloud.agent.api.ModifyStoragePoolComm
and: ModifyStoragePoolCommand add XenAPIException:Unable to setup heartbeat sr 
on SR ca748d82-3668-9559-07ba-19ff94844ed0 due to #6# Unable to create 
heartbeat volume hb-db2a4468-ef57-4936-9ccd-7b8f4c06
d822 host:db2a4468-ef57-4936-9ccd-7b8f4c06d822 pool: 
10.5.0.4/iqn.2016-10.local.marvin:tgt1/0
2016-12-23 11:30:59,112 WARN  [o.a.c.alerts] (catalina-exec-18:ctx-ecf415b

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
Packaging result: âcentos6 âcentos7 âdebian. JID-418


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
Packaging result: âcentos6 âcentos7 âdebian. JID-419


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
@blueorangutan test matrix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt 
+ vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1856
  
Packaging result: âcentos6 âcentos7 âdebian. JID-420


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] 4.9.2.0 with XenServer7 support, and 4.10.0.0 RM

2016-12-23 Thread Rohit Yadav

Hi Wido,


The XS7 patch [1] is not big, if you've a look no major changes were made into 
CloudStack other than some version related checked removed for XS 6.4+. 
Regression tests confirm that XS6 works as expected, along with vmware and kvm. 
Technically it's a feature, but with LTS releases we may end up backporting 
changes to support LTS users.


I'm aiming to cut RC-1 on/before 1st Jan which is more realistic than tomorrow. 
It would be great to have ipv6, strongswan and other PRs if they are 
tested/merged before 4.10/master freeze date.


[1] https://github.com/apache/cloudstack/pull/1711/files


Regards.


From: Wido den Hollander 
Sent: 23 December 2016 18:19:38
To: Rohit Yadav; dev@cloudstack.apache.org
Subject: Re: [DISCUSS] 4.9.2.0 with XenServer7 support, and 4.10.0.0 RM


> Op 23 december 2016 om 9:51 schreef Rohit Yadav :
>
>
> All,
>
>
> 4.9.1.0 was voted recently but did not receive a lot of attention in terms of 
> testing/voting, and several users reports on the list and privately that they 
> would want to have XenServer7 support. I agree with Marty and other users 
> that it would be a great holiday present to release another minor 4.9.2.0 
> release that bundles few bugfixes and support for XenServer7.
>
>
> I'm planning to work towards 4.9.2.0 so as to at least cut 4.9.2.0-rc1 
> on/before 1st Jan, and currently working towards stabilizing 4.9.
>

How big is the XS7 support patch? Technically, isn't that a feature?

I know very little about XS7 and I wouldn't be against. But when you talk about 
a Holiday present means you want to release it at least tomorrow? But you also 
say Jan 1st?

>
> Given the current holiday period and to avoid competing voting threads -- if 
> there are no objections, I'm pushing the freeze date for 4.10/master to 30th 
> January? I would also like to invite anyone who wants to take over as RM for 
> the 4.10.0.0 release, thanks.
>

No objections against that.

>
> Master will be open to accept bugfixes and PRs that can be reviewed/merged. 
> There are several good PRs we can review/merge such as Wido's PR on ipv6 
> support for basic zone/network, and Jayapal's/Will's Strongswan VPN. I would 
> be willing to accept PRs that don't break any smoke tests on xen/vmware/kvm 
> (as covered by Travis, Trillian, BVT and others) and growing list of 
> component tests that have been added in Travis and some of which we've 
> started running in Trillian.
>

I would really like #1700 and my additional Ipv6 stuff to be merged in to 4.10 
:)

Wido

>
> Happy holidays.
>
>
> Regards.
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack pull request #1861: CLOUDSTACK-9698 Make hardcorded wait timeout ...

2016-12-23 Thread sateesh-chodapuneedi

GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1861

CLOUDSTACK-9698 Make hardcorded wait timeout for NIC adapter hotplug as 
configurable

Jira
===
CLOUDSTACK-9698 Make hardcoded wait timeout for NIC adapter hotplug as 
configurable

Description
=
Currently ACS waits for 15 seconds (hard coded) for hot-plugged NIC in VR 
to get detected by guest OS.
The time taken to detect hot plugged NIC in guest OS depends on type of NIC 
adapter like (E1000, VMXNET3, E1000e etc.)
and guest OS itself. In uncommon scenarios the NIC detection may take 
longer time than 15 seconds,
in such cases NIC hotplug would be treated as failure which results in VPC 
tier configuration failure.
Alternatively making the wait timeout for NIC adapter hotplug as 
configurable will be helpful for admins in such scenarios.

Also in future if VMware introduces new NIC adapter types which may take 
time to get detected by guest OS, it is good to have flexibility of
configuring the wait timeout as fallback mechanism in such scenarios.

Fix
===
Introduce new configuration parameter (via ConfigKey) 
"vmware.nic.hotplug.wait.timeout" which is "Wait timeout (milli seconds) for 
hot plugged NIC of VM to be detected by guest OS." as fallback instead of hard 
coded timeout, to ensure flexibility for admins given the listed scenarios 
above.

Signed-off-by: Sateesh Chodapuneedi 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
pr-cloudstack-9698

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1861


commit 2ea7aadbac386f4d3a0e0062e1042e4266c24e91
Author: Sateesh Chodapuneedi 
Date:   2016-12-23T00:51:04Z

CLOUDSTACK-9698 Make the wait timeout for NIC adapter hotplug as 
configurable

Currently ACS waits for 15 seconds (hard coded) for hot-plugged NIC in VR 
to get detected by guest OS.
The time taken to detect hot plugged NIC in guest OS depends on type of NIC 
adapter like (E1000, VMXNET3, E1000e etc.)
and guest OS itself. In uncommon scenarios the NIC detection may take 
longer time than 15 seconds,
in such cases NIC hotplug would be treated as failure which results in VPC 
tier configuration failure.
Alternatively making the wait timeout for NIC adapter hotplug as 
configurable will be helpful for admins in such scenarios.

Also in future if VMware introduces new NIC adapter types which may take 
time to get detected by guest OS, it is good to have flexibility of
configuring the wait timeout as fallback mechanism in such scenarios.

Signed-off-by: Sateesh Chodapuneedi 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1700: CLOUDSTACK-9359: IPv6 for Basic Networking

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1700
  
Packaging result: âcentos6 âcentos7 âdebian. JID-421


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re:Re: [DISCUSS] 4.9.2.0 with XenServer7 support, and 4.10.0.0 RM

2016-12-23 Thread Haijiao

Hi Rohit 


Thanks for your hardworking like Santa Claus  ! 


Is that possible to include the PRs below in 4.9.2 LTS as well  ?


#977  VM Snapshotting implementation for KVM (lots of people awaiting for 
this)
#1794added more guest os (a simple to one to support latest OS)
#1849Scale CentOS7 VM fails with error 


Regards,


在2016年12月23 21时36分, "Rohit Yadav"写道:

Hi Wido,


The XS7 patch [1] is not big, if you've a look no major changes were made into 
CloudStack other than some version related checked removed for XS 6.4+. 
Regression tests confirm that XS6 works as expected, along with vmware and kvm. 
Technically it's a feature, but with LTS releases we may end up backporting 
changes to support LTS users.


I'm aiming to cut RC-1 on/before 1st Jan which is more realistic than tomorrow. 
It would be great to have ipv6, strongswan and other PRs if they are 
tested/merged before 4.10/master freeze date.


[1] https://github.com/apache/cloudstack/pull/1711/files


Regards.


From: Wido den Hollander 
Sent: 23 December 2016 18:19:38
To: Rohit Yadav; dev@cloudstack.apache.org
Subject: Re: [DISCUSS] 4.9.2.0 with XenServer7 support, and 4.10.0.0 RM


> Op 23 december 2016 om 9:51 schreef Rohit Yadav :
>
>
> All,
>
>
> 4.9.1.0 was voted recently but did not receive a lot of attention in terms of 
> testing/voting, and several users reports on the list and privately that they 
> would want to have XenServer7 support. I agree with Marty and other users 
> that it would be a great holiday present to release another minor 4.9.2.0 
> release that bundles few bugfixes and support for XenServer7.
>
>
> I'm planning to work towards 4.9.2.0 so as to at least cut 4.9.2.0-rc1 
> on/before 1st Jan, and currently working towards stabilizing 4.9.
>

How big is the XS7 support patch? Technically, isn't that a feature?

I know very little about XS7 and I wouldn't be against. But when you talk about 
a Holiday present means you want to release it at least tomorrow? But you also 
say Jan 1st?

>
> Given the current holiday period and to avoid competing voting threads -- if 
> there are no objections, I'm pushing the freeze date for 4.10/master to 30th 
> January? I would also like to invite anyone who wants to take over as RM for 
> the 4.10.0.0 release, thanks.
>

No objections against that.

>
> Master will be open to accept bugfixes and PRs that can be reviewed/merged. 
> There are several good PRs we can review/merge such as Wido's PR on ipv6 
> support for basic zone/network, and Jayapal's/Will's Strongswan VPN. I would 
> be willing to accept PRs that don't break any smoke tests on xen/vmware/kvm 
> (as covered by Travis, Trillian, BVT and others) and growing list of 
> component tests that have been added in Travis and some of which we've 
> started running in Trillian.
>

I would really like #1700 and my additional Ipv6 stuff to be merged in to 4.10 
:)

Wido

>
> Happy holidays.
>
>
> Regards.
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack pull request #1862: CLOUDSTACK-9704 Remove dependency on VmwareCo...

2016-12-23 Thread sateesh-chodapuneedi

GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1862

CLOUDSTACK-9704 Remove dependency on VmwareContext object to fetch systemVM 
keyfile

Jira
===
CLOUDSTACK-9704 Remove dependency on VmwareContext object to fetch system 
VM key file

Description

While remote executing commands/scripts through SSH in VR, ACS uses system 
vm keyfile.
ACS is fetching this key file using VMwareContext object which encapsulates 
vCenter connection handle.
This is inefficient because of dependency on getServiceContext() which 
means a vCenter connection
handle which is not required just to fetch a file in name space in 
management server.

Fix
===
Implement a method to fetch system vm key file by using Script class 
instead of VmwareManagerImpl. Ensure this implementation is not present in 
VmwareManagerImpl itself because fetching the manager object from VmwareContext 
object unnecessarily adds dependency on session object just to search for 
keyfile in class path.

Signed-off-by: Sateesh Chodapuneedi 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
pr-cloudstack-9704

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1862.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1862


commit 02bd90c424966c81c57bed9b8fc9f530e0b97b7d
Author: Sateesh Chodapuneedi 
Date:   2016-12-23T02:17:43Z

CLOUDSTACK-9704 Remove dependency on VmwareContext object to fetch system 
VM key file

While remote executing commands/scripts through SSH in VR, ACS uses system 
vm keyfile.
ACS is fetching this key file using VMwareContext object which encapsulates 
vCenter connection handle.
This is inefficient because of dependency on getServiceContext() which 
means a vCenter connection
handle which is not required just to fetch a file in name space in 
management server.

Signed-off-by: Sateesh Chodapuneedi 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

2016-12-23 Thread pdion891

Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-docs-admin/pull/40
  
@lmrv I think you are now at 50% completed, right ?  could it be possible 
to update this PR so we cloud merge this first step ?

Continue the Good work !!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
Trillian test result (tid-723)
Environment: kvm-centos6 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31971 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1638-t723-kvm-centos6.zip
Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Test completed. 47 look ok, 3 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 360.91 | 
test_privategw_acl.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | 
test_list_ids_parameter.py
test_01_vpc_site2site_vpn | Success | 170.70 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 71.21 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 276.26 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 388.95 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 657.38 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 552.74 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1361.25 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 574.80 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 779.03 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1372.84 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.62 | test_volumes.py
test_08_resize_volume | Success | 15.40 | test_volumes.py
test_07_resize_fail | Success | 20.49 | test_volumes.py
test_06_download_detached_volume | Success | 15.28 | test_volumes.py
test_05_detach_volume | Success | 100.22 | test_volumes.py
test_04_delete_attached_volume | Success | 10.22 | test_volumes.py
test_03_download_attached_volume | Success | 15.32 | test_volumes.py
test_02_attach_volume | Success | 77.89 | test_volumes.py
test_01_create_volume | Success | 861.85 | test_volumes.py
test_deploy_vm_multiple | Success | 333.14 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.86 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.15 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 86.20 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 130.91 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 131.15 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
test_01_stop_vm | Success | 50.41 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 105.83 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.18 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.15 | test_templates.py
test_01_create_template | Success | 65.64 | test_templates.py
test_10_destroy_cpvm | Success | 161.85 | test_ssvm.py
test_09_destroy_ssvm | Success | 194.00 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.75 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.89 | test_ssvm.py
test_06_stop_cpvm | Success | 132.02 | test_ssvm.py
test_05_stop_ssvm | Success | 134.03 | test_ssvm.py
test_04_cpvm_internals | Success | 1.48 | test_ssvm.py
test_03_ssvm_internals | Success | 3.74 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_04_change_offering_small | Success | 247.68 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.13 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 40.34 | test_routers.py
test_08_start_router | Success | 35.33 | test_routers.py
test_07_stop_router | Success | 10.16 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_0

[DISCUSS] VR metric collection

2016-12-23 Thread Pierre-Luc Dion

I'm looking for a way to collect metrics from VR's in a way that I would
call "aggressive" to collect CPU usage, disk, memory, network and VPN logs
in a way that I can almost have realtime data of them (every 15seconds).

My use case is to help troubleshoot network performance like haproxy and
VPNs, healthcheck and network usage, detect potantial issues. I've made a
POC intenally and I'd like to see how to go forward with this with the
community.

So what I did  is deployed tcollector and forward rsyslog on the VR and
point them on the IP:169.254.0.1.
I created iptables PortForward on hypervisors so data was send to OpenTSDB
and log into Logstash
so to me it's kind of simple and safe.

here is a quick list of change required on the VR and infra:
- add an agent on the VR
- forward log of rsyslogd
- haproxy stats to a socket instead of public ip
- Configure port forwarding on hypervisor
- some new zone settings ideally

Would I need to create a new systemvm-template for that ? or our
systemvm.iso support installation of package ?

So, what about adding telegraf [1] into our VR? Does is MIT license is
compatible with our's?
any one else interested by such as feature?

[1] https://github.com/influxdata/telegraf


Pierre-Luc

[GitHub] cloudstack-docs-admin pull request #41: 50% of the doc strings are translate...

2016-12-23 Thread lmrv

GitHub user lmrv opened a pull request:

https://github.com/apache/cloudstack-docs-admin/pull/41

50% of the doc strings are translated into French language

50% des chaines sont traduites en FR

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lmrv/cloudstack-docs-admin master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-admin/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit 90ae7fbf97b86217bc4905ad51a4b8437f12b84d
Author: Antoine Le Morvan 
Date:   2016-08-19T22:03:28Z

50% des chaines sont traduites en FR




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

2016-12-23 Thread lmrv

Github user lmrv commented on the issue:

https://github.com/apache/cloudstack-docs-admin/pull/40
  
See #41 for the rebase pull request.
I have now reach 50% of translated strings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request #40: index.po and ui.po translated in FR

2016-12-23 Thread lmrv

Github user lmrv closed the pull request at:

https://github.com/apache/cloudstack-docs-admin/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
Trillian test result (tid-725)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42332 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1837-t725-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 45 look ok, 3 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 848.57 | 
test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 340.19 | 
test_privategw_acl.py
test_01_create_volume | `Error` | 249.46 | test_volumes.py
test_01_vpc_site2site_vpn | Success | 154.94 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 61.10 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 240.44 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 480.02 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 810.31 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 500.22 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1394.04 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 542.82 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1284.09 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.50 | test_volumes.py
test_08_resize_volume | Success | 156.27 | test_volumes.py
test_07_resize_fail | Success | 156.34 | test_volumes.py
test_06_download_detached_volume | Success | 156.22 | test_volumes.py
test_05_detach_volume | Success | 241.17 | test_volumes.py
test_04_delete_attached_volume | Success | 146.08 | test_volumes.py
test_03_download_attached_volume | Success | 156.21 | test_volumes.py
test_02_attach_volume | Success | 179.55 | test_volumes.py
test_deploy_vm_multiple | Success | 358.29 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 27.54 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.84 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.75 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.78 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.15 | test_vm_life_cycle.py
test_01_stop_vm | Success | 125.78 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 80.64 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.21 | test_templates.py
test_03_delete_template | Success | 5.10 | test_templates.py
test_02_edit_template | Success | 90.09 | test_templates.py
test_01_create_template | Success | 40.51 | test_templates.py
test_10_destroy_cpvm | Success | 191.39 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.57 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.32 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.15 | test_ssvm.py
test_06_stop_cpvm | Success | 131.48 | test_ssvm.py
test_05_stop_ssvm | Success | 133.22 | test_ssvm.py
test_04_cpvm_internals | Success | 0.94 | test_ssvm.py
test_03_ssvm_internals | Success | 2.93 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.11 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.19 | test_snapshots.py
test_04_change_offering_small | Success | 239.52 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.11 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.16 | test_secondary_storage.py
test_09_reboot_router | Success | 40.31 | test_routers.py
test_08_start_router | Success | 30.26 | test_routers.py
test_07_stop_router | Success | 10.14 | test_routers.py
test_06_router_advanced | Success | 0.05 | test_routers.py
test_05_router_basic

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
Trillian test result (tid-726)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42722 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1837-t726-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 984.60 | 
test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 923.26 | 
test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 963.77 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 361.56 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 166.98 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 592.85 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 380.26 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 777.95 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 698.89 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1559.32 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 730.68 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 750.09 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1381.83 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 25.96 | test_volumes.py
test_06_download_detached_volume | Success | 55.69 | test_volumes.py
test_05_detach_volume | Success | 100.23 | test_volumes.py
test_04_delete_attached_volume | Success | 10.21 | test_volumes.py
test_03_download_attached_volume | Success | 25.42 | test_volumes.py
test_02_attach_volume | Success | 58.81 | test_volumes.py
test_01_create_volume | Success | 513.55 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.23 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 232.18 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 191.59 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.66 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 287.99 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.81 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 81.33 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.15 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.21 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.23 | test_vm_life_cycle.py
test_01_stop_vm | Success | 5.12 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 241.68 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 15.27 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.16 | test_templates.py
test_01_create_template | Success | 125.93 | test_templates.py
test_10_destroy_cpvm | Success | 272.08 | test_ssvm.py
test_09_destroy_ssvm | Success | 238.80 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.52 | test_ssvm.py
test_07_reboot_ssvm | Success | 158.44 | test_ssvm.py
test_06_stop_cpvm | Success | 176.80 | test_ssvm.py
test_05_stop_ssvm | Success | 209.04 | test_ssvm.py
test_04_cpvm_internals | Success | 1.20 | test_ssvm.py
test_03_ssvm_internals | Success | 3.54 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 66.55 | test_snapshots.py
test_04_change_offering_small | Success | 97.31 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storag

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
Trillian test result (tid-724)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
Total time taken: 43405 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1837-t724-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 45 look ok, 3 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 582.22 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1361.43 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 554.21 
| test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 776.66 | 
test_privategw_acl.py
test_01_primary_storage_iscsi | `Error` | 3.47 | test_primary_storage.py
test_01_vpc_site2site_vpn | Success | 332.14 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 136.92 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 533.27 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 330.37 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 689.49 | test_vpc_router_nics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 805.68 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 1055.84 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.99 | test_volumes.py
test_08_resize_volume | Success | 116.21 | test_volumes.py
test_07_resize_fail | Success | 116.52 | test_volumes.py
test_06_download_detached_volume | Success | 20.41 | test_volumes.py
test_05_detach_volume | Success | 100.25 | test_volumes.py
test_04_delete_attached_volume | Success | 10.28 | test_volumes.py
test_03_download_attached_volume | Success | 15.38 | test_volumes.py
test_02_attach_volume | Success | 10.82 | test_volumes.py
test_01_create_volume | Success | 393.15 | test_volumes.py
test_03_delete_vm_snapshots | Success | 280.26 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 191.46 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 100.73 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 237.91 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.84 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 185.27 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 66.28 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.15 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.19 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 10.23 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.29 | test_vm_life_cycle.py
test_01_stop_vm | Success | 25.28 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 111.12 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.07 | test_templates.py
test_04_extract_template | Success | 5.16 | test_templates.py
test_03_delete_template | Success | 5.13 | test_templates.py
test_02_edit_template | Success | 90.17 | test_templates.py
test_01_create_template | Success | 60.64 | test_templates.py
test_10_destroy_cpvm | Success | 196.68 | test_ssvm.py
test_09_destroy_ssvm | Success | 198.92 | test_ssvm.py
test_08_reboot_cpvm | Success | 151.69 | test_ssvm.py
test_07_reboot_ssvm | Success | 143.88 | test_ssvm.py
test_06_stop_cpvm | Success | 171.86 | test_ssvm.py
test_05_stop_ssvm | Success | 169.00 | test_ssvm.py
test_04_cpvm_internals | Success | 1.17 | test_ssvm.py
test_03_ssvm_internals | Success | 3.56 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 21.71 | test_snapshots.py
test_04_change_offering_small | Success | 126.60 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.05 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.10 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start |

[GitHub] cloudstack issue #1794: added more guest os

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1794
  
@karuturi can you fix the conflicts and address outstanding issues; I can 
consider and help review/merge this for 4.9.2.0 target if you can fix them in 
next 2-3 days. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #977: [4.9] CLOUDSTACK-8746: VM Snapshotting impleme...

2016-12-23 Thread rhtyd

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/977#discussion_r93811944
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
 ---
@@ -0,0 +1,219 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.snapshot;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseAsyncCreateCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SnapshotResponse;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.api.response.VolumeResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.PermissionDeniedException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.projects.Project;
+import com.cloud.storage.Snapshot;
+import com.cloud.user.Account;
+import com.cloud.uservm.UserVm;
+import com.cloud.vm.snapshot.VMSnapshot;
+
+@APICommand(name = "createSnapshotFromVMSnapshot", description = "Creates 
an instant snapshot of a volume from existing vm snapshot.", responseObject = 
SnapshotResponse.class, entityType = {Snapshot.class}, since = "4.6.0",
--- End diff --

Add since field?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #977: [4.9] CLOUDSTACK-8746: VM Snapshotting impleme...

2016-12-23 Thread rhtyd

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/977#discussion_r93811952
  
--- Diff: setup/db/db/schema-4910to41000-cleanup.sql ---
@@ -18,3 +18,9 @@
 --;
 -- Schema upgrade cleanup from 4.9.1.0 to 4.10.0.0;
 --;
+
--- End diff --

Move the changes to 4920to41000.sql


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #977: [4.9] CLOUDSTACK-8746: VM Snapshotting impleme...

2016-12-23 Thread rhtyd

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/977#discussion_r93811956
  
--- Diff: setup/db/db/schema-4910to41000.sql ---
@@ -53,3 +53,7 @@ ALTER TABLE `cloud`.`image_store_details` CHANGE COLUMN 
`value` `value` VARCHAR(
 NULL DEFAULT '1' COMMENT 'True if the detail can be displayed to the end 
user' AFTER `value`;
 
 ALTER TABLE `snapshots` ADD COLUMN `location_type` VARCHAR(32) COMMENT 
'Location of snapshot (ex. Primary)';
+
--- End diff --

Move the changes to 4920to41000.sql



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #977: [4.9] CLOUDSTACK-8746: VM Snapshotting implementation...

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/977
  
@ustcweizhou can you fix the conflicts and address outstanding issues?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Re:Re: [DISCUSS] 4.9.2.0 with XenServer7 support, and 4.10.0.0 RM

2016-12-23 Thread Rohit Yadav

Hi Haijiao,


Thanks, I've left my comments on the PRs you've shared. All of them are 
targeted to master, and the PR authors may be busy and/or may choose to not 
send it for 4.9 branch. If they don't make into 4.9 branch, but end up in 
master -- they all will be in 4.10.x.


Regards.


From: Haijiao <18602198...@163.com>
Sent: 23 December 2016 20:20:19
To: dev
Subject: Re:Re: [DISCUSS] 4.9.2.0 with XenServer7 support, and 4.10.0.0 RM

Hi Rohit


Thanks for your hardworking like Santa Claus  !


Is that possible to include the PRs below in 4.9.2 LTS as well  ?


#977  VM Snapshotting implementation for KVM (lots of people awaiting for 
this)
#1794added more guest os (a simple to one to support latest OS)
#1849Scale CentOS7 VM fails with error


Regards,


在2016年12月23 21时36分, "Rohit Yadav"写道:

Hi Wido,


The XS7 patch [1] is not big, if you've a look no major changes were made into 
CloudStack other than some version related checked removed for XS 6.4+. 
Regression tests confirm that XS6 works as expected, along with vmware and kvm. 
Technically it's a feature, but with LTS releases we may end up backporting 
changes to support LTS users.


I'm aiming to cut RC-1 on/before 1st Jan which is more realistic than tomorrow. 
It would be great to have ipv6, strongswan and other PRs if they are 
tested/merged before 4.10/master freeze date.


[1] https://github.com/apache/cloudstack/pull/1711/files


Regards.


From: Wido den Hollander 
Sent: 23 December 2016 18:19:38
To: Rohit Yadav; dev@cloudstack.apache.org
Subject: Re: [DISCUSS] 4.9.2.0 with XenServer7 support, and 4.10.0.0 RM


> Op 23 december 2016 om 9:51 schreef Rohit Yadav :
>
>
> All,
>
>
> 4.9.1.0 was voted recently but did not receive a lot of attention in terms of 
> testing/voting, and several users reports on the list and privately that they 
> would want to have XenServer7 support. I agree with Marty and other users 
> that it would be a great holiday present to release another minor 4.9.2.0 
> release that bundles few bugfixes and support for XenServer7.
>
>
> I'm planning to work towards 4.9.2.0 so as to at least cut 4.9.2.0-rc1 
> on/before 1st Jan, and currently working towards stabilizing 4.9.
>

How big is the XS7 support patch? Technically, isn't that a feature?

I know very little about XS7 and I wouldn't be against. But when you talk about 
a Holiday present means you want to release it at least tomorrow? But you also 
say Jan 1st?

>
> Given the current holiday period and to avoid competing voting threads -- if 
> there are no objections, I'm pushing the freeze date for 4.10/master to 30th 
> January? I would also like to invite anyone who wants to take over as RM for 
> the 4.10.0.0 release, thanks.
>

No objections against that.

>
> Master will be open to accept bugfixes and PRs that can be reviewed/merged. 
> There are several good PRs we can review/merge such as Wido's PR on ipv6 
> support for basic zone/network, and Jayapal's/Will's Strongswan VPN. I would 
> be willing to accept PRs that don't break any smoke tests on xen/vmware/kvm 
> (as covered by Travis, Trillian, BVT and others) and growing list of 
> component tests that have been added in Travis and some of which we've 
> started running in Trillian.
>

I would really like #1700 and my additional Ipv6 stuff to be merged in to 4.10 
:)

Wido

>
> Happy holidays.
>
>
> Regards.
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>

rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue




rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack pull request #1863: Smoke tests xen:iscsi fix

2016-12-23 Thread rhtyd

GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1863

Smoke tests xen:iscsi fix

@blueorangutan package

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack xs7-iscsifixtest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1863.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1863


commit 2da2019682a37ebbecf2fb58e4d622367e3eb078
Author: Rohit Yadav 
Date:   2016-12-24T03:20:03Z

Iscsi fix test

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1863: Smoke tests xen:iscsi fix

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1863
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
:happy: smoke tests looking a lot greener for the first time!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
Smoke tests looking a lot green for the first time :smile: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1700: CLOUDSTACK-9359: IPv6 for Basic Networking

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1700
  
@blueorangutan test centos7 kvm-centos6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
Merging this based on test results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1700: CLOUDSTACK-9359: IPv6 for Basic Networking

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1700
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos6) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1863: Smoke tests xen:iscsi fix

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1863
  
Packaging result: âcentos6 âcentos7 âdebian. JID-422


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1863: Smoke tests xen:iscsi fix

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1863
  
@blueorangutan test centos7 xenserver-65sp1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1863: Smoke tests xen:iscsi fix

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1863
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-12-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1638


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1864: maven: Move to jdk8

2016-12-23 Thread rhtyd

GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1864

maven: Move to jdk8

Experimental PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack j8-experimental

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1864.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1864


commit 2d5dce94530898ecb9e3e95982be85306758a707
Author: Rohit Yadav 
Date:   2016-12-24T04:11:13Z

maven: Move to jdk8

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
Packaging result: âcentos6 âcentos7 âdebian. JID-423


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
Packaging result: âcentos6 âcentos7 âdebian. JID-424


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2016-12-23 Thread rhtyd

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
@blueorangutan test matrix 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2016-12-23 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt 
+ vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

97 matches

Mail list logo