[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1762
  
@abhinandanprateek can you help reviewing this one, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1769
  
LGTM. @pdion891 would you like to review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1757
  
LGTM, merging this based on code review and test results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1745: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1745
  
LGTM, merging this based on last test run and code reviews.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed bot...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1757


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1711: XenServer 7 Support

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1711
  
Good progress :smiley: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1554: CLOUDSTACK-9602: API: improve resource limits compre...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1554
  
@marcaurele if I squash while merging, the git sha of the commit will 
change and the PR won't be marked as 'merged'. Which is why we use the `git-pr` 
tool that uses a merge strategy to merge the PR preserving the PR commit 
(sha/ids). Can you please run a git commit --amend when you do change to your 
PR, thanks. Squash them for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1745: CLOUDSTACK-9503: Increased the VR script time...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1745


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1765
  
LGTM, last test run looks okay. Failed tests around vpc/rvr are known 
intermittent issues.
@abhinandanprateek can you squash your commits, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: error adding VPN user in VPC network

2016-11-23 Thread Wei ZHOU
Will, this issue did happen for me in the remote access vpn of vpc with
redundant VRs.

Andrei, if you confirm it works, I will create a PR.

2016-11-22 20:58 GMT+01:00 Andrei Mikhailovsky :

> Dag from the users mailing list has pointed to this:
> https://issues.apache.org/jira/browse/CLOUDSTACK-9356
>
>
> - Original Message -
> > From: "Will Stevens" 
> > To: "dev" 
> > Sent: Tuesday, 22 November, 2016 17:37:56
> > Subject: Re: error adding VPN user in VPC network
>
> > Hmm. That is strange. I have not seen that behavior before.
> >
> > On Nov 22, 2016 11:45 AM, "Andrei Mikhailovsky"
> 
> > wrote:
> >
> >> Hi Will,
> >>
> >> forgot to mention that my VPN services are working well for all existing
> >> accounts on a none VPC networks. I am running version 4.9.0 and have no
> >> issues apart from creating new vpn users to a VPC enabled network.
> >>
> >> Actually, I've just checked that I can successfully add a new user to a
> >> non-VPC network. No issues there as far as I can see.
> >>
> >> Andrei
> >>
> >> - Original Message -
> >> > From: "Will Stevens" 
> >> > To: "dev" 
> >> > Sent: Tuesday, 22 November, 2016 13:47:36
> >> > Subject: Re: error adding VPN user in VPC network
> >>
> >> > I am not sure how you are able to add the VPN user to a Static NAT IP.
> >> You
> >> > should be adding it to the Source NAT IP.  Was that just a typo or are
> >> you
> >> > targeting the wrong IP address using the API or something like that?
> >> >
> >> > There are known issues with the current VPN implementation (openswan).
> >> > Basically, if you try to scp files over it or tail a log, it will drop
> >> your
> >> > connection.  You may want to try the code from my PR
> >> > https://github.com/apache/cloudstack/pull/1741 if you have problems
> with
> >> > the current implementation.  That PR should make it into the next
> >> release...
> >> >
> >> > *Will STEVENS*
> >> > Lead Developer
> >> >
> >> > 
> >> >
> >> > On Tue, Nov 22, 2016 at 8:35 AM, Andrei Mikhailovsky <
> >> > and...@arhont.com.invalid> wrote:
> >> >
> >> >> Hello
> >> >>
> >> >> Duplicating this from the users list.
> >> >>
> >> >> I am running ACS 4.9.0.
> >> >>
> >> >> I am having an issue with adding a VPN user to the VPC network. I've
> >> >> enabled the VPN service on the static IP. The service was enabled
> and I
> >> >> have the PSK shown to me. However, when I am adding a new user it
> fails
> >> >> with the following error:
> >> >>
> >> >> 2016-11-22 12:05:26,189 DEBUG [c.c.n.v.RemoteAccessVpnManagerImpl]
> >> >> (API-Job-Executor-82:ctx-d62e35c3 job-31537 ctx-8ac8a450)
> >> >> (logid:f76b2eae) VPN User VpnUser[40-andrei-45] is set on
> >> >> com.cloud.network.dao.RemoteAccessVpnVO$$EnhancerByCGLIB$$cc1dfb8d@
> >> >> 4465732c
> >> >> 2016-11-22 12:05:26,189 WARN [c.c.n.v.RemoteAccessVpnManagerImpl]
> >> >> (API-Job-Executor-82:ctx-d62e35c3 job-31537 ctx-8ac8a450)
> >> >> (logid:f76b2eae) Unable to apply vpn users
> >> >> java.lang.IndexOutOfBoundsException: Index: 1, Size: 1
> >> >> at java.util.ArrayList.rangeCheck(ArrayList.java:635)
> >> >> at java.util.ArrayList.get(ArrayList.java:411)
> >> >> at com.cloud.network.vpn.RemoteAccessVpnManagerImpl.applyVpnUsers(
> >> >> RemoteAccessVpnManagerImpl.java:532)
> >> >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >> >> at sun.reflect.NativeMethodAccessorImpl.invoke(
> >> >> NativeMethodAccessorImpl.java:57)
> >> >> at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> >> >> DelegatingMethodAccessorImpl.java:43)
> >> >> at java.lang.reflect.Method.invoke(Method.java:606)
> >> >> at org.springframework.aop.support.AopUtils.
> >> invokeJoinpointUsingReflection
> >> >> (AopUtils.java:317)
> >> >> at org.springframework.aop.framework.ReflectiveMethodInvocation.
> >> >> invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> >> >> at org.springframework.aop.framework.ReflectiveMethodInvocation.
> >> proceed(
> >> >> ReflectiveMethodInvocation.java:150)
> >> >> at org.springframework.aop.interceptor.ExposeInvocationInterceptor.
> >> invoke(
> >> >> ExposeInvocationInterceptor.java:91)
> >> >> at org.springframework.aop.framework.ReflectiveMethodInvocation.
> >> proceed(
> >> >> ReflectiveMethodInvocation.java:172)
> >> >> at org.springframework.aop.framework.JdkDynamicAopProxy.
> >> >> invoke(JdkDynamicAopProxy.java:204)
> >> >> at com.sun.proxy.$Proxy237.applyVpnUsers(Unknown Source)
> >> >> at org.apache.cloudstack.api.command.user.vpn.AddVpnUserCmd.execute(
> >> >> AddVpnUserCmd.java:122)
> >> >> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
> >> >> at com.cloud.api.ApiAsyncJobDispatcher.runJob(
> >> ApiAsyncJobDispatcher.java:
> >> >> 108)
> >> >> at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.
> >> >> runInContext(AsyncJobManagerImpl.java:554)
> >> >> at org.apache.cloudstack.managed.context.
> ManagedContextRunnable$1.run(
> >> >> ManagedContextRunnable.java:49)
> >> >> at org.apache.cloudstack.managed

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
@murali-reddy can you check why `test_router_dhcp_opts` failed?
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
LGTM, failures related to vpc/rvr are known intermittent failures. We'll 
kick another test round on #1753, #1754 etc. and work towards fixing them for 
vmware and xenserver separately.  Merging this based on code reviews and tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1681: CLOUDSTACK-9491: incorrect parsing of device ...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1681


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1680
  
LGTM. Merging this based on review and tests. 
Failures in vpc/rvr are known intermittent issues and will be addressed 
separately for xen/vmware.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@murali-reddy can you check why we've test failures for KVM? Also, if the 
integration tests don't take a lot of time (few minutes to half hour) can you 
move it to smoke tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1680: CLOUDSTACK-9498: VR CsFile search utility met...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1680


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1597: added constant for magic code

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1597
  
@vcharmcaster can you fix the space/tab issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1735
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1735
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1710
  
Do we have LGTMs on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1622
  
Thanks @ProjectMoon 
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1622
  
@ProjectMoon can you add a JIRA id for this, also in the commit's summary


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1622
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1623
  
@ProjectMoon thanks
@murali-reddy can you help review this?
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1623
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1566: Followup fix for #1162: Add support for not (re)star...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1566
  
LGTM. @ProjectMoon thanks, can you add a JIRA id for this, and also in the 
commit's summary


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...

2016-11-23 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1580#discussion_r89277508
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/api/response/NuageVlanIpRangeResponse.java
 ---
@@ -0,0 +1,38 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.response;
+
+import com.cloud.api.commands.VspConstants;
+import com.cloud.dc.Vlan;
+import com.cloud.serializer.Param;
+import com.google.gson.annotations.SerializedName;
+import org.apache.cloudstack.api.EntityReference;
+import org.apache.cloudstack.api.response.VlanIpRangeResponse;
+
+@EntityReference(value = Vlan.class)
+public class NuageVlanIpRangeResponse extends VlanIpRangeResponse {
--- End diff --

If you only need to communicate success/failure, you an use SuccessResponse 
instead of reintroducing a new class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...

2016-11-23 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1580#discussion_r89277328
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/DisableNuageUnderlayVlanIpRangeCmd.java
 ---
@@ -0,0 +1,110 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.api.response.VlanIpRangeResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import javax.inject.Inject;
+
+@APICommand(name = DisableNuageUnderlayVlanIpRangeCmd.APINAME, description 
= "disable Nuage underlay on vlan ip range", responseObject = 
SuccessResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+since = "4.9",
--- End diff --

Fix this to 4.10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...

2016-11-23 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1580#discussion_r89277386
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/EnableNuageUnderlayVlanIpRangeCmd.java
 ---
@@ -0,0 +1,110 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.api.response.VlanIpRangeResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import javax.inject.Inject;
+
+@APICommand(name = EnableNuageUnderlayVlanIpRangeCmd.APINAME, description 
= "enable Nuage underlay on vlan ip range", responseObject = 
SuccessResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+since = "4.9",
--- End diff --

Fix this to 4.10.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...

2016-11-23 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1580#discussion_r89277160
  
--- Diff: client/tomcatconf/commands.properties.in ---
@@ -0,0 +1,804 @@
+# Licensed to the Apache Software Foundation (ASF) under one
--- End diff --

Remove this file, we don't need it now that we've dynamic roles feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...

2016-11-23 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1580#discussion_r89277419
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/ListNuageUnderlayVlanIpRangesCmd.java
 ---
@@ -0,0 +1,80 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.commands;
+
+import com.cloud.api.response.NuageVlanIpRangeResponse;
+import com.cloud.dc.Vlan;
+import com.cloud.network.manager.NuageVspManager;
+import com.cloud.utils.Pair;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.command.admin.vlan.ListVlanIpRangesCmd;
+import org.apache.cloudstack.api.response.ListResponse;
+
+import javax.inject.Inject;
+import java.util.List;
+
+@APICommand(name = "listNuageUnderlayVlanIpRanges", description = "enable 
Nuage underlay on vlan ip range", responseObject = 
NuageVlanIpRangeResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+since = "4.9",
--- End diff --

Fix this to 4.10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1604
  
@romain-dartigues I'll have a look at the failure, meanwhile can you see my 
comments against the changes 
https://github.com/apache/cloudstack/pull/1604/files


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1618: Now returning os info with the list snapshot respons...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1618
  
@ProjectMoon thanks, can you add a JIRA id for this and also use that in 
your commit's PR.
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1618: Now returning os info with the list snapshot respons...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1618
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
LGTM, merging based on code reviews and tests, ignoring known intermittent 
errors in vpc/rvr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #756: CLOUDSTACK-8781 : Superfluous field during VPC creati...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/756
  
Thanks, merging this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1542: CLOUDSTACK-9379: Support nested virtualizatio...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1542


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #756: CLOUDSTACK-8781 : Superfluous field during VPC...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/756


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1559
  
Thanks @ProjectMoon can you squash your commits.
@murali-reddy @abhinandanprateek can you help review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1765
  
@rhtyd squashed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1765
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1765
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1623
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-231


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-23 Thread ProjectMoon
Github user ProjectMoon commented on the issue:

https://github.com/apache/cloudstack/pull/1559
  
@rhtyd, in my opinion the two commits are functionally separate enough that 
they should remain separate (and this might have been asked for in one of the 
various previous incarnations of this PR--I don't remember). I think rolling 
them into one commit puts too many things in one change. The smaller commits 
allows reverting of functionality easier, etc. If the change is 
rebased/fast-forward merged, then it shouldn't be any different than if there 
were two PRs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1622
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-230


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: WSDL for CloudStack

2016-11-23 Thread Rohit Yadav
Mauricio,


As far as I'm aware, we don't have any tooling to support this but you're right 
such a tool would consume response from listApis call.

You may want to write such a tool for your use-case and maybe publish it on 
github/pypi/etc.


Regards.


From: Mauricio Schaepers 
Sent: 21 November 2016 20:23:29
To: dev@cloudstack.apache.org
Subject: WSDL for CloudStack

Hi all,

I'm trying to automate several things including CloudStack. The Automation 
Framework I'm using requests a WSDL File.

Does anybody has already created a WSDL File for the REST API?

Or on other hand, if I setup the WSDL document, is anybody interested?
I mean, in the end it should be "just" converting the ListAPIs command to a 
valid WSDL syntax

Mauricio

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



Re: WSDL for CloudStack

2016-11-23 Thread Rafael Weingärtner
The idea to have a WSDL or a WADL is interesting. It helps in integrations
between system-system (without human coding/support), and allows more
sophisticated software to consume APIs.
Instead of creating something to generate the API externally, why not add a
plugin into CloudStack that generate the web service description? Then,
systems that have the ability to read the WSLD could do that on the fly.

Common Webservices already do this type of function. For WSDL, frameworks
normally respond with a WSDL when you post a request such as “
http://webservice.example/endpoint?WSDL”

The same can be done for WADL, normal RET web services return a WADL when
you request for a URL such as
http://localhost:8080/applicationname/application.wadl

WADL and WSDL are formal ways of describing web service methods, their
parameters, outputs, and a description of the method.


On Wed, Nov 23, 2016 at 8:03 AM, Rohit Yadav 
wrote:

> Mauricio,
>
>
> As far as I'm aware, we don't have any tooling to support this but you're
> right such a tool would consume response from listApis call.
>
> You may want to write such a tool for your use-case and maybe publish it
> on github/pypi/etc.
>
>
> Regards.
>
> 
> From: Mauricio Schaepers 
> Sent: 21 November 2016 20:23:29
> To: dev@cloudstack.apache.org
> Subject: WSDL for CloudStack
>
> Hi all,
>
> I'm trying to automate several things including CloudStack. The Automation
> Framework I'm using requests a WSDL File.
>
> Does anybody has already created a WSDL File for the REST API?
>
> Or on other hand, if I setup the WSDL document, is anybody interested?
> I mean, in the end it should be "just" converting the ListAPIs command to
> a valid WSDL syntax
>
> Mauricio
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


-- 
Rafael Weingärtner


[GitHub] cloudstack issue #1618: Now returning os info with the list snapshot respons...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1618
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-232


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1765
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-233


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1752: [4.8] Latest health test run

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1752
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1753: [4.9] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1753
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1753: [4.9] Latest health test run

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1753
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1754: [4.10] Latest health test run

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1754
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1752: [4.8] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1752
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1754: [4.10] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1754
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread wido
Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@jburwell @rhtyd I fixed most of the comments.

The NPE should be fixed and the StringUtils comments as well. I didn't 
refactor the other stuff @jburwell mentioned as my code is in-line with how the 
existing classes are written in the same files.

A new PR could do a refactor of those whole files, but it wouldn't change 
anything for a end-result. The functionality is still that we have a Qemu Guest 
Agent inside the VMs.

But this PR is open since May. Could we please merge this one in?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2016-11-23 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1771

CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work.

Description:
=

Trying to dedicate a guest VLAN range to an account fails. Either API 
documentation is wrong or code path needs to be corrected. If we pass both 
account and projectId parameters to the dedicateGuestVlanRange (which are not 
mentioned as mutually exclusive in API description) the API layer throws error 
saying both are mutually exclusive.

Steps to Reproduce:
===
Create an account. Create a project in that account.

Go to Admin account and change the view to the above project.

Navigate to Infrastructure -> Zone -> Physical Network -> Guest -> Dedicate 
Guest VLAN range.

Try to dedicate the guest VLAN range from the project view for the account 
associated with the project.

It fails with error saying "accountName and projectId are mutually 
exclusive".


![image](https://cloud.githubusercontent.com/assets/12583725/20559763/15fe55d8-b19c-11e6-9996-62602d269f10.png)


![image](https://cloud.githubusercontent.com/assets/12583725/20559765/1957af36-b19c-11e6-938f-e9c7c9eee987.png)

Expected:
===
The VLAN range should get dedicated to the project account.


![image](https://cloud.githubusercontent.com/assets/12583725/20559787/33ef67b2-b19c-11e6-90fd-41c9c583efd9.png)


![image](https://cloud.githubusercontent.com/assets/12583725/20559789/376cae22-b19c-11e6-9755-ff1e7237fb21.png)

Resolution:

Changed the account field of API to optional.
Even if the account name is passed while adding from a particular project 
view, then it is ignored in API.

Notes:
=
If we do the dedication from default view then it works fine as no 
projectId is associated over there.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1771.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1771


commit ef85dfd041858aeaee9aecfdc6bddabe1e21739d
Author: Nitin Kumar Maharana 
Date:   2016-11-23T11:07:20Z

CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work

Changed the account field of API to optional.
Even if the account name is passed while adding from a particular project 
view, then it is ignored in API.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@wido can you confirm if you've fixed the NPE issue I've shared in the 
comment above?
java.lang.NullPointerException
at java.io.File.(File.java:277)
at 
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.configure(LibvirtComputingResource.java:786)
at com.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread wido
Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
Yes @rhtyd, I added a check for NULL there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@wido alright, I'll initiate a final test round -- if that passes we can 
consider merging. /cc @jburwell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread ozhanrk
Github user ozhanrk commented on the issue:

https://github.com/apache/cloudstack/pull/1710
  
Hi @kiwiflyer @nathanejohnson i saw that you are merged this fix and using 
it on your ENA CloudStack branch, when you have time could you check the code 
for possible LGTM's please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread murali-reddy
Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1766
  
@murali-reddy a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1753: [4.9] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1753
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-234


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1752: [4.8] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1752
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-235


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1754: [4.10] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1754
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-236


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-237


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1754: [4.10] Latest health test run

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1754
  
@blueorangutan test matrix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1754: [4.10] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1754
  
@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt 
+ vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@wido please fix the build failures:
[INFO] Starting audit...

/jenkins/workspace/acs-pr-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.10.0.0-SNAPSHOT/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java:31:8:
 error: Unused import - com.cloud.utils.StringUtils.
Audit done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...

2016-11-23 Thread prashanthvarma
Github user prashanthvarma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1580#discussion_r89308445
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/api/response/NuageVlanIpRangeResponse.java
 ---
@@ -0,0 +1,38 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.api.response;
+
+import com.cloud.api.commands.VspConstants;
+import com.cloud.dc.Vlan;
+import com.cloud.serializer.Param;
+import com.google.gson.annotations.SerializedName;
+import org.apache.cloudstack.api.EntityReference;
+import org.apache.cloudstack.api.response.VlanIpRangeResponse;
+
+@EntityReference(value = Vlan.class)
+public class NuageVlanIpRangeResponse extends VlanIpRangeResponse {
--- End diff --

We are not just communicating success/failure, but extending 
VlanIpRangeResponse along with a boolean flag to specify if the listed vlan ip 
ranges are underlay enabled (or) disabled in Nuage VSP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...

2016-11-23 Thread prashanthvarma
Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/1580
  
@rhtyd I have resolved and responded to your comments, and updated the PR 
accordingly. Moreover, I have just kicked on our internal regression tests 
(including the added Marvin tests in this PR that test the code changes in this 
PR).

Regarding the above failures, all of them are either test environment 
(intermittent errors) and are not related to the code changes in this PR.

1) TestRVPCSite2SiteVpn - Failing to download the template in the 
setupClass.

Exception("Template download failed exception")

2) test_02_vpc_privategw_static_routes  - Failing to create privategateway 
in the VPC as the specified vlan is already in use.

errorText:Network with vlan vlan://926 already exists in zone 1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1604: improvement: systemvm slow operations

2016-11-23 Thread romain-dartigues
Github user romain-dartigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1604#discussion_r89310394
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsHelper.py ---
@@ -179,12 +179,12 @@ def get_hostname():
 return line.strip()
 
 
-def execute(command):
+def execute(command, wait=True):
 """ Execute command """
 logging.debug("Executing: %s" % command)
 p = subprocess.Popen(command, stdout=subprocess.PIPE, 
stderr=subprocess.PIPE, shell=True)
-result = p.communicate()[0]
-return result.splitlines()
+if wait:
+return p.communicate()[0].splitlines()
--- End diff --

@jburwell < I think your request, while valid, goes beyond the scope of 
this patch which was made to fix a problem we have in production.

To wait for an amount of time, it would be required to spawn a separate 
thread, as the `timeout` argument was added in Python 3 (3.2 I think).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-11-23 Thread romain-dartigues
Github user romain-dartigues commented on the issue:

https://github.com/apache/cloudstack/pull/1604
  
@rhtyd < separate function done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1753: [4.9] Latest health test run

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1753
  
@blueorangutan test matrix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1752: [4.8] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1752
  
@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt 
+ vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1752: [4.8] Latest health test run

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1752
  
@blueorangutan test matrix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1753: [4.9] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1753
  
@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt 
+ vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1604
  
okay @romain-dartigues I'll kick some tests
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1604
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-11-23 Thread pdion891
Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
btw, I don't think this PR should be backport since it would change 
behavior for someone that would upgrade from 4.x.x to 4.9.0 or 4.9.x(that would 
include this PR)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1604
  
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-238


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread wido
Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@rhtyd Yes, fixed. Forgot to commit that change locally. Pushed a new 
version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread nathanejohnson
Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1710
  
LGTM!  We're running it in our labs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1710
  
This code LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread ozhanrk
Github user ozhanrk commented on the issue:

https://github.com/apache/cloudstack/pull/1710
  
Hi @rhtyd we have got the required LGTM's now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-23 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1762
  
@rhtyd I am -1 on this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-239


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

2016-11-23 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1735
  
@nvazquez could you please check into the Travis failures?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-23 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1762
  
@jburwell We've been running this fix as a part of proprietary CS for 
several weeks now. We are observing elimination of deadlocks and no DB 
corruption. Retry seems to be the only realistic way of dealing with deadlocks 
in complex environment like ACS. Can we come up with a limited scope/conditions 
of this PR to move forward ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-23 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1762
  
@serg38 corruption could happen at any point -- it's a ticking time bomb.  
From a ACID perspective, this patch fails from a consistency perspective.  All 
data being updated must be re-queried and validated in order to ensure the 
consistency guarantee is not violated.  In a high volume system, it's not a 
matter of if, but when a sequence of events will occur and corrupt the 
database.   Bear in mind, these corruptions be in the content of the data and 
would not yield a MySQL error.  They will be phenomenon such as phantom rows or 
inconsistent data updates

As I said previously, the only real solution to deadlocks is to fix the way 
the system manages transactions and locks.  This patch is merely hiding an 
error while creating the potential for far larger problems.

For these reasons, I remain -1 on merging this patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-23 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1762
  
What about if the author can figure out a way to identify all part of 
transaction being cancelled and retry all parts? Or retry the whole 
transaction? It would  be nice  to open a path for the author to implement this 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


  1   2   >