[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/873
  
@karuturi can you please rebase this against latest master, let's get this 
reviewed and merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
@karuturi @swill @wido @NuxRo @nvazquez we believe this PR is ready to 
merge.  However, we need to cross check the test results.  Would one (or more 
of you) be able to test this PR in order to move it forward?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1703: Trillian testrun on PR-1692 fwd-merged on 4.9 branch

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1703
  
@karuturi @swill @wido @NuxRo @nvazquez we believe this PR is ready to 
merge.  However, we need to cross check the test results.  Would one (or more 
of you) be able to test this PR in order to move it forward?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: ACS 4.9 + VMware: Unable to remove one of the NICs of a multi-nic VM

[Prashanth Manthena]

Hi Paul,

First of all, thank you for your time and investigation.

I have tried with timeouts up to 180 seconds, and that didn't help either
:)

Yes, it doesn't explain the difference between 4.7 and 4.9, because I am
using the same vcenter/vmware setup (i.e. no vmware tools installed).

Let me know, if you want me to raise an issue on Jira for tracking this bug.

On Sat, Oct 15, 2016 at 8:55 PM, Paul Angus 
wrote:

> I tried extending the timeout to 30 seconds, but that didn't help.
> However, installing vmware tools (not easy in our built-in templates) made
> the problem go away.  With the tools installed the removal was pretty much
> instant.
> Doesn't explain the difference 4.7 and 4.9 that you are seeing though.
>
>
> Kind regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: Prashanth Manthena [mailto:prashanth.manth...@nuagenetworks.net]
> Sent: 14 October 2016 13:24
> To: dev@cloudstack.apache.org
> Subject: Re: ACS 4.9 + VMware: Unable to remove one of the NICs of a
> multi-nic VM
>
> Hi Paul,
>
> Thank you for trying it out.
>
> I am only hitting this issue for guest VMs (i.e. not with VPC VRs) created
> in ACS 4.9 (i.e. not in ACS 4.7) with VMware setups.
>
> Moreover, I get the same error when I am trying to remove the NIC (i.e.
> network adapter) directly from VMware's Vcenter.
>
> There is a possible workaround for this issue from VMware on Internet,
> which doesn't work in this scenario both from CloudStack and VMware:
> https://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=
> displayKC&externalId=2081503
>
> Most likely, this issue has something to do with how we deploy (multi-nic)
> guest VMs in ACS 4.9 with VMware setups.
>
> On Fri, Oct 14, 2016 at 1:00 PM, Paul Angus 
> wrote:
>
> > Hi Prashanth,
> >
> > I've just tried that. I get the same error - The guest operating
> > system did not respond to a hot-remove request for device ethernet1 in
> > a timely manner.
> >
> > Kind regards,
> >
> > Paul Angus
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> >
> >
> >
> >
> > -Original Message-
> > From: Prashanth Manthena [mailto:prashanth.manth...@nuagenetworks.net]
> > Sent: 14 October 2016 09:21
> > To: dev@cloudstack.apache.org
> > Subject: Re: ACS 4.9 + VMware: Unable to remove one of the NICs of a
> > multi-nic VM
> >
> > HI All,
> >
> > Does this issue ring a bell, and is anyone else hitting this issue ?
> >
> > Let me know, if it is a known issue.
> >
> > Thanking you in advance !!
> >
> > On Thu, Oct 13, 2016 at 6:25 PM, Prashanth Manthena < prashanth.manthena@
> > nuagenetworks.net> wrote:
> >
> > > Hi,
> > >
> > > I am hitting the following issue on an ACS 4.9 + VMware setup (steps
> > > to
> > > reproduce):
> > >
> > > 1) Deploy a multi-nic VM (or) add a nic to a single-nic VM
> > >
> > > 2) Remove the non-default nic from the multi-nic VM, which fails with
> > > the following error/exception in the management server log:
> > >
> > > 2016-10-05 06:13:28,251 DEBUG [c.c.a.ApiServlet]
> > > (catalina-exec-14:ctx-f8dc6bd0 ctx-ee610e01) (logid:58e9cf98)
> > > ===END===  10.31.52.95 -- GET
> > > command=queryAsyncJobResult&jobId=9ad66ce9-6e1b-4c25-bd2e-763f4586dd86
> > > &response=json&_=1475673245452
> > > 2016-10-05 06:13:29,787 ERROR [c.c.h.v.r.VmwareResource]
> > (DirectAgent-302:ctx-78a58d67 10.31.56.178, job-171/job-172, cmd:
> > UnPlugNicCommand) (logid:9ad66ce9) Unexpected exception:
> > > java.lang.RuntimeException: The guest operating system did not respond
> > to a hot-remove request for device ethernet1 in a timely manner.
> > > at com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(
> > VmwareClient.java:354)
> > > at com.cloud.hypervisor.vmware.mo.VirtualMachineMO.
> > configureVm(VirtualMachineMO.java:949)
> > > at com.cloud.hypervisor.vmware.resource.VmwareResource.
> > execute(VmwareResource.java:1103)
> > > at com.cloud.hypervisor.vmware.resource.VmwareResource.
> > executeRequest(VmwareResource.java:469)
> > > at com.cloud.agent.manager.DirectAgentAttache$Task.
> runInContext(
> > DirectAgentAttache.java:315)
> > > at org.apache.cloudstack.managed.context.
> > ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> > > at org.apache.cloudstack.managed.context.impl.
> > DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> > > at org.apache.cloudstack.managed.context.impl.
> > DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> > > at org.apache.cloudstack.managed.context.impl.
> > DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> > > at org.apache.cloudstack.managed.context.
> > ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> > > at java.util.concurrent.Executors$RunnableAdapter.

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@murali-reddy could you please squash your commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #872: Strongswan vpn feature

[jayapalu]

Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/872
  
@swill 
My setup is up with the strongswan template. Configured s2s VPN connection, 
I could observe that once that 'ipsec restart' or reload/rereadsecrets brought 
up the tunnels.

I will test  once again  issues you have mentioned above tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1559: CLOUDSTACK-9280: System VM volumes can be exp...

[GabrielBrascher]

Github user GabrielBrascher commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1559#discussion_r83600411
  
--- Diff: 
engine/storage/test/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelectorTest.java
 ---
@@ -0,0 +1,167 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.storage.endpoint;
+
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.cloudstack.engine.subsystem.api.storage.DataObject;
+import org.apache.cloudstack.engine.subsystem.api.storage.EndPoint;
+import org.apache.cloudstack.engine.subsystem.api.storage.StorageAction;
+import org.apache.cloudstack.engine.subsystem.api.storage.VolumeInfo;
+import org.apache.cloudstack.storage.DummyEndpoint;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.Spy;
+import org.powermock.api.mockito.PowerMockito;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
+
+import com.cloud.host.dao.HostDao;
+import com.cloud.utils.component.ComponentContext;
+import com.cloud.vm.SecondaryStorageVm;
+import com.cloud.vm.SecondaryStorageVmVO;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.VirtualMachine.State;
+import com.cloud.vm.VirtualMachine.Type;
+import com.cloud.vm.dao.SecondaryStorageVmDao;
+
+@RunWith(PowerMockRunner.class)
+@PrepareForTest(ComponentContext.class)
+public class DefaultEndPointSelectorTest {
+@Mock
+HostDao _hostDao;
+
+@Mock
+SecondaryStorageVmDao _ssvmDao;
+
+@InjectMocks
+@Spy
+DefaultEndPointSelector selector = new DefaultEndPointSelector();
+
+//Special mocked endpoints that the tests can use to identify what was 
returned from the method.
+private EndPoint selectMethodEndpoint = mock(EndPoint.class);
+private DummyEndpoint dummyEndpoint = mock(DummyEndpoint.class);
+
+/**
+ * The single common method that sets up the mocks to cover all 
possible scenarios we want to
+ * test. The VM type and volume state are passed in, while a potential 
list of existing SSVMs
+ * are also passed in. As its final action, the method calls {@link 
DefaultEndPointSelector#select(DataObject, StorageAction)}
+ * in order to test the method's operation and returns the endpoint 
found.
+ *
+ * @param vmType - State of the VM attached to the volume
+ * @param volumeState - State of the volume
+ * @param ssvmVOs - A list of SSVMs to return from the DAO
+ * @return The selected endpoint.
+ */
+public EndPoint mockEndpointSelection(Type vmType, State volumeState, 
SecondaryStorageVmVO ... ssvmVOs) {
--- End diff --

This method could be private. Did I missed something?
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1559: CLOUDSTACK-9280: System VM volumes can be exp...

[GabrielBrascher]

Github user GabrielBrascher commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1559#discussion_r83628876
  
--- Diff: 
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeDataFactoryImpl.java
 ---
@@ -77,22 +80,51 @@ public VolumeInfo getVolume(long volumeId, 
DataStoreRole storeRole) {
 
 @Override
 public VolumeInfo getVolume(long volumeId) {
+return getVolume(volumeId, false);
+}
+
+@Override
+public VolumeInfo getVolumeForExpunge(long volumeId) {
+return getVolume(volumeId, true);
+}
+
+protected VolumeInfo getVolume(long volumeId, boolean forExpunge) {
 VolumeVO volumeVO = volumeDao.findByIdIncludingRemoved(volumeId);
 if (volumeVO == null) {
 return null;
 }
+
+String dataStoreRole = "";
 VolumeObject vol = null;
 if (volumeVO.getPoolId() == null) {
+dataStoreRole = DataStoreRole.Image.toString();
 DataStore store = null;
 VolumeDataStoreVO volumeStore = 
volumeStoreDao.findByVolume(volumeId);
 if (volumeStore != null) {
-store = 
storeMgr.getDataStore(volumeStore.getDataStoreId(), DataStoreRole.Image);
+if (forExpunge) {
+store = 
storeMgr.getDataStoreForExpunge(volumeStore.getDataStoreId(), 
DataStoreRole.Image);
+} else {
+store = 
storeMgr.getDataStore(volumeStore.getDataStoreId(), DataStoreRole.Image);
+}
 }
+
 vol = VolumeObject.getVolumeObject(store, volumeVO);
 } else {
-DataStore store = storeMgr.getDataStore(volumeVO.getPoolId(), 
DataStoreRole.Primary);
+DataStore store = null;
+dataStoreRole = DataStoreRole.Primary.toString();
+if (forExpunge) {
+store = 
storeMgr.getDataStoreForExpunge(volumeVO.getPoolId(), DataStoreRole.Primary);
+} else {
+store = storeMgr.getDataStore(volumeVO.getPoolId(), 
DataStoreRole.Primary);
+}
+
 vol = VolumeObject.getVolumeObject(store, volumeVO);
 }
+
+if (vol.getDataStore() == null && forExpunge) {
+logger.warn("Was unable to find a DataStore (role = " + 
dataStoreRole + ") for expunged volume " + volumeId);
--- End diff --

Just a tip here. The [String 
format](https://docs.oracle.com/javase/7/docs/api/java/util/Formatter.html) can 
be very handy in cases like this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1559: CLOUDSTACK-9280: System VM volumes can be exp...

[GabrielBrascher]

Github user GabrielBrascher commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1559#discussion_r83647727
  
--- Diff: 
engine/storage/test/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelectorTest.java
 ---
@@ -0,0 +1,167 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.storage.endpoint;
+
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.cloudstack.engine.subsystem.api.storage.DataObject;
+import org.apache.cloudstack.engine.subsystem.api.storage.EndPoint;
+import org.apache.cloudstack.engine.subsystem.api.storage.StorageAction;
+import org.apache.cloudstack.engine.subsystem.api.storage.VolumeInfo;
+import org.apache.cloudstack.storage.DummyEndpoint;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.Spy;
+import org.powermock.api.mockito.PowerMockito;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
+
+import com.cloud.host.dao.HostDao;
+import com.cloud.utils.component.ComponentContext;
+import com.cloud.vm.SecondaryStorageVm;
+import com.cloud.vm.SecondaryStorageVmVO;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.VirtualMachine.State;
+import com.cloud.vm.VirtualMachine.Type;
+import com.cloud.vm.dao.SecondaryStorageVmDao;
+
+@RunWith(PowerMockRunner.class)
+@PrepareForTest(ComponentContext.class)
+public class DefaultEndPointSelectorTest {
+@Mock
+HostDao _hostDao;
+
+@Mock
+SecondaryStorageVmDao _ssvmDao;
+
+@InjectMocks
+@Spy
+DefaultEndPointSelector selector = new DefaultEndPointSelector();
+
+//Special mocked endpoints that the tests can use to identify what was 
returned from the method.
+private EndPoint selectMethodEndpoint = mock(EndPoint.class);
+private DummyEndpoint dummyEndpoint = mock(DummyEndpoint.class);
+
+/**
+ * The single common method that sets up the mocks to cover all 
possible scenarios we want to
+ * test. The VM type and volume state are passed in, while a potential 
list of existing SSVMs
+ * are also passed in. As its final action, the method calls {@link 
DefaultEndPointSelector#select(DataObject, StorageAction)}
+ * in order to test the method's operation and returns the endpoint 
found.
+ *
+ * @param vmType - State of the VM attached to the volume
+ * @param volumeState - State of the volume
+ * @param ssvmVOs - A list of SSVMs to return from the DAO
+ * @return The selected endpoint.
+ */
+public EndPoint mockEndpointSelection(Type vmType, State volumeState, 
SecondaryStorageVmVO ... ssvmVOs) {
+VolumeInfo volume = mock(VolumeInfo.class);
+VirtualMachine vm = mock(VirtualMachine.class);
+Long zoneId = 1l;
+
+when(vm.getType()).thenReturn(vmType);
+when(vm.getState()).thenReturn(volumeState);
+when(volume.getAttachedVM()).thenReturn(vm);
+when(volume.getDataCenterId()).thenReturn(zoneId);
+
+List ssvmList = new ArrayList<>();
+if (ssvmVOs != null) {
+for (SecondaryStorageVmVO ssvm : ssvmVOs) {
+ssvmList.add(ssvm);
+}
+}
+
+
when(_ssvmDao.listByZoneId(eq(SecondaryStorageVm.Role.templateProcessor), 
eq(zoneId)))
+.thenReturn(ssvmList);
+
+PowerMockito.mockStatic(ComponentContext.class);
+
when(ComponentContext.inject(DummyEndpoint.class)).thenReturn(dummyEndpoint);
+
+

[GitHub] cloudstack pull request #1559: CLOUDSTACK-9280: System VM volumes can be exp...

[GabrielBrascher]

Github user GabrielBrascher commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1559#discussion_r83595364
  
--- Diff: 
engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
 ---
@@ -345,15 +354,34 @@ public EndPoint select(DataObject object, 
StorageAction action) {
 }
 } else if (action == StorageAction.DELETEVOLUME) {
 VolumeInfo volume = (VolumeInfo)object;
+VirtualMachine vm = volume.getAttachedVM();
+
 if (volume.getHypervisorType() == 
Hypervisor.HypervisorType.VMware) {
-VirtualMachine vm = volume.getAttachedVM();
 if (vm != null) {
 Long hostId = vm.getHostId() != null ? vm.getHostId() 
: vm.getLastHostId();
 if (hostId != null) {
 return getEndPointFromHostId(hostId);
 }
 }
 }
+
+//Handle case where the volume is a volume of an expunging 
system VM and there are
+//no other system VMs existing in the zone.
+if (vm != null) {
+VirtualMachine.Type type = 
volume.getAttachedVM().getType();
+if ((type == VirtualMachine.Type.SecondaryStorageVm || 
type == VirtualMachine.Type.ConsoleProxy) &&
+(vm.getState() == State.Expunging || vm.getState() 
== State.Destroyed)) {
+
+List ssvms = 
ssvmDao.listByZoneId(Role.templateProcessor, volume.getDataCenterId());
+if (CollectionUtils.isEmpty(ssvms)) {
+
+s_logger.info("Volume " + volume.getName() + " is 
attached to a " + vm.getState() + " " + type + " and zone " +
+volume.getDataCenterId() + " has 
no SSVMs.");
+s_logger.info("Volume " + volume.getName() + " 
will be handled by dummy endpoint.");
+return DummyEndpoint.getEndpoint();
+}
+}
+}
--- End diff --

@ProjectMoon, it might be interesting to extract the code (lines 370 - 384) 
for a new method [e.g. `getDummyEndpoint(VolumeInfo volume, VirtualMachine 
vm)`].

With that, the `select(DataObject object, StorageAction action)` code gets 
a bit cleaner and the test case is "isolated" (test for `select(DataObject 
object, StorageAction action)` would just require a verify for the 
`getDummyEndpoint(VolumeInfo volume, VirtualMachine vm)`, which has its own 
unit test for its inner logic).

Commented lines (368 and 369) could become Javadoc for the new method.

Thanks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

XenServer 7

[Syed Ahmed]

Hi Guys,

I have some free time on my hands and was trying to add XenServer 7
support. There seems to be only one line change that was required to add
it. I am able to create VMs and do basic stuff like NAT/port forwarding.

If anyone is interested in trying this out, I have a branch [1] which I am
working on currently. I will open a PR after I am fairly confident that
everything works.

[1] https://github.com/syed/cloudstack/tree/xenserver7


Thanks,
-Syed

Re: XenServer 7

[Haijiao]

So cool, thats the feature lots of people awaiting and makes 4.10 shinning


Sent from my mobile



On 2016-10-17 23:28 , Syed Ahmed Wrote:

Hi Guys,

I have some free time on my hands and was trying to add XenServer 7
support. There seems to be only one line change that was required to add
it. I am able to create VMs and do basic stuff like NAT/port forwarding.

If anyone is interested in trying this out, I have a branch [1] which I am
working on currently. I will open a PR after I am fairly confident that
everything works.

[1] https://github.com/syed/cloudstack/tree/xenserver7


Thanks,
-Syed

RE: XenServer 7

[Marty Godsey]

That is amazing. I cannot wait to see this hit mainstream. The performance 
difference in XenServer 7 is considerably different than 6.5. I have my "core 
services" cluster running 7 and it works nicely. Core services like DNS, AD, 
and even ACS management servers but not compute nodes.

Regards,
Marty Godsey

-Original Message-
From: Haijiao [mailto:18602198...@163.com] 
Sent: Monday, October 17, 2016 11:31 AM
To: Syed Ahmed 
Cc: dev@cloudstack.apache.org
Subject: Re: XenServer 7

So cool, thats the feature lots of people awaiting and makes 4.10 shinning


Sent from my mobile



On 2016-10-17 23:28 , Syed Ahmed Wrote:

Hi Guys,

I have some free time on my hands and was trying to add XenServer 7 support. 
There seems to be only one line change that was required to add it. I am able 
to create VMs and do basic stuff like NAT/port forwarding.

If anyone is interested in trying this out, I have a branch [1] which I am 
working on currently. I will open a PR after I am fairly confident that 
everything works.

[1] https://github.com/syed/cloudstack/tree/xenserver7


Thanks,
-Syed

RE: XenServer 7

[Paul Angus]

Awesome Syed,


What can we do to help?
@rohit can we point blueorangutan at any repo to build packages for testing?

Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 


-Original Message-
From: Syed Ahmed [mailto:sah...@cloudops.com] 
Sent: 17 October 2016 16:29
To: dev@cloudstack.apache.org
Subject: XenServer 7

Hi Guys,

I have some free time on my hands and was trying to add XenServer 7 support. 
There seems to be only one line change that was required to add it. I am able 
to create VMs and do basic stuff like NAT/port forwarding.

If anyone is interested in trying this out, I have a branch [1] which I am 
working on currently. I will open a PR after I am fairly confident that 
everything works.

[1] https://github.com/syed/cloudstack/tree/xenserver7


Thanks,
-Syed

Re: XenServer 7

[Syed Ahmed]

Thanks Paul,

I am still trying to see what changes are needed. I am seeing problems when
adding an new host, sometimes the NFS doesn't get mounted. I will try to
sort these things today. I would need most of the help in testing and
making sure that we don't have any regressions. It would be awesome if you
could point blueorangutan to my branch.

Thanks,
-Syed


On Mon, Oct 17, 2016 at 12:42 PM, Paul Angus 
wrote:

> Awesome Syed,
>
>
> What can we do to help?
> @rohit can we point blueorangutan at any repo to build packages for
> testing?
>
> Kind regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: Syed Ahmed [mailto:sah...@cloudops.com]
> Sent: 17 October 2016 16:29
> To: dev@cloudstack.apache.org
> Subject: XenServer 7
>
> Hi Guys,
>
> I have some free time on my hands and was trying to add XenServer 7
> support. There seems to be only one line change that was required to add
> it. I am able to create VMs and do basic stuff like NAT/port forwarding.
>
> If anyone is interested in trying this out, I have a branch [1] which I am
> working on currently. I will open a PR after I am fairly confident that
> everything works.
>
> [1] https://github.com/syed/cloudstack/tree/xenserver7
>
>
> Thanks,
> -Syed
>

Re: XenServer 7

[Rajesh Ramchandani]

Syed - we are working with Citrix on XS7 as well, please drop a note if you 
need help.

Raj



On Mon, Oct 17, 2016 at 8:30 AM -0700, "Syed Ahmed" 
mailto:sah...@cloudops.com>> wrote:

Hi Guys,

I have some free time on my hands and was trying to add XenServer 7
support. There seems to be only one line change that was required to add
it. I am able to create VMs and do basic stuff like NAT/port forwarding.

If anyone is interested in trying this out, I have a branch [1] which I am
working on currently. I will open a PR after I am fairly confident that
everything works.

[1] https://github.com/syed/cloudstack/tree/xenserver7


Thanks,
-Syed



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

RE: XenServer 7

[Paul Angus]

Hey Rajesh,

Could you submit a pull request to Syed's branch containing where you've got to 
(or let us know where your work is publicly accessible) so that we can combine 
work..?



Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 


-Original Message-
From: Rajesh Ramchandani [mailto:rajesh.ramchand...@accelerite.com] 
Sent: 17 October 2016 18:37
To: dev@cloudstack.apache.org
Subject: Re: XenServer 7

Syed - we are working with Citrix on XS7 as well, please drop a note if you 
need help.

Raj



On Mon, Oct 17, 2016 at 8:30 AM -0700, "Syed Ahmed" 
mailto:sah...@cloudops.com>> wrote:

Hi Guys,

I have some free time on my hands and was trying to add XenServer 7 support. 
There seems to be only one line change that was required to add it. I am able 
to create VMs and do basic stuff like NAT/port forwarding.

If anyone is interested in trying this out, I have a branch [1] which I am 
working on currently. I will open a PR after I am fairly confident that 
everything works.

[1] https://github.com/syed/cloudstack/tree/xenserver7


Thanks,
-Syed



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

Re: XenServer 7

[Syed Ahmed]

Agree with Paul. If you can point to your public repo we can collaborate
easily.

As per testing. I have manually verified the following use cases below. I
am very happy with the results so far. I will open a PR with this and we
can run regression tests. I also have qcow2 images of XenServer7 and script
to reset/reinitialize it so I will post them as well on the PR so you guys
can take them and install/test XS7

* Create a new cluster with XenServer7
* Add Primary storage: Should create an SR on XS7
* Add another XS7 host to the Pool
* Add host2 to Cloudstack
* Create VM1 from template
* Create VM2 from template
* Ping/SSH VM1 to VM2 and vice-versa
* Stop/Delete/Expunge VM2
* Create Data disk
* Attach it to VM1
* Create VM snaphsot of VM1
* Restore VM snapshot of VM1
* Delete VM snapshot of VM1
* Create Volume snapshot of Datadisk
* Create volume snapshot of Root disk
* Create new template from snapshot of root disk
* Create volume from snapshot of datadisk
* Detach datadisk volume
* Delete datadisk volume
* Aquire a public IP
* Create a static nat to VM1
* Live migrate VM1 while traffic on VM
* Delete VM1

Thanks,
-Syed


On Mon, Oct 17, 2016 at 1:45 PM, Paul Angus 
wrote:

> Hey Rajesh,
>
> Could you submit a pull request to Syed's branch containing where you've
> got to (or let us know where your work is publicly accessible) so that we
> can combine work..?
>
>
>
> Kind regards,
>
> Paul Angus
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: Rajesh Ramchandani [mailto:rajesh.ramchand...@accelerite.com]
> Sent: 17 October 2016 18:37
> To: dev@cloudstack.apache.org
> Subject: Re: XenServer 7
>
> Syed - we are working with Citrix on XS7 as well, please drop a note if
> you need help.
>
> Raj
>
>
>
> On Mon, Oct 17, 2016 at 8:30 AM -0700, "Syed Ahmed"  > wrote:
>
> Hi Guys,
>
> I have some free time on my hands and was trying to add XenServer 7
> support. There seems to be only one line change that was required to add
> it. I am able to create VMs and do basic stuff like NAT/port forwarding.
>
> If anyone is interested in trying this out, I have a branch [1] which I am
> working on currently. I will open a PR after I am fairly confident that
> everything works.
>
> [1] https://github.com/syed/cloudstack/tree/xenserver7
>
>
> Thanks,
> -Syed
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>

[GitHub] cloudstack pull request #1711: Xenserver7

[syed]

GitHub user syed opened a pull request:

https://github.com/apache/cloudstack/pull/1711

Xenserver7

This PR adds support for XenServer 7. I have manually done the following 
tests

* Create a new cluster with XenServer7
* Add Primary storage: Should create an SR on XS7
* Add another XS7 host to the Pool 
* Add host2 to Cloudstack
* Create VM1 from template 
* Create VM2 from template 
* Ping/SSH VM1 to VM2 and vice-versa
* Stop/Delete/Expunge VM2
* Create Data disk 
* Attach it to VM1
* Create VM snaphsot of VM1
* Restore VM snapshot of VM1
* Delete VM snapshot of VM1
* Create Volume snapshot of Datadisk
* Create volume snapshot of Root disk
* Create new template from snapshot of root disk
* Create volume from snapshot of datadisk
* Detach datadisk volume
* Delete datadisk volume
* Aquire a public IP
* Create a static nat to VM1
* Live migrate VM1 while traffic on VM
* Delete VM1


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/syed/cloudstack xenserver7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1711.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1711


commit 7ffca736a3005ce9faa654fc19209ddb43dc4ff7
Author: Syed 
Date:   2016-10-17T15:25:00Z

Import json for XenServer7

commit 9fe4f1ca870e38d81b39672ac1ef7a6b7d4a071f
Author: Syed 
Date:   2016-10-17T19:52:50Z

Adding new resource




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: XenServer 7

[Syed Ahmed]

PR Created at https://github.com/apache/cloudstack/pull/1711



On Mon, Oct 17, 2016 at 3:20 PM, Syed Ahmed  wrote:

> Agree with Paul. If you can point to your public repo we can collaborate
> easily.
>
> As per testing. I have manually verified the following use cases below. I
> am very happy with the results so far. I will open a PR with this and we
> can run regression tests. I also have qcow2 images of XenServer7 and script
> to reset/reinitialize it so I will post them as well on the PR so you guys
> can take them and install/test XS7
>
> * Create a new cluster with XenServer7
> * Add Primary storage: Should create an SR on XS7
> * Add another XS7 host to the Pool
> * Add host2 to Cloudstack
> * Create VM1 from template
> * Create VM2 from template
> * Ping/SSH VM1 to VM2 and vice-versa
> * Stop/Delete/Expunge VM2
> * Create Data disk
> * Attach it to VM1
> * Create VM snaphsot of VM1
> * Restore VM snapshot of VM1
> * Delete VM snapshot of VM1
> * Create Volume snapshot of Datadisk
> * Create volume snapshot of Root disk
> * Create new template from snapshot of root disk
> * Create volume from snapshot of datadisk
> * Detach datadisk volume
> * Delete datadisk volume
> * Aquire a public IP
> * Create a static nat to VM1
> * Live migrate VM1 while traffic on VM
> * Delete VM1
>
> Thanks,
> -Syed
>
>
> On Mon, Oct 17, 2016 at 1:45 PM, Paul Angus 
> wrote:
>
>> Hey Rajesh,
>>
>> Could you submit a pull request to Syed's branch containing where you've
>> got to (or let us know where your work is publicly accessible) so that we
>> can combine work..?
>>
>>
>>
>> Kind regards,
>>
>> Paul Angus
>>
>> paul.an...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>>
>>
>>
>> -Original Message-
>> From: Rajesh Ramchandani [mailto:rajesh.ramchand...@accelerite.com]
>> Sent: 17 October 2016 18:37
>> To: dev@cloudstack.apache.org
>> Subject: Re: XenServer 7
>>
>> Syed - we are working with Citrix on XS7 as well, please drop a note if
>> you need help.
>>
>> Raj
>>
>>
>>
>> On Mon, Oct 17, 2016 at 8:30 AM -0700, "Syed Ahmed" > > wrote:
>>
>> Hi Guys,
>>
>> I have some free time on my hands and was trying to add XenServer 7
>> support. There seems to be only one line change that was required to add
>> it. I am able to create VMs and do basic stuff like NAT/port forwarding.
>>
>> If anyone is interested in trying this out, I have a branch [1] which I
>> am working on currently. I will open a PR after I am fairly confident that
>> everything works.
>>
>> [1] https://github.com/syed/cloudstack/tree/xenserver7
>>
>>
>> Thanks,
>> -Syed
>>
>>
>>
>> DISCLAIMER
>> ==
>> This e-mail may contain privileged and confidential information which is
>> the property of Accelerite, a Persistent Systems business. It is intended
>> only for the use of the individual or entity to which it is addressed. If
>> you are not the intended recipient, you are not authorized to read, retain,
>> copy, print, distribute or use this message. If you have received this
>> communication in error, please notify the sender and delete all copies of
>> this message. Accelerite, a Persistent Systems business does not accept any
>> liability for virus infected mails.
>>
>
>

Re: XenServer 7

[Syed Ahmed]

@Raj I'd be more interested in knowing if there are any corner cases that
We've missed. The fix seems to be relatively simple but I wonder if there
is something that I've missed as I cannot tests most of the scenarios

On Mon, Oct 17, 2016 at 4:00 PM, Syed Ahmed  wrote:

> PR Created at https://github.com/apache/cloudstack/pull/1711
>
>
>
> On Mon, Oct 17, 2016 at 3:20 PM, Syed Ahmed  wrote:
>
>> Agree with Paul. If you can point to your public repo we can collaborate
>> easily.
>>
>> As per testing. I have manually verified the following use cases below. I
>> am very happy with the results so far. I will open a PR with this and we
>> can run regression tests. I also have qcow2 images of XenServer7 and script
>> to reset/reinitialize it so I will post them as well on the PR so you guys
>> can take them and install/test XS7
>>
>> * Create a new cluster with XenServer7
>> * Add Primary storage: Should create an SR on XS7
>> * Add another XS7 host to the Pool
>> * Add host2 to Cloudstack
>> * Create VM1 from template
>> * Create VM2 from template
>> * Ping/SSH VM1 to VM2 and vice-versa
>> * Stop/Delete/Expunge VM2
>> * Create Data disk
>> * Attach it to VM1
>> * Create VM snaphsot of VM1
>> * Restore VM snapshot of VM1
>> * Delete VM snapshot of VM1
>> * Create Volume snapshot of Datadisk
>> * Create volume snapshot of Root disk
>> * Create new template from snapshot of root disk
>> * Create volume from snapshot of datadisk
>> * Detach datadisk volume
>> * Delete datadisk volume
>> * Aquire a public IP
>> * Create a static nat to VM1
>> * Live migrate VM1 while traffic on VM
>> * Delete VM1
>>
>> Thanks,
>> -Syed
>>
>>
>> On Mon, Oct 17, 2016 at 1:45 PM, Paul Angus 
>> wrote:
>>
>>> Hey Rajesh,
>>>
>>> Could you submit a pull request to Syed's branch containing where you've
>>> got to (or let us know where your work is publicly accessible) so that we
>>> can combine work..?
>>>
>>>
>>>
>>> Kind regards,
>>>
>>> Paul Angus
>>>
>>> paul.an...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>>> @shapeblue
>>>
>>>
>>>
>>>
>>> -Original Message-
>>> From: Rajesh Ramchandani [mailto:rajesh.ramchand...@accelerite.com]
>>> Sent: 17 October 2016 18:37
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: XenServer 7
>>>
>>> Syed - we are working with Citrix on XS7 as well, please drop a note if
>>> you need help.
>>>
>>> Raj
>>>
>>>
>>>
>>> On Mon, Oct 17, 2016 at 8:30 AM -0700, "Syed Ahmed" >> > wrote:
>>>
>>> Hi Guys,
>>>
>>> I have some free time on my hands and was trying to add XenServer 7
>>> support. There seems to be only one line change that was required to add
>>> it. I am able to create VMs and do basic stuff like NAT/port forwarding.
>>>
>>> If anyone is interested in trying this out, I have a branch [1] which I
>>> am working on currently. I will open a PR after I am fairly confident that
>>> everything works.
>>>
>>> [1] https://github.com/syed/cloudstack/tree/xenserver7
>>>
>>>
>>> Thanks,
>>> -Syed
>>>
>>>
>>>
>>> DISCLAIMER
>>> ==
>>> This e-mail may contain privileged and confidential information which is
>>> the property of Accelerite, a Persistent Systems business. It is intended
>>> only for the use of the individual or entity to which it is addressed. If
>>> you are not the intended recipient, you are not authorized to read, retain,
>>> copy, print, distribute or use this message. If you have received this
>>> communication in error, please notify the sender and delete all copies of
>>> this message. Accelerite, a Persistent Systems business does not accept any
>>> liability for virus infected mails.
>>>
>>
>>
>

[GitHub] cloudstack issue #1708: Fwd merge 4.8->4.9 marvintestfixes to master

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1708
  
@karuturi can you help run BVT tests on this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1703: Trillian testrun on PR-1692 fwd-merged on 4.9 branch

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1703
  
@karuturi can you help run BVT tests on this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1692
  
@karuturi can you help run BVT tests on this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
LGTM. @murali-reddy can you squash the commits to a single commit and 
rebase against latest 4.9 branch. Following merge of PR #1703 I'll kick a new 
trillian test run and merge based on the test results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1711: Xenserver7 Support

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1711
  
Thanks @syed for your PR. I'll kick some tests following merge of PR #1708.
@PaulAngus can add support for XenServer 7 in Trillian, thanks.

@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1711: Xenserver7 Support

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1711
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1709: CLOUDSTACK-7982 - KVM live migration

[marcaurele]

Github user marcaurele commented on the issue:

https://github.com/apache/cloudstack/pull/1709
  
Is there a way to get the management server log of the travis job?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1711: Xenserver7 Support

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1711
  
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-62


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1711: Xenserver7 Support

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1711
  
There was an env issue with the debian package job, it has been re-fired.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1711: Xenserver7 Support

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1711
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-63


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1711: Xenserver7 Support

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1711#discussion_r83789828
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java
 ---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.cloud.hypervisor.xenserver.resource;
+
+import com.cloud.resource.ServerResource;
+
+import javax.ejb.Local;
+
+@Local(value=ServerResource.class)
+public class XenServer700Resource extends Xenserver625Resource {
+
+@Override
+protected String getPatchFilePath() {
+return "scripts/vm/hypervisor/xenserver/xenserver70/patch";
--- End diff --

Refer to the comment on patch file, if same as XS 6.5 then 
XenServer650Resource can be reused


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1711: Xenserver7 Support

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1711#discussion_r83790292
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java
 ---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.cloud.hypervisor.xenserver.resource;
+
+import com.cloud.resource.ServerResource;
+
+import javax.ejb.Local;
+
+@Local(value=ServerResource.class)
+public class XenServer700Resource extends Xenserver625Resource {
+
+@Override
+protected String getPatchFilePath() {
+return "scripts/vm/hypervisor/xenserver/xenserver70/patch";
--- End diff --

Additional DB changes are also needed for guest OS mapping and HV 
capabilities table.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1711: Xenserver7 Support

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1711#discussion_r83789402
  
--- Diff: scripts/vm/hypervisor/xenserver/xenserver70/patch ---
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
--- End diff --

Is the content of this same as that of XS6.5? If so then this is not 
needed, the 6.5 one can be reused.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---