Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1600
I have run all of the relevant managed-storage tests and all passed
(details below).
I did encounter one issue:
When the fourth test of TestSnapshots ran, it failed because I did not have
the base.py file from this PR in my Marvin install. I went ahead and rebuilt
Marvin and re-installed it.
The same test then encountered another issue:
As it turns out, the new (optional) parameter, locationtype, was still
annotated as a CommandType.SHORT (the original design), even though the
variable it annotates was changed to be a String during the PR review. I went
ahead and made changes to CreateSnapshot.java (now the variable is annotated as
a CommandType.STRING) and to the Marvin test, TestSnapshot.py.
The only code that would have noticed this parameter issue is this one test
(none of the other tests in our system pass in this new (optional) parameter).
Here are the details of the test results:
TestSnapshots:
Note the error on the fourth test (and then that it passes after the noted
code changes):
test_01_create_volume_snapshot_using_sf_snapshot
(TestSnapshots.TestSnapshots) ... === TestName:
test_01_create_volume_snapshot_using_sf_snapshot | Status : SUCCESS ===
ok
test_02_create_volume_snapshot_using_sf_volume
(TestSnapshots.TestSnapshots) ... === TestName:
test_02_create_volume_snapshot_using_sf_volume | Status : SUCCESS ===
ok
test_03_create_volume_snapshot_using_sf_volume_and_sf_snapshot
(TestSnapshots.TestSnapshots) ... === TestName:
test_03_create_volume_snapshot_using_sf_volume_and_sf_snapshot | Status :
SUCCESS ===
ok
test_04_create_volume_snapshot_using_sf_snapshot_and_archiving
(TestSnapshots.TestSnapshots) ... === TestName:
test_04_create_volume_snapshot_using_sf_snapshot_and_archiving | Status :
EXCEPTION ===
ERROR
After the noted code changes:
test_04_create_volume_snapshot_using_sf_snapshot_and_archiving
(TestSnapshots.TestSnapshots) ... === TestName:
test_04_create_volume_snapshot_using_sf_snapshot_and_archiving | Status :
SUCCESS ===
ok
--
Ran 1 test in 3107.229s
OK
TestAddRemoveHosts:
test_add_remove_host_with_solidfire_plugin_1
(TestAddRemoveHosts.TestAddRemoveHosts) ... === TestName:
test_add_remove_host_with_solidfire_plugin_1 | Status : SUCCESS ===
ok
test_add_remove_host_with_solidfire_plugin_2
(TestAddRemoveHosts.TestAddRemoveHosts) ... === TestName:
test_add_remove_host_with_solidfire_plugin_2 | Status : SUCCESS ===
ok
test_add_remove_host_with_solidfire_plugin_3
(TestAddRemoveHosts.TestAddRemoveHosts) ... === TestName:
test_add_remove_host_with_solidfire_plugin_3 | Status : SUCCESS ===
ok
test_add_remove_host_with_solidfire_plugin_4
(TestAddRemoveHosts.TestAddRemoveHosts) ... === TestName:
test_add_remove_host_with_solidfire_plugin_4 | Status : SUCCESS ===
ok
--
Ran 4 tests in 4357.199s
OK
TestVMSnapshots:
test_01_take_VM_snapshot (TestVMSnapshots.TestVMSnapshots) ... ===
TestName: test_01_take_VM_snapshot | Status : SUCCESS ===
ok
test_02_take_VM_snapshot_with_data_disk (TestVMSnapshots.TestVMSnapshots)
... === TestName: test_02_take_VM_snapshot_with_data_disk | Status : SUCCESS ===
ok
--
Ran 2 tests in 750.531s
OK
TestVolumes (no XenServer SR resigning):
test_00_check_template_cache (TestVolumes.TestVolumes) ... === TestName:
test_00_check_template_cache | Status : SUCCESS ===
ok
Attach a volume to a stopped virtual machine, then start VM ... ===
TestName: test_01_attach_new_volume_to_stopped_VM | Status : SUCCESS ===
ok
Attach, detach, and attach volume to a running VM ... === TestName:
test_02_attach_detach_attach_volume | Status : SUCCESS ===
ok
Attach volume to running VM, then reboot. ... === TestName:
test_03_attached_volume_reboot_VM | Status : SUCCESS ===
ok
Detach volume from a running VM, then reboot. ... === TestName:
test_04_detach_volume_reboot | Status : SUCCESS ===
ok
Detach volume from a stopped VM, then start. ... === TestName:
test_05_detach_vol_stopped_VM_start | Status : SUCCESS ===
ok
Attach a volume to a stopped virtual machine, then start VM ... ===
TestName: test_06_attach_volume_to_stopped_VM | Status : SUCCESS ===
ok
Destroy and expunge VM with attached volume ... === TestName:
test_07_destroy_expunge_VM_with_volume | Status : SUCCESS ===
ok
Delete volume that was attached to a VM and is detached now ... ===
TestName: test_08_delete_volume_was_attached | Status : S
