[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1663#discussion_r76561209 --- Diff: test/integration/smoke/test_router_dns.py --- @@ -0,0 +1,286 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +import dns.resolver + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.lib.utils import cleanup_resources +from marvin.lib.base import (ServiceOffering, + VirtualMachine, + Account, + NATRule, + FireWallRule, + NetworkOffering, + Network) +from marvin.lib.common import (get_zone, + get_template, + get_domain, + list_routers, + list_nat_rules, + list_publicIP) + + +class TestRouterDns(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +cls.logger = logging.getLogger('TestRouterDns') +cls.stream_handler = logging.StreamHandler() +cls.logger.setLevel(logging.DEBUG) +cls.logger.addHandler(cls.stream_handler) + +cls.testClient = super(TestRouterDns, cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() + +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests()) +cls.services['mode'] = cls.zone.networktype +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services["ostype"] +) +cls.services["virtual_machine"]["zoneid"] = cls.zone.id + +cls.logger.debug("Creating Admin Account for domain %s on zone %s" % (cls.domain.id, cls.zone.id)) +cls.account = Account.create( +cls.api_client, +cls.services["account"], +admin=True, +domainid=cls.domain.id +) + +cls.logger.debug("Creating Service Offering on zone %s" % (cls.zone.id)) +cls.service_offering = ServiceOffering.create( +cls.api_client, +cls.services["service_offering"] +) + +cls.logger.debug("Creating Network Offering on zone %s" % (cls.zone.id)) +cls.services["isolated_network_offering"]["egress_policy"] = "true" +cls.network_offering = NetworkOffering.create(cls.api_client, + cls.services["isolated_network_offering"], + conservemode=True) +cls.network_offering.update(cls.api_client, state='Enabled') + +cls.logger.debug("Creating Network for Account %s using offering %s" % (cls.account.name, cls.network_offering.id)) +cls.network = Network.create(cls.api_client, + cls.services["network"], + accountid=cls.account.name, + domainid=cls.account.domainid, + networkofferingid=cls.network_offering.id, + zoneid=cls.zone.id) + +cls.logger.debug("Creating guest VM for Account %s using offering %s" % (cls.account.name, cls.service_offering.id)) +cls.vm = VirtualMachine.create(cls.api_client, + cls.services["virtual_machine"], + templateid=cls.template.id, + accountid=cls.account.name, +
[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1663#discussion_r76561273 --- Diff: test/integration/smoke/test_router_dns.py --- @@ -0,0 +1,286 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +import dns.resolver + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.lib.utils import cleanup_resources +from marvin.lib.base import (ServiceOffering, + VirtualMachine, + Account, + NATRule, + FireWallRule, + NetworkOffering, + Network) +from marvin.lib.common import (get_zone, + get_template, + get_domain, + list_routers, + list_nat_rules, + list_publicIP) + + +class TestRouterDns(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +cls.logger = logging.getLogger('TestRouterDns') +cls.stream_handler = logging.StreamHandler() +cls.logger.setLevel(logging.DEBUG) +cls.logger.addHandler(cls.stream_handler) + +cls.testClient = super(TestRouterDns, cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() + +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests()) +cls.services['mode'] = cls.zone.networktype +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services["ostype"] +) +cls.services["virtual_machine"]["zoneid"] = cls.zone.id + +cls.logger.debug("Creating Admin Account for domain %s on zone %s" % (cls.domain.id, cls.zone.id)) +cls.account = Account.create( +cls.api_client, +cls.services["account"], +admin=True, +domainid=cls.domain.id +) + +cls.logger.debug("Creating Service Offering on zone %s" % (cls.zone.id)) +cls.service_offering = ServiceOffering.create( +cls.api_client, +cls.services["service_offering"] +) + +cls.logger.debug("Creating Network Offering on zone %s" % (cls.zone.id)) +cls.services["isolated_network_offering"]["egress_policy"] = "true" +cls.network_offering = NetworkOffering.create(cls.api_client, + cls.services["isolated_network_offering"], + conservemode=True) +cls.network_offering.update(cls.api_client, state='Enabled') + +cls.logger.debug("Creating Network for Account %s using offering %s" % (cls.account.name, cls.network_offering.id)) +cls.network = Network.create(cls.api_client, + cls.services["network"], + accountid=cls.account.name, + domainid=cls.account.domainid, + networkofferingid=cls.network_offering.id, + zoneid=cls.zone.id) + +cls.logger.debug("Creating guest VM for Account %s using offering %s" % (cls.account.name, cls.service_offering.id)) +cls.vm = VirtualMachine.create(cls.api_client, + cls.services["virtual_machine"], + templateid=cls.template.id, + accountid=cls.account.name, +
[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1663#discussion_r76561300 --- Diff: test/integration/smoke/test_router_dns.py --- @@ -0,0 +1,286 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +import dns.resolver + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.lib.utils import cleanup_resources +from marvin.lib.base import (ServiceOffering, + VirtualMachine, + Account, + NATRule, + FireWallRule, + NetworkOffering, + Network) +from marvin.lib.common import (get_zone, + get_template, + get_domain, + list_routers, + list_nat_rules, + list_publicIP) + + +class TestRouterDns(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +cls.logger = logging.getLogger('TestRouterDns') +cls.stream_handler = logging.StreamHandler() +cls.logger.setLevel(logging.DEBUG) +cls.logger.addHandler(cls.stream_handler) + +cls.testClient = super(TestRouterDns, cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() + +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests()) +cls.services['mode'] = cls.zone.networktype +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services["ostype"] +) +cls.services["virtual_machine"]["zoneid"] = cls.zone.id + +cls.logger.debug("Creating Admin Account for domain %s on zone %s" % (cls.domain.id, cls.zone.id)) +cls.account = Account.create( +cls.api_client, +cls.services["account"], +admin=True, +domainid=cls.domain.id +) + +cls.logger.debug("Creating Service Offering on zone %s" % (cls.zone.id)) +cls.service_offering = ServiceOffering.create( +cls.api_client, +cls.services["service_offering"] +) + +cls.logger.debug("Creating Network Offering on zone %s" % (cls.zone.id)) +cls.services["isolated_network_offering"]["egress_policy"] = "true" +cls.network_offering = NetworkOffering.create(cls.api_client, + cls.services["isolated_network_offering"], + conservemode=True) +cls.network_offering.update(cls.api_client, state='Enabled') + +cls.logger.debug("Creating Network for Account %s using offering %s" % (cls.account.name, cls.network_offering.id)) +cls.network = Network.create(cls.api_client, + cls.services["network"], + accountid=cls.account.name, + domainid=cls.account.domainid, + networkofferingid=cls.network_offering.id, + zoneid=cls.zone.id) + +cls.logger.debug("Creating guest VM for Account %s using offering %s" % (cls.account.name, cls.service_offering.id)) +cls.vm = VirtualMachine.create(cls.api_client, + cls.services["virtual_machine"], + templateid=cls.template.id, + accountid=cls.account.name, +
[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1663#discussion_r76561383 --- Diff: test/integration/smoke/test_router_dns.py --- @@ -0,0 +1,286 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +import dns.resolver + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.lib.utils import cleanup_resources +from marvin.lib.base import (ServiceOffering, + VirtualMachine, + Account, + NATRule, + FireWallRule, + NetworkOffering, + Network) +from marvin.lib.common import (get_zone, + get_template, + get_domain, + list_routers, + list_nat_rules, + list_publicIP) + + +class TestRouterDns(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +cls.logger = logging.getLogger('TestRouterDns') +cls.stream_handler = logging.StreamHandler() +cls.logger.setLevel(logging.DEBUG) +cls.logger.addHandler(cls.stream_handler) + +cls.testClient = super(TestRouterDns, cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() + +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests()) +cls.services['mode'] = cls.zone.networktype +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services["ostype"] +) +cls.services["virtual_machine"]["zoneid"] = cls.zone.id + +cls.logger.debug("Creating Admin Account for domain %s on zone %s" % (cls.domain.id, cls.zone.id)) +cls.account = Account.create( +cls.api_client, +cls.services["account"], +admin=True, +domainid=cls.domain.id +) + +cls.logger.debug("Creating Service Offering on zone %s" % (cls.zone.id)) +cls.service_offering = ServiceOffering.create( +cls.api_client, +cls.services["service_offering"] +) + +cls.logger.debug("Creating Network Offering on zone %s" % (cls.zone.id)) +cls.services["isolated_network_offering"]["egress_policy"] = "true" +cls.network_offering = NetworkOffering.create(cls.api_client, + cls.services["isolated_network_offering"], + conservemode=True) +cls.network_offering.update(cls.api_client, state='Enabled') + +cls.logger.debug("Creating Network for Account %s using offering %s" % (cls.account.name, cls.network_offering.id)) +cls.network = Network.create(cls.api_client, + cls.services["network"], + accountid=cls.account.name, + domainid=cls.account.domainid, + networkofferingid=cls.network_offering.id, + zoneid=cls.zone.id) + +cls.logger.debug("Creating guest VM for Account %s using offering %s" % (cls.account.name, cls.service_offering.id)) +cls.vm = VirtualMachine.create(cls.api_client, + cls.services["virtual_machine"], + templateid=cls.template.id, + accountid=cls.account.name, +
[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1663#discussion_r76561440 --- Diff: test/integration/smoke/test_router_dns.py --- @@ -0,0 +1,286 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +import dns.resolver + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.lib.utils import cleanup_resources +from marvin.lib.base import (ServiceOffering, + VirtualMachine, + Account, + NATRule, + FireWallRule, + NetworkOffering, + Network) +from marvin.lib.common import (get_zone, + get_template, + get_domain, + list_routers, + list_nat_rules, + list_publicIP) + + +class TestRouterDns(cloudstackTestCase): + +@classmethod +def setUpClass(cls): +cls.logger = logging.getLogger('TestRouterDns') +cls.stream_handler = logging.StreamHandler() +cls.logger.setLevel(logging.DEBUG) +cls.logger.addHandler(cls.stream_handler) + +cls.testClient = super(TestRouterDns, cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.services = cls.testClient.getParsedTestDataConfig() + +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests()) +cls.services['mode'] = cls.zone.networktype +cls.template = get_template( +cls.api_client, +cls.zone.id, +cls.services["ostype"] +) +cls.services["virtual_machine"]["zoneid"] = cls.zone.id + +cls.logger.debug("Creating Admin Account for domain %s on zone %s" % (cls.domain.id, cls.zone.id)) +cls.account = Account.create( +cls.api_client, +cls.services["account"], +admin=True, +domainid=cls.domain.id +) + +cls.logger.debug("Creating Service Offering on zone %s" % (cls.zone.id)) +cls.service_offering = ServiceOffering.create( +cls.api_client, +cls.services["service_offering"] +) + +cls.logger.debug("Creating Network Offering on zone %s" % (cls.zone.id)) +cls.services["isolated_network_offering"]["egress_policy"] = "true" +cls.network_offering = NetworkOffering.create(cls.api_client, + cls.services["isolated_network_offering"], + conservemode=True) +cls.network_offering.update(cls.api_client, state='Enabled') + +cls.logger.debug("Creating Network for Account %s using offering %s" % (cls.account.name, cls.network_offering.id)) +cls.network = Network.create(cls.api_client, + cls.services["network"], + accountid=cls.account.name, + domainid=cls.account.domainid, + networkofferingid=cls.network_offering.id, + zoneid=cls.zone.id) + +cls.logger.debug("Creating guest VM for Account %s using offering %s" % (cls.account.name, cls.service_offering.id)) +cls.vm = VirtualMachine.create(cls.api_client, + cls.services["virtual_machine"], + templateid=cls.template.id, + accountid=cls.account.name, +
[GitHub] cloudstack issue #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS reflectio...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1663 @jburwell @NuxRo thanks for the reviews, I've fixed the outstanding issues. Please re-review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1636 @jburwell @milamberspace due to version change in poms already merged on 4.8 without a valid db upgrade path (which I had added in a separate PR), we'll see db failures for all PRs targeting 4.8 branch. Please fix and merge #1654 first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: CS 4.9 NIO Selector wait time PR-1601
thanks Simon and Rohit for the valuable inputs! After applying the following procedure the ssl errors are gone and host state is UP. # service cloudstack-management stop mysql> delete from configuration where name = "ssl.keystore" ; # mv /etc/cloudstack/management/cloudmanagementserver.keystore /etc/cloudstack/management/cloudmanagementserver.keystore.old # service cloudstack-management start # file /etc/cloudstack/management/cloudmanagementserver.keystore /etc/cloudstack/management/cloudmanagementserver.keystore: Java KeyStore # file /etc/cloudstack/management/cloudmanagementserver.keystore.old /etc/cloudstack/management/cloudmanagementserver.keystore.old: data #java -version java version "1.7.0_111" However new routers are not deployed, we still see entries that KVM hosts are unreachable (logs underneath). After starting a new router it is shown with "virsh list" on the KVM: kvm# virsh list | grep r-233-VM 111 r-233-VM running After some seconds the router is deleted, kvm# virsh list | grep r-233-VM # kvm#virsh -v 1.2.2 (libvirt was already restarted) Logs/Info KVM # kvm # dpkg -l | grep cloudstack ii cloudstack-agent 4.9.0 all CloudStack agent ii cloudstack-common 4.9.0 all A common package which contains files which are shared by several CloudStack packages kvm# df -kh | grep cloud 10.100.12.9:/export/cloud 188G 137G 51G 73% /mnt/5db02c19-1e8f-3591-bdb4-02608362521e kvm# tail -f /var/log/cloudstack/agent/agent.log ... 2016-08-29 06:55:06.203+: 4425: error : qemuMonitorFindBalloonObjectPath:1032 : internal error: Cannot determine balloon device path 2016-08-29 06:55:06.223+: 4426: error : qemuMonitorFindBalloonObjectPath:1032 : internal error: Cannot determine balloon device path 2016-08-29 06:55:24.062+: 4425: warning : qemuDomainObjTaint:1628 : Domain id=112 name='r-233-VM' uuid=d9dcd37a-242d-43ac-a18e-79a4bfa86ebb is tainted: high-privileges 2016-08-29 06:55:49.066+: 4423: error : qemuMonitorIO:656 : internal error: End of file from monitor Logs/Info Management Server # dpkg -l | grep cloudstack ii cloudstack-agent 4.9.0 all CloudStack agent ii cloudstack-common 4.9.0 all A common package which contains files which are shared by several CloudStack packages ii cloudstack-management 4.9.0 all CloudStack server library ii cloudstack-usage 4.9.0 all CloudStack usage monitor # mysql -u root cloud -e "select id,name,path from cloud.storage_pool where pool_type='Filesystem'" ++--+-+ | id | name | path| ++--+-+ | 1 | kvm704 Local Storage | /var/lib/libvirt/images | | 2 | kvm701 Local Storage | /var/lib/libvirt/images | | 3 | kvm702 Local Storage | /var/lib/libvirt/images | | 4 | kvm703 Local Storage | /var/lib/libvirt/images | ++--+-+ #tail -f /var/log/cloudstack/management/management-server.log | grep -v DEBUG ... 2016-08-29 08:55:42,484 WARN [o.a.c.alerts] (Work-Job-Executor-112:ctx-b46df979 job-2738/job-2739 ctx-68467c7a) (logid:337b354e) alertType:: 9 // dataCenterId:: 1 // podId:: 1 // clusterId:: null // message:: Command: com.cloud.agent.api.GetDomRVersionCommand failed while starting virtual router 2016-08-29 08:55:42,494 ERROR [c.c.n.r.VirtualNetworkApplianceManagerImpl] (Work-Job-Executor-112:ctx-b46df979 job-2738/job-2739 ctx-68467c7a) (logid:337b354e) GetDomRVersionCmd failed 2016-08-29 08:55:42,495 WARN [c.c.n.r.VirtualNetworkApplianceManagerImpl] (Work-Job-Executor-112:ctx-b46df979 job-2738/job-2739 ctx-68467c7a) (logid:337b354e) Command: com.cloud.agent.api.GetDomRVersionCommand failed while starting virtual router 2016-08-29 08:55:42,495 INFO [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-112:ctx-b46df979 job-2738/job-2739 ctx-68467c7a) (logid:337b354e) The guru did not like the answers so stopping VM[DomainRouter|r-233-VM] 2016-08-29 08:55:49,184 INFO [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-5bd7c179) (logid:86c0376e) Begin cleanup expired async-jobs 2016-08-29 08:55:49,192 INFO [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-5bd7c179) (logid:86c0376e) End cleanup expired async-jobs 2016-08-29 08:55:50,861 ERROR [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-112:ctx-b46df979 job-2738/job-2739 ctx-68467c7a) (logid:337b354e) Failed to start instance VM[DomainRouter|r-233-VM] com.cloud.utils.exception.ExecutionException: Unable to start VM:d9dcd37a-242d-43ac-a18e-79a4bfa
[GitHub] cloudstack pull request #1635: CLOUDSTACK-9451
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1635#discussion_r76569173 --- Diff: engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java --- @@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse, @BeanParam DeploymentPlan plan, E boolean stop(String caller) throws ResourceUnavailableException, CloudException; /** + * Stop the virtual machine, optionally force + * + */ +boolean stop(String caller, boolean forced) throws ResourceUnavailableException, CloudException; --- End diff -- @jburwell the `forced` flag has always existed, the `stopVirtualMachine` API accepts this and the query layer too has a method with this signature (https://github.com/apache/cloudstack/pull/1635/files#diff-0a1cd9df984252594918eec5acfed08cR3850) but it does not honour or pass this flag to the layers below, so effectively stopVM API with/without the `forced` flag has the same effect. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1663 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1663 [LTS/blocker] CLOUDSTACK-6432: Prevent DNS reflection attacks CLOUDSTACK-6432: Prevent DNS reflection attacks DNS on VR should not be publically accessible as it may be prone to DNS amplification/reflection attacks. This fixes the issue by only allowing VR DNS (port 53) to be accessible from guest network cidr, as per the fix in: https://issues.apache.org/jira/browse/CLOUDSTACK-6432 - Only allows guest network cidrs to query VR DNS on port 53. - Includes marvin smoke test that checks the VR DNS accessibility checks from guest and non-guest network. - Fixes Marvin sshClient to avoid using ssh agent when password is provided, previous some environments may have seen 'No existing session' exception without this fix. - Adds a new dnspython dependency that is used to perform dns resolutions in the tests. Due to repository commit issues I've created this PR, based on #1653 . /cc @jburwell @karuturi @NuxRo @ustcweizhou @wido and others You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack 4.9-dnsreflection-attack Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1663.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1663 commit 56ad2c83ae2fb8f3cb74df15ed57a35c795ebced Author: Rohit Yadav Date: 2016-08-22T09:31:41Z CLOUDSTACK-6432: Prevent DNS reflection attacks DNS on VR should not be publically accessible as it may be prone to DNS amplification/reflection attacks. This fixes the issue by only allowing VR DNS (port 53) to be accessible from guest network cidr, as per the fix in: https://issues.apache.org/jira/browse/CLOUDSTACK-6432 - Only allows guest network cidrs to query VR DNS on port 53. - Includes marvin smoke test that checks the VR DNS accessibility checks from guest and non-guest network. - Fixes Marvin sshClient to avoid using ssh agent when password is provided, previous some environments may have seen 'No existing session' exception without this fix. - Adds a new dnspython dependency that is used to perform dns resolutions in the tests. Signed-off-by: Rohit Yadav --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo this PR can be closed as we've moved to a new one with a marvin test #1663 Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1653: Prevent DNS reflection attacks
Github user NuxRo closed the pull request at: https://github.com/apache/cloudstack/pull/1653 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS reflectio...
Github user NuxRo commented on the issue: https://github.com/apache/cloudstack/pull/1663 Thanks a lot for implementing this properly :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1623 Yeah. Unfortunately I have not had any time to work on the pull requests lately. When I have time I will reopen it against 4.9. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Jenkins build log has vanished into 404 oblivion. Will see what happened with Travis (https://travis-ci.org/apache/cloudstack/builds/154436801). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1624 Fixes regarding VOLUME_DELETE events resulting from account deletion New version of #1491. **Original Description** New version of #1373, but updated for the 4.7 branch with another fix that allows it to properly find expunged root volumes. This is a bug fix, which is why we target the 4.7 branch. Original pull request: Fixes regarding usage event emission. UsageEventUtils was previously not checking deleted accounts, which meant that if an account was deleted that had some resources running on it, those resources would get destroyed without emitting any events. Furthermore, the VOLUME_DELETE event of ROOT volumes is the responsibility of the UserVmManager, which gets circumvented when expunging resources following the account deletion. Added a check to the AccountManager which catches the ROOT volumes that need to be deleted and emits events for them. To test this: Create a new user. As that user, create and destroy an instance. This should cause the VM_CREATE, VM_START, VM_STOP, VM_DESTROY, VOLUME_CREATE, and VOLUME_DELETE events to be emitted. Create a new instance as the same user. Log in as admin, and delete the user. The same set of events should be emitted, and there should be no duplicate DELETE events for the ROOT volume of the previous instance. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greenqloud/cloudstack pr-volume-usage-events-fixes-4.8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1624.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1624 commit 8009683e67da185bc3e6d630c42b0f614f1eb825 Author: nnesic Date: 2015-10-12T13:15:30Z Emit a VOLUME_DELETE usage event when account deletion destroys an instance. Currently the logic about volume deletion seems to be that an event should be emitted when the volume delete is requested, not when the deletion completes. The VolumeStateListener specifically ignores destroy events for ROOT volumes, assuming that the ROOT volume only gets deleted when the instance is destroyed and the UserVmManager should take care of it. When deleting an account, all of its resources get destroyed, but the instance expunging circumvents the UserVmManager, and thus we miss the VOLUME_DESTROY usage event. Added a check in the AccountManager to emit the deletion event for ROOT volumes belonging to instances which weren't destroyed prior to the account deletion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Have rebased to latest 4.8. Travis build failed with what looks like `Unable to execute /home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql: Unknown column 'state' in 'field list'`. Don't think it's related to this. Will see what happens with the latest 4.8 code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1624 Until #1654 is fixed and merged, all 4.8 will fail due to db upgrade failures. /cc @jburwell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1660 @jburwell I don't have a VMware setup, maybe when we got Trillian back I could have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1618: Now returning os info with the list snapshot ...
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1618#discussion_r76588109 --- Diff: api/src/org/apache/cloudstack/api/response/SnapshotResponse.java --- @@ -199,4 +207,20 @@ public boolean isRevertable() { public void setRevertable(boolean revertable) { this.revertable = revertable; } -} + +public String getOsTypeId() { --- End diff -- The get* methods are not used, please remove. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1606 @leprechau You may add an unit test as well for NetUtils.validateGuestCidr(). Check NetUtilsTest.java, there is already an existing test for 192.168. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1618: Now returning os info with the list snapshot respons...
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1618 Please add/modify Marvin tests based on these scenarios. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1618: Now returning os info with the list snapshot ...
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1618#discussion_r76588305 --- Diff: api/src/org/apache/cloudstack/api/response/SnapshotResponse.java --- @@ -102,6 +102,14 @@ @Param(description = "indicates whether the underlying storage supports reverting the volume to this snapshot") private boolean revertable; +@SerializedName(ApiConstants.OS_TYPE_ID) +@Param(description = "id of the os on volume") --- End diff -- Please add "since" along with the description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1622: Adding missing bits field to TemplateResponse
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1622#discussion_r76588913 --- Diff: api/src/org/apache/cloudstack/api/response/TemplateResponse.java --- @@ -169,6 +169,10 @@ @Param(description = "additional key/value details tied with template") private Map details; +@SerializedName(ApiConstants.BITS) +@Param(description="the processor bit size") --- End diff -- Please add "since" in Param --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1622: Adding missing bits field to TemplateResponse
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1622#discussion_r76589032 --- Diff: api/src/org/apache/cloudstack/api/response/TemplateResponse.java --- @@ -347,4 +351,11 @@ public String getZoneId() { return zoneId; } +public int getBits() { --- End diff -- This is not needed, please remove. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1586: CLOUDSTACK-9410 Data Disk shown as detached in XS
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1586 code change LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1621 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 @jburwell With this PR test_network_acl is successfull [root@ussarlabcsmgt41 Aug_23_2016_16_49_32_8HYYKG]# tail results.txt Test network ACL lists and items in VPC ... === TestName: test_network_acl | Status : SUCCESS === ok Ran 1 test in 211.968s OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1511: 4.9/master bountycastle changes
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1511 ### ACS CI BVT Run **Sumarry:** Build Number 79 Hypervisor xenserver NetworkType Advanced Passed=100 Failed=1 Skipped=3 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_non_contigiousvlan.py * test_extendPhysicalNetworkVlan Failing since 5 runs **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_snapshots.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_ssvm.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: CS 4.9 NIO Selector wait time PR-1601
We have done more investigations. An error happens when the script /usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh is executed: MGMT LOGS: 2016-08-29 16:00:11,342 DEBUG [c.c.a.t.Request] (AgentManager-Handler-12:null) (logid:) Seq 8-1837187172990452475: Processing: { Ans: , MgmtId: 90520741415395, via: 8, Ver: v1, Flags: 10, [{"com.cloud.agent.api.GetRouterAlertsAnswer":{"result":false,"details":"/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh: 1: /usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh: h!/bin/bash: not found","wait":0}}] } 2016-08-29 16:00:11,345 DEBUG [c.c.a.t.Request] (RouterStatusMonitor-1:ctx-9cdc1e33) (logid:5f04bf82) Seq 8-1837187172990452475: Received: { Ans: , MgmtId: 90520741415395, via: 8(kvm702), Ver: v1, Flags: 10, { GetRouterAlertsAnswer } } *2016-08-29 16:00:11,345 DEBUG [c.c.a.m.AgentManagerImpl] (RouterStatusMonitor-1:ctx-9cdc1e33) (logid:5f04bf82) Details from executing class com.cloud.agent.api.routing.GetRouterAlertsCommand: /usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh: 1: /usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh: h!/bin/bash: not found* 2016-08-29 16:00:11,345 WARN [c.c.n.r.VirtualNetworkApplianceManagerImpl] (RouterStatusMonitor-1:ctx-9cdc1e33) (logid:5f04bf82) Unable to get alerts from router r-221-VM /usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh: 1: /usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh: h!/bin/bash: not found 2016-08-29 16:00:11,411 INFO [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-64537bea) (logid:0c5d8104) NetworkGarbageCollector uses '600' seconds for GC interval. 2016-08-29 16:00:11,416 DEBUG [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-64537bea) (logid:0c5d8104) We found network 219 to be free for the first time. Adding it to the list: 1472479211 2016-08-29 16:00:12,392 DEBUG [c.c.s.StatsCollector] (StatsCollector-6:ctx-c1aeb528) (logid:a364cc05) StorageCollector is running... 2016-08-29 16:00:12,403 DEBUG [c.c.h.o.r.Ovm3HypervisorGuru] (StatsCollector-6:ctx-c1aeb528) (logid:a364cc05) getCommandHostDelegation: class com.cloud.agent.api.GetStorageStatsCommand For debugging we modified the "router_proxy.sh" slightly on the KVM Host: kvm# grep -A 2 DEBUG /usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh -n 46:# DEBUG CS Upgrade *47-echo "$(date): ssh -p 3922 -q -o StrictHostKeyChecking=no -i $cert root@$domRIp /opt/cloud/bin/$script $*" >> /tmp/router.txt* 48-ssh -p 3922 -q -o StrictHostKeyChecking=no -i $cert root@$domRIp "/opt/cloud/bin/$script $*" kvm# tail /tmp/router.txt Mon Aug 29 16:10:11 CEST 2016: ssh -p 3922 -q -o StrictHostKeyChecking=no -i /root/.ssh/id_rsa.cloud root@169.254.2.67 /opt/cloud/bin/netusage.sh -g Mon Aug 29 16:10:11 CEST 2016: ssh -p 3922 -q -o StrictHostKeyChecking=no -i /root/.ssh/id_rsa.cloud root@169.254.2.67 /opt/cloud/bin/netusage.sh -g On the router with IP 169.254.2.67 we see the failed logins as well: root@r-221-VM:~# tail -n 2 /var/log/auth.log Aug 29 14:10:11 r-221-VM sshd[7074]: Connection closed by 169.254.0.1 [preauth] Aug 29 14:10:11 r-221-VM sshd[7075]: Connection closed by 169.254.0.1 [preauth] These commands did not succeed. If we execute the command manually we get prompted for the key passphrase. kvm# ssh -p 3922 -o StrictHostKeyChecking=no -i /root/.ssh/id_rsa.cloud root@169.254.2.67 Enter passphrase for key '/root/.ssh/id_rsa.cloud': can someone confirm that the rsa key is protected with a passhrase? this looks suspicious to us... regards martin On 08/29/2016 10:09 AM, martin kolly wrote: > thanks Simon and Rohit for the valuable inputs! After applying the > following procedure the ssl errors are gone and host state is UP. > > # service cloudstack-management stop > > mysql> delete from configuration where name = "ssl.keystore" ; > # mv /etc/cloudstack/management/cloudmanagementserver.keystore > /etc/cloudstack/management/cloudmanagementserver.keystore.old > > # service cloudstack-management start > > # file /etc/cloudstack/management/cloudmanagementserver.keystore > /etc/cloudstack/management/cloudmanagementserver.keystore: Java KeyStore > # file /etc/cloudstack/management/cloudmanagementserver.keystore.old > /etc/cloudstack/management/cloudmanagementserver.keystore.old: data > > #java -version > java version "1.7.0_111" > > However new routers are not deployed, we still see entries that KVM > hosts are unreachable (logs underneath). > > After starting a new router it is shown with "virsh list" on the KVM: > kvm# virsh list | grep r-233-VM > 111 r-233-VM running > > After some seconds the router is deleted, > > kvm# virsh list | grep r-233-VM > # > > kvm#virsh -v > 1.2.2 > > (libvirt was already restarted) > > > > Logs/Info KVM # > > kvm # dpkg -l | grep cloudstack > ii cloudstack-agent > 4.9.0 all
[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1660 @jburwell Commit message amended. Is it ok like this? Yes, it should be ran against VMware. We also made some individual tests for `SshHelper.sshExecute` by adding a test API method which received an host ip and a command to execute on that host, and passed them to `SshHelper.sshExecute`. @serg38 posted results of this tests on [this comment](https://github.com/apache/cloudstack/pull/1660#issuecomment-242061367) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapsho...
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1664 @jburwell I will check with @nitt10prashant on this. Will try to add the tests in PR #1417 to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1511: 4.9/master bountycastle changes
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1511 ### ACS CI BVT Run **Sumarry:** Build Number 81 Hypervisor xenserver NetworkType Advanced Passed=100 Failed=1 Skipped=3 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_non_contigiousvlan.py * test_extendPhysicalNetworkVlan Failing since 6 runs **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_snapshots.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_ssvm.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
PR reviews for 4.10.0 release
Hi All, The Nuage Networks team is investing in ACS 4.10.0 and has several feature PR's outstanding for review : - https://github.com/apache/cloudstack/pull/1578 - https://github.com/apache/cloudstack/pull/1580 - https://github.com/apache/cloudstack/pull/1579 - https://github.com/apache/cloudstack/pull/1577 How can we better facilitate the review of these PR's ? Thanks, - Kris -- Kris Sterckx CloudStack Development Lead Nuage Networks
[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1560 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1511: 4.9/master bountycastle changes
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1511 ### ACS CI BVT Run **Sumarry:** Build Number 82 Hypervisor xenserver NetworkType Advanced Passed=100 Failed=1 Skipped=3 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_non_contigiousvlan.py * test_extendPhysicalNetworkVlan Failing since 7 runs **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_snapshots.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_ssvm.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1560 LGTM (code/logic seems alright, did not run any tests). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1593: CLOUDSTACK-9417: Usage module refactoring
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1593#discussion_r76730939 --- Diff: debian/cloudstack-usage.postinst --- @@ -43,6 +43,10 @@ case "$1" in rm -rf /etc/cloudstack/usage/key ln -s /etc/cloudstack/management/key /etc/cloudstack/usage/key fi + +# Usage cache folder permissions +chmod 0770 /var/cache/cloudstack/usage +chgrp cloud /var/cache/cloudstack/usage --- End diff -- Maybe we can use `debian/cloudstack-usage.dirs` for declaring/making directories? /cc @wido --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1593: CLOUDSTACK-9417: Usage module refactoring
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1593#discussion_r76730973 --- Diff: usage/conf/log4j-cloud_usage.xml.in --- @@ -48,7 +48,7 @@ under the License. - + --- End diff -- Much needed, usage logs never had timestamps. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1593: CLOUDSTACK-9417: Usage module refactoring
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1593#discussion_r76731031 --- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java --- @@ -43,9 +43,9 @@ protected static final int DEFAULT_AGGREGATION_RANGE = 1440; protected StringBuilder errors; protected List checkCases; -protected String lastCheckFile = "/usr/local/libexec/sanity-check-last-id"; +protected String lastCheckFile = "/var/cache/cloudstack/usage/sanity-check-last-id"; --- End diff -- Just a thought, why we store this in a file (on one of the mgmt/usage server hosts) and not in database? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper a...
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1660#discussion_r76731318 --- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java --- @@ -196,6 +198,10 @@ public static void scpTo(String host, int port, String user, File pemKeyFile, St String result = sbResult.toString(); +if (StringUtils.isBlank(result)) { +result = IOUtils.toString(stdout); --- End diff -- Add the default utf8 encoding, what if this throws an exception (IOException)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1660 Minor improvements suggested, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: PR reviews for 4.10.0 release
If you could get 2 LGTMs(any one from your team can also review and give LGTM) and if you can run BVT suite on PR(https://github.com/apache/cloudstack/tree/master/test/integration/smoke), they can be immediately merged. ~ Rajani http://cloudplatform.accelerite.com/ On August 30, 2016 at 3:47 AM, Kris Sterckx (kris.ster...@nuagenetworks.net) wrote: Hi All, The Nuage Networks team is investing in ACS 4.10.0 and has several feature PR's outstanding for review : - https://github.com/apache/cloudstack/pull/1578 - https://github.com/apache/cloudstack/pull/1580 - https://github.com/apache/cloudstack/pull/1579 - https://github.com/apache/cloudstack/pull/1577 How can we better facilitate the review of these PR's ? Thanks, - Kris -- Kris Sterckx CloudStack Development Lead Nuage Networks
[GitHub] cloudstack issue #1654: Updating pom.xml version numbers for release 4.8.2.0...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1654 @rhtyd I have updated this patch to properly support four position version numbers, as well as, remove the requirement that all versions have a ``DbUpgrade`` class defined and/or an upgrade path. Please see the commit message for more information about the scope and reasoning for these changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---