[GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper a...

2016-08-27 Thread nvazquez
Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1660#discussion_r76517779
  
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -195,6 +195,15 @@ public static void scpTo(String host, int port, String 
user, File pemKeyFile, St
 }
 
 String result = sbResult.toString();
+if (result == null || (result != null && result.isEmpty())){
--- End diff --

Done, thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper a...

2016-08-27 Thread nvazquez
Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1660#discussion_r76517786
  
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -195,6 +195,15 @@ public static void scpTo(String host, int port, String 
user, File pemKeyFile, St
 }
 
 String result = sbResult.toString();
+if (result == null || (result != null && result.isEmpty())){
+int stdOutAvailable = stdout.available();
+while (stdOutAvailable != 0){
+currentReadBytes = stdout.read(buffer);
+sbResult.append(new String(buffer, 0, 
currentReadBytes));
+stdOutAvailable = stdout.available();
+}
+result = sbResult.toString();
--- End diff --

Great, didn't know about those utils, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

2016-08-27 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
Thanks @rhtyd @jburwell for reviewing!
@jburwell sure, now PR is targeted to 4.9 branch. Jenkins hadn't started 
properly last time and failed, with last refactor it started properly. I also 
changed commit message, I think it explains the fix, but if not please let me 
know and I'll change it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1664: CLOUDSTACK-8676 Deploy user instance from vm ...

2016-08-27 Thread sateesh-chodapuneedi
GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1664

CLOUDSTACK-8676 Deploy user instance from vm snapshot for VMware hypervisor



Currently, ACS provides the ability to deploy a VM from a template or ISO. 
However, ACS does not provide the ability to deploy a VM(s) directly from a VM 
snapshot.

VM snapshots are stored in the primary storage and have a hierarchical or 
parent/child relationship. The requirement would be to provide the ability to 
deploy user instances from selected VM snapshots. Additionally, any VM snapshot 
in the hierarchy can be deployed concurrently.

Even though this can be supported and applicable to all hypervisors, to 
start with this feature is supported only for VMware hypervisor.

Also this feature supports creation of volume from VM snapshots. Details of 
new APIs added as part of this feature can be found in feature specification 
document below.

Feature specification is at 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Deploy+instance+from+VM+snapshot

There is a separate PR raised by @nitt10prashant  that contains marvin 
tests for this feature.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
deploy-from-snapshot

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1664.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1664


commit 9df51faa8a2f0678e7927ac6ef23752b1eae8f71
Author: rahul singal 
Date:   2016-05-09T11:24:53Z

Marvin script for cloudstack-9365

commit bee2bdc299844e081ef30ccc5de0c2e01b2a0581
Author: Will Stevens 
Date:   2016-05-11T06:03:49Z

Merge pull request #1489 from shapeblue/dynamicroles-master

CLOUDSTACK-8562: Dynamic Role-Based API Checker for CloudStack### 
CLOUDSTACK-8562: DB-Backed Dynamic Role Based API Access Checker

This feature allows root administrators to define new roles and associate 
API
permissions to them.

A limited form of role-based access control for the CloudStack management 
server
API is provided through a properties file, commands.properties, embedded in 
the
WAR distribution. Therefore, customizing API permissions requires unpacking 
the
distribution and modifying this file consistently on all servers. The old 
system
also does not permit the specification of additional roles.

FS:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dynamic+Role+Based+API+Access+Checker+for+CloudStack

DB-Backed Dynamic Role Based API Access Checker for CloudStack brings 
following
changes, features and use-cases:
- Moves the API access definitions from commands.properties to the mgmt 
server DB
- Allows defining custom roles (such as a read-only ROOT admin) beyond the
  current set of four (4) roles
- All roles will resolve to one of the four known roles types (Admin, 
Resource
  Admin, Domain Admin and User) which maintains this association by 
requiring
  all new defined roles to specify a role type.
- Allows changes to roles and API permissions per role at runtime including 
additions or
  removal of roles and/or modifications of permissions, without the need
  of restarting management server(s)

Upgrade/installation notes:
- The feature will be enabled by default for new installations, existing
  deployments will continue to use the older static role based api access 
checker
  with an option to enable this feature
- During fresh installation or upgrade, the upgrade paths will add four 
default
  roles based on the four default role types
- For ease of migration, at the time of upgrade commands.properties will be 
used
  to add existing set of permissions to the default roles. cloud.account
  will have a new role_id column which will be populated based on default 
roles
  as well

Dynamic-roles migration tool: scripts/util/migrate-dynamicroles.py
- Allows admins to migrate to the dynamic role based checker at a future 
date
- Performs a harder one-way migrate and update
- Migrates rules from existing commands.properties file into db and 
deprecates it
- Enables an internal hidden switch to enable dynamic role based checker 
feature

* pr/1489:
  maven: Fix jstl version usage
  CLOUDSTACK-8562: Deprecate commands.properties
  CLOUDSTACK-8562: DB-Backed Dynamic Role Based API Access Checker
  CLOUDSTACK-9361: Centrally handle API validations

Signed-off-by: Will Stevens 

commit dad9e5d86835ccdaa39a3c62047b7fce3a32de6d
Author: Mike Tutkowski 
Date:   2015-08-14T00:44:12Z

CLOUDSTACK-8813: Notify listeners when a host has been added to a cluster, 
is 

[GitHub] cloudstack issue #1417: CLOUDSTACK-9289:Automation for feature deploy vm fro...

2016-08-27 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1417
  
Hi @nitt10prashant / @swill 
Raised PR https://github.com/apache/cloudstack/pull/1664 for parent ticket 
CLOUDSTACK-8676


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapsho...

2016-08-27 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
Target this PR to ACS master branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---