[GitHub] cloudstack issue #872: Strongswan vpn feature
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/872 ### ACS CI BVT Run **Sumarry:** Build Number 209 Hypervisor xenserver NetworkType Advanced Passed=71 Failed=2 Skipped=3 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_vpc_vpn.py * test_01_redundant_vpc_site2site_vpn Failed * test_01_vpc_site2site_vpn Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_routers.py test_reset_vm_on_reboot.py test_snapshots.py test_deploy_vms_with_varied_deploymentplanners.py test_login.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1594#discussion_r67907224
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO vm, final
boolean cleanUpEvenIfUnabl
}
try {
-_networkMgr.release(profile, cleanUpEvenIfUnableToStop);
-s_logger.debug("Successfully released network resources for
the vm " + vm);
+s_logger.debug("Not releasing network resources until expunge
command is sent");
+//_networkMgr.release(profile, cleanUpEvenIfUnableToStop);
+//s_logger.debug("Successfully released network resources for
the vm " + vm);
--- End diff --
Done, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1594#discussion_r67907159
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -2086,6 +2089,18 @@ public boolean expunge(UserVmVO vm, long
callerUserId, Account caller) {
}
}
+/**
+ * Release network resources, it was done on vm stop previously.
+ * @param id vm id
+ * @throws ConcurrentOperationException
+ * @throws ResourceUnavailableException
+ */
+private void releaseNetworkResourcesOnExpunge(long id) throws
ConcurrentOperationException, ResourceUnavailableException {
+final VMInstanceVO vmInstance = _vmDao.findById(id);
--- End diff --
Done, thanks for pointing it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1594#discussion_r67907402
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO vm, final
boolean cleanUpEvenIfUnabl
}
try {
-_networkMgr.release(profile, cleanUpEvenIfUnableToStop);
-s_logger.debug("Successfully released network resources for
the vm " + vm);
+s_logger.debug("Not releasing network resources until expunge
command is sent");
--- End diff --
I decided to remove try-block as it only logged info, and include it on
method's javadoc, as I don't think it could be worth logging. Do you agree?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1594: CLOUDSTACK-9407: vm_network_map table doesnt get cle...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1594 Thanks @jburwell @swill for reviewing! I refactored this PR based on @jburwell comments, it would be nice if it can be included! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1580 @bvbharatk IMHO, above Marvin test failure is not related to the code on this PR. Let me know, if you want us to do any actions from our side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1593: CLOUDSTACK-9417: Usage module refactoring
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1593#discussion_r67938119
--- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java ---
@@ -72,7 +72,9 @@ protected boolean checkItemCountByPstmt(CheckCase
checkCase) throws SQLException
try (PreparedStatement pstmt =
conn.prepareStatement(checkCase.sqlTemplate)) {
if(checkCase.checkId) {
pstmt.setInt(1, lastId);
-pstmt.setInt(2, maxId);
+if (maxId > 0) {
+pstmt.setInt(2, maxId);
+}
--- End diff --
Hi @jburwell, actually when `maxId = -1` parameter is not set to prepared
statement, it is only added when it is found in `readMaxId()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
CS slack channel
Hi, Can someone grant me access to cloudstack slack channel. Cheers, Shiv
Re: CS slack channel
Invitation sent. :) Welcome. On Jun 21, 2016 9:45 PM, "Shiv Gurunathan" wrote: > Hi, > > Can someone grant me access to cloudstack slack channel. > > Cheers, > Shiv >
