[CI] Apache Hardware for CI/QA environment

2016-05-08 Thread Pierre-Luc Dion
Hi,

I've been trying to demystify the urban legend about available hardware
within Apache infrastructure that could be used as Continuous Integration
infrastructure for CloudStack builds.
So far the current status is that Apache have available hardware, few
servers which I don't have details.

Last status: servers are racked and cabled. But the network remain to be
configured and also the remote access (IPMI, vpn,..) for those servers.

Servers are located in USA Oregon.

I've arrass INFRA team last few days to have more information about the
hardware status and how we could help to make those servers available,  but
I got nothing from them so far.

If anyone have details about that hardware or documentation about how it
was supose to be deployed and used I would appreciate to have access to it.

Cheers,

PL


Re: [CI] Apache Hardware for CI/QA environment

2016-05-08 Thread Pierre-Luc Dion
And also, I've just created: INFRA-11829

On Sun, May 8, 2016 at 8:20 AM, Pierre-Luc Dion  wrote:

> Hi,
>
> I've been trying to demystify the urban legend about available hardware
> within Apache infrastructure that could be used as Continuous Integration
> infrastructure for CloudStack builds.
> So far the current status is that Apache have available hardware, few
> servers which I don't have details.
>
> Last status: servers are racked and cabled. But the network remain to be
> configured and also the remote access (IPMI, vpn,..) for those servers.
>
> Servers are located in USA Oregon.
>
> I've arrass INFRA team last few days to have more information about the
> hardware status and how we could help to make those servers available,  but
> I got nothing from them so far.
>
> If anyone have details about that hardware or documentation about how it
> was supose to be deployed and used I would appreciate to have access to it.
>
> Cheers,
>
> PL
>


[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

2016-05-08 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1535#issuecomment-217723457
  
would like to see it on 4.7 first otherwise: LGTM code reviewed and tested

CI result:

only the ping outside wolrd failure, which is not due to any code in this PR


[1535.results.network.txt](https://github.com/apache/cloudstack/files/253957/1535.results.network.txt)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


hidden configuration items revisited

2016-05-08 Thread Nathan Johnson
I would like to get some feedback for a proposed addition of a feature that  
would allow “Hidden” configuration items to be returned from the  
listConfigurations endpoint.

1) There will be a new optional parameter for listConfigurations called  
showhidden .  Defaults to false.  Existing behavior is preserved unless  
showhidden is set to true.

2) There is a now configuration item, com.cloud.allowshowhidden , which  
defaults to false.  This must be set to true in order for showhidden to be  
allowed.  If showhidden=true is passed and com.cloud.allowshowhidden=false,  
an InvalidParameterValueException is thrown.

So the web UI would still hide hidden configuration items regardless of the  
state of com.cloud.allowshowhidden since it will not be passing  
showhidden=true.  The main value of this would be from API implementations  
/ middleware, which is what our front-end talks to instead of directly to  
cloudstack management server.

Obviously there is an explicit reason hidden configuration items are not  
displayed via the API at present.  The Hidden configuration items contain  
some very sensitive data, such as private keys etc.  I would like to submit  
a pull request that would make sense to everyone and still be secure by  
default and not open up pandora’s box so to speak.  I have this working in  
our lab, but I wanted to get a bit of feedback before submitting a PR.

So several questions:

1) Would it make sense for com.cloud.allowshowhidden to be a “Hidden”  
configuration item?  The up side of this is that you could not toggle this  
value from the API.  Marking it hidden means that a rogue root admin api  
key holder could not grant themselves more access.  The down side is that  
I’m not sure how to easily change this value outside of manually going into  
the database and changing it, and one should hope that root admin api key  
holders are well trusted.  Currently I have this implemented as an  
“Advanced” configuration item.

2) I picked com.cloud.allowshowhidden out of my hat.  Is there a more  
appropriate name that I should use?



[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

2016-05-08 Thread ntavares
GitHub user ntavares opened a pull request:

https://github.com/apache/cloudstack/pull/1536

Honour GS use_ext_dns and redundant VR VIP

This patch addresses two issues:

On redundant VR setups, the primary resolver being handed out to instances 
is the guest_ip (primary IP for the VR). This might lead to problems upon 
failover, at least while the DHCP lease doesn't update (because the primary 
resolver will be checked first until times out, however it'll be gone upon 
failover).

If Global Setting use_ext_dns is true, we don't want the VR to be the 
primary resolver at all.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ntavares/cloudstack useextdns_rvmvip47

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1536.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1536


commit c269097a278b9bdf5b9ded457172ce3bf7b707ad
Author: Nuno Tavares 
Date:   2016-05-07T15:56:47Z

This patch addresses two issues:

On redundant VR setups, the primary resolver being handed out to instances 
is the guest_ip (primary IP for the VR). This might lead to problems upon 
failover, at least while the DHCP lease doesn't update (because the primary 
resolver will be checked first until times out, however it'll be gone upon 
failover).

If Global Setting use_ext_dns is true, we don't want the VR to be the 
primary resolver at all.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

2016-05-08 Thread ntavares
Github user ntavares commented on the pull request:

https://github.com/apache/cloudstack/pull/1536#issuecomment-217745413
  
Same as: https://github.com/apache/cloudstack/pull/1535 but for 4.7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

2016-05-08 Thread ntavares
Github user ntavares commented on the pull request:

https://github.com/apache/cloudstack/pull/1535#issuecomment-217745395
  
Here: https://github.com/apache/cloudstack/pull/1536



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

2016-05-08 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1536#issuecomment-217748908
  
@swill can we get this in. It's got 2 LGTM and was integration tested on 
master and monkey tested on 4.7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62441858
  
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -412,6 +428,36 @@ protected void runInContext() {
 }
 }
 
+class HostOutOfBandManagementStatsCollector extends 
ManagedContextRunnable {
+@Override
+protected void runInContext() {
+try {
+s_logger.debug("HostOutOfBandManagementStatsCollector is 
running...");
+List outOfBandManagementHosts = 
outOfBandManagementDao.findAllByManagementServer(ManagementServerNode.getManagementServerId());
+if (outOfBandManagementHosts == null) {
+return;
+}
+for (OutOfBandManagement outOfBandManagementHost : 
outOfBandManagementHosts) {
+Host host = 
_hostDao.findById(outOfBandManagementHost.getHostId());
+if (host == null) {
+continue;
+}
+if 
(outOfBandManagementService.isOutOfBandManagementEnabled(host)) {
+
outOfBandManagementService.submitBackgroundPowerSyncTask(host);
+} else {
+if (outOfBandManagementHost.getPowerState() != 
OutOfBandManagement.PowerState.Disabled) {
+if 
(outOfBandManagementService.transitionPowerStateToDisabled(Collections.singletonList(host)))
 {
--- End diff --

Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62441896
  
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -412,6 +428,36 @@ protected void runInContext() {
 }
 }
 
+class HostOutOfBandManagementStatsCollector extends 
ManagedContextRunnable {
+@Override
+protected void runInContext() {
+try {
+s_logger.debug("HostOutOfBandManagementStatsCollector is 
running...");
+List outOfBandManagementHosts = 
outOfBandManagementDao.findAllByManagementServer(ManagementServerNode.getManagementServerId());
+if (outOfBandManagementHosts == null) {
+return;
+}
+for (OutOfBandManagement outOfBandManagementHost : 
outOfBandManagementHosts) {
+Host host = 
_hostDao.findById(outOfBandManagementHost.getHostId());
+if (host == null) {
+continue;
+}
+if 
(outOfBandManagementService.isOutOfBandManagementEnabled(host)) {
+
outOfBandManagementService.submitBackgroundPowerSyncTask(host);
+} else {
+if (outOfBandManagementHost.getPowerState() != 
OutOfBandManagement.PowerState.Disabled) {
+if 
(outOfBandManagementService.transitionPowerStateToDisabled(Collections.singletonList(host)))
 {
+s_logger.debug("Out-of-band management was 
disabled in zone/cluster/host, disabled power state for host id:" + 
host.getId());
--- End diff --

Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62442087
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,111 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.List;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private String stdOutput;
+private String stdError;
+private int returnCode = -1;
+
+public String getStdOutput() {
+return stdOutput;
+}
+
+public void setStdOutput(String stdOutput) {
+this.stdOutput = stdOutput;
+}
+
+public String getStdError() {
+return stdError;
+}
+
+public void setStdError(String stdError) {
+this.stdError = stdError;
+}
+
+public int getReturnCode() {
+return returnCode;
+}
+
+public void setReturnCode(int returnCode) {
+this.returnCode = returnCode;
+}
+
+public static ProcessRunner executeCommands(List commands, 
long timeOutSeconds) {
--- End diff --

Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62442464
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,111 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.List;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private String stdOutput;
+private String stdError;
+private int returnCode = -1;
--- End diff --

Fixed, made members final.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62444371
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,111 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.List;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private String stdOutput;
+private String stdError;
+private int returnCode = -1;
+
+public String getStdOutput() {
+return stdOutput;
+}
+
+public void setStdOutput(String stdOutput) {
+this.stdOutput = stdOutput;
+}
+
+public String getStdError() {
+return stdError;
+}
+
+public void setStdError(String stdError) {
+this.stdError = stdError;
+}
+
+public int getReturnCode() {
+return returnCode;
+}
+
+public void setReturnCode(int returnCode) {
+this.returnCode = returnCode;
+}
+
+public static ProcessRunner executeCommands(List commands, 
long timeOutSeconds) {
+ProcessRunner result = new ProcessRunner();
+try {
+Process process = new 
ProcessBuilder().command(commands).start();
+StreamGobbler stdInputGobbler = new 
StreamGobbler(process.getInputStream());
+StreamGobbler stdErrorGobbler = new 
StreamGobbler(process.getErrorStream());
+stdInputGobbler.start();
+stdErrorGobbler.start();
+
+if (timeOutSeconds > 0) {
+ProcessWaitForThread worker = new 
ProcessWaitForThread(process);
--- End diff --

Removed use of this idiom, instead using Future and .get(timeout, ...).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r6206
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,111 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import org.apache.log4j.Logger;
+
+import java.io.IOException;
+import java.util.List;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private String stdOutput;
+private String stdError;
+private int returnCode = -1;
+
+public String getStdOutput() {
+return stdOutput;
+}
+
+public void setStdOutput(String stdOutput) {
+this.stdOutput = stdOutput;
+}
+
+public String getStdError() {
+return stdError;
+}
+
+public void setStdError(String stdError) {
+this.stdError = stdError;
+}
+
+public int getReturnCode() {
+return returnCode;
+}
+
+public void setReturnCode(int returnCode) {
+this.returnCode = returnCode;
+}
+
+public static ProcessRunner executeCommands(List commands, 
long timeOutSeconds) {
+ProcessRunner result = new ProcessRunner();
+try {
+Process process = new 
ProcessBuilder().command(commands).start();
+StreamGobbler stdInputGobbler = new 
StreamGobbler(process.getInputStream());
+StreamGobbler stdErrorGobbler = new 
StreamGobbler(process.getErrorStream());
--- End diff --

inheritIO is not useful here as we want to capture the input/output stream 
in stdErr and stdOut. Using future and a cache thread pool executor, I've 
removed the explicit use of a stream gobbler here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Removed Unused Void Class

2016-05-08 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1440#issuecomment-217771635
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 9h 08m 44s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_22_48_R3H25Y:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_22_48_R3H25Y/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_22_48_R3H25Y/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_22_48_R3H25Y/runinfo.txt)

**`/tmp/MarvinLogs/test_network_MSZ3SB:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_network_MSZ3SB/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_network_MSZ3SB/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_network_MSZ3SB/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_32L4E9:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_vpc_routers_32L4E9/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_vpc_routers_32L4E9/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_vpc_routers_32L4E9/runinfo.txt)


Uploads will be available until `2016-07-09 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-08 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1428#issuecomment-217771948
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 2
   Errors: 0
 Duration: 9h 09m 47s
```

**Summary of the problem(s):**
```
FAIL: Test redundant router internals
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", 
line 483, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
"Attempt to retrieve google.com index page should be successful once 
rule is added!"
AssertionError: Attempt to retrieve google.com index page should be 
successful once rule is added!
--
Additional details in: /tmp/MarvinLogs/test_network_7L4ZQC/results.txt
```

```
FAIL: test_04_rvpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
277, in test_04_rvpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
324, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, vm2.nic[0].ipaddress)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
559, in check_pvt_gw_connectivity
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_network_7L4ZQC/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_10_28_C71Y5A:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1428/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_10_28_C71Y5A/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1428/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_10_28_C71Y5A/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1428/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_10_28_C71Y5A/runinfo.txt)

**`/tmp/MarvinLogs/test_network_7L4ZQC:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1428/tmp/MarvinLogs/test_network_7L4ZQC/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1428/tmp/MarvinLogs/test_network_7L4ZQC/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1428/tmp/MarvinLogs/test_network_7L4ZQC/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_RRH1O6:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1428/tmp/MarvinLogs/test_vpc_routers_RRH1O6/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1428/tmp/MarvinLogs/test_vpc_routers_RRH1O6/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1428/tmp/MarvinLogs/test_vpc_routers_RRH1O6/runinfo.txt)


Uploads will be available until `2016-07-09 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

2016-05-08 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1496#issuecomment-217772228
  


### CI RESULTS

```
Tests Run: 88
  Skipped: 2
   Failed: 1
   Errors: 1
 Duration: 11h 25m 09s
```

**Summary of the problem(s):**
```
ERROR: Test to verify access to loadbalancer haproxy admin stats page
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
854, in tearDown
raise Exception("Cleanup failed with %s" % e)
Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created : 
u'2016-05-07T12:50:26+0200', jobresult : {errorcode : 530, errortext : u'Failed 
to delete network'}, cmd : 
u'org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd', userid : 
u'b90ec272-1410-11e6-9152-5254001daa61', jobstatus : 2, jobid : 
u'04de60c8-0aa7-4488-a076-a7475b147b47', jobresultcode : 530, jobresulttype : 
u'object', jobinstancetype : u'Network', accountid : 
u'b90e9c7d-1410-11e6-9152-5254001daa61'}
--
Additional details in: /tmp/MarvinLogs/test_network_9UCT1L/results.txt
```

```
FAIL: Test create, assign, remove of an Internal LB with roundrobin http 
traffic to 3 vm's in a Single VPC
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
599, in test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
self.execute_internallb_roundrobin_tests(vpc_offering)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
668, in execute_internallb_roundrobin_tests
self.setup_http_daemon(vm)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
519, in setup_http_daemon
self.fail("Failed to ssh into vm: %s due to %s" % (vm, e))
AssertionError: Failed to ssh into vm:  due to not all arguments converted during string 
formatting
--
Additional details in: /tmp/MarvinLogs/test_network_9UCT1L/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_03_57_IONYWP:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_03_57_IONYWP/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_03_57_IONYWP/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_03_57_IONYWP/runinfo.txt)

**`/tmp/MarvinLogs/test_host_ha_XQC3Z6:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/test_host_ha_XQC3Z6/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/test_host_ha_XQC3Z6/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/test_host_ha_XQC3Z6/runinfo.txt)

**`/tmp/MarvinLogs/test_network_9UCT1L:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/test_network_9UCT1L/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/test_network_9UCT1L/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/test_network_9UCT1L/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_UTADLF:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/test_vpc_routers_UTADLF/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/test_vpc_routers_UTADLF/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1496/tmp/MarvinLogs/test_vpc_routers_UTADLF/runinfo.txt)


Uploads will be available until `2016-07-09 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infr

[GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...

2016-05-08 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1529#issuecomment-217772487
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 2
   Errors: 1
 Duration: 10h 39m 56s
```

**Summary of the problem(s):**
```
ERROR: Test to verify access to loadbalancer haproxy admin stats page
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
854, in tearDown
raise Exception("Cleanup failed with %s" % e)
Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created : 
u'2016-05-07T12:42:29+0200', jobresult : {errorcode : 530, errortext : u'Failed 
to delete network'}, cmd : 
u'org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd', userid : 
u'31f149c9-1410-11e6-9280-5254001daa61', jobstatus : 2, jobid : 
u'0020223d-d484-443c-800e-9ee1e716ee7a', jobresultcode : 530, jobresulttype : 
u'object', jobinstancetype : u'Network', accountid : 
u'31f12b92-1410-11e6-9280-5254001daa61'}
--
Additional details in: /tmp/MarvinLogs/test_network_44MNJ7/results.txt
```

```
FAIL: test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
253, in test_02_vpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
324, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, vm2.nic[0].ipaddress)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
559, in check_pvt_gw_connectivity
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_network_44MNJ7/results.txt
```

```
FAIL: Test destroy(expunge) Virtual Machine
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 
646, in test_09_expunge_vm
self.assertEqual(list_vm_response,None,"Check Expunged virtual machine 
is in listVirtualMachines response")
AssertionError: Check Expunged virtual machine is in listVirtualMachines 
response
--
Additional details in: /tmp/MarvinLogs/test_vpc_routers_BJDKJO/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_00_21_EJXJA1:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1529/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_00_21_EJXJA1/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1529/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_00_21_EJXJA1/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1529/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_00_21_EJXJA1/runinfo.txt)

**`/tmp/MarvinLogs/test_network_44MNJ7:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1529/tmp/MarvinLogs/test_network_44MNJ7/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1529/tmp/MarvinLogs/test_network_44MNJ7/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1529/tmp/MarvinLogs/test_network_44MNJ7/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_BJDKJO:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1529/tmp/MarvinLogs/test_vpc_routers_BJDKJO/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1529/tmp/MarvinLogs/test_vpc_routers_BJDKJO/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1529/tmp/MarvinLogs/test_vpc_routers_BJDKJO/runinfo.txt)


Uploads will be available until `2016-07-09 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

2016-05-08 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1471#issuecomment-217773715
  
@remibergsma can you review @jburwell's comment and follow up in this 
thread?  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-08 Thread rhtyd
Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-217774436
  
@swill thanks, let's merge this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...

2016-05-08 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1488#issuecomment-217773917
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 1
   Errors: 0
 Duration: 4h 33m 33s
```

**Summary of the problem(s):**
```
FAIL: Test redundant router internals
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/smoke/test_routers_network_ops.py", 
line 290, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
"Attempt to retrieve google.com index page should be successful!"
AssertionError: Attempt to retrieve google.com index page should be 
successful!
--
Additional details in: /tmp/MarvinLogs/test_network_ZPKO7W/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_23_46_2X8SE4:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_23_46_2X8SE4/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_23_46_2X8SE4/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_23_46_2X8SE4/runinfo.txt)

**`/tmp/MarvinLogs/test_network_ZPKO7W:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_network_ZPKO7W/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_network_ZPKO7W/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_network_ZPKO7W/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_6GSXPB:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_vpc_routers_6GSXPB/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_vpc_routers_6GSXPB/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_vpc_routers_6GSXPB/runinfo.txt)


Uploads will be available until `2016-07-09 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1502#issuecomment-217775304
  
@jburwell I've fixed the outstanding issues, please re-review and suggest 
any other improvement or LGTM. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: hidden configuration items

2016-05-08 Thread Anshul Gangwar
I didn’t get  how will you use that info to connect? 

There are three connections involved in showing console to user. 

ms ——authenticate—> CPVM ——for VNC console—>Hypervisor
^
| gets images from CPVM
web  browser

Which of the above components you want to keep and which to remove?

Also you can look into other implementations of Console proxy which are rarely 
used to get more info.

Regards,
Anshul



> On 07-May-2016, at 11:39 AM, Nathan Johnson  wrote:
> 
> If you hit the /client/console endpoint with a vmid, it sends you back some  
> data that contains a link to a the console proxy VM and passes an encrypted  
> json payload that has the user, password and port for a vnc connection.   
> Normally this is meant to load in an iframe.  We want to decrypt this  
> response to direct a VNC client to the appropriate host / port / user /  
> pass and bypass use of the console proxy VM.  The key and iv appear to be  
> stored in the configuration table under the names security.encryption.key  
> and security.encryption.iv, but as they are hidden we cannot get these  
> credentials via the listConfigurations endpoint as-is.  So my question is:
> 
> What would be the most appropriate way to open up the possibility of  
> showing “hidden” configuration items via this API to our middleware?  Some  
> sort of entry in a config file somewhere?  An entry in the configuration  
> table itself?  Or is there some other way to get this information I’m  
> looking for?
> 
> Thanks in advance.
> 
> Nathan




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


RE: hidden configuration items revisited

2016-05-08 Thread Kishan Kavala
Nathan,
  You can use "Secure" category instead of "Hidden". Config items with "Secure" 
category are encrypted and also included in listConfigurations API response. 

~kishan

-Original Message-
From: Nathan Johnson [mailto:njohn...@ena.com] 
Sent: 08 May 2016 22:01
To: dev@cloudstack.apache.org
Subject: hidden configuration items revisited

I would like to get some feedback for a proposed addition of a feature that 
would allow “Hidden” configuration items to be returned from the 
listConfigurations endpoint.

1) There will be a new optional parameter for listConfigurations called 
showhidden .  Defaults to false.  Existing behavior is preserved unless 
showhidden is set to true.

2) There is a now configuration item, com.cloud.allowshowhidden , which 
defaults to false.  This must be set to true in order for showhidden to be 
allowed.  If showhidden=true is passed and com.cloud.allowshowhidden=false, an 
InvalidParameterValueException is thrown.

So the web UI would still hide hidden configuration items regardless of the 
state of com.cloud.allowshowhidden since it will not be passing 
showhidden=true.  The main value of this would be from API implementations / 
middleware, which is what our front-end talks to instead of directly to 
cloudstack management server.

Obviously there is an explicit reason hidden configuration items are not 
displayed via the API at present.  The Hidden configuration items contain some 
very sensitive data, such as private keys etc.  I would like to submit a pull 
request that would make sense to everyone and still be secure by default and 
not open up pandora’s box so to speak.  I have this working in our lab, but I 
wanted to get a bit of feedback before submitting a PR.

So several questions:

1) Would it make sense for com.cloud.allowshowhidden to be a “Hidden”  
configuration item?  The up side of this is that you could not toggle this 
value from the API.  Marking it hidden means that a rogue root admin api key 
holder could not grant themselves more access.  The down side is that I’m not 
sure how to easily change this value outside of manually going into the 
database and changing it, and one should hope that root admin api key holders 
are well trusted.  Currently I have this implemented as an “Advanced” 
configuration item.

2) I picked com.cloud.allowshowhidden out of my hat.  Is there a more 
appropriate name that I should use?




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-08 Thread marcaurele
Github user marcaurele commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1532#discussion_r62453258
  
--- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java ---
@@ -969,7 +969,12 @@ public T findByUuidIncludingRemoved(final String uuid) 
{
 @Override
 @DB()
 public T findByIdIncludingRemoved(ID id) {
-return findById(id, true, null);
+if (_cache != null) {
+final Element element = _cache.get(id);
+return element == null ? findById(id, true, null) : 
(T)element.getObjectValue();
+} else {
--- End diff --

The test for the existence of the cache is made on other lines in this 
class, so I kept it. My change is to use the cached value if there is one, as 
it wasn't the case before.
The function looks pretty much the same as the `findById` (line 944).

@DaanHoogland in your last code sample, on the first line you go first to 
the DB to retrieve the object. Then if the cache isn't null, you fetch the 
value from the cache and discard the one you just got. IMO it's a downgrade in 
terms of performance as you never use directly the value in cache but always do 
a query against the DB.

@jburwell I could change the code as you're suggesting, but then the 
exception should be raised at other places too to keep the code consistent when 
the cache isn't configured, which wasn't my initial goal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-05-08 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-217789291
  
@nvazquez The test results show that it took ~20mins to complete. Why list 
tests are taking so long?
Some observations:
- Tests are not tagged, please tag them (refer to existing tests). I ran 
them in a simulator setup and they passed so these can be added to Travis once 
the overall time is reduced and proper tags added
- Templates created as part of tests is not cleaned up.
- time.sleep(720). I saw the comment about vm snapshot issue, better to 
disable the vm snapshot test and enable it once snapshot issue is fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---