[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-216130431 @cristofolini, @alexandrelimassantana, I've extracted the internal loop logic to a separate method and I've added a unit test for this behavior. This logic couldn't be implemented in the Nic class itself since this just a model class and shouldn't contain any logic :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-216185039 tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: This branch implements the CSV and native...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-216185699 @anshul1886 please re-base against latest master, update on current status of your work/PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/540#issuecomment-216185889 tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/384#issuecomment-216185839 @pritisarap12 please rebase against latest master and share status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8599. CS reports failure for a...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/544#issuecomment-216185962 tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8609. [VMware] VM is not acces...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/556#issuecomment-216186028 tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8608. System VM's failed to st...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/555#issuecomment-216186000 tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Cloudstack 8612
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/562#issuecomment-216186055 tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Made the adding new keyboard language sup...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/669#issuecomment-216186163 @anshul1886 please rebase against latest master and share status of your PR This looks like an interesting PR we should have --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Allow VM snapshots and volume snapshots t...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/672#issuecomment-216186265 @anshul1886 please rebase against latest master and share status of your PR; also please update on outstanding comments from other reviewers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Browser Based Volume and Template Upload ...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/710#discussion_r61722909
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -1545,38 +1544,64 @@
"url": "http://10.147.28.7/templates/rajani-thin-volume.qcow2";,
"checksum": "02de0576dd3a61ab59c03fd795fc86ac",
},
+ "TAR": {
+"diskname": "LXCUploadVol",
+"url": "http://10.147.28.7/templates/lxc/rhel63_x64.tar.gz";,
+"checksum": "aa29a468bd77aba6c723af4db61c734a",
+},
'browser_resized_disk_offering': {
"displaytext": "Resizeddisk",
"name": "Resizeddisk",
"disksize": 3,
}
},
+"browser_upload_volume_extended":{
+ "VHD": {
+"diskname": "XenUploadVol",
+"url":
"http://10.147.28.7/templates/builtin/centos56-x86_64.vhd.bz2";,
+"checksum": "09b08b6abb1b903fca7711d3ac8d6598",
+},
+ "QCOW2": {
+"diskname": "KVMUploadVol",
+"url":
"http://10.147.28.7/templates/builtin/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2";,
+"checksum": "02de0576dd3a61ab59c03fd795fc86ac",
+},
+},
"browser_upload_template": {
"VHD": {
"templatename": "XenUploadtemplate",
"displaytext": "XenUploadtemplate",
"url":
"http://10.147.28.7/templates/builtin/centos56-x86_64.vhd.bz2";,
"hypervisor":"XenServer",
"checksum": "09b08b6abb1b903fca7711d3ac8d6598",
-"ostypeid":"74affaea-c658-11e4-ad38-a6d1374244b4"
+"ostypeid":"142"
},
"OVA": {
"templatename": "VMwareUploadtemplate",
"displaytext": "VMwareUploadtemplate",
"url":
"http://nfs1.lab.vmops.com/templates/vmware/CentOS5.3-x86_64.ova";,
"checksum": "02de0576dd3a61ab59c03fd795fc86ac",
"hypervisor":"VMware",
-"ostypeid":"74affaea-c658-11e4-ad38-a6d1374244b4"
+"ostypeid":"142"
},
"QCOW2": {
"templatename": "KVMUploadtemplate",
-"displaytext": "VMwareUploadtemplate",
+"displaytext": "KVMUploadtemplate",
"url":
"http://10.147.28.7/templates/builtin/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2";,
--- End diff --
please use a public template/url
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Browser Based Volume and Template Upload ...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/710#discussion_r61722942
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -1545,38 +1544,64 @@
"url": "http://10.147.28.7/templates/rajani-thin-volume.qcow2";,
"checksum": "02de0576dd3a61ab59c03fd795fc86ac",
},
+ "TAR": {
+"diskname": "LXCUploadVol",
+"url": "http://10.147.28.7/templates/lxc/rhel63_x64.tar.gz";,
+"checksum": "aa29a468bd77aba6c723af4db61c734a",
+},
'browser_resized_disk_offering': {
"displaytext": "Resizeddisk",
"name": "Resizeddisk",
"disksize": 3,
}
},
+"browser_upload_volume_extended":{
+ "VHD": {
+"diskname": "XenUploadVol",
+"url":
"http://10.147.28.7/templates/builtin/centos56-x86_64.vhd.bz2";,
--- End diff --
use a public url
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Browser Based Volume and Template Upload ...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/710#discussion_r61722912
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -1545,38 +1544,64 @@
"url": "http://10.147.28.7/templates/rajani-thin-volume.qcow2";,
"checksum": "02de0576dd3a61ab59c03fd795fc86ac",
},
+ "TAR": {
+"diskname": "LXCUploadVol",
+"url": "http://10.147.28.7/templates/lxc/rhel63_x64.tar.gz";,
+"checksum": "aa29a468bd77aba6c723af4db61c734a",
+},
'browser_resized_disk_offering': {
"displaytext": "Resizeddisk",
"name": "Resizeddisk",
"disksize": 3,
}
},
+"browser_upload_volume_extended":{
+ "VHD": {
+"diskname": "XenUploadVol",
+"url":
"http://10.147.28.7/templates/builtin/centos56-x86_64.vhd.bz2";,
+"checksum": "09b08b6abb1b903fca7711d3ac8d6598",
+},
+ "QCOW2": {
+"diskname": "KVMUploadVol",
+"url":
"http://10.147.28.7/templates/builtin/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2";,
+"checksum": "02de0576dd3a61ab59c03fd795fc86ac",
+},
+},
"browser_upload_template": {
"VHD": {
"templatename": "XenUploadtemplate",
"displaytext": "XenUploadtemplate",
"url":
"http://10.147.28.7/templates/builtin/centos56-x86_64.vhd.bz2";,
"hypervisor":"XenServer",
"checksum": "09b08b6abb1b903fca7711d3ac8d6598",
-"ostypeid":"74affaea-c658-11e4-ad38-a6d1374244b4"
+"ostypeid":"142"
},
"OVA": {
"templatename": "VMwareUploadtemplate",
"displaytext": "VMwareUploadtemplate",
"url":
"http://nfs1.lab.vmops.com/templates/vmware/CentOS5.3-x86_64.ova";,
"checksum": "02de0576dd3a61ab59c03fd795fc86ac",
"hypervisor":"VMware",
-"ostypeid":"74affaea-c658-11e4-ad38-a6d1374244b4"
+"ostypeid":"142"
},
"QCOW2": {
"templatename": "KVMUploadtemplate",
-"displaytext": "VMwareUploadtemplate",
+"displaytext": "KVMUploadtemplate",
"url":
"http://10.147.28.7/templates/builtin/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2";,
-"checksum": "da997b697feaa2f1f6e0d4785b0cece2",
+"checksum": "d06b5f6a-d44e-11e4-9d99-4af3a393b3ac",
"hypervisor":"KVM",
-"ostypeid":"2e02e376-cdf3-11e4-beb3-8aa6272b57ef"
+"ostypeid":"142"
+},
+ "TAR": {
+"templatename": "LXCUploadtemplate",
+"displaytext": "LXCUploadtemplate",
+"url": "http://10.147.28.7/templates/lxc/rhel63_x64.tar.gz";,
--- End diff --
please use a public template/url
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Browser Based Volume and Template Upload ...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/710#discussion_r61722946
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -1545,38 +1544,64 @@
"url": "http://10.147.28.7/templates/rajani-thin-volume.qcow2";,
"checksum": "02de0576dd3a61ab59c03fd795fc86ac",
},
+ "TAR": {
+"diskname": "LXCUploadVol",
+"url": "http://10.147.28.7/templates/lxc/rhel63_x64.tar.gz";,
--- End diff --
use a public url
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Browser Based Volume and Template Upload ...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/710#discussion_r61722935
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -1545,38 +1544,64 @@
"url": "http://10.147.28.7/templates/rajani-thin-volume.qcow2";,
"checksum": "02de0576dd3a61ab59c03fd795fc86ac",
},
+ "TAR": {
+"diskname": "LXCUploadVol",
+"url": "http://10.147.28.7/templates/lxc/rhel63_x64.tar.gz";,
+"checksum": "aa29a468bd77aba6c723af4db61c734a",
+},
'browser_resized_disk_offering': {
"displaytext": "Resizeddisk",
"name": "Resizeddisk",
"disksize": 3,
}
},
+"browser_upload_volume_extended":{
+ "VHD": {
+"diskname": "XenUploadVol",
+"url":
"http://10.147.28.7/templates/builtin/centos56-x86_64.vhd.bz2";,
+"checksum": "09b08b6abb1b903fca7711d3ac8d6598",
+},
+ "QCOW2": {
+"diskname": "KVMUploadVol",
+"url":
"http://10.147.28.7/templates/builtin/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2";,
--- End diff --
use a public url
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Browser Based Volume and Template Upload ...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/710#issuecomment-216186541 @sailajamada please rebase against latest master and share status of your PR Please update your test to use public URL in the test data and advise if we can use it against simulator so the test can be included to be run with Travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/756#issuecomment-216187288 @nlivens please rebase against latest master and push -f LGTM, the removed code (publicLoadBalancerProvider key) is not referenced in any of the actions or dataProviders to create and send the `data` payload tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Embedded Tomcat & Jetty
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-216187512 tag:pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-216188309 @rajesh-battala please rebase against latest master and update on status of the PR LGTM, cc @swill tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/793#issuecomment-216188660 @anshul1886 please rebase against latest master and push -f, update on status of your PR Can you add unit test for the changes, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/803#issuecomment-216189015 @anshul1886 please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8829 : Consecutive cold migrat...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/797#issuecomment-216188749 @maneesha-p please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8830 - [Vmware] VM snapshot fa...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/798#issuecomment-21613 @maneesha-p please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-216189432 @sanju1010 please rebase against latest master and push -f, update on status of your PR This is baremetal specific test, how do I test it; the resources/urls mentioned in your cfg are specific to some private network, in which case the PR test-data is unacceptable if no-one else can run your test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-216189486 @priyankparihar please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Notify listeners when a host has been add...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-216189633 @mike-tutkowski please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8849: Usage job should...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/827#issuecomment-216189896 @yvsubhash please rebase against latest master and push -f, update on status of your PR We'll need more information on why we should ignore/stop usage generation, in case we don't handle exception this will not generate usage for other kinds of resources --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/828#issuecomment-216190037 tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/828#issuecomment-216190007 @sureshanaparti please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-216190239 @bvbharat please rebase against latest master and push -f, update on status of your PR also, how do we test your changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8857 listProjects doesn't retu...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/838#issuecomment-216190449 LGTM, @bvbharatk can you rebase your branch and push -f against latest master tag:easypr cc @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1503#discussion_r61723859
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -264,10 +266,11 @@ public void handleAsyncJobPublishEvent(String
subject, String senderAddress, Obj
String info = job.getCmdInfo();
String cmdEventType = "unknown";
if (info != null) {
-String marker = "\"cmdEventType\"";
-int begin = info.indexOf(marker);
-if (begin >= 0) {
-cmdEventType = info.substring(begin + marker.length() + 2,
info.indexOf(",", begin) - 1);
+Type type = new TypeToken>(){}.getType();
+Map cmdInfo =
ApiGsonHelper.getBuilder().create().fromJson(info, type);
--- End diff --
is this Object necessary as the mapped type? Couldn't it be String
directly? If you are using the api solely for collecting the cmdEventType, you
could build the objects as String already and the typecheck on line 272 would
be unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Security group ingress/egress issues with...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/843#issuecomment-216190725 @jayapalu please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-216190807 @ustcweizhou please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Security group ingress/egress issues with...
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/843#discussion_r61723868 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -356,18 +356,25 @@ def allow_egress_traffic(session): return 'false' return 'true' +def getIpsetType(): +try: +util.pread2(['/bin/bash', '-c', "ipset -v | grep 'protocol version: 6'"]) +return 'nethash' --- End diff -- what is the protocol version is 6, how about we test if it's less than 6 we fallback on iptreemap otherwise use the netmask type --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/846#discussion_r61724005
--- Diff: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java ---
@@ -1087,4 +1087,11 @@ public HostVO findByPublicIp(String publicIp) {
sc.addAnd("dataCenterId", SearchCriteria.Op.EQ, zoneId);
return customSearch(sc, null);
}
+
+@Override
+public List listByType(Host.Type type) {
+SearchCriteria sc = TypeSearch.create();
+sc.setParameters("type", type);
+return listBy(sc);
--- End diff --
the listByType consumers are not doing != null checks, we can fix it by
doing it here and returning a Collections.emptyList(); this way the methods
ensures that no null is returned
Please fix the NPE case, otherwise LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/846#issuecomment-216191410 @kishankavala please rebase against latest master and push -f, update on status of your PR I've left a NPE check, we should merge it once you fix that. Thanks. tag:easypr cc @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8880: calculate free m...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/847#issuecomment-216191524 @kishankavala please rebase against latest master and push -f, update on status of your PR tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8886: Limitations is listUsage...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/858#issuecomment-216191628 @kansal please rebase against latest master and push -f, update on status of your PR tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8882: calculate networ...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/859#issuecomment-216191763 @kishankavala please rebase against latest master and push -f, update on status of your PR tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-7151: Support multiple physica...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/862#issuecomment-216192713 @sureshanaparti please rebase against latest master, squash your commits into one and push -f, update on status of your PR tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...
Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-216192751 That seems fair... But I think you could make 3 unit tests instead of 1 so each one would have only 1 assert and only one behavior each. Other than that it all looks fine. As Daan said, the code seems sane and the tests prove it's functionality. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8856 Primary Storage Used(type...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/865#issuecomment-216192785 @bvbharatk please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-216192973 @bvbharatk please rebase against latest master and push -f, update on status of your PR please move the sql changes to 481-490 upgrade path tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8894: Restrict vGPU enabled VM...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/868#issuecomment-216193049 @anshul1886 please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Strongswan vpn feature
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-216193434 @jayapalu please rebase against latest master and push -f, update on status of your PR. Please also squash merge your changes into a single commit. In general, LGTM though I've not tested this. Let's try to get it fixed/merged before 4.9, this is much needed and has been standing for long. pr:needlove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/873#issuecomment-216193641 @karuturi please rebase against latest master and push -f, update on status of your PR LGTM tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8897: baremetal:addHost:make h...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/874#issuecomment-216193842 @harikrishna-patnala please rebase against latest master and push -f, update on status of your PR LGTM tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8865: Adding SR doesn't create...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/876#issuecomment-216194398 @SudharmaJain sorry but can you again please rebase against latest master and push -f, update on status of your PR I would suggest you can add a marvin test that can be verified against Travis (simulator/mysql) that is more realistic than writing a unit test that mocks tcp stack and/or mysql server --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-216194476 LGTM tag:easypr Cc @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-216194579 tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8910: The reserved_capacity fi...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/892#issuecomment-216194837 LGTM, @SudharmaJain can you rebase against master again -- we want to have Travis pass tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/896#issuecomment-216194918 @yvsubhash please rebase against latest master and push -f, update on status of your PR tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-8921
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/899#issuecomment-216195030 @yvsubhash please rebase against latest master and push -f, update on status of your PR; please squash changes into single commit tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8931: Fail to deploy VM instan...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/907#issuecomment-216195490 @kansal please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8922: Unable to delete...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/905#issuecomment-216195355 @yvsubhash please rebase against latest master and push -f, update on status of your PR; please add a marvin test that can validate the fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: BUG-ID CLOUDSTACK-8939
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/914#issuecomment-216195564 @yvsubhash please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8944 Template download possibl...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/921#issuecomment-216195606 @yvsubhash please rebase against latest master and push -f, update on status of your PR tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1037#issuecomment-216195896 @atrbgithub please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-7984: Collect network st...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/926#issuecomment-216196724 @ustcweizhou please rebase against latest master and push -f, update on status of your PR; also squash changes to a single commit tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8910: The reserved_capacity fi...
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/892#issuecomment-216196848 @rhtyd Rebased again master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8950 Hypervisor Paramete...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/928#issuecomment-216197872 @karuturi please rebase against master and push -f, and update on status of your PR, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] secure and hidden config values are...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/927#issuecomment-216197677 @karuturi please rebase against latest master LGTM tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8959: Option to attach the con...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/938#issuecomment-216198287 @kansal please rebase against master and push -f, and update on status of your PR, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8969 VPN customer gateway can'...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/955#issuecomment-216198487 @SudharmaJain please rebase against master and push -f, and update on status of your PR, thanks LGTM tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8959: Option to attach the con...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/938#discussion_r61725650
--- Diff: engine/api/src/com/cloud/vm/VirtualMachineManager.java ---
@@ -55,6 +55,9 @@
static final ConfigKey VmConfigDriveLabel = new
ConfigKey("Hidden", String.class, "vm.configdrive.label", "config",
"The default lable name for the config drive", false);
+static final ConfigKey ConfigDriveCreation = new
ConfigKey("Advanced", Boolean.class, "use.config.drive", "true",
+"If true, use config drives for data transfer else don't use.
Default is true", true);
--- End diff --
Explain why this should be true/enabled by default?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-216199303 @SudharmaJain please rebase against master and push -f, and update on status of your PR, thanks LGTM tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-216200365 @ustcweizhou please squash changes into one, rebase against master and push -f, and update on status of your PR, thanks This looks like a interesting feature we should have :) thanks tag:needlove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/985#discussion_r61726188
--- Diff: systemvm/patches/debian/buildsystemvm.sh ---
@@ -389,6 +389,8 @@ packages() {
chroot . apt-get --no-install-recommends -q -y --force-yes install ipcalc
#irqbalance from wheezy-backports
chroot . apt-get --no-install-recommends -q -y --force-yes -t
wheezy-backports install irqbalance
+ #qemu guest agent
+ chroot . apt-get --no-install-recommends -q -y --force-yes install
qemu-guest-agent
--- End diff --
this needs to go in tools/appliance/definitions/systemvmtemplate
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-216201171 @wido thanks for the feature, can you rebase against latest master and push -f; update on the state of the PR We should have this feature. tag:needlove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [wip] CLOUDSTACK-8677: use wrapper classe...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/987#issuecomment-216201554 @DaanHoogland can you rebase against latest master; it's huge change, advise how to test and review it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/997#issuecomment-216202104 This can be closed, I've moved max. tests to travis and fix test runs etc. @runseb tag:closeme --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8996: Reducing Virual Machine ...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1010#issuecomment-216202490 @pritisarap12 can you rebase against latest master and share state of your PR, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-216203992 LGTM, let's merge if CI has passed; though we need to check installable packages wrt all sort of scripts using it (like cloud-setup-databases and others etc.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-216204074 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1087#issuecomment-216204381 @PaulAngus can you rebase against latest master and share state of your PR, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-216204778 @wolf29 can you rebase against latest master and share state of your PR, thanks LGTM tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1115#issuecomment-216205142 @abhinandanprateek @agneya2001 please check that your changes has been merged on master and close this PR, thanks tag:closeme --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CID-1338387: Deletion of method endPointS...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1124#issuecomment-216205563 @rafaelweingartner please rebase against master and update on status of your PR? Looks like this can be merged once CI tested by @swill tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update JuniperSrxResource.java
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1148#issuecomment-216205836 LGTM, @wenwenxiong can you rebase against latest master and share state of your PR, thanks tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...
Github user olivierlemasle commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1503#discussion_r61726860
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -264,10 +266,11 @@ public void handleAsyncJobPublishEvent(String
subject, String senderAddress, Obj
String info = job.getCmdInfo();
String cmdEventType = "unknown";
if (info != null) {
-String marker = "\"cmdEventType\"";
-int begin = info.indexOf(marker);
-if (begin >= 0) {
-cmdEventType = info.substring(begin + marker.length() + 2,
info.indexOf(",", begin) - 1);
+Type type = new TypeToken>(){}.getType();
+Map cmdInfo =
ApiGsonHelper.getBuilder().create().fromJson(info, type);
--- End diff --
@alexandrelimassantana You're right, it was unnecessary. I've updated the
pull request accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1152#issuecomment-216206238 @kansal can you rebase against latest master and share state of your PR, thanks @DaanHoogland @jburwell do we still have outstanding issues on PR; do we want this or not? thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9112: Deploy VM failing freque...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1180#issuecomment-216206438 @harikrishna-patnala can you rebase against latest master, update on tests etc and share state of your PR, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Marvin test to verify that adding TCP por...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1183#issuecomment-216206911 @sanju1010 can you rebase against latest master and share state of your PR, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1198#issuecomment-216207184 @ustcweizhou thanks, can you rebase against latest master and share state of your PR this looks like an interesting change we should have tag:needlove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9120 READ.ME files describing ...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1202#issuecomment-216207451 @DaanHoogland can you move them to a wiki? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix vm cannot register and poweron on vce...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1203#issuecomment-216207807 LGTM, not tested though @ghxandsky can you rebase against latest master and share state of your PR, thanks tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1212#issuecomment-216208175 @ustcweizhou can you rebase against latest master and share state of your PR, thanks LGTM, though a marvin smoke test that can run with Travis would be great tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-216208373 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8654: Added guest_os m...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1244#issuecomment-216208482 @kishankavala can you rebase against latest master and share state of your PR, thanks; the changes also need to be moved to 481-490 schema file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-216208431 @alexandrelimassantana, you're right, I've splitted up the 3 different test cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8654: Added guest_os m...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1244#issuecomment-216208493 tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1241#issuecomment-216208430 LGTM tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9168: Testpath to check if wro...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1245#issuecomment-216208576 @pritisarap12 please modify the test to be able to run on basic zone as well. rebase against master thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1246#issuecomment-216208690 @SudharmaJain can you rebase against latest master and share state of your PR, thanks tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-216208737 @sureshanaparti can you rebase against latest master and share state of your PR, thanks; squash all changes into a single commit tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/756#issuecomment-216208745 @rhtyd, rebased against latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-216208899 @koushik-das can you rebase against latest master and share state of your PR, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: automated CLOUDSTACK 9177 9178 9179
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1250#issuecomment-216208859 @shwetaag can you rebase against latest master and share state of your PR, thanks please also use publicly accessible URLs in the testdata, those with no access to the current private network/URLs should be able to run these tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
