[GitHub] cloudstack pull request: speedup iptables setup

2016-04-03 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1449#issuecomment-204985068
  
@kollyma Can you squash the commits for me and I will then merge this in.  
Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

2016-04-03 Thread bvbharatk
Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1254#issuecomment-205035894
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 158
 Hypervisor xenserver
 NetworkType Advanced
 Passed=106
 Failed=2
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* :setup Failing since 3 runs

 * ContextSuite context=TestVpcSite2SiteVpn>:setup Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2016-04-03 Thread swill
Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1444#discussion_r58316653
  
--- Diff: 
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
 ---
@@ -484,6 +489,10 @@ public DomainBlockStats answer(final InvocationOnMock 
invocation) throws Throwab
 // IO traffic as generated by the logic above, must be greater 
than zero
 Assert.assertTrue(vmStat.getDiskReadKBs() > 0);
 Assert.assertTrue(vmStat.getDiskWriteKBs() > 0);
+// Memory limit of VM must be greater than zero
--- End diff --

@maneesha-p: can you shed some light on this?

> You specify that memory must be greater than zero in this comment, but it 
uses >= in the actual logic. Can you explain?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

2016-04-03 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1454#issuecomment-205047143
  
@abhinandanprateek would you mind rebasing to current master so I can test 
this in my CI?  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

2016-04-03 Thread swill
Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-205111794
  

### CI RESULTS




**MULTIPLE FAILURES, NEEDS WORK!**

There are problems with this code.  Here is a summary of the issues.  I 
have included detailed results so you can track down the issues.

```
==
ERROR: test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
263, in test_02_vpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
309, in performVPCTests
vlan_1 = int(vlans[0])
TypeError: int() argument must be a string or a number, not 'tuple'
```

```
==
ERROR: test_03_vpc_privategw_restart_vpc_cleanup 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
275, in test_03_vpc_privategw_restart_vpc_cleanup
self.performVPCTests(vpc_off, True)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
309, in performVPCTests
vlan_1 = int(vlans[0])
TypeError: int() argument must be a string or a number, not 'tuple'
```

```
==
ERROR: test_04_rvpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
287, in test_04_rvpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
309, in performVPCTests
vlan_1 = int(vlans[0])
TypeError: int() argument must be a string or a number, not 'tuple'
```

Not sure if this is related to one of the other failures or not...
```
==
FAIL: Test Remote Access VPN in VPC
--
Traceback (most recent call last):
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 419, in test_01_vpc_remote_access_vpn
vpnUser, "Failed to create Remote Access VPN User")
AssertionError: Failed to create Remote Access VPN User
```


**Associated Uploads**


* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1455/results.txt)


Uploads will be available until `2016-06-04 00:00:00 + GMT`

*Comment created by [`upr comment`](https://github.com/swill/upr).*




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

2016-04-03 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request:

https://github.com/apache/cloudstack/pull/1454#issuecomment-205117865
  
@cristofolini @swill rebased the PR, up for CI now, Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-04-03 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-205149639
  
@swill I share what worked for me, I'm not saying you have to use 
oracle-java. The openjdk version 1.7.0_85+ causes test failures for building 
console proxy in my Linux environment while the same happens on OSX when using 
1.7.0_90+, while openjdk version 1.7.0_80 works alright. The issue has to do 
with a set of cipher suites that got disabled, and random seg fault related 
issues. Both of them are related to `javac` and not `java`, and they are not 
consistent across platforms. In production we support openjdk-jre and not the 
`jdk/javac`, I'm not trying to suggest we remove any sort of java7 jre support 
at all.

tl;dr -- as I suggested earlier, what you're facing is an environment 
issue. It it helps, I'll split the PR into three -- one for mvn versions, one 
for bounty castle and changes by Daan, and one that fixes Travis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: travis: Fix simulator tests and optimize ...

2016-04-03 Thread bhaisaab
GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1461

travis: Fix simulator tests and optimize default global configs

- Migrate to trusty based Travis VMs
- Increase tests across five build matrices
- Fix xunit-reader output, include time
- Fix pip/python usage, pkg installation
- Build CloudStack in parallel with -T4
- Deploy database with optimized global settings

cc @runseb @swill @wido @DaanHoogland 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack master-fixmytravis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1461.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1461


commit e98eb8f6c8fc860fedacb3ff040bc5b9a9079c21
Author: Rohit Yadav 
Date:   2016-03-26T01:44:40Z

travis: Fix simulator tests and optimize default global configs

- Migrate to trusty based Travis VMs
- Increase tests across five build matrices
- Fix xunit-reader output, include time
- Fix pip/python usage, pkg installation
- Build CloudStack in parallel with -T4
- Deploy database with optimized global settings

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-04-03 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-205154145
  
@DaanHoogland do you want to have a look, if you can help fix the issue of 
building against latest openjdk and advise if bountycastle related changes are 
causing this. Maybe send them as a separate PR?

@swill I've split this PR into two, this one is related to mvn version 
changes; #1461 will fix the Travis issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---