Hard coded test data

[Sanjeev Neelarapu]

Hi,

Some of the tests have hard coded test data inside tests and due to this some 
of the tests are failing in CI runs.
E.g:
Test_privategw_acl.py has lot of hard coded test data like vlans, static routes 
and private gateway configuration.  Unless we have these configured in test 
environment, tests would never pass.

It is good practice to move the test data to test_data.py file instead of 
hardcoding it.

I request the owner of this test suite file to fix it and make it more generic.

Best Regards,
Sanjeev N
Chief Product Engineer, Accelerite
Off: +91 40 6722 9368 | EMail: 
sanjeev.neelar...@accelerite.com
[cid:image001.png@01D18361.DE542D60]




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

[ProjectMoon]

Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1450#discussion_r57697669
  
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -778,10 +778,11 @@ public int compare(final PublicIpAddress o1, final 
PublicIpAddress o2) {
 
 final boolean add = ipAddr.getState() == 
IpAddress.State.Releasing ? false : true;
 boolean sourceNat = ipAddr.isSourceNat();
-/* enable sourceNAT for the first ip of the public 
interface */
-if (firstIP) {
-sourceNat = true;
+/* enable sourceNAT for the first ip of the public 
interface as long as it's source nat. */
+if (firstIP && !sourceNat) {
--- End diff --

How do I trigger this case using the CS API? Is it by adding multiple NICs 
to the virtual router?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

[ProjectMoon]

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1450#issuecomment-202811882
  
@cristofolini The idea was that the source NAT IP is always the first IP. 
Not sure if the logic is correct. But apparently I need to correct the logic 
for the case @jayapalu mentioned.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: speedup iptables setup

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1449#issuecomment-202819883
  
@swill it is our responsibility as committers to make sure that it is 
merged against the right branch. if it is not a new feature and at the moment 
4.7 is the branch to go for. merging forward to 4.8. and master/4.9 is the 
right procedure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1152#issuecomment-202822605
  
@kansal did you get to this yet?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Hard coded test data

[Koushik Das]

Please file tracking bugs for all such issues



From: Sanjeev Neelarapu 
Sent: Tuesday, March 29, 2016 2:29 PM
To: dev@cloudstack.apache.org
Subject: Hard coded test data


Hi,



Some of the tests have hard coded test data inside tests and due to this some 
of the tests are failing in CI runs.

E.g:

Test_privategw_acl.py has lot of hard coded test data like vlans, static routes 
and private gateway configuration.  Unless we have these configured in test 
environment, tests would never pass.



It is good practice to move the test data to test_data.py file instead of 
hardcoding it.



I request the owner of this test suite file to fix it and make it more generic.



Best Regards,

Sanjeev N

Chief Product Engineer, Accelerite

Off: +91 40 6722 9368 | EMail: 
sanjeev.neelar...@accelerite.com

[cid:image001.png@01D18361.DE542D60]



DISCLAIMER == This e-mail may contain privileged and confidential 
information which is the property of Accelerite, a Persistent Systems business. 
It is intended only for the use of the individual or entity to which it is 
addressed. If you are not the intended recipient, you are not authorized to 
read, retain, copy, print, distribute or use this message. If you have received 
this communication in error, please notify the sender and delete all copies of 
this message. Accelerite, a Persistent Systems business does not accept any 
liability for virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1271#issuecomment-202837715
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 143
 Hypervisor xenserver
 NetworkType Advanced
 Passed=101
 Failed=3
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* integration.smoke.test_loadbalance.TestLoadBalance

 * test_01_create_lb_rule_src_nat Failed

 * test_02_create_lb_rule_non_nat Failed

 * test_assign_and_removal_lb Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

[kansal]

Github user kansal commented on the pull request:

https://github.com/apache/cloudstack/pull/1152#issuecomment-202844861
  
@DaanHoogland I am not sure of the amount of work that needs to be done for 
fixing all the existing test cases. Will revisit this and update. I still 
personally think that going with the optional parameter presently and assuming( 
and making sure) that the new test cases are written in compliance with this 
API will be a good way to go forward. Your views?  
PS: I am still not very versed with the test case suits. Will check and 
revisit this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [SSL CERTS] Importing ROOT and INTERMEDIATE certs for SSVM

[Daan Hoogland]

Ilya, to my knowledge the certificate won't be saved on file. It will be
loaded from the command coming from the MS in the agent directly. Why are
you looking to update the ssvm? I thought these are only used in the
consoleproxy.

On Tue, Mar 29, 2016 at 12:17 AM, ilya  wrote:

> I'm having difficulty getting ROOT and INTERMEDIATE certificates to show
> up in SSVM java keystore.
>
>
> I've followed the procedure on
>
> http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/4.8/systemvm.html?highlight=pkcs
>
> and
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Procedure+to+Replace+realhostip.com+with+Your+Own+Domain+Name
>
> But after restart of SSVM and MS - the keystore still has default Go
> Daddy certs.
>
> Would any know how to troubleshoot it?
>
> Also, one thing to note, i'm not uploading the actual wild card cert -
> is its against security policy. It will be impossible for me to get a
> wildcard cert.
>
> Regards
> ilya
>



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1152#issuecomment-202852425
  
@kansal as the complexity is unknown I would just go ahead and update the 
pr. We'll see the damage and think of fixes as we go. As for setting the value 
to true for existing tests, fine. as long as the default is false. the fix 
(setting it to true for some test cases) is trivial and will probably not be 
needed very often. Who is going to check a response for a private key unless 
they really need it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

[nlivens]

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/1452#issuecomment-202859071
  
@pedro-martins Updated the PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

[alexandrelimassantana]

Github user alexandrelimassantana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1454#discussion_r57714466
  
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -2112,11 +2112,13 @@ private boolean doCancelMaintenance(final long 
hostId) {
 
 /* TODO: move to listener */
 _haMgr.cancelScheduledMigrations(host);
+
+boolean vms_migrating = false;
 final List vms = _haMgr.findTakenMigrationWork();
 for (final VMInstanceVO vm : vms) {
 if (vm != null && vm.getHostId() != null && vm.getHostId() == 
hostId) {
 s_logger.info("Unable to cancel migration because the vm 
is being migrated: " + vm);
--- End diff --

Can you turn the if on line 2119 to a method call like _isVmMigrating(vm, 
hostId)_? Or even _vm.isMigrating(hostId)_

I think that it will improve the readability of this segment you are 
working. Also... is there a need to check all VMs ? Once you find one that is 
migrating do you still need to keep checking if they are migrating? If there is 
not a need, try changing the loop for a while, or issuing a break.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [SSL CERTS] Importing ROOT and INTERMEDIATE certs for SSVM

[Suresh Sadhu]

Illa,
  
 Is there  any issue noticed while uploading/applying certificate., it refers 
old certificate if uploacertificate has any issues.
Check your logs for any exceptions.

Use below command to list all the certs in the keystore.if your certificate 
uploaded successfully then you can see entry(certificate) in the output with 
latest date

keytool -list -keystore /usr/local/cloud/systemvm/certs/realhostip.keystore 
-storepass vmops.com



Regards
Sadhu




-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Tuesday, March 29, 2016 5:19 PM
To: dev
Subject: Re: [SSL CERTS] Importing ROOT and INTERMEDIATE certs for SSVM

Ilya, to my knowledge the certificate won't be saved on file. It will be loaded 
from the command coming from the MS in the agent directly. Why are you looking 
to update the ssvm? I thought these are only used in the consoleproxy.

On Tue, Mar 29, 2016 at 12:17 AM, ilya  wrote:

> I'm having difficulty getting ROOT and INTERMEDIATE certificates to 
> show up in SSVM java keystore.
>
>
> I've followed the procedure on
>
> http://docs.cloudstack.apache.org/projects/cloudstack-administration/e
> n/4.8/systemvm.html?highlight=pkcs
>
> and
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Procedure+to+Re
> place+realhostip.com+with+Your+Own+Domain+Name
>
> But after restart of SSVM and MS - the keystore still has default Go 
> Daddy certs.
>
> Would any know how to troubleshoot it?
>
> Also, one thing to note, i'm not uploading the actual wild card cert - 
> is its against security policy. It will be impossible for me to get a 
> wildcard cert.
>
> Regards
> ilya
>



--
Daan



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[alexandrelimassantana]

Github user alexandrelimassantana commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-202874549
  
Does the _cleanup_resources(cls.api_client, cls._cleanup)_ cleans the db 
connection as well? I see that it is only 1 test as of now, but if there would 
be another, the setUp should also work correctly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9319: Use timeout when applyin...

[insom]

Github user insom commented on the pull request:

https://github.com/apache/cloudstack/pull/1451#issuecomment-202951746
  
@pedro-martins Thanks for the review but I don't want to make this change 
because (a) it'll mix two intents into on PR - fixing the bug *and* improving 
the logging - and (b) it would be *less* consistent with the rest of the 
CloudStack code base which, for better or worse, largely uses string 
concatenation for debug logging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9194: Making the console popup...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1270#issuecomment-203006893
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 144
 Hypervisor xenserver
 NetworkType Advanced
 Passed=101
 Failed=3
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* integration.smoke.test_loadbalance.TestLoadBalance

 * test_01_create_lb_rule_src_nat Failing since 2 runs

 * test_02_create_lb_rule_non_nat Failing since 2 runs

 * test_assign_and_removal_lb Failing since 2 runs


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1269#issuecomment-203152685
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 145
 Hypervisor xenserver
 NetworkType Advanced
 Passed=103
 Failed=1
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork

 * test_extendPhysicalNetworkVlan Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

[abhinandanprateek]

Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1454#discussion_r57835178
  
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -2112,11 +2112,13 @@ private boolean doCancelMaintenance(final long 
hostId) {
 
 /* TODO: move to listener */
 _haMgr.cancelScheduledMigrations(host);
+
+boolean vms_migrating = false;
 final List vms = _haMgr.findTakenMigrationWork();
 for (final VMInstanceVO vm : vms) {
 if (vm != null && vm.getHostId() != null && vm.getHostId() == 
hostId) {
 s_logger.info("Unable to cancel migration because the vm 
is being migrated: " + vm);
--- End diff --

@alexandrelimassantana 
The reason for not breaking from the for loop is to log info about vms that 
are under migration. Probably the log level should be increased to warn. These 
log messages would be valuable for trouble shooting.
On readability front yes the code will be improved further.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

VMXNET3 via the API

[Will Stevens]

Is this the correct way to set the Vmxnet3 property for a VMware template
via the API?

It does not seem to be working even though it seems to be accepted via the
API.  Any ideas?

http://10.10.90.41:8080/client/api?account=masteruser%40DEV&domainid=e3d90052-56b6-4cd5-a5be-dc34ee461755&name=migrate-me-2008R2-disk1&format=OVA&url=http%3A%2F%2F10.10.90.251%3A80%2Fmigrate-me-2008R2-disk1.ova&hypervisor=VMware&zoneid=f0bcb52b-2487-453e-8bcd-b82d56dc6e1b&apiKey=9-UVwC7DeAjLggZFyqhtC_IwqvH_40YNz0rJjBuwS666AVqevbj4Ajk2HDduaEdWxo3O_stNKGrFvSZDj_Nx6g&displaytext=migrate-me-2008R2-disk1&ostypeid=30f531a4-c467-11e5-bcaa-0050569856f2&details[0].value=Vmxnet3&command=registerTemplate&response=json&details[0].key=nicAdapterType&signature=OIaO2O/O2bZOs5790p0Enl83LwI%3D

response:
{ u'count': 1,
  u'template': [ { u'account': u'masteruser@DEV',
   u'created': u'2016-03-30T04:16:04+',
   u'crossZones': False,
   u'details': { u'key': u'nicAdapterType',
 u'value': u'Vmxnet3'},
   u'displaytext': u'migrate-me-2008R2-disk1',
   u'domain': u'AA02',
   u'domainid': u'e3d90052-56b6-4cd5-a5be-dc34ee461755',
   u'format': u'OVA',
   u'hypervisor': u'VMware',
   u'id': u'f34cb95d-5b0b-4b53-9690-399108fff940',
   u'isdynamicallyscalable': False,
   u'isextractable': False,
   u'isfeatured': False,
   u'ispublic': False,
   u'isready': False,
   u'name': u'migrate-me-2008R2-disk1',
   u'ostypeid': u'30f531a4-c467-11e5-bcaa-0050569856f2',
   u'ostypename': u'Other (64-bit)',
   u'passwordenabled': False,
   u'sshkeyenabled': False,
   u'status': u'',
   u'tags': [],
   u'templatetype': u'USER',
   u'zoneid': u'f0bcb52b-2487-453e-8bcd-b82d56dc6e1b',
   u'zonename': u'InternalCore'}]}

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

[abhinandanprateek]

Github user abhinandanprateek commented on the pull request:

https://github.com/apache/cloudstack/pull/1454#issuecomment-203249781
  
Output from marvin test:

TMP=/tmp
CLOUDDIR=/root/cloudstack-apple
mkdir -p /tmp/simulator/smoke/misc
nosetests --with-xunit --xunit-file=/tmp/test_quagga.xml --with-marvin 
--marvin-config=/root/cloudstack-apple/advanced.cfg 
/root/cloudstack-apple/test/integration/component/test_host_maintenance.py -s 
-a tags=advanced,required_hardware=true --zone=Bootcamp --hypervisor=KVM
 Marvin Init Started 

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

 Log Folder Path: /tmp//MarvinLogs//Mar_30_2016_10_02_53_F4MC43. All 
logs will be available here 

=== Marvin Init Logging Successful===

 Marvin Init Successful 
1 Hypervisor = 3e270f2d-f054-4cbe-85e1-0fbc30e8a414
1 Hypervisor = 6a34ca0a-ac2f-44db-a8f4-96b7de01dcd4
Host with id 3e270f2d-f054-4cbe-85e1-0fbc30e8a414 is in 
prepareHostForMaintenance
Host with id 3e270f2d-f054-4cbe-85e1-0fbc30e8a414 is in 
cancelHostMaintenance
Host with id 6a34ca0a-ac2f-44db-a8f4-96b7de01dcd4 is in 
prepareHostForMaintenance
Host with id 6a34ca0a-ac2f-44db-a8f4-96b7de01dcd4 is in 
cancelHostMaintenance
=== TestName: test_01_cancel_host_maintenace_with_no_migration_jobs | 
Status : SUCCESS ===

2 Hypervisor = 3e270f2d-f054-4cbe-85e1-0fbc30e8a414
2 Hypervisor = 3e270f2d-f054-4cbe-85e1-0fbc30e8a414
2 Hypervisor = 6a34ca0a-ac2f-44db-a8f4-96b7de01dcd4
2 Hypervisor = 6a34ca0a-ac2f-44db-a8f4-96b7de01dcd4
Create VMs as there are not enough vms to check host maintenance
Create VMs as there are not enough vms to check host maintenance
Creating vms = 5
Creating vms = 5
Using template a18cc46d-d4e8-476f-bdf6-9f3e5818a200 
Using template a18cc46d-d4e8-476f-bdf6-9f3e5818a200 
Using service offering 5bee807e-602a-4203-b9c3-ed72797b1d93 
Using service offering 5bee807e-602a-4203-b9c3-ed72797b1d93 
VM create = b67468ff-8120-42d7-87fe-2c7361c4afd3
VM create = b67468ff-8120-42d7-87fe-2c7361c4afd3
VM create = 8309716e-03ac-442a-ab18-a80748d5988c
VM create = 8309716e-03ac-442a-ab18-a80748d5988c
VM create = af8d8991-0ee2-44ca-bee4-d706f883dc0a
VM create = af8d8991-0ee2-44ca-bee4-d706f883dc0a
VM create = 1bacebb1-9be7-40a1-99f3-7b7e9deb45b7
VM create = 1bacebb1-9be7-40a1-99f3-7b7e9deb45b7
VM create = eac8b28d-0bea-4912-b6e4-3402ac07e802
VM create = eac8b28d-0bea-4912-b6e4-3402ac07e802
Host with id 3e270f2d-f054-4cbe-85e1-0fbc30e8a414 is in 
prepareHostForMaintenance
Host with id 3e270f2d-f054-4cbe-85e1-0fbc30e8a414 is in 
prepareHostForMaintenance
Vms found = 2 
Vms found = 2 
VirtualMachine on Hyp id = 8309716e-03ac-442a-ab18-a80748d5988c is in 
Migrating
VirtualMachine on Hyp id = 8309716e-03ac-442a-ab18-a80748d5988c is in 
Migrating
Host with id 3e270f2d-f054-4cbe-85e1-0fbc30e8a414 is in 
cancelHostMaintenance
Host with id 3e270f2d-f054-4cbe-85e1-0fbc30e8a414 is in 
cancelHostMaintenance
Host with id 6a34ca0a-ac2f-44db-a8f4-96b7de01dcd4 is in 
prepareHostForMaintenance
Host with id 6a34ca0a-ac2f-44db-a8f4-96b7de01dcd4 is in 
prepareHostForMaintenance
Vms found = 4 
Vms found = 4 
VirtualMachine on Hyp id = 8309716e-03ac-442a-ab18-a80748d5988c is in 
Migrating
VirtualMachine on Hyp id = 8309716e-03ac-442a-ab18-a80748d5988c is in 
Migrating
Host with id 6a34ca0a-ac2f-44db-a8f4-96b7de01dcd4 is in 
cancelHostMaintenance
Host with id 6a34ca0a-ac2f-44db-a8f4-96b7de01dcd4 is in 
cancelHostMaintenance
=== TestName: test_02_cancel_host_maintenace_with_migration_jobs | Status : 
SUCCESS ===

===final results are now copied to: 
/tmp//MarvinLogs/test_host_maintenance_RF5DFR===
++ date

echo Wed Mar 30 10:06:16 IST 2016 Wed Mar 30 10:06:16 IST 2016


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.4] CLOUDSTACK-9042: VR: DHCP: fix miss...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1266#issuecomment-203252716
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 146
 Hypervisor xenserver
 NetworkType Advanced
 Passed=99
 Failed=4
 Skipped=5

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* integration.smoke.test_vm_snapshots.TestSnapshots

 * test_01_create_vm_snapshots Failed

 * test_02_revert_vm_snapshots Failed

 * test_03_delete_vm_snapshots Failed

* integration.smoke.test_volumes.TestCreateVolume

 * test_01_create_volume Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
ContextSuite context=TestCreateTemplate>:setup
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Migrating CloudStack content from download.cloud.com

[Raja Pullela]

Just to summarize... and to close this thread for now,  

1) short term - we will move the content to cloudstack.apt-get.eu
2) long term - can someone from PMC or Cloudstack Apache Infra help find out 
the details on how to all the cloustack (downloads - software, sys templates 
etc) content hosted on 'download.cloudstack.org'  or something similar.

Best,
Raja
Senior Manager, Product Development
Accelerite,  
2055, Laurelwood Road,  Santa Clara, CA 95054, USA
Phone: 1-408-216-7010,  www.accelerite.com, @accelerite 

-Original Message-
From: Paul Angus [mailto:paul.an...@shapeblue.com] 
Sent: Monday, March 28, 2016 1:38 PM
To: dev@cloudstack.apache.org
Subject: RE: Migrating CloudStack content from download.cloud.com

If someone can figure out a community/ASF acceptable way of the ACS community 
owning a suitable vendor-neutral domain name, within the community we have 
enough resources to physically host it (including the space donated by BT via 
ShapeBlue).



Regards,

Paul Angus

paul.an...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue

-Original Message-
From: Erik Weber [mailto:terbol...@gmail.com]
Sent: Saturday, March 26, 2016 4:19 PM
To: dev@cloudstack.apache.org
Subject: Re: Migrating CloudStack content from download.cloud.com

One of the issues as far as I know is that as Apache CloudStack we have to be 
strict with what we distribute. Meaning, we won't be able to push noredist 
stuff, which is a pity.

Erik

Den lørdag 26. mars 2016 skrev Ian Rae  følgende:

> Does Apache provide such hosting services? It seems that the Apache 
> infrastructure is very restrictive, perhaps we should ask whether they 
> can provide reliable hosting for templates and other downloads.
>
> If Apache is ruled out as an option I recommend we have the community 
> contribute the hosting (happy to volunteer) but the URL should be a 
> community URL and not specific to a commercial vendor. It should 
> probably be mirrored geographically as well.
>
> Ian
>
> On Saturday, 26 March 2016, Ian Duffy >
> wrote:
>
> > I could be completely wrong here, but wasn't there some specific 
> > closed source citrix magic added to the templates at 
> > downloads.cloud.com that
> was
> > Cloud Platform specific?
> >
> > Ideally, this stuff should be hosted on an Apache Cloudstack 
> > infrastructure or atleast the main community source ( 
> > cloudstack.apt-get.eu, shapeblue repo, etc.).
> >
> > On 25 March 2016 at 15:00, Sebastien Goasguen  
> > > wrote:
> >
> > >
> > > > On Mar 25, 2016, at 10:24 AM, Raja Pullela <
> > raja.pull...@accelerite.com  >
> > > wrote:
> > > >
> > > > @Sebastien,  thanks for the feedback.  please note that the goal 
> > > > of
> > this
> > > exercise was not to impact any users during this migration and 
> > > hence
> the
> > > efforts to place the content at a location where we could move it to.
> > > Since Wido is ok with hosting the content on 
> > > 'cloudstack.apt-get.eu',
> it
> > > is even better.  I will work with Wido on the next steps.
> > > >
> > >
> > > Ok cool.
> > >
> > > We had other threads about avoiding company specific URL in docs. 
> > > So
> > let’s
> > > definitely avoid that.
> > >
> > >
> > > > @Ilya,  'cloud.com' is not getting transferred.
> > > >
> > > > Best,
> > > > Raja
> > > > Senior Manager, Product Development Accelerite, 
> > > > www.accelerite.com
> > > >
> > > > -Original Message-
> > > > From: Sebastien Goasguen [mailto:run...@gmail.com 
> ]
> > > > Sent: Friday, March 25, 2016 1:57 PM
> > > > To: dev@cloudstack.apache.org  
> > > > Subject: Re: Migrating CloudStack content from 
> > > > download.cloud.com
> > > >
> > > 
> > >  Citrix has been hosting   "download.cloud.com"  for  quite  some
> > > time  now
> > >  and  it holds  the  System Templates for all the releases and
> some
> > > tools.
> > >  Going forward,  this  content  needs  to  be  moved  from
> > >  "download.cloud.com".So, we will be moving  this content  to
> > >  "cloudstack.accelerite.com".I  will also be  updating  the
> > > links in the
> > >  documentation  to reflect
> > > >
> > > > Raja, I am going to give this a strong -1
> > > >
> > > > We talked about these sorts of things before and it is not
> appropriate.
> > > >
> > > >
> > > >
> > >  these  changes and will provide an update  once the  content 
> > >  move is complete.
> > > 
> > >  @Wido, if you could also copy this content to 
> > >  "cloudstack.apt-get.eu"  that will be great.  I can provide 
> > >  you
> the
> > > details in a separate email.
> > > >>>
> > > >>> Super! If you have a rsync source I will set it up.
> > > >>>
> > > >
> > > > @Wido, I think we need to host the sysVM on apt-get.eu and let 
> > > > that
> be
> > > the primary source and links in the docs.
> > > >
> > > >
> > > >>> Wido
> > > >>>
> > > 
> > >  Best,
> > >  Raja
> > >  Senior Manager, Product Development, Acc