date:20160202

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1389#issuecomment-178503110
  
not worth it, @borisroman?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

2016-02-02 Thread borisroman

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1389#issuecomment-178503500
  
@DaanHoogland Two errors, one in S2S and one in prv gw. Will reopen in a few


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1390

CLOUDSTACK-9267: String is not localized on create instance wizards.

Repro Steps: 
==
1. Setup basic environments as normal.
2. Open a browser, go to Web Console.
3. Upload a iso template.
4. Go to "Instances" page and add new instance.
5. Check the strings on create instance wizards.

Expected Result:
=
All the strings should be localized on create instance wizards.

Actual Result:
===
Some strings are not localized on create instance wizards.

Language:

JA -> Fail
SC -> Fail

Fix:
===
Fixed the hard coded string.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin 
CloudStack-Nitin24_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1390.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1390


commit ff10bdc2bf6fb2620feb68f5f232b04bc89cd707
Author: Nitin Kumar Maharana 
Date:   2016-02-02T10:58:49Z

CLOUDSTACK-9267: String is not localized on create instance wizards.

Fixed the hard coded string.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Discuss] Flexible CI/CD - Trillian

2016-02-02 Thread Paul Angus

Project: Trillian
We have been working on PoC of a CI environment design which will:

· Provide fast build or rebuild of environments for testing.

· Enable multiple independent concurrent builds

· Be available on-demand through automation or individual request.

· Be capable of fully utilising all available hardware

· Flexible enough to be used to build super-realistic development 
environments.
We intend to contribute and maintain our work within the Apache repos. However, 
we are currently building the POC, figuring out the requirements (and quirks) 
of the individual pieces, before pushing something concrete for to the 
community to review.

We envision that Trillian would cater for a number of use cases:

1.   CloudStack community integration testing of master against multiple 
deployment scenarios (using ASF infra)

2.   CloudStack community integration testing of PRs against multiple 
deployment scenarios (using ASF infra)

3.   Organisations/individuals running the full suites of tests available 
in Marvin against any physical environment they have.

4.   Organisations/individuals deploying and running the full suites of 
tests available in Marvin against virtualised infrastructures which can be 
deployed by Marvin.
As we intend Trillian to test multiple environments concurrently, we use nested 
virtualization on ESXi hosts (our testing has shown that this is the only 
hypervisor which can support the nested virtualisation of all other hypervisors 
with reasonable performance). We use Ansible to deploy and configure all 
aspects of the build as this will greatly lower the barrier to entry for 
independent testers.
We use CloudStack to provision the management server and virtualised (nested) 
hosts on the physical hosts. We are creating Ansible playbooks and roles which 
can:

1.   Create guest instances using Rene’s Ansible 2.0 CloudStack modules - a 
Marvin VM, a Mgmt Server (CentOS or Ubuntu), any number of compute hosts (KVM, 
vSphere or XenServer. Hyper-V later)

2.   Configure hosts (inc. installing the relevant CloudStack agent where 
required)

3.   Install required ACS packages on management server

4.   Configure a zone (including adding the compute hosts) via Marvin.

5.   Run the required Marvin tests.

6.   Return the results
We may need to propose enhancements to Marvin in order to sync the 
configuration of hosts with the configuration used by Marvin.

Using virtualised test environments, we can have multiple test scenarios 
running concurrently. To do this we have found that it is necessary to create 
pools or ranges of VLANs and IP addresses and allocate them to environments.  
So for any given physical environment which will be used for testing in, we 
take the total range(s) of IPs and VLANs available and carve them into 
non-overlapping chunks suitable for concurrent use as mgmt, public and guest 
networks.  These are stored in a MariaDB database.  When a range is being used 
in a testing environment, that range is marked as ‘inuse’ in the database.  
When creating a test environment, Trillian looks in the database for the next 
available VLAN range, the next available public IP range and so on.  The 
returned values are used to populate a Marvin cfg file which in turn will be 
used to both build the environment and when running the Marvin testing.  When 
the virtualised infra is cleaned up, the database will be updated to reflect 
that the used ranges are available again.
This initiative has only recently been started, and as stated earlier we are 
currently figuring out the requirements (and quirks) of the individual pieces 
and looking for the most suitable wrapper to glue it all together.
Also I have found that Marvin requires a little work to make the output more 
meaningful/readable (especially in the case of errors and exceptions) and to 
make it a little more intelligent about the tests it can/can’t run based on the 
chosen infrastructure components. I have also found unreachable or very slow 
ISO and template paths hardcoded into Marvin or individual tests.
We plan to enhance tests to address these issues and also reduce runtimes where 
possible.

NEXT STEPS

We will continue to our work on the PoC and share the results.

We’d like to get some community agreement around the goals and use cases which 
we are planning to satisfy before we get too far down the road of our PoC. So 
please share your thoughts.



[ShapeBlue]
Paul Angus
VP Technology   ,   ShapeBlue


d:  +44 203 617 0528 | s: +44 203 603 
0540 |  
m:  +44 7711 418784

e:  paul.an...@shapeblue.com | t: 
@cloudyangus  |
  w:  www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:imagea932fa.png@ce3f6520.47a350c4]


Shape Blue Ltd is a company incorporated in

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1389#issuecomment-178507273
  
thank, don't hurry


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1390#issuecomment-178507781
  
more explanation then code, but makes sense. mostly cosmatic: LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Discuss] Flexible CI/CD - Trillian

2016-02-02 Thread Nux!

Hi Paul,

This is great news, good job, naming apart. :-)

Is ESXi a hard requirement on running Trillian?

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Paul Angus" 
> To: dev@cloudstack.apache.org
> Cc: us...@cloudstack.apache.org
> Sent: Tuesday, 2 February, 2016 10:49:46
> Subject: [Discuss] Flexible CI/CD - Trillian

> Project: Trillian
> We have been working on PoC of a CI environment design which will:
> 
> · Provide fast build or rebuild of environments for testing.
> 
> · Enable multiple independent concurrent builds
> 
> · Be available on-demand through automation or individual request.
> 
> · Be capable of fully utilising all available hardware
> 
> · Flexible enough to be used to build super-realistic development
> environments.
> We intend to contribute and maintain our work within the Apache repos. 
> However,
> we are currently building the POC, figuring out the requirements (and quirks)
> of the individual pieces, before pushing something concrete for to the
> community to review.
> 
> We envision that Trillian would cater for a number of use cases:
> 
> 1.   CloudStack community integration testing of master against multiple
> deployment scenarios (using ASF infra)
> 
> 2.   CloudStack community integration testing of PRs against multiple
> deployment scenarios (using ASF infra)
> 
> 3.   Organisations/individuals running the full suites of tests available 
> in
> Marvin against any physical environment they have.
> 
> 4.   Organisations/individuals deploying and running the full suites of
> tests available in Marvin against virtualised infrastructures which can be
> deployed by Marvin.
> As we intend Trillian to test multiple environments concurrently, we use 
> nested
> virtualization on ESXi hosts (our testing has shown that this is the only
> hypervisor which can support the nested virtualisation of all other 
> hypervisors
> with reasonable performance). We use Ansible to deploy and configure all
> aspects of the build as this will greatly lower the barrier to entry for
> independent testers.
> We use CloudStack to provision the management server and virtualised (nested)
> hosts on the physical hosts. We are creating Ansible playbooks and roles which
> can:
> 
> 1.   Create guest instances using Rene’s Ansible 2.0 CloudStack modules - 
> a
> Marvin VM, a Mgmt Server (CentOS or Ubuntu), any number of compute hosts (KVM,
> vSphere or XenServer. Hyper-V later)
> 
> 2.   Configure hosts (inc. installing the relevant CloudStack agent where
> required)
> 
> 3.   Install required ACS packages on management server
> 
> 4.   Configure a zone (including adding the compute hosts) via Marvin.
> 
> 5.   Run the required Marvin tests.
> 
> 6.   Return the results
> We may need to propose enhancements to Marvin in order to sync the 
> configuration
> of hosts with the configuration used by Marvin.
> 
> Using virtualised test environments, we can have multiple test scenarios 
> running
> concurrently. To do this we have found that it is necessary to create pools or
> ranges of VLANs and IP addresses and allocate them to environments.  So for 
> any
> given physical environment which will be used for testing in, we take the 
> total
> range(s) of IPs and VLANs available and carve them into non-overlapping chunks
> suitable for concurrent use as mgmt, public and guest networks.  These are
> stored in a MariaDB database.  When a range is being used in a testing
> environment, that range is marked as ‘inuse’ in the database.  When creating a
> test environment, Trillian looks in the database for the next available VLAN
> range, the next available public IP range and so on.  The returned values are
> used to populate a Marvin cfg file which in turn will be used to both build 
> the
> environment and when running the Marvin testing.  When the virtualised infra 
> is
> cleaned up, the database will be updated to reflect that the used ranges are
> available again.
> This initiative has only recently been started, and as stated earlier we are
> currently figuring out the requirements (and quirks) of the individual pieces
> and looking for the most suitable wrapper to glue it all together.
> Also I have found that Marvin requires a little work to make the output more
> meaningful/readable (especially in the case of errors and exceptions) and to
> make it a little more intelligent about the tests it can/can’t run based on 
> the
> chosen infrastructure components. I have also found unreachable or very slow
> ISO and template paths hardcoded into Marvin or individual tests.
> We plan to enhance tests to address these issues and also reduce runtimes 
> where
> possible.
> 
> NEXT STEPS
> 
> We will continue to our work on the PoC and share the results.
> 
> We’d like to get some community agreement around the goals and use cases which
> we are planning to satisfy before

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1390#issuecomment-178522940
  
I thought of making a small explanation. But I follow this template while 
making a PR so that it would be easy for committer to review very fast. Anyway 
Thanks @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1390#issuecomment-178526046
  
There is one more localised issue in the project page, So instead of 
creating a new one adding it to this PR only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1390#issuecomment-178660255
  
LGTM as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] LTS Release Cycle

2016-02-02 Thread John Burwell

All,

Based on the feedback from Ilya, Erik, and Daan, I have updated my original LTS
proposal to clarify that LTS releases are official project deliverables, commit
traceability across branches, and RM approval of PRs:

## START ##

Motivation
==

The current monthly release cycle addresses the needs of users focused on
deploying new functionality as quickly as possible. It does not address the
needs of users oriented towards stability rather than new functionality. These
users typically employ QA processes to comply with corporate policy and/or
regulatory requirements. To maintain a growing, thriving community, we must
address the needs of both user types. Therefore, I propose that we overlay a
LTS release cycle onto the monthly release cycle to address the needs of
stability-oriented users with minimal to no impact on the monthly release
cycle. This proposed LTS release cycle has the following goals:

* Prefer Stability to New Functionality: Deliver releases that only address
defects and CVEs. This narrowly focused change scope greatly reduces the
upgrade risk/operational impact and shorter internal QA cycles.
* Reliable Release Lifetimes: Embracing a time-based release strategy, the
LTS release cycle will provide users with a reliable support time frames.
Users can use these time frames provide users with an 20 month window in which
to plan upgrades.
* Support Sustainability: With a defined end of support for LTS releases and
a maximum of two (2) LTS releases under active maintenance at any given time,
community members can better plan their commitments to release support
activities. We also have a agreed upon policy for release end-of-life (EOL) to
debate about continuing work on old releases.

LTS releases would be official project releases. Therefore, they would be
subject to same release voting requirements and available from the project
downloads page.

Proposed Process

LTS release branches will be cut twice year on 1 Jan and 1 July based the tag
of the most recent monthly release. The branch will be named _LTS and each LTS release will be versioned in the form of _. For example, if we cut an LTS branch based on
4.7.0, the branch would be named 4.7.0_LTS and the version of the first LTS
release would be 4.7.0_0, the second would be 4.7.0_1, etc. This release
naming convention differentiates LTS and monthly releases, communicates the
version on which the LTS release is based, and allows the maintenance releases
for monthly releases without version number contention/conflict. Finally, like
master, an LTS branch would be always deployable following its initial release.
While it is unlikely that LTS users would deploy from the branch, the quality
discipline of this requirement will benefit the long term stability of LTS
releases. Like master, all PRs targeting an LTS branch would require two LGTMs
(one code review and one independent test), as well as, an LGTM from the branch
RM. A combined code review/test LGTM and an RM LGTM would be acceptable.

The following are the types of changes that would permitted and guarantees
provided to users:

* No features or enhancements would be backported to LTS release branches.
* Database changes would be limited to those required to address the
backported defect fixes.
* Support for the release/version of the following components from the
release on which the LTS is based throughout the entire release cycle:
* MySQL/MariaDB
* JDK/JRE
* Linux distributions
* API compatibility for between all LTS revisions. API changes would be
limited to those required to fix defects or address security issues.

An LTS release would have a twenty (20) month lifetime from the date the
release branch is cut. This support period allows up to two (2) months of
branch stabilization before initial release with a minimum of eighteen (18)
months of availability for deployment. The twenty (20) month LTS lifecycle
would be divided into following support periods:

* 0-2 months (average): Stablization of the LTS branch with fixes based on
defects discovered from functional, regression, endurance, and scalability
testing.
* 2-14 months: backport blocker and critical priority defect fixes in the
scope of the LTS branch functionality; fix all blocker and critical priority
defects identified on the LTS branch
* 14-20 months: backport only CVE fixes in the scope of the LTS branch
functionality; fix all blocker priority defects identified on the LTS branch

Defect fixes that originate in an LTS branch would be pulled forward to master
only. Finally, an LTS branch should be release the fewest times necessary to
deliver fixes in a relatively timely manner. Therefore, LTS releases will be
triggered based on the number of pending of fixes and their severity with no
defect fix awaiting release more than forty-five (45) days. CVE fixes would
trigger the immediate release of a

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

2016-02-02 Thread borisroman

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1391

Restore iptables at once using iptables-restore instead of calling iptables 
numerous times



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack iptables-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1391


commit 9145301b261bb66c13823302e313f5baeedb9cac
Author: Boris Schrijver 
Date:   2016-02-01T14:57:26Z

Add iptables copnversion script.

Source: 
https://raw.githubusercontent.com/sl0/conv/master/iptables_converter.py

commit 21a2f3ea01f176825a2ae47ba05ffb1f2e840a9b
Author: Boris Schrijver 
Date:   2016-02-01T14:58:27Z

Restore iptables at once using iptables-restore instead of calling iptables 
numerous times




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: framework/quota: Fix checkstyle issue

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1392

framework/quota: Fix checkstyle issue

Fixes a checkstyle issue for enums, breaks with newer mvn checkstyle 
versions

cc @agneya2001

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.9-fixcheckstyle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1392


commit 03e4185157886d8df9889cd3073842c9650530a9
Author: Rohit Yadav 
Date:   2016-01-27T00:30:21Z

framework/quota: Fix checkstyle issue

Fixes a checkstyle issue for enums, breaks with newer checkstyle versions

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1393

maven: Upgrade dependency versions and to maven 3.3.9

Skipped: (but upgraded to latest minor release)
- Major spring framework version
- Servlet version
- Embedded jetty version
- Mockito version (beta)
- Mysql lib minor version upgrade (breaks mysql-ha plugin)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.9-mvn-upgrade

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1393


commit 39b8e1172dcb520cbee18b930791862972e3bb52
Author: Rohit Yadav 
Date:   2016-01-27T00:41:02Z

maven: Upgrade dependency versions and to maven 3.3.9

Skipped: (but upgraded to latest minor release)
- Major spring framework version
- Servlet version
- Embedded jetty version
- Mockito version (beta)
- Mysql lib minor version upgrade (breaks mysql-ha plugin)

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3137

2016-02-02 Thread jenkins

See 

--
[...truncated 824 lines...]
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
2016-02-02 17:13:11,192 DEBUG [utils.script.Script] (main:) Executing: 
/bin/bash -c /not/existing/scripts/1454433191192 
2016-02-02 17:13:11,195 DEBUG [utils.script.Script] (main:) Exit value is 127
2016-02-02 17:13:11,195 DEBUG [utils.script.Script] (main:) /bin/bash: 
/not/existing/scripts/1454433191192: No such file or directory
2016-02-02 17:13:11,196 DEBUG [utils.script.Script] (main:) Executing: 
/bin/bash -c echo 'hello world!' 
2016-02-02 17:13:11,199 DEBUG [utils.script.Script] (main:) Execution is 
successful.
2016-02-02 17:13:11,200 DEBUG [utils.script.Script] (main:) Executing: 
/bin/bash -c echo 'hello world!' 
2016-02-02 17:13:11,203 DEBUG [utils.script.Script] (main:) Execution is 
successful.
Tests run: 10, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.046 sec - in 
com.cloud.utils.ScriptTest
Running com.cloud.utils.TestProfiler
Configure log4j with default properties
2016-02-02 17:13:11,231 INFO  [cloud.utils.TestProfiler] (main:) testProfiler() 
started
2016-02-02 17:13:12,242 INFO  [cloud.utils.TestProfiler] (main:) Duration in 
Millis: 1010
2016-02-02 17:13:12,242 INFO  [cloud.utils.TestProfiler] (main:) testProfiler() 
stopped
Configure log4j with default properties
Configure log4j with default properties
2016-02-02 17:13:13,274 INFO  [cloud.utils.TestProfiler] (main:) Duration in 
Nano: 1010153737
Configure log4j with default properties
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.067 sec - in 
com.cloud.utils.TestProfiler
Running com.cloud.utils.net.NetUtilsTest
2016-02-02 17:13:13,316 INFO  [utils.net.NetUtils] (main:) Invalid value of 
cidr 10.3.6.5/50
2016-02-02 17:13:13,326 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::2
2016-02-02 17:13:13,327 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::2
2016-02-02 17:13:13,329 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::2
2016-02-02 17:13:13,330 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::1
2016-02-02 17:13:13,332 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::1
2016-02-02 17:13:13,334 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::d2da:3baa:2688:4166
2016-02-02 17:13:13,337 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::5f81:6288:a540:5ca0
2016-02-02 17:13:13,338 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::e860:b732:a35d:1fd5
2016-02-02 17:13:13,340 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::d4bc:dd99:983:dc07
2016-02-02 17:13:13,341 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::58af:16c2:12a2:ced1
2016-02-02 17:13:13,343 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::d4ff:913e:a129:66d6
2016-02-02 17:13:13,344 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::3a98:7108:da36:381f
2016-02-02 17:13:13,346 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::78e2:a686:b340:abd2
2016-02-02 17:13:13,348 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::fb04:a033:9e6a:92f
2016-02-02 17:13:13,349 INFO  [utils.net.NetUtilsTest] (main:) IP is 
1234:5678::bced:4efc:81dd:aa54
2016-02-02 17:13:13,368 ERROR [utils.net.NetUtils] (main:) empty cidr can not 
be converted to longs
com.cloud.utils.exception.CloudRuntimeException: empty cidr can not be 
converted to longs
at com.cloud.utils.net.NetUtils.cidrToLong(NetUtils.java:887)
at com.cloud.utils.net.NetUtils.isNetworksOverlap(NetUtils.java:1174)
at 
com.cloud.utils.net.NetUtilsTest.testIsNetworksOverlapWithEmptyValues(NetUtilsTest.java:509)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRun

[GitHub] cloudstack pull request: [4.7] VMware boot order fix

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1395

[4.7] VMware boot order fix

In case of VMware, since root disk needs to be first in the hdd boot order, 
we
collect list of hdds and create a hdd boot order with the root disk as the 
first
disk. This fixes a rare edge case where VMs would stop booting due to 
changed
boot order in hdds.

For sanity, we want cdroms to boot first, then hdds, floppies etc.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.7-vmware-boot-order

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1395


commit 2e01b37af4404db2c26deaaba9e6bf74c8381b0a
Author: Rohit Yadav 
Date:   2016-01-29T16:30:51Z

vmware: specify hdd boot order based on disk device bus name

In case of VMware, since root disk needs to be first in the hdd boot order, 
we
collect list of hdds and create a hdd boot order with the root disk as the 
first
disk. This fixes a rare edge case where VMs would stop booting due to 
changed
boot order in hdds.

For sanity, we want cdroms to boot first, then hdds, floppies etc.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1394

CLOUDSTACK-9268: Display VM in Load balancing rule in UI

Steps of Repro:
=
1:Create VMs 
2:Make LoadBalancing rule in GUI 
ãName:WWW 
ãPrivatePort:80 
ãPublicPort:80 
ãAdd VMs:some VMs

Expected Result:
==
The VMs which has been already assigned is should not be listed when you 
add the VM to an existing rule.

Actual Result:
===
The VMs which has been already assigned is still being listed when you add 
the VM to an existing rule.

Fix:
===
Added jsonObj to newly created row in multiedit.js to stop listing the same 
VM again.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin 
CloudStack-Nitin25_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1394


commit a68918fef7746823f79e096a70d136d2b4f31921
Author: Nitin Kumar Maharana 
Date:   2016-02-02T17:24:53Z

CLOUDSTACK-9268: Display VM in Load balancing rule in UI

Added jsonObj to newly created row in multiedit.js to stop listing the same 
VM again.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1365#issuecomment-178696450
  
@GabrielBrascher thanks, fixed the accessor 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1385#issuecomment-178702561
  
LGTM (just did code review, no regression tests)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: framework/quota: Fix checkstyle issue

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1392#issuecomment-178703798
  
simple rename of an enum: LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1393#issuecomment-178705720
  
@bhaisaab could you move the version numbers to the root pom instead of 
updating the project poms?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1394#issuecomment-178706035
  
@nitin-maharana can you add a screenshot of the intended change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1393#issuecomment-178706313
  
@DaanHoogland sure will do this weekend, this was mostly edited by the 
maven versions plugin. Do you want to work on this, as you may have some 
version related changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] VMware boot order fix

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1395#issuecomment-178709268
  
 looks good, I cannot test this. Can you create a marvin test (or point one 
out) for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1393#issuecomment-178710383
  
I will integrate them, and make a PR to this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1394#issuecomment-178716448
  
Before Fix:
=
![before fix - 
nitin](https://cloud.githubusercontent.com/assets/12583725/12758734/c3c0a486-ca03-11e5-9a87-23556d249aaa.jpg)

After Fix:
===
![after fix - 
nitin](https://cloud.githubusercontent.com/assets/12583725/12758745/cf8ef5ec-ca03-11e5-9324-426e3aade6dd.jpg)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9269: Missing field for Switch...

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1396

CLOUDSTACK-9269: Missing field for Switch type for Management and Storage 
traffic types

Repro Steps:
===
Create an Advanced zone(VMware).
Configure physical network.
Edit traffic type (Management or Storage)
Observe the switch type dropdown list is missing.

If we choose Guest or Public the dropdown is visible. See the below 
snapshots.

Expected Result:
==
The list should be shown in case of Management and storage.

Actual Result:
===
The list is missing in case of management and storage.

Fix:
===
Showing vswitchtype for all traffic types in case of VMware.

Traffic Type - Guest:
=

![public-nitin](https://cloud.githubusercontent.com/assets/12583725/12759158/aec4d38e-ca05-11e5-911f-d8aa8cb995b7.jpg)

Traffic Type - Management (Issue):
=

![management-nitin](https://cloud.githubusercontent.com/assets/12583725/12759171/bff00e08-ca05-11e5-8051-c24f0952a321.jpg)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin 
CloudStack-Nitin26_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1396.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1396


commit 85f93b6f96dde24dfc47d1bbf77e0c44e02455ff
Author: Nitin Kumar Maharana 
Date:   2016-02-02T17:53:42Z

CLOUDSTACK-9269: Missing field for Switch type for Management and Storage 
traffic types

Showing vswitchtype for all traffic types in case of VMware.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-178750977
  
Reopened from https://github.com/apache/cloudstack/pull/1393 with the 
branch on ASF remote. cc @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1393#issuecomment-178750332
  
@DaanHoogland how about this, I close this PR; push the branch to asf 
remote and you continue on that branch keeping the same PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: framework/quota: Fix checkstyle issue

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1392#issuecomment-178752840
  
Thanks, closing and moving this commit to PR 
https://github.com/apache/cloudstack/pull/1397
As it tries to fix the issue that the other PR brings


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: framework/quota: Fix checkstyle issue

Github user bhaisaab closed the pull request at:

https://github.com/apache/cloudstack/pull/1392


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions and to...

Github user bhaisaab closed the pull request at:

https://github.com/apache/cloudstack/pull/1393


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1397

maven: Upgrade dependency versions

Updated most dependencies to latest minor releases, except:

- Gson 2.x
- Major spring framework version
- Servlet version
- Embedded jetty version
- Mockito version (beta)
- Mysql lib minor version upgrade (breaks mysql-ha plugin)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cloudstack 4.9-mvn-upgrade

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1397.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1397


commit 8a5fdfa381dcfcf263192acf5110b5d18a07f500
Author: Rohit Yadav 
Date:   2016-01-27T00:41:02Z

maven: Upgrade dependency versions

Updated most dependencies to latest minor releases, except:

- Gson 2.x
- Major spring framework version
- Servlet version
- Embedded jetty version
- Mockito version (beta)
- Mysql lib minor version upgrade (breaks mysql-ha plugin)

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-178759820
  
@DaanHoogland I've tested this and fix an issue, please feel free to make 
changes directly on this branch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9270: UI alignment gone bad in...

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1398

CLOUDSTACK-9270: UI alignment gone bad in multiple places - VM Instance, 
Network, Egress rules

Steps to Repro:

Please see the snapshots attached. 

Fix:
===
Now it breaks into two lines once the word goes out of the box.
Fixed the advanced search field issue.

Network Section:
=

![network-section-nitin](https://cloud.githubusercontent.com/assets/12583725/12762032/66f27d32-ca13-11e5-8d0a-9c8f99a12a99.png)

Adding VM to LB Rule:
==

![adding-vm-to-lb-rule-nitin](https://cloud.githubusercontent.com/assets/12583725/12762050/76083cd0-ca13-11e5-873d-0037bc13a444.png)

Affinity Group Section:
==

![affinity-group-section-nitin](https://cloud.githubusercontent.com/assets/12583725/12762066/881c2a1c-ca13-11e5-8905-f72676151130.png)

Fixed Affinity Group Section:
==

![fix-affinity-group-section-nitin](https://cloud.githubusercontent.com/assets/12583725/12762083/990a673a-ca13-11e5-9d63-f895f9a1875c.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin 
CloudStack-Nitin23_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1398.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1398


commit 7c7bee8bbaab58aab6d0f9eaf3b8c60cf45866a1
Author: Nitin Kumar Maharana 
Date:   2016-02-02T19:39:36Z

CLOUDSTACK-9270: UI alignment gone bad in multiple places - VM Instance, 
Network, Egress rules

Now it breaks into two lines once the word goes out of the box.
Fixed the advanced search field issue.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : build-master-slowbuild #3138

2016-02-02 Thread jenkins

See

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

2016-02-02 Thread dmytro-shevchenko

Github user dmytro-shevchenko commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-178890524
  
Done, rebased with 4.9xx master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9272: No option in UI to add G...

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1399

CLOUDSTACK-9272: No option in UI to add GSLB with service type "HTTP"

Steps to Repro:

Go to Regions -> Local -> View GSLB -> Add GSLB
Click on the service type dropdown
Observe http is missing. Please see the attached snapshot.

Expected Behaviour:

As it supports http also, So http should be in the list.

Actual Behaviour:
==
http is missing from the list.

Fix:
===
It supports http also. Added http to the list.

Snapshot:

https://cloud.githubusercontent.com/assets/12583725/12772818/21513dc0-ca5b-11e5-822e-e2dd2426da65.png";>


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin 
CloudStack-Nitin21_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1399


commit 990e42f61b5408d1da2937bff5e67220633f3c16
Author: Nitin Kumar Maharana 
Date:   2016-02-03T04:22:13Z

CLOUDSTACK-9272: No option in UI to add GSLB with service type "HTTP"

It supports http also. Added http to the list.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

2016-02-02 Thread cloudsadhu

Github user cloudsadhu commented on the pull request:

https://github.com/apache/cloudstack/pull/691#issuecomment-179025093
  
for same issue Another PR created and checked in master so closing this PR 
request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

2016-02-02 Thread cloudsadhu

Github user cloudsadhu closed the pull request at:

https://github.com/apache/cloudstack/pull/691


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8830 : VM snapshot creation fa...

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1377#discussion_r51680970
  
--- Diff: test/integration/component/test_escalations_snapshots.py ---
@@ -152,6 +156,34 @@ def __verify_values(self, expected_vals, actual_vals):

   ))
 return return_flag
 
+def createInstance(self, service_off, networks=None, api_client=None):
+"""Creates an instance in account"""
+
+if api_client is None:
+api_client = self.apiclient
+
+self.debug("Deploying an instance in account: %s" %
+   self.account.name)
+try:
+vm = VirtualMachine.create(
+ api_client,
+ self.services["virtual_machine"],
+ templateid=self.template.id,
+ accountid=self.account.name,
+ domainid=self.account.domainid,
+ networkids=networks,
+ serviceofferingid=service_off.id)
+vms = VirtualMachine.list(api_client, id=vm.id, listall=True)
+self.assertIsInstance(vms,
--- End diff --

replace with validateList


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8830 : VM snapshot creation fa...

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1377#discussion_r51681219
  
--- Diff: test/integration/component/test_escalations_snapshots.py ---
@@ -639,3 +671,47 @@ def test_04_list_vm_snapshots_byid(self):
  "Listed VM Snapshot details are not as expected"
  )
 return
+
+@attr(tags=["advanced", "basic"], required_hardware="true")
+def test_05_check_vm_snapshot_creation_after_Instance_creation(self):
+"""
+@summary: Test  if SS creation is successful in the first
+10 minutes of VM deployment
+
+Step1: Create a VM with any Service offering
+Step2: Create a VM snapshot
+Step3: Verify if SS creation is successful within first
+   10 minutes of VM deployment
+"""
+if self.hypervisor.lower() not in ['vmware']:
+raise unittest.SkipTest("This test case is only for vmware. 
Hence, skipping the test")
--- End diff --

Can you replace with skipTest  to avoid raising an exception?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8830 : VM snapshot creation fa...

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1377#discussion_r51681502
  
--- Diff: test/integration/component/test_escalations_snapshots.py ---
@@ -639,3 +671,47 @@ def test_04_list_vm_snapshots_byid(self):
  "Listed VM Snapshot details are not as expected"
  )
 return
+
+@attr(tags=["advanced", "basic"], required_hardware="true")
+def test_05_check_vm_snapshot_creation_after_Instance_creation(self):
+"""
+@summary: Test  if SS creation is successful in the first
+10 minutes of VM deployment
+
+Step1: Create a VM with any Service offering
+Step2: Create a VM snapshot
+Step3: Verify if SS creation is successful within first
+   10 minutes of VM deployment
+"""
+if self.hypervisor.lower() not in ['vmware']:
+raise unittest.SkipTest("This test case is only for vmware. 
Hence, skipping the test")
+
+api_client = self.testClient.getUserApiClient(
+UserName=self.account.name,
+DomainName=self.account.domain)
+
+vm = self.createInstance(service_off=self.service_offering, 
api_client=api_client)
+start_time = time.time()
+
+
+snapshot_created_1 = VmSnapshot.create(
+ self.userapiclient,
+ vm.id
+ )
+self.assertIsNotNone(
+snapshot_created_1,
+"Snapshot creation failed"
+ )
+
+time_elapsed = time.time()-start_time
+
+self.assertTrue(
+time_elapsed < 600,
+"Snapshot did not get created in the first 10 
minutes after VM creation"
+)
+
--- End diff --

Remove all the white spaces


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

2016-02-02 Thread priyankparihar

Github user priyankparihar commented on the pull request:

https://github.com/apache/cloudstack/pull/1302#issuecomment-179028659
  
Hi, 
@alexandrelimassantana thanks for notifying. I have made modification,  
according to your suggestion. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

2016-02-02 Thread shwetaag

Github user shwetaag commented on the pull request:

https://github.com/apache/cloudstack/pull/1199#issuecomment-179035607
  
Did code review. Code looks  good to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9066: Update testpath to delet...

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1078#issuecomment-179054474
  
LGTM based on code review!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9168: Testpath to check if wro...

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1245#discussion_r51685979
  
--- Diff: test/integration/testpaths/testpath_netmask.py ---
@@ -0,0 +1,152 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test cases to Check Snapshots size in database
+"""
+
+import re
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  )
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   )
+
+
+class TestCheckNetmask(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestCheckNetmask, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+if cls.hypervisor.lower() not in ["xenserver"]:
+cls.skiptest = True
+return
+
+try:
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+
+# Create Service offering
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+)
+cls._cleanup.append(cls.service_offering)
+
+cls.vm = VirtualMachine.create(
+cls.apiclient,
+cls.testdata["small"],
+templateid=cls.template.id,
+accountid=cls.account.name,
+domainid=cls.account.domainid,
+serviceofferingid=cls.service_offering.id,
+zoneid=cls.zone.id,
+mode=cls.zone.networktype
+)
+
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+if self.skiptest:
+self.skipTest(
+"Test not to be run on %s" %
+self.hypervisor)
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.cleanup = []
+
+def tearDown(self):
+try:
+cleanup_resources(self.apiclient, self.cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+return
+
+@attr(tags=["basic"], required_hardware="false")
+def

[GitHub] cloudstack pull request: CLOUDSTACK-9168: Testpath to check if wro...