[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread ustcweizhou
Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1034#issuecomment-155352944
  
@remibergsma @karuturi 
For the isolated network and shared network, the guest NIC of VR is listed 
at the top of NIC tab.
However, for VPC VR, the guest NICs are listed at the bottom of NIC tab, 
the network name is missing for VPC tiers.
Sorry the description of the commit was not clear.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2015-11-10 Thread wido
GitHub user wido opened a pull request:

https://github.com/apache/cloudstack/pull/1054

CLOUDSTACK-8818: Use MySQL native connector with Python

MySQLdb has been deprecated and is also not supported in Python 3.

mysql.connector is a connector written in Python which talks the
native MySQL protocol without any external code.

https://dev.mysql.com/doc/connector-python/en/

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wido/cloudstack CLOUDSTACK-8818

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1054.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1054


commit 4a90b2e1124778c624a71e43bd0c3bc74733d096
Author: Wido den Hollander 
Date:   2015-11-10T08:04:48Z

CLOUDSTACK-8818: Use MySQL native connector with Python

MySQLdb has been deprecated and is also not supported in Python 3.

mysql.connector is a connector written in Python which talks the
native MySQL protocol without any external code.

https://dev.mysql.com/doc/connector-python/en/




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2015-11-10 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1054#issuecomment-155353598
  
Pylint result:

```
Global evaluation
-
Your code has been rated at 6.48/10 (previous run: 6.48/10, +0.00)
```

I also wrote a small test script:

```
from db import Database

db = Database(username='root', password='')

try:
db.testConnection()
print("Succes!")
except:
raise
```

The result:

```
wido@wido-laptop:~/repos/cloudstack/python/lib/cloudutils$ python 
smallthin.py 
Succes!
wido@wido-laptop:~/repos/cloudstack/python/lib/cloudutils$
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155356678
  
Just tested and managed to deploy the management server without issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155357693
  
@davidamorimfaria Thanks, will retest soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: New PMC member: Erik Weber

2015-11-10 Thread Paul Angus
Congratulations Erik.

Regards,

Paul Angus
VP Technology/Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
paul.an...@shapeblue.com

-Original Message-
From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com]
Sent: 10 November 2015 05:09
To: dev@cloudstack.apache.org
Cc: Erik Weber 
Subject: Re: New PMC member: Erik Weber

Congrats Erik !

Thanks,
Jayapal
> On 30-Oct-2015, at 7:31 pm, Giles Sirett  wrote:
>
> All
> The PMC is delighted to announce that we have asked Erik weber to join
> the PMC and he has accepted
>
> Please join me in congratulating Erik
>
> Kind Regards
> Giles
>
> D: +44 20 3603 0541 | M: +44 796 111
> 2055
> giles.sir...@shapeblue.com
> Find out more about ShapeBlue and our range of CloudStack related
> services
>
> IaaS Cloud Design &
> Build
> CSForge – rapid IaaS deployment
> framework
> CloudStack Consulting
> CloudStack Software
> Engineering
> CloudStack Infrastructure
> Support
> CloudStack Bootcamp Training
> Courses
>
> This email and any attachments to it may be confidential and are intended 
> solely for the use of the individual to whom it is addressed. Any views or 
> opinions expressed are solely those of the author and do not necessarily 
> represent those of Shape Blue Ltd or related companies. If you are not the 
> intended recipient of this email, you must neither take any action based upon 
> its contents, nor copy or show it to anyone. Please contact the sender if you 
> believe you have received this email in error. Shape Blue Ltd is a company 
> incorporated in England & Wales. ShapeBlue Services India LLP is a company 
> incorporated in India and is operated under license from Shape Blue Ltd. 
> Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
> operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
> registered by The Republic of South Africa and is traded under license from 
> Shape Blue Ltd. ShapeBlue is a registered trademark.

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.


[GitHub] cloudstack-docs-install pull request: include argument for tomcat7...

2015-11-10 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request:

https://github.com/apache/cloudstack-docs-install/pull/24

include argument for tomcat7 servlet container

include argument for tomcat7 servlet container during management server 
setup

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davidamorimfaria/cloudstack-docs-install 
CLOUDSTACK-9049

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-install/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit 418db90bc286fed10aba7b4952b7f9a4b0006ea8
Author: David Amorim Faria 
Date:   2015-11-10T09:17:34Z

include argument for tomcat7 servlet container during management server 
setup




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155368243
  
validated the build and install with centos7. validation on centos6 started


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155371923
  
added pr for docs-install 
https://github.com/apache/cloudstack-docs-install/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1034#issuecomment-155375779
  
@ustcweizhou and what about the ACL button?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1046#issuecomment-155378548
  
Ping @remibergsma @borisroman 

This PR LGTM :+1: 

I reviewed the code and read the comments in the PR, also looking at the 
tests @borisroman did and the screenshots he shared.

@remibergsma, you can proceed with the merge.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: squashed commit for dockerfiles part#2 in...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/999


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1046


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155381433
  
LGTM, Tested on CentOS7 with Tomcat 7. 

The package builds fine:

```
+ exit 0
RPM Build Done
```

Install also works:

```
Installed:
  cloudstack-common.x86_64 0:4.6.0-SNAPSHOT.el7.centos  

  cloudstack-management.x86_64 0:4.6.0-SNAPSHOT.el7.centos  


Complete!
```

Setup, now requires `--tomcat7` as parameter:

```
[root@cs2 x86_64]# cloudstack-setup-management --tomcat7
Starting to configure CloudStack Management Server:
Configure Firewall ...[OK]
Configure CloudStack Management Server ...[OK]
CloudStack Management Server setup is Done!
```

Files in `/etc/`:

```
[root@cs2 management]# pwd
/etc/cloudstack/management
[root@cs2 management]# ls -la
total 136
drwxr-xr-x. 3 root root   4096 Nov 10 09:10 .
drwxr-xr-x. 3 root root   4096 Nov  9 17:06 ..
drwxrwx---. 3 root cloud  4096 Nov 10 09:06 Catalina
-rw-r--r--. 1 root root   8945 Nov 10 08:56 catalina.policy
-rw-r--r--. 1 root root   3794 Nov 10 08:56 catalina.properties
-rw-r--r--. 1 root root   1653 Nov 10 08:56 classpath.conf
-rw-r--r--. 1 root root   1357 Nov 10 08:56 commons-logging.properties
-rw-r-. 1 root cloud  3125 Nov 10 09:08 db.properties
-rw-r-. 1 root cloud  3125 Nov  9 21:27 db.properties.rpmsave
-rw-r--r--. 1 root root972 Nov 10 08:56 environment.properties
-rw-r--r--. 1 root root927 Nov 10 08:56 java.security.ciphers
-rw-r--r--. 1 root root  8 Nov 10 09:08 key
-rw-r--r--. 1 root root   7020 Nov 10 08:56 log4j-cloud.xml
-rw-r--r--. 1 root root   6722 Nov 10 08:56 server7-nonssl.xml
-rw-r--r--. 1 root root   7251 Nov 10 08:56 server7-ssl.xml
lrwxrwxrwx. 1 root root 45 Nov 10 09:10 server.xml -> 
/etc/cloudstack/management/server7-nonssl.xml
-rw-r--r--. 1 root root   1383 Nov 10 08:56 tomcat-users.xml
-rw-r--r--. 1 root root  50475 Nov 10 08:56 web.xml
```

Enabling and starting:

```
[root@cs2 management]# systemctl enable cloudstack-management
[root@cs2 management]# systemctl start cloudstack-management
[root@cs2 management]# systemctl status cloudstack-management
cloudstack-management.service - CloudStack Management Server
   Loaded: loaded (/usr/lib/systemd/system/cloudstack-management.service; 
enabled)
   Active: active (running) since Tue 2015-11-10 09:11:41 GMT; 5s ago
 Main PID: 12381 (java)
   CGroup: /system.slice/cloudstack-management.service
   └─12381 java -Djava.awt.headless=true 
-Dcom.sun.management.jmxremote=false -Xmx2g -XX:+HeapDumpOnOutOfMemoryError 
-XX:HeapDumpPath=/var/log/cloudstack/management/ -XX:PermSize=512M 
-XX:MaxPermSize=800m -cla...
```

Deployed data center:

![screen shot 2015-11-10 at 11 12 
42](https://cloud.githubusercontent.com/assets/1630096/11059897/e10bf918-879c-11e5-9a5e-dabe59523077.png)

![screen shot 2015-11-10 at 11 07 
15](https://cloud.githubusercontent.com/assets/1630096/11059898/e62216a8-879c-11e5-8ce8-8df715798d7c.png)

Currently running some Marvin tests and that looks good. Will post results 
later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9047 rename enums

2015-11-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1049#issuecomment-155381918
  
I will build this PR locally to make sure Maven runs the unit tests 
successfully.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155381911
  
Ping @PaulAngus to have a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread ustcweizhou
Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1034#issuecomment-155383672
  
@wilderrodrigues Please see attachment

![image](https://cloud.githubusercontent.com/assets/3204966/11060199/f9a00d5a-879e-11e5-92fe-044acdd3a2f7.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155384967
  
@davidamorimfaria Please squash the commits, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1034#issuecomment-155386360
  
Thanks, @ustcweizhou ... this PR LGTM :+1: 

@remibergsma, I believe it's ready to be merged.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155389434
  
squashed



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/1034#issuecomment-155389974
  
Thanks @ustcweizhou LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1034


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/1055

CLOUDSTACK-9023 filtering privatekey info from logging

tested off-line but rebased afterwards!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9023

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1055.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1055


commit a580330864780582ec33d723c7da044d935d4f22
Author: Daan Hoogland 
Date:   2015-11-05T13:23:11Z

CLOUDSTACK-9023 filtering privatekey info from logging




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1055#issuecomment-155391693
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
[root@cs1 MarvinLogs]# cat test_network_XFGU4E/results.txt 
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 29 tests in 12467.478s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smo

[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland closed the pull request at:

https://github.com/apache/cloudstack/pull/1055


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155395711
  
LGTM on centos 6:
```
[root@cs3 x86_64]# cloudstack-setup-databases cloud:password@localhost 
--deploy-as=root
Mysql user name:cloud   
[ OK ]
Mysql user password:**  
[ OK ]
Mysql server ip:localhost   
[ OK ]
Mysql server port:3306  
[ OK ]
Mysql root user name:root   
[ OK ]
Mysql root user password:** 
[ OK ]
Checking Cloud database files ...   
[ OK ]
Checking local machine hostname ... 
[ OK ]
Checking SELinux setup ...  
checkSelinux failed with error continuing...
SELinux is set to enforcing. There are two options:
1> Set it permissive in /etc/selinux/config, then reboot the machine.
2> Type 'setenforce Permissive' in commandline, after which you can run 
this program again.

We strongly suggest you doing the option 1 that makes sure SELinux goes 
into permissive after system reboot.
[ OK ]
Detected local IP address as 192.168.22.63, will use as cluster management 
server node IP[ OK ]
Preparing /etc/cloudstack/management/db.properties  
[ OK ]
Applying /usr/share/cloudstack-management/setup/create-database.sql 
[ OK ]
Applying /usr/share/cloudstack-management/setup/create-schema.sql   
[ OK ]
Applying /usr/share/cloudstack-management/setup/create-database-premium.sql 
[ OK ]
Applying /usr/share/cloudstack-management/setup/create-schema-premium.sql   
[ OK ]
Applying /usr/share/cloudstack-management/setup/server-setup.sql
[ OK ]
Applying /usr/share/cloudstack-management/setup/templates.sql   
[ OK ]
Processing encryption ...   
[ OK ]
Finalizing setup ...
[ OK ]

CloudStack has successfully initialized database, you can check your 
database configuration in /etc/cloudstack/management/db.properties

[root@cs3 x86_64]# cloudstack-setup-management
Starting to configure CloudStack Management Server:
Configure Firewall ...[OK]
Configure CloudStack Management Server ...[OK]
CloudStack Management Server setup is Done!
[root@cs3 x86_64]#
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread DaanHoogland
GitHub user DaanHoogland reopened a pull request:

https://github.com/apache/cloudstack/pull/1055

CLOUDSTACK-9023 filtering privatekey info from logging

tested off-line but rebased afterwards!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9023

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1055.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1055


commit a580330864780582ec33d723c7da044d935d4f22
Author: Daan Hoogland 
Date:   2015-11-05T13:23:11Z

CLOUDSTACK-9023 filtering privatekey info from logging




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/935#issuecomment-155396401
  
@nvazquez I've built and tested your PR in our environment and the 
functionality we have tests for remains stable. :+1: 

What I did:

1. build and unit-test with developer and systemvm profiles

2. package centos7 KVM agent RPMs

3. deploy infra with

   - 1 mangement server (war installed from step 1)
   - 2 NSX controllers (cluster)
   - 1 NSX manger node
   - 1 NSX service node
   - 1 KVM host (agent installed from step 2)

4. deploy data center using 
[this](https://github.com/schubergphilis/MCT-shared/blob/master/marvin/mct-zone1-kvm1-NVP.cfg)
 config

5. run marvin tests from `test/integration/smoke/test_nicira_controller.py` 
with flags `tags=advanced,required_hardware=true`

Result
```
[root@cs1 cloudstack]# nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-NVP.cfg -s -a 
tags=advanced,required_hardware=true 
test/integration/smoke/test_nicira_controller.py

 Marvin Init Started 

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

 Log Folder Path: /tmp//MarvinLogs//Nov_10_2015_10_27_55_46U497. All 
logs will be available here 

=== Marvin Init Logging Successful===

 Marvin Init Successful 

/usr/lib/python2.7/site-packages/requests/packages/urllib3/util/ssl_.py:100: 
InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to fail. For more information, see 
https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
(previous warning repeated a couple times)
=== TestName: test_01_nicira_controller | Status : SUCCESS ===

=== TestName: test_02_nicira_controller_redirect | Status : SUCCESS ===

===final results are now copied to: 
/tmp//MarvinLogs/test_nicira_controller_RV74VA===

```

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix the new line bug (invalid char on UI)...

2015-11-10 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/1053#issuecomment-155398572
  
verified in spanish and english that that UI loads fine. did not see any js 
errors in spanish. 
LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/1055#issuecomment-155403829
  
did a mvn build on the pr and manually verified the api call. the private 
key isn't logged anymore.

before
```
2015-11-10 17:13:18,462 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(API-Job-Executor-3:ctx-74dad1b6 job-799) Executing AsyncJobVO {id:799, userId: 
2, accountId: 2, instanceType: None, instanceId: null, cmd: 
org.apache.cloudstack.api.command.admin.resource.UploadCustomCertificateCmd, 
cmdInfo: 
{"sessionkey":"UZeTJmhKlSkEyt9O1H0QceBb3yI","cmdEventType":"UPLOAD.CUSTOM.CERTIFICATE","ctxUserId":"2","signatureversion":"3","httpmethod":"GET","response":"json","domainsuffix":"abc.com","ctxDetails":"{}","certificate":"123","expires":"2015-11-10T12:04:08+","ctxAccountId":"2","ctxStartEventId":"2089","privatekey":"private123"},
 cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
null, initMsid: 233845178473200, completeMsid: null, lastUpdated: null, 
lastPolled: null, created: null}
```

after
```
2015-11-10 17:22:59,986 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(API-Job-Executor-1:ctx-3c64d80b job-800) Executing AsyncJobVO {id:800, userId: 
2, accountId: 2, instanceType: None, instanceId: null, cmd: 
org.apache.cloudstack.api.command.admin.resource.UploadCustomCertificateCmd, 
cmdInfo: 
{"sessionkey":"9kO_Di2wrf2ekMKCYrveEjCtTg8","cmdEventType":"UPLOAD.CUSTOM.CERTIFICATE","ctxUserId":"2","signatureversion":"3","httpmethod":"GET","response":"json","domainsuffix":"abc.com","ctxDetails":"{}","certificate":"123","expires":"2015-11-10T12:13:49+","ctxAccountId":"2","ctxStartEventId":"2091",},
 cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
null, initMsid: 233845178473200, completeMsid: null, lastUpdated: null, 
lastPolled: null, created: null}
```

LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155404689
  
Verified RPM build after squash to be sure:

```
+ exit 0
RPM Build Done
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/1056

CID-1338387: paranoia null checking



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CID-1338387

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1056.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1056


commit 7b76cd2fb40d7b26bd786a4a0f8724d8c316a9d3
Author: Daan Hoogland 
Date:   2015-11-10T11:53:35Z

CID-1338387: paranoia null checking




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155405695
  
Executed a few tests just to see if it actually does something:

```
Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
ok
```

It is still running the tests against the RPM deployed CentOS 7 box. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1052#issuecomment-155406515
  
Verified with @dahn that `cloudstack-management` started on CentOS 6 as 
well and that he was able to use the UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1052


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155409591
  
Wouldn't it be better to make sure 
`endPointSelector.selectHypervisorHost(...)` never returns null?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1055#issuecomment-155410264
  
I'm testing this PR with a 2 KVM host setup to run a set of basic Marvin 
tests. Will also grep the logs for the private key.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix the new line bug (invalid char on UI)...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1053#issuecomment-155410386
  
going to trust the translator: lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155410755
  
It was put in there explicitely (return null;) so i trusted the intention. 
a review of the architecture could be justified.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix the new line bug (invalid char on UI)...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1053


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155411442
  
That intention opens up an entire category of errors, null dereferencing). 
In addition forces defensive coding, just like what you introduce in this PR.
Why not try to, incrementally, move away from that instead of capitulating 
it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1055#issuecomment-155412998
  
@DaanHoogland sent me the below patch the other day and I run some tests on 
it. Just FYI the results (he rebased later and made a PR). The commit hash 
obviously doesn't match as it was my temp patch apply commit.

The patch I tested:
```
commit cad68778d8714a5359e3fa79a33d05206e032fea
Author: root 
Date:   Mon Nov 9 12:40:36 2015 +

   private key security fix received from Daan

diff --git 
a/api/src/org/apache/cloudstack/api/command/admin/resource/UploadCustomCertificateCmd.java
 
b/api/src/org/apache/cloudstack/api/command/admin/resource/UploadCustomCertificateCmd.java
index e11876a..e8d6cc5 100644
--- 
a/api/src/org/apache/cloudstack/api/command/admin/resource/UploadCustomCertificateCmd.java
+++ 
b/api/src/org/apache/cloudstack/api/command/admin/resource/UploadCustomCertificateCmd.java
@@ -32,7 +32,7 @@ import com.cloud.user.Account;
 @APICommand(name = "uploadCustomCertificate",
 responseObject = CustomCertificateResponse.class,
 description = "Uploads a custom certificate for the console 
proxy VMs to use for SSL. Can be used to upload a single certificate signed by 
a known CA. Can also be used, through mu
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = 
false)
+requestHasSensitiveInfo = true, responseHasSensitiveInfo = 
false)
 public class UploadCustomCertificateCmd extends BaseAsyncCmd {
 public static final Logger s_logger = 
Logger.getLogger(UploadCustomCertificateCmd.class.getName());
 
diff --git a/utils/src/main/java/com/cloud/utils/StringUtils.java 
b/utils/src/main/java/com/cloud/utils/StringUtils.java
index c598be8..71cebe1 100644
--- a/utils/src/main/java/com/cloud/utils/StringUtils.java
+++ b/utils/src/main/java/com/cloud/utils/StringUtils.java
@@ -186,7 +186,7 @@ public class StringUtils {
 private static final Pattern REGEX_PASSWORD_QUERYSTRING = 
Pattern.compile("(&|%26)?[^(&|%26)]*((p|P)assword|accesskey|secretkey)(=|%3D).*?(?=(%26|[&'\"]|$))");
 
 // removes a password/accesskey/ property from a response json object
-private static final Pattern REGEX_PASSWORD_JSON = 
Pattern.compile("\"((p|P)assword|accesskey|secretkey)\":\\s?\".*?\",?");
+private static final Pattern REGEX_PASSWORD_JSON = 
Pattern.compile("\"((p|P)assword|privatekey|accesskey|secretkey)\":\\s?\".*?\",?");
 
 private static final Pattern REGEX_PASSWORD_DETAILS = 
Pattern.compile("(&|%26)?details(\\[|%5B)\\d*(\\]|%5D)\\.key(=|%3D)((p|P)assword|accesskey|secretkey)(?=(%26|[&'\"]))");
```

Tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
Result:
```
[root@cs1 MarvinLogs]# cat test_network_XFGU4E/results.txt 
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test

Re: [GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread Daan Hoogland
sure

On Tue, Nov 10, 2015 at 1:47 PM, miguelaferreira  wrote:

> Github user miguelaferreira commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1056#issuecomment-155411442
>
> That intention opens up an entire category of errors, null
> dereferencing). In addition forces defensive coding, just like what you
> introduce in this PR.
> Why not try to, incrementally, move away from that instead of
> capitulating it?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>



-- 
Daan


[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155415964
  
@DaanHoogland I agree with @miguelaferreira.
I have looked that code.
The select it runs is the following: 
select h.id from host h where h.status = 'Up' and h.hypervisor_type is not 
null  and h.data_center_id = ? ORDER by rand() limit 1

That makes me wondering, why ordering by random the projection?! That can 
make problems harder to debug. Whatever, that is not the focus here.
The only ways I see that select returning nothing are the following:
• If we have no hosts in the zone;
• If all of the hosts have hypervisor_type equal to null, is it even 
possible to have a host with hypervisor_type = null?
I would be concerned about the first case, a zone with no hosts. Thus, we 
should have to check when the method 
“com.cloud.hypervisor.ovm3.resources.Ovm3HypervisorGuru.performSideEffectsForDelegationOnCommand(long,
 Command)” is called. 
What API method ends up in that code, or what action of ACS is going 
execute it?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-install pull request: include argument for tomcat7...

2015-11-10 Thread pdion891
Github user pdion891 commented on the pull request:


https://github.com/apache/cloudstack-docs-install/pull/24#issuecomment-155416905
  
LGTM,  we need to update the doc for 4.6.0 this PR must be in the 4.6 
branch of the doc and master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

2015-11-10 Thread nvazquez
Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/935#issuecomment-155418071
  
@wilderrodrigues Thanks a lot Wilder!

@miguelaferreira Thanks for following this PR and testing it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1055#issuecomment-155426180
  
Jenkins error seems unrelated:

```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on 
project cloud-server: Execution default-test of goal 
org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test failed: The forked 
VM terminated without properly saying goodbye. VM crash or System.exit called?
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


cloudstack vulnerable by COLLECTIONS-580?

2015-11-10 Thread Rene Moser
Hi

This security issue came to my attention:
https://issues.apache.org/jira/browse/COLLECTIONS-580

See
http://foxglovesecurity.com/2015/11/06/what-do-weblogic-websphere-jboss-jenkins-opennms-and-your-application-have-in-common-this-vulnerability/
for more background information.

I am not sure if cloudstack is affected, at least we have dependency to
this vulnerable lib:

 $ grep -Rl InvokerTransformer .
./plugins/hypervisors/kvm/target/dependencies/commons-collections-3.2.1.jar
./client/target/cloud-client-ui-4.5.2.war
./client/target/cloud-client-ui-4.5.2/WEB-INF/lib/commons-collections-3.2.1.jar
./usage/target/dependencies/commons-collections-3.2.1.jar
./agent/target/dependencies/commons-collections-3.2.jar
./engine/service/target/engine/WEB-INF/lib/commons-collections-3.2.jar

Thanks for clarification.

Yours
René


[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1055#issuecomment-155431369
  
JVM died:
```
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.324 sec - 
in org.apache.cloudstack.privategw.AclOnPrivateGwTest
Running org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest
#
# A fatal error has been detected by the Java Runtime Environment:
#
SUREFIRE-859: #  SIGSEGV (0xb) at pc=0xada6f654, pid=21145, tid=4136938304
#
# JRE version: 7.0_25-b15
# Java VM: Java HotSpot(TM) Server VM (23.25-b01 mixed mode linux-x86 )
# Problematic frame:
# C  [libnet.so+0x14654]  _fini+0x1d0c
#
SUREFIRE-859: # Failed to write core dump. Core dumps have been disabled. 
To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# 
/home/jenkins/jenkins-slave/workspace/cloudstack-pull-analysis/server/hs_err_pid21145.log
#
SUREFIRE-859: # If you would like to submit a bug report, please visit:
#   http://bugreport.sun.com/bugreport/crash.jsp
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#
Aborted
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Jeff Hair
Hi,

We are setting up an internal Maven repository to speed up our inhouse
builds that depend on CloudStack on the 4.5 branch (which contains
4.5.3-SNAPSHOT right now).

It's mostly working, but we are running into something very strange with
the checkstyle dependency. After uploading all artifacts with mvn deploy,
our repository server is directing mvn to go to
repository.apache.org/snapshots in order to download the checkstyle
dependency... which of course does not exist.

Has anyone gone through the experience of putting CloudStack SNAPSHOT
artifacts into an in-house Maven repository?


Re: Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Jeff Hair
Also, mirroring is probably not the best term. We are not mirroring the
build artifacts from the official build servers. We are attempting to
deploy artifacts produced by our build system into Archiva.

On Tue, Nov 10, 2015 at 2:23 PM, Jeff Hair  wrote:

> Hi,
>
> We are setting up an internal Maven repository to speed up our inhouse
> builds that depend on CloudStack on the 4.5 branch (which contains
> 4.5.3-SNAPSHOT right now).
>
> It's mostly working, but we are running into something very strange with
> the checkstyle dependency. After uploading all artifacts with mvn deploy,
> our repository server is directing mvn to go to
> repository.apache.org/snapshots in order to download the checkstyle
> dependency... which of course does not exist.
>
> Has anyone gone through the experience of putting CloudStack SNAPSHOT
> artifacts into an in-house Maven repository?
>



-- 
*Jeff Hair*
Technical Lead and Software Developer

Tel: (+354) 415 0200
j...@greenqloud.com
www.greenqloud.com


[Proposal] Template for CloudStack API Reference Pages

2015-11-10 Thread Rajsekhar K
Hi, All,

This is the proposal for a new template for CloudStack API reference pages.
This template is based on the reference page templates for REST APIs.

Please find attached the following documents for your review:

   - Template for normal and asynchronous CloudStack API references.
   - Sample API reference page using the template for a CloudStack API
   (listZones).


Please review this template and let me know your thoughts on this.

Thanks,
Rajsekhar


api-reference-template-version1.docx
Description: MS-Word 2007 document


listZones-sample-api.docx
Description: MS-Word 2007 document


[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1055


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-10 Thread Remi Bergsma
Hi all,

I've created a 4.6.0 release candidate, with the following artifacts up for a 
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151110T1545

Commit: e31ade03c66368c64f0cd66cb7b0b754cddfb79d

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/

PGP release keys (signed using A47DDC4F):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for at least 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate 
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)



[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2015-11-10 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1054#issuecomment-155444641
  
"Apache CloudStack Server" has failed says Jenkins. I don't see a failed 
test though?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...

2015-11-10 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1051#issuecomment-155444948
  
LGTM

Trivial fix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-10 Thread Remi Bergsma
FYI: Jenkins was so kind to build us some packages, should we want to use them:

CentOS 7 packages
http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter-centos7/3/

CentOS 6 packages
http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter/22/

Maybe Boris can build some Ubuntu packages, please?


Regards,
Remi




On 10/11/15 16:03, "Remi Bergsma"  wrote:

>Hi all,
>
>I've created a 4.6.0 release candidate, with the following artifacts up for a 
>vote:
>
>Git Branch and Commit SH:
>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151110T1545
>
>Commit: e31ade03c66368c64f0cd66cb7b0b754cddfb79d
>
>Source release (checksums and signatures are available at the same
>location):
>https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/
>
>PGP release keys (signed using A47DDC4F):
>https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
>Vote will be open for at least 72 hours.
>
>For sanity in tallying the vote, can PMC members please be sure to indicate 
>"(binding)" with their vote?
>
>[ ] +1  approve
>[ ] +0  no opinion
>[ ] -1  disapprove (and reason why)
>


[GitHub] cloudstack pull request: Cwe 190

2015-11-10 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/1057

Cwe 190

coverity warnings of this type adressed. Some where dismissed and maybe 
with reason but it seemed possible to remove them and hence obligatory ;p

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CWE-190

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1057.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1057


commit 944e6eabdff9b01f8980277fbe5dda5228fa94ad
Author: Daan Hoogland 
Date:   2015-11-10T13:00:22Z

CID-1175714 casts before bit shift

commit a9e122c77227363f3f27dbea7d13b4110c07a96f
Author: Daan Hoogland 
Date:   2015-11-10T13:16:49Z

CID-1116485: cast cidr during bit shifting
 and simple test included

commit 17849c3b4b66a96c32d7ed8fb713f763ef19ee39
Author: Daan Hoogland 
Date:   2015-11-10T13:40:24Z

CID-1116484 cast to long and use long as cidrsize type
 and simpel test

commit 1559e351d2a56a33ee3d844ce4964e5c4420e439
Author: Daan Hoogland 
Date:   2015-11-10T13:54:52Z

CID-1116483 cidr to netmask bitshifts guarded with casts

 and simple test

commit f04b68c99c2d112b83617be7d51ac351a1882254
Author: Daan Hoogland 
Date:   2015-11-10T15:18:52Z

CID-1116482 cidrToLong cleanup of bitshift problem

 and some trivial testing




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155451132
  
@miguelaferreira @rafaelweingartner I totally agree with you that this can 
be dealt with better. I didn't want to give it a second thought as my intention 
is to get more coverity issues fixed then newly reported on every itteration. I 
am fine with not committing this as I first approached so will look into a 
better solution. please see #1057 and comment on that as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1054#issuecomment-155456551
  
@wido 
Running org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest
#
# A fatal error has been detected by the Java Runtime Environment:
#
SUREFIRE-859: #  SIGSEGV (0xb) at pc=0xadc1552c, pid=22362, tid=4136426304
#
# JRE version: 7.0_25-b15
# Java VM: Java HotSpot(TM) Server VM (23.25-b01 mixed mode linux-x86 )
# Problematic frame:
# C  [libnet.so+0x352c]  _init+0x620
#
SUREFIRE-859: # Failed to write core dump. Core dumps have been disabled. 
To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# 
/home/jenkins/jenkins-slave/workspace/cloudstack-pull-analysis/server/hs_err_pid22362.log
#
SUREFIRE-859: # If you would like to submit a bug report, please visit:
#   http://bugreport.sun.com/bugreport/crash.jsp
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

also see INFRA-10703 and vote for it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Daan Hoogland
Jeff, kicking in an open door: did you edit your .m2/settings.xml?

On Tue, Nov 10, 2015 at 3:27 PM, Jeff Hair  wrote:

> Also, mirroring is probably not the best term. We are not mirroring the
> build artifacts from the official build servers. We are attempting to
> deploy artifacts produced by our build system into Archiva.
>
> On Tue, Nov 10, 2015 at 2:23 PM, Jeff Hair  wrote:
>
> > Hi,
> >
> > We are setting up an internal Maven repository to speed up our inhouse
> > builds that depend on CloudStack on the 4.5 branch (which contains
> > 4.5.3-SNAPSHOT right now).
> >
> > It's mostly working, but we are running into something very strange with
> > the checkstyle dependency. After uploading all artifacts with mvn deploy,
> > our repository server is directing mvn to go to
> > repository.apache.org/snapshots in order to download the checkstyle
> > dependency... which of course does not exist.
> >
> > Has anyone gone through the experience of putting CloudStack SNAPSHOT
> > artifacts into an in-house Maven repository?
> >
>
>
>
> --
> *Jeff Hair*
> Technical Lead and Software Developer
>
> Tel: (+354) 415 0200
> j...@greenqloud.com
> www.greenqloud.com
>



-- 
Daan


Re: Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Jeff Hair
Yes. It's like this. Not all of this may make sense as I don't normally
have a custom MVN repo set up.
* Edited settings.xml to have a new  element which points to
archiva releases repo and archiva snapshots repo.
* Added mirrors for both the releases and snapshots repo.
* Deployed a built version of 4.5.3-SNAPSHOT to archiva using mvn deploy
* Wipe out local ~/.m2/repository and see what happens. This leads to the
error I described in the first post.

On Tue, Nov 10, 2015 at 3:34 PM, Daan Hoogland 
wrote:

> Jeff, kicking in an open door: did you edit your .m2/settings.xml?
>
> On Tue, Nov 10, 2015 at 3:27 PM, Jeff Hair  wrote:
>
> > Also, mirroring is probably not the best term. We are not mirroring the
> > build artifacts from the official build servers. We are attempting to
> > deploy artifacts produced by our build system into Archiva.
> >
> > On Tue, Nov 10, 2015 at 2:23 PM, Jeff Hair  wrote:
> >
> > > Hi,
> > >
> > > We are setting up an internal Maven repository to speed up our inhouse
> > > builds that depend on CloudStack on the 4.5 branch (which contains
> > > 4.5.3-SNAPSHOT right now).
> > >
> > > It's mostly working, but we are running into something very strange
> with
> > > the checkstyle dependency. After uploading all artifacts with mvn
> deploy,
> > > our repository server is directing mvn to go to
> > > repository.apache.org/snapshots in order to download the checkstyle
> > > dependency... which of course does not exist.
> > >
> > > Has anyone gone through the experience of putting CloudStack SNAPSHOT
> > > artifacts into an in-house Maven repository?
> > >
> >
> >
> >
> > --
> > *Jeff Hair*
> > Technical Lead and Software Developer
> >
> > Tel: (+354) 415 0200
> > j...@greenqloud.com
> > www.greenqloud.com
> >
>
>
>
> --
> Daan
>



-- 
*Jeff Hair*
Technical Lead and Software Developer

Tel: (+354) 415 0200
j...@greenqloud.com
www.greenqloud.com


infra ticket

2015-11-10 Thread Daan Hoogland
Please every body review https://issues.apache.org/jira/browse/INFRA-10703
and vote for it. The builders ubuntu-[2456] are constantly failing with
segv in java and make our live harder.

-- 
Daan


Re: Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Daan Hoogland
Jeff, I am definitely not god amongst maven users so I have to start
guessing now. It might be that you need to do magic in the pom for this to
work. or in MAVEN_OPTS. (what are the mirrors for? these are mirrors of
your local repo, right?)

On Tue, Nov 10, 2015 at 4:47 PM, Jeff Hair  wrote:

> Yes. It's like this. Not all of this may make sense as I don't normally
> have a custom MVN repo set up.
> * Edited settings.xml to have a new  element which points to
> archiva releases repo and archiva snapshots repo.
> * Added mirrors for both the releases and snapshots repo.
> * Deployed a built version of 4.5.3-SNAPSHOT to archiva using mvn deploy
> * Wipe out local ~/.m2/repository and see what happens. This leads to the
> error I described in the first post.
>
> On Tue, Nov 10, 2015 at 3:34 PM, Daan Hoogland 
> wrote:
>
> > Jeff, kicking in an open door: did you edit your .m2/settings.xml?
> >
> > On Tue, Nov 10, 2015 at 3:27 PM, Jeff Hair  wrote:
> >
> > > Also, mirroring is probably not the best term. We are not mirroring the
> > > build artifacts from the official build servers. We are attempting to
> > > deploy artifacts produced by our build system into Archiva.
> > >
> > > On Tue, Nov 10, 2015 at 2:23 PM, Jeff Hair 
> wrote:
> > >
> > > > Hi,
> > > >
> > > > We are setting up an internal Maven repository to speed up our
> inhouse
> > > > builds that depend on CloudStack on the 4.5 branch (which contains
> > > > 4.5.3-SNAPSHOT right now).
> > > >
> > > > It's mostly working, but we are running into something very strange
> > with
> > > > the checkstyle dependency. After uploading all artifacts with mvn
> > deploy,
> > > > our repository server is directing mvn to go to
> > > > repository.apache.org/snapshots in order to download the checkstyle
> > > > dependency... which of course does not exist.
> > > >
> > > > Has anyone gone through the experience of putting CloudStack SNAPSHOT
> > > > artifacts into an in-house Maven repository?
> > > >
> > >
> > >
> > >
> > > --
> > > *Jeff Hair*
> > > Technical Lead and Software Developer
> > >
> > > Tel: (+354) 415 0200
> > > j...@greenqloud.com
> > > www.greenqloud.com
> > >
> >
> >
> >
> > --
> > Daan
> >
>
>
>
> --
> *Jeff Hair*
> Technical Lead and Software Developer
>
> Tel: (+354) 415 0200
> j...@greenqloud.com
> www.greenqloud.com
>



-- 
Daan


[GitHub] cloudstack pull request: Metrics views for CloudStack UI

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1038#issuecomment-155462713
  
Nice logo @bhaisaab :-)
![screen shot 2015-11-10 at 16 54 
01](https://cloud.githubusercontent.com/assets/1630096/11067217/cd2a0820-87cb-11e5-90b7-e878cad9a6da.png)

Deployed this to our employee cloud to give it a test drive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155468243
  
@rafaelweingartner after randomly oredering and limiting output to 1 the 
next step is looping over all (1) results and retrieving all hosts one by one 
ignoring previous results in the set. 

@miguelaferreira growing this out my idea is to start by having 
selectHypervisorHost throw an exception on host == null and catch it one level 
up to just ignore the finding it again part. I'll implement it for arguments 
sake and force push


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Jeff Hair
Well, the mirrors point to the same place. We started with using the
 element instead of the  element. It probably doesn't
make sense to have both.

On Tue, Nov 10, 2015 at 3:54 PM, Daan Hoogland 
wrote:

> Jeff, I am definitely not god amongst maven users so I have to start
> guessing now. It might be that you need to do magic in the pom for this to
> work. or in MAVEN_OPTS. (what are the mirrors for? these are mirrors of
> your local repo, right?)
>
> On Tue, Nov 10, 2015 at 4:47 PM, Jeff Hair  wrote:
>
> > Yes. It's like this. Not all of this may make sense as I don't normally
> > have a custom MVN repo set up.
> > * Edited settings.xml to have a new  element which points
> to
> > archiva releases repo and archiva snapshots repo.
> > * Added mirrors for both the releases and snapshots repo.
> > * Deployed a built version of 4.5.3-SNAPSHOT to archiva using mvn deploy
> > * Wipe out local ~/.m2/repository and see what happens. This leads to the
> > error I described in the first post.
> >
> > On Tue, Nov 10, 2015 at 3:34 PM, Daan Hoogland 
> > wrote:
> >
> > > Jeff, kicking in an open door: did you edit your .m2/settings.xml?
> > >
> > > On Tue, Nov 10, 2015 at 3:27 PM, Jeff Hair 
> wrote:
> > >
> > > > Also, mirroring is probably not the best term. We are not mirroring
> the
> > > > build artifacts from the official build servers. We are attempting to
> > > > deploy artifacts produced by our build system into Archiva.
> > > >
> > > > On Tue, Nov 10, 2015 at 2:23 PM, Jeff Hair 
> > wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > We are setting up an internal Maven repository to speed up our
> > inhouse
> > > > > builds that depend on CloudStack on the 4.5 branch (which contains
> > > > > 4.5.3-SNAPSHOT right now).
> > > > >
> > > > > It's mostly working, but we are running into something very strange
> > > with
> > > > > the checkstyle dependency. After uploading all artifacts with mvn
> > > deploy,
> > > > > our repository server is directing mvn to go to
> > > > > repository.apache.org/snapshots in order to download the
> checkstyle
> > > > > dependency... which of course does not exist.
> > > > >
> > > > > Has anyone gone through the experience of putting CloudStack
> SNAPSHOT
> > > > > artifacts into an in-house Maven repository?
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > *Jeff Hair*
> > > > Technical Lead and Software Developer
> > > >
> > > > Tel: (+354) 415 0200
> > > > j...@greenqloud.com
> > > > www.greenqloud.com
> > > >
> > >
> > >
> > >
> > > --
> > > Daan
> > >
> >
> >
> >
> > --
> > *Jeff Hair*
> > Technical Lead and Software Developer
> >
> > Tel: (+354) 415 0200
> > j...@greenqloud.com
> > www.greenqloud.com
> >
>
>
>
> --
> Daan
>



-- 
*Jeff Hair*
Technical Lead and Software Developer

Tel: (+354) 415 0200
j...@greenqloud.com
www.greenqloud.com


Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-10 Thread Boris Schrijver
Hi,

I've build the DEB packages for Ubuntu Trusty Tahr (14.04). They are available
here:

https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-agent_4.6.0_all.deb
https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-cli_4.6.0_all.deb
https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-common_4.6.0_all.deb
https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-docs_4.6.0_all.deb
https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-management_4.6.0_all.deb
https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-usage_4.6.0_all.deb

-- 

Met vriendelijke groet / Kind regards,

Boris Schrijver

PCextreme B.V.

http://www.pcextreme.nl/contact
Tel direct: +31 6 33784542

> On November 10, 2015 at 4:16 PM Remi Bergsma 
> wrote:
> 
> 
> FYI: Jenkins was so kind to build us some packages, should we want to use
> them:
> 
> CentOS 7 packages
> http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter-centos7/3/
> 
> CentOS 6 packages
> http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter/22/
> 
> Maybe Boris can build some Ubuntu packages, please?
> 
> 
> Regards,
> Remi
> 
> 
> 
> 
> On 10/11/15 16:03, "Remi Bergsma"  wrote:
> 
> >Hi all,
> >
> >I've created a 4.6.0 release candidate, with the following artifacts up for a
> >vote:
> >
> >Git Branch and Commit SH:
> >https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151110T1545
> >
> >Commit: e31ade03c66368c64f0cd66cb7b0b754cddfb79d
> >
> >Source release (checksums and signatures are available at the same
> >location):
> >https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/
> >
> >PGP release keys (signed using A47DDC4F):
> >https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> >
> >Vote will be open for at least 72 hours.
> >
> >For sanity in tallying the vote, can PMC members please be sure to indicate
> >"(binding)" with their vote?
> >
> >[ ] +1  approve
> >[ ] +0  no opinion
> >[ ] -1  disapprove (and reason why)
> >


[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155485478
  
@miguelaferreira @rafaelweingartner you guys care to discuss this further? 
(this as in this case but also this as in this pattern)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-10 Thread Wilder Rodrigues
Will start testing now. Back with results + vote tomorrow.

Cheers,
Wilder

> On 10 Nov 2015, at 17:22, Boris Schrijver  wrote:
> 
> Hi,
> 
> I've build the DEB packages for Ubuntu Trusty Tahr (14.04). They are available
> here:
> 
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-agent_4.6.0_all.deb
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-cli_4.6.0_all.deb
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-common_4.6.0_all.deb
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-docs_4.6.0_all.deb
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-management_4.6.0_all.deb
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-usage_4.6.0_all.deb
> 
> -- 
> 
> Met vriendelijke groet / Kind regards,
> 
> Boris Schrijver
> 
> PCextreme B.V.
> 
> http://www.pcextreme.nl/contact
> Tel direct: +31 6 33784542
> 
>> On November 10, 2015 at 4:16 PM Remi Bergsma 
>> wrote:
>> 
>> 
>> FYI: Jenkins was so kind to build us some packages, should we want to use
>> them:
>> 
>> CentOS 7 packages
>> http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter-centos7/3/
>> 
>> CentOS 6 packages
>> http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter/22/
>> 
>> Maybe Boris can build some Ubuntu packages, please?
>> 
>> 
>> Regards,
>> Remi
>> 
>> 
>> 
>> 
>> On 10/11/15 16:03, "Remi Bergsma"  wrote:
>> 
>>> Hi all,
>>> 
>>> I've created a 4.6.0 release candidate, with the following artifacts up for 
>>> a
>>> vote:
>>> 
>>> Git Branch and Commit SH:
>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151110T1545
>>> 
>>> Commit: e31ade03c66368c64f0cd66cb7b0b754cddfb79d
>>> 
>>> Source release (checksums and signatures are available at the same
>>> location):
>>> https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/
>>> 
>>> PGP release keys (signed using A47DDC4F):
>>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>> 
>>> Vote will be open for at least 72 hours.
>>> 
>>> For sanity in tallying the vote, can PMC members please be sure to indicate
>>> "(binding)" with their vote?
>>> 
>>> [ ] +1  approve
>>> [ ] +0  no opinion
>>> [ ] -1  disapprove (and reason why)
>>> 



[GitHub] cloudstack pull request: Shuffling the password to avoid having a ...

2015-11-10 Thread nnesic
GitHub user nnesic opened a pull request:

https://github.com/apache/cloudstack/pull/1058

Shuffling the password to avoid having a subset of characters in fixed 
positions.

Related to CLOUDSTACK-9052.

I am shuffling the characters in the password, to avoid having a certain 
char type in fixed positions. I modified the tests accordingly to only check 
that the different character types are present. 

I think it would be good to remove the hard requirement to have at least 
one of digits, upper-case, and  lowercase chars, as it reduces the number of 
possible combinations passwords can take. What do you think?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greenqloud/cloudstack pr/password_security

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1058.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1058


commit 376a56acf69de1b61a1869e2e223d65ed020062f
Author: nnesic 
Date:   2015-11-10T17:22:31Z

CLOUDSTACK-9052 Shuffling the password to avoid having a subset of 
characters in fixed positions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155515107
  
@ DaanHoogland, I noticed that the select is limiting the RS in one 
element. That is actually my point, if the register does not matter, I would 
rather order by id DESC or ASC and not at random (of course, I would maintain 
the limit 1 clause); because that way if something happens I think it would be 
easier to track the problem. 

Additionally, as you pointed that out, I think if the host == null, 
throwing an exception is a better way to go.

BTW: I was staring at that code now, and something hit me. 
The method 
“org.apache.cloudstack.storage.endpoint.DefaultEndPointSelector.selectHypervisorHost(Scope)”
 returns an object “EndPoint” that contains a random host id. If the host 
does not matter, why not use the host that we have already loaded in line 113? 
We could just check if the attribute “hypervisor_type” is not null for that 
host; that is what the select in “selectHypervisorHost” method is doing.

I also noticed that you created two new exceptions, would not it be better 
for us to use the already known “CloudRuntimeException”? Instead of 
creating other exception types.
I think there was a problem with Jenkins, JVM crash ?!
I will also take a look at PR #1057.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cwe 190

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1057#issuecomment-155517568
  
@DaanHoogland, pretty good job, you created the test cases and removed the 
return null cases.
I just have one question, why you use a cast for the octal value 
“0x” to long? Simple using 0x is not enough?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-10 Thread Raja Pullela
BVT ran this morning - but, don't think I have picked up this latest build, so, 
will report again later tomorrow...
BVTs are almost at 100% on KVM and XS both Adv/Basic.
Failed cases were all test related...  hope to do a +1 tomorrow!  
- integration.smoke.test_iso.TestISO.test_07_list_default_iso
- integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn.test_vpc_site2site_vpn
- :setup
- 
integration.smoke.test_vm_snapshots.TestSnapshots.test_01_test_vm_volume_snapshot

-Original Message-
From: Wilder Rodrigues [mailto:wrodrig...@schubergphilis.com] 
Sent: Tuesday, November 10, 2015 11:08 PM
To: dev@cloudstack.apache.org
Subject: Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

Will start testing now. Back with results + vote tomorrow.

Cheers,
Wilder

> On 10 Nov 2015, at 17:22, Boris Schrijver  wrote:
> 
> Hi,
> 
> I've build the DEB packages for Ubuntu Trusty Tahr (14.04). They are 
> available
> here:
> 
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-agent_4.6.0_al
> l.deb 
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-cli_4.6.0_all.
> deb 
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-common_4.6.0_a
> ll.deb 
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-docs_4.6.0_all
> .deb 
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-management_4.6
> .0_all.deb 
> https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-usage_4.6.0_al
> l.deb
> 
> --
> 
> Met vriendelijke groet / Kind regards,
> 
> Boris Schrijver
> 
> PCextreme B.V.
> 
> http://www.pcextreme.nl/contact
> Tel direct: +31 6 33784542
> 
>> On November 10, 2015 at 4:16 PM Remi Bergsma 
>> 
>> wrote:
>> 
>> 
>> FYI: Jenkins was so kind to build us some packages, should we want to 
>> use
>> them:
>> 
>> CentOS 7 packages
>> http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-
>> packages-with-branch-parameter-centos7/3/
>> 
>> CentOS 6 packages
>> http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-
>> packages-with-branch-parameter/22/
>> 
>> Maybe Boris can build some Ubuntu packages, please?
>> 
>> 
>> Regards,
>> Remi
>> 
>> 
>> 
>> 
>> On 10/11/15 16:03, "Remi Bergsma"  wrote:
>> 
>>> Hi all,
>>> 
>>> I've created a 4.6.0 release candidate, with the following artifacts 
>>> up for a
>>> vote:
>>> 
>>> Git Branch and Commit SH:
>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;
>>> h=4.6.0-RC20151110T1545
>>> 
>>> Commit: e31ade03c66368c64f0cd66cb7b0b754cddfb79d
>>> 
>>> Source release (checksums and signatures are available at the same
>>> location):
>>> https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/
>>> 
>>> PGP release keys (signed using A47DDC4F):
>>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>> 
>>> Vote will be open for at least 72 hours.
>>> 
>>> For sanity in tallying the vote, can PMC members please be sure to 
>>> indicate "(binding)" with their vote?
>>> 
>>> [ ] +1  approve
>>> [ ] +0  no opinion
>>> [ ] -1  disapprove (and reason why)
>>> 



[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155525984
  
If there will be no error recovery for the exception thrown on host == 
null, then you will probably be better off with using Optional. It's in 
Java8, but also in Guava, I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155535685
  
Are we already migrating to Java 8?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155536608
  
Optionals are great whether we need to handle or not, right? Especially in 
this one level case. I was thinking it would get more complicated in some 
cases. Even in this case if we realy think it through.

If we go and think of a good pattern to handle nulls with optionals we 
better make it very tempting to use all over the cloud. a bigger problem then a 
less then perfect solution is more then one solution to a problem. it will lead 
to confusion.

@rafaelweingartner yes we are going to 1.8. I think we can run on 1.8 now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155538342
  
That is great if we can use Java 8. However, I checked the maven compiler 
configuration, and it is using Java 1.7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[DISCUSS] Shared Networks on Nicira NVP Plugin

2015-11-10 Thread Nicolás Vázquez
Hi all,

I'm working on supporting Shared Networks on the Nicira NVP Plugin.

I see *nicira_nvp_router_map* table has a unique index on
*logicalrouter_uuid*, but changes I'm working on will allow shared networks
to connect to the same router, so I'll need to remove that index. (ALTER
TABLE `cloud`.`nicira_nvp_router_map` drop index `logicalrouter_uuid`;)

I saw on the docs that there are upgrading schema scripts on *setup/db/db*,
but I would like to ask you if it is ok to include alter table line on
*setup/db/db/schema-452to460.sql
*or would it be better to create a new file including it? In this case,
which will be the next CS version: 4.6.1 or 4.7.0? (just for naming it
*schema-460to461.sql* or *schema-460to470.sql*)

Thanks,
Nicolas


Re: cloudstack vulnerable by COLLECTIONS-580?

2015-11-10 Thread John Kinsella
Thanks for sending this, Rene. In the future, please send issues like this to 
secur...@cloudstack.apache.org.

We’re looking things over, and will have further comments after review.

John

On Nov 10, 2015, at 6:07 AM, Rene Moser 
mailto:m...@renemoser.net>> wrote:

Hi

This security issue came to my attention:
https://issues.apache.org/jira/browse/COLLECTIONS-580

See
http://foxglovesecurity.com/2015/11/06/what-do-weblogic-websphere-jboss-jenkins-opennms-and-your-application-have-in-common-this-vulnerability/
for more background information.

I am not sure if cloudstack is affected, at least we have dependency to
this vulnerable lib:

$ grep -Rl InvokerTransformer .
./plugins/hypervisors/kvm/target/dependencies/commons-collections-3.2.1.jar
./client/target/cloud-client-ui-4.5.2.war
./client/target/cloud-client-ui-4.5.2/WEB-INF/lib/commons-collections-3.2.1.jar
./usage/target/dependencies/commons-collections-3.2.1.jar
./agent/target/dependencies/commons-collections-3.2.jar
./engine/service/target/engine/WEB-INF/lib/commons-collections-3.2.jar

Thanks for clarification.

Yours
René



[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155541260
  
yeah, you had me at 'Are we'. I am now building with 1.8. change in the pom 
and et the java_home should be all


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155545730
  
Got it. Shouldn’t we create a PR changing the Java compilation level to 
1.8?
@DaanHoogland, I still have a doubt about the need of that 
“selectHypervisorHost” method call. If you take a look at the stack of 
calls, the method that starts the process is 
“com.cloud.hypervisor.HypervisorGuruManagerImpl.getGuruProcessedCommandTargetHost(long,
 Command)” that method makes me think that we could just use the host that it 
receives as a parameter instead of looking for another one.

What is the point on getting a host at random? There was not even a check 
if the hypervisor type of the host that was selected is the same as the host 
that initiated the whole process.
Moreover, line 79 of “getGuruProcessedCommandTargetHost”, already uses 
the hypervisor type of the host that is being sent as a parameter; I am seeing 
why that call “endPointSelector.selectHypervisorHost” is needed. It seems 
that we could just remove lines 114 and 115 (prior to the modifications that 
@DaanHoogland did) and we would be good to go, without much complications



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-13509
  
@rafaelweingartner I think the method configures the host to have the right 
storage endpoint. It is kind of an obfuscated side effect but I think the call 
to ```endPointSelector.selectHypervisorHost(new 
ZoneScope(host.getDataCenterId()));``` is not totally without effect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155565847
  
@rafaelweingartner the compile of cloudstack with 1.8 completes but not 
with unit tests. I think we need to work hard for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cwe 190

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1057#issuecomment-155577386
  
@rafaelweingartner the cast was the reason for starting this. Coverity 
complained about a 32 bit shift on an integer (31 bit + sign)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155595167
  
@DaanHoogland, sorry if I am being stubborn, but I really do not see what 
the method “endPointSelector.selectHypervisorHost” is used for; at the end 
we get the “EndPoint” and use just the host_id of that object, then we load 
the host using that id and the details of that host. 

My point is that, if the host does not matter, why not use the host we have 
already loaded in line 113, and then load the details of that host. If we do 
that, we can remove the “endPointSelector.selectHypervisorHost” method. 

The configure method you talked about 
(org.apache.cloudstack.storage.RemoteHostEndPoint.configure(Host)) will load 
the “publicAddress”,if the host it receives as a parameter is a SSVM. 
However, the select “select h.id from host h where h.status = 'Up' and 
h.hypervisor_type is not null” that is executed in 
(endPointSelector.selectHypervisorHost) will not return any of the system VMs, 
because they have “hypervisor_type” value as null. Therefore, we are using 
that method without needing it; that method will just return a random host of 
the environment.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cwe 190

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1057#issuecomment-155595924
  
Got it @DaanHoogland.
What about using () to surround the “(long) 0x” in lines 885, 
925 and 931 as you did in 779. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


"Unable to add the host" error, CS host XS

2015-11-10 Thread B Prakash
Issue while adding XS host, I get this "Unable to add the host" in the UI.  I 
am have pool and pool master configured, XS is with local storage, CS logs is 
as follows, am I missing something?


WARN  [c.c.a.d.ParamGenericValidationWorker] 
(615054626@qtp-36819918-8:ctx-1a6ba54a ctx-73611d66) Received unknown 
parameters for command addHost. Unknown parameters : clustertype
INFO  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8:ctx-1a6ba54a 
ctx-73611d66) Trying to add a new host at http://192.168.0.19 in data center 1
INFO  [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) 
Begin cleanup expired async-jobs
INFO  [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) 
End cleanup expired async-jobs
WARN  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8:ctx-1a6ba54a 
ctx-73611d66) Unable to find the server resources at http://192.168.0.19
INFO  [c.c.u.e.CSExceptionErrorCode] (615054626@qtp-36819918-8:ctx-1a6ba54a 
ctx-73611d66) Could not find exception: com.cloud.exception.DiscoveryException 
in error code list for exceptions
WARN  [o.a.c.a.c.a.h.AddHostCmd] (615054626@qtp-36819918-8:ctx-1a6ba54a 
ctx-73611d66) Exception:
com.cloud.exception.DiscoveryException: Unable to add the host
at 
com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:804)




Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread Mike Tutkowski
In more recent versions of CloudStack, you have to add the XenServer host
to its Resource Pool before adding it to its CloudStack cluster. Were you
trying to do it that way?

On Tue, Nov 10, 2015 at 6:23 PM, B Prakash  wrote:

> Issue while adding XS host, I get this "Unable to add the host" in the
> UI.  I am have pool and pool master configured, XS is with local storage,
> CS logs is as follows, am I missing something?
>
>
> WARN  [c.c.a.d.ParamGenericValidationWorker] 
> (615054626@qtp-36819918-8:ctx-1a6ba54a
> ctx-73611d66) Received unknown parameters for command addHost. Unknown
> parameters : clustertype
> INFO  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8:ctx-1a6ba54a
> ctx-73611d66) Trying to add a new host at http://192.168.0.19 in data
> center 1
> INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) Begin cleanup expired async-jobs
> INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) End cleanup expired async-jobs
> WARN  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8:ctx-1a6ba54a
> ctx-73611d66) Unable to find the server resources at http://192.168.0.19
> INFO  [c.c.u.e.CSExceptionErrorCode] (615054626@qtp-36819918-8:ctx-1a6ba54a
> ctx-73611d66) Could not find exception:
> com.cloud.exception.DiscoveryException in error code list for exceptions
> WARN  [o.a.c.a.c.a.h.AddHostCmd] (615054626@qtp-36819918-8:ctx-1a6ba54a
> ctx-73611d66) Exception:
> com.cloud.exception.DiscoveryException: Unable to add the host
> at
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:804)
>
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread B Prakash
Thanks Mike.  I have added the host to its resource pool with the same host as 
pool master.  I am able to ping XS host and the machine running CS.  But when I 
try to configuring the XS host in CS, it doesnt identify the host ip.
Thanks,
Prakash.

From: Mike Tutkowski 
Sent: Tuesday, November 10, 2015 8:34 PM
To: dev@cloudstack.apache.org
Subject: Re: "Unable to add the host" error, CS host XS

In more recent versions of CloudStack, you have to add the XenServer host
to its Resource Pool before adding it to its CloudStack cluster. Were you
trying to do it that way?

On Tue, Nov 10, 2015 at 6:23 PM, B Prakash  wrote:

> Issue while adding XS host, I get this "Unable to add the host" in the
> UI.  I am have pool and pool master configured, XS is with local storage,
> CS logs is as follows, am I missing something?
>
>
> WARN  [c.c.a.d.ParamGenericValidationWorker] 
> (615054626@qtp-36819918-8:ctx-1a6ba54a
> ctx-73611d66) Received unknown parameters for command addHost. Unknown
> parameters : clustertype
> INFO  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8:ctx-1a6ba54a
> ctx-73611d66) Trying to add a new host at http://192.168.0.19 in data
> center 1
> INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) Begin cleanup expired async-jobs
> INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) End cleanup expired async-jobs
> WARN  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8:ctx-1a6ba54a
> ctx-73611d66) Unable to find the server resources at http://192.168.0.19
> INFO  [c.c.u.e.CSExceptionErrorCode] (615054626@qtp-36819918-8:ctx-1a6ba54a
> ctx-73611d66) Could not find exception:
> com.cloud.exception.DiscoveryException in error code list for exceptions
> WARN  [o.a.c.a.c.a.h.AddHostCmd] (615054626@qtp-36819918-8:ctx-1a6ba54a
> ctx-73611d66) Exception:
> com.cloud.exception.DiscoveryException: Unable to add the host
> at
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:804)
>
>
>


--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread Mike Tutkowski
Which versions of XS and CloudStack are you running?

On Tue, Nov 10, 2015 at 7:00 PM, B Prakash  wrote:

> Thanks Mike.  I have added the host to its resource pool with the same
> host as pool master.  I am able to ping XS host and the machine running
> CS.  But when I try to configuring the XS host in CS, it doesnt identify
> the host ip.
> Thanks,
> Prakash.
> 
> From: Mike Tutkowski 
> Sent: Tuesday, November 10, 2015 8:34 PM
> To: dev@cloudstack.apache.org
> Subject: Re: "Unable to add the host" error, CS host XS
>
> In more recent versions of CloudStack, you have to add the XenServer host
> to its Resource Pool before adding it to its CloudStack cluster. Were you
> trying to do it that way?
>
> On Tue, Nov 10, 2015 at 6:23 PM, B Prakash  wrote:
>
> > Issue while adding XS host, I get this "Unable to add the host" in the
> > UI.  I am have pool and pool master configured, XS is with local storage,
> > CS logs is as follows, am I missing something?
> >
> >
> > WARN  [c.c.a.d.ParamGenericValidationWorker] (615054626@qtp-36819918-8
> :ctx-1a6ba54a
> > ctx-73611d66) Received unknown parameters for command addHost. Unknown
> > parameters : clustertype
> > INFO  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8:ctx-1a6ba54a
> > ctx-73611d66) Trying to add a new host at http://192.168.0.19 in data
> > center 1
> > INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> > (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) Begin cleanup expired async-jobs
> > INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> > (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) End cleanup expired async-jobs
> > WARN  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8:ctx-1a6ba54a
> > ctx-73611d66) Unable to find the server resources at http://192.168.0.19
> > INFO  [c.c.u.e.CSExceptionErrorCode] (615054626@qtp-36819918-8
> :ctx-1a6ba54a
> > ctx-73611d66) Could not find exception:
> > com.cloud.exception.DiscoveryException in error code list for exceptions
> > WARN  [o.a.c.a.c.a.h.AddHostCmd] (615054626@qtp-36819918-8:ctx-1a6ba54a
> > ctx-73611d66) Exception:
> > com.cloud.exception.DiscoveryException: Unable to add the host
> > at
> >
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:804)
> >
> >
> >
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread B Prakash
I am running XS 6.5 and CS 4.6.  XS is on virtualbox.  CS 4.6 is built/run on 
windows 10.  


From: Mike Tutkowski 
Sent: Tuesday, November 10, 2015 9:14 PM
To: dev@cloudstack.apache.org
Subject: Re: "Unable to add the host" error, CS host XS

Which versions of XS and CloudStack are you running?

On Tue, Nov 10, 2015 at 7:00 PM, B Prakash  wrote:

> Thanks Mike.  I have added the host to its resource pool with the same
> host as pool master.  I am able to ping XS host and the machine running
> CS.  But when I try to configuring the XS host in CS, it doesnt identify
> the host ip.
> Thanks,
> Prakash.
> 
> From: Mike Tutkowski 
> Sent: Tuesday, November 10, 2015 8:34 PM
> To: dev@cloudstack.apache.org
> Subject: Re: "Unable to add the host" error, CS host XS
>
> In more recent versions of CloudStack, you have to add the XenServer host
> to its Resource Pool before adding it to its CloudStack cluster. Were you
> trying to do it that way?
>
> On Tue, Nov 10, 2015 at 6:23 PM, B Prakash  wrote:
>
> > Issue while adding XS host, I get this "Unable to add the host" in the
> > UI.  I am have pool and pool master configured, XS is with local storage,
> > CS logs is as follows, am I missing something?
> >
> >
> > WARN  [c.c.a.d.ParamGenericValidationWorker] (615054626@qtp-36819918-8
> :ctx-1a6ba54a
> > ctx-73611d66) Received unknown parameters for command addHost. Unknown
> > parameters : clustertype
> > INFO  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8:ctx-1a6ba54a
> > ctx-73611d66) Trying to add a new host at http://192.168.0.19 in data
> > center 1
> > INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> > (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) Begin cleanup expired async-jobs
> > INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> > (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) End cleanup expired async-jobs
> > WARN  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8:ctx-1a6ba54a
> > ctx-73611d66) Unable to find the server resources at http://192.168.0.19
> > INFO  [c.c.u.e.CSExceptionErrorCode] (615054626@qtp-36819918-8
> :ctx-1a6ba54a
> > ctx-73611d66) Could not find exception:
> > com.cloud.exception.DiscoveryException in error code list for exceptions
> > WARN  [o.a.c.a.c.a.h.AddHostCmd] (615054626@qtp-36819918-8:ctx-1a6ba54a
> > ctx-73611d66) Exception:
> > com.cloud.exception.DiscoveryException: Unable to add the host
> > at
> >
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:804)
> >
> >
> >
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*




--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread Mike Tutkowski
Are you adding this host to a cluster in a basic zone? If so, have you run
this command on your XS host? xe-switch-network-backend bridge

On Tue, Nov 10, 2015 at 7:22 PM, B Prakash  wrote:

> I am running XS 6.5 and CS 4.6.  XS is on virtualbox.  CS 4.6 is built/run
> on windows 10.
>
> 
> From: Mike Tutkowski 
> Sent: Tuesday, November 10, 2015 9:14 PM
> To: dev@cloudstack.apache.org
> Subject: Re: "Unable to add the host" error, CS host XS
>
> Which versions of XS and CloudStack are you running?
>
> On Tue, Nov 10, 2015 at 7:00 PM, B Prakash  wrote:
>
> > Thanks Mike.  I have added the host to its resource pool with the same
> > host as pool master.  I am able to ping XS host and the machine running
> > CS.  But when I try to configuring the XS host in CS, it doesnt identify
> > the host ip.
> > Thanks,
> > Prakash.
> > 
> > From: Mike Tutkowski 
> > Sent: Tuesday, November 10, 2015 8:34 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: "Unable to add the host" error, CS host XS
> >
> > In more recent versions of CloudStack, you have to add the XenServer host
> > to its Resource Pool before adding it to its CloudStack cluster. Were you
> > trying to do it that way?
> >
> > On Tue, Nov 10, 2015 at 6:23 PM, B Prakash  wrote:
> >
> > > Issue while adding XS host, I get this "Unable to add the host" in the
> > > UI.  I am have pool and pool master configured, XS is with local
> storage,
> > > CS logs is as follows, am I missing something?
> > >
> > >
> > > WARN  [c.c.a.d.ParamGenericValidationWorker] (615054626@qtp-36819918-8
> > :ctx-1a6ba54a
> > > ctx-73611d66) Received unknown parameters for command addHost. Unknown
> > > parameters : clustertype
> > > INFO  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8
> :ctx-1a6ba54a
> > > ctx-73611d66) Trying to add a new host at http://192.168.0.19 in data
> > > center 1
> > > INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> > > (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) Begin cleanup expired async-jobs
> > > INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> > > (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) End cleanup expired async-jobs
> > > WARN  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8
> :ctx-1a6ba54a
> > > ctx-73611d66) Unable to find the server resources at
> http://192.168.0.19
> > > INFO  [c.c.u.e.CSExceptionErrorCode] (615054626@qtp-36819918-8
> > :ctx-1a6ba54a
> > > ctx-73611d66) Could not find exception:
> > > com.cloud.exception.DiscoveryException in error code list for
> exceptions
> > > WARN  [o.a.c.a.c.a.h.AddHostCmd] (615054626@qtp-36819918-8
> :ctx-1a6ba54a
> > > ctx-73611d66) Exception:
> > > com.cloud.exception.DiscoveryException: Unable to add the host
> > > at
> > >
> >
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:804)
> > >
> > >
> > >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread B Prakash
I am adding this host to cluster in basic zone.  I had bridge adapter for 
network, I also ran this command.  My CS still doesnt identify XS host ip.

From: Mike Tutkowski 
Sent: Tuesday, November 10, 2015 9:39 PM
To: dev@cloudstack.apache.org
Subject: Re: "Unable to add the host" error, CS host XS

Are you adding this host to a cluster in a basic zone? If so, have you run
this command on your XS host? xe-switch-network-backend bridge

On Tue, Nov 10, 2015 at 7:22 PM, B Prakash  wrote:

> I am running XS 6.5 and CS 4.6.  XS is on virtualbox.  CS 4.6 is built/run
> on windows 10.
>
> 
> From: Mike Tutkowski 
> Sent: Tuesday, November 10, 2015 9:14 PM
> To: dev@cloudstack.apache.org
> Subject: Re: "Unable to add the host" error, CS host XS
>
> Which versions of XS and CloudStack are you running?
>
> On Tue, Nov 10, 2015 at 7:00 PM, B Prakash  wrote:
>
> > Thanks Mike.  I have added the host to its resource pool with the same
> > host as pool master.  I am able to ping XS host and the machine running
> > CS.  But when I try to configuring the XS host in CS, it doesnt identify
> > the host ip.
> > Thanks,
> > Prakash.
> > 
> > From: Mike Tutkowski 
> > Sent: Tuesday, November 10, 2015 8:34 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: "Unable to add the host" error, CS host XS
> >
> > In more recent versions of CloudStack, you have to add the XenServer host
> > to its Resource Pool before adding it to its CloudStack cluster. Were you
> > trying to do it that way?
> >
> > On Tue, Nov 10, 2015 at 6:23 PM, B Prakash  wrote:
> >
> > > Issue while adding XS host, I get this "Unable to add the host" in the
> > > UI.  I am have pool and pool master configured, XS is with local
> storage,
> > > CS logs is as follows, am I missing something?
> > >
> > >
> > > WARN  [c.c.a.d.ParamGenericValidationWorker] (615054626@qtp-36819918-8
> > :ctx-1a6ba54a
> > > ctx-73611d66) Received unknown parameters for command addHost. Unknown
> > > parameters : clustertype
> > > INFO  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8
> :ctx-1a6ba54a
> > > ctx-73611d66) Trying to add a new host at http://192.168.0.19 in data
> > > center 1
> > > INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> > > (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) Begin cleanup expired async-jobs
> > > INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> > > (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) End cleanup expired async-jobs
> > > WARN  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8
> :ctx-1a6ba54a
> > > ctx-73611d66) Unable to find the server resources at
> http://192.168.0.19
> > > INFO  [c.c.u.e.CSExceptionErrorCode] (615054626@qtp-36819918-8
> > :ctx-1a6ba54a
> > > ctx-73611d66) Could not find exception:
> > > com.cloud.exception.DiscoveryException in error code list for
> exceptions
> > > WARN  [o.a.c.a.c.a.h.AddHostCmd] (615054626@qtp-36819918-8
> :ctx-1a6ba54a
> > > ctx-73611d66) Exception:
> > > com.cloud.exception.DiscoveryException: Unable to add the host
> > > at
> > >
> >
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:804)
> > >
> > >
> > >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread Mike Tutkowski
Are there several exceptions printed out in vmops.log or just the one you
posted in your original e-mail?

On Tue, Nov 10, 2015 at 8:15 PM, B Prakash  wrote:

> I am adding this host to cluster in basic zone.  I had bridge adapter for
> network, I also ran this command.  My CS still doesnt identify XS host ip.
> 
> From: Mike Tutkowski 
> Sent: Tuesday, November 10, 2015 9:39 PM
> To: dev@cloudstack.apache.org
> Subject: Re: "Unable to add the host" error, CS host XS
>
> Are you adding this host to a cluster in a basic zone? If so, have you run
> this command on your XS host? xe-switch-network-backend bridge
>
> On Tue, Nov 10, 2015 at 7:22 PM, B Prakash  wrote:
>
> > I am running XS 6.5 and CS 4.6.  XS is on virtualbox.  CS 4.6 is
> built/run
> > on windows 10.
> >
> > 
> > From: Mike Tutkowski 
> > Sent: Tuesday, November 10, 2015 9:14 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: "Unable to add the host" error, CS host XS
> >
> > Which versions of XS and CloudStack are you running?
> >
> > On Tue, Nov 10, 2015 at 7:00 PM, B Prakash  wrote:
> >
> > > Thanks Mike.  I have added the host to its resource pool with the same
> > > host as pool master.  I am able to ping XS host and the machine running
> > > CS.  But when I try to configuring the XS host in CS, it doesnt
> identify
> > > the host ip.
> > > Thanks,
> > > Prakash.
> > > 
> > > From: Mike Tutkowski 
> > > Sent: Tuesday, November 10, 2015 8:34 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: "Unable to add the host" error, CS host XS
> > >
> > > In more recent versions of CloudStack, you have to add the XenServer
> host
> > > to its Resource Pool before adding it to its CloudStack cluster. Were
> you
> > > trying to do it that way?
> > >
> > > On Tue, Nov 10, 2015 at 6:23 PM, B Prakash  wrote:
> > >
> > > > Issue while adding XS host, I get this "Unable to add the host" in
> the
> > > > UI.  I am have pool and pool master configured, XS is with local
> > storage,
> > > > CS logs is as follows, am I missing something?
> > > >
> > > >
> > > > WARN  [c.c.a.d.ParamGenericValidationWorker]
> (615054626@qtp-36819918-8
> > > :ctx-1a6ba54a
> > > > ctx-73611d66) Received unknown parameters for command addHost.
> Unknown
> > > > parameters : clustertype
> > > > INFO  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8
> > :ctx-1a6ba54a
> > > > ctx-73611d66) Trying to add a new host at http://192.168.0.19 in
> data
> > > > center 1
> > > > INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> > > > (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) Begin cleanup expired
> async-jobs
> > > > INFO  [o.a.c.f.j.i.AsyncJobManagerImpl]
> > > > (AsyncJobMgr-Heartbeat-1:ctx-9eb87638) End cleanup expired async-jobs
> > > > WARN  [c.c.r.ResourceManagerImpl] (615054626@qtp-36819918-8
> > :ctx-1a6ba54a
> > > > ctx-73611d66) Unable to find the server resources at
> > http://192.168.0.19
> > > > INFO  [c.c.u.e.CSExceptionErrorCode] (615054626@qtp-36819918-8
> > > :ctx-1a6ba54a
> > > > ctx-73611d66) Could not find exception:
> > > > com.cloud.exception.DiscoveryException in error code list for
> > exceptions
> > > > WARN  [o.a.c.a.c.a.h.AddHostCmd] (615054626@qtp-36819918-8
> > :ctx-1a6ba54a
> > > > ctx-73611d66) Exception:
> > > > com.cloud.exception.DiscoveryException: Unable to add the host
> > > > at
> > > >
> > >
> >
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:804)
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > *Mike Tutkowski*
> > > *Senior CloudStack Developer, SolidFire Inc.*
> > > e: mike.tutkow...@solidfire.com
> > > o: 303.746.7302
> > > Advancing the way the world uses the cloud
> > > *™*
> >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread B Prakash
There are two more exceptions printed in vmops.log as follows;

2015-11-10 19:12:55,075 DEBUG [c.c.a.ApiServlet] 
(1034892751@qtp-1967400458-7:ctx-23ec1109) ===START===  0:0:0:0:0:0:0:1 -- POST 
 command=addHost&response=json
2015-11-10 19:12:55,124 WARN  [c.c.a.d.ParamGenericValidationWorker] 
(1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) Received unknown 
parameters for command addHost. Unknown parameters : clustertype
2015-11-10 19:12:55,160 INFO  [c.c.r.ResourceManagerImpl] 
(1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) Trying to add a new 
host at http://192.168.0.19 in data center 1
2015-11-10 19:12:56,041 DEBUG [c.c.c.ConsoleProxyManagerImpl] 
(consoleproxy-1:ctx-620ccc56) Skip capacity scan as there is no Primary Storage 
in 'Up' state
2015-11-10 19:12:56,436 DEBUG [o.a.c.s.SecondaryStorageManagerImpl] 
(secstorage-1:ctx-8341054e) Zone 1 is not ready to launch secondary storage VM 
yet
2015-11-10 19:12:57,366 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
Timer:ctx-c19ba5d9) Resetting hosts suitable for reconnect
2015-11-10 19:12:57,370 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
Timer:ctx-c19ba5d9) Completed resetting hosts suitable for reconnect
2015-11-10 19:12:57,370 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
Timer:ctx-c19ba5d9) Acquiring hosts for clusters already owned by this 
management server
2015-11-10 19:12:57,372 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
Timer:ctx-c19ba5d9) Completed acquiring hosts for clusters already owned by 
this management server
2015-11-10 19:12:57,372 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
Timer:ctx-c19ba5d9) Acquiring hosts for clusters not owned by any management 
server
2015-11-10 19:12:57,373 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
Timer:ctx-c19ba5d9) Completed acquiring hosts for clusters not owned by any 
management server
2015-11-10 19:13:00,405 DEBUG [c.c.h.x.r.XenServerConnectionPool] 
(1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) Unable to create master 
connection to host(192.168.0.19) , due to org.apache.xmlrpc.XmlRpcException: 
Failed to read server's response: connect timed out
2015-11-10 19:13:00,406 DEBUG [c.c.h.x.d.XcpServerDiscoverer] 
(1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) other exceptions: 
com.cloud.utils.exception.CloudRuntimeException: Unable to create master 
connection to host(192.168.0.19) , due to org.apache.xmlrpc.XmlRpcException: 
Failed to read server's response: connect timed out
com.cloud.utils.exception.CloudRuntimeException: Unable to create master 
connection to host(192.168.0.19) , due to org.apache.xmlrpc.XmlRpcException: 
Failed to read server's response: connect timed out
at 
com.cloud.hypervisor.xenserver.resource.XenServerConnectionPool.getConnect(XenServerConnectionPool.java:168)
at 
com.cloud.hypervisor.xenserver.discoverer.XcpServerDiscoverer.find(XcpServerDiscoverer.java:217)
at 
com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:748)
at 
com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:599)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at 
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
at com.sun.proxy.$Proxy166.discoverHosts(Unknown Source)
at 
org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:142)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
at com.cloud.api.ApiServer.queueCommand(ApiServer.java:703)
at com.cloud.api.ApiServer.handleRequest(ApiServer.java:528)
at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:296)
at com.cloud.api.ApiServlet$1.run(ApiServlet.java:127)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedCont

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread Mike Tutkowski
Is your CS cluster up and running at the moment (ex. Can you deploy VMs to
it)?

In other words, before you attempt to add this new host, is the cluster
working?

On Tuesday, November 10, 2015, B Prakash  wrote:

> There are two more exceptions printed in vmops.log as follows;
>
> 2015-11-10 19:12:55,075 DEBUG [c.c.a.ApiServlet]
> (1034892751@qtp-1967400458-7:ctx-23ec1109) ===START===  0:0:0:0:0:0:0:1
> -- POST  command=addHost&response=json
> 2015-11-10 19:12:55,124 WARN  [c.c.a.d.ParamGenericValidationWorker]
> (1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) Received unknown
> parameters for command addHost. Unknown parameters : clustertype
> 2015-11-10 19:12:55,160 INFO  [c.c.r.ResourceManagerImpl]
> (1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) Trying to add a
> new host at http://192.168.0.19 in data center 1
> 2015-11-10 19:12:56,041 DEBUG [c.c.c.ConsoleProxyManagerImpl]
> (consoleproxy-1:ctx-620ccc56) Skip capacity scan as there is no Primary
> Storage in 'Up' state
> 2015-11-10 19:12:56,436 DEBUG [o.a.c.s.SecondaryStorageManagerImpl]
> (secstorage-1:ctx-8341054e) Zone 1 is not ready to launch secondary storage
> VM yet
> 2015-11-10 19:12:57,366 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager
> Timer:ctx-c19ba5d9) Resetting hosts suitable for reconnect
> 2015-11-10 19:12:57,370 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager
> Timer:ctx-c19ba5d9) Completed resetting hosts suitable for reconnect
> 2015-11-10 19:12:57,370 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager
> Timer:ctx-c19ba5d9) Acquiring hosts for clusters already owned by this
> management server
> 2015-11-10 19:12:57,372 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager
> Timer:ctx-c19ba5d9) Completed acquiring hosts for clusters already owned by
> this management server
> 2015-11-10 19:12:57,372 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager
> Timer:ctx-c19ba5d9) Acquiring hosts for clusters not owned by any
> management server
> 2015-11-10 19:12:57,373 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager
> Timer:ctx-c19ba5d9) Completed acquiring hosts for clusters not owned by any
> management server
> 2015-11-10 19:13:00,405 DEBUG [c.c.h.x.r.XenServerConnectionPool]
> (1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) Unable to create
> master connection to host(192.168.0.19) , due to
> org.apache.xmlrpc.XmlRpcException: Failed to read server's response:
> connect timed out
> 2015-11-10 19:13:00,406 DEBUG [c.c.h.x.d.XcpServerDiscoverer]
> (1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) other exceptions:
> com.cloud.utils.exception.CloudRuntimeException: Unable to create master
> connection to host(192.168.0.19) , due to
> org.apache.xmlrpc.XmlRpcException: Failed to read server's response:
> connect timed out
> com.cloud.utils.exception.CloudRuntimeException: Unable to create master
> connection to host(192.168.0.19) , due to
> org.apache.xmlrpc.XmlRpcException: Failed to read server's response:
> connect timed out
> at
> com.cloud.hypervisor.xenserver.resource.XenServerConnectionPool.getConnect(XenServerConnectionPool.java:168)
> at
> com.cloud.hypervisor.xenserver.discoverer.XcpServerDiscoverer.find(XcpServerDiscoverer.java:217)
> at
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:748)
> at
> com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:599)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
> at
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
> at
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
> at com.sun.proxy.$Proxy166.discoverHosts(Unknown Source)
> at
> org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:142)
> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
> at com.cloud.api.ApiServer.queueCommand(ApiServer.java:703)
> at com.cloud.api.ApiServer.handleRequest(ApiServer.java:528)
> at
> com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:296)
> at com.cloud.api.ApiServlet$1.run(ApiServlet.java:127)
> at
>

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread Remi Bergsma
Make sure management server can talk to the xenserver (xapi) over port 443 
(firewalls?). Right now it says it cannot due to a timeout:

Failed to read server's response: connect timed out

@mike From the logs this seems the first host to be added to this zone. 

Sent from my iPhone

> On 11 Nov 2015, at 04:36, B Prakash  wrote:
> 
> There are two more exceptions printed in vmops.log as follows;
> 
> 2015-11-10 19:12:55,075 DEBUG [c.c.a.ApiServlet] 
> (1034892751@qtp-1967400458-7:ctx-23ec1109) ===START===  0:0:0:0:0:0:0:1 -- 
> POST  command=addHost&response=json
> 2015-11-10 19:12:55,124 WARN  [c.c.a.d.ParamGenericValidationWorker] 
> (1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) Received unknown 
> parameters for command addHost. Unknown parameters : clustertype
> 2015-11-10 19:12:55,160 INFO  [c.c.r.ResourceManagerImpl] 
> (1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) Trying to add a new 
> host at http://192.168.0.19 in data center 1
> 2015-11-10 19:12:56,041 DEBUG [c.c.c.ConsoleProxyManagerImpl] 
> (consoleproxy-1:ctx-620ccc56) Skip capacity scan as there is no Primary 
> Storage in 'Up' state
> 2015-11-10 19:12:56,436 DEBUG [o.a.c.s.SecondaryStorageManagerImpl] 
> (secstorage-1:ctx-8341054e) Zone 1 is not ready to launch secondary storage 
> VM yet
> 2015-11-10 19:12:57,366 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
> Timer:ctx-c19ba5d9) Resetting hosts suitable for reconnect
> 2015-11-10 19:12:57,370 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
> Timer:ctx-c19ba5d9) Completed resetting hosts suitable for reconnect
> 2015-11-10 19:12:57,370 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
> Timer:ctx-c19ba5d9) Acquiring hosts for clusters already owned by this 
> management server
> 2015-11-10 19:12:57,372 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
> Timer:ctx-c19ba5d9) Completed acquiring hosts for clusters already owned by 
> this management server
> 2015-11-10 19:12:57,372 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
> Timer:ctx-c19ba5d9) Acquiring hosts for clusters not owned by any management 
> server
> 2015-11-10 19:12:57,373 DEBUG [c.c.h.d.HostDaoImpl] (ClusteredAgentManager 
> Timer:ctx-c19ba5d9) Completed acquiring hosts for clusters not owned by any 
> management server
> 2015-11-10 19:13:00,405 DEBUG [c.c.h.x.r.XenServerConnectionPool] 
> (1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) Unable to create 
> master connection to host(192.168.0.19) , due to 
> org.apache.xmlrpc.XmlRpcException: Failed to read server's response: connect 
> timed out
> 2015-11-10 19:13:00,406 DEBUG [c.c.h.x.d.XcpServerDiscoverer] 
> (1034892751@qtp-1967400458-7:ctx-23ec1109 ctx-beece821) other exceptions: 
> com.cloud.utils.exception.CloudRuntimeException: Unable to create master 
> connection to host(192.168.0.19) , due to org.apache.xmlrpc.XmlRpcException: 
> Failed to read server's response: connect timed out
> com.cloud.utils.exception.CloudRuntimeException: Unable to create master 
> connection to host(192.168.0.19) , due to org.apache.xmlrpc.XmlRpcException: 
> Failed to read server's response: connect timed out
>at 
> com.cloud.hypervisor.xenserver.resource.XenServerConnectionPool.getConnect(XenServerConnectionPool.java:168)
>at 
> com.cloud.hypervisor.xenserver.discoverer.XcpServerDiscoverer.find(XcpServerDiscoverer.java:217)
>at 
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:748)
>at 
> com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:599)
>at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>at java.lang.reflect.Method.invoke(Method.java:497)
>at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
>at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
>at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
>at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
>at com.sun.proxy.$Proxy166.discoverHosts(Unknown Source)
>at 
> org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:142)
>at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
>at com.cloud.api.ApiServer.queueCommand(ApiServer.java:703)
>at com.cloud.api.ApiServer.handleRequest(ApiServer.java:528)
>at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:296)
>at com.cloud.ap

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1056#issuecomment-155679945
  
We don't need Java 8 to use optional. And yes, optional is meant for 
expressing that a value may be present or not. The API is quite clear, I don't 
see the confusion.

https://github.com/google/guava/wiki/UsingAndAvoidingNullExplained


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [Proposal] Template for CloudStack API Reference Pages

2015-11-10 Thread Daejuan Jacobs
I assume by "Format" you mean data type.

But I think this looks good. It's simple, yet it manages to nail all the
points you need when developing on a software's API.

On Tue, Nov 10, 2015 at 8:33 AM Rajsekhar K 
wrote:

> Hi, All,
>
> This is the proposal for a new template for CloudStack API reference
> pages. This template is based on the reference page templates for REST APIs.
>
> Please find attached the following documents for your review:
>
>- Template for normal and asynchronous CloudStack API references.
>- Sample API reference page using the template for a CloudStack API
>(listZones).
>
>
> Please review this template and let me know your thoughts on this.
>
> Thanks,
> Rajsekhar
>


  1   2   >