Re: Build failed in Jenkins: build-systemvm-master #624

[Rajani Karuturi]

ok. thanks. I will attempt a fix.

~Rajani

On Tue, Sep 15, 2015 at 11:34 AM, Rohit Yadav 
wrote:

> The ISO url needs to be fixed to use 7.9.0 as  the 7.8.0 archive url is
> not available.
> http://cdimage.debian.org/cdimage/archive/7.9.0/
>
> On 15-Sep-2015, at 9:59 am, Rajani Karuturi 
> wrote:
>
> Anyone understands why this is failing?
>
>
> ~Rajani
>
>
>
> On 15-Sep-2015, at 3:23 am, jenk...@cloudstack.org wrote:
>
> See 
>
> Changes:
>
> [Rajani Karuturi] CLOUDSTACK-8816 Fixed entityUuid missing in some cases
> is events
>
> [Rajani Karuturi] CLOUDSTACK-8816: instance uuid is missing in events for
> delete account
>
> [Rajani Karuturi] CLOUDSTACK-8816: entity uuid missing in create network
> event
>
> [Rajani Karuturi] CLOUDSTACK-8816: Project UUID is not showing for some of
> operations in RabbitMQ.
>
> [Rajani Karuturi] CLOUDSTACK-8816 Systemvm reboot event doesnt have uuids.
> Fixed the same
>
> [Boris Schrijver] Added QCOW2 virtual size checking for S3.
>
> [anshul.gangwar] Fixed secstorage.proxy is not setting proxy configuration
> on SSVM in some cases
>
> [Rajani Karuturi] CLOUDSTACK-8835: Added alerts incase of template
> download failure
>
> [Boris Schrijver] Fixed Findbugs issue introduced by
> 1c6378ec0056e8c75990a4a0c15e99b2df162a75 PR #795.
>
> [Boris Schrijver] Added Unit Tests for QCOW2Utils.
>
> [sanjeev] Tagging tests appropriately to pick them for running on basic
> zone
>
> [sanjeev] Tagging tests appropriately to pick them for running on basic
> zone
>
> [Rajani Karuturi] Revert "Tagging tests appropriately to pick them for
> running on basic zone"
>
> --
> [...truncated 1087 lines...]
> + '[' -t 2 ']'
> + echo '[2015-09-14 21:57:30] INFO: destroying existing veewee image, if
> any'
> [2015-09-14 21:57:30] INFO: destroying existing veewee image, if any
> + set +e
> + bundle exec veewee vbox destroy systemvmtemplate-master-4.6.0
> Error:: You tried to destroy a non-existing box
> 'systemvmtemplate-master-4.6.0'
> + set -e
> + add_on_exit veewee_destroy
> + local n=3
> + on_exit_items[${n}]=veewee_destroy
> + '[' 3 -eq 0 ']'
> + veewee_build
> + log INFO 'building new image with veewee'
> + local level=INFO
> + shift
> + [[ 1 != \1 ]]
> + local code=
> ++ date '+%F %T'
> + local 'line=[2015-09-14 21:57:32] INFO: building new image with veewee'
> + '[' -t 2 ']'
> + echo '[2015-09-14 21:57:32] INFO: building new image with veewee'
> [2015-09-14 21:57:32] INFO: building new image with veewee
> + bundle exec veewee vbox build systemvmtemplate-master-4.6.0 --nogui
> --auto
> Downloading vbox guest additions iso v 4.3.14 -
> http://download.virtualbox.org/virtualbox/4.3.14/VBoxGuestAdditions_4.3.14.iso
> Checking if isofile VBoxGuestAdditions_4.3.14.iso already exists.
> Full path: <
> http://jenkins.buildacloud.org/job/build-systemvm-master/ws/tools/appliance/iso/VBoxGuestAdditions_4.3.14.iso
> >
>
>
> Fetching file:   0% |  | ETA:
>  --:--:--
> Fetching file:   1% || 652.2KB   3.6MB/s ETA:
>   0:00:17
> Fetching file:   2% ||   1.3MB   3.2MB/s ETA:
>   0:00:19
> Fetching file:   3% ||   1.9MB   3.2MB/s ETA:
>   0:00:18
> Fetching file:   4% ||   2.5MB   3.2MB/s ETA:
>   0:00:18
> Fetching file:   5% |o   |   3.1MB   3.2MB/s ETA:
>   0:00:18
> Fetching file:   6% |o   |   3.8MB   3.2MB/s ETA:
>   0:00:18
> Fetching file:   7% |o   |   4.4MB   3.3MB/s ETA:
>   0:00:17
> Fetching file:   8% |o   |   5.0MB   3.4MB/s ETA:
>   0:00:17
> Fetching file:   9% |oo  |   5.7MB   3.4MB/s ETA:
>   0:00:16
> Fetching file:  10% |oo  |   6.3MB   3.5MB/s ETA:
>   0:00:16
> Fetching file:  11% |oo  |   6.9MB   3.5MB/s ETA:
>   0:00:15
> Fetching file:  12% |oo  |   7.5MB   3.6MB/s ETA:
>   0:00:15
> Fetching file:  13% |ooo |   8.2MB   3.6MB/s ETA:
>   0:00:15
> Fetching file:  14% |ooo |   8.8MB   3.6MB/s ETA:
>   0:00:15
> Fetching file:  15% |ooo |   9.4MB   3.5MB/s ETA:
>   0:00:15
> Fetching file:  16% |ooo |  10.1MB   3.4MB/s ETA:
>   0:00:15
> Fetching file:  17% ||  10.7MB   3.4MB/s ETA:
>   0:00:15
> Fetching file:  18% ||  11.3MB   3.4MB/s ETA:
>   0:00:15
> Fetching file:  19% ||  12.0MB   3.4MB/s ETA:
>   0:00:15
> Fetching file:  20% ||  12.6MB   3.4MB/s ETA:
>   0:00:14
> Fetching file:  21% |o   |  13.2MB   3.4MB/s ETA:
>   0:00:14
> Fetching file:  22% |o   |  13.8MB   3.4MB/s ETA:
>   0:00:14
> Fetching file:  23% |o   |  14.5MB   3.4MB/s ETA:
>   0:00:14
>

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/817#issuecomment-140301614
  
@bhaisaab Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/813#issuecomment-140303120
  
@bhaisaab Could you take a quick peek?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/820#issuecomment-140305692
  
@remibergsma Yes, stupid. Fixed that. Pushed a new commit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/821#issuecomment-140306807
  
@DaanHoogland Pushed a fix for that log line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/824#issuecomment-140307070
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/821#issuecomment-140308111
  
@wido Can you squash both commits into one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/821#issuecomment-140315801
  
@borisroman Done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/821#issuecomment-140316281
  
LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/792#issuecomment-140317652
  
Can anyone review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/825

Replaced all occurences of Charset.forName(UTF-8) with 
StringUtils.getPreferredCharset().



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack charset

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/825.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #825


commit 9b8c0bc12e5829aa538123737064a3696d602596
Author: Boris Schrijver 
Date:   2015-09-15T08:43:41Z

Replaced all occurences of Charset.forName(UTF-8) with 
StringUtils.getPreferredCharset().




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8645: Improve logging of RBD f...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/821


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/804#issuecomment-140329820
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/804


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/825#issuecomment-140332659
  
Pending travis LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...

[kansal]

GitHub user kansal opened a pull request:

https://github.com/apache/cloudstack/pull/826

Fixed: Error given when creating VPN user in one network if VR for an…

…other network is stopped.

Problem: Adding a VPN user to an IP on an isolated network fails with an 
exception if the end-user has two isolated networks and one of them is not in 
use (i.e. VR is stopped).

Fix: Presently in the code, all the VR which are not in Running state are 
forced to throw error. Added a check for the Stopped and Stopping state 
routers. Configurations will be applied to them when they get restarted.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kansal/cloudstack CLOUDSTACK-8853

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/826.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #826


commit dfcb2e17dbd3cb41d21e3dabbcdc30b41233b422
Author: Kshitij Kansal 
Date:   2015-09-15T09:12:29Z

Fixed: Error given when creating VPN user in one network if VR for another 
network is stopped




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

[Raja Pullela]

Hi,

JIRA - ticket https://issues.apache.org/jira/browse/CLOUDSTACK-8843
Can someone please pick up this ticket ?  This is failing a bunch of the BVTs 
tests in Basiczone.

Thanks,
Raja

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/825#issuecomment-140339356
  
Travis failed due to a time-out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

[kansal]

Github user kansal commented on the pull request:

https://github.com/apache/cloudstack/pull/818#issuecomment-140339650
  
@remibergsma Yes its CLOUDSTACK-8844. It's already syncing the comments in 
the JIRA issue. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8849: Usage job should...

[yvsubhash]

GitHub user yvsubhash opened a pull request:

https://github.com/apache/cloudstack/pull/827

BUG-ID: CLOUDSTACK-8849: Usage job should stop usage generation in ca…

…se of any exception

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-8849

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/827.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #827


commit 2818bd4f82eb1e9517fa13935cef6159fdd22cf9
Author: Sudhansu 
Date:   2015-08-25T11:43:56Z

BUG-ID: CLOUDSTACK-8849: Usage job should stop usage generation in case of 
any exception




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

[sureshanaparti]

GitHub user sureshanaparti opened a pull request:

https://github.com/apache/cloudstack/pull/828

CLOUDSTACK-8854: Apple Mac OS/X VM get created without USB controller in 
ESXi hypervisors

CLOUDSTACK-8854: Apple Mac OS/X VM get created without USB controller in 
ESXi hypervisors

Problem Description: CloudStack doesn’t add a USB controller to the Apple 
Mac OS X VMs created in ESXi hypervisors. But, vSphere Client, by default, adds 
a USB Controller to the Mac OS VMs. Mac OS X machines require USB Controller 
for USB mouse and keyboard access.

Root Cause: The Guest OS details are specified in the Virtual Machine 
Configuration Spec for creating the VM (using the SDK API) in the EXSi 
hypervisor. No USB Controller is added to the Virtual Machine Configuration 
Spec. As the guest OS Identification details are specified in the VM 
Configuration Spec, It is assumed that the Create VM SDK API would create the 
defaults in the VM same as vSphere Client. But, as per the observation, USB 
Controller is not added to the Guest OS - Mac OS VM created through the SDK API.

Resolution: When the Guest OS is Apple Mac OS, Add the USB Controller 
(EHCI+UHCI - Mac supported) to the Virtual Machine Configuration Spec before 
Creating or Starting the VM. For any existing Mac OS VMs, Stop and Start to add 
the USB Controller. For new VMs with Mac OS, USB Controller is added 
automatically.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sureshanaparti/cloudstack CLOUDSTACK-8854

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/828.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #828


commit f532ea728fadfa326706a9afd2a04a8118d0116f
Author: Suresh Kumar Anaparti 
Date:   2015-09-15T10:05:38Z

CLOUDSTACK-8854: Apple Mac OS/X VM get created without USB controller in 
ESXi hypervisors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

[DaanHoogland]

GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/829

CLOUDSTACK-8848: extra state to handle; no power report from host

there no no real handling code now so this can be regarded as a DISCUSS 
item. It may well be an improvement over existing code as is, however.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-8848

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/829.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #829


commit c4d6f9b7a87d8549bcc7efc2c8e529636d0a1d86
Author: Daan Hoogland 
Date:   2015-09-15T10:48:56Z

CLOUDSTACK-8848: extra state to handle; no power report from host




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

[sureshanaparti]

GitHub user sureshanaparti opened a pull request:

https://github.com/apache/cloudstack/pull/830

CLOUDSTACK-8858: listVolumes API fails for a particular domain with NPE.

CLOUDSTACK-8858: listVolumes API fails for a particular domain with NPE.

Summary: listVolumes API fails when volume associated vm instance has NULL 
or invalid state. Fix the code to guard this situation since this should not 
block volume listing.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sureshanaparti/cloudstack CLOUDSTACK-8858

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #830


commit c3777632c5817cc1e635ee59eb18d6cb4f210e29
Author: Suresh Kumar Anaparti 
Date:   2015-09-15T10:52:06Z

CLOUDSTACK-8858: listVolumes API fails for a particular domain with NPE.

Summary: listVolumes API fails when volume associated vm instance has NULL 
or invalid state. Fix the code to guard this situation since this should not 
block volume listing.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/824#discussion_r39497551
  
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade453to460.java ---
@@ -30,12 +30,12 @@
 import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.utils.script.Script;
 
-public class Upgrade452to460 implements DbUpgrade {
--- End diff --

shouldn't we keep this as 452to460 untill 453 is actually released with db 
migrations? it is not needed otherwise


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/824#discussion_r39497595
  
--- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java 
---
@@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {
 new Upgrade2211to2212(), new Upgrade2212to2213(), new 
Upgrade2213to2214(), new Upgrade2214to30(),
 new Upgrade30to301(), new Upgrade301to302(), new 
Upgrade302to40(), new Upgrade40to41(), new Upgrade410to420(),
 new Upgrade420to421(), new Upgrade421to430(), new 
Upgrade430to440(), new Upgrade440to441(), new Upgrade441to442(),
-new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460()});
+new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to453(), new Upgrade453to460()});
 
 _upgradeMap.put("2.2.1", new DbUpgrade[] {new Upgrade221to222(), 
new UpgradeSnapshot223to224(), new Upgrade222to224(),
 new Upgrade224to225(), new Upgrade225to226(), new 
Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to2213(),
 new Upgrade2213to2214(), new Upgrade2214to30(), new 
Upgrade30to301(), new Upgrade301to302(), new Upgrade302to40(),
 new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(), new Upgrade430to440(),
-new Upgrade440to441(), new Upgrade441to442(), new 
Upgrade442to450(), new Upgrade450to451(), new Upgrade451to452(), new 
Upgrade452to460()});
+new Upgrade440to441(), new Upgrade441to442(), new 
Upgrade442to450(), new Upgrade450to451(), new Upgrade451to452(), new 
Upgrade452to453(), new Upgrade453to460()});
 
 _upgradeMap.put("2.2.2", new DbUpgrade[] {new Upgrade222to224(), 
new UpgradeSnapshot223to224(), new Upgrade224to225(),
 new Upgrade225to226(), new Upgrade227to228(), new 
Upgrade228to229(), new Upgrade229to2210(),
 new Upgrade2210to2211(), new Upgrade2211to2212(), new 
Upgrade2212to2213(), new Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.3", new DbUpgrade[] {new Upgrade222to224(), 
new UpgradeSnapshot223to224(), new Upgrade224to225(),
 new Upgrade225to226(), new Upgrade227to228(), new 
Upgrade228to229(), new Upgrade229to2210(),
 new Upgrade2210to2211(), new Upgrade2211to2212(), new 
Upgrade2212to2213(), new Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.4", new DbUpgrade[] {new Upgrade224to225(), 
new Upgrade225to226(), new Upgrade227to228(),
 new Upgrade228to229(), new Upgrade229to2210(), new 
Upgrade2210to2211(), new Upgrade2211to2212(),
 new Upgrade2212to2213(), new Upgrade2213to2214(), new 
Upgrade2214to30(), new Upgrade30to301(),
 new Upgrade301to302(), new Upgrade302to40(), new 
Upgrade40to41(), new Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.5", new DbUpgrade[] {new Upgrade225to226(), 
new Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/824#discussion_r39498235
  
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade453to460.java ---
@@ -30,12 +30,12 @@
 import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.utils.script.Script;
 
-public class Upgrade452to460 implements DbUpgrade {
--- End diff --

I think 4.5.3 would be only a bugfix release that ought not involve any 
schema change. Since, 4.5.2 to 4.5.3 won't have any schema changes, adding a 
linear upgrade paths simplifies the paths. IMO, it's just stubs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/824#discussion_r39498281
  
--- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java 
---
@@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {
 new Upgrade2211to2212(), new Upgrade2212to2213(), new 
Upgrade2213to2214(), new Upgrade2214to30(),
 new Upgrade30to301(), new Upgrade301to302(), new 
Upgrade302to40(), new Upgrade40to41(), new Upgrade410to420(),
 new Upgrade420to421(), new Upgrade421to430(), new 
Upgrade430to440(), new Upgrade440to441(), new Upgrade441to442(),
-new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460()});
+new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to453(), new Upgrade453to460()});
 
 _upgradeMap.put("2.2.1", new DbUpgrade[] {new Upgrade221to222(), 
new UpgradeSnapshot223to224(), new Upgrade222to224(),
 new Upgrade224to225(), new Upgrade225to226(), new 
Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to2213(),
 new Upgrade2213to2214(), new Upgrade2214to30(), new 
Upgrade30to301(), new Upgrade301to302(), new Upgrade302to40(),
 new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(), new Upgrade430to440(),
-new Upgrade440to441(), new Upgrade441to442(), new 
Upgrade442to450(), new Upgrade450to451(), new Upgrade451to452(), new 
Upgrade452to460()});
+new Upgrade440to441(), new Upgrade441to442(), new 
Upgrade442to450(), new Upgrade450to451(), new Upgrade451to452(), new 
Upgrade452to453(), new Upgrade453to460()});
 
 _upgradeMap.put("2.2.2", new DbUpgrade[] {new Upgrade222to224(), 
new UpgradeSnapshot223to224(), new Upgrade224to225(),
 new Upgrade225to226(), new Upgrade227to228(), new 
Upgrade228to229(), new Upgrade229to2210(),
 new Upgrade2210to2211(), new Upgrade2211to2212(), new 
Upgrade2212to2213(), new Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.3", new DbUpgrade[] {new Upgrade222to224(), 
new UpgradeSnapshot223to224(), new Upgrade224to225(),
 new Upgrade225to226(), new Upgrade227to228(), new 
Upgrade228to229(), new Upgrade229to2210(),
 new Upgrade2210to2211(), new Upgrade2211to2212(), new 
Upgrade2212to2213(), new Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.4", new DbUpgrade[] {new Upgrade224to225(), 
new Upgrade225to226(), new Upgrade227to228(),
 new Upgrade228to229(), new Upgrade229to2210(), new 
Upgrade2210to2211(), new Upgrade2211to2212(),
 new Upgrade2212to2213(), new Upgrade2213to2214(), new 
Upgrade2214to30(), new Upgrade30to301(),
 new Upgrade301to302(), new Upgrade302to40(), new 
Upgrade40to41(), new Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.5", new DbUpgrade[] {new Upgrade225to226(), 
new Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to22

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/824#discussion_r39498419
  
--- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java 
---
@@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {
 new Upgrade2211to2212(), new Upgrade2212to2213(), new 
Upgrade2213to2214(), new Upgrade2214to30(),
 new Upgrade30to301(), new Upgrade301to302(), new 
Upgrade302to40(), new Upgrade40to41(), new Upgrade410to420(),
 new Upgrade420to421(), new Upgrade421to430(), new 
Upgrade430to440(), new Upgrade440to441(), new Upgrade441to442(),
-new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460()});
+new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to453(), new Upgrade453to460()});
 
 _upgradeMap.put("2.2.1", new DbUpgrade[] {new Upgrade221to222(), 
new UpgradeSnapshot223to224(), new Upgrade222to224(),
 new Upgrade224to225(), new Upgrade225to226(), new 
Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to2213(),
 new Upgrade2213to2214(), new Upgrade2214to30(), new 
Upgrade30to301(), new Upgrade301to302(), new Upgrade302to40(),
 new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(), new Upgrade430to440(),
-new Upgrade440to441(), new Upgrade441to442(), new 
Upgrade442to450(), new Upgrade450to451(), new Upgrade451to452(), new 
Upgrade452to460()});
+new Upgrade440to441(), new Upgrade441to442(), new 
Upgrade442to450(), new Upgrade450to451(), new Upgrade451to452(), new 
Upgrade452to453(), new Upgrade453to460()});
 
 _upgradeMap.put("2.2.2", new DbUpgrade[] {new Upgrade222to224(), 
new UpgradeSnapshot223to224(), new Upgrade224to225(),
 new Upgrade225to226(), new Upgrade227to228(), new 
Upgrade228to229(), new Upgrade229to2210(),
 new Upgrade2210to2211(), new Upgrade2211to2212(), new 
Upgrade2212to2213(), new Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.3", new DbUpgrade[] {new Upgrade222to224(), 
new UpgradeSnapshot223to224(), new Upgrade224to225(),
 new Upgrade225to226(), new Upgrade227to228(), new 
Upgrade228to229(), new Upgrade229to2210(),
 new Upgrade2210to2211(), new Upgrade2211to2212(), new 
Upgrade2212to2213(), new Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.4", new DbUpgrade[] {new Upgrade224to225(), 
new Upgrade225to226(), new Upgrade227to228(),
 new Upgrade228to229(), new Upgrade229to2210(), new 
Upgrade2210to2211(), new Upgrade2211to2212(),
 new Upgrade2212to2213(), new Upgrade2213to2214(), new 
Upgrade2214to30(), new Upgrade30to301(),
 new Upgrade301to302(), new Upgrade302to40(), new 
Upgrade40to41(), new Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.5", new DbUpgrade[] {new Upgrade225to226(), 
new Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to22

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/824#discussion_r39498765
  
--- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java 
---
@@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {
 new Upgrade2211to2212(), new Upgrade2212to2213(), new 
Upgrade2213to2214(), new Upgrade2214to30(),
 new Upgrade30to301(), new Upgrade301to302(), new 
Upgrade302to40(), new Upgrade40to41(), new Upgrade410to420(),
 new Upgrade420to421(), new Upgrade421to430(), new 
Upgrade430to440(), new Upgrade440to441(), new Upgrade441to442(),
-new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460()});
+new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to453(), new Upgrade453to460()});
 
 _upgradeMap.put("2.2.1", new DbUpgrade[] {new Upgrade221to222(), 
new UpgradeSnapshot223to224(), new Upgrade222to224(),
 new Upgrade224to225(), new Upgrade225to226(), new 
Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to2213(),
 new Upgrade2213to2214(), new Upgrade2214to30(), new 
Upgrade30to301(), new Upgrade301to302(), new Upgrade302to40(),
 new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(), new Upgrade430to440(),
-new Upgrade440to441(), new Upgrade441to442(), new 
Upgrade442to450(), new Upgrade450to451(), new Upgrade451to452(), new 
Upgrade452to460()});
+new Upgrade440to441(), new Upgrade441to442(), new 
Upgrade442to450(), new Upgrade450to451(), new Upgrade451to452(), new 
Upgrade452to453(), new Upgrade453to460()});
 
 _upgradeMap.put("2.2.2", new DbUpgrade[] {new Upgrade222to224(), 
new UpgradeSnapshot223to224(), new Upgrade224to225(),
 new Upgrade225to226(), new Upgrade227to228(), new 
Upgrade228to229(), new Upgrade229to2210(),
 new Upgrade2210to2211(), new Upgrade2211to2212(), new 
Upgrade2212to2213(), new Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.3", new DbUpgrade[] {new Upgrade222to224(), 
new UpgradeSnapshot223to224(), new Upgrade224to225(),
 new Upgrade225to226(), new Upgrade227to228(), new 
Upgrade228to229(), new Upgrade229to2210(),
 new Upgrade2210to2211(), new Upgrade2211to2212(), new 
Upgrade2212to2213(), new Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.4", new DbUpgrade[] {new Upgrade224to225(), 
new Upgrade225to226(), new Upgrade227to228(),
 new Upgrade228to229(), new Upgrade229to2210(), new 
Upgrade2210to2211(), new Upgrade2211to2212(),
 new Upgrade2212to2213(), new Upgrade2213to2214(), new 
Upgrade2214to30(), new Upgrade30to301(),
 new Upgrade301to302(), new Upgrade302to40(), new 
Upgrade40to41(), new Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.5", new DbUpgrade[] {new Upgrade225to226(), 
new Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

[sateesh-chodapuneedi]

Github user sateesh-chodapuneedi commented on the pull request:

https://github.com/apache/cloudstack/pull/828#issuecomment-140357559
  
LGTM.
Can you please share more details on testing you have performed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/792#discussion_r39499607
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
@@ -3407,6 +3390,18 @@ public void handleSrAndVdiDetach(final String iqn, 
final Connection conn) throws
 removeSR(conn, sr);
 }
 
+protected void destroyUnattachedVBD(Connection conn, VM vm) {
+try {
+for (VBD vbd : vm.getVBDs(conn)) {
+if (Types.VbdType.DISK.equals(vbd.getType(conn)) && 
!vbd.getCurrentlyAttached(conn)) {
+vbd.destroy(conn);
+}
+}
+} catch (final Exception e) {
+s_logger.debug("destroyUnattachedVBD failed due to " + 
e.toString());
--- End diff --

maybe add the exception or/and catch more specific exceptions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/792#issuecomment-140359521
  
one remark, lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-140360164
  
@mike-tutkowski @DaanHoogland @karuturi @miguelaferreira @rafaelweingartner 
@pedro-martins 

First of all let me just get one thing clear: Rafael mentioned that he has 
a script that changes the Java files automatically. Did I read it right? If so, 
why doesn't this script also compile the code with a simple Maven run after the 
changes?

We have been suffering from things that simply break and are difficult to 
track because PRs are not properly reviewed/tested. In this particular case, 
how is possible to get 2 LGTM without even compiling the project locally?

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/825#issuecomment-140361064
  
LGTM, thanks @borisroman 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/825


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-140365763
  
@wilderrodrigues I commented: "travis timeouts are unrelated. analysis 
passes, LGTM". So it was compiled otherwise the analysis would not have passed. 
What I missed there was the noredist build. This one must be run instead of the 
regular in cloudstack-pull-anaysis. hat job doesn't run at all atm. I made an 
infra ticket for that and next we need to (finaly) get the noredist in there. 
It had been on my list and was phased out of it. it is no back on :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-140366106
  
@karuturi @remibergsma @rafaelweingartner @DaanHoogland @miguelaferreira 

Please, before proceeding with this PR see my comments on the previous 
(#714) one.

We would like to hear what is the problem with the current approach before 
we get this change in. And before LGTM it, please make sure that at least the 
following tests are executed:

test_routers.py
test_vm_life_cycle.py
test_vpc_routers.py
test_vpc_routers_nics.py
test_reset_vm_on_reboot.py

Also, this branch branch cannot be automatically merged. It has conflicts! 
It will be a nightmare to get it through.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-140366714
  
@rafaelweingartner do you think "Re-pushing the PR 714" is a good commit 
header?
I mean when someone goes thought the commit list looking for something, 
will that header provide information to what is the underlying code change 
about?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-noredist #4653

[jenkins]

See 

Changes:

[Boris Schrijver] Replaced all occurences of Charset.forName(UTF-8) with 
StringUtils.getPreferredCharset().

--
[...truncated 6099 lines...]
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-plugin-user-authenticator-saml2 ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-plugin-netapp ---
[INFO] Building jar: 

[INFO] 
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ 
cloud-plugin-netapp ---
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on 
project cloud-plugin-network-vcs: Compilation failure: Compilation failure:
[ERROR] 
:[95,11]
 error: cannot find symbol
[ERROR] symbol:   class Output
[ERROR] location: class BrocadeVcsApi
[ERROR] 
:[366,14]
 error: cannot find symbol
[ERROR] symbol:   class Output
[ERROR] location: class BrocadeVcsApi
[ERROR] 
:[423,14]
 error: cannot find symbol
[ERROR] symbol:   class Output
[ERROR] location: class BrocadeVcsApi
[ERROR] 
:[120,8]
 error: cannot find symbol
[ERROR] symbol:   class PortProfileGlobal
[ERROR] location: class BrocadeVcsApi
[ERROR] 
:[120,50]
 error: cannot find symbol
[ERROR] symbol:   class PortProfileGlobal
[ERROR] location: class BrocadeVcsApi
[ERROR] 
:[121,19]
 error: cannot find symbol
[ERROR] symbol:   method setVlanProfile()
[ERROR] location: variable portProfile of type PortProfile
[ERROR] 
:[122,8]
 error: cannot find symbol
[ERROR] symbol:   class Activate
[ERROR] location: class BrocadeVcsApi
[ERROR] 
:[122,32]
 error: cannot find symbol
[ERROR] symbol:   class Activate
[ERROR] location: class BrocadeVcsApi
[ERROR] 
:[135,34]
 error: PortProfile() is not public in PortProfile; cannot be accessed from 
outside package
[ERROR] 
:[136,19]
 error: cannot find symbol
[ERROR] symbol:   method setName(String)
[ERROR] location: variable portProfile of type PortProfile
[ERROR] 
:[149,8]
 error: cannot find symbol
[ERROR] symbol:   class VlanProfile
[ERROR] location: class BrocadeVcsApi
[ERROR] 
:[149,38]
 error: cannot find symbol
[ERROR] symbol:   class VlanProfile
[ERROR] location: class BrocadeVcsApi
[ERROR] 
:[164,8]
 error: cannot find symbol
[ERROR] symbol:   class SwitchportBasic
[ERROR] location: class Brocad

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-140367124
  
Hi @DaanHoogland, what I don't understand is how travis compiled and 15 
days ago @rafaelweingartner  said that he forgot to push 1 file.

Looking at the history, we see the following:


![image](https://cloud.githubusercontent.com/assets/5129209/9875766/1f62e9f0-5bb1-11e5-84be-ab3d50057a86.png)

So, perhaps the timeout occurred before the missing file was needed, so one 
could not tell if it would have worked at all. Therefore we have to compile the 
PRs and test them before LGTM.

I also don't get why @mike-tutkowski simply gave a LGTM without any 
comment. Come on, guys... lets improve ACS, not make it worse.

In the past - not long ago - we had problems with HyperV, not even used in 
our environment, and also with static fields not initialised properly that 
caused systemVMs to not start at all. If I see a change of +4k line 380 files 
in a tightly-coupled system like ACS, I would test it as much as I could before 
saying anything.

@rafaelweingartner @pedro-martins : do you have a test environment? 

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-140368629
  
and later we see:


![untitled](https://cloud.githubusercontent.com/assets/2486961/9875930/82d5a148-5bb2-11e5-8687-730633f8ff36.png)
We now found a point of improvement in our CI. The point of CI is that we 
can rely on it and that a reviewer does not need to run tests every time, 
exceptions are there to confirm this rule, of course.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

[Wido den Hollander]

On 15-09-15 13:56, Dmytro Shevchenko wrote:
> Hello Wido, I saw you updated this code again. Maybe you know, what
> procedure for rebuilding this library in Apache maven repository?
> Because here http://repo.maven.apache.org/maven2/com/ceph/rados/ still
> present only old 0.1.4 version and it's impossible recompile Cloudstack
> with new patches.  Of cause we can download source code from Github,
> compile it and replace 'jar' file on production, but this is dirty hack
> and not acceptable for 'continues integration'.
> 

It's up to me to do a new release of rados-java and I haven't done that
yet since I wanted to know for sure if the code works.

While writing some code for libvirt yesterday I came up with a better
solution for rados-java as well.

https://www.redhat.com/archives/libvir-list/2015-September/msg00458.html

For now you can replace 'rados.jar' on the production systems, but for
4.6 I want to make sure we depend on a new, to be released, version of
rados-java.

Wido

> 
> ---
> Best regards
> Dmytro Shevchenko
> dshevchenko.m...@gmail.com
> skype: demonsh_mk
> 
> 
> On 09/12/2015 06:16 PM, Wido den Hollander wrote:
>> On 09/11/2015 05:08 PM, Andrija Panic wrote:
>>> THx a lot Wido !!! - we will patch this - For my understanding - is this
>>> "temorary"solution - since it raises limit to 256 snaps ? Or am I
>>> wrong ? I
>>> mean, since we dont stil have proper snapshots removal etc, so after
>>> i.e.
>>> 3-6months we will again have 256 snapshots of a single volume on CEPH ?
>>>
>> No, it will also work with >256 snapshots. I've tested it with 256 and
>> that worked fine. I see no reason why it won't work with 1024 or 2048
>> for example.
>>
>>> BTW we also have other exception, that causes same consequences - agent
>>> disocnnecting and VMs going down...
>>> As Dmytro explained, unprotecting snapshot causes same consequence...
>>>
>>>  From my understanding, any RBD exception, might cause Agent to
>>> disconnect
>>> (or actually mgmt server to disconnect agent)...
>>>
>>> Any clue on this, recommendation?
>>>
>> No, I don't have a clue. It could be that the job hangs somewhere inside
>> the Agent due to a uncaught exception though.
>>
>>> Thx a lot for fixing rados-java stuff !
>>>
>> You're welcome!
>>
>> Wido
>>
>>> Andrija
>>>
>>> On 11 September 2015 at 15:28, Wido den Hollander 
>>> wrote:
>>>
 On 11-09-15 14:43, Dmytro Shevchenko wrote:
> Thanks a lot Wido! Any chance to find out why management server
> decided
> that it lost connection to agent after that exceptions? It's not so
> critical as this bug with 16 snapshots, but during last week we catch
> situation when Agent failed unprotect snapshot, rise exception and
> this
> is was a reason of disconnection a bit later after that. (It is not
> clear why CS decided remove that volume, it was template with one
> 'gold'
> snapshot with several active clones)
>
 No, I didn't look at CS at all. I just spend the day improving the
 RADOS
 bindings.

 Wido

> On 09/11/2015 03:20 PM, Wido den Hollander wrote:
>> On 11-09-15 10:19, Wido den Hollander wrote:
>>> On 10-09-15 23:15, Andrija Panic wrote:
 Wido,

 could you folow maybe what my colegue Dmytro just sent ?

>>> Yes, seems logical.
>>>
 Its not only matter of question fixing rados-java (16 snaps limit)
 - it
 seems that for any RBD exception, ACS will freak out...

>>> No, a RbdException will be caught, but the Rados Bindings shouldn't
>>> throw NegativeArraySizeException in any case.
>>>
>>> That's the main problem.
>>>
>> Seems to be fixed with this commit:
>>
 https://github.com/ceph/rados-java/commit/5584f3961c95d998d2a9eff947a5b7b4d4ba0b64

>> Just tested it with 256 snapshots:
>>
>> ---
>>T E S T S
>> ---
>> Running com.ceph.rbd.TestRbd
>> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
>> 521.014 sec
>>
>> Results :
>>
>> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>>
>> The bindings should now be capable of listing more then 16 snapshots.
>>
>> You can build the bindings manually and replace rados.jar on your
>> running systems.
>>
>> For 4.6 I'll try to get the updated rados-java included.
>>
>> Wido
>>
>>> Wido
>>>
 THx

 On 10 September 2015 at 17:06, Dmytro Shevchenko <
 dmytro.shevche...@safeswisscloud.com> wrote:

> Hello everyone, some clarification about this. Configuration:
> CS: 4.5.1
> Primary storage: Ceph
>
> Actually we have 2 separate bugs:
>
> 1. When you remove some volume with more then 16 snapshots
> (doesn't
> matter
> destroyed o

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

[sureshanaparti]

Github user sureshanaparti commented on the pull request:

https://github.com/apache/cloudstack/pull/828#issuecomment-140369704
  
@sateesh-chodapuneedi These changes were successfully tested on Apple 
hardware. When a VM is created with guest OS as Apple Mac OS, the USB 
controller (EHCI+UHCI) is added to the VM and enables the USB mouse and 
keyboard access.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

[sateesh-chodapuneedi]

Github user sateesh-chodapuneedi commented on the pull request:

https://github.com/apache/cloudstack/pull/828#issuecomment-140370176
  
@sureshanaparti that sounds good.
Thanks for the patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

VPC router issue

[Wilder Rodrigues]

Hi all,

This morning I shared a message on our Slack channel about the current issue 
I’m facing with VPC routers. The problem was caught by the test_vpc_routers.py 
tests, which are unable to verify the following:

* Create a VPC with 2 Tiers, 3 VMs, 2Pub IPs, and 1 ACL
* Stop the VPC router
* Start the VPC router

I have been busy trying to figure out when it stopped working when I then 
stopped at commit 
https://github.com/apache/cloudstack/commit/f5e5f4d0026f8ffd6f3aa7e8e4c7be0cd809d6c9
 - although it’s not really the one causing the issue given what I have changed 
there.

The only way to get it working is by restarting the VPC with the cleanup option 
- os destroying the VPC router and just restarting the VPC.

Since not many people have been testing the routers as much as I do, it seems 
no one is aware of this issue.

Long story short: current master is broken.

/me digging through PRs to find the root cause.

Cheers,
Wilder

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

[Jayapal Reddy Uradi]

Assigned to myself.

Thanks,
Jayapal
> On 15-Sep-2015, at 2:49 pm, Raja Pullela  wrote:
> 
> Hi,
> 
> JIRA - ticket https://issues.apache.org/jira/browse/CLOUDSTACK-8843
> Can someone please pick up this ticket ?  This is failing a bunch of the BVTs 
> tests in Basiczone.
> 
> Thanks,
> Raja

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

[Wilder Rodrigues]

I have the feeling that we are fixing 1 issue and created 2.

Please, make sure the routers tests are executed and green before creating the 
PR. I will do the same.

Cheers,
Wilder


> On 15 Sep 2015, at 14:23, Jayapal Reddy Uradi  
> wrote:
> 
> Assigned to myself.
> 
> Thanks,
> Jayapal
>> On 15-Sep-2015, at 2:49 pm, Raja Pullela  wrote:
>> 
>> Hi,
>> 
>> JIRA - ticket https://issues.apache.org/jira/browse/CLOUDSTACK-8843
>> Can someone please pick up this ticket ?  This is failing a bunch of the 
>> BVTs tests in Basiczone.
>> 
>> Thanks,
>> Raja
> 

Build failed in Jenkins: build-master-jdk18 #352

[jenkins]

See 

Changes:

[Boris Schrijver] Replaced all occurences of Charset.forName(UTF-8) with 
StringUtils.getPreferredCharset().

--
[...truncated 5515 lines...]
[INFO] Apache CloudStack Plugin - Hypervisor KVM . SUCCESS [32.546s]
[INFO] Apache CloudStack Plugin - RabbitMQ Event Bus . SUCCESS [5.785s]
[INFO] Apache CloudStack Plugin - In Memory Event Bus  SUCCESS [10.916s]
[INFO] Apache CloudStack Plugin - Kafka Event Bus  SUCCESS [4.732s]
[INFO] Apache CloudStack Plugin - Hypervisor Baremetal ... SUCCESS [12.502s]
[INFO] Apache CloudStack Plugin - Hypervisor UCS . SUCCESS [6.668s]
[INFO] Apache CloudStack Plugin - Hypervisor Hyper-V . SUCCESS [15.495s]
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM3 ... SUCCESS [43.535s]
[INFO] Apache CloudStack Plugin - Network Elastic Load Balancer  SUCCESS 
[14.243s]
[INFO] Apache CloudStack Plugin - Network Internal Load Balancer  SUCCESS 
[22.559s]
[INFO] Apache CloudStack Framework - Spring Life Cycle ... SUCCESS [4.786s]
[INFO] Apache CloudStack Plugin - Network Juniper Contrail  SUCCESS [35.560s]
[INFO] Apache CloudStack Plugin - Palo Alto .. SUCCESS [19.304s]
[INFO] Apache CloudStack Plugin - Network Netscaler .. SUCCESS [11.396s]
[INFO] Apache CloudStack Plugin - Network Nicira NVP . SUCCESS [32.444s]
[INFO] Apache CloudStack Plugin - BigSwitch Virtual Network Segment  SUCCESS 
[21.689s]
[INFO] Apache CloudStack Plugin - Network Brocade VCS  FAILURE [12.401s]
[INFO] Apache CloudStack Plugin - Midokura Midonet ... SKIPPED
[INFO] Apache CloudStack Plugin - Stratosphere SSP ... SKIPPED
[INFO] Apache CloudStack Plugin - Network Opendaylight ... SKIPPED
[INFO] Apache CloudStack Plugin - Storage Allocator Random  SKIPPED
[INFO] Apache CloudStack Plugin - User Authenticator LDAP  SKIPPED
[INFO] Apache CloudStack Plugin - User Authenticator MD5 . SKIPPED
[INFO] Apache CloudStack Plugin - User Authenticator PBKDF2-SHA-256  SKIPPED
[INFO] Apache CloudStack Plugin - User Authenticator Plain Text  SKIPPED
[INFO] Apache CloudStack Plugin - User Authenticator SAML2  SKIPPED
[INFO] Apache CloudStack Plugin - User Authenticator SHA256 Salted  SKIPPED
[INFO] Apache CloudStack Plugin - Dns Notifier Example ... SKIPPED
[INFO] Apache CloudStack Plugin - Storage Image S3 ... SKIPPED
[INFO] Apache CloudStack Plugin - Storage Image Swift provider  SKIPPED
[INFO] Apache CloudStack Plugin - Storage Image default provider  SKIPPED
[INFO] Apache CloudStack Plugin - Storage Image sample provider  SKIPPED
[INFO] Apache CloudStack Plugin - Storage Volume Nexenta Provider  SKIPPED
[INFO] Apache CloudStack Plugin - Storage Volume CloudByte Provider  SKIPPED
[INFO] Apache CloudStack Plugin - Storage Volume sample provider  SKIPPED
[INFO] Apache CloudStack Plugin - SNMP Alerts  SKIPPED
[INFO] Apache CloudStack Plugin - Syslog Alerts .. SKIPPED
[INFO] Apache CloudStack Plugin - Network VXLAN .. SKIPPED
[INFO] Apache CloudStack Plugin - GloboDNS ... SKIPPED
[INFO] Apache CloudStack Framework - Spring Module ... SKIPPED
[INFO] Apache CloudStack Secondary Storage Controller  SKIPPED
[INFO] Apache CloudStack Console Proxy - RDP Client .. SKIPPED
[INFO] Apache CloudStack Console Proxy ... SKIPPED
[INFO] Apache CloudStack Console Proxy - Server .. SKIPPED
[INFO] Apache CloudStack System VM ... SKIPPED
[INFO] Apache CloudStack Client UI ... SKIPPED
[INFO] Apache CloudStack Framework - QuickCloud .. SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 17:43.659s
[INFO] Finished at: Tue Sep 15 12:30:09 UTC 2015
[INFO] Final Memory: 66M/210M
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on 
project cloud-plugin-network-vcs: Compilation failure: Compilation failure:
[ERROR] 
:[95,11]
 error: cannot find symbol
[ERROR] symbol:   class Output
[ERROR] location: class BrocadeVcsApi
[ERROR] 
:[366,14]
 error: cannot find symbol
[ERROR] symbol:   class Output
[ERROR] location: class BrocadeVcsApi
[ERROR] 
:[423,14]
 error: cannot find symbol
[ERROR] symbol:   class Output
[ERROR] location: class B

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/825#issuecomment-140378109
  
@borisroman @wido 

Was this PR compiled locally? Master is now broken. When I try to build I 
get:

BrocadeVcsApi.java:[378,26] error: cannot find symbol

I checked the file and found out the following:

* Previous to @borisroman changes:

import com.cloud.dc.Vlan;
import com.cloud.utils.StringUtils;
import com.cloud.utils.cisco.n1kv.vsm.PortProfile;

* After @borisroman changes:

import com.cloud.network.schema.interfacevlan.InterfaceVlan;
import com.cloud.network.schema.interfacevlan.Interface;
import com.cloud.network.schema.interfacevlan.Vlan;
import com.cloud.network.schema.portprofile.PortProfile;
import com.cloud.network.schema.portprofile.PortProfile.Activate;
import com.cloud.network.schema.portprofile.PortProfile.Static;
import com.cloud.network.schema.portprofile.PortProfileGlobal;
import com.cloud.network.schema.portprofile.VlanProfile;
import com.cloud.network.schema.portprofile.VlanProfile.Switchport;
import com.cloud.network.schema.portprofile.VlanProfile.Switchport.Mode;
import com.cloud.network.schema.portprofile.VlanProfile.Switchport.Trunk;
import 
com.cloud.network.schema.portprofile.VlanProfile.Switchport.Trunk.Allowed;
import com.cloud.network.schema.portprofile.VlanProfile.SwitchportBasic;
import 
com.cloud.network.schema.portprofile.VlanProfile.SwitchportBasic.Basic;
import com.cloud.network.schema.showvcs.Output;

Which gives also this error:

PortProfile() is not public in PortProfile; cannot be accessed from outside 
package.

The imports are all wrong. Could you please fix it?

ping @remibergsma @miguelaferreira @DaanHoogland @karuturi @bhaisaab 

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

[Jayapal Reddy Uradi]

Wilder, That is true.

All these issues are because of the VR refactoring. I don’t know what are the 
unit test cases run on VR refactor code.
VR (shell) scripts  are stabilized over years and now suddenly moved to new 
implementation. What we have figured out is that this new implementation is 
done only partially. What I am suggesting now to move ahead is to call the 
existing/old shell  scripts in new implementation for configuring the VR to 
avoid spending time on unnecessary bugs.  
With current implementation we may see many issues in production for some time 
to come.

Thanks,
Jayapal

> On 15-Sep-2015, at 5:57 pm, Wilder Rodrigues  
> wrote:
> 
> I have the feeling that we are fixing 1 issue and created 2.
> 
> Please, make sure the routers tests are executed and green before creating 
> the PR. I will do the same.
> 
> Cheers,
> Wilder
> 
> 
>> On 15 Sep 2015, at 14:23, Jayapal Reddy Uradi 
>>  wrote:
>> 
>> Assigned to myself.
>> 
>> Thanks,
>> Jayapal
>>> On 15-Sep-2015, at 2:49 pm, Raja Pullela  wrote:
>>> 
>>> Hi,
>>> 
>>> JIRA - ticket https://issues.apache.org/jira/browse/CLOUDSTACK-8843
>>> Can someone please pick up this ticket ?  This is failing a bunch of the 
>>> BVTs tests in Basiczone.
>>> 
>>> Thanks,
>>> Raja
>> 
> 

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/825#issuecomment-140378819
  
@wilderrodrigues If something breaks master, any committer can revert it in 
order to restore stability. I didn't verify yet, but feel free to revert and 
ping the dev-list about it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-140379362
  
@wilderrodrigues I got your point, and I also hate when projects that I 
work start breaking as a consequence of bad/poor code. Here goes an explanation 
in a timeline manner, so you can get a better understanding of everything that 
happened:

When I assigned that “task” to an intern (@pedro-martins), he executed 
it going class by class literally (I have to give credits for him to be so calm 
and controlled, I would not stand to do that). While doing that he noted down 
classes that he was changing the code. When he pushed, @DaanHoogland pointed 
out that the PR was adding more lines then removing due to code formatting. 
Therefore, he created a script that was fed with that list of classes and 
performed the changes (deleted the lines that had to be deleted and changed the 
variable names that had to be changed). Another problem arose, for some reason 
in a few classes such as “VMwareGuru” there are static methods that do not 
need to be static and that use the “logger” variable, with our PR that had 
to be changed. He was supposed to find each of the classes that had a problem 
from that “ComponentLifecycleBase” hierarchic and fix it. Sadly, he missed 
one class out of 380. We indeed tried to build the whole pro
 ject with a maven install, but it did not work at that time, there was a 
problem with a class that we have not touched. 

After that the PR 714 was merged by @DaanHoogland, and then reverted by 
@karuturi.

When I noticed that problem, I got the task and created a script that 
really builds the whole “ComponentLifecycleBase” hierarchic and executes 
the deletes and changes on variable names that are needed. Then I manually 
check the classes that have some problem, around 8 classes that have static 
methods that do not need to be static. I created a new PR #778 for that, 
because we did not find a way to re-open the PR #714. The first time I pushed 
to PR 778 I successfully did a maven install on ACS to check for compilation 
problems that might be caused by our change. Then the time passed on (conflicts 
appeared) and I did another two rebases, the first one I hit a problem with a 
missing class on “cloud-plugin-network-vcs”  and the last one another 
missing class on “cloud-framework-db”.

I had sent an email asking about the first missing class I found, but got 
no answers.

Now to answer your first question, I indeed created a script, but just 
after the PR 714 was reverted (we were not kidding about that). Moreover, the 
pushes I did to PR 778 I made sure to execute a maven run to build the project 
and see if everything was ok. Sadly I hit other problems with missing classes. 

Sadly during PR 714, we had problems with Travis build timeouts at the same 
time that we were working on PR 714, if Travis CI was working properly we would 
have spotted the problem and the PR 714 would not need to be reverted.

@wilderrodrigues now your last point, we indeed have a production and test 
environments running ACS 4.3.2 (both the same version because we are extending 
ACS, everything we build is added into our 4.3.2, tested and then pushed to our 
production environment), that is why we are not building the components changed 
and testing it here. We did not see a reason to add this PR was not also added 
to 4.3.2. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-140380153
  
@wilderrodrigues thanks for your comments, I have just answered your 
comments on PR 714. I will work on a rebase today and push it again.

@miguelaferreira, I really do not find that a good name. I was just without 
a good inspiration to create one ;) What about this one now?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/825#issuecomment-140380659
  
Reverted by commit 6e426fa46d8cda50ec76f33429320d4590701678


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reverted PR 825

[Wilder Rodrigues]

Guys,

Unfortunately, PR 825 broke Master. Due to that, Remi and I just reverted it.

@Boris: please fix the error and reopen the PR.

Cheers,
Wilder

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/825#issuecomment-140388758
  
Building is passing again:

[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 7:52.562s
[INFO] Finished at: Tue Sep 15 15:14:58 GMT 2015
[INFO] Final Memory: 91M/414M
[INFO] 

[root@cs1 cloudstack]# 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

[Wilder Rodrigues]

Hi Jayapal,

I would not suggest to move back to the sceptres, but focus on fixing and for 
every fix test it very well so we get confidence. If we start calling scripts 
com the python code it will have a huge chance to become a real mess!

Let’s stick to it and fix it and once it’s stable we can discuss a refactor of 
the thing from scratch - we already have some ideas.

The most important point is: for everyone touching Java/Python code, please 
test your changes before creating PRs or LGTM other’s committers PRs.

Cheers,
Wilder


> On 15 Sep 2015, at 14:52, Jayapal Reddy Uradi  
> wrote:
> 
> Wilder, That is true.
> 
> All these issues are because of the VR refactoring. I don’t know what are the 
> unit test cases run on VR refactor code.
> VR (shell) scripts  are stabilized over years and now suddenly moved to new 
> implementation. What we have figured out is that this new implementation is 
> done only partially. What I am suggesting now to move ahead is to call the 
> existing/old shell  scripts in new implementation for configuring the VR to 
> avoid spending time on unnecessary bugs.  
> With current implementation we may see many issues in production for some 
> time to come.
> 
> Thanks,
> Jayapal
> 
>> On 15-Sep-2015, at 5:57 pm, Wilder Rodrigues  
>> wrote:
>> 
>> I have the feeling that we are fixing 1 issue and created 2.
>> 
>> Please, make sure the routers tests are executed and green before creating 
>> the PR. I will do the same.
>> 
>> Cheers,
>> Wilder
>> 
>> 
>>> On 15 Sep 2015, at 14:23, Jayapal Reddy Uradi 
>>>  wrote:
>>> 
>>> Assigned to myself.
>>> 
>>> Thanks,
>>> Jayapal
 On 15-Sep-2015, at 2:49 pm, Raja Pullela  wrote:
 
 Hi,
 
 JIRA - ticket https://issues.apache.org/jira/browse/CLOUDSTACK-8843
 Can someone please pick up this ticket ?  This is failing a bunch of the 
 BVTs tests in Basiczone.
 
 Thanks,
 Raja
>>> 
>> 
> 

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-140392192
  
"In this particular case, how is possible to get 2 LGTM without even 
compiling the project locally?"

I was depending on the info Daan refers to and, as such, did not build it 
locally.

By the time I came into the picture with regards to this PR, it was mainly 
a matter of looking through 361 files for changes to the name of a variable. 
Not sure how verbose of a comment you'd like for that, but it looked reasonable 
to me.

Perhaps we need to document on our Wiki exactly what needs to go into a 
review (including comments).

A lot of reviews for PRs that I've seen have taken my approach here: The PR 
submitter asked for another review, a reviewer took time to go through the code 
online, but didn't compile because he/she expected asfbot's SUCCESS meant it 
was OK from that standpoint, then wrote "LGTM."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/804#issuecomment-140395721
  
We got a :-1:  from @DaanHoogland  and still the PR was merged without any 
explanation from the author.

Was it tested by anyone?

ping @bhaisaab @borisroman @remibergsma @miguelaferreira 

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: VPC router issue

[Wilder Rodrigues]

6 days ago test_pc_routers.py succeeded with  PR 788:

https://github.com/apache/cloudstack/pull/788

It’s in the test results I put there.

I’m now testing Master to verify if it’s still occurring there. I tested the PR 
#808 (https://github.com/apache/cloudstack/pull/805), which had a bunch of 
tests executed against, but not the test_vpc_routers, and there it fails.

So, the problem occurred between 788 and 805.

Will keep digging.

Cheers,
Wilder


On 15 Sep 2015, at 14:18, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>> wrote:

Hi all,

This morning I shared a message on our Slack channel about the current issue 
I’m facing with VPC routers. The problem was caught by the test_vpc_routers.py 
tests, which are unable to verify the following:

* Create a VPC with 2 Tiers, 3 VMs, 2Pub IPs, and 1 ACL
* Stop the VPC router
* Start the VPC router

I have been busy trying to figure out when it stopped working when I then 
stopped at commit 
https://github.com/apache/cloudstack/commit/f5e5f4d0026f8ffd6f3aa7e8e4c7be0cd809d6c9
 - although it’s not really the one causing the issue given what I have changed 
there.

The only way to get it working is by restarting the VPC with the cleanup option 
- os destroying the VPC router and just restarting the VPC.

Since not many people have been testing the routers as much as I do, it seems 
no one is aware of this issue.

Long story short: current master is broken.

/me digging through PRs to find the root cause.

Cheers,
Wilder

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/804#issuecomment-140400310
  
@wilderrodrigues Not sure if @DaanHoogland actually :-1: it, he said he 
wouldn't do that. It's confusing though ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-140402029
  
I could say this again, but it doesn't seem like it's a popular opinion 
with regards to CloudStack development:

If we are really "late in the game" with regards to the 4.6 release, then 
probably half or more of the PRs we put into the codebase should not be going 
in at this point (they should be going into 4.7).

The way most software development I've been involved with over the past 17 
years works is that defect and enhancement tickets are prioritized by a 
cross-functional team (it doesn't have to be cross functional, though, for CS).

These defect/enhancement priorities along with the stage at which we are in 
development (i.e. how close we are to our release deadline) inform what 
actually goes into the current release and what is postponed to the next 
release.

We have a habit with CS of just continuously churning the codebase up until 
the very last moment.

If we had an awesome suite of regression tests, we might be able to get 
away with that. I saw "we might," but - in reality - it's still not a good idea 
to do that. Many defects don't show up until the code has "soaked" over long 
periods of time and we don't have any way to protect against that the way we 
develop and test CS code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8850: revertSnapshot command d...

[yvsubhash]

GitHub user yvsubhash opened a pull request:

https://github.com/apache/cloudstack/pull/831

CLOUDSTACK-8850: revertSnapshot command does not work

Updating the documentation before the api is actually supported

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-8850

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #831


commit 7d83ca9e0aea4744474f62a3a3ccee4b5fa8090d
Author: subhash yedugundla 
Date:   2015-09-15T13:55:41Z

CLOUDSTACK-8850: revertSnapshot command does not work
Updating the documentation before the api is actually supported




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/804#issuecomment-140403283
  
@remibergsma indeed. Perhaps I have been through many untested PRs today 
and one more just got my brain in a fuzzy state.

My argument remains as the PR lacks context and tests, although it got 
merged.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-140403471
  
@mike-tutkowski **we** don't have an awesome suite of regression tests 
because **we** don't write them. And if so, we should not rely on the builds we 
have, like @DaanHoogland  mentioned, because we know they are flakey at best. I 
do agree with you when you say that we should make the review process a bit 
more detailed and formalised. Simply giving out a LGTM because someone else 
already did and we don't see anything strange while skimming through the code, 
is definitely not enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-140403964
  
@rafaelweingartner I totally understand. Inspiration is not something that 
always comes when needed. Please do take your time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-140404617
  
Right, Miguel (as you and I were discussing for that other PR with regards 
to tests).

My point then is we especially should not be putting in this much code so 
close to a 4.6 GA. No commercial-grade software I've ever worked on does that 
(and they did have awesome suites of regression tests).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/832

Replaced all occurences of Charset.forName(UTF-8) with 
StringUtils.getPreferredCharset().



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack charset

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #832


commit c855e93a6a2bb38c94bbb4e6a30c0f338c8e2c88
Author: Boris Schrijver 
Date:   2015-09-15T14:44:59Z

Replaced all occurences of Charset.forName(UTF-8) with 
StringUtils.getPreferredCharset().




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

After box restart CS 4.5.2 fails to start

[Keerthiraja SJ]

Hi All,

Today I installed CS 4.5.2 on CentOS 6.7 and able to start the app
successfully.

All of a sudden the box reboot then while I started the cloudsatck it fails
to start where I could see a different issue and ERROR on catalina.out

ERROR
==
INFO  [c.c.s.ConfigurationServerImpl] (main:null) Processing
updateSSLKeyStore
INFO  [c.c.s.ConfigurationServerImpl] (main:null) SSL keystore located at
/etc/cloudstack/management/cloudmanagementserver.keystore
WARN  [c.c.s.ConfigurationServerImpl] (main:null) Would use fail-safe
keystore to continue.
java.io.IOException: Fail to create keystore file!
at
com.cloud.server.ConfigurationServerImpl.updateSSLKeystore(ConfigurationServerImpl.java:664)
at
com.cloud.server.ConfigurationServerImpl.persistDefaultValues(ConfigurationServerImpl.java:304)
at
com.cloud.server.ConfigurationServerImpl.configure(ConfigurationServerImpl.java:166)
at
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle$3.with(CloudStackExtendedLifeCycle.java:114)
at
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.with(CloudStackExtendedLifeCycle.java:153)
at
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.configure(CloudStackExtendedLifeCycle.java:110)
at
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:56)
at
org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:167)
at
org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:51)
at
org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:339)
at
org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:143)
at
org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:108)
at
org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:945)
at
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:482)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:122)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:245)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:233)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:117)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:79)
at
org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
at
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:70)
at
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:57)
at
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:61)
at
org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:52)
at
org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4210)
at
org.apache.catalina.core.StandardContext.start(StandardContext.java:4709)
at
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:791)
at
org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:771)
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:526)
at
org.apache.catalina.startup.HostConfig.deployDirectory(HostConfig.java:1041)
at
org.apache.catalina.startup.HostConfig.deployDirectories(HostConfig.java:964)
at
org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:502)
at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1277)
at
org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:321)
at
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:142)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1053)
at org.apache.catalina.core.StandardHost.start(StandardHost.java:722)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1045)
at
org.apache.catalina.core.StandardEngin

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/804#issuecomment-140420588
  
@wilderrodrigues -> @DaanHoogland Didn't -1, he actually said the opposite. 
The screenshots where added to provide context (question from daan). I tested 
them to confirm working order. After which I asked @wido to merge them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-140423615
  
I completely agree with you in this Mike. We should stop churning in 
features when we don't even have a proper build that prevents **syntax** errors!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-140424617
  
Maybe the compiler is overworked and just did a cursory glance and reported 
back "LGTM." ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-140423091
  
@wilderrodrigues conflicts solved, I tried to do a maven install, to run 
all tests and compile everything, but that did not work, hence there is a class 
missing "com.cloud.network.schema.showvcs.Output;"

@miguelaferreira I think the commit heading is better now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

[karuturi]

GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/833

changed the systemvm base iso file from debian-7.8.0 to debian-7.9.0

7.8.0 url is not available(404 Error)

This fixes the jenkins 
http://jenkins.buildacloud.org/job/build-systemvm-master/624/console which is 
failing with the below error
```
Checking if isofile iso-cd/debian-7.8.0-i386-netinst.iso already exists.
Full path: 
/home/jenkins/acs/workspace/build-systemvm-master/tools/appliance/iso/iso-cd/debian-7.8.0-i386-netinst.iso
There was an error downloading 
http://cdimage.debian.org/cdimage/archive/7.8.0/i386/iso-cd/debian-7.8.0-i386-netinst.iso:
404 Not Found
```

This is tested and build is successful at 
http://jenkins.buildacloud.org/view/parameterized/job/parameterized-sytemvm/1/


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cloudstack systemvm-build

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/833.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #833


commit eb98e71a34ed2e4b8d7798c7a93708312ed0a793
Author: Rajani Karuturi 
Date:   2015-09-15T16:16:18Z

changed the systemvm base iso file from debian-7.8.0 to debian-7.9.0

7.8.0 url is not available(404 Error)

This fixes the jenkins 
http://jenkins.buildacloud.org/job/build-systemvm-master/624/console which is 
failing with the below error

```
Checking if isofile iso-cd/debian-7.8.0-i386-netinst.iso already exists.
Full path: 
/home/jenkins/acs/workspace/build-systemvm-master/tools/appliance/iso/iso-cd/debian-7.8.0-i386-netinst.iso
There was an error downloading 
http://cdimage.debian.org/cdimage/archive/7.8.0/i386/iso-cd/debian-7.8.0-i386-netinst.iso:
404 Not Found
```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/833#issuecomment-140460941
  
I really dont know the implications of change it from debian-7.8.0 to 
debian-7.9.0. If there is a better fix available, please advise. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Build failed in Jenkins: build-systemvm-master #624

[Rajani Karuturi]

Rohit,
Can you review https://github.com/apache/cloudstack/pull/833 ?

Thanks,

~Rajani

On Tue, Sep 15, 2015 at 12:45 PM, Rajani Karuturi  wrote:

> ok. thanks. I will attempt a fix.
>
> ~Rajani
>
> On Tue, Sep 15, 2015 at 11:34 AM, Rohit Yadav 
> wrote:
>
>> The ISO url needs to be fixed to use 7.9.0 as  the 7.8.0 archive url is
>> not available.
>> http://cdimage.debian.org/cdimage/archive/7.9.0/
>>
>> On 15-Sep-2015, at 9:59 am, Rajani Karuturi 
>> wrote:
>>
>> Anyone understands why this is failing?
>>
>>
>> ~Rajani
>>
>>
>>
>> On 15-Sep-2015, at 3:23 am, jenk...@cloudstack.org wrote:
>>
>> See > >
>>
>> Changes:
>>
>> [Rajani Karuturi] CLOUDSTACK-8816 Fixed entityUuid missing in some cases
>> is events
>>
>> [Rajani Karuturi] CLOUDSTACK-8816: instance uuid is missing in events for
>> delete account
>>
>> [Rajani Karuturi] CLOUDSTACK-8816: entity uuid missing in create network
>> event
>>
>> [Rajani Karuturi] CLOUDSTACK-8816: Project UUID is not showing for some
>> of operations in RabbitMQ.
>>
>> [Rajani Karuturi] CLOUDSTACK-8816 Systemvm reboot event doesnt have
>> uuids. Fixed the same
>>
>> [Boris Schrijver] Added QCOW2 virtual size checking for S3.
>>
>> [anshul.gangwar] Fixed secstorage.proxy is not setting proxy
>> configuration on SSVM in some cases
>>
>> [Rajani Karuturi] CLOUDSTACK-8835: Added alerts incase of template
>> download failure
>>
>> [Boris Schrijver] Fixed Findbugs issue introduced by
>> 1c6378ec0056e8c75990a4a0c15e99b2df162a75 PR #795.
>>
>> [Boris Schrijver] Added Unit Tests for QCOW2Utils.
>>
>> [sanjeev] Tagging tests appropriately to pick them for running on basic
>> zone
>>
>> [sanjeev] Tagging tests appropriately to pick them for running on basic
>> zone
>>
>> [Rajani Karuturi] Revert "Tagging tests appropriately to pick them for
>> running on basic zone"
>>
>> --
>> [...truncated 1087 lines...]
>> + '[' -t 2 ']'
>> + echo '[2015-09-14 21:57:30] INFO: destroying existing veewee image, if
>> any'
>> [2015-09-14 21:57:30] INFO: destroying existing veewee image, if any
>> + set +e
>> + bundle exec veewee vbox destroy systemvmtemplate-master-4.6.0
>> Error:: You tried to destroy a non-existing box
>> 'systemvmtemplate-master-4.6.0'
>> + set -e
>> + add_on_exit veewee_destroy
>> + local n=3
>> + on_exit_items[${n}]=veewee_destroy
>> + '[' 3 -eq 0 ']'
>> + veewee_build
>> + log INFO 'building new image with veewee'
>> + local level=INFO
>> + shift
>> + [[ 1 != \1 ]]
>> + local code=
>> ++ date '+%F %T'
>> + local 'line=[2015-09-14 21:57:32] INFO: building new image with veewee'
>> + '[' -t 2 ']'
>> + echo '[2015-09-14 21:57:32] INFO: building new image with veewee'
>> [2015-09-14 21:57:32] INFO: building new image with veewee
>> + bundle exec veewee vbox build systemvmtemplate-master-4.6.0 --nogui
>> --auto
>> Downloading vbox guest additions iso v 4.3.14 -
>> http://download.virtualbox.org/virtualbox/4.3.14/VBoxGuestAdditions_4.3.14.iso
>> Checking if isofile VBoxGuestAdditions_4.3.14.iso already exists.
>> Full path: <
>> http://jenkins.buildacloud.org/job/build-systemvm-master/ws/tools/appliance/iso/VBoxGuestAdditions_4.3.14.iso
>> >
>>
>>
>> Fetching file:   0% |  | ETA:
>>  --:--:--
>> Fetching file:   1% || 652.2KB   3.6MB/s ETA:
>>   0:00:17
>> Fetching file:   2% ||   1.3MB   3.2MB/s ETA:
>>   0:00:19
>> Fetching file:   3% ||   1.9MB   3.2MB/s ETA:
>>   0:00:18
>> Fetching file:   4% ||   2.5MB   3.2MB/s ETA:
>>   0:00:18
>> Fetching file:   5% |o   |   3.1MB   3.2MB/s ETA:
>>   0:00:18
>> Fetching file:   6% |o   |   3.8MB   3.2MB/s ETA:
>>   0:00:18
>> Fetching file:   7% |o   |   4.4MB   3.3MB/s ETA:
>>   0:00:17
>> Fetching file:   8% |o   |   5.0MB   3.4MB/s ETA:
>>   0:00:17
>> Fetching file:   9% |oo  |   5.7MB   3.4MB/s ETA:
>>   0:00:16
>> Fetching file:  10% |oo  |   6.3MB   3.5MB/s ETA:
>>   0:00:16
>> Fetching file:  11% |oo  |   6.9MB   3.5MB/s ETA:
>>   0:00:15
>> Fetching file:  12% |oo  |   7.5MB   3.6MB/s ETA:
>>   0:00:15
>> Fetching file:  13% |ooo |   8.2MB   3.6MB/s ETA:
>>   0:00:15
>> Fetching file:  14% |ooo |   8.8MB   3.6MB/s ETA:
>>   0:00:15
>> Fetching file:  15% |ooo |   9.4MB   3.5MB/s ETA:
>>   0:00:15
>> Fetching file:  16% |ooo |  10.1MB   3.4MB/s ETA:
>>   0:00:15
>> Fetching file:  17% ||  10.7MB   3.4MB/s ETA:
>>   0:00:15
>> Fetching file:  18% ||  11.3MB   3.4MB/s ETA:
>>   0:00:15
>> Fetching file:  19% ||  12.0MB   3.4MB/s ETA:
>>   0:00:15
>> Fetching file:  20% | 

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-140487166
  
@rafaelweingartner Thanks for the time you spent on this. The commit header 
is indeed better. It now conveys what is being done. If you happen to have to 
change something in the commit again (for other reasons), may I suggest you 
follow what most people do and make the header like this: `CLOUDSTACK-8750: 
changed variable s_logger to logger non-static`

I've posted on the Jira ticket (CLOUDSTACK-8750) a question about why is 
this change being made. After reading the description of the ticket I couldn't 
figure out what is the improvement. Maybe you could shed some light on that?
Is it just, not having an extra line in each class declaring the logger? Or 
am I missing something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-140491359
  
Actually, the ticket is as simple as that. 

It was just an exercise to an intern that is working with me in my thesis. 
We are doing few very small cleans and changes in ACS code to teach some coding 
skills to some interns. Thus, we found pretty bothering to code sometimes, we 
were coding you start to write “log” and hit ctrl+space bar and nothing 
showed up, the same happens in classes that use the “_” to start variable 
names. We know that s_something is an ACS standard for static variables, but we 
thought that the name logger would be better. 

That was a pretty interesting proposal, because we could get to know a 
little better the ACS code, and found some others small things we could change 
to make the coding more pleasant. For instance, we are planning a PR removing 
the “@Local” from all classes of ComponenteLifeCycleBase, hence they all 
are either spring beans or manually instantiated.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-140493836
  
I do agree that prepending "s_" to static variables is a waste of 
characters. Modern IDEs will signal static variables for you. It's a bit like 
prepending (or appending) type information in the variable name. There was a 
time it was useful, but that time is long gone.

I also appreciate abstraction in code, that is, you've now introduced a 
protected variable in a base class that will be available to all the classes 
that extend it. However I do not see a real benefit in adding this particular 
indirection level. I mean, loggers are very straight forward to add and 
understand, so standardising on they declaration and use, seem to me far better 
than having it be a static variable in some classes, and a non 
static-protected-inherited variable in others.

There is plenty I would like see done in terms of cleaning the code of ACS. 
For instance I've measured duplicate code a year ago and found 25% of the code 
to be redundant. 
(http://www.slideshare.net/miguel_f/20141121-cccenoanimations)

The DB layer is another example. ACS is at the moment using a deprecated 
library for it's DB layer, while there are other libraries (e.g. spring-data) 
that would actually generate most of the hand-made code we have now.
I'll be very happy to share my thoughts with you about potential 
refactorings that would benefit the ACS code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8850: revertSnapshot command d...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/831#issuecomment-140508485
  
Please note revertSnapshot for KVM has been merged into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-140527418
  
I do agree with you that removing duplicated code, reducing cyclomatic 
complexity and writing test case is much better. However, those tasks require 
certain programing skills and knowledge of the code. I have interns that have 
never worked with Java, spring*, web applications and Eclipse/Netbeans. 
Therefore, I am starting introducing simple and pretty easy tasks, so they can 
get comfortable working on a huge project such as ACS. It takes a while to get 
used to working with tools such as Eclipse, Maven and Git. 

We are at the very beginning of my thesis. Most of them are not ready to 
start writing TDDs and refactoring methods. The ones that are, we already did 
some pretty interesting PRs: #560, #700 and #762.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/833#issuecomment-140554664
  
@karuturi Our mirror at PCextreme still hosts the Debian 7.8.0 image.


http://debian.apt-get.eu/cd-images/7.8.0/i386/iso-cd/debian-7.8.0-i386-netinst.iso

If upgrading to 7.9.0 fails we can change the image source to our mirror.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-systemvm-master #625

[jenkins]

See 

Changes:

[anshul.gangwar] CLOUDSTACK-8834: Fixed unable to download Template , when in 
multi zones

[wido] CLOUDSTACK-8645: Improve logging of RBD functionality in KVM

[Boris Schrijver] Replaced all occurences of Charset.forName(UTF-8) with 
StringUtils.getPreferredCharset().

[wrodrigues] Revert "Merge pull request #825 from borisroman/charset"

--
[...truncated 1087 lines...]
+ '[' -t 2 ']'
+ echo '[2015-09-15 21:57:34] INFO: destroying existing veewee image, if any'
[2015-09-15 21:57:34] INFO: destroying existing veewee image, if any
+ set +e
+ bundle exec veewee vbox destroy systemvmtemplate-master-4.6.0
Error:: You tried to destroy a non-existing box 'systemvmtemplate-master-4.6.0'
+ set -e
+ add_on_exit veewee_destroy
+ local n=3
+ on_exit_items[${n}]=veewee_destroy
+ '[' 3 -eq 0 ']'
+ veewee_build
+ log INFO 'building new image with veewee'
+ local level=INFO
+ shift
+ [[ 1 != \1 ]]
+ local code=
++ date '+%F %T'
+ local 'line=[2015-09-15 21:57:35] INFO: building new image with veewee'
+ '[' -t 2 ']'
+ echo '[2015-09-15 21:57:35] INFO: building new image with veewee'
[2015-09-15 21:57:35] INFO: building new image with veewee
+ bundle exec veewee vbox build systemvmtemplate-master-4.6.0 --nogui --auto
Downloading vbox guest additions iso v 4.3.14 - 
http://download.virtualbox.org/virtualbox/4.3.14/VBoxGuestAdditions_4.3.14.iso
Checking if isofile VBoxGuestAdditions_4.3.14.iso already exists.
Full path: 


   
Fetching file:   0% |  | ETA:  --:--:--
Fetching file:   1% || 646.0KB   4.2MB/s ETA:   0:00:14
Fetching file:   2% ||   1.3MB   3.8MB/s ETA:   0:00:16
Fetching file:   3% ||   1.9MB   3.8MB/s ETA:   0:00:15
Fetching file:   4% ||   2.5MB   3.7MB/s ETA:   0:00:16
Fetching file:   5% |o   |   3.1MB   3.8MB/s ETA:   0:00:15
Fetching file:   6% |o   |   3.8MB   3.7MB/s ETA:   0:00:15
Fetching file:   7% |o   |   4.4MB   3.8MB/s ETA:   0:00:15
Fetching file:   8% |o   |   5.0MB   3.7MB/s ETA:   0:00:15
Fetching file:   9% |oo  |   5.7MB   3.7MB/s ETA:   0:00:15
Fetching file:  10% |oo  |   6.3MB   3.6MB/s ETA:   0:00:15
Fetching file:  11% |oo  |   6.9MB   3.6MB/s ETA:   0:00:15
Fetching file:  12% |oo  |   7.5MB   3.6MB/s ETA:   0:00:15
Fetching file:  13% |ooo |   8.2MB   3.6MB/s ETA:   0:00:15
Fetching file:  14% |ooo |   8.8MB   3.6MB/s ETA:   0:00:14
Fetching file:  15% |ooo |   9.4MB   3.6MB/s ETA:   0:00:14
Fetching file:  16% |ooo |  10.1MB   3.6MB/s ETA:   0:00:14
Fetching file:  17% ||  10.7MB   3.6MB/s ETA:   0:00:14
Fetching file:  18% ||  11.3MB   3.6MB/s ETA:   0:00:14
Fetching file:  19% ||  11.9MB   3.6MB/s ETA:   0:00:14
Fetching file:  20% ||  12.6MB   3.6MB/s ETA:   0:00:13
Fetching file:  21% |o   |  13.2MB   3.6MB/s ETA:   0:00:13
Fetching file:  22% |o   |  13.8MB   3.6MB/s ETA:   0:00:13
Fetching file:  23% |o   |  14.5MB   3.6MB/s ETA:   0:00:13
Fetching file:  24% |o   |  15.1MB   3.6MB/s ETA:   0:00:13
Fetching file:  25% |oo  |  15.7MB   3.5MB/s ETA:   0:00:13
Fetching file:  26% |oo  |  16.4MB   3.5MB/s ETA:   0:00:13
Fetching file:  27% |oo  |  17.0MB   3.5MB/s ETA:   0:00:13
Fetching file:  28% |oo  |  17.6MB   3.5MB/s ETA:   0:00:12
Fetching file:  29% |oo  |  18.2MB   3.5MB/s ETA:   0:00:12
Fetching file:  30% |ooo |  18.9MB   3.5MB/s ETA:   0:00:12
Fetching file:  31% |ooo |  19.5MB   3.5MB/s ETA:   0:00:12
Fetching file:  32% |ooo |  20.1MB   3.5MB/s ETA:   0:00:12
Fetching file:  33% |ooo |  20.8MB   3.5MB/s ETA:   0:00:12
Fetching file:  34% ||  21.4MB   3.5MB/s ETA:   0:00:11
Fetching file:  35% ||  22.0MB   3.5MB/s ETA:   0:00:11
Fetching file:  36% ||  22.6MB   3.5MB/s ETA:   0:00:11
Fetching file:  37% ||  23.3MB   3.4MB/s ETA:   0:00:11
Fetching file:  38% |o   |  23.9MB   3.4MB/s ETA:   0:00:11
Fetching file:  39% |o   |  24.5MB   3.4MB/s ETA:   0:00:11
Fetching file:  40% |o   |  25.2MB

Re: After box restart CS 4.5.2 fails to start

[Abhinandan Prateek]

This looks like a user privilege issue. Can you make sure that you are running 
cloudstack with enough privileges (sudo included).

> On 15-Sep-2015, at 8:24 pm, Keerthiraja SJ  wrote:
>
> Hi All,
>
> Today I installed CS 4.5.2 on CentOS 6.7 and able to start the app
> successfully.
>
> All of a sudden the box reboot then while I started the cloudsatck it fails
> to start where I could see a different issue and ERROR on catalina.out
>
> ERROR
> ==
> INFO  [c.c.s.ConfigurationServerImpl] (main:null) Processing
> updateSSLKeyStore
> INFO  [c.c.s.ConfigurationServerImpl] (main:null) SSL keystore located at
> /etc/cloudstack/management/cloudmanagementserver.keystore
> WARN  [c.c.s.ConfigurationServerImpl] (main:null) Would use fail-safe
> keystore to continue.
> java.io.IOException: Fail to create keystore file!
>at
> com.cloud.server.ConfigurationServerImpl.updateSSLKeystore(ConfigurationServerImpl.java:664)
>at
> com.cloud.server.ConfigurationServerImpl.persistDefaultValues(ConfigurationServerImpl.java:304)
>at
> com.cloud.server.ConfigurationServerImpl.configure(ConfigurationServerImpl.java:166)
>at
> org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle$3.with(CloudStackExtendedLifeCycle.java:114)
>at
> org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.with(CloudStackExtendedLifeCycle.java:153)
>at
> org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.configure(CloudStackExtendedLifeCycle.java:110)
>at
> org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:56)
>at
> org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:167)
>at
> org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:51)
>at
> org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:339)
>at
> org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:143)
>at
> org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:108)
>at
> org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:945)
>at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:482)
>at
> org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145)
>at
> org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:122)
>at
> org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:245)
>at
> org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
>at
> org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
>at
> org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:233)
>at
> org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:117)
>at
> org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:79)
>at
> org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
>at
> org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:70)
>at
> org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:57)
>at
> org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:61)
>at
> org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:52)
>at
> org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4210)
>at
> org.apache.catalina.core.StandardContext.start(StandardContext.java:4709)
>at
> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:791)
>at
> org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:771)
>at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:526)
>at
> org.apache.catalina.startup.HostConfig.deployDirectory(HostConfig.java:1041)
>at
> org.apache.catalina.startup.HostConfig.deployDirectories(HostConfig.java:964)
>at
> org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:502)
>at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1277)
>at
> org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:321)
>at
> org.apache.catalina.util.Lifecycl

Re: Recurring snapshot taking full every time

[Abhinandan Prateek]

Can you check in the SMlog on the concerned host if you see any error when the 
plugin is being invoked ?

> On 14-Sep-2015, at 5:01 pm, raja sekhar  wrote:
>
> Hi abhinandan,
>
> Thanks for your reply.
> We are facing the issue only for root volumes in that host. The snapshot
> recurring policy for data disks in same host is working fine.
> if the host configuration is not properly instrumented the policy for data
> disks also fails, but it is working fine.
> please suggest us.
>
> Note: The manual snapshots for root disk is working fine,and it is taking
> child when second manual is configured , problem only with root daily
> snapshots every day it is taking full instead of taking child snapshots
> throwing error "*Failed to get parent snapshot**, due to There was a
> failure communicating with the plugin*".
>
> Regards,
> rajasekhar.
>
> On Mon, Sep 14, 2015 at 4:00 PM, Abhinandan Prateek <
> abhinandan.prat...@shapeblue.com> wrote:
>
>> Looks like the host is not instrumented properly and management server is
>> unable to invoke plugin on the host.
>> Can you force-reconnect the host that is throwing this error ? That should
>> recopy the plugins on to the host.
>>
>>> On 14-Sep-2015, at 3:15 pm, raja sekhar  wrote:
>>>
>>> Hi All,
>>>
>>> I am using CS 4.3.1 and xenserver 6.2
>>> I have configured daily recurring snapshot policy for all the root
>> volumes.
>>> but recent three days onwards it is taking full snapshots and not taking
>>> any child snapshots.
>>> I have configured snapshot.delta.max to 16.
>>> please help me my secondary storage is becoming full.
>>>
>>> The log file details shows:
>>>
>>> 2015-09-14 01:03:29,973 DEBUG [c.c.a.m.DirectAgentAttache]
>>> (DirectAgent-24:ctx-d68622c5) Seq 4-482873005: Response Received:
>>> 2015-09-14 01:03:29,973 DEBUG [c.c.a.m.ClusteredAgentManagerImpl]
>>> (DirectAgent-24:ctx-d68622c5) Seq 4-482873005: MgmtId 195780927071877:
>>> Resp: Routing to peer
>>> 2015-09-14 01:03:32,233 DEBUG [c.c.c.ConsoleProxyManagerImpl]
>>> (consoleproxy-1:ctx-b1db30de) Zone 1 is ready to launch console proxy
>>> 2015-09-14 01:03:32,334 DEBUG [c.c.s.s.SecondaryStorageManagerImpl]
>>> (secstorage-1:ctx-e024d41b) Zone 1 is ready to launch secondary storage
>> VM
>>> 2015-09-14 01:03:33,934 WARN  [c.c.u.n.Link] (AgentManager-Selector:null)
>>> SSL: Fail to find the generated keystore. Loading fail-safe one to
>> continue.
>>> 2015-09-14 01:03:34,044 DEBUG [c.c.a.t.Request]
>>> (AgentManager-Handler-10:null) Seq 1-457572529: Executing:  { Cmd ,
>> MgmtId:
>>> 108371418365724, via: 1, Ver: v1, Flags: 100011,
>>>
>> [{"org.apache.cloudstack.storage.command.CreateObjectCommand":{"data":{"org.apache.cloudstack.storage.to.SnapshotObjectTO":{"volume":{"uuid":"bcf7653a-33db-461a-9355-e5d518012679","volumeType":"ROOT","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"165fb777-4225-326a-bc48-f5b465f9486b","id":1,"poolType":"NetworkFilesystem","host":"172.30.36.51","path":"/vS02304090GCSP_NAS05","port":2049,"url":"NetworkFilesystem://
>>>
>> 172.30.36.51//vS02304090GCSP_NAS05/?ROLE=Primary&STOREUUID=165fb777-4225-326a-bc48-f5b465f9486b
>>>
>> "}},"name":"ROOT-189","size":85899345920,"path":"9deefbf6-86e6-4359-acb3-99e1aebcb359","volumeId":696,"vmName":"i-11-189-VM","accountId":11,"format":"VHD","id":696,"deviceId":0,"hypervisorType":"XenServer"},"parentSnapshotPath":"3a6e9e1a-fd95-4530-ae67-03a368b3e2fd","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"165fb777-4225-326a-bc48-f5b465f9486b","id":1,"poolType":"NetworkFilesystem","host":"172.30.36.51","path":"/vS02304090GCSP_NAS05","port":2049,"url":"NetworkFilesystem://
>>>
>> 172.30.36.51//vS02304090GCSP_NAS05/?ROLE=Primary&STOREUUID=165fb777-4225-326a-bc48-f5b465f9486b
>> "}},"vmName":"i-11-189-VM","name":"SAGXD02_ROOT-189_20150914090333","hypervisorType":"XenServer","id":6732,"quiescevm":false,"parents":["3a6e9e1a-fd95-4530-ae67-03a368b3e2fd"],"physicalSize":0}},"wait":0}}]
>>> }
>>> 2015-09-14 01:03:34,045 DEBUG [c.c.a.m.DirectAgentAttache]
>>> (DirectAgent-333:ctx-c3e7c331) Seq 1-457572529: Executing request
>>> 2015-09-14 01:03:35,421 WARN  [c.c.h.x.r.CitrixResourceBase]
>>> (DirectAgent-333:ctx-c3e7c331) callHostPlugin failed for cmd:
>> getVhdParent
>>> with args snapshotUuid: 3a6e9e1a-fd95-4530-ae67-03a368b3e2fd, isISCSI:
>>> false, primaryStorageSRUuid: a6a7f65a-a1d2-83e3-d3b0-f38792863fb6,  due
>> to
>>> There was a failure communicating with the plugin.
>>> 2015-09-14 01:03:35,421 DEBUG [c.c.h.x.r.XenServerStorageProcessor]
>>> (DirectAgent-333:ctx-c3e7c331) Failed to get parent snapshot
>>> com.cloud.utils.exception.CloudRuntimeException: callHostPlugin failed
>> for
>>> cmd: getVhdParent with args snapshotUuid:
>>> 3a6e9e1a-fd95-4530-ae67-03a368b3e2fd, isISCSI: false,
>> primaryStorageSRUuid:
>>> a6a7f65a-a1d2-83e3-d3b0-f38792863fb6,  due to There was a failure
>>> communicating with the plugin.
>>>   at
>>>
>> com.cloud.hypervisor.xen.resource.CitrixResourceBase.callHos

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

[Jayapal Reddy Uradi]

Hi Wilder,

CLOUDSTACK-8843 This 
ticket is actually NOT regression. It is not implemented/tested for the basic 
zone VR.
What I have observed in the VR refactor is that sanity testing of components 
the code affects is not done.
Now we are spending time on fixing issues which were stable earlier.

Thanks,
Jayapal


On 15-Sep-2015, at 6:55 pm, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>> wrote:

Hi Jayapal,

I would not suggest to move back to the sceptres, but focus on fixing and for 
every fix test it very well so we get confidence. If we start calling scripts 
com the python code it will have a huge chance to become a real mess!

Let’s stick to it and fix it and once it’s stable we can discuss a refactor of 
the thing from scratch - we already have some ideas.

The most important point is: for everyone touching Java/Python code, please 
test your changes before creating PRs or LGTM other’s committers PRs.

Cheers,
Wilder


On 15 Sep 2015, at 14:52, Jayapal Reddy Uradi 
mailto:jayapalreddy.ur...@citrix.com>> wrote:

Wilder, That is true.

All these issues are because of the VR refactoring. I don’t know what are the 
unit test cases run on VR refactor code.
VR (shell) scripts  are stabilized over years and now suddenly moved to new 
implementation. What we have figured out is that this new implementation is 
done only partially. What I am suggesting now to move ahead is to call the 
existing/old shell  scripts in new implementation for configuring the VR to 
avoid spending time on unnecessary bugs.
With current implementation we may see many issues in production for some time 
to come.

Thanks,
Jayapal

On 15-Sep-2015, at 5:57 pm, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>> wrote:

I have the feeling that we are fixing 1 issue and created 2.

Please, make sure the routers tests are executed and green before creating the 
PR. I will do the same.

Cheers,
Wilder


On 15 Sep 2015, at 14:23, Jayapal Reddy Uradi 
mailto:jayapalreddy.ur...@citrix.com>> wrote:

Assigned to myself.

Thanks,
Jayapal
On 15-Sep-2015, at 2:49 pm, Raja Pullela 
mailto:raja.pull...@citrix.com>> wrote:

Hi,

JIRA - ticket https://issues.apache.org/jira/browse/CLOUDSTACK-8843
Can someone please pick up this ticket ?  This is failing a bunch of the BVTs 
tests in Basiczone.

Thanks,
Raja

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/804#issuecomment-140624485
  
I think Daan did not say -1 or :-1: while unit tests are welcome, does not 
hurt to be merciful on one or few line changes if they indeed fix a bug


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/833#issuecomment-140624609
  
Thanks @karuturi LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/833#issuecomment-140624682
  
@karuturi no need to worry on the implications, except for openswan we 
don't have a version reliance of a packages; and for openswan we install a 
specific version


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

[harikrishna-patnala]

Github user harikrishna-patnala commented on the pull request:

https://github.com/apache/cloudstack/pull/833#issuecomment-140624768
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: VPC router issue

[Raja Pullela]

Hi Wilder,   BTW, I just checked my setup and it was passing on Sep 9th and was 
regressed after that.

Thanks for checking this out,
Raja
-Original Message-
From: Wilder Rodrigues [mailto:wrodrig...@schubergphilis.com] 
Sent: Tuesday, September 15, 2015 7:12 PM
To: dev@cloudstack.apache.org
Cc: Remi Bergsma ; Rohit Yadav 
; Rajani Karuturi ; Daan Hoogland 

Subject: Re: VPC router issue

6 days ago test_pc_routers.py succeeded with  PR 788:

https://github.com/apache/cloudstack/pull/788

It’s in the test results I put there.

I’m now testing Master to verify if it’s still occurring there. I tested the PR 
#808 (https://github.com/apache/cloudstack/pull/805), which had a bunch of 
tests executed against, but not the test_vpc_routers, and there it fails.

So, the problem occurred between 788 and 805.

Will keep digging.

Cheers,
Wilder


On 15 Sep 2015, at 14:18, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>> wrote:

Hi all,

This morning I shared a message on our Slack channel about the current issue 
I’m facing with VPC routers. The problem was caught by the test_vpc_routers.py 
tests, which are unable to verify the following:

* Create a VPC with 2 Tiers, 3 VMs, 2Pub IPs, and 1 ACL
* Stop the VPC router
* Start the VPC router

I have been busy trying to figure out when it stopped working when I then 
stopped at commit 
https://github.com/apache/cloudstack/commit/f5e5f4d0026f8ffd6f3aa7e8e4c7be0cd809d6c9
 - although it’s not really the one causing the issue given what I have changed 
there.

The only way to get it working is by restarting the VPC with the cleanup option 
- os destroying the VPC router and just restarting the VPC.

Since not many people have been testing the routers as much as I do, it seems 
no one is aware of this issue.

Long story short: current master is broken.

/me digging through PRs to find the root cause.

Cheers,
Wilder

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/824#discussion_r39593369
  
--- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java 
---
@@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {
 new Upgrade2211to2212(), new Upgrade2212to2213(), new 
Upgrade2213to2214(), new Upgrade2214to30(),
 new Upgrade30to301(), new Upgrade301to302(), new 
Upgrade302to40(), new Upgrade40to41(), new Upgrade410to420(),
 new Upgrade420to421(), new Upgrade421to430(), new 
Upgrade430to440(), new Upgrade440to441(), new Upgrade441to442(),
-new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460()});
+new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to453(), new Upgrade453to460()});
 
 _upgradeMap.put("2.2.1", new DbUpgrade[] {new Upgrade221to222(), 
new UpgradeSnapshot223to224(), new Upgrade222to224(),
 new Upgrade224to225(), new Upgrade225to226(), new 
Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to2213(),
 new Upgrade2213to2214(), new Upgrade2214to30(), new 
Upgrade30to301(), new Upgrade301to302(), new Upgrade302to40(),
 new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(), new Upgrade430to440(),
-new Upgrade440to441(), new Upgrade441to442(), new 
Upgrade442to450(), new Upgrade450to451(), new Upgrade451to452(), new 
Upgrade452to460()});
+new Upgrade440to441(), new Upgrade441to442(), new 
Upgrade442to450(), new Upgrade450to451(), new Upgrade451to452(), new 
Upgrade452to453(), new Upgrade453to460()});
 
 _upgradeMap.put("2.2.2", new DbUpgrade[] {new Upgrade222to224(), 
new UpgradeSnapshot223to224(), new Upgrade224to225(),
 new Upgrade225to226(), new Upgrade227to228(), new 
Upgrade228to229(), new Upgrade229to2210(),
 new Upgrade2210to2211(), new Upgrade2211to2212(), new 
Upgrade2212to2213(), new Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.3", new DbUpgrade[] {new Upgrade222to224(), 
new UpgradeSnapshot223to224(), new Upgrade224to225(),
 new Upgrade225to226(), new Upgrade227to228(), new 
Upgrade228to229(), new Upgrade229to2210(),
 new Upgrade2210to2211(), new Upgrade2211to2212(), new 
Upgrade2212to2213(), new Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.4", new DbUpgrade[] {new Upgrade224to225(), 
new Upgrade225to226(), new Upgrade227to228(),
 new Upgrade228to229(), new Upgrade229to2210(), new 
Upgrade2210to2211(), new Upgrade2211to2212(),
 new Upgrade2212to2213(), new Upgrade2213to2214(), new 
Upgrade2214to30(), new Upgrade30to301(),
 new Upgrade301to302(), new Upgrade302to40(), new 
Upgrade40to41(), new Upgrade410to420(), new Upgrade420to421(),
-new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to460()});
+new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(), new Upgrade452to453(), new 
Upgrade453to460()});
 
 _upgradeMap.put("2.2.5", new DbUpgrade[] {new Upgrade225to226(), 
new Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to22

RE: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

[Raja Pullela]

I agree with jayapal, so far none of the BVTs for the hypervisors are at 100% 
except for the simulator's.   
Also, changes/refactoring some of the very core functionality such as VR should 
be thought through and thoroughly tested before being pushed as the impact will 
be huge and stabilization will take time.  At this point we are not sure what 
else is broken ??? 

Also, we should review/critic such changes to make sure we don't spend time on 
it later on...
Please note that Travis tests passing at 100% cannot be taken as the basis to 
think that the changes are good.  

my 2cents!
Raja
-Original Message-
From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] 
Sent: Wednesday, September 16, 2015 9:46 AM
To: dev@cloudstack.apache.org
Subject: Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not 
opened in VR

Hi Wilder,

CLOUDSTACK-8843 This 
ticket is actually NOT regression. It is not implemented/tested for the basic 
zone VR.
What I have observed in the VR refactor is that sanity testing of components 
the code affects is not done.
Now we are spending time on fixing issues which were stable earlier.

Thanks,
Jayapal


On 15-Sep-2015, at 6:55 pm, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>> wrote:

Hi Jayapal,

I would not suggest to move back to the sceptres, but focus on fixing and for 
every fix test it very well so we get confidence. If we start calling scripts 
com the python code it will have a huge chance to become a real mess!

Let’s stick to it and fix it and once it’s stable we can discuss a refactor of 
the thing from scratch - we already have some ideas.

The most important point is: for everyone touching Java/Python code, please 
test your changes before creating PRs or LGTM other’s committers PRs.

Cheers,
Wilder


On 15 Sep 2015, at 14:52, Jayapal Reddy Uradi 
mailto:jayapalreddy.ur...@citrix.com>> wrote:

Wilder, That is true.

All these issues are because of the VR refactoring. I don’t know what are the 
unit test cases run on VR refactor code.
VR (shell) scripts  are stabilized over years and now suddenly moved to new 
implementation. What we have figured out is that this new implementation is 
done only partially. What I am suggesting now to move ahead is to call the 
existing/old shell  scripts in new implementation for configuring the VR to 
avoid spending time on unnecessary bugs.
With current implementation we may see many issues in production for some time 
to come.

Thanks,
Jayapal

On 15-Sep-2015, at 5:57 pm, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>> wrote:

I have the feeling that we are fixing 1 issue and created 2.

Please, make sure the routers tests are executed and green before creating the 
PR. I will do the same.

Cheers,
Wilder


On 15 Sep 2015, at 14:23, Jayapal Reddy Uradi 
mailto:jayapalreddy.ur...@citrix.com>> wrote:

Assigned to myself.

Thanks,
Jayapal
On 15-Sep-2015, at 2:49 pm, Raja Pullela 
mailto:raja.pull...@citrix.com>> wrote:

Hi,

JIRA - ticket https://issues.apache.org/jira/browse/CLOUDSTACK-8843
Can someone please pick up this ticket ?  This is failing a bunch of the BVTs 
tests in Basiczone.

Thanks,
Raja

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

[Rajani Karuturi]

I agree. Most of the blockers we see now are VR related.

~Rajani



On 16-Sep-2015, at 10:15 am, Raja Pullela  wrote:

> I agree with jayapal, so far none of the BVTs for the hypervisors are at 100% 
> except for the simulator's.   
> Also, changes/refactoring some of the very core functionality such as VR 
> should be thought through and thoroughly tested before being pushed as the 
> impact will be huge and stabilization will take time.  At this point we are 
> not sure what else is broken ??? 
> 
> Also, we should review/critic such changes to make sure we don't spend time 
> on it later on...
> Please note that Travis tests passing at 100% cannot be taken as the basis to 
> think that the changes are good.  
> 
> my 2cents!
> Raja
> -Original Message-
> From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] 
> Sent: Wednesday, September 16, 2015 9:46 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is 
> not opened in VR
> 
> Hi Wilder,
> 
> CLOUDSTACK-8843 This 
> ticket is actually NOT regression. It is not implemented/tested for the basic 
> zone VR.
> What I have observed in the VR refactor is that sanity testing of components 
> the code affects is not done.
> Now we are spending time on fixing issues which were stable earlier.
> 
> Thanks,
> Jayapal
> 
> 
> On 15-Sep-2015, at 6:55 pm, Wilder Rodrigues 
> mailto:wrodrig...@schubergphilis.com>> wrote:
> 
> Hi Jayapal,
> 
> I would not suggest to move back to the sceptres, but focus on fixing and for 
> every fix test it very well so we get confidence. If we start calling scripts 
> com the python code it will have a huge chance to become a real mess!
> 
> Let’s stick to it and fix it and once it’s stable we can discuss a refactor 
> of the thing from scratch - we already have some ideas.
> 
> The most important point is: for everyone touching Java/Python code, please 
> test your changes before creating PRs or LGTM other’s committers PRs.
> 
> Cheers,
> Wilder
> 
> 
> On 15 Sep 2015, at 14:52, Jayapal Reddy Uradi 
> mailto:jayapalreddy.ur...@citrix.com>> wrote:
> 
> Wilder, That is true.
> 
> All these issues are because of the VR refactoring. I don’t know what are the 
> unit test cases run on VR refactor code.
> VR (shell) scripts  are stabilized over years and now suddenly moved to new 
> implementation. What we have figured out is that this new implementation is 
> done only partially. What I am suggesting now to move ahead is to call the 
> existing/old shell  scripts in new implementation for configuring the VR to 
> avoid spending time on unnecessary bugs.
> With current implementation we may see many issues in production for some 
> time to come.
> 
> Thanks,
> Jayapal
> 
> On 15-Sep-2015, at 5:57 pm, Wilder Rodrigues 
> mailto:wrodrig...@schubergphilis.com>> wrote:
> 
> I have the feeling that we are fixing 1 issue and created 2.
> 
> Please, make sure the routers tests are executed and green before creating 
> the PR. I will do the same.
> 
> Cheers,
> Wilder
> 
> 
> On 15 Sep 2015, at 14:23, Jayapal Reddy Uradi 
> mailto:jayapalreddy.ur...@citrix.com>> wrote:
> 
> Assigned to myself.
> 
> Thanks,
> Jayapal
> On 15-Sep-2015, at 2:49 pm, Raja Pullela 
> mailto:raja.pull...@citrix.com>> wrote:
> 
> Hi,
> 
> JIRA - ticket https://issues.apache.org/jira/browse/CLOUDSTACK-8843
> Can someone please pick up this ticket ?  This is failing a bunch of the BVTs 
> tests in Basiczone.
> 
> Thanks,
> Raja
> 
> 
> 
> 
> 

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

[sateesh-chodapuneedi]

Github user sateesh-chodapuneedi commented on the pull request:

https://github.com/apache/cloudstack/pull/806#issuecomment-140627846
  
@sureshanaparti code LGTM.
I will test this patch today in my lab and will get back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/833#issuecomment-140628293
  
Thanks guys. Will merge in sometime. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8866 : restart.retry.interval ...

[maneesha-p]

GitHub user maneesha-p opened a pull request:

https://github.com/apache/cloudstack/pull/834

CLOUDSTACK-8866 : restart.retry.interval is being used instead of 
migrate.retry.interval during host maintenance

The frequency at which Cloudstack tries to migrate the VMs is currently 
controlled by the global parameter "restart.retry.interval" which has a default 
value of 600 seconds or 10 minutes.This has to be changed to use 
"migrate.retry.interval" which by default is 120 seconds or 2 minutes . 
Cloudstack uses restart.retry.interval for all 
operations-migrate,restart,stop,destroy.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maneesha-p/cloudstack CLOUDSTACK-8866

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #834


commit 648df908f398b7054015c3843d4845617a4d8adb
Author: Maneesha.P 
Date:   2015-09-08T05:15:14Z

CLOUDSTACK-8866 : restart.retry.interval is being used instead of 
migrate.retry.interval during host maintenance




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[PROPOSAL] stable master and 4.6 release

[Rajani Karuturi]

Hi all,
There is little progress on 4.6 blockers this week. To release 4.6, we all
should come together and fix the blockers. In recent days, master has
broken multiple times with compilation failures/regressions. If master
breaks, time spent on figuring out what happened and fixing it is time
*not* spent on 4.6.

Here is what we propose:

1. Only BLOCKER fixes to master. If there's something else that needs to
get in, it can be discussed with the RMs on a case-by-case basis.
2. Atleast one of the reviewers of a PR should do the actual tests. We do
not have good CI in place and travis just does simulator tests. Until we
have a real hypervisor CI in place, manually testing the PR is a must.
Also, LGTM(or +1) should be accompanied with whats tested and why you are
giving LGTM.

Let us all work together on getting 4.6 out.

Thanks

Regards from the 4.6 RMs,
Remi and Rajani.



On Thu, Sep 10, 2015 at 2:52 PM, Remi Bergsma 
wrote:

> Hi all,
>
>
> A lot of work is being done to make 4.6 ready for a release. It's great to
> see it's getting better every day!
>
>
> Today Rajani and myself looked at all blocker and critical issues on 4.6.
> We decided to bump some of them to blocker. Two more issues need to
> verified against current master. In case still broken, they will be marked
> blocker as well. This means we'll have 6-8 blocker issues to resolve. Most
> of them are virtual router related and we feel we cannot do a RC without
> properly fixing them.
>
>
> If you have some time, please:
>
>
> Look at the 4.6 release dashboard:
>
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12326765
>
>
> Fix one of the blockers (or critical issues):
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-8697?filter=12332940
>
>
> It also helps if people help reviewing PRs:
>
> https://github.com/apache/cloudstack/pulls
>
>
> Apart from these issues, 4.6 (aka master) is pretty stable. Feel free to
> test-drive it and verify your key functionality.
>
>
> Thanks!
>
>
> Regards from the 4.6 RMs,
>
>
> Rajani / Remi
>
>

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/829#issuecomment-140641376
  
@DaanHoogland this is for just master, or also applies for 4.5; if so 
please send a PR for 4.5 as well. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/806#issuecomment-140641828
  
Alright, let's wait for lab tests to confirm the patch and only then we 
should merge it.

Thanks for helping test it @sateesh-chodapuneedi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---