[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/761#issuecomment-136286725
  
Changes LGTM for 4.4.
@miguelaferreira @remibergsma These can be fixed properly in a future 
release. isVmAlive() can return some enum (like yes, no, unknown) similar to 
isAgentAlive().



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Wido den Hollander


On 08/31/2015 07:59 AM, Mike Tutkowski wrote:
> Hi,
> 
> I'm having a problem migrating a VM from one 12.04 KVM host to another
> 12.04 KVM host in the same cluster in CS 4.6.
> 
> Anyone know why I might be receiving this error message?
> 
> invalid argument: virDomainDefFormat: unsupported flags (0x8)
> 

Hmm, that is probably a flag which is passed down to libvirt by the KVM
Agent. That flag is not supported in the libvirt on 12.04 I guess.

Don't know which flag it is, but I think it's something like that.

Wido

> The root disk is stored on cluster-scoped NFS primary storage.
> 
> Thanks!
> 


Re: [GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

2015-08-31 Thread Daan Hoogland
I agree

On Mon, Aug 31, 2015 at 6:45 AM, kansal  wrote:

> Github user kansal commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/685#issuecomment-136250704
>
> @DaanHoogland Yes the first test in a way does the same thing only.
> The thing is that the second test is more intuitive in a way that it firsts
> registers a key-pair (the registration is successful) and then registers
> another one with different name but same key (Registration fails here). So
> the "Existing pair" check which the first one wants to test is
> automatically tested. In my opinion the first test can be removed. Your
> opinion?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>



-- 
Daan


Build failed in Jenkins: build-master-slowbuild #2191

2015-08-31 Thread jenkins
See 

Changes:

[koushik] Made following fixes in simulator

[miguelferreira] Add vm scalling test that runs on simulator

[Rajani Karuturi] Revert "Merge pull request #714 from 
rafaelweingartner/master-lrg-cs-hackday-003"

--
[...truncated 28153 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.762s]
[INFO] Apache CloudStack . SUCCESS [2.190s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.798s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [21.582s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:16.581s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.111s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [54.266s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.478s]
[INFO] Apache CloudStack API . SUCCESS [2:01.432s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [18.240s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.891s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.094s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.000s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [34.256s]
[INFO] Apache CloudStack Core  SUCCESS [1:31.216s]
[INFO] Apache CloudStack Agents .. SUCCESS [39.315s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.804s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.868s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:20.879s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [43.222s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [26.528s]
[INFO] Apache CloudStack Server .. SUCCESS [4:23.553s]
[INFO] Apache CloudStack Usage Server  SUCCESS [45.380s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[6:11.908s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.155s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [1.050s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [1:13.013s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [1:44.923s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [39.164s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [30.588s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [22.420s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.289s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [33.780s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.469s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [6.932s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.789s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.072s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.994s]
[INFO] Apache CloudStack Plugin - Storage Volume Soli

[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/761#issuecomment-136302213
  
I didn't realise this was a hotfix for 4.4.
I wouldn't want this fix for master, but for a previous release that has a 
critical bug, I can live with it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/761#issuecomment-136302649
  
The rats build failed because some files (mostly travis related) do not 
have license headers.
These files have not been changed in this PR.

```
  .travis.yml
  
engine/schema/src/org/apache/cloudstack/resourcedetail/dao/SnapshotPolicyDetailsDaoImpl.java
  
engine/schema/src/org/apache/cloudstack/resourcedetail/dao/SnapshotPolicyDetailsDao.java
  
engine/schema/src/org/apache/cloudstack/resourcedetail/SnapshotPolicyDetailVO.java
  api/src/org/apache/cloudstack/api/command/admin/iso/CopyIsoCmdByAdmin.java
  debian/source/format
  tools/travis/after_success.sh
  tools/travis/before_install.sh
  tools/travis/install.sh
  tools/travis/script.sh
  tools/travis/after_failure.sh
  tools/travis/before_script.sh
  tools/travis/xunit-reader.py
  tools/travis/after_script.sh
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/751#issuecomment-136305158
  
Code LGTM and travis passes but I do not know what to test and the analysis 
gives a lot of *solved* issues from findbugs which I am sure have nothing to do 
with this PR but make me fail wary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/750#issuecomment-136305163
  
Code LGTM and travis passes but I do not know what to test and the analysis 
gives a lot of new issues fro findbugs which I am sure have nothing to do with 
this PR but make me fail wary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-31 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/751#issuecomment-136306330
  
@DaanHoogland this is just the UI :)
Alright 2LGTM, merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/751


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-31 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/763#issuecomment-136306743
  
Works fine now, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/750


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Rohit Yadav
Hi Mike,

I think it is related to this, the libvirt version is really old that lacks the 
flags:
https://github.com/apache/cloudstack/commit/5d29b63cfa98a15d7734798c5b29a43658d7f112

If VM migration flag (8) is not available, can you check if 
VIR_DOMAIN_XML_SECURE (flag=1) works for you, if so we can change the above fix 
to use 0x1 (or 1) to support KVM/12.04 though I’m not sure if for vm migration 
the xml dump method should be provided 0x1 and not 0x8 
(VIR_DOMAIN_XML_MIGRATABLE).

On 31-Aug-2015, at 11:29 am, Mike Tutkowski  wrote:

Hi,

I'm having a problem migrating a VM from one 12.04 KVM host to another
12.04 KVM host in the same cluster in CS 4.6.

Anyone know why I might be receiving this error message?

invalid argument: virDomainDefFormat: unsupported flags (0x8)

The root disk is stored on cluster-scoped NFS primary storage.

Thanks!

--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.


[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-31 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/763#issuecomment-136309843
  
Thanks @remibergsma. Since this isnt my code, LGTM from me as well(The 
actual PR also has 2 LGTMs). merging now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: simulator-4.5-singlerun #268

2015-08-31 Thread jenkins
See 

--
Started by upstream project "build-4.5-simulator" build number 323
originally caused by:
 Started by upstream project "build-4.5" build number 521
 originally caused by:
  Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on simulator in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git --version # timeout=400
 > /usr/bin/git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016)
at hudson.scm.SCM.checkout(SCM.java:484)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1258)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528)
at hudson.model.Run.execute(Run.java:1759)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)
Caused by: hudson.plugins.git.GitException: Command "/usr/bin/git fetch --tags 
--progress https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: error:  while accessing 
https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs

fatal: HTTP request failed

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
at ..remote call to simulator(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
at hudson.remoting.Channel.call(Channel.java:752)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
at sun.proxy.$Proxy46.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733)
... 11 more
ERROR: Error fetching remote repo 'origin'
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 
'xunit.xml' relative to 
' for the 
testing framework 'JUnit'.  Did you enter a pattern relative to the correct 
directory?  Did you generate the result report(s) for 'JUnit'?
[xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the 
resolved pattern 'xunit.xml'. Configuration error?.
[xUnit] [INFO] - Failing BUILD.
[xUnit] [INFO] -

[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/761#issuecomment-136314787
  
Travis error seems not related. I can force push to see if it works this 
time. At least the Apache pull-analysis build succeeded.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/761#issuecomment-136317069
  
Seems Travis is broken for 4.4 :-s


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/692


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/763


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix findbugs issue: 76, DM_DEFAULT_ENCODI...

2015-08-31 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/764

Fix findbugs issue: 76, DM_DEFAULT_ENCODING, Priority: High

ex.printStacktrace prints to System.err by default. Used it and removed
the printwriter which was causing the findbugs issue.

Also, I do not see a reason to write the stacktrace both to stdout and
stderr. But, keeping it as is for now

This fixes the findbugs issues which is reported as new in 
http://jenkins.buildacloud.org/job/build-master-slowbuild/2191/findbugsResult/new/

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack findbugs-cglib

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/764.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #764


commit 398bbf46de391d95164b5ffec4cd2593dcb6608e
Author: Rajani Karuturi 
Date:   2015-08-31T09:36:16Z

Fix findbugs issue: 76, DM_DEFAULT_ENCODING, Priority: High

ex.printStacktrace prints to System.err by default. Used it and removed
the printwriter which was causing the findbugs issue.

Also, I do not see a reason to write the stacktrace both to stdout and
stderr. But, keeping it as is for now




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/761#issuecomment-136318482
  
It has been partially fixed on 4.6, but still the code can be improved 
since it might return null. Below an snippet of the 4.6 code:

@Override
   public boolean isVmAlive(com.cloud.vm.VirtualMachine vm, Host host) 
throws UnknownVM {
   Status status = isAgentAlive(host);
   if (status == null) {
   throw new UnknownVM();
   }
   return status == Status.Up ? true : null;
   }

As you can see, they now throw an Exception in canse the status is null. 
However, in the return it might return null. In addition, the return type is no 
longer a wrapper class, but a native boolean. Returning null would be very bad.

Could you perhaps make an amalgama of the fix, @remibergsma ? You can then 
push it towards 4.4 and 4.6

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: simulator-4.5-singlerun #269

2015-08-31 Thread jenkins
See 

--
Started by user Daan Hoogland
[EnvInject] - Loading node environment variables.
Building remotely on simulator in workspace 

Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git init 
 >  # 
 > timeout=400
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git --version # timeout=400
 > /usr/bin/git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error cloning remote repo 'origin'
ERROR: Error cloning remote repo 'origin'
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 
'xunit.xml' relative to 
' for the 
testing framework 'JUnit'.  Did you enter a pattern relative to the correct 
directory?  Did you generate the result report(s) for 'JUnit'?
[xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the 
resolved pattern 'xunit.xml'. Configuration error?.
[xUnit] [INFO] - Failing BUILD.
[xUnit] [INFO] - There are errors when processing test results.
[xUnit] [INFO] - Skipping tests recording.
[xUnit] [INFO] - Stop build.


Re: Build failed in Jenkins: build-master-slowbuild #2176

2015-08-31 Thread Rajani Karuturi
The below pr would fix the findbugs issue.
https://github.com/apache/cloudstack/pull/764

~Rajani

On Sun, Aug 30, 2015 at 2:59 PM, Daan Hoogland 
wrote:

> The job is removed after 10 others are run. Look at
> http://jenkins.buildacloud.org/job/build-master-slowbuild
>  and go
> to
> the latest job. The issue is reported under new. It boils down to 'new
> PrintWriter(System.out)' is perceived as dangerous implicit default
> encoding of an unknown character type. This happens in the catch clause.
>
> BTW Why do we need a ThrowableRenderer? We don't render things very
> differently then the default rendering
>
> On Sun, Aug 30, 2015 at 12:10 AM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
> > What I found a little strange in that code, was the try-catch structure.
> As
> > I said, I might not fully understand what the code is supposed to do,
> but I
> > think that the try catch structure is not necessary.
> >
> > About the loops, I found a little weird that start, especially because it
> > gets the cause, then if it is not null, it will limit the next iteration
> of
> > th.getStackTrace(), of the th (cause), not adding the last element. As I
> > said, I do not understand the structure of the “Throwable” that is being
> > received there; maybe that is why I found the loop weird.
> >
> > Sure I can create the PR, but my intention was just to start a
> conversation
> > about it, and not create a PR. I tried to see the find bugs warnings to
> > check if my suggestion would remove them, but the link is not working:
> > http://jenkins.buildacloud.org/job/build-master-slowbuild/2176/
> >
> > On Sat, Aug 29, 2015 at 6:59 PM, Daan Hoogland 
> > wrote:
> >
> > > I don't see anything strange in that code. Or it would be; How do you
> > > propose we test it?
> > > please create a PR. I will LGTM if only to remove the findbugs warning
> we
> > > are having now.
> > >
> > > On Sat, Aug 29, 2015 at 11:05 PM, Rafael Weingärtner <
> > > rafaelweingart...@gmail.com> wrote:
> > >
> > > > Hi folks,
> > > > I took a look in that class “CglibThrowableRenderer”, I do not know
> > much
> > > > about the org.apache.log4j.spi.ThrowableRenderer interface and how is
> > the
> > > > structure of the “Throwable” that its “doRender” receives, but I
> found
> > a
> > > > little odd that code.
> > > >
> > > > I am probably over simplifying things, but here goes my R$ 0.10 cents
> > of
> > > > contribution:
> > > >
> > > > First I did not seem much sense on that try{}catch structure (again I
> > am
> > > > probably over simplifying things), but at first sight I did not see
> any
> > > > possible exceptions that could happen there. Therefore, I removed it.
> > > >
> > > > Second, I extracted some logic to methods, I do not understand
> properly
> > > > those conditionals, and maybe the method names do not represent what
> is
> > > > being evaluated there, but I think that would make it easier to read
> > the
> > > > code.
> > > >
> > > > I also took the liberty and remove the constructor; hence it was
> > merely a
> > > > default constructor.
> > > >
> > > > I think that there is also more room for improvements, that loop
> seems
> > a
> > > > little odd to me. However, to improve it a little bit more I think it
> > > would
> > > > require more time.
> > > >
> > > > You can find the code I changed here:
> > > >
> > > >
> > >
> >
> https://github.com/rafaelweingartner/cloudstack/commit/751d93ac3c5285dab0eb1554527f1d3bc3008283
> > > >
> > > >
> > > >
> > > > What do you guys think?
> > > >
> > > > On Sat, Aug 29, 2015 at 9:55 AM, Daan Hoogland <
> > daan.hoogl...@gmail.com>
> > > > wrote:
> > > >
> > > > > This is due to the re-introduction of CglibThrowableRenderer. It is
> > not
> > > > > really a new finding. I had a look at it and findbugs considders
> 'new
> > > > > PrintWriter(System.err)' a risk. I think this one should be
> ignored.
> > > > >
> > > > > thoughts?
> > > > >
> > > > > On Sat, Aug 29, 2015 at 1:13 PM,  wrote:
> > > > >
> > > > > > See <
> > http://jenkins.buildacloud.org/job/build-master-slowbuild/2176/
> > > >
> > > > > >
> > > > > > --
> > > > > > [...truncated 28153 lines...]
> > > > > > [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @
> > > > > > cloud-quickcloud ---
> > > > > > [INFO] No sources to compile
> > > > > > [INFO]
> > > > > > [INFO] >>> findbugs-maven-plugin:3.0.1:check
> (cloudstack-findbugs)
> > @
> > > > > > cloud-quickcloud >>>
> > > > > > [INFO]
> > > > > > [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @
> > > > > > cloud-quickcloud ---
> > > > > > [INFO]
> > > > > > [INFO] <<< findbugs-maven-plugin:3.0.1:check
> (cloudstack-findbugs)
> > @
> > > > > > cloud-quickcloud <<<
> > > > > > [INFO]
> > > > > > [INFO] --- findbugs-maven-plugin:3.0.1:check
> (cloudstack-findbugs)
> > @
> > > > > > cloud-quickcloud ---
> > > > > > [INFO]
> > > > > > [INFO] --- cob

Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Nux!
Hi,

Has anyone seen this before and can translate to English? The logs don't say 
much, it's obviously SSL related somehow.

The agent says:

java.io.IOException: SSL: Fail to init SSL! java.io.IOException: Connection 
closed with -1 on reading size.
at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
at java.lang.Thread.run(Thread.java:745)
2015-08-31 10:27:56,315 INFO  [utils.nio.NioClient] (Agent-Selector:null) 
Connecting to 192.168.168.2:8250

2015-08-31 10:28:06,333 ERROR [utils.nio.NioConnection] (Agent-Selector:null) 
Unable to initialize the threads.
java.io.IOException: SSL: Fail to init SSL! java.io.IOException: Connection 
closed with -1 on reading size.
at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
at java.lang.Thread.run(Thread.java:745)

openssl s_client -connect 192.168.168.2:8250 just hangs with 
"CONNECTED(0003)"


This happened after a java openjdk (1.6.0 and 1.7.0) and httpd updates from 
CentOs6.

Obviously the hypervisors are in disconnected state and no VM operation is 
possible etc.

Thoughts?


--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-08-31 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/761#issuecomment-136321979
  
Just discussed with @remibergsma and went over the old (4.4) code, the 
change made by @rajesh-battala  - which broke the behaviour - and how 4.6 now 
is. The change LGTM concerning the hotfix on 4.4.

In terms of future proof fix, would be nice to have a massive tests on all 
the investigators and get rid of those things returning null instead of a 
boolean.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8762: Check to confirm disk ac...

2015-08-31 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/754#issuecomment-136322596
  
Yes, I'm still getting the same error.

It could very well be an environment issue.
ping @wilderrodrigues @remibergsma can you guys give it a try?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/689#issuecomment-136322597
  
Changes included from the PR, branch rebased from latest master.

Please help review - @karuturi @jburwell @DaanHoogland @remibergsma 
@kishankavala and others


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Nux!
A downgrade of both java-1.6.0-openjdk and java-1.7.0-openjdk followed by a 
reboot of the management server seems to have fixed it, but it's not a solution 
I like very much.

Anyone has any clues as to what causes that error?

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Nux!" 
> To: "dev" 
> Sent: Monday, 31 August, 2015 10:58:16
> Subject: Hypervisors disconnected - java.io.IOException Fail to init SSL 
> java.io.IOException: Connection closed with -1
> on reading size

> Hi,
> 
> Has anyone seen this before and can translate to English? The logs don't say
> much, it's obviously SSL related somehow.
> 
> The agent says:
> 
> java.io.IOException: SSL: Fail to init SSL! java.io.IOException: Connection
> closed with -1 on reading size.
>   at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
>   at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
>   at java.lang.Thread.run(Thread.java:745)
> 2015-08-31 10:27:56,315 INFO  [utils.nio.NioClient] (Agent-Selector:null)
> Connecting to 192.168.168.2:8250
> 
> 2015-08-31 10:28:06,333 ERROR [utils.nio.NioConnection] (Agent-Selector:null)
> Unable to initialize the threads.
> java.io.IOException: SSL: Fail to init SSL! java.io.IOException: Connection
> closed with -1 on reading size.
>   at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
>   at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
>   at java.lang.Thread.run(Thread.java:745)
> 
> openssl s_client -connect 192.168.168.2:8250 just hangs with
> "CONNECTED(0003)"
> 
> 
> This happened after a java openjdk (1.6.0 and 1.7.0) and httpd updates from
> CentOs6.
> 
> Obviously the hypervisors are in disconnected state and no VM operation is
> possible etc.
> 
> Thoughts?
> 
> 
> --
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro


Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Rajani Karuturi
Hi Lucian,
Can you share the point release numbers of java before and after the
upgrade? (May be that would help us find the issue.)

~Rajani

On Mon, Aug 31, 2015 at 3:42 PM, Nux!  wrote:

> A downgrade of both java-1.6.0-openjdk and java-1.7.0-openjdk followed by
> a reboot of the management server seems to have fixed it, but it's not a
> solution I like very much.
>
> Anyone has any clues as to what causes that error?
>
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
> - Original Message -
> > From: "Nux!" 
> > To: "dev" 
> > Sent: Monday, 31 August, 2015 10:58:16
> > Subject: Hypervisors disconnected - java.io.IOException Fail to init SSL
> java.io.IOException: Connection closed with -1
> > on reading size
>
> > Hi,
> >
> > Has anyone seen this before and can translate to English? The logs don't
> say
> > much, it's obviously SSL related somehow.
> >
> > The agent says:
> >
> > java.io.IOException: SSL: Fail to init SSL! java.io.IOException:
> Connection
> > closed with -1 on reading size.
> >   at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
> >   at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
> >   at java.lang.Thread.run(Thread.java:745)
> > 2015-08-31 10:27:56,315 INFO  [utils.nio.NioClient] (Agent-Selector:null)
> > Connecting to 192.168.168.2:8250
> >
> > 2015-08-31 10:28:06,333 ERROR [utils.nio.NioConnection]
> (Agent-Selector:null)
> > Unable to initialize the threads.
> > java.io.IOException: SSL: Fail to init SSL! java.io.IOException:
> Connection
> > closed with -1 on reading size.
> >   at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
> >   at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
> >   at java.lang.Thread.run(Thread.java:745)
> >
> > openssl s_client -connect 192.168.168.2:8250 just hangs with
> > "CONNECTED(0003)"
> >
> >
> > This happened after a java openjdk (1.6.0 and 1.7.0) and httpd updates
> from
> > CentOs6.
> >
> > Obviously the hypervisors are in disconnected state and no VM operation
> is
> > possible etc.
> >
> > Thoughts?
> >
> >
> > --
> > Sent from the Delta quadrant using Borg technology!
> >
> > Nux!
> > www.nux.ro
>


[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread jburwell
Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/689#issuecomment-136326260
  
I will re-review later today (31 August 2015).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/689#issuecomment-136326696
  
@bhaisaab lot of code :) .. I will review tomorrow.
Can you review 755 if possible? ;) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Nux!
Rajani,

Sure:

Downgrade  java-1.6.0-openjdk-1:1.6.0.35-1.13.7.1.el6_6.x86_64  @base
Downgraded1:1.6.0.36-1.13.8.1.el6_7.x86_64  @updates
Downgrade  java-1.7.0-openjdk-1:1.7.0.85-2.6.1.3.el6_6.x86_64   @updates
Downgraded1:1.7.0.85-2.6.1.3.el6_7.x86_64   @updates
Downgrade  java-1.7.0-openjdk-devel-1:1.7.0.85-2.6.1.3.el6_6.x86_64 @updates
Downgraded  1:1.7.0.85-2.6.1.3.el6_7.x86_64 @updates

The differences seem trivial and there's always the risk it may not have been 
the java change at all doing this, but I do not know what else could have 
triggered it.

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Rajani Karuturi" 
> To: dev@cloudstack.apache.org
> Sent: Monday, 31 August, 2015 11:21:45
> Subject: Re: Hypervisors disconnected - java.io.IOException Fail to init SSL 
> java.io.IOException: Connection closed with
> -1 on reading size

> Hi Lucian,
> Can you share the point release numbers of java before and after the
> upgrade? (May be that would help us find the issue.)
> 
> ~Rajani
> 
> On Mon, Aug 31, 2015 at 3:42 PM, Nux!  wrote:
> 
>> A downgrade of both java-1.6.0-openjdk and java-1.7.0-openjdk followed by
>> a reboot of the management server seems to have fixed it, but it's not a
>> solution I like very much.
>>
>> Anyone has any clues as to what causes that error?
>>
>> Lucian
>>
>> --
>> Sent from the Delta quadrant using Borg technology!
>>
>> Nux!
>> www.nux.ro
>>
>> - Original Message -
>> > From: "Nux!" 
>> > To: "dev" 
>> > Sent: Monday, 31 August, 2015 10:58:16
>> > Subject: Hypervisors disconnected - java.io.IOException Fail to init SSL
>> java.io.IOException: Connection closed with -1
>> > on reading size
>>
>> > Hi,
>> >
>> > Has anyone seen this before and can translate to English? The logs don't
>> say
>> > much, it's obviously SSL related somehow.
>> >
>> > The agent says:
>> >
>> > java.io.IOException: SSL: Fail to init SSL! java.io.IOException:
>> Connection
>> > closed with -1 on reading size.
>> >   at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
>> >   at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
>> >   at java.lang.Thread.run(Thread.java:745)
>> > 2015-08-31 10:27:56,315 INFO  [utils.nio.NioClient] (Agent-Selector:null)
>> > Connecting to 192.168.168.2:8250
>> >
>> > 2015-08-31 10:28:06,333 ERROR [utils.nio.NioConnection]
>> (Agent-Selector:null)
>> > Unable to initialize the threads.
>> > java.io.IOException: SSL: Fail to init SSL! java.io.IOException:
>> Connection
>> > closed with -1 on reading size.
>> >   at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
>> >   at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
>> >   at java.lang.Thread.run(Thread.java:745)
>> >
>> > openssl s_client -connect 192.168.168.2:8250 just hangs with
>> > "CONNECTED(0003)"
>> >
>> >
>> > This happened after a java openjdk (1.6.0 and 1.7.0) and httpd updates
>> from
>> > CentOs6.
>> >
>> > Obviously the hypervisors are in disconnected state and no VM operation
>> is
>> > possible etc.
>> >
>> > Thoughts?
>> >
>> >
>> > --
>> > Sent from the Delta quadrant using Borg technology!
>> >
>> > Nux!
>> > www.nux.ro


[GitHub] cloudstack pull request: Fix findbugs issue: 76, DM_DEFAULT_ENCODI...

2015-08-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/764#issuecomment-136332126
  
@karuturi please have a look at 
https://github.com/apache/cloudstack/pull/762/files Your solution will work but 
I like the other one as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38301615
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import javax.inject.Inject;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.AccountService;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import com.cloud.user.Account;
+
+import java.util.UUID;
+
+@APICommand(name = "linkDomainToLdap", description = "link an existing 
cloudstack domain to group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.6.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkDomainToLdapCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(LinkDomainToLdapCmd.class.getName());
+private static final String s_name = "linkdomaintoldapresponse";
+
+@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class, description = "The id of the domain which 
has to be linked to LDAP.")
--- End diff --

Shouldn't this be mandatory?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Build failed in Jenkins: build-master-slowbuild #2176

2015-08-31 Thread Rajani Karuturi
sorry. I didnt see that. Will review 762 and close 764.

~Rajani



On 31-Aug-2015, at 4:21 pm, Daan Hoogland  wrote:

> https://github.com/apache/cloudstack/pull/762 by Rafael, did as well. Let's
> have a run-off ;)
> 
> On Mon, Aug 31, 2015 at 11:56 AM, Rajani Karuturi  wrote:
> 
>> The below pr would fix the findbugs issue.
>> https://github.com/apache/cloudstack/pull/764
>> 
>> ~Rajani
>> 
>> On Sun, Aug 30, 2015 at 2:59 PM, Daan Hoogland 
>> wrote:
>> 
>>> The job is removed after 10 others are run. Look at
>>> http://jenkins.buildacloud.org/job/build-master-slowbuild
>>>  and go
>>> to
>>> the latest job. The issue is reported under new. It boils down to 'new
>>> PrintWriter(System.out)' is perceived as dangerous implicit default
>>> encoding of an unknown character type. This happens in the catch clause.
>>> 
>>> BTW Why do we need a ThrowableRenderer? We don't render things very
>>> differently then the default rendering
>>> 
>>> On Sun, Aug 30, 2015 at 12:10 AM, Rafael Weingärtner <
>>> rafaelweingart...@gmail.com> wrote:
>>> 
 What I found a little strange in that code, was the try-catch
>> structure.
>>> As
 I said, I might not fully understand what the code is supposed to do,
>>> but I
 think that the try catch structure is not necessary.
 
 About the loops, I found a little weird that start, especially because
>> it
 gets the cause, then if it is not null, it will limit the next
>> iteration
>>> of
 th.getStackTrace(), of the th (cause), not adding the last element. As
>> I
 said, I do not understand the structure of the “Throwable” that is
>> being
 received there; maybe that is why I found the loop weird.
 
 Sure I can create the PR, but my intention was just to start a
>>> conversation
 about it, and not create a PR. I tried to see the find bugs warnings to
 check if my suggestion would remove them, but the link is not working:
 http://jenkins.buildacloud.org/job/build-master-slowbuild/2176/
 
 On Sat, Aug 29, 2015 at 6:59 PM, Daan Hoogland <
>> daan.hoogl...@gmail.com>
 wrote:
 
> I don't see anything strange in that code. Or it would be; How do you
> propose we test it?
> please create a PR. I will LGTM if only to remove the findbugs
>> warning
>>> we
> are having now.
> 
> On Sat, Aug 29, 2015 at 11:05 PM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
> 
>> Hi folks,
>> I took a look in that class “CglibThrowableRenderer”, I do not know
 much
>> about the org.apache.log4j.spi.ThrowableRenderer interface and how
>> is
 the
>> structure of the “Throwable” that its “doRender” receives, but I
>>> found
 a
>> little odd that code.
>> 
>> I am probably over simplifying things, but here goes my R$ 0.10
>> cents
 of
>> contribution:
>> 
>> First I did not seem much sense on that try{}catch structure
>> (again I
 am
>> probably over simplifying things), but at first sight I did not see
>>> any
>> possible exceptions that could happen there. Therefore, I removed
>> it.
>> 
>> Second, I extracted some logic to methods, I do not understand
>>> properly
>> those conditionals, and maybe the method names do not represent
>> what
>>> is
>> being evaluated there, but I think that would make it easier to
>> read
 the
>> code.
>> 
>> I also took the liberty and remove the constructor; hence it was
 merely a
>> default constructor.
>> 
>> I think that there is also more room for improvements, that loop
>>> seems
 a
>> little odd to me. However, to improve it a little bit more I think
>> it
> would
>> require more time.
>> 
>> You can find the code I changed here:
>> 
>> 
> 
 
>>> 
>> https://github.com/rafaelweingartner/cloudstack/commit/751d93ac3c5285dab0eb1554527f1d3bc3008283
>> 
>> 
>> 
>> What do you guys think?
>> 
>> On Sat, Aug 29, 2015 at 9:55 AM, Daan Hoogland <
 daan.hoogl...@gmail.com>
>> wrote:
>> 
>>> This is due to the re-introduction of CglibThrowableRenderer. It
>> is
 not
>>> really a new finding. I had a look at it and findbugs considders
>>> 'new
>>> PrintWriter(System.err)' a risk. I think this one should be
>>> ignored.
>>> 
>>> thoughts?
>>> 
>>> On Sat, Aug 29, 2015 at 1:13 PM,  wrote:
>>> 
 See <
 http://jenkins.buildacloud.org/job/build-master-slowbuild/2176/
>> 
 
 --
 [...truncated 28153 lines...]
 [INFO] --- maven-compiler-plugin:3.2:compile (default-compile)
>> @
 cloud-quickcloud ---
 [INFO] No sources to compile
 [INFO]
 [INFO] >>> findbugs-maven-plugin:3.0.1:check
>>> (cloudstack-findbugs)
 @
 cloud-quickcloud >>>
 [INFO]
 [INFO

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38301757
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import javax.inject.Inject;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.AccountService;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import com.cloud.user.Account;
+
+import java.util.UUID;
+
+@APICommand(name = "linkDomainToLdap", description = "link an existing 
cloudstack domain to group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.6.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkDomainToLdapCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(LinkDomainToLdapCmd.class.getName());
+private static final String s_name = "linkdomaintoldapresponse";
+
+@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class, description = "The id of the domain which 
has to be linked to LDAP.")
+private Long domainId;
+
+@Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, 
required = true, description = "type of the ldap name. GROUP or OU")
+private String type;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+private String name;
+
+@Parameter(name = ApiConstants.ADMIN, type = CommandType.STRING, 
required = false, description = "domain admin username in LDAP ")
+private String admin;
+
+@Parameter(name = ApiConstants.ACCOUNT_TYPE, type = CommandType.SHORT, 
required = true, description = "Type of the account to auto import. Specify 0 
for user, 1 for root " +
+"admin, and 2 for domain admin")
+private short accountType;
+
+@Inject
+private LdapManager _ldapManager;
+
+@Inject
+public AccountService _accountService;
+
+@Override
+public void execute() throws ServerApiException {
+try {
+LinkDomainToLdapResponse response = 
_ldapManager.linkDomainToLdap(domainId, type, name, accountType);
--- End diff --

linkDomainToAdmin() and createUserAccount() involves DB updates. Shouldn't 
it be in a tx? What if the first call succeeds and the second call fails?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Rajani Karuturi
If I am reading it right, java 1.7 has no version change and 1.6 is changed
from 1.6.0.35 to 16.0.36 which caused the failure

Interestingly, I do not see release notes for 1.6.0_36
http://www.oracle.com/technetwork/java/javase/releasenotes-136954.html

~Rajani

On Mon, Aug 31, 2015 at 4:09 PM, Nux!  wrote:

> Rajani,
>
> Sure:
>
> Downgrade  java-1.6.0-openjdk-1:1.6.0.35-1.13.7.1.el6_6.x86_64  @base
> Downgraded1:1.6.0.36-1.13.8.1.el6_7.x86_64
> @updates
> Downgrade  java-1.7.0-openjdk-1:1.7.0.85-2.6.1.3.el6_6.x86_64
>  @updates
> Downgraded1:1.7.0.85-2.6.1.3.el6_7.x86_64
>  @updates
> Downgrade  java-1.7.0-openjdk-devel-1:1.7.0.85-2.6.1.3.el6_6.x86_64
> @updates
> Downgraded  1:1.7.0.85-2.6.1.3.el6_7.x86_64
> @updates
>
> The differences seem trivial and there's always the risk it may not have
> been the java change at all doing this, but I do not know what else could
> have triggered it.
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
> - Original Message -
> > From: "Rajani Karuturi" 
> > To: dev@cloudstack.apache.org
> > Sent: Monday, 31 August, 2015 11:21:45
> > Subject: Re: Hypervisors disconnected - java.io.IOException Fail to init
> SSL java.io.IOException: Connection closed with
> > -1 on reading size
>
> > Hi Lucian,
> > Can you share the point release numbers of java before and after the
> > upgrade? (May be that would help us find the issue.)
> >
> > ~Rajani
> >
> > On Mon, Aug 31, 2015 at 3:42 PM, Nux!  wrote:
> >
> >> A downgrade of both java-1.6.0-openjdk and java-1.7.0-openjdk followed
> by
> >> a reboot of the management server seems to have fixed it, but it's not a
> >> solution I like very much.
> >>
> >> Anyone has any clues as to what causes that error?
> >>
> >> Lucian
> >>
> >> --
> >> Sent from the Delta quadrant using Borg technology!
> >>
> >> Nux!
> >> www.nux.ro
> >>
> >> - Original Message -
> >> > From: "Nux!" 
> >> > To: "dev" 
> >> > Sent: Monday, 31 August, 2015 10:58:16
> >> > Subject: Hypervisors disconnected - java.io.IOException Fail to init
> SSL
> >> java.io.IOException: Connection closed with -1
> >> > on reading size
> >>
> >> > Hi,
> >> >
> >> > Has anyone seen this before and can translate to English? The logs
> don't
> >> say
> >> > much, it's obviously SSL related somehow.
> >> >
> >> > The agent says:
> >> >
> >> > java.io.IOException: SSL: Fail to init SSL! java.io.IOException:
> >> Connection
> >> > closed with -1 on reading size.
> >> >   at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
> >> >   at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
> >> >   at java.lang.Thread.run(Thread.java:745)
> >> > 2015-08-31 10:27:56,315 INFO  [utils.nio.NioClient]
> (Agent-Selector:null)
> >> > Connecting to 192.168.168.2:8250
> >> >
> >> > 2015-08-31 10:28:06,333 ERROR [utils.nio.NioConnection]
> >> (Agent-Selector:null)
> >> > Unable to initialize the threads.
> >> > java.io.IOException: SSL: Fail to init SSL! java.io.IOException:
> >> Connection
> >> > closed with -1 on reading size.
> >> >   at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
> >> >   at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
> >> >   at java.lang.Thread.run(Thread.java:745)
> >> >
> >> > openssl s_client -connect 192.168.168.2:8250 just hangs with
> >> > "CONNECTED(0003)"
> >> >
> >> >
> >> > This happened after a java openjdk (1.6.0 and 1.7.0) and httpd updates
> >> from
> >> > CentOs6.
> >> >
> >> > Obviously the hypervisors are in disconnected state and no VM
> operation
> >> is
> >> > possible etc.
> >> >
> >> > Thoughts?
> >> >
> >> >
> >> > --
> >> > Sent from the Delta quadrant using Borg technology!
> >> >
> >> > Nux!
> >> > www.nux.ro
>


[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/689#issuecomment-136335429
  
7.5kloc would justify 15klotc (kilo-lines of test code) I am not very 
worried about the quality of this code or the zeal of some bluely shaped 
programmers to maintain it but it will have to be maintainable by others! over 
10 lines of code is an hazard to review if there is not twice as much test-code 
there, give or take.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38302004
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import javax.inject.Inject;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.AccountService;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import com.cloud.user.Account;
+
+import java.util.UUID;
+
+@APICommand(name = "linkDomainToLdap", description = "link an existing 
cloudstack domain to group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.6.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkDomainToLdapCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(LinkDomainToLdapCmd.class.getName());
+private static final String s_name = "linkdomaintoldapresponse";
+
+@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class, description = "The id of the domain which 
has to be linked to LDAP.")
+private Long domainId;
+
+@Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, 
required = true, description = "type of the ldap name. GROUP or OU")
+private String type;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+private String name;
+
+@Parameter(name = ApiConstants.ADMIN, type = CommandType.STRING, 
required = false, description = "domain admin username in LDAP ")
+private String admin;
+
+@Parameter(name = ApiConstants.ACCOUNT_TYPE, type = CommandType.SHORT, 
required = true, description = "Type of the account to auto import. Specify 0 
for user, 1 for root " +
+"admin, and 2 for domain admin")
+private short accountType;
+
+@Inject
+private LdapManager _ldapManager;
+
+@Inject
+public AccountService _accountService;
+
+@Override
+public void execute() throws ServerApiException {
+try {
+LinkDomainToLdapResponse response = 
_ldapManager.linkDomainToLdap(domainId, type, name, accountType);
+if(admin!=null) {
+try {
+LdapUser ldapUser = _ldapManager.getUser(admin, type, 
name);
+if(!ldapUser.isDisabled()) {
--- End diff --

If the LDAP user is disabled after creation of CS user account, how will 
the account be removed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38302129
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import javax.inject.Inject;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.AccountService;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import com.cloud.user.Account;
+
+import java.util.UUID;
+
+@APICommand(name = "linkDomainToLdap", description = "link an existing 
cloudstack domain to group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.6.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkDomainToLdapCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(LinkDomainToLdapCmd.class.getName());
+private static final String s_name = "linkdomaintoldapresponse";
+
+@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class, description = "The id of the domain which 
has to be linked to LDAP.")
+private Long domainId;
+
+@Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, 
required = true, description = "type of the ldap name. GROUP or OU")
+private String type;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+private String name;
+
+@Parameter(name = ApiConstants.ADMIN, type = CommandType.STRING, 
required = false, description = "domain admin username in LDAP ")
+private String admin;
+
+@Parameter(name = ApiConstants.ACCOUNT_TYPE, type = CommandType.SHORT, 
required = true, description = "Type of the account to auto import. Specify 0 
for user, 1 for root " +
+"admin, and 2 for domain admin")
+private short accountType;
+
+@Inject
+private LdapManager _ldapManager;
+
+@Inject
+public AccountService _accountService;
--- End diff --

BaseCmd already has AccountService. Why another one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Nux!
Rajani,

Yes, you read right.
The rpm changelog shows:
 Tue Jul 28 2015 Andrew Hughes  - 1:1.6.0.36-1.13.8.1
- Update tarball to fix TCK regression (PR2565)
- Resolves: rhbz#1235150

* Wed Jul 22 2015 Andrew Hughes  - 1:1.6.0.36-1.13.8.0
- Update to IcedTea 1.13.8
- Update no_pr2125.patch to work against new version.
- Resolves: rhbz#1235150

Nothing dramatic, though I do not have permission to read those bugzilla 
entries.

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Rajani Karuturi" 
> To: dev@cloudstack.apache.org
> Sent: Monday, 31 August, 2015 11:59:04
> Subject: Re: Hypervisors disconnected - java.io.IOException Fail to init SSL 
> java.io.IOException: Connection closed with
> -1 on reading size

> If I am reading it right, java 1.7 has no version change and 1.6 is changed
> from 1.6.0.35 to 16.0.36 which caused the failure
> 
> Interestingly, I do not see release notes for 1.6.0_36
> http://www.oracle.com/technetwork/java/javase/releasenotes-136954.html
> 
> ~Rajani
> 
> On Mon, Aug 31, 2015 at 4:09 PM, Nux!  wrote:
> 
>> Rajani,
>>
>> Sure:
>>
>> Downgrade  java-1.6.0-openjdk-1:1.6.0.35-1.13.7.1.el6_6.x86_64  @base
>> Downgraded1:1.6.0.36-1.13.8.1.el6_7.x86_64
>> @updates
>> Downgrade  java-1.7.0-openjdk-1:1.7.0.85-2.6.1.3.el6_6.x86_64
>>  @updates
>> Downgraded1:1.7.0.85-2.6.1.3.el6_7.x86_64
>>  @updates
>> Downgrade  java-1.7.0-openjdk-devel-1:1.7.0.85-2.6.1.3.el6_6.x86_64
>> @updates
>> Downgraded  1:1.7.0.85-2.6.1.3.el6_7.x86_64
>> @updates
>>
>> The differences seem trivial and there's always the risk it may not have
>> been the java change at all doing this, but I do not know what else could
>> have triggered it.
>>
>> --
>> Sent from the Delta quadrant using Borg technology!
>>
>> Nux!
>> www.nux.ro
>>
>> - Original Message -
>> > From: "Rajani Karuturi" 
>> > To: dev@cloudstack.apache.org
>> > Sent: Monday, 31 August, 2015 11:21:45
>> > Subject: Re: Hypervisors disconnected - java.io.IOException Fail to init
>> SSL java.io.IOException: Connection closed with
>> > -1 on reading size
>>
>> > Hi Lucian,
>> > Can you share the point release numbers of java before and after the
>> > upgrade? (May be that would help us find the issue.)
>> >
>> > ~Rajani
>> >
>> > On Mon, Aug 31, 2015 at 3:42 PM, Nux!  wrote:
>> >
>> >> A downgrade of both java-1.6.0-openjdk and java-1.7.0-openjdk followed
>> by
>> >> a reboot of the management server seems to have fixed it, but it's not a
>> >> solution I like very much.
>> >>
>> >> Anyone has any clues as to what causes that error?
>> >>
>> >> Lucian
>> >>
>> >> --
>> >> Sent from the Delta quadrant using Borg technology!
>> >>
>> >> Nux!
>> >> www.nux.ro
>> >>
>> >> - Original Message -
>> >> > From: "Nux!" 
>> >> > To: "dev" 
>> >> > Sent: Monday, 31 August, 2015 10:58:16
>> >> > Subject: Hypervisors disconnected - java.io.IOException Fail to init
>> SSL
>> >> java.io.IOException: Connection closed with -1
>> >> > on reading size
>> >>
>> >> > Hi,
>> >> >
>> >> > Has anyone seen this before and can translate to English? The logs
>> don't
>> >> say
>> >> > much, it's obviously SSL related somehow.
>> >> >
>> >> > The agent says:
>> >> >
>> >> > java.io.IOException: SSL: Fail to init SSL! java.io.IOException:
>> >> Connection
>> >> > closed with -1 on reading size.
>> >> >   at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
>> >> >   at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
>> >> >   at java.lang.Thread.run(Thread.java:745)
>> >> > 2015-08-31 10:27:56,315 INFO  [utils.nio.NioClient]
>> (Agent-Selector:null)
>> >> > Connecting to 192.168.168.2:8250
>> >> >
>> >> > 2015-08-31 10:28:06,333 ERROR [utils.nio.NioConnection]
>> >> (Agent-Selector:null)
>> >> > Unable to initialize the threads.
>> >> > java.io.IOException: SSL: Fail to init SSL! java.io.IOException:
>> >> Connection
>> >> > closed with -1 on reading size.
>> >> >   at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
>> >> >   at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
>> >> >   at java.lang.Thread.run(Thread.java:745)
>> >> >
>> >> > openssl s_client -connect 192.168.168.2:8250 just hangs with
>> >> > "CONNECTED(0003)"
>> >> >
>> >> >
>> >> > This happened after a java openjdk (1.6.0 and 1.7.0) and httpd updates
>> >> from
>> >> > CentOs6.
>> >> >
>> >> > Obviously the hypervisors are in disconnected state and no VM
>> operation
>> >> is
>> >> > possible etc.
>> >> >
>> >> > Thoughts?
>> >> >
>> >> >
>> >> > --
>> >> > Sent from the Delta quadrant using Borg technology!
>> >> >
>> >> > Nux!
>> >> > www.nux.ro


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38302765
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import javax.inject.Inject;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.AccountService;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import com.cloud.user.Account;
+
+import java.util.UUID;
+
+@APICommand(name = "linkDomainToLdap", description = "link an existing 
cloudstack domain to group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.6.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkDomainToLdapCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(LinkDomainToLdapCmd.class.getName());
+private static final String s_name = "linkdomaintoldapresponse";
+
+@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class, description = "The id of the domain which 
has to be linked to LDAP.")
+private Long domainId;
+
+@Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, 
required = true, description = "type of the ldap name. GROUP or OU")
+private String type;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+private String name;
+
+@Parameter(name = ApiConstants.ADMIN, type = CommandType.STRING, 
required = false, description = "domain admin username in LDAP ")
+private String admin;
+
+@Parameter(name = ApiConstants.ACCOUNT_TYPE, type = CommandType.SHORT, 
required = true, description = "Type of the account to auto import. Specify 0 
for user, 1 for root " +
+"admin, and 2 for domain admin")
+private short accountType;
+
+@Inject
+private LdapManager _ldapManager;
+
+@Inject
+public AccountService _accountService;
+
+@Override
+public void execute() throws ServerApiException {
+try {
+LinkDomainToLdapResponse response = 
_ldapManager.linkDomainToLdap(domainId, type, name, accountType);
+if(admin!=null) {
+try {
+LdapUser ldapUser = _ldapManager.getUser(admin, type, 
name);
+if(!ldapUser.isDisabled()) {
+Account account = 
_accountService.getActiveAccountByName(admin, domainId);
+if (account == null) {
+UserAccount userAccount =
+_accountService.createUserAccount(admin, 
"", ldapUser.getFirstname(), ldapUser.getLastname(), ldapUser.getEmail(), null, 
admin, Account.ACCOUNT_TYPE_DOMAIN_ADMIN, domainId, admin, null, 
UUID.randomUUID().toString(),
+  
UUID.randomUUID().toString(), User.Source.LDAP);
--- End diff --

1. Why is password empty? Shouldn't it be taken as input?
2. What happens if createUserAccount() fail

Build failed in Jenkins: build-master-slowbuild #2192

2015-08-31 Thread jenkins
See 

Changes:

[Rohit Yadav] CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal 
iso/template listing

[Rajani Karuturi] CLOUDSTACK-8725 RVR functionality is broken in case of 
isolated networks, conntrackd fails to start.

--
[...truncated 28153 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.906s]
[INFO] Apache CloudStack . SUCCESS [2.194s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.944s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [21.551s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:17.560s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.108s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [55.402s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [26.359s]
[INFO] Apache CloudStack API . SUCCESS [1:49.928s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.504s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.374s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.125s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [30.030s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [32.382s]
[INFO] Apache CloudStack Core  SUCCESS [1:29.204s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.530s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.539s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.825s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:16.435s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [44.131s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.229s]
[INFO] Apache CloudStack Server .. SUCCESS [4:20.615s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.459s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[6:16.661s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.152s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.696s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [1:09.899s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [1:46.343s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [39.728s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [28.158s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [31.529s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.281s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [34.196s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.015s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [5.766s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.804s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.236s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.001s]
[INFO] Apache CloudStack Plugin - Storage V

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38303216
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
 ---
@@ -39,6 +39,9 @@
 private static final ConfigKey ldapProvider = new 
ConfigKey(String.class, "ldap.provider", "Advanced", "openldap", "ldap 
provider ex:openldap, microsoftad",

 true, ConfigKey.Scope.Global, null);
 
+private static final ConfigKey ldapEnableNestedGroups = new 
ConfigKey(Boolean.class, "ldap.nested.groups.enable", "Advanced", 
"true",
--- End diff --

Please update FS with this config information.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38303506
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 ---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
 closeContext(context);
 }
 }
+
+@Override
+public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String 
type, String name, short accountType) {
+Validate.notNull(type, "type cannot be null. It should either be 
GROUP or OU");
--- End diff --

What if type is empty or something other than "GROUP" or "OU"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38303622
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 ---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
 closeContext(context);
 }
 }
+
+@Override
+public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String 
type, String name, short accountType) {
+Validate.notNull(type, "type cannot be null. It should either be 
GROUP or OU");
+Validate.notNull(domainId, "domainId cannot be null.");
--- End diff --

What if domainId is already present? I understand there will be a DB 
constraint violation exception but it is better to throw 
InvalidParameterException instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38303769
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 ---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
 closeContext(context);
 }
 }
+
+@Override
+public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String 
type, String name, short accountType) {
+Validate.notNull(type, "type cannot be null. It should either be 
GROUP or OU");
+Validate.notNull(domainId, "domainId cannot be null.");
+Validate.notEmpty(name, "GROUP or OU name cannot be empty");
--- End diff --

What if the name doesn't exist in LDAP?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38303804
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 ---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
 closeContext(context);
 }
 }
+
+@Override
+public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String 
type, String name, short accountType) {
+Validate.notNull(type, "type cannot be null. It should either be 
GROUP or OU");
+Validate.notNull(domainId, "domainId cannot be null.");
+Validate.notEmpty(name, "GROUP or OU name cannot be empty");
+//Account type constants in com.cloud.user.Account
+Validate.isTrue(accountType>=0 && accountType<=5, "accountype 
should be a number from 0-5");
--- End diff --

The parameter description in the Cmd says allowed values are 0, 1, 2. 
Shouldn't this be in sync with description?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38304057
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 ---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
 closeContext(context);
 }
 }
+
+@Override
+public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String 
type, String name, short accountType) {
+Validate.notNull(type, "type cannot be null. It should either be 
GROUP or OU");
+Validate.notNull(domainId, "domainId cannot be null.");
+Validate.notEmpty(name, "GROUP or OU name cannot be empty");
--- End diff --

Is it possible to map different CS domains to same LDAP group/ou name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-08-31 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request:

https://github.com/apache/cloudstack/pull/765

CLOUDSTACK-8688 - default policies for INPUT and FORWARD should be se…

…t to DROP instead of ACCEPT

  - In order to be able to access the routers via the link local interface, 
we have to add a rules with NEW and ESTABLISHED state

Tests:

* Deployed 2 zones, basic and advanced, using KVM as hypervisor
* On the basic zone, created 1 security group, added ingress rules to open 
port 22 and deployed 1 VM
  * SSH into the router and checked that the INPUT/FORWARD policies were 
set to DROP
  * SSH to the VM
* On the advanced zone, created 1 single VPC (with 2 tiers, 2 puc IPs, 2 
VMs and 1 ACL), 1 redundant VPC ((with 2 tiers, 2 puc IPs, 2 VMs and 1 ACL)), 1 
isolated network (with 1 VM and 1 pub IP), 1 redundant network (with 1 VM and 1 
pub IP)
  * SSH into all routers to check that the INPUT/FORWARD policies were set 
to DROP
  * SSH into all VMs to test the communication

sbpltk1zffh04:asf_cloudstack wrodrigues$ ssh root@192.168.23.26
The authenticity of host '192.168.23.26 (192.168.23.26)' can't be 
established.
RSA key fingerprint is cb:42:81:d0:05:97:f4:be:9e:3b:dd:3f:c6:d2:48:e7.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '192.168.23.26' (RSA) to the list of known hosts.
root@192.168.23.26's password: 
# ls /
bin bootdev etc homelib 
lib64   linuxrc lost+found  media   mnt opt proc
rootrun sbinsys tmp usr var
# exit
Connection to 192.168.23.26 closed.
sbpltk1zffh04:asf_cloudstack wrodrigues$ ssh root@192.168.22.63
The authenticity of host '192.168.22.63 (192.168.22.63)' can't be 
established.
RSA key fingerprint is a2:20:d6:e2:fb:c5:89:94:57:f5:89:b1:a1:6d:63:99.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '192.168.22.63' (RSA) to the list of known hosts.
root@192.168.22.63's password: 
# ls /
bin bootdev etc homelib 
lib64   linuxrc lost+found  media   mnt opt proc
rootrun sbinsys tmp usr var
# exit
Connection to 192.168.22.63 closed.
sbpltk1zffh04:asf_cloudstack wrodrigues$ ssh root@192.168.23.27 
The authenticity of host '192.168.23.27 (192.168.23.27)' can't be 
established.
RSA key fingerprint is 20:f1:6d:9b:74:c5:7b:53:10:5c:a0:0c:bc:9f:2a:29.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '192.168.23.27' (RSA) to the list of known hosts.
root@192.168.23.27's password: 
# ls /
bin bootdev etc homelib 
lib64   linuxrc lost+found  media   mnt opt proc
rootrun sbinsys tmp usr var
# exitConnection to 192.168.23.27 closed.
sbpltk1zffh04:asf_cloudstack wrodrigues$ ssh root@192.168.23.28
The authenticity of host '192.168.23.28 (192.168.23.28)' can't be 
established.
RSA key fingerprint is f7:ae:49:46:ba:02:c1:25:5a:50:87:0e:6f:a4:43:a3.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '192.168.23.28' (RSA) to the list of known hosts.
root@192.168.23.28's password: 
# ls /
bin bootdev etc homelib 
lib64   linuxrc lost+found  media   mnt opt proc
rootrun sbinsys tmp usr var
# exitConnection to 192.168.23.28 closed.
sbpltk1zffh04:asf_cloudstack wrodrigues$ ssh root@192.168.23.29
The authenticity of host '192.168.23.29 (192.168.23.29)' can't be 
established.
RSA key fingerprint is 09:0c:f2:41:a3:74:3d:ee:04:2b:78:ff:a9:91:0d:79.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '192.168.23.29' (RSA) to the list of known hosts.
root@192.168.23.29's password: 
# ls /
bin bootdev etc homelib 
lib64   linuxrc lost+found  media   mnt opt proc
rootrun sbinsys tmp usr var
# exit
Connection to 192.168.23.29 closed.
sbpltk1zffh04:asf_cloudstack wrodrigues$ ssh root@192.168.23.30
The authenticity of host '192.168.23.30 (192.168.23.30)' can't be 
established.
RSA key fingerprint is 2c:a6:10:f5:6d:4b:d1:70:e2:47:07:19:0b:86:c1:b0.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '192.168.23.30' (RSA) to the list of known hosts.

root@192.168.23.30's password: 

Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Milamber

Hello,

Perhaps an issue on SSL/TLS requirement. Check difference of the file 
below (now and after the update)


JAVA_HOME/jre/lib/security/java.security

Particularly the keys:
jdk.certpath.disabledAlgorithms
and
jdk.tls.legacyAlgorithms


Also, check the keystore contains the ssl keys with the keytool command (from 
the updated packages). Can you read-it, check the key size, etc.


Some reference:
http://www.oracle.com/technetwork/java/javase/6u17-141447.html
6861062 java classes_security Disable MD2 in certificate 
chain validation


http://www.oracle.com/technetwork/java/javase/7u40-relnotes-2004172.html
Default x.509 Certificates Have Longer Key Length

Starting from 7u40, the use of x.509 certificates with RSA keys less 
than 1024 bits in length is restricted. This restriction is applied via 
the Java Security property, jdk.certpath.disabledAlgorithms. The default 
value of jdk.certpath.disabledAlgorithms is now as follows:

jdk.certpath.disabledAlgorithms=MD2, RSA keySize < 1024

In order to avoid the compatibility issue, users who use X.509 
certificates with RSA keys less than 1024 bits, are recommended to 
update their certificates with stronger keys. As a workaround, at their 
own risk, users can adjust the key size to permit smaller key sizes 
through the security property jdk.certpath.disabledAlgorithms.


=



On 31/08/2015 12:11, Nux! wrote:

Rajani,

Yes, you read right.
The rpm changelog shows:
  Tue Jul 28 2015 Andrew Hughes  - 1:1.6.0.36-1.13.8.1
- Update tarball to fix TCK regression (PR2565)
- Resolves: rhbz#1235150

* Wed Jul 22 2015 Andrew Hughes  - 1:1.6.0.36-1.13.8.0
- Update to IcedTea 1.13.8
- Update no_pr2125.patch to work against new version.
- Resolves: rhbz#1235150

Nothing dramatic, though I do not have permission to read those bugzilla 
entries.

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -

From: "Rajani Karuturi" 
To: dev@cloudstack.apache.org
Sent: Monday, 31 August, 2015 11:59:04
Subject: Re: Hypervisors disconnected - java.io.IOException Fail to init SSL 
java.io.IOException: Connection closed with
-1 on reading size
If I am reading it right, java 1.7 has no version change and 1.6 is changed
from 1.6.0.35 to 16.0.36 which caused the failure

Interestingly, I do not see release notes for 1.6.0_36
http://www.oracle.com/technetwork/java/javase/releasenotes-136954.html

~Rajani

On Mon, Aug 31, 2015 at 4:09 PM, Nux!  wrote:


Rajani,

Sure:

Downgrade  java-1.6.0-openjdk-1:1.6.0.35-1.13.7.1.el6_6.x86_64  @base
Downgraded1:1.6.0.36-1.13.8.1.el6_7.x86_64
@updates
Downgrade  java-1.7.0-openjdk-1:1.7.0.85-2.6.1.3.el6_6.x86_64
  @updates
Downgraded1:1.7.0.85-2.6.1.3.el6_7.x86_64
  @updates
Downgrade  java-1.7.0-openjdk-devel-1:1.7.0.85-2.6.1.3.el6_6.x86_64
@updates
Downgraded  1:1.7.0.85-2.6.1.3.el6_7.x86_64
@updates

The differences seem trivial and there's always the risk it may not have
been the java change at all doing this, but I do not know what else could
have triggered it.

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -

From: "Rajani Karuturi" 
To: dev@cloudstack.apache.org
Sent: Monday, 31 August, 2015 11:21:45
Subject: Re: Hypervisors disconnected - java.io.IOException Fail to init

SSL java.io.IOException: Connection closed with

-1 on reading size
Hi Lucian,
Can you share the point release numbers of java before and after the
upgrade? (May be that would help us find the issue.)

~Rajani

On Mon, Aug 31, 2015 at 3:42 PM, Nux!  wrote:


A downgrade of both java-1.6.0-openjdk and java-1.7.0-openjdk followed

by

a reboot of the management server seems to have fixed it, but it's not a
solution I like very much.

Anyone has any clues as to what causes that error?

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -

From: "Nux!" 
To: "dev" 
Sent: Monday, 31 August, 2015 10:58:16
Subject: Hypervisors disconnected - java.io.IOException Fail to init

SSL

java.io.IOException: Connection closed with -1

on reading size
Hi,

Has anyone seen this before and can translate to English? The logs

don't

say

much, it's obviously SSL related somehow.

The agent says:

java.io.IOException: SSL: Fail to init SSL! java.io.IOException:

Connection

closed with -1 on reading size.
   at com.cloud.utils.nio.NioClient.init(NioClient.java:87)
   at com.cloud.utils.nio.NioConnection.run(NioConnection.java:111)
   at java.lang.Thread.run(Thread.java:745)
2015-08-31 10:27:56,315 INFO  [utils.nio.NioClient]

(Agent-Selector:null)

Connecting to 192.168.168.2:8250

2015-08-31 10:28:06,333 ERROR [utils.nio.NioConnection]

(Agent-Selector:null)

Unable to initialize the threads.
java.io.IOException: SSL: Fail to init SSL! java.io.IOException:

Connection

closed with -1 on reading size.
   at com.cloud.utils.nio.NioClient.in

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-08-31 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/765#issuecomment-136354474
  
Some screenshots:

VMs:


![image](https://cloud.githubusercontent.com/assets/5129209/9578445/681a3194-4fea-11e5-80c8-b085d4bf9809.png)

Infra:


![image](https://cloud.githubusercontent.com/assets/5129209/9578454/789935d8-4fea-11e5-91dd-990de69f63e0.png)

Routers:


![image](https://cloud.githubusercontent.com/assets/5129209/9578463/8546144a-4fea-11e5-99ed-5c29044c403b.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Hypervisors disconnected - java.io.IOException Fail to init SSL java.io.IOException: Connection closed with -1 on reading size

2015-08-31 Thread Nux!
Thanks Milamber,

I'll have to set up a test env for this and follow your advice.

I'll get back with any findings.

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Milamber" 
> To: dev@cloudstack.apache.org
> Sent: Monday, 31 August, 2015 13:13:10
> Subject: Re: Hypervisors disconnected - java.io.IOException Fail to init SSL 
> java.io.IOException: Connection closed with
> -1 on reading size

> Hello,
> 
> Perhaps an issue on SSL/TLS requirement. Check difference of the file
> below (now and after the update)
> 
> JAVA_HOME/jre/lib/security/java.security
> 
> Particularly the keys:
> jdk.certpath.disabledAlgorithms
> and
> jdk.tls.legacyAlgorithms
> 
> 
> Also, check the keystore contains the ssl keys with the keytool command (from
> the updated packages). Can you read-it, check the key size, etc.
> 
> 
> Some reference:
> http://www.oracle.com/technetwork/java/javase/6u17-141447.html
> 6861062 java classes_security Disable MD2 in certificate
> chain validation
> 
> http://www.oracle.com/technetwork/java/javase/7u40-relnotes-2004172.html
> Default x.509 Certificates Have Longer Key Length
> 
> Starting from 7u40, the use of x.509 certificates with RSA keys less
> than 1024 bits in length is restricted. This restriction is applied via
> the Java Security property, jdk.certpath.disabledAlgorithms. The default
> value of jdk.certpath.disabledAlgorithms is now as follows:
> jdk.certpath.disabledAlgorithms=MD2, RSA keySize < 1024
> 
> In order to avoid the compatibility issue, users who use X.509
> certificates with RSA keys less than 1024 bits, are recommended to
> update their certificates with stronger keys. As a workaround, at their
> own risk, users can adjust the key size to permit smaller key sizes
> through the security property jdk.certpath.disabledAlgorithms.
> 
> =
> 
> 
> 
> On 31/08/2015 12:11, Nux! wrote:
>> Rajani,
>>
>> Yes, you read right.
>> The rpm changelog shows:
>>   Tue Jul 28 2015 Andrew Hughes  - 1:1.6.0.36-1.13.8.1
>> - Update tarball to fix TCK regression (PR2565)
>> - Resolves: rhbz#1235150
>>
>> * Wed Jul 22 2015 Andrew Hughes  - 1:1.6.0.36-1.13.8.0
>> - Update to IcedTea 1.13.8
>> - Update no_pr2125.patch to work against new version.
>> - Resolves: rhbz#1235150
>>
>> Nothing dramatic, though I do not have permission to read those bugzilla
>> entries.
>>
>> --
>> Sent from the Delta quadrant using Borg technology!
>>
>> Nux!
>> www.nux.ro
>>
>> - Original Message -
>>> From: "Rajani Karuturi" 
>>> To: dev@cloudstack.apache.org
>>> Sent: Monday, 31 August, 2015 11:59:04
>>> Subject: Re: Hypervisors disconnected - java.io.IOException Fail to init SSL
>>> java.io.IOException: Connection closed with
>>> -1 on reading size
>>> If I am reading it right, java 1.7 has no version change and 1.6 is changed
>>> from 1.6.0.35 to 16.0.36 which caused the failure
>>>
>>> Interestingly, I do not see release notes for 1.6.0_36
>>> http://www.oracle.com/technetwork/java/javase/releasenotes-136954.html
>>>
>>> ~Rajani
>>>
>>> On Mon, Aug 31, 2015 at 4:09 PM, Nux!  wrote:
>>>
 Rajani,

 Sure:

 Downgrade  java-1.6.0-openjdk-1:1.6.0.35-1.13.7.1.el6_6.x86_64  @base
 Downgraded1:1.6.0.36-1.13.8.1.el6_7.x86_64
 @updates
 Downgrade  java-1.7.0-openjdk-1:1.7.0.85-2.6.1.3.el6_6.x86_64
   @updates
 Downgraded1:1.7.0.85-2.6.1.3.el6_7.x86_64
   @updates
 Downgrade  java-1.7.0-openjdk-devel-1:1.7.0.85-2.6.1.3.el6_6.x86_64
 @updates
 Downgraded  1:1.7.0.85-2.6.1.3.el6_7.x86_64
 @updates

 The differences seem trivial and there's always the risk it may not have
 been the java change at all doing this, but I do not know what else could
 have triggered it.

 --
 Sent from the Delta quadrant using Borg technology!

 Nux!
 www.nux.ro

 - Original Message -
> From: "Rajani Karuturi" 
> To: dev@cloudstack.apache.org
> Sent: Monday, 31 August, 2015 11:21:45
> Subject: Re: Hypervisors disconnected - java.io.IOException Fail to init
 SSL java.io.IOException: Connection closed with
> -1 on reading size
> Hi Lucian,
> Can you share the point release numbers of java before and after the
> upgrade? (May be that would help us find the issue.)
>
> ~Rajani
>
> On Mon, Aug 31, 2015 at 3:42 PM, Nux!  wrote:
>
>> A downgrade of both java-1.6.0-openjdk and java-1.7.0-openjdk followed
 by
>> a reboot of the management server seems to have fixed it, but it's not a
>> solution I like very much.
>>
>> Anyone has any clues as to what causes that error?
>>
>> Lucian
>>
>> --
>> Sent from the Delta quadrant using Borg technology!
>>
>> Nux!
>> www.nux.ro
>>
>> - Original Message -
>>> From: "Nux!" 
>>> To: "dev" 
>>> Sent: Monday, 3

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-08-31 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/765#issuecomment-136363043
  
VM Life Cycle tests (Advanced Zone)

```
[root@cs1 integration]# nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone2-kvm2-ISOLATED.cfg -s -a 
tags=advanced,required_hardware=false smoke/test_vm_life_cycle.py 

 Marvin Init Started 

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

 Log Folder Path: /tmp//MarvinLogs//Aug_31_2015_12_14_38_JN3PBD. All 
logs will be available here 

=== Marvin Init Logging Successful===

 Marvin Init Successful 
=== TestName: test_advZoneVirtualRouter | Status : SUCCESS ===

=== TestName: test_deploy_vm | Status : SUCCESS ===

=== TestName: test_deploy_vm_multiple | Status : SUCCESS ===

=== TestName: test_01_stop_vm | Status : SUCCESS ===

=== TestName: test_02_start_vm | Status : SUCCESS ===

=== TestName: test_03_reboot_vm | Status : SUCCESS ===

=== TestName: test_06_destroy_vm | Status : SUCCESS ===

=== TestName: test_07_restore_vm | Status : SUCCESS ===

=== TestName: test_09_expunge_vm | Status : SUCCESS ===

===final results are now copied to: 
/tmp//MarvinLogs/test_vm_life_cycle_L0WK32===
[root@cs1 integration]# 
```

VM Life Cycle tests (Basic Zone)

```
[root@cs1 integration]# nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-basic.cfg -s -a 
tags=basic,required_hardware=false smoke/test_vm_life_cycle.py 

 Marvin Init Started 

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

 Log Folder Path: /tmp//MarvinLogs//Aug_31_2015_12_41_40_5VQUD2. All 
logs will be available here 

=== Marvin Init Logging Successful===

 Marvin Init Successful 
=== TestName: test_deploy_vm | Status : SUCCESS ===

=== TestName: test_deploy_vm_multiple | Status : SUCCESS ===

=== TestName: test_01_stop_vm | Status : SUCCESS ===

=== TestName: test_02_start_vm | Status : SUCCESS ===

=== TestName: test_03_reboot_vm | Status : SUCCESS ===

=== TestName: test_06_destroy_vm | Status : SUCCESS ===

=== TestName: test_07_restore_vm | Status : SUCCESS ===

=== TestName: test_09_expunge_vm | Status : SUCCESS ===

===final results are now copied to: 
/tmp//MarvinLogs/test_vm_life_cycle_8F4UL3===
[root@cs1 integration]#
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...

2015-08-31 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/762#issuecomment-136363041
  
The tests that have failed do not seem to be related to the code that was 
changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-08-31 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-136366153
  
Hi @karuturi, If you take a look at here: 

https://github.com/rafaelweingartner/cloudstack/blob/master-lrg-cs-hackday-003/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
You can see that the commit was properly coded. The method 
“resolveNameInGuid” was static (for some off reason) and we had changed it 
to non-static, it does not need to be static. It seems that there was either a 
problem with the merge or someone else had put back the static keyword in that 
method there.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

2015-08-31 Thread Sebastien Goasguen
did you do the aws configure ?

aws cli needs to know your keys as well..

> On Aug 28, 2015, at 6:04 PM, Rajani Karuturi  wrote:
> 
> Hi Carlos,
> I have the signature fix and config looks like below. I also checked that
> the keys are correct.
> 
> 
> On Fri, Aug 28, 2015 at 20:53 PM, Carlos Reategui 
> wrote:
> 
> Rajani,
> Take a look at your ~/.aws/config and make sure the keys are correct.  Also
> is you are using a current version of the AWS CLI make sure to add the
> signature_version block as mentioned in the ec2stack readme.
> 
> From the above looks like you are not using profiles therefore your config
> file should look something like this:
> 
> 
> [default]
> 
> output = json
> 
> region =
> 
> aws_access_key_id = xx
> 
> aws_secret_access_key = y
> 
> ec2 =
> 
>signature_version = v2
> 
> 
> 
> Regards,
> Carlos
> 
> 
> On Fri, Aug 28, 2015 at 4:04 AM, Rajani Karuturi  
>> wrote:
> 
>> Hi Sebastien,
>> 
>> I am trying to configure and use ec2stack. This is what I have done
>> 
>> $ pip install awscli
>> $ cd cloudstack-ec2stack
>> $ python setup.py install
>> $ ec2stack-configure
>> $ ec2stack &
>> $ ec2stack-register http://localhost:5000 cs_api_key cs_secret_key
>> $ aws ec2 describe-images --endpoint=http://localhost:5000
>> # it gave the below error message
>> # Unable to locate credentials. You can configure credentials by running
>> "aws configure”.
>> $ aws configure # gave AWS api and secret key
>> $ aws ec2 describe-images --endpoint=http://localhost:5000
>> # this is the output I see
>> # localhost - - [28/Aug/2015 16:25:24] "POST / HTTP/1.1" 401 -
>> # ‘RequestID’
>> 
>> I don’t see anything in cloudstack logs
>> 
>> If I change the api key and secret key to
>> $ ec2stack-register http://localhost:5000 aws_api_key aws_secret_key
>> 
>> I see below in cloudstack logs
>> 
>> 2015-08-28 16:22:37,118 DEBUG [c.c.a.ApiServlet]
>> (1188257713@qtp-2099531272-3:ctx-29d29342) ===START===  10.147.28.40 --
>> GET
>> 
> apikey=aws_api_key&command=listTemplates&listAll=true&response=json&templatefilter=executable&signature=6OggS6Zb2vbejw60BbFbYhaiEEY%3D
>> 2015-08-28 16:22:37,120 DEBUG [c.c.a.ApiServer]
>> (1188257713@qtp-2099531272-3:ctx-29d29342 ctx-574b2cf4) apiKey does not
>> map to a valid user -- ignoring request, apiKey:aws_api_key
>> 2015-08-28 16:22:37,122 DEBUG [c.c.a.ApiServlet]
>> (1188257713@qtp-2099531272-3:ctx-29d29342 ctx-574b2cf4) ===END===
>> 10.147.28.40 -- GET
>> 
> apikey=aws_api_key&command=listTemplates&listAll=true&response=json&templatefilter=executable&signature=6OggS6Zb2vbejw60BbFbYhaiEEY%3D
>> 
>> 
>> where are the logs for ec2stack? how can I see what it is happening?
>> 
>> ~Rajani
>> 
>> 
>> 
>> On 27-Aug-2015, at 12:54 am, sebgoa >
> wrote:
>> 
>>> 
>>> On Aug 26, 2015, at 7:08 PM, David Nalley >
> wrote:
>>> 
 +1 (binding)
 
 sigs and hashes look good.
 builds fine
 no binaries present.
 A few files seem to be missing license headers, but I don't think it's
 a blocker.
 License and NOTICE appear to be correct.
 
 I wish we pointed to the cloudstack docker hub account rather than the
 runseb account, but don't think it's a blocker for release
 
>>> 
>>> missed that, now fixed.
>>> 
 --David
 
 On Wed, Aug 26, 2015 at 5:25 AM, sebgoa  > wrote:
> Hi All,
> 
> I've created a 0.8.0 release of EC2stack, with the following artifacts
>> up for a vote:
> 
> Git Branch and Commit SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack-ec2stack.git
> 
> Commit: a61d7c01129dfe4c31515a48e0f6b4a53436c208
> 
> There are no code changes from the time the code was donated to the
>> ASF, only license headers and a Dockerfile.
> 
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/ec2stack-0.8.0/
> 
> PGP release keys (signed using 8F89EB84):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> 
> For testing functionality you might consider using the Docker image:
> docker pull cloudstack/cloudstack-ec2stack
> 
> Do remember that the official release artifact is the source code,
>> which needs to contain proper licensing and proper signatures.
> 
> Vote will be open for 72 hours.
> 
> For sanity in tallying the vote, can PMC members please be sure to
>> indicate "(binding)" with their vote?
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>>> 
>> 
>> 
> 
> 
> 
> -- 
> -
> Sent from Windows Phone
> ~Rajani



New Defects reported by Coverity Scan for cloudstack

2015-08-31 Thread scan-admin

Hi,

Please find the latest report on new defect(s) introduced to cloudstack found 
with Coverity Scan.

3 new defect(s) introduced to cloudstack found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1320908:  FindBugs: Dodgy code  (FB.BC_VACUOUS_INSTANCEOF)
/server/src/com/cloud/vm/UserVmManagerImpl.java: 2194 in 
com.cloud.vm.UserVmManagerImpl.updateVirtualMachine(org.apache.cloudstack.api.command.user.vm.UpdateVMCmd)()



*** CID 1320908:  FindBugs: Dodgy code  (FB.BC_VACUOUS_INSTANCEOF)
/server/src/com/cloud/vm/UserVmManagerImpl.java: 2194 in 
com.cloud.vm.UserVmManagerImpl.updateVirtualMachine(org.apache.cloudstack.api.command.user.vm.UpdateVMCmd)()
2188 }
2189 
2190 if (details != null && !details.isEmpty()) {
2191 _vmDao.loadDetails(vmInstance);
2192 
2193 for(Map.Entry entry : details.entrySet()) {
>>> CID 1320908:  FindBugs: Dodgy code  (FB.BC_VACUOUS_INSTANCEOF)
>>> instanceof will always return true for all nonnull values, since all 
>>> java.util.Map$Entry are instances of 
>>> java.util.Map$Entry
2194 if(entry instanceof Map.Entry) {
2195 vmInstance.setDetail(entry.getKey(), 
entry.getValue());
2196 }
2197 }
2198 _vmDao.saveDetails(vmInstance);
2199 }

** CID 1320905:  Null pointer dereferences  (NULL_RETURNS)
/utils/src/main/java/com/cloud/utils/net/NetUtils.java: 1267 in 
com.cloud.utils.net.NetUtils.getIp6FromRange(java.lang.String)()



*** CID 1320905:  Null pointer dereferences  (NULL_RETURNS)
/utils/src/main/java/com/cloud/utils/net/NetUtils.java: 1267 in 
com.cloud.utils.net.NetUtils.getIp6FromRange(java.lang.String)()
1261 // Can cover 127 bits
1262 public static String getIp6FromRange(final String ip6Range) {
1263 final String[] ips = ip6Range.split("-");
1264 final String startIp = ips[0];
1265 final IPv6Address start = IPv6Address.fromString(startIp);
1266 final BigInteger gap = countIp6InRange(ip6Range);
>>> CID 1320905:  Null pointer dereferences  (NULL_RETURNS)
>>> Calling a method on null object "gap".
1267 BigInteger next = new BigInteger(gap.bitLength(), s_rand);
1268 while (next.compareTo(gap) >= 0) {
1269 next = new BigInteger(gap.bitLength(), s_rand);
1270 }
1271 InetAddress resultAddr = null;
1272 final BigInteger startInt = 
convertIPv6AddressToBigInteger(start);

** CID 1320904:  Null pointer dereferences  (NULL_RETURNS)
/utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java:
 53 in 
org.apache.cloudstack.utils.imagestore.ImageStoreUtil.checkTemplateFormat(java.lang.String,
 java.lang.String)()



*** CID 1320904:  Null pointer dereferences  (NULL_RETURNS)
/utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java:
 53 in 
org.apache.cloudstack.utils.imagestore.ImageStoreUtil.checkTemplateFormat(java.lang.String,
 java.lang.String)()
47 if (isCompressedExtension(uripath)) {
48 command = "file -z ";
49 }
50 String output = Script.runSimpleBashScript(command + path + " | 
cut -d: -f2", 6);
51 
52 // vmdk
>>> CID 1320904:  Null pointer dereferences  (NULL_RETURNS)
>>> Calling a method on null object "output".
53 if ((output.contains("VMware") || output.contains("data")) && 
isCorrectExtension(uripath, "vmdk")) {
54 s_logger.debug("File at path " + path + " looks like a 
vmware image :" + output);
55 return "";
56 }
57 // raw
58 if ((output.contains("x86 boot") || output.contains("data")) && 
(isCorrectExtension(uripath, "raw") || isCorrectExtension(uripath, "img"))) {



To view the defects in Coverity Scan visit, 
https://scan.coverity.com/projects/cloudstack?tab=overview

To manage Coverity Scan email notifications for "dev@cloudstack.apache.org", 
click 
https://scan.coverity.com/subscriptions/edit?email=dev%40cloudstack.apache.org&token=494aabd5ba647999fa41b6d766646231



Build failed in Jenkins: build-master-slowbuild #2193

2015-08-31 Thread jenkins
See 

--
[...truncated 28153 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.690s]
[INFO] Apache CloudStack . SUCCESS [2.506s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.777s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.383s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:13.664s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.174s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [52.637s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.799s]
[INFO] Apache CloudStack API . SUCCESS [1:47.583s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.602s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.983s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.100s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [26.832s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.830s]
[INFO] Apache CloudStack Core  SUCCESS [1:15.627s]
[INFO] Apache CloudStack Agents .. SUCCESS [34.673s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.711s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.415s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.711s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [45.135s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [33.385s]
[INFO] Apache CloudStack Server .. SUCCESS [4:24.309s]
[INFO] Apache CloudStack Usage Server  SUCCESS [52.116s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:35.593s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.075s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.441s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [56.847s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [58.832s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [35.399s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.350s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [22.299s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [23.116s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [34.718s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.134s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [5.677s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.727s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.130s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[2:31.905s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[3:19.041s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [21.172s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [27.950s]
[INFO] Apache CloudStack Plugin - ACL

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-08-31 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/714#issuecomment-136390913
  
@karuturi, I was just reviewing my commit, I am really sorry.
I indeed forgot to commit the removal of the static keyword in that method. 
It was right in my workspace, but I had not committed it. Would you like us to 
re-open the PR to fix that? Or should we create a new one?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...

2015-08-31 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/756#issuecomment-136397028
  
Hi @nlivens ,

I'm looking int your PR and also and some documentation of Cloudstack 4.2 
related to Netscaler as external load balancer for VPCs:

The implementation was done in this issue: 
https://issues.apache.org/jira/browse/CLOUDSTACK-869

The documentation can be found here: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+%3A+Support+of+Netscaler+as+External+LoadBalancing+Provider+in+VPC

And if it should be removed, I believe it wouldn't be only about the 
Netscaler option, but also the offering - as showed in the image below:


![image](https://cloud.githubusercontent.com/assets/5129209/9581609/ba0891d8-5000-11e5-930d-6973b74b9aca.png)

So, unless I misunderstood something, this PR should not be applied.

@bhaisaab @remibergsma @DaanHoogland could one of you please give some 
thought on this PR and on what I wrote?

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Marcus
There are a bunch of things like this in the code already, and they're
wrapped in version checks. See

_hypervisorLibvirtVersion in LibvirtComputingResource. We just need to
figure out which versions need to be left out.




On Mon, Aug 31, 2015 at 1:56 AM, Rohit Yadav 
wrote:

> Hi Mike,
>
> I think it is related to this, the libvirt version is really old that
> lacks the flags:
>
> https://github.com/apache/cloudstack/commit/5d29b63cfa98a15d7734798c5b29a43658d7f112
>
> If VM migration flag (8) is not available, can you check
> if VIR_DOMAIN_XML_SECURE (flag=1) works for you, if so we can change the
> above fix to use 0x1 (or 1) to support KVM/12.04 though I’m not sure if for
> vm migration the xml dump method should be provided 0x1 and not 0x8
> (VIR_DOMAIN_XML_MIGRATABLE).
>
> On 31-Aug-2015, at 11:29 am, Mike Tutkowski 
> .com> wrote:
>
> Hi,
>
> I'm having a problem migrating a VM from one 12.04 KVM host to another
> 12.04 KVM host in the same cluster in CS 4.6.
>
> Anyone know why I might be receiving this error message?
>
> invalid argument: virDomainDefFormat: unsupported flags (0x8)
>
> The root disk is stored on cluster-scoped NFS primary storage.
>
> Thanks!
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>
>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
>
>
>
>
> M. +91 88 262 30892 | rohit.ya...@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build
> 
> CSForge – rapid IaaS deployment framework 
> CloudStack Consulting 
> CloudStack Software Engineering
> 
> CloudStack Infrastructure Support
> 
> CloudStack Bootcamp Training Courses
> 
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>


Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

2015-08-31 Thread Rajani Karuturi
Yes. I did. Can you point me logs or a way to debug?


On Mon, Aug 31, 2015 at 18:46 PM, Sebastien Goasguen 
wrote:

did you do the aws configure ?

aws cli needs to know your keys as well..

> On Aug 28, 2015, at 6:04 PM, Rajani Karuturi > wrote:
>
> Hi Carlos,
> I have the signature fix and config looks like below. I also checked that
> the keys are correct.
>
>
> On Fri, Aug 28, 2015 at 20:53 PM, Carlos Reategui >
> wrote:
>
> Rajani,
> Take a look at your ~/.aws/config and make sure the keys are correct.
Also
> is you are using a current version of the AWS CLI make sure to add the
> signature_version block as mentioned in the ec2stack readme.
>
> From the above looks like you are not using profiles therefore your config
> file should look something like this:
>
>
> [default]
>
> output = json
>
> region =
>
> aws_access_key_id = xx
>
> aws_secret_access_key = y
>
> ec2 =
>
>signature_version = v2
>
>
>
> Regards,
> Carlos
>
>
> On Fri, Aug 28, 2015 at 4:04 AM, Rajani Karuturi <
rajani.karut...@citrix.com 
> 
>> wrote:
>
>> Hi Sebastien,
>>
>> I am trying to configure and use ec2stack. This is what I have done
>>
>> $ pip install awscli
>> $ cd cloudstack-ec2stack
>> $ python setup.py install
>> $ ec2stack-configure
>> $ ec2stack &
>> $ ec2stack-register http://localhost:5000 cs_api_key cs_secret_key
>> $ aws ec2 describe-images --endpoint=http://localhost:5000
>> # it gave the below error message
>> # Unable to locate credentials. You can configure credentials by running
>> "aws configure”.
>> $ aws configure # gave AWS api and secret key
>> $ aws ec2 describe-images --endpoint=http://localhost:5000
>> # this is the output I see
>> # localhost - - [28/Aug/2015 16:25:24] "POST / HTTP/1.1" 401 -
>> # ‘RequestID’
>>
>> I don’t see anything in cloudstack logs
>>
>> If I change the api key and secret key to
>> $ ec2stack-register http://localhost:5000 aws_api_key aws_secret_key
>>
>> I see below in cloudstack logs
>>
>> 2015-08-28 16:22:37,118 DEBUG [c.c.a.ApiServlet]
>> (1188257713@qtp-2099531272-3:ctx-29d29342) ===START===  10.147.28.40 --
>> GET
>>
>
apikey=aws_api_key&command=listTemplates&listAll=true&response=json&templatefilter=executable&signature=6OggS6Zb2vbejw60BbFbYhaiEEY%3D
>> 2015-08-28 16:22:37,120 DEBUG [c.c.a.ApiServer]
>> (1188257713@qtp-2099531272-3:ctx-29d29342 ctx-574b2cf4) apiKey does not
>> map to a valid user -- ignoring request, apiKey:aws_api_key
>> 2015-08-28 16:22:37,122 DEBUG [c.c.a.ApiServlet]
>> (1188257713@qtp-2099531272-3:ctx-29d29342 ctx-574b2cf4) ===END===
>> 10.147.28.40 -- GET
>>
>
apikey=aws_api_key&command=listTemplates&listAll=true&response=json&templatefilter=executable&signature=6OggS6Zb2vbejw60BbFbYhaiEEY%3D
>>
>>
>> where are the logs for ec2stack? how can I see what it is happening?
>>
>> ~Rajani
>>
>>
>>
>> On 27-Aug-2015, at 12:54 am, sebgoa 
>
> wrote:
>>
>>>
>>> On Aug 26, 2015, at 7:08 PM, David Nalley 
>
> wrote:
>>>
 +1 (binding)

 sigs and hashes look good.
 builds fine
 no binaries present.
 A few files seem to be missing license headers, but I don't think it's
 a blocker.
 License and NOTICE appear to be correct.

 I wish we pointed to the cloudstack docker hub account rather than the
 runseb account, but don't think it's a blocker for release

>>>
>>> missed that, now fixed.
>>>
 --David

 On Wed, Aug 26, 2015 at 5:25 AM, sebgoa 
> > wrote:
> Hi All,
>
> I've created a 0.8.0 release of EC2stack, with the following artifacts
>> up for a vote:
>
> Git Branch and Commit SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack-ec2stack.git
>
> Commit: a61d7c01129dfe4c31515a48e0f6b4a53436c208
>
> There are no code changes from the time the code was donated to the
>> ASF, only license headers and a Dockerfile.
>
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/ec2stack-0.8.0/
>
> PGP release keys (signed using 8F89EB84):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
> For testing functionality you might consider using the Docker image:
> docker pull cloudstack/cloudstack-ec2stack
>
> Do remember that the official release artifact is the source code,
>> which needs to contain proper licensing and proper signatures.
>
> Vote will be open for 72 hours.
>
> For sanity in tallying the vote, can PMC members please be sure to
>> indicate "(binding)" with their vote?
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>>>
>>
>>
>
>
>
> --
> -
> Sent from Windows Phone
> ~Rajani



-- 
-
Sent from Windows Phone
~Rajani


Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-31 Thread David Nalley
On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das  wrote:
> I am no longer able to start MS after this. I did a clean build followed by 
> starting MS. Did travis pass for it? Should we revert?
>

Yes, and in general, when things break you should feel empowered to
revert (still send a note to the list, but as a committer, you have a
binding veto at your disposal - feel free to make use of it to keep
quality high.)

--David


Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Marcus
Looks like the VIR_DOMAIN_XML_MIGRATABLE flag was introduced in v1.0.0
(version 100 in how the Libvirt API reports), and VIR_DOMAIN_XML_SECURE
was all the way back in v0.8.0 (version 8000).

On Mon, Aug 31, 2015 at 8:04 AM, Marcus  wrote:

> There are a bunch of things like this in the code already, and they're
> wrapped in version checks. See
>
> _hypervisorLibvirtVersion in LibvirtComputingResource. We just need to
> figure out which versions need to be left out.
>
>
>
>
> On Mon, Aug 31, 2015 at 1:56 AM, Rohit Yadav 
> wrote:
>
>> Hi Mike,
>>
>> I think it is related to this, the libvirt version is really old that
>> lacks the flags:
>>
>> https://github.com/apache/cloudstack/commit/5d29b63cfa98a15d7734798c5b29a43658d7f112
>>
>> If VM migration flag (8) is not available, can you check
>> if VIR_DOMAIN_XML_SECURE (flag=1) works for you, if so we can change the
>> above fix to use 0x1 (or 1) to support KVM/12.04 though I’m not sure if for
>> vm migration the xml dump method should be provided 0x1 and not 0x8
>> (VIR_DOMAIN_XML_MIGRATABLE).
>>
>> On 31-Aug-2015, at 11:29 am, Mike Tutkowski >
>> .com> wrote:
>>
>> Hi,
>>
>> I'm having a problem migrating a VM from one 12.04 KVM host to another
>> 12.04 KVM host in the same cluster in CS 4.6.
>>
>> Anyone know why I might be receiving this error message?
>>
>> invalid argument: virDomainDefFormat: unsupported flags (0x8)
>>
>> The root disk is stored on cluster-scoped NFS primary storage.
>>
>> Thanks!
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the cloud
>> *™*
>>
>>
>> Regards,
>> Rohit Yadav
>> Software Architect, ShapeBlue
>>
>>
>>
>>
>> M. +91 88 262 30892 | rohit.ya...@shapeblue.com
>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>>
>>
>>
>>
>> Find out more about ShapeBlue and our range of CloudStack related services
>>
>> IaaS Cloud Design & Build
>> 
>> CSForge – rapid IaaS deployment framework 
>> CloudStack Consulting 
>> CloudStack Software Engineering
>> 
>> CloudStack Infrastructure Support
>> 
>> CloudStack Bootcamp Training Courses
>> 
>>
>> This email and any attachments to it may be confidential and are intended
>> solely for the use of the individual to whom it is addressed. Any views or
>> opinions expressed are solely those of the author and do not necessarily
>> represent those of Shape Blue Ltd or related companies. If you are not the
>> intended recipient of this email, you must neither take any action based
>> upon its contents, nor copy or show it to anyone. Please contact the sender
>> if you believe you have received this email in error. Shape Blue Ltd is a
>> company incorporated in England & Wales. ShapeBlue Services India LLP is a
>> company incorporated in India and is operated under license from Shape Blue
>> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
>> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
>> a company registered by The Republic of South Africa and is traded under
>> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>>
>
>


Build failed in Jenkins: build-master-slowbuild #2194

2015-08-31 Thread jenkins
See 

--
[...truncated 28153 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.796s]
[INFO] Apache CloudStack . SUCCESS [2.191s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.777s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [20.458s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:14.135s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.111s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [52.772s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [26.516s]
[INFO] Apache CloudStack API . SUCCESS [1:52.558s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.167s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [37.289s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.089s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.125s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.045s]
[INFO] Apache CloudStack Core  SUCCESS [1:15.775s]
[INFO] Apache CloudStack Agents .. SUCCESS [34.202s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [35.406s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [13.616s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:04.997s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.274s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [24.556s]
[INFO] Apache CloudStack Server .. SUCCESS [4:15.042s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.224s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:29.438s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.080s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.453s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [55.990s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.063s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [32.789s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [36.513s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.107s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [22.886s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [38.621s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [13.323s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [5.854s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.700s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.495s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.011s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[34.715s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.897s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [25.135s]
[INFO] Apache CloudStack Plugin - ACL Sta

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
Thanks, everyone

Marcus - Do you think I should put in a version check or is that version of
Libvirt too old to bother supporting?

On Monday, August 31, 2015, Marcus  wrote:

> Looks like the VIR_DOMAIN_XML_MIGRATABLE flag was introduced in v1.0.0
> (version 100 in how the Libvirt API reports), and VIR_DOMAIN_XML_SECURE
> was all the way back in v0.8.0 (version 8000).
>
> On Mon, Aug 31, 2015 at 8:04 AM, Marcus  > wrote:
>
>> There are a bunch of things like this in the code already, and they're
>> wrapped in version checks. See
>>
>> _hypervisorLibvirtVersion in LibvirtComputingResource. We just need to
>> figure out which versions need to be left out.
>>
>>
>>
>>
>> On Mon, Aug 31, 2015 at 1:56 AM, Rohit Yadav > > wrote:
>>
>>> Hi Mike,
>>>
>>> I think it is related to this, the libvirt version is really old that
>>> lacks the flags:
>>>
>>> https://github.com/apache/cloudstack/commit/5d29b63cfa98a15d7734798c5b29a43658d7f112
>>>
>>> If VM migration flag (8) is not available, can you check
>>> if VIR_DOMAIN_XML_SECURE (flag=1) works for you, if so we can change the
>>> above fix to use 0x1 (or 1) to support KVM/12.04 though I’m not sure if for
>>> vm migration the xml dump method should be provided 0x1 and not 0x8
>>> (VIR_DOMAIN_XML_MIGRATABLE).
>>>
>>> On 31-Aug-2015, at 11:29 am, Mike Tutkowski >>
>>> .com> wrote:
>>>
>>> Hi,
>>>
>>> I'm having a problem migrating a VM from one 12.04 KVM host to another
>>> 12.04 KVM host in the same cluster in CS 4.6.
>>>
>>> Anyone know why I might be receiving this error message?
>>>
>>> invalid argument: virDomainDefFormat: unsupported flags (0x8)
>>>
>>> The root disk is stored on cluster-scoped NFS primary storage.
>>>
>>> Thanks!
>>>
>>> --
>>> *Mike Tutkowski*
>>> *Senior CloudStack Developer, SolidFire Inc.*
>>> e: mike.tutkow...@solidfire.com
>>> 
>>> o: 303.746.7302
>>> Advancing the way the world uses the cloud
>>> *™*
>>>
>>>
>>> Regards,
>>> Rohit Yadav
>>> Software Architect, ShapeBlue
>>>
>>>
>>>
>>>
>>> M. +91 88 262 30892 | rohit.ya...@shapeblue.com
>>> 
>>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>>>
>>>
>>>
>>>
>>> Find out more about ShapeBlue and our range of CloudStack related
>>> services
>>>
>>> IaaS Cloud Design & Build
>>> 
>>> CSForge – rapid IaaS deployment framework
>>> 
>>> CloudStack Consulting 
>>> CloudStack Software Engineering
>>> 
>>> CloudStack Infrastructure Support
>>> 
>>> CloudStack Bootcamp Training Courses
>>> 
>>>
>>> This email and any attachments to it may be confidential and are
>>> intended solely for the use of the individual to whom it is addressed. Any
>>> views or opinions expressed are solely those of the author and do not
>>> necessarily represent those of Shape Blue Ltd or related companies. If you
>>> are not the intended recipient of this email, you must neither take any
>>> action based upon its contents, nor copy or show it to anyone. Please
>>> contact the sender if you believe you have received this email in error.
>>> Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>>> Services India LLP is a company incorporated in India and is operated under
>>> license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a
>>> company incorporated in Brasil and is operated under license from Shape
>>> Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of
>>> South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is
>>> a registered trademark.
>>>
>>
>>
>

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-31 Thread Daan Hoogland
As David says; Though I think it is very polite of you to wait and ask
around, you have this right if you can show master doesn't work.

On Mon, Aug 31, 2015 at 6:06 PM, David Nalley  wrote:

> On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das 
> wrote:
> > I am no longer able to start MS after this. I did a clean build followed
> by starting MS. Did travis pass for it? Should we revert?
> >
>
> Yes, and in general, when things break you should feel empowered to
> revert (still send a note to the list, but as a committer, you have a
> binding veto at your disposal - feel free to make use of it to keep
> quality high.)
>
> --David
>



-- 
Daan


Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Marcus
Might as well put the check in, to ensure we don't try to use flags that
aren't available.

On Mon, Aug 31, 2015 at 10:21 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Thanks, everyone
>
> Marcus - Do you think I should put in a version check or is that version of
> Libvirt too old to bother supporting?
>
> On Monday, August 31, 2015, Marcus  wrote:
>
> > Looks like the VIR_DOMAIN_XML_MIGRATABLE flag was introduced in v1.0.0
> > (version 100 in how the Libvirt API reports), and
> VIR_DOMAIN_XML_SECURE
> > was all the way back in v0.8.0 (version 8000).
> >
> > On Mon, Aug 31, 2015 at 8:04 AM, Marcus  > > wrote:
> >
> >> There are a bunch of things like this in the code already, and they're
> >> wrapped in version checks. See
> >>
> >> _hypervisorLibvirtVersion in LibvirtComputingResource. We just need to
> >> figure out which versions need to be left out.
> >>
> >>
> >>
> >>
> >> On Mon, Aug 31, 2015 at 1:56 AM, Rohit Yadav  >> > wrote:
> >>
> >>> Hi Mike,
> >>>
> >>> I think it is related to this, the libvirt version is really old that
> >>> lacks the flags:
> >>>
> >>>
> https://github.com/apache/cloudstack/commit/5d29b63cfa98a15d7734798c5b29a43658d7f112
> >>>
> >>> If VM migration flag (8) is not available, can you check
> >>> if VIR_DOMAIN_XML_SECURE (flag=1) works for you, if so we can change
> the
> >>> above fix to use 0x1 (or 1) to support KVM/12.04 though I’m not sure
> if for
> >>> vm migration the xml dump method should be provided 0x1 and not 0x8
> >>> (VIR_DOMAIN_XML_MIGRATABLE).
> >>>
> >>> On 31-Aug-2015, at 11:29 am, Mike Tutkowski  >>>
> >>> .com> wrote:
> >>>
> >>> Hi,
> >>>
> >>> I'm having a problem migrating a VM from one 12.04 KVM host to another
> >>> 12.04 KVM host in the same cluster in CS 4.6.
> >>>
> >>> Anyone know why I might be receiving this error message?
> >>>
> >>> invalid argument: virDomainDefFormat: unsupported flags (0x8)
> >>>
> >>> The root disk is stored on cluster-scoped NFS primary storage.
> >>>
> >>> Thanks!
> >>>
> >>> --
> >>> *Mike Tutkowski*
> >>> *Senior CloudStack Developer, SolidFire Inc.*
> >>> e: mike.tutkow...@solidfire.com
> >>> 
> >>> o: 303.746.7302
> >>> Advancing the way the world uses the cloud
> >>> *™*
> >>>
> >>>
> >>> Regards,
> >>> Rohit Yadav
> >>> Software Architect, ShapeBlue
> >>>
> >>>
> >>>
> >>>
> >>> M. +91 88 262 30892 | rohit.ya...@shapeblue.com
> >>> 
> >>> Blog: bhaisaab.org | Twitter: @_bhaisaab
> >>>
> >>>
> >>>
> >>>
> >>> Find out more about ShapeBlue and our range of CloudStack related
> >>> services
> >>>
> >>> IaaS Cloud Design & Build
> >>> 
> >>> CSForge – rapid IaaS deployment framework
> >>> 
> >>> CloudStack Consulting 
> >>> CloudStack Software Engineering
> >>> 
> >>> CloudStack Infrastructure Support
> >>> 
> >>> CloudStack Bootcamp Training Courses
> >>> 
> >>>
> >>> This email and any attachments to it may be confidential and are
> >>> intended solely for the use of the individual to whom it is addressed.
> Any
> >>> views or opinions expressed are solely those of the author and do not
> >>> necessarily represent those of Shape Blue Ltd or related companies. If
> you
> >>> are not the intended recipient of this email, you must neither take any
> >>> action based upon its contents, nor copy or show it to anyone. Please
> >>> contact the sender if you believe you have received this email in
> error.
> >>> Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
> >>> Services India LLP is a company incorporated in India and is operated
> under
> >>> license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a
> >>> company incorporated in Brasil and is operated under license from Shape
> >>> Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic
> of
> >>> South Africa and is traded under license from Shape Blue Ltd.
> ShapeBlue is
> >>> a registered trademark.
> >>>
> >>
> >>
> >
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>


[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...

2015-08-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/756#issuecomment-136449843
  
@wilderrodrigues I agree. @nlivens maybe a conditional display can be 
concocted. I suppose you made this because the dropdown was hindering your 
eyesight..?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...

2015-08-31 Thread kmccormick
GitHub user kmccormick opened a pull request:

https://github.com/apache/cloudstack/pull/766

CLOUDSTACK-8678: Reserve RAM for KVM host OS

Use host.reserved.ram.mb agent property to modify total system RAM
before reporting to management server.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kmccormick/cloudstack CLOUDSTACK-8678

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/766.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #766


commit 414136637e2fd115c781e3b3d6c8d83f40191b31
Author: Kevin McCormick 
Date:   2015-08-31T18:11:17Z

CLOUDSTACK-8678: Reserve RAM for KVM host OS

Use host.reserved.ram.mb agent property to modify total system RAM
before reporting to management server.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: Discuss reserving memory on KVM hypervisors ref: CLOUDSTACK-8678

2015-08-31 Thread Kevin McCormick
I've submitted a pull request here: 
https://github.com/apache/cloudstack/pull/766.

Basically just does a totalRAM - host.reserved.mem.mb before reporting total 
RAM to the management server.

Remi, if you can test, that would be great. We can get it done later this week, 
but we don't have automation setup for testing, etc.



Kevin McCormick
Director of Cloud Services

Intrinium
-Original Message-
From: Remi Bergsma [mailto:rberg...@schubergphilis.com]
Sent: Friday, August 28, 2015 23:41
To:  
Subject: Re: Discuss reserving memory on KVM hypervisors ref: CLOUDSTACK-8678

Making the agent property work (host.reserved.mem.mb) would be awesome! On labs 
you can then set it to something low.

Let me know if you need help with testing!

Thanks, Remi

Sent from my iPhone

> On 29 Aug 2015, at 07:49, Erik Weber  wrote:
>
> Make it configurable to enable/disable the check? Or even the size.
>
> For labs etc you might not have or want that much to spare.
>
>
> Erik
>
> Den lørdag 29. august 2015 skrev Josh Harshman 
> følgende:
>
>> Wido -
>> Looks like the problem resides in the logic that does the detection of the
>> host resources.  It looks like most, if not all, the KVM host detection
>> occurs in the LibvirtComputingResource class.  Here I can modify it so it
>> will take the value stored in dom0MinMem into account when calculating the
>> ram available.
>>
>> I've forked the repo and am working on a fix.
>> Does anyone have anything to add?  Suggestions?
>>
>> 
>> From: Wido den Hollander >
>> Sent: Friday, August 28, 2015 12:38 AM
>> To: dev@cloudstack.apache.org 
>> Subject: Re: Discuss reserving memory on KVM hypervisors ref:
>> CLOUDSTACK-8678
>>
>>
>>
>> Josh Harshman
>> Cloud Engineer
>>
>> Intrinium
>>
>>> On 27-08-15 18:36, Josh Harshman wrote:
>>> In a KVM cluster, CloudStack sees 100% of the compute node's RAM and
>> treats it as allocatable space which eventually leads to OOM killing guests.
>>>
>>>
>>> There is an agent property named host.reserved.mem.mb which is able to
>> be set in the agent.properties file and passed to the management server.
>> This value is stored as dom0MinMem, however, it appears to be ignored.
>>>
>>>
>>> If we could tweak the host capacity calculation and have it take this
>> into account, I believe that would be ideal.
>>>
>>>
>>> Side note: the variable dom0MinMem is declared as an int and can be
>> overflowed. Suggested change would be make it a long and add a check
>> especially if we are going to make this a configurable parameter.
>>
>> Yes, that seems like a sane thing to do. We should be able to say that
>> eg 8GB of memory should stay available for the HV.
>>
>> Don't know where the problem lies though. A PR is welcome :)
>>
>> Wido
>>
>>>
>>>
>>> Josh Harshman
>>>
>>> Cloud Engineer
>>>
>>>
>>> Intrinium
>>> Tel: (509) 465-1234 x5259
>>> Fax: (866) 565-4578
>>> Lync / Skype: josh.harsh...@intrinium.com 
>>> Web: http://intrinium.com
>>>
>>>
>>> [Intrinium Long Sig Logo]
>>>
>>>
>>> [Facebook]
>> [Twitter]   [Linkedin] <
>> http://www.linkedin.com/company/intrinium_networks_it_security?trk=fc_badge>
>> [Youtube]  [Blog] <
>> http://intrinium.com/blog/>
>>>
>>> Information Security and Compliance Consulting | Managed IT and Security
>> Services | Cloud Services
>>>
>>>
>>>
>>>
>>>
>>> 
>>>
>>> This email and any files transmitted with it are confidential and
>> intended solely for the use of the individual or entity to whom they are
>> addressed. If you have received this email in error please notify the
>> system manager. This message contains confidential information and is
>> intended only for the individual named. If you are not the named addressee
>> you should not disseminate, distribute or copy this e-mail. Please notify
>> the sender immediately by e-mail if you have received this e-mail by
>> mistake and delete this e-mail from your system. If you are not the
>> intended recipient you are notified that disclosing, copying, distributing
>> or taking any action in reliance on the contents of this information is
>> strictly prohibited.
>>


Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
Sounds good

Does this look reasonable (I haven't tested it yet):

CVE-2015-3252: Get XML with sensitive information suitable
for migration by using

   VIR_DOMAIN_XML_MIGRATABLE flag (value = 8)


https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainXMLFlags


   Use VIR_DOMAIN_XML_SECURE (value = 1) prior
to v1.0.0.

 */

if (conn.getLibVirVersion() >= 100) { // 100 equals
v1.0.0

xmlDesc =
dm.getXMLDesc(8).replace(libvirtComputingResource.getPrivateIp(),
command.getDestinationIp());

}

else {

xmlDesc =
dm.getXMLDesc(1).replace(libvirtComputingResource.getPrivateIp(),
command.getDestinationIp());

}

On Mon, Aug 31, 2015 at 12:06 PM, Marcus  wrote:

> Might as well put the check in, to ensure we don't try to use flags that
> aren't available.
>
> On Mon, Aug 31, 2015 at 10:21 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
> > Thanks, everyone
> >
> > Marcus - Do you think I should put in a version check or is that version
> of
> > Libvirt too old to bother supporting?
> >
> > On Monday, August 31, 2015, Marcus  wrote:
> >
> > > Looks like the VIR_DOMAIN_XML_MIGRATABLE flag was introduced in v1.0.0
> > > (version 100 in how the Libvirt API reports), and
> > VIR_DOMAIN_XML_SECURE
> > > was all the way back in v0.8.0 (version 8000).
> > >
> > > On Mon, Aug 31, 2015 at 8:04 AM, Marcus  > > > wrote:
> > >
> > >> There are a bunch of things like this in the code already, and they're
> > >> wrapped in version checks. See
> > >>
> > >> _hypervisorLibvirtVersion in LibvirtComputingResource. We just need to
> > >> figure out which versions need to be left out.
> > >>
> > >>
> > >>
> > >>
> > >> On Mon, Aug 31, 2015 at 1:56 AM, Rohit Yadav <
> rohit.ya...@shapeblue.com
> > >> > wrote:
> > >>
> > >>> Hi Mike,
> > >>>
> > >>> I think it is related to this, the libvirt version is really old that
> > >>> lacks the flags:
> > >>>
> > >>>
> >
> https://github.com/apache/cloudstack/commit/5d29b63cfa98a15d7734798c5b29a43658d7f112
> > >>>
> > >>> If VM migration flag (8) is not available, can you check
> > >>> if VIR_DOMAIN_XML_SECURE (flag=1) works for you, if so we can change
> > the
> > >>> above fix to use 0x1 (or 1) to support KVM/12.04 though I’m not sure
> > if for
> > >>> vm migration the xml dump method should be provided 0x1 and not 0x8
> > >>> (VIR_DOMAIN_XML_MIGRATABLE).
> > >>>
> > >>> On 31-Aug-2015, at 11:29 am, Mike Tutkowski  > >>>
> > >>> .com> wrote:
> > >>>
> > >>> Hi,
> > >>>
> > >>> I'm having a problem migrating a VM from one 12.04 KVM host to
> another
> > >>> 12.04 KVM host in the same cluster in CS 4.6.
> > >>>
> > >>> Anyone know why I might be receiving this error message?
> > >>>
> > >>> invalid argument: virDomainDefFormat: unsupported flags (0x8)
> > >>>
> > >>> The root disk is stored on cluster-scoped NFS primary storage.
> > >>>
> > >>> Thanks!
> > >>>
> > >>> --
> > >>> *Mike Tutkowski*
> > >>> *Senior CloudStack Developer, SolidFire Inc.*
> > >>> e: mike.tutkow...@solidfire.com
> > >>> 
> > >>> o: 303.746.7302
> > >>> Advancing the way the world uses the cloud
> > >>> *™*
> > >>>
> > >>>
> > >>> Regards,
> > >>> Rohit Yadav
> > >>> Software Architect, ShapeBlue
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> M. +91 88 262 30892 | rohit.ya...@shapeblue.com
> > >>> 
> > >>> Blog: bhaisaab.org | Twitter: @_bhaisaab
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> Find out more about ShapeBlue and our range of CloudStack related
> > >>> services
> > >>>
> > >>> IaaS Cloud Design & Build
> > >>> 
> > >>> CSForge – rapid IaaS deployment framework
> > >>> 
> > >>> CloudStack Consulting 
> > >>> CloudStack Software Engineering
> > >>> 
> > >>> CloudStack Infrastructure Support
> > >>> 
> > >>> CloudStack Bootcamp Training Courses
> > >>> 
> > >>>
> > >>> This email and any attachments to it may be confidential and are
> > >>> intended solely for the use of the individual to whom it is
> addressed.
> > Any
> > >>> views or opinions expressed are solely those of the author and do not
> > >>> necessarily represent those of Shape Blue Ltd or related companies.
> If
> > you
> > >>> are not the intended recipient of this email, you must neither take
> any
> > >>> action based upon its contents, nor copy or show it to anyone. Please
> > >>> contact the sender if you believe you have received this email in
> > error.
> > >>> Shape Blue Ltd is a company incorporated in England & Wales.
> ShapeBlue
> > >>> Services India LLP is a company incorporated in India and is operated
> > under
> > >>> li

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
This is probably more esthetically pleasing to most people (and simpler
looking):

CVE-2015-3252: Get XML with sensitive information suitable
for migration by using

   VIR_DOMAIN_XML_MIGRATABLE flag (value = 8)


https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainXMLFlags


   Use VIR_DOMAIN_XML_SECURE (value = 1) prior
to v1.0.0.

 */

int xmlFlag = conn.getLibVirVersion() >= 100 ? 8 : 1;


xmlDesc =
dm.getXMLDesc(xmlFlag).replace(libvirtComputingResource.getPrivateIp(),
command.getDestinationIp());

On Mon, Aug 31, 2015 at 12:34 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Sounds good
>
> Does this look reasonable (I haven't tested it yet):
>
> CVE-2015-3252: Get XML with sensitive information suitable
> for migration by using
>
>VIR_DOMAIN_XML_MIGRATABLE flag (value = 8)
>
>
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainXMLFlags
>
>
>Use VIR_DOMAIN_XML_SECURE (value = 1) prior
> to v1.0.0.
>
>  */
>
> if (conn.getLibVirVersion() >= 100) { // 100 equals
> v1.0.0
>
> xmlDesc =
> dm.getXMLDesc(8).replace(libvirtComputingResource.getPrivateIp(),
> command.getDestinationIp());
>
> }
>
> else {
>
> xmlDesc =
> dm.getXMLDesc(1).replace(libvirtComputingResource.getPrivateIp(),
> command.getDestinationIp());
>
> }
>
> On Mon, Aug 31, 2015 at 12:06 PM, Marcus  wrote:
>
>> Might as well put the check in, to ensure we don't try to use flags that
>> aren't available.
>>
>> On Mon, Aug 31, 2015 at 10:21 AM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>> > Thanks, everyone
>> >
>> > Marcus - Do you think I should put in a version check or is that
>> version of
>> > Libvirt too old to bother supporting?
>> >
>> > On Monday, August 31, 2015, Marcus  wrote:
>> >
>> > > Looks like the VIR_DOMAIN_XML_MIGRATABLE flag was introduced in v1.0.0
>> > > (version 100 in how the Libvirt API reports), and
>> > VIR_DOMAIN_XML_SECURE
>> > > was all the way back in v0.8.0 (version 8000).
>> > >
>> > > On Mon, Aug 31, 2015 at 8:04 AM, Marcus > > > > wrote:
>> > >
>> > >> There are a bunch of things like this in the code already, and
>> they're
>> > >> wrapped in version checks. See
>> > >>
>> > >> _hypervisorLibvirtVersion in LibvirtComputingResource. We just need
>> to
>> > >> figure out which versions need to be left out.
>> > >>
>> > >>
>> > >>
>> > >>
>> > >> On Mon, Aug 31, 2015 at 1:56 AM, Rohit Yadav <
>> rohit.ya...@shapeblue.com
>> > >> > wrote:
>> > >>
>> > >>> Hi Mike,
>> > >>>
>> > >>> I think it is related to this, the libvirt version is really old
>> that
>> > >>> lacks the flags:
>> > >>>
>> > >>>
>> >
>> https://github.com/apache/cloudstack/commit/5d29b63cfa98a15d7734798c5b29a43658d7f112
>> > >>>
>> > >>> If VM migration flag (8) is not available, can you check
>> > >>> if VIR_DOMAIN_XML_SECURE (flag=1) works for you, if so we can change
>> > the
>> > >>> above fix to use 0x1 (or 1) to support KVM/12.04 though I’m not sure
>> > if for
>> > >>> vm migration the xml dump method should be provided 0x1 and not 0x8
>> > >>> (VIR_DOMAIN_XML_MIGRATABLE).
>> > >>>
>> > >>> On 31-Aug-2015, at 11:29 am, Mike Tutkowski
>> > > >>>
>> > >>> .com> wrote:
>> > >>>
>> > >>> Hi,
>> > >>>
>> > >>> I'm having a problem migrating a VM from one 12.04 KVM host to
>> another
>> > >>> 12.04 KVM host in the same cluster in CS 4.6.
>> > >>>
>> > >>> Anyone know why I might be receiving this error message?
>> > >>>
>> > >>> invalid argument: virDomainDefFormat: unsupported flags (0x8)
>> > >>>
>> > >>> The root disk is stored on cluster-scoped NFS primary storage.
>> > >>>
>> > >>> Thanks!
>> > >>>
>> > >>> --
>> > >>> *Mike Tutkowski*
>> > >>> *Senior CloudStack Developer, SolidFire Inc.*
>> > >>> e: mike.tutkow...@solidfire.com
>> > >>> 
>> > >>> o: 303.746.7302
>> > >>> Advancing the way the world uses the cloud
>> > >>> *™*
>> > >>>
>> > >>>
>> > >>> Regards,
>> > >>> Rohit Yadav
>> > >>> Software Architect, ShapeBlue
>> > >>>
>> > >>>
>> > >>>
>> > >>>
>> > >>> M. +91 88 262 30892 | rohit.ya...@shapeblue.com
>> > >>> 
>> > >>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>> > >>>
>> > >>>
>> > >>>
>> > >>>
>> > >>> Find out more about ShapeBlue and our range of CloudStack related
>> > >>> services
>> > >>>
>> > >>> IaaS Cloud Design & Build
>> > >>> 
>> > >>> CSForge – rapid IaaS deployment framework
>> > >>> 
>> > >>> CloudStack Consulting > >
>> > >>> CloudStack Software Engineering
>> > >>> 
>> > >>> CloudStack Infrastructure Support
>> > >>> 

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
I see a test was failing: LibvirtComputingResourceTest.testMigrateCommand.

I'm not sure if you can do an "or" with Mockito, but I changed a check to
the following and it passes now (it was failing because a 1 was being
passed in now instead of an 8 on my platform):

try {

verify(dm, times(1)).getXMLDesc(8);

} catch (final Throwable t) {

try {

verify(dm, times(1)).getXMLDesc(1);

}

catch (final LibvirtException e) {

fail(e.getMessage());

}

}

On Mon, Aug 31, 2015 at 12:38 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> This is probably more esthetically pleasing to most people (and simpler
> looking):
>
> CVE-2015-3252: Get XML with sensitive information suitable
> for migration by using
>
>VIR_DOMAIN_XML_MIGRATABLE flag (value = 8)
>
>
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainXMLFlags
>
>
>Use VIR_DOMAIN_XML_SECURE (value = 1) prior
> to v1.0.0.
>
>  */
>
> int xmlFlag = conn.getLibVirVersion() >= 100 ? 8 : 1;
>
>
> xmlDesc =
> dm.getXMLDesc(xmlFlag).replace(libvirtComputingResource.getPrivateIp(),
> command.getDestinationIp());
>
> On Mon, Aug 31, 2015 at 12:34 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Sounds good
>>
>> Does this look reasonable (I haven't tested it yet):
>>
>> CVE-2015-3252: Get XML with sensitive information
>> suitable for migration by using
>>
>>VIR_DOMAIN_XML_MIGRATABLE flag (value = 8)
>>
>>
>> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainXMLFlags
>>
>>
>>Use VIR_DOMAIN_XML_SECURE (value = 1)
>> prior to v1.0.0.
>>
>>  */
>>
>> if (conn.getLibVirVersion() >= 100) { // 100 equals
>> v1.0.0
>>
>> xmlDesc =
>> dm.getXMLDesc(8).replace(libvirtComputingResource.getPrivateIp(),
>> command.getDestinationIp());
>>
>> }
>>
>> else {
>>
>> xmlDesc =
>> dm.getXMLDesc(1).replace(libvirtComputingResource.getPrivateIp(),
>> command.getDestinationIp());
>>
>> }
>>
>> On Mon, Aug 31, 2015 at 12:06 PM, Marcus  wrote:
>>
>>> Might as well put the check in, to ensure we don't try to use flags that
>>> aren't available.
>>>
>>> On Mon, Aug 31, 2015 at 10:21 AM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
>>> > Thanks, everyone
>>> >
>>> > Marcus - Do you think I should put in a version check or is that
>>> version of
>>> > Libvirt too old to bother supporting?
>>> >
>>> > On Monday, August 31, 2015, Marcus  wrote:
>>> >
>>> > > Looks like the VIR_DOMAIN_XML_MIGRATABLE flag was introduced in
>>> v1.0.0
>>> > > (version 100 in how the Libvirt API reports), and
>>> > VIR_DOMAIN_XML_SECURE
>>> > > was all the way back in v0.8.0 (version 8000).
>>> > >
>>> > > On Mon, Aug 31, 2015 at 8:04 AM, Marcus >> > > > wrote:
>>> > >
>>> > >> There are a bunch of things like this in the code already, and
>>> they're
>>> > >> wrapped in version checks. See
>>> > >>
>>> > >> _hypervisorLibvirtVersion in LibvirtComputingResource. We just need
>>> to
>>> > >> figure out which versions need to be left out.
>>> > >>
>>> > >>
>>> > >>
>>> > >>
>>> > >> On Mon, Aug 31, 2015 at 1:56 AM, Rohit Yadav <
>>> rohit.ya...@shapeblue.com
>>> > >> > wrote:
>>> > >>
>>> > >>> Hi Mike,
>>> > >>>
>>> > >>> I think it is related to this, the libvirt version is really old
>>> that
>>> > >>> lacks the flags:
>>> > >>>
>>> > >>>
>>> >
>>> https://github.com/apache/cloudstack/commit/5d29b63cfa98a15d7734798c5b29a43658d7f112
>>> > >>>
>>> > >>> If VM migration flag (8) is not available, can you check
>>> > >>> if VIR_DOMAIN_XML_SECURE (flag=1) works for you, if so we can
>>> change
>>> > the
>>> > >>> above fix to use 0x1 (or 1) to support KVM/12.04 though I’m not
>>> sure
>>> > if for
>>> > >>> vm migration the xml dump method should be provided 0x1 and not 0x8
>>> > >>> (VIR_DOMAIN_XML_MIGRATABLE).
>>> > >>>
>>> > >>> On 31-Aug-2015, at 11:29 am, Mike Tutkowski
>>> >> > >>>
>>> > >>> .com> wrote:
>>> > >>>
>>> > >>> Hi,
>>> > >>>
>>> > >>> I'm having a problem migrating a VM from one 12.04 KVM host to
>>> another
>>> > >>> 12.04 KVM host in the same cluster in CS 4.6.
>>> > >>>
>>> > >>> Anyone know why I might be receiving this error message?
>>> > >>>
>>> > >>> invalid argument: virDomainDefFormat: unsupported flags (0x8)
>>> > >>>
>>> > >>> The root disk is stored on cluster-scoped NFS primary storage.
>>> > >>>
>>> > >>> Thanks!
>>> > >>>
>>> > >>> --
>>> > >>> *Mike Tutkowski*
>>> > >>> *Senior CloudStack Developer, SolidFire Inc.*
>>> > >>> e: mike.tutkow...@solidfire.com
>>> > >>> 
>>> > >>> o: 303.746.7302
>>> > >>> Advancing the way the world uses the cloud
>>> > >>> *™*

Build failed in Jenkins: build-master-slowbuild #2195

2015-08-31 Thread jenkins
See 

--
[...truncated 28153 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.813s]
[INFO] Apache CloudStack . SUCCESS [3.368s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [1.304s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [21.203s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:15.399s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.108s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [51.585s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.674s]
[INFO] Apache CloudStack API . SUCCESS [1:48.932s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.596s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.134s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.088s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.517s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [26.012s]
[INFO] Apache CloudStack Core  SUCCESS [1:17.567s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.154s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [35.450s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [13.832s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:12.008s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [47.375s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [30.632s]
[INFO] Apache CloudStack Server .. SUCCESS [4:26.309s]
[INFO] Apache CloudStack Usage Server  SUCCESS [51.324s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:32.191s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.083s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.435s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [1:04.645s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [54.552s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [31.428s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.694s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [24.112s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.249s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [34.602s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.335s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [5.858s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.711s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [1:21.857s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[3:29.304s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[1:23.030s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [20.503s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [30.556s]
[INFO] Apache CloudStack Plugin -

Re: [DISCUSS] Let's fix CloudStack Upgrades and DB migrations with CloudStack Chimp

2015-08-31 Thread David Nalley
On Sat, Aug 29, 2015 at 4:27 AM, Wido den Hollander  wrote:
>
>
> On 08/28/2015 07:16 PM, David Nalley wrote:
>> I REALLY like the idea. I wish we could gut the existing upgrade process
>> and replace it wholesale.
>> However, I'd urge us to use some existing tool as the foundation (while
>> there links in the wiki page, it wasn't clear to me that this was assured),
>> something open source that lots of other folks are also using means we can
>> leverage it, without having to write it ourselves.
>>
>
> Yes, if that's possible it would be great. Don't try to re-invent the wheel.
>
> I don't know if any of those projects in Java exist though.
>

Flyway and Migrate4j are at least two that I know of.

--David


Re: [DISCUSS] Let's fix CloudStack Upgrades and DB migrations with CloudStack Chimp

2015-08-31 Thread Rene Moser
+1!

On 08/28/2015 08:51 AM, Rohit Yadav wrote:
> Hi all,
> 
> Some of us have discussed in the past on fixing CloudStack’s upgrade and
> DB migration, I’m trying to explore if we can really fix this. Please
> review, advise changes, add suggestions along with your upgrade
> experience so we can improve this in near future starting with ACS 4.7
> or above:
> 
> http://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Chimp
> (note: this wiki will keep changing depending on the discussions and
> feedback)


Build failed in Jenkins: build-master-slowbuild #2196

2015-08-31 Thread jenkins
See 

--
[...truncated 28153 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.767s]
[INFO] Apache CloudStack . SUCCESS [2.303s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.789s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.458s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:20.011s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.119s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [52.974s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [26.814s]
[INFO] Apache CloudStack API . SUCCESS [1:49.337s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [19.671s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [32.807s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.087s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.054s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.254s]
[INFO] Apache CloudStack Core  SUCCESS [1:17.502s]
[INFO] Apache CloudStack Agents .. SUCCESS [40.706s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [35.490s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [13.759s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:02.230s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.936s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [24.557s]
[INFO] Apache CloudStack Server .. SUCCESS [4:09.480s]
[INFO] Apache CloudStack Usage Server  SUCCESS [45.415s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:28.679s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.073s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.437s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [58.555s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.975s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.532s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [25.972s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [22.144s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [23.343s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.251s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [11.629s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [5.720s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.733s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.171s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.553s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.084s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.040s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.093s]
[INFO] Apache CloudStack Plugin - ACL Sta

[GitHub] cloudstack-www pull request: update download URL

2015-08-31 Thread pdion891
GitHub user pdion891 opened a pull request:

https://github.com/apache/cloudstack-www/pull/15

update download URL

Update download URL because of change on apache servers.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdion891/cloudstack-www download

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-www/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 51b4b065a4d731e26517d7a1d824a0b380101b86
Author: pdion891 
Date:   2015-09-01T00:40:15Z

update download URL




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www pull request: update download URL

2015-08-31 Thread pdion891
Github user pdion891 closed the pull request at:

https://github.com/apache/cloudstack-www/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-www pull request: update download URL

2015-08-31 Thread pdion891
Github user pdion891 commented on the pull request:

https://github.com/apache/cloudstack-www/pull/15#issuecomment-136538156
  
Will do directly as the site is impacted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
OK, just an FYI that the version-checking code I put in based on Marcus'
comments worked. I can now live migrate the VM.

I plan to open a PR for this later tonight.

On Mon, Aug 31, 2015 at 1:49 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> I see a test was failing: LibvirtComputingResourceTest.testMigrateCommand.
>
> I'm not sure if you can do an "or" with Mockito, but I changed a check to
> the following and it passes now (it was failing because a 1 was being
> passed in now instead of an 8 on my platform):
>
> try {
>
> verify(dm, times(1)).getXMLDesc(8);
>
> } catch (final Throwable t) {
>
> try {
>
> verify(dm, times(1)).getXMLDesc(1);
>
> }
>
> catch (final LibvirtException e) {
>
> fail(e.getMessage());
>
> }
>
> }
>
> On Mon, Aug 31, 2015 at 12:38 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> This is probably more esthetically pleasing to most people (and simpler
>> looking):
>>
>> CVE-2015-3252: Get XML with sensitive information
>> suitable for migration by using
>>
>>VIR_DOMAIN_XML_MIGRATABLE flag (value = 8)
>>
>>
>> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainXMLFlags
>>
>>
>>Use VIR_DOMAIN_XML_SECURE (value = 1)
>> prior to v1.0.0.
>>
>>  */
>>
>> int xmlFlag = conn.getLibVirVersion() >= 100 ? 8 : 1;
>>
>>
>> xmlDesc =
>> dm.getXMLDesc(xmlFlag).replace(libvirtComputingResource.getPrivateIp(),
>> command.getDestinationIp());
>>
>> On Mon, Aug 31, 2015 at 12:34 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> Sounds good
>>>
>>> Does this look reasonable (I haven't tested it yet):
>>>
>>> CVE-2015-3252: Get XML with sensitive information
>>> suitable for migration by using
>>>
>>>VIR_DOMAIN_XML_MIGRATABLE flag (value = 8)
>>>
>>>
>>> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainXMLFlags
>>>
>>>
>>>Use VIR_DOMAIN_XML_SECURE (value = 1)
>>> prior to v1.0.0.
>>>
>>>  */
>>>
>>> if (conn.getLibVirVersion() >= 100) { // 100 equals
>>> v1.0.0
>>>
>>> xmlDesc =
>>> dm.getXMLDesc(8).replace(libvirtComputingResource.getPrivateIp(),
>>> command.getDestinationIp());
>>>
>>> }
>>>
>>> else {
>>>
>>> xmlDesc =
>>> dm.getXMLDesc(1).replace(libvirtComputingResource.getPrivateIp(),
>>> command.getDestinationIp());
>>>
>>> }
>>>
>>> On Mon, Aug 31, 2015 at 12:06 PM, Marcus  wrote:
>>>
 Might as well put the check in, to ensure we don't try to use flags that
 aren't available.

 On Mon, Aug 31, 2015 at 10:21 AM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:

 > Thanks, everyone
 >
 > Marcus - Do you think I should put in a version check or is that
 version of
 > Libvirt too old to bother supporting?
 >
 > On Monday, August 31, 2015, Marcus  wrote:
 >
 > > Looks like the VIR_DOMAIN_XML_MIGRATABLE flag was introduced in
 v1.0.0
 > > (version 100 in how the Libvirt API reports), and
 > VIR_DOMAIN_XML_SECURE
 > > was all the way back in v0.8.0 (version 8000).
 > >
 > > On Mon, Aug 31, 2015 at 8:04 AM, Marcus >>> > > > wrote:
 > >
 > >> There are a bunch of things like this in the code already, and
 they're
 > >> wrapped in version checks. See
 > >>
 > >> _hypervisorLibvirtVersion in LibvirtComputingResource. We just
 need to
 > >> figure out which versions need to be left out.
 > >>
 > >>
 > >>
 > >>
 > >> On Mon, Aug 31, 2015 at 1:56 AM, Rohit Yadav <
 rohit.ya...@shapeblue.com
 > >> >
 wrote:
 > >>
 > >>> Hi Mike,
 > >>>
 > >>> I think it is related to this, the libvirt version is really old
 that
 > >>> lacks the flags:
 > >>>
 > >>>
 >
 https://github.com/apache/cloudstack/commit/5d29b63cfa98a15d7734798c5b29a43658d7f112
 > >>>
 > >>> If VM migration flag (8) is not available, can you check
 > >>> if VIR_DOMAIN_XML_SECURE (flag=1) works for you, if so we can
 change
 > the
 > >>> above fix to use 0x1 (or 1) to support KVM/12.04 though I’m not
 sure
 > if for
 > >>> vm migration the xml dump method should be provided 0x1 and not
 0x8
 > >>> (VIR_DOMAIN_XML_MIGRATABLE).
 > >>>
 > >>> On 31-Aug-2015, at 11:29 am, Mike Tutkowski
 >>> > >>>
 > >>> .com> wrote:
 > >>>
 > >>> Hi,
 > >>>
 > >>> I'm having a problem migrating a VM from one 12.04 KVM host to
 another
 > >>> 12.04 KVM host in the same cluster in CS 4.6.
 > >>>
 > >>> Anyone know why I might be receiving this error message?
 > >>>
 > >>> invalid argument: virDomainDef

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-31 Thread Mike Tutkowski
What do we think, though, about tickets listed as Minor going in at this
point in 4.6 development?

If they entail a trivial change in only a file or two, it's probably OK,
but where should we draw the line?

At some point as the release goes on, we should stop accepting PRs that are
tied to Minor tickets and only allow churn in that branch for more major
issues. Those PRs tied to Minor tickets can then be for the next release.

Thoughts?

On Mon, Aug 31, 2015 at 12:03 PM, Daan Hoogland 
wrote:

> As David says; Though I think it is very polite of you to wait and ask
> around, you have this right if you can show master doesn't work.
>
> On Mon, Aug 31, 2015 at 6:06 PM, David Nalley  wrote:
>
> > On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das 
> > wrote:
> > > I am no longer able to start MS after this. I did a clean build
> followed
> > by starting MS. Did travis pass for it? Should we revert?
> > >
> >
> > Yes, and in general, when things break you should feel empowered to
> > revert (still send a note to the list, but as a committer, you have a
> > binding veto at your disposal - feel free to make use of it to keep
> > quality high.)
> >
> > --David
> >
>
>
>
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Build failed in Jenkins: build-master-slowbuild #2197

2015-08-31 Thread jenkins
See 

--
[...truncated 28153 lines...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.815s]
[INFO] Apache CloudStack . SUCCESS [2.052s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.771s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.670s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:14.632s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.135s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.028s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.365s]
[INFO] Apache CloudStack API . SUCCESS [1:50.992s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [15.885s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.151s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.097s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.411s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.544s]
[INFO] Apache CloudStack Core  SUCCESS [1:14.531s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.351s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [35.766s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.464s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:11.530s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [45.419s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [31.700s]
[INFO] Apache CloudStack Server .. SUCCESS [4:27.837s]
[INFO] Apache CloudStack Usage Server  SUCCESS [50.262s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:33.168s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.109s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.489s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [1:00.843s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [57.456s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [34.654s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.426s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [24.112s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.790s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [36.144s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.301s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [6.758s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.903s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [49.487s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[3:38.253s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[1:56.727s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [19.857s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [31.718s]
[INFO] Apache CloudStack Plugin - A

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38383968
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import javax.inject.Inject;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.AccountService;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import com.cloud.user.Account;
+
+import java.util.UUID;
+
+@APICommand(name = "linkDomainToLdap", description = "link an existing 
cloudstack domain to group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.6.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkDomainToLdapCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(LinkDomainToLdapCmd.class.getName());
+private static final String s_name = "linkdomaintoldapresponse";
+
+@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class, description = "The id of the domain which 
has to be linked to LDAP.")
--- End diff --

yes it should be. will change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38383999
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import javax.inject.Inject;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.AccountService;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import com.cloud.user.Account;
+
+import java.util.UUID;
+
+@APICommand(name = "linkDomainToLdap", description = "link an existing 
cloudstack domain to group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.6.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkDomainToLdapCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(LinkDomainToLdapCmd.class.getName());
+private static final String s_name = "linkdomaintoldapresponse";
+
+@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class, description = "The id of the domain which 
has to be linked to LDAP.")
+private Long domainId;
+
+@Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, 
required = true, description = "type of the ldap name. GROUP or OU")
+private String type;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+private String name;
+
+@Parameter(name = ApiConstants.ADMIN, type = CommandType.STRING, 
required = false, description = "domain admin username in LDAP ")
+private String admin;
+
+@Parameter(name = ApiConstants.ACCOUNT_TYPE, type = CommandType.SHORT, 
required = true, description = "Type of the account to auto import. Specify 0 
for user, 1 for root " +
+"admin, and 2 for domain admin")
+private short accountType;
+
+@Inject
+private LdapManager _ldapManager;
+
+@Inject
+public AccountService _accountService;
+
+@Override
+public void execute() throws ServerApiException {
+try {
+LinkDomainToLdapResponse response = 
_ldapManager.linkDomainToLdap(domainId, type, name, accountType);
--- End diff --

it is ok for the first call to succeed and the second to fail. for example 
if the username already exists, it will fail. I will check if tx is required.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38384030
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import javax.inject.Inject;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.AccountService;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import com.cloud.user.Account;
+
+import java.util.UUID;
+
+@APICommand(name = "linkDomainToLdap", description = "link an existing 
cloudstack domain to group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.6.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkDomainToLdapCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(LinkDomainToLdapCmd.class.getName());
+private static final String s_name = "linkdomaintoldapresponse";
+
+@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class, description = "The id of the domain which 
has to be linked to LDAP.")
+private Long domainId;
+
+@Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, 
required = true, description = "type of the ldap name. GROUP or OU")
+private String type;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+private String name;
+
+@Parameter(name = ApiConstants.ADMIN, type = CommandType.STRING, 
required = false, description = "domain admin username in LDAP ")
+private String admin;
+
+@Parameter(name = ApiConstants.ACCOUNT_TYPE, type = CommandType.SHORT, 
required = true, description = "Type of the account to auto import. Specify 0 
for user, 1 for root " +
+"admin, and 2 for domain admin")
+private short accountType;
+
+@Inject
+private LdapManager _ldapManager;
+
+@Inject
+public AccountService _accountService;
+
+@Override
+public void execute() throws ServerApiException {
+try {
+LinkDomainToLdapResponse response = 
_ldapManager.linkDomainToLdap(domainId, type, name, accountType);
+if(admin!=null) {
+try {
+LdapUser ldapUser = _ldapManager.getUser(admin, type, 
name);
+if(!ldapUser.isDisabled()) {
--- End diff --

its mentioned in fs. It will be disabled only when the user attempts to 
login. but, once the user is disabled, he wont be able to login. resources will 
continue to work


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38384040
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import javax.inject.Inject;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.AccountService;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import com.cloud.user.Account;
+
+import java.util.UUID;
+
+@APICommand(name = "linkDomainToLdap", description = "link an existing 
cloudstack domain to group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.6.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkDomainToLdapCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(LinkDomainToLdapCmd.class.getName());
+private static final String s_name = "linkdomaintoldapresponse";
+
+@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class, description = "The id of the domain which 
has to be linked to LDAP.")
+private Long domainId;
+
+@Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, 
required = true, description = "type of the ldap name. GROUP or OU")
+private String type;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+private String name;
+
+@Parameter(name = ApiConstants.ADMIN, type = CommandType.STRING, 
required = false, description = "domain admin username in LDAP ")
+private String admin;
+
+@Parameter(name = ApiConstants.ACCOUNT_TYPE, type = CommandType.SHORT, 
required = true, description = "Type of the account to auto import. Specify 0 
for user, 1 for root " +
+"admin, and 2 for domain admin")
+private short accountType;
+
+@Inject
+private LdapManager _ldapManager;
+
+@Inject
+public AccountService _accountService;
--- End diff --

didnt see that. will reuse.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38384079
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
 ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import javax.inject.Inject;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.AccountService;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import com.cloud.user.Account;
+
+import java.util.UUID;
+
+@APICommand(name = "linkDomainToLdap", description = "link an existing 
cloudstack domain to group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.6.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkDomainToLdapCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(LinkDomainToLdapCmd.class.getName());
+private static final String s_name = "linkdomaintoldapresponse";
+
+@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class, description = "The id of the domain which 
has to be linked to LDAP.")
+private Long domainId;
+
+@Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, 
required = true, description = "type of the ldap name. GROUP or OU")
+private String type;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, 
required = true, description = "name of the group or OU in LDAP")
+private String name;
+
+@Parameter(name = ApiConstants.ADMIN, type = CommandType.STRING, 
required = false, description = "domain admin username in LDAP ")
+private String admin;
+
+@Parameter(name = ApiConstants.ACCOUNT_TYPE, type = CommandType.SHORT, 
required = true, description = "Type of the account to auto import. Specify 0 
for user, 1 for root " +
+"admin, and 2 for domain admin")
+private short accountType;
+
+@Inject
+private LdapManager _ldapManager;
+
+@Inject
+public AccountService _accountService;
+
+@Override
+public void execute() throws ServerApiException {
+try {
+LinkDomainToLdapResponse response = 
_ldapManager.linkDomainToLdap(domainId, type, name, accountType);
+if(admin!=null) {
+try {
+LdapUser ldapUser = _ldapManager.getUser(admin, type, 
name);
+if(!ldapUser.isDisabled()) {
+Account account = 
_accountService.getActiveAccountByName(admin, domainId);
+if (account == null) {
+UserAccount userAccount =
+_accountService.createUserAccount(admin, 
"", ldapUser.getFirstname(), ldapUser.getLastname(), ldapUser.getEmail(), null, 
admin, Account.ACCOUNT_TYPE_DOMAIN_ADMIN, domainId, admin, null, 
UUID.randomUUID().toString(),
+  
UUID.randomUUID().toString(), User.Source.LDAP);
--- End diff --

password is not required in db for ldap as authentication happens at ldap.
if it fails, domain admin acc

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38384082
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
 ---
@@ -39,6 +39,9 @@
 private static final ConfigKey ldapProvider = new 
ConfigKey(String.class, "ldap.provider", "Advanced", "openldap", "ldap 
provider ex:openldap, microsoftad",

 true, ConfigKey.Scope.Global, null);
 
+private static final ConfigKey ldapEnableNestedGroups = new 
ConfigKey(Boolean.class, "ldap.nested.groups.enable", "Advanced", 
"true",
--- End diff --

ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38384124
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 ---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
 closeContext(context);
 }
 }
+
+@Override
+public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String 
type, String name, short accountType) {
+Validate.notNull(type, "type cannot be null. It should either be 
GROUP or OU");
--- End diff --

it fails when an enum is created. check the next few lines and the test 
case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38384161
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 ---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
 closeContext(context);
 }
 }
+
+@Override
+public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String 
type, String name, short accountType) {
+Validate.notNull(type, "type cannot be null. It should either be 
GROUP or OU");
+Validate.notNull(domainId, "domainId cannot be null.");
--- End diff --

a message is shown in the ui with "an entity already exists". We can refine 
it. But an additional query to do the check is not necessary. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Support live migration on older version o...

2015-08-31 Thread mike-tutkowski
GitHub user mike-tutkowski opened a pull request:

https://github.com/apache/cloudstack/pull/767

Support live migration on older version of Libvirt

https://issues.apache.org/jira/browse/CLOUDSTACK-8792

A flag being passed to Libvirt assumes v1.0.0 or later.

We need to put a check in the code to pass in a different flag if the 
version of Libvirt is < 1.0.0.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-tutkowski/cloudstack CLOUDSTACK-8792

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/767.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #767


commit c5a0d5e01c98a1a1915ea2d778baa2f30807f788
Author: Mike Tutkowski 
Date:   2015-08-31T18:40:08Z

Support live migration on older version of Libvirt




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38384216
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 ---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
 closeContext(context);
 }
 }
+
+@Override
+public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String 
type, String name, short accountType) {
+Validate.notNull(type, "type cannot be null. It should either be 
GROUP or OU");
+Validate.notNull(domainId, "domainId cannot be null.");
+Validate.notEmpty(name, "GROUP or OU name cannot be empty");
--- End diff --

if the name doesnt exist, authentication will fail. 
Yes it is possible to map different cs domains to same ldap group


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-08-31 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/755#discussion_r38384226
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 ---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
 closeContext(context);
 }
 }
+
+@Override
+public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String 
type, String name, short accountType) {
+Validate.notNull(type, "type cannot be null. It should either be 
GROUP or OU");
+Validate.notNull(domainId, "domainId cannot be null.");
+Validate.notEmpty(name, "GROUP or OU name cannot be empty");
+//Account type constants in com.cloud.user.Account
+Validate.isTrue(accountType>=0 && accountType<=5, "accountype 
should be a number from 0-5");
--- End diff --

mm.. yes. at this point I only checked for allowed account types. will make 
the change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Request for PR Review (Cannot live migrate VM with Libvirt < v1.0.0)

2015-08-31 Thread Mike Tutkowski
Hi,

I was wondering if a couple people could take a look at the following PR:

https://github.com/apache/cloudstack/pull/767

There is not much code involved.

It solves the following issue related to live migration on KVM:

https://issues.apache.org/jira/browse/CLOUDSTACK-8792

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

2015-08-31 Thread Rohit Yadav
+1 (binding)

Following install and api tests performed;

pip install 
ec2stack-configure
ec2stack-register ec2stack_server_address   # or register 
user using curl
pip install awscli
aws configure set default.ec2.signature_version v2

aws ec2 describe-images —endpoint=
# minor issue here, aws printed the json with ImageId having additional newline 
and spaces that could be fixed, like ‘\nuuid-here   \n’ to ‘uuid-here’.

aws ec2 run-instances —image-id  —count 1 —instance-type 
m1.small —endpoint=
# VM launched :)

On 26-Aug-2015, at 2:55 pm, sebgoa mailto:run...@gmail.com>> 
wrote:

Hi All,

I've created a 0.8.0 release of EC2stack, with the following artifacts up for a 
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack-ec2stack.git

Commit: a61d7c01129dfe4c31515a48e0f6b4a53436c208

There are no code changes from the time the code was donated to the ASF, only 
license headers and a Dockerfile.

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/ec2stack-0.8.0/

PGP release keys (signed using 8F89EB84):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

For testing functionality you might consider using the Docker image:
docker pull cloudstack/cloudstack-ec2stack

Do remember that the official release artifact is the source code, which needs 
to contain proper licensing and proper signatures.

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate 
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

2015-08-31 Thread Rohit Yadav

On 28-Aug-2015, at 4:34 pm, Rajani Karuturi 
mailto:rajani.karut...@citrix.com>> wrote:

$ ec2stack-register http://localhost:5000 cs_api_key cs_secret_key
$ aws ec2 describe-images --endpoint=http://localhost:5000
# it gave the below error message
# Unable to locate credentials. You can configure credentials by running "aws 
configure”.
$ aws configure # gave AWS api and secret key
$ aws ec2 describe-images --endpoint=http://localhost:5000
# this is the output I see
# localhost - - [28/Aug/2015 16:25:24] "POST / HTTP/1.1" 401 -
# ‘RequestID’

Something went wrong with registering the user, use this to register the 
apikey/secretkey:

curl -d AWSSecretKey=yoursecretkey -d AWSAccessKeyId=yourapikey -d 
Action=RegisterSecretKey http://localhost:5000

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.


[GitHub] cloudstack pull request: Support live migration on older version o...

2015-08-31 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/767#issuecomment-136585198
  
LGTM, whoever merged, please merge on 4.5 branch as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


  1   2   >