[QUESTION] SQL in old upgrade code

2015-07-19 Thread Daan Hoogland 
devs,

in Upgrade218to22 in private void modifyIndexes(Connection conn), an
index is removed twice without any code inbetween. Does anybody know
of a (my)sql quirk that makes this necessary?

I am trying to remove the last high impact coverity warning so we can
use coverity in our review process. Alternative would be to remove
this old upgrade code altogether but I don't want to make this call
just yet.

any opinions greatly appreciated,
-- 
Daan

Re: [QUESTION] SQL in old upgrade code

2015-07-19 Thread Daan Hoogland 
nevermind, I was reading over an extra underscore ('_')...:(

On Sun, Jul 19, 2015 at 4:10 PM, Daan Hoogland  wrote:
> devs,
>
> in Upgrade218to22 in private void modifyIndexes(Connection conn), an
> index is removed twice without any code inbetween. Does anybody know
> of a (my)sql quirk that makes this necessary?
>
> I am trying to remove the last high impact coverity warning so we can
> use coverity in our review process. Alternative would be to remove
> this old upgrade code altogether but I don't want to make this call
> just yet.
>
> any opinions greatly appreciated,
> --
> Daan



-- 
Daan

[GitHub] cloudstack pull request: Dockerfile

2015-07-19 Thread pdion891 
GitHub user pdion891 opened a pull request:

https://github.com/apache/cloudstack/pull/605

Dockerfile

Initial PR for Dockerization of CloudStack. 

Important Changes:
* scripts/vm/systemvm/injectkeys.sh:   script execution will pass event if 
/dev/loop0 not detected and will skip verification of sshkey, this is a 
limiation in Docker container.
* Dockerfile for simulator move into /tools/docker: Need to change  Jenkins 
jobs and Dockerhub build after the merge.


Current docker file working:
* simulator (Seb's original file)
* management-server on centos6 (using RPM's)
* marvin

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdion891/cloudstack dockerfile

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/605.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #605


commit f1ce83d894d1501da13d72269f7b8deea3ae4b4a
Author: Pierre-Luc Dion 
Date:   2015-06-07T18:13:23Z

add check to not mount systemvm.iso if inside unprivileged docker container

commit b2e6143a4838bad1265fa321317ee56b34525d00
Author: Pierre-Luc Dion 
Date:   2015-06-07T19:54:37Z

move Dockerfile into tools/docker

commit a3b76e201dbcf70e753e8c13721bc749c8a17b13
Author: Pierre-Luc Dion 
Date:   2015-06-07T18:13:47Z

initial README.md file for Dockerfiles instructions

commit a0019a1befd010abf78df5a4234ed1c8834414db
Author: Pierre-Luc Dion 
Date:   2015-06-07T18:13:23Z

Dockerfile to create images for CloudStack management server using RPMs 
based on CentOS 6

commit 28556e2eda9d2875f1969016c19ee66e8667cb7d
Author: Pierre-Luc Dion 
Date:   2015-06-07T18:13:23Z

RPM download URL using TEST URL for validation

commit a6e7c40015dd126a3192126a381e9982fc75097b
Author: Pierre-Luc Dion 
Date:   2015-06-07T18:13:23Z

add check to not mount systemvm.iso if inside unprivileged docker container

commit c020c65aee16e16fafdf8b21257a6d3124f66438
Author: Pierre-Luc Dion 
Date:   2015-06-07T18:13:23Z

RPM download URL using TEST URL for validation

commit 6b07d43815a273af54b343dcf8b2d7083b804210
Author: Pierre-Luc Dion 
Date:   2015-06-07T18:13:23Z

Dockerfile to create images for CloudStack management server using RPMs 
based on CentOS 6

commit ef23d7da3323b7fb5198523f1efb0114f5bb7733
Author: Pierre-Luc Dion 
Date:   2015-06-07T18:13:47Z

initial README.md file for Dockerfiles instructions

commit 408615daea4d431a6c8594b7194e411293abb815
Author: Pierre-Luc Dion 
Date:   2015-06-07T19:54:37Z

move Dockerfile into tools/docker

commit 73b1ab2cddc880a4d784fc6b6c8e43bb0b504708
Author: Pierre-Luc Dion 
Date:   2015-06-07T20:39:04Z

move supervisord.conf, fix Dockerfile.centos6: comment copy of fixed file

commit cf1797974883540a4a6c1d691552a7c0c97adeea
Author: Pierre-Luc Dion 
Date:   2015-06-07T20:41:06Z

fix conflict Dockerfile.centos6

commit bd1a29930e5f715b6428832ce8dba463e8522606
Author: Pierre-Luc Dion 
Date:   2015-06-07T20:42:15Z

set init.sh to executable

commit 64b79581763c93a63c0fa96207e64fd526f1cd9a
Author: Pierre-Luc Dion 
Date:   2015-06-08T01:16:14Z

add licenses

commit 3f7cdc4f030009b5fe9ae71bb2cf6bcda61373cb
Author: Pierre-Luc Dion 
Date:   2015-06-08T01:20:46Z

change titles

commit 2e1c02aa26e924833d916ca926296bf07be784f8
Author: Pierre-Luc Dion 
Date:   2015-06-09T02:32:15Z

add docker container for Marvin including test and config examples

commit 096fa16d33066c32ee94d436a459b877a99f8c9c
Author: Pierrre-Luc Dion 
Date:   2015-06-09T02:35:42Z

add license header

commit 981c479a11ce72b0c7e289ef630ac6f972dc2942
Author: Pierre-Luc Dion 
Date:   2015-06-09T02:35:49Z

Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cloudstack 
into dockerfile

commit ef109663f41f5bf4b1cc93b60e640a28f6901e36
Author: Pierre-Luc Dion 
Date:   2015-06-09T02:36:19Z

Merge branch 'dockerfile' of github.com:pdion891/cloudstack into dockerfile

commit 0fc4f9aa680738f7009e62d8c6317c516e4fe132
Author: Pierrre-Luc Dion 
Date:   2015-06-10T02:43:58Z

add marvin scripts into /marvin

commit 616285604fc007bcdcf82e1ed04be3dc76c6c4b0
Author: Pierre-Luc Dion 
Date:   2015-06-13T19:31:44Z

use another container for mysql database

commit 7e6fbc1e5fc0e68a6755e7b15d1913c07c5fe260
Author: Pierre-Luc Dion 
Date:   2015-06-13T19:49:02Z

rename init.sh

commit a7cdf1019828c2d6386eb0d7ef7a9fe1b44b3aee
Author: Pierre-Luc Dion 
Date:   2015-06-13T19:49:52Z

Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cloudstack 
into dockerfile

commit efdeaef72bf1cbad14634a2d198de29946999ace
Author: Pierre-Luc Dion 
Date:   2015-06-13T19:50:33Z

Merge branch 'dockerfile' of github.com:pdion891/cloudstack into dockerfile

commit 07dee393883451580e90848202de830db4ee1040
Author: Pierre-Luc Dion 
Date:

Build failed in Jenkins: build-master-slowbuild #1853

2015-07-19 Thread jenkins 
See 

--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on coohq-slave-01 (cloudstack-buildslave-centos6 
systemvmbuilder) in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git --version # timeout=10
 > /usr/bin/git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016)
at hudson.scm.SCM.checkout(SCM.java:484)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1258)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528)
at hudson.model.Run.execute(Run.java:1759)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)
Caused by: hudson.plugins.git.GitException: Command "/usr/bin/git -c 
core.askpass=true fetch --tags --progress 
https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: fatal: unable to access 
'https://git-wip-us.apache.org/repos/asf/cloudstack.git/': gnutls_handshake() 
failed: A TLS packet with unexpected length was received.

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to coohq-slave-01(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
at hudson.remoting.Channel.call(Channel.java:752)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
at sun.proxy.$Proxy46.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733)
... 11 more
ERROR: Error fetching remote repo 'origin'
[FINDBUGS] Skipping publisher since build result is FAILURE
Skipping Cobertura coverage report as build was not UNSTABLE or better ...

Build failed in Jenkins: build-master-slowbuild #1854

2015-07-19 Thread jenkins 
See 

--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on coohq-slave-01 (cloudstack-buildslave-centos6 
systemvmbuilder) in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git --version # timeout=10
 > /usr/bin/git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016)
at hudson.scm.SCM.checkout(SCM.java:484)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1258)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528)
at hudson.model.Run.execute(Run.java:1759)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)
Caused by: hudson.plugins.git.GitException: Command "/usr/bin/git -c 
core.askpass=true fetch --tags --progress 
https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: fatal: unable to access 
'https://git-wip-us.apache.org/repos/asf/cloudstack.git/': gnutls_handshake() 
failed: A TLS packet with unexpected length was received.

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to coohq-slave-01(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
at hudson.remoting.Channel.call(Channel.java:752)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
at sun.proxy.$Proxy46.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733)
... 11 more
ERROR: Error fetching remote repo 'origin'
[FINDBUGS] Skipping publisher since build result is FAILURE
Skipping Cobertura coverage report as build was not UNSTABLE or better ...

[GitHub] cloudstack pull request: boring resourse leaks again

2015-07-19 Thread karuturi 
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/602#issuecomment-122759444
  
one of the travis jobs timedout. builds.a.o is down to see what caused the 
failures
code changes looks good :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8632: Unable to revert snapsho...

2015-07-19 Thread Sanjeev N 
LGTM

On Thu, Jul 16, 2015 at 11:34 AM, wilderrodrigues 
wrote:

> Github user wilderrodrigues commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/590#issuecomment-121843137
>
> LGTM
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-07-19 Thread devdeep 
Github user devdeep commented on the pull request:

https://github.com/apache/cloudstack/pull/351#issuecomment-122773398
  
I'll take a look and get back if I have any queries


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---