Re: keep stable, stable

2015-06-21 Thread Daan Hoogland
Sorry Marcus,

This commit is one of a series of three that implement
CLOUDSTACK-8537. one is the fix. one is a refactor required to test it
and one is the test. I could have only backported the fix. It was
blocking a user from implementing convergence using terraform. So if
you are saying that I should not have backported the test for it you
got a point (this one was needed for it). Otherwise we (Rohit and I)
have been guarding these branches with exactly the policy that you
propagate.

I don't mind that you are trying press this point and agree that we
should go there. I think you could have picked a worse example to make
it in fact as this commit hits a border line.

On the other hand I also think you are wrong. cherry picking fixes
from newer release branches is not what is slowing us down.
Cherry-picking untested fixes is. This code is rather trivial but
actually in my opinion the way backporting should be done to prevent
blocking releases.

Also I think that we can not make hard on this policy. We are not
going fast enough with our releases to ask it of our users. Chicken
and egg story whcih we can circumvent by automating the testing and
using that automation. I see very little people working on fixing the
load of jenkins jobs that aren't working.

On Sat, Jun 20, 2015 at 6:49 PM, Marcus  wrote:
> This commit, after looking at the code for 60 seconds, looks like it
> refactors some existing code into methods to make it more testable. Perhaps
> there's more nuance than that, but the commit message doesn't point
> anything like that out to help me find it.
>
> I'm not trying to be critical of any specific commit, and this is a
> community. I don't have any special right to set the expectations on my
> own. I'm just stating my opinion, and my opinion is that once a release
> branch goes production, there should be no changes to it, save to fix
> broken functionality or security. No refactoring, no nice-to-have
> enhancements, no formatting fixes, no fixes for theoretical bugs or static
> analysis. When we release, we are in a known state, and I don't think we
> should perturb that known state unless we really, really need to.
> Otherwise, creating bugfix releases to that branch will be painful and more
> prone to regressions.
>
> In my opinion, there are two major things that keep us from turning around
> quick incremental point releases. One is this issue, the other is letting
> pre-existing bugs that aren't regressions block the vote. I will probably
> always be sensitive to these things, and if anyone takes offense to that
> I'm sorry. I realize that everyone has their own motivations, timelines,
> commitments, and pressure to get improvements into the code base, but I
> just don't think point releases are the place for most of these, and I
> don't see anyone else pushing back, so I figure I need to get the opinion
> out there, even if it's a lone one.
>
> On Fri, Jun 19, 2015 at 2:11 PM, Daan Hoogland 
> wrote:
>
>> On Fri, Jun 19, 2015 at 8:31 PM, Marcus  wrote:
>> > Why are we touching 4.5 branch with anything other than known bugfixes?
>>
>> Please don't say this is not a bug, Marcus. have a good look at what
>> it does! I had complaints on it responding counter intuitively and it
>> is in all versions.
>>
>> --
>> Daan
>>



-- 
Daan


[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-21 Thread DaanHoogland
Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/482#issuecomment-113882368
  
LGTM waiting for travis to agree


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/497

Attempt to resolve ovm3 jenkins failure

Resolve unsafe cast warnings reported by lint checker
Add some debug config to compiler plugin

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack fixjenkinsovm3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/497.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #497


commit 611c98bd8f2d3ff890998ed13512f6d4f10d315d
Author: Rafael da Fonseca 
Date:   2015-06-21T12:03:53Z

Resolve unsafe cast warnings reported by lint checker
Add some debug config to compiler plugin




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: This is a quick fix to attempt to resolve...

2015-06-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/482


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: simulator-singlerun #1291

2015-06-21 Thread jenkins
See 

--
Started by upstream project "build-master-simulator" build number 2108
originally caused by:
 Started by an SCM change
 Started by upstream project "build-master" build number 2413
 originally caused by:
  Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on simulator in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > /usr/bin/git --version # timeout=400
 > /usr/bin/git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016)
at hudson.scm.SCM.checkout(SCM.java:484)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1258)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528)
at hudson.model.Run.execute(Run.java:1759)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)
Caused by: hudson.plugins.git.GitException: Command "/usr/bin/git fetch --tags 
--progress https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: error:  while accessing 
https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs

fatal: HTTP request failed

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
at ..remote call to simulator(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
at hudson.remoting.Channel.call(Channel.java:752)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
at sun.proxy.$Proxy46.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733)
... 11 more
ERROR: Error fetching remote repo 'origin'
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 
'xunit.xml' relative to 
' for the testing 
framework 'JUnit'.  Did you enter a pattern relative to the correct directory?  
Did you generate the result report(s) for 'JUnit'?
[xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the 

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/497#issuecomment-113935237
  
Looks like you've got it @rsafonseca please squash the commits all 50+ of 
'em :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca
Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/497#issuecomment-113935738
  
Hi Rohit,
Sorry for spamming you guys so hard this weekend eheh :)
I've found the problem, but it's still not properly fixed. Cause seems to
be a 20k+ string in XenTest.java
Gave me some work to make that a StringBuilder instead of just adding
strings.. this should use a lot less heap and cpu, but now it seems to be
failing consistently, although build doesn't stop because i've put a flag
on the compiler plugin to continue anyway.
Will squash the whole thing when i get all SUCCESS instead of UNSTABLE ;)
Although 0 travis failures so far.. yay for the other fix hehe

On Sun, Jun 21, 2015 at 7:47 PM, Rohit Yadav 
wrote:

> Looks like you've got it @rsafonseca 
> please squash the commits all 50+ of 'em :)
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca
Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/497#issuecomment-113937925
  
Just as i said travis was stable, got a lot of failures haha :)
Upon looking into it, travis didn't fail, it is correctly reporting that i 
killed ovm3 lol, so travis fix is working as expected.. this PR is the one who 
isn't 
Will fix soon, i can now reproduce the issue locally :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca
Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/497#issuecomment-113955383
  
Victory!
One of the problem nodes just compiled it successfully and ran until the 
end without problems
Will now get started on cleaning up the PR and just leave the fix and a 
couple other minor improvements made along the way


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread rsafonseca
Github user rsafonseca commented on the pull request:

https://github.com/apache/cloudstack/pull/497#issuecomment-113956319
  
@bhaisaab you can go ahead and merge now :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build environment stability

2015-06-21 Thread Rafael Fonseca
Hi all,

Sorry for the 100+ SPAM mails from asfbot caused by me, this was a good
weekend for the Cloudstack build environment though :)

- jenkins-slow-build is now sucessful:
Daan worked very hard on this to get it running properly, we now have
proper alerting for bad practice/bugs on new code ... thanks Daan :)

- Travis timeouts/failures
PR #482 fixed a few problems that were causing failures, not a single false
positive since it has been merged.. and i gave travis quite some work to do
:)

- Jenkins OVM3 failure
PR #497 fixes the problem.. gave me some work to debug but it's done! will
no longer get those anoying FAILURE messages from jenkins when your code is
proper after this one is also merged.

Happy Cloudstacking to all :)

Rafael


[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/498

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in DeployVMCmd.java



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs85

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/498.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #498


commit d8efaa272c138d384372ce4aedcaed787a548661
Author: Rafael da Fonseca 
Date:   2015-06-21T22:06:53Z

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in DeployVMCmd.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix 2 findbugs occurences of DM_BOXED_PRI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/499

Fix 2 findbugs occurences of DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrad…

…e218to22.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs86

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #499


commit 5670d638ebc9558af01dd4e08ca2b90cfd6eb1de
Author: Rafael da Fonseca 
Date:   2015-06-21T22:09:40Z

Fix 2 findbugs occurences of DM_BOXED_PRIMITIVE_FOR_PARSING in 
Upgrade218to22.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix 2 more findbugs DM_BOXED_PRIMITIVE_FO...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/500

Fix 2 more findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.…

…java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs87

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #500


commit eabffb81dea5a56803ce89ec56fe2f1f99154358
Author: Rafael da Fonseca 
Date:   2015-06-21T22:34:35Z

Fix 2 more findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/501

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in BareMetalResourceBase.…

…java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs88

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #501


commit 4562fb373db32e8d991452e11a468983360fe15b
Author: Rafael da Fonseca 
Date:   2015-06-21T22:36:18Z

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in BareMetalResourceBase.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/502

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in OvmResourceBase.java



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs89

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/502.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #502


commit c26af21b29ac9b2513d0c3a7e89611b560085585
Author: Rafael da Fonseca 
Date:   2015-06-21T22:39:05Z

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in OvmResourceBase.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/503

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorPrim…

…aryDataStoreLifeCycle.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs90

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #503


commit 33f38d017b8b710be442ea161c746460dcd88bdf
Author: Rafael da Fonseca 
Date:   2015-06-21T22:41:08Z

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in 
ElastistorPrimaryDataStoreLifeCycle.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSI...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/504

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorUtil…

….java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs91

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/504.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #504


commit cc09a822fbbcb58488a8c760ab975d918840f9d1
Author: Rafael da Fonseca 
Date:   2015-06-21T22:42:37Z

Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorUtil.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/505

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING…

… warning in Upgrade410to420.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs92

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #505


commit 73b0fb2c6ac193f14961499e335570fcbc14a402
Author: Rafael da Fonseca 
Date:   2015-06-21T23:07:59Z

Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warning in Upgrade410to420.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/497#discussion_r32905980
  
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
 ../../pom.xml
   
   
-
-org.apache.xmlrpc
-xmlrpc-client
-3.1.3
-
+
+   xml-apis
+   xml-apis
+   1.4.01
+
+
+  org.apache.xmlrpc
+  xmlrpc-client
+  3.1.3
--- End diff --

Can we resuse the version number(cs.xmlrpc.version) from parent pom?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/497#discussion_r32905987
  
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
 ../../pom.xml
   
   
-
-org.apache.xmlrpc
-xmlrpc-client
-3.1.3
-
+
+   xml-apis
+   xml-apis
+   1.4.01
+
+
+  org.apache.xmlrpc
+  xmlrpc-client
+  3.1.3
+
+
+   org.apache.xmlrpc
+   xmlrpc-common
+   3.1.3
+
+
+   org.apache.commons
+   commons-lang3
+   3.4
--- End diff --

can you add this version to parent pom and use from there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/497#discussion_r32905983
  
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
 ../../pom.xml
   
   
-
-org.apache.xmlrpc
-xmlrpc-client
-3.1.3
-
+
+   xml-apis
+   xml-apis
+   1.4.01
+
+
+  org.apache.xmlrpc
+  xmlrpc-client
+  3.1.3
+
+
+   org.apache.xmlrpc
+   xmlrpc-common
+   3.1.3
--- End diff --

Can we resuse the version number(cs.xmlrpc.version) from parent pom?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/497#discussion_r32905996
  
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
 ../../pom.xml
   
   
-
-org.apache.xmlrpc
-xmlrpc-client
-3.1.3
-
+
+   xml-apis
+   xml-apis
+   1.4.01
+
+
+  org.apache.xmlrpc
+  xmlrpc-client
+  3.1.3
+
+
+   org.apache.xmlrpc
+   xmlrpc-common
+   3.1.3
+
+
+   org.apache.commons
+   commons-lang3
+   3.4
+
+
+   log4j
+   log4j
+   1.2.17
--- End diff --

Can we reuse cs.log4j.version from parent pom?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-21 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/497#discussion_r32906046
  
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
 ../../pom.xml
   
   
-
-org.apache.xmlrpc
-xmlrpc-client
-3.1.3
-
+
+   xml-apis
+   xml-apis
--- End diff --

this is a new dependency. Is this conflict resolution? If yes, can this be 
added to the exclusion list of the dependency? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Build environment stability

2015-06-21 Thread Rajani Karuturi
Thanks for all the hard work Rafeal and Daan. much needed fixes.

~Rajani

On Mon, Jun 22, 2015 at 2:35 AM, Rafael Fonseca 
wrote:

> Hi all,
>
> Sorry for the 100+ SPAM mails from asfbot caused by me, this was a good
> weekend for the Cloudstack build environment though :)
>
> - jenkins-slow-build is now sucessful:
> Daan worked very hard on this to get it running properly, we now have
> proper alerting for bad practice/bugs on new code ... thanks Daan :)
>
> - Travis timeouts/failures
> PR #482 fixed a few problems that were causing failures, not a single false
> positive since it has been merged.. and i gave travis quite some work to do
> :)
>
> - Jenkins OVM3 failure
> PR #497 fixes the problem.. gave me some work to debug but it's done! will
> no longer get those anoying FAILURE messages from jenkins when your code is
> proper after this one is also merged.
>
> Happy Cloudstacking to all :)
>
> Rafael
>


[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-21 Thread shwetaag
Github user shwetaag commented on the pull request:

https://github.com/apache/cloudstack/pull/153#issuecomment-114021543
  
@gauravaradhye  and @DaanHoogland  another request for this was created 

https://github.com/apache/cloudstack/pull/184
and @sanjeevneelarapu reviewed it and checked it . Most of your review 
comments were incorporated in the new request except moving it to maintenance 
folder. 





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-21 Thread shwetaag
Github user shwetaag closed the pull request at:

https://github.com/apache/cloudstack/pull/153


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


question about Admin's capability to create a VM on a disabled host

2015-06-21 Thread Raja Pullela
Hi,

This is regarding a question about Admin user's ability to create a VM on a 
disabled host...  does anyone know the purpose/use?  can I understand it will 
help in troubleshooting.

Thanks,
Raja