[Propose] Improvements in XenServer + ACS integration

[Marco Sinhoreli]

Hi community,

I'm starting this discussion to share some ideas about XenServer integration in 
ACS. Since XenServer has some nice features to do that like RBAC, host plugin 
and XenStore, I demonstrate these to some community members at CCCEU14.

Some references you can look in these links:
https://blog.xenproject.org/2011/11/09/xcp-rbac-and-pam-authentication-in-the-xenapi/
https://wiki.xenserver.org/index.php?title=RBAC
http://wiki.xen.org/wiki/XAPI_Host_Plugins
http://wiki.xen.org/wiki/XenStore

Actual status in ACS:
During the XenServer setup, is possible to define a user to connect to the 
xapi. In XenCenter, is possible to use a different user (no-root) using 
external authentication like AD our PAM since the RBAC is configured properly 
for this. In ACS it's not possible because many command need be called by root 
using SSH. Another issue in this approach is about security: root password is 
stored in DB and, in this approach we have a security compliance issue. The 
root used used to call shell scripts in the XenServer host are all hard-coded.

What we can do?
- Substitute host SSH connection to XAPI host plugins
In my view, I prefer use just one-way to connect to XenServer, in this case, 
changing host SSH interactions to use exclusively XAPI. XAPI implements Host 
Plugins where could be used to as a security layer to call commands into host.

An example of host plugin:

# cat xen_plugin_demo

#!/usr/bin/python


import XenAPIPlugin

import subprocess


def main(session, args):

try:

p = subprocess.Popen(args["cmd"].split(" "), stdout=subprocess.PIPE,  
stderr=subprocess.PIPE)

out, err = p.communicate()

return out

except KeyError:

raise RuntimeError("No argument found with key.")


if __name__ == "__main__":

XenAPIPlugin.dispatch({"main": main})

And a client:

$ cat call_plugin.py

import XenAPI

import sys


session = XenAPI.Session('https://192.168.56.12')

session.login_with_password('cloud', 'password')

host, = session.xenapi.host.get_all()


print

print session.xenapi.host.call_plugin(host, 'xen_plugin_demo', 'main', {'cmd' : 
" ".join(sys.argv[1:])})

Calling:

$ python call_plugin.py ls /root


add_roles.sh

support.tar.bz2

- Setup RBAC to use a non-root to manage the XenServer host
As a suggestion, for this approach, need to have a user pre-seted in PAM or 
configure XenServer AD. Follow what need be running in the XenServer shell to 
setup the user, external auth, associate RBAC role to this user:

adduser cloudstack

password cloudstack

xe pool-enable-external-auth auth-type=PAM config:user=cloudstack 
service-name=CloudStack

xe subject-add subject-name=cloudstack

subject_uuid=$(xe subject-list  | awk '/^uuid/{print $5}')

role_uuid=$(xe role-list  name=pool-admin params=uuid | awk '/^uuid/{print $5}')

xe subject-role-add uuid=${subject_uuid} role-uuid=${role_uuid}

We can in this case, maintain the scripts used today, needing change the way to 
call them from ACS.

Best regards,


Marco Sinhoreli
Consultant Manager

[cid:4ED26AB2-F780-4A47-A562-29FA916D6FE6]

Phone: +55 21 2586 6390 | Fax: +55 21 2586 6002 | Mobile: +55 21 98276 3636 | 
Mobile: +55 21 99711 4645
Praia de Botafogo 501, bloco 1 - sala 101, Botafogo, Rio de Janeiro, RJ - 
Brazil - CEP 22250-040
marco.sinhor...@shapeblue.com | 
www.shapeblue.com | 
Twitter:@shapeBlue

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge - rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Build failed in Jenkins: cloudstack-4.3-maven-build #642

[jenkins]

See 

Changes:

[Ian Duffy] modify travis file to force true on test execution. The XML parser 
will determine failures

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on cloudstack-buildslave-centos6-87d 
(cloudstack-buildslave-centos6) in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url git://git.apache.org/cloudstack.git # 
 > timeout=400
Fetching upstream changes from git://git.apache.org/cloudstack.git
 > /usr/bin/git --version # timeout=400
 > /usr/bin/git fetch --tags --progress git://git.apache.org/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
 > /usr/bin/git rev-parse origin/4.3^{commit} # timeout=400
Checking out Revision 879f94c74310ed89afe6d25df3b52c00422bbc5a (origin/4.3)
 > /usr/bin/git config core.sparsecheckout # timeout=400
 > /usr/bin/git checkout -f 879f94c74310ed89afe6d25df3b52c00422bbc5a
 > /usr/bin/git rev-list df9fe7817c17b045f2f293bd238bf4982eebd7b5 # timeout=400
FATAL: Couldn’t find any executable in /opt/apache-maven-3.0.5
Build step 'Invoke top-level Maven targets' marked build as failure

Build failed in Jenkins: cloudstack-4.3-maven-build #643

[jenkins]

See 

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on cloudstack-buildslave-centos6-87d 
(cloudstack-buildslave-centos6) in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url git://git.apache.org/cloudstack.git # 
 > timeout=400
Fetching upstream changes from git://git.apache.org/cloudstack.git
 > /usr/bin/git --version # timeout=400
 > /usr/bin/git fetch --tags --progress git://git.apache.org/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
 > /usr/bin/git rev-parse origin/4.3^{commit} # timeout=400
Checking out Revision 879f94c74310ed89afe6d25df3b52c00422bbc5a (origin/4.3)
 > /usr/bin/git config core.sparsecheckout # timeout=400
 > /usr/bin/git checkout -f 879f94c74310ed89afe6d25df3b52c00422bbc5a
 > /usr/bin/git rev-list 879f94c74310ed89afe6d25df3b52c00422bbc5a # timeout=400
FATAL: Couldn’t find any executable in /opt/apache-maven-3.0.5
Build step 'Invoke top-level Maven targets' marked build as failure

Re: Build failed in Jenkins: cloudstack-4.3-maven-build #643

[Ian Duffy]

Maven issues on build slaves?
On 23 Nov 2014 12:52,  wrote:

> See 
>
> --
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> Started by an SCM change
> [EnvInject] - Loading node environment variables.
> Building remotely on cloudstack-buildslave-centos6-87d
> (cloudstack-buildslave-centos6) in workspace <
> http://jenkins.buildacloud.org/job/cloudstack-4.3-maven-build/ws/>
>  > /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
> Fetching changes from the remote Git repository
>  > /usr/bin/git config remote.origin.url git://
> git.apache.org/cloudstack.git # timeout=400
> Fetching upstream changes from git://git.apache.org/cloudstack.git
>  > /usr/bin/git --version # timeout=400
>  > /usr/bin/git fetch --tags --progress git://
> git.apache.org/cloudstack.git +refs/heads/*:refs/remotes/origin/*
>  > /usr/bin/git rev-parse origin/4.3^{commit} # timeout=400
> Checking out Revision 879f94c74310ed89afe6d25df3b52c00422bbc5a (origin/4.3)
>  > /usr/bin/git config core.sparsecheckout # timeout=400
>  > /usr/bin/git checkout -f 879f94c74310ed89afe6d25df3b52c00422bbc5a
>  > /usr/bin/git rev-list 879f94c74310ed89afe6d25df3b52c00422bbc5a #
> timeout=400
> FATAL: Couldn’t find any executable in /opt/apache-maven-3.0.5
> Build step 'Invoke top-level Maven targets' marked build as failure
>

Test failure on 4.3 branch

[Ian Duffy]

Hi,

The test "test_01_sys_vm_start" fails on the 4.3 branch.

https://travis-ci.org/apache/cloudstack/jobs/41867306

Anybody who can look into this?

Thanks,

Ian

Re: Test failure on 4.3 branch

[Rohit Yadav]

Hi Ian,

Thanks for looking into that.

From the exception and local testing, I found that the deployment planner 
failed to find a pool for the system vms for some reason. Anyone know if there 
was a issue or regression in simulator that got fixed in 4.4/4.5/master as 
systemvm fails to starts using simulator only for 4.3?

> On 23-Nov-2014, at 7:11 pm, Ian Duffy  wrote:
>
> Hi,
>
> The test "test_01_sys_vm_start" fails on the 4.3 branch.
>
> https://travis-ci.org/apache/cloudstack/jobs/41867306
>
> Anybody who can look into this?
>
> Thanks,
>
> Ian

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +91 88 262 30892 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab



Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: Build failed in Jenkins: cloudstack-4.3-maven-build #643

[Rohit Yadav]

> On 23-Nov-2014, at 6:49 pm, Ian Duffy  wrote:
>
> Maven issues on build slaves?

I could not identify or resolve the issue. The noredist 4.3-maven build works 
and succeeds, for some reason this specific build job fails.

> On 23 Nov 2014 12:52,  wrote:
>
>> See 
>>
>> --
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> Started by an SCM change
>> [EnvInject] - Loading node environment variables.
>> Building remotely on cloudstack-buildslave-centos6-87d
>> (cloudstack-buildslave-centos6) in workspace <
>> http://jenkins.buildacloud.org/job/cloudstack-4.3-maven-build/ws/>
>>> /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
>> Fetching changes from the remote Git repository
>>> /usr/bin/git config remote.origin.url git://
>> git.apache.org/cloudstack.git # timeout=400
>> Fetching upstream changes from git://git.apache.org/cloudstack.git
>>> /usr/bin/git --version # timeout=400
>>> /usr/bin/git fetch --tags --progress git://
>> git.apache.org/cloudstack.git +refs/heads/*:refs/remotes/origin/*
>>> /usr/bin/git rev-parse origin/4.3^{commit} # timeout=400
>> Checking out Revision 879f94c74310ed89afe6d25df3b52c00422bbc5a (origin/4.3)
>>> /usr/bin/git config core.sparsecheckout # timeout=400
>>> /usr/bin/git checkout -f 879f94c74310ed89afe6d25df3b52c00422bbc5a
>>> /usr/bin/git rev-list 879f94c74310ed89afe6d25df3b52c00422bbc5a #
>> timeout=400
>> FATAL: Couldn’t find any executable in /opt/apache-maven-3.0.5
>> Build step 'Invoke top-level Maven targets' marked build as failure
>>

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +91 88 262 30892 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab



Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Jenkins build is back to stable : simulator-singlerun #685

[jenkins]

See 

Re: Review Request 27979: CLOUDSTACK-7903: Decrease minimal usage aggregation range value

[Rohit Yadav]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27979/#review62753
---


@Kishan can you review this?

- Rohit Yadav


On Nov. 18, 2014, 1:44 p.m., Ilia Shakitko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27979/
> ---
> 
> (Updated Nov. 18, 2014, 1:44 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala, Rohit Yadav, Simon Fiddaman, 
> Stephen Hoogendijk, and Wei Zhou.
> 
> 
> Bugs: CLOUDSTACK-7903
> https://issues.apache.org/jira/browse/CLOUDSTACK-7903
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When you want to build 95-percentile billing model for the network traffic 
> usage, it is good to have 5-minutes (or 1-minute) usage samples instead of 10 
> (which is minimum allowed in ACS at the moment). Let admin to control it.
> This change decreases the lower limit for USAGE_AGGREGATION_RANGE_MIN 
> parameter, making it minimum possible positive integer. It is also removes 
> declaration of the same constant in 3 places.
> 
> Will be happy if patch can be:
> - cherry-picked to the 4.4 and 4.5 branches
> - included to the 4.4.2 tag.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 23ddfb1 
>   server/src/com/cloud/server/StatsCollector.java 1fcaa62 
>   usage/src/com/cloud/usage/UsageManagerImpl.java fe7ee1e 
> 
> Diff: https://reviews.apache.org/r/27979/diff/
> 
> 
> Testing
> ---
> 
> Tested on master, 4.4 and 4.5 branches. But then during the review time I had 
> to re-prepare the patch and it become compatible only for master branch.
> 
> If you accept the patch, could you also cherry-pick my commit to 4.4 and 4.5 
> branches? (there will be 1 one-line conflict to resolve)
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>

Re: [DISCUSS] Should we install XenServer tools in systemvmtemplates

[Rohit Yadav]

So, what’s the conclusion of this thread? We should not install install 
xenserver tools at all?

> On 21-Nov-2014, at 4:59 pm, Stephen Turner  wrote:
>
> I didn't even realise we still support XS 5.6. I would advocate not 
> supporting that any more, independent of this tools discussion, because 
> Citrix won't fix any bugs on it now, even security bugs. Can't we move to a 
> model where we only support hypervisor versions that the hypervisor vendor 
> supports?
>
> --
> Stephen Turner
>
>
> 
>
> From: Tim Mackey 
> Date: 21 November 2014 09:38:21 CET
> To: dev@cloudstack.apache.org 
> Subject: Re: [DISCUSS] Should we install XenServer tools in systemvmtemplates
>
> The big problem I recall with the 5.6 Linux tools happened during live
> migration.  I don't recall the specific circumstances, but if the VM was
> migrated, it could cause either the guest or the host to crash.  I've never
> paid attention to the specific Linux version in the system VMs, but the
> tools themselves aren't supported for installation on a newer version of an
> operating system than what was originally certified.  XenCenter when faced
> with 5.6 tools on a 6.2 host would actually say that the tools are there
> but need to be upgraded for optimal performance.
>
> This also opens the question of XCP and the tools since XenServer tools
> were never designed to work with XCP.  They probably do work just fine, but
> if there was an issue we'd be challenged to get it sorted.
>
> If the option of automatically having the tools installed isn't viable, the
> next things I'd look at would be:
>
> - removing support for XenServer versions prior to 6.0
> - removing support for XCP (or at least only supporting 1.6)
> - having the rpm/deb packages for each version of hypervisor pre-loaded
> (assuming redist EULA) and when a systemVM starts having a first boot which
> installs the correct package and then reboots the system VM
>
> At least that way the tools would be there, and we'd have better system VM
> performance while still locking ourselves to specific supported hypervisor
> versions.  No idea what impact removal of support for older XenServer
> versions might have on the install base, but I'd hope those on 5.6 would at
> least be planning an upgrade given 5.6 went EOL from Citrix a while back.
>
> -tim
>
> On Fri, Nov 21, 2014 at 3:15 AM, Rohit Yadav 
> wrote:
>
>> Tim, during 4.0/4.1 we used to install a very old xstools 5.6, can we just
>> use that and if we do will that cause any (potential) issue since you
>> mentioned it has few bugs in it?
>>
>> Regards.
>>
>>> On 20-Nov-2014, at 10:23 pm, Tim Mackey  wrote:
>>>
>>> It's the other way around.  Newer XenServer works with older tools, not
>> the
>>> other way.
>>> On Nov 20, 2014 4:57 PM, "Rohit Yadav" 
>> wrote:
>>>
 If XenServer tools are backward compatible then we can perhaps install
>> the
 latest xs-tools (6.2)? Will that cause issue if the underlying
 Xen/XenServer hypervisor version is not 6.2?

> On 20-Nov-2014, at 9:12 pm, Tim Mackey  wrote:
>
> From the XenServer perspective, we have a small problem.  The XenServer
> tools are backward compatible, but not guaranteed forward compatible.
 What
> that means is we'd need to include the XenServer 5.6 tools, and those
 have
> a commercial license.  The XenServer 5.6 tools also have a few bugs
>> which
> were fixed in later versions.
>
> I'm certain we could define a minimum version which would work, and
>> could
> solve any commercial license concerns, but what about having the system
 VMs
> automatically download and apply the correct tools?  Since we know the
> hypervisor version, could we even go so far as automatically update the
> tools should the hypervisor be upgraded?
>
> -tim
>
> On Thu, Nov 20, 2014 at 10:19 AM, Rohit Yadav <
>> rohit.ya...@shapeblue.com
>
> wrote:
>
>> Hi,
>>
>> During the CCCEU conference, I’ve been in some discussions with few
 people
>> on whether we should install/bundle xenserver tools (and vmware tools
>> and/or virtio-modules).
>>
>> I think we can easily do this, but let’s discuss the following;
>>
>> - Which version of xs-tools etc. we should install? For the build
 system,
>> is a publicly available source (iso etc)?
>> - Will installing these tools cause any issue?
>> - If we install all these tools on a single template, could that cause
 any
>> issue?
>>
>> Regards,
>> Rohit Yadav
>> Software Architect, ShapeBlue
>> M. +91 88 262 30892 | rohit.ya...@shapeblue.com
>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>>
>> Find out more about ShapeBlue and our range of CloudStack related
 services
>>
>> IaaS Cloud Design & Build<
>> http://shapeblue.com/iaas-cloud-design-and-build//>
>> CSForge – rapid IaaS deployment framework<
>> http://shapeblue

Re: 05bec59c - kvm, qcow, systemvm qemu-img -o compat

[Rohit Yadav]

I think the correct fix should be to check qemu version and execute 
with/without compat option based on that. Can any of who have the infra use 
this way and test/fix this? I can do it now, but I don’t have reference infra 
to test/fix this.

> On 20-Nov-2014, at 11:37 pm, edison su  wrote:
>
> Hi Leo,
> Our new internal build system are using ubuntu 14.04 or something like
> that, which has qemu 1.x installed by default, that's why I added the
> "compat" option in the build script, otherwise, the image build by
> qemu 1.x, won't work on RHEL 6.x.
> The fix would be, in the build script, check the version of qemu-img,
> if it's 0.x, then don't add "compat" option. There are a lot of people
> still using RHEL 6.x as KVM hypervisor, we have to make sure the image
> we build can still work on these machines.
>
> On Thu, Nov 20, 2014 at 6:49 AM, Leo Simons  
> wrote:
>> Hey Edison, all,
>>
>>  
>> https://github.com/apache/cloudstack/commit/05bec59c1498dbcfb8a1089c86855fd3b433ea58
>>
>> breaks our internal build with
>>
>>+ qemu-img convert -o compat=0.10 -f raw -c -O qcow2 raw.img \
>>  systemvmtemplate-systemvm-persistent-config-4.5.0.124-kvm.qcow2
>>Unknown option 'compat'
>>qemu-img: Invalid options for file format 'qcow2'.
>>
>> This is on CentOS release 6.6, which has qemu-img-0.15.0-1.el6.rfx.x86_64.
>>
>> Based on
>>  http://wiki.qemu.org/OlderNews
>> that seems like it is a really old qemu (august 2011).
>>
>> I'm guessing you have a newer OS / newer qemu? Can you please let me know 
>> what OS, OS version and qemu(-img) version you are using?
>>
>> Also, does anyone know if there some minimum version of qemu-img that should 
>> be used / cloudstack assumes? Is 0.15 still ok to do an acceptable image 
>> conversion with? (we currently don't have any kvm use ourselves, but, I'd 
>> like for our build infra to produce useful kvm images nonetheless).
>>
>> According to
>>  http://wiki.qemu.org/ChangeLog/1.1
>> the -o compat switch was introduced in 1.1.
>>
>> According to
>>  https://github.com/qemu/qemu/commit/9117b47717ad208b12786ce88eacb013f9b3dd1c
>> the default format was changed from 0.10 to 1.1 in qemu 1.7 and onwards.
>>
>> The libvirt people
>>  https://bugzilla.redhat.com/show_bug.cgi?id=997977
>> say they pass -o compat when qemu supports it (so when v >= 1.1 I imagine).
>>
>> I think we should do the same in the build script and I'll make a patch.
>>
>> But, should we publish newer-format images too? According to
>>  http://wiki.qemu.org/Features/Qcow3
>> the new format is much better so I imagine qcow/kvm users will really 
>> appreciate the newer formats.
>>
>> Thoughts?
>>
>>
>> cheers,
>>
>>
>> Leo
>>
>
>
>
> --
> Best Regards,
> Edison

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +91 88 262 30892 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab



Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: Pending Reviews

[Rohit Yadav]

Looks like both of them were merged in all qualifying branches.
Can you check and let me know, if they need to be merged on any other branches 
other than those mentioned on the reviews.

> On 20-Nov-2014, at 10:53 pm, David Bierce  wrote:
>
> Ello —
>
> I had a few patches that were posted to review board.
>
> https://reviews.apache.org/r/25585/ 
> https://reviews.apache.org/r/24779/ 
>
> These patches received some comments and were updated but have otherwise been 
> untouched.  Is there a normal process to accept or reject patches rather than 
> letting them sit in limbo for a few months?
>
>
> Thanks,
> David Bierce
>
>
>
>

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +91 88 262 30892 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab



Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Review Request 28389: CLOUDSTACK-7963: Fixed test case in test_dedicate_guest_vlan_ranges.py

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28389/
---

Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7963
https://issues.apache.org/jira/browse/CLOUDSTACK-7963


Repository: cloudstack-git


Description
---

Test case failed with exception:
int() argument must be a string or a number, not 'NoneType'

It fails while checking if the vlan id of the network is from the dedicated 
range.
The network does not get vlan id in the first place because it is not in 
implemented state.

Solution:
Either deploy a VM in the network or implement the network with persistent 
network offering

Changes:
Used persistent network offering instead of normal offering.


Diffs
-

  test/integration/component/test_dedicate_guest_vlan_ranges.py efba229 

Diff: https://reviews.apache.org/r/28389/diff/


Testing
---

Release a dedicated vlan range when no vlan id is in use ... === TestName: 
test_05_release_range_vlan_in_use | Status : SUCCESS ===
ok

--
Ran 1 test in 61.409s

OK


Thanks,

Ashutosh Kelkar

Review Request 28327: CLOUDSTACK-7938: Marvin - Create a new section in test_data.py for configurable data and change test cases accordingly

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28327/
---

Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7938
https://issues.apache.org/jira/browse/CLOUDSTACK-7938


Repository: cloudstack-git


Description
---

Separating the configurable data from test_data.py and putting it in different 
section so that we know which data needs changes according to the setup and 
environment.

Made according changes in test cases.
Removed the static data from the test cases.
Removed method from common.py which is used no more.


Diffs
-

  test/integration/component/test_lb_secondary_ip.py 841257f 
  test/integration/component/test_netscaler_configs.py 91fb85b 
  test/integration/component/test_netscaler_lb.py e3d65bb 
  test/integration/component/test_netscaler_lb_algo.py 0d571b4 
  test/integration/component/test_netscaler_lb_sticky.py a5f55a8 
  test/integration/component/test_persistent_networks.py f782700 
  test/integration/component/test_portable_ip.py cf0cb3b 
  test/integration/smoke/test_primary_storage.py 310afca 
  tools/marvin/marvin/config/test_data.py 2f97d5f 
  tools/marvin/marvin/lib/common.py 63662b9 

Diff: https://reviews.apache.org/r/28327/diff/


Testing
---

Yes.

All test suites tested and changes working fine.


Thanks,

Gaurav Aradhye

Jenkins build became unstable: simulator-singlerun #687

[jenkins]

See 

Build failed in Jenkins: cloudstack-4.3-maven-build #644

[jenkins]

See 

Changes:

[Rohit Yadav] appliance: use 4.3 git snapshot to configure services

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on cloudstack-buildslave-centos6-87d 
(cloudstack-buildslave-centos6) in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=400
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url git://git.apache.org/cloudstack.git # 
 > timeout=400
Fetching upstream changes from git://git.apache.org/cloudstack.git
 > /usr/bin/git --version # timeout=400
 > /usr/bin/git fetch --tags --progress git://git.apache.org/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
 > /usr/bin/git rev-parse origin/4.3^{commit} # timeout=400
Checking out Revision cef29cc8180f3507b7b1ef6b89f52b0fa7ccbafd (origin/4.3)
 > /usr/bin/git config core.sparsecheckout # timeout=400
 > /usr/bin/git checkout -f cef29cc8180f3507b7b1ef6b89f52b0fa7ccbafd
 > /usr/bin/git rev-list 879f94c74310ed89afe6d25df3b52c00422bbc5a # timeout=400
FATAL: Couldn’t find any executable in /opt/apache-maven-3.0.5
Build step 'Invoke top-level Maven targets' marked build as failure