Re: [VOTE][ACS44]Apache CloudStack 4.4.1 RC 1 in branch 4.4-RC20140924T2100

[Daan Hoogland]

Pierre-Luc,

you could. I have baked version that I will upload to apt-get soon.

On Mon, Sep 29, 2014 at 3:14 AM, Pierre-Luc Dion  wrote:

> Hi Daan,
>
> Do we use following systemvm as part of 4.4.1 rc1?
> http://jenkins.buildacloud.org/view/4.4/job/cloudstack-4.4-systemvm64/130/
>
> Thanks,
>
> PL
>
> On Sun, Sep 28, 2014 at 6:01 PM, Daan Hoogland 
> wrote:
>
> > Hi All,
> >
> > I've created a 4.4.1 release, with the following artifacts up for a vote:
> >
> > Git Branch and Commit SH:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140924T2100
> > Commit: 620ad650bdda23cabdf4c9dc480072c02c59a2d1
> >
> > List of changes:
> >
> >
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/
> >
> > Source release (checksums and signatures are available at the same
> > location):
> > https://dist.apache.org/repos/dist/dev/cloudstack/4.4.1/
> >
> > PGP release keys (signed using 4096R/AA4736F3):
> > https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> >
> > Vote will be open for 72 hours.
> >
> > For sanity in tallying the vote, can PMC members please be sure to
> > indicate "(binding)" with their vote?
> >
> > [ ] +1  approve
> > [ ] +0  no opinion
> > [ ] -1  disapprove (and reason why)
> >
> > --
> > Daan
> >
>



-- 
Daan

Re: Review Request 24882: CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests which are not applicable for hyper-v

[Vinay Varma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24882/
---

(Updated Sept. 29, 2014, 7:13 a.m.)


Review request for cloudstack and Santhosh Edukulla.


Changes
---

Modified the tests as per review comments


Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282


Repository: cloudstack-git


Description
---

CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests 
which are not applicable for hyper-v


Diffs (updated)
-

  test/integration/component/test_escalations_instances.py 73ebf13 
  test/integration/component/test_escalations_ipaddresses.py b29cd1d 
  test/integration/component/test_escalations_isos.py 925c2fb 
  test/integration/component/test_escalations_networks.py c0ab709 
  test/integration/component/test_escalations_snapshots.py 8d289e1 
  test/integration/component/test_escalations_volumes.py 8d6ba99 

Diff: https://reviews.apache.org/r/24882/diff/


Testing
---

Executed the tests and attached are the log files for each of the files changed.


File Attachments


InstancesResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/4ac84a27-fc7c-4b8c-9509-d75a350b53a3__InstancesResults.txt
IPAddressesResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/14aad713-9256-44ed-a9e2-d7225c5c975c__IPAddressesResults.txt
IsoResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/516de1c8-09d0-4e07-abe4-3483463750c3__IsoResults.txt
SnapshotsResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/46f2a6c3-f0f7-4397-918e-bb8df1d63e97__SnapshotsResults.txt
VolumeResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/28d59100-315b-45e8-9aaa-b60982571637__VolumeResults.txt
NetworksResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/869b26e2-9fc2-44cf-bbc1-fc13fd60bc58__NetworksResults.txt


Thanks,

Vinay Varma

Re: Build failed in Jenkins: simulator-singlerun #458

[Srikanteswararao Talluri]

Jenkins couldn¹t find .xml unit test report at the specified location
while it tried to parse the result.  Reason for this is that job deletes
the .xml file at the beginning of every run and since marvin init failed,
it didn¹t regenerate the file. It could happen with failure any other
stage of this job run.

I have just fixed the job to  empty the xunit.xml file instead of deleting
it at the start of every run.

[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the
pattern 'xunit.xml' relative to

Thanks,
~Talluri



On 26/09/14 8:04 pm, "Nitin Mehta"  wrote:

>Hugo/others - Any idea we keep getting this intermittent exception from
>Jenkins and how can we fix it ?
>Googling for NoFoundTestException didn't help much.
>
>Thanks,
>-Nitin
>
>On 26/09/14 5:27 AM, "jenk...@cloudstack.org" 
>wrote:
>
>>See 
>>
>>Changes:
>>
>>[sailaja.mada] Additional Guest OS support for vGPU Test Automation
>>
>>--
>>[...truncated 8854 lines...]
>>[INFO] Apache CloudStack Developer Mode .. SUCCESS
>>[4.938s]
>>[INFO] Apache CloudStack Developer Tools . SUCCESS
>>[2.403s]
>>[INFO] Apache CloudStack apidocs . SUCCESS
>>[2:48.743s]
>>[INFO] Apache CloudStack marvin .. SUCCESS
>>[22.690s]
>>[INFO] Apache CloudStack DevCloud  SUCCESS
>>[5.489s]
>>[INFO] Apache CloudStack DevCloud-KVM  SUCCESS
>>[2.166s]
>>[INFO] 
>>
>>[INFO] BUILD SUCCESS
>>[INFO] 
>>
>>[INFO] Total time: 12:57.949s (Wall Clock)
>>[INFO] Finished at: Fri Sep 26 08:23:07 EDT 2014
>>[INFO] Final Memory: 81M/427M
>>[INFO] 
>>
>>[simulator-singlerun] $ mvn -P developer,simulator -Ddeploydb -pl
>>developer
>>[INFO] Scanning for projects...
>>[INFO]   
>> 
>>[INFO] 
>>
>>[INFO] Building Apache CloudStack Developer Mode 4.5.0-SNAPSHOT
>>[INFO] 
>>
>>[INFO] 
>>[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @
>>cloud-developer ---
>>[INFO] Starting audit...
>>Audit done.
>>
>>[INFO] 
>>[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties
>>(default) @ cloud-developer ---
>>[WARNING] Ignoring missing properties file:
>>>t
>>ils/conf/db.properties.override>
>>[INFO] 
>>[INFO] --- maven-remote-resources-plugin:1.3:process (default) @
>>cloud-developer ---
>>[INFO] 
>>[INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
>>[INFO] Executing tasks
>>
>>main:
>>[INFO] Executed tasks
>>[INFO] 
>>[INFO] >>> exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer
>
>>[INFO] 
>>[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @
>>cloud-developer ---
>>[INFO] Starting audit...
>>Audit done.
>>
>>[INFO] 
>>[INFO] <<< exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer
>><<<
>>[INFO] 
>>[INFO] --- exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer
>>---
>>log4j:WARN No appenders could be found for logger
>>(org.springframework.core.env.StandardEnvironment).
>>log4j:WARN Please initialize the log4j system properly.
>>log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for
>>more info.
>>> WARNING: Provided file does not exist:
>>>t
>>ils/conf/db.properties.override>
>>> WARNING: Provided file does not exist:
>>>l
>>oper-prefill.sql.override>
>>> Initializing database=cloud with host=localhost port=3306
>>username=cloud password=cloud
>>> Running query: drop database if exists `cloud`
>>> Running query: create database `cloud`
>>> Running query: GRANT ALL ON cloud.* to 'cloud'@`localhost`
>>identified by 'cloud'
>>> Running query: GRANT ALL ON cloud.* to 'cloud'@`%`
>>identified by 'cloud'
>>> Initializing database=cloud_usage with host=localhost port=3306
>>username=cloud password=cloud
>>> Running query: drop database if exists `cloud_usage`
>>> Running query: create database `cloud_usage`
>>> Running query: GRANT ALL ON cloud_usage.* to
>>'cloud'@`localhost` identified by 'cloud'
>>> Running query: GRANT ALL ON cloud_usage.* to 'cloud'@`%`
>>identified by 'cloud'
>>> Initializing database=cloudbridge with host=localhost port=33

Re: Review Request 26008: CLOUDSTACK-7627: Automated Remote Access VPN on VPC Test Cases

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26008/#review54795
---


Here are few comments:


test/integration/component/test_remotevpn_vpc.py


try to use validateList() from utils.py



test/integration/component/test_remotevpn_vpc.py


Please use 'self.__class__' instead of directly using the class name which 
improves maintainability of the code.  Just in case, if you want to change the 
class name in future, you don't have to change at all the places.


- SrikanteswaraRao Talluri


On Sept. 25, 2014, 12:15 a.m., Chandan Purushothama wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26008/
> ---
> 
> (Updated Sept. 25, 2014, 12:15 a.m.)
> 
> 
> Review request for cloudstack, sangeetha hariharan, sanjeev n, Santhosh 
> Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7627
> https://issues.apache.org/jira/browse/CLOUDSTACK-7627
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Test Suite for Testing Remote Access VPN on VPC. 
> 
> I successfully automated the following components:
> 
> 1.VPN Client Installation on Linux
> 2.Component that efficiently verifies Remote VPN Access between client and 
> the Server.
> 3.Developed a component that automates VPN Client Configuration and services.
> 4.Test Cases of the Feature
> 5.Tested the Code multiple times on XenServer.
> 6.Tested the Code multiple times on VMWare (To test Skipping of Test Cases)
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_remotevpn_vpc.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py bebcab9 
> 
> Diff: https://reviews.apache.org/r/26008/diff/
> 
> 
> Testing
> ---
> 
> Testing Done on Two Configurations: XenServer and VMWare
> 
> XenServer Test Results:
> 
> Test case 01 : Enable VPN for Public IP Address on the VPC ... === TestName: 
> test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS ===
> ok
> Test case 02 : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser 
> | Status : SUCCESS ===
> ok
> Test case 03 : Add a Different VPN User and Test Access with already existing 
> VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS 
> ===
> ok
> Test case 04 : Add a Previously Removed VPN User from the VPC and Test the 
> VPN Connectivity ... === TestName: 
> test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS ===
> ok
> Test case 05 : Disable the VPN Service on the VPC ... === TestName: 
> test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS ===
> ok
> Test case 06 : Enabled Previously Dsiabled VPN Access to VPC. ... === 
> TestName: test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : 
> SUCCESS ===
> ok
> Test case 07 : Create Nine VPN Users to test the remote.vpn.user.limit=8 
> Configuration parameter ... === TestName: 
> test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS ===
> ok
> 
> --
> Ran 7 tests in 851.687s
> 
> OK
> 
> 
> VMWare Test Results:
> 
> === TestName: None | Status : EXCEPTION ===
> SKIP: Only XenServer VPNClient Template is ready currently. KVM,VMWare or 
> Hyper-V VPN Client Templates are not ready. Skipping the test suite for those 
> configurations
>  >> begin captured stdout << -
> === TestName: None | Status : EXCEPTION ===
> 
> 
> - >> end captured stdout << --
>  >> begin captured logging << 
> CSLog: DEBUG: Obtain the Admin's API Client
> CSLog: DEBUG: Get the dictionary information that will be used during CCP 
> tests, from test_data.py present on the Client
> CSLog: DEBUG: Payload: {'apiKey': 
> u'fGs23pVVge8K-HxeQCo3WBCria7hJs5JZW_j7cKnX1mMpbBKH8JwNCxcWHxBgA-slwW0d1YJHJKbCX_Doc3-GQ',
>  'command': 'listDomains', 'signature': '5BHLOjDELImWRpvI/16LQ/TrLRM=', 
> 'response': 'json'}
> CSLog: DEBUG: Sending GET Cmd : listDomains===
> requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection 
> (1): 10.220.135.90
> requests.packages.urllib3.connectionpool: DEBUG: "GET 
> /client/api?apiKey=fGs23pVVge8K-HxeQCo3WBCria7hJs5JZW_j7cKnX1mMpbBKH8JwNCxcWHxBgA-slwW0d1YJHJKbCX_Doc3-GQ&command=listDomains&response=json&signature=5BHLOjDELImWRpvI%2F16LQ%2FTrLRM%3D
>  HTTP/1.1" 200 159
> CSLog: DEBUG: Response : [{path : u'ROOT', haschild : False, id : 
> u'42ebae70-4375-11e4-86a1-66733ba24ed8', name : u'ROOT', level : 0}]
> CSLog: DEBUG: Payload: {'apiKey': 
> u'fGs23pVVge8K-HxeQCo3WBCria7hJs5JZW_j7cKnX1mMpbBKH

Review Request 26134: CLOUDSTACK-7644: test_persistent_networks.py - SSH failure in case of LB rule due to port mismatch

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26134/
---

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7644
https://issues.apache.org/jira/browse/CLOUDSTACK-7644


Repository: cloudstack-git


Description
---

Reason of failure:
The test cases which were trying to connecte via SSH after configuring LB rule 
were failing because the LB rule has public port , but SSH was connecting 
to default port 22.

Changes:
1. Correct port number is passed now to the SSH method.
2. Fixed all pep8 issues


Diffs
-

  test/integration/component/test_persistent_networks.py 02f6229 

Diff: https://reviews.apache.org/r/26134/diff/


Testing
---

Yes. This change fixed following 3 test cases.

Logs:
test_vpc_delete_account (test_persistent_networks.TestVPCNetworkOperations) ... 
=== TestName: test_vpc_delete_account | Status : SUCCESS ===
ok

--
Ran 1 test in 519.039s

OK
~


test_cleanup_persistent_network_1_true 
(test_persistent_networks.TestRestartPersistentNetwork) ... === TestName: 
test_cleanup_persistent_network_1_true | Status :
SUCCESS ===
ok
test_cleanup_persistent_network_2_false 
(test_persistent_networks.TestRestartPersistentNetwork) ... === TestName: 
test_cleanup_persistent_network_2_false | Status :
SUCCESS ===
ok

--
Ran 2 tests in 564.115s

OK


Thanks,

Gaurav Aradhye

Re: Review Request 24882: CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests which are not applicable for hyper-v

[Alex Brett]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24882/#review54798
---



test/integration/component/test_escalations_instances.py


Minor one but where we're checking multiple hypervisors to skip I'd have 
done e.g. "if self.hypervisor.lower() in ['kvm', 'hyperv']:" or similar rather 
than have two separate ifs...



test/integration/component/test_escalations_isos.py


You don't need this as you've already got above:
from marvin.lib.utils import *


- Alex Brett


On Sept. 29, 2014, 7:13 a.m., Vinay Varma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24882/
> ---
> 
> (Updated Sept. 29, 2014, 7:13 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests 
> which are not applicable for hyper-v
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_escalations_instances.py 73ebf13 
>   test/integration/component/test_escalations_ipaddresses.py b29cd1d 
>   test/integration/component/test_escalations_isos.py 925c2fb 
>   test/integration/component/test_escalations_networks.py c0ab709 
>   test/integration/component/test_escalations_snapshots.py 8d289e1 
>   test/integration/component/test_escalations_volumes.py 8d6ba99 
> 
> Diff: https://reviews.apache.org/r/24882/diff/
> 
> 
> Testing
> ---
> 
> Executed the tests and attached are the log files for each of the files 
> changed.
> 
> 
> File Attachments
> 
> 
> InstancesResults.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/08/20/4ac84a27-fc7c-4b8c-9509-d75a350b53a3__InstancesResults.txt
> IPAddressesResults.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/08/20/14aad713-9256-44ed-a9e2-d7225c5c975c__IPAddressesResults.txt
> IsoResults.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/08/20/516de1c8-09d0-4e07-abe4-3483463750c3__IsoResults.txt
> SnapshotsResults.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/08/20/46f2a6c3-f0f7-4397-918e-bb8df1d63e97__SnapshotsResults.txt
> VolumeResults.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/08/20/28d59100-315b-45e8-9aaa-b60982571637__VolumeResults.txt
> NetworksResults.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/08/20/869b26e2-9fc2-44cf-bbc1-fc13fd60bc58__NetworksResults.txt
> 
> 
> Thanks,
> 
> Vinay Varma
> 
>

Re: [VOTE][ACS44]Apache CloudStack 4.4.1 RC 1 in branch 4.4-RC20140924T2100

[Rohit Yadav]

+1

Testing using KVM on Ubuntu, was able to successfully deploy a basic zone, 
launch VMs.

On 29-Sep-2014, at 12:01 am, Daan Hoogland  wrote:
> Hi All,
>
> I've created a 4.4.1 release, with the following artifacts up for a vote:
>
> Git Branch and Commit SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140924T2100
> Commit: 620ad650bdda23cabdf4c9dc480072c02c59a2d1
>
> List of changes:
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/
>
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/4.4.1/
>
> PGP release keys (signed using 4096R/AA4736F3):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
> Vote will be open for 72 hours.
>
> For sanity in tallying the vote, can PMC members please be sure to
> indicate "(binding)" with their vote?
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
> --
> Daan

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +41 779015219 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab



Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: Review Request 24882: CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests which are not applicable for hyper-v

[Vinay Varma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24882/
---

(Updated Sept. 29, 2014, 11:22 a.m.)


Review request for cloudstack and Santhosh Edukulla.


Changes
---

Uploaded latest patch after incorporating review comments


Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282


Repository: cloudstack-git


Description
---

CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests 
which are not applicable for hyper-v


Diffs (updated)
-

  test/integration/component/test_escalations_instances.py 73ebf13 
  test/integration/component/test_escalations_ipaddresses.py b29cd1d 
  test/integration/component/test_escalations_isos.py 925c2fb 
  test/integration/component/test_escalations_networks.py c0ab709 
  test/integration/component/test_escalations_snapshots.py 8d289e1 
  test/integration/component/test_escalations_volumes.py 8d6ba99 

Diff: https://reviews.apache.org/r/24882/diff/


Testing
---

Executed the tests and attached are the log files for each of the files changed.


File Attachments


InstancesResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/4ac84a27-fc7c-4b8c-9509-d75a350b53a3__InstancesResults.txt
IPAddressesResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/14aad713-9256-44ed-a9e2-d7225c5c975c__IPAddressesResults.txt
IsoResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/516de1c8-09d0-4e07-abe4-3483463750c3__IsoResults.txt
SnapshotsResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/46f2a6c3-f0f7-4397-918e-bb8df1d63e97__SnapshotsResults.txt
VolumeResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/28d59100-315b-45e8-9aaa-b60982571637__VolumeResults.txt
NetworksResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/869b26e2-9fc2-44cf-bbc1-fc13fd60bc58__NetworksResults.txt


Thanks,

Vinay Varma

Re: [VOTE][ACS44]Apache CloudStack 4.4.1 RC 1 in branch 4.4-RC20140924T2100

[Wei ZHOU]

+1

KVM  + Advanzed zone
Upgrade from 4.3.0 to 4.4.1-RC
Everything looks fine.

-Wei

2014-09-29 12:57 GMT+02:00 Rohit Yadav :

> +1
>
> Testing using KVM on Ubuntu, was able to successfully deploy a basic zone,
> launch VMs.
>
> On 29-Sep-2014, at 12:01 am, Daan Hoogland 
> wrote:
> > Hi All,
> >
> > I've created a 4.4.1 release, with the following artifacts up for a vote:
> >
> > Git Branch and Commit SH:
> >
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140924T2100
> > Commit: 620ad650bdda23cabdf4c9dc480072c02c59a2d1
> >
> > List of changes:
> >
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/
> >
> > Source release (checksums and signatures are available at the same
> > location):
> > https://dist.apache.org/repos/dist/dev/cloudstack/4.4.1/
> >
> > PGP release keys (signed using 4096R/AA4736F3):
> > https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> >
> > Vote will be open for 72 hours.
> >
> > For sanity in tallying the vote, can PMC members please be sure to
> > indicate "(binding)" with their vote?
> >
> > [ ] +1  approve
> > [ ] +0  no opinion
> > [ ] -1  disapprove (and reason why)
> >
> > --
> > Daan
>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
> M. +41 779015219 | rohit.ya...@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build<
> http://shapeblue.com/iaas-cloud-design-and-build//>
> CSForge – rapid IaaS deployment framework
> CloudStack Consulting
> CloudStack Infrastructure Support<
> http://shapeblue.com/cloudstack-infrastructure-support/>
> CloudStack Bootcamp Training Courses<
> http://shapeblue.com/cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>

Re: Review Request 24882: CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests which are not applicable for hyper-v

[Vinay Varma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24882/
---

(Updated Sept. 29, 2014, 12:46 p.m.)


Review request for cloudstack and Santhosh Edukulla.


Changes
---

Uploaded new patch after incorporating review comments


Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282


Repository: cloudstack-git


Description
---

CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests 
which are not applicable for hyper-v


Diffs (updated)
-

  test/integration/component/test_escalations_instances.py 73ebf13 
  test/integration/component/test_escalations_ipaddresses.py b29cd1d 
  test/integration/component/test_escalations_isos.py 925c2fb 
  test/integration/component/test_escalations_networks.py c0ab709 
  test/integration/component/test_escalations_snapshots.py 8d289e1 
  test/integration/component/test_escalations_volumes.py 8d6ba99 

Diff: https://reviews.apache.org/r/24882/diff/


Testing
---

Executed the tests and attached are the log files for each of the files changed.


File Attachments


InstancesResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/4ac84a27-fc7c-4b8c-9509-d75a350b53a3__InstancesResults.txt
IPAddressesResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/14aad713-9256-44ed-a9e2-d7225c5c975c__IPAddressesResults.txt
IsoResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/516de1c8-09d0-4e07-abe4-3483463750c3__IsoResults.txt
SnapshotsResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/46f2a6c3-f0f7-4397-918e-bb8df1d63e97__SnapshotsResults.txt
VolumeResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/28d59100-315b-45e8-9aaa-b60982571637__VolumeResults.txt
NetworksResults.txt
  
https://reviews.apache.org/media/uploaded/files/2014/08/20/869b26e2-9fc2-44cf-bbc1-fc13fd60bc58__NetworksResults.txt


Thanks,

Vinay Varma

4.4 and 4.3 NOTICE headers do not have a Copyright line

[Leo Simons]

Hey folks,

http://www.apache.org/dev/licensing-howto.html
“””
NOTICE should contain only the following text, adapted with the product's name 
and copyright dates:

Apache [PRODUCT_NAME]
Copyright [-20XX] The Apache Software Foundation


This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
“””

Master has the copyright line [1], but the 4.4 branch doesn’t, and so the 4.4.1 
RC also doesn’t. I don’t think it’s worth rerolling 4.4.1 for, but thought it 
was worth an e-mail.

If there’s a release management guide or script (pardon my ignorance), it 
should probably learn how to update the year in the Copyright statement.


cheers,


Leo

[1] since April, 
https://github.com/schubergphilis/cloudstack/commit/43ef7ef4730d084d8f5f4b542ba029339b2b80b4

[PULL-REQUEST] Note downloading of source releases exists in LICENSE.md

[Leo Simons]

(ran this command:

  git request-pull -p origin/master https://github.com/lsimons/cloudstack

which results in this:)

The following changes since commit 1d01ee3a60259b2113d14c2890306d7f2e56fbff:

  CLOUDSTACK-7615: Update log msg to print error msg rather than exception 
(2014-09-29 17:15:42 +0530)

are available in the git repository at:

  https://github.com/lsimons/cloudstack 

for you to fetch changes up to a93f8ae19ff2448af5e5e51c2db8c425ce677ec8:

  Note downloading of source releases exists. (2014-09-29 16:24:42 +0200)


Leo Simons (1):
  Note downloading of source releases exists.

 INSTALL.md | 11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/INSTALL.md b/INSTALL.md
index 9924ba9..3c2a338 100644
--- a/INSTALL.md
+++ b/INSTALL.md
@@ -40,12 +40,21 @@ Start the MySQL service:
 
 ## Getting the Source Code
 
-You may get the source code from the repository hosted on Apache:
+Links to source code for official cloudstack releases can be retrieved from 
the cloudstack website at:
+
+http://cloudstack.apache.org/downloads.html
+
+Alternatively, you may get the source code from the repository hosted on 
Apache:
 
 $ git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git
 
 Or, you may fork the repository from the official Apache CloudStack mirror on 
[Github](https://github.com/apache/cloudstack)
 
+To checkout the source code corresponding to a specific release, for example 
4.4.1, do:
+
+$ git fetch origin
+$ git checkout 4.4.1
+
 To checkout a specific branch, for example 4.4, do:
 
 $ git fetch origin

Re: [VOTE][ACS44]Apache CloudStack 4.4.1 RC 1 in branch 4.4-RC20140924T2100

[Leo Simons]

* NOTICE is missing copyright statement (see other e-mail)
* CHANGES.md does not list changes from 4.4.0 to 4.4.1
  (list _is_ at
   
http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/fixed_issues.html
 )
* INSTALL.md states to get source code from git (see other e-mail)
* checksums&sig ok
* build & run from scratch based on README works
* local automated tests inside devcloud-like virtual box pass
  (from tag)
* jenkins-controlled automated tests inside SBP test environment pass
  (from 4.4 branch with identical code aside from version # change)

+1 from me (non-binding :-D)


cheers,


Leo

On Sep 29, 2014, at 12:01 AM, Daan Hoogland  wrote:
> Hi All,
> 
> I've created a 4.4.1 release, with the following artifacts up for a vote:
> 
> Git Branch and Commit SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140924T2100
> Commit: 620ad650bdda23cabdf4c9dc480072c02c59a2d1
> 
> List of changes:
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/
> 
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/4.4.1/
> 
> PGP release keys (signed using 4096R/AA4736F3):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> 
> Vote will be open for 72 hours.
> 
> For sanity in tallying the vote, can PMC members please be sure to
> indicate "(binding)" with their vote?
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
> 
> -- 
> Daan

Re: 4.4 and 4.3 NOTICE headers do not have a Copyright line

[Daan Hoogland]

thanks Leo,

this should be done in build_asf.sh. will have a look.

On Mon, Sep 29, 2014 at 4:14 PM, Leo Simons 
wrote:

> Hey folks,
>
> http://www.apache.org/dev/licensing-howto.html
> “””
> NOTICE should contain only the following text, adapted with the product's
> name and copyright dates:
>
> Apache [PRODUCT_NAME]
> Copyright [-20XX] The Apache Software Foundation
>
>
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> “””
>
> Master has the copyright line [1], but the 4.4 branch doesn’t, and so the
> 4.4.1 RC also doesn’t. I don’t think it’s worth rerolling 4.4.1 for, but
> thought it was worth an e-mail.
>
> If there’s a release management guide or script (pardon my ignorance), it
> should probably learn how to update the year in the Copyright statement.
>
>
> cheers,
>
>
> Leo
>
> [1] since April,
> https://github.com/schubergphilis/cloudstack/commit/43ef7ef4730d084d8f5f4b542ba029339b2b80b4
>
>


-- 
Daan

Re: Build failed in Jenkins: simulator-singlerun #458

[Nitin Mehta]

Thanks Talluri. But why was Marvin init failing so many times ?
Will this not mask the issue ?

-Nitin

On 29/09/14 12:30 AM, "Srikanteswararao Talluri"
 wrote:

>Jenkins couldn¹t find .xml unit test report at the specified location
>while it tried to parse the result.  Reason for this is that job deletes
>the .xml file at the beginning of every run and since marvin init failed,
>it didn¹t regenerate the file. It could happen with failure any other
>stage of this job run.
>
>I have just fixed the job to  empty the xunit.xml file instead of deleting
>it at the start of every run.
>
>[xUnit] [INFO] - Starting to record.
>[xUnit] [INFO] - Processing JUnit
>[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the
>pattern 'xunit.xml' relative to
>
>Thanks,
>~Talluri
>
>
>
>On 26/09/14 8:04 pm, "Nitin Mehta"  wrote:
>
>>Hugo/others - Any idea we keep getting this intermittent exception from
>>Jenkins and how can we fix it ?
>>Googling for NoFoundTestException didn't help much.
>>
>>Thanks,
>>-Nitin
>>
>>On 26/09/14 5:27 AM, "jenk...@cloudstack.org" 
>>wrote:
>>
>>>See 
>>>
>>>Changes:
>>>
>>>[sailaja.mada] Additional Guest OS support for vGPU Test Automation
>>>
>>>--
>>>[...truncated 8854 lines...]
>>>[INFO] Apache CloudStack Developer Mode .. SUCCESS
>>>[4.938s]
>>>[INFO] Apache CloudStack Developer Tools . SUCCESS
>>>[2.403s]
>>>[INFO] Apache CloudStack apidocs . SUCCESS
>>>[2:48.743s]
>>>[INFO] Apache CloudStack marvin .. SUCCESS
>>>[22.690s]
>>>[INFO] Apache CloudStack DevCloud  SUCCESS
>>>[5.489s]
>>>[INFO] Apache CloudStack DevCloud-KVM  SUCCESS
>>>[2.166s]
>>>[INFO] 
>>>
>>>[INFO] BUILD SUCCESS
>>>[INFO] 
>>>
>>>[INFO] Total time: 12:57.949s (Wall Clock)
>>>[INFO] Finished at: Fri Sep 26 08:23:07 EDT 2014
>>>[INFO] Final Memory: 81M/427M
>>>[INFO] 
>>>
>>>[simulator-singlerun] $ mvn -P developer,simulator -Ddeploydb -pl
>>>developer
>>>[INFO] Scanning for projects...
>>>[INFO]  
>>> 
>>>[INFO] 
>>>
>>>[INFO] Building Apache CloudStack Developer Mode 4.5.0-SNAPSHOT
>>>[INFO] 
>>>
>>>[INFO] 
>>>[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @
>>>cloud-developer ---
>>>[INFO] Starting audit...
>>>Audit done.
>>>
>>>[INFO] 
>>>[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties
>>>(default) @ cloud-developer ---
>>>[WARNING] Ignoring missing properties file:
>>>>>u
>>>t
>>>ils/conf/db.properties.override>
>>>[INFO] 
>>>[INFO] --- maven-remote-resources-plugin:1.3:process (default) @
>>>cloud-developer ---
>>>[INFO] 
>>>[INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
>>>[INFO] Executing tasks
>>>
>>>main:
>>>[INFO] Executed tasks
>>>[INFO] 
>>>[INFO] >>> exec-maven-plugin:1.2.1:java (create-schema) @
>>>cloud-developer
>>
>>>[INFO] 
>>>[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @
>>>cloud-developer ---
>>>[INFO] Starting audit...
>>>Audit done.
>>>
>>>[INFO] 
>>>[INFO] <<< exec-maven-plugin:1.2.1:java (create-schema) @
>>>cloud-developer
>>><<<
>>>[INFO] 
>>>[INFO] --- exec-maven-plugin:1.2.1:java (create-schema) @
>>>cloud-developer
>>>---
>>>log4j:WARN No appenders could be found for logger
>>>(org.springframework.core.env.StandardEnvironment).
>>>log4j:WARN Please initialize the log4j system properly.
>>>log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for
>>>more info.
>>>> WARNING: Provided file does not exist:
>>>>>u
>>>t
>>>ils/conf/db.properties.override>
>>>> WARNING: Provided file does not exist:
>>>>>e
>>>l
>>>oper-prefill.sql.override>
>>>> Initializing database=cloud with host=localhost port=3306
>>>username=cloud password=cloud
>>>> Running query: drop database if exists `cloud`
>>>> Running query: create database `cloud`
>>>> Running query: GRANT ALL ON cloud.* to 'cloud'@`localhost`
>>>identified by 'cloud'
>>>> Running query: GRANT ALL ON cloud.* to 'cloud'@`%`
>>>identified by 'cloud'
>>>> Initializing database=cloud_usage with host=localhost
>>>port=3306
>>>username=cloud password=cloud
>>>> Running query: drop database if exists `cloud_usage`
>>>> Ru

Cluster/Host dedication logic

[Logan Barfield]

I was doing some testing with the explicit and implicit dedication
features, and was just wondering about the logic behind it.

>From a service provider perspective this feature seems most useful for
dedicating certain resources to a domain or account.  In other words, a
client pays for a single host/cluster of hosts, and all their instances are
isolated on those hosts.

Right now if a host/cluster is explicitly dedicated system VMs will ignore
that dedication and deploy on the dedicated hosts anyway.  This isn't ideal
because the system VMs consume resources dedicated (and being paid for) by
a single client.  That being said the system VMs have to get deployed
somewhere, so this is probably the best solution overall.

To get around this issue a host can be implicitly dedicated.  In this case
only VMs specifically deployed by the dedicated user will be provisioned on
their resources.  This prevents unwanted resource consumption on the
dedicated infrastructure.  However, this causes the opposite problem with
virtual routers.  The dedicated client's virtual router is deployed on
shared resources, instead of their dedicated infrastructure.  This isn't
ideal, because a customer paying for dedicated resources can be negatively
impacted by an issue with the shared hosts (e.g., host running their VR
goes down causing network outages).

Would it be hard to change the implicit dedication logic to allow the
virtual router owned by an account to reside on their implicitly dedicated
resources, or even to prefer those resources?  This would ensure that a
client paying for dedicated resources would only be affected by outages on
their own hardware.  If a console proxy or secondary storage VM goes down
they would still be affected, but that's a much less urgent/immediately
visible problem than losing a virtual router.

I know the implicit dedication manager views virtual routers as being owned
by the "system" right now, but since they are tied to a specific account I
don't think this change would be too hard to implement.

Is my logic sound on this, or is there something I'm not considering?


Thank You,

Logan Barfield
Tranquil Hosting

Re: how to add new data table to DB

[Kuangching Wang]

By convention, which file should I add to? create-database.sql?

KC

On Sep 28, 2014, at 9:07 PM, Abhinandan Prateek  wrote:

> You still need to write Sql for creating new db table in MySQL db.
> 
> -abhi
> 
>> On 29-Sep-2014, at 6:41 am, Kuang-Ching Wang  
>> wrote:
>> 
>> Hi,
>> 
>> I need to create a new table to store data in the cloudstack DB.  I followed 
>> existing examples to:
>> - add a new VO class, with @Entity and @Table(name = “new_table_name")
>> - add a new Dao interface
>> - add a new DaoImpl class for the interface
>> - update spring context (of my network plugin) with a new bean id for the 
>> new DaoImpl class
>> 
>> I was expecting with the change and a reinstall of my cloudstack-management 
>> service (even doing cloudstack-setup-databases again), a new table would be 
>> created.  However, this is not happening.
>> 
>> Is there some step I missed?
>> 
>> Thanks,
>> KC

--
Dr. Wang, Kuang-Ching, Associate Professor
308 Fluor Daniel Building
ECE Department, Clemson University
Clemson, SC 29634
864-656-0846 (Office)
864-656-7220 (Fax)
kw...@clemson.edu

Re: how to add new data table to DB

[Kuangching Wang]

Why 440to441? What’s the convention to choose which .sql file to add to?  I am 
working against master, which is 4.5.0.

KC
  
On Sep 28, 2014, at 9:25 PM, Jayapal Reddy Uradi 
 wrote:

> You need to add you create table entries in schema-440to441.sql.
> 
> If you do not want to redeploy (without using cloudstack-setup-databases) you 
> can go to mysql prompt, use cloud db and create table.
> After creating table restart the MS will work.
> 
> Thanks,
> Jayapal
> 
> On 29-Sep-2014, at 9:37 AM, Abhinandan Prateek  wrote:
> 
>> You still need to write Sql for creating new db table in MySQL db.
>> 
>> -abhi
>> 
>>> On 29-Sep-2014, at 6:41 am, Kuang-Ching Wang  
>>> wrote:
>>> 
>>> Hi,
>>> 
>>> I need to create a new table to store data in the cloudstack DB.  I 
>>> followed existing examples to:
>>> - add a new VO class, with @Entity and @Table(name = “new_table_name")
>>> - add a new Dao interface
>>> - add a new DaoImpl class for the interface
>>> - update spring context (of my network plugin) with a new bean id for the 
>>> new DaoImpl class
>>> 
>>> I was expecting with the change and a reinstall of my cloudstack-management 
>>> service (even doing cloudstack-setup-databases again), a new table would be 
>>> created.  However, this is not happening.
>>> 
>>> Is there some step I missed?
>>> 
>>> Thanks,
>>> KC
> 

--
Dr. Wang, Kuang-Ching, Associate Professor
308 Fluor Daniel Building
ECE Department, Clemson University
Clemson, SC 29634
864-656-0846 (Office)
864-656-7220 (Fax)
kw...@clemson.edu

Re: [VOTE][ACS44]Apache CloudStack 4.4.1 RC 1 in branch 4.4-RC20140924T2100

[Ian Duffy]

Tested using XenServer 6.2.1.

Brought up an environment within VirtualBox with basic networking and
booted a PE enabled template.

Instance came up without issue, security groups worked, password resets
worked.

+1 for basic functionality working.

On 29 September 2014 15:49, Leo Simons  wrote:

> * NOTICE is missing copyright statement (see other e-mail)
> * CHANGES.md does not list changes from 4.4.0 to 4.4.1
>   (list _is_ at
>
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/fixed_issues.html
> )
> * INSTALL.md states to get source code from git (see other e-mail)
> * checksums&sig ok
> * build & run from scratch based on README works
> * local automated tests inside devcloud-like virtual box pass
>   (from tag)
> * jenkins-controlled automated tests inside SBP test environment pass
>   (from 4.4 branch with identical code aside from version # change)
>
> +1 from me (non-binding :-D)
>
>
> cheers,
>
>
> Leo
>
> On Sep 29, 2014, at 12:01 AM, Daan Hoogland 
> wrote:
> > Hi All,
> >
> > I've created a 4.4.1 release, with the following artifacts up for a vote:
> >
> > Git Branch and Commit SH:
> >
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140924T2100
> > Commit: 620ad650bdda23cabdf4c9dc480072c02c59a2d1
> >
> > List of changes:
> >
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/
> >
> > Source release (checksums and signatures are available at the same
> > location):
> > https://dist.apache.org/repos/dist/dev/cloudstack/4.4.1/
> >
> > PGP release keys (signed using 4096R/AA4736F3):
> > https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> >
> > Vote will be open for 72 hours.
> >
> > For sanity in tallying the vote, can PMC members please be sure to
> > indicate "(binding)" with their vote?
> >
> > [ ] +1  approve
> > [ ] +0  no opinion
> > [ ] -1  disapprove (and reason why)
> >
> > --
> > Daan
>
>

Re: Review Request 25248: Fix NPE in case VM is started and its template does not exist anymore

[Animesh Chaturvedi]

> On Sept. 2, 2014, 7:01 p.m., Nitin Mehta wrote:
> > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java, line 
> > 814
> > 
> >
> > Checking for template==null masks the whole problem. 
> > 1. Such validations should have happenned in the deployvm api layer if 
> > it comes from that api.
> > 2. If its coming from a startvm api its perfectly fine to have the 
> > template removed since the volume already exists. 
> > 3. If you see how template is used below...if it has to 'create' a new 
> > volume the template shouldnt be removed but again the validations should be 
> > in api layer.
> 
> Rohit Yadav wrote:
> So, I can read code too, upper layers are not passing the template so 
> what do you propose? How may I fix this then?
> 
> Nitin Mehta wrote:
> Firstly, check whether the issue is reproducible. Just realized that from 
> 4.3 onwards templates have 'Inactive' state to mark it removed. Removed 
> attribute should never be set so this exception shouldnt be hit . Check when 
> is the removed flag set as it should be a bug(check CLOUDSTACK-5997 and 
> backporting it already fixes that). 
> Secondly, even if this bug doesnt exist, do a sanity check and see this 
> kind of check is in the api which will ultimately call this method. Check if 
> apis are missing them. But some apis might not need it like StartVm, Rebootvm 
> where new volume is not created. Do write a util method which could be shared 
> by all apis. I guess that should be good enough.
> 
> Rohit Yadav wrote:
> This was for 4.3.1, I guess this is a special case and not a blocker. The 
> issue was reproducible when say an admin removed a template where a user may 
> be trying to create a VM and was in a wizard. I'm closing as we're not 
> putting this for 4.3.1 release.
> 
> Nitin Mehta wrote:
> Please punt it for 4.5. We should fix it.

Is anyone of you putting a fix for 4.5


- Animesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25248/#review52059
---


On Sept. 2, 2014, 1:53 p.m., Rohit Yadav wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25248/
> ---
> 
> (Updated Sept. 2, 2014, 1:53 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, edison su, Darren Shepherd, 
> Sebastien Goasguen, and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6945
> https://issues.apache.org/jira/browse/CLOUDSTACK-6945
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixes https://issues.apache.org/jira/browse/CLOUDSTACK-6945
> 
> 
> Diffs
> -
> 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 2fd7a52 
> 
> Diff: https://reviews.apache.org/r/25248/diff/
> 
> 
> Testing
> ---
> 
> Builds cleanly, will throw resource not available exception when template 
> does not exist.
> 
> 
> Thanks,
> 
> Rohit Yadav
> 
>

Re: Review Request 26008: CLOUDSTACK-7627: Automated Remote Access VPN on VPC Test Cases

[Chandan Purushothama]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26008/
---

(Updated Sept. 29, 2014, 11:16 p.m.)


Review request for cloudstack, sangeetha hariharan, sanjeev n, Santhosh 
Edukulla, and SrikanteswaraRao Talluri.


Changes
---

Incorporated reviewers recommendations. Kindly review and check it in,

Thank you,
Chandan.


Bugs: CLOUDSTACK-7627
https://issues.apache.org/jira/browse/CLOUDSTACK-7627


Repository: cloudstack-git


Description
---

Test Suite for Testing Remote Access VPN on VPC. 

I successfully automated the following components:

1.VPN Client Installation on Linux
2.Component that efficiently verifies Remote VPN Access between client and the 
Server.
3.Developed a component that automates VPN Client Configuration and services.
4.Test Cases of the Feature
5.Tested the Code multiple times on XenServer.
6.Tested the Code multiple times on VMWare (To test Skipping of Test Cases)


Diffs (updated)
-

  test/integration/component/test_remotevpn_vpc.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py 00fa52c 

Diff: https://reviews.apache.org/r/26008/diff/


Testing
---

Testing Done on Two Configurations: XenServer and VMWare

XenServer Test Results:

Test case 01 : Enable VPN for Public IP Address on the VPC ... === TestName: 
test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS ===
ok
Test case 02 : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser | 
Status : SUCCESS ===
ok
Test case 03 : Add a Different VPN User and Test Access with already existing 
VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS 
===
ok
Test case 04 : Add a Previously Removed VPN User from the VPC and Test the VPN 
Connectivity ... === TestName: 
test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS ===
ok
Test case 05 : Disable the VPN Service on the VPC ... === TestName: 
test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS ===
ok
Test case 06 : Enabled Previously Dsiabled VPN Access to VPC. ... === TestName: 
test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : SUCCESS ===
ok
Test case 07 : Create Nine VPN Users to test the remote.vpn.user.limit=8 
Configuration parameter ... === TestName: 
test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS ===
ok

--
Ran 7 tests in 851.687s

OK


VMWare Test Results:

=== TestName: None | Status : EXCEPTION ===
SKIP: Only XenServer VPNClient Template is ready currently. KVM,VMWare or 
Hyper-V VPN Client Templates are not ready. Skipping the test suite for those 
configurations
 >> begin captured stdout << -
=== TestName: None | Status : EXCEPTION ===


- >> end captured stdout << --
 >> begin captured logging << 
CSLog: DEBUG: Obtain the Admin's API Client
CSLog: DEBUG: Get the dictionary information that will be used during CCP 
tests, from test_data.py present on the Client
CSLog: DEBUG: Payload: {'apiKey': 
u'fGs23pVVge8K-HxeQCo3WBCria7hJs5JZW_j7cKnX1mMpbBKH8JwNCxcWHxBgA-slwW0d1YJHJKbCX_Doc3-GQ',
 'command': 'listDomains', 'signature': '5BHLOjDELImWRpvI/16LQ/TrLRM=', 
'response': 'json'}
CSLog: DEBUG: Sending GET Cmd : listDomains===
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection 
(1): 10.220.135.90
requests.packages.urllib3.connectionpool: DEBUG: "GET 
/client/api?apiKey=fGs23pVVge8K-HxeQCo3WBCria7hJs5JZW_j7cKnX1mMpbBKH8JwNCxcWHxBgA-slwW0d1YJHJKbCX_Doc3-GQ&command=listDomains&response=json&signature=5BHLOjDELImWRpvI%2F16LQ%2FTrLRM%3D
 HTTP/1.1" 200 159
CSLog: DEBUG: Response : [{path : u'ROOT', haschild : False, id : 
u'42ebae70-4375-11e4-86a1-66733ba24ed8', name : u'ROOT', level : 0}]
CSLog: DEBUG: Payload: {'apiKey': 
u'fGs23pVVge8K-HxeQCo3WBCria7hJs5JZW_j7cKnX1mMpbBKH8JwNCxcWHxBgA-slwW0d1YJHJKbCX_Doc3-GQ',
 'name': u'XenRT-Zone-0', 'command': 'listZones', 'signature': 
'MH3voxNCEMIMA3deggb/EVxAog8=', 'response': 'json'}
CSLog: DEBUG: Sending GET Cmd : listZones===
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection 
(1): 10.220.135.90
requests.packages.urllib3.connectionpool: DEBUG: "GET 
/client/api?response=json&apiKey=fGs23pVVge8K-HxeQCo3WBCria7hJs5JZW_j7cKnX1mMpbBKH8JwNCxcWHxBgA-slwW0d1YJHJKbCX_Doc3-GQ&command=listZones&name=XenRT-Zone-0&signature=MH3voxNCEMIMA3deggb%2FEVxAog8%3D
 HTTP/1.1" 200 416
CSLog: DEBUG: Response : [{localstorageenabled : False, name : u'XenRT-Zone-0', 
guestcidraddress : u'192.168.200.0/24', tags : [], zonetoken : 
u'd8f55583-777e-3f86-9a97-8b35a24bd558', dns1 : u'10.220.247.5', 
securitygroupsenabled : False, allocationstate : u'Enabled', internaldns1 : 
u'10.220.112.11', dhcpprovider : u'VirtualRouter', netwo

Re: Shellshock

[Sheng Yang]

http://systemvm-public-ip/cgi-bin/ipcalc is NOT a bash script, so it's
normal that it cannot be exploited.

--Sheng

On Fri, Sep 26, 2014 at 1:57 PM, Demetrius Tsitrelis <
demetrius.tsitre...@citrix.com> wrote:

> Do you mean you tried setting the USER_AGENT like in
> https://community.qualys.com/blogs/securitylabs/2014/09/25/qualysguard-remote-detection-for-bash-shellshock
> ?
>
>
> -Original Message-
> From: Ian Duffy [mailto:i...@ianduffy.ie]
> Sent: Friday, September 26, 2014 6:56 AM
> To: CloudStack Dev
> Subject: Re: Shellshock
>
> Tried this against the latest system vms built on Jenkins.
>
> Didn't get a successful exploited response. Tested against http://systemvm
> - public-ip/cgi-bin/ipcalc
> On 25 Sep 2014 16:56, "Abhinandan Prateek"  wrote:
>
> >
> > After heart bleed we are Shell shocked
> > http://www.bbc.com/news/technology-29361794 !
> > It may not affect cloudstack directly as it is a vulnerability that
> > affects bash, and allows the attacker to take control of the system
> > running bash shell.
> >
> > -abhi
>

Re: Review Request 24991: CLOUDSTACK-6697: BigSwitchVns plugin update

[Kuang-Ching Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24991/
---

(Updated Sept. 30, 2014, 1:02 a.m.)


Review request for cloudstack, Chiradeep Vittal, David Nalley, Sebastien 
Goasguen, and Hugo Trippaers.


Changes
---

adding missing declaration in two schema files


Repository: cloudstack-git


Description
---

CLOUDSTACK-6697: BigSwitchVns plugin update

This patch updates the BigSwitch network plugin in the following ways:
- provides compatibility with Big Switch's Big Cloud Fabric controller
- provides L2 Connectivity service
- uses HTTPS with sticky/trust-always certificate handling
- Updates plugin terminology in package name, code, and GUI to BigSwitchBCF 
with isolation method referred to as "BCF_SEGMENT"


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 
c5a9bf286df8d502a6ca33661fb52ee717643566 
  api/src/com/cloud/network/PhysicalNetwork.java 
7c9349d932771fdbecc4a0b1ae4cad28b3d67857 
  client/WEB-INF/classes/resources/messages.properties 
c9eb7ae24666ca8f3dbd5914539af827489313b6 
  client/WEB-INF/classes/resources/messages_fr_FR.properties 
004187f69b4f8449c88214ff3b047ef603ad65dc 
  client/WEB-INF/classes/resources/messages_ja_JP.properties 
7bc90b538a4f8160e74b72720bc83a776d244b75 
  client/WEB-INF/classes/resources/messages_ko_KR.properties 
ce79d2e5b27d861960c8ee1fd4b1e099ed883ef3 
  client/WEB-INF/classes/resources/messages_nl_NL.properties 
89ef828a3c157228680b90adbcb76b182f342638 
  client/WEB-INF/classes/resources/messages_pt_BR.properties 
8ee08ba3cbbfa3285b7ad728b8b119ee9e379c65 
  client/WEB-INF/classes/resources/messages_ru_RU.properties 
ff68668e6ff75546236a11d29e37d8d4ad1f58f1 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 
ebba5e0bb07a992ee55eb2ab8e71a11073064cfe 
  client/pom.xml dccf18d2d4dec0390c487ca87f4cf116f5deb8f7 
  client/tomcatconf/commands.properties.in 
09b7ddc8ee9e9dd85a72f81b373bc69a0ec91942 
  engine/schema/src/com/cloud/user/dao/VmDiskStatisticsDaoImpl.java 
e1136d3cf567b73fd1198181aea4d6995df6b78a 
  plugins/network-elements/bigswitch-vns/pom.xml 
6665454e4190f1d10fe91dfa62828e456758d0d8 
  
plugins/network-elements/bigswitch-vns/resources/META-INF/cloudstack/vns/module.properties
 5783d38e5cb78be0d418c80981246d721d18b62a 
  
plugins/network-elements/bigswitch-vns/resources/META-INF/cloudstack/vns/spring-vns-context.xml
 d5bb92afe3d3051dbdd4b4d49698c313c77d255f 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java
 e950abe3bed85b75a20be2b8c4537a2fbd6be39e 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java
 534bb7f9f9154a652a20310fe020bddc4249ef54 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java
 82c2fe90d63e0148bca8de9ce8612e4dd53cf735 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java
 c3b9a9d6d9504e34cbe1294ac640f56aab101395 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java
 72ac98ac9e0a1ae4858019e3baccc160300e24bf 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java
 6cf169bbfc97b57561af729aef297c76230fd118 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java
 076b187fdf48cf776902dc9a91dc26e00396158a 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java
 0cae01d471dd9c5c504002c24f865ded59812d9e 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java
 8310b0763708c3f049ef4ce427d09f0c07cd05b3 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java
 39cd26649c9bb0c4993f55bef65edfc326c4ceda 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java
 40f09207606115a5d0ec7f9378c4c52d16405dfd 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java
 5c6f555c8a40a4b785aed6fdfa743131006be209 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java
 1e2155dcd899bc11f9e9463cec432c020751e905 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java
 4cde78e503935f7ba3b4a90a6f4568f0dd32c7ab 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java
 7942b6f2be3467465334b0628577b87564dbdab2 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java
 790ac9c6afbee9156cb8d26ee2a2b5980fe4ce18 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java
 01b5d49a90bb4428716d6b9c344d4ccfc97fb34f 
  
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/AttachmentData.java
 f1866e2621b6f9c19e4a9be3107

RE: Shellshock

[Demetrius Tsitrelis]

http://systemvm-public-ip/cgi-bin/ipcalc is a perl script.

-Original Message-
From: Sheng Yang [mailto:sh...@yasker.org] 
Sent: Monday, September 29, 2014 5:21 PM
To: 
Subject: Re: Shellshock

http://systemvm-public-ip/cgi-bin/ipcalc is NOT a bash script, so it's normal 
that it cannot be exploited.

--Sheng

On Fri, Sep 26, 2014 at 1:57 PM, Demetrius Tsitrelis < 
demetrius.tsitre...@citrix.com> wrote:

> Do you mean you tried setting the USER_AGENT like in 
> https://community.qualys.com/blogs/securitylabs/2014/09/25/qualysguard
> -remote-detection-for-bash-shellshock
> ?
>
>
> -Original Message-
> From: Ian Duffy [mailto:i...@ianduffy.ie]
> Sent: Friday, September 26, 2014 6:56 AM
> To: CloudStack Dev
> Subject: Re: Shellshock
>
> Tried this against the latest system vms built on Jenkins.
>
> Didn't get a successful exploited response. Tested against 
> http://systemvm
> - public-ip/cgi-bin/ipcalc
> On 25 Sep 2014 16:56, "Abhinandan Prateek"  wrote:
>
> >
> > After heart bleed we are Shell shocked
> > http://www.bbc.com/news/technology-29361794 !
> > It may not affect cloudstack directly as it is a vulnerability that 
> > affects bash, and allows the attacker to take control of the system 
> > running bash shell.
> >
> > -abhi
>

Re: [VOTE][ACS44]Apache CloudStack 4.4.1 RC 1 in branch 4.4-RC20140924T2100

[Pierre-Luc Dion]

+1

basic deployment, did tests upgrade from 4.3.0  and 4.2.1 to 4.4.1 , it
went smoothly in both cases.
I've tests using XenServer 6.2.0 with system vm from :
http://jenkins.buildacloud.org/view/4.4/job/cloudstack-4.4-systemvm64/131/

Please let me know what should be the URLs for system vm that will goes in
the RN if this vote pass.




*Pierre-Luc DION*
Architecte de Solution Cloud | Cloud Solutions Architect
t 855.652.5683

*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_


On Mon, Sep 29, 2014 at 5:22 PM, Ian Duffy  wrote:

> Tested using XenServer 6.2.1.
>
> Brought up an environment within VirtualBox with basic networking and
> booted a PE enabled template.
>
> Instance came up without issue, security groups worked, password resets
> worked.
>
> +1 for basic functionality working.
>
> On 29 September 2014 15:49, Leo Simons  wrote:
>
> > * NOTICE is missing copyright statement (see other e-mail)
> > * CHANGES.md does not list changes from 4.4.0 to 4.4.1
> >   (list _is_ at
> >
> >
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/fixed_issues.html
> > )
> > * INSTALL.md states to get source code from git (see other e-mail)
> > * checksums&sig ok
> > * build & run from scratch based on README works
> > * local automated tests inside devcloud-like virtual box pass
> >   (from tag)
> > * jenkins-controlled automated tests inside SBP test environment pass
> >   (from 4.4 branch with identical code aside from version # change)
> >
> > +1 from me (non-binding :-D)
> >
> >
> > cheers,
> >
> >
> > Leo
> >
> > On Sep 29, 2014, at 12:01 AM, Daan Hoogland 
> > wrote:
> > > Hi All,
> > >
> > > I've created a 4.4.1 release, with the following artifacts up for a
> vote:
> > >
> > > Git Branch and Commit SH:
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140924T2100
> > > Commit: 620ad650bdda23cabdf4c9dc480072c02c59a2d1
> > >
> > > List of changes:
> > >
> >
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/
> > >
> > > Source release (checksums and signatures are available at the same
> > > location):
> > > https://dist.apache.org/repos/dist/dev/cloudstack/4.4.1/
> > >
> > > PGP release keys (signed using 4096R/AA4736F3):
> > > https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> > >
> > > Vote will be open for 72 hours.
> > >
> > > For sanity in tallying the vote, can PMC members please be sure to
> > > indicate "(binding)" with their vote?
> > >
> > > [ ] +1  approve
> > > [ ] +0  no opinion
> > > [ ] -1  disapprove (and reason why)
> > >
> > > --
> > > Daan
> >
> >
>

Re: Review Request 26080: Automation for volume life cycle testPath

[prashant mishra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26080/
---

(Updated Sept. 30, 2014, 5:33 a.m.)


Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7632
https://issues.apache.org/jira/browse/CLOUDSTACK-7632


Repository: cloudstack-git


Description
---

Automation for volume life cycle testPath


Diffs (updated)
-

  test/integration/testpaths/testpath_volumelifecycle.py PRE-CREATION 

Diff: https://reviews.apache.org/r/26080/diff/


Testing
---

tested on following setup 

1-only shared storage
2-local storage + zone wide storage +shared storage


Thanks,

prashant mishra

Review Request 26165: CLOUDSTACK-7646: test_nuage_vsp.py - Fixed basic indentation issues, list index issues, marked it as invalid because the test cases needs attention by the original author as it d

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26165/
---

Review request for cloudstack, Suresh Ramamurthy and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7646
https://issues.apache.org/jira/browse/CLOUDSTACK-7646


Repository: cloudstack-git


Description
---

It fails even after fixing the indetation and list index issues.
Also it has hard coded information about the nuage VSP plugin.

I request Suresh to take a look, move the hard coded information to config and 
read it from there.
Also it should be ok to move test to Smoke as it is a basic validation test?
Inputs from Suresh would be helpful.

Changes in this patch:
1. Fix indentation
2. Fix list index issues
3. Fix pep8 issues
4. Move it to Smoke folder


Diffs
-

  test/integration/component/test_nuage_vsp.py 096b9d1 
  test/integration/smoke/test_nuage_vsp.py PRE-CREATION 

Diff: https://reviews.apache.org/r/26165/diff/


Testing
---

Test case does not pass.


Thanks,

Gaurav Aradhye

Re: Review Request 25885: CLOUDSTACK-7594: Adding automation test cases for Stopped VM test path

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25885/#review54951
---



test/integration/testpaths/testpath_stopped_vm.py


Did you test this?, Router won't be destroyed immediately. It will happen 
after gc interval.



test/integration/testpaths/testpath_stopped_vm.py


same as previous comment, Router won't be destroyed immediately after 
destroying all the guests in that network.



test/integration/testpaths/testpath_stopped_vm.py


What is the difference between 2nd test and this?


- SrikanteswaraRao Talluri


On Sept. 22, 2014, 5:46 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25885/
> ---
> 
> (Updated Sept. 22, 2014, 5:46 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7594
> https://issues.apache.org/jira/browse/CLOUDSTACK-7594
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Automation test cases for Stopped VM test path.
> 
> 
> Diffs
> -
> 
>   test/integration/testpaths/__init__.py PRE-CREATION 
>   test/integration/testpaths/testpath_stopped_vm.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25885/diff/
> 
> 
> Testing
> ---
> 
> Yes. 4 test cases are failing due to wrong router state, I am investigating 
> on this.
> 
> Log:
> Positive test for stopped VM test path - T1 ... === TestName: 
> test_01_pt_deploy_vm_without_startvm | Status : FAILED ===
> FAIL
> Positive test for stopped VM test path - T1 variant ... === TestName: 
> test_02_pt_deploy_vm_with_startvm_true | Status : FAILED ===
> FAIL
> Positive test for stopped VM test path - T2 ... === TestName: 
> test_03_pt_deploy_vm_with_startvm_false | Status : FAILED ===
> FAIL
> Positive test for stopped VM test path - T2 variant ... === TestName: 
> test_04_pt_deploy_vm_with_startvm_true | Status : FAILED ===
> FAIL
> Positive test for stopped VM test path - T3 and variant ... === TestName: 
> test_05_pt_startvm_false_attach_disk | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T4 ... === TestName: 
> test_06_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T5 ... === TestName: 
> test_07_pt_startvm_false_attach_iso | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T5 variant ... === TestName: 
> test_08_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS ===
> ok
> 
> ==
> FAIL: Positive test for stopped VM test path - T1
> --
> Traceback (most recent call last):
>   File "/root/test/testpath_stopped_vm.py", line 260, in 
> test_01_pt_deploy_vm_without_startvm
> self.assertTrue(response[0], response[1])
> AssertionError: Router state should be Stopped, it is Running
>  >> begin captured stdout << -
> === TestName: test_01_pt_deploy_vm_without_startvm | Status : FAILED ===
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 26165: CLOUDSTACK-7646: test_nuage_vsp.py - Fixed basic indentation issues, list index issues, marked it as invalid because the test cases needs attention by the original author as

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26165/#review54954
---


Let's fix all the outstanding issues related to the script before moving it to 
smoke test folder. Otherwise, It will effect the BVT pass rates.

OR
We can move this test to smoke folder and skip it until it is properly running 
or the setup with Nuage VSP is available..

- SrikanteswaraRao Talluri


On Sept. 30, 2014, 5:53 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26165/
> ---
> 
> (Updated Sept. 30, 2014, 5:53 a.m.)
> 
> 
> Review request for cloudstack, Suresh Ramamurthy and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7646
> https://issues.apache.org/jira/browse/CLOUDSTACK-7646
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> It fails even after fixing the indetation and list index issues.
> Also it has hard coded information about the nuage VSP plugin.
> 
> I request Suresh to take a look, move the hard coded information to config 
> and read it from there.
> Also it should be ok to move test to Smoke as it is a basic validation test?
> Inputs from Suresh would be helpful.
> 
> Changes in this patch:
> 1. Fix indentation
> 2. Fix list index issues
> 3. Fix pep8 issues
> 4. Move it to Smoke folder
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_nuage_vsp.py 096b9d1 
>   test/integration/smoke/test_nuage_vsp.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26165/diff/
> 
> 
> Testing
> ---
> 
> Test case does not pass.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>