Jenkins build is back to stable : simulator-singlerun #404

[jenkins]

See 

Re: Review Request 25773: Adding update method in base.py to update storagepool

[prashant mishra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25773/
---

(Updated Sept. 19, 2014, 7:58 a.m.)


Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7579

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7579


Repository: cloudstack-git


Description
---

Adding update method in base.py  to update storagepool


Diffs (updated)
-

  tools/marvin/marvin/lib/base.py 04217b2 

Diff: https://reviews.apache.org/r/25773/diff/


Testing
---

Tested with zone wide storage : successfully  updated tag of a primary storage 
pool


Thanks,

prashant mishra

Re: Review Request 25773: Adding update method in base.py to update storagepool

[prashant mishra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25773/
---

(Updated Sept. 19, 2014, 11:21 a.m.)


Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7579

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7579


Repository: cloudstack-git


Description
---

Adding update method in base.py  to update storagepool


Diffs (updated)
-

  tools/marvin/marvin/lib/base.py 04217b2 

Diff: https://reviews.apache.org/r/25773/diff/


Testing
---

Tested with zone wide storage : successfully  updated tag of a primary storage 
pool


Thanks,

prashant mishra

Re: Review Request 25773: Adding update method in base.py to update storagepool

[prashant mishra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25773/
---

(Updated Sept. 19, 2014, 11:36 a.m.)


Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7579

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7579


Repository: cloudstack-git


Description
---

Adding update method in base.py  to update storagepool


Diffs (updated)
-

  tools/marvin/marvin/lib/base.py 04217b2 

Diff: https://reviews.apache.org/r/25773/diff/


Testing
---

Tested with zone wide storage : successfully  updated tag of a primary storage 
pool


Thanks,

prashant mishra

PrimaryStorageDownloadCommand question

[Hugo Trippaers]

Heya,

I’m looking at fixing a potential NPE in the PrimaryStorageDownloadCommand. 
When the constructor 'public PrimaryStorageDownloadCommand(String url, 
StoragePool pool, int wait) ‘ is used it calls 'super(null, url, null, null);’ 
which in the constructor unboxes the fourth parameter from a Long to a long. 
This would generate an NPE.

There is several easy fixes, but looking through the code i failed to find 
where this command is used. Can somebody shine a light on this, or is this 
class a relic from days gone by that we could remove.

CC Edison as he last touched this piece of code

Cheers,

Hugo

[DISCUSS] Replace /tools/devcloud or create /tools/devcloud4

[Ian Duffy]

Hi All,

To my knowledge the work under /tools/devcloud doesn't work with the later
versions of cloudstack.

I have been working on creating a devcloud environment centered around
vagrant https://github.com/imduffy15/devcloud4

This has been tested enough for me to be comfortable to share it out to a
wide audience.

What are peoples views on introducing it? (readmes available on the github
page for those who want a description)

Thanks,

Ian

Re: [DISCUSS] Replace /tools/devcloud or create /tools/devcloud4

[sebgoa]

On Sep 19, 2014, at 1:51 PM, Ian Duffy  wrote:

> Hi All,
> 
> To my knowledge the work under /tools/devcloud doesn't work with the later
> versions of cloudstack.
> 
> I have been working on creating a devcloud environment centered around
> vagrant https://github.com/imduffy15/devcloud4
> 
> This has been tested enough for me to be comfortable to share it out to a
> wide audience.
> 
> What are peoples views on introducing it? (readmes available on the github
> page for those who want a description)
> 

I am +1 for dumping your stuff in tools/devcloud directly

I have used it and it works great. it should be in 4.4

> Thanks,
> 
> Ian

Re: [DISCUSS] Replace /tools/devcloud or create /tools/devcloud4

[Rohit Yadav]

On 19-Sep-2014, at 2:00 pm, sebgoa  wrote:

> I am +1 for dumping your stuff in tools/devcloud directly
>
> I have used it and it works great. it should be in 4.4

+1

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +41 779015219 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab



Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: [DISCUSS] Replace /tools/devcloud or create /tools/devcloud4

[Daan Hoogland]

Please do

On Fri, Sep 19, 2014 at 2:22 PM, Rohit Yadav 
wrote:

>
> On 19-Sep-2014, at 2:00 pm, sebgoa  wrote:
>
> > I am +1 for dumping your stuff in tools/devcloud directly
> >
> > I have used it and it works great. it should be in 4.4
>
> +1
>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
> M. +41 779015219 | rohit.ya...@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build<
> http://shapeblue.com/iaas-cloud-design-and-build//>
> CSForge – rapid IaaS deployment framework
> CloudStack Consulting
> CloudStack Infrastructure Support<
> http://shapeblue.com/cloudstack-infrastructure-support/>
> CloudStack Bootcamp Training Courses<
> http://shapeblue.com/cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>



-- 
Daan

Re: PrimaryStorageDownloadCommand question

[Mike Tutkowski]

In HypervDirectConnectResourceTest appears to be the only place in the
codebase where we actually make an instance of the
PrimaryStorageDownloadCommand (and, as the name of the class implies, it's
for testing purposes):

private PrimaryStorageDownloadCommand samplePrimaryDownloadCommand() {

String cmdJson =

"{\"localPath\":" + s_testLocalStorePathJSON +
",\"poolUuid\":\"" + s_testLocalStoreUUID + "\",\"poolId\":201," +
"\"secondaryStorageUrl\":" +

"\"nfs://10.70.176.36/mnt/cshv3/secondarystorage\"," +
"\"primaryStorageUrl\":" + "\"nfs://10.70.176.29E:DisksDisks\"," +
"\"url\":" +

"\"nfs://
10.70.176.36/mnt/cshv3/secondarystorage/template/tmpl//2/204//af39aa7f-2b12-37e1-86d3-e23f2f005101.vhdx\
"," +

"\"format\":\"VHDX\",\"accountId\":2," + "\"name\":" +
"\"204-2-5a1db1ac-932b-3e7e-a0e8-5684c72cb862\"" +
",\"contextMap\":{},\"wait\":10800}";

PrimaryStorageDownloadCommand cmd = s_gson.fromJson(cmdJson,
PrimaryStorageDownloadCommand.class);

return cmd;

}

On Fri, Sep 19, 2014 at 5:41 AM, Hugo Trippaers  wrote:

> Heya,
>
> I’m looking at fixing a potential NPE in the
> PrimaryStorageDownloadCommand. When the constructor 'public
> PrimaryStorageDownloadCommand(String url, StoragePool pool, int wait) ‘ is
> used it calls 'super(null, url, null, null);’ which in the constructor
> unboxes the fourth parameter from a Long to a long. This would generate an
> NPE.
>
> There is several easy fixes, but looking through the code i failed to find
> where this command is used. Can somebody shine a light on this, or is this
> class a relic from days gone by that we could remove.
>
> CC Edison as he last touched this piece of code
>
> Cheers,
>
> Hugo




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Mike Tutkowski]

If it helps for whoever is going to investigate this virtual router issue,
it looks like the management server cannot SSH into the virtual router:

INFO  [c.c.h.v.r.VmwareResource] (DirectAgent-30:ctx-1fe5b2aa
192.168.129.82, job-55/job-56, cmd: CheckSshCommand) Could not connect to
192.168.128.34 due to java.net.ConnectException: Connection refused


On Thu, Sep 18, 2014 at 8:12 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Turning off the version checking didn't fix the router issue.
>
> It gets cloned, then started, gets to the command prompt, then is shut
> down and restarted. It finally ends up in the stopped state and I get an
> error back in the GUI that deploying my VM failed.
>
> On Thu, Sep 18, 2014 at 7:46 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Actually, the virtual router says it requires an upgrade.
>>
>> I think I can just turn that check off and re-run my create-VM test.
>>
>> On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> OK, I checked in a fix for this:
>>>
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=18e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81509e6885aa536932
>>>
>>> I did notice that both before and after my fix that the virtual router
>>> is NOT coming up.
>>>
>>> The system VM being cloned and the starting of the VM looks fine. It
>>> gets to the command prompt and then a little while later is shut down and
>>> restarted. I get an error in the GUI indicating that my VM deployment
>>> failed.
>>>
>>> I don't personally know a whole lot about how the virtual router code
>>> works, so we should pass that on to an appropriate developer.
>>>
>>> On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 Just destroyed and re-created my env from scratch without
 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.

 I think I know what the author was intending with the code that is
 causing the problem, so I'll go ahead and put in what I think is a fix,
 re-create my env, and see if it works.

 On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev 
 wrote:

>  Thank you Mike, please keep us posted.
>
> Regards
> ilya
>
> On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
>
> Little clarification on this:
>
>  "The dsName is derived from the UUID of the datastore."
>
>  I mean that the dsName is derived from the UUID primary storage in
> the DB.
>
> On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Just a little update on this:
>>
>>  The problem doesn't seem to have anything to do with "managed"
>> storage code that was introduced back in March.
>>
>>  The dsName is derived from the UUID of the datastore. This leads to
>> a null being returned from
>> diskInfoBuilder.getDiskInfoByBackingFileBaseName, which subsequently 
>> leads
>> to a null being returned from this method (and a NullPointerException 
>> being
>> thrown).
>>
>>  I plan to take a look at the history of this file in gitk.
>>
>> private VirtualMachineDiskInfo
>> getMatchingExistingDisk(VirtualMachineDiskInfoBuilder diskInfoBuilder,
>> DiskTO vol) {
>>
>> if (diskInfoBuilder != null) {
>>
>> VolumeObjectTO volume = (VolumeObjectTO)vol.getData();
>>
>> String dsName = volume.getDataStore().getUuid().replace(
>> "-", "");
>>
>>
>>  Map details = vol.getDetails();
>>
>> boolean isManaged = details != null &&
>> Boolean.parseBoolean(details.get(DiskTO.MANAGED));
>>
>>
>>  VirtualMachineDiskInfo diskInfo =
>>
>>
>> diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ? new
>> DatastoreFile(volume.getPath()).getFileBaseName() : volume.getPath(),
>> dsName);
>>
>> On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> I think I found the magic. :)
>>>
>>> sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec
>>>
>>> If I mount /export/secondary to /mnt/sec (I did it in a bit of a
>>> roundabout way here), then the management server is happy.
>>>
>>> I think this is only VMware "thing" for the management server.
>>>
>>> Does anyone know if we document this?
>>>
>>> Thanks!
>>>
>>> On Thu, Sep 18, 2014 at 4:18 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 The instructions even say the following:

  If your secondary storage mount point is not named
 /mnt/secondary, substitute your own mount point name.

 On Thu, Sep 18, 2014 at 4:15 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Erik Weber]

Which systemvm template are you using?

Erik
19. sep. 2014 03:47 skrev "Mike Tutkowski" 
følgende:

> Actually, the virtual router says it requires an upgrade.
>
> I think I can just turn that check off and re-run my create-VM test.
>
> On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
> > OK, I checked in a fix for this:
> >
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=18e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81509e6885aa536932
> >
> > I did notice that both before and after my fix that the virtual router is
> > NOT coming up.
> >
> > The system VM being cloned and the starting of the VM looks fine. It gets
> > to the command prompt and then a little while later is shut down and
> > restarted. I get an error in the GUI indicating that my VM deployment
> > failed.
> >
> > I don't personally know a whole lot about how the virtual router code
> > works, so we should pass that on to an appropriate developer.
> >
> > On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> >> Just destroyed and re-created my env from scratch without
> >> 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.
> >>
> >> I think I know what the author was intending with the code that is
> >> causing the problem, so I'll go ahead and put in what I think is a fix,
> >> re-create my env, and see if it works.
> >>
> >> On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev 
> >> wrote:
> >>
> >>>  Thank you Mike, please keep us posted.
> >>>
> >>> Regards
> >>> ilya
> >>>
> >>> On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
> >>>
> >>> Little clarification on this:
> >>>
> >>>  "The dsName is derived from the UUID of the datastore."
> >>>
> >>>  I mean that the dsName is derived from the UUID primary storage in the
> >>> DB.
> >>>
> >>> On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
> >>> mike.tutkow...@solidfire.com> wrote:
> >>>
>  Just a little update on this:
> 
>   The problem doesn't seem to have anything to do with "managed"
>  storage code that was introduced back in March.
> 
>   The dsName is derived from the UUID of the datastore. This leads to a
>  null being returned from
> diskInfoBuilder.getDiskInfoByBackingFileBaseName,
>  which subsequently leads to a null being returned from this method
> (and a
>  NullPointerException being thrown).
> 
>   I plan to take a look at the history of this file in gitk.
> 
>  private VirtualMachineDiskInfo
>  getMatchingExistingDisk(VirtualMachineDiskInfoBuilder diskInfoBuilder,
>  DiskTO vol) {
> 
>  if (diskInfoBuilder != null) {
> 
>  VolumeObjectTO volume = (VolumeObjectTO)vol.getData();
> 
>  String dsName =
> volume.getDataStore().getUuid().replace("-",
>  "");
> 
> 
>   Map details = vol.getDetails();
> 
>  boolean isManaged = details != null &&
>  Boolean.parseBoolean(details.get(DiskTO.MANAGED));
> 
> 
>   VirtualMachineDiskInfo diskInfo =
> 
> 
>  diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ? new
>  DatastoreFile(volume.getPath()).getFileBaseName() : volume.getPath(),
>  dsName);
> 
>  On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
>  mike.tutkow...@solidfire.com> wrote:
> 
> > I think I found the magic. :)
> >
> > sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec
> >
> > If I mount /export/secondary to /mnt/sec (I did it in a bit of a
> > roundabout way here), then the management server is happy.
> >
> > I think this is only VMware "thing" for the management server.
> >
> > Does anyone know if we document this?
> >
> > Thanks!
> >
> > On Thu, Sep 18, 2014 at 4:18 PM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> >> The instructions even say the following:
> >>
> >>  If your secondary storage mount point is not named /mnt/secondary,
> >> substitute your own mount point name.
> >>
> >> On Thu, Sep 18, 2014 at 4:15 PM, Mike Tutkowski <
> >> mike.tutkow...@solidfire.com> wrote:
> >>
> >>> Yeah, I've been through the instructions a couple times and don't
> >>> see anything that indicates why it's having trouble with /mnt/sec
> (it says
> >>> /mnt/sec instead of /mnt/secondary in the log messages).
> >>>
> >>> On Thu, Sep 18, 2014 at 4:01 PM, Ritu Sabharwal <
> >>> rsabh...@brocade.com> wrote:
> >>>
>  I have an external NFS server and it is mounted to /mnt/secondary
>  on my CS server so seeding command I used is:
> 
> 
> /usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-sys-tmplt
>  -m /mnt/secondary  -u
> 
> http://cloudstack.apt-get.eu/systemvm/4.4/systemvm64template-4.4.0-6-vmware.o

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Mike Tutkowski]

http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-vmware.ova

On Fri, Sep 19, 2014 at 9:58 AM, Erik Weber  wrote:

> Which systemvm template are you using?
>
> Erik
> 19. sep. 2014 03:47 skrev "Mike Tutkowski" 
> følgende:
>
> > Actually, the virtual router says it requires an upgrade.
> >
> > I think I can just turn that check off and re-run my create-VM test.
> >
> > On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> > > OK, I checked in a fix for this:
> > >
> > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=18e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81509e6885aa536932
> > >
> > > I did notice that both before and after my fix that the virtual router
> is
> > > NOT coming up.
> > >
> > > The system VM being cloned and the starting of the VM looks fine. It
> gets
> > > to the command prompt and then a little while later is shut down and
> > > restarted. I get an error in the GUI indicating that my VM deployment
> > > failed.
> > >
> > > I don't personally know a whole lot about how the virtual router code
> > > works, so we should pass that on to an appropriate developer.
> > >
> > > On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
> > > mike.tutkow...@solidfire.com> wrote:
> > >
> > >> Just destroyed and re-created my env from scratch without
> > >> 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.
> > >>
> > >> I think I know what the author was intending with the code that is
> > >> causing the problem, so I'll go ahead and put in what I think is a
> fix,
> > >> re-create my env, and see if it works.
> > >>
> > >> On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev  >
> > >> wrote:
> > >>
> > >>>  Thank you Mike, please keep us posted.
> > >>>
> > >>> Regards
> > >>> ilya
> > >>>
> > >>> On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
> > >>>
> > >>> Little clarification on this:
> > >>>
> > >>>  "The dsName is derived from the UUID of the datastore."
> > >>>
> > >>>  I mean that the dsName is derived from the UUID primary storage in
> the
> > >>> DB.
> > >>>
> > >>> On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
> > >>> mike.tutkow...@solidfire.com> wrote:
> > >>>
> >  Just a little update on this:
> > 
> >   The problem doesn't seem to have anything to do with "managed"
> >  storage code that was introduced back in March.
> > 
> >   The dsName is derived from the UUID of the datastore. This leads
> to a
> >  null being returned from
> > diskInfoBuilder.getDiskInfoByBackingFileBaseName,
> >  which subsequently leads to a null being returned from this method
> > (and a
> >  NullPointerException being thrown).
> > 
> >   I plan to take a look at the history of this file in gitk.
> > 
> >  private VirtualMachineDiskInfo
> >  getMatchingExistingDisk(VirtualMachineDiskInfoBuilder
> diskInfoBuilder,
> >  DiskTO vol) {
> > 
> >  if (diskInfoBuilder != null) {
> > 
> >  VolumeObjectTO volume = (VolumeObjectTO)vol.getData();
> > 
> >  String dsName =
> > volume.getDataStore().getUuid().replace("-",
> >  "");
> > 
> > 
> >   Map details = vol.getDetails();
> > 
> >  boolean isManaged = details != null &&
> >  Boolean.parseBoolean(details.get(DiskTO.MANAGED));
> > 
> > 
> >   VirtualMachineDiskInfo diskInfo =
> > 
> > 
> >  diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ? new
> >  DatastoreFile(volume.getPath()).getFileBaseName() :
> volume.getPath(),
> >  dsName);
> > 
> >  On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
> >  mike.tutkow...@solidfire.com> wrote:
> > 
> > > I think I found the magic. :)
> > >
> > > sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec
> > >
> > > If I mount /export/secondary to /mnt/sec (I did it in a bit of a
> > > roundabout way here), then the management server is happy.
> > >
> > > I think this is only VMware "thing" for the management server.
> > >
> > > Does anyone know if we document this?
> > >
> > > Thanks!
> > >
> > > On Thu, Sep 18, 2014 at 4:18 PM, Mike Tutkowski <
> > > mike.tutkow...@solidfire.com> wrote:
> > >
> > >> The instructions even say the following:
> > >>
> > >>  If your secondary storage mount point is not named
> /mnt/secondary,
> > >> substitute your own mount point name.
> > >>
> > >> On Thu, Sep 18, 2014 at 4:15 PM, Mike Tutkowski <
> > >> mike.tutkow...@solidfire.com> wrote:
> > >>
> > >>> Yeah, I've been through the instructions a couple times and don't
> > >>> see anything that indicates why it's having trouble with /mnt/sec
> > (it says
> > >>> /mnt/sec instead of /mnt/secondary in the log messages).

Re: Review Request 25706: CLOUDSTACK-7561: UI: After creating a new account, the "Add Account" dialog remains open

[Brian Federle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25706/#review53960
---

Ship it!


Ship It!

- Brian Federle


On Sept. 16, 2014, 7:36 p.m., Gabor Apati-Nagy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25706/
> ---
> 
> (Updated Sept. 16, 2014, 7:36 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-7561
> https://issues.apache.org/jira/browse/CLOUDSTACK-7561
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Deleted code that was raising exception when it tried to call non-existing 
> function.
> 
> 
> Diffs
> -
> 
>   ui/scripts/accountsWizard.js f0221932706c5c68a343104c9745c1b7a5177a72 
> 
> Diff: https://reviews.apache.org/r/25706/diff/
> 
> 
> Testing
> ---
> 
> After adding an account using the UI there were no exceptions raised and the 
> dialog closes properly.
> 
> 
> Thanks,
> 
> Gabor Apati-Nagy
> 
>

Re: Review Request 25707: CLOUDSTACK-7562: Details page for disk offerings only show details for write performance

[Brian Federle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25707/#review53963
---

Ship it!


Ship It!

- Brian Federle


On Sept. 16, 2014, 7:37 p.m., Gabor Apati-Nagy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25707/
> ---
> 
> (Updated Sept. 16, 2014, 7:37 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-7562
> https://issues.apache.org/jira/browse/CLOUDSTACK-7562
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Corrected typo
> 
> 
> Diffs
> -
> 
>   ui/scripts/configuration.js a70c672bf2e482623d9344fb9fa27bff4cc14cef 
> 
> Diff: https://reviews.apache.org/r/25707/diff/
> 
> 
> Testing
> ---
> 
> REPRO
> Home -> Service Offerings -> Disk Offerings -> select any storage offering
> 
> 
> Correct Result after this fix:
> 
> Disk Write Rate (BPS) 
> Disk Read Rate (BPS)  
> Disk Write Rate (IOPS)
> Disk Read Rate (IOPS) 
> 
> Result on master branch before this fix:
> 
> Disk Write Rate (BPS) 
> Disk Write Rate (BPS) 
> Disk Write Rate (IOPS)
> Disk Write Rate (IOPS)
> 
> 
> Thanks,
> 
> Gabor Apati-Nagy
> 
>

RE: Jenkins build is back to normal : build-master-noredist #3562

[Frank Zhang]

Thanks Hugo 

> -Original Message-
> From: jenk...@cloudstack.org [mailto:jenk...@cloudstack.org]
> Sent: Thursday, September 18, 2014 3:30 AM
> To: dev@cloudstack.apache.org; bhais...@apache.org
> Subject: Jenkins build is back to normal : build-master-noredist #3562
> 
> See 

Review Request 25837: Additional Guest OS support for vGPU Test Automation

[sailaja mada]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25837/
---

Review request for cloudstack, Doug Clark, John Dilley, and Sanjay Tripathi.


Repository: cloudstack-git


Description
---

Additional Guest OS support for vGPU Test Automation


Diffs
-

  test/integration/component/test_deploy_vgpu_vm.py 081ab4b 
  tools/marvin/marvin/config/test_data.py 6b02476 

Diff: https://reviews.apache.org/r/25837/diff/


Testing
---

Yes.  Testing is done with Win7,Win8 and Win2012 templates with XS 65 tools 
installed.

All the testcases are passed


Thanks,

sailaja mada

Review Request 25841: CLOUDSTACK-7587 - Automation - Add simulator_only attribute to acl related test cases.

[sangeetha hariharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25841/
---

Review request for cloudstack, Alex Brett, Chandan Purushothama, Min Chen, and 
Santhosh Edukulla.


Repository: cloudstack-git


Description
---

Added "simulator_only" attribute to all the acl related test cases , so that 
they do not get picked up by the hypervisor runs bu get picked only for the 
simulator runs.


Diffs
-

  test/integration/component/test_acl_isolatednetwork.py 59119f1 
  test/integration/component/test_acl_isolatednetwork_delete.py 3d09390 
  test/integration/component/test_acl_listsnapshot.py ac8748d 
  test/integration/component/test_acl_listvm.py 398f98a 
  test/integration/component/test_acl_listvolume.py e527582 
  test/integration/component/test_acl_sharednetwork.py 5d57f30 
  test/integration/component/test_acl_sharednetwork_deployVM-impersonation.py 
a05a2d8 

Diff: https://reviews.apache.org/r/25841/diff/


Testing
---

Tested by making sure that when " -a 
!simulator_only,tags=advanced,required_hardware=false" is used for the acl 
related test suites , not test case gets executed.


Thanks,

sangeetha hariharan

Re: Review Request 25266: Simulator build support need to extends for RPM build

[Rayees Namathponnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25266/
---

(Updated Sept. 19, 2014, 7:17 p.m.)


Review request for cloudstack, Frank Zhang and Hugo Trippaers.


Bugs: CLOUDSTACK-7469
https://issues.apache.org/jira/browse/CLOUDSTACK-7469


Repository: cloudstack-git


Description
---

Currently there is no option to build rpm with simulator,  as part this patch 
modified package.sh file to accept simulator

also updated cloud.spec file to build both oss and nooss simulator buids


To build noredist and simulator, you need to use below package command
./package.sh --pack noredist --s simulator

default package with simulato, need to call  ./package.sh


Diffs
-

  packaging/centos63/cloud.spec 7306d1f 
  packaging/centos63/package.sh 6a2d168 

Diff: https://reviews.apache.org/r/25266/diff/


Testing
---

Yes


File Attachments (updated)


0001-Simulator-build-support-for-RPM-builds.patch
  
https://reviews.apache.org/media/uploaded/files/2014/09/19/2537284e-f1de-419a-b5b6-66b8ddfcac84__0001-Simulator-build-support-for-RPM-builds.patch


Thanks,

Rayees Namathponnan

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/16#issuecomment-56225895
  
Looks like the build has passed now: 
http://jenkins.buildacloud.org/job/systemvm-refactor-CLOUDSTACK-7143/9/

I'll test it against KVM and if it works I'll go ahead and merge it. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 25841: CLOUDSTACK-7587 - Automation - Add simulator_only attribute to acl related test cases.

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25841/#review54006
---

Ship it!


Ship It!

- Amogh Vasekar


On Sept. 19, 2014, 7:12 p.m., sangeetha hariharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25841/
> ---
> 
> (Updated Sept. 19, 2014, 7:12 p.m.)
> 
> 
> Review request for cloudstack, Alex Brett, Chandan Purushothama, Min Chen, 
> and Santhosh Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added "simulator_only" attribute to all the acl related test cases , so that 
> they do not get picked up by the hypervisor runs bu get picked only for the 
> simulator runs.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_acl_isolatednetwork.py 59119f1 
>   test/integration/component/test_acl_isolatednetwork_delete.py 3d09390 
>   test/integration/component/test_acl_listsnapshot.py ac8748d 
>   test/integration/component/test_acl_listvm.py 398f98a 
>   test/integration/component/test_acl_listvolume.py e527582 
>   test/integration/component/test_acl_sharednetwork.py 5d57f30 
>   test/integration/component/test_acl_sharednetwork_deployVM-impersonation.py 
> a05a2d8 
> 
> Diff: https://reviews.apache.org/r/25841/diff/
> 
> 
> Testing
> ---
> 
> Tested by making sure that when " -a 
> !simulator_only,tags=advanced,required_hardware=false" is used for the acl 
> related test suites , not test case gets executed.
> 
> 
> Thanks,
> 
> sangeetha hariharan
> 
>

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Amogh Vasekar]

Are you building the systemvm.iso too? I have seen connection refused
issue mostly when the system Vms and the management server have different
SSH keys (that are passed via systemvm.iso)
I am assuming you are using standard vswitch in your deployment.

Amogh 

On 9/19/14 9:01 AM, "Mike Tutkowski"  wrote:

>http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulB
>uild/artifact/tools/appliance/dist/systemvm64template-master-vmware.ova
>
>On Fri, Sep 19, 2014 at 9:58 AM, Erik Weber  wrote:
>
>> Which systemvm template are you using?
>>
>> Erik
>> 19. sep. 2014 03:47 skrev "Mike Tutkowski"
>>
>> følgende:
>>
>> > Actually, the virtual router says it requires an upgrade.
>> >
>> > I think I can just turn that check off and re-run my create-VM test.
>> >
>> > On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
>> > mike.tutkow...@solidfire.com> wrote:
>> >
>> > > OK, I checked in a fix for this:
>> > >
>> > >
>> > >
>> >
>> 
>>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=1
>>8e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81509e68
>>85aa536932
>> > >
>> > > I did notice that both before and after my fix that the virtual
>>router
>> is
>> > > NOT coming up.
>> > >
>> > > The system VM being cloned and the starting of the VM looks fine. It
>> gets
>> > > to the command prompt and then a little while later is shut down and
>> > > restarted. I get an error in the GUI indicating that my VM
>>deployment
>> > > failed.
>> > >
>> > > I don't personally know a whole lot about how the virtual router
>>code
>> > > works, so we should pass that on to an appropriate developer.
>> > >
>> > > On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
>> > > mike.tutkow...@solidfire.com> wrote:
>> > >
>> > >> Just destroyed and re-created my env from scratch without
>> > >> 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.
>> > >>
>> > >> I think I know what the author was intending with the code that is
>> > >> causing the problem, so I'll go ahead and put in what I think is a
>> fix,
>> > >> re-create my env, and see if it works.
>> > >>
>> > >> On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev
>>> >
>> > >> wrote:
>> > >>
>> > >>>  Thank you Mike, please keep us posted.
>> > >>>
>> > >>> Regards
>> > >>> ilya
>> > >>>
>> > >>> On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
>> > >>>
>> > >>> Little clarification on this:
>> > >>>
>> > >>>  "The dsName is derived from the UUID of the datastore."
>> > >>>
>> > >>>  I mean that the dsName is derived from the UUID primary storage
>>in
>> the
>> > >>> DB.
>> > >>>
>> > >>> On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
>> > >>> mike.tutkow...@solidfire.com> wrote:
>> > >>>
>> >  Just a little update on this:
>> > 
>> >   The problem doesn't seem to have anything to do with "managed"
>> >  storage code that was introduced back in March.
>> > 
>> >   The dsName is derived from the UUID of the datastore. This leads
>> to a
>> >  null being returned from
>> > diskInfoBuilder.getDiskInfoByBackingFileBaseName,
>> >  which subsequently leads to a null being returned from this
>>method
>> > (and a
>> >  NullPointerException being thrown).
>> > 
>> >   I plan to take a look at the history of this file in gitk.
>> > 
>> >  private VirtualMachineDiskInfo
>> >  getMatchingExistingDisk(VirtualMachineDiskInfoBuilder
>> diskInfoBuilder,
>> >  DiskTO vol) {
>> > 
>> >  if (diskInfoBuilder != null) {
>> > 
>> >  VolumeObjectTO volume =
>>(VolumeObjectTO)vol.getData();
>> > 
>> >  String dsName =
>> > volume.getDataStore().getUuid().replace("-",
>> >  "");
>> > 
>> > 
>> >   Map details = vol.getDetails();
>> > 
>> >  boolean isManaged = details != null &&
>> >  Boolean.parseBoolean(details.get(DiskTO.MANAGED));
>> > 
>> > 
>> >   VirtualMachineDiskInfo diskInfo =
>> > 
>> > 
>> >  diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ? new
>> >  DatastoreFile(volume.getPath()).getFileBaseName() :
>> volume.getPath(),
>> >  dsName);
>> > 
>> >  On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
>> >  mike.tutkow...@solidfire.com> wrote:
>> > 
>> > > I think I found the magic. :)
>> > >
>> > > sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec
>> > >
>> > > If I mount /export/secondary to /mnt/sec (I did it in a bit of a
>> > > roundabout way here), then the management server is happy.
>> > >
>> > > I think this is only VMware "thing" for the management server.
>> > >
>> > > Does anyone know if we document this?
>> > >
>> > > Thanks!
>> > >
>> > > On Thu, Sep 18, 2014 at 4:18 PM, Mike Tutkowski <
>> > > mike.tutkow...@solidfire.com> wrote:
>> > >
>> > >> The instructions even say the following:
>> > >>
>> > >>  If your secondar

KVM/CLVM disk format determination

[Simon Weller]

Marcus/Edison,


I've  been looking at CLOUDSTACK-6460 to see if I could figure out why CLVM 
volumes are being seen as format QCOW2 rather than RAW when attempting a 
primary storage migration. I've found that when a new volume gets attached to a 
VM, it seems that QCOW2 is being set as the format in the volumes table for 
that volume.


Upon allocation, it's NULL, then once you attach it, it changes to QCOW2.


Here's a log snippet that shows this happening:


org.apache.cloudstack.storage.command.AttachCommand":
{"disk":
{"data":
{"org.apache.cloudstack.storage.to.VolumeObjectTO":
{"uuid":"558b0140-8d98-429c-9de3-44dc7ec96f51","volumeType":"DATADISK","dataStore":
{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":

{"uuid":"076d1cd7-9c80-4302-8e13-ea8187a9a96b","id":201,"poolType":"CLVM","host":"localhost","path":"/csstore01","port":0,"url":"CLVM://localhost//csstore01/?ROLE=Primary&STOREUUID=076d1cd7-9c80-4302-8e13-ea8187a9a96b"
 }

},"name":"test7_2","size":5368709120,"path":"558b0140-8d98-429c-9de3-44dc7ec96f51","volumeId":17456,"accountId":6,"format":"QCOW2","id":17456,"hypervisorType":"KVM"
}
}
,"diskSeq":5,"path":"558b0140-8d98-429c-9de3-44dc7ec96f51","type":"DATADISK","_details":

{"managed":"false","storagePort":"0","storageHost":"localhost","volumeSize":"5368709120"
 }

},"vmName":"i-6-22370-VM","inSeq":false,"wait":0}}]
}?


I've been working through the code for a couple of days now, and I'd appreciate 
if you could point me in the right direction in terms of how a volume format is 
determined at attachment to a VM. There's a lot of legacy unused methods 
littered through the code that tie hypervisors to particular disk formats, so 
any expert advice would help me narrow down where to look.


Thanks in advance,


Simon

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Mike Tutkowski]

Hi,

I built the code the following way:

mvn -P developer,systemvm clean install -D noredist

The environment is XenServer with two hosts in a Basic Zone.

Thanks,
Mike

On Fri, Sep 19, 2014 at 2:03 PM, Amogh Vasekar 
wrote:

> Are you building the systemvm.iso too? I have seen connection refused
> issue mostly when the system Vms and the management server have different
> SSH keys (that are passed via systemvm.iso)
> I am assuming you are using standard vswitch in your deployment.
>
> Amogh
>
> On 9/19/14 9:01 AM, "Mike Tutkowski"  wrote:
>
> >
> http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulB
> >uild/artifact/tools/appliance/dist/systemvm64template-master-vmware.ova
> >
> >On Fri, Sep 19, 2014 at 9:58 AM, Erik Weber  wrote:
> >
> >> Which systemvm template are you using?
> >>
> >> Erik
> >> 19. sep. 2014 03:47 skrev "Mike Tutkowski"
> >>
> >> følgende:
> >>
> >> > Actually, the virtual router says it requires an upgrade.
> >> >
> >> > I think I can just turn that check off and re-run my create-VM test.
> >> >
> >> > On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
> >> > mike.tutkow...@solidfire.com> wrote:
> >> >
> >> > > OK, I checked in a fix for this:
> >> > >
> >> > >
> >> > >
> >> >
> >>
> >>
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=1
> >>8e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81509e68
> >>85aa536932
> >> > >
> >> > > I did notice that both before and after my fix that the virtual
> >>router
> >> is
> >> > > NOT coming up.
> >> > >
> >> > > The system VM being cloned and the starting of the VM looks fine. It
> >> gets
> >> > > to the command prompt and then a little while later is shut down and
> >> > > restarted. I get an error in the GUI indicating that my VM
> >>deployment
> >> > > failed.
> >> > >
> >> > > I don't personally know a whole lot about how the virtual router
> >>code
> >> > > works, so we should pass that on to an appropriate developer.
> >> > >
> >> > > On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
> >> > > mike.tutkow...@solidfire.com> wrote:
> >> > >
> >> > >> Just destroyed and re-created my env from scratch without
> >> > >> 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.
> >> > >>
> >> > >> I think I know what the author was intending with the code that is
> >> > >> causing the problem, so I'll go ahead and put in what I think is a
> >> fix,
> >> > >> re-create my env, and see if it works.
> >> > >>
> >> > >> On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev
> >> >> >
> >> > >> wrote:
> >> > >>
> >> > >>>  Thank you Mike, please keep us posted.
> >> > >>>
> >> > >>> Regards
> >> > >>> ilya
> >> > >>>
> >> > >>> On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
> >> > >>>
> >> > >>> Little clarification on this:
> >> > >>>
> >> > >>>  "The dsName is derived from the UUID of the datastore."
> >> > >>>
> >> > >>>  I mean that the dsName is derived from the UUID primary storage
> >>in
> >> the
> >> > >>> DB.
> >> > >>>
> >> > >>> On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
> >> > >>> mike.tutkow...@solidfire.com> wrote:
> >> > >>>
> >> >  Just a little update on this:
> >> > 
> >> >   The problem doesn't seem to have anything to do with "managed"
> >> >  storage code that was introduced back in March.
> >> > 
> >> >   The dsName is derived from the UUID of the datastore. This leads
> >> to a
> >> >  null being returned from
> >> > diskInfoBuilder.getDiskInfoByBackingFileBaseName,
> >> >  which subsequently leads to a null being returned from this
> >>method
> >> > (and a
> >> >  NullPointerException being thrown).
> >> > 
> >> >   I plan to take a look at the history of this file in gitk.
> >> > 
> >> >  private VirtualMachineDiskInfo
> >> >  getMatchingExistingDisk(VirtualMachineDiskInfoBuilder
> >> diskInfoBuilder,
> >> >  DiskTO vol) {
> >> > 
> >> >  if (diskInfoBuilder != null) {
> >> > 
> >> >  VolumeObjectTO volume =
> >>(VolumeObjectTO)vol.getData();
> >> > 
> >> >  String dsName =
> >> > volume.getDataStore().getUuid().replace("-",
> >> >  "");
> >> > 
> >> > 
> >> >   Map details = vol.getDetails();
> >> > 
> >> >  boolean isManaged = details != null &&
> >> >  Boolean.parseBoolean(details.get(DiskTO.MANAGED));
> >> > 
> >> > 
> >> >   VirtualMachineDiskInfo diskInfo =
> >> > 
> >> > 
> >> >  diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ? new
> >> >  DatastoreFile(volume.getPath()).getFileBaseName() :
> >> volume.getPath(),
> >> >  dsName);
> >> > 
> >> >  On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
> >> >  mike.tutkow...@solidfire.com> wrote:
> >> > 
> >> > > I think I found the magic. :)
> >> > >
> >> > > sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec
> >> > >
> >> > > If I mount /export/seco

Re: Review Request 25732: null IOPS is being processed while creating a vm using third party storage plugins

[Mike Tutkowski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25732/#review54035
---

Ship it!


Ship It!

- Mike Tutkowski


On Sept. 17, 2014, 6:28 a.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25732/
> ---
> 
> (Updated Sept. 17, 2014, 6:28 a.m.)
> 
> 
> Review request for cloudstack and Mike Tutkowski.
> 
> 
> Bugs: CLOUDSTACK-7570
> https://issues.apache.org/jira/browse/CLOUDSTACK-7570
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> this bug will only occur in the following scenario
> 1> create a compute offering with custom mode but not custom IOPS
> 2> input the required min and max IOPS
> 3> now create a VM based on the created compute offering
> 
> issue:
> ServiceOfferingVO dummyoffering = new ServiceOfferingVO(serviceOffering);
> this constructor is not setting the min and max IOPS for the dummyoffering
> 
> fix: 
> adding the min and max iops to the following constructor.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/service/ServiceOfferingVO.java df68fb8 
>   engine/schema/src/com/cloud/storage/DiskOfferingVO.java 152fa2c 
> 
> Diff: https://reviews.apache.org/r/25732/diff/
> 
> 
> Testing
> ---
> 
> system testing done
> 
> 
> Thanks,
> 
> punith s
> 
>

Re: Review Request 25732: null IOPS is being processed while creating a vm using third party storage plugins

[Mike Tutkowski]

> On Sept. 19, 2014, 4:09 p.m., Mike Tutkowski wrote:
> > Ship It!

I committed this under SHA dd4f6bcaf3a380e52c987e4a400fce09fb180006 and I 
resolved and closed the following JIRA ticket for you:

https://issues.apache.org/jira/browse/CLOUDSTACK-7570

Thanks for finding and fixing this issue, Punith!


- Mike


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25732/#review54035
---


On Sept. 17, 2014, 6:28 a.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25732/
> ---
> 
> (Updated Sept. 17, 2014, 6:28 a.m.)
> 
> 
> Review request for cloudstack and Mike Tutkowski.
> 
> 
> Bugs: CLOUDSTACK-7570
> https://issues.apache.org/jira/browse/CLOUDSTACK-7570
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> this bug will only occur in the following scenario
> 1> create a compute offering with custom mode but not custom IOPS
> 2> input the required min and max IOPS
> 3> now create a VM based on the created compute offering
> 
> issue:
> ServiceOfferingVO dummyoffering = new ServiceOfferingVO(serviceOffering);
> this constructor is not setting the min and max IOPS for the dummyoffering
> 
> fix: 
> adding the min and max iops to the following constructor.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/service/ServiceOfferingVO.java df68fb8 
>   engine/schema/src/com/cloud/storage/DiskOfferingVO.java 152fa2c 
> 
> Diff: https://reviews.apache.org/r/25732/diff/
> 
> 
> Testing
> ---
> 
> system testing done
> 
> 
> Thanks,
> 
> punith s
> 
>

RE: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Ritu Sabharwal]

Hi Mike,

Thanks for trying out this and the investigation.

I hope the developer for system vm would pick up this issue and help to resolve.

Thanks & Regards,
Ritu S.

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: Friday, September 19, 2014 9:01 AM
To: dev@cloudstack.apache.org
Subject: Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with 
Vmware setup with CS server

http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-vmware.ova

On Fri, Sep 19, 2014 at 9:58 AM, Erik Weber  wrote:

> Which systemvm template are you using?
>
> Erik
> 19. sep. 2014 03:47 skrev "Mike Tutkowski"
> 
> følgende:
>
> > Actually, the virtual router says it requires an upgrade.
> >
> > I think I can just turn that check off and re-run my create-VM test.
> >
> > On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> > > OK, I checked in a fix for this:
> > >
> > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;
> h=18e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81
> 509e6885aa536932
> > >
> > > I did notice that both before and after my fix that the virtual
> > > router
> is
> > > NOT coming up.
> > >
> > > The system VM being cloned and the starting of the VM looks fine.
> > > It
> gets
> > > to the command prompt and then a little while later is shut down
> > > and restarted. I get an error in the GUI indicating that my VM
> > > deployment failed.
> > >
> > > I don't personally know a whole lot about how the virtual router
> > > code works, so we should pass that on to an appropriate developer.
> > >
> > > On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
> > > mike.tutkow...@solidfire.com> wrote:
> > >
> > >> Just destroyed and re-created my env from scratch without
> > >> 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.
> > >>
> > >> I think I know what the author was intending with the code that
> > >> is causing the problem, so I'll go ahead and put in what I think
> > >> is a
> fix,
> > >> re-create my env, and see if it works.
> > >>
> > >> On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev
> > >>  >
> > >> wrote:
> > >>
> > >>>  Thank you Mike, please keep us posted.
> > >>>
> > >>> Regards
> > >>> ilya
> > >>>
> > >>> On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
> > >>>
> > >>> Little clarification on this:
> > >>>
> > >>>  "The dsName is derived from the UUID of the datastore."
> > >>>
> > >>>  I mean that the dsName is derived from the UUID primary storage
> > >>> in
> the
> > >>> DB.
> > >>>
> > >>> On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
> > >>> mike.tutkow...@solidfire.com> wrote:
> > >>>
> >  Just a little update on this:
> > 
> >   The problem doesn't seem to have anything to do with "managed"
> >  storage code that was introduced back in March.
> > 
> >   The dsName is derived from the UUID of the datastore. This
> >  leads
> to a
> >  null being returned from
> > diskInfoBuilder.getDiskInfoByBackingFileBaseName,
> >  which subsequently leads to a null being returned from this
> >  method
> > (and a
> >  NullPointerException being thrown).
> > 
> >   I plan to take a look at the history of this file in gitk.
> > 
> >  private VirtualMachineDiskInfo
> >  getMatchingExistingDisk(VirtualMachineDiskInfoBuilder
> diskInfoBuilder,
> >  DiskTO vol) {
> > 
> >  if (diskInfoBuilder != null) {
> > 
> >  VolumeObjectTO volume =
> >  (VolumeObjectTO)vol.getData();
> > 
> >  String dsName =
> > volume.getDataStore().getUuid().replace("-",
> >  "");
> > 
> > 
> >   Map details = vol.getDetails();
> > 
> >  boolean isManaged = details != null &&
> >  Boolean.parseBoolean(details.get(DiskTO.MANAGED));
> > 
> > 
> >   VirtualMachineDiskInfo diskInfo =
> > 
> > 
> >  diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ?
> >  new
> >  DatastoreFile(volume.getPath()).getFileBaseName() :
> volume.getPath(),
> >  dsName);
> > 
> >  On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
> >  mike.tutkow...@solidfire.com> wrote:
> > 
> > > I think I found the magic. :)
> > >
> > > sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec
> > >
> > > If I mount /export/secondary to /mnt/sec (I did it in a bit of
> > > a roundabout way here), then the management server is happy.
> > >
> > > I think this is only VMware "thing" for the management server.
> > >
> > > Does anyone know if we document this?
> > >
> > > Thanks!
> > >
> > > On Thu, Sep 18, 2014 at 4:18 PM, Mike Tutkowski <
> > > mike.tutkow...@solidfire.com> wrote:
> > >
> > >> The instructions even say the followin

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Mike Tutkowski]

No problem :)

The one issue is fixed now. We just need to have someone check out what's
going on with the virtual router.

On Fri, Sep 19, 2014 at 5:21 PM, Ritu Sabharwal 
wrote:

> Hi Mike,
>
> Thanks for trying out this and the investigation.
>
> I hope the developer for system vm would pick up this issue and help to
> resolve.
>
> Thanks & Regards,
> Ritu S.
>
> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Friday, September 19, 2014 9:01 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs
> with Vmware setup with CS server
>
>
> http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-vmware.ova
>
> On Fri, Sep 19, 2014 at 9:58 AM, Erik Weber  wrote:
>
> > Which systemvm template are you using?
> >
> > Erik
> > 19. sep. 2014 03:47 skrev "Mike Tutkowski"
> > 
> > følgende:
> >
> > > Actually, the virtual router says it requires an upgrade.
> > >
> > > I think I can just turn that check off and re-run my create-VM test.
> > >
> > > On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
> > > mike.tutkow...@solidfire.com> wrote:
> > >
> > > > OK, I checked in a fix for this:
> > > >
> > > >
> > > >
> > >
> > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;
> > h=18e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81
> > 509e6885aa536932
> > > >
> > > > I did notice that both before and after my fix that the virtual
> > > > router
> > is
> > > > NOT coming up.
> > > >
> > > > The system VM being cloned and the starting of the VM looks fine.
> > > > It
> > gets
> > > > to the command prompt and then a little while later is shut down
> > > > and restarted. I get an error in the GUI indicating that my VM
> > > > deployment failed.
> > > >
> > > > I don't personally know a whole lot about how the virtual router
> > > > code works, so we should pass that on to an appropriate developer.
> > > >
> > > > On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
> > > > mike.tutkow...@solidfire.com> wrote:
> > > >
> > > >> Just destroyed and re-created my env from scratch without
> > > >> 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.
> > > >>
> > > >> I think I know what the author was intending with the code that
> > > >> is causing the problem, so I'll go ahead and put in what I think
> > > >> is a
> > fix,
> > > >> re-create my env, and see if it works.
> > > >>
> > > >> On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev
> > > >>  > >
> > > >> wrote:
> > > >>
> > > >>>  Thank you Mike, please keep us posted.
> > > >>>
> > > >>> Regards
> > > >>> ilya
> > > >>>
> > > >>> On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
> > > >>>
> > > >>> Little clarification on this:
> > > >>>
> > > >>>  "The dsName is derived from the UUID of the datastore."
> > > >>>
> > > >>>  I mean that the dsName is derived from the UUID primary storage
> > > >>> in
> > the
> > > >>> DB.
> > > >>>
> > > >>> On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
> > > >>> mike.tutkow...@solidfire.com> wrote:
> > > >>>
> > >  Just a little update on this:
> > > 
> > >   The problem doesn't seem to have anything to do with "managed"
> > >  storage code that was introduced back in March.
> > > 
> > >   The dsName is derived from the UUID of the datastore. This
> > >  leads
> > to a
> > >  null being returned from
> > > diskInfoBuilder.getDiskInfoByBackingFileBaseName,
> > >  which subsequently leads to a null being returned from this
> > >  method
> > > (and a
> > >  NullPointerException being thrown).
> > > 
> > >   I plan to take a look at the history of this file in gitk.
> > > 
> > >  private VirtualMachineDiskInfo
> > >  getMatchingExistingDisk(VirtualMachineDiskInfoBuilder
> > diskInfoBuilder,
> > >  DiskTO vol) {
> > > 
> > >  if (diskInfoBuilder != null) {
> > > 
> > >  VolumeObjectTO volume =
> > >  (VolumeObjectTO)vol.getData();
> > > 
> > >  String dsName =
> > > volume.getDataStore().getUuid().replace("-",
> > >  "");
> > > 
> > > 
> > >   Map details = vol.getDetails();
> > > 
> > >  boolean isManaged = details != null &&
> > >  Boolean.parseBoolean(details.get(DiskTO.MANAGED));
> > > 
> > > 
> > >   VirtualMachineDiskInfo diskInfo =
> > > 
> > > 
> > >  diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ?
> > >  new
> > >  DatastoreFile(volume.getPath()).getFileBaseName() :
> > volume.getPath(),
> > >  dsName);
> > > 
> > >  On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
> > >  mike.tutkow...@solidfire.com> wrote:
> > > 
> > > > I think I found the magic. :)
> > > >
> > > > sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec
> > > >
> > > > If I

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[ilya musayev]

Ritu,

Open a ticket in JIRA as major/blocker for 4.5, so it gets noticed.

You can also try running you code on 4.4 or 4.3.1, but i know it maybe 
too much work to backport.


Mike thank you for spending time trying to figure this out.

Regards
ilya
On 9/19/14, 4:21 PM, Ritu Sabharwal wrote:

Hi Mike,

Thanks for trying out this and the investigation.

I hope the developer for system vm would pick up this issue and help to resolve.

Thanks & Regards,
Ritu S.

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: Friday, September 19, 2014 9:01 AM
To: dev@cloudstack.apache.org
Subject: Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with 
Vmware setup with CS server

http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-vmware.ova

On Fri, Sep 19, 2014 at 9:58 AM, Erik Weber  wrote:


Which systemvm template are you using?

Erik
19. sep. 2014 03:47 skrev "Mike Tutkowski"

følgende:


Actually, the virtual router says it requires an upgrade.

I think I can just turn that check off and re-run my create-VM test.

On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:


OK, I checked in a fix for this:




https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;
h=18e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81
509e6885aa536932

I did notice that both before and after my fix that the virtual
router

is

NOT coming up.

The system VM being cloned and the starting of the VM looks fine.
It

gets

to the command prompt and then a little while later is shut down
and restarted. I get an error in the GUI indicating that my VM
deployment failed.

I don't personally know a whole lot about how the virtual router
code works, so we should pass that on to an appropriate developer.

On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:


Just destroyed and re-created my env from scratch without
8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.

I think I know what the author was intending with the code that
is causing the problem, so I'll go ahead and put in what I think
is a

fix,

re-create my env, and see if it works.

On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev

  Thank you Mike, please keep us posted.

Regards
ilya

On 9/18/14, 4:14 PM, Mike Tutkowski wrote:

Little clarification on this:

  "The dsName is derived from the UUID of the datastore."

  I mean that the dsName is derived from the UUID primary storage
in

the

DB.

On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:


Just a little update on this:

  The problem doesn't seem to have anything to do with "managed"
storage code that was introduced back in March.

  The dsName is derived from the UUID of the datastore. This
leads

to a

null being returned from

diskInfoBuilder.getDiskInfoByBackingFileBaseName,

which subsequently leads to a null being returned from this
method

(and a

NullPointerException being thrown).

  I plan to take a look at the history of this file in gitk.

 private VirtualMachineDiskInfo
getMatchingExistingDisk(VirtualMachineDiskInfoBuilder

diskInfoBuilder,

DiskTO vol) {

 if (diskInfoBuilder != null) {

 VolumeObjectTO volume =
(VolumeObjectTO)vol.getData();

 String dsName =

volume.getDataStore().getUuid().replace("-",

"");


  Map details = vol.getDetails();

 boolean isManaged = details != null &&
Boolean.parseBoolean(details.get(DiskTO.MANAGED));


  VirtualMachineDiskInfo diskInfo =


diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ?
new
DatastoreFile(volume.getPath()).getFileBaseName() :

volume.getPath(),

dsName);

On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:


I think I found the magic. :)

sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec

If I mount /export/secondary to /mnt/sec (I did it in a bit of
a roundabout way here), then the management server is happy.

I think this is only VMware "thing" for the management server.

Does anyone know if we document this?

Thanks!

On Thu, Sep 18, 2014 at 4:18 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:


The instructions even say the following:

  If your secondary storage mount point is not named

/mnt/secondary,

substitute your own mount point name.

On Thu, Sep 18, 2014 at 4:15 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:


Yeah, I've been through the instructions a couple times and
don't see anything that indicates why it's having trouble
with /mnt/sec

(it says

/mnt/sec instead of /mnt/secondary in the log messages).

On Thu, Sep 18, 2014 at 4:01 PM, Ritu Sabharwal <
rsabh...@brocade.com> wrote:


I have an external NFS server and it is mounted to

/mnt/secondary

on my CS server so seeding command I used is:



/usr/share/cloudstack-co

Re: Review Request 25647: enabling the rootdisksize variable for vm creation wrt managed storage

[Mike Tutkowski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25647/#review54047
---



server/src/com/cloud/vm/UserVmManagerImpl.java


Is this fix only for managed storage?

From what I understand, the same issue exists for non-managed storage, but 
non-managed storage usually works because the template is being copied down to 
a shared storage repository that is typically quite a bit larger than the size 
of the template.

For non-managed storage, however, if we were running low on space in a 
given storage repository, we might try to copy the template down to this 
storage repository thinking the template is smaller than it actually is and 
this process could fail.


- Mike Tutkowski


On Sept. 17, 2014, 6:22 a.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25647/
> ---
> 
> (Updated Sept. 17, 2014, 6:22 a.m.)
> 
> 
> Review request for cloudstack and Mike Tutkowski.
> 
> 
> Bugs: 7406
> https://issues.apache.org/jira/browse/7406
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> since cloudstack is not able to process the S3 or Switf templates for its 
> virtual size(root disk size), admin is facing issues while creating a vm 
> using third party storage plugins like cloudbyte and solidfire etc.
> this patch enables the resize of root disk, on passing a  variable 
> ismanagedstorage = true in deployVmCmd as a detail.
> hence template root disksize is overriden by the given rootdisk size by the 
> admin
> 
> this patch also fixes the iops null issue.
> 
> for more ref
> https://issues.apache.org/jira/browse/CLOUDSTACK-7406
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ea2a89 
> 
> Diff: https://reviews.apache.org/r/25647/diff/
> 
> 
> Testing
> ---
> 
> dry run only.
> 
> 
> Thanks,
> 
> punith s
> 
>

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Mike Tutkowski]

Yeah, it's just a coincidence that there were two blocker issues here.

I fixed the one in the compute area, but I don't have much experience with
the virtual router code. It would be more efficient there to find someone
with experience in that area.

On Fri, Sep 19, 2014 at 5:27 PM, ilya musayev 
wrote:

> Ritu,
>
> Open a ticket in JIRA as major/blocker for 4.5, so it gets noticed.
>
> You can also try running you code on 4.4 or 4.3.1, but i know it maybe too
> much work to backport.
>
> Mike thank you for spending time trying to figure this out.
>
> Regards
> ilya
>
> On 9/19/14, 4:21 PM, Ritu Sabharwal wrote:
>
>> Hi Mike,
>>
>> Thanks for trying out this and the investigation.
>>
>> I hope the developer for system vm would pick up this issue and help to
>> resolve.
>>
>> Thanks & Regards,
>> Ritu S.
>>
>> -Original Message-
>> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> Sent: Friday, September 19, 2014 9:01 AM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs
>> with Vmware setup with CS server
>>
>> http://jenkins.buildacloud.org/job/build-systemvm64-
>> master/lastSuccessfulBuild/artifact/tools/appliance/dist/
>> systemvm64template-master-vmware.ova
>>
>> On Fri, Sep 19, 2014 at 9:58 AM, Erik Weber  wrote:
>>
>>  Which systemvm template are you using?
>>>
>>> Erik
>>> 19. sep. 2014 03:47 skrev "Mike Tutkowski"
>>> 
>>> følgende:
>>>
>>>  Actually, the virtual router says it requires an upgrade.

 I think I can just turn that check off and re-run my create-VM test.

 On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:

  OK, I checked in a fix for this:
>
>
>
>  https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff
>>> ;
>>> h=18e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81
>>> 509e6885aa536932
>>>
 I did notice that both before and after my fix that the virtual
> router
>
 is
>>>
 NOT coming up.
>
> The system VM being cloned and the starting of the VM looks fine.
> It
>
 gets
>>>
 to the command prompt and then a little while later is shut down
> and restarted. I get an error in the GUI indicating that my VM
> deployment failed.
>
> I don't personally know a whole lot about how the virtual router
> code works, so we should pass that on to an appropriate developer.
>
> On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>  Just destroyed and re-created my env from scratch without
>> 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.
>>
>> I think I know what the author was intending with the code that
>> is causing the problem, so I'll go ahead and put in what I think
>> is a
>>
> fix,
>>>
 re-create my env, and see if it works.
>>
>> On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev
>> > wrote:
>>
>>Thank you Mike, please keep us posted.
>>>
>>> Regards
>>> ilya
>>>
>>> On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
>>>
>>> Little clarification on this:
>>>
>>>   "The dsName is derived from the UUID of the datastore."
>>>
>>>   I mean that the dsName is derived from the UUID primary storage
>>> in
>>>
>> the
>>>
 DB.
>>>
>>> On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
>>>  Just a little update on this:

   The problem doesn't seem to have anything to do with "managed"
 storage code that was introduced back in March.

   The dsName is derived from the UUID of the datastore. This
 leads

>>> to a
>>>
 null being returned from

>>> diskInfoBuilder.getDiskInfoByBackingFileBaseName,

> which subsequently leads to a null being returned from this
 method

>>> (and a

> NullPointerException being thrown).

   I plan to take a look at the history of this file in gitk.

  private VirtualMachineDiskInfo
 getMatchingExistingDisk(VirtualMachineDiskInfoBuilder

>>> diskInfoBuilder,
>>>
 DiskTO vol) {

  if (diskInfoBuilder != null) {

  VolumeObjectTO volume =
 (VolumeObjectTO)vol.getData();

  String dsName =

>>> volume.getDataStore().getUuid().replace("-",

> "");


   Map details = vol.getDetails();

  boolean isManaged = details != null &&
 Boolean.parseBoolean(details.get(DiskTO.MANAGED));


   VirtualMachineDiskInfo diskInfo =


 diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ?
>

Build failed in Jenkins: simulator-singlerun #415

[jenkins]

See 

--
[...truncated 8782 lines...]
> Running query: GRANT ALL ON cloud_usage.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON cloud_usage.* to 'cloud'@`%` 
identified by 'cloud'
> Initializing database=cloudbridge with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `cloudbridge`
> Running query: create database `cloudbridge`
> Running query: GRANT ALL ON cloudbridge.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON cloudbridge.* to 'cloud'@`%` 
identified by 'cloud'
> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 2:19.831s
[INFO] Finished at: Fri Sep 19 19:55:34 EDT 2014
[INFO] Final Memory: 42M/176M
[INFO] 
[WARNING] The requested profile "simulator" could not be activated because it 
does not exist.
[simulator-singlerun] $ mvn -P developer -pl developer -Ddeploydb-simulator
[INFO] Scanning for projects...
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Developer Mode 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties 
(default) @ cloud-developer ---
[WARNING] Ignoring missing properties file: 

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] 
[INFO] >>> exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer >>>
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] <<< exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer <<<
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer ---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Abhinandan Prateek]

The VMWare template build by jenkins job does not have VMWare tools installed 
on it.
Use the ones provided by Citrix.

On 19-Sep-2014, at 9:31 pm, Mike Tutkowski  wrote:

> http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-vmware.ova
> 
> On Fri, Sep 19, 2014 at 9:58 AM, Erik Weber  wrote:
> 
>> Which systemvm template are you using?
>> 
>> Erik
>> 19. sep. 2014 03:47 skrev "Mike Tutkowski" 
>> følgende:
>> 
>>> Actually, the virtual router says it requires an upgrade.
>>> 
>>> I think I can just turn that check off and re-run my create-VM test.
>>> 
>>> On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>> 
 OK, I checked in a fix for this:
 
 
 
>>> 
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=18e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81509e6885aa536932
 
 I did notice that both before and after my fix that the virtual router
>> is
 NOT coming up.
 
 The system VM being cloned and the starting of the VM looks fine. It
>> gets
 to the command prompt and then a little while later is shut down and
 restarted. I get an error in the GUI indicating that my VM deployment
 failed.
 
 I don't personally know a whole lot about how the virtual router code
 works, so we should pass that on to an appropriate developer.
 
 On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:
 
> Just destroyed and re-created my env from scratch without
> 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.
> 
> I think I know what the author was intending with the code that is
> causing the problem, so I'll go ahead and put in what I think is a
>> fix,
> re-create my env, and see if it works.
> 
> On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev >> 
> wrote:
> 
>> Thank you Mike, please keep us posted.
>> 
>> Regards
>> ilya
>> 
>> On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
>> 
>> Little clarification on this:
>> 
>> "The dsName is derived from the UUID of the datastore."
>> 
>> I mean that the dsName is derived from the UUID primary storage in
>> the
>> DB.
>> 
>> On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>> 
>>> Just a little update on this:
>>> 
>>> The problem doesn't seem to have anything to do with "managed"
>>> storage code that was introduced back in March.
>>> 
>>> The dsName is derived from the UUID of the datastore. This leads
>> to a
>>> null being returned from
>>> diskInfoBuilder.getDiskInfoByBackingFileBaseName,
>>> which subsequently leads to a null being returned from this method
>>> (and a
>>> NullPointerException being thrown).
>>> 
>>> I plan to take a look at the history of this file in gitk.
>>> 
>>>private VirtualMachineDiskInfo
>>> getMatchingExistingDisk(VirtualMachineDiskInfoBuilder
>> diskInfoBuilder,
>>> DiskTO vol) {
>>> 
>>>if (diskInfoBuilder != null) {
>>> 
>>>VolumeObjectTO volume = (VolumeObjectTO)vol.getData();
>>> 
>>>String dsName =
>>> volume.getDataStore().getUuid().replace("-",
>>> "");
>>> 
>>> 
>>> Map details = vol.getDetails();
>>> 
>>>boolean isManaged = details != null &&
>>> Boolean.parseBoolean(details.get(DiskTO.MANAGED));
>>> 
>>> 
>>> VirtualMachineDiskInfo diskInfo =
>>> 
>>> 
>>> diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ? new
>>> DatastoreFile(volume.getPath()).getFileBaseName() :
>> volume.getPath(),
>>> dsName);
>>> 
>>> On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>> 
 I think I found the magic. :)
 
 sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec
 
 If I mount /export/secondary to /mnt/sec (I did it in a bit of a
 roundabout way here), then the management server is happy.
 
 I think this is only VMware "thing" for the management server.
 
 Does anyone know if we document this?
 
 Thanks!
 
 On Thu, Sep 18, 2014 at 4:18 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:
 
> The instructions even say the following:
> 
> If your secondary storage mount point is not named
>> /mnt/secondary,
> substitute your own mount point name.
> 
> On Thu, Sep 18, 2014 at 4:15 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
> 
>> Yeah, I've been through the instructions a couple times and don't
>> see anything that indicates

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Mike Tutkowski]

Can you provide me a link to the Citrix ones?

Does this mean the standard build for VMware on Jenkins in terms of the
system template is pretty much useless when it comes to the virtual router?

Thanks

On Fri, Sep 19, 2014 at 7:49 PM, Abhinandan Prateek 
wrote:

> The VMWare template build by jenkins job does not have VMWare tools
> installed on it.
> Use the ones provided by Citrix.
>
> On 19-Sep-2014, at 9:31 pm, Mike Tutkowski 
> wrote:
>
> >
> http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-vmware.ova
> >
> > On Fri, Sep 19, 2014 at 9:58 AM, Erik Weber  wrote:
> >
> >> Which systemvm template are you using?
> >>
> >> Erik
> >> 19. sep. 2014 03:47 skrev "Mike Tutkowski" <
> mike.tutkow...@solidfire.com>
> >> følgende:
> >>
> >>> Actually, the virtual router says it requires an upgrade.
> >>>
> >>> I think I can just turn that check off and re-run my create-VM test.
> >>>
> >>> On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
> >>> mike.tutkow...@solidfire.com> wrote:
> >>>
>  OK, I checked in a fix for this:
> 
> 
> 
> >>>
> >>
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=18e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81509e6885aa536932
> 
>  I did notice that both before and after my fix that the virtual router
> >> is
>  NOT coming up.
> 
>  The system VM being cloned and the starting of the VM looks fine. It
> >> gets
>  to the command prompt and then a little while later is shut down and
>  restarted. I get an error in the GUI indicating that my VM deployment
>  failed.
> 
>  I don't personally know a whole lot about how the virtual router code
>  works, so we should pass that on to an appropriate developer.
> 
>  On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
>  mike.tutkow...@solidfire.com> wrote:
> 
> > Just destroyed and re-created my env from scratch without
> > 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.
> >
> > I think I know what the author was intending with the code that is
> > causing the problem, so I'll go ahead and put in what I think is a
> >> fix,
> > re-create my env, and see if it works.
> >
> > On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev <
> ilya.musa...@gmail.com
> >>>
> > wrote:
> >
> >> Thank you Mike, please keep us posted.
> >>
> >> Regards
> >> ilya
> >>
> >> On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
> >>
> >> Little clarification on this:
> >>
> >> "The dsName is derived from the UUID of the datastore."
> >>
> >> I mean that the dsName is derived from the UUID primary storage in
> >> the
> >> DB.
> >>
> >> On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
> >> mike.tutkow...@solidfire.com> wrote:
> >>
> >>> Just a little update on this:
> >>>
> >>> The problem doesn't seem to have anything to do with "managed"
> >>> storage code that was introduced back in March.
> >>>
> >>> The dsName is derived from the UUID of the datastore. This leads
> >> to a
> >>> null being returned from
> >>> diskInfoBuilder.getDiskInfoByBackingFileBaseName,
> >>> which subsequently leads to a null being returned from this method
> >>> (and a
> >>> NullPointerException being thrown).
> >>>
> >>> I plan to take a look at the history of this file in gitk.
> >>>
> >>>private VirtualMachineDiskInfo
> >>> getMatchingExistingDisk(VirtualMachineDiskInfoBuilder
> >> diskInfoBuilder,
> >>> DiskTO vol) {
> >>>
> >>>if (diskInfoBuilder != null) {
> >>>
> >>>VolumeObjectTO volume = (VolumeObjectTO)vol.getData();
> >>>
> >>>String dsName =
> >>> volume.getDataStore().getUuid().replace("-",
> >>> "");
> >>>
> >>>
> >>> Map details = vol.getDetails();
> >>>
> >>>boolean isManaged = details != null &&
> >>> Boolean.parseBoolean(details.get(DiskTO.MANAGED));
> >>>
> >>>
> >>> VirtualMachineDiskInfo diskInfo =
> >>>
> >>>
> >>> diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ? new
> >>> DatastoreFile(volume.getPath()).getFileBaseName() :
> >> volume.getPath(),
> >>> dsName);
> >>>
> >>> On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
> >>> mike.tutkow...@solidfire.com> wrote:
> >>>
>  I think I found the magic. :)
> 
>  sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec
> 
>  If I mount /export/secondary to /mnt/sec (I did it in a bit of a
>  roundabout way here), then the management server is happy.
> 
>  I think this is only VMware "thing" for the management server.
> 
>  Does anyone know if we document this?
> 
>  Thanks!
> 

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Abhinandan Prateek]

VMWare Template:   
http://download.cloud.com/templates/4.5/systemvm64template-4.5-vmware.ova
 Checksum: 3106a79a4ce66cd7f6a7c50e93f2db57

Last I checked systemvm.iso will not get mounted.

-abhi

On 20-Sep-2014, at 8:32 am, Mike Tutkowski  wrote:

> Can you provide me a link to the Citrix ones?
> 
> Does this mean the standard build for VMware on Jenkins in terms of the
> system template is pretty much useless when it comes to the virtual router?
> 
> Thanks
> 
> On Fri, Sep 19, 2014 at 7:49 PM, Abhinandan Prateek 
> wrote:
> 
>> The VMWare template build by jenkins job does not have VMWare tools
>> installed on it.
>> Use the ones provided by Citrix.
>> 
>> On 19-Sep-2014, at 9:31 pm, Mike Tutkowski 
>> wrote:
>> 
>>> 
>> http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-vmware.ova
>>> 
>>> On Fri, Sep 19, 2014 at 9:58 AM, Erik Weber  wrote:
>>> 
 Which systemvm template are you using?
 
 Erik
 19. sep. 2014 03:47 skrev "Mike Tutkowski" <
>> mike.tutkow...@solidfire.com>
 følgende:
 
> Actually, the virtual router says it requires an upgrade.
> 
> I think I can just turn that check off and re-run my create-VM test.
> 
> On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
> 
>> OK, I checked in a fix for this:
>> 
>> 
>> 
> 
 
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=18e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81509e6885aa536932
>> 
>> I did notice that both before and after my fix that the virtual router
 is
>> NOT coming up.
>> 
>> The system VM being cloned and the starting of the VM looks fine. It
 gets
>> to the command prompt and then a little while later is shut down and
>> restarted. I get an error in the GUI indicating that my VM deployment
>> failed.
>> 
>> I don't personally know a whole lot about how the virtual router code
>> works, so we should pass that on to an appropriate developer.
>> 
>> On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>> 
>>> Just destroyed and re-created my env from scratch without
>>> 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.
>>> 
>>> I think I know what the author was intending with the code that is
>>> causing the problem, so I'll go ahead and put in what I think is a
 fix,
>>> re-create my env, and see if it works.
>>> 
>>> On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev <
>> ilya.musa...@gmail.com
> 
>>> wrote:
>>> 
 Thank you Mike, please keep us posted.
 
 Regards
 ilya
 
 On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
 
 Little clarification on this:
 
 "The dsName is derived from the UUID of the datastore."
 
 I mean that the dsName is derived from the UUID primary storage in
 the
 DB.
 
 On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:
 
> Just a little update on this:
> 
> The problem doesn't seem to have anything to do with "managed"
> storage code that was introduced back in March.
> 
> The dsName is derived from the UUID of the datastore. This leads
 to a
> null being returned from
> diskInfoBuilder.getDiskInfoByBackingFileBaseName,
> which subsequently leads to a null being returned from this method
> (and a
> NullPointerException being thrown).
> 
> I plan to take a look at the history of this file in gitk.
> 
>   private VirtualMachineDiskInfo
> getMatchingExistingDisk(VirtualMachineDiskInfoBuilder
 diskInfoBuilder,
> DiskTO vol) {
> 
>   if (diskInfoBuilder != null) {
> 
>   VolumeObjectTO volume = (VolumeObjectTO)vol.getData();
> 
>   String dsName =
> volume.getDataStore().getUuid().replace("-",
> "");
> 
> 
>Map details = vol.getDetails();
> 
>   boolean isManaged = details != null &&
> Boolean.parseBoolean(details.get(DiskTO.MANAGED));
> 
> 
>VirtualMachineDiskInfo diskInfo =
> 
> 
> diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ? new
> DatastoreFile(volume.getPath()).getFileBaseName() :
 volume.getPath(),
> dsName);
> 
> On Thu, Sep 18, 2014 at 4:34 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
> 
>> I think I found the magic. :)
>> 
>> sudo mount -t nfs 192.168.129.46:/export/secondary /mnt/sec
>> 

Re: [VMWARE SETUP ERROR] Error seeing in brining up System VMs with Vmware setup with CS server

[Mike Tutkowski]

Thanks!

On Fri, Sep 19, 2014 at 9:18 PM, Abhinandan Prateek 
wrote:

>
> VMWare Template:
> http://download.cloud.com/templates/4.5/systemvm64template-4.5-vmware.ova
>  Checksum: 3106a79a4ce66cd7f6a7c50e93f2db57
>
> Last I checked systemvm.iso will not get mounted.
>
> -abhi
>
> On 20-Sep-2014, at 8:32 am, Mike Tutkowski 
> wrote:
>
> > Can you provide me a link to the Citrix ones?
> >
> > Does this mean the standard build for VMware on Jenkins in terms of the
> > system template is pretty much useless when it comes to the virtual
> router?
> >
> > Thanks
> >
> > On Fri, Sep 19, 2014 at 7:49 PM, Abhinandan Prateek <
> agneya2...@gmail.com>
> > wrote:
> >
> >> The VMWare template build by jenkins job does not have VMWare tools
> >> installed on it.
> >> Use the ones provided by Citrix.
> >>
> >> On 19-Sep-2014, at 9:31 pm, Mike Tutkowski <
> mike.tutkow...@solidfire.com>
> >> wrote:
> >>
> >>>
> >>
> http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-vmware.ova
> >>>
> >>> On Fri, Sep 19, 2014 at 9:58 AM, Erik Weber 
> wrote:
> >>>
>  Which systemvm template are you using?
> 
>  Erik
>  19. sep. 2014 03:47 skrev "Mike Tutkowski" <
> >> mike.tutkow...@solidfire.com>
>  følgende:
> 
> > Actually, the virtual router says it requires an upgrade.
> >
> > I think I can just turn that check off and re-run my create-VM test.
> >
> > On Thu, Sep 18, 2014 at 7:43 PM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> >> OK, I checked in a fix for this:
> >>
> >>
> >>
> >
> 
> >>
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=18e5aa116e99906f24a292bf7546809e05c72ec2;hp=7537c33bcdda65672fdd8f81509e6885aa536932
> >>
> >> I did notice that both before and after my fix that the virtual
> router
>  is
> >> NOT coming up.
> >>
> >> The system VM being cloned and the starting of the VM looks fine. It
>  gets
> >> to the command prompt and then a little while later is shut down and
> >> restarted. I get an error in the GUI indicating that my VM
> deployment
> >> failed.
> >>
> >> I don't personally know a whole lot about how the virtual router
> code
> >> works, so we should pass that on to an appropriate developer.
> >>
> >> On Thu, Sep 18, 2014 at 6:35 PM, Mike Tutkowski <
> >> mike.tutkow...@solidfire.com> wrote:
> >>
> >>> Just destroyed and re-created my env from scratch without
> >>> 8bb4022f3729154f85036c4a7f55e2de783e4909 and it works fine.
> >>>
> >>> I think I know what the author was intending with the code that is
> >>> causing the problem, so I'll go ahead and put in what I think is a
>  fix,
> >>> re-create my env, and see if it works.
> >>>
> >>> On Thu, Sep 18, 2014 at 6:26 PM, ilya musayev <
> >> ilya.musa...@gmail.com
> >
> >>> wrote:
> >>>
>  Thank you Mike, please keep us posted.
> 
>  Regards
>  ilya
> 
>  On 9/18/14, 4:14 PM, Mike Tutkowski wrote:
> 
>  Little clarification on this:
> 
>  "The dsName is derived from the UUID of the datastore."
> 
>  I mean that the dsName is derived from the UUID primary storage in
>  the
>  DB.
> 
>  On Thu, Sep 18, 2014 at 5:12 PM, Mike Tutkowski <
>  mike.tutkow...@solidfire.com> wrote:
> 
> > Just a little update on this:
> >
> > The problem doesn't seem to have anything to do with "managed"
> > storage code that was introduced back in March.
> >
> > The dsName is derived from the UUID of the datastore. This leads
>  to a
> > null being returned from
> > diskInfoBuilder.getDiskInfoByBackingFileBaseName,
> > which subsequently leads to a null being returned from this
> method
> > (and a
> > NullPointerException being thrown).
> >
> > I plan to take a look at the history of this file in gitk.
> >
> >   private VirtualMachineDiskInfo
> > getMatchingExistingDisk(VirtualMachineDiskInfoBuilder
>  diskInfoBuilder,
> > DiskTO vol) {
> >
> >   if (diskInfoBuilder != null) {
> >
> >   VolumeObjectTO volume = (VolumeObjectTO)vol.getData();
> >
> >   String dsName =
> > volume.getDataStore().getUuid().replace("-",
> > "");
> >
> >
> >Map details = vol.getDetails();
> >
> >   boolean isManaged = details != null &&
> > Boolean.parseBoolean(details.get(DiskTO.MANAGED));
> >
> >
> >VirtualMachineDiskInfo diskInfo =
> >
> >
> > diskInfoBuilder.getDiskInfoByBackingFileBaseName(isManaged ? new
>