[ACS44] ready to abandon 4.4-forward

2014-08-04 Thread Daan Hoogland 
ok, thanks Gaurav,

There is no more reason to maintain 4.4-forward. I will keep it around
for a week off cooling period and then delete it.

Please in line with our newly approved way of working [1] make a
branch off 4.4 for any work you need to go in 4.4.1 and call for a
merge of that branch when ready. As the diff to master is to big at
this moment, 4.4 will adopt the new way of working but be on it's own.
read the wiki [2] under heading "Proposed Gitflow based Check-in
Process".

with some ammendament from that page:

This would be the flow for a hot fix

branch off from the release branch (was: tag on master). in this case
it would be 4.4 (was: release/4.4.0)
commit the fixes in hotfix- (was: hotfix/4.4.1)
call for me for the merge untill I do the release
port (was: merge) to develop
port (was: merge) to master and update tags
delete hot fix branch

Note that my change of this procedure is only for the 4.4 (and maybe
still 4.3) branch As Leo [3] has shown it is not feasible to extend
the new way of working into these old branches


[1] http://markmail.org/message/h7nh6ozseien7ezh
[2] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Git
[3] http://markmail.org/message/on2l5n6uaucpuuwf

I will get the systemvm upgrade path as inspired by the 4.3 one in and
propose a 4.4.1.

kind regards,
Daan

On Mon, Aug 4, 2014 at 6:43 AM, Gaurav Aradhye
 wrote:
> Yes Daan, the one with (-) is the one to keep.
>
> Regards,
> Gaurav
>
>
> On Mon, Aug 4, 2014 at 12:11 AM, Daan Hoogland 
> wrote:
>
>> H test developers,
>>
>> One of the diffs between 4.4 and 4.4-forward I am not sure of is the
>> folowing
>>
>> diff --git a/test/integration/smoke/test_network.py
>> b/test/integration/smoke/test_network.py
>> index 988a162..4943b47 100644
>> --- a/test/integration/smoke/test_network.py
>> +++ b/test/integration/smoke/test_network.py
>> @@ -383,13 +383,12 @@ class TestPortForwarding(cloudstackTestCase):
>>
>>  try:
>>  nat_rule.delete(self.apiclient)
>> -except Exception as e:
>> -self.fail("NAT Rule Deletion Failed: %s" % e)
>> -
>> -# NAT rule listing should fail as the nat rule does not exist
>> -with self.assertRaises(Exception):
>> -list_nat_rules(self.apiclient,
>> -   id=nat_rule.id)
>> +list_nat_rule_response = list_nat_rules(
>> +self.apiclient,
>> +id=nat_rule.id
>> +)
>> +except CloudstackAPIException:
>> +self.fail("Nat Rule Deletion or Listing Failed")
>>
>>  # Check if the Public SSH port is inaccessible
>>  with self.assertRaises(Exception):
>>
>> It would seem that the original (- minus signs) is the one to keep,
>> please comment on this
>>
>> --
>> Daan
>>



-- 
Daan

Jenkins build became unstable: simulator-singlerun #33

2014-08-04 Thread jenkins 
See

Build failed in Jenkins: simulator-singlerun #34

2014-08-04 Thread jenkins 
See 

Changes:

[rajanikaruturi] added tools/marvin/build to gitignore

--
[...truncated 7247 lines...]
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer ---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
> WARNING: Provided file does not exist: 

> Initializing database=simulator with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `simulator`
> Running query: create database `simulator`
> Running query: GRANT ALL ON simulator.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON simulator.* to 'cloud'@`%` identified 
by 'cloud'
> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24.148s
[INFO] Finished at: Mon Aug 04 04:32:21 EDT 2014
[INFO] Final Memory: 41M/178M
[INFO] 
[simulator-singlerun] $ /bin/bash -x /tmp/hudson8390563182580183520.sh
+ jps -l
+ grep -q Launcher
+ rm -f xunit.xml
+ rm -rf /tmp/MarvinLogs
+ echo Check for initialization of the management server
Check for initialization of the management server
+ COUNTER=0
+ SERVER_PID=13293
+ mvn -P systemvm,simulator -pl :cloud-client-ui jetty:run
+ '[' 0 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=1
+ '[' 1 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=2
+ '[' 2 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=3
+ '[' 3 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=4
+ '[' 4 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=5
+ '[' 5 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=6
+ '[' 6 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=7
+ '[' 7 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=8
+ '[' 8 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=9
+ '[' 9 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=10
+ '[' 10 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=11
+ '[' 11 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=12
+ '[' 12 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=13
+ '[' 13 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=14
+ '[' 14 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=15
+ '[' 15 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=16
+ '[' 16 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=17
+ '[' 17 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=18
+ '[' 18 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=19
+ '[' 19 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=20
+ '[' 20 -lt 44 ']'
+ grep -q 'Management se

Re: [ACS44]{DISCUSS] remove from the site

2014-08-04 Thread benoit lair 
Hello


Haven't we got a very similar problem when upgrading from acs 4.2 to acs
4.3 ? From my memories, we had to apply a trick in order to get working the
system vm template after upgrading the acs version.

I do not see this as a blocking step for a production environment. If there
is in the installation upgrade process the notice with a tutorial
explaining why and how to do it securely, so we can prepare smoothly our
upgrade, isn't it ?


2014-08-01 16:55 GMT+02:00 David Nalley :

> On Fri, Aug 1, 2014 at 10:45 AM, Sebastien Goasguen 
> wrote:
> >
> > On Aug 1, 2014, at 4:56 AM, Daan Hoogland 
> wrote:
> >
> >> H,
> >>
> >> In the last couple of days a lot of problems with 4.4.0 have been
> >> reported. Workarounds, if at all available, are hard and require
> >> intimate sysadmin experience. It seems to me we didn't deliver the
> >> quality we want to.
> >>
> >> One of the problems is that the systemvms need an upgrade because of
> >> our java 1.7 usage which poses a potential bootstrap problem in case
> >> the secondary storage vm is rebooted/restarted. A possible solution
> >> would be to have the svm do an update on the java packages with ssh
> >> during the upgrade of the management server.
> >> Concequential problem is that the upgrade of the systemvms at this
> >> moment requires manual intervention of the operator, as the upgrade
> >> code as used in the case of 4.3 has not been created for this version.
> >> A workaround is here:
> >> https://gist.github.com/terbolous/102ae8edd1cda192561c/
> >>
> >> SO I wonder if we should still expose the world to version 4.4.0
> >>
> >> thoughts?
> >
> > Haven't tried upgrade, but if there is an issue (and it seems like there
> is), then we should release 4.4.1 asap.
> > And inform users@ of the problem...
> >
>
> Agreed.
> We can't undo 4.4.0 - we can delay promoting the 4.4 release until
> 4.4.1 is available.
>
> --David
>

Review Request 24228: CLOUDSTACK-7235: Fixed ModifyStoragePoolCommand returns unsupported command answer if provided wrong path

2014-08-04 Thread Anshul Gangwar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24228/
---

Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Bugs: CLOUDSTACK-7235
https://issues.apache.org/jira/browse/CLOUDSTACK-7235


Repository: cloudstack-git


Description
---

 Now ModifyStoragePoolCommand returns appropriate error if provided wrong path


Diffs
-

  
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs
 195a964 

Diff: https://reviews.apache.org/r/24228/diff/


Testing
---

verified by adding the primary storage with wrong path. Appropriate error is 
returned from the agent


Thanks,

Anshul Gangwar

Re: Review Request 24152: CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network

2014-08-04 Thread Koushik Das 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24152/
---

(Updated Aug. 4, 2014, 10:18 a.m.)


Review request for cloudstack, Alena Prokharchyk and Sheng Yang.


Changes
---

Rebased with latest master


Bugs: CLOUDSTACK-7182
https://issues.apache.org/jira/browse/CLOUDSTACK-7182


Repository: cloudstack-git


Description
---

- Check to see if network is implemented changed from 'state == 
Implementing||Implemented' to 'state == Implemented'. The earlier check was a 
hack to prevent the issue described next.
- At the time of implementing network (using implementNetwork() method), if the 
VR needs to be deployed then it follows the same path of regular VM deployment. 
This leads to a nested call to implementNetwork() while preparing VR nics. This 
flow creates issues in dealing with network state transitions. The original 
call puts network in "Implementing" state and then the nested call again tries 
to put it into same state resulting in issues. In order to avoid it, 
implementNetwork() call for VR is replaced with below code.


Diffs (updated)
-

  
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 cdca839 

Diff: https://reviews.apache.org/r/24152/diff/


Testing
---

Ran isolated network tests using simulator.
Also ran the following VPC test using simulator:
1. created vpc, VR gets started as part of this
2. created network in the vpc
3. deployed vm in network created in step#2


Thanks,

Koushik Das

Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy support scripts from spawning multiple java processes

2014-08-04 Thread Saurav Lahiri 
Rajani,
I had missed this. My apologies. The status shows as submitted. I am
guessing that you have updated the status and nothing more needs to be done.

Saurav



On Mon, Jul 28, 2014 at 11:48 AM, Rajani Karuturi 
wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
>
> On April 29th, 2014, 12:29 p.m. UTC, *Santhosh Edukulla* wrote:
>
> Ship It!
>
>  On May 23rd, 2014, 6:54 p.m. UTC, *Santhosh Edukulla* wrote:
>
> If we don't have any review issues pending, can some body with commit rights 
> push this patch?
>
>  On July 22nd, 2014, 6:29 a.m. UTC, *Santhosh Edukulla* wrote:
>
> Saurav,
>
> Please update BugId and Branch fields. This review submission is pending 
> since long. Please check.
>
> Santhosh
>
>  santhosh, bug-id is mentioned in the subject CLOUDSTACK-6328
>
> I looked at the bug comments on the bug. changes are already committed by 
> jayapal. But, commit id isnt updated here and the review isnt closed.
>
> here is the commit for master 
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=96b1c6b
>
> saurav, can you mark this review submitted?
>
>
> - Rajani
>
> On April 23rd, 2014, 9:20 a.m. UTC, Saurav Lahiri wrote:
>   Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh
> Battala, and Santhosh Edukulla.
> By Saurav Lahiri.
>
> *Updated April 23, 2014, 9:20 a.m.*
>  *Repository: * cloudstack-git
> Description
>
> With multiple java processes writing to the same logfile, each is not aware 
> of the log4j's internal counter state, this needs to be prevented. So before 
> starting new java process via the _run.sh , a check is made to ensure that 
> there are no existing java processes running. This will prevent multiple java 
> process writing to the same log file namely cloud.out.
>
>   Testing
>
> Tested the changes with console proxy vm and secondary storage vm. They start 
> and stop as expected.
>
>   Diffs
>
>- systemvm/patches/debian/config/etc/init.d/cloud (83853bc)
>- systemvm/scripts/run.sh (146d96f)
>- systemvm/scripts/utils.sh (PRE-CREATION)
>
> View Diff 
>

Re: Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java

2014-08-04 Thread Damodar Reddy Talakanti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/
---

(Updated Aug. 4, 2014, 11:42 a.m.)


Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh 
Edukulla.


Changes
---

Incorporated Murali Comments and added few more fixes from COverity scan.


Repository: cloudstack-git


Description
---

Fixed some more Coverity reported issues in CitrixResourceBase.java.

Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180


Diffs (updated)
-

  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 775f5455 

Diff: https://reviews.apache.org/r/23924/diff/


Testing (updated)
---

Ran against marvin BVT.


Thanks,

Damodar Reddy Talakanti

Re: Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java

2014-08-04 Thread Santhosh Edukulla 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/#review49450
---



plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java


Please check if static is required here.


- Santhosh Edukulla


On Aug. 4, 2014, 11:42 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23924/
> ---
> 
> (Updated Aug. 4, 2014, 11:42 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh 
> Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed some more Coverity reported issues in CitrixResourceBase.java.
> 
> Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  775f5455 
> 
> Diff: https://reviews.apache.org/r/23924/diff/
> 
> 
> Testing
> ---
> 
> Ran against marvin BVT.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java

2014-08-04 Thread Damodar Reddy Talakanti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/
---

(Updated Aug. 4, 2014, 11:56 a.m.)


Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh 
Edukulla.


Changes
---

Incorporated Santhosh comments


Repository: cloudstack-git


Description
---

Fixed some more Coverity reported issues in CitrixResourceBase.java.

Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180


Diffs (updated)
-

  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 775f5455 

Diff: https://reviews.apache.org/r/23924/diff/


Testing
---

Ran against marvin BVT.


Thanks,

Damodar Reddy Talakanti

Re: Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java

2014-08-04 Thread Santhosh Edukulla 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/#review49451
---

Ship it!


Ship It!

- Santhosh Edukulla


On Aug. 4, 2014, 11:56 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23924/
> ---
> 
> (Updated Aug. 4, 2014, 11:56 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh 
> Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed some more Coverity reported issues in CitrixResourceBase.java.
> 
> Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  775f5455 
> 
> Diff: https://reviews.apache.org/r/23924/diff/
> 
> 
> Testing
> ---
> 
> Ran against marvin BVT.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Jenkins build is unstable: simulator-singlerun #35

2014-08-04 Thread jenkins 
See

Re: Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java

2014-08-04 Thread Santhosh Edukulla 


> On Aug. 4, 2014, 11:59 a.m., Santhosh Edukulla wrote:
> > Ship It!

acffe5a..b73fe32  master -> master


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/#review49451
---


On Aug. 4, 2014, 11:56 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23924/
> ---
> 
> (Updated Aug. 4, 2014, 11:56 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh 
> Edukulla.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed some more Coverity reported issues in CitrixResourceBase.java.
> 
> Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  775f5455 
> 
> Diff: https://reviews.apache.org/r/23924/diff/
> 
> 
> Testing
> ---
> 
> Ran against marvin BVT.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Review Request 24229: upgrade system templates in 4.4.x

2014-08-04 Thread daan Hoogland 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24229/
---

Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.


Repository: cloudstack-git


Description
---

upgrade code for templates in 4.4.x due to java upgrade


Diffs
-

  engine/schema/src/com/cloud/upgrade/dao/Upgrade440to441.java 497da8d 

Diff: https://reviews.apache.org/r/24229/diff/


Testing
---

sugestions welcome


Thanks,

daan Hoogland

Jenkins build is still unstable: simulator-singlerun #36

2014-08-04 Thread jenkins 
See

Review Request 24232: Removing invalid and unused import from test_escalations_templates.py

2014-08-04 Thread Gaurav Aradhye 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24232/
---

Review request for cloudstack and Girish Shilamkar.


Repository: cloudstack-git


Description
---

Removed invalid and unused import which was causing failure.


Diffs
-

  test/integration/component/test_escalations_templates.py 06e3d42 

Diff: https://reviews.apache.org/r/24232/diff/


Testing
---

Tested with python command.


Thanks,

Gaurav Aradhye

[ACS44] templates upgrade

2014-08-04 Thread Daan Hoogland 
H,

please have a look at https://reviews.apache.org/r/24229/
I will apply this on 4.4 if all right.
Any advice on testing this code?

-- 
Daan

implementing git workflow

2014-08-04 Thread Leo Simons 
Hey folks,

Since Daan volunteered me to do some docs, I’ve updated Rohit’s page at
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Git

with additional details.

I went back through all the e-mails on the subject to find questions/concerns, 
addressed the ones I think have consensus and highlighted a few places where 
additional decision/discussion may be needed.

Remaining topics I’m not sure about:
* when to cut over
* how to cut over
* policy for who merges to release branches
* policy for adding features in micro releases
* what to name hot fixes

Comments on each below.

When to cut over

I think docs are quite sufficient now. I’d personally suggest to just do it.

Since the vote is done I think any committer should feel free to pick up the 
ball :)

How to cut over
---
* Someone has to make the branches and announce the flip on the mailing list.
* Everyone has to flip / git flow init / etc.
* Someone has to update jenkins.buildacloud.org to build the new develop branch.
* ???
* Profit.

Again, I’d personally suggest to just do it.

Policy for who merges to release branches
-
There was some unresolved discussion about
1. when it is ok to directly commit to the release branch
2. when it is ok for other people than the release manager to merge to the 
release branch
3. when/how to do a freeze of a release branch

Git flow says:
1. basically never
2. what’s a release manager?
3. never, cut release branch == feature freeze, tag release == freeze

Personally I would suggest
1. never unless you are doing release management (i.e. version bump) commits
2. always as long as you are confident and prepared to suffer the wrath of 
doing it wrong, ask the release manager to do it if you are not confident
3. at the jurisdiction of the release manager

Policy for adding features onto release branches

It has been cloudstack practice to include new features (or enable features) in 
micro releases.

I did document how to do this within the git-flow model, but I strongly suggest 
to simply stop doing it.

I suggest the policy is that this can be done as an exception to the rule after 
discussion on the mailing list, using lazy consensus, with the release manager 
doing the merge to the release branch.

what to name hotfixes
-
hotfix/

the - should be descriptive and is optional.

hotfix/4.4-

for fixes to 4.4.x.



cheers,



Leo

Re: Wiki : Code Submission and Review Guidelines

2014-08-04 Thread Leo Simons 
On Jul 31, 2014, at 10:34 AM, Santhosh Edukulla  
wrote:
> Iam not sure if it is already available, so i added a simple wiki with few 
> notes for new submission and review process at the link below.
> 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Code+Submission+and+Review+Guidelines

There were a few places. I changed them to point at this page since it’s better 
:)

In general the wiki suffers from duplicated info! Now that I have access I 
might try and do some more cleanup.

> In case, if there are any issues with the wiki, please feel free to modify 
> and add accordingly. If we can add specific examples for few cases helping 
> users to follow them appropriately, then it will be more good.

Well, what I’m missing is the inverse of these guidelines. Being a committer on 
an apache project is a privilege and a responsibility, and if a guideline is 
needed for code submission, it requires definition of the behavior of the 
reviewer at least as much as behavior of the contributor.

* ensuring submissions to reviewboard get review
  * it’s not good community-building to require patch submitters
to go hunt for a committer that can review their work
* ensuring review is consistent
  * it’s not good to be told to do one thing, then to be told to
do another thing, then to be told to do another thing…
  * it’s not good to be told something is ok (lazy consensus…),
do a bunch of work, and then be told it is not ok (remember,
-1 includes a commitment to help sort out the issue, whether
a contribution comes from a committer or not)
* ensuring review aligns with committer practice & code quality
  * it’s not a good thing to hold a contributor to a _higher_
standard than committers
  * it’s not a good thing to require contributors to follow all
code quality standards when existing code does not follow those
standards — fixing a bug shouldn’t involve rewriting the
surrounding code and accepting a bugfix shouldn’t involve
those things either

I think it is good to improve quality and good to have quality guidelines, but 
when you have them it is more important that committers adhere to them than 
external contributors. I.e. quality _practices_.

In general I’m not a big fan of documented guidelines and policies and 
procedures. I think apache has too many of them already, and I’m _especially_ 
guilty since I wrote a bunch of it :-).

_That_ said, what we need the most is more people stepping up and doing review, 
and if this guideline helps with that, great! Go go go! :)


cheers,


Leo

Jenkins build is still unstable: simulator-singlerun #37

2014-08-04 Thread jenkins 
See

Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to be connected before verication

2014-08-04 Thread John Dilley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/
---

(Updated Aug. 4, 2014, 2:50 p.m.)


Review request for cloudstack and Santhosh Edukulla.


Changes
---

Updated diff with whitespace issues fixed


Bugs: CLOUDSTACK-7223
https://issues.apache.org/jira/browse/CLOUDSTACK-7223


Repository: cloudstack-git


Description
---

This change waits for the system VM agent state to be up in the testcases that 
stop/reboot/destroy system VMs before verifying that they are functioning 
properly.


Diffs (updated)
-

  test/integration/smoke/test_ssvm.py ac4079e 

Diff: https://reviews.apache.org/r/24182/diff/


Testing
---

Tested against KVM advanced zone


Thanks,

John Dilley

Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to be connected before verication

2014-08-04 Thread Rohit Yadav 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49455
---


Thanks for the patch, is this already merged into master and respective branch?

- Rohit Yadav


On Aug. 4, 2014, 2:50 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> ---
> 
> (Updated Aug. 4, 2014, 2:50 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7223
> https://issues.apache.org/jira/browse/CLOUDSTACK-7223
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This change waits for the system VM agent state to be up in the testcases 
> that stop/reboot/destroy system VMs before verifying that they are 
> functioning properly.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_ssvm.py ac4079e 
> 
> Diff: https://reviews.apache.org/r/24182/diff/
> 
> 
> Testing
> ---
> 
> Tested against KVM advanced zone
> 
> 
> Thanks,
> 
> John Dilley
> 
>

Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to be connected before verication

2014-08-04 Thread John Dilley 


> On Aug. 4, 2014, 2:56 p.m., Rohit Yadav wrote:
> > Thanks for the patch, is this already merged into master and respective 
> > branch?

Not yet - Santhosh asked for a patch that didn't have the whitespace issues.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49455
---


On Aug. 4, 2014, 2:50 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> ---
> 
> (Updated Aug. 4, 2014, 2:50 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7223
> https://issues.apache.org/jira/browse/CLOUDSTACK-7223
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This change waits for the system VM agent state to be up in the testcases 
> that stop/reboot/destroy system VMs before verifying that they are 
> functioning properly.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_ssvm.py ac4079e 
> 
> Diff: https://reviews.apache.org/r/24182/diff/
> 
> 
> Testing
> ---
> 
> Tested against KVM advanced zone
> 
> 
> Thanks,
> 
> John Dilley
> 
>

Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to be connected before verication

2014-08-04 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49457
---


Commit 0c77b2007e3918b10a8de560b2f63bd0f0f2cbdd in cloudstack's branch 
refs/heads/master from John Dilley
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0c77b20 ]

CLOUDSTACK-7223: Wait for system VM agent state to be up before verification

Signed-off-by: Santhosh Edukulla 


- ASF Subversion and Git Services


On Aug. 4, 2014, 2:50 p.m., John Dilley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> ---
> 
> (Updated Aug. 4, 2014, 2:50 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7223
> https://issues.apache.org/jira/browse/CLOUDSTACK-7223
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This change waits for the system VM agent state to be up in the testcases 
> that stop/reboot/destroy system VMs before verifying that they are 
> functioning properly.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_ssvm.py ac4079e 
> 
> Diff: https://reviews.apache.org/r/24182/diff/
> 
> 
> Testing
> ---
> 
> Tested against KVM advanced zone
> 
> 
> Thanks,
> 
> John Dilley
> 
>

Re: Revert Bacck

2014-08-04 Thread Daan Hoogland 
Jaya, If you want to go from 4.4.1 to 4.4.0 all you need to do is
replace the code. There have not been any database changes yet, so a
replace of the rpms/debs/jars should do.


On Mon, Aug 4, 2014 at 5:00 PM, Elapavuluri, Jaya
 wrote:
> Hello,
>
> I am currently working on 4.4.1 and would like to revert back to 4.4. Could 
> some one guide me with this.



-- 
Daan

Revert Bacck

2014-08-04 Thread Elapavuluri, Jaya 
Hello,

I am currently working on 4.4.1 and would like to revert back to 4.4. Could 
some one guide me with this.

ACS 4.5 branch date

2014-08-04 Thread Rayees Namathponnan 
Hi All,

When we are going to create ACS 4.5 branch ? is there any scheduled date ?

Regards,
Rayees

Review Request 24238: Fix mvn marvin.sync profile

2014-08-04 Thread Leo Simons 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24238/
---

Review request for cloudstack and Rohit Yadav.


Repository: cloudstack-git


Description
---

Commit e10f8e887571e28f31dbcf02a0beac163a901fe1 broke
  mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin
Because the maven file had hard-coded 0.1.0.

This fix removes the hard-coding completely, by having the python setup read
the version from the maven pom.xml, and the maven setup using its version.


Diffs
-

  tools/marvin/MANIFEST.in 3d373818c2096db12b61902a51f2fe39f2e0608e 
  tools/marvin/pom.xml 3bf70e041c6bab051d7a184ff9c3c81ea31d2054 
  tools/marvin/setup.py 555d67dfc491cf5ab52d36b417a6b5842ea6ad96 

Diff: https://reviews.apache.org/r/24238/diff/


Testing
---

Commands that work now for me include:

mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin
python setup.py install
python setup.py develop
mvn -P developer -pl :cloud-marvin


Thanks,

Leo Simons

Re: ACS 4.5 branch date

2014-08-04 Thread Hugo Trippaers 
Rayees,

The scheduled date was July 19th. However we didn't create the branch yet as we 
don’t have a release manager for 4.5. Also the discussion on git flow is still 
pending and it might be wise to wait until that proposal is discussed before we 
continue with 4.5 as it will change how we deal with branching. 

Effectively this means that we have no set date when we will “officially” start 
working towards a 4.5 release.

Cheers,

Hugo


On 4 aug. 2014, at 17:56, Rayees Namathponnan  
wrote:

> Hi All,
> 
> When we are going to create ACS 4.5 branch ? is there any scheduled date ?
> 
> Regards,
> Rayees

Jenkins build is still unstable: simulator-singlerun #38

2014-08-04 Thread jenkins 
See

Re: Review Request 24238: Fix mvn marvin.sync profile

2014-08-04 Thread Santhosh Edukulla 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24238/#review49460
---



tools/marvin/setup.py


Please tying like this to as a dependency on pom.xml, may unnecessarily 
lead to tight coupling with mvn logic inside of setup.py. Currently, only 
cloudstackAPI is the one which marvin relies upon while building cs through 
mvn, otherwise we can remove that dependency as well, its in plan. Any upload 
of marvin to external package download system will tie this dependency on 
pom.xml. 


- Santhosh Edukulla


On Aug. 4, 2014, 4:08 p.m., Leo Simons wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24238/
> ---
> 
> (Updated Aug. 4, 2014, 4:08 p.m.)
> 
> 
> Review request for cloudstack and Rohit Yadav.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Commit e10f8e887571e28f31dbcf02a0beac163a901fe1 broke
>   mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin
> Because the maven file had hard-coded 0.1.0.
> 
> This fix removes the hard-coding completely, by having the python setup read
> the version from the maven pom.xml, and the maven setup using its version.
> 
> 
> Diffs
> -
> 
>   tools/marvin/MANIFEST.in 3d373818c2096db12b61902a51f2fe39f2e0608e 
>   tools/marvin/pom.xml 3bf70e041c6bab051d7a184ff9c3c81ea31d2054 
>   tools/marvin/setup.py 555d67dfc491cf5ab52d36b417a6b5842ea6ad96 
> 
> Diff: https://reviews.apache.org/r/24238/diff/
> 
> 
> Testing
> ---
> 
> Commands that work now for me include:
> 
> mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin
> python setup.py install
> python setup.py develop
> mvn -P developer -pl :cloud-marvin
> 
> 
> Thanks,
> 
> Leo Simons
> 
>

Build failed in Jenkins: simulator-singlerun #39

2014-08-04 Thread jenkins 
See 

--
[...truncated 7239 lines...]
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer ---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
> WARNING: Provided file does not exist: 

> Initializing database=simulator with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `simulator`
> Running query: create database `simulator`
> Running query: GRANT ALL ON simulator.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON simulator.* to 'cloud'@`%` identified 
by 'cloud'
> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 32.073s
[INFO] Finished at: Mon Aug 04 12:35:56 EDT 2014
[INFO] Final Memory: 43M/169M
[INFO] 
[simulator-singlerun] $ /bin/bash -x /tmp/hudson2802412659749729197.sh
+ jps -l
+ grep -q Launcher
+ rm -f xunit.xml
+ rm -rf /tmp/MarvinLogs
+ echo Check for initialization of the management server
Check for initialization of the management server
+ COUNTER=0
+ SERVER_PID=14413
+ '[' 0 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ mvn -P systemvm,simulator -pl :cloud-client-ui jetty:run
+ sleep 5
+ COUNTER=1
+ '[' 1 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=2
+ '[' 2 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=3
+ '[' 3 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=4
+ '[' 4 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=5
+ '[' 5 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=6
+ '[' 6 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=7
+ '[' 7 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=8
+ '[' 8 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=9
+ '[' 9 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=10
+ '[' 10 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=11
+ '[' 11 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=12
+ '[' 12 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=13
+ '[' 13 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=14
+ '[' 14 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=15
+ '[' 15 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=16
+ '[' 16 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=17
+ '[' 17 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=18
+ '[' 18 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=19
+ '[' 19 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=20
+ '[' 20 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=21
+ '['

Secondary ip address and static nat

2014-08-04 Thread Alena Prokharchyk 
Hi Jayapal,

I have a question to you regarding your commit aedb8c47 for secondary ip 
address in terms of StaticNat feature. Before this checkin, we didn’t allow 
Static nat to be enabled on the 1 VM and multiple public Ips. After the 
checkin, you can create multiple static nat rules per same vm/different public 
Ips, as long as each rule is assigned to a different secondary ip address of 
the vm.

Here is the check that you do when see if the public ip is ready for static nat:


Method in RulesManagerImpl: protected void isIpReadyForStaticNat(long vmId, 
IPAddressVO ipAddress, String vmIp, Account caller, long callerUserId)

Before the fix:

IPAddressVO oldIP = _ipAddressDao.findByAssociatedVmId(vmId);

After the fix:

//check wether the vm ip is alreday associated with any public ip address
IPAddressVO oldIP = _ipAddressDao.findByAssociatedVmIdAndVmIp(vmId, vmIp);


Just wanted to confirm if that’s the expected behavior. If it is, we have a lot 
of regression bugs in the ip addresses cleanup when static nat ip is referenced 
just by vmId. For instance one of them is 
https://issues.apache.org/jira/browse/CLOUDSTACK-7218. During the vm expunge 
when we cleanup vm’s resources, we expect only one static nat enabled public ip 
address for vm:

private boolean cleanupVmResources(long vmId) {

// If vm is assigned to static nat, disable static nat for the ip
// address and disassociate ip if elasticIP is enabled
IPAddressVO ip = _ipAddressDao.findByAssociatedVmId(vmId);
try {
 if (ip != null) {
if (_rulesMgr.disableStaticNat(ip.getId(), 
_accountMgr.getAccount(Account.ACCOUNT_ID_SYSTEM), User.UID_SYSTEM, true)) {
s_logger.debug("Disabled 1-1 nat for ip address " + ip + " 
as a part of vm id=" + vmId + " expunge”);



And I suspect that the same kind of bugs will happen in all the places where 
you make a call to _ipAddressDao.findByAssociatedVmId(vmId) returning only one 
entry, where there can be more than one per vm/public ip.

Or if you say that we still shouldn’t allow more than one Static Nat enabled 
Public IP per single VM, then the isIpReadyForStaticNat should be fixed by 
disallowing enabling static nat on the vm that is already associated with the 
public ip address, disregarding the vmIp, and considering the vmId only when 
make a search.


Can you please take a look and elaborate.

Thank you,
-Alena.

Re: Review Request 24238: Fix mvn marvin.sync profile

2014-08-04 Thread Leo Simons 


> On Aug. 4, 2014, 4:35 p.m., Santhosh Edukulla wrote:
> > tools/marvin/setup.py, line 35
> > 
> >
> > Please tying like this to as a dependency on pom.xml, may unnecessarily 
> > lead to tight coupling with mvn logic inside of setup.py. Currently, only 
> > cloudstackAPI is the one which marvin relies upon while building cs through 
> > mvn, otherwise we can remove that dependency as well, its in plan. Any 
> > upload of marvin to external package download system will tie this 
> > dependency on pom.xml.

Yep, this change requires that there is a file named pom.xml which has in it 
 That's why 
MANIFEST.in now has to include that file. It doesn't depend on maven being 
installed or available. It's pretty common practice with distutils to 
externalize the version into a VERSION file or similar, especially on 
multi-module projects. But, maven can't externalize _its_ versions, they MUST 
be in the pom. I guess you can choose:

* have an ugly pom.xml file shipped in your sdist, but maven release plugin 
works for bumping _all_ versions, marvin versions stay synced with management 
server, you don't have multiple places to update a string (DRY), etc
* don't have the pom.xml file in your sdist, and have the same version number 
repeated in 3+ places, leading to bugs like the one that just happened, 
ever-lasting confusing errors when bumping versions, difficulty configuring CI 
servers to inject different versions, and other such fun
* add an ugly non-standard pre processor to the build process which injects 
version numbers into the various build files

This patch represents my opinion on the subject: if you can, don't have maven, 
but if you have maven, respect it's authority over your versioning :-)

I have no idea why you call this a dependency. It's just a VERSION file that 
happens to have some extra XML around it.


- Leo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24238/#review49460
---


On Aug. 4, 2014, 4:08 p.m., Leo Simons wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24238/
> ---
> 
> (Updated Aug. 4, 2014, 4:08 p.m.)
> 
> 
> Review request for cloudstack and Rohit Yadav.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Commit e10f8e887571e28f31dbcf02a0beac163a901fe1 broke
>   mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin
> Because the maven file had hard-coded 0.1.0.
> 
> This fix removes the hard-coding completely, by having the python setup read
> the version from the maven pom.xml, and the maven setup using its version.
> 
> 
> Diffs
> -
> 
>   tools/marvin/MANIFEST.in 3d373818c2096db12b61902a51f2fe39f2e0608e 
>   tools/marvin/pom.xml 3bf70e041c6bab051d7a184ff9c3c81ea31d2054 
>   tools/marvin/setup.py 555d67dfc491cf5ab52d36b417a6b5842ea6ad96 
> 
> Diff: https://reviews.apache.org/r/24238/diff/
> 
> 
> Testing
> ---
> 
> Commands that work now for me include:
> 
> mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin
> python setup.py install
> python setup.py develop
> mvn -P developer -pl :cloud-marvin
> 
> 
> Thanks,
> 
> Leo Simons
> 
>

Re: How to speed up testing using BVT/smoke tests with Simulator

2014-08-04 Thread Ian Duffy 
Rohit,

Those changes cause conflicts when attempting to deploy the devcloud.sql
file as they specify the same primary keys.


On 1 August 2014 15:56, Rohit Yadav  wrote:

> I’ve added config in developer/developer-prefill.sql to have three new
> config params commonly used by devs and to speed up account cleanup (60s
> now).
>
> 137655d4e11cb490391d0f4982c52262bbb7427c master
> a68d8986829c462d655bf59a0cbcc0d4e8b1cc3e 4.4
>
> Regards.
>
> On 01-Aug-2014, at 7:27 am, Santhosh Edukulla <
> santhosh.eduku...@citrix.com> wrote:
>
> > 1. yes, test cases currently run in parallel in ci environment, using
> parallel nose commands.
> >
> > 2. There were few  hard codings for sleep, where we removed at some
> places, still there could be few\many out there.
> >
> > 3. 1 sec sleep and poll check is too heavy i believe, for async. So,
> worst a test case can add time of execution by 5 seconds more, compared to
> succesful operation time.
> >
> > Santhosh
> > 
> > From: Rohit Yadav [rohit.ya...@shapeblue.com]
> > Sent: Thursday, July 31, 2014 7:15 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: How to speed up testing using BVT/smoke tests with Simulator
> >
> > Hi Edison,
> >
> > Thanks for the pointers! I’ll try them out and see if there is way to do
> it on Travis/CloudBees as well and I hope other people will religiously
> start using simulator/bvt (at least the basic ones) for their check-ins.
> >
> > Regards.
> >
> > On 01-Aug-2014, at 12:15 am, Edison Su  wrote:
> >
> >>
> >>
> >>> -Original Message-
> >>> From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
> >>> Sent: Thursday, July 31, 2014 5:12 AM
> >>> To: dev@cloudstack.apache.org
> >>> Subject: How to speed up testing using BVT/smoke tests with Simulator
> >>>
> >>> Hi,
> >>>
> >>> Santosh put together a good wiki page on how to validate local changes
> using
> >>> our Python/marvin based build verification tests (path:
> >>> test/integration/smoke):
> >>>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check
> >>> -ins+for+your+local+changes%2C+using+Simulator
> >>>
> >>> I've a mini PC for this and using CloudStack 4.4.0 to build/test
> CloudStack
> >>> 4.4/master branch on it in a VM. Some of us are also exploring
> free/cheap CI
> >>> services such as Travis, CloudBees etc. which can be used by
> developers to
> >>> test their check-ins. If anyone of you have tried something like this
> please
> >>> share.
> >> Today, I tried to build and test CloudStack on a super powerful machine
> provided by Azure. Imaging, build & test on a 16 Cores, 120G machine, it
> should be awesome, and most importantly, it's FREE. You can get a free MSDN
> subscription fromhttps://
> svn.apache.org/repos/private/committers/donated-licenses/msdn-subscription.html,
> after that, you will get $150 credit monthly in Azure. For build &test
> only, $150 is good enough.
> >>
> >>>
> >>> This is how I build CloudStack for validating with simulator:
> >>>   mvn -Pdeveloper -Dsimulator clean install
> >>>   mvn -Pdeveloper -pl developer -Ddeploydb
> >>>   mvn -Pdeveloper -pl developer -Ddeploydb-simulator
> >>>   mvn -pl client jetty:run -Dsimulator
> >>>
> >>> And finally run smoke tests (BVT):
> >>> nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg --with-
> >>> xunit --xunit-file=/tmp/bvt_selfservice_cases.xml -a
> >>> tags=advanced,required_hardware=false -w test/integration/smoke --
> >>> hypervisor=simulator
> >>>
> >>> It currently took 50 mins on my setup. How can we speed it up, say by
> >>> reducing global variable timeout settings etc? Should we reduce
> timeouts etc.
> >>> in deploydb-simulator specific sql files?
> >>
> >> There several places we can improve the marvin test:
> >> 1. queryAsyncJob waits 5 second for each call, can change to 1s.
> >> 2. There are hardcoded sleep in test code, such base.py, search
> time.sleep
> >> 3. global configuration: account.cleanup.interval sets to 600s, so the
> test suite will stop for 10 minutes after running for a while.
> >> 3. most importantly, if we can run the test cases in parallel, then
> speedup should be great. Does anybody try to run it in parallel before?
> >>
> >>>
> >>> Regards,
> >>> Rohit Yadav
> >>> Software Architect, ShapeBlue
> >>> M. +41 779015219 | rohit.ya...@shapeblue.com
> >>> Blog: bhaisaab.org | Twitter: @_bhaisaab
> >>>
> >>>
> >>>
> >>>
> >>> Find out more about ShapeBlue and our range of CloudStack related
> services
> >>>
> >>> IaaS Cloud Design & Build >>> build//>
> >>> CSForge - rapid IaaS deployment
> >>> framework
> >>> CloudStack Consulting
> >>> CloudStack Infrastructure Support >>> infrastructure-support/>
> >>> CloudStack Bootcamp Training Courses >>> training/>
> >>>
> >>> This email and any attachments to it may b

[MEETUP] CloudStack SF Bay Area User Group - August 14th, 2014

2014-08-04 Thread Karen Vuong 
Hi all,



Join us! The next CloudStack meetup in the Silicon Valley has just been
scheduled for Thursday, August 14th. The main topic will be presented by
Nitin Mehta on replacing realhostip.com with your custom domain. John
Kinsella will discuss CloudStack monitoring. There will be plenty of time
for networking, pizza & beer as well!



Date: Thursday, August 14th

Time: 6:00pm – 9:00pm

Address: SAP Labs - Building 3

3420 Hillview Ave., Palo Alto , CA US

Event link:
http://www.meetup.com/CloudStack-SF-Bay-Area-Users-Group/events/198952162/



Click-to-tweet:  http://ctt.ec/7ygsx - Learn how to replace realhostip.com
w/ your custom domain @ the next #CloudStack Bay Area User meetup 8/14!
http://clds.co/1kiC743



Thanks,



Karen

Re: [VOTE] git workflow

2014-08-04 Thread Tanner Danzey 
+1


On Thu, Jul 31, 2014 at 5:28 AM, Rajani Karuturi  wrote:

> Hi All,
>
> We had long discussions on the git flow.
> I tried to capture the summary of it @
> http://markmail.org/message/j5z7dxjcqxfkfhpj
> This is updated on wiki @
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Git#Git-ProposedGitflowbasedCheck-inProcess
> and is up for a vote:
>
> Can you share your opinion on the proposal?
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
>
> Thanks,
> ~Rajani
>
>
>
>


-- 
*Tanner Danzey*
Systems Engineer
Northstar Technology Group
arkan...@gmail.com / tanner.dan...@northstar-tg.com
(701) 237-9096 x7122

Re: How to speed up testing using BVT/smoke tests with Simulator

2014-08-04 Thread Rohit Yadav 
Hi Ian,

Thanks for catching that, I’ve fixed it on master and 4.4 now using insert on 
duplicate update syntax.

b157104563d2d30ede7bfabe2df8cf42d3dadb1d master
9315321dacc877e67279b3b59b6b2e08d125ddbe 4.4

On 04-Aug-2014, at 9:31 pm, Ian Duffy  wrote:

> Rohit,
>
> Those changes cause conflicts when attempting to deploy the devcloud.sql
> file as they specify the same primary keys.
>
>
> On 1 August 2014 15:56, Rohit Yadav  wrote:
>
>> I’ve added config in developer/developer-prefill.sql to have three new
>> config params commonly used by devs and to speed up account cleanup (60s
>> now).
>>
>> 137655d4e11cb490391d0f4982c52262bbb7427c master
>> a68d8986829c462d655bf59a0cbcc0d4e8b1cc3e 4.4
>>
>> Regards.
>>
>> On 01-Aug-2014, at 7:27 am, Santhosh Edukulla <
>> santhosh.eduku...@citrix.com> wrote:
>>
>>> 1. yes, test cases currently run in parallel in ci environment, using
>> parallel nose commands.
>>>
>>> 2. There were few  hard codings for sleep, where we removed at some
>> places, still there could be few\many out there.
>>>
>>> 3. 1 sec sleep and poll check is too heavy i believe, for async. So,
>> worst a test case can add time of execution by 5 seconds more, compared to
>> succesful operation time.
>>>
>>> Santhosh
>>> 
>>> From: Rohit Yadav [rohit.ya...@shapeblue.com]
>>> Sent: Thursday, July 31, 2014 7:15 PM
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: How to speed up testing using BVT/smoke tests with Simulator
>>>
>>> Hi Edison,
>>>
>>> Thanks for the pointers! I’ll try them out and see if there is way to do
>> it on Travis/CloudBees as well and I hope other people will religiously
>> start using simulator/bvt (at least the basic ones) for their check-ins.
>>>
>>> Regards.
>>>
>>> On 01-Aug-2014, at 12:15 am, Edison Su  wrote:
>>>


> -Original Message-
> From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
> Sent: Thursday, July 31, 2014 5:12 AM
> To: dev@cloudstack.apache.org
> Subject: How to speed up testing using BVT/smoke tests with Simulator
>
> Hi,
>
> Santosh put together a good wiki page on how to validate local changes
>> using
> our Python/marvin based build verification tests (path:
> test/integration/smoke):
>
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check
> -ins+for+your+local+changes%2C+using+Simulator
>
> I've a mini PC for this and using CloudStack 4.4.0 to build/test
>> CloudStack
> 4.4/master branch on it in a VM. Some of us are also exploring
>> free/cheap CI
> services such as Travis, CloudBees etc. which can be used by
>> developers to
> test their check-ins. If anyone of you have tried something like this
>> please
> share.
 Today, I tried to build and test CloudStack on a super powerful machine
>> provided by Azure. Imaging, build & test on a 16 Cores, 120G machine, it
>> should be awesome, and most importantly, it's FREE. You can get a free MSDN
>> subscription fromhttps://
>> svn.apache.org/repos/private/committers/donated-licenses/msdn-subscription.html,
>> after that, you will get $150 credit monthly in Azure. For build &test
>> only, $150 is good enough.

>
> This is how I build CloudStack for validating with simulator:
>  mvn -Pdeveloper -Dsimulator clean install
>  mvn -Pdeveloper -pl developer -Ddeploydb
>  mvn -Pdeveloper -pl developer -Ddeploydb-simulator
>  mvn -pl client jetty:run -Dsimulator
>
> And finally run smoke tests (BVT):
> nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg --with-
> xunit --xunit-file=/tmp/bvt_selfservice_cases.xml -a
> tags=advanced,required_hardware=false -w test/integration/smoke --
> hypervisor=simulator
>
> It currently took 50 mins on my setup. How can we speed it up, say by
> reducing global variable timeout settings etc? Should we reduce
>> timeouts etc.
> in deploydb-simulator specific sql files?

 There several places we can improve the marvin test:
 1. queryAsyncJob waits 5 second for each call, can change to 1s.
 2. There are hardcoded sleep in test code, such base.py, search
>> time.sleep
 3. global configuration: account.cleanup.interval sets to 600s, so the
>> test suite will stop for 10 minutes after running for a while.
 3. most importantly, if we can run the test cases in parallel, then
>> speedup should be great. Does anybody try to run it in parallel before?

>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
> M. +41 779015219 | rohit.ya...@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related
>> services
>
> IaaS Cloud Design & Build build//>
> CSForge - rapid IaaS deployment
> framework
> CloudStack Consulting

Re: Review Request 24238: Fix mvn marvin.sync profile

2014-08-04 Thread Rohit Yadav 


> On Aug. 4, 2014, 4:35 p.m., Santhosh Edukulla wrote:
> > tools/marvin/setup.py, line 35
> > 
> >
> > Please tying like this to as a dependency on pom.xml, may unnecessarily 
> > lead to tight coupling with mvn logic inside of setup.py. Currently, only 
> > cloudstackAPI is the one which marvin relies upon while building cs through 
> > mvn, otherwise we can remove that dependency as well, its in plan. Any 
> > upload of marvin to external package download system will tie this 
> > dependency on pom.xml.
> 
> Leo Simons wrote:
> Yep, this change requires that there is a file named pom.xml which has in 
> it  That's why 
> MANIFEST.in now has to include that file. It doesn't depend on maven being 
> installed or available. It's pretty common practice with distutils to 
> externalize the version into a VERSION file or similar, especially on 
> multi-module projects. But, maven can't externalize _its_ versions, they MUST 
> be in the pom. I guess you can choose:
> 
> * have an ugly pom.xml file shipped in your sdist, but maven release 
> plugin works for bumping _all_ versions, marvin versions stay synced with 
> management server, you don't have multiple places to update a string (DRY), 
> etc
> * don't have the pom.xml file in your sdist, and have the same version 
> number repeated in 3+ places, leading to bugs like the one that just 
> happened, ever-lasting confusing errors when bumping versions, difficulty 
> configuring CI servers to inject different versions, and other such fun
> * add an ugly non-standard pre processor to the build process which 
> injects version numbers into the various build files
> 
> This patch represents my opinion on the subject: if you can, don't have 
> maven, but if you have maven, respect it's authority over your versioning :-)
> 
> I have no idea why you call this a dependency. It's just a VERSION file 
> that happens to have some extra XML around it.

Leo thanks for the patch, how about we add a statement in pom.xml that creates 
a version.py (or pick any other suitable name) file that only have version 
information and setup.py imports it. We can commit a static version.py file 
just in mvn fails this way Marvin dist won't have to depend on pom.xml file and 
we can still dynamically change version string?

I think this will adress Santhosh's comment. Can you re-submit the patch with 
such a logic or any better logic?


- Rohit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24238/#review49460
---


On Aug. 4, 2014, 4:08 p.m., Leo Simons wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24238/
> ---
> 
> (Updated Aug. 4, 2014, 4:08 p.m.)
> 
> 
> Review request for cloudstack and Rohit Yadav.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Commit e10f8e887571e28f31dbcf02a0beac163a901fe1 broke
>   mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin
> Because the maven file had hard-coded 0.1.0.
> 
> This fix removes the hard-coding completely, by having the python setup read
> the version from the maven pom.xml, and the maven setup using its version.
> 
> 
> Diffs
> -
> 
>   tools/marvin/MANIFEST.in 3d373818c2096db12b61902a51f2fe39f2e0608e 
>   tools/marvin/pom.xml 3bf70e041c6bab051d7a184ff9c3c81ea31d2054 
>   tools/marvin/setup.py 555d67dfc491cf5ab52d36b417a6b5842ea6ad96 
> 
> Diff: https://reviews.apache.org/r/24238/diff/
> 
> 
> Testing
> ---
> 
> Commands that work now for me include:
> 
> mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin
> python setup.py install
> python setup.py develop
> mvn -P developer -pl :cloud-marvin
> 
> 
> Thanks,
> 
> Leo Simons
> 
>

Re: Review Request 23805: Added "state" parameter to the "listPublicIpAddresses" API call

2014-08-04 Thread Rohit Yadav 


> On July 29, 2014, 10:20 a.m., Rohit Yadav wrote:
> > Looks fine, we still need to test it before we land it on master. I 
> > unfortunately don't have my hardware (and some parts) setup will try with 
> > DevCloud or hope someone else would review, test and ship it :)
> 
> Ilia Shakitko wrote:
> Maybe we can add a reviewer who is currently working on master branch?
> 
> Rohit Yadav wrote:
> Hi, I was going to apply it today but your patch is not a git-formatted 
> patch. Please upload a new git formatted patch, ref: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Git#Git-Patches

ping?


- Rohit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23805/#review48976
---


On July 28, 2014, 10:12 a.m., Ilia Shakitko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23805/
> ---
> 
> (Updated July 28, 2014, 10:12 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Alex Huang, Harikrishna 
> Patnala, Kishan Kavala, Prachi Damle, Rohit Yadav, Ilia Shakitko, Wei Zhou, 
> and Wido den Hollander.
> 
> 
> Bugs: CLOUDSTACK-7159
> https://issues.apache.org/jira/browse/CLOUDSTACK-7159
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This improvement is introducing a new parameter for the 
> "listPublicIpAddresses" API call - "state".
> 
> Few times we've faced an impedemence of having a list of "Free" 
> publicIpAddresses. You have to go thru all the IPs with (allocatedonly = 
> false) and filter out the "Free" once. It's not a big deal, but it's an extra 
> time and traffic between CloudStack and an API consumer.
> 
> I also moved few methods out of the 'API Implementation' and put them above 
> as a minor refactoring.
> Method "getForLoadBalancing" has been removed because it's not being used in 
> code anywhere else.
> 
> This patch is done for "master" branch.
> 
> 
> Diffs
> -
> 
>   
> api/src/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
>  07ccfe9 
>   server/src/com/cloud/server/ManagementServerImpl.java 99b12732 
> 
> Diff: https://reviews.apache.org/r/23805/diff/
> 
> 
> Testing
> ---
> 
> 1) Build successfull
> 2) No tests broken
> 3) Tested few different calls with cloudmonkey:
> 
> list publicipaddresses forvirtualnetwork=false listall=true page=1 pagesize=0
> count = 10
> 
> list publicipaddresses forvirtualnetwork=false listall=true 
> allocatedonly=false page=1 pagesize=0
> count = 100
> 
> list publicipaddresses forvirtualnetwork=false listall=true state=free page=1 
> pagesize=0
> count = 90
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>

4.4.1 related checkins

2014-08-04 Thread Amogh Vasekar 
Hi,

I am wondering where we are to check-in commits we think should go in
4.4.1.
4.4 / 4.4-forward / create 4.4.1 / create a branch and request a merge /
some other way?

Thanks,
Amogh

Build failed in Jenkins: simulator-singlerun #40

2014-08-04 Thread jenkins 
See 

Changes:

[Rohit Yadav] devcloud: user insert on duplicate update in devcloud.sql

[anthony.xu] got VBD statistics from RRD

--
[...truncated 7253 lines...]
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 17.754s
[INFO] Finished at: Mon Aug 04 17:17:24 EDT 2014
[INFO] Final Memory: 40M/212M
[INFO] 
[simulator-singlerun] $ /bin/bash -x /tmp/hudson3768932731793080831.sh
+ jps -l
+ grep -q Launcher
+ rm -f xunit.xml
+ rm -rf /tmp/MarvinLogs
+ echo Check for initialization of the management server
Check for initialization of the management server
+ COUNTER=0
+ SERVER_PID=21218
+ mvn -P systemvm,simulator -pl :cloud-client-ui jetty:run
+ '[' 0 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=1
+ '[' 1 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=2
+ '[' 2 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=3
+ '[' 3 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=4
+ '[' 4 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=5
+ '[' 5 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=6
+ '[' 6 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=7
+ '[' 7 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=8
+ '[' 8 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=9
+ '[' 9 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=10
+ '[' 10 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=11
+ '[' 11 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=12
+ '[' 12 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=13
+ '[' 13 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=14
+ '[' 14 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=15
+ '[' 15 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=16
+ '[' 16 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=17
+ '[' 17 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=18
+ '[' 18 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=19
+ '[' 19 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=20
+ '[' 20 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=21
+ '[' 21 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=22
+ '[' 22 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=23
+ '[' 23 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=24
+ '[' 24 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=25
+ '[' 25 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=26
+ '[' 26 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=27
+ '[' 27 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=28
+ '[' 28 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=29
+ '[' 29 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=30
+ '[' 30 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=31
+ '[' 31 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=32
+ '[' 32 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-ou

Build failed in Jenkins: simulator-singlerun #41

2014-08-04 Thread jenkins 
See 

Changes:

[Alena Prokharchyk] CLOUDSTACK-7194: deployVm Api, "hypervisor" parameter:

[amogh.vasekar] CLOUDSTACK-7211: Missing LXC mappings, reuse KVM mappings

[frank.zhang] CLOUDSTACK-6278

[frank.zhang] CLOUDSTACK-6278

[frank.zhang] CLOUDSTACK-6278

--
[...truncated 7226 lines...]
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Developer Mode 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties 
(default) @ cloud-developer ---
[WARNING] Ignoring missing properties file: 

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] 
[INFO] >>> exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer >>>
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] <<< exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer <<<
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer ---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
> WARNING: Provided file does not exist: 

> Initializing database=simulator with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `simulator`
> Running query: create database `simulator`
> Running query: GRANT ALL ON simulator.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON simulator.* to 'cloud'@`%` identified 
by 'cloud'
> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 17.403s
[INFO] Finished at: Mon Aug 04 18:23:41 EDT 2014
[INFO] Final Memory: 41M/212M
[INFO] 
[simulator-singlerun] $ /bin/bash -x /tmp/hudson2221178264909289034.sh
+ grep -q Launcher
+ jps -l
+ rm -f xunit.xml
+ rm -rf /tmp/MarvinLogs
+ echo Check for initialization of the management server
Check for initialization of the management server
+ COUNTER=0
+ SERVER_PID=27885
+ '[' 0 -lt 44 ']'
+ mvn -P systemvm,simulator -pl :cloud-client-ui jetty:run
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=1
+ '[' 1 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=2
+ '[' 2 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=3
+ '[' 3 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=4
+ '[' 4 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=5
+ '[' 5 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=6
+ '[' 6 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=7
+ '[' 7 -lt 44 ']'
+ grep

Build failed in Jenkins: simulator-singlerun #42

2014-08-04 Thread jenkins 
See 

--
[...truncated 7205 lines...]
[INFO] 
[INFO] Total time: 1:55.332s
[INFO] Finished at: Mon Aug 04 18:56:44 EDT 2014
[INFO] Final Memory: 40M/175M
[INFO] 
[WARNING] The requested profile "simulator" could not be activated because it 
does not exist.
[simulator-singlerun] $ mvn -P developer -pl developer -Ddeploydb-simulator
[INFO] Scanning for projects...
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Developer Mode 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties 
(default) @ cloud-developer ---
[WARNING] Ignoring missing properties file: 

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] 
[INFO] >>> exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer >>>
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] <<< exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer <<<
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer ---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
> WARNING: Provided file does not exist: 

> Initializing database=simulator with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `simulator`
> Running query: create database `simulator`
> Running query: GRANT ALL ON simulator.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON simulator.* to 'cloud'@`%` identified 
by 'cloud'
> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 18.053s
[INFO] Finished at: Mon Aug 04 18:57:06 EDT 2014
[INFO] Final Memory: 40M/182M
[INFO] 
[simulator-singlerun] $ /bin/bash -x /tmp/hudson3875596728589579393.sh
+ jps -l
+ grep -q Launcher
+ rm -f xunit.xml
+ rm -rf /tmp/MarvinLogs
+ echo Check for initialization of the management server
Check for initialization of the management server
+ COUNTER=0
+ SERVER_PID=1297
+ '[' 0 -lt 44 ']'
+ mvn -P systemvm,simulator -pl :cloud-client-ui jetty:run
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=1
+ '[' 1 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=2
+ '[' 2 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=3
+ '[' 3 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=4
+ '[' 4 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=5
+ '[' 5 -lt 44 ']'
+ grep -q 'Manageme

Build failed in Jenkins: simulator-singlerun #43

2014-08-04 Thread jenkins 
See 

Changes:

[min.chen] CLOUDSTACK-7239:Wrong message thrown on Primary Storage addition 
failure

--
[...truncated 7196 lines...]
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:51.395s
[INFO] Finished at: Mon Aug 04 19:36:30 EDT 2014
[INFO] Final Memory: 41M/181M
[INFO] 
[WARNING] The requested profile "simulator" could not be activated because it 
does not exist.
[simulator-singlerun] $ mvn -P developer -pl developer -Ddeploydb-simulator
[INFO] Scanning for projects...
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Developer Mode 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties 
(default) @ cloud-developer ---
[WARNING] Ignoring missing properties file: 

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] 
[INFO] >>> exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer >>>
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] <<< exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer <<<
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer ---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
> WARNING: Provided file does not exist: 

> Initializing database=simulator with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `simulator`
> Running query: create database `simulator`
> Running query: GRANT ALL ON simulator.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON simulator.* to 'cloud'@`%` identified 
by 'cloud'
> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 16.769s
[INFO] Finished at: Mon Aug 04 19:36:50 EDT 2014
[INFO] Final Memory: 41M/180M
[INFO] 
[simulator-singlerun] $ /bin/bash -x /tmp/hudson3506206818976267219.sh
+ jps -l
+ grep -q Launcher
+ rm -f xunit.xml
+ rm -rf /tmp/MarvinLogs
+ echo Check for initialization of the management server
Check for initialization of the management server
+ COUNTER=0
+ SERVER_PID=7185
+ '[' 0 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ mvn -P systemvm,simulator -pl :cloud-cli

Build failed in Jenkins: simulator-singlerun #44

2014-08-04 Thread jenkins 
See 

Changes:

[nitin.mehta] CLOUDSTACK-7018: Restore VM - missing destroyed usage event for 
the destroyed root volume. Also removed the resource count logic since we 
destroy the old root volume and create a new one.

--
[...truncated 7213 lines...]
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Developer Mode 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties 
(default) @ cloud-developer ---
[WARNING] Ignoring missing properties file: 

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] 
[INFO] >>> exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer >>>
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] <<< exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer <<<
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer ---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
> WARNING: Provided file does not exist: 

> Initializing database=simulator with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `simulator`
> Running query: create database `simulator`
> Running query: GRANT ALL ON simulator.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON simulator.* to 'cloud'@`%` identified 
by 'cloud'
> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 32.767s
[INFO] Finished at: Mon Aug 04 20:10:56 EDT 2014
[INFO] Final Memory: 40M/156M
[INFO] 
[simulator-singlerun] $ /bin/bash -x /tmp/hudson2270122532487864279.sh
+ jps -l
+ grep -q Launcher
+ rm -f xunit.xml
+ rm -rf /tmp/MarvinLogs
+ echo Check for initialization of the management server
Check for initialization of the management server
+ COUNTER=0
+ SERVER_PID=13043
+ mvn -P systemvm,simulator -pl :cloud-client-ui jetty:run
+ '[' 0 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=1
+ '[' 1 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=2
+ '[' 2 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=3
+ '[' 3 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=4
+ '[' 4 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=5
+ '[' 5 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=6
+ '[' 6 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=7
+ '[' 7 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up

Build failed in Jenkins: simulator-singlerun #45

2014-08-04 Thread jenkins 
See 

--
[...truncated 7214 lines...]
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties 
(default) @ cloud-developer ---
[WARNING] Ignoring missing properties file: 

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] 
[INFO] >>> exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer >>>
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] <<< exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer <<<
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer ---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
> WARNING: Provided file does not exist: 

> Initializing database=simulator with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `simulator`
> Running query: create database `simulator`
> Running query: GRANT ALL ON simulator.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON simulator.* to 'cloud'@`%` identified 
by 'cloud'
> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 20.029s
[INFO] Finished at: Mon Aug 04 20:44:08 EDT 2014
[INFO] Final Memory: 41M/187M
[INFO] 
[simulator-singlerun] $ /bin/bash -x /tmp/hudson3552752956374988133.sh
+ grep -q Launcher
+ jps -l
+ rm -f xunit.xml
+ rm -rf /tmp/MarvinLogs
+ echo Check for initialization of the management server
Check for initialization of the management server
+ COUNTER=0
+ SERVER_PID=18879
+ '[' 0 -lt 44 ']'
+ mvn -P systemvm,simulator -pl :cloud-client-ui jetty:run
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=1
+ '[' 1 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=2
+ '[' 2 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=3
+ '[' 3 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=4
+ '[' 4 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=5
+ '[' 5 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=6
+ '[' 6 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=7
+ '[' 7 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=8
+ '[' 8 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=9
+ '[' 9 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=10
+ '[' 10 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=11
+ '[' 11 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=12
+ '[' 12 -lt 44 ']'
+ grep -q 'Management se

Re: implementing git workflow

2014-08-04 Thread Rajani Karuturi 
Hi Leo,
Thanks for the detailed wiki. 

shouldn’t we use git flow support for LTS releases? 
http://stackoverflow.com/a/16866118/201514 


~Rajani



On 04-Aug-2014, at 7:29 pm, Leo Simons  wrote:

> Hey folks,
> 
> Since Daan volunteered me to do some docs, I’ve updated Rohit’s page at
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Git
> 
> with additional details.
> 
> I went back through all the e-mails on the subject to find 
> questions/concerns, addressed the ones I think have consensus and highlighted 
> a few places where additional decision/discussion may be needed.
> 
> Remaining topics I’m not sure about:
> * when to cut over
> * how to cut over
> * policy for who merges to release branches
> * policy for adding features in micro releases
> * what to name hot fixes
> 
> Comments on each below.
> 
> When to cut over
> 
> I think docs are quite sufficient now. I’d personally suggest to just do it.
> 
> Since the vote is done I think any committer should feel free to pick up the 
> ball :)
> 
> How to cut over
> ---
> * Someone has to make the branches and announce the flip on the mailing list.
> * Everyone has to flip / git flow init / etc.
> * Someone has to update jenkins.buildacloud.org to build the new develop 
> branch.
> * ???
> * Profit.
> 
> Again, I’d personally suggest to just do it.
> 
> Policy for who merges to release branches
> -
> There was some unresolved discussion about
> 1. when it is ok to directly commit to the release branch
> 2. when it is ok for other people than the release manager to merge to the 
> release branch
> 3. when/how to do a freeze of a release branch
> 
> Git flow says:
> 1. basically never
> 2. what’s a release manager?
> 3. never, cut release branch == feature freeze, tag release == freeze
> 
> Personally I would suggest
> 1. never unless you are doing release management (i.e. version bump) commits
> 2. always as long as you are confident and prepared to suffer the wrath of 
> doing it wrong, ask the release manager to do it if you are not confident
> 3. at the jurisdiction of the release manager
> 
> Policy for adding features onto release branches
> 
> It has been cloudstack practice to include new features (or enable features) 
> in micro releases.
> 
> I did document how to do this within the git-flow model, but I strongly 
> suggest to simply stop doing it.
> 
> I suggest the policy is that this can be done as an exception to the rule 
> after discussion on the mailing list, using lazy consensus, with the release 
> manager doing the merge to the release branch.
> 
> what to name hotfixes
> -
> hotfix/
> 
> the - should be descriptive and is optional.
> 
> hotfix/4.4-
> 
> for fixes to 4.4.x.
> 
> 
> 
> cheers,
> 
> 
> 
> Leo
>

Re: Review Request 24152: CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network

2014-08-04 Thread Koushik Das 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24152/
---

(Updated Aug. 5, 2014, 5:16 a.m.)


Review request for cloudstack, Alena Prokharchyk and Sheng Yang.


Changes
---

Updated the testing done field


Bugs: CLOUDSTACK-7182
https://issues.apache.org/jira/browse/CLOUDSTACK-7182


Repository: cloudstack-git


Description
---

- Check to see if network is implemented changed from 'state == 
Implementing||Implemented' to 'state == Implemented'. The earlier check was a 
hack to prevent the issue described next.
- At the time of implementing network (using implementNetwork() method), if the 
VR needs to be deployed then it follows the same path of regular VM deployment. 
This leads to a nested call to implementNetwork() while preparing VR nics. This 
flow creates issues in dealing with network state transitions. The original 
call puts network in "Implementing" state and then the nested call again tries 
to put it into same state resulting in issues. In order to avoid it, 
implementNetwork() call for VR is replaced with below code.


Diffs
-

  
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 cdca839 

Diff: https://reviews.apache.org/r/24152/diff/


Testing (updated)
---

1. Ran the network related tests under /test/integration/smoke folder using 
Simulator. Also the other smoke tests didn’t cause any new failures.

2. Also ran the following VPC test using simulator:
a. created vpc, VR gets started as part of this
b. created network in the vpc
c. deployed vm in network created in step#2

3. Manually ran the following tests using simulator (for both regular VR and 
VPC VR):
a. VR stop/start via API when the network is in Implemented state. Network 
implement shouldn’t be triggered in this case.
Deployed VM, network gets implemented, stopped/started VR. Repeated this for 
VPC as well.
b. VR start via API when network is Allocated state. It should trigger network 
implement process. This test case is a good one to test the chicken-egg problem 
– VR triggers network implement, and network implement in turn triggers the 
provider implementation – which is the virtual router itself.
Deployed VM, network gets implemented, destroyed VM, after sometime VR gets 
stopped and network goes to allocated state. At this point started the VR. Also 
repeated same for VPC.

4. Ran #3 using XS setup as well


Thanks,

Koushik Das

Build failed in Jenkins: simulator-singlerun #46

2014-08-04 Thread jenkins 
See 

Changes:

[girish] Fixing vpc distributed test cases

[Devdeep Singh] CLOUDSTACK-7244. On an upgraded setup, 'Hyperv' hypervisor type 
option isn't available

--
[...truncated 7222 lines...]
[INFO] 
[INFO] Total time: 2:07.327s
[INFO] Finished at: Tue Aug 05 02:07:31 EDT 2014
[INFO] Final Memory: 41M/172M
[INFO] 
[WARNING] The requested profile "simulator" could not be activated because it 
does not exist.
[simulator-singlerun] $ mvn -P developer -pl developer -Ddeploydb-simulator
[INFO] Scanning for projects...
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Developer Mode 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties 
(default) @ cloud-developer ---
[WARNING] Ignoring missing properties file: 

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] 
[INFO] >>> exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer >>>
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] <<< exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer <<<
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer ---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
> WARNING: Provided file does not exist: 

> Initializing database=simulator with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `simulator`
> Running query: create database `simulator`
> Running query: GRANT ALL ON simulator.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON simulator.* to 'cloud'@`%` identified 
by 'cloud'
> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 16.934s
[INFO] Finished at: Tue Aug 05 02:07:52 EDT 2014
[INFO] Final Memory: 41M/189M
[INFO] 
[simulator-singlerun] $ /bin/bash -x /tmp/hudson1262622570577078730.sh
+ jps -l
+ grep -q Launcher
+ rm -f xunit.xml
+ rm -rf /tmp/MarvinLogs
+ echo Check for initialization of the management server
Check for initialization of the management server
+ COUNTER=0
+ SERVER_PID=24996
+ '[' 0 -lt 44 ']'
+ mvn -P systemvm,simulator -pl :cloud-client-ui jetty:run
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=1
+ '[' 1 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=2
+ '[' 2 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=3
+ '[' 3 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+

Review Request 24298: CLOUDSTACK-6873: Moved test cases that run only on simulator and those should be run serially to misc folder and also tagged them with required_hardware='simulator only'

2014-08-04 Thread Gaurav Aradhye 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24298/
---

Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-6873
https://issues.apache.org/jira/browse/CLOUDSTACK-6873


Repository: cloudstack-git


Description
---

The tests in test suites test_deploy_vm.py and test_vm_ha.py need to be run 
serially, hence moved them to misc folder.
Also tagged the tests as "required_hardware='simulator only'" which require to 
be run only on simulator.

Moved the normal tests (for which above criteria don't apply) from 
test_deploy_vm.py to test_vm_life_cycle.py in smoke folder.


Diffs
-

  test/integration/smoke/misc/__init__.py PRE-CREATION 
  test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION 
  test/integration/smoke/misc/test_vm_ha.py PRE-CREATION 
  test/integration/smoke/test_deploy_vm.py 29cdb96 
  test/integration/smoke/test_vm_ha.py c7d1648 
  test/integration/smoke/test_vm_life_cycle.py 1386830 

Diff: https://reviews.apache.org/r/24298/diff/


Testing
---

Yes, tested test_vm_life_cycle.py with python command.


Thanks,

Gaurav Aradhye

Re: Review Request 23837: CLOUDSTACK-7087: Downgrade openswan to previous version for VPN services to fix OSX client

2014-08-04 Thread Harikrishna Patnala 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23837/
---

(Updated Aug. 5, 2014, 6:50 a.m.)


Review request for cloudstack and Kishan Kavala.


Bugs: CLOUDSTACK-7087
https://issues.apache.org/jira/browse/CLOUDSTACK-7087


Repository: cloudstack-git


Description
---

CLOUDSTACK-7087: Downgrade openswan to previous version for VPN services to fix 
OSX client
Downgrading openswan version to 1:2.6.37-3


Diffs
-

  tools/appliance/definitions/systemvm64template/postinstall.sh 5ce0163 
  tools/appliance/definitions/systemvmtemplate/postinstall.sh 822cd5f 

Diff: https://reviews.apache.org/r/23837/diff/


Testing
---


Thanks,

Harikrishna Patnala

Re: Review Request 23837: CLOUDSTACK-7087: Downgrade openswan to previous version for VPN services to fix OSX client

2014-08-04 Thread Harikrishna Patnala 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23837/
---

(Updated Aug. 5, 2014, 6:55 a.m.)


Review request for cloudstack and Kishan Kavala.


Bugs: CLOUDSTACK-7087
https://issues.apache.org/jira/browse/CLOUDSTACK-7087


Repository: cloudstack-git


Description
---

CLOUDSTACK-7087: Downgrade openswan to previous version for VPN services to fix 
OSX client
Downgrading openswan version to 1:2.6.37-3


Diffs (updated)
-

  tools/appliance/definitions/systemvm64template/postinstall.sh 8763a9f 
  tools/appliance/definitions/systemvmtemplate/postinstall.sh 587d44d 

Diff: https://reviews.apache.org/r/23837/diff/


Testing
---


Thanks,

Harikrishna Patnala

Build failed in Jenkins: simulator-singlerun #47

2014-08-04 Thread jenkins 
See 

--
[...truncated 7203 lines...]
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:55.013s
[INFO] Finished at: Tue Aug 05 02:40:59 EDT 2014
[INFO] Final Memory: 40M/184M
[INFO] 
[WARNING] The requested profile "simulator" could not be activated because it 
does not exist.
[simulator-singlerun] $ mvn -P developer -pl developer -Ddeploydb-simulator
[INFO] Scanning for projects...
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Developer Mode 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties 
(default) @ cloud-developer ---
[WARNING] Ignoring missing properties file: 

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] 
[INFO] >>> exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer >>>
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-developer ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] <<< exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer <<<
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema-simulator) @ 
cloud-developer ---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
> WARNING: Provided file does not exist: 

> Initializing database=simulator with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `simulator`
> Running query: create database `simulator`
> Running query: GRANT ALL ON simulator.* to 'cloud'@`localhost` 
identified by 'cloud'
> Running query: GRANT ALL ON simulator.* to 'cloud'@`%` identified 
by 'cloud'
> Processing SQL file at 

> Processing SQL file at 

> Processing SQL file at 

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-developer ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-developer ---
[INFO] Installing 
 
to 
/var/lib/jenkins/.m2/repository/org/apache/cloudstack/cloud-developer/4.5.0-SNAPSHOT/cloud-developer-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 36.258s
[INFO] Finished at: Tue Aug 05 02:41:39 EDT 2014
[INFO] Final Memory: 39M/169M
[INFO] 
[simulator-singlerun] $ /bin/bash -x /tmp/hudson1644497296506266206.sh
+ jps -l
+ grep -q Launcher
+ rm -f xunit.xml
+ rm -rf /tmp/MarvinLogs
+ echo Check for initialization of the management server
Check for initialization of the management server
+ COUNTER=0
+ SERVER_PID=30842
+ mvn -P systemvm,simulator -pl :cloud-client-ui jetty:run
+ '[' 0 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1 is up' jetty-output.out
+ sleep 5
+ COUNTER=1
+ '[' 1 -lt 44 ']'
+ grep -q 'Management server node 127.0.0.1