Re: CloudStack-3831

[sebgoa]

On Jun 13, 2014, at 10:13 PM, Matt Spurlin  wrote:

> I have created a patch for CloudStack-3831, but unfortunately I am
> having an issue getting it submitted to the review board. Upon
> submission I get the following error:
> 
> Proxy Error
> 
> The proxy server received an invalid response from an upstream server.
> The proxy server could not handle the request POST /r/new/.
> 
> 
> Is there another way I can submit this to the review board?

Can you try again with RB ?
How large is the patch.

If that still fails, assuming you have your own github fork, let us know where 
that is and I can try to grab the commit from there.

Re: Unable to start primary and secondary storage instances

[sebgoa]

On Jun 13, 2014, at 8:52 PM, "Elapavuluri, Jaya"  
wrote:

> Hello,
> 
> I am trying to run the cloudstack (4.4), where the following are warnings 
> shown,
> 
> Unable to acquire lock on storage vm
> WARN  [o.a.c.s.SecondaryStorageManagerImpl] (secstorage-1:ctx-23287615) 
> Exception while trying to start secondary storage vm
> java.lang.RuntimeException: Job failed due to exception Resource [Host:1] is 
> unreachable: Host 1: Unable to start instance due to Unable to acquire lock 
> on VMTemplateStoragePool: 66
>   at 
> com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:114)
>   at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:503)
>   at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
>   at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
>   at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
>   at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
>   at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
>   at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:460)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>   at java.lang.Thread.run(Thread.java:745)
> INFO  [o.a.c.s.SecondaryStorageManagerImpl] (secstorage-1:ctx-23287615) 
> Unable to start secondary storage vm for standby capacity, secStorageVm vm Id 
> : 57, will recycle it and start a new one
> INFO  [o.a.c.s.PremiumSecondaryStorageManagerImpl] 
> (secstorage-1:ctx-23287615) Primary secondary storage is not even started, 
> wait until next turn
> INFO  [o.a.c.f.j.i.AsyncJobMonitor] (Work-Job-Executor-25:ctx-8555714b 
> job-276/job-301) Remove job-301
> 
> 
> Could some one help me on this.
> 
What are you using for secondary storage ?
Is it available/mounted on the hypervisors ?

Add S3 secondary storage

[sebgoa]

Hi folks,

if we want to add a S3 object store as secondary storage, do we just call addS3 
?
http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/addS3.html

I have a basic zone with an existing NFS secondary store, can I add a second 
secondary storage using a S3 store ?

thanks,

-sebastien

Marvin add service offering

[Ian Duffy]

Hi All,

Is it possible to create a service offering using marvin?

I tried using:

"service_offering": {

 "name": "Tiny Instance",

 "displaytext": "Tiny Instance",

 "cpunumber": 1,

 "cpuspeed": 100,

 "memory": 128

},


However it didn't work. I got this example from tools/marvin/marvin/config.


Is it possible to modify existing service templates using marvin? If so
what is the syntax for this?


Thanks,

Ian

Can we delete a template after a VM is instantiated from it?

[Rafael Weingartner]

 Hi,

I was wondering if we can delete a template that has already been used to
instantiate some VMs.

Would that cause any trouble?

-- 
Rafael Weingärtner

RE: Marvin add service offering

[Santhosh Edukulla]

Hi Ian,

We have createserviceoffering and updateserviceoffering apis available. Please 
check moke/test_service_offerings.py suite for examples.

Santhosh 

From: Ian Duffy [i...@ianduffy.ie]
Sent: Sunday, June 15, 2014 11:13 AM
To: CloudStack Dev
Subject: Marvin add service offering

Hi All,

Is it possible to create a service offering using marvin?

I tried using:

"service_offering": {

 "name": "Tiny Instance",

 "displaytext": "Tiny Instance",

 "cpunumber": 1,

 "cpuspeed": 100,

 "memory": 128

},


However it didn't work. I got this example from tools/marvin/marvin/config.


Is it possible to modify existing service templates using marvin? If so
what is the syntax for this?


Thanks,

Ian

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alex Ough]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/
---

(Updated June 15, 2014, 9:40 p.m.)


Review request for cloudstack.


Changes
---

Please review


Repository: cloudstack-git


Description
---

This is the review request for the core changes related with #17790 that has 
only the new plugin codes.


Diffs (updated)
-

  api/src/com/cloud/event/EventTypes.java 39ef710 
  api/src/com/cloud/user/AccountService.java 7e37b38 
  api/src/com/cloud/user/DomainService.java 4c1f93d 
  api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558 
  api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae 
  api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
50d67d9 
  api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
5754ec5 
  
api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java 
3e5e1d3 
  api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
f30c985 
  api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
3c185e4 
  api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
a7ce74a 
  api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
312c9ee 
  api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
a6d2b0b 
  api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
409a84d 
  api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
f6743ba 
  api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
b08cbbb 
  api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
51e218d 
  api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
08ba521 
  api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 
c6e09ef 
  api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 
d69eccf 
  api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 69623d0 
  api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java 2090d21 
  api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
cf5d355 
  api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
  api/src/org/apache/cloudstack/region/Region.java df64e44 
  api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
  api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
  client/pom.xml d8dbde7 
  client/tomcatconf/commands.properties.in 45debe4 
  
engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
 489b37d 
  engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
  engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
  
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
 957f708 
  plugins/pom.xml 9b391b8 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
 626bb8f 
  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
 887ad00 
  
server/resources/META-INF/cloudstack/core/spring-server-core-managers-context.xml
 fc1c7e2 
  server/src/com/cloud/api/ApiResponseHelper.java 38f2f0b 
  server/src/com/cloud/api/dispatch/ParamProcessWorker.java e9bdd8b 
  server/src/com/cloud/event/ActionEventUtils.java 28e5680 
  server/src/com/cloud/projects/ProjectManagerImpl.java d10c059 
  server/src/com/cloud/user/AccountManager.java 03bf842 
  server/src/com/cloud/user/AccountManagerImpl.java 2070ee6 
  server/src/com/cloud/user/DomainManager.java f72b18a 
  server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 
  server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 
  server/src/org/apache/cloudstack/region/RegionManagerImpl.java 8910714 
  server/src/org/apache/cloudstack/region/RegionServiceImpl.java 98cf500 
  server/test/com/cloud/user/MockAccountManagerImpl.java f373cba 
  server/test/com/cloud/user/MockDomainManagerImpl.java 7dddefb 
  server/test/org/apache/cloudstack/region/RegionManagerTest.java d7bc537 
  setup/db/db/schema-440to450.sql 2bd5386 
  ui/scripts/regions.js 66dae8c 

Diff: https://reviews.apache.org/r/20099/diff/


Testing
---

1. Successfully tested real time synchronization as soon as resources are 
created/deleted/modified in one region.
2. Successfully tested full scans to synchronize resources that were missed 
during real time synchronization because of any reasons like network connection 
issues.
3. The tests were done manually and also automatically by randomly generating 
changes each region.


Thanks,

Alex Ough

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

[Alex Ough]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17790/
---

(Updated June 15, 2014, 9:48 p.m.)


Review request for cloudstack.


Changes
---

Please review


Repository: cloudstack-git


Description
---

Currently, under the environment of cloudstack with multiple regions, each 
region has its own management server running with a separate database, which 
will cause data discrepancies when users create/update/delete 
domain/account/user data independently in each management server. So to support 
multiple regions and provide one point of entry for each customer, this 
implementation duplicates domain/account/user information of customers in one 
region to all of the regions independently whenever there is any change.

https://issues.apache.org/jira/browse/CLOUDSTACK-4992
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions


Diffs (updated)
-

  engine/schema/src/org/apache/cloudstack/multiregion/RmapVO.java PRE-CREATION 
  engine/schema/src/org/apache/cloudstack/multiregion/RsyncVO.java PRE-CREATION 
  engine/schema/src/org/apache/cloudstack/multiregion/dao/RmapDao.java 
PRE-CREATION 
  engine/schema/src/org/apache/cloudstack/multiregion/dao/RmapDaoImpl.java 
PRE-CREATION 
  engine/schema/src/org/apache/cloudstack/multiregion/dao/RsyncDao.java 
PRE-CREATION 
  engine/schema/src/org/apache/cloudstack/multiregion/dao/RsyncDaoImpl.java 
PRE-CREATION 
  plugins/event-bus/multiregion/pom.xml PRE-CREATION 
  
plugins/event-bus/multiregion/resources/META-INF/cloudstack/spring-plugin-multiregion-system-context.xml
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/FullSyncer.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/InjectedCollection.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/MultiRegionEventBus.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/StringManipulator.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/AccountCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/BaseCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/DomainCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/UserCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/command/ListSyncAccountsCmd.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/command/ListSyncAccountsCmdByAdmin.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/command/ListSyncDomainChildrenCmd.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/command/ListSyncDomainsCmd.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/command/ListSyncUsersCmd.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/dao/SyncAccountJoinDao.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/dao/SyncAccountJoinDaoImpl.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/dao/SyncUserAccountJoinDao.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/dao/SyncUserAccountJoinDaoImpl.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/ApiSyncResponseHelper.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/SyncAccountResponse.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/SyncDomainResponse.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/SyncQueryManagerImpl.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/SyncQueryService.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/response/SyncUserResponse.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/exception/APIFailureException.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/service/AccountFullSyncProcessor.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/service/AccountService.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/clo

RE: Add S3 secondary storage

[Sanjeev Neelarapu]

Hi Sebastien,

#1 For adding S3 object store as secondary storage use "addImageStore" API with 
provider as "s3"
http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/addImageStore.html

#2 We can't add S3 store if a zone already has NFS as secondary store, however 
we can migrate from NFS to S3
http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/updateCloudToUseObjectStore.html

Thanks,
Sanjeev

-Original Message-
From: sebgoa [mailto:run...@gmail.com] 
Sent: Sunday, June 15, 2014 8:28 PM
To: dev@cloudstack.apache.org
Subject: Add S3 secondary storage

Hi folks,

if we want to add a S3 object store as secondary storage, do we just call addS3 
?
http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/addS3.html

I have a basic zone with an existing NFS secondary store, can I add a second 
secondary storage using a S3 store ?

thanks,

-sebastien

RE: Can we delete a template after a VM is instantiated from it?

[Sanjeev Neelarapu]

We can delete template without any issues.

-Sanjeev

-Original Message-
From: Rafael Weingartner [mailto:rafaelweingart...@gmail.com] 
Sent: Sunday, June 15, 2014 8:48 PM
To: dev@cloudstack.apache.org
Subject: Can we delete a template after a VM is instantiated from it?

 Hi,

I was wondering if we can delete a template that has already been used to 
instantiate some VMs.

Would that cause any trouble?

--
Rafael Weingärtner

Re: [ANNOUNCE] Pierre-Luc Dion as a committer

[Punith S]

congrats. cheers!


On Sun, Jun 15, 2014 at 5:17 AM, Ahmad Emneina  wrote:

> Awesome stuff. Congrats Pierre-Luc!
>
>
> On Sat, Jun 14, 2014 at 2:12 PM, Nux!  wrote:
>
> > Congratulations, Pierre-Luc :)
> >
> > --
> > Sent from the Delta quadrant using Borg technology!
> >
> > Nux!
> > www.nux.ro
> >
> >
> > - Original Message -
> > From: "sebgoa" 
> > To: dev@cloudstack.apache.org
> > Sent: Tuesday, 10 June, 2014 12:45:36 PM
> > Subject: [ANNOUNCE] Pierre-Luc Dion as a committer
> >
> > The Project Management Committee (PMC) for Apache CloudStack has
> > asked Pierre-Luc Dion to become a committer and we are pleased to
> announce
> > that he has accepted.
> >
> > Being a committer allows many contributors to contribute more
> > autonomously. For
> > developers, it makes it easier to submit changes and eliminates the need
> to
> > have contributions reviewed via the patch submission process. Whether
> > contributions are development-related or otherwise, it is a recognition
> of
> > a
> > contributor's participation in the project and commitment to the project
> > and
> > the Apache Way.
> >
> > Please join me in congratulating Pierre-Luc!
> >
> > PS: Nice work on the documentation
> >
> > -Sebastien, on behalf of the CloudStack PMC
> >
>



-- 
regards,

punith s
cloudbyte.com

Re: [DISCUSS] [PROPOSAL] Implementation of DNS Provider for Bind (for 4.5)

[Chiradeep Vittal]

It looks like the DnsProvider calls the REST API of the RoR-based DNSAPI.

+1, but as Rohit said, I’d love to see the design details on the Wiki. This 
will make it easier for folks like Erik to integrate PowerDns.
Does the VR use the Bind server for name resolution? That is, is the Bind 
server the same as the zone DNS? Is this configured on a region level or a zone 
level? Or is it strictly per network offering?

From: Rohit Yadav mailto:bhais...@apache.org>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Friday, June 13, 2014 at 6:53 AM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: Re: [DISCUSS] [PROPOSAL] Implementation of DNS Provider for Bind (for 
4.5)

Hi Silvano,

On Fri, Jun 13, 2014 at 10:51 AM, Silvano Nogueira Buback <
silv...@corp.globo.com> wrote:

Hi there,


I work at Globo.com, a media company in Brazil. Here we use a cloudstack
private network with an advanced zone setup (isolated vlans).

For some couple of reasons, the name of virtual machine needs to be
available not only on virtual router network context, but on our internal
DNS servers.

Our proposal is integrate cloudstack (v 4.5) with DNS server (Bind server)
thru an open source API written by globo.com called DNSAPI. More info at
https://github.com/globocom/Dns-Api.


Thanks for the proposal.

I recommend that you document your design goals in 4.5 or above design docs
wiki:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.5+Design+Documents

I saw the video you shared, it looked seamless but I could not figure out
how the ACS plugin interacts with the DNS provider. The API library you
mentioned is written in Ruby, so how does it integrate or work with the dns
plugin in ACS, is it over HTTP or RPC/Thrift?

Regards.



To make this implementation of DNS provider, we based our plugin on
"dns-notifier", but we had to add more classes for our implementation.

* DnsAPINetworkDAO to manage the networkDomain for each network.
* DnsAPIVirtualMachineDAO to manage DNS records for vms.
* DnsAPIElement, this class implements the provider itself.
* DnsAPIResource, implements all communications with DNSAPI
(ServerResource).

Besides this classes, another one was necessary to the call to
DnsAPIResource and return the answer, and one API command was created to
configure the provider in Zone.

Above a video that show you how everything was integrated.

https://www.youtube.com/watch?v=fAB53T_NZMI

We really appreciate all your comments about our implementation,

thanks in advance
PS: Sorry about duplicated e-mail in mailing list, but I forget to use
DISCUSS and send using company e-mail)

Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

[Koushik Das]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22510/#review45720
---



api/src/com/cloud/agent/api/to/NfsTO.java


Make it constant.



plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java


Will data.getPath() return a path with proper separator? 



plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java


Is the intent to replace all occurrences of File.Separator? I still see 
this one left out.

Also please open a bug to track changes to other HVs.


- Koushik Das


On June 12, 2014, 12:32 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22510/
> ---
> 
> (Updated June 12, 2014, 12:32 p.m.)
> 
> 
> Review request for cloudstack, edison su, Koushik Das, and Min Chen.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Due to File.separator on windows machine the template creation from snapshot 
> is failing as it has mis-matched path separator which is windows path 
> separator(\). Fixed the same by adding getPathSeparator() method to 
> DataStoreTO.java and all it's implementations.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc 
>   api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 
>   api/src/com/cloud/agent/api/to/S3TO.java f64fe35 
>   api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad 
>   core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 
>   core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
>  9c86fbe 
> 
> Diff: https://reviews.apache.org/r/22510/diff/
> 
> 
> Testing
> ---
> 
> Tested on Windows 2012 R2 server and on centos. Tested the following use 
> cases.
> 
> 1. Attach ISO
> 2. Detach ISO
> 3. Snapshot creation from root disk
> 4. Snapshot creation from data disk
> 5. volume creation from (3)
> 6. template creation from(3)
> 7. Launch a VM after registering new template.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Review Request 22613: CLOUDSTACK-6912: 4.2 32 bit system vm template job failing in jenkins

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22613/
---

Review request for cloudstack and Abhinandan Prateek.


Bugs: CLOUDSTACK-6912
https://issues.apache.org/jira/browse/CLOUDSTACK-6912


Repository: cloudstack-git


Description
---

4.2 32 bit system vm template job failing in jenkins


Diffs
-

  tools/appliance/definitions/systemvmtemplate/base.sh 4d6092a 

Diff: https://reviews.apache.org/r/22613/diff/


Testing
---


Thanks,

Harikrishna Patnala

Re: Review Request 22613: CLOUDSTACK-6912: 4.2 32 bit system vm template job failing in jenkins

[Abhinandan Prateek]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22613/#review45721
---

Ship it!


Ship It!

- Abhinandan Prateek


On June 16, 2014, 6:10 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22613/
> ---
> 
> (Updated June 16, 2014, 6:10 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6912
> https://issues.apache.org/jira/browse/CLOUDSTACK-6912
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 4.2 32 bit system vm template job failing in jenkins
> 
> 
> Diffs
> -
> 
>   tools/appliance/definitions/systemvmtemplate/base.sh 4d6092a 
> 
> Diff: https://reviews.apache.org/r/22613/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 22613: CLOUDSTACK-6912: 4.2 32 bit system vm template job failing in jenkins

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22613/#review45722
---


Commit a2b620c0b43dc6739dab3fdb854421bf63f72f1b in cloudstack's branch 
refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a2b620c ]

CLOUDSTACK-6912: 4.2 32 bit system vm template job failing in jenkins

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On June 16, 2014, 6:10 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22613/
> ---
> 
> (Updated June 16, 2014, 6:10 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6912
> https://issues.apache.org/jira/browse/CLOUDSTACK-6912
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 4.2 32 bit system vm template job failing in jenkins
> 
> 
> Diffs
> -
> 
>   tools/appliance/definitions/systemvmtemplate/base.sh 4d6092a 
> 
> Diff: https://reviews.apache.org/r/22613/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

[Damodar Reddy Talakanti]

> On June 16, 2014, 6:04 a.m., Koushik Das wrote:
> > plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java,
> >  line 1407
> > 
> >
> > Is the intent to replace all occurrences of File.Separator? I still see 
> > this one left out.
> > 
> > Also please open a bug to track changes to other HVs.

Yes intention is to remove all File.separator. Did not change that because that 
is related to Swift storage which I did not touch. These changes are for NFS 
only.
Will fix this when doing changes for Swift.


- Damodar Reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22510/#review45720
---


On June 12, 2014, 12:32 p.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22510/
> ---
> 
> (Updated June 12, 2014, 12:32 p.m.)
> 
> 
> Review request for cloudstack, edison su, Koushik Das, and Min Chen.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Due to File.separator on windows machine the template creation from snapshot 
> is failing as it has mis-matched path separator which is windows path 
> separator(\). Fixed the same by adding getPathSeparator() method to 
> DataStoreTO.java and all it's implementations.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc 
>   api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 
>   api/src/com/cloud/agent/api/to/S3TO.java f64fe35 
>   api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad 
>   core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 
>   core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
>  9c86fbe 
> 
> Diff: https://reviews.apache.org/r/22510/diff/
> 
> 
> Testing
> ---
> 
> Tested on Windows 2012 R2 server and on centos. Tested the following use 
> cases.
> 
> 1. Attach ISO
> 2. Detach ISO
> 3. Snapshot creation from root disk
> 4. Snapshot creation from data disk
> 5. volume creation from (3)
> 6. template creation from(3)
> 7. Launch a VM after registering new template.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>