Review Request 21900: [Windows] Move all titles and descriptions to a property file or move to build properties

2014-05-25 Thread Damodar Reddy Talakanti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21900/
---

Review request for cloudstack, Abhinandan Prateek and Murali Reddy.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6702

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6702


Repository: cloudstack-git


Description
---

Move all text that is getting displayed on the installation wizard to a wix 
language files so that we can change texts later


Diffs
-

  client/pom.xml 6d895ce 
  scripts/installer/windows/Setup_Databases.wxs f4e8fa1 
  scripts/installer/windows/acs.wxs 84045c5 
  scripts/installer/windows/dependencies.wxs 82fcd27 
  scripts/installer/windows/en-us.wxl PRE-CREATION 
  scripts/installer/windows/optionstheme.xml 527309f 
  scripts/installer/windows/optionstheme_en-us.wxl PRE-CREATION 

Diff: https://reviews.apache.org/r/21900/diff/


Testing
---

Tested on windows 2012 R2 server


Thanks,

Damodar Reddy Talakanti

Re: Review Request 20621: CLOUDSTACK-6529: Fixed adding hosts even if any host addition fails.

2014-05-25 Thread Abhinandan Prateek 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20621/#review43911
---

Ship it!


Ship It!

- Abhinandan Prateek


On May 23, 2014, 12:39 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20621/
> ---
> 
> (Updated May 23, 2014, 12:39 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6529
> https://issues.apache.org/jira/browse/CLOUDSTACK-6529
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. In deployDataCenter when a host addition fails, it is not continuing 
> further. Added a change, to continue adding all hosts, even if any addition 
> fails. Do a cleanup only when all host addition fails. Tested the changes on 
> local setup 
> 
> 2. Removed another unwanted arguments from class host which are not part of 
> addHost call.
> 3. Added an exit check based upon correct input file path type.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 66609da 
>   tools/marvin/marvin/deployDataCenter.py 4d8be58 
> 
> Diff: https://reviews.apache.org/r/20621/diff/
> 
> 
> Testing
> ---
> 
> Tested the changes that it is not breaking existing deployDataCenter.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

2014-05-25 Thread Abhinandan Prateek 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21858/#review43913
---

Ship it!


Ship It!

- Abhinandan Prateek


On May 23, 2014, 12:31 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21858/
> ---
> 
> (Updated May 23, 2014, 12:31 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6758
> https://issues.apache.org/jira/browse/CLOUDSTACK-6758
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Whenever API returns error message for failed job (not exception), in this 
> case it is returned to test cases as it is. Instead it should throw 
> exceptions for failed jobs.
> 
> With this change, reverted changes done in the test cases (Checking for 
> ERROR_CODE_530) with commit 
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8eca37056f5bb1eee10f0bedee785142d7c3437a
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_accounts.py 9b9ae75 
>   test/integration/component/test_add_remove_network.py 969d94c 
>   test/integration/component/test_affinity_groups.py d31746a 
>   test/integration/component/test_assign_vm.py 0b07e9f 
>   test/integration/component/test_ip_reservation.py eb193d1 
>   test/integration/component/test_non_contiguous_vlan.py 1f74252 
>   test/integration/component/test_projects.py cf6cec8 
>   test/integration/component/test_volumes.py 4a91e5d 
>   test/integration/component/test_vpc.py 31b421c 
>   test/integration/component/test_vpc_network.py 8d12ec6 
>   test/integration/component/test_vpc_network_lbrules.py 47bdce5 
>   test/integration/component/test_vpc_vms_deployment.py 19aa448 
>   test/integration/smoke/test_network.py 7cd3973 
>   test/integration/smoke/test_nic.py a76e858 
>   test/integration/smoke/test_primary_storage.py 5b24b64 
>   test/integration/smoke/test_volumes.py cc76e49 
>   tools/marvin/marvin/cloudstackConnection.py 8044da7 
>   tools/marvin/marvin/codes.py c72a6bd 
> 
> Diff: https://reviews.apache.org/r/21858/diff/
> 
> 
> Testing
> ---
> 
> Tested all the changed test cases on VMware.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 20621: CLOUDSTACK-6529: Fixed adding hosts even if any host addition fails.

2014-05-25 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20621/#review43912
---


Commit 6f3ff068270f48e00531c462de4f7d76395658ff in cloudstack's branch 
refs/heads/4.4-forward from santhosh
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6f3ff06 ]

Added fix for CLOUDSTACK-6529

Fixed to continue adding all hosts, even if any addition fails and remove
unused args from host class.

Signed-off-by: santhosh 
Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On May 23, 2014, 12:39 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20621/
> ---
> 
> (Updated May 23, 2014, 12:39 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6529
> https://issues.apache.org/jira/browse/CLOUDSTACK-6529
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. In deployDataCenter when a host addition fails, it is not continuing 
> further. Added a change, to continue adding all hosts, even if any addition 
> fails. Do a cleanup only when all host addition fails. Tested the changes on 
> local setup 
> 
> 2. Removed another unwanted arguments from class host which are not part of 
> addHost call.
> 3. Added an exit check based upon correct input file path type.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 66609da 
>   tools/marvin/marvin/deployDataCenter.py 4d8be58 
> 
> Diff: https://reviews.apache.org/r/20621/diff/
> 
> 
> Testing
> ---
> 
> Tested the changes that it is not breaking existing deployDataCenter.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

2014-05-25 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21858/#review43914
---


Commit d9066f8d2931acc44ae66fc33f9eaa87b572de6a in cloudstack's branch 
refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d9066f8 ]

CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On May 23, 2014, 12:31 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21858/
> ---
> 
> (Updated May 23, 2014, 12:31 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6758
> https://issues.apache.org/jira/browse/CLOUDSTACK-6758
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Whenever API returns error message for failed job (not exception), in this 
> case it is returned to test cases as it is. Instead it should throw 
> exceptions for failed jobs.
> 
> With this change, reverted changes done in the test cases (Checking for 
> ERROR_CODE_530) with commit 
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8eca37056f5bb1eee10f0bedee785142d7c3437a
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_accounts.py 9b9ae75 
>   test/integration/component/test_add_remove_network.py 969d94c 
>   test/integration/component/test_affinity_groups.py d31746a 
>   test/integration/component/test_assign_vm.py 0b07e9f 
>   test/integration/component/test_ip_reservation.py eb193d1 
>   test/integration/component/test_non_contiguous_vlan.py 1f74252 
>   test/integration/component/test_projects.py cf6cec8 
>   test/integration/component/test_volumes.py 4a91e5d 
>   test/integration/component/test_vpc.py 31b421c 
>   test/integration/component/test_vpc_network.py 8d12ec6 
>   test/integration/component/test_vpc_network_lbrules.py 47bdce5 
>   test/integration/component/test_vpc_vms_deployment.py 19aa448 
>   test/integration/smoke/test_network.py 7cd3973 
>   test/integration/smoke/test_nic.py a76e858 
>   test/integration/smoke/test_primary_storage.py 5b24b64 
>   test/integration/smoke/test_volumes.py cc76e49 
>   tools/marvin/marvin/cloudstackConnection.py 8044da7 
>   tools/marvin/marvin/codes.py c72a6bd 
> 
> Diff: https://reviews.apache.org/r/21858/diff/
> 
> 
> Testing
> ---
> 
> Tested all the changed test cases on VMware.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 21854: CLOUDSTACK-6282 - Added automated test for Networks and VPC API's

2014-05-25 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21854/#review43915
---


Commit 7dc0fca2e90822014d3d6e3a01d2592e7caae5d2 in cloudstack's branch 
refs/heads/4.4-forward from vinayvarmav
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7dc0fca ]

CLOUDSTACK-6282-Added Automated testes for Networks and VPC API's

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On May 23, 2014, 10:57 a.m., Vinay Varma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21854/
> ---
> 
> (Updated May 23, 2014, 10:57 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6282 - Added automated test for Networks and VPC API's. Created 
> patch for 4.4-forward branch and uploaded. Also attached the results file for 
> 4.4-forward branch
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_escalations_networks.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py 9df3f2f 
>   tools/marvin/marvin/lib/base.py 7d08e89 
> 
> Diff: https://reviews.apache.org/r/21854/diff/
> 
> 
> Testing
> ---
> 
> Executed the tests and attached the results file
> 
> 
> File Attachments
> 
> 
> 4.4NetworkResults.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/05/23/25a6c082-1f8d-48ad-adee-af8e021ee803__4.4NetworkResults.txt
> 
> 
> Thanks,
> 
> Vinay Varma
> 
>

Re: Review Request 20621: CLOUDSTACK-6529: Fixed adding hosts even if any host addition fails.

2014-05-25 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20621/#review43916
---


Commit 8b39e2ff71dd452fd4919450e427c851d2b8d1d6 in cloudstack's branch 
refs/heads/master from santhosh
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8b39e2f ]

Added fix for CLOUDSTACK-6529

Fixed to continue adding all hosts, even if any addition fails and remove
unused args from host class.

Signed-off-by: santhosh 
Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On May 23, 2014, 12:39 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20621/
> ---
> 
> (Updated May 23, 2014, 12:39 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6529
> https://issues.apache.org/jira/browse/CLOUDSTACK-6529
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. In deployDataCenter when a host addition fails, it is not continuing 
> further. Added a change, to continue adding all hosts, even if any addition 
> fails. Do a cleanup only when all host addition fails. Tested the changes on 
> local setup 
> 
> 2. Removed another unwanted arguments from class host which are not part of 
> addHost call.
> 3. Added an exit check based upon correct input file path type.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/configGenerator.py 66609da 
>   tools/marvin/marvin/deployDataCenter.py 4d8be58 
> 
> Diff: https://reviews.apache.org/r/20621/diff/
> 
> 
> Testing
> ---
> 
> Tested the changes that it is not breaking existing deployDataCenter.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

2014-05-25 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21858/#review43917
---


Commit a0ad836fd2ae2a5ebae97b72acbe35ad1c429a82 in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a0ad836 ]

CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On May 23, 2014, 12:31 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21858/
> ---
> 
> (Updated May 23, 2014, 12:31 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6758
> https://issues.apache.org/jira/browse/CLOUDSTACK-6758
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Whenever API returns error message for failed job (not exception), in this 
> case it is returned to test cases as it is. Instead it should throw 
> exceptions for failed jobs.
> 
> With this change, reverted changes done in the test cases (Checking for 
> ERROR_CODE_530) with commit 
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8eca37056f5bb1eee10f0bedee785142d7c3437a
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_accounts.py 9b9ae75 
>   test/integration/component/test_add_remove_network.py 969d94c 
>   test/integration/component/test_affinity_groups.py d31746a 
>   test/integration/component/test_assign_vm.py 0b07e9f 
>   test/integration/component/test_ip_reservation.py eb193d1 
>   test/integration/component/test_non_contiguous_vlan.py 1f74252 
>   test/integration/component/test_projects.py cf6cec8 
>   test/integration/component/test_volumes.py 4a91e5d 
>   test/integration/component/test_vpc.py 31b421c 
>   test/integration/component/test_vpc_network.py 8d12ec6 
>   test/integration/component/test_vpc_network_lbrules.py 47bdce5 
>   test/integration/component/test_vpc_vms_deployment.py 19aa448 
>   test/integration/smoke/test_network.py 7cd3973 
>   test/integration/smoke/test_nic.py a76e858 
>   test/integration/smoke/test_primary_storage.py 5b24b64 
>   test/integration/smoke/test_volumes.py cc76e49 
>   tools/marvin/marvin/cloudstackConnection.py 8044da7 
>   tools/marvin/marvin/codes.py c72a6bd 
> 
> Diff: https://reviews.apache.org/r/21858/diff/
> 
> 
> Testing
> ---
> 
> Tested all the changed test cases on VMware.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Build failed in Jenkins: cloudstack-4.4-forward-build #152

2014-05-25 Thread jenkins 
See 


Changes:

[aprateek] Added fix for CLOUDSTACK-6529

[aprateek] CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

[aprateek] CLOUDSTACK-6282-Added Automated testes for Networks and VPC API's

[aprateek] Fixed issues in regression suite project cpu limits

--
[...truncated 20797 lines...]
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Compiling 18 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-hypervisor-ovm ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-hypervisor-ovm ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Open vSwitch 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-network-ovs ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-plugin-network-ovs ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-network-ovs ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-network-ovs ---
[INFO] Compiling 33 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-network-ovs ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-network-ovs ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Hypervisor Xen 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-hypervisor-xen ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-hypervisor-xen ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO]

Jenkins build is back to normal : cloudstack-4.4-forward-build #153

2014-05-25 Thread jenkins 
See

Review Request 21901: L10N:001-Fixed the legacy hard-coding issues

2014-05-25 Thread Vetrivel Chinnasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21901/
---

Review request for cloudstack and Brian Federle.


Repository: cloudstack-git


Description
---

Externalized the hard coded strings in JavaScript files and added them to 
messages.properties files. Also appended the link dictionary.jsp with the 
externalized strings.


Diffs
-

  client/WEB-INF/classes/resources/messages.properties eff2c3e 
  systemvm/js/cloud.logger.js 751627e 
  ui/dictionary.jsp 9cc030a 
  ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a 
  ui/scripts/accounts.js a789084 
  ui/scripts/configuration.js 1a88224 
  ui/scripts/events.js 2731cb6 
  ui/scripts/network.js f934f21 
  ui/scripts/sharedFunctions.js 2cfc89f 
  ui/scripts/storage.js 2660aa5 
  ui/scripts/system.js 67e01f1 
  ui/scripts/templates.js 67cc2fb 
  ui/scripts/ui-custom/physicalResources.js 06fcca7 
  ui/scripts/ui-custom/regions.js 986e009 
  ui/scripts/ui/dialog.js 34cec7b 
  ui/scripts/ui/widgets/listView.js be40d33 
  ui/scripts/vpc.js 020b9d7 

Diff: https://reviews.apache.org/r/21901/diff/


Testing
---

Tested in local environment by replacing the fixed file.


Thanks,

Vetrivel Chinnasamy