Re: Review Request 20479: Added fix for CLOUDSTACK-6389

2014-04-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20479/#review41809
---


Commit cfa783fef27f64ebdd42f66c59445cb37c9a9764 in cloudstack's branch 
refs/heads/4.4-automation from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=cfa783f ]

Added fix for CLOUDSTACK-6389

Added changes for CLOUDSTACK-6389.
More details in the bug.

Signed-off-by: Santhosh Edukulla 
Signed-off-by: SrikanteswaraRao Talluri 


- ASF Subversion and Git Services


On April 18, 2014, 11:10 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20479/
> ---
> 
> (Updated April 18, 2014, 11:10 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-6389
> https://issues.apache.org/jira/browse/CLOUDSTACK-6389
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added fix for the bug. Removed references for basic and cleaned up code from 
> setup and teardown.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_nic.py 5c72607 
> 
> Diff: https://reviews.apache.org/r/20479/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 20479: Added fix for CLOUDSTACK-6389

2014-04-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20479/#review41808
---


Commit cfa783fef27f64ebdd42f66c59445cb37c9a9764 in cloudstack's branch 
refs/heads/4.4-automation from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=cfa783f ]

Added fix for CLOUDSTACK-6389

Added changes for CLOUDSTACK-6389.
More details in the bug.

Signed-off-by: Santhosh Edukulla 
Signed-off-by: SrikanteswaraRao Talluri 


- ASF Subversion and Git Services


On April 18, 2014, 11:10 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20479/
> ---
> 
> (Updated April 18, 2014, 11:10 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-6389
> https://issues.apache.org/jira/browse/CLOUDSTACK-6389
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added fix for the bug. Removed references for basic and cleaned up code from 
> setup and teardown.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_nic.py 5c72607 
> 
> Diff: https://reviews.apache.org/r/20479/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 20479: Added fix for CLOUDSTACK-6389

2014-04-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20479/#review41810
---


Commit 6c9b21907c2600f320d2afc2fb7273fae73b7ba1 in cloudstack's branch 
refs/heads/master from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6c9b219 ]

Added fix for CLOUDSTACK-6389

Added changes for CLOUDSTACK-6389.
More details in the bug.

Signed-off-by: Santhosh Edukulla 
Signed-off-by: SrikanteswaraRao Talluri 


- ASF Subversion and Git Services


On April 18, 2014, 11:10 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20479/
> ---
> 
> (Updated April 18, 2014, 11:10 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-6389
> https://issues.apache.org/jira/browse/CLOUDSTACK-6389
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added fix for the bug. Removed references for basic and cleaned up code from 
> setup and teardown.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_nic.py 5c72607 
> 
> Diff: https://reviews.apache.org/r/20479/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 20479: Added fix for CLOUDSTACK-6389

2014-04-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20479/#review41811
---


Commit 6c9b21907c2600f320d2afc2fb7273fae73b7ba1 in cloudstack's branch 
refs/heads/master from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6c9b219 ]

Added fix for CLOUDSTACK-6389

Added changes for CLOUDSTACK-6389.
More details in the bug.

Signed-off-by: Santhosh Edukulla 
Signed-off-by: SrikanteswaraRao Talluri 


- ASF Subversion and Git Services


On April 18, 2014, 11:10 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20479/
> ---
> 
> (Updated April 18, 2014, 11:10 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-6389
> https://issues.apache.org/jira/browse/CLOUDSTACK-6389
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added fix for the bug. Removed references for basic and cleaned up code from 
> setup and teardown.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_nic.py 5c72607 
> 
> Diff: https://reviews.apache.org/r/20479/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Jenkins build is back to normal : build-master #716

2014-04-30 Thread jenkins
See 



Re: [ACS4.4] Cherry pick several IAM bug fixes

2014-04-30 Thread Daan Hoogland
Min,

see inline

On Wed, Apr 30, 2014 at 7:15 AM, Min Chen  wrote:
> Hi Hugo/Daan,
>
> Would you please cherry-pick the following IAM bug fixes from 4.4-forward 
> branch to 4.4 branch?
>
> Commit : 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
this contains some trailing spaces in the altered lines, can you please amend?

> CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are not 
> working.
>
> Commit: 092b4be8d91e2e63aea12e1d40aa264e144e6d84
done

> CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm
> deployment flow
>
> Commit: a4cb8d11462cb404eba067541639d46e509d717b
done

> CLOUDSTACK-6513: IAM - Templates - When templates are listed with
> templatefilter="shared" is used , we see public templates also being
> included in the list.
>
> Commit: b2b59ed83a566762c960371717b7998b4719ba70
done

> CLOUDSTACK-6533: IAM - Templates - Public templates do not have
> permissions to be used by ROOT group.
>
> Commit: 0767060b1f4cf96db721bd625971345fbda4c48c
done

> CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
> affinity groups available for regular users by passing account and
> domainId paramater.
>
> Commit:7309146f9f3f57b7f7cad40945e11e34a6ff6fab
done

> CLOUDSTACK-6513: Optimize code by removing deprecated utility to
> QueryManagerImpl as private method just used for listTemplates and
> listAffinityGroups to avoid misuse by new list APIs.
>
> Commit: 3af2f6d1418c66533067b5050d2fe3fd4200beb9
contains code in comment, can you please delete?

> CLOUDSTACK-6513: templateFilter=shared should not show self-owned
> template.
>
> Thanks.
> -min


regards
-- 
Daan


Re: git commit: updated refs/heads/4.4 to 8696f38

2014-04-30 Thread Daan Hoogland
On Tue, Apr 29, 2014 at 8:06 PM,   wrote:
> 8696f386dd73baf0b8281166a75195b3570e3436


Anthony,

please refrain from checking in to branch 4.4 directly in this stage.
Escpecially when commenting out but leaving code in comment in the
source. This is not what we have a revision system for.

Amend this or I will revert.

-- 
Daan


Build failed in Jenkins: build-master-noredist #2675

2014-04-30 Thread jenkins
See 

Changes:

[Daan Hoogland] CLOUDSTACK-6485: private gateway network should not be 
associated with vpc

[Daan Hoogland] formatting

[min.chen] CLOUDSTACK-6349: IAM - No error message presented to the user , when 
invalid password is provided.

[min.chen] CLOUDSTACK-6349: IAM - No error message presented to the user , when

[min.chen] CLOUDSTACK-6501:IAM - DomainAdmin - When listVirtualMachines is used

[min.chen] CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py 
are

[min.chen] CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm

[min.chen] CLOUDSTACK-6513: IAM - Templates - When templates are listed with

[laszlo.hornyak] autounboxing fix in ConfigurationManager

[laszlo.hornyak] Static resource compression

[nitin.mehta] CLOUDSTACK-6530: Populate the first class entities in the context 
to be available for publishing more information for the event bus, checking the 
displayable property etc.

[mike.tutkowski] CLOUDSTACK-6170 Needed to add logic for XS 6.2 + XS62ESP1 + 
XS62ESP1004

[koushik] CLOUDSTACK-4371: [Performance Testing] Basic zone with 20K Hosts, 
management server restart leaves the hosts in disconnected state for very long 
time

[muralimmreddy] CLOUDSTACK-6271: The cloud-setup-databases was failing when 
your jasypt jar path has spaces in it's path

[koushik] Fixed CLOUDSTACK-6509 Cannot import multiple LDAP/AD users into a 
cloudstack account

[rajesh.battala] Removed Epoch tag/number from the cloud.spec to fix the rpm 
installation of Management Server, Agent and awsapi

[talluri] Fixed pep8 issues arising as part of merge

[anthony.xu] disable XS event

[laszlo.hornyak] null pointer dereference fix

[talluri] Fix few issues seen in run.

[talluri] Added fix for CLOUDSTACK-6389

[talluri] removed basic zone tag and added advanced zone tag

--
[...truncated 24832 lines...]
[INFO] Installing 

 to 
/jenkins/.m2/repository/org/apache/cloudstack/cloud-plugin-hypervisor-ovm/4.5.0-SNAPSHOT/cloud-plugin-hypervisor-ovm-4.5.0-SNAPSHOT.pom
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Open vSwitch 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-network-ovs ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-plugin-network-ovs ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-network-ovs ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-network-ovs ---
[INFO] Compiling 33 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-network-ovs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-network-ovs ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-network-ovs ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ cloud-plugin-network-ovs ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ 
cloud-plugin-network-ovs ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-plugin-network-ovs ---
[INFO] Installing 


Jenkins build is back to normal : build-master-noredist #2676

2014-04-30 Thread jenkins
See 



Re: Create template from snapshot using ec2

2014-04-30 Thread Páll Helgason
Hi Marty,

Thanks for the reply. It doesn’t really get to the management server since it’s 
failing before that.

2014-04-23 10:38:19,017 INFO  [cloud.api.ApiServer] (catalina-exec-18:null) 
(userId=10 accountId=10 sessionId=null) 127.0.0.1 -- GET 
command=registerTemplate&response=json&zoneid=596ee614-0917-496c-bce3-129254c3e110&hypervisor=VMWare&name=CentosFromSnapshot&displaytext=test&format=ova&url=null&ostypeid=1f3da26c-c553-11e3-b989-005056b0541d&apikey=ZmpaQ2xwNDVSbDh3SnRnNnE0dG9Kc2xLWW5GZFdr&signature=n41Wzfb%2FV9WvTxo4UGgam9bNZgU%3D
 431 Please specify a valid URL. URL:null is invalid

I’ve since gone through the code and figured out that the current 
implementation requires that the [manifest] parameter (according to the ec2 
spec) is set and is used as the URL. So I’ll be changing that for us to make 
this possible (i.e. to create register a snapshot without having a URL to it). 
I’ve also added the ability to register an ISO image with ec2-register. I can 
commit these changes, when done, to the master branch if anyone is interested.

Cheers,

-- 
Páll Helgason
Core Team

Tel: (+354) 415 0202 
pa...@greenqloud.com
www.greenqloud.com




On 25.4.2014, at 18:33, Marty Sweet  wrote:

> Hi Pall,
> 
> I have CC'ed in the users mailing list as they might have more suggestions 
> there.
> 
> In the meantime, please can you provide the management-server.log around the 
> time when you run this API command. It might provide a useful insight to the 
> problem.
> Also, how you do mean 'fails on the url'? What does it return? an error code? 
> JSON array?
> 
> Marty
> 
> 
> 
> 
> On 23 April 2014 15:37, Páll Helgason  wrote:
> Hi,
> 
> Maybe someone here can help me with this. I’m trying to create a template 
> from a snapshot (CS 4.2.1 + VMWare 5.0) created with the ec2 tools. Creating 
> the snapshot works just fine (and so does ec2-create-image). But when I try 
> to register the snapshot as a template it’s just not working. 
> 
> The command I use is ec2-register -d test -n CentosFromSnapshot -s 
> c651d9b9-fd17-4002-b32f-c46ad27c93ac -a ova:VUmc:Other:VMWare (figured out 
> the -a stuff from the code). According to the awsapi logs this calls 
> 
> http://127.0.0.1:8080/client/api?command=registerTemplate&response=json&zoneid=596ee614-0917-496c-bce3-129254c3e110&hypervisor=VMWare&name=CentosFromSnapshot&displaytext=test&format=ova&url=null&ostypeid=1f3da26c-c553-11e3-b989-005056b0541d&apikey=xxx&signature=
> 
> which of course fails on the url. Going through the code I can’t find 
> anything that is handling the -s parameter. Am I missing something or is this 
> not implemented?
> 
> Cheers,
> 
> -- 
> Páll Helgason
> Core Team
> 
> Tel: (+354) 415 0202 
> pa...@greenqloud.com
> www.greenqloud.com
> 
> 
> 
> 
> 



Re: Create template from snapshot using ec2

2014-04-30 Thread sebgoa

On Apr 30, 2014, at 11:47 AM, Páll Helgason  wrote:

> Hi Marty,
> 
> Thanks for the reply. It doesn’t really get to the management server since 
> it’s failing before that.
> 
> 2014-04-23 10:38:19,017 INFO  [cloud.api.ApiServer] (catalina-exec-18:null) 
> (userId=10 accountId=10 sessionId=null) 127.0.0.1 -- GET 
> command=registerTemplate&response=json&zoneid=596ee614-0917-496c-bce3-129254c3e110&hypervisor=VMWare&name=CentosFromSnapshot&displaytext=test&format=ova&url=null&ostypeid=1f3da26c-c553-11e3-b989-005056b0541d&apikey=ZmpaQ2xwNDVSbDh3SnRnNnE0dG9Kc2xLWW5GZFdr&signature=n41Wzfb%2FV9WvTxo4UGgam9bNZgU%3D
>  431 Please specify a valid URL. URL:null is invalid
> 
> I’ve since gone through the code and figured out that the current 
> implementation requires that the [manifest] parameter (according to the ec2 
> spec) is set and is used as the URL. So I’ll be changing that for us to make 
> this possible (i.e. to create register a snapshot without having a URL to 
> it). I’ve also added the ability to register an ISO image with ec2-register. 
> I can commit these changes, when done, to the master branch if anyone is 
> interested.
> 

Yes please, can you file a bug for it, and then submit your review.

-sebastien

> Cheers,
> 
> -- 
> Páll Helgason
> Core Team
> 
> Tel: (+354) 415 0202 
> pa...@greenqloud.com
> www.greenqloud.com
> 
> 
> 
> 
> On 25.4.2014, at 18:33, Marty Sweet  wrote:
> 
>> Hi Pall,
>> 
>> I have CC'ed in the users mailing list as they might have more suggestions 
>> there.
>> 
>> In the meantime, please can you provide the management-server.log around the 
>> time when you run this API command. It might provide a useful insight to the 
>> problem.
>> Also, how you do mean 'fails on the url'? What does it return? an error 
>> code? JSON array?
>> 
>> Marty
>> 
>> 
>> 
>> 
>> On 23 April 2014 15:37, Páll Helgason  wrote:
>> Hi,
>> 
>> Maybe someone here can help me with this. I’m trying to create a template 
>> from a snapshot (CS 4.2.1 + VMWare 5.0) created with the ec2 tools. Creating 
>> the snapshot works just fine (and so does ec2-create-image). But when I try 
>> to register the snapshot as a template it’s just not working. 
>> 
>> The command I use is ec2-register -d test -n CentosFromSnapshot -s 
>> c651d9b9-fd17-4002-b32f-c46ad27c93ac -a ova:VUmc:Other:VMWare (figured out 
>> the -a stuff from the code). According to the awsapi logs this calls 
>> 
>> http://127.0.0.1:8080/client/api?command=registerTemplate&response=json&zoneid=596ee614-0917-496c-bce3-129254c3e110&hypervisor=VMWare&name=CentosFromSnapshot&displaytext=test&format=ova&url=null&ostypeid=1f3da26c-c553-11e3-b989-005056b0541d&apikey=xxx&signature=
>> 
>> which of course fails on the url. Going through the code I can’t find 
>> anything that is handling the -s parameter. Am I missing something or is 
>> this not implemented?
>> 
>> Cheers,
>> 
>> -- 
>> Páll Helgason
>> Core Team
>> 
>> Tel: (+354) 415 0202 
>> pa...@greenqloud.com
>> www.greenqloud.com
>> 
>> 
>> 
>> 
>> 
> 



db deployment is failing in master branch

2014-04-30 Thread Rajesh Battala
Hi All,

Deploying DB on master branch is failing.

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[WARNING]
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:297)
at java.lang.Thread.run(Thread.java:722)
Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to upgrade 
the database
at 
com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:352)
at 
com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:447)
at com.cloud.upgrade.DatabaseCreator.main(DatabaseCreator.java:222)
... 6 more
Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to execute 
upgrade script: /home/rajesh/hyperv/developer/target/db/db/schema-430to440.sql
at 
com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:267)
at 
com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:321)
... 8 more
Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Duplicate 
column name 'instance_ip'
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:193)
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
at 
com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:258)
... 9 more


Thanks
Rajesh Battala


[GitHub] cloudstack-docs-rn pull request: preperation to 4.4 release-notes

2014-04-30 Thread runseb
Github user runseb commented on the pull request:

https://github.com/apache/cloudstack-docs-rn/pull/7#issuecomment-41780413
  
I applied it but we have to be careful with this. For example changing from 
4.3 to 'release' in the bug list is not quite right. The filter will change for 
4.4 and we will need to change that accordingly. the list of bugs is generated 
by the script in utils/jira.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: db deployment is failing in master branch

2014-04-30 Thread Rajesh Battala
I have figure out that root cause. 
Murali commit has committed the file with instance_ip column.  
(https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=095151c98a45022b9759a45c066d8ec815de19e4)
 
After that again Amogh commit is trying to create the same column. 
(https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=78c683f5682560deffa405ac76edf23f8e17565d)
 

769 ALTER TABLE `cloud`.`load_balancer_vm_map` ADD COLUMN instance_ip 
VARCHAR(40);
 770 ALTER TABLE `cloud`.`load_balancer_vm_map` DROP KEY `load_balancer_id`, 
ADD UNIQUE KEY load_balancer_id (`load_balancer_id`, `instance_id`, 
`instance_ip`);
 771 ALTER TABLE `cloud`.`vpc_offerings` ADD COLUMN supports_region_level_vpc 
boolean default false;
 772 ALTER TABLE `cloud`.`network_offerings` ADD COLUMN supports_streched_l2 
boolean default false;
 773 ALTER TABLE `cloud`.`networks` ADD COLUMN streched_l2 boolean default 
false;
 774 ALTER TABLE `cloud`.`vpc` ADD COLUMN region_level_vpc boolean default 
false;
 775 INSERT INTO `cloud`.`configuration`(category, instance, component, name, 
value, description, default_value) VALUES ('Advanced', 'DEFAULT', 
'NetworkOrchestrationService', 'router.redundant.vrrp.interval', '1', 'seconds 
between VRRP broadcast. It would 3 times broadcast fail to trigger fail-over 
mechanism of redundant router', '1') ON DUPLICATE KEY UPDATE 
category='Advanced';
 776 INSERT INTO `cloud`.`configuration`(category, instance, component, name, 
value, description, default_value) VALUES ('Advanced', 'DEFAULT', 
'NetworkOrchestrationService', 'router.aggregation.command.each.timeout', '3', 
'timeout in seconds for each Virtual Router command being aggregated. The final 
aggregation command timeout would be determined by this timeout * commands 
counts ', '3') ON DUPLICATE KEY UPDATE category='Advanced';
 777 ALTER TABLE `cloud`.`load_balancer_vm_map` ADD COLUMN instance_ip 
VARCHAR(40);
 778 ALTER TABLE `cloud`.`load_balancer_vm_map` DROP KEY `load_balancer_id`, 
ADD UNIQUE KEY load_balancer_id (`load_balancer_id`, `instance_id`, 
`instance_ip`)



I can fix this issue and commit the changes. 

Thanks
Rajesh Battala


-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Wednesday, April 30, 2014 3:29 PM
To: dev@cloudstack.apache.org
Subject: db deployment is failing in master branch

Hi All,

Deploying DB on master branch is failing.

> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
[WARNING]
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:297)
at java.lang.Thread.run(Thread.java:722)
Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to upgrade 
the database
at 
com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:352)
at 
com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:447)
at com.cloud.upgrade.DatabaseCreator.main(DatabaseCreator.java:222)
... 6 more
Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to execute 
upgrade script: /home/rajesh/hyperv/developer/target/db/db/schema-430to440.sql
at 
com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:267)
at 
com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:321)
... 8 more
Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Duplicate 
column name 'instance_ip'
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:193)
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
at 
com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:258)
... 9 more


Thanks
Rajesh Battala


[GitHub] cloudstack-docs-rn pull request: preperation to 4.4 release-notes

2014-04-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-docs-rn/pull/7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [REMINDER] Review Request 18677: CLOUDSTACK-3272

2014-04-30 Thread Sonal Ojha
Kindly let me know your comments to the changes.


On Wed, Apr 16, 2014 at 9:32 AM, Sonal Ojha wrote:

> Please take a look.
>
> -- Forwarded message --
> From: Sonal Ojha 
> Date: Tue, Apr 15, 2014 at 6:07 PM
> Subject: Re: Review Request 18677: CLOUDSTACK-3272
> To: Murali Reddy , Chiradeep Vittal <
> chirade...@gmail.com>
> Cc: Sonal Ojha , cloudstack <
> dev@cloudstack.apache.org>
>
>
>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
>   Review request for cloudstack, Chiradeep Vittal and Murali Reddy.
> By Sonal Ojha.
>
> *Updated April 15, 2014, 12:37 p.m.*
> Changes
>
> Removed the earlier not working patch files and added a new patch file 
> (0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch) which works 
> on master with commit 55f53e13e. I could successfully apply the latest patch 
> attached on master and test the alert/action/resource/usage events published 
> on rabbitmq message bus. Earlier patch didnt work as it was built on the 
> older version and had some changes which werent required. Kindly take a look 
> and revert back.
>
>   *Bugs: * 
> CLOUDSTACK-3272
>  *Repository: * cloudstack-git
> Description
>
> At present, there are multiple event types that are generated by CS, action 
> events,usage events, resource state change events and alerts. Current problem 
> is
> all the events gets published on the event bus when event bus is enabled. 
> Intent is to introduce global setting config parameters to specify which 
> category of events to be published or not be published on the event bus.
>
>   Testing
>
> Successfully tested publishing / not publishing of various events based on 
> the global parameter publish.*.events.
>
>   Diffs
>
>- server/src/com/cloud/configuration/Config.java (2d55f46)
>- server/src/com/cloud/event/ActionEventUtils.java (00122de)
>- server/src/com/cloud/test/DatabaseConfig.java (9370218)
>
> View Diff 
> File Attachments (updated)
>
>- Working patch for master (latest git commit 
> 55f53e13e)
>
>
>
>
> --
>
> *Thanks and Regards,*
>
> *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard
> Availability Services, India*
>
> 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
> Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com
> ▪ www.sungardas. *in*
>
> *[image: Logo]* 
> *[image: cid:image019.png@01CF48EC.6617C7F0]* 
>  *[image: 
> cid:image020.png@01CF48EC.6617C7F0]*
>  *[image: 
> cid:image021.png@01CF48EC.6617C7F0]*
>  *[image: 
> cid:image022.png@01CF48EC.6617C7F0]*
>  *[image: 
> cid:image023.png@01CF48EC.6617C7F0]*
>  *[image: cid:image024.png@01CF48EC.6617C7F0]*
> *CONFIDENTIALITY:*  This e-mail (including any attachments) may contain
> confidential, proprietary and privileged information, and unauthorized
> disclosure or use is prohibited.  If you received this e-mail in error,
> please notify the sender and delete this e-mail from your system.
>



-- 

*Thanks and Regards,*

*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability
Services, India*

2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪
www.sungardas. *in*

*[image: Logo]* 
*[image: cid:image019.png@01CF48EC.6617C7F0]*
 *[image:
cid:image020.png@01CF48EC.6617C7F0]* 
 *[image: 
cid:image021.png@01CF48EC.6617C7F0]*
 *[image: 
cid:image022.png@01CF48EC.6617C7F0]*
 *[image: 
cid:image023.png@01CF48EC.6617C7F0]*
 *[image: cid:image024.png@01CF48EC.6617C7F0]*
*CONFIDENTIALITY:*  This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited.  If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.


[cloudmonkey] Problem listing virtualmachines by account

2014-04-30 Thread Nux!

Hi,

How can I list the VMs of a certain account?
Apparently cloudmonkey allows listing VMs per account (a pretty D'OH 
feature), but I can't get it to work. All I get is this:


mycloudmonkey > list virtualmachines 
account=e7905355-2e13-4ea7-b6d8-e23ad214f20f 
domainid=730c8a4a-a44f-11e3-bae5-f6145f6a2f37
431: could not find account e7905355-2e13-4ea7-b6d8-e23ad214f20f in 
domain 730c8a4a-a44f-11e3-bae5-f6145f6a2f37


What am I missing?

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


RE: [cloudmonkey] Problem listing virtualmachines by account

2014-04-30 Thread Saksham Srivastava
Nux,

You have to specify the account name not the uuid.
#list virtualmachines account= 
domainid=730c8a4a-a44f-11e3-bae5-f6145f6a2f37 listall=true


Thanks,
Saksham

-Original Message-
From: Nux! [mailto:n...@li.nux.ro] 
Sent: Wednesday, April 30, 2014 5:48 PM
To: dev@cloudstack.apache.org
Subject: [cloudmonkey] Problem listing virtualmachines by account

Hi,

How can I list the VMs of a certain account?
Apparently cloudmonkey allows listing VMs per account (a pretty D'OH feature), 
but I can't get it to work. All I get is this:

mycloudmonkey > list virtualmachines
account=e7905355-2e13-4ea7-b6d8-e23ad214f20f
domainid=730c8a4a-a44f-11e3-bae5-f6145f6a2f37
431: could not find account e7905355-2e13-4ea7-b6d8-e23ad214f20f in domain 
730c8a4a-a44f-11e3-bae5-f6145f6a2f37

What am I missing?

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


RE: [cloudmonkey] Problem listing virtualmachines by account

2014-04-30 Thread Nux!

On 30.04.2014 13:40, Saksham Srivastava wrote:

Nux,

You have to specify the account name not the uuid.
#list virtualmachines account=
domainid=730c8a4a-a44f-11e3-bae5-f6145f6a2f37 listall=true


Thanks, that fooled me. I'm surprised when I have to use non-UUIDs .. 
:)


--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


schema upgrade in 4.4 not in master

2014-04-30 Thread Daan Hoogland
Sheng,

I encountered your commit 3578c7137f42fdcaadad9b263e18921e2fa094da in
4.4: CLOUDSTACK-6047: Make aggregation command timeout configurable
It includes a change to the db upgrade script schema-430to440.sql that
is not in master.

Should this be ported to master?

-- 
Daan


Re: Review Request 20659: CLOUDSTACK-5674: Fixed cloudstackConnection.py to return FAILED in case of well handled exceptions returning from server having jobresultcode as 530

2014-04-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20659/#review41830
---


Commit b273f6642341b7ec2640bf6de865a91ccb50feb4 in cloudstack's branch 
refs/heads/master from SrikanteswaraRao Talluri
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b273f66 ]

CLOUDSTACK-5674:Fixes for BVT and Regression test failures.
Signed-off-by: SrikanteswaraRao Talluri 

Conflicts:
test/integration/smoke/test_nic.py


- ASF Subversion and Git Services


On April 24, 2014, 9:15 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20659/
> ---
> 
> (Updated April 24, 2014, 9:15 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-5674
> https://issues.apache.org/jira/browse/CLOUDSTACK-5674
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> In case of well handled exceptions returned from the server with proper error 
> message, the response was as it is returned. Instead, it should check the 
> jobresultcode. If the jobresultcode is 530, it means that exception is 
> returned from server. In this case we should return FAILED.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/cloudstackConnection.py d006002 
>   tools/marvin/marvin/codes.py 4d44c58 
> 
> Diff: https://reviews.apache.org/r/20659/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: Review Request 19892: Add Juniper Contrail support to devCloud environment

2014-04-30 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19892/#review41834
---



tools/devcloud/devcloud-advanced_juniper-contrail.cfg


sorry to get back so late but I think you introduced an error here: there 
is a '[' missing in comparison to the last version. 


- daan Hoogland


On April 15, 2014, 8:18 p.m., Sachchidanand Vaidya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19892/
> ---
> 
> (Updated April 15, 2014, 8:18 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Add OpenContrail support to devCloud environment:
> - Created new devcloud advanced networking config file 
> (devcloud-advanced_juniper-contrail.cfg).
> - Modification to deployDataCenter script, to enable 
> "JuniperContrailRouter" &
>   "JuniperContrailVpcRouter" providers.
> 
> 
> Diffs
> -
> 
>   tools/devcloud/devcloud-advanced_juniper-contrail.cfg PRE-CREATION 
>   tools/marvin/marvin/deployDataCenter.py c4f6e1e 
> 
> Diff: https://reviews.apache.org/r/19892/diff/
> 
> 
> Testing
> ---
> 
> Unit tested with devCloud2 and ACS4.3 code base.
> 
> 
> Thanks,
> 
> Sachchidanand Vaidya
> 
>



Re: Review Request 19892: Add Juniper Contrail support to devCloud environment

2014-04-30 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19892/#review41837
---


your patch does not apply, Can you test-apply it to a freshly checked out 
version of master? thanks

- daan Hoogland


On April 15, 2014, 8:18 p.m., Sachchidanand Vaidya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19892/
> ---
> 
> (Updated April 15, 2014, 8:18 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Add OpenContrail support to devCloud environment:
> - Created new devcloud advanced networking config file 
> (devcloud-advanced_juniper-contrail.cfg).
> - Modification to deployDataCenter script, to enable 
> "JuniperContrailRouter" &
>   "JuniperContrailVpcRouter" providers.
> 
> 
> Diffs
> -
> 
>   tools/devcloud/devcloud-advanced_juniper-contrail.cfg PRE-CREATION 
>   tools/marvin/marvin/deployDataCenter.py c4f6e1e 
> 
> Diff: https://reviews.apache.org/r/19892/diff/
> 
> 
> Testing
> ---
> 
> Unit tested with devCloud2 and ACS4.3 code base.
> 
> 
> Thanks,
> 
> Sachchidanand Vaidya
> 
>



RE: git commit: updated refs/heads/4.4 to 8696f38

2014-04-30 Thread Alex Huang
Daan,

I added Anthony to the to list to draw his attention.  I propose that you just 
revert commits if the right process is not followed for a release branch.

--Alex

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Wednesday, April 30, 2014 1:50 AM
> To: dev
> Cc: comm...@cloudstack.apache.org
> Subject: Re: git commit: updated refs/heads/4.4 to 8696f38
> 
> On Tue, Apr 29, 2014 at 8:06 PM,   wrote:
> > 8696f386dd73baf0b8281166a75195b3570e3436
> 
> 
> Anthony,
> 
> please refrain from checking in to branch 4.4 directly in this stage.
> Escpecially when commenting out but leaving code in comment in the source.
> This is not what we have a revision system for.
> 
> Amend this or I will revert.
> 
> --
> Daan


Re: [ACS4.4] Cherry pick several IAM bug fixes

2014-04-30 Thread Min Chen
Thanks Daan. I am addressing those two commits now.

-min

On 4/30/14 1:42 AM, "Daan Hoogland"  wrote:

>Min,
>
>see inline
>
>On Wed, Apr 30, 2014 at 7:15 AM, Min Chen  wrote:
>> Hi Hugo/Daan,
>>
>> Would you please cherry-pick the following IAM bug fixes from
>>4.4-forward branch to 4.4 branch?
>>
>> Commit : 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
>this contains some trailing spaces in the altered lines, can you please
>amend?
>
>> CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are
>>not working.
>>
>> Commit: 092b4be8d91e2e63aea12e1d40aa264e144e6d84
>done
>
>> CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm
>> deployment flow
>>
>> Commit: a4cb8d11462cb404eba067541639d46e509d717b
>done
>
>> CLOUDSTACK-6513: IAM - Templates - When templates are listed with
>> templatefilter="shared" is used , we see public templates also being
>> included in the list.
>>
>> Commit: b2b59ed83a566762c960371717b7998b4719ba70
>done
>
>> CLOUDSTACK-6533: IAM - Templates - Public templates do not have
>> permissions to be used by ROOT group.
>>
>> Commit: 0767060b1f4cf96db721bd625971345fbda4c48c
>done
>
>> CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
>> affinity groups available for regular users by passing account and
>> domainId paramater.
>>
>> Commit:7309146f9f3f57b7f7cad40945e11e34a6ff6fab
>done
>
>> CLOUDSTACK-6513: Optimize code by removing deprecated utility to
>> QueryManagerImpl as private method just used for listTemplates and
>> listAffinityGroups to avoid misuse by new list APIs.
>>
>> Commit: 3af2f6d1418c66533067b5050d2fe3fd4200beb9
>contains code in comment, can you please delete?
>
>> CLOUDSTACK-6513: templateFilter=shared should not show self-owned
>> template.
>>
>> Thanks.
>> -min
>
>
>regards
>-- 
>Daan



Re: schema upgrade in 4.4 not in master

2014-04-30 Thread Sheng Yang
It's in the master.

See commit: 4620c27ebf750c840b530d18fed7d8adf857e91 in the master branch.

--Sheng


On Wed, Apr 30, 2014 at 6:38 AM, Daan Hoogland wrote:

> Sheng,
>
> I encountered your commit 3578c7137f42fdcaadad9b263e18921e2fa094da in
> 4.4: CLOUDSTACK-6047: Make aggregation command timeout configurable
> It includes a change to the db upgrade script schema-430to440.sql that
> is not in master.
>
> Should this be ported to master?
>
> --
> Daan
>


Re: [ACS4.4] Cherry pick several IAM bug fixes

2014-04-30 Thread Min Chen
Hi Daan,

I have fixed those two commits. Could you please cherry-pick the
following commits from 4.4-forward to 4.4 branch/

1. CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are
not working.
Commit: 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
Commit: 42b803dd4b6e01107cbcf08d87f17c47934e8ae7

2. CLOUDSTACK-6513: templateFilter=shared should not show self-owned
template.
Commit: 3af2f6d1418c66533067b5050d2fe3fd4200beb9
Commit: 412793f9b41bb03eda2b8474f9f22a12b5097327

Thanks
-min


On 4/30/14 9:39 AM, "Min Chen"  wrote:

>Thanks Daan. I am addressing those two commits now.
>
>-min
>
>On 4/30/14 1:42 AM, "Daan Hoogland"  wrote:
>
>>Min,
>>
>>see inline
>>
>>On Wed, Apr 30, 2014 at 7:15 AM, Min Chen  wrote:
>>> Hi Hugo/Daan,
>>>
>>> Would you please cherry-pick the following IAM bug fixes from
>>>4.4-forward branch to 4.4 branch?
>>>
>>> Commit : 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
>>this contains some trailing spaces in the altered lines, can you please
>>amend?
>>
>>> CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are
>>>not working.
>>>
>>> Commit: 092b4be8d91e2e63aea12e1d40aa264e144e6d84
>>done
>>
>>> CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm
>>> deployment flow
>>>
>>> Commit: a4cb8d11462cb404eba067541639d46e509d717b
>>done
>>
>>> CLOUDSTACK-6513: IAM - Templates - When templates are listed with
>>> templatefilter="shared" is used , we see public templates also being
>>> included in the list.
>>>
>>> Commit: b2b59ed83a566762c960371717b7998b4719ba70
>>done
>>
>>> CLOUDSTACK-6533: IAM - Templates - Public templates do not have
>>> permissions to be used by ROOT group.
>>>
>>> Commit: 0767060b1f4cf96db721bd625971345fbda4c48c
>>done
>>
>>> CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
>>> affinity groups available for regular users by passing account and
>>> domainId paramater.
>>>
>>> Commit:7309146f9f3f57b7f7cad40945e11e34a6ff6fab
>>done
>>
>>> CLOUDSTACK-6513: Optimize code by removing deprecated utility to
>>> QueryManagerImpl as private method just used for listTemplates and
>>> listAffinityGroups to avoid misuse by new list APIs.
>>>
>>> Commit: 3af2f6d1418c66533067b5050d2fe3fd4200beb9
>>contains code in comment, can you please delete?
>>
>>> CLOUDSTACK-6513: templateFilter=shared should not show self-owned
>>> template.
>>>
>>> Thanks.
>>> -min
>>
>>
>>regards
>>-- 
>>Daan
>



Review Request 20901: Remove accidentally added columns while resolving merge conflicts

2014-04-30 Thread Amogh Vasekar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20901/
---

Review request for cloudstack and Rajesh Battala.


Repository: cloudstack-git


Description
---

Remove accidentally added columns while resolving merge conflicts


Diffs
-

  setup/db/db/schema-430to440.sql 711919e6b4605f4d9285a4eb2c75f10d52b81fd3 

Diff: https://reviews.apache.org/r/20901/diff/


Testing
---


Thanks,

Amogh Vasekar



4.4-forward: Management Server fails to start

2014-04-30 Thread Prachi Damle
I synced to latest 4.4-forward and the server fails to start.

Anyone seeing this?

Thanks,
Prachi


Re: 4.4-forward: Management Server fails to start

2014-04-30 Thread Min Chen
Yes, I see the same issue.

Daan, 
I think that it is your commit 3852afa717dc147ef9dc19d7b3801c341f321e77
that broke it. You break NetworkACLItemCidrsDao out of NetworkACLItemDao,
but you forgot to add that into spring context xml file. You may need to
add that into 
cloud-engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema
-core-daos-context.xml.

Thanks
-min

On 4/30/14 10:57 AM, "Prachi Damle"  wrote:

>I synced to latest 4.4-forward and the server fails to start.
>
>Anyone seeing this?
>
>Thanks,
>Prachi



RE: 4.4-forward: Management Server fails to start

2014-04-30 Thread Prachi Damle
Created https://issues.apache.org/jira/browse/CLOUDSTACK-6549

-Original Message-
From: Min Chen [mailto:min.c...@citrix.com] 
Sent: Wednesday, April 30, 2014 11:01 AM
To: dev@cloudstack.apache.org
Cc: Daan Hoogland
Subject: Re: 4.4-forward: Management Server fails to start
Importance: High

Yes, I see the same issue.

Daan, 
I think that it is your commit 3852afa717dc147ef9dc19d7b3801c341f321e77
that broke it. You break NetworkACLItemCidrsDao out of NetworkACLItemDao, but 
you forgot to add that into spring context xml file. You may need to add that 
into cloud-engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema
-core-daos-context.xml.

Thanks
-min

On 4/30/14 10:57 AM, "Prachi Damle"  wrote:

>I synced to latest 4.4-forward and the server fails to start.
>
>Anyone seeing this?
>
>Thanks,
>Prachi



[ACS44]cherry pick CLOUDSTACK-6517

2014-04-30 Thread Prachi Damle
Hi Hugo/Daan,

Can you please cherry-pick following to 4.4:

Commit hash:e14c2ec7241ec2333ea3ac3d56a0e938fe1bf131

CLOUDSTACK-6517: IAM - Admin is allowed to create PortFowarding rule for a 
regular user, when admin does not have " UseEntry" permission for IpAddress.
Contained in branches: 4.4-forward

Thanks,
Prachi


Re: [DISCUSS] LXC systemvm

2014-04-30 Thread Rohit Yadav
Thanks Chiradeep and Pedro for your replies. My $dayjob requires me to work
with baremetal servers, in fact almost all our infra consists of baremetal
servers which at times is difficult to work with, therefore I'm exploring
ways to introduce docker/lxc (containers), mesos (cluster management), etcd
(conf/locking) and a manager/controller (cloudstack?).

Pedro's idea is great, I've been reading about the concept of idempotent
servers (I think it was Chad Fowler and others) where you deploy a server
once and it sort of becomes immutable so you don't upgrade it, change its
config once in production and in case you need some changes you create a
new one and destroy old ones.



On Wed, Apr 30, 2014 at 10:20 AM, Pedro Roque Marques <
pedro.r.marq...@gmail.com> wrote:

> Rohit,
>
> On Apr 29, 2014, at 12:07 PM, Rohit Yadav  wrote:
> > This looks great, Chiradeep can you share with us how the networking will
> > work in case of using systemvms in LXC containers, how it will
> communicate
> > with outside world and with other instances running in shared/separate
> LXC
> > containers.
>
> LXC networking can be configured to work just like a VM; one typically
> associates the LXC with a linux network namespace and uses a "veth" port
> instead of a "tap" interface.
>
> For examples of how configure OpenContrail to use netns see:
>  1. https://github.com/pedro-r-marques/opencontrail-netns; (no
> orchestration system)
>  2.
> https://github.com/pedro-r-marques/nova-docker/blob/opencontrail/novadocker/virt/docker/opencontrail.py;
> (openstack + docker).
>
> The same recipes can be used to configure bridged interfaces or OVS;
>
> In the case of using OpenContrail you get the added benefit that it
> integrates functionality such as "security-groups", dhcp, vpc support all
> in one... so you don't need to worry about ip-chains and L3 agents.
>
> > Will we need a loadbalancer (like nginx) for reverse proxying
> > and example or use case of a infra deployment.
>
> The OpenStack crowd typically implements the load balancer and external
> router (aka cloudstack domain router) as an app running inside a netns.
>
> > Lastly, will we have feature
> > of moving containers across machines and some distributed locking service
> > that the systemvms or agent may implement?
>
> The neat thing about containers is how fast they start (and how little
> overhead they have) compared to VMs. To move containers, just kill one and
> start the other;
>
>   Pedro.


About ServerResource

2014-04-30 Thread Silvano Buback
Guys,

I work at Globo, largest media company in Latin America, and we started
using Cloudstack to manage our cloud infrastructure. In order to do that,
we need to implement some plugins and one of these plugins is a plugin to
talk with our DNS API, which is basically a Rails Application with Http Api
that translates calls to our Bind Server.

Reading some talks and documents I understood that the call to an
external API needs to be placed in my own ServerResource
implementation (DNSApiServerResource class). So, when implementing my DNS
Provider, I'm using as model the example
"cloud-plugin-example-dns-notifier" and created a DNSApiServerResource to
make calls to DNSAPI.

The configuration and server for DNSAPI is the same for all zones,
so the problem is that by using this model I need to create one host entry
(related to my DNSAIServerResource) for each DNSAPI Provider enabled in
each zone, all of them with exactly the same configuration.

 An alternative is to call the API directly from the DNSAPIElement, but
I'm worried if it is a bad Cloudstack pattern to make calls to external
APIs without a ServerResource. We would like to share this implementation
with the community later on.

 If it's incorrect, which type of host would my DNSAPI be? The only
options are: Storage, Routing, SecondaryStorage,
SecondaryStorageCmdExecutor, ConsoleProxy, ExternalFirewall,
ExternalLoadBalancer, ExternalVirtualSwitchSupervisor, PxeServer,
BaremetalPxe, BaremetalDhcp, TrafficMonitor, ExternalDhcp,
SecondaryStorageVM, LocalSecondaryStorage, L2Networking.

Thank you in advance,

Silvano Buback


About ServerResource

2014-04-30 Thread Silvano Buback
Guys,

I work at Globo, largest media company in Latin America, and we started
using Cloudstack to manage our cloud infrastructure. In order to do that,
we need to implement some plugins and one of these plugins is a plugin to
talk with our DNS API, which is basically a Rails Application with Http Api
that translates calls to our Bind Server.

Reading some talks and documents I understood that the call to an
external API needs to be placed in my own ServerResource
implementation (DNSApiServerResource class). So, when implementing my DNS
Provider, I'm using as model the example
"cloud-plugin-example-dns-notifier" and created a DNSApiServerResource to
make calls to DNSAPI.

The configuration and server for DNSAPI is the same for all zones,
so the problem is that by using this model I need to create one host entry
(related to my DNSAIServerResource) for each DNSAPI Provider enabled in
each zone, all of them with exactly the same configuration.

 An alternative is to call the API directly from the DNSAPIElement, but
I'm worried if it is a bad Cloudstack pattern to make calls to external
APIs without a ServerResource. We would like to share this implementation
with the community later on.

 If it's incorrect, which type of host would my DNSAPI be? The only
options are: Storage, Routing, SecondaryStorage,
SecondaryStorageCmdExecutor, ConsoleProxy, ExternalFirewall,
ExternalLoadBalancer, ExternalVirtualSwitchSupervisor, PxeServer,
BaremetalPxe, BaremetalDhcp, TrafficMonitor, ExternalDhcp,
SecondaryStorageVM, LocalSecondaryStorage, L2Networking.

Thank you in advance,

Silvano Buback


Re: db deployment is failing in master branch

2014-04-30 Thread Amogh Vasekar
Submitted patch https://reviews.apache.org/r/20901/ for this.
Sorry for the issue

Amogh

On 4/30/14 3:22 AM, "Rajesh Battala"  wrote:

>I have figure out that root cause.
>Murali commit has committed the file with instance_ip column.
>(https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=09515
>1c98a45022b9759a45c066d8ec815de19e4)
>After that again Amogh commit is trying to create the same column.
>(https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=78c68
>3f5682560deffa405ac76edf23f8e17565d)
>
>769 ALTER TABLE `cloud`.`load_balancer_vm_map` ADD COLUMN instance_ip
>VARCHAR(40);
> 770 ALTER TABLE `cloud`.`load_balancer_vm_map` DROP KEY
>`load_balancer_id`, ADD UNIQUE KEY load_balancer_id (`load_balancer_id`,
>`instance_id`, `instance_ip`);
> 771 ALTER TABLE `cloud`.`vpc_offerings` ADD COLUMN
>supports_region_level_vpc boolean default false;
> 772 ALTER TABLE `cloud`.`network_offerings` ADD COLUMN
>supports_streched_l2 boolean default false;
> 773 ALTER TABLE `cloud`.`networks` ADD COLUMN streched_l2 boolean
>default false;
> 774 ALTER TABLE `cloud`.`vpc` ADD COLUMN region_level_vpc boolean
>default false;
> 775 INSERT INTO `cloud`.`configuration`(category, instance, component,
>name, value, description, default_value) VALUES ('Advanced', 'DEFAULT',
>'NetworkOrchestrationService', 'router.redundant.vrrp.interval', '1',
>'seconds between VRRP broadcast. It would 3 times broadcast fail to
>trigger fail-over mechanism of redundant router', '1') ON DUPLICATE KEY
>UPDATE category='Advanced';
> 776 INSERT INTO `cloud`.`configuration`(category, instance, component,
>name, value, description, default_value) VALUES ('Advanced', 'DEFAULT',
>'NetworkOrchestrationService', 'router.aggregation.command.each.timeout',
>'3', 'timeout in seconds for each Virtual Router command being
>aggregated. The final aggregation command timeout would be determined by
>this timeout * commands counts ', '3') ON DUPLICATE KEY UPDATE
>category='Advanced';
> 777 ALTER TABLE `cloud`.`load_balancer_vm_map` ADD COLUMN instance_ip
>VARCHAR(40);
> 778 ALTER TABLE `cloud`.`load_balancer_vm_map` DROP KEY
>`load_balancer_id`, ADD UNIQUE KEY load_balancer_id (`load_balancer_id`,
>`instance_id`, `instance_ip`)
>
>
>
>I can fix this issue and commit the changes.
>
>Thanks
>Rajesh Battala
>
>
>-Original Message-
>From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
>Sent: Wednesday, April 30, 2014 3:29 PM
>To: dev@cloudstack.apache.org
>Subject: db deployment is failing in master branch
>
>Hi All,
>
>Deploying DB on master branch is failing.
>
>> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
>[WARNING]
>java.lang.reflect.InvocationTargetException
>at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>at 
>sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
>57)
>at 
>sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorIm
>pl.java:43)
>at java.lang.reflect.Method.invoke(Method.java:601)
>at 
>org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:297)
>at java.lang.Thread.run(Thread.java:722)
>Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to
>upgrade the database
>at 
>com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.ja
>va:352)
>at 
>com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java
>:447)
>at 
>com.cloud.upgrade.DatabaseCreator.main(DatabaseCreator.java:222)
>... 6 more
>Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to
>execute upgrade script:
>/home/rajesh/hyperv/developer/target/db/db/schema-430to440.sql
>at 
>com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.
>java:267)
>at 
>com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.ja
>va:321)
>... 8 more
>Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException:
>Duplicate column name 'instance_ip'
>at 
>com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:193)
>at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
>at 
>com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.
>java:258)
>... 9 more
>
>
>Thanks
>Rajesh Battala



Review Request 20907: [PATCH] CLOUDSTACK-6552 Cloudstack-Management install package creates log directory that is never used

2014-04-30 Thread David Bierce

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20907/
---

Review request for cloudstack.


Summary (updated)
-

[PATCH] CLOUDSTACK-6552 Cloudstack-Management install package creates log 
directory that is never used


Bugs: CLOUDSTACK-6552
https://issues.apache.org/jira/browse/CLOUDSTACK-6552


Repository: cloudstack-git


Description (updated)
---

The RPM build cloud.spec creates a directory that is never used by cloudstack 
management and is just left as an empty directory name cloudstack-management in 
/var/log.


Diffs (updated)
-

  packaging/centos63/cloud.spec 83c598b 

Diff: https://reviews.apache.org/r/20907/diff/


Testing (updated)
---

Build RPMs on CentOS 6.4 and 6.5 using master

mvn clean install -Dnonoss -Dnoredist
package.sh -p noredist

Resulting packages installed on Centos 6.5 without the unused directory. 


Thanks,

David Bierce



Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management install package creates log directory that is never used

2014-04-30 Thread David Bierce

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20921/
---

Review request for cloudstack.


Bugs: CLOUDSTACK-6552
https://issues.apache.org/jira/browse/CLOUDSTACK-6552


Repository: cloudstack-git


Description
---

The RPM build cloud.spec creates a directory that is never used by cloudstack 
management and is just left as an empty directory name cloudstack-management in 
/var/log.


Diffs
-

  packaging/centos63/cloud.spec 83c598b 

Diff: https://reviews.apache.org/r/20921/diff/


Testing
---

Build RPMs on CentOS 6.4 and 6.5 using master

mvn clean install -Dnonoss -Dnoredist
package.sh -p noredist

Resulting packages installed on Centos 6.5 without the unused directory. 


Thanks,

David Bierce



Re: Review Request 20901: Remove accidentally added columns while resolving merge conflicts

2014-04-30 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20901/#review41888
---

Ship it!


Ship It!

- Nitin Mehta


On April 30, 2014, 5:50 p.m., Amogh Vasekar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20901/
> ---
> 
> (Updated April 30, 2014, 5:50 p.m.)
> 
> 
> Review request for cloudstack and Rajesh Battala.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Remove accidentally added columns while resolving merge conflicts
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-430to440.sql 711919e6b4605f4d9285a4eb2c75f10d52b81fd3 
> 
> Diff: https://reviews.apache.org/r/20901/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Amogh Vasekar
> 
>



Re: Review Request 19892: Add Juniper Contrail support to devCloud environment

2014-04-30 Thread Sachchidanand Vaidya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19892/
---

(Updated April 30, 2014, 4:15 p.m.)


Review request for cloudstack.


Changes
---

Thanks Daan. I have updated the diff based on latest code on Master. Also taken 
care of review comment.

Regards,
Sachin


Repository: cloudstack-git


Description
---

Add OpenContrail support to devCloud environment:
- Created new devcloud advanced networking config file 
(devcloud-advanced_juniper-contrail.cfg).
- Modification to deployDataCenter script, to enable 
"JuniperContrailRouter" &
  "JuniperContrailVpcRouter" providers.


Diffs (updated)
-

  tools/devcloud/devcloud-advanced_juniper-contrail.cfg PRE-CREATION 
  tools/marvin/marvin/deployDataCenter.py 31f663e 

Diff: https://reviews.apache.org/r/19892/diff/


Testing
---

Unit tested with devCloud2 and ACS4.3 code base.


Thanks,

Sachchidanand Vaidya



Re: schema upgrade in 4.4 not in master

2014-04-30 Thread Daan Hoogland
On Wed, Apr 30, 2014 at 6:44 PM, Sheng Yang  wrote:
> 4620c27ebf750c840b530d18fed7d8adf857e91


ok, I see. I had a conflict because the change was in a different
place then in 4.4. Sorry

-- 
Daan


Re: 4.4-forward: Management Server fails to start

2014-04-30 Thread Daan Hoogland
oops, will check in in a hurry (after a test run in master)

On Wed, Apr 30, 2014 at 8:10 PM, Prachi Damle  wrote:
> Created https://issues.apache.org/jira/browse/CLOUDSTACK-6549
>
> -Original Message-
> From: Min Chen [mailto:min.c...@citrix.com]
> Sent: Wednesday, April 30, 2014 11:01 AM
> To: dev@cloudstack.apache.org
> Cc: Daan Hoogland
> Subject: Re: 4.4-forward: Management Server fails to start
> Importance: High
>
> Yes, I see the same issue.
>
> Daan,
> I think that it is your commit 
> 3852afa717dc147ef9dc19d7b3801c341f321e77
> that broke it. You break NetworkACLItemCidrsDao out of NetworkACLItemDao, but 
> you forgot to add that into spring context xml file. You may need to add that 
> into 
> cloud-engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema
> -core-daos-context.xml.
>
> Thanks
> -min
>
> On 4/30/14 10:57 AM, "Prachi Damle"  wrote:
>
>>I synced to latest 4.4-forward and the server fails to start.
>>
>>Anyone seeing this?
>>
>>Thanks,
>>Prachi
>



-- 
Daan


Re: [ACS44]cherry pick CLOUDSTACK-6517

2014-04-30 Thread Daan Hoogland
On Wed, Apr 30, 2014 at 9:00 PM, Prachi Damle  wrote:
> e14c2ec7241ec2333ea3ac3d56a0e938fe1bf131


Prachi, your commit contains dos line endings:
-IAMPolicyPermissionVO permit =
_policyPermissionDao.findByPolicyAndEntity(iamPolicyId, entityType,
scope, scopeId, action, perm);
+IAMPolicyPermissionVO permit =
_policyPermissionDao.findByPolicyAndEntity(iamPolicyId, entityType,
scope,^M
+scopeId, action, perm, accessType);^M

Since I only saw them in java files I will let it pass but please
adjust your work environment to prevent the line endings to enter the
system. When they end up in configuration files or scripts things
might break inexplicably.

-- 
Daan