manually adding a vhd to secondary storage

2014-04-05 Thread chris snow
I've created a vhd using 'debootstrap' and 'xe vid-create / xe vdi-import'.

Is there a way that I can manually add my vhd to secondary storage
without using the admin UI?

My secondary storage looks like this:

/opt/storage/secondary/template/
└── tmpl
├── 1
│   ├── 1
│   │   ├── 774D7C32-EF42-48E5-A963-4C30C70C12F6.vhd
│   │   └── template.properties
│   ├── 2
│   │   ├── ae73e20a-0ec1-3fa2-a19d-f28268211bdc.vhd
│   │   └── template.properties
└── 2
├── 202
│   ├── 202-2-c447d7ca-7303-3211-9dd4-8a64a6dc8e67.iso
│   └── template.properties

What is the naming convention for the sub-folders of tmpl?
What do x and y represent in 'tmpl/x/y'?  At a guess x=1 is vhd's, x=2
is iso's  - is this correct? What about values for y - how are they
allocated?

For the template.properties - is there a definition somewhere for this
file, or do I need to look at some code to figure out how the values
are populated (e.g. checksum algorithm)?

   filename=29838623-89b9-350c-a03d-4da2cacdb5ae.vhd
   vhd=true
   id=5
   vhd.filename=29838623-89b9-350c-a03d-4da2cacdb5ae.vhd
   public=true
   uniquename=tiny Linux
   vhd.virtualsize=52428800
   virtualsize=52428800
   checksum=046e134e642e6d344b34648223ba4bc1
   hvm=false
   description=tiny Linux
   vhd.size=50430464
   size=50430464

Many thanks in advance,

Chris


Build failed in Jenkins: build-master-slowbuild #527

2014-04-05 Thread jenkins
See 

Changes:

[marcus] add conntrackd logrotate for systemvms, dont start conntrackd on 
logrotate if it isnt running

--
[...truncated 18147 lines...]

Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi ---
[INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/amazon/ec2/AmazonEC2SkeletonInterface.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/amazon/s3/AmazonS3SkeletonInterface.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SAcl.java.  Ensure this class was instrumented, and this 
data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SBucket.java.  Ensure this class was instrumented, and 
this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SHost.java.  Ensure this class was instrumented, and 
this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/BucketPolicyDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackAccountDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackConfigurationDao.java.  Ensure this 
class was instrumented, and this data file contains the instrumentation 
information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java.  Ensure this class 
was instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackUserDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MHostDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MHostMountDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultiPartPartsDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultiPartUploadsDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultipartMetaDao.java.  Ensure this class was 
instrumented, and this data file contains the in

Re: Review Request 19917: Improvements on exception handlers (JIRA-6242)

2014-04-05 Thread Daan Hoogland
H Ding,

I didn't mean for you to test it in a certain way. I was just curious
about what you did with the patch before you submitted it. Did you
start a cloud instance with it and try to hit any of the log messages
for instance. You explained the background of your effort and I am
curious as to how it satisfied your objectives.

I will let the patch rest a few days to see if we get any more
reactions and apply it from Denver next week.

On Sat, Apr 5, 2014 at 2:03 AM, Ding Yuan  wrote:
> HI Daan,
> I am not sure exactly how to monkey-test cloudstack, what I did was to do
> $ mvn test
> which shows "BUILD SUCCESS". I also did this:
> $ mvn clean install -P systemvm,developer
> which also succeeded.
>
> Is that what you mean? If not, please let me know what to do and I will 
> further test it.
> I will also work on assigning the proper reviewers now.
>
> Thanks,
> Ding
>
> On Apr 3, 2014, at 12:04 PM, Daan Hoogland  wrote:
>
>> thanks Ding,
>>
>> I saw your update. Did your run a cloud with this code; i.e. did you
>> monkey-test it?
>>
>> On Thu, Apr 3, 2014 at 5:26 PM, Ding Yuan  wrote:
>>> Oops, sorry I didn't publish my diff. I just published it on review board.
>>> Thanks for the comment Daan! Please let me know if I further need to 
>>> improve it.
>>>
>>> Ding
>>>
>>> On Apr 3, 2014, at 9:52 AM, Daan Hoogland  wrote:
>>>
 Ding,

 I think we can dare to do so in master as it will not see release for
 a while. We'll just have to be aware of the locations and be on alert
 for any stacktraces that will pass this list. I would not like to do
 this on the 4.4 branch even when it is an improvement of code quality
 as such. It might do things or prevent things from happening that we
 need done.

 I don't see a new version of the diff in the review request. Did you
 'Update' -> 'Upload Diff'?

 regards,
 Daan

 On Thu, Apr 3, 2014 at 12:34 AM, Ding Yuan  wrote:
> Uploaded a new patch to 19917. Changed the verbosity to debug, and 
> addressed
> Daan's comment on providing more distinctive text messages.
>
> Sorry that I haven't split them into smaller patches.
>
> Note in a few cases the original code was like:
>try {
>   pstmt = txn.prepareAutoCloseStatement(sql);
>   String gmtCutTime =
> DateUtil.getDateDisplayString(TimeZone.getTimeZone("GMT"), cutTime);
>   pstmt.setString(1, gmtCutTime);
>   pstmt.setString(2, gmtCutTime);
>
>   ResultSet rs = pstmt.executeQuery();
>   while (rs.next()) {
>   RunningHostCountInfo info = new RunningHostCountInfo();
>   info.setDcId(rs.getLong(1));
>   info.setHostType(rs.getString(2));
>   info.setCount(rs.getInt(3));
>
>   l.add(info);
>  }
>} catch (SQLException e) {
>} catch (Throwable e) {
>}
>
> The try block only throws SQLException as checked exception, and this code
> would also swallow any unchecked exceptions. I removed the catch 
> (Throwable)
> in these cases to avoid potentially swallowing any unexpected runtime
> exceptions. Please let me know if this is not desirable so I can further
> update.
>
> Thanks,
> Ding
>
> On Apr 2, 2014, at 5:17 PM, Ding Yuan  wrote:
>
> Thanks all for the quick comments!
> If i understand the discussion correctly, I will just change all the added
> log printing statements to debug verbosity. I will upload a new patch for
> that shortly.
>
> Now a bit back story: the reason we are doing this is that we recently did
> an analysis on many bugs collected from JIRA to understand why today's 
> cloud
> system fails. And we found that almost all of the cluster-wide failures 
> are
> caused by buggy exception handling, which would often turn a component
> failure into a cluster-wide one. One of the common bug pattern is ignoring
> some exceptions -- allowing them to propagate and finally turn into 
> disaster.
> Therefore we built a simple static checking tool just to check some simple
> rules for exception handling, such as if an exception is ignored.
> Admittedly, it would be much harder to reason about the potential
> consequences caused for ignoring a certain exception, that's why without
> much more domain knowledge I can only recommend to 1) avoid over-catching 
> an
> exception, especially when the handling logic will swallow it, and 2) log
> them, as what this patch does.
>
> Nevertheless, it seems the four cases I mentioned in JIRA-6242 are
> particularly suspicious. It might be worthwhile to double check their
> correctness if you have time. I am reposting them below.
>
> Thanks!
> Ding
>
> ===

Re: manually adding a vhd to secondary storage

2014-04-05 Thread giljae o
Hi Chrix,

The x is account id synced to id on account table
The y is template id synced to id on vm_template table.

James


On Sat, Apr 5, 2014 at 4:33 PM, chris snow  wrote:

> I've created a vhd using 'debootstrap' and 'xe vid-create / xe vdi-import'.
>
> Is there a way that I can manually add my vhd to secondary storage
> without using the admin UI?
>
> My secondary storage looks like this:
>
> /opt/storage/secondary/template/
> └── tmpl
> ├── 1
> │   ├── 1
> │   │   ├── 774D7C32-EF42-48E5-A963-4C30C70C12F6.vhd
> │   │   └── template.properties
> │   ├── 2
> │   │   ├── ae73e20a-0ec1-3fa2-a19d-f28268211bdc.vhd
> │   │   └── template.properties
> └── 2
> ├── 202
> │   ├── 202-2-c447d7ca-7303-3211-9dd4-8a64a6dc8e67.iso
> │   └── template.properties
>
> What is the naming convention for the sub-folders of tmpl?
> What do x and y represent in 'tmpl/x/y'?  At a guess x=1 is vhd's, x=2
> is iso's  - is this correct? What about values for y - how are they
> allocated?
>
> For the template.properties - is there a definition somewhere for this
> file, or do I need to look at some code to figure out how the values
> are populated (e.g. checksum algorithm)?
>
>filename=29838623-89b9-350c-a03d-4da2cacdb5ae.vhd
>vhd=true
>id=5
>vhd.filename=29838623-89b9-350c-a03d-4da2cacdb5ae.vhd
>public=true
>uniquename=tiny Linux
>vhd.virtualsize=52428800
>virtualsize=52428800
>checksum=046e134e642e6d344b34648223ba4bc1
>hvm=false
>description=tiny Linux
>vhd.size=50430464
>size=50430464
>
> Many thanks in advance,
>
> Chris
>


Jenkins build is back to normal : build-master-slowbuild #528

2014-04-05 Thread jenkins
See 



Re: Problem in set mac address in vif's

2014-04-05 Thread Rafael Weingartner
Hi all,

Rodrigo Works with me at our university's lab, he was trying to explain a
problem that we ran into, after an O.S upgrade that we did.

First of all I would like to say that I am sorry if I am bothering you
guys, since this is not a problem related to CS per se, but rather a
problem with the underlying structure. However, we know that in CS's dev
and users lists have high skilled and talented programmers and system
administrators, so It is worth a shot to describe our situation here.

The base system installed on the physical hosts is an Ubuntu Server 12.10,
with Xen hypervisor (4.1) packages and XCP (1.6). The CS version that we
have deployed is 4.1.1.

 As Rodrigo described, when we start the virtual router, the CS management
server creates its VM perfectly on the physical hosts. However, it never
presets it as running, it keeps showing state as starting. So, we logged
into the physical host to check out what was happening, we noticed that the
virtual router VM was running however it seemed that it was no responding
to ping. Looking at the syslog, we have found a message like this one:
"Failed to ip link set vif1.0 address fe:ff:ff:ff:ff:ff".  After the XCP
starts a VM it runs a script called ".../xen-api/scripts/vif", and it seems
that it is not running properly. We looked up at the script the command
that was failing, the command is the following:  "ip link set dev address
macAddress".

We tried to run that command manually "ip link set vif1.0 address
fe:ff:ff:ff:ff:f" and then we got the following error: RTNETLINK answers:
Operation not permitted. (Before, that command we ran "ip link set vif1.0
down"). We have tried to run the same command with some other interfaces
such as eth0, eth1, or even xenbr0, with them the command runs perfectly.

Have anyone seen anything like this before? Does anyone have any ideas how
to work this around?



On Fri, Apr 4, 2014 at 6:07 PM, Rodrigo Lopez
wrote:

> Hi, today i stumbled upon a problem. when i try to startup my virtual
> router the script on xen-api/scripts/vif don't finish his job, stoping in
> the line:
> ${IP} link set "${dev}" address "${address}"
> the complete code is:
> # ip link set vif1.0 address fe:ff:ff:ff:ff:ff
>
> this command don't run fine and return this error: RTNETLINK answers:
> Operation not permitted
>
> in the syslog i have this error: scripts-vif: Failed to ip link set
> vif4.1 address fe:ff:ff:ff:ff:ff
>
> I try run this cod to others interfaces and run perfectly.
>
> anyone have any ideia to help me?
>



-- 
Rafael Weingärtner


RE: Interesting 4.2.1. Issue...

2014-04-05 Thread Michael Phillips
Took about 2 days, but the heap space issue has re-occurred.
...sigh...
So switching to tomcat 6.0.33 had zero effect..
Anyone else have any ideas??


> Subject: RE: Interesting 4.2.1. Issue...
> From: a...@opencloud.net.au
> To: dev@cloudstack.apache.org
> Date: Fri, 4 Apr 2014 11:10:28 +0800
> 
> Thanks and thanks for sharing the steps
> 
> Kind Regards
> Amin 
> 
> -Original Message-
> From: Michael Phillips [mailto:mphilli7...@hotmail.com] 
> Sent: Friday, 4 April 2014 11:02 AM
> To: dev@cloudstack.apache.org
> Subject: RE: Interesting 4.2.1. Issue...
> 
> So I manually downloaded tomcat 6.0.33 
> herehttps://cwiki.apache.org/confluence/display/CLOUDSTACK/Setting+up+CloudStack+Development+Environment+on+Linux
> Then did the following1. extracted 6.0.33 to /usr/share/tomcat6.0.33. 2. 
> Changed symlink of /usr/share/cloudstack-managemet/bin  to 
> /usr/share/tomcat6.0.33/bin3. Changed symlink of 
> /usr/share/cloudstack-management/lib to /usr/share/tomcat6.0.33/lib4. 
> Verified cloudstack was running tomcat 6.0.33 by creating a 
> tomcat_version.jsp file in /usr/share/cloudstack-management/webapps/client
> code for tomcat_version.jsp can be found 
> herehttp://stackoverflow.com/questions/14925073/how-to-find-out-running-tomcat-version
> I'll definitely let you know how it goes...
> 
> > Subject: RE: Interesting 4.2.1. Issue...
> > From: a...@opencloud.net.au
> > To: dev@cloudstack.apache.org
> > Date: Fri, 4 Apr 2014 10:43:35 +0800
> > 
> > I tried but I failed to do so, each time cloudstack attempts to install to 
> > go fetches the 6.0.35 from the repo, maybe you have installed it after 
> > installing the cloudstack, if you managed to have a running cloudstack 
> > version above the 6.0.33 feedback with the results.
> > 
> > Kind Regards
> > Amin
> > 
> > -Original Message-
> > From: Michael Phillips [mailto:mphilli7...@hotmail.com]
> > Sent: Friday, 4 April 2014 10:41 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: Interesting 4.2.1. Issue...
> > 
> > So did you try changing your version of tomcat?
> > 
> > > Subject: RE: Interesting 4.2.1. Issue...
> > > From: a...@opencloud.net.au
> > > To: dev@cloudstack.apache.org
> > > Date: Fri, 4 Apr 2014 10:35:42 +0800
> > > 
> > > cd /usr/share/tomcat6/bin/
> > > ./version.sh
> > > 
> > > The output should be 6.0.33 instead of 6.0.35
> > > 
> > > Using CATALINA_BASE:   /usr/share/tomcat6
> > > Using CATALINA_HOME:   /usr/share/tomcat6
> > > Using CATALINA_TMPDIR: /usr/share/tomcat6/temp
> > > Using JRE_HOME:/usr
> > > Using CLASSPATH:   /usr/share/tomcat6/bin/bootstrap.jar
> > > Server version: Apache Tomcat/6.0.35
> > > Server built:   
> > > Server number:  6.0.35.0
> > > OS Name:Linux
> > > OS Version: 3.11.0-18-generic
> > > Architecture:   amd64
> > > JVM Version:1.6.0_30-b30
> > > JVM Vendor: Sun Microsystems Inc.
> > > 
> > > 
> > > Kind Regards
> > > Amin
> > > 
> > > 
> > > 
> > > -Original Message-
> > > From: Michael Phillips [mailto:mphilli7...@hotmail.com]
> > > Sent: Friday, 4 April 2014 10:31 AM
> > > To: dev@cloudstack.apache.org
> > > Subject: RE: Interesting 4.2.1. Issue...
> > > 
> > > I've put tomcat 6.0.33 on our mgmt servers. I'm going to monitor it for 
> > > the next few days to see if we get the error again.
> > > Do you know any way way to verify the version of tomcat that's running?
> > > 
> > > > Subject: RE: Interesting 4.2.1. Issue...
> > > > From: a...@opencloud.net.au
> > > > To: dev@cloudstack.apache.org
> > > > Date: Thu, 3 Apr 2014 10:35:29 +0800
> > > > 
> > > > No we didn't, it wouldn't matter because the memory would still 
> > > > fill up, the problem is it opens a thread and it fails to close it 
> > > > so whatever you will increase soon or later the memory will fill 
> > > > up (if I understand right)
> > > > 
> > > > The error in catalina is as follows:
> > > > 
> > > > SEVERE: The web application [/client] created a ThreadLocal with key of 
> > > > type [java.lang.ThreadLocal] (value [java.lang.ThreadLocal@1bd66d2d]) 
> > > > and a value of type [com.cloud.api.SerializationContext] (value 
> > > > [com.cloud.api.SerializationContext@2f6baed9]) but failed to remove it 
> > > > when the web application was stopped. This is very likely to create a 
> > > > memory leak.
> > > > 
> > > > If someone could help with this error generated in the catalina log, 
> > > > that would be much appreicated.
> > > > 
> > > > Kind Regards
> > > > Amin
> > > > 
> > > > 
> > > > 
> > > > 
> > > > -Original Message-
> > > > From: Michael Phillips [mailto:mphilli7...@hotmail.com]
> > > > Sent: Thursday, 3 April 2014 9:34 AM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: RE: Interesting 4.2.1. Issue...
> > > > 
> > > > A few other articles also mention setting the initial heap size "-Xms" 
> > > > to the same value as the heap size, to go ahead and fully commit the 
> > > > heap. Have you tried that?
> > > > One other thing I am curious of is have you fiddled 

Remove Mgmt Server

2014-04-05 Thread Michael Phillips
Hey dev guys, what's the proper way to remove a management server from a 
management server cluster?
I am referring to the actual management servers and not the hypervisors 
  

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

2014-04-05 Thread Alex Ough

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17790/
---

(Updated April 5, 2014, 9:31 p.m.)


Review request for cloudstack.


Changes
---

All done except #8 because
1. domainDao.findImmediateChildrenForParent() returns list of DomainVO not 
Domain
2. accountDao.findActiveAccountsForDomain() returns list of AccountVO not 
Account
3. userDao.listByAccount() returns list of UserVO not User

And I merged the patches because only the new patch has been changed.


Repository: cloudstack-git


Description
---

Currently, under the environment of cloudstack with multiple regions, each 
region has its own management server running with a separate database, which 
will cause data discrepancies when users create/update/delete 
domain/account/user data independently in each management server. So to support 
multiple regions and provide one point of entry for each customer, this 
implementation duplicates domain/account/user information of customers in one 
region to all of the regions independently whenever there is any change.

https://issues.apache.org/jira/browse/CLOUDSTACK-4992
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions


Diffs (updated)
-

  api/src/com/cloud/domain/Domain.java 365a705 
  api/src/com/cloud/event/EventTypes.java 39ef710 
  api/src/com/cloud/user/Account.java b912e51 
  api/src/com/cloud/user/AccountService.java 7e37b38 
  api/src/com/cloud/user/User.java 36e9028 
  api/src/com/cloud/user/UserAccount.java c5a0637 
  api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558 
  api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae 
  api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
f6743ba 
  api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
b08cbbb 
  api/src/org/apache/cloudstack/api/response/AccountResponse.java 2e50c51 
  api/src/org/apache/cloudstack/api/response/DomainResponse.java 0c0281e 
  api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
  api/src/org/apache/cloudstack/api/response/UserResponse.java 40e1561 
  api/src/org/apache/cloudstack/region/Region.java df64e44 
  api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
  api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
  client/pom.xml d8dbde7 
  
engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
 489b37d 
  engine/schema/src/com/cloud/domain/DomainVO.java f6494b3 
  engine/schema/src/com/cloud/rmap/RmapVO.java PRE-CREATION 
  engine/schema/src/com/cloud/rmap/dao/RmapDao.java PRE-CREATION 
  engine/schema/src/com/cloud/rmap/dao/RmapDaoImpl.java PRE-CREATION 
  engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
  engine/schema/src/com/cloud/user/UserAccountVO.java cef9239 
  engine/schema/src/com/cloud/user/UserVO.java 68879f6 
  engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
  framework/db/src/com/cloud/utils/db/Attribute.java 82c2bdb 
  framework/db/src/com/cloud/utils/db/GenericDao.java cb401cd 
  framework/db/src/com/cloud/utils/db/GenericDaoBase.java 2052aad 
  framework/db/src/com/cloud/utils/db/SqlGenerator.java befe34b 
  framework/db/test/com/cloud/utils/db/GenericDaoBaseTest.java aef0c69 
  framework/db/test/com/cloud/utils/db/SqlGeneratorTest.java PRE-CREATION 
  plugins/event-bus/multiregion/pom.xml PRE-CREATION 
  
plugins/event-bus/multiregion/resources/META-INF/cloudstack/spring-mom-multiregion-daos-context.xml
 PRE-CREATION 
  
plugins/event-bus/multiregion/resources/META-INF/cloudstack/system/spring-plugin-multiregion-system-context.xml
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/FullSyncer.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/InjectedCollection.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/MultiRegionEventBus.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/StringManipulator.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/AccountCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/BaseCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/DomainCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/UserCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/exception/APIFailureException.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/exception/InvalidDataException.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

2014-04-05 Thread Alex Ough

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17790/
---

(Updated April 6, 2014, 3:32 a.m.)


Review request for cloudstack.


Changes
---

I fixed a few minor bugs, so please discard the previous patch (diff r11).


Repository: cloudstack-git


Description
---

Currently, under the environment of cloudstack with multiple regions, each 
region has its own management server running with a separate database, which 
will cause data discrepancies when users create/update/delete 
domain/account/user data independently in each management server. So to support 
multiple regions and provide one point of entry for each customer, this 
implementation duplicates domain/account/user information of customers in one 
region to all of the regions independently whenever there is any change.

https://issues.apache.org/jira/browse/CLOUDSTACK-4992
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions


Diffs (updated)
-

  api/src/com/cloud/domain/Domain.java 365a705 
  api/src/com/cloud/event/EventTypes.java 39ef710 
  api/src/com/cloud/user/Account.java b912e51 
  api/src/com/cloud/user/AccountService.java 7e37b38 
  api/src/com/cloud/user/User.java 36e9028 
  api/src/com/cloud/user/UserAccount.java c5a0637 
  api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558 
  api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae 
  api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
f6743ba 
  api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
b08cbbb 
  api/src/org/apache/cloudstack/api/response/AccountResponse.java 2e50c51 
  api/src/org/apache/cloudstack/api/response/DomainResponse.java 0c0281e 
  api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
  api/src/org/apache/cloudstack/api/response/UserResponse.java 40e1561 
  api/src/org/apache/cloudstack/region/Region.java df64e44 
  api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
  api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
  client/pom.xml d8dbde7 
  
engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
 489b37d 
  engine/schema/src/com/cloud/domain/DomainVO.java f6494b3 
  engine/schema/src/com/cloud/rmap/RmapVO.java PRE-CREATION 
  engine/schema/src/com/cloud/rmap/dao/RmapDao.java PRE-CREATION 
  engine/schema/src/com/cloud/rmap/dao/RmapDaoImpl.java PRE-CREATION 
  engine/schema/src/com/cloud/user/AccountVO.java 0f5a044 
  engine/schema/src/com/cloud/user/UserAccountVO.java cef9239 
  engine/schema/src/com/cloud/user/UserVO.java 68879f6 
  engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
  framework/db/src/com/cloud/utils/db/Attribute.java 82c2bdb 
  framework/db/src/com/cloud/utils/db/GenericDao.java cb401cd 
  framework/db/src/com/cloud/utils/db/GenericDaoBase.java 2052aad 
  framework/db/src/com/cloud/utils/db/SqlGenerator.java befe34b 
  framework/db/test/com/cloud/utils/db/GenericDaoBaseTest.java aef0c69 
  framework/db/test/com/cloud/utils/db/SqlGeneratorTest.java PRE-CREATION 
  plugins/event-bus/multiregion/pom.xml PRE-CREATION 
  
plugins/event-bus/multiregion/resources/META-INF/cloudstack/spring-mom-multiregion-daos-context.xml
 PRE-CREATION 
  
plugins/event-bus/multiregion/resources/META-INF/cloudstack/system/spring-plugin-multiregion-system-context.xml
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/FullSyncer.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/InjectedCollection.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/MultiRegionEventBus.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/StringManipulator.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/AccountCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/BaseCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/DomainCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/UserCaller.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/exception/APIFailureException.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/exception/InvalidDataException.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/exception/UnsupportedException.java
 PRE-CREATION 
  
plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/service/AccountFullSyncProcessor.java
 PRE-CREATION 
  
plugins/event-bus/multir