Re: Review Request 16551: put the hard coded rdp server port in host deatils

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16551/#review31007
---



plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java


The rdp server port should be returned in details by the hyperv agent. You 
can update the agent to populate the port details in StartupCommand


- Devdeep Singh


On Jan. 1, 2014, 7:52 a.m., Anshul Gangwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16551/
> ---
> 
> (Updated Jan. 1, 2014, 7:52 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Donal Lafferty, and Rajesh 
> Battala.
> 
> 
> Bugs: CLOUDSTACK-5703
> https://issues.apache.org/jira/browse/CLOUDSTACK-5703
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This patch removes the hard coded value of rdp server port and put it in host 
> details
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java
>  2330da1 
>   server/src/com/cloud/servlet/ConsoleProxyServlet.java e0aaa6d 
> 
> Diff: https://reviews.apache.org/r/16551/diff/
> 
> 
> Testing
> ---
> 
> tested on my local setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 16550: fixed rdp console mouse patch

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16550/#review31008
---

Ship it!


Committed in a4d4d4b09aaff5b5606d1f9f58b2b80c92aee0a9

- Devdeep Singh


On Jan. 1, 2014, 7:45 a.m., Anshul Gangwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16550/
> ---
> 
> (Updated Jan. 1, 2014, 7:45 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Donal Lafferty, and Rajesh 
> Battala.
> 
> 
> Bugs: CLOUDSTACK-5702
> https://issues.apache.org/jira/browse/CLOUDSTACK-5702
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> this patch fixed the mouse events handling in rdp console
> 
> 
> Diffs
> -
> 
>   
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyRdpClient.java
>  73c00be 
> 
> Diff: https://reviews.apache.org/r/16550/diff/
> 
> 
> Testing
> ---
> 
> tested on my local setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 16551: put the hard coded rdp server port in host deatils

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16551/#review31009
---

Ship it!


Committed in e74889ac91c919ab26852da3d93133eaeae874c8

- Devdeep Singh


On Jan. 1, 2014, 7:52 a.m., Anshul Gangwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16551/
> ---
> 
> (Updated Jan. 1, 2014, 7:52 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Donal Lafferty, and Rajesh 
> Battala.
> 
> 
> Bugs: CLOUDSTACK-5703
> https://issues.apache.org/jira/browse/CLOUDSTACK-5703
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This patch removes the hard coded value of rdp server port and put it in host 
> details
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java
>  2330da1 
>   server/src/com/cloud/servlet/ConsoleProxyServlet.java e0aaa6d 
> 
> Diff: https://reviews.apache.org/r/16551/diff/
> 
> 
> Testing
> ---
> 
> tested on my local setup
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

RE: [VOTE] 3rd round of voting for ASF 4.2.1 RC

[Nux!]

On 31.12.2013 23:47, Edison Su wrote:

-Original Message-
From: Nux! [mailto:n...@li.nux.ro]
Sent: Monday, December 23, 2013 6:35 AM
To: dev@cloudstack.apache.org
Subject: Re: [VOTE] 3rd round of voting for ASF 4.2.1 RC

On 23.12.2013 05:42, Abhinandan Prateek wrote:
It gives me immense pleasure to inform that the vote to label this 
ASF

4.2.1 RC as the GA release has been passed with following stats:


Can someone check KVM volume snapshots before declaring this GA? It's
been consistently broken for me in 4.2.1-SNAPSHOT with NFS as well as
GlusterFS shared mount point.
It was working in 4.2.0 afaicr.


In the ACS release(since 4.0), KVM snapshot only works when CLVM is
used as primary storage, otherwise, taking snapshot in KVM will fail,
as there is no formal way to backup snapshot from primary storage to
secondary storage.


In https://issues.apache.org/jira/browse/CLOUDSTACK-5393 some people 
clearly used this feature with NFS, you must be referring to something 
else. Maybe "VM snapshots"?


--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

Re: ssh to ssvm

[金凯 马]

Ensure that command executed in management host.

SSH the "Link Local IP Address" of the System VM

XenServer/KVM Hypervisors using: /root/.ssh/id_rsa.cloud
ESXi Hypervisors using: /var/lib/cloudstack/management/.ssh/id_rsa


在 2014年1月1日，2:05，Yichi Lu  写道：

> Sanjeev Neelarapu  writes:
> 
>> Hi Yichi,
>> Try connecting to ssvm using id_rsa instead of id_rsa.cloud
>> 
>> -Sanjeev
> 
> # ssh -i /root/.ssh/id_rsa -p 3922 root@169.254.0.201
> Warning: Identity file /root/.ssh/id_rsa not accessible:
>  No such file or directory.
> Permission denied (publickey).
> 
> 

Re: networks and isolation/broadcast

[Daan Hoogland]

> While I've got your attention, what's the deal with isolation method vs 
> broadcast method? These are always set to the same thing as far as I've seen.

I've been asking this but haven't found the answer yet. There is an
overlap but both have some extra values the other hasn't.

I don't like either of your solutions but haven't got a good
alternative. Best would be to be able to set the isolation type on
each physical network on creation. The wizard and zone creation api
command would have to be extended and allow for vlan as default.

regards,

On Wed, Jan 1, 2014 at 8:53 AM, Marcus Sorensen  wrote:
> I suppose the answer might be to update the network with the proper
> isolation method when the traffic type is added. Look up the physical
> network's isolation method, grab network object for the public network, and
> set the right isolation.
> On Jan 1, 2014 12:46 AM, "Marcus Sorensen"  wrote:
>
>>   I ran into an issue today that I'm still trying to wrap my head
>> around, and I wanted to bounce this off of you guys. I have a physical
>> network whose isolation method is set to 'VXLAN' (v4.3+). I add my
>> Public traffic type to it. I'd assume that nics generated for public
>> traffic would have the standard vxlan://  URI for  isolation URI and
>> broadcast URI, but they just have a vlan://. Digging into it, it seems
>> that public traffic is hard-coded to BroadcastDomainType.Vlan. I fixed
>> this fairly easily for my testing, there were only a few places to
>> fix, by pulling the BroadcastDomainType from the network object rather
>> than hardcoding it, but that found another problem. This only works if
>> I change the broadcast type in the 'networks' mysql table by hand, as
>> during zone deployment the public network creation is also hard-coded
>> to vlan.
>>
>>   I'm not sure how to go about fixing this, since the Public, Control,
>> Management networks are created upon zone deployment, (see
>> createDefaultSystemNetworks). The immediate thing that jumped out was
>> a config variable for public isolation method, set prior to zone
>> deployment, or perhaps even one that overrides what's in the table.
>>
>>   While I've got your attention, what's the deal with isolation method
>> vs broadcast method? These are always set to the same thing as far as
>> I've seen.
>>

RE: [VOTE] 3rd round of voting for ASF 4.2.1 RC

[Nux!]

On 31.12.2013 19:48, Sudha Ponnaganti wrote:

Nux,

Defect 5393 [1]  is not reproducible in 4.3 so that got closed. Can
you open a new one for 4.2.1 with exact problem you are having.


Done.
https://issues.apache.org/jira/browse/CLOUDSTACK-5709

I have installed a new ACS today, single-host to keep things minimal, 
with the RPMs built from the 21Dec github. Same problem occurs 
consistently.


HTH
Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

Re: networks and isolation/broadcast

[Marcus Sorensen]

That's just it. The isolation type *is* provided when creating
physical network. If I create a physical network with isolation type
'VXLAN', and then add traffic type of 'Public', it doesn't obey it.
There's physical_networks and networks, when the zone is created, an
entry goes in network that is Public/Vlan, hardcoded. The Public
traffic type uses this, regardless of what the physical_network its
being added to says. So if we updated the the public network table row
with the correct isolation method for that physical network we are
adding traffic type to when we add the public traffic type, that would
work. It's worth noting that a zone can only have one physical network
with traffic type of public.

On Wed, Jan 1, 2014 at 12:37 PM, Daan Hoogland  wrote:
>> While I've got your attention, what's the deal with isolation method vs 
>> broadcast method? These are always set to the same thing as far as I've seen.
>
> I've been asking this but haven't found the answer yet. There is an
> overlap but both have some extra values the other hasn't.
>
> I don't like either of your solutions but haven't got a good
> alternative. Best would be to be able to set the isolation type on
> each physical network on creation. The wizard and zone creation api
> command would have to be extended and allow for vlan as default.
>
> regards,
>
> On Wed, Jan 1, 2014 at 8:53 AM, Marcus Sorensen  wrote:
>> I suppose the answer might be to update the network with the proper
>> isolation method when the traffic type is added. Look up the physical
>> network's isolation method, grab network object for the public network, and
>> set the right isolation.
>> On Jan 1, 2014 12:46 AM, "Marcus Sorensen"  wrote:
>>
>>>   I ran into an issue today that I'm still trying to wrap my head
>>> around, and I wanted to bounce this off of you guys. I have a physical
>>> network whose isolation method is set to 'VXLAN' (v4.3+). I add my
>>> Public traffic type to it. I'd assume that nics generated for public
>>> traffic would have the standard vxlan://  URI for  isolation URI and
>>> broadcast URI, but they just have a vlan://. Digging into it, it seems
>>> that public traffic is hard-coded to BroadcastDomainType.Vlan. I fixed
>>> this fairly easily for my testing, there were only a few places to
>>> fix, by pulling the BroadcastDomainType from the network object rather
>>> than hardcoding it, but that found another problem. This only works if
>>> I change the broadcast type in the 'networks' mysql table by hand, as
>>> during zone deployment the public network creation is also hard-coded
>>> to vlan.
>>>
>>>   I'm not sure how to go about fixing this, since the Public, Control,
>>> Management networks are created upon zone deployment, (see
>>> createDefaultSystemNetworks). The immediate thing that jumped out was
>>> a config variable for public isolation method, set prior to zone
>>> deployment, or perhaps even one that overrides what's in the table.
>>>
>>>   While I've got your attention, what's the deal with isolation method
>>> vs broadcast method? These are always set to the same thing as far as
>>> I've seen.
>>>

Re: networks and isolation/broadcast

[Mike Tutkowski]

Hey guys,

The NPE I saw last night was related to "isolation id." Is it possible this
NPE is related to something new that was put that you are talking about
here?

Thank!

ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2:ctx-ae5d80b2
ctx-5c12c4d9) unhandled exception executing api command: createVlanIpRange
java.lang.NullPointerException
at com.cloud.utils.net.NetUtils.isSameIsolationId(NetUtils.java:1419)
at com.cloud.configuration.ConfigurationManagerImpl.
createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2474)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(
NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(
DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:616)
at org.springframework.aop.support.AopUtils.
invokeJoinpointUsingReflection(AopUtils.java:317)
at org.springframework.aop.framework.ReflectiveMethodInvocation.
invokeJoinpoint(ReflectiveMethodInvocation.java:183)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
ReflectiveMethodInvocation.java:150)
at com.cloud.event.ActionEventInterceptor.invoke(
ActionEventInterceptor.java:50)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
ReflectiveMethodInvocation.java:161)
at org.springframework.aop.interceptor.ExposeInvocationInterceptor.
invoke(ExposeInvocationInterceptor.java:91)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
ReflectiveMethodInvocation.java:172)
at org.springframework.aop.framework.JdkDynamicAopProxy.
invoke(JdkDynamicAopProxy.java:204)
at sun.proxy.$Proxy96.createVlanAndPublicIpRange(Unknown Source)
at org.apache.cloudstack.api.command.admin.vlan.
CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:211)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:161)
at com.cloud.api.ApiServer.queueCommand(ApiServer.java:530)
at com.cloud.api.ApiServer.handleRequest(ApiServer.java:373)
at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:322)
at com.cloud.api.ApiServlet.access$000(ApiServlet.java:52)
at com.cloud.api.ApiServlet$1.run(ApiServlet.java:114)
at org.apache.cloudstack.managed.context.impl.
DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
callWithContext(DefaultManagedContext.java:103)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
runWithContext(DefaultManagedContext.java:53)
at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:111)


On Wed, Jan 1, 2014 at 2:33 PM, Marcus Sorensen  wrote:

> That's just it. The isolation type *is* provided when creating
> physical network. If I create a physical network with isolation type
> 'VXLAN', and then add traffic type of 'Public', it doesn't obey it.
> There's physical_networks and networks, when the zone is created, an
> entry goes in network that is Public/Vlan, hardcoded. The Public
> traffic type uses this, regardless of what the physical_network its
> being added to says. So if we updated the the public network table row
> with the correct isolation method for that physical network we are
> adding traffic type to when we add the public traffic type, that would
> work. It's worth noting that a zone can only have one physical network
> with traffic type of public.
>
> On Wed, Jan 1, 2014 at 12:37 PM, Daan Hoogland 
> wrote:
> >> While I've got your attention, what's the deal with isolation method vs
> broadcast method? These are always set to the same thing as far as I've
> seen.
> >
> > I've been asking this but haven't found the answer yet. There is an
> > overlap but both have some extra values the other hasn't.
> >
> > I don't like either of your solutions but haven't got a good
> > alternative. Best would be to be able to set the isolation type on
> > each physical network on creation. The wizard and zone creation api
> > command would have to be extended and allow for vlan as default.
> >
> > regards,
> >
> > On Wed, Jan 1, 2014 at 8:53 AM, Marcus Sorensen 
> wrote:
> >> I suppose the answer might be to update the network with the proper
> >> isolation method when the traffic type is added. Look up the physical
> >> network's isolation method, grab network object for the public network,
> and
> >> set the right isolation.
> >> On Jan 1, 2014 12:46 AM, "Marcus Sorensen"  wrote:
> >>
> >>>   I ran into an issue today that I'm still trying to wrap my head
> >>> around, and I wanted to bounce this off of you guys. I have a physical
> >>> network whose isolation method is set to 'VXLAN' (v4.3+). I add my
> >>> Public traffic type to it. I'd assume that nics generated for public
> >>> traffic would have the standard vxlan://  URI for  isolation URI and
> >>> broadcast URI, but they just have a vlan://. Digging into it, it seems
> >>> that pu

Re: networks and isolation/broadcast

[Marcus Sorensen]

Which branch? I see these in master, you can check out the commit just
before these and see if it helps:

commit b477e4e830597100f0c0171dd8e56f4033bd07aa
Author: Daan Hoogland 
Date:   Tue Dec 31 12:52:51 2013 +0100

some xtra cases

commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
Author: Daan Hoogland 
Date:   Tue Dec 31 12:25:17 2013 +0100

isSameIsolationId

commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
Author: Daan Hoogland 
Date:   Fri Dec 20 16:47:58 2013 +0100

check vlans and other isolation types

commit d50517e931e68daef6735bd18273499fee0d4649
Author: Sateesh Chodapuneedi 
Date:   Tue Dec 31 07:16:35 2013 +0530

I also have a commit just after these, but it was pretty minor and
only to KVM agent code.

On Wed, Jan 1, 2014 at 3:27 PM, Mike Tutkowski
 wrote:
> Hey guys,
>
> The NPE I saw last night was related to "isolation id." Is it possible this
> NPE is related to something new that was put that you are talking about
> here?
>
> Thank!
>
> ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2:ctx-ae5d80b2
> ctx-5c12c4d9) unhandled exception executing api command: createVlanIpRange
> java.lang.NullPointerException
> at com.cloud.utils.net.NetUtils.isSameIsolationId(NetUtils.java:1419)
> at com.cloud.configuration.ConfigurationManagerImpl.
> createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2474)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(
> NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:616)
> at org.springframework.aop.support.AopUtils.
> invokeJoinpointUsingReflection(AopUtils.java:317)
> at org.springframework.aop.framework.ReflectiveMethodInvocation.
> invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> ReflectiveMethodInvocation.java:150)
> at com.cloud.event.ActionEventInterceptor.invoke(
> ActionEventInterceptor.java:50)
> at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> ReflectiveMethodInvocation.java:161)
> at org.springframework.aop.interceptor.ExposeInvocationInterceptor.
> invoke(ExposeInvocationInterceptor.java:91)
> at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> ReflectiveMethodInvocation.java:172)
> at org.springframework.aop.framework.JdkDynamicAopProxy.
> invoke(JdkDynamicAopProxy.java:204)
> at sun.proxy.$Proxy96.createVlanAndPublicIpRange(Unknown Source)
> at org.apache.cloudstack.api.command.admin.vlan.
> CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:211)
> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:161)
> at com.cloud.api.ApiServer.queueCommand(ApiServer.java:530)
> at com.cloud.api.ApiServer.handleRequest(ApiServer.java:373)
> at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:322)
> at com.cloud.api.ApiServlet.access$000(ApiServlet.java:52)
> at com.cloud.api.ApiServlet$1.run(ApiServlet.java:114)
> at org.apache.cloudstack.managed.context.impl.
> DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
> callWithContext(DefaultManagedContext.java:103)
> at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
> runWithContext(DefaultManagedContext.java:53)
> at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:111)
>
>
> On Wed, Jan 1, 2014 at 2:33 PM, Marcus Sorensen  wrote:
>
>> That's just it. The isolation type *is* provided when creating
>> physical network. If I create a physical network with isolation type
>> 'VXLAN', and then add traffic type of 'Public', it doesn't obey it.
>> There's physical_networks and networks, when the zone is created, an
>> entry goes in network that is Public/Vlan, hardcoded. The Public
>> traffic type uses this, regardless of what the physical_network its
>> being added to says. So if we updated the the public network table row
>> with the correct isolation method for that physical network we are
>> adding traffic type to when we add the public traffic type, that would
>> work. It's worth noting that a zone can only have one physical network
>> with traffic type of public.
>>
>> On Wed, Jan 1, 2014 at 12:37 PM, Daan Hoogland 
>> wrote:
>> >> While I've got your attention, what's the deal with isolation method vs
>> broadcast method? These are always set to the same thing as far as I've
>> seen.
>> >
>> > I've been asking this but haven't found the answer yet. There is an
>> > overlap but both have some extra values the other hasn't.
>> >
>> > I don't like either of your solutions but haven't got a good
>> > alternative. Best would be to be able to set the isolation type on
>> > each physical network on creation. The wizard and zone creation api
>> > command wo

Re: networks and isolation/broadcast

[Mike Tutkowski]

This is in 4.3.

I know the file is NetUtils, but I'm not sure in Git how to look at the
history of a particular file like I could do in SVN.


On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen  wrote:

> Which branch? I see these in master, you can check out the commit just
> before these and see if it helps:
>
> commit b477e4e830597100f0c0171dd8e56f4033bd07aa
> Author: Daan Hoogland 
> Date:   Tue Dec 31 12:52:51 2013 +0100
>
> some xtra cases
>
> commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
> Author: Daan Hoogland 
> Date:   Tue Dec 31 12:25:17 2013 +0100
>
> isSameIsolationId
>
> commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
> Author: Daan Hoogland 
> Date:   Fri Dec 20 16:47:58 2013 +0100
>
> check vlans and other isolation types
>
> commit d50517e931e68daef6735bd18273499fee0d4649
> Author: Sateesh Chodapuneedi 
> Date:   Tue Dec 31 07:16:35 2013 +0530
>
> I also have a commit just after these, but it was pretty minor and
> only to KVM agent code.
>
> On Wed, Jan 1, 2014 at 3:27 PM, Mike Tutkowski
>  wrote:
> > Hey guys,
> >
> > The NPE I saw last night was related to "isolation id." Is it possible
> this
> > NPE is related to something new that was put that you are talking about
> > here?
> >
> > Thank!
> >
> > ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2:ctx-ae5d80b2
> > ctx-5c12c4d9) unhandled exception executing api command:
> createVlanIpRange
> > java.lang.NullPointerException
> > at com.cloud.utils.net.NetUtils.isSameIsolationId(NetUtils.java:1419)
> > at com.cloud.configuration.ConfigurationManagerImpl.
> > createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2474)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at sun.reflect.NativeMethodAccessorImpl.invoke(
> > NativeMethodAccessorImpl.java:57)
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> > DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:616)
> > at org.springframework.aop.support.AopUtils.
> > invokeJoinpointUsingReflection(AopUtils.java:317)
> > at org.springframework.aop.framework.ReflectiveMethodInvocation.
> > invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> > at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> > ReflectiveMethodInvocation.java:150)
> > at com.cloud.event.ActionEventInterceptor.invoke(
> > ActionEventInterceptor.java:50)
> > at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> > ReflectiveMethodInvocation.java:161)
> > at org.springframework.aop.interceptor.ExposeInvocationInterceptor.
> > invoke(ExposeInvocationInterceptor.java:91)
> > at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> > ReflectiveMethodInvocation.java:172)
> > at org.springframework.aop.framework.JdkDynamicAopProxy.
> > invoke(JdkDynamicAopProxy.java:204)
> > at sun.proxy.$Proxy96.createVlanAndPublicIpRange(Unknown Source)
> > at org.apache.cloudstack.api.command.admin.vlan.
> > CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:211)
> > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:161)
> > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:530)
> > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:373)
> > at
> com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:322)
> > at com.cloud.api.ApiServlet.access$000(ApiServlet.java:52)
> > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:114)
> > at org.apache.cloudstack.managed.context.impl.
> > DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> > at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
> > callWithContext(DefaultManagedContext.java:103)
> > at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
> > runWithContext(DefaultManagedContext.java:53)
> > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:111)
> >
> >
> > On Wed, Jan 1, 2014 at 2:33 PM, Marcus Sorensen 
> wrote:
> >
> >> That's just it. The isolation type *is* provided when creating
> >> physical network. If I create a physical network with isolation type
> >> 'VXLAN', and then add traffic type of 'Public', it doesn't obey it.
> >> There's physical_networks and networks, when the zone is created, an
> >> entry goes in network that is Public/Vlan, hardcoded. The Public
> >> traffic type uses this, regardless of what the physical_network its
> >> being added to says. So if we updated the the public network table row
> >> with the correct isolation method for that physical network we are
> >> adding traffic type to when we add the public traffic type, that would
> >> work. It's worth noting that a zone can only have one physical network
> >> with traffic type of public.
> >>
> >> On Wed, Jan 1, 2014 at 12:37 PM, Daan Hoogland  >
> >> wrote:
> >> >> While I've got your attention, what's the deal with isolation method
> vs
> >> broadcast method? These are always set 

Re: networks and isolation/broadcast

[Marcus Sorensen]

You can do "git blame (file)" and it will show you each line and the
commit. You can also do a git log on the file.  The issue may not be as
obvious as that, though, there may be something totally unrelated causing
that object to end up null in this code. Or it may be specific to your
setup, some obscure bug nobody else is hitting.
On Jan 1, 2014 4:22 PM, "Mike Tutkowski" 
wrote:

> This is in 4.3.
>
> I know the file is NetUtils, but I'm not sure in Git how to look at the
> history of a particular file like I could do in SVN.
>
>
> On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen 
> wrote:
>
> > Which branch? I see these in master, you can check out the commit just
> > before these and see if it helps:
> >
> > commit b477e4e830597100f0c0171dd8e56f4033bd07aa
> > Author: Daan Hoogland 
> > Date:   Tue Dec 31 12:52:51 2013 +0100
> >
> > some xtra cases
> >
> > commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
> > Author: Daan Hoogland 
> > Date:   Tue Dec 31 12:25:17 2013 +0100
> >
> > isSameIsolationId
> >
> > commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
> > Author: Daan Hoogland 
> > Date:   Fri Dec 20 16:47:58 2013 +0100
> >
> > check vlans and other isolation types
> >
> > commit d50517e931e68daef6735bd18273499fee0d4649
> > Author: Sateesh Chodapuneedi 
> > Date:   Tue Dec 31 07:16:35 2013 +0530
> >
> > I also have a commit just after these, but it was pretty minor and
> > only to KVM agent code.
> >
> > On Wed, Jan 1, 2014 at 3:27 PM, Mike Tutkowski
> >  wrote:
> > > Hey guys,
> > >
> > > The NPE I saw last night was related to "isolation id." Is it possible
> > this
> > > NPE is related to something new that was put that you are talking about
> > > here?
> > >
> > > Thank!
> > >
> > > ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2:ctx-ae5d80b2
> > > ctx-5c12c4d9) unhandled exception executing api command:
> > createVlanIpRange
> > > java.lang.NullPointerException
> > > at
> com.cloud.utils.net.NetUtils.isSameIsolationId(NetUtils.java:1419)
> > > at com.cloud.configuration.ConfigurationManagerImpl.
> > > createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2474)
> > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > > at sun.reflect.NativeMethodAccessorImpl.invoke(
> > > NativeMethodAccessorImpl.java:57)
> > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> > > DelegatingMethodAccessorImpl.java:43)
> > > at java.lang.reflect.Method.invoke(Method.java:616)
> > > at org.springframework.aop.support.AopUtils.
> > > invokeJoinpointUsingReflection(AopUtils.java:317)
> > > at org.springframework.aop.framework.ReflectiveMethodInvocation.
> > > invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> > > at
> > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> > > ReflectiveMethodInvocation.java:150)
> > > at com.cloud.event.ActionEventInterceptor.invoke(
> > > ActionEventInterceptor.java:50)
> > > at
> > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> > > ReflectiveMethodInvocation.java:161)
> > > at org.springframework.aop.interceptor.ExposeInvocationInterceptor.
> > > invoke(ExposeInvocationInterceptor.java:91)
> > > at
> > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> > > ReflectiveMethodInvocation.java:172)
> > > at org.springframework.aop.framework.JdkDynamicAopProxy.
> > > invoke(JdkDynamicAopProxy.java:204)
> > > at sun.proxy.$Proxy96.createVlanAndPublicIpRange(Unknown Source)
> > > at org.apache.cloudstack.api.command.admin.vlan.
> > > CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:211)
> > > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:161)
> > > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:530)
> > > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:373)
> > > at
> > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:322)
> > > at com.cloud.api.ApiServlet.access$000(ApiServlet.java:52)
> > > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:114)
> > > at org.apache.cloudstack.managed.context.impl.
> > > DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> > > at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
> > > callWithContext(DefaultManagedContext.java:103)
> > > at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.
> > > runWithContext(DefaultManagedContext.java:53)
> > > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:111)
> > >
> > >
> > > On Wed, Jan 1, 2014 at 2:33 PM, Marcus Sorensen 
> > wrote:
> > >
> > >> That's just it. The isolation type *is* provided when creating
> > >> physical network. If I create a physical network with isolation type
> > >> 'VXLAN', and then add traffic type of 'Public', it doesn't obey it.
> > >> There's physical_networks and networks, when the zone is created, an
> > >> entry goes in network that is Public/Vlan, hardcoded. The Public
> > >

Re: networks and isolation/broadcast

[Mike Tutkowski]

Yeah, in my case I'm just setting up a basic zone with a XenServer host.

The code in NetUtils checks for null or "" on the variable in question
that's passed in. However, in a certain case, null for that variable can
slip by and lead to a NPE.

if ((one == null || one.equals(""))

&&

(other == null || other.equals("")))

{

return true;

}

if other == null, this will not catch it and it can throw a NPE later.


On Wed, Jan 1, 2014 at 9:51 PM, Marcus Sorensen  wrote:

> You can do "git blame (file)" and it will show you each line and the
> commit. You can also do a git log on the file.  The issue may not be as
> obvious as that, though, there may be something totally unrelated causing
> that object to end up null in this code. Or it may be specific to your
> setup, some obscure bug nobody else is hitting.
> On Jan 1, 2014 4:22 PM, "Mike Tutkowski" 
> wrote:
>
> > This is in 4.3.
> >
> > I know the file is NetUtils, but I'm not sure in Git how to look at the
> > history of a particular file like I could do in SVN.
> >
> >
> > On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen 
> > wrote:
> >
> > > Which branch? I see these in master, you can check out the commit just
> > > before these and see if it helps:
> > >
> > > commit b477e4e830597100f0c0171dd8e56f4033bd07aa
> > > Author: Daan Hoogland 
> > > Date:   Tue Dec 31 12:52:51 2013 +0100
> > >
> > > some xtra cases
> > >
> > > commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
> > > Author: Daan Hoogland 
> > > Date:   Tue Dec 31 12:25:17 2013 +0100
> > >
> > > isSameIsolationId
> > >
> > > commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
> > > Author: Daan Hoogland 
> > > Date:   Fri Dec 20 16:47:58 2013 +0100
> > >
> > > check vlans and other isolation types
> > >
> > > commit d50517e931e68daef6735bd18273499fee0d4649
> > > Author: Sateesh Chodapuneedi 
> > > Date:   Tue Dec 31 07:16:35 2013 +0530
> > >
> > > I also have a commit just after these, but it was pretty minor and
> > > only to KVM agent code.
> > >
> > > On Wed, Jan 1, 2014 at 3:27 PM, Mike Tutkowski
> > >  wrote:
> > > > Hey guys,
> > > >
> > > > The NPE I saw last night was related to "isolation id." Is it
> possible
> > > this
> > > > NPE is related to something new that was put that you are talking
> about
> > > > here?
> > > >
> > > > Thank!
> > > >
> > > > ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2:ctx-ae5d80b2
> > > > ctx-5c12c4d9) unhandled exception executing api command:
> > > createVlanIpRange
> > > > java.lang.NullPointerException
> > > > at
> > com.cloud.utils.net.NetUtils.isSameIsolationId(NetUtils.java:1419)
> > > > at com.cloud.configuration.ConfigurationManagerImpl.
> > > > createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2474)
> > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > > > at sun.reflect.NativeMethodAccessorImpl.invoke(
> > > > NativeMethodAccessorImpl.java:57)
> > > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> > > > DelegatingMethodAccessorImpl.java:43)
> > > > at java.lang.reflect.Method.invoke(Method.java:616)
> > > > at org.springframework.aop.support.AopUtils.
> > > > invokeJoinpointUsingReflection(AopUtils.java:317)
> > > > at org.springframework.aop.framework.ReflectiveMethodInvocation.
> > > > invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> > > > at
> > > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> > > > ReflectiveMethodInvocation.java:150)
> > > > at com.cloud.event.ActionEventInterceptor.invoke(
> > > > ActionEventInterceptor.java:50)
> > > > at
> > > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> > > > ReflectiveMethodInvocation.java:161)
> > > > at
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.
> > > > invoke(ExposeInvocationInterceptor.java:91)
> > > > at
> > > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> > > > ReflectiveMethodInvocation.java:172)
> > > > at org.springframework.aop.framework.JdkDynamicAopProxy.
> > > > invoke(JdkDynamicAopProxy.java:204)
> > > > at sun.proxy.$Proxy96.createVlanAndPublicIpRange(Unknown Source)
> > > > at org.apache.cloudstack.api.command.admin.vlan.
> > > > CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:211)
> > > > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:161)
> > > > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:530)
> > > > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:373)
> > > > at
> > > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:322)
> > > > at com.cloud.api.ApiServlet.access$000(ApiServlet.java:52)
> > > > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:114)
> > > > at org.apache.cloudstack.managed.context.impl.
> > > > DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> > > > at
> > org.apache.cloudstack.managed.c

Re: networks and isolation/broadcast

[Mike Tutkowski]

I should say this check doesn't have to catch it...it might, but it doesn't
have to (depends on the value of one).


On Wed, Jan 1, 2014 at 9:59 PM, Mike Tutkowski  wrote:

> Yeah, in my case I'm just setting up a basic zone with a XenServer host.
>
> The code in NetUtils checks for null or "" on the variable in question
> that's passed in. However, in a certain case, null for that variable can
> slip by and lead to a NPE.
>
> if ((one == null || one.equals(""))
>
> &&
>
> (other == null || other.equals("")))
>
> {
>
> return true;
>
> }
>
> if other == null, this will not catch it and it can throw a NPE later.
>
>
> On Wed, Jan 1, 2014 at 9:51 PM, Marcus Sorensen wrote:
>
>> You can do "git blame (file)" and it will show you each line and the
>> commit. You can also do a git log on the file.  The issue may not be as
>> obvious as that, though, there may be something totally unrelated causing
>> that object to end up null in this code. Or it may be specific to your
>> setup, some obscure bug nobody else is hitting.
>> On Jan 1, 2014 4:22 PM, "Mike Tutkowski" 
>> wrote:
>>
>> > This is in 4.3.
>> >
>> > I know the file is NetUtils, but I'm not sure in Git how to look at the
>> > history of a particular file like I could do in SVN.
>> >
>> >
>> > On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen 
>> > wrote:
>> >
>> > > Which branch? I see these in master, you can check out the commit just
>> > > before these and see if it helps:
>> > >
>> > > commit b477e4e830597100f0c0171dd8e56f4033bd07aa
>> > > Author: Daan Hoogland 
>> > > Date:   Tue Dec 31 12:52:51 2013 +0100
>> > >
>> > > some xtra cases
>> > >
>> > > commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
>> > > Author: Daan Hoogland 
>> > > Date:   Tue Dec 31 12:25:17 2013 +0100
>> > >
>> > > isSameIsolationId
>> > >
>> > > commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
>> > > Author: Daan Hoogland 
>> > > Date:   Fri Dec 20 16:47:58 2013 +0100
>> > >
>> > > check vlans and other isolation types
>> > >
>> > > commit d50517e931e68daef6735bd18273499fee0d4649
>> > > Author: Sateesh Chodapuneedi 
>> > > Date:   Tue Dec 31 07:16:35 2013 +0530
>> > >
>> > > I also have a commit just after these, but it was pretty minor and
>> > > only to KVM agent code.
>> > >
>> > > On Wed, Jan 1, 2014 at 3:27 PM, Mike Tutkowski
>> > >  wrote:
>> > > > Hey guys,
>> > > >
>> > > > The NPE I saw last night was related to "isolation id." Is it
>> possible
>> > > this
>> > > > NPE is related to something new that was put that you are talking
>> about
>> > > > here?
>> > > >
>> > > > Thank!
>> > > >
>> > > > ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2:ctx-ae5d80b2
>> > > > ctx-5c12c4d9) unhandled exception executing api command:
>> > > createVlanIpRange
>> > > > java.lang.NullPointerException
>> > > > at
>> > com.cloud.utils.net.NetUtils.isSameIsolationId(NetUtils.java:1419)
>> > > > at com.cloud.configuration.ConfigurationManagerImpl.
>> > > > createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2474)
>> > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> > > > at sun.reflect.NativeMethodAccessorImpl.invoke(
>> > > > NativeMethodAccessorImpl.java:57)
>> > > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(
>> > > > DelegatingMethodAccessorImpl.java:43)
>> > > > at java.lang.reflect.Method.invoke(Method.java:616)
>> > > > at org.springframework.aop.support.AopUtils.
>> > > > invokeJoinpointUsingReflection(AopUtils.java:317)
>> > > > at org.springframework.aop.framework.ReflectiveMethodInvocation.
>> > > > invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>> > > > at
>> > > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
>> > > > ReflectiveMethodInvocation.java:150)
>> > > > at com.cloud.event.ActionEventInterceptor.invoke(
>> > > > ActionEventInterceptor.java:50)
>> > > > at
>> > > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
>> > > > ReflectiveMethodInvocation.java:161)
>> > > > at
>> org.springframework.aop.interceptor.ExposeInvocationInterceptor.
>> > > > invoke(ExposeInvocationInterceptor.java:91)
>> > > > at
>> > > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
>> > > > ReflectiveMethodInvocation.java:172)
>> > > > at org.springframework.aop.framework.JdkDynamicAopProxy.
>> > > > invoke(JdkDynamicAopProxy.java:204)
>> > > > at sun.proxy.$Proxy96.createVlanAndPublicIpRange(Unknown Source)
>> > > > at org.apache.cloudstack.api.command.admin.vlan.
>> > > > CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:211)
>> > > > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:161)
>> > > > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:530)
>> > > > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:373)
>> > > > at
>> > > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:322)
>> > > >

Re: networks and isolation/broadcast

[Marcus Sorensen]

Yeah, it would be clearer if they were checked separately:

if (one == null || one.isEmpty()) {
return true;
} else if ( other == null || other.isEmpty()) [
return true;
}

or something like that.

On Wed, Jan 1, 2014 at 10:00 PM, Mike Tutkowski
 wrote:
> I should say this check doesn't have to catch it...it might, but it doesn't
> have to (depends on the value of one).
>
>
> On Wed, Jan 1, 2014 at 9:59 PM, Mike Tutkowski > wrote:
>
>> Yeah, in my case I'm just setting up a basic zone with a XenServer host.
>>
>> The code in NetUtils checks for null or "" on the variable in question
>> that's passed in. However, in a certain case, null for that variable can
>> slip by and lead to a NPE.
>>
>> if ((one == null || one.equals(""))
>>
>> &&
>>
>> (other == null || other.equals("")))
>>
>> {
>>
>> return true;
>>
>> }
>>
>> if other == null, this will not catch it and it can throw a NPE later.
>>
>>
>> On Wed, Jan 1, 2014 at 9:51 PM, Marcus Sorensen wrote:
>>
>>> You can do "git blame (file)" and it will show you each line and the
>>> commit. You can also do a git log on the file.  The issue may not be as
>>> obvious as that, though, there may be something totally unrelated causing
>>> that object to end up null in this code. Or it may be specific to your
>>> setup, some obscure bug nobody else is hitting.
>>> On Jan 1, 2014 4:22 PM, "Mike Tutkowski" 
>>> wrote:
>>>
>>> > This is in 4.3.
>>> >
>>> > I know the file is NetUtils, but I'm not sure in Git how to look at the
>>> > history of a particular file like I could do in SVN.
>>> >
>>> >
>>> > On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen 
>>> > wrote:
>>> >
>>> > > Which branch? I see these in master, you can check out the commit just
>>> > > before these and see if it helps:
>>> > >
>>> > > commit b477e4e830597100f0c0171dd8e56f4033bd07aa
>>> > > Author: Daan Hoogland 
>>> > > Date:   Tue Dec 31 12:52:51 2013 +0100
>>> > >
>>> > > some xtra cases
>>> > >
>>> > > commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
>>> > > Author: Daan Hoogland 
>>> > > Date:   Tue Dec 31 12:25:17 2013 +0100
>>> > >
>>> > > isSameIsolationId
>>> > >
>>> > > commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
>>> > > Author: Daan Hoogland 
>>> > > Date:   Fri Dec 20 16:47:58 2013 +0100
>>> > >
>>> > > check vlans and other isolation types
>>> > >
>>> > > commit d50517e931e68daef6735bd18273499fee0d4649
>>> > > Author: Sateesh Chodapuneedi 
>>> > > Date:   Tue Dec 31 07:16:35 2013 +0530
>>> > >
>>> > > I also have a commit just after these, but it was pretty minor and
>>> > > only to KVM agent code.
>>> > >
>>> > > On Wed, Jan 1, 2014 at 3:27 PM, Mike Tutkowski
>>> > >  wrote:
>>> > > > Hey guys,
>>> > > >
>>> > > > The NPE I saw last night was related to "isolation id." Is it
>>> possible
>>> > > this
>>> > > > NPE is related to something new that was put that you are talking
>>> about
>>> > > > here?
>>> > > >
>>> > > > Thank!
>>> > > >
>>> > > > ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2:ctx-ae5d80b2
>>> > > > ctx-5c12c4d9) unhandled exception executing api command:
>>> > > createVlanIpRange
>>> > > > java.lang.NullPointerException
>>> > > > at
>>> > com.cloud.utils.net.NetUtils.isSameIsolationId(NetUtils.java:1419)
>>> > > > at com.cloud.configuration.ConfigurationManagerImpl.
>>> > > > createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2474)
>>> > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>> > > > at sun.reflect.NativeMethodAccessorImpl.invoke(
>>> > > > NativeMethodAccessorImpl.java:57)
>>> > > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(
>>> > > > DelegatingMethodAccessorImpl.java:43)
>>> > > > at java.lang.reflect.Method.invoke(Method.java:616)
>>> > > > at org.springframework.aop.support.AopUtils.
>>> > > > invokeJoinpointUsingReflection(AopUtils.java:317)
>>> > > > at org.springframework.aop.framework.ReflectiveMethodInvocation.
>>> > > > invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>>> > > > at
>>> > > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
>>> > > > ReflectiveMethodInvocation.java:150)
>>> > > > at com.cloud.event.ActionEventInterceptor.invoke(
>>> > > > ActionEventInterceptor.java:50)
>>> > > > at
>>> > > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
>>> > > > ReflectiveMethodInvocation.java:161)
>>> > > > at
>>> org.springframework.aop.interceptor.ExposeInvocationInterceptor.
>>> > > > invoke(ExposeInvocationInterceptor.java:91)
>>> > > > at
>>> > > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
>>> > > > ReflectiveMethodInvocation.java:172)
>>> > > > at org.springframework.aop.framework.JdkDynamicAopProxy.
>>> > > > invoke(JdkDynamicAopProxy.java:204)
>>> > > > at sun.proxy.$Proxy96.createVlanAndPublicIpRange(Unknown Source)
>>> > > > at org.apache.cloudstack.api.command.admin.vlan.
>>> >

Re: networks and isolation/broadcast

[Mike Tutkowski]

Yeah, but I wasn't sure of the coder's intend and if your replacement code
meet their expectations, so I didn't change it. I was hoping someone would
claim the code and chime in. :)


On Wed, Jan 1, 2014 at 10:16 PM, Marcus Sorensen wrote:

> Yeah, it would be clearer if they were checked separately:
>
> if (one == null || one.isEmpty()) {
> return true;
> } else if ( other == null || other.isEmpty()) [
> return true;
> }
>
> or something like that.
>
> On Wed, Jan 1, 2014 at 10:00 PM, Mike Tutkowski
>  wrote:
> > I should say this check doesn't have to catch it...it might, but it
> doesn't
> > have to (depends on the value of one).
> >
> >
> > On Wed, Jan 1, 2014 at 9:59 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com
> >> wrote:
> >
> >> Yeah, in my case I'm just setting up a basic zone with a XenServer host.
> >>
> >> The code in NetUtils checks for null or "" on the variable in question
> >> that's passed in. However, in a certain case, null for that variable can
> >> slip by and lead to a NPE.
> >>
> >> if ((one == null || one.equals(""))
> >>
> >> &&
> >>
> >> (other == null || other.equals("")))
> >>
> >> {
> >>
> >> return true;
> >>
> >> }
> >>
> >> if other == null, this will not catch it and it can throw a NPE later.
> >>
> >>
> >> On Wed, Jan 1, 2014 at 9:51 PM, Marcus Sorensen  >wrote:
> >>
> >>> You can do "git blame (file)" and it will show you each line and the
> >>> commit. You can also do a git log on the file.  The issue may not be as
> >>> obvious as that, though, there may be something totally unrelated
> causing
> >>> that object to end up null in this code. Or it may be specific to your
> >>> setup, some obscure bug nobody else is hitting.
> >>> On Jan 1, 2014 4:22 PM, "Mike Tutkowski"  >
> >>> wrote:
> >>>
> >>> > This is in 4.3.
> >>> >
> >>> > I know the file is NetUtils, but I'm not sure in Git how to look at
> the
> >>> > history of a particular file like I could do in SVN.
> >>> >
> >>> >
> >>> > On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen  >
> >>> > wrote:
> >>> >
> >>> > > Which branch? I see these in master, you can check out the commit
> just
> >>> > > before these and see if it helps:
> >>> > >
> >>> > > commit b477e4e830597100f0c0171dd8e56f4033bd07aa
> >>> > > Author: Daan Hoogland 
> >>> > > Date:   Tue Dec 31 12:52:51 2013 +0100
> >>> > >
> >>> > > some xtra cases
> >>> > >
> >>> > > commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
> >>> > > Author: Daan Hoogland 
> >>> > > Date:   Tue Dec 31 12:25:17 2013 +0100
> >>> > >
> >>> > > isSameIsolationId
> >>> > >
> >>> > > commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
> >>> > > Author: Daan Hoogland 
> >>> > > Date:   Fri Dec 20 16:47:58 2013 +0100
> >>> > >
> >>> > > check vlans and other isolation types
> >>> > >
> >>> > > commit d50517e931e68daef6735bd18273499fee0d4649
> >>> > > Author: Sateesh Chodapuneedi 
> >>> > > Date:   Tue Dec 31 07:16:35 2013 +0530
> >>> > >
> >>> > > I also have a commit just after these, but it was pretty minor and
> >>> > > only to KVM agent code.
> >>> > >
> >>> > > On Wed, Jan 1, 2014 at 3:27 PM, Mike Tutkowski
> >>> > >  wrote:
> >>> > > > Hey guys,
> >>> > > >
> >>> > > > The NPE I saw last night was related to "isolation id." Is it
> >>> possible
> >>> > > this
> >>> > > > NPE is related to something new that was put that you are talking
> >>> about
> >>> > > > here?
> >>> > > >
> >>> > > > Thank!
> >>> > > >
> >>> > > > ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2:ctx-ae5d80b2
> >>> > > > ctx-5c12c4d9) unhandled exception executing api command:
> >>> > > createVlanIpRange
> >>> > > > java.lang.NullPointerException
> >>> > > > at
> >>> > com.cloud.utils.net.NetUtils.isSameIsolationId(NetUtils.java:1419)
> >>> > > > at com.cloud.configuration.ConfigurationManagerImpl.
> >>> > > > createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2474)
> >>> > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> >>> > > > at sun.reflect.NativeMethodAccessorImpl.invoke(
> >>> > > > NativeMethodAccessorImpl.java:57)
> >>> > > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> >>> > > > DelegatingMethodAccessorImpl.java:43)
> >>> > > > at java.lang.reflect.Method.invoke(Method.java:616)
> >>> > > > at org.springframework.aop.support.AopUtils.
> >>> > > > invokeJoinpointUsingReflection(AopUtils.java:317)
> >>> > > > at
> org.springframework.aop.framework.ReflectiveMethodInvocation.
> >>> > > > invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> >>> > > > at
> >>> > >
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> >>> > > > ReflectiveMethodInvocation.java:150)
> >>> > > > at com.cloud.event.ActionEventInterceptor.invoke(
> >>> > > > ActionEventInterceptor.java:50)
> >>> > > > at
> >>> > >
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
> >>> > > > ReflectiveMethodInvocation.java:161)

Re: networks and isolation/broadcast

[Marcus Sorensen]

git blame will show you the commit and committer.

On Wed, Jan 1, 2014 at 10:19 PM, Mike Tutkowski
 wrote:
> Yeah, but I wasn't sure of the coder's intend and if your replacement code
> meet their expectations, so I didn't change it. I was hoping someone would
> claim the code and chime in. :)
>
>
> On Wed, Jan 1, 2014 at 10:16 PM, Marcus Sorensen wrote:
>
>> Yeah, it would be clearer if they were checked separately:
>>
>> if (one == null || one.isEmpty()) {
>> return true;
>> } else if ( other == null || other.isEmpty()) [
>> return true;
>> }
>>
>> or something like that.
>>
>> On Wed, Jan 1, 2014 at 10:00 PM, Mike Tutkowski
>>  wrote:
>> > I should say this check doesn't have to catch it...it might, but it
>> doesn't
>> > have to (depends on the value of one).
>> >
>> >
>> > On Wed, Jan 1, 2014 at 9:59 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com
>> >> wrote:
>> >
>> >> Yeah, in my case I'm just setting up a basic zone with a XenServer host.
>> >>
>> >> The code in NetUtils checks for null or "" on the variable in question
>> >> that's passed in. However, in a certain case, null for that variable can
>> >> slip by and lead to a NPE.
>> >>
>> >> if ((one == null || one.equals(""))
>> >>
>> >> &&
>> >>
>> >> (other == null || other.equals("")))
>> >>
>> >> {
>> >>
>> >> return true;
>> >>
>> >> }
>> >>
>> >> if other == null, this will not catch it and it can throw a NPE later.
>> >>
>> >>
>> >> On Wed, Jan 1, 2014 at 9:51 PM, Marcus Sorensen > >wrote:
>> >>
>> >>> You can do "git blame (file)" and it will show you each line and the
>> >>> commit. You can also do a git log on the file.  The issue may not be as
>> >>> obvious as that, though, there may be something totally unrelated
>> causing
>> >>> that object to end up null in this code. Or it may be specific to your
>> >>> setup, some obscure bug nobody else is hitting.
>> >>> On Jan 1, 2014 4:22 PM, "Mike Tutkowski" > >
>> >>> wrote:
>> >>>
>> >>> > This is in 4.3.
>> >>> >
>> >>> > I know the file is NetUtils, but I'm not sure in Git how to look at
>> the
>> >>> > history of a particular file like I could do in SVN.
>> >>> >
>> >>> >
>> >>> > On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen > >
>> >>> > wrote:
>> >>> >
>> >>> > > Which branch? I see these in master, you can check out the commit
>> just
>> >>> > > before these and see if it helps:
>> >>> > >
>> >>> > > commit b477e4e830597100f0c0171dd8e56f4033bd07aa
>> >>> > > Author: Daan Hoogland 
>> >>> > > Date:   Tue Dec 31 12:52:51 2013 +0100
>> >>> > >
>> >>> > > some xtra cases
>> >>> > >
>> >>> > > commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
>> >>> > > Author: Daan Hoogland 
>> >>> > > Date:   Tue Dec 31 12:25:17 2013 +0100
>> >>> > >
>> >>> > > isSameIsolationId
>> >>> > >
>> >>> > > commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
>> >>> > > Author: Daan Hoogland 
>> >>> > > Date:   Fri Dec 20 16:47:58 2013 +0100
>> >>> > >
>> >>> > > check vlans and other isolation types
>> >>> > >
>> >>> > > commit d50517e931e68daef6735bd18273499fee0d4649
>> >>> > > Author: Sateesh Chodapuneedi 
>> >>> > > Date:   Tue Dec 31 07:16:35 2013 +0530
>> >>> > >
>> >>> > > I also have a commit just after these, but it was pretty minor and
>> >>> > > only to KVM agent code.
>> >>> > >
>> >>> > > On Wed, Jan 1, 2014 at 3:27 PM, Mike Tutkowski
>> >>> > >  wrote:
>> >>> > > > Hey guys,
>> >>> > > >
>> >>> > > > The NPE I saw last night was related to "isolation id." Is it
>> >>> possible
>> >>> > > this
>> >>> > > > NPE is related to something new that was put that you are talking
>> >>> about
>> >>> > > > here?
>> >>> > > >
>> >>> > > > Thank!
>> >>> > > >
>> >>> > > > ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2:ctx-ae5d80b2
>> >>> > > > ctx-5c12c4d9) unhandled exception executing api command:
>> >>> > > createVlanIpRange
>> >>> > > > java.lang.NullPointerException
>> >>> > > > at
>> >>> > com.cloud.utils.net.NetUtils.isSameIsolationId(NetUtils.java:1419)
>> >>> > > > at com.cloud.configuration.ConfigurationManagerImpl.
>> >>> > > > createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2474)
>> >>> > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
>> Method)
>> >>> > > > at sun.reflect.NativeMethodAccessorImpl.invoke(
>> >>> > > > NativeMethodAccessorImpl.java:57)
>> >>> > > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(
>> >>> > > > DelegatingMethodAccessorImpl.java:43)
>> >>> > > > at java.lang.reflect.Method.invoke(Method.java:616)
>> >>> > > > at org.springframework.aop.support.AopUtils.
>> >>> > > > invokeJoinpointUsingReflection(AopUtils.java:317)
>> >>> > > > at
>> org.springframework.aop.framework.ReflectiveMethodInvocation.
>> >>> > > > invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>> >>> > > > at
>> >>> > >
>> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(
>> >>> > > > ReflectiveMethodInvocation.java:150)
>> >>> > >

Re: networks and isolation/broadcast

[Mike Tutkowski]

OK, thanks!


On Wed, Jan 1, 2014 at 10:32 PM, Marcus Sorensen wrote:

> git blame will show you the commit and committer.
>
> On Wed, Jan 1, 2014 at 10:19 PM, Mike Tutkowski
>  wrote:
> > Yeah, but I wasn't sure of the coder's intend and if your replacement
> code
> > meet their expectations, so I didn't change it. I was hoping someone
> would
> > claim the code and chime in. :)
> >
> >
> > On Wed, Jan 1, 2014 at 10:16 PM, Marcus Sorensen  >wrote:
> >
> >> Yeah, it would be clearer if they were checked separately:
> >>
> >> if (one == null || one.isEmpty()) {
> >> return true;
> >> } else if ( other == null || other.isEmpty()) [
> >> return true;
> >> }
> >>
> >> or something like that.
> >>
> >> On Wed, Jan 1, 2014 at 10:00 PM, Mike Tutkowski
> >>  wrote:
> >> > I should say this check doesn't have to catch it...it might, but it
> >> doesn't
> >> > have to (depends on the value of one).
> >> >
> >> >
> >> > On Wed, Jan 1, 2014 at 9:59 PM, Mike Tutkowski <
> >> mike.tutkow...@solidfire.com
> >> >> wrote:
> >> >
> >> >> Yeah, in my case I'm just setting up a basic zone with a XenServer
> host.
> >> >>
> >> >> The code in NetUtils checks for null or "" on the variable in
> question
> >> >> that's passed in. However, in a certain case, null for that variable
> can
> >> >> slip by and lead to a NPE.
> >> >>
> >> >> if ((one == null || one.equals(""))
> >> >>
> >> >> &&
> >> >>
> >> >> (other == null || other.equals("")))
> >> >>
> >> >> {
> >> >>
> >> >> return true;
> >> >>
> >> >> }
> >> >>
> >> >> if other == null, this will not catch it and it can throw a NPE
> later.
> >> >>
> >> >>
> >> >> On Wed, Jan 1, 2014 at 9:51 PM, Marcus Sorensen  >> >wrote:
> >> >>
> >> >>> You can do "git blame (file)" and it will show you each line and the
> >> >>> commit. You can also do a git log on the file.  The issue may not
> be as
> >> >>> obvious as that, though, there may be something totally unrelated
> >> causing
> >> >>> that object to end up null in this code. Or it may be specific to
> your
> >> >>> setup, some obscure bug nobody else is hitting.
> >> >>> On Jan 1, 2014 4:22 PM, "Mike Tutkowski" <
> mike.tutkow...@solidfire.com
> >> >
> >> >>> wrote:
> >> >>>
> >> >>> > This is in 4.3.
> >> >>> >
> >> >>> > I know the file is NetUtils, but I'm not sure in Git how to look
> at
> >> the
> >> >>> > history of a particular file like I could do in SVN.
> >> >>> >
> >> >>> >
> >> >>> > On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen <
> shadow...@gmail.com
> >> >
> >> >>> > wrote:
> >> >>> >
> >> >>> > > Which branch? I see these in master, you can check out the
> commit
> >> just
> >> >>> > > before these and see if it helps:
> >> >>> > >
> >> >>> > > commit b477e4e830597100f0c0171dd8e56f4033bd07aa
> >> >>> > > Author: Daan Hoogland 
> >> >>> > > Date:   Tue Dec 31 12:52:51 2013 +0100
> >> >>> > >
> >> >>> > > some xtra cases
> >> >>> > >
> >> >>> > > commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
> >> >>> > > Author: Daan Hoogland 
> >> >>> > > Date:   Tue Dec 31 12:25:17 2013 +0100
> >> >>> > >
> >> >>> > > isSameIsolationId
> >> >>> > >
> >> >>> > > commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
> >> >>> > > Author: Daan Hoogland 
> >> >>> > > Date:   Fri Dec 20 16:47:58 2013 +0100
> >> >>> > >
> >> >>> > > check vlans and other isolation types
> >> >>> > >
> >> >>> > > commit d50517e931e68daef6735bd18273499fee0d4649
> >> >>> > > Author: Sateesh Chodapuneedi 
> >> >>> > > Date:   Tue Dec 31 07:16:35 2013 +0530
> >> >>> > >
> >> >>> > > I also have a commit just after these, but it was pretty minor
> and
> >> >>> > > only to KVM agent code.
> >> >>> > >
> >> >>> > > On Wed, Jan 1, 2014 at 3:27 PM, Mike Tutkowski
> >> >>> > >  wrote:
> >> >>> > > > Hey guys,
> >> >>> > > >
> >> >>> > > > The NPE I saw last night was related to "isolation id." Is it
> >> >>> possible
> >> >>> > > this
> >> >>> > > > NPE is related to something new that was put that you are
> talking
> >> >>> about
> >> >>> > > > here?
> >> >>> > > >
> >> >>> > > > Thank!
> >> >>> > > >
> >> >>> > > > ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2
> :ctx-ae5d80b2
> >> >>> > > > ctx-5c12c4d9) unhandled exception executing api command:
> >> >>> > > createVlanIpRange
> >> >>> > > > java.lang.NullPointerException
> >> >>> > > > at
> >> >>> > com.cloud.utils.net.NetUtils.isSameIsolationId(NetUtils.java:1419)
> >> >>> > > > at com.cloud.configuration.ConfigurationManagerImpl.
> >> >>> > > > createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2474)
> >> >>> > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> >> Method)
> >> >>> > > > at sun.reflect.NativeMethodAccessorImpl.invoke(
> >> >>> > > > NativeMethodAccessorImpl.java:57)
> >> >>> > > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> >> >>> > > > DelegatingMethodAccessorImpl.java:43)
> >> >>> > > > at java.lang.reflect.Method.invoke(Method.java:616)
> >> >>> > > >

Review Request 16560: CLOUDSTACK-5711 allow scaling from the same offering when using custom compute offering.

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16560/
---

Review request for cloudstack and koushik pv.


Repository: cloudstack-git


Description
---

CLOUDSTACK-5711 allow scaling from the same offering when using custom compute 
offering.
https://issues.apache.org/jira/browse/CLOUDSTACK-5711


Diffs
-

  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 15418d4 
  server/src/com/cloud/server/ManagementServerImpl.java e98c97a 
  server/src/com/cloud/vm/UserVmManager.java 1592910 
  server/src/com/cloud/vm/UserVmManagerImpl.java 19285da 

Diff: https://reviews.apache.org/r/16560/diff/


Testing
---

tested on 4.3


Thanks,

bharat kumar

Re: Review Request 16465: fixed the listvirtualmachines API to show cpu, memory and cpucores when using custom compute offering

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16465/
---

(Updated Jan. 2, 2014, 6:01 a.m.)


Review request for cloudstack and Kishan Kavala.


Bugs: CLOUDSTACK-5472
https://issues.apache.org/jira/browse/CLOUDSTACK-5472


Repository: cloudstack-git


Description
---

CLOUDSTACK-5472 fixed the listvirtualmachines API to show cpu, memory and 
cpucores when using custom compute offering
https://issues.apache.org/jira/browse/CLOUDSTACK-5472


Diffs (updated)
-

  setup/db/db/schema-420to421.sql c09a1bb 

Diff: https://reviews.apache.org/r/16465/diff/


Testing
---

Tested on 4.3


Thanks,

bharat kumar

Re: Review Request 16560: CLOUDSTACK-5711 allow scaling from the same offering when using custom compute offering.

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16560/
---

(Updated Jan. 2, 2014, 6:07 a.m.)


Review request for cloudstack and Koushik Das.


Changes
---

sorry accidentally added koushik pv.


Repository: cloudstack-git


Description
---

CLOUDSTACK-5711 allow scaling from the same offering when using custom compute 
offering.
https://issues.apache.org/jira/browse/CLOUDSTACK-5711


Diffs
-

  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 15418d4 
  server/src/com/cloud/server/ManagementServerImpl.java e98c97a 
  server/src/com/cloud/vm/UserVmManager.java 1592910 
  server/src/com/cloud/vm/UserVmManagerImpl.java 19285da 

Diff: https://reviews.apache.org/r/16560/diff/


Testing
---

tested on 4.3


Thanks,

bharat kumar

Re: networks and isolation/broadcast

[Mike Tutkowski]

Looks like Daan added the method:

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=utils/src/com/cloud/utils/net/NetUtils.java;h=a315b935495469648a0a82a25c39c9c53f0226f6;hp=11a483c3f7e420056dce7893a86946de5c40e244;hb=94abbb1367bc817bae98f369e78679f0ddb7727f;hpb=6897984970df1455fa1ee0490157758ccfb68cff


On Wed, Jan 1, 2014 at 10:33 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> OK, thanks!
>
>
> On Wed, Jan 1, 2014 at 10:32 PM, Marcus Sorensen wrote:
>
>> git blame will show you the commit and committer.
>>
>> On Wed, Jan 1, 2014 at 10:19 PM, Mike Tutkowski
>>  wrote:
>> > Yeah, but I wasn't sure of the coder's intend and if your replacement
>> code
>> > meet their expectations, so I didn't change it. I was hoping someone
>> would
>> > claim the code and chime in. :)
>> >
>> >
>> > On Wed, Jan 1, 2014 at 10:16 PM, Marcus Sorensen > >wrote:
>> >
>> >> Yeah, it would be clearer if they were checked separately:
>> >>
>> >> if (one == null || one.isEmpty()) {
>> >> return true;
>> >> } else if ( other == null || other.isEmpty()) [
>> >> return true;
>> >> }
>> >>
>> >> or something like that.
>> >>
>> >> On Wed, Jan 1, 2014 at 10:00 PM, Mike Tutkowski
>> >>  wrote:
>> >> > I should say this check doesn't have to catch it...it might, but it
>> >> doesn't
>> >> > have to (depends on the value of one).
>> >> >
>> >> >
>> >> > On Wed, Jan 1, 2014 at 9:59 PM, Mike Tutkowski <
>> >> mike.tutkow...@solidfire.com
>> >> >> wrote:
>> >> >
>> >> >> Yeah, in my case I'm just setting up a basic zone with a XenServer
>> host.
>> >> >>
>> >> >> The code in NetUtils checks for null or "" on the variable in
>> question
>> >> >> that's passed in. However, in a certain case, null for that
>> variable can
>> >> >> slip by and lead to a NPE.
>> >> >>
>> >> >> if ((one == null || one.equals(""))
>> >> >>
>> >> >> &&
>> >> >>
>> >> >> (other == null || other.equals("")))
>> >> >>
>> >> >> {
>> >> >>
>> >> >> return true;
>> >> >>
>> >> >> }
>> >> >>
>> >> >> if other == null, this will not catch it and it can throw a NPE
>> later.
>> >> >>
>> >> >>
>> >> >> On Wed, Jan 1, 2014 at 9:51 PM, Marcus Sorensen <
>> shadow...@gmail.com
>> >> >wrote:
>> >> >>
>> >> >>> You can do "git blame (file)" and it will show you each line and
>> the
>> >> >>> commit. You can also do a git log on the file.  The issue may not
>> be as
>> >> >>> obvious as that, though, there may be something totally unrelated
>> >> causing
>> >> >>> that object to end up null in this code. Or it may be specific to
>> your
>> >> >>> setup, some obscure bug nobody else is hitting.
>> >> >>> On Jan 1, 2014 4:22 PM, "Mike Tutkowski" <
>> mike.tutkow...@solidfire.com
>> >> >
>> >> >>> wrote:
>> >> >>>
>> >> >>> > This is in 4.3.
>> >> >>> >
>> >> >>> > I know the file is NetUtils, but I'm not sure in Git how to look
>> at
>> >> the
>> >> >>> > history of a particular file like I could do in SVN.
>> >> >>> >
>> >> >>> >
>> >> >>> > On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen <
>> shadow...@gmail.com
>> >> >
>> >> >>> > wrote:
>> >> >>> >
>> >> >>> > > Which branch? I see these in master, you can check out the
>> commit
>> >> just
>> >> >>> > > before these and see if it helps:
>> >> >>> > >
>> >> >>> > > commit b477e4e830597100f0c0171dd8e56f4033bd07aa
>> >> >>> > > Author: Daan Hoogland 
>> >> >>> > > Date:   Tue Dec 31 12:52:51 2013 +0100
>> >> >>> > >
>> >> >>> > > some xtra cases
>> >> >>> > >
>> >> >>> > > commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
>> >> >>> > > Author: Daan Hoogland 
>> >> >>> > > Date:   Tue Dec 31 12:25:17 2013 +0100
>> >> >>> > >
>> >> >>> > > isSameIsolationId
>> >> >>> > >
>> >> >>> > > commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
>> >> >>> > > Author: Daan Hoogland 
>> >> >>> > > Date:   Fri Dec 20 16:47:58 2013 +0100
>> >> >>> > >
>> >> >>> > > check vlans and other isolation types
>> >> >>> > >
>> >> >>> > > commit d50517e931e68daef6735bd18273499fee0d4649
>> >> >>> > > Author: Sateesh Chodapuneedi 
>> >> >>> > > Date:   Tue Dec 31 07:16:35 2013 +0530
>> >> >>> > >
>> >> >>> > > I also have a commit just after these, but it was pretty minor
>> and
>> >> >>> > > only to KVM agent code.
>> >> >>> > >
>> >> >>> > > On Wed, Jan 1, 2014 at 3:27 PM, Mike Tutkowski
>> >> >>> > >  wrote:
>> >> >>> > > > Hey guys,
>> >> >>> > > >
>> >> >>> > > > The NPE I saw last night was related to "isolation id." Is it
>> >> >>> possible
>> >> >>> > > this
>> >> >>> > > > NPE is related to something new that was put that you are
>> talking
>> >> >>> about
>> >> >>> > > > here?
>> >> >>> > > >
>> >> >>> > > > Thank!
>> >> >>> > > >
>> >> >>> > > > ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2
>> :ctx-ae5d80b2
>> >> >>> > > > ctx-5c12c4d9) unhandled exception executing api command:
>> >> >>> > > createVlanIpRange
>> >> >>> > > > java.lang.NullPointerException
>> >> >>> > > > at
>> >> >>> >
>> com.cloud.utils.net.NetUtils.isSam

Review Request 16566: CLOUDSTACK-5551: Search not working for Configuration parameters in (Account/zone/cluster/storage) settings page

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16566/
---

Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-5551
https://issues.apache.org/jira/browse/CLOUDSTACK-5551


Repository: cloudstack-git


Description
---

CLOUDSTACK-5551: Search not working for Configuration parameters in 
(Account/zone/cluster/storage) settings page

Added filters while listing scoped configuration parameters.
Fixed: Some parameters are missing from UI settings tab because of missing 
scope entry in configuration table.


Diffs
-

  engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 73b68ea 
  framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 
22452b9 
  
framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
 305d286 
  server/src/com/cloud/server/ConfigurationServerImpl.java 4020926 
  server/src/com/cloud/server/ManagementServerImpl.java e98c97a 
  server/src/com/cloud/vm/UserVmManager.java 1592910 
  setup/db/db/schema-421to430.sql 284fb17 

Diff: https://reviews.apache.org/r/16566/diff/


Testing
---


Thanks,

Harikrishna Patnala

Re: Review Request 16566: CLOUDSTACK-5551: Search not working for Configuration parameters in (Account/zone/cluster/storage) settings page

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16566/
---

(Updated Jan. 2, 2014, 6:55 a.m.)


Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-5551
https://issues.apache.org/jira/browse/CLOUDSTACK-5551


Repository: cloudstack-git


Description
---

CLOUDSTACK-5551: Search not working for Configuration parameters in 
(Account/zone/cluster/storage) settings page

Added filters while listing scoped configuration parameters.
Fixed: Some parameters are missing from UI settings tab because of missing 
scope entry in configuration table.


Diffs (updated)
-

  framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 
22452b9 
  
framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
 305d286 
  server/src/com/cloud/server/ConfigurationServerImpl.java 4020926 
  server/src/com/cloud/server/ManagementServerImpl.java e98c97a 
  server/src/com/cloud/vm/UserVmManager.java 1592910 
  setup/db/db/schema-421to430.sql 284fb17 

Diff: https://reviews.apache.org/r/16566/diff/


Testing
---


Thanks,

Harikrishna Patnala

Re: Review Request 16541: CLOUDSTACK-5636: Fixed issue 'Failed to upgrade network offering' in test_vpc_network test suite

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16541/#review31020
---


Commit 8f15fc1fc13c2aa4ebb6ccc618b5192eae2e6063 in branch refs/heads/4.3 from 
Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8f15fc1 ]

CLOUDSTACK-5636: Fixed issue 'Failed to upgrade network offering' in 
test_vpc_network test suite


- ASF Subversion and Git Services


On Dec. 31, 2013, 1:21 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16541/
> ---
> 
> (Updated Dec. 31, 2013, 1:21 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5636
> https://issues.apache.org/jira/browse/CLOUDSTACK-5636
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changes:
> 1) Load balancing rule is now applied to only one VM and not the other VM for 
> which static NAT rule has been created. There is no need to include that VM 
> under load balancing for which static NAT is defined.
> 
> 2) When all the VMs in the VPC are stopped, network state goes from 
> Implemented --> Shutdown --> Allocated. We can't update the network when it 
> is in Shutdown state, we should wait for the network state to become 
> Allocated. Added check for network state and then updated the network. This 
> resolves the root cause of the issue 5636 (Failed to shutdown the network 
> elements and resources as a part of update to network with specified id; 
> network is in wrong state: Shutdown').
> 
> 3) Code cleanup - removed unused variables, modifyed imports, removed 
> white-spaces.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_network.py 9b2269d 
> 
> Diff: https://reviews.apache.org/r/16541/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> Log:
> 
> test_01_create_network_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC ... skipped 'skip'
> test_01_create_network_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC ... skipped 'skip'
> test_02_create_network_fail_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC mismatched services (Should fail) ... skipped 
> 'skip'
> test_02_create_network_fail_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC mismatched services (Should fail) ... skipped 
> 'skip'
> test_04_create_multiple_networks_with_lb_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create multiple networks with LB service (Should fail) ... skipped 'skip'
> test_04_create_multiple_networks_with_lb_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create multiple networks with LB service (Should fail) ... skipped 'skip'
> test_05_create_network_ext_LB (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with external LB devices ... skipped 'skip'
> test_06_create_network_with_rvr (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with redundant router capability ... skipped 'skip'
> test_07_create_network_unsupported_services 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network services not supported by VPC (Should fail) ... skipped 
> 'skip'
> test_08_create_network_without_sourceNAT 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network without sourceNAT service in VPC (should fail) ... 
> skipped 'skip'
> test_09_create_network_shared_nwoff_network_off_shared 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with shared network offering ... skipped 'skip'
> test_09_create_network_shared_nwoff_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with shared network offering ... skipped 'skip'
> test_10_create_network_with_conserve_mode_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with conserve mode ON ... skipped 'skip'
> test_10_create_network_with_conserve_mode_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with conserve mode ON ... skipped 'skip'
> test_01_wait_network_gc (test_vpc_network_fixed.TestVPCNetworkGc)
> Test network gc after shutdown of vms in the network ... skipped 'skip'
> test_02_start_vm_network_gc (test_vpc_network_fixed.TestVPCNetworkGc)
> Test network rules after starting a VpcVr that was shutdown after network.gc 
> ... skipped 'skip'
> test_03_restart_vpcvr (test_vpc_network_fixed.TestVPCNetworkGc)
> Test Stop all the Vms that are part of the a Network ... skipped 'skip'
> test_01_create_network_outside_range_network_offering 
> (test_vpc_network_fixed.TestVPCNetworkRanges)
> Test create network outside 

Re: Review Request 16566: CLOUDSTACK-5551: Search not working for Configuration parameters in (Account/zone/cluster/storage) settings page

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16566/
---

(Updated Jan. 2, 2014, 7:09 a.m.)


Review request for cloudstack and Koushik Das.


Changes
---

removed some unwanted changes.


Bugs: CLOUDSTACK-5551
https://issues.apache.org/jira/browse/CLOUDSTACK-5551


Repository: cloudstack-git


Description
---

CLOUDSTACK-5551: Search not working for Configuration parameters in 
(Account/zone/cluster/storage) settings page

Added filters while listing scoped configuration parameters.
Fixed: Some parameters are missing from UI settings tab because of missing 
scope entry in configuration table.


Diffs (updated)
-

  framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 
22452b9 
  
framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
 305d286 
  server/src/com/cloud/server/ConfigurationServerImpl.java 4020926 
  server/src/com/cloud/server/ManagementServerImpl.java e98c97a 
  server/src/com/cloud/vm/UserVmManager.java 1592910 

Diff: https://reviews.apache.org/r/16566/diff/


Testing
---


Thanks,

Harikrishna Patnala

Re: Review Request 16541: CLOUDSTACK-5636: Fixed issue 'Failed to upgrade network offering' in test_vpc_network test suite

[Girish Shilamkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16541/#review31021
---

Ship it!


Committed to 4.3 and master.

- Girish Shilamkar


On Dec. 31, 2013, 1:21 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16541/
> ---
> 
> (Updated Dec. 31, 2013, 1:21 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5636
> https://issues.apache.org/jira/browse/CLOUDSTACK-5636
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changes:
> 1) Load balancing rule is now applied to only one VM and not the other VM for 
> which static NAT rule has been created. There is no need to include that VM 
> under load balancing for which static NAT is defined.
> 
> 2) When all the VMs in the VPC are stopped, network state goes from 
> Implemented --> Shutdown --> Allocated. We can't update the network when it 
> is in Shutdown state, we should wait for the network state to become 
> Allocated. Added check for network state and then updated the network. This 
> resolves the root cause of the issue 5636 (Failed to shutdown the network 
> elements and resources as a part of update to network with specified id; 
> network is in wrong state: Shutdown').
> 
> 3) Code cleanup - removed unused variables, modifyed imports, removed 
> white-spaces.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_network.py 9b2269d 
> 
> Diff: https://reviews.apache.org/r/16541/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> Log:
> 
> test_01_create_network_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC ... skipped 'skip'
> test_01_create_network_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC ... skipped 'skip'
> test_02_create_network_fail_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC mismatched services (Should fail) ... skipped 
> 'skip'
> test_02_create_network_fail_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC mismatched services (Should fail) ... skipped 
> 'skip'
> test_04_create_multiple_networks_with_lb_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create multiple networks with LB service (Should fail) ... skipped 'skip'
> test_04_create_multiple_networks_with_lb_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create multiple networks with LB service (Should fail) ... skipped 'skip'
> test_05_create_network_ext_LB (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with external LB devices ... skipped 'skip'
> test_06_create_network_with_rvr (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with redundant router capability ... skipped 'skip'
> test_07_create_network_unsupported_services 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network services not supported by VPC (Should fail) ... skipped 
> 'skip'
> test_08_create_network_without_sourceNAT 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network without sourceNAT service in VPC (should fail) ... 
> skipped 'skip'
> test_09_create_network_shared_nwoff_network_off_shared 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with shared network offering ... skipped 'skip'
> test_09_create_network_shared_nwoff_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with shared network offering ... skipped 'skip'
> test_10_create_network_with_conserve_mode_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with conserve mode ON ... skipped 'skip'
> test_10_create_network_with_conserve_mode_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with conserve mode ON ... skipped 'skip'
> test_01_wait_network_gc (test_vpc_network_fixed.TestVPCNetworkGc)
> Test network gc after shutdown of vms in the network ... skipped 'skip'
> test_02_start_vm_network_gc (test_vpc_network_fixed.TestVPCNetworkGc)
> Test network rules after starting a VpcVr that was shutdown after network.gc 
> ... skipped 'skip'
> test_03_restart_vpcvr (test_vpc_network_fixed.TestVPCNetworkGc)
> Test Stop all the Vms that are part of the a Network ... skipped 'skip'
> test_01_create_network_outside_range_network_offering 
> (test_vpc_network_fixed.TestVPCNetworkRanges)
> Test create network outside cidr range of VPC ... skipped 'skip'
> test_01_create_network_outside_range_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetworkRanges)
> Test create network outside cidr range of VPC ... skipped 'skip'
> test_02_create_network_o

Re: networks and isolation/broadcast

[Mike Tutkowski]

Yeah, this does appear to be a bug.

I re-ran the attempted creation of my CloudStack cloud with a different
XenServer host and was left in the same state (NPE).

I plan to try this with KVM tomorrow (er, later today, I guess).


On Wed, Jan 1, 2014 at 11:10 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Looks like Daan added the method:
>
>
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=utils/src/com/cloud/utils/net/NetUtils.java;h=a315b935495469648a0a82a25c39c9c53f0226f6;hp=11a483c3f7e420056dce7893a86946de5c40e244;hb=94abbb1367bc817bae98f369e78679f0ddb7727f;hpb=6897984970df1455fa1ee0490157758ccfb68cff
>
>
> On Wed, Jan 1, 2014 at 10:33 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> OK, thanks!
>>
>>
>> On Wed, Jan 1, 2014 at 10:32 PM, Marcus Sorensen wrote:
>>
>>> git blame will show you the commit and committer.
>>>
>>> On Wed, Jan 1, 2014 at 10:19 PM, Mike Tutkowski
>>>  wrote:
>>> > Yeah, but I wasn't sure of the coder's intend and if your replacement
>>> code
>>> > meet their expectations, so I didn't change it. I was hoping someone
>>> would
>>> > claim the code and chime in. :)
>>> >
>>> >
>>> > On Wed, Jan 1, 2014 at 10:16 PM, Marcus Sorensen >> >wrote:
>>> >
>>> >> Yeah, it would be clearer if they were checked separately:
>>> >>
>>> >> if (one == null || one.isEmpty()) {
>>> >> return true;
>>> >> } else if ( other == null || other.isEmpty()) [
>>> >> return true;
>>> >> }
>>> >>
>>> >> or something like that.
>>> >>
>>> >> On Wed, Jan 1, 2014 at 10:00 PM, Mike Tutkowski
>>> >>  wrote:
>>> >> > I should say this check doesn't have to catch it...it might, but it
>>> >> doesn't
>>> >> > have to (depends on the value of one).
>>> >> >
>>> >> >
>>> >> > On Wed, Jan 1, 2014 at 9:59 PM, Mike Tutkowski <
>>> >> mike.tutkow...@solidfire.com
>>> >> >> wrote:
>>> >> >
>>> >> >> Yeah, in my case I'm just setting up a basic zone with a XenServer
>>> host.
>>> >> >>
>>> >> >> The code in NetUtils checks for null or "" on the variable in
>>> question
>>> >> >> that's passed in. However, in a certain case, null for that
>>> variable can
>>> >> >> slip by and lead to a NPE.
>>> >> >>
>>> >> >> if ((one == null || one.equals(""))
>>> >> >>
>>> >> >> &&
>>> >> >>
>>> >> >> (other == null || other.equals("")))
>>> >> >>
>>> >> >> {
>>> >> >>
>>> >> >> return true;
>>> >> >>
>>> >> >> }
>>> >> >>
>>> >> >> if other == null, this will not catch it and it can throw a NPE
>>> later.
>>> >> >>
>>> >> >>
>>> >> >> On Wed, Jan 1, 2014 at 9:51 PM, Marcus Sorensen <
>>> shadow...@gmail.com
>>> >> >wrote:
>>> >> >>
>>> >> >>> You can do "git blame (file)" and it will show you each line and
>>> the
>>> >> >>> commit. You can also do a git log on the file.  The issue may not
>>> be as
>>> >> >>> obvious as that, though, there may be something totally unrelated
>>> >> causing
>>> >> >>> that object to end up null in this code. Or it may be specific to
>>> your
>>> >> >>> setup, some obscure bug nobody else is hitting.
>>> >> >>> On Jan 1, 2014 4:22 PM, "Mike Tutkowski" <
>>> mike.tutkow...@solidfire.com
>>> >> >
>>> >> >>> wrote:
>>> >> >>>
>>> >> >>> > This is in 4.3.
>>> >> >>> >
>>> >> >>> > I know the file is NetUtils, but I'm not sure in Git how to
>>> look at
>>> >> the
>>> >> >>> > history of a particular file like I could do in SVN.
>>> >> >>> >
>>> >> >>> >
>>> >> >>> > On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen <
>>> shadow...@gmail.com
>>> >> >
>>> >> >>> > wrote:
>>> >> >>> >
>>> >> >>> > > Which branch? I see these in master, you can check out the
>>> commit
>>> >> just
>>> >> >>> > > before these and see if it helps:
>>> >> >>> > >
>>> >> >>> > > commit b477e4e830597100f0c0171dd8e56f4033bd07aa
>>> >> >>> > > Author: Daan Hoogland 
>>> >> >>> > > Date:   Tue Dec 31 12:52:51 2013 +0100
>>> >> >>> > >
>>> >> >>> > > some xtra cases
>>> >> >>> > >
>>> >> >>> > > commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
>>> >> >>> > > Author: Daan Hoogland 
>>> >> >>> > > Date:   Tue Dec 31 12:25:17 2013 +0100
>>> >> >>> > >
>>> >> >>> > > isSameIsolationId
>>> >> >>> > >
>>> >> >>> > > commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
>>> >> >>> > > Author: Daan Hoogland 
>>> >> >>> > > Date:   Fri Dec 20 16:47:58 2013 +0100
>>> >> >>> > >
>>> >> >>> > > check vlans and other isolation types
>>> >> >>> > >
>>> >> >>> > > commit d50517e931e68daef6735bd18273499fee0d4649
>>> >> >>> > > Author: Sateesh Chodapuneedi 
>>> >> >>> > > Date:   Tue Dec 31 07:16:35 2013 +0530
>>> >> >>> > >
>>> >> >>> > > I also have a commit just after these, but it was pretty
>>> minor and
>>> >> >>> > > only to KVM agent code.
>>> >> >>> > >
>>> >> >>> > > On Wed, Jan 1, 2014 at 3:27 PM, Mike Tutkowski
>>> >> >>> > >  wrote:
>>> >> >>> > > > Hey guys,
>>> >> >>> > > >
>>> >> >>> > > > The NPE I saw last night was related to "isolation id." Is
>>> it
>>> >> >>> possible
>>> >> >>> > > this
>>> >> >>> > > > 

Re: Error while building

[Dumindu Buddhika]

here are the files in the above directory.
as it seems the required files are available in the code. but build gives
that error anyway.


Thanks.

bad_format_cert.crt  root_chain.crt  rsa_random_pkey.key
dsa_self_signed.crt  rsa_ca_signed2.crt  rsa_self_signed.crt
dsa_self_signed.key  rsa_ca_signed2.key  rsa_self_signed.key
expired_cert.crt rsa_ca_signed.crt   rsa_self_signed_with_pwd.crt
non_x509_pem.crt rsa_ca_signed.key   rsa_self_signed_with_pwd.key


Dumindu Buddhika,
Undergraduate,
Department of Computer Science and Engineering,
University of Moratuwa,
Sri Lanka.
Mobile:+94715764749


On Tue, Dec 31, 2013 at 8:27 PM, Daan Hoogland wrote:

> in my env:
>
> $ ls server/target/test-classes/certs/
> bad_format_cert.crt   rsa_ca_signed2.crt
> dsa_self_signed.crt   rsa_ca_signed2.key
> dsa_self_signed.key   rsa_random_pkey.key
> expired_cert.crt  rsa_self_signed.crt
> non_x509_pem.crt  rsa_self_signed.key
> root_chain.crtrsa_self_signed_with_pwd.crt
> rsa_ca_signed.crt rsa_self_signed_with_pwd.key
> rsa_ca_signed.key
>
> so I think you have a problem with either your environment (tools
> installed?) or your system (diskspace?) or your checkout/clone didn't
> fully succeed..??
>
> I did
> $ git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git
>
> and then
> $ mvn clean test
>
> and it build without hesitation
>
> good hunting,
> Daan
>
> On Tue, Dec 31, 2013 at 3:25 PM, Dumindu Buddhika
>  wrote:
> > Thanks for the feedback.
> > Here is the report containing the test error(report file you pointed
> out).
> > it says some file is missing.
> > Please let me know the cause for the error if you can help. :)
> >
> > Thank you
> >
> >
> ---
> > Test set: org.apache.cloudstack.network.lb.CertServiceTest
> >
> ---
> > Tests run: 15, Failures: 0, Errors: 12, Skipped: 0, Time elapsed: 1.6 sec
> > <<< FAILURE!
> >
> runUploadSslCertWithCAChain(org.apache.cloudstack.network.lb.CertServiceTest)
> >  Time elapsed: 0.324 sec  <<< ERROR!
> > java.io.FileNotFoundException: File
> >
> '/media/TV%26Movie/aca/cloudstack/server/target/test-classes/certs/rsa_ca_signed.crt'
> > does not exist
> > at org.apache.commons.io.FileUtils.openInputStream(FileUtils.java:137)
> > at org.apache.commons.io.FileUtils.readFileToString(FileUtils.java:1102)
> > at org.apache.commons.io.FileUtils.readFileToString(FileUtils.java:1120)
> > at
> >
> org.apache.cloudstack.network.lb.CertServiceTest.runUploadSslCertWithCAChain(CertServiceTest.java:104)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at
> >
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at
> >
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:616)
> > at
> >
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
> > at
> >
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> > at
> >
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
> > at
> >
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> > at
> >
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
> > at
> >
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
> > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
> > at
> >
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
> > at
> >
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
> > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
> > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
> > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
> > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
> > at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
> > at
> >
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
> > at
> >
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
> > at
> >
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at
> >
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at
> >
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:616)
> > at
> >
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > at
> >
> org.apache.maven.

Help Me, i have some question

[guang wu]

hi,everyone
  i have some question about cloudstack,
No.1: how can i use External DHCP Server(not use VirtualRouter VM DHCP
Server), i set global  settings
direct.attach.network.externalIpAllocator.enabled = true,and restart
management server,but vm's ip address also provide for VirtualRouter, how
can i do ?

No.2: why design Redundancy Router VM not HA itself(Redundancy Router VM
not HA tag),but  general Virtual Router VM has ha tag?

Re: Review Request 16541: CLOUDSTACK-5636: Fixed issue 'Failed to upgrade network offering' in test_vpc_network test suite

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16541/#review31023
---


Commit 97ede2524c1e19a5de68deab7c5d8327d26a81e9 in branch refs/heads/master 
from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=97ede25 ]

CLOUDSTACK-5636: Fixed issue 'Failed to upgrade network offering' in 
test_vpc_network test suite

Conflicts:
test/integration/component/test_vpc_network.py


- ASF Subversion and Git Services


On Dec. 31, 2013, 1:21 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16541/
> ---
> 
> (Updated Dec. 31, 2013, 1:21 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5636
> https://issues.apache.org/jira/browse/CLOUDSTACK-5636
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changes:
> 1) Load balancing rule is now applied to only one VM and not the other VM for 
> which static NAT rule has been created. There is no need to include that VM 
> under load balancing for which static NAT is defined.
> 
> 2) When all the VMs in the VPC are stopped, network state goes from 
> Implemented --> Shutdown --> Allocated. We can't update the network when it 
> is in Shutdown state, we should wait for the network state to become 
> Allocated. Added check for network state and then updated the network. This 
> resolves the root cause of the issue 5636 (Failed to shutdown the network 
> elements and resources as a part of update to network with specified id; 
> network is in wrong state: Shutdown').
> 
> 3) Code cleanup - removed unused variables, modifyed imports, removed 
> white-spaces.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_network.py 9b2269d 
> 
> Diff: https://reviews.apache.org/r/16541/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> Log:
> 
> test_01_create_network_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC ... skipped 'skip'
> test_01_create_network_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC ... skipped 'skip'
> test_02_create_network_fail_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC mismatched services (Should fail) ... skipped 
> 'skip'
> test_02_create_network_fail_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network in VPC mismatched services (Should fail) ... skipped 
> 'skip'
> test_04_create_multiple_networks_with_lb_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create multiple networks with LB service (Should fail) ... skipped 'skip'
> test_04_create_multiple_networks_with_lb_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create multiple networks with LB service (Should fail) ... skipped 'skip'
> test_05_create_network_ext_LB (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with external LB devices ... skipped 'skip'
> test_06_create_network_with_rvr (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with redundant router capability ... skipped 'skip'
> test_07_create_network_unsupported_services 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network services not supported by VPC (Should fail) ... skipped 
> 'skip'
> test_08_create_network_without_sourceNAT 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network without sourceNAT service in VPC (should fail) ... 
> skipped 'skip'
> test_09_create_network_shared_nwoff_network_off_shared 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with shared network offering ... skipped 'skip'
> test_09_create_network_shared_nwoff_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with shared network offering ... skipped 'skip'
> test_10_create_network_with_conserve_mode_network_offering 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with conserve mode ON ... skipped 'skip'
> test_10_create_network_with_conserve_mode_network_offering_vpcns 
> (test_vpc_network_fixed.TestVPCNetwork)
> Test create network with conserve mode ON ... skipped 'skip'
> test_01_wait_network_gc (test_vpc_network_fixed.TestVPCNetworkGc)
> Test network gc after shutdown of vms in the network ... skipped 'skip'
> test_02_start_vm_network_gc (test_vpc_network_fixed.TestVPCNetworkGc)
> Test network rules after starting a VpcVr that was shutdown after network.gc 
> ... skipped 'skip'
> test_03_restart_vpcvr (test_vpc_network_fixed.TestVPCNetworkGc)
> Test Stop all the Vms that are part of the a Network ... skipped 'skip'
> test_01_create_network_outside_range_network_offering 
> (test_

Re: networks and isolation/broadcast

[Marcus Sorensen]

There are some other issues near that commit as well. A fix for
CLOUDSTACK-5502 that makes 'untagged' invalid needs to be backed out.



On Thu, Jan 2, 2014 at 12:14 AM, Mike Tutkowski
 wrote:
> Yeah, this does appear to be a bug.
>
> I re-ran the attempted creation of my CloudStack cloud with a different
> XenServer host and was left in the same state (NPE).
>
> I plan to try this with KVM tomorrow (er, later today, I guess).
>
>
> On Wed, Jan 1, 2014 at 11:10 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Looks like Daan added the method:
>>
>>
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=utils/src/com/cloud/utils/net/NetUtils.java;h=a315b935495469648a0a82a25c39c9c53f0226f6;hp=11a483c3f7e420056dce7893a86946de5c40e244;hb=94abbb1367bc817bae98f369e78679f0ddb7727f;hpb=6897984970df1455fa1ee0490157758ccfb68cff
>>
>>
>> On Wed, Jan 1, 2014 at 10:33 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>>> OK, thanks!
>>>
>>>
>>> On Wed, Jan 1, 2014 at 10:32 PM, Marcus Sorensen wrote:
>>>
 git blame will show you the commit and committer.

 On Wed, Jan 1, 2014 at 10:19 PM, Mike Tutkowski
  wrote:
 > Yeah, but I wasn't sure of the coder's intend and if your replacement
 code
 > meet their expectations, so I didn't change it. I was hoping someone
 would
 > claim the code and chime in. :)
 >
 >
 > On Wed, Jan 1, 2014 at 10:16 PM, Marcus Sorensen >>> >wrote:
 >
 >> Yeah, it would be clearer if they were checked separately:
 >>
 >> if (one == null || one.isEmpty()) {
 >> return true;
 >> } else if ( other == null || other.isEmpty()) [
 >> return true;
 >> }
 >>
 >> or something like that.
 >>
 >> On Wed, Jan 1, 2014 at 10:00 PM, Mike Tutkowski
 >>  wrote:
 >> > I should say this check doesn't have to catch it...it might, but it
 >> doesn't
 >> > have to (depends on the value of one).
 >> >
 >> >
 >> > On Wed, Jan 1, 2014 at 9:59 PM, Mike Tutkowski <
 >> mike.tutkow...@solidfire.com
 >> >> wrote:
 >> >
 >> >> Yeah, in my case I'm just setting up a basic zone with a XenServer
 host.
 >> >>
 >> >> The code in NetUtils checks for null or "" on the variable in
 question
 >> >> that's passed in. However, in a certain case, null for that
 variable can
 >> >> slip by and lead to a NPE.
 >> >>
 >> >> if ((one == null || one.equals(""))
 >> >>
 >> >> &&
 >> >>
 >> >> (other == null || other.equals("")))
 >> >>
 >> >> {
 >> >>
 >> >> return true;
 >> >>
 >> >> }
 >> >>
 >> >> if other == null, this will not catch it and it can throw a NPE
 later.
 >> >>
 >> >>
 >> >> On Wed, Jan 1, 2014 at 9:51 PM, Marcus Sorensen <
 shadow...@gmail.com
 >> >wrote:
 >> >>
 >> >>> You can do "git blame (file)" and it will show you each line and
 the
 >> >>> commit. You can also do a git log on the file.  The issue may not
 be as
 >> >>> obvious as that, though, there may be something totally unrelated
 >> causing
 >> >>> that object to end up null in this code. Or it may be specific to
 your
 >> >>> setup, some obscure bug nobody else is hitting.
 >> >>> On Jan 1, 2014 4:22 PM, "Mike Tutkowski" <
 mike.tutkow...@solidfire.com
 >> >
 >> >>> wrote:
 >> >>>
 >> >>> > This is in 4.3.
 >> >>> >
 >> >>> > I know the file is NetUtils, but I'm not sure in Git how to
 look at
 >> the
 >> >>> > history of a particular file like I could do in SVN.
 >> >>> >
 >> >>> >
 >> >>> > On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen <
 shadow...@gmail.com
 >> >
 >> >>> > wrote:
 >> >>> >
 >> >>> > > Which branch? I see these in master, you can check out the
 commit
 >> just
 >> >>> > > before these and see if it helps:
 >> >>> > >
 >> >>> > > commit b477e4e830597100f0c0171dd8e56f4033bd07aa
 >> >>> > > Author: Daan Hoogland 
 >> >>> > > Date:   Tue Dec 31 12:52:51 2013 +0100
 >> >>> > >
 >> >>> > > some xtra cases
 >> >>> > >
 >> >>> > > commit 2cf356e047e26977c1d294fafc57e986c04fc5f4
 >> >>> > > Author: Daan Hoogland 
 >> >>> > > Date:   Tue Dec 31 12:25:17 2013 +0100
 >> >>> > >
 >> >>> > > isSameIsolationId
 >> >>> > >
 >> >>> > > commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce
 >> >>> > > Author: Daan Hoogland 
 >> >>> > > Date:   Fri Dec 20 16:47:58 2013 +0100
 >> >>> > >
 >> >>> > > check vlans and other isolation types
 >> >>> > >
 >> >>> > > commit d50517e931e68daef6735bd18273499fee0d4649
 >> >>> > > Author: Sateesh Chodapuneedi 
 >> >>> > > Date:   Tue Dec 31 07:16:35 2013 +0530
 >> >>> > >
 >> >>> > > I also have a commit just after these, but it was p