Re: Review Request 12758: Cloustack - 3452: Added check if security groups feature is enabled in basic zone before creating any sec group

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12758/#review23571
---

Ship it!




commit 4f8c43fc2089e455aaad8203c01d44ed409d0c32 (master)
 
commit 3c360ce02807240586d471ab4c0cbd24d76ed7e6 (4.2)

- Prasanna Santhanam


On July 19, 2013, 1:07 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12758/
> ---
> 
> (Updated July 19, 2013, 1:07 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Resolved issue CLOUDSTACK - 3452: 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3452
> 
> Addded check if security groups feature is enabled for basic zone before 
> creating security group while creating VM.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/integration/lib/base.py 13507bc 
> 
> Diff: https://reviews.apache.org/r/12758/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Reviewboard and jenkins

[Prasanna Santhanam]

On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote:
> 
> On Jul 19, 2013, at 7:15 PM, Daan Hoogland  wrote:
> 
> > good stuff, does it run the risk of running while another instance is busy?
> 
> Probably not, it's a single threaded script. I intend to use jenkins
> to schedule it and i can tell jenkins not to start another instance
> of a job once one is running.
> 
should set a "quiet period" for the job so that it doesn't kick up
jobs for each checkin but a group instead. we'll run out of executors
fast if that happens.

> There are probably some bug still in the script, but hey we got to
> start somewhere. ;-)
> 

Absolutely, could you put it up on cso-infra/github so we can hack it
and customize?

-- 
Prasanna.,


Powered by BigRock.com

Re: Reviewboard and jenkins

[Hugo Trippaers]

Sent from my iPhone

On 20 jul. 2013, at 10:09, Prasanna Santhanam  wrote:

> On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote:
>> 
>> On Jul 19, 2013, at 7:15 PM, Daan Hoogland  wrote:
>> 
>>> good stuff, does it run the risk of running while another instance is busy?
>> 
>> Probably not, it's a single threaded script. I intend to use jenkins
>> to schedule it and i can tell jenkins not to start another instance
>> of a job once one is running.
> should set a "quiet period" for the job so that it doesn't kick up
> jobs for each checkin but a group instead. we'll run out of executors
> fast if that happens.

Every time the script runs it will look at the newest 20 submissions and 
process them in order. That should be ok for now.

> 
>> There are probably some bug still in the script, but hey we got to
>> start somewhere. ;-)
> 
> Absolutely, could you put it up on cso-infra/github so we can hack it
> and customize?

Absolutely, will put it there this weekend if I have some time. I don't have 
enough permissions to setup a new repo in CloudStack extras yet.

Cheers,
Hugo

> 
> -- 
> Prasanna.,
> 
> 
> Powered by BigRock.com
> 

Re: Noisy ASFBot

[Daan Hoogland]

I agree,

@Prasanna, can we make ignore default and /activate ASFBot? That would have
my preference.

Daan


On Sat, Jul 20, 2013 at 6:55 AM, Prasanna Santhanam  wrote:

> On Sat, Jul 20, 2013 at 12:48:28AM +0200, Hugo Trippaers wrote:
> > Hey guys,
> >
> > I've noticed that our friendly bots on #cloudstack-dev make a lot
> > more noise than we all do. I'm getting the impression that is is
> > actually hindering people trying to get a conversation going. It
> > difficult to keep track if ASFBot and Cato_Fong regularly make a lot
> > of noise.
> >
> > While its very useful messages it might be better to tone that down
> > a little until the user / bot ratio is more in favour of the users i
> > think.
> >
> > What do you think?
> >
> > Cheers,
> >
> /ignore ASFBot or Cato_Fong?
>
> --
> Prasanna.,
>
> 
> Powered by BigRock.com
>
>

Re: [ACS42] NFS Cache Naming

[Daan Hoogland]

NFS Staging it was in my recollection.


On Fri, Jul 19, 2013 at 10:30 PM, John Burwell  wrote:

> All,
>
> It was my understanding that we had agreed to rename the "NFS Cache"
> mechanism to reflect that it is not a cache and remove the assumption that
> it will always be backed by NFS.  Is my understanding correct?
>
> Thanks,
> -John

Re: [DISCUSS] coding convention for method - and class length

[Daan Hoogland]

John, Chip,

I don't mean to impose laws on people. A convention is by definition a
shared rule of thumb, in my understanding. If I am not correct in my
understanding of the English language and the connotations of the term
convention, I retract my proposal to add these two 'rules' to the coding
conventions.

regards,
Daan


On Fri, Jul 19, 2013 at 10:33 PM, John Burwell  wrote:

> All,
>
> I agree with Chip's sentiments.  Personally, I strive for the "one screen
> full" rule of thumb.  However, I think a hard and fast rule is a bit
> restrictive.
>
> Thanks,
> -John
>
> On Jul 18, 2013, at 5:21 PM, Mike Tutkowski 
> wrote:
>
> > Like eight or so years ago, I sent a method I had to modify to the
> printer
> > (so I could study it on regular paper) and it came out on 14 pages.
> >
> >
> > On Thu, Jul 18, 2013 at 3:04 PM, Donal Lafferty
> > wrote:
> >
> >>> -Original Message-
> >>> From: Chip Childers [mailto:chip.child...@sungard.com]
> >>> Sent: 18 July 2013 9:43 PM
> >>> To: dev@cloudstack.apache.org
> >>> Subject: Re: [DISCUSS] coding convention for method - and class length
> >>>
> >>> On Thu, Jul 18, 2013 at 02:34:36PM -0600, Mike Tutkowski wrote:
>  I'm not sure how I feel about an arbitrary number of lines per method
>  (although 200 is obviously quite high and I would recommend
>  modularizing such a method), but I'm not in favor of limiting the
>  number of methods per class (especially not to just 10). Some types of
>  objects simply need many discrete operations and 10 is too limiting.
> >>>
> >>> +1 to both thoughts.
> >>>
> >>> Smaller methods is good, but a specific number of lines as policy vs. a
> >> rule of
> >>> thumb are two different things.
> >>>
> >>> I completely agree with Daan's underlying concern though...  some of
> >> these
> >>> class files are horrible to try and comprehend.
> >>>
> >>> My favorite example:
> >>>
> >>> https://git-wip-
> >>>
> >>
> us.apache.org/repos/asf/cloudstack/?p=cloudstack.git;a=blob_plain;f=plugin
> >>> s/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceB
> >>> ase.java;hb=master
> >>>
> >> [Donal Lafferty]
> >> StyleCheck sets a default limit of 150 lines.
> >>
> >> Meanwhile, have you heard of the function 'best kick' in a certain
> >> company's soccer video game?  IIRC, it's several 1000 lines.
> >>
> >>
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *™*
>
>

Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

[Daan Hoogland]

Alex,

it falls through to 'UnDecided' if not known. Do you mean it should throw
something? or maybe add an extra 'UnDefined'?


On Fri, Jul 19, 2013 at 5:31 PM, Alex Huang  wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12685/
>
> Ship it!
>
> master: 2d4464d
>
> One review comment is if you are checking for the colon to see if the value 
> has the schema already, then shouldn't it also check if the schema matches 
> what's declared?  But that shouldn't block this review.  The code itself is 
> technically sound.
>
>
> - Alex Huang
>
> On July 17th, 2013, 3:46 p.m. UTC, daan Hoogland wrote:
>   Review request for cloudstack and Hugo Trippaers.
> By daan Hoogland.
>
> *Updated July 17, 2013, 3:46 p.m.*
>  *Bugs: * CLOUDSTACK-1532
>  *Repository: * cloudstack-git
> Description
>
> the review for the complete patch was open to long and no longer applicable, 
> so I am starting with smaller patches as this is really needed to implement 
> CLOUDSTACK-1532
>
>   Testing
>
> unit testing
>
>   Diffs
>
>- api/src/com/cloud/network/Networks.java (5aede05)
>- api/test/com/cloud/network/NetworksTest.java (PRE-CREATION)
>
> View Diff 
>

Re: Noisy ASFBot

[Prasanna Santhanam]

What I like particularly about ASFBot is that it lets me track JIRA
easily. If it is indeed creating noise may be some of the alerts can
be pruned down. The thing I suspect is annoying people is the git2jira
updates on bugs. I guess bot comments on JIRA bug reports needn't be
broadcast.

Humbeedoh in the #asfinfra channel is your man for tuning the bot.

On Sat, Jul 20, 2013 at 12:15:33PM +0200, Daan Hoogland wrote:
> I agree,
> 
> @Prasanna, can we make ignore default and /activate ASFBot? That would have
> my preference.
> 
> Daan
> 
> 
> On Sat, Jul 20, 2013 at 6:55 AM, Prasanna Santhanam  wrote:
> 
> > On Sat, Jul 20, 2013 at 12:48:28AM +0200, Hugo Trippaers wrote:
> > > Hey guys,
> > >
> > > I've noticed that our friendly bots on #cloudstack-dev make a lot
> > > more noise than we all do. I'm getting the impression that is is
> > > actually hindering people trying to get a conversation going. It
> > > difficult to keep track if ASFBot and Cato_Fong regularly make a lot
> > > of noise.
> > >
> > > While its very useful messages it might be better to tone that down
> > > a little until the user / bot ratio is more in favour of the users i
> > > think.
> > >
> > > What do you think?
> > >
> > > Cheers,
> > >
> > /ignore ASFBot or Cato_Fong?
> >
> > --
> > Prasanna.,
> >
> > 
> > Powered by BigRock.com
> >
> >

-- 
Prasanna.,


Powered by BigRock.com

Re: Noisy ASFBot

[Prasanna Santhanam]

I've turned off the noisy jobs from Cato_Fong. I suspect it isn't
useful to others but only to those who are debugging the tests.

Will enable them at a more appropriate time later.

On Sat, Jul 20, 2013 at 04:23:36PM +0530, Prasanna Santhanam wrote:
> What I like particularly about ASFBot is that it lets me track JIRA
> easily. If it is indeed creating noise may be some of the alerts can
> be pruned down. The thing I suspect is annoying people is the git2jira
> updates on bugs. I guess bot comments on JIRA bug reports needn't be
> broadcast.
> 
> Humbeedoh in the #asfinfra channel is your man for tuning the bot.
> 
> On Sat, Jul 20, 2013 at 12:15:33PM +0200, Daan Hoogland wrote:
> > I agree,
> > 
> > @Prasanna, can we make ignore default and /activate ASFBot? That would have
> > my preference.
> > 
> > Daan
> > 
> > 
> > On Sat, Jul 20, 2013 at 6:55 AM, Prasanna Santhanam  wrote:
> > 
> > > On Sat, Jul 20, 2013 at 12:48:28AM +0200, Hugo Trippaers wrote:
> > > > Hey guys,
> > > >
> > > > I've noticed that our friendly bots on #cloudstack-dev make a lot
> > > > more noise than we all do. I'm getting the impression that is is
> > > > actually hindering people trying to get a conversation going. It
> > > > difficult to keep track if ASFBot and Cato_Fong regularly make a lot
> > > > of noise.
> > > >
> > > > While its very useful messages it might be better to tone that down
> > > > a little until the user / bot ratio is more in favour of the users i
> > > > think.
> > > >
> > > > What do you think?
> > > >
> > > > Cheers,
> > > >
> > > /ignore ASFBot or Cato_Fong?
> > >
> > > --
> > > Prasanna.,
> > >
> > > 
> > > Powered by BigRock.com
> > >
> > >
> 
> -- 
> Prasanna.,
> 
> 
> Powered by BigRock.com

-- 
Prasanna.,


Powered by BigRock.com

Re: Review Request 12427: Fix for CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12427/#review23574
---


Commit 78f1092df12928f06646b3bc42d69cc45dd3b1d3 in branch refs/heads/master 
from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=78f1092 ]

CLOUDSTACK-3365: cluster level parameters 
cluster.(cpu/memory).allocated.capacity.notificationthreshold is not 
considering overcommit value


- ASF Subversion and Git Services


On July 19, 2013, 10:14 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12427/
> ---
> 
> (Updated July 19, 2013, 10:14 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Nitin 
> Mehta.
> 
> 
> Bugs: CLOUDSTACK-3365
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3365: cluster level parameters 
> cluster.(cpu/memory).allocated.capacity.notificationthreshold is not 
> considering overcommit value
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 
> 
> Diff: https://reviews.apache.org/r/12427/diff/
> 
> 
> Testing
> ---
> 
> Tested locally both with actual usage and over committed values for memory. 
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12427: Fix for CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12427/#review23575
---


Commit f604e3d9cc9073c8863bbd7dfc47fb6693a0b6f0 in branch refs/heads/4.2 from 
Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f604e3d ]

CLOUDSTACK-3365: cluster level parameters 
cluster.(cpu/memory).allocated.capacity.notificationthreshold is not 
considering overcommit value


- ASF Subversion and Git Services


On July 19, 2013, 10:14 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12427/
> ---
> 
> (Updated July 19, 2013, 10:14 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Nitin 
> Mehta.
> 
> 
> Bugs: CLOUDSTACK-3365
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3365: cluster level parameters 
> cluster.(cpu/memory).allocated.capacity.notificationthreshold is not 
> considering overcommit value
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 
> 
> Diff: https://reviews.apache.org/r/12427/diff/
> 
> 
> Testing
> ---
> 
> Tested locally both with actual usage and over committed values for memory. 
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12427: Fix for CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value

[Koushik Das]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12427/#review23576
---

Ship it!


master -> 78f1092df12928f06646b3bc42d69cc45dd3b1d3
4.2 -> f604e3d9cc9073c8863bbd7dfc47fb6693a0b6f0

Currently in the db. for total capacity of a resource actual value is stored 
but for used capacity the value stored takes into account over provisioning 
factor. As a result of this for any comparison the total capacity needs to be 
re-calibrated in the code everywhere based on over provisioning factor. Please 
open a new bug for future to store used/total capacity values in db. based on 
same scale factor.

- Koushik Das


On July 19, 2013, 10:14 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12427/
> ---
> 
> (Updated July 19, 2013, 10:14 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Nitin 
> Mehta.
> 
> 
> Bugs: CLOUDSTACK-3365
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3365: cluster level parameters 
> cluster.(cpu/memory).allocated.capacity.notificationthreshold is not 
> considering overcommit value
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 
> 
> Diff: https://reviews.apache.org/r/12427/diff/
> 
> 
> Testing
> ---
> 
> Tested locally both with actual usage and over committed values for memory. 
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12427: Fix for CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value

[Koushik Das]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12427/#review23577
---

Ship it!


Ship It!

- Koushik Das


On July 19, 2013, 10:14 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12427/
> ---
> 
> (Updated July 19, 2013, 10:14 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Nitin 
> Mehta.
> 
> 
> Bugs: CLOUDSTACK-3365
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3365: cluster level parameters 
> cluster.(cpu/memory).allocated.capacity.notificationthreshold is not 
> considering overcommit value
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 
> 
> Diff: https://reviews.apache.org/r/12427/diff/
> 
> 
> Testing
> ---
> 
> Tested locally both with actual usage and over committed values for memory. 
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

[Alex Huang]

Daan,

It should assert and throw a CloudRuntimeException.

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Exceptions+and+logging

--Alex

From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Saturday, July 20, 2013 3:25 AM
To: Alex Huang
Cc: Hugo Trippaers; cloudstack
Subject: Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to 
scan URIs

Alex,
it falls through to 'UnDecided' if not known. Do you mean it should throw 
something? or maybe add an extra 'UnDefined'?

On Fri, Jul 19, 2013 at 5:31 PM, Alex Huang 
mailto:alex.hu...@citrix.com>> wrote:
This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/12685/



Ship it!

master: 2d4464d



One review comment is if you are checking for the colon to see if the value has 
the schema already, then shouldn't it also check if the schema matches what's 
declared?  But that shouldn't block this review.  The code itself is 
technically sound.


- Alex Huang


On July 17th, 2013, 3:46 p.m. UTC, daan Hoogland wrote:
Review request for cloudstack and Hugo Trippaers.
By daan Hoogland.

Updated July 17, 2013, 3:46 p.m.
Bugs: CLOUDSTACK-1532
Repository: cloudstack-git
Description

the review for the complete patch was open to long and no longer applicable, so 
I am starting with smaller patches as this is really needed to implement 
CLOUDSTACK-1532


Testing

unit testing


Diffs

  *   api/src/com/cloud/network/Networks.java (5aede05)
  *   api/test/com/cloud/network/NetworksTest.java (PRE-CREATION)

View Diff

Re: Reviewboard and jenkins

[David Nalley]

On Sat, Jul 20, 2013 at 5:53 AM, Hugo Trippaers  wrote:
>
>
> Sent from my iPhone
>
> On 20 jul. 2013, at 10:09, Prasanna Santhanam  wrote:
>
>> On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote:
>>>
>>> On Jul 19, 2013, at 7:15 PM, Daan Hoogland  wrote:
>>>
 good stuff, does it run the risk of running while another instance is busy?
>>>
>>> Probably not, it's a single threaded script. I intend to use jenkins
>>> to schedule it and i can tell jenkins not to start another instance
>>> of a job once one is running.
>> should set a "quiet period" for the job so that it doesn't kick up
>> jobs for each checkin but a group instead. we'll run out of executors
>> fast if that happens.
>
> Every time the script runs it will look at the newest 20 submissions and 
> process them in order. That should be ok for now.
>

I actually wonder if we shouldn't pipeline this - e.g. - does the patch apply
If it applies does it build (and have unit tests pass)
If it builds does it package
If it packages, do the integration tests pass (or given the long
running nature, perhaps we have stages of that as well)

The first three are pretty easy to scale using on-demand resources.


>>
>>> There are probably some bug still in the script, but hey we got to
>>> start somewhere. ;-)
>>
>> Absolutely, could you put it up on cso-infra/github so we can hack it
>> and customize?
>
> Absolutely, will put it there this weekend if I have some time. I don't have 
> enough permissions to setup a new repo in CloudStack extras yet.
>


You do now.

Re: master unstable with CLOUDSTACK-3682/3683

[Sheng Yang]

CLOUDSTACK-3682: NPE in BridgeVifDriver causing systemvm startup failure in
KVM

https://issues.apache.org/jira/browse/CLOUDSTACK-3682

Agent log excerpt:
Jul 19 22:25:24 apache-81-3.fmt.vmops.com local1: 2013-07-20 05:25:24,952
WARN [cloud.agent.Agent] (agentRequest-Handler-1:null) Caught:
Jul 19 22:25:24 java.lang.NullPointerException
Jul 19 22:25:24 apache-81-3.fmt.vmops.com at
com.cloud.hypervisor.kvm.resource.BridgeVifDriver.plug(BridgeVifDriver.java:118)
Jul 19 22:25:24 apache-81-3.fmt.vmops.com at
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.createVif(LibvirtComputingResource.java:3504)
Jul 19 22:25:24 apache-81-3.fmt.vmops.com at
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.createVifs(LibvirtComputingResource.java:3266)
Jul 19 22:25:24 apache-81-3.fmt.vmops.com at
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.execute(LibvirtComputingResource.java:3291)
Jul 19 22:25:24 apache-81-3.fmt.vmops.com at
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1223)
Jul 19 22:25:24 apache-81-3.fmt.vmops.com at
com.cloud.agent.Agent.processRequest(Agent.java:499)
Jul 19 22:25:24 apache-81-3.fmt.vmops.com at
com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:807)
Jul 19 22:25:24 apache-81-3.fmt.vmops.com at
com.cloud.utils.nio.Task.run(Task.java:83)
Jul 19 22:25:24 apache-81-3.fmt.vmops.com at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
Jul 19 22:25:24 apache-81-3.fmt.vmops.com at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
Jul 19 22:25:24 apache-81-3.fmt.vmops.com at
java.lang.Thread.run(Thread.java:679)



CLOUDSTACK-3683: BeanCreationExceptions during systemvm start on XenServer

https://issues.apache.org/jira/browse/CLOUDSTACK-3683

Mgmt server log excerpt:
Jul 19 22:53:39 cloudstack-centos63.fmt.vmops.com local0: 2013-07-20
05:53:39,233 WARN [storage.secondary.SecondaryStorageManagerImpl]
(secstorage-1:null) Exception while trying to start secondary storage vm
Jul 19 22:53:39
cloudstack-centos63.fmt.vmops.comorg.springframework.beans.factory.BeanCreationException:
Error creating
bean with name
'org.apache.cloudstack.storage.datastore.PrimaryDataStoreImpl': Injection
of autowired dependencies failed; nested exception is
org.springframework.beans.factory.BeanCreationException: Could not autowire
field:
org.apache.cloudstack.engine.subsystem.api.storage.SnapshotDataFactory
org.apache.cloudstack.storage.datastore.PrimaryDataStoreImpl.snapshotFactory;
nested exception is
org.springframework.beans.factory.BeanCreationNotAllowedException: Error
creating bean with name 'dataStoreProviderManager': Singleton bean creation
not allowed while the singletons of this factory are in destruction (Do not
request a bean from a BeanFactory in a destroy method implementation!)

--Sheng


On Fri, Jul 19, 2013 at 11:44 PM, Prasanna Santhanam  wrote:

> Both bugs are blocking the run of tests on master.
>
>
> --
> Prasanna.,
>
> 
> Powered by BigRock.com
>
>

Re: Reviewboard and jenkins

[Prasanna Santhanam]

On Sat, Jul 20, 2013 at 09:46:59AM -0400, David Nalley wrote:
> On Sat, Jul 20, 2013 at 5:53 AM, Hugo Trippaers  wrote:
> >
> >
> > Sent from my iPhone
> >
> > On 20 jul. 2013, at 10:09, Prasanna Santhanam  wrote:
> >
> >> On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote:
> >>>
> >>> On Jul 19, 2013, at 7:15 PM, Daan Hoogland  
> >>> wrote:
> >>>
>  good stuff, does it run the risk of running while another instance is 
>  busy?
> >>>
> >>> Probably not, it's a single threaded script. I intend to use jenkins
> >>> to schedule it and i can tell jenkins not to start another instance
> >>> of a job once one is running.
> >> should set a "quiet period" for the job so that it doesn't kick up
> >> jobs for each checkin but a group instead. we'll run out of executors
> >> fast if that happens.
> >
> > Every time the script runs it will look at the newest 20 submissions and 
> > process them in order. That should be ok for now.
> >
> 
> I actually wonder if we shouldn't pipeline this - e.g. - does the
> patch apply
> If it applies does it build (and have unit tests pass)
> If it builds does it package
> If it packages, do the integration tests pass (or given the long
> running nature, perhaps we have stages of that as well)
> 
> The first three are pretty easy to scale using on-demand resources.

Yup that's what I'd like to do with this as well. The simulator
pipeline that Ian is helping build will tie in very well with this.

> 
> 
> >>
> >>> There are probably some bug still in the script, but hey we got to
> >>> start somewhere. ;-)
> >>
> >> Absolutely, could you put it up on cso-infra/github so we can hack it
> >> and customize?
> >
> > Absolutely, will put it there this weekend if I have some time. I don't 
> > have enough permissions to setup a new repo in CloudStack extras yet.
> >
> 
> 
> You do now.

-- 
Prasanna.,


Powered by BigRock.com

Error to start MS on 4.2

[Min Chen]

Hi there,

Anybody encounter this issue in starting MS on latest 4.2 branch?

INFO  [utils.component.ComponentContext] (Timer-2:) Starting 
com.cloud.ucs.manager.UcsManagerImpl
ERROR [utils.component.ComponentContext] (Timer-2:) Unhandled exception
java.lang.NumberFormatException: null
at java.lang.Integer.parseInt(Integer.java:417)
at java.lang.Integer.valueOf(Integer.java:554)
at com.cloud.ucs.manager.UcsManagerImpl.start(UcsManagerImpl.java:178)
at 
com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(ComponentContext.java:135)
at com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
at java.util.TimerThread.mainLoop(Timer.java:512)
at java.util.TimerThread.run(Timer.java:462)
Exception in thread "Timer-2" java.lang.RuntimeException: Unable to start 
com.cloud.ucs.manager.UcsManagerImpl
at 
com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(ComponentContext.java:141)
at com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
at java.util.TimerThread.mainLoop(Timer.java:512)
at java.util.TimerThread.run(Timer.java:462)
Caused by: java.lang.NumberFormatException: null
at java.lang.Integer.parseInt(Integer.java:417)
at java.lang.Integer.valueOf(Integer.java:554)
at com.cloud.ucs.manager.UcsManagerImpl.start(UcsManagerImpl.java:178)
at 
com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(ComponentContext.java:135)
... 3 more

CC Frank here to see if he knows any recent change on UcsManagerImpl.

Thanks
-min

RE: Error to start MS on 4.2

[Vijayendra Bhamidipati]

Hi Min,

Yes it's due to Frank's changes that went into 
0633608f8035f8f409c271fc6e7548699a63d366 on master (and 
a5ee39a54a8574b030655916d6156d049c99009c on 4.2). He introduced a new global 
configuration variable ucs.sync.blade.interval. So to not run into this error, 
either redeploy your db or insert a row in the configuration table manually and 
then bring up your server. Here's the entry in Config.java:

UCSSyncBladeInterval("Advanced", ManagementServer.class, Integer.class, 
"ucs.sync.blade.interval", "3600", "the interval cloudstack sync with UCS 
manager for available blades in case user remove blades from chassis without 
notifying CloudStack", null);

So doing:

mysql> insert into configuration values("Advanced", "DEFAULT", 
"management-server", "ucs.sync.blade.interval", "3600", "the interval 
cloudstack sync with UCS manager for available blades in case user remove 
blades from chassis without notifying CloudStack");
Query OK, 1 row affected (0.04 sec)

Should fix this.. on my tree I'm still at one commit behind Frank's.


Cheers!
Regards,
Vijay



-Original Message-
From: Min Chen [mailto:min.c...@citrix.com] 
Sent: Saturday, July 20, 2013 11:57 AM
To: dev@cloudstack.apache.org
Cc: Frank Zhang
Subject: Error to start MS on 4.2

Hi there,

Anybody encounter this issue in starting MS on latest 4.2 branch?

INFO  [utils.component.ComponentContext] (Timer-2:) Starting 
com.cloud.ucs.manager.UcsManagerImpl
ERROR [utils.component.ComponentContext] (Timer-2:) Unhandled exception
java.lang.NumberFormatException: null
at java.lang.Integer.parseInt(Integer.java:417)
at java.lang.Integer.valueOf(Integer.java:554)
at com.cloud.ucs.manager.UcsManagerImpl.start(UcsManagerImpl.java:178)
at 
com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(ComponentContext.java:135)
at com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
at java.util.TimerThread.mainLoop(Timer.java:512)
at java.util.TimerThread.run(Timer.java:462)
Exception in thread "Timer-2" java.lang.RuntimeException: Unable to start 
com.cloud.ucs.manager.UcsManagerImpl
at 
com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(ComponentContext.java:141)
at com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
at java.util.TimerThread.mainLoop(Timer.java:512)
at java.util.TimerThread.run(Timer.java:462)
Caused by: java.lang.NumberFormatException: null at 
java.lang.Integer.parseInt(Integer.java:417)
at java.lang.Integer.valueOf(Integer.java:554)
at com.cloud.ucs.manager.UcsManagerImpl.start(UcsManagerImpl.java:178)
at 
com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(ComponentContext.java:135)
... 3 more

CC Frank here to see if he knows any recent change on UcsManagerImpl.

Thanks
-min

Re: Error to start MS on 4.2

[Min Chen]

Thanks Vijay. I just figured out that trick myself:) I will check in a fix
to 4.2, seems that he forgot to seed this  config value in
schema410to420.sql.

-min

On 7/20/13 12:05 PM, "Vijayendra Bhamidipati"
 wrote:

>Hi Min,
>
>Yes it's due to Frank's changes that went into
>0633608f8035f8f409c271fc6e7548699a63d366 on master (and
>a5ee39a54a8574b030655916d6156d049c99009c on 4.2). He introduced a new
>global configuration variable ucs.sync.blade.interval. So to not run into
>this error, either redeploy your db or insert a row in the configuration
>table manually and then bring up your server. Here's the entry in
>Config.java:
>
>UCSSyncBladeInterval("Advanced", ManagementServer.class, Integer.class,
>"ucs.sync.blade.interval", "3600", "the interval cloudstack sync with UCS
>manager for available blades in case user remove blades from chassis
>without notifying CloudStack", null);
>
>So doing:
>
>mysql> insert into configuration values("Advanced", "DEFAULT",
>"management-server", "ucs.sync.blade.interval", "3600", "the interval
>cloudstack sync with UCS manager for available blades in case user remove
>blades from chassis without notifying CloudStack");
>Query OK, 1 row affected (0.04 sec)
>
>Should fix this.. on my tree I'm still at one commit behind Frank's.
>
>
>Cheers!
>Regards,
>Vijay
>
>
>
>-Original Message-
>From: Min Chen [mailto:min.c...@citrix.com]
>Sent: Saturday, July 20, 2013 11:57 AM
>To: dev@cloudstack.apache.org
>Cc: Frank Zhang
>Subject: Error to start MS on 4.2
>
>Hi there,
>
>Anybody encounter this issue in starting MS on latest 4.2 branch?
>
>INFO  [utils.component.ComponentContext] (Timer-2:) Starting
>com.cloud.ucs.manager.UcsManagerImpl
>ERROR [utils.component.ComponentContext] (Timer-2:) Unhandled exception
>java.lang.NumberFormatException: null
>at java.lang.Integer.parseInt(Integer.java:417)
>at java.lang.Integer.valueOf(Integer.java:554)
>at com.cloud.ucs.manager.UcsManagerImpl.start(UcsManagerImpl.java:178)
>at 
>com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Compone
>ntContext.java:135)
>at 
>com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
>at java.util.TimerThread.mainLoop(Timer.java:512)
>at java.util.TimerThread.run(Timer.java:462)
>Exception in thread "Timer-2" java.lang.RuntimeException: Unable to start
>com.cloud.ucs.manager.UcsManagerImpl
>at 
>com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Compone
>ntContext.java:141)
>at 
>com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
>at java.util.TimerThread.mainLoop(Timer.java:512)
>at java.util.TimerThread.run(Timer.java:462)
>Caused by: java.lang.NumberFormatException: null at
>java.lang.Integer.parseInt(Integer.java:417)
>at java.lang.Integer.valueOf(Integer.java:554)
>at com.cloud.ucs.manager.UcsManagerImpl.start(UcsManagerImpl.java:178)
>at 
>com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Compone
>ntContext.java:135)
>... 3 more
>
>CC Frank here to see if he knows any recent change on UcsManagerImpl.
>
>Thanks
>-min

Re: Review Request 11942: ProcessUtil cleanup

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11942/
---

(Updated July 20, 2013, 8:01 p.m.)


Review request for cloudstack.


Changes
---

no change, only rebased


Repository: cloudstack-git


Description
---

- possible resource leak closed
- file content read uses now commons-lang FileUtils
- Added unit tests


Diffs (updated)
-

  utils/src/com/cloud/utils/ProcessUtil.java c9fdf35 
  utils/test/com/cloud/utils/ProcessUtilTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/11942/diff/


Testing
---

test included


Thanks,

Laszlo Hornyak

Another way to save your build time

[Edison Su]

If you already know how to enable hostswap with jetty + maven + 
eclipse/intellij, please ignore.
There are two links:
https://gist.github.com/naaman/1053217
http://www.clickonchris.com/2010/05/configuring-jetty-maven-and-eclipse-together-with-hot-deploy/
If you follow their steps, test and develop cloudstack mgt server will be much 
much easier.

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

[Mike Tutkowski]

> On June 28, 2013, 9:42 a.m., John Burwell wrote:
> > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java,
> >  line 3927
> > 
> >
> > Use an ExceutorService.  Don't implement your own thread pool.  Also, 
> > why are we multi-threading?  Are there performance numbers to justify this 
> > complexity?

It often takes on the order of seconds to rescan HBAs and VMFS datastores and - 
due to certain VMware issues - these kinds of scans need to happen several 
times while I'm attaching and detaching volumes. Instead of taking, say, 3 
seconds per scan times the number of hosts and making the user wait that long, 
I perform these scans in parallel. This can be the difference between the user 
waiting only 10 - 15 seconds or having to wait over a minute.

I have converted the custom threading "pool" to use the ExecutorService.


- Mike


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11479/#review22508
---


On June 21, 2013, 10:35 a.m., Mike Tutkowski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11479/
> ---
> 
> (Updated June 21, 2013, 10:35 a.m.)
> 
> 
> Review request for cloudstack, edison su and John Burwell.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This patch implements a storage plug-in for SolidFire. The plug-in is based 
> on the new storage framework that went in with 4.2, as well.
> 
> In addition, there are GUI (and related) changes to enable admins and end 
> users to specify a Min, Max, and Burst number of IOPS for a Disk Offering. 
> These fields (although optional) tend to follow the pattern previously 
> established for the Disk Size field.
> 
> Also, the storage framework itself has been enhanced. For example, it now 
> supports creating and deleting storage repositories as is necessary for a 
> dynamic type of zone-wide primary storage (such as the SolidFire plug-in is).
> 
> The desired behavior of the software is as such:
> 
> * Allow an admin to invoke the CloudStack API to add Primary Storage based on 
> the SolidFire plug-in.
> 
> * Allow an admin to create a Disk Offering that specifies a Min, Max, and 
> Burst number of IOPS or allows the admin to pass this ability on to the end 
> user.
> 
> * Allow an end user to execute such a Disk Offering. As is the case for any 
> Disk Offering, this leads to the creation of a row in the volumes table.
> 
> * Allow an end user to attach the resultant volume (noted in the DB) to a VM. 
> The storage framework invokes logic in the plug-in and the plug-in creates a 
> volume on its SAN with the correct size and IOPS values. The agent software 
> for XenServer detects that such an attach is being requested and creates a 
> Storage Repository (and single VDI within the SR) based on the storage IP 
> address of the SAN and the IQN of the volume. The VDI is then hooked up to 
> the VM.
> 
> * Allow an end user to detach the volume. This leads to the destruction of 
> the SR, but the SAN volume remains intact and can be reattached later to any 
> VM running in a XenServer resource pool in the zone.
> 
> * Allow an end user to delete the volume. This leads to the volume being 
> deleted on the SAN and being marked in the CloudStack DB as deleted.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/offering/DiskOffering.java ae4528c 
>   api/src/com/cloud/storage/StoragePool.java 8b95383 
>   api/src/com/cloud/storage/Volume.java 4903594 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 1704ca3 
>   
> api/src/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java
>  a2c5f77 
>   
> api/src/org/apache/cloudstack/api/command/admin/storage/CreateStoragePoolCmd.java
>  74eb2b9 
>   api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java 
> 86a494b 
>   api/src/org/apache/cloudstack/api/response/DiskOfferingResponse.java 
> 35cf21a 
>   api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java 965407d 
>   api/src/org/apache/cloudstack/api/response/VolumeResponse.java e3463bd 
>   client/WEB-INF/classes/resources/messages.properties a0a36c8 
>   client/pom.xml ab758eb 
>   client/tomcatconf/applicationContext.xml.in 049e483 
>   core/src/com/cloud/agent/api/AttachVolumeAnswer.java b377b7c 
>   core/src/com/cloud/agent/api/AttachVolumeCommand.java 2658262 
>   core/test/org/apache/cloudstack/api/agent/test/AttachVolumeAnswerTest.java 
> 251a6cb 
>   core/test/org/apache/cloudstack/api/agent/test/AttachVolumeCommandTest.java 
> 1ec416a 
>   
> core/test/org/apache/cloudstack/api/agent/test/BackupSnapshotCommandTest.java 
> 44d53aa 
>   core

Re: Error to start MS on 4.2

[Koushik Das]

The code needs to handle the case when the db. entry is not present. It should 
fall back on some default value.

-Koushik

On 21-Jul-2013, at 12:38 AM, Min Chen  wrote:

> Thanks Vijay. I just figured out that trick myself:) I will check in a fix
> to 4.2, seems that he forgot to seed this  config value in
> schema410to420.sql.
> 
> -min
> 
> On 7/20/13 12:05 PM, "Vijayendra Bhamidipati"
>  wrote:
> 
>> Hi Min,
>> 
>> Yes it's due to Frank's changes that went into
>> 0633608f8035f8f409c271fc6e7548699a63d366 on master (and
>> a5ee39a54a8574b030655916d6156d049c99009c on 4.2). He introduced a new
>> global configuration variable ucs.sync.blade.interval. So to not run into
>> this error, either redeploy your db or insert a row in the configuration
>> table manually and then bring up your server. Here's the entry in
>> Config.java:
>> 
>> UCSSyncBladeInterval("Advanced", ManagementServer.class, Integer.class,
>> "ucs.sync.blade.interval", "3600", "the interval cloudstack sync with UCS
>> manager for available blades in case user remove blades from chassis
>> without notifying CloudStack", null);
>> 
>> So doing:
>> 
>> mysql> insert into configuration values("Advanced", "DEFAULT",
>> "management-server", "ucs.sync.blade.interval", "3600", "the interval
>> cloudstack sync with UCS manager for available blades in case user remove
>> blades from chassis without notifying CloudStack");
>> Query OK, 1 row affected (0.04 sec)
>> 
>> Should fix this.. on my tree I'm still at one commit behind Frank's.
>> 
>> 
>> Cheers!
>> Regards,
>> Vijay
>> 
>> 
>> 
>> -Original Message-
>> From: Min Chen [mailto:min.c...@citrix.com]
>> Sent: Saturday, July 20, 2013 11:57 AM
>> To: dev@cloudstack.apache.org
>> Cc: Frank Zhang
>> Subject: Error to start MS on 4.2
>> 
>> Hi there,
>> 
>> Anybody encounter this issue in starting MS on latest 4.2 branch?
>> 
>> INFO  [utils.component.ComponentContext] (Timer-2:) Starting
>> com.cloud.ucs.manager.UcsManagerImpl
>> ERROR [utils.component.ComponentContext] (Timer-2:) Unhandled exception
>> java.lang.NumberFormatException: null
>> at java.lang.Integer.parseInt(Integer.java:417)
>> at java.lang.Integer.valueOf(Integer.java:554)
>> at com.cloud.ucs.manager.UcsManagerImpl.start(UcsManagerImpl.java:178)
>> at 
>> com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Compone
>> ntContext.java:135)
>> at 
>> com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
>> at java.util.TimerThread.mainLoop(Timer.java:512)
>> at java.util.TimerThread.run(Timer.java:462)
>> Exception in thread "Timer-2" java.lang.RuntimeException: Unable to start
>> com.cloud.ucs.manager.UcsManagerImpl
>> at 
>> com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Compone
>> ntContext.java:141)
>> at 
>> com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:50)
>> at java.util.TimerThread.mainLoop(Timer.java:512)
>> at java.util.TimerThread.run(Timer.java:462)
>> Caused by: java.lang.NumberFormatException: null at
>> java.lang.Integer.parseInt(Integer.java:417)
>> at java.lang.Integer.valueOf(Integer.java:554)
>> at com.cloud.ucs.manager.UcsManagerImpl.start(UcsManagerImpl.java:178)
>> at 
>> com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Compone
>> ntContext.java:135)
>> ... 3 more
>> 
>> CC Frank here to see if he knows any recent change on UcsManagerImpl.
>> 
>> Thanks
>> -min
>