Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

[Gaurav Aradhye]

> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_cpu_limits.py, line 186
> > 
> >
> > `delete` is not handled?

Hi Prasanna, Can you please elaborate this? Delete condition seems to be 
handled.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10828/#review19846
---


On April 29, 2013, 8:36 a.m., Chirag Jog wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10828/
> ---
> 
> (Updated April 29, 2013, 8:36 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam, sailaja mada, and Girish 
> Shilamkar.
> 
> 
> Description
> ---
> 
> Here is the detailed test plan: 
> https://issues.apache.org/jira/secure/attachment/12571551/LimitResourcesTestPlan1.xlsx
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1466.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chirag Jog
> 
>

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10828/#review21051
---



test/integration/component/test_cpu_limits.py


I see it. Please ignore.


- Prasanna Santhanam


On April 29, 2013, 8:36 a.m., Chirag Jog wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10828/
> ---
> 
> (Updated April 29, 2013, 8:36 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam, sailaja mada, and Girish 
> Shilamkar.
> 
> 
> Description
> ---
> 
> Here is the detailed test plan: 
> https://issues.apache.org/jira/secure/attachment/12571551/LimitResourcesTestPlan1.xlsx
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1466.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chirag Jog
> 
>

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

[Hugo Trippaers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11428/#review21052
---

Ship it!


Ship It!

- Hugo Trippaers


On May 27, 2013, 1:46 a.m., Hiroaki Kawai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11428/
> ---
> 
> (Updated May 27, 2013, 1:46 a.m.)
> 
> 
> Review request for cloudstack, Sheng Yang and Hugo Trippaers.
> 
> 
> Description
> ---
> 
> Ovs brcompat will be obsolete, so if network.bridge.type was
> set to openvswitch, we'll use ovs command explicitly.
> 
> 
> This addresses bug CLOUDSTACK-2327.
> 
> 
> Diffs
> -
> 
>   agent/bindir/cloud-setup-agent.in 5e2ba09 
>   python/lib/cloudutils/globalEnv.py 94d981f 
>   python/lib/cloudutils/networkConfig.py b6b729a 
>   python/lib/cloudutils/serviceConfig.py 1e32d0f 
> 
> Diff: https://reviews.apache.org/r/11428/diff/
> 
> 
> Testing
> ---
> 
> Tested with my local machines. 
> - create .rpm, .deb
> - install it (CentOS 6.4 and Ubuntu 13.04)
> - add the computing node in management server
> 
> 
> Thanks,
> 
> Hiroaki Kawai
> 
>

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

[Hugo Trippaers]

> On May 27, 2013, 7:21 a.m., Hugo Trippaers wrote:
> > Ship It!

Looking good, you can commit it yourself right?


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11428/#review21052
---


On May 27, 2013, 1:46 a.m., Hiroaki Kawai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11428/
> ---
> 
> (Updated May 27, 2013, 1:46 a.m.)
> 
> 
> Review request for cloudstack, Sheng Yang and Hugo Trippaers.
> 
> 
> Description
> ---
> 
> Ovs brcompat will be obsolete, so if network.bridge.type was
> set to openvswitch, we'll use ovs command explicitly.
> 
> 
> This addresses bug CLOUDSTACK-2327.
> 
> 
> Diffs
> -
> 
>   agent/bindir/cloud-setup-agent.in 5e2ba09 
>   python/lib/cloudutils/globalEnv.py 94d981f 
>   python/lib/cloudutils/networkConfig.py b6b729a 
>   python/lib/cloudutils/serviceConfig.py 1e32d0f 
> 
> Diff: https://reviews.apache.org/r/11428/diff/
> 
> 
> Testing
> ---
> 
> Tested with my local machines. 
> - create .rpm, .deb
> - install it (CentOS 6.4 and Ubuntu 13.04)
> - add the computing node in management server
> 
> 
> Thanks,
> 
> Hiroaki Kawai
> 
>

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11428/#review21055
---


Commit a16b707250fde01f24c9ab6f11189b630dd70962 in branch refs/heads/master 
from Hiroaki KAWAI 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a16b707 ]

CLOUDSTACK-2327: make cloud-setup-agent ovs aware

Ovs brcompat will be obsolete, so if network.bridge.type was
set to openvswitch, we'll use ovs command explicitly.

Signed-off-by: Hiroaki KAWAI 


- ASF Subversion and Git Services


On May 27, 2013, 1:46 a.m., Hiroaki Kawai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11428/
> ---
> 
> (Updated May 27, 2013, 1:46 a.m.)
> 
> 
> Review request for cloudstack, Sheng Yang and Hugo Trippaers.
> 
> 
> Description
> ---
> 
> Ovs brcompat will be obsolete, so if network.bridge.type was
> set to openvswitch, we'll use ovs command explicitly.
> 
> 
> This addresses bug CLOUDSTACK-2327.
> 
> 
> Diffs
> -
> 
>   agent/bindir/cloud-setup-agent.in 5e2ba09 
>   python/lib/cloudutils/globalEnv.py 94d981f 
>   python/lib/cloudutils/networkConfig.py b6b729a 
>   python/lib/cloudutils/serviceConfig.py 1e32d0f 
> 
> Diff: https://reviews.apache.org/r/11428/diff/
> 
> 
> Testing
> ---
> 
> Tested with my local machines. 
> - create .rpm, .deb
> - install it (CentOS 6.4 and Ubuntu 13.04)
> - add the computing node in management server
> 
> 
> Thanks,
> 
> Hiroaki Kawai
> 
>

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11428/#review21054
---


Commit 8faf845889b28157a2ecbd6e406d73a326b27756 in branch refs/heads/4.1 from 
Hiroaki KAWAI 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8faf845 ]

CLOUDSTACK-2327: make cloud-setup-agent ovs aware

Ovs brcompat will be obsolete, so if network.bridge.type was
set to openvswitch, we'll use ovs command explicitly.

Signed-off-by: Hiroaki KAWAI 


- ASF Subversion and Git Services


On May 27, 2013, 1:46 a.m., Hiroaki Kawai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11428/
> ---
> 
> (Updated May 27, 2013, 1:46 a.m.)
> 
> 
> Review request for cloudstack, Sheng Yang and Hugo Trippaers.
> 
> 
> Description
> ---
> 
> Ovs brcompat will be obsolete, so if network.bridge.type was
> set to openvswitch, we'll use ovs command explicitly.
> 
> 
> This addresses bug CLOUDSTACK-2327.
> 
> 
> Diffs
> -
> 
>   agent/bindir/cloud-setup-agent.in 5e2ba09 
>   python/lib/cloudutils/globalEnv.py 94d981f 
>   python/lib/cloudutils/networkConfig.py b6b729a 
>   python/lib/cloudutils/serviceConfig.py 1e32d0f 
> 
> Diff: https://reviews.apache.org/r/11428/diff/
> 
> 
> Testing
> ---
> 
> Tested with my local machines. 
> - create .rpm, .deb
> - install it (CentOS 6.4 and Ubuntu 13.04)
> - add the computing node in management server
> 
> 
> Thanks,
> 
> Hiroaki Kawai
> 
>

Re: Question about Review Request

[Sebastien Goasguen]

On May 27, 2013, at 1:55 AM, Mike Tutkowski  
wrote:

> Hi everyone,
> 
> I'm trying to submit code for the first time.
> 
> I'm following the instructions here:
> 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines
> 
> When it says to upload my diff, I assume it means my .patch file. Is that
> correct?
> 
> I generate such a file this way:
> 
> git format-patch upstream/master --stdout > solidfire_plugin.patch
> 

That should work. I usually just do:
git format-patch master --stdout > my.patch

> It works just fine, but when I try to upload it by clicking on the Create
> Review Request button, I get the following error:
> 
> The file
> 'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java'
> (r5f45a62) could not be found in the repository
> *
> *

Create a fresh branch out of your local master and try to see if your patch 
applies cleanly:
git --check apply ( I think).

Maybe it's a relative path issue (just a wild guess).


> I'm not sure why it says this because this file is a part of the current
> repository.
> 
> Would someone be able to explain what I might be doing wrong here?
> 
> I did update from the ACS repo and merge its master (my upstream/master)
> into my solidfire_plugin branch recently. After doing this, I committed the
> changes and made my .patch file.
> 

Did you check your patch making sure that all changed files were staged ?

I always do a git status -s , it's very helpful.

> Thanks!
> 
> -- 
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *™*

Re: [DISCUSS] Should we be releasing -beta releases?

[Sebastien Goasguen]

On May 24, 2013, at 12:26 PM, Chip Childers  wrote:

> On Tue, May 14, 2013 at 10:41:30AM -0400, Chip Childers wrote:
>> As a way to get more user feedback on our major feature releases, what
>> does everyone think about releasing one or two -beta releases for each
>> major feature release?
>> 
>> This might fall in line with some of the stated concerns about our
>> release schedule (see [1]).  I've stated a desire to be quicker about
>> our releases (my vote was 4 months).  I've also been saying quite
>> publicly that we should never release if we know about upgrade issues
>> (that's the cost of having actual users of our project, which I'm more
>> than willing for us to pay).
>> 
>> Perhaps -betaX releases would be helpful to get attention from the users
>> to test the release (including upgrade paths).  The stated assumption
>> could be: -beta releases are not releases that can be upgraded *from*,
>> but are intended to help support testing by end users that want to check
>> the upcoming release against their expected feature set and upgrade
>> path.
>> 
>> I would see the first -beta-1 being released about 1 month after feature
>> freeze.  For example, for 4.2.0, it would be on 2013-06-30.  I would
>> only do a -beta-2 (or later) beta release if required due to testing
>> results.  I would also suggest that the -beta-* releases would *not*
>> have any particular quality criteria (well...  perhaps minimal, like
>> blocking on issues that fundamentally make the software unstable).
>> 
>> I'm not sure about my own proposal here, but I wanted to throw it out
>> and see if any of you have feedback / thoughts.
>> 
>> -chip
>> 
>> [1] http://markmail.org/message/3ctdwor5hfbpa3vx
> 
> To summarize the discussions of this thread:
> 
> 1) The idea of ensuring that we get user testing of release candidates
> is one that most agree with.
> 
> 2) Concerns were raised about the overhead of "officially" releasing
> beta releases, especially if there is any expectation that there would
> be an upgrade path from a -beta to an official release.
> 
> I'd like to simplify this by saying that we should actually plan on
> announcing the start of each round of voting on RC's to the users@ list.
> We can get feedback from them on each round.  

Why don't we include users@ in the voting thread in the first place ?
The entire community can vote, correct ? committers and non-committers.

Asking @users for feedback make it sound a little bit like feedback is welcome 
but not voting.

> And while I don't really
> love having a bunch of rounds of voting, 4.1.0 has basically proven that
> user engagement testing the RC's is critical.  I think that we might
> also consider (at a release manager's discretion) periodically
> announcing a request for testing of the feature branch's code during the
> QA part of our release cycles.

+1

> 
> Shout if you disagree.

Commits into 4.1 without patch request

[Wido den Hollander]

Hi Hiroaki,

I've noticed you pushed a couple of commits into both master and 4.1 
without going through the patch request on the mailinglist.


For example in 4.1:
* 9bc43930b822a294c863e954bc5b39fc4b506f46
* 8faf845889b28157a2ecbd6e406d73a326b27756

When the 4.1 branch was frozen the agreement was/is that all commits 
into the 4.1 branch have to go through the mailinglist so Chip Childers 
can pick them up and cherry-pick them into the 4.1 branch.


I see you made some good commits, but the 4.1 branch is actually frozen 
at this point.


The Debian package fixes are very welcome though! But since we are in 
the process of voting for a 4.1 release we have to make sure nothing 
changes in the 4.1 branch.


Maybe you weren't aware of this agreement, so that why I'm sending this 
to you.


Thanks!

Wido

[VOTE] List CloudStack related books on the website

[Sebastien Goasguen]

Hi,

After a relatively long discussion on the marketing@ list about the "Packt 
Book" [1] I would like to call a vote.

Proposal:

I propose to list CloudStack related books on our website [2]. The page listing 
these books would contain the following disclaimer:

"This listing does not represent official endorsement by the Apache CloudStack 
project. The Apache CloudStack project does not recommend one book versus 
another nor does it guarantee the quality of the books."

Inclusion of a book in the listing would be done via a vote on the marketing@ 
list.


As a quick summary, alternatives to this proposal were to:
1-not do anything
2-list the books on the wiki

A few of us have already expressed their opinions and discussed the 
possibilities. Check [1]. 

Vote will be open for 96 hours (To accommodate Memorial day in the USA).

Reply with:

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

PS: If edits of the disclaimer are needed but that they do not change the 
meaning of it, the disclaimer will be modified but the vote will not be 
restarted.

[1] http://markmail.org/thread/r4qdmbonmx6yq2uv
[2] http://cloudstack.apache.org

-Sebastien

Re: [VOTE] List CloudStack related books on the website

[Giles Sirett]

+1


Kind Regards
Giles

D: +44 20 3603 0541 | M: +44 796 111 
2055
giles.sir...@shapeblue.com

On 27 May 2013, at 09:27, "Sebastien Goasguen" 
mailto:run...@gmail.com>> wrote:

Hi,

After a relatively long discussion on the marketing@ list about the "Packt 
Book" [1] I would like to call a vote.

Proposal:

I propose to list CloudStack related books on our website [2]. The page listing 
these books would contain the following disclaimer:

"This listing does not represent official endorsement by the Apache CloudStack 
project. The Apache CloudStack project does not recommend one book versus 
another nor does it guarantee the quality of the books."

Inclusion of a book in the listing would be done via a vote on the marketing@ 
list.


As a quick summary, alternatives to this proposal were to:
1-not do anything
2-list the books on the wiki

A few of us have already expressed their opinions and discussed the 
possibilities. Check [1].

Vote will be open for 96 hours (To accommodate Memorial day in the USA).

Reply with:

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

PS: If edits of the disclaimer are needed but that they do not change the 
meaning of it, the disclaimer will be modified but the vote will not be 
restarted.

[1] http://markmail.org/thread/r4qdmbonmx6yq2uv
[2] http://cloudstack.apache.org

-Sebastien
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is operated under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: Commits into 4.1 without patch request

[Hiroaki KAWAI]

Hi Wido,

Thank you for telling me that.

I remembered that Chip has sent how to control 4.1 release.
http://markmail.org/message/qkkxycablpsmogsx

https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+4.1+Release

Chip, the commits I pushed into 4.1 were:
- 2 patch commit for debian packaging issues
- 9bc4393 for Japanese translations
- 8faf845 for KVM OVS setup issue

I'm sorry I should have send a patch request. But I'm sure
first 3 are really release blockers.

Regards,


(2013/05/27 17:10), Wido den Hollander wrote:

Hi Hiroaki,

I've noticed you pushed a couple of commits into both master and 4.1
without going through the patch request on the mailinglist.

For example in 4.1:
* 9bc43930b822a294c863e954bc5b39fc4b506f46
* 8faf845889b28157a2ecbd6e406d73a326b27756

When the 4.1 branch was frozen the agreement was/is that all commits
into the 4.1 branch have to go through the mailinglist so Chip Childers
can pick them up and cherry-pick them into the 4.1 branch.

I see you made some good commits, but the 4.1 branch is actually frozen
at this point.

The Debian package fixes are very welcome though! But since we are in
the process of voting for a 4.1 release we have to make sure nothing
changes in the 4.1 branch.

Maybe you weren't aware of this agreement, so that why I'm sending this
to you.

Thanks!

Wido

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

[Daan Hoogland]

Being in the habit of replying on my own mails as I seems to be on this list;

This seems to be related to eclipse refresh/build code. Does anybody have a 
solution to it? The problem is not consistently present but all the more 
irritating.

Regards,

-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] 
Sent: maandag 27 mei 2013 7:49
To: dev@cloudstack.apache.org
Subject: master build breaks at com.cloud.vpc.NetworkACLServiceTest

LS,

Lately I've been getting, "com.cloud.exception.InvalidParameterValueException: 
ACL item with number 1 already exists in ACL: null", while building cloudstack. 
I first thought it was my own hack so I don't know when it was introduced (it 
is in a clean master that it happens). The full surfire report follows:

---
Test set: com.cloud.vpc.NetworkACLServiceTest
---
Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.219 sec <<< 
FAILURE!
testCreateACLItem(com.cloud.vpc.NetworkACLServiceTest)  Time elapsed: 0.016 sec 
 <<< ERROR!
com.cloud.exception.InvalidParameterValueException: ACL item with number 1 
already exists in ACL: null
at 
com.cloud.network.vpc.NetworkACLServiceImpl.createNetworkACLItem(NetworkACLServiceImpl.java:270)
at 
com.cloud.vpc.NetworkACLServiceTest.testCreateACLItem(NetworkACLServiceTest.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at 
org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:74)
at 
org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:83)
at 
org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:72)
at 
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:231)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
at 
org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
at 
org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:71)
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
at 
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:174)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at 
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at 
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at 
org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)

Re: [VOTE] List CloudStack related books on the website

[Nguyen Anh Tu]

+1


2013/5/27 Giles Sirett 

> +1
>
>
> Kind Regards
> Giles
>
> D: +44 20 3603 0541 | M: +44 796 111
> 2055
> giles.sir...@shapeblue.com
>
> On 27 May 2013, at 09:27, "Sebastien Goasguen"  run...@gmail.com>> wrote:
>
> Hi,
>
> After a relatively long discussion on the marketing@ list about the
> "Packt Book" [1] I would like to call a vote.
>
> Proposal:
> 
> I propose to list CloudStack related books on our website [2]. The page
> listing these books would contain the following disclaimer:
>
> "This listing does not represent official endorsement by the Apache
> CloudStack project. The Apache CloudStack project does not recommend one
> book versus another nor does it guarantee the quality of the books."
>
> Inclusion of a book in the listing would be done via a vote on the
> marketing@ list.
> 
>
> As a quick summary, alternatives to this proposal were to:
> 1-not do anything
> 2-list the books on the wiki
>
> A few of us have already expressed their opinions and discussed the
> possibilities. Check [1].
>
> Vote will be open for 96 hours (To accommodate Memorial day in the USA).
>
> Reply with:
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
> PS: If edits of the disclaimer are needed but that they do not change the
> meaning of it, the disclaimer will be modified but the vote will not be
> restarted.
>
> [1] http://markmail.org/thread/r4qdmbonmx6yq2uv
> [2] http://cloudstack.apache.org
>
> -Sebastien
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is
> operated under license from Shape Blue Ltd. ShapeBlue is a registered
> trademark.
>



-- 

N.g.U.y.e.N.A.n.H.t.U

Re: [VOTE] List CloudStack related books on the website

[Ryan Lei]

+1 since it is the only English book on CloudStack as I know.
Listing it on the official website does not necessarily mean promoting it,
but it's important to keep the disclaimer.
The quality of the book will be reflected in Amazon ratings or some other
review blogs or even word of mouth.
Be sure to list all the future books to make things fair.


On Mon, May 27, 2013 at 5:56 PM, Nguyen Anh Tu  wrote:

> +1
>
>
> 2013/5/27 Giles Sirett 
>
> > +1
> >
> >
> > Kind Regards
> > Giles
> >
> > D: +44 20 3603 0541 | M: +44 796 111
> > 2055
> > giles.sir...@shapeblue.com
> >
> > On 27 May 2013, at 09:27, "Sebastien Goasguen"  > run...@gmail.com>> wrote:
> >
> > Hi,
> >
> > After a relatively long discussion on the marketing@ list about the
> > "Packt Book" [1] I would like to call a vote.
> >
> > Proposal:
> > 
> > I propose to list CloudStack related books on our website [2]. The page
> > listing these books would contain the following disclaimer:
> >
> > "This listing does not represent official endorsement by the Apache
> > CloudStack project. The Apache CloudStack project does not recommend one
> > book versus another nor does it guarantee the quality of the books."
> >
> > Inclusion of a book in the listing would be done via a vote on the
> > marketing@ list.
> > 
> >
> > As a quick summary, alternatives to this proposal were to:
> > 1-not do anything
> > 2-list the books on the wiki
> >
> > A few of us have already expressed their opinions and discussed the
> > possibilities. Check [1].
> >
> > Vote will be open for 96 hours (To accommodate Memorial day in the USA).
> >
> > Reply with:
> >
> > [ ] +1  approve
> > [ ] +0  no opinion
> > [ ] -1  disapprove (and reason why)
> >
> > PS: If edits of the disclaimer are needed but that they do not change the
> > meaning of it, the disclaimer will be modified but the vote will not be
> > restarted.
> >
> > [1] http://markmail.org/thread/r4qdmbonmx6yq2uv
> > [2] http://cloudstack.apache.org
> >
> > -Sebastien
> > This email and any attachments to it may be confidential and are intended
> > solely for the use of the individual to whom it is addressed. Any views
> or
> > opinions expressed are solely those of the author and do not necessarily
> > represent those of Shape Blue Ltd or related companies. If you are not
> the
> > intended recipient of this email, you must neither take any action based
> > upon its contents, nor copy or show it to anyone. Please contact the
> sender
> > if you believe you have received this email in error. Shape Blue Ltd is a
> > company incorporated in England & Wales. ShapeBlue Services India LLP is
> > operated under license from Shape Blue Ltd. ShapeBlue is a registered
> > trademark.
> >
>
>
>
> --
>
> N.g.U.y.e.N.A.n.H.t.U
>

Re: patchviasocket: Why in Perl and not native Java?

[Wido den Hollander]

On 05/26/2013 06:41 PM, Marcus Sorensen wrote:

Yes, you're welcome to rewrite it in Python.  You're spot on with why
it's not in Java.



Thanks for the clarification!


  As for why it's in Perl, it was simple for me to do and we already
have a dependency on it. As far as I've seen, the majority of what's
written for the agent to call is in Bash, and this task was fairly
difficult for Bash. The exceptions being security groups and the
installation helpers, which are in Python, presumably because they're
also difficult in Bash. The script this replaced was a Bash script.
It's probably because some people are really good at Bash, but don't
know Perl or Python, some are good at Python, but don't know Perl, and
vice versa.  Or maybe someone knows them all but has a preference on a
specific tool for a specific job, for compatibility or whatever
reason. I personally tend to shy away from Python if I want to write
something that I know will work everywhere, due to the 2.6/2.7
compatibility and spread between distros, but that shouldn't matter
for a simple script like patchviasocket.pl.



Ack, I might give it a try to rewrite in Python.


Do we want to standardize and say that if it can't be in Java, and it
can't be in Bash, it has to be in Python? The other dependencies on
Perl are few, so we could probably wipe them out as well. If we have
to limit, I'd much rather it be Java, Perl, Python than Java, Bash,
Python, but it's too late for that I think. As a side note, Bash seems
to be highly preferred in the agent code, even though some of the
system vm scripts are fairly complex. It would be nice to see these
simplified by using a more powerful language as well.



I'd vote for:
* Java
* Bash
* Python

The reasoning behind Python is that:
A): We already have a lot of Python scripts (783 vs 1 Perl)
B): It seems to be the standard for Linux distributions to develop their 
scripts in. Ubuntu is a good example.


Wido



On Sun, May 26, 2013 at 3:20 AM, Wido den Hollander  wrote:

Hi Marcus,

This is somewhat a rhetorical question, but I wanted to confirm anyway.

The 4.2 SystemVMs use a VirtIO socket on KVM to get their boot arguments.
That is great, since there is no longer a need for patch disks which enables
them to run on RBD.

One of the things I dislike about the KVM agent is all the scripts it runs,
I'd rather see them all disappear since executing scripts and getting the
correct exit statuses is always a difficult thing.

Anyway, the patchviasocket.pl script opens the VirtIO Unix Socket on the
hypervisor and writes some data to it.

I've been searching and with some third party libraries it is also possible
to do this natively from Java, for example:

* http://www.matthew.ath.cx/projects/java/
* http://code.google.com/p/junixsocket/

They require libraries on the system with JNI though, so it will make our
packaging efforts harder. Was this the reasoning behind doing this in Perl?

If so, why Perl? Since most of the stuff in CloudStack is done in Java,
Python or Bash, why Perl? Couldn't we rewrite this in Python if we don't
want to do this in Java?

Wido

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

[Prasanna Santhanam]

> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_cpu_limits.py, line 527
> > 
> >
> > There's some confusion I have here:
> > 
> > 1. you are using the apiClient of the admin role and the limits apply 
> > on the account (domadmin, chlilddomadmin) 
> > 2. use the api client of the account you created instead to establish 
> > the limits? createUserApiClient from marvin's library can be used here.
> >
> 
> Gaurav Aradhye wrote:
> Hi Prasanna, are you suggesting this change while updating limits for an 
> account or creating an instance with the account?
> 
> In both the methods we are passing the account id and respective domain 
> id for which we are updating limits/creating account within. Also, will 
> creating new api client of that account make difference in this case as we 
> are already specifying account and domain id?

Updating the limits is only done by admin. I'm suggesting the use of user's 
apiclient only for the instance creation. You're right that you are passing the 
account/domainid so only the account is affected. But you're still doing an 
admin action. Typically the users will hit these limits as a result of their 
own operations and not by that of the admin. 

Eventually, it might turn out to be the same thing but it ensures that we don't 
have role specific control-flow in the server side for (admin/domadmin/user). 
Let me know if that complicates the test case.


- Prasanna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10828/#review19846
---


On April 29, 2013, 8:36 a.m., Chirag Jog wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10828/
> ---
> 
> (Updated April 29, 2013, 8:36 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam, sailaja mada, and Girish 
> Shilamkar.
> 
> 
> Description
> ---
> 
> Here is the detailed test plan: 
> https://issues.apache.org/jira/secure/attachment/12571551/LimitResourcesTestPlan1.xlsx
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1466.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chirag Jog
> 
>

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

[Gaurav Aradhye]

> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_cpu_limits.py, line 527
> > 
> >
> > There's some confusion I have here:
> > 
> > 1. you are using the apiClient of the admin role and the limits apply 
> > on the account (domadmin, chlilddomadmin) 
> > 2. use the api client of the account you created instead to establish 
> > the limits? createUserApiClient from marvin's library can be used here.
> >

Hi Prasanna, are you suggesting this change while updating limits for an 
account or creating an instance with the account?

In both the methods we are passing the account id and respective domain id for 
which we are updating limits/creating account within. Also, will creating new 
api client of that account make difference in this case as we are already 
specifying account and domain id?


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10828/#review19846
---


On April 29, 2013, 8:36 a.m., Chirag Jog wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10828/
> ---
> 
> (Updated April 29, 2013, 8:36 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam, sailaja mada, and Girish 
> Shilamkar.
> 
> 
> Description
> ---
> 
> Here is the detailed test plan: 
> https://issues.apache.org/jira/secure/attachment/12571551/LimitResourcesTestPlan1.xlsx
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1466.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chirag Jog
> 
>

Re: [VOTE] Release Apache CloudStack 4.1.0 (fourth round)

[Wido den Hollander]

Hi Chip,

I'm sorry, this is a -1 again.

Hiroaki found a bug in the Deb packaging again, with commit: 
c4d61897d93420093dfbb046502b3f5e0d31fb9f


The agent wasn't depending on nfs-common, which would cause problems for 
users installing and running with NFS.


I also found another bug in the Deb packaging which I caused yesterday: 
d9084df9a9e46d663b8ef11639af528caab91bb5


server.xml and tomcat6.conf are both symlinks and with I listed the 
files in /var/lib/dpkg/info/cloudstack-management.list it didn't show 
these symlinks are part of the package.


Anyway, again, this is just packaging issues, code wise it works for me.

Wido

On 05/26/2013 04:54 PM, Chip Childers wrote:

Hi All,

I've created a 4.1.0 release, with the following artifacts up for a
vote.

The changes from round 3 are two commits related to DEB packaging.

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.1
Commit:  db007da15290970c842c3229a11051c20b512a65

List of changes:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CHANGES;hb=4.1

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.1.0/

PGP release keys (signed using A99A5D58):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Testing instructions are here:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+test+procedure

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure to
indicate "(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

Review Request: Update L10N strings for 4.1 (Italian and Chinese) from Transifex to repo

[Milamber ASF]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11433/
---

Review request for cloudstack and Chip Childers.


Description
---


@chipc 
Before next RC, please apply this patch on 4.1 branch to update L10N strings 
for 4.1 (Italian and Chinese) from Transifex


Diffs
-

  client/WEB-INF/classes/resources/messages_it_IT.properties 5f68d9a 
  client/WEB-INF/classes/resources/messages_zh_CN.properties d6ce543 

Diff: https://reviews.apache.org/r/11433/diff/


Testing
---


Thanks,

Milamber ASF

Re: [VOTE] Release Apache CloudStack 4.1.0 (fourth round)

[Noah Slater]

Is this am argument for keeping the Debian packaging in a seperate repo?
cloudstack-deb, perhaps? Repositories are cheap.

On Monday, 27 May 2013, Wido den Hollander wrote:

> Hi Chip,
>
> I'm sorry, this is a -1 again.
>
> Hiroaki found a bug in the Deb packaging again, with commit:
> c4d61897d93420093dfbb046502b3f**5e0d31fb9f
>
> The agent wasn't depending on nfs-common, which would cause problems for
> users installing and running with NFS.
>
> I also found another bug in the Deb packaging which I caused yesterday:
> d9084df9a9e46d663b8ef11639af52**8caab91bb5
>
> server.xml and tomcat6.conf are both symlinks and with I listed the files
> in /var/lib/dpkg/info/cloudstack-**management.list it didn't show these
> symlinks are part of the package.
>
> Anyway, again, this is just packaging issues, code wise it works for me.
>
> Wido
>
> On 05/26/2013 04:54 PM, Chip Childers wrote:
>
>> Hi All,
>>
>> I've created a 4.1.0 release, with the following artifacts up for a
>> vote.
>>
>> The changes from round 3 are two commits related to DEB packaging.
>>
>> Git Branch and Commit SH:
>> https://git-wip-us.apache.org/**repos/asf?p=cloudstack.git;a=**
>> shortlog;h=refs/heads/4.1
>> Commit:  db007da15290970c842c3229a11051**c20b512a65
>>
>> List of changes:
>> https://git-wip-us.apache.org/**repos/asf?p=cloudstack.git;a=**
>> blob_plain;f=CHANGES;hb=4.1
>>
>> Source release (checksums and signatures are available at the same
>> location):
>> https://dist.apache.org/repos/**dist/dev/cloudstack/4.1.0/
>>
>> PGP release keys (signed using A99A5D58):
>> https://dist.apache.org/repos/**dist/release/cloudstack/KEYS
>>
>> Testing instructions are here:
>> https://cwiki.apache.org/**confluence/display/CLOUDSTACK/**
>> Release+test+procedure
>>
>> Vote will be open for 72 hours.
>>
>> For sanity in tallying the vote, can PMC members please be sure to
>> indicate "(binding)" with their vote?
>>
>> [ ] +1  approve
>> [ ] +0  no opinion
>> [ ] -1  disapprove (and reason why)
>>
>>

-- 
NS

Re: Review Request: Fix for CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object

[Nitin Mehta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11373/#review21060
---



server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java


Can offering.getVolatileVm() be null ? If yes then we should set false.


- Nitin Mehta


On May 24, 2013, 12:22 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11373/
> ---
> 
> (Updated May 24, 2013, 12:22 p.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Description
> ---
> 
> Missing isVolatile parameter in the response of service offering.
> Need to add this in service offering response object. 
> 
> 
> This addresses bug CLOUDSTACK-2672.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
> 08ebbb0 
>   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java ce20562 
>   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 598e1d1 
>   setup/db/db/schema-410to420.sql 442a544 
> 
> Diff: https://reviews.apache.org/r/11373/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: Fix for CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11373/#review21061
---



server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java


It cannot be null as serviceofferingJoinVO is populated from service 
offering table and while creating service offering entry we set to false if the 
isVolatile is null.




- Harikrishna Patnala


On May 24, 2013, 12:22 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11373/
> ---
> 
> (Updated May 24, 2013, 12:22 p.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Description
> ---
> 
> Missing isVolatile parameter in the response of service offering.
> Need to add this in service offering response object. 
> 
> 
> This addresses bug CLOUDSTACK-2672.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
> 08ebbb0 
>   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java ce20562 
>   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 598e1d1 
>   setup/db/db/schema-410to420.sql 442a544 
> 
> Diff: https://reviews.apache.org/r/11373/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: Fix for CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object

[Harikrishna Patnala]

> On May 27, 2013, 12:27 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java, line 71
> > 
> >
> > Can offering.getVolatileVm() be null ? If yes then we should set false.

It cannot be null as serviceofferingJoinVO is populated from service offering 
table and while creating service offering entry we set to false if the 
isVolatile is null.


- Harikrishna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11373/#review21060
---


On May 24, 2013, 12:22 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11373/
> ---
> 
> (Updated May 24, 2013, 12:22 p.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Description
> ---
> 
> Missing isVolatile parameter in the response of service offering.
> Need to add this in service offering response object. 
> 
> 
> This addresses bug CLOUDSTACK-2672.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
> 08ebbb0 
>   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java ce20562 
>   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 598e1d1 
>   setup/db/db/schema-410to420.sql 442a544 
> 
> Diff: https://reviews.apache.org/r/11373/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: Fix for CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object

[Nitin Mehta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11373/#review21063
---

Ship it!


Ship It!

- Nitin Mehta


On May 24, 2013, 12:22 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11373/
> ---
> 
> (Updated May 24, 2013, 12:22 p.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Description
> ---
> 
> Missing isVolatile parameter in the response of service offering.
> Need to add this in service offering response object. 
> 
> 
> This addresses bug CLOUDSTACK-2672.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
> 08ebbb0 
>   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java ce20562 
>   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 598e1d1 
>   setup/db/db/schema-410to420.sql 442a544 
> 
> Diff: https://reviews.apache.org/r/11373/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: [VOTE] List CloudStack related books on the website

[Kelly Hair]

+1 as well




On 5/27/13 4:35 AM, "Giles Sirett"  wrote:

>+1
>
>
>Kind Regards
>Giles
>
>D: +44 20 3603 0541 | M: +44 796 111
>2055
>giles.sir...@shapeblue.com
>
>On 27 May 2013, at 09:27, "Sebastien Goasguen"
>mailto:run...@gmail.com>> wrote:
>
>Hi,
>
>After a relatively long discussion on the marketing@ list about the
>"Packt Book" [1] I would like to call a vote.
>
>Proposal:
>
>I propose to list CloudStack related books on our website [2]. The page
>listing these books would contain the following disclaimer:
>
>"This listing does not represent official endorsement by the Apache
>CloudStack project. The Apache CloudStack project does not recommend one
>book versus another nor does it guarantee the quality of the books."
>
>Inclusion of a book in the listing would be done via a vote on the
>marketing@ list.
>
>
>As a quick summary, alternatives to this proposal were to:
>1-not do anything
>2-list the books on the wiki
>
>A few of us have already expressed their opinions and discussed the
>possibilities. Check [1].
>
>Vote will be open for 96 hours (To accommodate Memorial day in the USA).
>
>Reply with:
>
>[ ] +1  approve
>[ ] +0  no opinion
>[ ] -1  disapprove (and reason why)
>
>PS: If edits of the disclaimer are needed but that they do not change the
>meaning of it, the disclaimer will be modified but the vote will not be
>restarted.
>
>[1] http://markmail.org/thread/r4qdmbonmx6yq2uv
>[2] http://cloudstack.apache.org
>
>-Sebastien
>This email and any attachments to it may be confidential and are intended
>solely for the use of the individual to whom it is addressed. Any views
>or opinions expressed are solely those of the author and do not
>necessarily represent those of Shape Blue Ltd or related companies. If
>you are not the intended recipient of this email, you must neither take
>any action based upon its contents, nor copy or show it to anyone. Please
>contact the sender if you believe you have received this email in error.
>Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>Services India LLP is operated under license from Shape Blue Ltd.
>ShapeBlue is a registered trademark.

Re: Review Request: Fix for CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11373/#review21064
---


Commit 82974458a675c52e888c91f569f0f1ca278197d7 in branch refs/heads/master 
from Nitin Mehta 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8297445 ]

CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object
Signed off by :- Nitin Mehta 


- ASF Subversion and Git Services


On May 24, 2013, 12:22 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11373/
> ---
> 
> (Updated May 24, 2013, 12:22 p.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Description
> ---
> 
> Missing isVolatile parameter in the response of service offering.
> Need to add this in service offering response object. 
> 
> 
> This addresses bug CLOUDSTACK-2672.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
> 08ebbb0 
>   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java ce20562 
>   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 598e1d1 
>   setup/db/db/schema-410to420.sql 442a544 
> 
> Diff: https://reviews.apache.org/r/11373/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: [VOTE] List CloudStack related books on the website

[Geoff Higginbottom]

+1

Regards

Geoff Higginbottom
CTO / Cloud Architect

D: +44 20 3603 0542 | S: +44 20 3603 
0540| M: +447968161581

geoff.higginbot...@shapeblue.com 
|www.shapeblue.com | Twitter:@shapeblue

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS


On 27 May 2013, at 09:27, "Sebastien Goasguen" 
mailto:run...@gmail.com>> wrote:

Hi,

After a relatively long discussion on the marketing@ list about the "Packt 
Book" [1] I would like to call a vote.

Proposal:

I propose to list CloudStack related books on our website [2]. The page listing 
these books would contain the following disclaimer:

"This listing does not represent official endorsement by the Apache CloudStack 
project. The Apache CloudStack project does not recommend one book versus 
another nor does it guarantee the quality of the books."

Inclusion of a book in the listing would be done via a vote on the marketing@ 
list.


As a quick summary, alternatives to this proposal were to:
1-not do anything
2-list the books on the wiki

A few of us have already expressed their opinions and discussed the 
possibilities. Check [1].

Vote will be open for 96 hours (To accommodate Memorial day in the USA).

Reply with:

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

PS: If edits of the disclaimer are needed but that they do not change the 
meaning of it, the disclaimer will be modified but the vote will not be 
restarted.

[1] http://markmail.org/thread/r4qdmbonmx6yq2uv
[2] http://cloudstack.apache.org

-Sebastien
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is operated under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

[Gaurav Aradhye]

> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_cpu_limits.py, line 417
> > 
> >
> > method name doesn't reflect intent. you are doing a checkResourceCount 
> > but doing an updateCount within? Was this intended?

Here we are checking the updated resource count. Will Change method name to 
"checkUpdatedResourceCount" to avoid confusion.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10828/#review19846
---


On April 29, 2013, 8:36 a.m., Chirag Jog wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10828/
> ---
> 
> (Updated April 29, 2013, 8:36 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam, sailaja mada, and Girish 
> Shilamkar.
> 
> 
> Description
> ---
> 
> Here is the detailed test plan: 
> https://issues.apache.org/jira/secure/attachment/12571551/LimitResourcesTestPlan1.xlsx
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1466.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chirag Jog
> 
>

Re: [VOTE] List CloudStack related books on the website

[Roland Wartenberg]

+1

Sent from my iPad

On May 27, 2013, at 1:27 AM, Sebastien Goasguen  wrote:

> Hi,
> 
> After a relatively long discussion on the marketing@ list about the "Packt 
> Book" [1] I would like to call a vote.
> 
> Proposal:
> 
> I propose to list CloudStack related books on our website [2]. The page 
> listing these books would contain the following disclaimer:
> 
> "This listing does not represent official endorsement by the Apache 
> CloudStack project. The Apache CloudStack project does not recommend one book 
> versus another nor does it guarantee the quality of the books."
> 
> Inclusion of a book in the listing would be done via a vote on the marketing@ 
> list.
> 
> 
> As a quick summary, alternatives to this proposal were to:
> 1-not do anything
> 2-list the books on the wiki
> 
> A few of us have already expressed their opinions and discussed the 
> possibilities. Check [1]. 
> 
> Vote will be open for 96 hours (To accommodate Memorial day in the USA).
> 
> Reply with:
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
> 
> PS: If edits of the disclaimer are needed but that they do not change the 
> meaning of it, the disclaimer will be modified but the vote will not be 
> restarted.
> 
> [1] http://markmail.org/thread/r4qdmbonmx6yq2uv
> [2] http://cloudstack.apache.org
> 
> -Sebastien

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

[Gaurav Aradhye]

> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_cpu_limits.py, line 405
> > 
> >
> > Should these utility methods be included in every test class? Can we 
> > not include them in a single class and import as necessary?

Is this same as the change suggested before(line no. 166)?


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10828/#review19846
---


On April 29, 2013, 8:36 a.m., Chirag Jog wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10828/
> ---
> 
> (Updated April 29, 2013, 8:36 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam, sailaja mada, and Girish 
> Shilamkar.
> 
> 
> Description
> ---
> 
> Here is the detailed test plan: 
> https://issues.apache.org/jira/secure/attachment/12571551/LimitResourcesTestPlan1.xlsx
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1466.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chirag Jog
> 
>

Re: [VOTE] Release Apache CloudStack 4.1.0 (fourth round)

[Chip Childers]

Ok. Vote cancelled.

I'll re-spin a fifth round RC.

On May 27, 2013, at 7:29 AM, Wido den Hollander  wrote:

> Hi Chip,
>
> I'm sorry, this is a -1 again.
>
> Hiroaki found a bug in the Deb packaging again, with commit: 
> c4d61897d93420093dfbb046502b3f5e0d31fb9f
>
> The agent wasn't depending on nfs-common, which would cause problems for 
> users installing and running with NFS.
>
> I also found another bug in the Deb packaging which I caused yesterday: 
> d9084df9a9e46d663b8ef11639af528caab91bb5
>
> server.xml and tomcat6.conf are both symlinks and with I listed the files in 
> /var/lib/dpkg/info/cloudstack-management.list it didn't show these symlinks 
> are part of the package.
>
> Anyway, again, this is just packaging issues, code wise it works for me.
>
> Wido
>
> On 05/26/2013 04:54 PM, Chip Childers wrote:
>> Hi All,
>>
>> I've created a 4.1.0 release, with the following artifacts up for a
>> vote.
>>
>> The changes from round 3 are two commits related to DEB packaging.
>>
>> Git Branch and Commit SH:
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.1
>> Commit:  db007da15290970c842c3229a11051c20b512a65
>>
>> List of changes:
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CHANGES;hb=4.1
>>
>> Source release (checksums and signatures are available at the same
>> location):
>> https://dist.apache.org/repos/dist/dev/cloudstack/4.1.0/
>>
>> PGP release keys (signed using A99A5D58):
>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>
>> Testing instructions are here:
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+test+procedure
>>
>> Vote will be open for 72 hours.
>>
>> For sanity in tallying the vote, can PMC members please be sure to
>> indicate "(binding)" with their vote?
>>
>> [ ] +1  approve
>> [ ] +0  no opinion
>> [ ] -1  disapprove (and reason why)
>

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

[Prasanna Santhanam]

> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_cpu_limits.py, line 405
> > 
> >
> > Should these utility methods be included in every test class? Can we 
> > not include them in a single class and import as necessary?
> 
> Gaurav Aradhye wrote:
> Is this same as the change suggested before(line no. 166)?

yes


- Prasanna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10828/#review19846
---


On April 29, 2013, 8:36 a.m., Chirag Jog wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10828/
> ---
> 
> (Updated April 29, 2013, 8:36 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam, sailaja mada, and Girish 
> Shilamkar.
> 
> 
> Description
> ---
> 
> Here is the detailed test plan: 
> https://issues.apache.org/jira/secure/attachment/12571551/LimitResourcesTestPlan1.xlsx
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1466.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chirag Jog
> 
>

[GSoC] Results

[Sebastien Goasguen]

Hi folks,

Results for GSoC proposals will be announced in 5 hours and 15 minutes on the 
Google web site:
http://www.google-melange.com/gsoc/homepage/google/gsoc2013

Thanks to everyone for their proposals,

-Sebastien

Re: [VOTE] Release Apache CloudStack 4.1.0 (fourth round)

[Hiroaki KAWAI]

(2013/05/27 22:34), Chip Childers wrote:

Ok. Vote cancelled.

I'll re-spin a fifth round RC.


Thank you.

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

[Alex Huang]

Daan,

The other possibility is that the test is affected by another test so that it 
breaks when the tests are in a certain order.  Have you noticed what's the 
order of the tests ran when it breaks?

--Alex

> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: Monday, May 27, 2013 2:37 AM
> To: dev@cloudstack.apache.org
> Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest
> 
> Being in the habit of replying on my own mails as I seems to be on this list;
> 
> This seems to be related to eclipse refresh/build code. Does anybody have a
> solution to it? The problem is not consistently present but all the more
> irritating.
> 
> Regards,
> 
> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: maandag 27 mei 2013 7:49
> To: dev@cloudstack.apache.org
> Subject: master build breaks at com.cloud.vpc.NetworkACLServiceTest
> 
> LS,
> 
> Lately I've been getting,
> "com.cloud.exception.InvalidParameterValueException: ACL item with
> number 1 already exists in ACL: null", while building cloudstack. I first 
> thought
> it was my own hack so I don't know when it was introduced (it is in a clean
> master that it happens). The full surfire report follows:
> 
> ---
> Test set: com.cloud.vpc.NetworkACLServiceTest
> ---
> Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.219 sec <<<
> FAILURE!
> testCreateACLItem(com.cloud.vpc.NetworkACLServiceTest)  Time elapsed:
> 0.016 sec  <<< ERROR!
> com.cloud.exception.InvalidParameterValueException: ACL item with
> number 1 already exists in ACL: null
> at
> com.cloud.network.vpc.NetworkACLServiceImpl.createNetworkACLItem(Ne
> tworkACLServiceImpl.java:270)
> at
> com.cloud.vpc.NetworkACLServiceTest.testCreateACLItem(NetworkACLServ
> iceTest.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Framework
> Method.java:45)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.jav
> a:15)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(Framework
> Method.java:42)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMeth
> od.java:20)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java
> :28)
> at
> org.springframework.test.context.junit4.statements.RunBeforeTestMethod
> Callbacks.evaluate(RunBeforeTestMethodCallbacks.java:74)
> at
> org.springframework.test.context.junit4.statements.RunAfterTestMethodC
> allbacks.evaluate(RunAfterTestMethodCallbacks.java:83)
> at
> org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(
> SpringRepeat.java:72)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(S
> pringJUnit4ClassRunner.java:231)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.j
> ava:47)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
> at 
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
> at 
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
> at
> org.springframework.test.context.junit4.statements.RunBeforeTestClassCall
> backs.evaluate(RunBeforeTestClassCallbacks.java:61)
> at
> org.springframework.test.context.junit4.statements.RunAfterTestClassCallb
> acks.evaluate(RunAfterTestClassCallbacks.java:71)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(Spring
> JUnit4ClassRunner.java:174)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.jav
> a:236)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Prov
> ider.java:134)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java
> :113)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
>

Re: [VOTE] List CloudStack related books on the website

[Noah Slater]

-0

I think we should be listing books, but I would prefer it to be on the wiki.

(Note that your vote email should include +0 and -0, which are weak
approval/disapproval.)


On 27 May 2013 09:27, Sebastien Goasguen  wrote:

> Hi,
>
> After a relatively long discussion on the marketing@ list about the
> "Packt Book" [1] I would like to call a vote.
>
> Proposal:
> 
> I propose to list CloudStack related books on our website [2]. The page
> listing these books would contain the following disclaimer:
>
> "This listing does not represent official endorsement by the Apache
> CloudStack project. The Apache CloudStack project does not recommend one
> book versus another nor does it guarantee the quality of the books."
>
> Inclusion of a book in the listing would be done via a vote on the
> marketing@ list.
> 
>
> As a quick summary, alternatives to this proposal were to:
> 1-not do anything
> 2-list the books on the wiki
>
> A few of us have already expressed their opinions and discussed the
> possibilities. Check [1].
>
> Vote will be open for 96 hours (To accommodate Memorial day in the USA).
>
> Reply with:
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
> PS: If edits of the disclaimer are needed but that they do not change the
> meaning of it, the disclaimer will be modified but the vote will not be
> restarted.
>
> [1] http://markmail.org/thread/r4qdmbonmx6yq2uv
> [2] http://cloudstack.apache.org
>
> -Sebastien




-- 
NS

Review Request: Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11435/
---

Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Description
---

[Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C
https://issues.apache.org/jira/browse/CLOUDSTACK-2621


This addresses bug Cloudstack-2621.


Diffs
-

  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 214e292 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
b969be2 

Diff: https://reviews.apache.org/r/11435/diff/


Testing
---

tested on master.


Thanks,

bharat kumar

Review Request: CLOUDSTACK-2620 [Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11436/
---

Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Description
---

[Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address 
in case of multiple subnets
https://issues.apache.org/jira/browse/CLOUDSTACK-2620


This addresses bug Cloudstack-2620.


Diffs
-

  api/src/com/cloud/agent/api/to/DnsmasqTO.java f99878c 
  core/src/com/cloud/network/DnsMasqConfigurator.java ee8e5fc 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
b969be2 

Diff: https://reviews.apache.org/r/11436/diff/


Testing
---

tested on master.


Thanks,

bharat kumar

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

[Daan Hoogland]

Alex,

Can this change out of the box? I had the problem on a clean checkout of master.

-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com] 
Sent: maandag 27 mei 2013 15:55
To: dev@cloudstack.apache.org
Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

Daan,

The other possibility is that the test is affected by another test so that it 
breaks when the tests are in a certain order.  Have you noticed what's the 
order of the tests ran when it breaks?

--Alex

> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: Monday, May 27, 2013 2:37 AM
> To: dev@cloudstack.apache.org
> Subject: RE: master build breaks at 
> com.cloud.vpc.NetworkACLServiceTest
> 
> Being in the habit of replying on my own mails as I seems to be on 
> this list;
> 
> This seems to be related to eclipse refresh/build code. Does anybody 
> have a solution to it? The problem is not consistently present but all 
> the more irritating.
> 
> Regards,
> 
> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: maandag 27 mei 2013 7:49
> To: dev@cloudstack.apache.org
> Subject: master build breaks at com.cloud.vpc.NetworkACLServiceTest
> 
> LS,
> 
> Lately I've been getting,
> "com.cloud.exception.InvalidParameterValueException: ACL item with 
> number 1 already exists in ACL: null", while building cloudstack. I 
> first thought it was my own hack so I don't know when it was 
> introduced (it is in a clean master that it happens). The full surfire report 
> follows:
> 
> --
> - Test set: com.cloud.vpc.NetworkACLServiceTest
> --
> - Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time 
> elapsed: 0.219 sec <<< FAILURE!
> testCreateACLItem(com.cloud.vpc.NetworkACLServiceTest)  Time elapsed:
> 0.016 sec  <<< ERROR!
> com.cloud.exception.InvalidParameterValueException: ACL item with 
> number 1 already exists in ACL: null
> at
> com.cloud.network.vpc.NetworkACLServiceImpl.createNetworkACLItem(Ne
> tworkACLServiceImpl.java:270)
> at
> com.cloud.vpc.NetworkACLServiceTest.testCreateACLItem(NetworkACLServ
> iceTest.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Framework
> Method.java:45)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCall
> able.jav
> a:15)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(Framework
> Method.java:42)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMeth
> od.java:20)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.j
> ava
> :28)
> at
> org.springframework.test.context.junit4.statements.RunBeforeTestMethod
> Callbacks.evaluate(RunBeforeTestMethodCallbacks.java:74)
> at
> org.springframework.test.context.junit4.statements.RunAfterTestMethodC
> allbacks.evaluate(RunAfterTestMethodCallbacks.java:83)
> at
> org.springframework.test.context.junit4.statements.SpringRepeat.evalua
> te(
> SpringRepeat.java:72)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChi
> ld(S
> pringJUnit4ClassRunner.java:231)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunn
> er.j
> ava:47)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
> at 
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
> at 
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
> at
> org.springframework.test.context.junit4.statements.RunBeforeTestClassC
> all
> backs.evaluate(RunBeforeTestClassCallbacks.java:61)
> at
> org.springframework.test.context.junit4.statements.RunAfterTestClassCa
> llb
> acks.evaluate(RunAfterTestClassCallbacks.java:71)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(Sp
> ring
> JUnit4ClassRunner.java:174)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider
> .jav
> a:236)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4P
> rov
> ider.java:134)
> at
> org.apache.maven.surefire.junit4.JUnit4Provid

Re: [VOTE] List CloudStack related books on the website

[Outback Dingo]

On Mon, May 27, 2013 at 4:27 AM, Sebastien Goasguen wrote:

> Hi,
>
> After a relatively long discussion on the marketing@ list about the
> "Packt Book" [1] I would like to call a vote.
>
> Proposal:
> 
> I propose to list CloudStack related books on our website [2]. The page
> listing these books would contain the following disclaimer:
>
> "This listing does not represent official endorsement by the Apache
> CloudStack project. The Apache CloudStack project does not recommend one
> book versus another nor does it guarantee the quality of the books."
>
> Inclusion of a book in the listing would be done via a vote on the
> marketing@ list.
> 
>
> As a quick summary, alternatives to this proposal were to:
> 1-not do anything
> 2-list the books on the wiki
>
> A few of us have already expressed their opinions and discussed the
> possibilities. Check [1].
>
> Vote will be open for 96 hours (To accommodate Memorial day in the USA).
>
> Reply with:
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>

+1


>
> PS: If edits of the disclaimer are needed but that they do not change the
> meaning of it, the disclaimer will be modified but the vote will not be
> restarted.
>
> [1] http://markmail.org/thread/r4qdmbonmx6yq2uv
> [2] http://cloudstack.apache.org
>
> -Sebastien

Re: [VOTE] List CloudStack related books on the website

[kel...@backbonetechnology.com]

+1 of course!

Sent from my HTC

- Reply message -
From: "Noah Slater" 
To: "dev@cloudstack.apache.org" , 
"market...@cloudstack.apache.org" 
Subject: [VOTE] List CloudStack related books on the website
Date: Mon, May 27, 2013 7:00 AM

-0

I think we should be listing books, but I would prefer it to be on the wiki.

(Note that your vote email should include +0 and -0, which are weak
approval/disapproval.)


On 27 May 2013 09:27, Sebastien Goasguen  wrote:

> Hi,
>
> After a relatively long discussion on the marketing@ list about the
> "Packt Book" [1] I would like to call a vote.
>
> Proposal:
> 
> I propose to list CloudStack related books on our website [2]. The page
> listing these books would contain the following disclaimer:
>
> "This listing does not represent official endorsement by the Apache
> CloudStack project. The Apache CloudStack project does not recommend one
> book versus another nor does it guarantee the quality of the books."
>
> Inclusion of a book in the listing would be done via a vote on the
> marketing@ list.
> 
>
> As a quick summary, alternatives to this proposal were to:
> 1-not do anything
> 2-list the books on the wiki
>
> A few of us have already expressed their opinions and discussed the
> possibilities. Check [1].
>
> Vote will be open for 96 hours (To accommodate Memorial day in the USA).
>
> Reply with:
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
> PS: If edits of the disclaimer are needed but that they do not change the
> meaning of it, the disclaimer will be modified but the vote will not be
> restarted.
>
> [1] http://markmail.org/thread/r4qdmbonmx6yq2uv
> [2] http://cloudstack.apache.org
>
> -Sebastien




-- 
NS

Review Request: CLOUDSTACK-2648 [Multiple_IP_Ranges] Reboot or start/stop router vm deletes the ip alises created on VR in case of multiple subnets

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11437/
---

Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Description
---

[Multiple_IP_Ranges] Reboot or start/stop router vm deletes the ip alises 
created on VR in case of multiple subnets
https://issues.apache.org/jira/browse/CLOUDSTACK-2648


This addresses bug Cloudstack-2648.


Diffs
-

  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
8b996d1 
  patches/systemvm/debian/config/root/deleteIpAlias.sh 865ff3b 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 630d1b4 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 4680fde 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
b969be2 

Diff: https://reviews.apache.org/r/11437/diff/


Testing
---

tested on master.


Thanks,

bharat kumar

Re: Review Request: Cloudstack-2621 [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C

[Koushik Das]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11435/#review21069
---



server/src/com/cloud/configuration/ConfigurationManagerImpl.java


There are multiple return paths for this method. How are you ensuring 
consistency in the db. for all the return paths? The complexity of the code 
makes the testing very difficult



server/src/com/cloud/configuration/ConfigurationManagerImpl.java


unused



server/src/com/cloud/configuration/ConfigurationManagerImpl.java


First check if log level is debug and then only print the message. Do in 
other places as well



server/src/com/cloud/configuration/ConfigurationManagerImpl.java


There are multiple db calls _vlanDao, _nicIpAliasDao, _publicIpAddressDao. 
What happens in case of partial success? Should this be in a txn?



server/src/com/cloud/configuration/ConfigurationManagerImpl.java


In some cases you are throwing and in some case you are returning boolean? 
What is the logic?



server/src/com/cloud/configuration/ConfigurationManagerImpl.java


there is a return, what happens to the txn?



server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java


why is the error message add/remove vpn users?

Also what is the account and zone here



server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java


unused



server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java


Is it possible that some routers are running and some are not? If so what 
happens?



server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java


error message: same as above



server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java


message says apply but this for revoke. right? also dhcp has become "dhco"



server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java


dhco -> dhcp


- Koushik Das


On May 27, 2013, 2:50 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11435/
> ---
> 
> (Updated May 27, 2013, 2:50 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Description
> ---
> 
> [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C
> https://issues.apache.org/jira/browse/CLOUDSTACK-2621
> 
> 
> This addresses bug Cloudstack-2621.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 214e292 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> b969be2 
> 
> Diff: https://reviews.apache.org/r/11435/diff/
> 
> 
> Testing
> ---
> 
> tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

[Daan Hoogland]

And if not how do I manipulate the order of tests?

-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] 
Sent: maandag 27 mei 2013 17:02
To: dev@cloudstack.apache.org
Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

Alex,

Can this change out of the box? I had the problem on a clean checkout of master.

-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com]
Sent: maandag 27 mei 2013 15:55
To: dev@cloudstack.apache.org
Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

Daan,

The other possibility is that the test is affected by another test so that it 
breaks when the tests are in a certain order.  Have you noticed what's the 
order of the tests ran when it breaks?

--Alex

> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: Monday, May 27, 2013 2:37 AM
> To: dev@cloudstack.apache.org
> Subject: RE: master build breaks at
> com.cloud.vpc.NetworkACLServiceTest
> 
> Being in the habit of replying on my own mails as I seems to be on 
> this list;
> 
> This seems to be related to eclipse refresh/build code. Does anybody 
> have a solution to it? The problem is not consistently present but all 
> the more irritating.
> 
> Regards,
> 
> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: maandag 27 mei 2013 7:49
> To: dev@cloudstack.apache.org
> Subject: master build breaks at com.cloud.vpc.NetworkACLServiceTest
> 
> LS,
> 
> Lately I've been getting,
> "com.cloud.exception.InvalidParameterValueException: ACL item with 
> number 1 already exists in ACL: null", while building cloudstack. I 
> first thought it was my own hack so I don't know when it was 
> introduced (it is in a clean master that it happens). The full surfire report 
> follows:
> 
> --
> - Test set: com.cloud.vpc.NetworkACLServiceTest
> --
> - Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 0.219 sec <<< FAILURE!
> testCreateACLItem(com.cloud.vpc.NetworkACLServiceTest)  Time elapsed:
> 0.016 sec  <<< ERROR!
> com.cloud.exception.InvalidParameterValueException: ACL item with 
> number 1 already exists in ACL: null
> at
> com.cloud.network.vpc.NetworkACLServiceImpl.createNetworkACLItem(Ne
> tworkACLServiceImpl.java:270)
> at
> com.cloud.vpc.NetworkACLServiceTest.testCreateACLItem(NetworkACLServ
> iceTest.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Framework
> Method.java:45)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCall
> able.jav
> a:15)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(Framework
> Method.java:42)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMeth
> od.java:20)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.j
> ava
> :28)
> at
> org.springframework.test.context.junit4.statements.RunBeforeTestMethod
> Callbacks.evaluate(RunBeforeTestMethodCallbacks.java:74)
> at
> org.springframework.test.context.junit4.statements.RunAfterTestMethodC
> allbacks.evaluate(RunAfterTestMethodCallbacks.java:83)
> at
> org.springframework.test.context.junit4.statements.SpringRepeat.evalua
> te(
> SpringRepeat.java:72)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChi
> ld(S
> pringJUnit4ClassRunner.java:231)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunn
> er.j
> ava:47)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
> at 
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
> at 
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
> at
> org.springframework.test.context.junit4.statements.RunBeforeTestClassC
> all
> backs.evaluate(RunBeforeTestClassCallbacks.java:61)
> at
> org.springframework.test.context.junit4.statements.RunAfterTestClassCa
> llb
> acks.evaluate(RunAfterTestClassCallbacks.java:71)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(Sp
> ring
> JUnit4ClassRunner.java:174)
>

RE: Update on Hyper-V plugin work

[Donal Lafferty]

 Hi Chip,

Thanks for clarifying the IP info required.  I'll take a closer look ASAP.

WRT collaboration, on the agent-side, I did the design work, and used 
colleagues working on CloudStack features for learning and some discussion.  
Reviews requests have flowed through this mailing list.  However, the final 
architecture meant to ease scaling out development.  The stateless agent and 
HTTP request model should allow developers to add commands without stepping on 
each other's toes.
 
On the System VM side, the community updated the storage architecture such that 
CloudStack 4.2 will expect Hyper-V to use S3, and they updated the system VM 
such that it is using a kernel with Hyper-V PV drivers.  Citrix have provided 
some effort for a suitable console proxy, which needs to be integrated into the 
System VM.  (Volunteers?)

DL


-Original Message-
From: Chip Childers [mailto:chip.child...@sungard.com] 
Sent: 24 May 2013 1:28 PM
To: dev@cloudstack.apache.org
Cc: cloudstack-...@incubator.apache.org
Subject: Re: Update on Hyper-V plugin work

Donal,

First, thank you for sending this out!  It seems like really good progress.  
Who are you working with on this?  Are you running solo?

The technical elements of this seem sound at first review.

The licensing implications are going to take some time to parse through though. 
 One of the things that could help us on that front, would be to understand 
which of the licenses are runtime vs. buildtime.  It would also be good to 
highlight which dependencies would easily be considered "system dependencies" 
(as in: expected to be installed prior to our software being installed).

Again, thanks!

-chip

On Fri, May 24, 2013 at 02:22:41AM +, Donal Lafferty wrote:
> Reproduced from 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Progress
> 
> Apologies for the length - skip to the heading that interests you.
> 
> h1. Update on Hyper-V plugin work (2013-05-23):
> 
> h2. New plugin Architecture:
> 
> https://cwiki.apache.org/confluence/download/attachments/31822487/Phas
> e2_HyperV_Remote_Agent.png
> 
> h3. How does is the new architecture an improvement?
> 
> The plugin's architecture uses JSON over HTTP.  This allows the plugin agent 
> to be written in C# rather than Java.  .NET has tools to create WMI wrappers 
> that allows the Hyper-V API calls to be quickly rewritten in C#.  The result 
> is easier to maintain and does not suffer the IP problems of the Python used 
> in phase 1.  An all C# agent can be contained in a single C#/.NET Windows 
> Service.  The result is a more robust design, because there are far fewer 
> points of failure.
> 
> Switching from CloudStack Message bus to JSON over HTTP communications allows 
> the plugin's remote agent to be implemented in C#.  Previously, this agent 
> was written in Java to take advantage to the existing CloudStack message bus 
> agent.  The CloudStack message bus is difficult to port due it's reliance on 
> the Java NIO API. The NIO API is peculiar to Java.  As a consequence, porting 
> to even similar languages such as C# is difficult.  Design work is required 
> that would consume significant time. In contrast, JSON over HTTP passes 
> kernel commands as JSON in the body of an HTTP POST.  This solution is 
> RPC-like and not RESTful, because the destination URI that corresponds to the 
> command and not the resource being manipulated.  The HTTP stack removes the 
> dependency on NIO.  HTTP stacks themselves are easy to come by regardless of 
> the language or platform.  Using an RPC approach avoids undertaking design 
> work to translate incoming kernel commands to a suitable RESTful equivalent.  
> Therefore, JSON over HTTP minimises the effort required to adopt the best 
> language for a platform.
> 
> C# code to call the Hyper-V's API directly removes IP restrictions and 
> complexity of the existing Python code.  Hyper-V is controlled through 
> Windows Management Interface (WMI).  WMI provides a uniform framework through 
> which services and operating subsystems can provide information and register 
> control APIs.  All Hyper-V control packages ultimately call this API. Phase 1 
> of the plugin controlled Hyper-V using a port of cloud.com's OpenStack driver 
> for Hyper-V.  The driver could be easily repurposed, because the OpenStack 
> information model is similar to that of CloudStack.  However, this Python 
> code has IP, support, and coding drawbacks.  The code is a derivative of an 
> existing work, which prevented immediate donation to ASF. The code used a 
> third party WMI wrapper package that limited the version of Python that could 
> be used.  Finally, the python wrapper did not address discover of WMI 
> objects, properties and methods.  In contrast, the C# code can be transferred 
> to ASF immediately.  The strongly typed wrappers rely on C# and .NET, which 
> is well supported. These wrappers are simple to update as they are machine 
> generated code.  More importantly, th

PLEASE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

[Daan Hoogland]

I ran the test in eclipse, it passes, next I do a maven build in eclipse which 
fails on this test. How do I force it to pass, please. This is costing me 
serious time. I am not working on ACLs

Regards,
Daan Hoogland

-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] 
Sent: maandag 27 mei 2013 18:23
To: dev@cloudstack.apache.org
Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

And if not how do I manipulate the order of tests?

-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
Sent: maandag 27 mei 2013 17:02
To: dev@cloudstack.apache.org
Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

Alex,

Can this change out of the box? I had the problem on a clean checkout of master.

-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com]
Sent: maandag 27 mei 2013 15:55
To: dev@cloudstack.apache.org
Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

Daan,

The other possibility is that the test is affected by another test so that it 
breaks when the tests are in a certain order.  Have you noticed what's the 
order of the tests ran when it breaks?

--Alex

> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: Monday, May 27, 2013 2:37 AM
> To: dev@cloudstack.apache.org
> Subject: RE: master build breaks at
> com.cloud.vpc.NetworkACLServiceTest
> 
> Being in the habit of replying on my own mails as I seems to be on 
> this list;
> 
> This seems to be related to eclipse refresh/build code. Does anybody 
> have a solution to it? The problem is not consistently present but all 
> the more irritating.
> 
> Regards,
> 
> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: maandag 27 mei 2013 7:49
> To: dev@cloudstack.apache.org
> Subject: master build breaks at com.cloud.vpc.NetworkACLServiceTest
> 
> LS,
> 
> Lately I've been getting,
> "com.cloud.exception.InvalidParameterValueException: ACL item with 
> number 1 already exists in ACL: null", while building cloudstack. I 
> first thought it was my own hack so I don't know when it was 
> introduced (it is in a clean master that it happens). The full surfire report 
> follows:
> 
> --
> - Test set: com.cloud.vpc.NetworkACLServiceTest
> --
> - Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 0.219 sec <<< FAILURE!
> testCreateACLItem(com.cloud.vpc.NetworkACLServiceTest)  Time elapsed:
> 0.016 sec  <<< ERROR!
> com.cloud.exception.InvalidParameterValueException: ACL item with 
> number 1 already exists in ACL: null
> at
> com.cloud.network.vpc.NetworkACLServiceImpl.createNetworkACLItem(Ne
> tworkACLServiceImpl.java:270)
> at
> com.cloud.vpc.NetworkACLServiceTest.testCreateACLItem(NetworkACLServ
> iceTest.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Framework
> Method.java:45)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCall
> able.jav
> a:15)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(Framework
> Method.java:42)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMeth
> od.java:20)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.j
> ava
> :28)
> at
> org.springframework.test.context.junit4.statements.RunBeforeTestMethod
> Callbacks.evaluate(RunBeforeTestMethodCallbacks.java:74)
> at
> org.springframework.test.context.junit4.statements.RunAfterTestMethodC
> allbacks.evaluate(RunAfterTestMethodCallbacks.java:83)
> at
> org.springframework.test.context.junit4.statements.SpringRepeat.evalua
> te(
> SpringRepeat.java:72)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChi
> ld(S
> pringJUnit4ClassRunner.java:231)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunn
> er.j
> ava:47)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
> at 
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
> at 
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
> at
> org.springframework.test.context.junit4.statements.RunB

RE: PLEASE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

[Pranav Saxena]

What you might want to try to unblock yourself - whatever method you see is 
failing , go to that file and remove the @Test annotation written just above 
that method . This would skip that particular test .  In your  case it is this 
file - 

com.cloud.vpc.NetworkACLServiceTest.testCreateACLItem(NetworkACLServ
> iceTest.java:141)

Thanks,
Pranav

-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] 
Sent: Monday, May 27, 2013 10:09 PM
To: dev@cloudstack.apache.org
Subject: PLEASE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

I ran the test in eclipse, it passes, next I do a maven build in eclipse which 
fails on this test. How do I force it to pass, please. This is costing me 
serious time. I am not working on ACLs

Regards,
Daan Hoogland

-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
Sent: maandag 27 mei 2013 18:23
To: dev@cloudstack.apache.org
Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

And if not how do I manipulate the order of tests?

-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
Sent: maandag 27 mei 2013 17:02
To: dev@cloudstack.apache.org
Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

Alex,

Can this change out of the box? I had the problem on a clean checkout of master.

-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com]
Sent: maandag 27 mei 2013 15:55
To: dev@cloudstack.apache.org
Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

Daan,

The other possibility is that the test is affected by another test so that it 
breaks when the tests are in a certain order.  Have you noticed what's the 
order of the tests ran when it breaks?

--Alex

> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: Monday, May 27, 2013 2:37 AM
> To: dev@cloudstack.apache.org
> Subject: RE: master build breaks at
> com.cloud.vpc.NetworkACLServiceTest
> 
> Being in the habit of replying on my own mails as I seems to be on 
> this list;
> 
> This seems to be related to eclipse refresh/build code. Does anybody 
> have a solution to it? The problem is not consistently present but all 
> the more irritating.
> 
> Regards,
> 
> -Original Message-
> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
> Sent: maandag 27 mei 2013 7:49
> To: dev@cloudstack.apache.org
> Subject: master build breaks at com.cloud.vpc.NetworkACLServiceTest
> 
> LS,
> 
> Lately I've been getting,
> "com.cloud.exception.InvalidParameterValueException: ACL item with 
> number 1 already exists in ACL: null", while building cloudstack. I 
> first thought it was my own hack so I don't know when it was 
> introduced (it is in a clean master that it happens). The full surfire report 
> follows:
> 
> --
> - Test set: com.cloud.vpc.NetworkACLServiceTest
> --
> - Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 0.219 sec <<< FAILURE!
> testCreateACLItem(com.cloud.vpc.NetworkACLServiceTest)  Time elapsed:
> 0.016 sec  <<< ERROR!
> com.cloud.exception.InvalidParameterValueException: ACL item with 
> number 1 already exists in ACL: null
> at
> com.cloud.network.vpc.NetworkACLServiceImpl.createNetworkACLItem(Ne
> tworkACLServiceImpl.java:270)
> at
> com.cloud.vpc.NetworkACLServiceTest.testCreateACLItem(NetworkACLServ
> iceTest.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Framework
> Method.java:45)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCall
> able.jav
> a:15)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(Framework
> Method.java:42)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMeth
> od.java:20)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.j
> ava
> :28)
> at
> org.springframework.test.context.junit4.statements.RunBeforeTestMethod
> Callbacks.evaluate(RunBeforeTestMethodCallbacks.java:74)
> at
> org.springframework.test.context.junit4.statements.RunAfterTestMethodC
> allbacks.evaluate(RunAfterTestMethodCallbacks.java:83)
> at
> org.springframework.test.context.junit4.statements.SpringRepeat.evalua
> te(
> SpringRepeat.java:72)
> at
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChi
> ld(S
> pringJUnit4ClassRunner.java:231)
>

LDAP auth broken?

[Francois Gaudreault]

Hi,

I am using 4.1 commit "8a9206fd28872dd436b22b847e93466f06e043bc", and I 
am getting this error when trying to authenticate using LDAP:


java.lang.NullPointerException
at 
com.sun.jndi.ldap.LdapNamingEnumeration.getNextBatch(LdapNamingEnumeration.java:129)
at 
com.sun.jndi.ldap.LdapNamingEnumeration.nextAux(LdapNamingEnumeration.java:263)
at 
com.sun.jndi.ldap.LdapNamingEnumeration.nextImpl(LdapNamingEnumeration.java:254)
at 
com.sun.jndi.ldap.LdapNamingEnumeration.next(LdapNamingEnumeration.java:202)
at 
com.cloud.server.auth.LDAPUserAuthenticator.authenticate(LDAPUserAuthenticator.java:115)
at 
com.cloud.user.AccountManagerImpl.getUserAccount(AccountManagerImpl.java:1912)
at 
com.cloud.user.AccountManagerImpl.authenticateUser(AccountManagerImpl.java:1784)

at com.cloud.api.ApiServer.loginUser(ApiServer.java:766)
at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:210)
at com.cloud.api.ApiServlet.doPost(ApiServlet.java:71)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at 
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
at 
org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:889)
at 
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:721)
at 
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2274)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)

at java.lang.Thread.run(Thread.java:679)
WARN  [server.auth.LDAPUserAuthenticator] (catalina-exec-21:) Unknown 
error encountered null


Any ideas?

I tested using ldapsearch and it works fine.

--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_

[GSOC] Five projects accepted for 2013 Google Summer of Code

[Sebastien Goasguen]

Hi,

I am pleased to report that the following projects have been accepted by the 
2013 Google Summer of Code:

"CloudStack: LDAP user provisioning", Ian Duffy

"Improving CloudStack support in Apache Whirr and Apache Provisionr 
incubating", Meng Han

"Integration project to deploy and use Apache Mesos on a CloudStack based 
Cloud" Dharmesh Kakadia

"A New Modular UI for Apache CloudStack" Shiva Teja Reddy

"Add Xen/XCP support for GRE SDN Controller" Nguyen Anh Tu

Join me in congratulating all five and welcoming them to the Apache CloudStack 
community this summer.

Abhi, Kelcey, Hugo and Myself will be their mentors but if you see questions 
from any of these five students feel free to jump in and help them out.

Happy coding,

Cheers,

-Sebastien

Re: [VOTE] List CloudStack related books on the website

[Rohit Yadav]

-1 list of books etc. on website (binding, if committers are allowed to do
that).

The list should be on the project wiki and not on the website.
Even if we have the right intention, the website should ought not be seen
as platform of promoting anything other than the materials published within
Apache CloudStack, which means promoting anything which means books,
goodies and things of that sort.

What we can do is create a wiki on things about CloudStack, which we
already have and in the education/how-to section add list of books related
to CloudStack or cloud computing, but on the wiki and not on the website.

Cheers.

On Mon, May 27, 2013 at 1:57 PM, Sebastien Goasguen wrote:

> Hi,
>
> After a relatively long discussion on the marketing@ list about the
> "Packt Book" [1] I would like to call a vote.
>
> Proposal:
> 
> I propose to list CloudStack related books on our website [2]. The page
> listing these books would contain the following disclaimer:
>
> "This listing does not represent official endorsement by the Apache
> CloudStack project. The Apache CloudStack project does not recommend one
> book versus another nor does it guarantee the quality of the books."
>
> Inclusion of a book in the listing would be done via a vote on the
> marketing@ list.
> 
>
> As a quick summary, alternatives to this proposal were to:
> 1-not do anything
> 2-list the books on the wiki
>
> A few of us have already expressed their opinions and discussed the
> possibilities. Check [1].
>
> Vote will be open for 96 hours (To accommodate Memorial day in the USA).
>
> Reply with:
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
> PS: If edits of the disclaimer are needed but that they do not change the
> meaning of it, the disclaimer will be modified but the vote will not be
> restarted.
>
> [1] http://markmail.org/thread/r4qdmbonmx6yq2uv
> [2] http://cloudstack.apache.org
>
> -Sebastien

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/#review21071
---


Commit a5723992a0eeea9fc383c656b0d61dfc9e541ff9 in branch refs/heads/4.0 from 
Wei Zhou 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a572399 ]

CLOUDSTACK-1325: add password in response of RestoreVM


- ASF Subversion and Git Services


On May 6, 2013, 5:12 a.m., Wei Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> ---
> 
> (Updated May 6, 2013, 5:12 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Harikrishna Patnala.
> 
> 
> Description
> ---
> 
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
> 
> This patch add a new password in the response.
> 
> 
> This addresses bug CLOUDSTACK-1325.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/UserVmService.java 6635657 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 
> 
> Diff: https://reviews.apache.org/r/9539/diff/
> 
> 
> Testing
> ---
> 
> Testing manually ok.
> 
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
> 
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: [GSOC] Five projects accepted for 2013 Google Summer of Code

[Kelcey Jamison Damage]

Awesome! I pasted this list in my 'important' folder, lol

- Original Message -
From: "Sebastien Goasguen" 
To: dev@cloudstack.apache.org
Sent: Monday, May 27, 2013 12:23:40 PM
Subject: [GSOC] Five projects accepted for 2013 Google Summer of Code

Hi,

I am pleased to report that the following projects have been accepted by the 
2013 Google Summer of Code:

"CloudStack: LDAP user provisioning", Ian Duffy

"Improving CloudStack support in Apache Whirr and Apache Provisionr 
incubating", Meng Han

"Integration project to deploy and use Apache Mesos on a CloudStack based 
Cloud" Dharmesh Kakadia

"A New Modular UI for Apache CloudStack" Shiva Teja Reddy

"Add Xen/XCP support for GRE SDN Controller" Nguyen Anh Tu

Join me in congratulating all five and welcoming them to the Apache CloudStack 
community this summer.

Abhi, Kelcey, Hugo and Myself will be their mentors but if you see questions 
from any of these five students feel free to jump in and help them out.

Happy coding,

Cheers,

-Sebastien

Re: [VOTE] List CloudStack related books on the website

[Noah Slater]

As a committer you have a binding vote. However, our by-laws do not make it
clear what sort of decision-making process we use for non-technical matters
such as this. So I am not sure whether your -1 counts as a veto.


On 27 May 2013 19:14, Rohit Yadav  wrote:

> -1 list of books etc. on website (binding, if committers are allowed to do
> that).
>
> The list should be on the project wiki and not on the website.
> Even if we have the right intention, the website should ought not be seen
> as platform of promoting anything other than the materials published within
> Apache CloudStack, which means promoting anything which means books,
> goodies and things of that sort.
>
> What we can do is create a wiki on things about CloudStack, which we
> already have and in the education/how-to section add list of books related
> to CloudStack or cloud computing, but on the wiki and not on the website.
>
> Cheers.
>
> On Mon, May 27, 2013 at 1:57 PM, Sebastien Goasguen  >wrote:
>
> > Hi,
> >
> > After a relatively long discussion on the marketing@ list about the
> > "Packt Book" [1] I would like to call a vote.
> >
> > Proposal:
> > 
> > I propose to list CloudStack related books on our website [2]. The page
> > listing these books would contain the following disclaimer:
> >
> > "This listing does not represent official endorsement by the Apache
> > CloudStack project. The Apache CloudStack project does not recommend one
> > book versus another nor does it guarantee the quality of the books."
> >
> > Inclusion of a book in the listing would be done via a vote on the
> > marketing@ list.
> > 
> >
> > As a quick summary, alternatives to this proposal were to:
> > 1-not do anything
> > 2-list the books on the wiki
> >
> > A few of us have already expressed their opinions and discussed the
> > possibilities. Check [1].
> >
> > Vote will be open for 96 hours (To accommodate Memorial day in the USA).
> >
> > Reply with:
> >
> > [ ] +1  approve
> > [ ] +0  no opinion
> > [ ] -1  disapprove (and reason why)
> >
> > PS: If edits of the disclaimer are needed but that they do not change the
> > meaning of it, the disclaimer will be modified but the vote will not be
> > restarted.
> >
> > [1] http://markmail.org/thread/r4qdmbonmx6yq2uv
> > [2] http://cloudstack.apache.org
> >
> > -Sebastien
>



-- 
NS

Re: Question about Review Request

[Mike Tutkowski]

Thanks for the reply, Sebastien!

So, I went ahead and updated from upstream again and merged upstream/master
to master, then merged master to solidfire_plugin.

I created another patch file and tried to upload it to Review Board, but
received the same error message.

I then tried to apply the patch file to a new branch, called
solidfire_plugin2, that I created off of master.

There was no error output when I did an apply --check, but when I actually
tried to apply the patch I received the following output (any thoughts?):

mtutkowski-LT:cloudstack mtutkowski$ git apply solidfire_plugin.patch
solidfire_plugin.patch:66: trailing whitespace.

solidfire_plugin.patch:68: trailing whitespace.

solidfire_plugin.patch:70: trailing whitespace.

solidfire_plugin.patch:72: trailing whitespace.

solidfire_plugin.patch:74: trailing whitespace.

warning: squelched 708 whitespace errors
warning: 713 lines add whitespace errors.


On Mon, May 27, 2013 at 1:45 AM, Sebastien Goasguen wrote:

>
> On May 27, 2013, at 1:55 AM, Mike Tutkowski 
> wrote:
>
> > Hi everyone,
> >
> > I'm trying to submit code for the first time.
> >
> > I'm following the instructions here:
> >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines
> >
> > When it says to upload my diff, I assume it means my .patch file. Is that
> > correct?
> >
> > I generate such a file this way:
> >
> > git format-patch upstream/master --stdout > solidfire_plugin.patch
> >
>
> That should work. I usually just do:
> git format-patch master --stdout > my.patch
>
> > It works just fine, but when I try to upload it by clicking on the Create
> > Review Request button, I get the following error:
> >
> > The file
> >
> 'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java'
> > (r5f45a62) could not be found in the repository
> > *
> > *
>
> Create a fresh branch out of your local master and try to see if your
> patch applies cleanly:
> git --check apply ( I think).
>
> Maybe it's a relative path issue (just a wild guess).
>
>
> > I'm not sure why it says this because this file is a part of the current
> > repository.
> >
> > Would someone be able to explain what I might be doing wrong here?
> >
> > I did update from the ACS repo and merge its master (my upstream/master)
> > into my solidfire_plugin branch recently. After doing this, I committed
> the
> > changes and made my .patch file.
> >
>
> Did you check your patch making sure that all changed files were staged ?
>
> I always do a git status -s , it's very helpful.
>
> > Thanks!
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *™*
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Question about Review Request

[Mike Tutkowski]

Regardless of those whitespace messages, it looks like my new branch
(solidfire_plugin2) does have the changes in the patch file (they show up
as modified, but not staged files or - in the case of new files - untracked
files).


On Mon, May 27, 2013 at 5:36 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Thanks for the reply, Sebastien!
>
> So, I went ahead and updated from upstream again and merged
> upstream/master to master, then merged master to solidfire_plugin.
>
> I created another patch file and tried to upload it to Review Board, but
> received the same error message.
>
> I then tried to apply the patch file to a new branch, called
> solidfire_plugin2, that I created off of master.
>
> There was no error output when I did an apply --check, but when I actually
> tried to apply the patch I received the following output (any thoughts?):
>
> mtutkowski-LT:cloudstack mtutkowski$ git apply solidfire_plugin.patch
> solidfire_plugin.patch:66: trailing whitespace.
>
> solidfire_plugin.patch:68: trailing whitespace.
>
> solidfire_plugin.patch:70: trailing whitespace.
>
> solidfire_plugin.patch:72: trailing whitespace.
>
> solidfire_plugin.patch:74: trailing whitespace.
>
> warning: squelched 708 whitespace errors
> warning: 713 lines add whitespace errors.
>
>
> On Mon, May 27, 2013 at 1:45 AM, Sebastien Goasguen wrote:
>
>>
>> On May 27, 2013, at 1:55 AM, Mike Tutkowski 
>> wrote:
>>
>> > Hi everyone,
>> >
>> > I'm trying to submit code for the first time.
>> >
>> > I'm following the instructions here:
>> >
>> >
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines
>> >
>> > When it says to upload my diff, I assume it means my .patch file. Is
>> that
>> > correct?
>> >
>> > I generate such a file this way:
>> >
>> > git format-patch upstream/master --stdout > solidfire_plugin.patch
>> >
>>
>> That should work. I usually just do:
>> git format-patch master --stdout > my.patch
>>
>> > It works just fine, but when I try to upload it by clicking on the
>> Create
>> > Review Request button, I get the following error:
>> >
>> > The file
>> >
>> 'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java'
>> > (r5f45a62) could not be found in the repository
>> > *
>> > *
>>
>> Create a fresh branch out of your local master and try to see if your
>> patch applies cleanly:
>> git --check apply ( I think).
>>
>> Maybe it's a relative path issue (just a wild guess).
>>
>>
>> > I'm not sure why it says this because this file is a part of the current
>> > repository.
>> >
>> > Would someone be able to explain what I might be doing wrong here?
>> >
>> > I did update from the ACS repo and merge its master (my upstream/master)
>> > into my solidfire_plugin branch recently. After doing this, I committed
>> the
>> > changes and made my .patch file.
>> >
>>
>> Did you check your patch making sure that all changed files were staged ?
>>
>> I always do a git status -s , it's very helpful.
>>
>> > Thanks!
>> >
>> > --
>> > *Mike Tutkowski*
>> > *Senior CloudStack Developer, SolidFire Inc.*
>> > e: mike.tutkow...@solidfire.com
>> > o: 303.746.7302
>> > Advancing the way the world uses the
>> > cloud
>> > *™*
>>
>>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the 
> cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Question about Review Request

[Chip Childers]

Can you send the patch to the list as a txt attachment with a subject
line that indicates you want to have it reviewed and committed?
Perhaps we have to do this the old fashioned way.

On May 27, 2013, at 7:46 PM, Mike Tutkowski
 wrote:

> Regardless of those whitespace messages, it looks like my new branch
> (solidfire_plugin2) does have the changes in the patch file (they show up
> as modified, but not staged files or - in the case of new files - untracked
> files).
>
>
> On Mon, May 27, 2013 at 5:36 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Thanks for the reply, Sebastien!
>>
>> So, I went ahead and updated from upstream again and merged
>> upstream/master to master, then merged master to solidfire_plugin.
>>
>> I created another patch file and tried to upload it to Review Board, but
>> received the same error message.
>>
>> I then tried to apply the patch file to a new branch, called
>> solidfire_plugin2, that I created off of master.
>>
>> There was no error output when I did an apply --check, but when I actually
>> tried to apply the patch I received the following output (any thoughts?):
>>
>> mtutkowski-LT:cloudstack mtutkowski$ git apply solidfire_plugin.patch
>> solidfire_plugin.patch:66: trailing whitespace.
>>
>> solidfire_plugin.patch:68: trailing whitespace.
>>
>> solidfire_plugin.patch:70: trailing whitespace.
>>
>> solidfire_plugin.patch:72: trailing whitespace.
>>
>> solidfire_plugin.patch:74: trailing whitespace.
>>
>> warning: squelched 708 whitespace errors
>> warning: 713 lines add whitespace errors.
>>
>>
>> On Mon, May 27, 2013 at 1:45 AM, Sebastien Goasguen wrote:
>>
>>>
>>> On May 27, 2013, at 1:55 AM, Mike Tutkowski 
>>> wrote:
>>>
 Hi everyone,

 I'm trying to submit code for the first time.

 I'm following the instructions here:
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines

 When it says to upload my diff, I assume it means my .patch file. Is
>>> that
 correct?

 I generate such a file this way:

 git format-patch upstream/master --stdout > solidfire_plugin.patch
>>>
>>> That should work. I usually just do:
>>> git format-patch master --stdout > my.patch
>>>
 It works just fine, but when I try to upload it by clicking on the
>>> Create
 Review Request button, I get the following error:

 The file
>>> 'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java'
 (r5f45a62) could not be found in the repository
 *
 *
>>>
>>> Create a fresh branch out of your local master and try to see if your
>>> patch applies cleanly:
>>> git --check apply ( I think).
>>>
>>> Maybe it's a relative path issue (just a wild guess).
>>>
>>>
 I'm not sure why it says this because this file is a part of the current
 repository.

 Would someone be able to explain what I might be doing wrong here?

 I did update from the ACS repo and merge its master (my upstream/master)
 into my solidfire_plugin branch recently. After doing this, I committed
>>> the
 changes and made my .patch file.
>>>
>>> Did you check your patch making sure that all changed files were staged ?
>>>
>>> I always do a git status -s , it's very helpful.
>>>
 Thanks!

 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloud
 *™*
>>
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the 
>> cloud
>> *™*
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *™*

Re: Question about Review Request

[Mike Tutkowski]

Sounds good

I have sent out an e-mail under the subject of "Patch File for Review
(Storage Plug-in Related)".

Thanks!

I supposed we'll need to find out what wasn't working with Review Board if
my next patch has similar trouble. :)


On Mon, May 27, 2013 at 6:24 PM, Chip Childers wrote:

> Can you send the patch to the list as a txt attachment with a subject
> line that indicates you want to have it reviewed and committed?
> Perhaps we have to do this the old fashioned way.
>
> On May 27, 2013, at 7:46 PM, Mike Tutkowski
>  wrote:
>
> > Regardless of those whitespace messages, it looks like my new branch
> > (solidfire_plugin2) does have the changes in the patch file (they show up
> > as modified, but not staged files or - in the case of new files -
> untracked
> > files).
> >
> >
> > On Mon, May 27, 2013 at 5:36 PM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> >> Thanks for the reply, Sebastien!
> >>
> >> So, I went ahead and updated from upstream again and merged
> >> upstream/master to master, then merged master to solidfire_plugin.
> >>
> >> I created another patch file and tried to upload it to Review Board, but
> >> received the same error message.
> >>
> >> I then tried to apply the patch file to a new branch, called
> >> solidfire_plugin2, that I created off of master.
> >>
> >> There was no error output when I did an apply --check, but when I
> actually
> >> tried to apply the patch I received the following output (any
> thoughts?):
> >>
> >> mtutkowski-LT:cloudstack mtutkowski$ git apply solidfire_plugin.patch
> >> solidfire_plugin.patch:66: trailing whitespace.
> >>
> >> solidfire_plugin.patch:68: trailing whitespace.
> >>
> >> solidfire_plugin.patch:70: trailing whitespace.
> >>
> >> solidfire_plugin.patch:72: trailing whitespace.
> >>
> >> solidfire_plugin.patch:74: trailing whitespace.
> >>
> >> warning: squelched 708 whitespace errors
> >> warning: 713 lines add whitespace errors.
> >>
> >>
> >> On Mon, May 27, 2013 at 1:45 AM, Sebastien Goasguen  >wrote:
> >>
> >>>
> >>> On May 27, 2013, at 1:55 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com>
> >>> wrote:
> >>>
>  Hi everyone,
> 
>  I'm trying to submit code for the first time.
> 
>  I'm following the instructions here:
> >>>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines
> 
>  When it says to upload my diff, I assume it means my .patch file. Is
> >>> that
>  correct?
> 
>  I generate such a file this way:
> 
>  git format-patch upstream/master --stdout > solidfire_plugin.patch
> >>>
> >>> That should work. I usually just do:
> >>> git format-patch master --stdout > my.patch
> >>>
>  It works just fine, but when I try to upload it by clicking on the
> >>> Create
>  Review Request button, I get the following error:
> 
>  The file
> >>>
> 'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java'
>  (r5f45a62) could not be found in the repository
>  *
>  *
> >>>
> >>> Create a fresh branch out of your local master and try to see if your
> >>> patch applies cleanly:
> >>> git --check apply ( I think).
> >>>
> >>> Maybe it's a relative path issue (just a wild guess).
> >>>
> >>>
>  I'm not sure why it says this because this file is a part of the
> current
>  repository.
> 
>  Would someone be able to explain what I might be doing wrong here?
> 
>  I did update from the ACS repo and merge its master (my
> upstream/master)
>  into my solidfire_plugin branch recently. After doing this, I
> committed
> >>> the
>  changes and made my .patch file.
> >>>
> >>> Did you check your patch making sure that all changed files were
> staged ?
> >>>
> >>> I always do a git status -s , it's very helpful.
> >>>
>  Thanks!
> 
>  --
>  *Mike Tutkowski*
>  *Senior CloudStack Developer, SolidFire Inc.*
>  e: mike.tutkow...@solidfire.com
>  o: 303.746.7302
>  Advancing the way the world uses the
>  cloud
>  *™*
> >>
> >>
> >> --
> >> *Mike Tutkowski*
> >> *Senior CloudStack Developer, SolidFire Inc.*
> >> e: mike.tutkow...@solidfire.com
> >> o: 303.746.7302
> >> Advancing the way the world uses the cloud<
> http://solidfire.com/solution/overview/?video=play>
> >> *™*
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Question about Review Request

[John Burwell]

Mike,

I would encourage Review Board as the first preference.  It provides a
good medium to review code and encourage other project members to
review patches, as well as, observe the review process.

Thanks,
-John




On May 27, 2013, at 8:42 PM, Mike Tutkowski
 wrote:

> Sounds good
>
> I have sent out an e-mail under the subject of "Patch File for Review
> (Storage Plug-in Related)".
>
> Thanks!
>
> I supposed we'll need to find out what wasn't working with Review Board if
> my next patch has similar trouble. :)
>
>
> On Mon, May 27, 2013 at 6:24 PM, Chip Childers 
> wrote:
>
>> Can you send the patch to the list as a txt attachment with a subject
>> line that indicates you want to have it reviewed and committed?
>> Perhaps we have to do this the old fashioned way.
>>
>> On May 27, 2013, at 7:46 PM, Mike Tutkowski
>>  wrote:
>>
>>> Regardless of those whitespace messages, it looks like my new branch
>>> (solidfire_plugin2) does have the changes in the patch file (they show up
>>> as modified, but not staged files or - in the case of new files -
>> untracked
>>> files).
>>>
>>>
>>> On Mon, May 27, 2013 at 5:36 PM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com> wrote:
>>>
 Thanks for the reply, Sebastien!

 So, I went ahead and updated from upstream again and merged
 upstream/master to master, then merged master to solidfire_plugin.

 I created another patch file and tried to upload it to Review Board, but
 received the same error message.

 I then tried to apply the patch file to a new branch, called
 solidfire_plugin2, that I created off of master.

 There was no error output when I did an apply --check, but when I
>> actually
 tried to apply the patch I received the following output (any
>> thoughts?):

 mtutkowski-LT:cloudstack mtutkowski$ git apply solidfire_plugin.patch
 solidfire_plugin.patch:66: trailing whitespace.

 solidfire_plugin.patch:68: trailing whitespace.

 solidfire_plugin.patch:70: trailing whitespace.

 solidfire_plugin.patch:72: trailing whitespace.

 solidfire_plugin.patch:74: trailing whitespace.

 warning: squelched 708 whitespace errors
 warning: 713 lines add whitespace errors.


 On Mon, May 27, 2013 at 1:45 AM, Sebastien Goasguen >> wrote:

>
> On May 27, 2013, at 1:55 AM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com>
> wrote:
>
>> Hi everyone,
>>
>> I'm trying to submit code for the first time.
>>
>> I'm following the instructions here:
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines
>>
>> When it says to upload my diff, I assume it means my .patch file. Is
> that
>> correct?
>>
>> I generate such a file this way:
>>
>> git format-patch upstream/master --stdout > solidfire_plugin.patch
>
> That should work. I usually just do:
> git format-patch master --stdout > my.patch
>
>> It works just fine, but when I try to upload it by clicking on the
> Create
>> Review Request button, I get the following error:
>>
>> The file
>> 'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java'
>> (r5f45a62) could not be found in the repository
>> *
>> *
>
> Create a fresh branch out of your local master and try to see if your
> patch applies cleanly:
> git --check apply ( I think).
>
> Maybe it's a relative path issue (just a wild guess).
>
>
>> I'm not sure why it says this because this file is a part of the
>> current
>> repository.
>>
>> Would someone be able to explain what I might be doing wrong here?
>>
>> I did update from the ACS repo and merge its master (my
>> upstream/master)
>> into my solidfire_plugin branch recently. After doing this, I
>> committed
> the
>> changes and made my .patch file.
>
> Did you check your patch making sure that all changed files were
>> staged ?
>
> I always do a git status -s , it's very helpful.
>
>> Thanks!
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the
>> cloud
>> *™*


 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the cloud<
>> http://solidfire.com/solution/overview/?video=play>
 *™*
>>>
>>>
>>>
>>> --
>>> *Mike Tutkowski*
>>> *Senior CloudStack Developer, SolidFire Inc.*
>>> e: mike.tutkow...@solidfire.com
>>> o: 303.746.7302
>>> Advancing the way the world uses the
>>> cloud
>>> *™*
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFi

Re: Question about Review Request

[Mike Tutkowski]

Yeah, I certainly agree with you, John.

Any thoughts on what I might do to make Review Board work in my situation?

I am new to Review Board and don't know why my patch file won't upload, but
does apply to a new branch in my local repo.

Thanks!


On Mon, May 27, 2013 at 7:24 PM, John Burwell  wrote:

> Mike,
>
> I would encourage Review Board as the first preference.  It provides a
> good medium to review code and encourage other project members to
> review patches, as well as, observe the review process.
>
> Thanks,
> -John
>
>
>
>
> On May 27, 2013, at 8:42 PM, Mike Tutkowski
>  wrote:
>
> > Sounds good
> >
> > I have sent out an e-mail under the subject of "Patch File for Review
> > (Storage Plug-in Related)".
> >
> > Thanks!
> >
> > I supposed we'll need to find out what wasn't working with Review Board
> if
> > my next patch has similar trouble. :)
> >
> >
> > On Mon, May 27, 2013 at 6:24 PM, Chip Childers <
> chip.child...@sungard.com>wrote:
> >
> >> Can you send the patch to the list as a txt attachment with a subject
> >> line that indicates you want to have it reviewed and committed?
> >> Perhaps we have to do this the old fashioned way.
> >>
> >> On May 27, 2013, at 7:46 PM, Mike Tutkowski
> >>  wrote:
> >>
> >>> Regardless of those whitespace messages, it looks like my new branch
> >>> (solidfire_plugin2) does have the changes in the patch file (they show
> up
> >>> as modified, but not staged files or - in the case of new files -
> >> untracked
> >>> files).
> >>>
> >>>
> >>> On Mon, May 27, 2013 at 5:36 PM, Mike Tutkowski <
> >>> mike.tutkow...@solidfire.com> wrote:
> >>>
>  Thanks for the reply, Sebastien!
> 
>  So, I went ahead and updated from upstream again and merged
>  upstream/master to master, then merged master to solidfire_plugin.
> 
>  I created another patch file and tried to upload it to Review Board,
> but
>  received the same error message.
> 
>  I then tried to apply the patch file to a new branch, called
>  solidfire_plugin2, that I created off of master.
> 
>  There was no error output when I did an apply --check, but when I
> >> actually
>  tried to apply the patch I received the following output (any
> >> thoughts?):
> 
>  mtutkowski-LT:cloudstack mtutkowski$ git apply solidfire_plugin.patch
>  solidfire_plugin.patch:66: trailing whitespace.
> 
>  solidfire_plugin.patch:68: trailing whitespace.
> 
>  solidfire_plugin.patch:70: trailing whitespace.
> 
>  solidfire_plugin.patch:72: trailing whitespace.
> 
>  solidfire_plugin.patch:74: trailing whitespace.
> 
>  warning: squelched 708 whitespace errors
>  warning: 713 lines add whitespace errors.
> 
> 
>  On Mon, May 27, 2013 at 1:45 AM, Sebastien Goasguen  >>> wrote:
> 
> >
> > On May 27, 2013, at 1:55 AM, Mike Tutkowski <
> >> mike.tutkow...@solidfire.com>
> > wrote:
> >
> >> Hi everyone,
> >>
> >> I'm trying to submit code for the first time.
> >>
> >> I'm following the instructions here:
> >>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines
> >>
> >> When it says to upload my diff, I assume it means my .patch file. Is
> > that
> >> correct?
> >>
> >> I generate such a file this way:
> >>
> >> git format-patch upstream/master --stdout > solidfire_plugin.patch
> >
> > That should work. I usually just do:
> > git format-patch master --stdout > my.patch
> >
> >> It works just fine, but when I try to upload it by clicking on the
> > Create
> >> Review Request button, I get the following error:
> >>
> >> The file
> >>
> 'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java'
> >> (r5f45a62) could not be found in the repository
> >> *
> >> *
> >
> > Create a fresh branch out of your local master and try to see if your
> > patch applies cleanly:
> > git --check apply ( I think).
> >
> > Maybe it's a relative path issue (just a wild guess).
> >
> >
> >> I'm not sure why it says this because this file is a part of the
> >> current
> >> repository.
> >>
> >> Would someone be able to explain what I might be doing wrong here?
> >>
> >> I did update from the ACS repo and merge its master (my
> >> upstream/master)
> >> into my solidfire_plugin branch recently. After doing this, I
> >> committed
> > the
> >> changes and made my .patch file.
> >
> > Did you check your patch making sure that all changed files were
> >> staged ?
> >
> > I always do a git status -s , it's very helpful.
> >
> >> Thanks!
> >>
> >> --
> >> *Mike Tutkowski*
> >> *Senior CloudStack Developer, SolidFire Inc.*
> >> e: mike.tutkow...@solidfire.com
> >> o: 303.746.7302
> >> Advancing the way the world uses the
> >> cloud

Re: Question about Review Request

[Chip Childers]

I was going to use his attachment tomorrow, to figure out what's wrong
with review board. Agreed that its a preference!

On May 27, 2013, at 9:25 PM, John Burwell  wrote:

> Mike,
>
> I would encourage Review Board as the first preference.  It provides a
> good medium to review code and encourage other project members to
> review patches, as well as, observe the review process.
>
> Thanks,
> -John
>
>
>
>
> On May 27, 2013, at 8:42 PM, Mike Tutkowski
>  wrote:
>
>> Sounds good
>>
>> I have sent out an e-mail under the subject of "Patch File for Review
>> (Storage Plug-in Related)".
>>
>> Thanks!
>>
>> I supposed we'll need to find out what wasn't working with Review Board if
>> my next patch has similar trouble. :)
>>
>>
>> On Mon, May 27, 2013 at 6:24 PM, Chip Childers 
>> wrote:
>>
>>> Can you send the patch to the list as a txt attachment with a subject
>>> line that indicates you want to have it reviewed and committed?
>>> Perhaps we have to do this the old fashioned way.
>>>
>>> On May 27, 2013, at 7:46 PM, Mike Tutkowski
>>>  wrote:
>>>
 Regardless of those whitespace messages, it looks like my new branch
 (solidfire_plugin2) does have the changes in the patch file (they show up
 as modified, but not staged files or - in the case of new files -
>>> untracked
 files).


 On Mon, May 27, 2013 at 5:36 PM, Mike Tutkowski <
 mike.tutkow...@solidfire.com> wrote:

> Thanks for the reply, Sebastien!
>
> So, I went ahead and updated from upstream again and merged
> upstream/master to master, then merged master to solidfire_plugin.
>
> I created another patch file and tried to upload it to Review Board, but
> received the same error message.
>
> I then tried to apply the patch file to a new branch, called
> solidfire_plugin2, that I created off of master.
>
> There was no error output when I did an apply --check, but when I
>>> actually
> tried to apply the patch I received the following output (any
>>> thoughts?):
>
> mtutkowski-LT:cloudstack mtutkowski$ git apply solidfire_plugin.patch
> solidfire_plugin.patch:66: trailing whitespace.
>
> solidfire_plugin.patch:68: trailing whitespace.
>
> solidfire_plugin.patch:70: trailing whitespace.
>
> solidfire_plugin.patch:72: trailing whitespace.
>
> solidfire_plugin.patch:74: trailing whitespace.
>
> warning: squelched 708 whitespace errors
> warning: 713 lines add whitespace errors.
>
>
> On Mon, May 27, 2013 at 1:45 AM, Sebastien Goasguen >>> wrote:
>
>>
>> On May 27, 2013, at 1:55 AM, Mike Tutkowski <
>>> mike.tutkow...@solidfire.com>
>> wrote:
>>
>>> Hi everyone,
>>>
>>> I'm trying to submit code for the first time.
>>>
>>> I'm following the instructions here:
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines
>>>
>>> When it says to upload my diff, I assume it means my .patch file. Is
>> that
>>> correct?
>>>
>>> I generate such a file this way:
>>>
>>> git format-patch upstream/master --stdout > solidfire_plugin.patch
>>
>> That should work. I usually just do:
>> git format-patch master --stdout > my.patch
>>
>>> It works just fine, but when I try to upload it by clicking on the
>> Create
>>> Review Request button, I get the following error:
>>>
>>> The file
>>> 'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java'
>>> (r5f45a62) could not be found in the repository
>>> *
>>> *
>>
>> Create a fresh branch out of your local master and try to see if your
>> patch applies cleanly:
>> git --check apply ( I think).
>>
>> Maybe it's a relative path issue (just a wild guess).
>>
>>
>>> I'm not sure why it says this because this file is a part of the
>>> current
>>> repository.
>>>
>>> Would someone be able to explain what I might be doing wrong here?
>>>
>>> I did update from the ACS repo and merge its master (my
>>> upstream/master)
>>> into my solidfire_plugin branch recently. After doing this, I
>>> committed
>> the
>>> changes and made my .patch file.
>>
>> Did you check your patch making sure that all changed files were
>>> staged ?
>>
>> I always do a git status -s , it's very helpful.
>>
>>> Thanks!
>>>
>>> --
>>> *Mike Tutkowski*
>>> *Senior CloudStack Developer, SolidFire Inc.*
>>> e: mike.tutkow...@solidfire.com
>>> o: 303.746.7302
>>> Advancing the way the world uses the
>>> cloud
>>> *™*
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud<
>>> http://solidfire.com/solution/overview/?video=play

Re: Question about Review Request

[John Burwell]

Mike,

What error are you getting from Review Board?  Have you rebased your
branch to master recently?  Finally, are you submitting a squashed
patch?

Thanks,
-John

On May 27, 2013, at 9:27 PM, Mike Tutkowski
 wrote:

> Yeah, I certainly agree with you, John.
>
> Any thoughts on what I might do to make Review Board work in my situation?
>
> I am new to Review Board and don't know why my patch file won't upload, but
> does apply to a new branch in my local repo.
>
> Thanks!
>
>
> On Mon, May 27, 2013 at 7:24 PM, John Burwell  wrote:
>
>> Mike,
>>
>> I would encourage Review Board as the first preference.  It provides a
>> good medium to review code and encourage other project members to
>> review patches, as well as, observe the review process.
>>
>> Thanks,
>> -John
>>
>>
>>
>>
>> On May 27, 2013, at 8:42 PM, Mike Tutkowski
>>  wrote:
>>
>>> Sounds good
>>>
>>> I have sent out an e-mail under the subject of "Patch File for Review
>>> (Storage Plug-in Related)".
>>>
>>> Thanks!
>>>
>>> I supposed we'll need to find out what wasn't working with Review Board
>> if
>>> my next patch has similar trouble. :)
>>>
>>>
>>> On Mon, May 27, 2013 at 6:24 PM, Chip Childers <
>> chip.child...@sungard.com>wrote:
>>>
 Can you send the patch to the list as a txt attachment with a subject
 line that indicates you want to have it reviewed and committed?
 Perhaps we have to do this the old fashioned way.

 On May 27, 2013, at 7:46 PM, Mike Tutkowski
  wrote:

> Regardless of those whitespace messages, it looks like my new branch
> (solidfire_plugin2) does have the changes in the patch file (they show
>> up
> as modified, but not staged files or - in the case of new files -
 untracked
> files).
>
>
> On Mon, May 27, 2013 at 5:36 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Thanks for the reply, Sebastien!
>>
>> So, I went ahead and updated from upstream again and merged
>> upstream/master to master, then merged master to solidfire_plugin.
>>
>> I created another patch file and tried to upload it to Review Board,
>> but
>> received the same error message.
>>
>> I then tried to apply the patch file to a new branch, called
>> solidfire_plugin2, that I created off of master.
>>
>> There was no error output when I did an apply --check, but when I
 actually
>> tried to apply the patch I received the following output (any
 thoughts?):
>>
>> mtutkowski-LT:cloudstack mtutkowski$ git apply solidfire_plugin.patch
>> solidfire_plugin.patch:66: trailing whitespace.
>>
>> solidfire_plugin.patch:68: trailing whitespace.
>>
>> solidfire_plugin.patch:70: trailing whitespace.
>>
>> solidfire_plugin.patch:72: trailing whitespace.
>>
>> solidfire_plugin.patch:74: trailing whitespace.
>>
>> warning: squelched 708 whitespace errors
>> warning: 713 lines add whitespace errors.
>>
>>
>> On Mon, May 27, 2013 at 1:45 AM, Sebastien Goasguen  wrote:
>>
>>>
>>> On May 27, 2013, at 1:55 AM, Mike Tutkowski <
 mike.tutkow...@solidfire.com>
>>> wrote:
>>>
 Hi everyone,

 I'm trying to submit code for the first time.

 I'm following the instructions here:
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines

 When it says to upload my diff, I assume it means my .patch file. Is
>>> that
 correct?

 I generate such a file this way:

 git format-patch upstream/master --stdout > solidfire_plugin.patch
>>>
>>> That should work. I usually just do:
>>> git format-patch master --stdout > my.patch
>>>
 It works just fine, but when I try to upload it by clicking on the
>>> Create
 Review Request button, I get the following error:

 The file
>> 'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java'
 (r5f45a62) could not be found in the repository
 *
 *
>>>
>>> Create a fresh branch out of your local master and try to see if your
>>> patch applies cleanly:
>>> git --check apply ( I think).
>>>
>>> Maybe it's a relative path issue (just a wild guess).
>>>
>>>
 I'm not sure why it says this because this file is a part of the
 current
 repository.

 Would someone be able to explain what I might be doing wrong here?

 I did update from the ACS repo and merge its master (my
 upstream/master)
 into my solidfire_plugin branch recently. After doing this, I
 committed
>>> the
 changes and made my .patch file.
>>>
>>> Did you check your patch making sure that all changed files were
 staged ?
>>>
>>> I always do a git status -s , it's very helpful.
>>>
 Thanks!
>>

Re: Question about Review Request

[Mike Tutkowski]

Hi John,

Here is a copy/paste of part of the e-mail chain.

Thanks!

Hi everyone,

I'm trying to submit code for the first time.

I'm following the instructions here:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines

When it says to upload my diff, I assume it means my .patch file. Is that
correct?

I generate such a file this way:

git format-patch upstream/master --stdout > solidfire_plugin.patch

It works just fine, but when I try to upload it by clicking on the Create
Review Request button, I get the following error:

The file
'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java'
(r5f45a62) could not be found in the repository
*
*
I'm not sure why it says this because this file is a part of the current
repository.

Would someone be able to explain what I might be doing wrong here?

I did update from the ACS repo and merge its master (my upstream/master)
into my solidfire_plugin branch recently. After doing this, I committed the
changes and made my .patch file.

Thanks!
Sebastien Goasguen
1:45 AM (17 hours ago)
to dev
On May 27, 2013, at 1:55 AM, Mike Tutkowski 
wrote:

> Hi everyone,
>
> I'm trying to submit code for the first time.
>
> I'm following the instructions here:
>
>
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines
>
> When it says to upload my diff, I assume it means my .patch file. Is that
> correct?
>
> I generate such a file this way:
>
> git format-patch upstream/master --stdout > solidfire_plugin.patch
>

That should work. I usually just do:
git format-patch master --stdout > my.patch

> It works just fine, but when I try to upload it by clicking on the Create
> Review Request button, I get the following error:
>
> The file
>
'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java'
> (r5f45a62) could not be found in the repository
> *
> *

Create a fresh branch out of your local master and try to see if your patch
applies cleanly:
git --check apply ( I think).

Maybe it's a relative path issue (just a wild guess).


> I'm not sure why it says this because this file is a part of the current
> repository.
>
> Would someone be able to explain what I might be doing wrong here?
>
> I did update from the ACS repo and merge its master (my upstream/master)
> into my solidfire_plugin branch recently. After doing this, I committed
the
> changes and made my .patch file.
>

Did you check your patch making sure that all changed files were staged ?

I always do a git status -s , it's very helpful.

> Thanks!
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *™*
Mike Tutkowski 
5:36 PM (1 hour ago)
to dev
Thanks for the reply, Sebastien!

So, I went ahead and updated from upstream again and merged upstream/master
to master, then merged master to solidfire_plugin.

I created another patch file and tried to upload it to Review Board, but
received the same error message.

I then tried to apply the patch file to a new branch, called
solidfire_plugin2, that I created off of master.

There was no error output when I did an apply --check, but when I actually
tried to apply the patch I received the following output (any thoughts?):

mtutkowski-LT:cloudstack mtutkowski$ git apply solidfire_plugin.patch
solidfire_plugin.patch:66: trailing whitespace.

solidfire_plugin.patch:68: trailing whitespace.

solidfire_plugin.patch:70: trailing whitespace.

solidfire_plugin.patch:72: trailing whitespace.

solidfire_plugin.patch:74: trailing whitespace.

warning: squelched 708 whitespace errors
warning: 713 lines add whitespace errors.
-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*
Mike Tutkowski 
5:45 PM (1 hour ago)
to dev
Regardless of those whitespace messages, it looks like my new branch
(solidfire_plugin2) does have the changes in the patch file (they show up
as modified, but not staged files or - in the case of new files - untracked
files).


On Mon, May 27, 2013 at 7:31 PM, John Burwell  wrote:

> Mike,
>
> What error are you getting from Review Board?  Have you rebased your
> branch to master recently?  Finally, are you submitting a squashed
> patch?
>
> Thanks,
> -John
>
> On May 27, 2013, at 9:27 PM, Mike Tutkowski
>  wrote:
>
> > Yeah, I certainly agree with you, John.
> >
> > Any thoughts on what I might do to make Review Board work in my
> situation?
> >
> > I am new to Review Board and don't know why my patch file won't upload,
> but
> > does apply to a new branch in my local repo.
> >
> > Thanks!
> >
> >
> > On Mon, May 27, 2013 at 7:24 PM, John Burwell 
> wrote:
> >
> >> Mike,
> >>
> >> I would encourage Review Board as the first preference.  

Re: Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11379/
---

(Updated May 28, 2013, 1:46 a.m.)


Review request for cloudstack, Devdeep Singh and Prachi Damle.


Changes
---

Updated Diff with Prachi's suggestion on List API changes.
For additional changes on adding 'isDedicated' flag to existing list APIs of 
host/cluster/pod/zone, and enhancing the APIs to get details about which 
account the resource is dedicated to,  I will create issues on Jira and track 
them separately. 


Description
---

Review Request for "Dedicated Resources: Explicit Dedication"
=

Functional Spec for the above Private zone, pod, cluster or host, can be found 
here: 
https://cwiki.apache.org/CLOUDSTACK/dedicated-resources-private-zone-pod-cluster-host-functional-spec.html
This patch request is a part of this feature.

This feature allows a user to deploy VMs only in the resources dedicated to his 
account or domain.

1. Resources(Zones, Pods, Clusters or hosts) can be dedicated to an account or 
domain.
   Implemented 12 new APIs to dedicate/list/release resources:
   - dedicateZone, listDedicatedZones, releaseDedicatedZone for a Zone.
   - dedicatePod, listDedicatedPods, releaseDedicatedPod for a Pod.
   - dedicateCluster, listDedicatedClusters, releaseDedicatedCluster for a 
Cluster
   - dedicateHost, listDedicatedHosts, releaseDedicatedHost for a Host.
2. Once a resource(eg. pod) is dedicated to an account, other resources(eg. 
clusters/hosts) inside that cannot be further dedicated.
3. Once a resource is dedicated to a domain, other resources inside that can be 
further dedicated to its sub-domain or account.
4. If any resource (eg.cluster) is dedicated to a account/domain, then 
resources(eg. Pod) above that cannot be dedicated to different accounts/domain 
(not belonging to the same domain) 
5. To use Explicit dedication, user needs to create an Affinity Group of type 
'ExplicitDedication'
6. A VM can be deployed with the above affinity group parameter as an input.
7. A new ExplicitDedicationProcessor has been added which will process the 
affinity group of type 'Explicit Dedication' for a deployment of a VM that 
demands dedicated resources.
   This processor implements the AffinityGroupProcessor adapter. This processor 
will update the avoid list.
8. A VM requesting dedication will be deployed on dedicatd resources if 
available with the user account.
9. A VM requesting dedication can also be deployed on the dedicated resources 
available with the parent domains iff no dedicated resources are available with 
the current user's account or 
   domain. 
10. A VM (without dedication) can be deployed on shared host but not on 
dedicated hosts.
11. To modify the dedication, the resource has to be released first.
12. Existing Private zone functionality has been redirected to Explicit 
dedication of zones.
13. Updated the db upgrade schema script. A new table "dedicated_resources" has 
been added.
14. Added the right permissions in commands.properties
15. Unit tests:  For the new APIs and Service, added unit tests under : 
plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java
16. Marvin Test: To dedicate host, create affinity group, deploy-vm, check if 
vm is deployed on the dedicated host.

Created 2 patches for the bug:
Patch 2 is for files that are modifying the files that have windows line 
endings. git am will not work for such files in a single patch.


This addresses bug CLOUDSTACK-681.


Diffs (updated)
-

  api/src/com/cloud/dc/DedicatedResources.java PRE-CREATION 
  api/src/com/cloud/event/EventTypes.java da96294 
  client/pom.xml 0c38ecb 
  client/tomcatconf/applicationContext.xml.in edf83a9 
  client/tomcatconf/commands.properties.in fd5479f 
  client/tomcatconf/componentContext.xml.in e946f44 
  
engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
 963e4d7 
  engine/schema/src/com/cloud/dc/dao/ClusterDao.java 3ce0798 
  engine/schema/src/com/cloud/dc/dao/ClusterDaoImpl.java 86dc65e 
  engine/schema/src/com/cloud/domain/dao/DomainDaoImpl.java 9460a73 
  engine/schema/src/com/cloud/host/dao/HostDao.java 98bdcb4 
  engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 07a4232 
  plugins/affinity-group-processors/explicit-dedication/pom.xml PRE-CREATION 
  
plugins/affinity-group-processors/explicit-dedication/src/org/apache/cloudstack/affinity/ExplicitDedicationProcessor.java
 PRE-CREATION 
  plugins/dedicated-resources/pom.xml PRE-CREATION 
  
plugins/dedicated-resources/src/org/apache/cloudstack/dedicated/api/commands/DedicateClusterCmd.java
 PRE-CREATION 
  
plugins/dedicated-resources/src/org/apache/cloudstack/dedicated/api/commands/DedicateHostCmd.java
 PRE-CREATION 
  
plugins/dedicated-resources/src/org/apache

Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11380/
---

(Updated May 28, 2013, 1:47 a.m.)


Review request for cloudstack, Devdeep Singh and Prachi Damle.


Description
---

Patch 2 for https://reviews.apache.org/r/11379/
Created for files 
server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java, 
server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, 
server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java


This addresses bug CLOUDSTACK-681.


Diffs (updated)
-

  server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 
  server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java e3b7d31 
  server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 484b044 

Diff: https://reviews.apache.org/r/11380/diff/


Testing
---

Unittest: For the new APIs and Service, added unit tests under : 
plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java
Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is 
deployed on the dedicated host.
Rat Build Successful.


Thanks,

Saksham Srivastava

[ACS41][PATCH REQ]

[Hiroaki KAWAI]

Chip, please cherry-pick to 4.1.
# This was my bug, sorry.

Branch: master

commit e9a6d47316d8de90eb662e9938ea7fcbe0ee0596
Author: Hiroaki KAWAI 
Date:   Tue May 28 11:55:21 2013 +0900

agent: fix network.bridge.type to be optional

New network.bridge.type was introduced, but for
buckward compatibility, the key should be optional.

Signed-off-by: Hiroaki KAWAI 

Re: [GSOC] Five projects accepted for 2013 Google Summer of Code

[Dharmesh Kakadia]

Thanks !! Looking forward to an exciting summer !! :)

Thanks,
Dharmesh


On Tue, May 28, 2013 at 1:02 AM, Kelcey Jamison Damage wrote:

> Awesome! I pasted this list in my 'important' folder, lol
>
> - Original Message -
> From: "Sebastien Goasguen" 
> To: dev@cloudstack.apache.org
> Sent: Monday, May 27, 2013 12:23:40 PM
> Subject: [GSOC] Five projects accepted for 2013 Google Summer of Code
>
> Hi,
>
> I am pleased to report that the following projects have been accepted by
> the 2013 Google Summer of Code:
>
> "CloudStack: LDAP user provisioning", Ian Duffy
>
> "Improving CloudStack support in Apache Whirr and Apache Provisionr
> incubating", Meng Han
>
> "Integration project to deploy and use Apache Mesos on a CloudStack based
> Cloud" Dharmesh Kakadia
>
> "A New Modular UI for Apache CloudStack" Shiva Teja Reddy
>
> "Add Xen/XCP support for GRE SDN Controller" Nguyen Anh Tu
>
> Join me in congratulating all five and welcoming them to the Apache
> CloudStack community this summer.
>
> Abhi, Kelcey, Hugo and Myself will be their mentors but if you see
> questions from any of these five students feel free to jump in and help
> them out.
>
> Happy coding,
>
> Cheers,
>
> -Sebastien
>

Re: LDAP auth broken?

[Abhinandan Prateek]

Check if the query filter is going to get the valid identifier for the
particular user. If that looks fine then can you tell us what LDAP server
you are using and also specifiy the query filter that you have configured.

-abhi

On 27/05/13 10:25 PM, "Francois Gaudreault" 
wrote:

>Hi,
>
>I am using 4.1 commit "8a9206fd28872dd436b22b847e93466f06e043bc", and I
>am getting this error when trying to authenticate using LDAP:
>
>java.lang.NullPointerException
> at 
>com.sun.jndi.ldap.LdapNamingEnumeration.getNextBatch(LdapNamingEnumeration
>.java:129)
> at 
>com.sun.jndi.ldap.LdapNamingEnumeration.nextAux(LdapNamingEnumeration.java
>:263)
> at 
>com.sun.jndi.ldap.LdapNamingEnumeration.nextImpl(LdapNamingEnumeration.jav
>a:254)
> at 
>com.sun.jndi.ldap.LdapNamingEnumeration.next(LdapNamingEnumeration.java:20
>2)
> at 
>com.cloud.server.auth.LDAPUserAuthenticator.authenticate(LDAPUserAuthentic
>ator.java:115)
> at 
>com.cloud.user.AccountManagerImpl.getUserAccount(AccountManagerImpl.java:1
>912)
> at 
>com.cloud.user.AccountManagerImpl.authenticateUser(AccountManagerImpl.java
>:1784)
> at com.cloud.api.ApiServer.loginUser(ApiServer.java:766)
> at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:210)
> at com.cloud.api.ApiServlet.doPost(ApiServlet.java:71)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
> at 
>org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Applicati
>onFilterChain.java:290)
> at 
>org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilter
>Chain.java:206)
> at 
>org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.
>java:233)
> at 
>org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.
>java:191)
> at 
>org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:1
>27)
> at 
>org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:1
>02)
> at 
>org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
> at 
>org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.ja
>va:109)
> at 
>org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298
>)
> at 
>org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.jav
>a:889)
> at 
>org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process
>(Http11NioProtocol.java:721)
> at 
>org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.jav
>a:2274)
> at 
>java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:
>1146)
> at 
>java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java
>:615)
> at java.lang.Thread.run(Thread.java:679)
>WARN  [server.auth.LDAPUserAuthenticator] (catalina-exec-21:) Unknown
>error encountered null
>
>Any ideas?
>
>I tested using ldapsearch and it works fine.
>
>-- 
>Francois Gaudreault
>Architecte de Solution Cloud | Cloud Solutions Architect
>fgaudrea...@cloudops.com
>514-629-6775
>- - -
>CloudOps
>420 rue Guy
>Montréal QC  H3J 1S6
>www.cloudops.com
>@CloudOps_
>

Re: [GSOC] Five projects accepted for 2013 Google Summer of Code

[Rohit Yadav]

On Tue, May 28, 2013 at 12:53 AM, Sebastien Goasguen wrote:

> Hi,
>
> I am pleased to report that the following projects have been accepted by
> the 2013 Google Summer of Code:
>
> "CloudStack: LDAP user provisioning", Ian Duffy
>
> "Improving CloudStack support in Apache Whirr and Apache Provisionr
> incubating", Meng Han
>
> "Integration project to deploy and use Apache Mesos on a CloudStack based
> Cloud" Dharmesh Kakadia
>
> "A New Modular UI for Apache CloudStack" Shiva Teja Reddy
>
> "Add Xen/XCP support for GRE SDN Controller" Nguyen Anh Tu
>
> Join me in congratulating all five and welcoming them to the Apache
> CloudStack community this summer.
>

Congrats everyone and welcome to the Apache CloudStack community once again.


> Abhi, Kelcey, Hugo and Myself will be their mentors but if you see
> questions from any of these five students feel free to jump in and help
> them out.
>

While these good folks may be officially your mentors, feel free to
reachout to the community anytime. Your mentors, admin will guide you well,
but one advise from my side is that you all develop your work in open from
the beginning, for example start by forking the github branches and share
your repos/branch on which you'll be working on with the community on
dev@email. If you've not yet already, start by getting the source
code,
building it and just play around and ask things you don't understand and in
case of any issues. The first few weeks as per GSoC is the bonding period,
so understand, research and explore your projects alongwith CloudStack,
bond with your mentor and community people; interact with us on IRC, ML,
attend weekly IRC meetings and local meetups if possible :) Good luck.

Cheers.


> Happy coding,
>
> Cheers,
>
> -Sebastien

Re: Review Request: CS-2273: Automation: Change account membership for VMs

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/
---

(Updated May 28, 2013, 5:29 a.m.)


Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and Girish 
Shilamkar.


Changes
---

Added few more tests related to limits, projects and snapshots


Description
---

Testcases for changing account membership for vas


This addresses bug CLOUDSTACK-2273.


Diffs (updated)
-

  test/integration/component/test_assign_vm.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py f3a96bd 

Diff: https://reviews.apache.org/r/11307/diff/


Testing
---


Thanks,

Ashutosh Kelkar

Re: Review Request: CS-2273: Automation: Change account membership for VMs

[Ashutosh Kelkar]

> On May 23, 2013, 6:14 a.m., Likitha Shetty wrote:
> > test/integration/component/test_assign_vm.py, line 321
> > 
> >
> > If a domain admin tries to move a VM to an account in a subdomain that 
> > belongs to a different domain, the request should fail. This is because a 
> > domain admin can only move VM's between 2 accounts that are in the domain 
> > path.
> > So shouldn't the check condition of test_08 be changed?

As per 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Change+account+membership+Test+Plan
 this test condition should pass the vm move.

Shall i change the TP and test check condition? 


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/#review20929
---


On May 28, 2013, 5:29 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11307/
> ---
> 
> (Updated May 28, 2013, 5:29 a.m.)
> 
> 
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and Girish 
> Shilamkar.
> 
> 
> Description
> ---
> 
> Testcases for changing account membership for vas
> 
> 
> This addresses bug CLOUDSTACK-2273.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_assign_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py f3a96bd 
> 
> Diff: https://reviews.apache.org/r/11307/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request: Marvin logger output showing repeated log lines.

[Ashutosh Kelkar]

> On May 23, 2013, 6:15 a.m., Prasanna Santhanam wrote:
> > Can you create a bug report for this? Otherwise the patch LGTM.

Created a bug report CLOUDSTACK-2703


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11340/#review20930
---


On May 23, 2013, 6:09 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11340/
> ---
> 
> (Updated May 23, 2013, 6:09 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> ---
> 
> In unit tests runs the same log output line is repeated for number tests in a 
> class, making log unreadable.
> This is because we are creating a logger by class name for each test load in 
> loadTestsFromFile()
> 
> with this fix now logger will log the test case and class name.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/TestCaseExecuteEngine.py 5743868 
> 
> Diff: https://reviews.apache.org/r/11340/diff/
> 
> 
> Testing
> ---
> 
> Testing Done.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request: Marvin logger output showing repeated log lines.

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11340/
---

(Updated May 28, 2013, 5:40 a.m.)


Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.


Description
---

In unit tests runs the same log output line is repeated for number tests in a 
class, making log unreadable.
This is because we are creating a logger by class name for each test load in 
loadTestsFromFile()

with this fix now logger will log the test case and class name.


This addresses bug CLOUDSTACK-2703.


Diffs
-

  tools/marvin/marvin/TestCaseExecuteEngine.py 5743868 

Diff: https://reviews.apache.org/r/11340/diff/


Testing
---

Testing Done.


Thanks,

Ashutosh Kelkar

Re: Review Request: Marvin logger output showing repeated log lines.

[Prasanna Santhanam]

> On May 23, 2013, 6:15 a.m., Prasanna Santhanam wrote:
> > Can you create a bug report for this? Otherwise the patch LGTM.
> 
> Ashutosh Kelkar wrote:
> Created a bug report CLOUDSTACK-2703

Thanks, this will correct the TestCase logger when running tests using python 
-m marvin.deployAndRun. The nose test runner however doesn't duplicate the log 
messages. 


- Prasanna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11340/#review20930
---


On May 28, 2013, 5:40 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11340/
> ---
> 
> (Updated May 28, 2013, 5:40 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> ---
> 
> In unit tests runs the same log output line is repeated for number tests in a 
> class, making log unreadable.
> This is because we are creating a logger by class name for each test load in 
> loadTestsFromFile()
> 
> with this fix now logger will log the test case and class name.
> 
> 
> This addresses bug CLOUDSTACK-2703.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/TestCaseExecuteEngine.py 5743868 
> 
> Diff: https://reviews.apache.org/r/11340/diff/
> 
> 
> Testing
> ---
> 
> Testing Done.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request: CS-2273: Automation: Change account membership for VMs

[Likitha Shetty]

> On May 23, 2013, 6:14 a.m., Likitha Shetty wrote:
> >

Ashutosh, are you referring to TP 8 in the Test-Plan? If yes, then the TP is 
still valid because in the TP the sub-domains (SubDomain1 and SubDomain2) that 
we are trying to move the VM’s between are under the same domain(Doamin1).
But from what I can see, in case of this test condition the 
sub-domains(subdomain1 and subdomain2) that we are trying to move the VM’s 
between are under two different domains. Is that right?

If we are trying to test TP 8 in this test then we can change line 155 from 
cls.sdomain_account_user2  = 
create_domain_account_user(cls.domain_account_user2['domain']) to 
cls.sdomain_account_user2  = 
create_domain_account_user(cls.domain_account_user1['domain']). With that 
change the test condition can pass the VM move.


- Likitha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/#review20929
---


On May 28, 2013, 5:29 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11307/
> ---
> 
> (Updated May 28, 2013, 5:29 a.m.)
> 
> 
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and Girish 
> Shilamkar.
> 
> 
> Description
> ---
> 
> Testcases for changing account membership for vas
> 
> 
> This addresses bug CLOUDSTACK-2273.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_assign_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py f3a96bd 
> 
> Diff: https://reviews.apache.org/r/11307/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: [jira] [Created] (CLOUDSTACK-2702) unable to install XenServer Support Package (CSP) on Xen cloud platform 1.6

[Prasanna Santhanam]

On Mon, May 27, 2013 at 07:18:19PM +, Dean Kamali (JIRA) wrote:
> Dean Kamali created CLOUDSTACK-2702:
> ---
> 
>  Summary: unable to install XenServer Support Package (CSP) on 
> Xen cloud platform 1.6
>  Key: CLOUDSTACK-2702
>  URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2702
>  Project: CloudStack
>   Issue Type: Bug
>   Security Level: Public (Anyone can view this level - this is the 
> default.)
>   Components: Xen
>  Environment: Xen Cloud Platform 1.6
> Reporter: Dean Kamali
> 
> 
> To enable security groups, elastic load balancing, and elastic IP on
> XenServer, We need to install CloudStack XenServer Support Package
> (CSP). After installing Xen cloud platform Server. 
> 
> I'm getting an error, when I try to install the package. 
> 
>  xe-install-supplemental-pack xenserver-cloud-supp.iso
> 
> Error repository is not compatible with the installed product
> (xenserver expected), Do you want to continue? (Y/N)? 
> 
> When I answer by Y
> 
> FATAL: missing dependency xs:main 
> 
> 

The Cloud Supplemental Pack (CSP) is not packaged for XCP AFAIK. The
CSP step is only supported/tested against a Citrix XenServer. Does
anyone know how to get SecurityGroups to work on an XCP and/or if this
is supported?

-- 
Prasanna.,


Powered by BigRock.com

Re: [GSOC] Five projects accepted for 2013 Google Summer of Code

[Nguyen Anh Tu]

Thanks! I'm ready for the beginning. Will try my best :-)

Sent from my GT-N7000
On 28 May 2013 02:24, "Sebastien Goasguen"  wrote:

> Hi,
>
> I am pleased to report that the following projects have been accepted by
> the 2013 Google Summer of Code:
>
> "CloudStack: LDAP user provisioning", Ian Duffy
>
> "Improving CloudStack support in Apache Whirr and Apache Provisionr
> incubating", Meng Han
>
> "Integration project to deploy and use Apache Mesos on a CloudStack based
> Cloud" Dharmesh Kakadia
>
> "A New Modular UI for Apache CloudStack" Shiva Teja Reddy
>
> "Add Xen/XCP support for GRE SDN Controller" Nguyen Anh Tu
>
> Join me in congratulating all five and welcoming them to the Apache
> CloudStack community this summer.
>
> Abhi, Kelcey, Hugo and Myself will be their mentors but if you see
> questions from any of these five students feel free to jump in and help
> them out.
>
> Happy coding,
>
> Cheers,
>
> -Sebastien

Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity Rules

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/
---

(Updated May 28, 2013, 6:28 a.m.)


Review request for cloudstack, Prachi Damle, Prasanna Santhanam, and sangeetha 
hariharan.


Changes
---

There is only one test in this patch. Is there an updated patch with the 
skipped tests completed?


Description
---

Add testcases for Affinity/Anti-Affinity Rules


This addresses bug CLOUDSTACK-2254.


Diffs
-

  test/integration/component/test_affinity_groups.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py ec1c34e 

Diff: https://reviews.apache.org/r/11067/diff/


Testing
---

The tests which are not skipped are working.


Thanks,

Girish Shilamkar

Re: Review Request: CLOUDSTACK-2648 [Multiple_IP_Ranges] Reboot or start/stop router vm deletes the ip alises created on VR in case of multiple subnets

[Koushik Das]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11437/#review21078
---



core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java


Please put a comment as to the need for this extra '-'. In case you are 
doing this to handle any boundary condition explain that as well.



patches/systemvm/debian/config/root/deleteIpAlias.sh


Plese review the condition. Do you need both checks?



server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java


dhco -> dhcp, also should be revoke



server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java


The message says apply, should be revoke.


- Koushik Das


On May 27, 2013, 3:23 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11437/
> ---
> 
> (Updated May 27, 2013, 3:23 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Description
> ---
> 
> [Multiple_IP_Ranges] Reboot or start/stop router vm deletes the ip alises 
> created on VR in case of multiple subnets
> https://issues.apache.org/jira/browse/CLOUDSTACK-2648
> 
> 
> This addresses bug Cloudstack-2648.
> 
> 
> Diffs
> -
> 
>   
> core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
> 8b996d1 
>   patches/systemvm/debian/config/root/deleteIpAlias.sh 865ff3b 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  630d1b4 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  4680fde 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> b969be2 
> 
> Diff: https://reviews.apache.org/r/11437/diff/
> 
> 
> Testing
> ---
> 
> tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>