Review Request: change memory size to 128mb for the tiny service offering

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11003/
---

Review request for cloudstack and Prasanna Santhanam.


Description
---

change memory size to 128mb  for the tiny service offering


This addresses bug CLOUDSTACK-2377.


Diffs
-

  test/integration/component/test_accounts.py fb38e62 
  test/integration/component/test_allocation_states.py fe4c35f 
  test/integration/component/test_blocker_bugs.py a6ea25a 
  test/integration/component/test_egress_rules.py 4af6eee 
  test/integration/component/test_eip_elb.py cb41859 
  test/integration/component/test_network_offering.py 00566a0 
  test/integration/component/test_project_configs.py fa2ee0a 
  test/integration/component/test_project_limits.py 4a8b9d4 
  test/integration/component/test_project_resources.py e79254c 
  test/integration/component/test_project_usage.py 44ef2f9 
  test/integration/component/test_projects.py 9fa6075 
  test/integration/component/test_resource_limits.py 418080a 
  test/integration/component/test_routers.py 96eb9aa 
  test/integration/component/test_security_groups.py fe2561a 
  test/integration/component/test_templates.py 3867fb4 
  test/integration/component/test_usage.py dbd0be9 
  test/integration/component/test_volumes.py f7eb9f9 
  test/integration/smoke/test_affinity_groups.py 6ccd478 

Diff: https://reviews.apache.org/r/11003/diff/


Testing
---

tested


Thanks,

SrikanteswaraRao Talluri

Re: [MERGE] Dedicate guest vlan ranges to account

[Prasanna Santhanam]

On Wed, May 08, 2013 at 06:10:11AM +, Likitha Shetty wrote:
> Prasanna, fixed the error.
> 
> About the API naming of commands related to guest vlan range dedication, the 
> API names were chosen to be consistent with the commands related to 
> dedication of other resources (Host, Pod, Cluster and Zone - 
> https://reviews.apache.org/r/10797/ ).
> In fact I was thinking of renaming the commands related to Public Ip Ranges 
> dedication to :
> dedicatePublicIpRange
> releaseDedicatedPublicIpRange
> 
> Since we are operating on a dedicated resource isn't it more fitting? 
> 

Changing the publicIpRange related APIs is okay. I'm fine with that.

-- 
Prasanna.,


Powered by BigRock.com

Re: Review Request: CLOUDSTACK-1820 - Automation: Need to add automation for AWS Style region feature

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10936/#review20296
---

Ship it!


Thanks these are good tests! I've removed the debug statements you put in print 
since those won't show in the default test run. I'll also break down these 
tests into three suites:

a) test_regions (tests basic creation - goes into the tests/integration/smoke 
so it can be part of the checkin tests)
b) test_regions (extended regions tests in tests/integration/component so it 
runs with our regression
c) test_regions_accounts (account CRUD operation in relation to regions)

commit 5ef2f1f26fcd159cb48b25882ea10cb3fc44d1b9
Author: Sangeetha Hariharan 
Date:   Fri May 3 17:02:32 2013 -0700

CLOUDSTACK-2329, CLOUDSTACK-1820: Tests for regions

Marvin tests and corresponding library changes for the regions feature.

Signed-off-by: Prasanna Santhanam 


- Prasanna Santhanam


On May 4, 2013, 4:13 a.m., sangeetha hariharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10936/
> ---
> 
> (Updated May 4, 2013, 4:13 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> ---
> 
> Added Test cases to test APIs relating to Regions feature.
> 
> 
> This addresses bug CLOUDSTACK-1820.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_regions.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py bebf2b5 
> 
> Diff: https://reviews.apache.org/r/10936/diff/
> 
> 
> Testing
> ---
> 
> Executed the scripts  against a CloudStack set up and made sure they executed 
> successfully.
> 
> 
> Thanks,
> 
> sangeetha hariharan
> 
>

Re: Review Request: fix regions related test script to conform with library changes relating to account object

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10941/#review20297
---

Ship it!


commit 5ef2f1f26fcd159cb48b25882ea10cb3fc44d1b9
Author: Sangeetha Hariharan 
Date:   Fri May 3 17:02:32 2013 -0700

CLOUDSTACK-2329, CLOUDSTACK-1820: Tests for regions

Marvin tests and corresponding library changes for the regions feature.

Signed-off-by: Prasanna Santhanam 


- Prasanna Santhanam


On May 4, 2013, 1:29 a.m., sangeetha hariharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10941/
> ---
> 
> (Updated May 4, 2013, 1:29 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> ---
> 
> Modify account.account.* to account.* 
> 
> 
> This addresses bug 2329.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_regions.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10941/diff/
> 
> 
> Testing
> ---
> 
> Able to execute test_regions.py . Earlier there were syntax errors.
> 
> 
> Thanks,
> 
> sangeetha hariharan
> 
>

Re: Review Request: CLOUDSTACK-1820 - Automation: Need to add automation for AWS Style region feature

[Prasanna Santhanam]

> On May 8, 2013, 8:23 a.m., Prasanna Santhanam wrote:
> > Thanks these are good tests! I've removed the debug statements you put in 
> > print since those won't show in the default test run. I'll also break down 
> > these tests into three suites:
> > 
> > a) test_regions (tests basic creation - goes into the 
> > tests/integration/smoke so it can be part of the checkin tests)
> > b) test_regions (extended regions tests in tests/integration/component so 
> > it runs with our regression
> > c) test_regions_accounts (account CRUD operation in relation to regions)
> > 
> > commit 5ef2f1f26fcd159cb48b25882ea10cb3fc44d1b9
> > Author: Sangeetha Hariharan 
> > Date:   Fri May 3 17:02:32 2013 -0700
> > 
> > CLOUDSTACK-2329, CLOUDSTACK-1820: Tests for regions
> > 
> > Marvin tests and corresponding library changes for the regions feature.
> > 
> > Signed-off-by: Prasanna Santhanam 
> >

All tests run perfectly now:
~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
--with-marvin --marvin-config=setup/dev/advanced.cfg 
test/integration/component/test_regions.py --load
Test for duplicate checks on region id ... ok
Test for duplicate checks on region name ... ok
Test for update Region ... ok

--
Ran 3 tests in 0.129s

OK

~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
--with-marvin --marvin-config=setup/dev/advanced.cfg 
test/integration/smoke/test_regions.py --load
Test for create region ... ok

--
Ran 1 test in 0.057s

OK

~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
--with-marvin --marvin-config=setup/dev/advanced.cfg 
test/integration/component/test_regions_accounts.py --load
Test for creating account by passing id parameter ... ok
Test for creating User by passing id parameter ... ok
Test for creating Domain by passing id parameter ... ok

--
Ran 3 tests in 10.346s

OK



- Prasanna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10936/#review20296
---


On May 4, 2013, 4:13 a.m., sangeetha hariharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10936/
> ---
> 
> (Updated May 4, 2013, 4:13 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> ---
> 
> Added Test cases to test APIs relating to Regions feature.
> 
> 
> This addresses bug CLOUDSTACK-1820.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_regions.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py bebf2b5 
> 
> Diff: https://reviews.apache.org/r/10936/diff/
> 
> 
> Testing
> ---
> 
> Executed the scripts  against a CloudStack set up and made sure they executed 
> successfully.
> 
> 
> Thanks,
> 
> sangeetha hariharan
> 
>

Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

[Sanjay Tripathi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/
---

Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh 
Chodapuneedi.


Description
---

CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with 
Alerts


This addresses bug CLOUDSTACK-1603.


Diffs
-

  
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
 f2cb1c4 

Diff: https://reviews.apache.org/r/11004/diff/


Testing
---

Tested on my local CloudStack setup.


Thanks,

Sanjay Tripathi

Review Request: (CLOUDSTACK-2318) update volumes.path to fix stop/start vm error after upgrade from 2.2.14 to 3.0.0

[Wei Zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11005/
---

Review request for cloudstack and Chip Childers.


Description
---

more details in 
http://markmail.org/message/h2qiuapd4jkxzhpo?q=KVM+Agent+problem
https://issues.apache.org/jira/browse/CLOUDSTACK-2318


This addresses bug CLOUDSTACK-2318.


Diffs
-

  setup/db/db/schema-2214to30.sql 60eceea 

Diff: https://reviews.apache.org/r/11005/diff/


Testing
---

Testing ok.


Thanks,

Wei Zhou

Re: Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/#review20299
---



engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java


Can you update the message too to be more informative? I don't think we 
need to surface the name of the internal command that has failed in the alert 
message.


- Devdeep Singh


On May 8, 2013, 8:44 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11004/
> ---
> 
> (Updated May 8, 2013, 8:44 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh 
> Chodapuneedi.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with 
> Alerts
> 
> 
> This addresses bug CLOUDSTACK-1603.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
>  f2cb1c4 
> 
> Diff: https://reviews.apache.org/r/11004/diff/
> 
> 
> Testing
> ---
> 
> Tested on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request: CLOUDSTACK-2189 volume is stuck in resizing state

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10947/#review20300
---

Ship it!


Ship It!

- Devdeep Singh


On May 6, 2013, 12:53 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10947/
> ---
> 
> (Updated May 6, 2013, 12:53 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and edison su.
> 
> 
> Description
> ---
> 
> After resize operation, the state of the volume is resizing only.
> The issue is, VolumeServiceImpl is calling the wrong call back for the resize 
> volume operation.
> Fixed the issue by calling the right callback which will change the state 
> transition from resizing to Ready.
> 
> 
> This addresses bug CLOUDSTACK-2189.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
>  b39502b 
> 
> Diff: https://reviews.apache.org/r/10947/diff/
> 
> 
> Testing
> ---
> 
> Unittests are success.
> Created a volume of 5 GB, verified the state in the db and in the kvm. 
> Resized the volume to 20GB, volume attached to the kvm instance had increased 
> to 20GB, resizevolume logs shows the volume is increased.
> DB is now having the state change from Resizing to Ready.
> 
> The testing output is pasted on the bug comment
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request: change memory size to 128mb for the tiny service offering

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11003/#review20302
---

Ship it!


commit b8358e109e737c454a351942c0f3d66f674febd7
Author: Srikanteswararao Talluri 
Date:   Wed May 8 12:23:15 2013 +0530

CLOUDSTACK-2377: change memory size to 128 mb for the tiny service offering 
in the integration tests

Signed-off-by: Prasanna Santhanam 


- Prasanna Santhanam


On May 8, 2013, 7:15 a.m., SrikanteswaraRao Talluri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11003/
> ---
> 
> (Updated May 8, 2013, 7:15 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> ---
> 
> change memory size to 128mb  for the tiny service offering
> 
> 
> This addresses bug CLOUDSTACK-2377.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_accounts.py fb38e62 
>   test/integration/component/test_allocation_states.py fe4c35f 
>   test/integration/component/test_blocker_bugs.py a6ea25a 
>   test/integration/component/test_egress_rules.py 4af6eee 
>   test/integration/component/test_eip_elb.py cb41859 
>   test/integration/component/test_network_offering.py 00566a0 
>   test/integration/component/test_project_configs.py fa2ee0a 
>   test/integration/component/test_project_limits.py 4a8b9d4 
>   test/integration/component/test_project_resources.py e79254c 
>   test/integration/component/test_project_usage.py 44ef2f9 
>   test/integration/component/test_projects.py 9fa6075 
>   test/integration/component/test_resource_limits.py 418080a 
>   test/integration/component/test_routers.py 96eb9aa 
>   test/integration/component/test_security_groups.py fe2561a 
>   test/integration/component/test_templates.py 3867fb4 
>   test/integration/component/test_usage.py dbd0be9 
>   test/integration/component/test_volumes.py f7eb9f9 
>   test/integration/smoke/test_affinity_groups.py 6ccd478 
> 
> Diff: https://reviews.apache.org/r/11003/diff/
> 
> 
> Testing
> ---
> 
> tested
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>

Re: Review Request: CLOUDSTACK-2189 volume is stuck in resizing state

[Devdeep Singh]

> On May 8, 2013, 8:56 a.m., Devdeep Singh wrote:
> > Ship It!

Can a committer merge these changes?


- Devdeep


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10947/#review20300
---


On May 6, 2013, 12:53 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10947/
> ---
> 
> (Updated May 6, 2013, 12:53 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and edison su.
> 
> 
> Description
> ---
> 
> After resize operation, the state of the volume is resizing only.
> The issue is, VolumeServiceImpl is calling the wrong call back for the resize 
> volume operation.
> Fixed the issue by calling the right callback which will change the state 
> transition from resizing to Ready.
> 
> 
> This addresses bug CLOUDSTACK-2189.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
>  b39502b 
> 
> Diff: https://reviews.apache.org/r/10947/diff/
> 
> 
> Testing
> ---
> 
> Unittests are success.
> Created a volume of 5 GB, verified the state in the db and in the kvm. 
> Resized the volume to 20GB, volume attached to the kvm instance had increased 
> to 20GB, resizevolume logs shows the volume is increased.
> DB is now having the state change from Resizing to Ready.
> 
> The testing output is pasted on the bug comment
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

[Sanjay Tripathi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/
---

(Updated May 8, 2013, 8:58 a.m.)


Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh 
Chodapuneedi.


Changes
---

Updated patch as per review comment.


Description
---

CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with 
Alerts


This addresses bug CLOUDSTACK-1603.


Diffs (updated)
-

  
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
 f2cb1c4 

Diff: https://reviews.apache.org/r/11004/diff/


Testing
---

Tested on my local CloudStack setup.


Thanks,

Sanjay Tripathi

Re: Review Request: fixing the scripts to conform with lib changes

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10981/#review20303
---

Ship it!


commit 1fe50a8d6778e37fd0784919538fdc7afccfb4c8
Author: Talluri 
Date:   Wed May 8 04:43:31 2013 +0530

CLOUDSTACK-2363: fixing the scripts to conform with lib changes

Signed-off-by: Prasanna Santhanam 


- Prasanna Santhanam


On May 7, 2013, 5:49 p.m., SrikanteswaraRao Talluri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10981/
> ---
> 
> (Updated May 7, 2013, 5:49 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> ---
> 
> fixing the scripts to conform with lib changes
> 
> 
> This addresses bug CLOUDSTACK-2363.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_project_configs.py fa2ee0a 
>   test/integration/component/test_project_limits.py 4a8b9d4 
>   test/integration/component/test_projects.py 9fa6075 
>   test/integration/smoke/test_network.py 322e8c2 
>   test/integration/smoke/test_templates.py fa4bc40 
> 
> Diff: https://reviews.apache.org/r/10981/diff/
> 
> 
> Testing
> ---
> 
> tested
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>

Re: Review Request: fix userdata integration test

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10976/#review20304
---

Ship it!


commit 731cc439a363fd3b17b1ed5eeca51f92f9e993cc
Author: Talluri 
Date:   Wed May 8 14:12:46 2013 +0530

CLOUDSTACK-2362: correct list append method

fix userdata integration test


- Prasanna Santhanam


On May 7, 2013, 4:06 p.m., SrikanteswaraRao Talluri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10976/
> ---
> 
> (Updated May 7, 2013, 4:06 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> ---
> 
> Clean up the VM created in each test in tearDown method otherwise test is 
> failing because it verifies the first VM in the list VM. 
> 
> 
> This addresses bug CLOUDSTACK-2362.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_deploy_vm_with_userdata.py fd9e320 
> 
> Diff: https://reviews.apache.org/r/10976/diff/
> 
> 
> Testing
> ---
> 
> Test userdata as GET, size > 2k ... ok
> Test userdata as POST, size > 2k ... ok
> 
> --
> XML: /tmp/r.xml
> --
> Ran 2 tests in 401.378s
> 
> OK
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>

Re: Review Request: fix storage xenmotion test script

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10975/#review20305
---

Ship it!


commit 8be304434e808660f17c5753abbf455a49ed7602
Author: Talluri 
Date:   Wed May 8 02:41:02 2013 +0530

CLOUDSTACK-2361: fix storage xenmotion test script

Signed-off-by: Prasanna Santhanam 


- Prasanna Santhanam


On May 7, 2013, 3:55 p.m., SrikanteswaraRao Talluri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10975/
> ---
> 
> (Updated May 7, 2013, 3:55 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> ---
> 
> fix storage xenmotion test script for the following:
> 1. getting network type in the setup
> 2. validating pool response in the test migrate volume. 
> 
> 
> This addresses bug CLOUDSTACK-2361.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_storage_motion.py 086ec77 
> 
> Diff: https://reviews.apache.org/r/10975/diff/
> 
> 
> Testing
> ---
> 
> tested
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>

Re: Review Request: fix missing network type in the test scripts test_volumes.py and test_templates.py

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10974/#review20306
---

Ship it!


commit 93db64fc2531d72713c6b26d9e749f9aa6fd6640
Author: Talluri 
Date:   Wed May 8 00:57:26 2013 +0530

CLOUDSTACK-2359: fix missing network type in the test scripts 
test_volumes.py and test_templates.py

Signed-off-by: Prasanna Santhanam 


- Prasanna Santhanam


On May 7, 2013, 2:03 p.m., SrikanteswaraRao Talluri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10974/
> ---
> 
> (Updated May 7, 2013, 2:03 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> ---
> 
> fix missing network type in the test scripts test_volumes.py and 
> test_templates.py 
> 
> 
> This addresses bug CLOUDSTACK-2359.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_templates.py fa4bc40 
>   test/integration/smoke/test_volumes.py ecac8c9 
> 
> Diff: https://reviews.apache.org/r/10974/diff/
> 
> 
> Testing
> ---
> 
> tested
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10948/#review20307
---


Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch refs/heads/master 
from Prasanna Santhanam 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 ]

CLOUDSTACK-702: Tests for Multiple IP Ranges-R4

Add ip range overlapped with two ip ranges in the exiting cidr

Signed-off-by: sanjeevneelarapu 
Signed-off-by: Prasanna Santhanam 


- ASF Subversion and Git Services


On May 6, 2013, 4:42 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10948/
> ---
> 
> (Updated May 6, 2013, 4:42 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Description
> ---
> 
> Cloudstack-702. Multiple ip ranges in different subnets. 
> 
> This feature enables adding of guest ip ranges (public ips)  form different 
> subnets.
> 
> In order to provide the dhcp service to a different subnet we create an 
> ipalias on the router. This allows the router to listen to the dhcp request 
> from the guest vms and respond accordingly. Every time a vm is deployed in 
> the new subnet we configure an ip alias on the router. Cloudstack uses 
> dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue 
> ips on the new subnets. Added a new class dnsmasqconfigurator which generates 
> the dnsmasq confg file, this file replaces the old config in the router. 
> 
> The details of the alias ips are stored in db in the nic_ip_alias table. 
> Every time a new subnet is added one of the ip from the subnet is used to 
> configure the ip alias. 
> 
> I have pushed the code to github 
> https://github.com/bvbharatk/cloud-stack/commit/052ebe7fc7dea5ece99cadc23b306c5f8d6e0ea9
>  , also rebased the code with master. 
> I need to test the code for advanced sg enabled network using kvm.
> 
> The code dose not include any unit tests as of now. will add them asap.
> 
> 
> This addresses bug Cloudstack-702.
> https://issues.apache.org/jira/browse/Cloudstack-702
> 
> 
> Diffs
> -
> 
> 
> Diff: https://reviews.apache.org/r/10948/diff/
> 
> 
> Testing
> ---
> 
> Tested this with xenserver in basic zone.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges support

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10946/#review20308
---


Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch refs/heads/master 
from Prasanna Santhanam 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 ]

CLOUDSTACK-702: Tests for Multiple IP Ranges-R4

Add ip range overlapped with two ip ranges in the exiting cidr

Signed-off-by: sanjeevneelarapu 
Signed-off-by: Prasanna Santhanam 


- ASF Subversion and Git Services


On May 6, 2013, 9:56 a.m., sanjeev n wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10946/
> ---
> 
> (Updated May 6, 2013, 9:56 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao 
> Talluri.
> 
> 
> Description
> ---
> 
> Tests for Multiple IP Ranges
> 1. Add ip range overlapped with two exiting ip ranges in the existing cidr
> 
> 
> This addresses bug CLOUDSTACK-702.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_multiple_ip_ranges.py 29942bd 
> 
> Diff: https://reviews.apache.org/r/10946/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>

Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/#review20309
---


Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch refs/heads/master 
from Prasanna Santhanam 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 ]

CLOUDSTACK-702: Tests for Multiple IP Ranges-R4

Add ip range overlapped with two ip ranges in the exiting cidr

Signed-off-by: sanjeevneelarapu 
Signed-off-by: Prasanna Santhanam 


- ASF Subversion and Git Services


On May 2, 2013, 12:04 p.m., sanjeev n wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10861/
> ---
> 
> (Updated May 2, 2013, 12:04 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao 
> Talluri.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-702: Tests for Multiple IP Ranges
> 
> 1. Deleting IP Range from the existing CIDR.
> 
> 
> This addresses bug CLOUDSTACK-702.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_multiple_ip_ranges.py 489e7ca 
> 
> Diff: https://reviews.apache.org/r/10861/diff/
> 
> 
> Testing
> ---
> 
> Tested with fixed IP addresses since code has not been implemented(To make 
> sure no syntax errors).
> 
> 
> Thanks,
> 
> sanjeev n
> 
>

Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges support

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10946/#review20310
---

Ship it!


commit 53e496517ed51bab2c81084a02f49b0408b19a37
Author: sanjeevneelarapu 
Date:   Mon May 6 20:38:54 2013 +0530

CLOUDSTACK-702: Tests for Multiple IP Ranges-R4

Add ip range overlapped with two ip ranges in the exiting cidr

Signed-off-by: sanjeevneelarapu 
Signed-off-by: Prasanna Santhanam 


- Prasanna Santhanam


On May 6, 2013, 9:56 a.m., sanjeev n wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10946/
> ---
> 
> (Updated May 6, 2013, 9:56 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao 
> Talluri.
> 
> 
> Description
> ---
> 
> Tests for Multiple IP Ranges
> 1. Add ip range overlapped with two exiting ip ranges in the existing cidr
> 
> 
> This addresses bug CLOUDSTACK-702.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_multiple_ip_ranges.py 29942bd 
> 
> Diff: https://reviews.apache.org/r/10946/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>

Review Request: Fix test_global_settings.py which is checking for the wrong global setting

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11006/
---

Review request for cloudstack and Prasanna Santhanam.


Description
---

1. test_global_settings.py is checking the wrong global setting while 
validating the updated config
2. Need to add tags - advanced, basic, devcloud etc., 


This addresses bug CLOUDSTACK-2382.


Diffs
-

  test/integration/smoke/test_global_settings.py a7cdb3e 

Diff: https://reviews.apache.org/r/11006/diff/


Testing
---

tested


Thanks,

SrikanteswaraRao Talluri

Re: Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

[Sanjay Tripathi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/
---

(Updated May 8, 2013, 9:35 a.m.)


Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh 
Chodapuneedi.


Changes
---

Updated patch.


Description
---

CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with 
Alerts


This addresses bug CLOUDSTACK-1603.


Diffs (updated)
-

  
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
 f2cb1c4 

Diff: https://reviews.apache.org/r/11004/diff/


Testing
---

Tested on my local CloudStack setup.


Thanks,

Sanjay Tripathi

Review request for Test Plan for Deploy virtual machine user data enhancements

[Shweta Agarwal]

I am taking up test execution for the feature : " Deploy virtual machine user 
data enhancements"
I've written some test cases for the same. Please review and let me know if any 
comments.
Here are Test cases: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+cases+for+DeployVirtualMachine+userdata+enhancements


Ref FS for the feature is here:  
https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements


Thanks
Shweta

Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
---

(Updated May 8, 2013, 11:09 a.m.)


Review request for cloudstack.


Changes
---

new diff file with some ommisions added


Description
---

converting vlan id to uri to support a broader range of networks in for 
instance vpc gateway connections


Diffs (updated)
-

  api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99 
  api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0 
  api/src/com/cloud/network/NetworkService.java 5d4fd67 
  api/src/com/cloud/network/Networks.java f085e9f 
  api/src/com/cloud/network/vpc/PrivateIp.java eb68433 
  api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4 
  api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 
  api/src/com/cloud/network/vpc/VpcService.java 23e2764 
  
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java
 2055695 
  api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java 
ca76062 
  api/test/com/cloud/agent/api/to/NetworkTOTest.java PRE-CREATION 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
b9bda4d 
  engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 
  
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java
 6d14e3f 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
 b897df2 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 8fe8c88 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 
37761aa 
  plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java 
a626e31 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 030eff0 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 bac361d 
  
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java
 a16733b 
  
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 
1733712 
  
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
 a0068c3 
  
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
 98e1461 
  
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java
 b1ecaac 
  server/src/com/cloud/api/ApiResponseHelper.java d7eaa26 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793 
  server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 4a90a77 
  server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 
686f5bc 
  server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java 
d405382 
  server/src/com/cloud/network/NetworkManager.java 4af716c 
  server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1 
  server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92 
  server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986 
  server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7 
  server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3 
  
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 
ebf2d42 
  server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db 
  server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9 
  server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8 
  server/test/com/cloud/vpc/MockNetworkManagerImpl.java f884ba1 
  server/test/com/cloud/vpc/MockVpcManagerImpl.java baccbd0 
  setup/db/db/schema-410to420.sql c8ac1ec 

Diff: https://reviews.apache.org/r/10970/diff/


Testing
---


Thanks,

daan Hoogland

[DISCUSS]Support for intel TXT technology

[Manasa Veloori (3P)]

http://comments.gmane.org/gmane.comp.apache.cloudstack.devel/8118

Hi All,


Just as a continuation on the discuss regarding the support of Intel TXT  for 
cloud stackI have few questions


1.  Suppose we have the xenserver6.0 host running the trust agent and it is 
registered with attestation server  and now if we want to  upgrade it to 
XenServer 6.1.how does attestation server handle this situation?

2.  Suppose I have a host which is not registered with attestation server 
and as a admin I have changed the tag of the host to 'Trusted-host'(default tag 
for trusted host).Now when I am trying to register the host how will the 
attestation server handle.

3.  If trust agent is not running in the host and we added that host to the 
registered zonewill it throw any exception.

4.  Do we have to explicitly register the host with attestation server 
prior to adding it to cloud stack or will it automatically gets registered when 
we add host to CloudStack.

5.  How CloudStack handles the situation when attestation server goes down 
i.e., CloudStack already have some trusted hosts and  now the user wants to 
deploy an instance in trusted host but the attestation server is down.

Thanks,
Manasa

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10948/#review20313
---


Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch 
refs/heads/marvin_refactor from Prasanna Santhanam 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 ]

CLOUDSTACK-702: Tests for Multiple IP Ranges-R4

Add ip range overlapped with two ip ranges in the exiting cidr

Signed-off-by: sanjeevneelarapu 
Signed-off-by: Prasanna Santhanam 


- ASF Subversion and Git Services


On May 6, 2013, 4:42 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10948/
> ---
> 
> (Updated May 6, 2013, 4:42 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Description
> ---
> 
> Cloudstack-702. Multiple ip ranges in different subnets. 
> 
> This feature enables adding of guest ip ranges (public ips)  form different 
> subnets.
> 
> In order to provide the dhcp service to a different subnet we create an 
> ipalias on the router. This allows the router to listen to the dhcp request 
> from the guest vms and respond accordingly. Every time a vm is deployed in 
> the new subnet we configure an ip alias on the router. Cloudstack uses 
> dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue 
> ips on the new subnets. Added a new class dnsmasqconfigurator which generates 
> the dnsmasq confg file, this file replaces the old config in the router. 
> 
> The details of the alias ips are stored in db in the nic_ip_alias table. 
> Every time a new subnet is added one of the ip from the subnet is used to 
> configure the ip alias. 
> 
> I have pushed the code to github 
> https://github.com/bvbharatk/cloud-stack/commit/052ebe7fc7dea5ece99cadc23b306c5f8d6e0ea9
>  , also rebased the code with master. 
> I need to test the code for advanced sg enabled network using kvm.
> 
> The code dose not include any unit tests as of now. will add them asap.
> 
> 
> This addresses bug Cloudstack-702.
> https://issues.apache.org/jira/browse/Cloudstack-702
> 
> 
> Diffs
> -
> 
> 
> Diff: https://reviews.apache.org/r/10948/diff/
> 
> 
> Testing
> ---
> 
> Tested this with xenserver in basic zone.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10861/#review20314
---


Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch 
refs/heads/marvin_refactor from Prasanna Santhanam 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 ]

CLOUDSTACK-702: Tests for Multiple IP Ranges-R4

Add ip range overlapped with two ip ranges in the exiting cidr

Signed-off-by: sanjeevneelarapu 
Signed-off-by: Prasanna Santhanam 


- ASF Subversion and Git Services


On May 2, 2013, 12:04 p.m., sanjeev n wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10861/
> ---
> 
> (Updated May 2, 2013, 12:04 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao 
> Talluri.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-702: Tests for Multiple IP Ranges
> 
> 1. Deleting IP Range from the existing CIDR.
> 
> 
> This addresses bug CLOUDSTACK-702.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_multiple_ip_ranges.py 489e7ca 
> 
> Diff: https://reviews.apache.org/r/10861/diff/
> 
> 
> Testing
> ---
> 
> Tested with fixed IP addresses since code has not been implemented(To make 
> sure no syntax errors).
> 
> 
> Thanks,
> 
> sanjeev n
> 
>

Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges support

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10946/#review20312
---


Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch 
refs/heads/marvin_refactor from Prasanna Santhanam 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 ]

CLOUDSTACK-702: Tests for Multiple IP Ranges-R4

Add ip range overlapped with two ip ranges in the exiting cidr

Signed-off-by: sanjeevneelarapu 
Signed-off-by: Prasanna Santhanam 


- ASF Subversion and Git Services


On May 6, 2013, 9:56 a.m., sanjeev n wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10946/
> ---
> 
> (Updated May 6, 2013, 9:56 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao 
> Talluri.
> 
> 
> Description
> ---
> 
> Tests for Multiple IP Ranges
> 1. Add ip range overlapped with two exiting ip ranges in the existing cidr
> 
> 
> This addresses bug CLOUDSTACK-702.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_multiple_ip_ranges.py 29942bd 
> 
> Diff: https://reviews.apache.org/r/10946/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>

Re: Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/#review20315
---

Ship it!


Ship It!

- Devdeep Singh


On May 8, 2013, 9:35 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11004/
> ---
> 
> (Updated May 8, 2013, 9:35 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh 
> Chodapuneedi.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with 
> Alerts
> 
> 
> This addresses bug CLOUDSTACK-1603.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
>  f2cb1c4 
> 
> Diff: https://reviews.apache.org/r/11004/diff/
> 
> 
> Testing
> ---
> 
> Tested on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Suggestion needed for CLOUDSTACK-212

[Chip Childers]

Dharmesh,

I'd also suggest that you actually plan on submitting this after the 4.2
feature freeze, to be included in 4.3.  This is the type of change that
has bitten us with almost every release...  and doing it close to the
end of the merge window may not be a good idea.  Our general preference
is to do these types of changes in master right *after* the latest
feature release has it's branch cut.

-chip

On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
> ok. I will go with that.
> 
> Thanks,
> Dharmesh
> 
> On Wed, May 8, 2013 at 1:08 AM, Chip Childers 
> wrote:
> 
> > On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> > > Hi,
> > >
> > > I am trying to move java package structure from com.cloud to org.apache (
> > > https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am thinking of
> > > doing it the following way (Totally newbie), needed feedback on that.
> > >
> > > 1. grep "com.cloud" on the entire repo.
> > > 2. update all package declarations using eclipse.
> > > 3. Update scripts etc found in 1 manually.
> > >
> > > Will it be a good way to do it ? Any better suggestion ?
> > >
> > > Thanks,
> > > Dharmesh
> >
> > That seems like a reasonable approach.  We will probably want to create
> > a branch when you submit a patch for this, and apply it there...  just
> > to spend some time ensuring that the changes work.
> >
> > -chip
> >

Re: [DOCS] OpenHelp writers conference in June: Is CS going?

[Joe Brockmeier]

On Tue, May 7, 2013, at 09:19 PM, Radhika Puthiyetath wrote:
> I thought JZB is planning to attend..

I was interested in attending, but it's the week before the CloudStack
Collaboration Conference, and the weekend after SELF, which is the
weekend after Texas LinuxFest. 

I did talk to one of the conference organizers a while back about
attracting more doc contributors - and his response was essentially that
we're welcoming enough and have sane contribution policies, but it's a
matter of building enough critical mass of people who understand the
project and wish to actually do docs... 

Best,

jzb
-- 
Joe Brockmeier
j...@zonker.net
Twitter: @jzb
http://www.dissociatedpress.net/

Re: Review Request: CLOUDSTACK-869-nTier-Apps-2.0_Support-NetScalar-as-external-LB-provider

[Rajesh Battala]

> On May 6, 2013, 3:36 p.m., Murali Reddy wrote:
> > plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java,
> >  line 967
> > 
> >
> > implement and shutdown need to be implemented? how would VLAN be 
> > configured on NetScaler with out implementing network?

When a tier network (where LB is Netscaler)  is implemented, In Netscaler 
Element (implement and shutdown) methods will call which will take care of 
Netscaler in that tier network. (It works like implementing a guest network [ 
here it’s a guest network with vpc id and had cidr taken from the super cidr]) 


> On May 6, 2013, 3:36 p.m., Murali Reddy wrote:
> > plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java,
> >  line 980
> > 
> >
> > remove the TODO's, if there is no  need for method implementation and 
> > just return true

will remove them


> On May 6, 2013, 3:36 p.m., Murali Reddy wrote:
> > server/src/com/cloud/network/NetworkServiceImpl.java, line 1056
> > 
> >
> > same should hold for other external devices as well. so please put 
> > generic comment (with out netscaler)

will make the comment to be generic


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10858/#review20191
---


On April 30, 2013, 3:28 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10858/
> ---
> 
> (Updated April 30, 2013, 3:28 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala, Murali Reddy, Alena 
> Prokharchyk, Vijay Venkatachalam, and Ram Ganesh.
> 
> 
> Description
> ---
> 
> This feature will introduce Netscaler as external LB provider in VPC.
> As of now only 1 tier is support for external LB.
> A new VPC offering will be created "Default VPC Offering with NS" with all 
> the services provided by VPCVR and LB service with NetScaler.
> Existing NetscalerElement is used and implements VpcProvider.
> In VpcManager, Netscaler is added as one of the supported providers.
> Netscaler will be dedicated to the vpc.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/vpc/VpcOffering.java 3961d0a 
>   
> plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
>  2bbdb04 
>   server/src/com/cloud/network/NetworkServiceImpl.java 2dcb47d 
>   server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java b1606db 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
>   server/test/com/cloud/vpc/ChildTestConfiguration.java PRE-CREATION 
>   server/test/com/cloud/vpc/VpcManagerTest.java PRE-CREATION 
>   
> server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java
>  cbb6c00 
>   server/test/resources/VpcContext.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10858/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> ==
> 1. Creation of Vpc with the default offering with NS is created successfully. 
> ( Enable Netscaler provider in network service providers)
> 2. Deletion of Vpc with the default offering with NS is deleted successfully.
> 3. Creation of new Vpc Network Offering with Netscaler as LB provider with 
> dedicated mode is created successfully.
> 4. Creation of new Vpc Network Offering with Netscaler as LB provider with 
> shared mode should throw exception.
> 5. Creation of tier (webtier) with the created Vpcnetscaler offering is 
> created successfully.
> 6. Verified Only one tier with netscaler as LB provider can be created. 
> 7. Verified deploying Instance in the tier is successful.
> 8. Verified a new nic got created with gateway ip from the tier cidr.
> 9. Verified deployed instance should get the ip from the specified tier cidr 
> range.
> 10. Acquire public ip in the vpc.
> 11. Verified creation on LB rule, is selecting only free dedicated Netscaler 
> device and necessary configuration is created and LB rule is created on NS
> 12. Deletion of LB rule is successful.
> 13. Modification of LB rule is successful
> 14. Creation of LB Health Check of TCP type is successful.
> 15. Deletion of LB Health Check of TCP type is successful.
> 16. Creation of LB Health Check of HTTP type is successful.
> 17. Deletion of LB Health Check of HTTP type is successful.
> 18. IpAssoc command is executed successful on Netscaler.
> 19. Deletion of tier will delete the tier and config on netscaler is cleared
> 20. Deletion of tier will mark the netscaler to be in free mode.
> 
> 
> Unit Test:
> ===
> Created Vpc

Re: Review Request: CLOUDSTACK-869-nTier-Apps-2.0_Support-NetScalar-as-external-LB-provider

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10858/
---

(Updated May 8, 2013, 1:38 p.m.)


Review request for cloudstack, Kishan Kavala, Murali Reddy, Alena Prokharchyk, 
Vijay Venkatachalam, and Ram Ganesh.


Changes
---

Incorporated the changes from the review comments.
All Unit tests are passing and rat is successful.


Description
---

This feature will introduce Netscaler as external LB provider in VPC.
As of now only 1 tier is support for external LB.
A new VPC offering will be created "Default VPC Offering with NS" with all the 
services provided by VPCVR and LB service with NetScaler.
Existing NetscalerElement is used and implements VpcProvider.
In VpcManager, Netscaler is added as one of the supported providers.
Netscaler will be dedicated to the vpc.


Diffs (updated)
-

  api/src/com/cloud/network/vpc/VpcOffering.java 3961d0a 
  
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
 7bd9c2e 
  server/pom.xml 808dd3e 
  server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92 
  server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java b1606db 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9 
  server/test/com/cloud/vpc/VpcTest.java PRE-CREATION 
  
server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java
 cbb6c00 

Diff: https://reviews.apache.org/r/10858/diff/


Testing
---

Manual Testing:
==
1. Creation of Vpc with the default offering with NS is created successfully. ( 
Enable Netscaler provider in network service providers)
2. Deletion of Vpc with the default offering with NS is deleted successfully.
3. Creation of new Vpc Network Offering with Netscaler as LB provider with 
dedicated mode is created successfully.
4. Creation of new Vpc Network Offering with Netscaler as LB provider with 
shared mode should throw exception.
5. Creation of tier (webtier) with the created Vpcnetscaler offering is created 
successfully.
6. Verified Only one tier with netscaler as LB provider can be created. 
7. Verified deploying Instance in the tier is successful.
8. Verified a new nic got created with gateway ip from the tier cidr.
9. Verified deployed instance should get the ip from the specified tier cidr 
range.
10. Acquire public ip in the vpc.
11. Verified creation on LB rule, is selecting only free dedicated Netscaler 
device and necessary configuration is created and LB rule is created on NS
12. Deletion of LB rule is successful.
13. Modification of LB rule is successful
14. Creation of LB Health Check of TCP type is successful.
15. Deletion of LB Health Check of TCP type is successful.
16. Creation of LB Health Check of HTTP type is successful.
17. Deletion of LB Health Check of HTTP type is successful.
18. IpAssoc command is executed successful on Netscaler.
19. Deletion of tier will delete the tier and config on netscaler is cleared
20. Deletion of tier will mark the netscaler to be in free mode.


Unit Test:
===
Created VpcManger tests and added few tests to createNetworkOfferingTest


Thanks,

Rajesh Battala

Re: Review Request: CLOUDSTACK-869-nTier-Apps-2.0_Support-NetScalar-as-external-LB-provider

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10858/
---

(Updated May 8, 2013, 1:39 p.m.)


Review request for cloudstack, Kishan Kavala, Murali Reddy, Alena Prokharchyk, 
Vijay Venkatachalam, and Ram Ganesh.


Description
---

This feature will introduce Netscaler as external LB provider in VPC.
As of now only 1 tier is support for external LB.
A new VPC offering will be created "Default VPC Offering with NS" with all the 
services provided by VPCVR and LB service with NetScaler.
Existing NetscalerElement is used and implements VpcProvider.
In VpcManager, Netscaler is added as one of the supported providers.
Netscaler will be dedicated to the vpc.


Diffs
-

  api/src/com/cloud/network/vpc/VpcOffering.java 3961d0a 
  
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
 7bd9c2e 
  server/pom.xml 808dd3e 
  server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92 
  server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java b1606db 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9 
  server/test/com/cloud/vpc/VpcTest.java PRE-CREATION 
  
server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java
 cbb6c00 

Diff: https://reviews.apache.org/r/10858/diff/


Testing
---

Manual Testing:
==
1. Creation of Vpc with the default offering with NS is created successfully. ( 
Enable Netscaler provider in network service providers)
2. Deletion of Vpc with the default offering with NS is deleted successfully.
3. Creation of new Vpc Network Offering with Netscaler as LB provider with 
dedicated mode is created successfully.
4. Creation of new Vpc Network Offering with Netscaler as LB provider with 
shared mode should throw exception.
5. Creation of tier (webtier) with the created Vpcnetscaler offering is created 
successfully.
6. Verified Only one tier with netscaler as LB provider can be created. 
7. Verified deploying Instance in the tier is successful.
8. Verified a new nic got created with gateway ip from the tier cidr.
9. Verified deployed instance should get the ip from the specified tier cidr 
range.
10. Acquire public ip in the vpc.
11. Verified creation on LB rule, is selecting only free dedicated Netscaler 
device and necessary configuration is created and LB rule is created on NS
12. Deletion of LB rule is successful.
13. Modification of LB rule is successful
14. Creation of LB Health Check of TCP type is successful.
15. Deletion of LB Health Check of TCP type is successful.
16. Creation of LB Health Check of HTTP type is successful.
17. Deletion of LB Health Check of HTTP type is successful.
18. IpAssoc command is executed successful on Netscaler.
19. Deletion of tier will delete the tier and config on netscaler is cleared
20. Deletion of tier will mark the netscaler to be in free mode.


Unit Test:
===
Created VpcManger tests and added few tests to createNetworkOfferingTest


Thanks,

Rajesh Battala

Re: Suggestion needed for CLOUDSTACK-212

[Sebastien Goasguen]

On May 8, 2013, at 9:30 AM, Chip Childers  wrote:

> Dharmesh,
> 
> I'd also suggest that you actually plan on submitting this after the 4.2
> feature freeze, to be included in 4.3.  This is the type of change that
> has bitten us with almost every release...  and doing it close to the
> end of the merge window may not be a good idea.  Our general preference
> is to do these types of changes in master right *after* the latest
> feature release has it's branch cut.
> 
> -chip

To add to that, feature freeze for 4.2 is scheduled to be 5/31.

We could have your code in a feature branch before that, and merge it early 
june. It would then be included in 4.3



> 
> On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
>> ok. I will go with that.
>> 
>> Thanks,
>> Dharmesh
>> 
>> On Wed, May 8, 2013 at 1:08 AM, Chip Childers 
>> wrote:
>> 
>>> On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
 Hi,
 
 I am trying to move java package structure from com.cloud to org.apache (
 https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am thinking of
 doing it the following way (Totally newbie), needed feedback on that.
 
 1. grep "com.cloud" on the entire repo.
 2. update all package declarations using eclipse.
 3. Update scripts etc found in 1 manually.
 
 Will it be a good way to do it ? Any better suggestion ?
 
 Thanks,
 Dharmesh
>>> 
>>> That seems like a reasonable approach.  We will probably want to create
>>> a branch when you submit a patch for this, and apply it there...  just
>>> to spend some time ensuring that the changes work.
>>> 
>>> -chip
>>> 

Re: [ACS41] Outstanding bugs... help resolving still needed

[Chip Childers]

On Tue, May 07, 2013 at 03:00:42PM -0700, Kelven Yang wrote:
> CLOUDSTACK-2218 is an environment/setup issue to me. I've changed the bug
> status unless otherwise proven to be real issue

Thanks for checking into it.  I couldn't reproduce it myself, but the
reporter was claiming that it was due to one of a set of commits they
referenced...  so I was unsure if I was the one with the dirty
environment.

-chip

Re: Suggestion needed for CLOUDSTACK-212

[Dharmesh Kakadia]

I have started refactoring !! I am planning to finish refactoring by
tomorrow. I will then need help and guidance in doing testing,branching
etc. Let's try this out !!

Thanks,
Dharmesh


On Wed, May 8, 2013 at 7:20 PM, Sebastien Goasguen  wrote:

>
> On May 8, 2013, at 9:30 AM, Chip Childers 
> wrote:
>
> > Dharmesh,
> >
> > I'd also suggest that you actually plan on submitting this after the 4.2
> > feature freeze, to be included in 4.3.  This is the type of change that
> > has bitten us with almost every release...  and doing it close to the
> > end of the merge window may not be a good idea.  Our general preference
> > is to do these types of changes in master right *after* the latest
> > feature release has it's branch cut.
> >
> > -chip
>
> To add to that, feature freeze for 4.2 is scheduled to be 5/31.
>
> We could have your code in a feature branch before that, and merge it
> early june. It would then be included in 4.3
>
>
>
> >
> > On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
> >> ok. I will go with that.
> >>
> >> Thanks,
> >> Dharmesh
> >>
> >> On Wed, May 8, 2013 at 1:08 AM, Chip Childers <
> chip.child...@sungard.com>wrote:
> >>
> >>> On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
>  Hi,
> 
>  I am trying to move java package structure from com.cloud to
> org.apache (
>  https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am thinking
> of
>  doing it the following way (Totally newbie), needed feedback on that.
> 
>  1. grep "com.cloud" on the entire repo.
>  2. update all package declarations using eclipse.
>  3. Update scripts etc found in 1 manually.
> 
>  Will it be a good way to do it ? Any better suggestion ?
> 
>  Thanks,
>  Dharmesh
> >>>
> >>> That seems like a reasonable approach.  We will probably want to create
> >>> a branch when you submit a patch for this, and apply it there...  just
> >>> to spend some time ensuring that the changes work.
> >>>
> >>> -chip
> >>>
>
>

External Network Usage

[Will Stevens]

Hey All,
In my Palo Alto Firewall integration, I have not yet implemented usage
tracking.

I am getting messages in the console as follows:
(ExternalNetworkMonitor-1:) Didn't get an external network usage answer for
guest VLAN 3037

I believe this is implemented through the
'ExternalNetworkResourceUsageCommand'.  I have a basic stub in place for
this, but I am just returning a new 'ExternalNetworkResourceUsageAnswer'.

I have not been able to find any documentation on now the
ExternalNetworkMonitor works.  Is there any docs on how to integrate with
this somewhere?  If not, is it possible for someone can give me a basic
idea of how this is expected to function? What type of data should I be
adding to this?

Thanks,

Will

Re: Review Request: (CLOUDSTACK-2318) update volumes.path to fix stop/start vm error after upgrade from 2.2.14 to 3.0.0

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11005/#review20320
---


Commit e85c0a965a18908343a6b7206a36abe201db12a8 in branch refs/heads/4.1 from 
Chip Childers 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e85c0a9 ]

CLOUDSTACK-2318: update volumes.path to fix stop/start vm error after
upgrade from 2.2.14 to 3.0.0

Signed-off-by: Chip Childers 


- ASF Subversion and Git Services


On May 8, 2013, 8:45 a.m., Wei Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11005/
> ---
> 
> (Updated May 8, 2013, 8:45 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> more details in 
> http://markmail.org/message/h2qiuapd4jkxzhpo?q=KVM+Agent+problem
> https://issues.apache.org/jira/browse/CLOUDSTACK-2318
> 
> 
> This addresses bug CLOUDSTACK-2318.
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-2214to30.sql 60eceea 
> 
> Diff: https://reviews.apache.org/r/11005/diff/
> 
> 
> Testing
> ---
> 
> Testing ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-2318) update volumes.path to fix stop/start vm error after upgrade from 2.2.14 to 3.0.0

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11005/#review20321
---


Commit 99d0936314571e645f62e40bf4d227232be89632 in branch refs/heads/master 
from Chip Childers 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=99d0936 ]

CLOUDSTACK-2318: update volumes.path to fix stop/start vm error after
upgrade from 2.2.14 to 3.0.0

Signed-off-by: Chip Childers 


- ASF Subversion and Git Services


On May 8, 2013, 8:45 a.m., Wei Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11005/
> ---
> 
> (Updated May 8, 2013, 8:45 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> more details in 
> http://markmail.org/message/h2qiuapd4jkxzhpo?q=KVM+Agent+problem
> https://issues.apache.org/jira/browse/CLOUDSTACK-2318
> 
> 
> This addresses bug CLOUDSTACK-2318.
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-2214to30.sql 60eceea 
> 
> Diff: https://reviews.apache.org/r/11005/diff/
> 
> 
> Testing
> ---
> 
> Testing ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-2318) update volumes.path to fix stop/start vm error after upgrade from 2.2.14 to 3.0.0

[Chip Childers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11005/#review20322
---

Ship it!


Ship It!

- Chip Childers


On May 8, 2013, 8:45 a.m., Wei Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11005/
> ---
> 
> (Updated May 8, 2013, 8:45 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> more details in 
> http://markmail.org/message/h2qiuapd4jkxzhpo?q=KVM+Agent+problem
> https://issues.apache.org/jira/browse/CLOUDSTACK-2318
> 
> 
> This addresses bug CLOUDSTACK-2318.
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-2214to30.sql 60eceea 
> 
> Diff: https://reviews.apache.org/r/11005/diff/
> 
> 
> Testing
> ---
> 
> Testing ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

RE: Review request for Test Plan for Deploy virtual machine user data enhancements

[Sangeetha Hariharan]

Shweta,

I have 1 suggestion after going over the test plans. As part of validations for 
your test cases could you also include the check to make sure that we are able 
to fetch the user data successfully from within the user Vms.

Thanks
Sangeetha
-Original Message-
From: Shweta Agarwal [mailto:shweta.agar...@citrix.com] 
Sent: Wednesday, May 08, 2013 3:35 AM
To: dev@cloudstack.apache.org
Subject: Review request for Test Plan for Deploy virtual machine user data 
enhancements

I am taking up test execution for the feature : " Deploy virtual machine user 
data enhancements"
I've written some test cases for the same. Please review and let me know if any 
comments.
Here are Test cases: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+cases+for+DeployVirtualMachine+userdata+enhancements


Ref FS for the feature is here:  
https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements


Thanks
Shweta

Re: network guru refactor proposal

[Chiradeep Vittal]

See for example the extensive documentation for 4.2
https://cwiki.apache.org/confluence/x/dzXVAQ

The PVLAN one is a good one
https://cwiki.apache.org/confluence/x/c17VAQ


On 5/7/13 1:25 PM, "Daan Hoogland"  wrote:

>On 2013/5/7 19:18 , Chiradeep Vittal wrote:
>> For a major change, I'd expect a functional specification. It is still
>>not
>> clear to me what is "nicira hosted private gateways". I can guess, but
>> without a concrete document, it is hard to see where you are going with
>> this.
>There is a jira ticket for it. Is this what you mean? Or do you want a
>word-up with pre- and post conditions? The functional change is not
>really big in comparison with the code change so a document seems
>overkill to me but I am biased, so open to suggestions.
>
>in short: the user question is to be able to hook the newly to be
>created vpc private gateway to an existing external network, in this
>case a logical switch in nicira.
>
>regards,
>>
>> On 5/7/13 6:30 AM, "Daan Hoogland"  wrote:
>>
>>> The main objective is to have a nicira based private network guru to
>>>use
>>> for vpsgateways. I want to abstract common code with the 'generic' vlan
>>> based private network but also abstract out commonalities that might be
>>> shared with the guest networks.  canHandle could be generalized and
>>> called by all classes, though it has another footprint now in the guest
>>> networks then it has in PrivateNetworkGuru.
>>>
>>> Alternatively I will copy code from NiciraNvpGuestNetworkGuru and
>>> PrivateNetworkGuru to a new class and later refactor it, which is not
>>>my
>>> favorite way to go.
>>>
>>> I must admit that including network gurus that do not support any
>>> extensions in the hierarchy is an esthetic touch if no code is shared.
>>>I
>>> will refrain if maintainability issues can be expected.
>>>
>>> Regards,
>>>
>>> -Original Message-
>>> From: Murali Reddy [mailto:murali.re...@citrix.com]
>>> Sent: dinsdag 7 mei 2013 15:17
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: network guru refactor proposal
>>>
>>> On 07/05/13 5:23 PM, "Daan Hoogland" 
>>>wrote:
>>>
 LS,

 I want to refactor the network guru hierarchy to put som functionality
 in abstract base classes. This will come down to extending the
 hierarchy for guest networks to include all gurus. Are there any
 thoughts or gotchas to share?
>>> GuestNetworkGuru in some sense already acting as abstract base class,
>>> except for the fact that it is tied to 'Vlan' isolation. We can
>>> generalise the 'GuestNetworkGuru' and let the isolation type specific
>>> network design aspects to concrete classes. Other gurus (direct, pod
>>> based) for guest networks does not have any extensions at this point
>>>and
>>> does not overlap much with GuestNetworkGuru, so they may remain as is.
>>> Are there any specify observations that you think refactor will
>>>address?
>>>
 This would be the second part of a three stage strategy I have to
 support creating a nicira hosted private gateway for vpcs.
 The first one is making sure vlans are specified as uri throughout the
 system. I will be submitting a patch for review for this part soon.
 The last part will be creating a guru based on Hugo's
 NiciraNvpGuestNetworkGuru.

 Any comment is appreciated,
 Daan Hoogland

>>>

[ACS41] Release Blocker Update for 2013-05-08

[Chip Childers]

Here's where we stand:

CLOUDSTACK-2309
  Upgrade from 2.2.14 to 4.1.0 : network static routes deleted on SSVM

  Kishan - any update on 2309?  Also note that Wei suggested a fix to the
  reporter for 528.  However, you said you thought 2309 and 528 could be
  related.  Can you review the suggestion?

CLOUDSTACK-528
  Failed to create secondary storage

  Wei offered a suggested correction to the DB for this bug.  Hopefully
  we will get a response from Guillaume or Nicolas that it worked, and
  we can implement the fix in the upgrade script.

CLOUDSTACK-1907
  Can't create system VM on XCP1.6 hypervisor

  There is a suggested fix in the comments of this bug.  Can someone
  familiar with this portion of the code *please* review and comment?

-chip

Re: Dispatcher

[Kelven Yang]

API job dispatch and internal job execution are managed through Async Job
facility inside CloudStack. You can look at
ApiServer.java/ApiDispather.java/AsyncJobManagerImpl.java in source code
to get more details.

I'm currently working on improving VM state sync, HA and job management as
a whole as an enhancement feature, the work includes job scheduling, job
serialization, job monitoring, job concurrency control and a message bus
for job event notification, I will write down more details once I've got
time and notify the community accordingly

Kelven  

On 5/7/13 8:26 AM, "Faisal Azizullah"  wrote:

>Hi,
>
>Can some one point me to the documentation/source code of Dispatcher in
>cloud stack .
>
>Thanks,
>
>Faisal 

Re: Review Request: (CLOUDSTACK-2318) update volumes.path to fix stop/start vm error after upgrade from 2.2.14 to 3.0.0

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11005/#review20329
---


Commit 99d0936314571e645f62e40bf4d227232be89632 in branch 
refs/heads/ui-cisco-asa1000v-support from Chip Childers 

[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=99d0936 ]

CLOUDSTACK-2318: update volumes.path to fix stop/start vm error after
upgrade from 2.2.14 to 3.0.0

Signed-off-by: Chip Childers 


- ASF Subversion and Git Services


On May 8, 2013, 8:45 a.m., Wei Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11005/
> ---
> 
> (Updated May 8, 2013, 8:45 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> more details in 
> http://markmail.org/message/h2qiuapd4jkxzhpo?q=KVM+Agent+problem
> https://issues.apache.org/jira/browse/CLOUDSTACK-2318
> 
> 
> This addresses bug CLOUDSTACK-2318.
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-2214to30.sql 60eceea 
> 
> Diff: https://reviews.apache.org/r/11005/diff/
> 
> 
> Testing
> ---
> 
> Testing ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Upgrade issue 4.0.2

[Ahmad Emneina]

Looping in dev;

Hey guys, are there any documented workarounds for the 4.0-4.02 upgrade
issues people are facing?


On Wed, May 8, 2013 at 11:10 AM, John Skinner wrote:

> I had this same issue when I attempted to upgrade my production
> environment from 3.0.2 to 4.0.2. I could not get the XenServer hosts to
> connect back, so I had to end up rolling back to 3.0.2. I haven't been able
> to get around it.
>
> John Skinner
>
> --
> The information in this message is intended for the named recipients only.
> It may contain information that is privileged, confidential or otherwise
> protected from disclosure. If you are not the intended recipient, you are
> hereby notified that any disclosure, copying, distribution, or the taking
> of any action in reliance on the contents of this message is strictly
> prohibited. If you have received this e-mail in error, do not print it or
> disseminate it or its contents. In such event, please notify the sender by
> return e-mail and delete the e-mail file immediately thereafter. Thank you.
>
>
>
> On May 6, 2013, at 2:44 AM, prak...@assistanz.com wrote:
>
> > Hi,
> >
> > I have upgraded cloudstack from 3.0.2 to 4.0.2 but still xenserver host
> > is in disconnected status for few hours.
> >
> > Any solution for this issue?
> >
>
>

RE: [ACS41] Release Blocker Update for 2013-05-08

[Edison Su]

> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Wednesday, May 08, 2013 10:18 AM
> To: dev@cloudstack.apache.org
> Cc: Kishan Kavala
> Subject: [ACS41] Release Blocker Update for 2013-05-08
> 
> Here's where we stand:
> 
> CLOUDSTACK-2309
>   Upgrade from 2.2.14 to 4.1.0 : network static routes deleted on SSVM
> 
>   Kishan - any update on 2309?  Also note that Wei suggested a fix to the
>   reporter for 528.  However, you said you thought 2309 and 528 could be
>   related.  Can you review the suggestion?
> 
> CLOUDSTACK-528
>   Failed to create secondary storage
> 
>   Wei offered a suggested correction to the DB for this bug.  Hopefully
>   we will get a response from Guillaume or Nicolas that it worked, and
>   we can implement the fix in the upgrade script.
> 
> CLOUDSTACK-1907
>   Can't create system VM on XCP1.6 hypervisor
> 
>   There is a suggested fix in the comments of this bug.  Can someone
>   familiar with this portion of the code *please* review and comment?

I can pick it up.

> 
> -chip

Re: [ACS41] Release Blocker Update for 2013-05-08

[Chip Childers]

On Wed, May 08, 2013 at 11:25:26AM -0700, Edison Su wrote:
> 
> 
> > -Original Message-
> > From: Chip Childers [mailto:chip.child...@sungard.com]
> > Sent: Wednesday, May 08, 2013 10:18 AM
> > To: dev@cloudstack.apache.org
> > Cc: Kishan Kavala
> > Subject: [ACS41] Release Blocker Update for 2013-05-08
> > 
> > CLOUDSTACK-1907
> >   Can't create system VM on XCP1.6 hypervisor
> > 
> >   There is a suggested fix in the comments of this bug.  Can someone
> >   familiar with this portion of the code *please* review and comment?
> 
> I can pick it up.
>

Thank you Edison!

Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

[edison su]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/
---

Review request for cloudstack and Chip Childers.


Description
---

Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 


This addresses bug CLOUDSTACK-1907.


Diffs
-

  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
 a711ec0 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 
828a827 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
 0ce91bc 

Diff: https://reviews.apache.org/r/11012/diff/


Testing
---

no


Thanks,

edison su

Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/#review20334
---


Commit 63630a412fddc92fdc68dc27e12d2a68dd09f1dd in branch refs/heads/4.1 from 
Chip Childers 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=63630a4 ]

CLOUDSTACK-1907: Debian Squeeze 6.0 (64-bit) is not experimental any more


- ASF Subversion and Git Services


On May 8, 2013, 6:45 p.m., edison su wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/
> ---
> 
> (Updated May 8, 2013, 6:45 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 
> 
> 
> This addresses bug CLOUDSTACK-1907.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
>  a711ec0 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
>  828a827 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
>  0ce91bc 
> 
> Diff: https://reviews.apache.org/r/11012/diff/
> 
> 
> Testing
> ---
> 
> no
> 
> 
> Thanks,
> 
> edison su
> 
>

Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/#review20335
---


Commit 738d35a61d12aa4ff4aef89f546a077e8629 in branch refs/heads/master 
from Chip Childers 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=738d35a ]

CLOUDSTACK-1907: Debian Squeeze 6.0 (64-bit) is not experimental any more


- ASF Subversion and Git Services


On May 8, 2013, 6:45 p.m., edison su wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/
> ---
> 
> (Updated May 8, 2013, 6:45 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 
> 
> 
> This addresses bug CLOUDSTACK-1907.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
>  a711ec0 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
>  828a827 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
>  0ce91bc 
> 
> Diff: https://reviews.apache.org/r/11012/diff/
> 
> 
> Testing
> ---
> 
> no
> 
> 
> Thanks,
> 
> edison su
> 
>

Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

[Chip Childers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/#review20336
---

Ship it!


Ship It!

- Chip Childers


On May 8, 2013, 6:45 p.m., edison su wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/
> ---
> 
> (Updated May 8, 2013, 6:45 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 
> 
> 
> This addresses bug CLOUDSTACK-1907.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
>  a711ec0 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
>  828a827 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
>  0ce91bc 
> 
> Diff: https://reviews.apache.org/r/11012/diff/
> 
> 
> Testing
> ---
> 
> no
> 
> 
> Thanks,
> 
> edison su
> 
>

Re: Supported Source NAT Type?

[Will Stevens]

I am trying to use the 'per account' source nat type in the network
offering for my Palo Alto Firewall integration.  I currently have it
working for one network per account.  Obviously I would like to support
more than one network per account.  I am not sure that this functionality
is currently implemented.

Here is the code in question in ExternalFirewallDeviceManagerImpl.java and
function 'manageGuestNetworkWithExternalFirewall':
IPAddressVO sourceNatIp = null;
if (!sharedSourceNat) {
// Get the source NAT IP address for this account
List sourceNatIps =
_networkModel.listPublicIpsAssignedToAccount(network.getAccountId(),
zoneId, true);

if (sourceNatIps.size() != 1) {
String errorMsg = "External firewall was unable to find the source
NAT IP address for account "
+ account.getAccountName();
s_logger.error(errorMsg);
return true;
} else {
sourceNatIp = _ipAddressDao.findById(sourceNatIps.get(0).getId());
}
}

This piece of code is supposed to handle the when the source nat type is
'per account' instead of 'per zone'.  This clearly only supports one
network per account.

Since the condition when 'sourceNatIps.size() != 1' is only an error, would
I have the go ahead to implement support for multiple networks in one
account or am I missing something here?  Basically, I will want to set the
'sourceNatIp' variable to be the source nat ip for the specific network.

Let me know what you think...

Thanks,

Will





On Thu, Apr 18, 2013 at 6:28 PM, Will Stevens  wrote:

> Great.  Thanks again, this is very helpful.
>
> So the way I am doing it is good for now.  If IP space becomes an issue
> (when people are actually using it), I could implement the 'per zone'
> approach as well.
>
> In the per zone approach, the firewall would be initially configured with
> a public IP and a generic source nat rule which would map the entire guest
> network range in the trusted zone to the preconfigured public IP in the
> untrusted zone.  I understand how this works now and why the source nat
> rules will not need to be managed by cloudstack.
>
> Thanks again for the explanation.
>
>
> On Thu, Apr 18, 2013 at 6:12 PM, Sheng Yang  wrote:
>
>> Hi Will,
>>
>> "per account" is perfectly fine in your case. "per zone" can be used if
>> user want to preserve some public IPs. And with "per zone", CloudStack
>> just
>> won't care about source nat ip allocation etc any more, it would assume
>> that the firewall should already has taken care of that. Source NAT IP
>> would be blank in Cloudstack(a.k.a. isolated network without source nat
>> ip).
>>
>> It's not requirement to support "per zone". In fact as long as your device
>> can support of the source nat mechanism then it's fine. But I don't think
>> you need to handle source nat rules if you use "per zone" mode(from CS's
>> perspective). E.g. Juniper SRX has such a configuration:
>>
>> nat {
>> source {
>> pool inat-pool {
>> address {
>> 10.223.161.18/32;
>> }
>> }
>> rule-set trust {
>> from zone trust;
>> to zone untrust;
>> rule i-nat {
>> match {
>> source-address 10.0.0.0/8;
>> }
>> then {
>> source-nat {
>> pool {
>> inat-pool;
>> }
>> }
>> }
>> }
>> }
>> }
>> }
>>
>> This one would fit all traffic from "trust" zone(every newly created
>> isolated network would be in trust zone) to "untrust" zone(public
>> network),
>> using source nat.
>>
>> --Sheng
>>
>> On Thu, Apr 18, 2013 at 2:50 PM, Will Stevens 
>> wrote:
>>
>> > Thanks for the answer Sheng.
>> >
>> > I currently have the Palo Alto firewall using the 'per account' method
>> and
>> > when 'IpAssocCommand' is run (when the first VM is added to a palo alto
>> > network ), I am dynamically creating a public sub-interface and
>> assigning a
>> > public IP (provided by cloudstack).  I am also creating a private
>> > sub-interface on the PA which I am using the the gateway for the CS
>> > network.  I am dynamically creating/deleting the SourceNat rules between
>> > the two sub-interfaces (gateway/cidr# -> public_ip/32) on implement and
>> > shutdown.
>> >
>> > In your eyes, is this the best way to handle this?  If I was to use the
>> > 'per zone' option, how would the Source Nat IP get set in Cloudstack?
>>  So
>> > there would be one public IP per zone which all the public traffic
>> would go
>> > through for all networks?  I would still have to handle the source nat
>> > rules from each CS network to that single public IP I believe.
>> >
>> > I am slowly getting this all documented at:
>> >
>> >
>> https://cwiki.apache.org/confluence/display

Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/#review20344
---


Commit 738d35a61d12aa4ff4aef89f546a077e8629 in branch refs/heads/internallb 
from Chip Childers 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=738d35a ]

CLOUDSTACK-1907: Debian Squeeze 6.0 (64-bit) is not experimental any more


- ASF Subversion and Git Services


On May 8, 2013, 6:45 p.m., edison su wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/
> ---
> 
> (Updated May 8, 2013, 6:45 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 
> 
> 
> This addresses bug CLOUDSTACK-1907.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
>  a711ec0 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
>  828a827 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
>  0ce91bc 
> 
> Diff: https://reviews.apache.org/r/11012/diff/
> 
> 
> Testing
> ---
> 
> no
> 
> 
> Thanks,
> 
> edison su
> 
>

Re: Review Request: (CLOUDSTACK-2318) update volumes.path to fix stop/start vm error after upgrade from 2.2.14 to 3.0.0

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11005/#review20345
---


Commit 99d0936314571e645f62e40bf4d227232be89632 in branch refs/heads/internallb 
from Chip Childers 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=99d0936 ]

CLOUDSTACK-2318: update volumes.path to fix stop/start vm error after
upgrade from 2.2.14 to 3.0.0

Signed-off-by: Chip Childers 


- ASF Subversion and Git Services


On May 8, 2013, 8:45 a.m., Wei Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11005/
> ---
> 
> (Updated May 8, 2013, 8:45 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> more details in 
> http://markmail.org/message/h2qiuapd4jkxzhpo?q=KVM+Agent+problem
> https://issues.apache.org/jira/browse/CLOUDSTACK-2318
> 
> 
> This addresses bug CLOUDSTACK-2318.
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-2214to30.sql 60eceea 
> 
> Diff: https://reviews.apache.org/r/11005/diff/
> 
> 
> Testing
> ---
> 
> Testing ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Supported Source NAT Type?

[Sheng Yang]

I've checked the code and seems it's legacy code here. SRX's support for
"per account" is broken anyway, so you can modify it according to your
requirement.

Multiple networks per account for external devices is really nice to have,
I think you can go ahead and implement it.

Thanks.

--Sheng

On Wed, May 8, 2013 at 1:25 PM, Will Stevens  wrote:

> I am trying to use the 'per account' source nat type in the network
> offering for my Palo Alto Firewall integration.  I currently have it
> working for one network per account.  Obviously I would like to support
> more than one network per account.  I am not sure that this functionality
> is currently implemented.
>
> Here is the code in question in ExternalFirewallDeviceManagerImpl.java and
> function 'manageGuestNetworkWithExternalFirewall':
> IPAddressVO sourceNatIp = null;
> if (!sharedSourceNat) {
> // Get the source NAT IP address for this account
> List sourceNatIps =
> _networkModel.listPublicIpsAssignedToAccount(network.getAccountId(),
> zoneId, true);
>
> if (sourceNatIps.size() != 1) {
> String errorMsg = "External firewall was unable to find the source
> NAT IP address for account "
> + account.getAccountName();
> s_logger.error(errorMsg);
> return true;
> } else {
> sourceNatIp = _ipAddressDao.findById(sourceNatIps.get(0).getId());
> }
> }
>
> This piece of code is supposed to handle the when the source nat type is
> 'per account' instead of 'per zone'.  This clearly only supports one
> network per account.
>
> Since the condition when 'sourceNatIps.size() != 1' is only an error, would
> I have the go ahead to implement support for multiple networks in one
> account or am I missing something here?  Basically, I will want to set the
> 'sourceNatIp' variable to be the source nat ip for the specific network.
>
> Let me know what you think...
>
> Thanks,
>
> Will
>
>
>
>
>
> On Thu, Apr 18, 2013 at 6:28 PM, Will Stevens 
> wrote:
>
> > Great.  Thanks again, this is very helpful.
> >
> > So the way I am doing it is good for now.  If IP space becomes an issue
> > (when people are actually using it), I could implement the 'per zone'
> > approach as well.
> >
> > In the per zone approach, the firewall would be initially configured with
> > a public IP and a generic source nat rule which would map the entire
> guest
> > network range in the trusted zone to the preconfigured public IP in the
> > untrusted zone.  I understand how this works now and why the source nat
> > rules will not need to be managed by cloudstack.
> >
> > Thanks again for the explanation.
> >
> >
> > On Thu, Apr 18, 2013 at 6:12 PM, Sheng Yang  wrote:
> >
> >> Hi Will,
> >>
> >> "per account" is perfectly fine in your case. "per zone" can be used if
> >> user want to preserve some public IPs. And with "per zone", CloudStack
> >> just
> >> won't care about source nat ip allocation etc any more, it would assume
> >> that the firewall should already has taken care of that. Source NAT IP
> >> would be blank in Cloudstack(a.k.a. isolated network without source nat
> >> ip).
> >>
> >> It's not requirement to support "per zone". In fact as long as your
> device
> >> can support of the source nat mechanism then it's fine. But I don't
> think
> >> you need to handle source nat rules if you use "per zone" mode(from CS's
> >> perspective). E.g. Juniper SRX has such a configuration:
> >>
> >> nat {
> >> source {
> >> pool inat-pool {
> >> address {
> >> 10.223.161.18/32;
> >> }
> >> }
> >> rule-set trust {
> >> from zone trust;
> >> to zone untrust;
> >> rule i-nat {
> >> match {
> >> source-address 10.0.0.0/8;
> >> }
> >> then {
> >> source-nat {
> >> pool {
> >> inat-pool;
> >> }
> >> }
> >> }
> >> }
> >> }
> >> }
> >> }
> >>
> >> This one would fit all traffic from "trust" zone(every newly created
> >> isolated network would be in trust zone) to "untrust" zone(public
> >> network),
> >> using source nat.
> >>
> >> --Sheng
> >>
> >> On Thu, Apr 18, 2013 at 2:50 PM, Will Stevens 
> >> wrote:
> >>
> >> > Thanks for the answer Sheng.
> >> >
> >> > I currently have the Palo Alto firewall using the 'per account' method
> >> and
> >> > when 'IpAssocCommand' is run (when the first VM is added to a palo
> alto
> >> > network ), I am dynamically creating a public sub-interface and
> >> assigning a
> >> > public IP (provided by cloudstack).  I am also creating a private
> >> > sub-interface on the PA which I am using the the gateway for the CS
> >> > network.  I am dynamically creating/deleting the SourceNat rules
> betw

Re: Supported Source NAT Type?

[Will Stevens]

Alright, I have updated the code to what I have pasted at the bottom.  I
have tested it and it is working as expected.  With this change I now have
multiple networks per account working with my external firewall device.

I will be posting my code to a public repo soon so people can start
checking it out.

Thanks for confirming this was legacy.

Cheers,

Will

---

IPAddressVO sourceNatIp = null;
if (!sharedSourceNat) {
// Get the source NAT IP address for this network
List sourceNatIps =
_networkModel.listPublicIpsAssignedToAccount(network.getAccountId(),
zoneId, true);

for (IpAddress ipAddress : sourceNatIps) {
if (ipAddress.getAssociatedWithNetworkId().longValue() ==
network.getId()) {
sourceNatIp = _ipAddressDao.findById(ipAddress.getId());
break;
}
}
if (sourceNatIp == null) {
String errorMsg = "External firewall was unable to find the source
NAT IP address for network " + network.getName();
s_logger.error(errorMsg);
return true;
}
}




On Wed, May 8, 2013 at 5:21 PM, Sheng Yang  wrote:

> I've checked the code and seems it's legacy code here. SRX's support for
> "per account" is broken anyway, so you can modify it according to your
> requirement.
>
> Multiple networks per account for external devices is really nice to have,
> I think you can go ahead and implement it.
>
> Thanks.
>
> --Sheng
>
> On Wed, May 8, 2013 at 1:25 PM, Will Stevens 
> wrote:
>
> > I am trying to use the 'per account' source nat type in the network
> > offering for my Palo Alto Firewall integration.  I currently have it
> > working for one network per account.  Obviously I would like to support
> > more than one network per account.  I am not sure that this functionality
> > is currently implemented.
> >
> > Here is the code in question in ExternalFirewallDeviceManagerImpl.java
> and
> > function 'manageGuestNetworkWithExternalFirewall':
> > IPAddressVO sourceNatIp = null;
> > if (!sharedSourceNat) {
> > // Get the source NAT IP address for this account
> > List sourceNatIps =
> > _networkModel.listPublicIpsAssignedToAccount(network.getAccountId(),
> > zoneId, true);
> >
> > if (sourceNatIps.size() != 1) {
> > String errorMsg = "External firewall was unable to find the
> source
> > NAT IP address for account "
> > + account.getAccountName();
> > s_logger.error(errorMsg);
> > return true;
> > } else {
> > sourceNatIp =
> _ipAddressDao.findById(sourceNatIps.get(0).getId());
> > }
> > }
> >
> > This piece of code is supposed to handle the when the source nat type is
> > 'per account' instead of 'per zone'.  This clearly only supports one
> > network per account.
> >
> > Since the condition when 'sourceNatIps.size() != 1' is only an error,
> would
> > I have the go ahead to implement support for multiple networks in one
> > account or am I missing something here?  Basically, I will want to set
> the
> > 'sourceNatIp' variable to be the source nat ip for the specific network.
> >
> > Let me know what you think...
> >
> > Thanks,
> >
> > Will
> >
> >
> >
> >
> >
> > On Thu, Apr 18, 2013 at 6:28 PM, Will Stevens 
> > wrote:
> >
> > > Great.  Thanks again, this is very helpful.
> > >
> > > So the way I am doing it is good for now.  If IP space becomes an issue
> > > (when people are actually using it), I could implement the 'per zone'
> > > approach as well.
> > >
> > > In the per zone approach, the firewall would be initially configured
> with
> > > a public IP and a generic source nat rule which would map the entire
> > guest
> > > network range in the trusted zone to the preconfigured public IP in the
> > > untrusted zone.  I understand how this works now and why the source nat
> > > rules will not need to be managed by cloudstack.
> > >
> > > Thanks again for the explanation.
> > >
> > >
> > > On Thu, Apr 18, 2013 at 6:12 PM, Sheng Yang  wrote:
> > >
> > >> Hi Will,
> > >>
> > >> "per account" is perfectly fine in your case. "per zone" can be used
> if
> > >> user want to preserve some public IPs. And with "per zone", CloudStack
> > >> just
> > >> won't care about source nat ip allocation etc any more, it would
> assume
> > >> that the firewall should already has taken care of that. Source NAT IP
> > >> would be blank in Cloudstack(a.k.a. isolated network without source
> nat
> > >> ip).
> > >>
> > >> It's not requirement to support "per zone". In fact as long as your
> > device
> > >> can support of the source nat mechanism then it's fine. But I don't
> > think
> > >> you need to handle source nat rules if you use "per zone" mode(from
> CS's
> > >> perspective). E.g. Juniper SRX has such a configuration:
> > >>
> > >> nat {
> > >> source {
> > >> pool inat-pool {
> > >> address {
> > >> 10.223.161.18/32;
> > >> }
> > >> }
> > >> rule-set trust {
> > >> from zone

Re: Supported Source NAT Type?

[Sheng Yang]

The code looks fine to me. Looking forward to your repo!

--Sheng


On Wed, May 8, 2013 at 3:12 PM, Will Stevens  wrote:

> Alright, I have updated the code to what I have pasted at the bottom.  I
> have tested it and it is working as expected.  With this change I now have
> multiple networks per account working with my external firewall device.
>
> I will be posting my code to a public repo soon so people can start
> checking it out.
>
> Thanks for confirming this was legacy.
>
> Cheers,
>
> Will
>
> ---
>
> IPAddressVO sourceNatIp = null;
> if (!sharedSourceNat) {
> // Get the source NAT IP address for this network
> List sourceNatIps =
> _networkModel.listPublicIpsAssignedToAccount(network.getAccountId(),
> zoneId, true);
>
> for (IpAddress ipAddress : sourceNatIps) {
> if (ipAddress.getAssociatedWithNetworkId().longValue() ==
> network.getId()) {
> sourceNatIp = _ipAddressDao.findById(ipAddress.getId());
> break;
> }
> }
> if (sourceNatIp == null) {
> String errorMsg = "External firewall was unable to find the source
> NAT IP address for network " + network.getName();
> s_logger.error(errorMsg);
> return true;
> }
> }
>
>
>
>
> On Wed, May 8, 2013 at 5:21 PM, Sheng Yang  wrote:
>
> > I've checked the code and seems it's legacy code here. SRX's support for
> > "per account" is broken anyway, so you can modify it according to your
> > requirement.
> >
> > Multiple networks per account for external devices is really nice to
> have,
> > I think you can go ahead and implement it.
> >
> > Thanks.
> >
> > --Sheng
> >
> > On Wed, May 8, 2013 at 1:25 PM, Will Stevens 
> > wrote:
> >
> > > I am trying to use the 'per account' source nat type in the network
> > > offering for my Palo Alto Firewall integration.  I currently have it
> > > working for one network per account.  Obviously I would like to support
> > > more than one network per account.  I am not sure that this
> functionality
> > > is currently implemented.
> > >
> > > Here is the code in question in ExternalFirewallDeviceManagerImpl.java
> > and
> > > function 'manageGuestNetworkWithExternalFirewall':
> > > IPAddressVO sourceNatIp = null;
> > > if (!sharedSourceNat) {
> > > // Get the source NAT IP address for this account
> > > List sourceNatIps =
> > > _networkModel.listPublicIpsAssignedToAccount(network.getAccountId(),
> > > zoneId, true);
> > >
> > > if (sourceNatIps.size() != 1) {
> > > String errorMsg = "External firewall was unable to find the
> > source
> > > NAT IP address for account "
> > > + account.getAccountName();
> > > s_logger.error(errorMsg);
> > > return true;
> > > } else {
> > > sourceNatIp =
> > _ipAddressDao.findById(sourceNatIps.get(0).getId());
> > > }
> > > }
> > >
> > > This piece of code is supposed to handle the when the source nat type
> is
> > > 'per account' instead of 'per zone'.  This clearly only supports one
> > > network per account.
> > >
> > > Since the condition when 'sourceNatIps.size() != 1' is only an error,
> > would
> > > I have the go ahead to implement support for multiple networks in one
> > > account or am I missing something here?  Basically, I will want to set
> > the
> > > 'sourceNatIp' variable to be the source nat ip for the specific
> network.
> > >
> > > Let me know what you think...
> > >
> > > Thanks,
> > >
> > > Will
> > >
> > >
> > >
> > >
> > >
> > > On Thu, Apr 18, 2013 at 6:28 PM, Will Stevens 
> > > wrote:
> > >
> > > > Great.  Thanks again, this is very helpful.
> > > >
> > > > So the way I am doing it is good for now.  If IP space becomes an
> issue
> > > > (when people are actually using it), I could implement the 'per zone'
> > > > approach as well.
> > > >
> > > > In the per zone approach, the firewall would be initially configured
> > with
> > > > a public IP and a generic source nat rule which would map the entire
> > > guest
> > > > network range in the trusted zone to the preconfigured public IP in
> the
> > > > untrusted zone.  I understand how this works now and why the source
> nat
> > > > rules will not need to be managed by cloudstack.
> > > >
> > > > Thanks again for the explanation.
> > > >
> > > >
> > > > On Thu, Apr 18, 2013 at 6:12 PM, Sheng Yang 
> wrote:
> > > >
> > > >> Hi Will,
> > > >>
> > > >> "per account" is perfectly fine in your case. "per zone" can be used
> > if
> > > >> user want to preserve some public IPs. And with "per zone",
> CloudStack
> > > >> just
> > > >> won't care about source nat ip allocation etc any more, it would
> > assume
> > > >> that the firewall should already has taken care of that. Source NAT
> IP
> > > >> would be blank in Cloudstack(a.k.a. isolated network without source
> > nat
> > > >> ip).
> > > >>
> > > >> It's not requirement to support "per zone". In fact as long as your
> > > device
> > > >> can support of the source nat mechanism then it's fine. But I don't
> > > think
> 

[MERGE] PVLAN branch to MASTER

[Sheng Yang]

FS at:
https://cwiki.apache.org/CLOUDSTACK/pvlan-for-isolation-within-a-vlan.html

PVLAN branch has been under development for some time, and now the
functionality works on KVM and Xen, would be followed by VMware soon

VM live migration is not supported so far, I am waiting for the fix of
https://issues.apache.org/jira/browse/CLOUDSTACK-1638 .

We're using ovs/open flow to manipulate ingress/egress traffic to emulate
the isolation PVLAN function on KVM and Xen. The details are in the FS.

The core code change is minimal and there is no DB change, because we took
advantage of "broadcast domain" to introduce "pvlan://" broadcast URI to
describe the primary and isolated PVLAN for the network.

If there is no objection, I would merge the branch in 48 hours.

Thanks.

--Sheng

Re: [MERGE] PVLAN branch to MASTER

[Sheng Yang]

JIRA ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-1456

Discussion:
http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201304.mbox/%3cca+2rt43r6wfzpvsjqx1qwqv3kz4umszys+rjf+bjefno0lx...@mail.gmail.com%3E

--Sheng


On Wed, May 8, 2013 at 4:25 PM, Sheng Yang  wrote:

> FS at:
> https://cwiki.apache.org/CLOUDSTACK/pvlan-for-isolation-within-a-vlan.html
>
> PVLAN branch has been under development for some time, and now the
> functionality works on KVM and Xen, would be followed by VMware soon
>
> VM live migration is not supported so far, I am waiting for the fix of
> https://issues.apache.org/jira/browse/CLOUDSTACK-1638 .
>
> We're using ovs/open flow to manipulate ingress/egress traffic to emulate
> the isolation PVLAN function on KVM and Xen. The details are in the FS.
>
> The core code change is minimal and there is no DB change, because we took
> advantage of "broadcast domain" to introduce "pvlan://" broadcast URI to
> describe the primary and isolated PVLAN for the network.
>
> If there is no objection, I would merge the branch in 48 hours.
>
> Thanks.
>
> --Sheng
>

Re: [MERGE] PVLAN branch to MASTER

[Chip Childers]

On Wed, May 08, 2013 at 04:25:31PM -0700, Sheng Yang wrote:
> FS at:
> https://cwiki.apache.org/CLOUDSTACK/pvlan-for-isolation-within-a-vlan.html
> 
> PVLAN branch has been under development for some time, and now the
> functionality works on KVM and Xen, would be followed by VMware soon
> 
> VM live migration is not supported so far, I am waiting for the fix of
> https://issues.apache.org/jira/browse/CLOUDSTACK-1638 .
> 
> We're using ovs/open flow to manipulate ingress/egress traffic to emulate
> the isolation PVLAN function on KVM and Xen. The details are in the FS.
> 
> The core code change is minimal and there is no DB change, because we took
> advantage of "broadcast domain" to introduce "pvlan://" broadcast URI to
> describe the primary and isolated PVLAN for the network.
> 
> If there is no objection, I would merge the branch in 48 hours.
> 
> Thanks.
> 
> --Sheng

Hey Sheng,

Recently, merge requests have included things like:

* Did you check the branch's RAT execution success?
* Are there new dependencies introduced?
* What automated testing (unit and integration) is included in the new
feature?
* What testing has been done to check for potential regressions?

Some of these might be easily answered, but they're what we've agreed
are the key elements of a feature merge request.

-chip

Re: Git merge question

[Chip Childers]

On Mon, May 06, 2013 at 11:21:47AM -0600, Mike Tutkowski wrote:
> Hi everyone,
> 
> I've used SVN for many years, but am a bit new to Git.
> 
> I've been making changes locally in my repo for a while and wanted to
> update my repo from the "upstream" repo, but do not want to first stage or
> commit changes locally.
> 
> I get the following error message:
> 
> mtutkowski-LT:incubator-cloudstack mtutkowski$ git merge upstream/master
> Updating 73d87f1..4c0eecc
> error: Your local changes to the following files would be overwritten by
> merge:
> client/pom.xml
> client/tomcatconf/applicationContext.xml.in
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> server/src/com/cloud/storage/VolumeManagerImpl.java
> Please, commit your changes or stash them before you can merge.
> Aborting
> 
> If I do a git stash, then git merge upstream/master, then un-stash, should
> that work as I might expect (where the un-stash will lead to a merge of
> sorts since some stashed files will be different from the newly merged
> ones)?

git stash will stash the changes, and then git stash pop will attempt to
re-apply them.  If there are conflicts, you will have to sort them out
after the pop.

OTOH, you should consider committing as you go in a local branch, and
merging the latest from master periodically into that branch.

> 
> Thanks!
> 
> -- 
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *™*

Re: [MERGE] CLOUDSTACK-747 "nTier Apps 2.0 : Internal Load Balancing between the VPC tiers"

[Chip Childers]

On Mon, May 06, 2013 at 10:33:51AM -0700, Alena Prokharchyk wrote:
> Hi all,
> 
> I would like to merge the Internal LB feature from  asf/internallb branch
> to master.
> 
> - link to FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Internal+Load+Balanc
> ing+between+VPC+tiers
> - Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-747
> - UnitTests: the tests are added to
> 
> cloud-plugin-network-internallb/test (Internal LB element management):
> 
> * InternalLbElementServiceTest.java
> * InternalLbElementTest.java
> * InternalLBVMManagerTest.java
> * InternalLBVMServiceTest.java
> 
> and cloud-server/test/lb (Internal LB rules management):
> 
> * ApplicationLoadBalancerTest.java
> 
> 
> - Integration tests: python test is
> test/integration/smoke/test_internal_lb.py
> - As various people were working on the branch, so I did do daily merges
> (not rebase) with the master branch, and internal lb commits are spread
> over time. To fetch all the internal LB commits, execute this command:
> 
>   git log internallb ^master --no-merges
> 
> After the approval, the merge to master will be done as one squashed
> commit.
> 
> - there is no UI for the feature yet; it will be developed in another
> branch and merged to master branch separately.
> - Attached is the RAT report that resulted in "0 Unknown Licenses"
> 
> 
> 
> Thank you,
> -Alena.
>

+1 from me

Re: Fwd: [IP CLEARANCE] CloudStack Marvin Test Suite

[Chip Childers]

On Wed, May 08, 2013 at 10:43:03AM +0530, Prasanna Santhanam wrote:
> Thanks Chip, Indeed I've been waiting for this to finally get through
> legal. I'll merge it at a suitable time once the vote passes.
> 
> There's going to be a some more patches coming to fix the changes
> we've made in the past few months to be get these tests to running
> state. All this work was done on github/cloudstack-qa from where the
> patches will be generated for reviewboard.

Let's just make sure that they come in from the individuals that
authored each bit of code.

Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11012/#review20359
---


Commit 738d35a61d12aa4ff4aef89f546a077e8629 in branch 
refs/heads/planner_reserve from Chip Childers 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=738d35a ]

CLOUDSTACK-1907: Debian Squeeze 6.0 (64-bit) is not experimental any more


- ASF Subversion and Git Services


On May 8, 2013, 6:45 p.m., edison su wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/
> ---
> 
> (Updated May 8, 2013, 6:45 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907, 
> 
> 
> This addresses bug CLOUDSTACK-1907.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
>  a711ec0 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
>  828a827 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
>  0ce91bc 
> 
> Diff: https://reviews.apache.org/r/11012/diff/
> 
> 
> Testing
> ---
> 
> no
> 
> 
> Thanks,
> 
> edison su
> 
>

Re: Review Request: (CLOUDSTACK-2318) update volumes.path to fix stop/start vm error after upgrade from 2.2.14 to 3.0.0

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11005/#review20360
---


Commit 99d0936314571e645f62e40bf4d227232be89632 in branch 
refs/heads/planner_reserve from Chip Childers 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=99d0936 ]

CLOUDSTACK-2318: update volumes.path to fix stop/start vm error after
upgrade from 2.2.14 to 3.0.0

Signed-off-by: Chip Childers 


- ASF Subversion and Git Services


On May 8, 2013, 8:45 a.m., Wei Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11005/
> ---
> 
> (Updated May 8, 2013, 8:45 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> ---
> 
> more details in 
> http://markmail.org/message/h2qiuapd4jkxzhpo?q=KVM+Agent+problem
> https://issues.apache.org/jira/browse/CLOUDSTACK-2318
> 
> 
> This addresses bug CLOUDSTACK-2318.
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-2214to30.sql 60eceea 
> 
> Diff: https://reviews.apache.org/r/11005/diff/
> 
> 
> Testing
> ---
> 
> Testing ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Git merge question

[Mike Tutkowski]

I see...maybe a local commit would have been preferable.

I'm used to not committing until I have the code in a stable state
(probably typical with centralized VCSs like SVN), but with my local repo I
suppose it doesn't matter as much.


On Wed, May 8, 2013 at 5:45 PM, Chip Childers wrote:

> On Mon, May 06, 2013 at 11:21:47AM -0600, Mike Tutkowski wrote:
> > Hi everyone,
> >
> > I've used SVN for many years, but am a bit new to Git.
> >
> > I've been making changes locally in my repo for a while and wanted to
> > update my repo from the "upstream" repo, but do not want to first stage
> or
> > commit changes locally.
> >
> > I get the following error message:
> >
> > mtutkowski-LT:incubator-cloudstack mtutkowski$ git merge upstream/master
> > Updating 73d87f1..4c0eecc
> > error: Your local changes to the following files would be overwritten by
> > merge:
> > client/pom.xml
> > client/tomcatconf/applicationContext.xml.in
> >
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> > server/src/com/cloud/storage/VolumeManagerImpl.java
> > Please, commit your changes or stash them before you can merge.
> > Aborting
> >
> > If I do a git stash, then git merge upstream/master, then un-stash,
> should
> > that work as I might expect (where the un-stash will lead to a merge of
> > sorts since some stashed files will be different from the newly merged
> > ones)?
>
> git stash will stash the changes, and then git stash pop will attempt to
> re-apply them.  If there are conflicts, you will have to sort them out
> after the pop.
>
> OTOH, you should consider committing as you go in a local branch, and
> merging the latest from master periodically into that branch.
>
> >
> > Thanks!
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Git merge question

[Chip Childers]

Yes, git is a completely different workflow.  Branch frequently...
commit frequently...

On Wed, May 8, 2013 at 9:23 PM, Mike Tutkowski
 wrote:
> I see...maybe a local commit would have been preferable.
>
> I'm used to not committing until I have the code in a stable state
> (probably typical with centralized VCSs like SVN), but with my local repo I
> suppose it doesn't matter as much.
>
>
> On Wed, May 8, 2013 at 5:45 PM, Chip Childers 
> wrote:
>
>> On Mon, May 06, 2013 at 11:21:47AM -0600, Mike Tutkowski wrote:
>> > Hi everyone,
>> >
>> > I've used SVN for many years, but am a bit new to Git.
>> >
>> > I've been making changes locally in my repo for a while and wanted to
>> > update my repo from the "upstream" repo, but do not want to first stage
>> or
>> > commit changes locally.
>> >
>> > I get the following error message:
>> >
>> > mtutkowski-LT:incubator-cloudstack mtutkowski$ git merge upstream/master
>> > Updating 73d87f1..4c0eecc
>> > error: Your local changes to the following files would be overwritten by
>> > merge:
>> > client/pom.xml
>> > client/tomcatconf/applicationContext.xml.in
>> >
>> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>> > server/src/com/cloud/storage/VolumeManagerImpl.java
>> > Please, commit your changes or stash them before you can merge.
>> > Aborting
>> >
>> > If I do a git stash, then git merge upstream/master, then un-stash,
>> should
>> > that work as I might expect (where the un-stash will lead to a merge of
>> > sorts since some stashed files will be different from the newly merged
>> > ones)?
>>
>> git stash will stash the changes, and then git stash pop will attempt to
>> re-apply them.  If there are conflicts, you will have to sort them out
>> after the pop.
>>
>> OTOH, you should consider committing as you go in a local branch, and
>> merging the latest from master periodically into that branch.
>>
>> >
>> > Thanks!
>> >
>> > --
>> > *Mike Tutkowski*
>> > *Senior CloudStack Developer, SolidFire Inc.*
>> > e: mike.tutkow...@solidfire.com
>> > o: 303.746.7302
>> > Advancing the way the world uses the
>> > cloud
>> > *™*
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *™*

Review Request: PVLAN support for vmware Distributed Virtual switch deployments on cloudstack

[Venkata Siva Vijayendra Bhamidipati]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11018/
---

Review request for cloudstack, Chip Childers, Sateesh Chodapuneedi, and Kelven 
Yang.


Description
---

Please find attached the diffs for pvlan support for vmware DVSwitch 
deployments on cloudstack. You will find two diffs - the parent diff is 
Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the 
pvlan branch from the master. The other diff contains the changes for pvlan 
support.


This addresses bug CLOUDSTACK-1456.


Diffs
-

  
engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
 25e7423 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 99ad1ca 
  server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
  server/src/com/cloud/network/NetworkModelImpl.java bd62886 
  server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java 0a3e20b 
  
vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java 
247be2a 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
7f323c5 

Diff: https://reviews.apache.org/r/11018/diff/


Testing
---

The code has been tested on the Vmware DVSwitch for advanced shared networks on 
vmware cluster deployments on cloudstack. Unit tests will be the same as those 
provided by Sheng as part of the overall PVLAN support for XenServer and KVM, 
and will exercise the vmware pvlan code path when user VMs are created with 
vNICs sitting on advanced shared networks that have the optional Private VLAN 
value set during their creation. VM live migration using vmware vMotion has 
also been tested with these changes on vmware and it works as expected.

Further testing will be carried out and this review request will be updated 
accordingly.


Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: PVLAN support for vmware Distributed Virtual switch deployments on cloudstack

[Venkata Siva Vijayendra Bhamidipati]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11018/
---

(Updated May 9, 2013, 2:08 a.m.)


Review request for cloudstack, Chip Childers, Sateesh Chodapuneedi, and Kelven 
Yang.


Description
---

Please find attached the diffs for pvlan support for vmware DVSwitch 
deployments on cloudstack. You will find two diffs - the parent diff is 
Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the 
pvlan branch from the master. The other diff contains the changes for pvlan 
support.


This addresses bug CLOUDSTACK-1456.


Diffs
-

  
engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
 25e7423 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 99ad1ca 
  server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
  server/src/com/cloud/network/NetworkModelImpl.java bd62886 
  server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java 0a3e20b 
  
vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java 
247be2a 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
7f323c5 

Diff: https://reviews.apache.org/r/11018/diff/


Testing
---

The code has been tested on the Vmware DVSwitch for advanced shared networks on 
vmware cluster deployments on cloudstack. Unit tests will be the same as those 
provided by Sheng as part of the overall PVLAN support for XenServer and KVM, 
and will exercise the vmware pvlan code path when user VMs are created with 
vNICs sitting on advanced shared networks that have the optional Private VLAN 
value set during their creation. VM live migration using vmware vMotion has 
also been tested with these changes on vmware and it works as expected.

Further testing will be carried out and this review request will be updated 
accordingly.


Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: bug fix for https://issues.apache.org/jira/browse/CLOUDSTACK-1907

[Ryan Lei]

I'm glad to see this fixed, but there are some other changes in the
supported guest os type as of XCP 1.6 (at least in my XCP 1.6.10).

For example, Windows 8 (32-bit/64-bit), Ubuntu 10.10, 12.04 , Solaris 10
(all experimental).
Maybe it's best to completely go through the list in XCP 1.6.x, instead of
copying the current list and just fix the ones for System VMs.

Thanks!



On Thu, May 9, 2013 at 8:20 AM, ASF Subversion and Git Services <
asf...@urd.zones.apache.org> wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11012/#review20359
> ---
>
>
> Commit 738d35a61d12aa4ff4aef89f546a077e8629 in branch
> refs/heads/planner_reserve from Chip Childers 
> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=738d35a ]
>
> CLOUDSTACK-1907: Debian Squeeze 6.0 (64-bit) is not experimental any more
>
>
> - ASF Subversion and Git Services
>
>
> On May 8, 2013, 6:45 p.m., edison su wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/11012/
> > ---
> >
> > (Updated May 8, 2013, 6:45 p.m.)
> >
> >
> > Review request for cloudstack and Chip Childers.
> >
> >
> > Description
> > ---
> >
> > Fix bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1907,
> >
> >
> > This addresses bug CLOUDSTACK-1907.
> >
> >
> > Diffs
> > -
> >
> >
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
> a711ec0
> >
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
> 828a827
> >
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
> 0ce91bc
> >
> > Diff: https://reviews.apache.org/r/11012/diff/
> >
> >
> > Testing
> > ---
> >
> > no
> >
> >
> > Thanks,
> >
> > edison su
> >
> >
>
>

Review Request: PVLAN provisioning support for vmware Distributed Virtual Switch deployments on cloudstack.

[Venkata Siva Vijayendra Bhamidipati]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11019/
---

Review request for cloudstack, Chip Childers, Sateesh Chodapuneedi, and Kelven 
Yang.


Description
---

Please find attached the diffs for pvlan support for vmware DVSwitch 
deployments on cloudstack. You will find two diffs - the parent diff is 
Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the 
pvlan branch from the master. The other diff contains the changes for pvlan 
support.

These diffs do not contain changes for pvlan provisioning on the Cisco Nexus 
1000v distributed virtual switch.


This addresses bug CLOUDSTACK-1456.


Diffs
-

  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 99ad1ca 
  server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
  server/src/com/cloud/network/NetworkModelImpl.java bd62886 
  server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
  
vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java 
247be2a 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
7f323c5 

Diff: https://reviews.apache.org/r/11019/diff/


Testing
---

The code has been tested on the Vmware DVSwitch for advanced shared networks on 
vmware cluster deployments on cloudstack. Unit tests will be the same as those 
provided by Sheng as part of the overall PVLAN support for XenServer and KVM, 
and will exercise the vmware pvlan code path when user VMs are created with 
vNICs sitting on advanced shared networks that have the optional Private VLAN 
value set during their creation. VM live migration using vmware vMotion has 
also been tested with these changes on vmware and it works as expected.

Further testing will be carried out and this review request will be updated 
accordingly.


Thanks,

Venkata Siva Vijayendra Bhamidipati

"_Enhancer" Question

[Mike Tutkowski]

Hi,

I was wondering if someone could explain to me the "_Enhancer" pattern we
are using in CloudStack (below) and how this kind of class is created.

class
org.apache.cloudstack.storage.allocator.ZoneWideStoragePoolAllocator_EnhancerByCloudStack_4ff7ea3a

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

[ACS42] Schedule Remember - Feature freeze on 2013-05-31

[Animesh Chaturvedi]

Folks

I wanted to remind everyone about the 4.2 schedule for getting new features and 
improvements integrated into master. The window closes on 2013-05-31. 

The list of features and improvements that have been tagged in Jira as 
targeting 4.2 are on the release wiki page [1].  Out of 98 features and 
improvement we have more than half of them in open state [2]. If you  are 
working on these items already please update the status appropriately. Given 
that we are roughly  three weeks away from feature freeze date and following 
our 4.1 convention please update feature progress in ticket by Wednesday every 
week.

We also have a comprehensive dashboard [3] for better visibility on how we are 
progressing on ACS 42. Please take a look and visit it often .


As for bugs here is a summary

Blocker (b)  | Critical (c) | Major (m) | Total 
(t)

Incoming Defects (last 7 days)  :7 b |  15 c | 29 m   | 54 t
-
Outgoing Defects (last 7 days)  :   5 b   |  7 c   | 13 m   | 25 t
-
Open Unassigned : 6 b | 19 c | 53 m| 89 t
-
Open Total  :   13 b | 52 c | 121 m | 207 t
-

We have a large number of unassigned and open defects, If you are interested in 
helping out on defects for specific components dashboard has a widget for that.


[1] http://s.apache.org/zCN
[2] http://s.apache.org/q8C
[3] http://s.apache.org/M5k

RE: "_Enhancer" Question

[Mice Xia]

Here is what I know about enhancer:

Enhancer is a term in cglib, an enhancer is a subclass of original class which 
'enhances' its functionality
In Cloudstack, enhancer (and interceptor) is used to implement aspect-oriented 
features, e.g, transaction, events framework..
Classes that implement ComponentMethodInterceptable are actually instantiated 
with their enhancers

You can check com.cloud.utils.component.ComponentInstantiationPostProcessor for 
details about how enhancer co-work with method interceptors.

And for interceptors:
ActionEventInterceptor : implement annotation-based event framework
TransactionContextBuilder: implement annotation-based transaction


Regards
Mice

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Thursday, May 09, 2013 12:37 PM
To: dev@cloudstack.apache.org
Subject: "_Enhancer" Question

Hi,

I was wondering if someone could explain to me the "_Enhancer" pattern we are 
using in CloudStack (below) and how this kind of class is created.

class
org.apache.cloudstack.storage.allocator.ZoneWideStoragePoolAllocator_EnhancerByCloudStack_4ff7ea3a

Thanks!

--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: [ACS42] Schedule Remember - Feature freeze on 2013-05-31

[Mike Tutkowski]

Hi Animesh,

I have a quick question for you.

As you know, I'm in the process of developing a storage plug-in for 4.2.

I'm working with Edison on getting some issues out of the storage framework
as well as completing the implementation of the plug-in.

Can you tell me how I should handle our situation in that we will likely be
close, but not quite there yet, as of May 31st?

Can we check in what we have (as long as we don't break functionality that
we're aware of) and then deal with remaining issues after?

Not sure exactly how the process works here.

Thanks!


On Wed, May 8, 2013 at 11:32 PM, Animesh Chaturvedi <
animesh.chaturv...@citrix.com> wrote:

> Folks
>
> I wanted to remind everyone about the 4.2 schedule for getting new
> features and improvements integrated into master. The window closes on
> 2013-05-31.
>
> The list of features and improvements that have been tagged in Jira as
> targeting 4.2 are on the release wiki page [1].  Out of 98 features and
> improvement we have more than half of them in open state [2]. If you  are
> working on these items already please update the status appropriately.
> Given that we are roughly  three weeks away from feature freeze date and
> following our 4.1 convention please update feature progress in ticket by
> Wednesday every week.
>
> We also have a comprehensive dashboard [3] for better visibility on how we
> are progressing on ACS 42. Please take a look and visit it often .
>
>
> As for bugs here is a summary
>
> Blocker (b)  | Critical (c) | Major (m) |
> Total (t)
>
> 
> Incoming Defects (last 7 days)  :7 b |  15 c | 29 m   | 54 t
>
> -
> Outgoing Defects (last 7 days)  :   5 b   |  7 c   | 13 m   | 25 t
>
> -
> Open Unassigned : 6 b | 19 c | 53 m| 89 t
>
> -
> Open Total  :   13 b | 52 c | 121 m | 207 t
>
> -
>
> We have a large number of unassigned and open defects, If you are
> interested in helping out on defects for specific components dashboard has
> a widget for that.
>
>
> [1] http://s.apache.org/zCN
> [2] http://s.apache.org/q8C
> [3] http://s.apache.org/M5k
>
>
>
>
>
>
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: "_Enhancer" Question

[Kelven Yang]

I've updated the wiki page for some background information on how we end
up current way of doing this.

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+Spring+in+Clou
dStack


Kelven

On 5/8/13 9:37 PM, "Mike Tutkowski"  wrote:

>Hi,
>
>I was wondering if someone could explain to me the "_Enhancer" pattern we
>are using in CloudStack (below) and how this kind of class is created.
>
>class
>org.apache.cloudstack.storage.allocator.ZoneWideStoragePoolAllocator_Enhan
>cerByCloudStack_4ff7ea3a
>
>Thanks!
>
>-- 
>*Mike Tutkowski*
>*Senior CloudStack Developer, SolidFire Inc.*
>e: mike.tutkow...@solidfire.com
>o: 303.746.7302
>Advancing the way the world uses the
>cloud
>**

Re: "_Enhancer" Question

[Kelven Yang]

Could someone help move the linked wiki page to root level in wiki?
although the work is done in Javelin branch, it now applies to all future
releases.

Kelven

On 5/8/13 11:14 PM, "Kelven Yang"  wrote:

>I've updated the wiki page for some background information on how we end
>up current way of doing this.
>
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+Spring+in+Clo
>u
>dStack
>
>
>Kelven
>
>On 5/8/13 9:37 PM, "Mike Tutkowski"  wrote:
>
>>Hi,
>>
>>I was wondering if someone could explain to me the "_Enhancer" pattern we
>>are using in CloudStack (below) and how this kind of class is created.
>>
>>class
>>org.apache.cloudstack.storage.allocator.ZoneWideStoragePoolAllocator_Enha
>>n
>>cerByCloudStack_4ff7ea3a
>>
>>Thanks!
>>
>>-- 
>>*Mike Tutkowski*
>>*Senior CloudStack Developer, SolidFire Inc.*
>>e: mike.tutkow...@solidfire.com
>>o: 303.746.7302
>>Advancing the way the world uses the
>>cloud
>>**
>