About Use Ceph by SharedMountPoint in Cloudstack

[Guangjian Liu]

I have question about Use Ceph by Primary storage SharedMountPoint in
Cloudstack.

I use Cloudstack 3.0.2 and CloudStack 4.0.1 for this validate, success
in  CloudStack 4.0.1, but fail in Cloudstack 3.0.2.

My question is does Cloudstack 3.0.2 support Ceph by SharedMountPoint?

KVM Server: ubuntu 12.04
Ceph version 0.56.4
Using library: libvirt 0.10.2
Using API: QEMU 0.10.2


-- 
Guangjian

Re: About Use Ceph by SharedMountPoint in Cloudstack

[Guangjian Liu]

when use cs 3.0.2, it show exception in CS log:

2013-04-28 16:29:28,293 WARN  [cloud.vm.VirtualMachineManagerImpl]
(AgentManager-Handler-7:null) Cleanup failed due to
java.lang.NullPointerException
at
com.cloud.hypervisor.kvm.storage.LibvirtStorageAdaptor.createStoragePool(LibvirtStorageAdaptor.java:462)
at
com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager.createStoragePool(KVMStoragePoolManager.java:57)
at
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.execute(LibvirtComputingResource.java:2087)
at
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1053)
at com.cloud.agent.Agent.processRequest(Agent.java:518)
at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:831)
at com.cloud.utils.nio.Task.run(Task.java:83)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:679)


On Sun, Apr 28, 2013 at 4:39 PM, Guangjian Liu  wrote:

>
> I have question about Use Ceph by Primary storage SharedMountPoint in
> Cloudstack.
>
> I use Cloudstack 3.0.2 and CloudStack 4.0.1 for this validate, success
> in  CloudStack 4.0.1, but fail in Cloudstack 3.0.2.
>
> My question is does Cloudstack 3.0.2 support Ceph by SharedMountPoint?
>
> KVM Server: ubuntu 12.04
> Ceph version 0.56.4
> Using library: libvirt 0.10.2
> Using API: QEMU 0.10.2
>
>
> --
> Guangjian
>



-- 
Guangjian

Re: Error starting management server

[Dharmesh Kakadia]

Anyone ?


On Sat, Apr 27, 2013 at 10:08 PM, Dharmesh Kakadia wrote:

> I found out the issue. I was behind the proxy and python was not able to
> bypass the local address. After unsetting proxy, I am able to add zones,
> pod and cluster. But while adding hosts I get following error:
>
> INFO  [cloud.resource.ResourceManagerImpl] (1793095672@qtp-165312501-9:)
> Trying to add a new host at http://192.168.56.10 in data center 1
> WARN  [cloud.resource.ResourceManagerImpl] (1793095672@qtp-165312501-9:)
> Unable to find the server resources at http://192.168.56.10
> INFO  [utils.exception.CSExceptionErrorCode] (1793095672@qtp-165312501-9:)
> Could not find exception: com.cloud.exception.DiscoveryException in error
> code list for exceptions
> WARN  [admin.host.AddHostCmd] (1793095672@qtp-165312501-9:) Exception:
> com.cloud.exception.DiscoveryException: Unable to add the host
> at
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:894)
> at
> com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:639)
> at
> org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:143)
> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:155)
> at com.cloud.api.ApiServer.queueCommand(ApiServer.java:512)
> at com.cloud.api.ApiServer.handleRequest(ApiServer.java:362)
> at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:304)
> at com.cloud.api.ApiServlet.doPost(ApiServlet.java:71)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> at
> org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
> at
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
> at
> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
> at
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
> at
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
> at
> org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
> at
> org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
> at
> org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
> at
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
> at org.mortbay.jetty.Server.handle(Server.java:326)
> at
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
> at
> org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:945)
> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:756)
> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
> at
> org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
> at
> org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
> INFO  [cloud.api.ApiServer] (1793095672@qtp-165312501-9:) Unable to add
> the host
>
> Host (192.168.56.10) and management servers are able to ping each other.
> Any pointers on what can be wrong ?
>
> Thanks,
> Dharmesh
>
>
> On Fri, Apr 26, 2013 at 7:33 PM, Prasanna Santhanam wrote:
>
>> On Fri, Apr 26, 2013 at 06:30:23PM +0530, Dharmesh Kakadia wrote:
>> > Hi,
>> >
>> > I have created bug
>> https://issues.apache.org/jira/browse/CLOUDSTACK-2211 as
>> > suggested by you.
>> > Being a newbie I was not sure how things are done in Apache Way.
>> Couldn't
>> > assign you the bug. Correct me if I missed something.
>>
>> That is the Apache Way ;) I'll pick it up and add some logs for you
>> soon. Thanks for your patience. You should be able to proceed with the
>> UI Wizard in the meantime to setup your zones.
>>
>>
>> --
>> Prasanna.,
>>
>> 
>> Powered by BigRock.com
>>
>>
>

Re: [DOCS][TRANSLATIONS] Upate

[Isaac Chiang]

Hi all:
The Glossary function on Transifex is quite awesome. I captured
some screenshots for it.

http://i.imgur.com/WPOcVsI.png

The link above is the Glossary page on Transifex, we can add new term here.

We need to determine this term is a noun, verb or something else (There is
a combo box for it ) and corresponding translation. We can also add some
comment of it (Avoid misunderstanding if you're co-working with someone).

When you are translating on the page(link below), and if you select the the
"Glossary" tab, the glossary tab window will show the added terms
associated to the sentence you are translating as a hint.

http://i.imgur.com/GqD07pn.png

The function can avoid inconsistent problem and better started in the
beginning of translation. I am too late for discovering this function. So
the zh_TW's document got lots of inconsistent translation problem. And I'm
now rebuilding the dictionary  :(

For your information and happy translating! :D

Regards

Isaac






On Wed, Apr 24, 2013 at 4:20 PM, Sebastien Goasguen wrote:

>
> On Apr 24, 2013, at 4:18 AM, Isaac Chiang  wrote:
>
> > I Get it :)  I'll investigate this function deeper to see how it can help
> > us.
>
> Terrific, I was hoping you would say that :)
>
> >
> > Many thanks.
> >
> > Isaac
> >
> >
> > On Wed, Apr 24, 2013 at 4:11 PM, Sebastien Goasguen  >wrote:
> >
> >>
> >> On Apr 24, 2013, at 3:58 AM, Isaac Chiang 
> wrote:
> >>
> >>> Hi Sebastien:
> >>>
> >>>   Thanks!! I see the "View glossary" button just right at the
> >>> upper right corner of the table in this page:
> >>>
> >>> https://www.transifex.com/projects/p/ACS_DOCS/
> >>>
> >>> After entering the glossary page, I am able to select language for
> >> glossary
> >>> and add new term.
> >>>
> >>> So I'm wondering if this glossary table will be appended to the
> document
> >> or
> >>> it just provide the hint
> >>>
> >>> when we're translating?
> >>
> >> We are not using it:
> >>
> >> http://help.transifex.com/features/glossary.html
> >>
> >> However we could to insure consistency of the translations between
> >> translators of the same language.
> >>
> >>
> >>>
> >>> Regards
> >>>
> >>>
> >>> Isaac
> >>>
> >>>
> >>>
> >>>
> >>> On Wed, Apr 24, 2013 at 3:21 PM, Sebastien Goasguen  >>> wrote:
> >>>
> 
>  On Apr 23, 2013, at 10:17 PM, Isaac Chiang 
> >> wrote:
> 
> > Hi all:
> > I have a few questions and looking for help. After the documents
> > have been translated, can I use Transifex to review these documents?
>  Cause
> > I noticed that some of the terminology aren't consistent during the
> > translation and the language sources are too large for me to handling
> >> the
> > review process. So I'm wondering if it is possible for a normal user
> in
> > Transifex to mark the sentence as reviewed and prevent from reviewing
> >> it
> > twice?
> 
>  Isaac, considering you translated 95% of the documentation in zh-TW I
> >> made
>  you a maintainer of the ACS_DOCS
>  You should be able to review your own translations, string by string.
> >
> > Another question is about the glossary, is it part of translation
> >> program
> > or a assistant mechanism to support translation?
> 
>  Don't know, I have never looked at the glossary. Where do you see it ?
> 
> >
> > Thanks & best regards
> >
> > Isaac
> >
> >
> > On Tue, Apr 23, 2013 at 9:50 PM, Gavin Lee 
> >> wrote:
> >
> >> Following Milamber's guide , below process I used for
> >> 4.1.xmessage.properties on zh_CN:
> >> 1. git pull for the latest messages_zh_CN.properties
> >> 2. native2ascii -reverse messages_zh_CN.properties
> >> /tmp/zh_CN.properties.native -encoding utf8
> >> 3. copy to the CloudStack_UI transifex project:
> >> cp/tmp/zh_CN.properties.native /
> >> txprj/acsui/translations/CloudStack_UI.41xmessageproperties
> >> 4. tx push -l zh_CN -r CloudStack_UI.41xmessageproperties -t
> >> 5. Do translation on transifex, there are some untranslated items
> when
> >> syncing with en.properties
> >> 6. tx pull -a
> >>
> >>
> >> Then convert to ascii with unicode, the i18nedit tools throws
>  exception, I
> >> tried native2ascii command as below and UI display correctly:
> >> native2ascii -encoding UTF-8 zh_CN.properties
> >> messages_zh_CN.properties
> >>
> >> Are the whole processes above correct or not?
> >>
> >>
> >>
> >>
> >> On Tue, Apr 23, 2013 at 12:01 AM, Sebastien Goasguen <
> >> run...@gmail.com
> >>> wrote:
> >>
> >>> Milamber, I made you a manager of the transifex project so you can
> >> help
> >>> fixing those issues.
> >>>
> >>> -sebastien
> >>>
> >>> On Apr 22, 2013, at 11:10 AM, Milamber 
> wrote:
> >>>
> 
> 
>  Le 17/04/2013 07:26, Sebastien Goasguen a ecrit :
> > On Apr 16, 2013, at 11:10 AM, Milamber
> >> wrote:

Re: About Use Ceph by SharedMountPoint in Cloudstack

[Wido den Hollander]

Hi,

On 04/28/2013 10:39 AM, Guangjian Liu wrote:

I have question about Use Ceph by Primary storage SharedMountPoint in
Cloudstack.



The CephFS POSIX filesytem isn't production ready yet, so that's a 
reason for not doing this.


Also, RBD is the recommend setup for running Virtual Machines from a 
Ceph cluster, it gives you snapshots and cloning (Coming in CloudStack 
4.2) and much better performance than CephFS.


I would never recommend running virtual machines from CephFS when you 
are also able to use RBD.


Wido


I use Cloudstack 3.0.2 and CloudStack 4.0.1 for this validate, success
in  CloudStack 4.0.1, but fail in Cloudstack 3.0.2.

My question is does Cloudstack 3.0.2 support Ceph by SharedMountPoint?

KVM Server: ubuntu 12.04
Ceph version 0.56.4
Using library: libvirt 0.10.2
Using API: QEMU 0.10.2

Re: [GSoC] Introduction and Project Discussion

[Shiva Teja]

Hi Rohit,

I think you made my work a lot easier :) I can use code from cloudmonkey to
generate API cache and then build the code for the wrapper using it.

I might need some information on this. How would a RESTful CloudStack API
look like ? If I get these basic rules, I am guessing it shouldn't be tough
to generate the wrapper.

Here's a very basic idea. I am using the same terminology used in
cloudmonkey. In "listUsers", users is subject and list is the verb.
In most of the cases the URL for an API command can be something like
"baseurl/subject/verb" with an appropriately chosen HTTP method based on
the verb. For some "verbs" like list, get, update, delete, add, it doesn't
make sense to have them in the URL and using the appropriate HTTP method
would mean the same. So I'll have to write the rules for each verb. These
rules might contain method to be used for the verb, should the verb be in
the URL or not...etc. And use these rules to generate the wrapper.

I am trying to decide these rules, so that they don't deviate from the
point of being a RESTful API. Will get back with final implementation
details before I finish my application for GSoC.

Regard,
Shiva Teja(irc: teja)


On Sat, Apr 27, 2013 at 10:14 PM, Rohit Yadav  wrote:

> Hi Shiva,
>
> On Sat, Apr 27, 2013 at 1:29 AM, Shiva Teja  wrote:
>
> > Hi all,
> >
> > I am Shiva Teja, an undergrad student from IIT Mandi, India. I will be
> > participating in GSoC this year. I'd like to work on the new CloudStack
> UI
> > with bootstrap project[1]. I've been experimenting with API for the past
> > few days. After reading a couple of blog posts by Sebastien, his recent
> > hack on this[2] and a recent discussion[3] on the mailing list about
> making
> > CloudStack API RESTfull, here are the things I plan to do.
> >
>
> Have you started working on your plan or just proposing? Hope you have a
> setup and tried CloudStack on DevCloud. For starters I suggest you to
> download, build and deploy CloudStack, play around APIs, cloudmonkey (a
> CLI) and the API Discovery service because both of your idea proposals are
> around APIs.
>
> 1. A more "human", RESTfull wrapper API on top of CloudStack API using
> > Flask python framework. Something like "GET /users" will directly
> > correspond to "listUsers" API command. "DELETE /user/" will
> correspond
> > to the respective "deleteUser" API call.
> >
>
> It's tricky, first you should get a full list of entities. It's a lot of
> hard work if you do it manually but you can do smartly if you use Api
> Discovery. There are more than 300+ APIs in CloudStack, now groupped as per
> entities (see a package like org.apache.cloudstack.api.. class>).
>
> So, first you need to classify the entities, get it checked (like write
> tests) and then define these operations. Few of us are inclined towards
> rewriting an API server that is RESTful and not query based. The challenge
> there is to reuse present cmd classes, one way is to use reflections and
> another round of api annotations refactoring. Easiest way would be to just
> fix/add/reuse Api Discovery, or write something use metaprogamming that
> auto generates your wrapper.
>
> I'm floating these ideas so you can think about it and come up with a
> strategy that creates maintainable, extendable code which would require
> less time to implement it.
>
> 2. A complete UI designed using Twitter Bootstrap and Backbone.js.
> > Obviously this will use the API that I'll be making.
> >
>
> +1 This is a fantastic idea, a better, faster, modular UI that is
> responsive is much appreciated and we will have an alternative to the
> default one.
>
> Avoid sending direct emails to anyone and feel free to reach out to the dev
> ML, email like a boss™.
>
> Happy hacking!
>
> Cheers.
>
> (An app made using Bootstrap and Backbone.js:
> > http://coenraets.org/directory/ )
> >
> > Any suggestions/comments ?
> >
> > [1] https://issues.apache.org/jira/browse/CLOUDSTACK-1778
> > [2] https://github.com/runseb/cloudstack-flask
> > [3]
> >
> >
> http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201304.mbox/%3C20130424083847.GA11354%40cloud-2.local%3E
> >
> > Thanks,
> > Shiva Teja.
> >
>

Review Request: Automation: CPU limits tests from Resource Limits Tests

[Chirag Jog]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10828/
---

Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.


Description
---

Here is the detailed test plan: 
https://issues.apache.org/jira/secure/attachment/12571551/LimitResourcesTestPlan1.xlsx


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1466.


Diffs
-

  test/integration/component/test_cpu_limits.py PRE-CREATION 

Diff: https://reviews.apache.org/r/10828/diff/


Testing
---


Thanks,

Chirag Jog

Re: CloudStack GitHub repository

[Joe Brockmeier]

Noah, I opened a bug on this weeks ago, and had reported to the mailing
list. 

https://issues.apache.org/jira/browse/INFRA-6130

On Sat, Apr 27, 2013, at 11:28 AM, Noah Slater wrote:
> Devs,
> 
> I have requested that our GitHub repository be moved to indicate we are
> no
> longer in incubation.
> 
> Follow along here:
> 
> https://issues.apache.org/jira/browse/INFRA-6203
> 
> Thanks,
> 
> -- 
> NS


Best,

jzb
-- 
Joe Brockmeier
j...@zonker.net
Twitter: @jzb
http://www.dissociatedpress.net/

[MERGE] CS-2163

[Nitin Mehta]

I would like to merge the feature which will add the ability in CS so that the 
user can have better control over first class objects in CS

- The feature can be found in the branch cs-2163 and has been rebased with 
master.
- Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-2163
- The FS can be found @ 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Ability+to+have+better+control+over+first+class+objects+in+CS
- I have added the unit tests and marvin tests as well.
- I ran the RAT check as well with no failures.

Thanks,
Nitin

Re: Error starting management server

[Prasanna Santhanam]

On Sat, Apr 27, 2013 at 10:08:22PM +0530, Dharmesh Kakadia wrote:
> I found out the issue. I was behind the proxy and python was not able to
> bypass the local address. After unsetting proxy, I am able to add zones,
> pod and cluster. But while adding hosts I get following error:

Ah - should've noticed the university in the email :)
Can you update your bugreport to include proxy support in the CLI and marvin? 

For the host exception, can you check if your devcloud VM has the XAPI
service running?  xcp-xapi?

> 
> INFO  [cloud.resource.ResourceManagerImpl] (1793095672@qtp-165312501-9:)
> Trying to add a new host at http://192.168.56.10 in data center 1
> WARN  [cloud.resource.ResourceManagerImpl] (1793095672@qtp-165312501-9:)
> Unable to find the server resources at http://192.168.56.10
> INFO  [utils.exception.CSExceptionErrorCode] (1793095672@qtp-165312501-9:)
> Could not find exception: com.cloud.exception.DiscoveryException in error
> code list for exceptions
> WARN  [admin.host.AddHostCmd] (1793095672@qtp-165312501-9:) Exception:
> com.cloud.exception.DiscoveryException: Unable to add the host
> at
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:894)
> at
> com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:639)
> at
> org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:143)
> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:155)
> at com.cloud.api.ApiServer.queueCommand(ApiServer.java:512)
> at com.cloud.api.ApiServer.handleRequest(ApiServer.java:362)
> at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:304)
> at com.cloud.api.ApiServlet.doPost(ApiServlet.java:71)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> at
> org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
> at
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
> at
> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
> at
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
> at
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
> at
> org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
> at
> org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
> at
> org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
> at
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
> at org.mortbay.jetty.Server.handle(Server.java:326)
> at
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
> at
> org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:945)
> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:756)
> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
> at
> org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
> at
> org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
> INFO  [cloud.api.ApiServer] (1793095672@qtp-165312501-9:) Unable to add the
> host
> 
> Host (192.168.56.10) and management servers are able to ping each other.
> Any pointers on what can be wrong ?
> 
> Thanks,
> Dharmesh
> 
> 
> On Fri, Apr 26, 2013 at 7:33 PM, Prasanna Santhanam  wrote:
> 
> > On Fri, Apr 26, 2013 at 06:30:23PM +0530, Dharmesh Kakadia wrote:
> > > Hi,
> > >
> > > I have created bug https://issues.apache.org/jira/browse/CLOUDSTACK-2211as
> > > suggested by you.
> > > Being a newbie I was not sure how things are done in Apache Way. Couldn't
> > > assign you the bug. Correct me if I missed something.
> >
> > That is the Apache Way ;) I'll pick it up and add some logs for you
> > soon. Thanks for your patience. You should be able to proceed with the
> > UI Wizard in the meantime to setup your zones.
> >
> >
> > --
> > Prasanna.,
> >
> > 
> > Powered by BigRock.com
> >
> >

-- 
Prasanna.,


Powered by BigRock.com

Re: Review Request: Automation tests for reset ssh key for access to VM

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10335/#review19840
---


Any updates the the diff you sent through?

- Prasanna Santhanam


On April 8, 2013, 11:30 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10335/
> ---
> 
> (Updated April 8, 2013, 11:30 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Harikrishna Patnala.
> 
> 
> Description
> ---
> 
> Automation tests for Reset SSH key for access to VM 
> https://issues.apache.org/jira/browse/CLOUDSTACK-1800
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_reset_ssh_keypair.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10335/diff/
> 
> 
> Testing
> ---
> 
> Done.
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Error starting management server

[Dharmesh Kakadia]

I have updated the bug report. xapi is listening on devcloud host. "xe
vm-list" shows the control domain running. Anything that you think is wrong
?

Thanks,
Dharmesh


On Mon, Apr 29, 2013 at 9:54 AM, Prasanna Santhanam  wrote:

> On Sat, Apr 27, 2013 at 10:08:22PM +0530, Dharmesh Kakadia wrote:
> > I found out the issue. I was behind the proxy and python was not able to
> > bypass the local address. After unsetting proxy, I am able to add zones,
> > pod and cluster. But while adding hosts I get following error:
>
> Ah - should've noticed the university in the email :)
> Can you update your bugreport to include proxy support in the CLI and
> marvin?
>
> For the host exception, can you check if your devcloud VM has the XAPI
> service running?  xcp-xapi?
>
> >
> > INFO  [cloud.resource.ResourceManagerImpl] (1793095672@qtp-165312501-9:)
> > Trying to add a new host at http://192.168.56.10 in data center 1
> > WARN  [cloud.resource.ResourceManagerImpl] (1793095672@qtp-165312501-9:)
> > Unable to find the server resources at http://192.168.56.10
> > INFO  [utils.exception.CSExceptionErrorCode] (1793095672@qtp-165312501-9
> :)
> > Could not find exception: com.cloud.exception.DiscoveryException in error
> > code list for exceptions
> > WARN  [admin.host.AddHostCmd] (1793095672@qtp-165312501-9:) Exception:
> > com.cloud.exception.DiscoveryException: Unable to add the host
> > at
> >
> com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:894)
> > at
> >
> com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:639)
> > at
> >
> org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:143)
> > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:155)
> > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:512)
> > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:362)
> > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:304)
> > at com.cloud.api.ApiServlet.doPost(ApiServlet.java:71)
> > at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
> > at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> > at
> > org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
> > at
> > org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
> > at
> >
> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
> > at
> > org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
> > at
> > org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
> > at
> > org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
> > at
> >
> org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
> > at
> >
> org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
> > at
> > org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
> > at org.mortbay.jetty.Server.handle(Server.java:326)
> > at
> > org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
> > at
> >
> org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:945)
> > at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:756)
> > at
> org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
> > at
> org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
> > at
> >
> org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
> > at
> >
> org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
> > INFO  [cloud.api.ApiServer] (1793095672@qtp-165312501-9:) Unable to add
> the
> > host
> >
> > Host (192.168.56.10) and management servers are able to ping each other.
> > Any pointers on what can be wrong ?
> >
> > Thanks,
> > Dharmesh
> >
> >
> > On Fri, Apr 26, 2013 at 7:33 PM, Prasanna Santhanam 
> wrote:
> >
> > > On Fri, Apr 26, 2013 at 06:30:23PM +0530, Dharmesh Kakadia wrote:
> > > > Hi,
> > > >
> > > > I have created bug
> https://issues.apache.org/jira/browse/CLOUDSTACK-2211as
> > > > suggested by you.
> > > > Being a newbie I was not sure how things are done in Apache Way.
> Couldn't
> > > > assign you the bug. Correct me if I missed something.
> > >
> > > That is the Apache Way ;) I'll pick it up and add some logs for you
> > > soon. Thanks for your patience. You should be able to proceed with the
> > > UI Wizard in the meantime to setup your zones.
> > >
> > >
> > > --
> > > Prasanna.,
> > >
> > > 
> > > Powered by BigRock.com
> > >
> > >
>
> --
> Prasanna.,
>
> 
> Powered by BigRock.com
>
>

Re: [GSoC] Introduction and Project Discussion

[Rohit Yadav]

On Mon, Apr 29, 2013 at 1:53 AM, Shiva Teja  wrote:

> Hi Rohit,
>
> I think you made my work a lot easier :) I can use code from cloudmonkey to
> generate API cache and then build the code for the wrapper using it.
>
> I might need some information on this. How would a RESTful CloudStack API
> look like ?


This is a hard issue because the challenge is not just to implement
something, but something that will be maintainable. Your APIs are your
interface or contract to the outside world so once you give away your spec
to the outside world, you've the burden to keep backward compatibility and
not mess up when you do any kind of refactoring.

Some general rules I see are; all entities are nouns, the verbs are not
part of the url but how you call them; so list/read would be GET, create
would be POST, update would be PUT, remove/del would be DELETE... that said
you can create your own X- headers to mean something. People have written
books, gave talk on how to write good RESTful APIs.


> If I get these basic rules, I am guessing it shouldn't be tough
> to generate the wrapper.
>

The implementation won't be tough, but getting it right would be. Right now
I'm just splitting the apiname at the camelCase's hump in cloudmonkey, so
camel becomes a command and Case becomes the entity.


>
> Here's a very basic idea. I am using the same terminology used in
> cloudmonkey. In "listUsers", users is subject and list is the verb.
> In most of the cases the URL for an API command can be something like
> "baseurl/subject/verb" with an appropriately chosen HTTP method based on
> the verb. For some "verbs" like list, get, update, delete, add, it doesn't
> make sense to have them in the URL and using the appropriate HTTP method
> would mean the same. So I'll have to write the rules for each verb. These
> rules might contain method to be used for the verb, should the verb be in
> the URL or not...etc. And use these rules to generate the wrapper.
>

It's not straight forward, for example create/add/generate are few words in
apis which would be GET Apis in restful terms. One way would be to manually
sort/group the apis, other would be to annotate each api with an entity
name, RESTful type {one of GET, POST, PUT etc.} and parent (For example,
/zone/pod/cluster makes sense?).


> I am trying to decide these rules, so that they don't deviate from the
> point of being a RESTful API. Will get back with final implementation
> details before I finish my application for GSoC.
>

Lastly, talk to Sebastien or someone who would is participating in GSoC as
a mentor because it's important to identify who would mentor you if they
would, best of luck.

Cheers.
I'm skipping applying to being a GSoC mentor this year, pissed off from
GSoC admins this year. FOSS is just going to dogs; fck they did not include
one project that has no real company to back its development and really
needs help; VideoLAN/VLC.



> Regard,
> Shiva Teja(irc: teja)
>
>
> On Sat, Apr 27, 2013 at 10:14 PM, Rohit Yadav  wrote:
>
> > Hi Shiva,
> >
> > On Sat, Apr 27, 2013 at 1:29 AM, Shiva Teja 
> wrote:
> >
> > > Hi all,
> > >
> > > I am Shiva Teja, an undergrad student from IIT Mandi, India. I will be
> > > participating in GSoC this year. I'd like to work on the new CloudStack
> > UI
> > > with bootstrap project[1]. I've been experimenting with API for the
> past
> > > few days. After reading a couple of blog posts by Sebastien, his recent
> > > hack on this[2] and a recent discussion[3] on the mailing list about
> > making
> > > CloudStack API RESTfull, here are the things I plan to do.
> > >
> >
> > Have you started working on your plan or just proposing? Hope you have a
> > setup and tried CloudStack on DevCloud. For starters I suggest you to
> > download, build and deploy CloudStack, play around APIs, cloudmonkey (a
> > CLI) and the API Discovery service because both of your idea proposals
> are
> > around APIs.
> >
> > 1. A more "human", RESTfull wrapper API on top of CloudStack API using
> > > Flask python framework. Something like "GET /users" will directly
> > > correspond to "listUsers" API command. "DELETE /user/" will
> > correspond
> > > to the respective "deleteUser" API call.
> > >
> >
> > It's tricky, first you should get a full list of entities. It's a lot of
> > hard work if you do it manually but you can do smartly if you use Api
> > Discovery. There are more than 300+ APIs in CloudStack, now groupped as
> per
> > entities (see a package like org.apache.cloudstack.api.. > class>).
> >
> > So, first you need to classify the entities, get it checked (like write
> > tests) and then define these operations. Few of us are inclined towards
> > rewriting an API server that is RESTful and not query based. The
> challenge
> > there is to reuse present cmd classes, one way is to use reflections and
> > another round of api annotations refactoring. Easiest way would be to
> just
> > fix/add/reuse Api Discovery, or write something use metaprogamming that
> > auto ge

Re: Review Request: Multiple IP Ranges Support in CloudStack

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/
---

(Updated April 29, 2013, 5:35 a.m.)


Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Changes
---

Combined three patches into one patch


Description
---

Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple 
IP Ranges" support in CloudStack.


This addresses bug CLOUDSTACK-702.


Diffs (updated)
-

  test/integration/component/test_multiple_ip_ranges.py PRE-CREATION 

Diff: https://reviews.apache.org/r/10792/diff/


Testing
---


Thanks,

sanjeev n

Re: Error starting management server

[Prasanna Santhanam]

On Mon, Apr 29, 2013 at 10:36:48AM +0530, Dharmesh Kakadia wrote:
> I have updated the bug report. xapi is listening on devcloud host. "xe
> vm-list" shows the control domain running. Anything that you think is wrong
> ?
> 
Has your devcloudVM come up with the NIC (192.168.56.10)? What does
ifconfig -a show for xenbr0 and xenbr1?
 
-- 
Prasanna.,


Powered by BigRock.com

Re: Error starting management server

[Dharmesh Kakadia]

This is xenbr0 and xenbr1.

xenbr0Link encap:Ethernet  HWaddr 08:00:27:9b:32:00
  inet addr:192.168.56.10  Bcast:192.168.56.255  Mask:255.255.255.0
  inet6 addr: fe80::a00:27ff:fe9b:3200/64 Scope:Link
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:738 errors:0 dropped:0 overruns:0 frame:0
  TX packets:336 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:0
  RX bytes:146760 (143.3 KiB)  TX bytes:37974 (37.0 KiB)

xenbr1Link encap:Ethernet  HWaddr 08:00:27:19:f1:58
  inet addr:10.0.3.15  Bcast:10.0.3.255  Mask:255.255.255.0
  inet6 addr: fe80::a00:27ff:fe19:f158/64 Scope:Link
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:12 errors:0 dropped:0 overruns:0 frame:0
  TX packets:213 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:0
  RX bytes:1945 (1.8 KiB)  TX bytes:18602 (18.1 KiB)

eth0 and eth1 does not have IPs assigned.

Thanks,
Dharmesh


On Mon, Apr 29, 2013 at 11:05 AM, Prasanna Santhanam  wrote:

> On Mon, Apr 29, 2013 at 10:36:48AM +0530, Dharmesh Kakadia wrote:
> > I have updated the bug report. xapi is listening on devcloud host. "xe
> > vm-list" shows the control domain running. Anything that you think is
> wrong
> > ?
> >
> Has your devcloudVM come up with the NIC (192.168.56.10)? What does
> ifconfig -a show for xenbr0 and xenbr1?
>
> --
> Prasanna.,
>
> 
> Powered by BigRock.com
>
>

Re: Review Request: Multiple IP Ranges Support in CloudStack

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/#review19842
---

Ship it!


commit b2fdd5e2a23b44e5976c7135632d1ca6ade57663
Author: sanjeevneelarapu 
Date:   Fri Apr 26 17:10:37 2013 +0530

CLOUDSTACK-702: Tests for Multiple IP Ranges

1. Adding a cidr in existing subnet
2. Adding a cidr in new subnet

Signed-off-by: sanjeevneelarapu 
Signed-off-by: Prasanna Santhanam 


- Prasanna Santhanam


On April 29, 2013, 5:35 a.m., sanjeev n wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10792/
> ---
> 
> (Updated April 29, 2013, 5:35 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao 
> Talluri.
> 
> 
> Description
> ---
> 
> Adding two test cases(Adding guest CIDR in same and diff subnet) for 
> "Multiple IP Ranges" support in CloudStack.
> 
> 
> This addresses bug CLOUDSTACK-702.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_multiple_ip_ranges.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10792/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> sanjeev n
> 
>

Re: Error starting management server

[Prasanna Santhanam]

That looks fine too. I have a silly question:

1. Does your internal univ. subnet conflict with 192.168.x.y? Is it
contacting a different machine perhaps?

2. Is the devcloudVM on the same host as your codebase from where you
run mvn?

If no, can you get on IRC #cloudstack? 

-- 
Prasanna.,

On Mon, Apr 29, 2013 at 11:10:41AM +0530, Dharmesh Kakadia wrote:
> This is xenbr0 and xenbr1.
> 
> xenbr0Link encap:Ethernet  HWaddr 08:00:27:9b:32:00
>   inet addr:192.168.56.10  Bcast:192.168.56.255  Mask:255.255.255.0
>   inet6 addr: fe80::a00:27ff:fe9b:3200/64 Scope:Link
>   UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
>   RX packets:738 errors:0 dropped:0 overruns:0 frame:0
>   TX packets:336 errors:0 dropped:0 overruns:0 carrier:0
>   collisions:0 txqueuelen:0
>   RX bytes:146760 (143.3 KiB)  TX bytes:37974 (37.0 KiB)
> 
> xenbr1Link encap:Ethernet  HWaddr 08:00:27:19:f1:58
>   inet addr:10.0.3.15  Bcast:10.0.3.255  Mask:255.255.255.0
>   inet6 addr: fe80::a00:27ff:fe19:f158/64 Scope:Link
>   UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
>   RX packets:12 errors:0 dropped:0 overruns:0 frame:0
>   TX packets:213 errors:0 dropped:0 overruns:0 carrier:0
>   collisions:0 txqueuelen:0
>   RX bytes:1945 (1.8 KiB)  TX bytes:18602 (18.1 KiB)
> 
> eth0 and eth1 does not have IPs assigned.
> 
> Thanks,
> Dharmesh
> 
> 
> On Mon, Apr 29, 2013 at 11:05 AM, Prasanna Santhanam  wrote:
> 
> > On Mon, Apr 29, 2013 at 10:36:48AM +0530, Dharmesh Kakadia wrote:
> > > I have updated the bug report. xapi is listening on devcloud host. "xe
> > > vm-list" shows the control domain running. Anything that you think is
> > wrong
> > > ?
> > >
> > Has your devcloudVM come up with the NIC (192.168.56.10)? What does
> > ifconfig -a show for xenbr0 and xenbr1?
> >
> > --
> > Prasanna.,
> >
> > 
> > Powered by BigRock.com
> >
> >



Powered by BigRock.com

Re: Review Request: Automation tests to qualify user provided hostname feature.

[Prasanna Santhanam]

> On April 26, 2013, 10:42 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_custom_hostname.py, line 265
> > 
> >
> > How's this test different from the previous one? Should the setting be 
> > false? It looks like you are testing for the negative result?
> 
> Girish Shilamkar wrote:
> The flag is true but we don't provide the hostname so it should pick up 
> the configured instance name. There are different set of tests where flag is 
> false.

I see now in the comments. Can you change the names of the tests thus?
test_01_user_provided_hostname(self)
"""Test for user provided hostname to an instance
"""

test_02_instancename_from_default_configuration(self)
"""Test for globally set instancename 
"""

When the tests are run it is hard to distinguish between the tests without this 
information from the logs output by our testrunner..


- Prasanna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10793/#review19762
---


On April 26, 2013, 7:14 p.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10793/
> ---
> 
> (Updated April 26, 2013, 7:14 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao 
> Talluri.
> 
> 
> Description
> ---
> 
> Automation tests to qualify User provides hostname feature.
> 1. Defines services class
> 2. Test to verify custom hostname for the instance with internal name
> 3. Test to verify custom hostname for the instance without internal name
> 
> 
> This addresses bug CLOUDSTACK-778.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_custom_hostname.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10793/diff/
> 
> 
> Testing
> ---
> 
> Tested and works fine.
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request: Automation: CPU limits tests from Resource Limits Tests

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10828/#review19844
---



test/integration/component/test_cpu_limits.py


ASF license header is missing.



test/integration/component/test_cpu_limits.py


detect from cls.get_zone().networktype? This should prevent it from being 
reqd in the settings.



test/integration/component/test_cpu_limits.py


Is the entire suite skipped? Can the tests in this suite be run as they are?


- Prasanna Santhanam


On April 29, 2013, 2:29 a.m., Chirag Jog wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10828/
> ---
> 
> (Updated April 29, 2013, 2:29 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> ---
> 
> Here is the detailed test plan: 
> https://issues.apache.org/jira/secure/attachment/12571551/LimitResourcesTestPlan1.xlsx
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1466.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chirag Jog
> 
>

Re: Review Request: Adding more Granular Global Parameters

[Harikrishna Patnala]

> On April 28, 2013, 6:49 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/Config.java, line 56
> > 
> >
> > Where is the actual change for this config in the code ? It should have 
> > been AlertManagerImpl I guess

Yes it's AlertManagerImpl and I have changed it while checking for alerts.


- Harikrishna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/#review19830
---


On April 26, 2013, 5:31 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10740/
> ---
> 
> (Updated April 26, 2013, 5:31 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin 
> Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-741: Granular Global Parameters
> Adding the zone, cluster, account level parameters:
> zone: network.throttling.rate, Guest Domain Prefix
> cluster: cluster.cpu.allocated.capacity.disablethreshold, 
> cluster.cpu.allocated.capacity.notificationthreshold, 
> cluster.memory.allocated.capacity.disablethreshold, 
> cluster.memory.allocated.capacity.notificationthreshold
> account:  allow.public.user.templates, remote.access.vpn.client.iprange  
> 
> 
> This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and 
> CLOUDSTACK-741.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
>   api/src/com/cloud/network/NetworkModel.java 4d7d714 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 
> 9f34405 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 
> 074c5a3 
>   api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 
> 176c47a 
>   server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
>   server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
>   server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
>   server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
>   server/src/com/cloud/configuration/Config.java dbcbc53 
>   server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
>   server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
>   server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
>   server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
>   server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
>   server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
>   server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
>   server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
>   server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
>   server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
>   server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
>   
> server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java 
> fb29469 
>   
> server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java 
> f1163ef 
>   setup/db/db/schema-410to420.sql 78444fd 
>   test/integration/smoke/test_global_settings.py 12b35d7 
> 
> Diff: https://reviews.apache.org/r/10740/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: Adding more Granular Global Parameters

[Abhinandan Prateek]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/#review19847
---

Ship it!


Ship It!

- Abhinandan Prateek


On April 26, 2013, 5:31 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10740/
> ---
> 
> (Updated April 26, 2013, 5:31 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin 
> Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-741: Granular Global Parameters
> Adding the zone, cluster, account level parameters:
> zone: network.throttling.rate, Guest Domain Prefix
> cluster: cluster.cpu.allocated.capacity.disablethreshold, 
> cluster.cpu.allocated.capacity.notificationthreshold, 
> cluster.memory.allocated.capacity.disablethreshold, 
> cluster.memory.allocated.capacity.notificationthreshold
> account:  allow.public.user.templates, remote.access.vpn.client.iprange  
> 
> 
> This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and 
> CLOUDSTACK-741.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
>   api/src/com/cloud/network/NetworkModel.java 4d7d714 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 
> 9f34405 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 
> 074c5a3 
>   api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 
> 176c47a 
>   server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
>   server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
>   server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
>   server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
>   server/src/com/cloud/configuration/Config.java dbcbc53 
>   server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
>   server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
>   server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
>   server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
>   server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
>   server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
>   server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
>   server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
>   server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
>   server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
>   server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
>   
> server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java 
> fb29469 
>   
> server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java 
> f1163ef 
>   setup/db/db/schema-410to420.sql 78444fd 
>   test/integration/smoke/test_global_settings.py 12b35d7 
> 
> Diff: https://reviews.apache.org/r/10740/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: [GSoC] Introduction and Project Discussion

[Shiva Teja]

This probably needs of lot of discussion. For now, I'll stick to basics and
concentrate more on the UI. Thanks for the help.

Regards,
Shiva Teja.


On Mon, Apr 29, 2013 at 10:45 AM, Rohit Yadav  wrote:

> On Mon, Apr 29, 2013 at 1:53 AM, Shiva Teja  wrote:
>
> > Hi Rohit,
> >
> > I think you made my work a lot easier :) I can use code from cloudmonkey
> to
> > generate API cache and then build the code for the wrapper using it.
> >
> > I might need some information on this. How would a RESTful CloudStack API
> > look like ?
>
>
> This is a hard issue because the challenge is not just to implement
> something, but something that will be maintainable. Your APIs are your
> interface or contract to the outside world so once you give away your spec
> to the outside world, you've the burden to keep backward compatibility and
> not mess up when you do any kind of refactoring.
>
> Some general rules I see are; all entities are nouns, the verbs are not
> part of the url but how you call them; so list/read would be GET, create
> would be POST, update would be PUT, remove/del would be DELETE... that said
> you can create your own X- headers to mean something. People have written
> books, gave talk on how to write good RESTful APIs.
>
>
> > If I get these basic rules, I am guessing it shouldn't be tough
> > to generate the wrapper.
> >
>
> The implementation won't be tough, but getting it right would be. Right now
> I'm just splitting the apiname at the camelCase's hump in cloudmonkey, so
> camel becomes a command and Case becomes the entity.
>
>
> >
> > Here's a very basic idea. I am using the same terminology used in
> > cloudmonkey. In "listUsers", users is subject and list is the verb.
> > In most of the cases the URL for an API command can be something like
> > "baseurl/subject/verb" with an appropriately chosen HTTP method based on
> > the verb. For some "verbs" like list, get, update, delete, add, it
> doesn't
> > make sense to have them in the URL and using the appropriate HTTP method
> > would mean the same. So I'll have to write the rules for each verb. These
> > rules might contain method to be used for the verb, should the verb be in
> > the URL or not...etc. And use these rules to generate the wrapper.
> >
>
> It's not straight forward, for example create/add/generate are few words in
> apis which would be GET Apis in restful terms. One way would be to manually
> sort/group the apis, other would be to annotate each api with an entity
> name, RESTful type {one of GET, POST, PUT etc.} and parent (For example,
> /zone/pod/cluster makes sense?).
>
>
> > I am trying to decide these rules, so that they don't deviate from the
> > point of being a RESTful API. Will get back with final implementation
> > details before I finish my application for GSoC.
> >
>
> Lastly, talk to Sebastien or someone who would is participating in GSoC as
> a mentor because it's important to identify who would mentor you if they
> would, best of luck.
>
> Cheers.
> I'm skipping applying to being a GSoC mentor this year, pissed off from
> GSoC admins this year. FOSS is just going to dogs; fck they did not include
> one project that has no real company to back its development and really
> needs help; VideoLAN/VLC.
>
>
>
> > Regard,
> > Shiva Teja(irc: teja)
> >
> >
> > On Sat, Apr 27, 2013 at 10:14 PM, Rohit Yadav 
> wrote:
> >
> > > Hi Shiva,
> > >
> > > On Sat, Apr 27, 2013 at 1:29 AM, Shiva Teja 
> > wrote:
> > >
> > > > Hi all,
> > > >
> > > > I am Shiva Teja, an undergrad student from IIT Mandi, India. I will
> be
> > > > participating in GSoC this year. I'd like to work on the new
> CloudStack
> > > UI
> > > > with bootstrap project[1]. I've been experimenting with API for the
> > past
> > > > few days. After reading a couple of blog posts by Sebastien, his
> recent
> > > > hack on this[2] and a recent discussion[3] on the mailing list about
> > > making
> > > > CloudStack API RESTfull, here are the things I plan to do.
> > > >
> > >
> > > Have you started working on your plan or just proposing? Hope you have
> a
> > > setup and tried CloudStack on DevCloud. For starters I suggest you to
> > > download, build and deploy CloudStack, play around APIs, cloudmonkey (a
> > > CLI) and the API Discovery service because both of your idea proposals
> > are
> > > around APIs.
> > >
> > > 1. A more "human", RESTfull wrapper API on top of CloudStack API using
> > > > Flask python framework. Something like "GET /users" will directly
> > > > correspond to "listUsers" API command. "DELETE /user/" will
> > > correspond
> > > > to the respective "deleteUser" API call.
> > > >
> > >
> > > It's tricky, first you should get a full list of entities. It's a lot
> of
> > > hard work if you do it manually but you can do smartly if you use Api
> > > Discovery. There are more than 300+ APIs in CloudStack, now groupped as
> > per
> > > entities (see a package like org.apache.cloudstack.api.. cmd
> > > class>).
> > >
> > > So, first you need to classify the 

RE: Review Request: CLOUDSTACK-1904: API : UI : Admin can not delete Events/Archive from other accounts

[Sanjay Tripathi]

David,

In CloudStack, the domain-admin is able to list the events from his domain and 
from the subdomain/accounts under his domain, and prior to this fix, 
domain-admin was able to delete/archive the events only from his account and 
not from sub-domains/accounts under his domain. This fix will allow 
domain-admin to delete/archive events which he can see on his dashboard.

So, this fix is not changing the existing design. Please let me know your 
thoughts on this.

--Sanjay

> -Original Message-
> From: Sanjay Tripathi [mailto:sanjay.tripa...@citrix.com]
> Sent: Saturday, April 27, 2013 1:55 AM
> To: dev@cloudstack.apache.org; David Nalley; Sateesh Chodapuneedi; Min
> Chen; Devdeep Singh
> Cc: cloudstack
> Subject: RE: Review Request: CLOUDSTACK-1904: API : UI : Admin can not
> delete Events/Archive from other accounts
> 
> David,
> 
> This was the intended design for the feature "Ability to delete/archive
> events" and mentioned in the Functional spec:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Ability+to+delet
> e+or+archive+Events+and+Alerts
> This tells that root/domain admin has the privilege to delete/archive events
> of accounts/sub-domains which are under his/her domain.
> 
> --Sanjay
> 
> > -Original Message-
> > From: David Nalley [mailto:nore...@reviews.apache.org] On Behalf Of
> > David Nalley
> > Sent: Friday, April 26, 2013 8:44 PM
> > To: Sateesh Chodapuneedi; Min Chen; Devdeep Singh
> > Cc: David Nalley; Sanjay Tripathi; cloudstack
> > Subject: Re: Review Request: CLOUDSTACK-1904: API : UI : Admin can not
> > delete Events/Archive from other accounts
> >
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/10796/#review19771
> > ---
> >
> >
> > Sanjay:
> >
> > This looks like a change in the design. Can you make sure this gets
> > discussed on the list first?
> >
> > Thanks,
> >
> > --David
> >
> > - David Nalley
> >
> >
> > On April 26, 2013, 11:26 a.m., Sanjay Tripathi wrote:
> > >
> > > ---
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/10796/
> > > ---
> > >
> > > (Updated April 26, 2013, 11:26 a.m.)
> > >
> > >
> > > Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi,
> > and Min Chen.
> > >
> > >
> > > Description
> > > ---
> > >
> > > CLOUDSTACK-1904: API : UI : Admin can not delete Events/Archive from
> > other accounts.
> > >
> > >
> > > This addresses bug CLOUDSTACK-1904.
> > >
> > >
> > > Diffs
> > > -
> > >
> > >
> >
> api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd
> > .java 55ca92a
> > >   core/src/com/cloud/event/dao/EventDao.java da5f47a
> > >   core/src/com/cloud/event/dao/EventDaoImpl.java 6ba59c5
> > >   server/src/com/cloud/domain/dao/DomainDao.java afeb0f4
> > >   server/src/com/cloud/domain/dao/DomainDaoImpl.java c30ca5e
> > >   server/src/com/cloud/server/ManagementServerImpl.java 16127a2
> > >   server/src/com/cloud/user/dao/AccountDao.java 3b7fa66
> > >   server/src/com/cloud/user/dao/AccountDaoImpl.java 892fdcd
> > >   server/test/com/cloud/event/EventControlsUnitTest.java 3c25275
> > >
> > > Diff: https://reviews.apache.org/r/10796/diff/
> > >
> > >
> > > Testing
> > > ---
> > >
> > > Tests:
> > > 1. Create a domain.
> > > 2. Create an admin account (a11) under this domain.
> > > 3. Login to the domain admin account and then logout (this is to
> > > generate
> > login/logout events).
> > > 4. Login to Root Admin account.
> > > 5. Go to Events and try to delete/archive events with account=a11
> > > (domain
> > admin account).
> > > 6. Event got deleted and verifies the control flow of admin accounts
> > > in
> > CloudStack.
> > >
> > >
> > > Thanks,
> > >
> > > Sanjay Tripathi
> > >
> > >

Re: Review Request: Adding more Granular Global Parameters

[Abhinandan Prateek]

> On April 29, 2013, 6:22 a.m., Abhinandan Prateek wrote:
> > Ship It!

The patch does not apply please resubmit.


- Abhinandan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/#review19847
---


On April 26, 2013, 5:31 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10740/
> ---
> 
> (Updated April 26, 2013, 5:31 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin 
> Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-741: Granular Global Parameters
> Adding the zone, cluster, account level parameters:
> zone: network.throttling.rate, Guest Domain Prefix
> cluster: cluster.cpu.allocated.capacity.disablethreshold, 
> cluster.cpu.allocated.capacity.notificationthreshold, 
> cluster.memory.allocated.capacity.disablethreshold, 
> cluster.memory.allocated.capacity.notificationthreshold
> account:  allow.public.user.templates, remote.access.vpn.client.iprange  
> 
> 
> This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and 
> CLOUDSTACK-741.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
>   api/src/com/cloud/network/NetworkModel.java 4d7d714 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 
> 9f34405 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 
> 074c5a3 
>   api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 
> 176c47a 
>   server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
>   server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
>   server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
>   server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
>   server/src/com/cloud/configuration/Config.java dbcbc53 
>   server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
>   server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
>   server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
>   server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
>   server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
>   server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
>   server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
>   server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
>   server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
>   server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
>   server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
>   
> server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java 
> fb29469 
>   
> server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java 
> f1163ef 
>   setup/db/db/schema-410to420.sql 78444fd 
>   test/integration/smoke/test_global_settings.py 12b35d7 
> 
> Diff: https://reviews.apache.org/r/10740/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: Adding more Granular Global Parameters

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/
---

(Updated April 29, 2013, 6:40 a.m.)


Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin 
Mehta.


Changes
---

updated patch.


Description
---

CLOUDSTACK-741: Granular Global Parameters
Adding the zone, cluster, account level parameters:
zone: network.throttling.rate, Guest Domain Prefix
cluster: cluster.cpu.allocated.capacity.disablethreshold, 
cluster.cpu.allocated.capacity.notificationthreshold, 
cluster.memory.allocated.capacity.disablethreshold, 
cluster.memory.allocated.capacity.notificationthreshold
account:  allow.public.user.templates, remote.access.vpn.client.iprange  


This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and 
CLOUDSTACK-741.


Diffs (updated)
-

  api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
  api/src/com/cloud/network/NetworkModel.java 4d7d714 
  api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 
9f34405 
  api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 
074c5a3 
  api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 176c47a 
  server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
  server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
  server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
  server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
  server/src/com/cloud/configuration/Config.java dbcbc53 
  server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
  server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
  server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
  server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
  server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
  server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
  server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
  server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
  server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
  server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
  server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
  server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
  server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java 
fb29469 
  server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java 
f1163ef 
  setup/db/db/schema-410to420.sql 78444fd 
  test/integration/smoke/test_global_settings.py 12b35d7 

Diff: https://reviews.apache.org/r/10740/diff/


Testing
---


Thanks,

Harikrishna Patnala

[ACS41][ACS42][QA] Automation Subtask

[Sudha Ponnaganti]

Hi,

I have created Automation sub task for some of the 4.1 and 4.2 features which 
are automatable. If you are interested to add automation for any of these 
features please assign it to yourself. Test plans are posted on cwiki [1] and 
detailed steps would help to automate test cases easily.

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+Plans

Thanks
/Sudha

Review Request: Source NAT on private gateway feature

[Jayapal Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10833/
---

Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and Chiradeep 
Vittal.


Description
---

Source NAT on private gateway feature


This addresses bug CLOUDSTACK-1828.


Diffs
-

  api/src/com/cloud/network/NetworkService.java 6c9bebc 
  api/src/com/cloud/network/vpc/PrivateIp.java 857fc22 
  api/src/com/cloud/network/vpc/VpcGateway.java 1756616 
  api/src/com/cloud/network/vpc/VpcService.java 07ce89b 
  
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java
 9fd736f 
  api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java 
4123477 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
7148e07 
  patches/systemvm/debian/config/opt/cloud/bin/vpc_privateGateway.sh a09d8f7 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 0064edf 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 99ad1ca 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 46ae35a 
  server/src/com/cloud/api/ApiResponseHelper.java 6090ff0 
  server/src/com/cloud/network/NetworkServiceImpl.java 2dcb47d 
  
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 
bdfac06 
  server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 2595a6a 
  server/src/com/cloud/network/vpc/PrivateIpAddress.java 826bea2 
  server/src/com/cloud/network/vpc/PrivateIpVO.java e6616ae 
  server/src/com/cloud/network/vpc/VpcGatewayVO.java 718e4df 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
  server/test/com/cloud/network/MockNetworkManagerImpl.java e9987bd 
  server/test/com/cloud/vpc/MockNetworkManagerImpl.java 9b18358 
  server/test/com/cloud/vpc/MockVpcManagerImpl.java 0f26928 
  setup/db/db/schema-410to420.sql 78444fd 

Diff: https://reviews.apache.org/r/10833/diff/


Testing
---

1. created the private gateway with source nat enable.
2. created private gateway with with source nat disable.
3. NAT rules for private gateway interface are configured correctly on VR.


Thanks,

Jayapal Reddy