[GitHub] asfgit closed pull request #8: Update URLs for gitbox.apache.org migration
asfgit closed pull request #8: Update URLs for gitbox.apache.org migration
URL: https://github.com/apache/cassandra-builds/pull/8
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cassandra-release/finish_release.sh
b/cassandra-release/finish_release.sh
index bcc9898..290e4ac 100755
--- a/cassandra-release/finish_release.sh
+++ b/cassandra-release/finish_release.sh
@@ -17,7 +17,7 @@ artifacts_svn_dir="$HOME/svn/cassandra-dist"
###
-asf_git_repo="http://git-wip-us.apache.org/repos/asf";
+asf_git_repo="https://gitbox.apache.org/repos/asf";
apache_host="people.apache.org"
# Reset getopts in case it has been used previously in the shell.
diff --git a/cassandra-release/prepare_release.sh
b/cassandra-release/prepare_release.sh
index 96e2aad..a7965b1 100755
--- a/cassandra-release/prepare_release.sh
+++ b/cassandra-release/prepare_release.sh
@@ -16,7 +16,7 @@ debian_package_dir="$HOME/tmp/debian"
###
-asf_git_repo="http://git-wip-us.apache.org/repos/asf";
+asf_git_repo="https://gitbox.apache.org/repos/asf";
staging_repo="https://repository.apache.org/content/repositories";
apache_host="people.apache.org"
diff --git a/jenkins-dsl/cassandra_job_dsl_seed.groovy
b/jenkins-dsl/cassandra_job_dsl_seed.groovy
index 79fe708..7212fe7 100644
--- a/jenkins-dsl/cassandra_job_dsl_seed.groovy
+++ b/jenkins-dsl/cassandra_job_dsl_seed.groovy
@@ -4,7 +4,7 @@
//
-def jobDescription = 'Apache Cassandra DSL-generated job - DSL git repo: https://git-wip-us.apache.org/repos/asf?p=cassandra-builds.git";>cassandra-builds'
+def jobDescription = 'Apache Cassandra DSL-generated job - DSL git repo: https://gitbox.apache.org/repos/asf?p=cassandra-builds.git";>cassandra-builds'
def jdkLabel = 'JDK 1.8 (latest)'
if(binding.hasVariable("CASSANDRA_JDK_LABEL")) {
jdkLabel = "${CASSANDRA_JDK_LABEL}"
@@ -18,7 +18,7 @@ def largeSlaveLabel = 'cassandra6||cassandra7'
if(binding.hasVariable("CASSANDRA_LARGE_SLAVE_LABEL")) {
largeSlaveLabel = "${CASSANDRA_LARGE_SLAVE_LABEL}"
}
-def mainRepo = "https://git-wip-us.apache.org/repos/asf/cassandra.git";
+def mainRepo = "https://gitbox.apache.org/repos/asf/cassandra.git";
if(binding.hasVariable("CASSANDRA_GIT_URL")) {
mainRepo = "${CASSANDRA_GIT_URL}"
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic opened a new pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic opened a new pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269420661 ## File path: docker/build-debs.sh ## @@ -78,7 +87,12 @@ fi # Install build dependencies and build package echo "y" | sudo mk-build-deps --install + Review comment: This had to be done otherwise following `dpkg-buildpackage` complained that JAVA_HOME can not be set like it was set at the beginning of this file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269420661 ## File path: docker/build-debs.sh ## @@ -78,7 +87,12 @@ fi # Install build dependencies and build package echo "y" | sudo mk-build-deps --install + Review comment: This had to be done otherwise following `dpkg-buildpackage` complained that JAVA_HOME can not be set like it was set at the beginning of this file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269420748 ## File path: docker/build-debs.sh ## @@ -78,7 +87,12 @@ fi # Install build dependencies and build package echo "y" | sudo mk-build-deps --install + +unset JAVA8_HOME +unset JAVA_HOME + Review comment: This had to be done otherwise following `dpkg-buildpackage` complained that JAVA_HOME can not be set like it was set at the beginning of this file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269420748 ## File path: docker/build-debs.sh ## @@ -78,7 +87,12 @@ fi # Install build dependencies and build package echo "y" | sudo mk-build-deps --install + +unset JAVA8_HOME +unset JAVA_HOME + Review comment: This had to be done otherwise following `dpkg-buildpackage` complained that `JAVA_HOME` can not be set like it was set at the beginning of this file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269421929 ## File path: docker/stretch-image.docker ## @@ -1,32 +1,34 @@ -FROM debian:jessie-backports Review comment: `jessie-backports` does not exist anymore, the subsequent update returns 404 on repos This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 -
Cassandra 4.0 packaging support
URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269422027
##
File path: docker/stretch-image.docker
##
@@ -1,32 +1,34 @@
-FROM debian:jessie-backports
+FROM debian:stretch-backports
ENV DEB_DIST_DIR=/dist
ENV BUILD_HOME=/home/build
ENV CASSANDRA_DIR=$BUILD_HOME/cassandra
+ENV ANT_VERSION=1.10.5
-LABEL org.cassandra.buildenv=jessie
+LABEL org.cassandra.buildenv=stretch
VOLUME ${DEB_DIST_DIR}
# install deps
RUN apt-get update && apt-get -y install \
- ant \
build-essential \
curl \
devscripts \
git \
sudo
-RUN apt-get -y -t jessie-backports --no-install-recommends install \
- openjdk-7-jdk \
Review comment:
`openjdk-7-jdk` is not in stretch anymore, Ive removed 7 from centos too
then
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on issue #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on issue #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#issuecomment-477001506 There needs to be merged / reviewed this too: https://github.com/smiklosovic/cassandra/commit/4a3926aa58f2b8a4a1e4b02b67810817243ff83e This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] mshuler commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
mshuler commented on a change in pull request #9: CASSANDRA-14712 - Cassandra
4.0 packaging support
URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269569635
##
File path: docker/centos7-image.docker
##
@@ -4,26 +4,27 @@ ENV BUILD_HOME=/home/build
ENV RPM_BUILD_DIR=$BUILD_HOME/rpmbuild
ENV RPM_DIST_DIR=/dist
ENV CASSANDRA_DIR=$BUILD_HOME/cassandra
+ENV ANT_VERSION=1.10.5
LABEL org.cassandra.buildenv=centos
VOLUME ${RPM_DIST_DIR}
# install deps
RUN yum -y install \
- ant \
- ant-junit \
epel-release \
git \
- java-1.7.0-openjdk-devel \
java-1.8.0-openjdk-devel \
+ java-11-openjdk-devel \
make \
rpm-build \
sudo
# via epel-releases
RUN yum -y install python2-pip
+RUN mkdir -p /opt && curl
http://www-eu.apache.org/dist/ant/binaries/apache-ant-$ANT_VERSION-bin.tar.gz |
tar xz -C /opt && mv /opt/apache-ant-$ANT_VERSION /opt/ant && ln -s
/opt/ant/bin/ant /usr/local/bin/ant
Review comment:
why?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] mshuler commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
mshuler commented on a change in pull request #9: CASSANDRA-14712 - Cassandra
4.0 packaging support
URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269569842
##
File path: docker/stretch-image.docker
##
@@ -1,32 +1,34 @@
-FROM debian:jessie-backports
+FROM debian:stretch-backports
ENV DEB_DIST_DIR=/dist
ENV BUILD_HOME=/home/build
ENV CASSANDRA_DIR=$BUILD_HOME/cassandra
+ENV ANT_VERSION=1.10.5
-LABEL org.cassandra.buildenv=jessie
+LABEL org.cassandra.buildenv=stretch
VOLUME ${DEB_DIST_DIR}
# install deps
RUN apt-get update && apt-get -y install \
- ant \
build-essential \
curl \
devscripts \
git \
sudo
-RUN apt-get -y -t jessie-backports --no-install-recommends install \
- openjdk-7-jdk \
- openjdk-8-jdk
+RUN apt-get -y -t stretch-backports --no-install-recommends install \
+ openjdk-8-jdk \
+ openjdk-11-jdk
-RUN apt-get -y -t jessie-backports install \
+RUN apt-get -y -t stretch-backports install \
python-sphinx \
python-sphinx-rtd-theme
RUN update-java-alternatives --set java-1.8.0-openjdk-amd64
+RUN mkdir -p /opt && curl
http://www-eu.apache.org/dist/ant/binaries/apache-ant-$ANT_VERSION-bin.tar.gz |
tar xz -C /opt && mv /opt/apache-ant-$ANT_VERSION /opt/ant && ln -s
/opt/ant/bin/ant /usr/local/bin/ant
Review comment:
why again?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] mshuler commented on issue #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
mshuler commented on issue #9: CASSANDRA-14712 - Cassandra 4.0 packaging support URL: https://github.com/apache/cassandra-builds/pull/9#issuecomment-477163370 Not sure why you're downloading a specific version of ant. Please, squash your commits. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on a change in pull request #9: CASSANDRA-14712 - Cassandra 4.0 packaging support
smiklosovic commented on a change in pull request #9: CASSANDRA-14712 -
Cassandra 4.0 packaging support
URL: https://github.com/apache/cassandra-builds/pull/9#discussion_r269855955
##
File path: docker/stretch-image.docker
##
@@ -1,32 +1,34 @@
-FROM debian:jessie-backports
+FROM debian:stretch-backports
ENV DEB_DIST_DIR=/dist
ENV BUILD_HOME=/home/build
ENV CASSANDRA_DIR=$BUILD_HOME/cassandra
+ENV ANT_VERSION=1.10.5
-LABEL org.cassandra.buildenv=jessie
+LABEL org.cassandra.buildenv=stretch
VOLUME ${DEB_DIST_DIR}
# install deps
RUN apt-get update && apt-get -y install \
- ant \
build-essential \
curl \
devscripts \
git \
sudo
-RUN apt-get -y -t jessie-backports --no-install-recommends install \
- openjdk-7-jdk \
- openjdk-8-jdk
+RUN apt-get -y -t stretch-backports --no-install-recommends install \
+ openjdk-8-jdk \
+ openjdk-11-jdk
-RUN apt-get -y -t jessie-backports install \
+RUN apt-get -y -t stretch-backports install \
python-sphinx \
python-sphinx-rtd-theme
RUN update-java-alternatives --set java-1.8.0-openjdk-amd64
+RUN mkdir -p /opt && curl
http://www-eu.apache.org/dist/ant/binaries/apache-ant-$ANT_VERSION-bin.tar.gz |
tar xz -C /opt && mv /opt/apache-ant-$ANT_VERSION /opt/ant && ln -s
/opt/ant/bin/ant /usr/local/bin/ant
Review comment:
@mshuler fixed in both cases
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-diff] krummas opened a new pull request #1: add github actions pull request verification
krummas opened a new pull request #1: add github actions pull request verification URL: https://github.com/apache/cassandra-diff/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-diff] krummas merged pull request #1: add github actions pull request verification
krummas merged pull request #1: add github actions pull request verification URL: https://github.com/apache/cassandra-diff/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever opened a new pull request #10: Configure so emails are sent when a build fails…
michaelsembwever opened a new pull request #10: Configure so emails are sent when a build fails… URL: https://github.com/apache/cassandra-builds/pull/10 **I have no idea how to test or deploy this change.** --- Configure so emails are sent when a build fails, becomes unstable or returns to stable, to the builds@ ML and the authors of the breakage. ref: - https://lists.apache.org/thread.html/e170de03f9b89e4dff06a5f524c7fb0ede6790f9f08c75aa50320889@ - https://jenkinsci.github.io/job-dsl-plugin/#method/javaposse.jobdsl.dsl.helpers.publisher.PublisherContext.extendedEmail This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on issue #10: Configure so emails are sent when a build fails…
michaelsembwever commented on issue #10: Configure so emails are sent when a build fails… URL: https://github.com/apache/cassandra-builds/pull/10#issuecomment-527966144 @mshuler @spodkowinski This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] mshuler commented on a change in pull request #10: Configure so emails are sent when a build fails…
mshuler commented on a change in pull request #10: Configure so emails are sent
when a build fails…
URL: https://github.com/apache/cassandra-builds/pull/10#discussion_r320851818
##
File path: jenkins-dsl/cassandra_job_dsl_seed.groovy
##
@@ -105,6 +105,19 @@ job('Cassandra-template-artifacts') {
javadocDir 'build/javadoc'
keepAll false
}
+extendedEmail {
+recipientList('bui...@cassandra.apache.org')
+triggers {
+stillUnstable {
Review comment:
stillUnstable is defined as:
// Triggers an email if the build status is "Unstable" for two or more
builds in a row.
I think we're going for failure{} and fixed{}? These triggers would send on
every build failure - there is an alternate firstFailure{} trigger, so only one
email would be sent in the case of repeated build failures. I can't remember if
we used regression{} in other jenkinses, but that might suit the needs for this
without spamming every failure{} too. I'll see if I can find some old DSL foo
to see what we used.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a change in pull request #10: Configure so emails are sent when a build fails…
michaelsembwever commented on a change in pull request #10: Configure so emails
are sent when a build fails…
URL: https://github.com/apache/cassandra-builds/pull/10#discussion_r320936973
##
File path: jenkins-dsl/cassandra_job_dsl_seed.groovy
##
@@ -105,6 +105,19 @@ job('Cassandra-template-artifacts') {
javadocDir 'build/javadoc'
keepAll false
}
+extendedEmail {
+recipientList('bui...@cassandra.apache.org')
+triggers {
+stillUnstable {
Review comment:
Fixed.
> These triggers would send on every build failure - there is an alternate
firstFailure{} trigger, so only one email would be sent in the case of repeated
build failures.
Let's start with `failure {}`, as no one should be committing on top of a
broken HEAD. (In a perfect world, that should be as bad as breaking it to begin
with.)
(If/When we change to `firstFailure{}` then `culprits()` looks like it can
be removed.)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever merged pull request #10: Configure so emails are sent when a build fails…
michaelsembwever merged pull request #10: Configure so emails are sent when a build fails… URL: https://github.com/apache/cassandra-builds/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on issue #10: Configure so emails are sent when a build fails…
michaelsembwever commented on issue #10: Configure so emails are sent when a build fails… URL: https://github.com/apache/cassandra-builds/pull/10#issuecomment-528245197 Watching deployment in https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-Job-DSL/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-website] dependabot[bot] opened a new pull request #1: Bump jekyll from 3.4.3 to 3.6.3 in /src
dependabot[bot] opened a new pull request #1: Bump jekyll from 3.4.3 to 3.6.3 in /src URL: https://github.com/apache/cassandra-website/pull/1 Bumps [jekyll](https://github.com/jekyll/jekyll) from 3.4.3 to 3.6.3. Release notes *Sourced from [jekyll's releases](https://github.com/jekyll/jekyll/releases).* > ## v3.6.2 > ### Development Fixes > > * Update Rubocop to 0.51.0 ([#6444](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6444)) > * Add test for layout as string ([#6445](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6445)) > > ### Bug Fixes > > * Problematic UTF+bom files ([#6322](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6322)) > * Always treat `data.layout` as a string ([#6442](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6442)) > > ## v3.6.1 > ### Documentation > > * Doc y_day in docs/permalinks ([#6244](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6244)) > * Update frontmatter.md ([#6371](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6371)) > * Elaborate on excluding items from processing ([#6136](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6136)) > * Style lists in tables ([#6379](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6379)) > * Remove duplicate &[#34](https://github-redirect.dependabot.com/jekyll/jekyll/issues/34);available&[#34](https://github-redirect.dependabot.com/jekyll/jekyll/issues/34); ([#6380](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6380)) > > ### Development Fixes > > * Bump rubocop to use `v0.50.x` ([#6368](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6368)) > > ## v3.6.0 > ### Minor Enhancements > > * Ignore final newline in folded YAML string ([#6054](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6054)) > * Add URL checks to Doctor ([#5760](https://github-redirect.dependabot.com/jekyll/jekyll/issues/5760)) > * Fix serving files that clash with directories ([#6222](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6222)) ([#6231](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6231)) > * Bump supported Ruby version to `>= 2.1.0` ([#6220](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6220)) > * set `LiquidError#template_name` for errors in included file ([#6206](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6206)) > * Access custom config array throughout session ([#6200](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6200)) > * Add support for Rouge 2, in addition to Rouge 1 ([#5919](https://github-redirect.dependabot.com/jekyll/jekyll/issues/5919)) > * Allow `yield` to logger methods & bail early on no-op messages ([#6315](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6315)) > * Update mime-types. ([#6336](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6336)) > * Use a Schwartzian transform with custom sorting ([#6342](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6342)) > * Alias `Drop#invoke_drop` to `Drop#[]` ([#6338](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6338)) > > ### Bug Fixes > > * `Deprecator`: fix typo for `--serve` command ([#6229](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6229)) > * `Reader#read_directories`: guard against an entry not being a directory ([#6226](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6226)) > * kramdown: symbolize keys in-place ([#6247](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6247)) > * Call `to_s` on site.url before attempting to concatenate strings ([#6253](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6253)) > * Enforce Style/FrozenStringLiteralComment ([#6265](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6265)) > * Update theme-template README to note &[#39](https://github-redirect.dependabot.com/jekyll/jekyll/issues/39);assets&[#39](https://github-redirect.dependabot.com/jekyll/jekyll/issues/39); directory ([#6257](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6257)) > * Memoize the return value of `Document#url` ([#6266](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6266)) > * delegate `StaticFile#to_json` to `StaticFile#to_liquid` ([#6273](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6273)) > * Fix `Drop#key?` so it can handle a nil argument ([#6281](https://github-redirect.dependabot.com/jekyll/jekyll/issues/6281)) > ... (truncated) Changelog *Sourced from [jekyll's changelog](https://github.com/jekyll/jekyll/blob/master/History.markdown).* > ## 3.6.3 / 2018-09-18 > > ### Bug Fixes > > * 3.6.x: security:
[GitHub] [cassandra-in-jvm-dtest-api] ifesdjeen opened a new pull request #1: Introduce the extracted in-JVM DTest API
ifesdjeen opened a new pull request #1: Introduce the extracted in-JVM DTest API URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1 Patch by Alex Petrov; reviewed by David Capwell for CASSANDRA-15539. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API
dcapwell commented on a change in pull request #1: Introduce the extracted
in-JVM DTest API
URL:
https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1#discussion_r384688584
##
File path:
src/main/java/org/apache/cassandra/distributed/shared/DistributedTestBase.java
##
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.distributed.shared;
+
+import org.apache.cassandra.distributed.api.ICluster;
+import org.apache.cassandra.distributed.api.IInstance;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.BeforeClass;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+
+public abstract class DistributedTestBase
+{
+@After
+public void afterEach()
+{
+System.runFinalization();
+System.gc();
+}
+
+public abstract Builder
builder();
+
+public static String KEYSPACE = "distributed_test_keyspace";
+
+// TODO: move this to Cluster.java?
+public static void nativeLibraryWorkaround()
+{
+// Disable the Netty tcnative library otherwise the
io.netty.internal.tcnative.CertificateCallbackTask,
+// CertificateVerifierTask, SSLPrivateKeyMethodDecryptTask,
SSLPrivateKeyMethodSignTask,
+// SSLPrivateKeyMethodTask, and SSLTask hold a gcroot against the
InstanceClassLoader.
+System.setProperty("cassandra.disable_tcactive_openssl", "true");
+System.setProperty("io.netty.transport.noNative", "true");
+}
+
+public static void processReaperWorkaround() throws Throwable {
+// Make sure the 'process reaper' thread is initially created under
the main classloader,
+// otherwise it gets created with the contextClassLoader pointing to
an InstanceClassLoader
+// which prevents it from being garbage collected.
+new ProcessBuilder().command("true").start().waitFor();
+}
+
+public static void setupLogging()
+{
+try
+{
+File root = Files.createTempDirectory("in-jvm-dtest").toFile();
+root.deleteOnExit();
+String testConfPath = "test/conf/logback-dtest.xml";
+Path logConfPath = Paths.get(root.getPath(), "/logback-dtest.xml");
+
+if (!logConfPath.toFile().exists())
+{
+Files.copy(new File(testConfPath).toPath(),
+ logConfPath);
+}
+
+System.setProperty("logback.configurationFile", "file://" +
logConfPath);
+}
+catch (IOException e)
+{
+throw new RuntimeException(e);
+}
+}
+
+@BeforeClass
+public static void setup() throws Throwable {
+setupLogging();
+System.setProperty("cassandra.ring_delay_ms", Integer.toString(10 *
1000));
Review comment:
same, should move to cluster
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API
dcapwell commented on a change in pull request #1: Introduce the extracted
in-JVM DTest API
URL:
https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1#discussion_r384688358
##
File path:
src/main/java/org/apache/cassandra/distributed/shared/DistributedTestBase.java
##
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.distributed.shared;
+
+import org.apache.cassandra.distributed.api.ICluster;
+import org.apache.cassandra.distributed.api.IInstance;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.BeforeClass;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+
+public abstract class DistributedTestBase
+{
+@After
+public void afterEach()
+{
+System.runFinalization();
+System.gc();
+}
+
+public abstract Builder
builder();
+
+public static String KEYSPACE = "distributed_test_keyspace";
+
+// TODO: move this to Cluster.java?
+public static void nativeLibraryWorkaround()
+{
+// Disable the Netty tcnative library otherwise the
io.netty.internal.tcnative.CertificateCallbackTask,
+// CertificateVerifierTask, SSLPrivateKeyMethodDecryptTask,
SSLPrivateKeyMethodSignTask,
+// SSLPrivateKeyMethodTask, and SSLTask hold a gcroot against the
InstanceClassLoader.
+System.setProperty("cassandra.disable_tcactive_openssl", "true");
+System.setProperty("io.netty.transport.noNative", "true");
+}
+
+public static void processReaperWorkaround() throws Throwable {
+// Make sure the 'process reaper' thread is initially created under
the main classloader,
+// otherwise it gets created with the contextClassLoader pointing to
an InstanceClassLoader
Review comment:
why not include it under shared then?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API
dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1#discussion_r384691389 ## File path: src/main/java/org/apache/cassandra/distributed/shared/Versions.java ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.distributed.shared; + +import java.io.File; +import java.net.MalformedURLException; +import java.net.URL; +import java.nio.file.Paths; +import java.util.*; +import java.util.regex.Matcher; +import java.util.regex.Pattern; +import java.util.stream.Collectors; + +public class Versions Review comment: FYI one thing I have been seeing is that 2 distinct versions with the same major.minor is unclear which one gets picked up (think current branch is 3.0 and you pull in the 3.0 dtest for the previous release) This should be improved, but will be so much easier once this JIRA is completed! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API
dcapwell commented on a change in pull request #1: Introduce the extracted
in-JVM DTest API
URL:
https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1#discussion_r384686278
##
File path: src/main/java/org/apache/cassandra/distributed/api/IListen.java
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.distributed.api;
+
+public interface IListen
+{
+public interface Cancel { void cancel(); }
Review comment:
nit: since IListen is public Cancel is already public, so don't need
`public` here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API
dcapwell commented on a change in pull request #1: Introduce the extracted
in-JVM DTest API
URL:
https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1#discussion_r384689479
##
File path:
src/main/java/org/apache/cassandra/distributed/shared/NetworkTopology.java
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.distributed.shared;
+
+import java.io.Serializable;
+import java.net.InetAddress;
+import java.net.UnknownHostException;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+import java.util.function.IntFunction;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+public class NetworkTopology
+{
+private final Map map;
+
+public static class DcAndRack
+{
+private final String dc;
+private final String rack;
+
+private DcAndRack(String dc, String rack)
+{
+this.dc = dc;
+this.rack = rack;
+}
+
+@Override
+public String toString()
+{
+return "DcAndRack{" +
+ "dc='" + dc + '\'' +
+ ", rack='" + rack + '\'' +
+ '}';
+}
+
+@Override
+public boolean equals(Object o)
+{
+if (this == o) return true;
+if (o == null || getClass() != o.getClass()) return false;
+DcAndRack dcAndRack = (DcAndRack) o;
+return Objects.equals(dc, dcAndRack.dc) &&
+ Objects.equals(rack, dcAndRack.rack);
+}
+
+@Override
+public int hashCode()
+{
+return Objects.hash(dc, rack);
+}
+}
+
+public static class AddressAndPort implements Serializable
Review comment:
I feel this should be top level
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API
dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1#discussion_r384679660 ## File path: pom.xml ## @@ -0,0 +1,94 @@ + Review comment: for first release I am ok with 1 jar, but there will be a need to split this into multiple jars: for example https://issues.apache.org/jira/browse/CASSANDRA-15602 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API
dcapwell commented on a change in pull request #1: Introduce the extracted
in-JVM DTest API
URL:
https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1#discussion_r384688663
##
File path:
src/main/java/org/apache/cassandra/distributed/shared/DistributedTestBase.java
##
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.distributed.shared;
+
+import org.apache.cassandra.distributed.api.ICluster;
+import org.apache.cassandra.distributed.api.IInstance;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.BeforeClass;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+
+public abstract class DistributedTestBase
+{
+@After
+public void afterEach()
+{
+System.runFinalization();
+System.gc();
+}
+
+public abstract Builder
builder();
+
+public static String KEYSPACE = "distributed_test_keyspace";
+
+// TODO: move this to Cluster.java?
+public static void nativeLibraryWorkaround()
+{
+// Disable the Netty tcnative library otherwise the
io.netty.internal.tcnative.CertificateCallbackTask,
+// CertificateVerifierTask, SSLPrivateKeyMethodDecryptTask,
SSLPrivateKeyMethodSignTask,
+// SSLPrivateKeyMethodTask, and SSLTask hold a gcroot against the
InstanceClassLoader.
+System.setProperty("cassandra.disable_tcactive_openssl", "true");
+System.setProperty("io.netty.transport.noNative", "true");
+}
+
+public static void processReaperWorkaround() throws Throwable {
+// Make sure the 'process reaper' thread is initially created under
the main classloader,
+// otherwise it gets created with the contextClassLoader pointing to
an InstanceClassLoader
+// which prevents it from being garbage collected.
+new ProcessBuilder().command("true").start().waitFor();
+}
+
+public static void setupLogging()
Review comment:
same, should move to cluster
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API
dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1#discussion_r384684017 ## File path: src/main/java/org/apache/cassandra/distributed/api/ICluster.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.distributed.api; + +import org.apache.cassandra.distributed.shared.NetworkTopology; + +import java.util.stream.Stream; + +public interface ICluster extends AutoCloseable Review comment: we really should rely on default methods to slim down the required interface; again, im ok with first release like this (since this is the same logic). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API
dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1#discussion_r384676411 ## File path: pom.xml ## @@ -0,0 +1,94 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + +org.apache +apache +10 + + +4.0.0 +org.apache.cassandra +dtest-api +0.0.1-SNAPSHOT +In JVM Test API +In JVM Test API + + +UTF-8 + + + + +Apache License, Version 2.0 +http://www.apache.org/licenses/LICENSE-2.0.txt +repo + + + + + +junit Review comment: *should* the API depend on Junit? tests do, but don't think the API should This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #1: Introduce the extracted in-JVM DTest API
dcapwell commented on a change in pull request #1: Introduce the extracted
in-JVM DTest API
URL:
https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1#discussion_r384687941
##
File path:
src/main/java/org/apache/cassandra/distributed/shared/DistributedTestBase.java
##
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.distributed.shared;
+
+import org.apache.cassandra.distributed.api.ICluster;
+import org.apache.cassandra.distributed.api.IInstance;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.BeforeClass;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+
+public abstract class DistributedTestBase
+{
+@After
+public void afterEach()
+{
+System.runFinalization();
+System.gc();
+}
+
+public abstract Builder
builder();
+
+public static String KEYSPACE = "distributed_test_keyspace";
+
+// TODO: move this to Cluster.java?
+public static void nativeLibraryWorkaround()
+{
+// Disable the Netty tcnative library otherwise the
io.netty.internal.tcnative.CertificateCallbackTask,
+// CertificateVerifierTask, SSLPrivateKeyMethodDecryptTask,
SSLPrivateKeyMethodSignTask,
+// SSLPrivateKeyMethodTask, and SSLTask hold a gcroot against the
InstanceClassLoader.
+System.setProperty("cassandra.disable_tcactive_openssl", "true");
Review comment:
don't have to fix here, but it would be good to move this to `Cluster`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-website] mshuler opened a new pull request #2: Run container build steps as non-root user
mshuler opened a new pull request #2: Run container build steps as non-root user URL: https://github.com/apache/cassandra-website/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-website] mshuler merged pull request #2: Run container build steps as non-root user
mshuler merged pull request #2: Run container build steps as non-root user URL: https://github.com/apache/cassandra-website/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever opened a new pull request #3: Symlink for 3.11 should point to latest 3.11*
michaelsembwever opened a new pull request #3: URL: https://github.com/apache/cassandra-website/pull/3 Previously the 3.11 was getting symlink'd to the earliest 3.11, which was obviously wrong. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-website] ossarga commented on issue #3: Symlink for 3.11 should point to latest 3.11*
ossarga commented on issue #3: URL: https://github.com/apache/cassandra-website/pull/3#issuecomment-616872518 Change looks good to me. I ran the changed bash code on the master branch of the repo inside a Ubuntu docker container. The change works as expected. I am happy for this to be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-diff] yifan-c opened a new pull request #8: Support running diff on multiple keyspaces
yifan-c opened a new pull request #8: URL: https://github.com/apache/cassandra-diff/pull/8 - Replaced discrete inputs, keyspace and tables, with one list of keyspace table pairs. Now a table is identified by keyspace and table name. - The scheme of JobMetadataDb is updated correspondingly to replace all 'table_name' with 'keyspace_table_name' and replace `table_names` with `keyspace_table_names` - DBService in api service is changed to make sure it can query with the new schema. - Readme is updated to include an example of running with multiple keyspaces. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-harry] ifesdjeen opened a new pull request #1: Harry: initial version
ifesdjeen opened a new pull request #1: URL: https://github.com/apache/cassandra-harry/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-harry] ifesdjeen closed pull request #1: Harry: initial version
ifesdjeen closed pull request #1: URL: https://github.com/apache/cassandra-harry/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-harry] ifesdjeen opened a new pull request #2: 15348 first version
ifesdjeen opened a new pull request #2: URL: https://github.com/apache/cassandra-harry/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-harry] ifesdjeen merged pull request #2: 15348 first version
ifesdjeen merged pull request #2: URL: https://github.com/apache/cassandra-harry/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-harry] shirlema opened a new pull request #3: Update README.md
shirlema opened a new pull request #3: URL: https://github.com/apache/cassandra-harry/pull/3 In What's Missing section: Removed the repeated bullet of * Partition deletions are not implemented Removed extra "o" from * Exhaustive checker should use more precise information from data tracker, not just watermarks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-harry] ifesdjeen closed pull request #1: Harry: initial version
ifesdjeen closed pull request #1: URL: https://github.com/apache/cassandra-harry/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-harry] ifesdjeen merged pull request #2: 15348 first version
ifesdjeen merged pull request #2: URL: https://github.com/apache/cassandra-harry/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-harry] ifesdjeen merged pull request #3: Update README.md
ifesdjeen merged pull request #3: URL: https://github.com/apache/cassandra-harry/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-harry] ifesdjeen merged pull request #3: Update README.md
ifesdjeen merged pull request #3: URL: https://github.com/apache/cassandra-harry/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-harry] ifesdjeen opened a new pull request #4: Update jackson dependency to 2.11.3 to force yaml to 1.26
ifesdjeen opened a new pull request #4: URL: https://github.com/apache/cassandra-harry/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
[GitHub] [cassandra-website] ossarga commented on a diff in pull request #121: move and prepare files for content folder
ossarga commented on code in PR #121:
URL: https://github.com/apache/cassandra-website/pull/121#discussion_r841307662
##
site-content/docker-entrypoint.sh:
##
@@ -196,14 +196,87 @@ generate_site_yaml() {
render_site_content_to_html() {
pushd "${CASSANDRA_WEBSITE_DIR}/site-content" > /dev/null
- echo "Building the site HTML content."
+ log_message "INFO" "Building the site HTML content."
antora --generator antora-site-generator-lunr site.yaml
- echo "Rendering complete!"
+ log_message "INFO" "Rendering complete!"
popd > /dev/null
}
+
+prepare_site_html_for_publication() {
+ pushd "${CASSANDRA_WEBSITE_DIR}" > /dev/null
+
+ # copy everything to content/ directory
+ log_message "INFO" "Moving site HTML to content/"
+ mkdir -p content/doc
+ cp -r site-content/build/html/* content/
+
+ # remove hardcoded domain name, and empty domain names first before we
duplicate and documentation
+ content_files_to_change=($(grep -rl 'https://cassandra.apache.org/'
content/))
+ log_message "INFO" "Removing hardcoded domain names in
${#content_files_to_change[*]} files"
+ for content_file in ${content_files_to_change[*]}
+ do
+log_message "DEBUG" "Processing file ${content_file}"
+# sed automatically uses the character following the 's' as a delimiter.
+# In this case we will use the ',' so we can avoid the need to escape the
'/' characters
+sed -i 's,https://cassandra.apache.org/,/,g' ${content_file}
+ done
+
+ content_files_to_change=($(grep -rl 'href="//' content/))
+ log_message "INFO" "Removing empty domain names in
${#content_files_to_change[*]} files"
+ for content_file in ${content_files_to_change[*]}
+ do
+log_message "DEBUG" "Processing file ${content_file}"
+sed -i 's,href="//,href="/,g' ${content_file}
+ done
+
+ # move around the in-tree docs if generated
+ if [ "${COMMAND_GENERATE_DOCS}" = "run" ]
+ then
+log_message "INFO" "Moving versioned documentation HTML to content/doc"
+move_intree_document_directories "3.11" "3.11.11" "3.11.12"
+move_intree_document_directories "4.0" "4.0.0" "4.0.1" "4.0.2" "4.0.3"
"stable"
+move_intree_document_directories "trunk" "4.1" "latest"
Review Comment:
Agreed. I have been thinking about this for some time. It will be addressed
in [CASSANDRA-17517](https://issues.apache.org/jira/browse/CASSANDRA-17517).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cassandra-website] ossarga commented on a diff in pull request #121: move and prepare files for content folder
ossarga commented on code in PR #121:
URL: https://github.com/apache/cassandra-website/pull/121#discussion_r841307849
##
site-content/docker-entrypoint.sh:
##
@@ -241,10 +314,41 @@ run_preview_mode() {
}
+log_level_str_to_int() {
+ local log_level_int
+ case $1 in
+"OFF")
+ log_level_int=0
+;;
+"ERROR")
+ log_level_int=1
+;;
+"WARN")
+ log_level_int=2
+;;
+"INFO")
+ log_level_int=3
+;;
+"DEBUG"|"*")
+ log_level_int=4
+;;
+ esac
+ echo ${log_level_int}
+}
+
+
+log_message() {
+ if [ ${LOG_LEVEL_INT} -ne 0 ] && [ $(log_level_str_to_int $1) -le
${LOG_LEVEL_INT} ]
+ then
+echo "container: $1: $2"
+ fi
+}
Review Comment:
Great suggestion! They will make an appearance in my next Pull Request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cassandra-accord] belliottsmith commented on a diff in pull request #2: Initial Cassandra integration
belliottsmith commented on code in PR #2:
URL: https://github.com/apache/cassandra-accord/pull/2#discussion_r841458215
##
accord-core/src/main/java/accord/local/CommandStore.java:
##
@@ -228,7 +228,7 @@ public void processBlocking(Consumer
consumer)
}
catch (InterruptedException e)
{
-Thread.currentThread().interrupt();
+throw new AssertionError(e);
Review Comment:
would be nice to have `UncheckedInterruptedException` here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
