Re: [VOTE] Release Apache Cassandra 5.0-alpha1 (take3)

[Berenguer Blasi]

+1

On 4/9/23 22:28, Mick Semb Wever wrote:


The vote will be open for 72 hours (longer if needed). Everyone
who has tested the build is invited to vote. Votes by PMC members
are considered binding. A vote passes if there are at least three
binding +1s and no -1's.



+1

Checked
- signing correct
- checksums are correct
- source artefact builds (JDK 11+17)
- binary artefact runs (JDK 11+17)
- debian package runs (JDK 11+17)
- debian repo runs (JDK 11+17)
- redhat* package runs (JDK11+17)
- redhat* repo runs (JDK 11+17)

Re: [VOTE] Release Apache Cassandra 5.0-alpha1 (take3)

[guo Maxwell]

+1

Berenguer Blasi  于2023年9月7日周四 15:27写道：

> +1
> On 4/9/23 22:28, Mick Semb Wever wrote:
>
>
> The vote will be open for 72 hours (longer if needed). Everyone who has
>> tested the build is invited to vote. Votes by PMC members are considered
>> binding. A vote passes if there are at least three binding +1s and no -1's.
>>
>
>
> +1
>
> Checked
> - signing correct
> - checksums are correct
> - source artefact builds (JDK 11+17)
> - binary artefact runs (JDK 11+17)
> - debian package runs (JDK 11+17)
> - debian repo runs (JDK 11+17)
> - redhat* package runs (JDK11+17)
> - redhat* repo runs (JDK 11+17)
>
>
>

-- 
you are the apple of my eye !

Re: [VOTE] Release Apache Cassandra 5.0-alpha1 (take3)

[Brandon Williams]

+1

Kind Regards,
Brandon

On Mon, Sep 4, 2023 at 3:26 PM Mick Semb Wever  wrote:
>
>
> Proposing the test build of Cassandra 5.0-alpha1 for release.
>
> DISCLAIMER, this alpha release does not contain the expected 5.0
> features: Vector Search (CEP-30), Transactional Cluster Metadata
> (CEP-21) and Accord Transactions (CEP-15).  These features will land
> in a later alpha release.
>
> Please also note that this is an alpha release and what that means, further 
> info at 
> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
>
> sha1: bc5e3741d475e2e99fd7a10450681fd708431a89
> Git: https://github.com/apache/cassandra/tree/5.0-alpha1-tentative
> Maven Artifacts: 
> https://repository.apache.org/content/repositories/orgapachecassandra-1316/org/apache/cassandra/cassandra-all/5.0-alpha1/
>
> The Source and Build Artifacts, and the Debian and RPM packages and 
> repositories, are available here: 
> https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/
>
> The vote will be open for 72 hours (longer if needed). Everyone who has 
> tested the build is invited to vote. Votes by PMC members are considered 
> binding. A vote passes if there are at least three binding +1s and no -1's.
>
> [1]: CHANGES.txt: 
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt
> [2]: NEWS.txt: 
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt
>

Re: [VOTE] Release Apache Cassandra 5.0-alpha1 (take3)

[Jacek Lewandowski]

Mick, is the documentation / website ok?

If so, +1

Best Regards,
- - -- --- -  -
Jacek Lewandowski


czw., 7 wrz 2023 o 12:58 Brandon Williams  napisał(a):

> +1
>
> Kind Regards,
> Brandon
>
> On Mon, Sep 4, 2023 at 3:26 PM Mick Semb Wever  wrote:
> >
> >
> > Proposing the test build of Cassandra 5.0-alpha1 for release.
> >
> > DISCLAIMER, this alpha release does not contain the expected 5.0
> > features: Vector Search (CEP-30), Transactional Cluster Metadata
> > (CEP-21) and Accord Transactions (CEP-15).  These features will land
> > in a later alpha release.
> >
> > Please also note that this is an alpha release and what that means,
> further info at
> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
> >
> > sha1: bc5e3741d475e2e99fd7a10450681fd708431a89
> > Git: https://github.com/apache/cassandra/tree/5.0-alpha1-tentative
> > Maven Artifacts:
> https://repository.apache.org/content/repositories/orgapachecassandra-1316/org/apache/cassandra/cassandra-all/5.0-alpha1/
> >
> > The Source and Build Artifacts, and the Debian and RPM packages and
> repositories, are available here:
> https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/
> >
> > The vote will be open for 72 hours (longer if needed). Everyone who has
> tested the build is invited to vote. Votes by PMC members are considered
> binding. A vote passes if there are at least three binding +1s and no -1's.
> >
> > [1]: CHANGES.txt:
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt
> > [2]: NEWS.txt:
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt
> >
>

Re: [VOTE] Release Apache Cassandra 5.0-alpha1 (take3)

[Benjamin Lerer]

+1

Le jeu. 7 sept. 2023 à 13:53, Jacek Lewandowski 
a écrit :

> Mick, is the documentation / website ok?
>
> If so, +1
>
> Best Regards,
> - - -- --- -  -
> Jacek Lewandowski
>
>
> czw., 7 wrz 2023 o 12:58 Brandon Williams  napisał(a):
>
>> +1
>>
>> Kind Regards,
>> Brandon
>>
>> On Mon, Sep 4, 2023 at 3:26 PM Mick Semb Wever  wrote:
>> >
>> >
>> > Proposing the test build of Cassandra 5.0-alpha1 for release.
>> >
>> > DISCLAIMER, this alpha release does not contain the expected 5.0
>> > features: Vector Search (CEP-30), Transactional Cluster Metadata
>> > (CEP-21) and Accord Transactions (CEP-15).  These features will land
>> > in a later alpha release.
>> >
>> > Please also note that this is an alpha release and what that means,
>> further info at
>> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
>> >
>> > sha1: bc5e3741d475e2e99fd7a10450681fd708431a89
>> > Git: https://github.com/apache/cassandra/tree/5.0-alpha1-tentative
>> > Maven Artifacts:
>> https://repository.apache.org/content/repositories/orgapachecassandra-1316/org/apache/cassandra/cassandra-all/5.0-alpha1/
>> >
>> > The Source and Build Artifacts, and the Debian and RPM packages and
>> repositories, are available here:
>> https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/
>> >
>> > The vote will be open for 72 hours (longer if needed). Everyone who has
>> tested the build is invited to vote. Votes by PMC members are considered
>> binding. A vote passes if there are at least three binding +1s and no -1's.
>> >
>> > [1]: CHANGES.txt:
>> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt
>> > [2]: NEWS.txt:
>> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt
>> >
>>
>

Re: [VOTE] Release Apache Cassandra 5.0-alpha1 (take3)

[Andrés de la Peña]

+1

On Thu, 7 Sept 2023 at 12:52, Jacek Lewandowski 
wrote:

> Mick, is the documentation / website ok?
>
> If so, +1
>
> Best Regards,
> - - -- --- -  -
> Jacek Lewandowski
>
>
> czw., 7 wrz 2023 o 12:58 Brandon Williams  napisał(a):
>
>> +1
>>
>> Kind Regards,
>> Brandon
>>
>> On Mon, Sep 4, 2023 at 3:26 PM Mick Semb Wever  wrote:
>> >
>> >
>> > Proposing the test build of Cassandra 5.0-alpha1 for release.
>> >
>> > DISCLAIMER, this alpha release does not contain the expected 5.0
>> > features: Vector Search (CEP-30), Transactional Cluster Metadata
>> > (CEP-21) and Accord Transactions (CEP-15).  These features will land
>> > in a later alpha release.
>> >
>> > Please also note that this is an alpha release and what that means,
>> further info at
>> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
>> >
>> > sha1: bc5e3741d475e2e99fd7a10450681fd708431a89
>> > Git: https://github.com/apache/cassandra/tree/5.0-alpha1-tentative
>> > Maven Artifacts:
>> https://repository.apache.org/content/repositories/orgapachecassandra-1316/org/apache/cassandra/cassandra-all/5.0-alpha1/
>> >
>> > The Source and Build Artifacts, and the Debian and RPM packages and
>> repositories, are available here:
>> https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/
>> >
>> > The vote will be open for 72 hours (longer if needed). Everyone who has
>> tested the build is invited to vote. Votes by PMC members are considered
>> binding. A vote passes if there are at least three binding +1s and no -1's.
>> >
>> > [1]: CHANGES.txt:
>> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt
>> > [2]: NEWS.txt:
>> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt
>> >
>>
>

Re: [Discuss] disabling io.netty.transport.noNative in tests

[Jon Meredith]

I think the Native dependencies were disabled for in-jvm Netty because they
prevented the in-jvm dtest InstanceClassLoaders from being garbage
collected and were a source of out-of-metaspace exceptions.  I'll echo
Alex's comment that you will also need to investigate in-jvm upgrade tests.
I'm not sure if it's possible to load two different versions of native
libraries concurrently.

Perhaps the netty code has changed and we can re-enable, or perhaps you can
determine what was not being released by the native code -- that would be
much better and as Alex says more reflective of the common environment.

To check if it is now safe, you can use the ResourceLeakTest - you may have
to comment out a few @Ignores - the previous bar was for the
looperGossiperNetwork test to complete 100 loops.

Jon.

On Wed, Sep 6, 2023 at 9:32 AM Alex Petrov  wrote:

> I think most of the time people actually use netty _with_ native. This
> might have been introduced when we were tried to make shaded in-JVM dtest
> jars. If all tests are passing, and we actually do have a confirmtion that
> native Netty is being used, I would say +1 to remove `noNative`.
>
> Just to make sure though, did you have a chance to see if the upgrade
> tests also work fine?
>
> On Thu, Aug 31, 2023, at 1:20 PM, Miklosovic, Stefan wrote:
>
> Hi list,
>
> Currently, we are skipping the usage of native libraries in Netty as part
> of testing here (1).
>
> In 5.0 branch, we upgraded Netty to 4.1.96 and we brought all native
> dependencies to the class path so they are there in runtime (x86, arm, mac).
>
> I conducted few CI tests for 5.0+ and not having
> "io.netty.transport.noNative" set to "true" introduces no errors. I think
> we were just too motivated here to skip stuff left and right. Having this
> property enabled seems to have no functional effect. Also, one negative
> side-effect of having this property enabled is that it logs exceptions when
> running in-jvm-dtests e.g. in IDEA and it pollutes the logs unnecessarily
> and it is just a visual clutter to deal with every time. To silence this, I
> set (2) so it skips the logic in (3) completely hence no un-necessary
> logging will occure.
>
> My question is whether we should not remove (4) in 5.0, that means that
> tests will use native libraries too. That also means that we are running
> tests closer to a production environment. I just do not see any reason why
> we should skip this when all tests are just passing with it too with
> additional benefit of not seeing an exception logged every time when
> testing it locally.
>
> Thanks
>
> (1)
> https://github.com/apache/cassandra-in-jvm-dtest-api/blob/trunk/src/main/java/org/apache/cassandra/distributed/api/ICluster.java#L95-L102
> (2)
> https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java#L196
> (3)
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/NativeTransportService.java#L163
> (4)
> https://github.com/apache/cassandra-in-jvm-dtest-api/blob/trunk/src/main/java/org/apache/cassandra/distributed/api/ICluster.java#L101
>
>
>

Re: [VOTE] Release Apache Cassandra 5.0-alpha1 (take3)

[Mick Semb Wever]

On Thu, 7 Sept 2023 at 13:53, Jacek Lewandowski 
wrote:

> Mick, is the documentation / website ok?
>


Can you elaborate on what is ok ?

https://cassandra.apache.org/doc/5.0/index.html
 is in an ok state.
There's lots still to add for 5.0 and I know Lorina is very busy on this
front.  I don't think any of that is a release blocker though.

And, I suggest we repeat what we did with previous major releases and not
list the alpha releases on the downloads page (but do list the first
beta).  Announcement emails will contain all the information to links and
there'll probably be blog posts too.

Re: [Discuss] disabling io.netty.transport.noNative in tests

[Miklosovic, Stefan]

Thank you for your insights. I created (1) to track the work / progress.

(1) https://issues.apache.org/jira/browse/CASSANDRA-18830


From: Jon Meredith 
Sent: Thursday, September 7, 2023 15:42
To: dev@cassandra.apache.org
Subject: Re: [Discuss] disabling io.netty.transport.noNative in tests

NetApp Security WARNING: This is an external email. Do not click links or open 
attachments unless you recognize the sender and know the content is safe.



I think the Native dependencies were disabled for in-jvm Netty because they 
prevented the in-jvm dtest InstanceClassLoaders from being garbage collected 
and were a source of out-of-metaspace exceptions.  I'll echo Alex's comment 
that you will also need to investigate in-jvm upgrade tests. I'm not sure if 
it's possible to load two different versions of native libraries concurrently.

Perhaps the netty code has changed and we can re-enable, or perhaps you can 
determine what was not being released by the native code -- that would be much 
better and as Alex says more reflective of the common environment.

To check if it is now safe, you can use the ResourceLeakTest - you may have to 
comment out a few @Ignores - the previous bar was for the looperGossiperNetwork 
test to complete 100 loops.

Jon.

On Wed, Sep 6, 2023 at 9:32 AM Alex Petrov 
mailto:al...@coffeenco.de>> wrote:
I think most of the time people actually use netty _with_ native. This might 
have been introduced when we were tried to make shaded in-JVM dtest jars. If 
all tests are passing, and we actually do have a confirmtion that native Netty 
is being used, I would say +1 to remove `noNative`.

Just to make sure though, did you have a chance to see if the upgrade tests 
also work fine?

On Thu, Aug 31, 2023, at 1:20 PM, Miklosovic, Stefan wrote:
Hi list,

Currently, we are skipping the usage of native libraries in Netty as part of 
testing here (1).

In 5.0 branch, we upgraded Netty to 4.1.96 and we brought all native 
dependencies to the class path so they are there in runtime (x86, arm, mac).

I conducted few CI tests for 5.0+ and not having "io.netty.transport.noNative" 
set to "true" introduces no errors. I think we were just too motivated here to 
skip stuff left and right. Having this property enabled seems to have no 
functional effect. Also, one negative side-effect of having this property 
enabled is that it logs exceptions when running in-jvm-dtests e.g. in IDEA and 
it pollutes the logs unnecessarily and it is just a visual clutter to deal with 
every time. To silence this, I set (2) so it skips the logic in (3) completely 
hence no un-necessary logging will occure.

My question is whether we should not remove (4) in 5.0, that means that tests 
will use native libraries too. That also means that we are running tests closer 
to a production environment. I just do not see any reason why we should skip 
this when all tests are just passing with it too with additional benefit of not 
seeing an exception logged every time when testing it locally.

Thanks

(1) 
https://github.com/apache/cassandra-in-jvm-dtest-api/blob/trunk/src/main/java/org/apache/cassandra/distributed/api/ICluster.java#L95-L102
(2) 
https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java#L196
(3) 
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/NativeTransportService.java#L163