Re: Current Branch Merge Path - PLEASE READ!

2016-12-11 Thread Jeff Jirsa
It depends on severity, but generally… If you find a bug in 3.0, you should 
work back to 2.1 to see if it exists in older versions. We don’t put minor 
fixes into 2.1 (or really 2.2 at this point) – 2.1 is critical fixes only, and 
2.2 is getting to that point as well.

If it’s a minor minor bug, fix it in 3.0 and generate patches for versions 
newer than that. If it’s a critical bug, go back to 2.1 and see if it exists 
there as well.



On 12/10/16, 6:03 PM, "Jay Zhuang"  wrote:

>I'm new to the community, sorry if it’s obvious question. Are there any 
>general guidance on choosing which branch we should start with? For 
>example, if I find a bug in 3.0, should I try to reproduce it in the 
>lowest version (2.1) and work from there?
>
>Thanks,
>Jay
>
>On 12/8/16 10:29 AM, Michael Shuler wrote:
>> The current branch merge path is, in full:
>>
>> cassandra-2.1
>>  |
>>  cassandra-2.2
>>   |
>>   cassandra-3.0
>>|
>>cassandra-3.11
>> |
>> cassandra-3.X
>>  |
>>  trunk
>>
>> Wherever you start, please follow through the complete path to trunk.
>>
>> I reopened JIRAs #12768, #12817, and #12694 for skipping cassandra-3.11.
>> Owners of those tickets, please commit to the cassandra-3.11 branch and
>> merge up. There were too many conflicts for me to comfortably try to
>> resolve on a straight merge from 3.0.
>>


smime.p7s
Description: S/MIME cryptographic signature


Re: streaming_connections_per_host - speeding up CPU bound bootstrap

2016-12-11 Thread Nate McCall
I have not dug too deeply yet, but how would you compare/reconcile
your proposed changes with this comment:
https://issues.apache.org/jira/browse/CASSANDRA-4663?focusedCommentId=15342248&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15342248

On Thu, Dec 8, 2016 at 4:10 AM, Corentin Chary  wrote:
> Currently the StreamPlan created for bootstrap (and rebuild) will only
> create one connection per host. If you have less nodes than cores,
> this is likely to be CPU bound (a CPU seems to be able to process
> ~5MB/s).
>
> Is there any reason why something naive like
> https://github.com/iksaif/cassandra/commit/8352c21284811ca15d63183ceae0b11586623f31
> would not work ?
>
> I believe this is what is about
> https://issues.apache.org/jira/browse/CASSANDRA-4663
> See also: https://issues.apache.org/jira/browse/CASSANDRA-12229, but I
> don't believe non-blocking I/O would change anything here.
>
> --
> Corentin Chary
> http://xf.iksaif.net


Re: streaming_connections_per_host - speeding up CPU bound bootstrap

2016-12-11 Thread Corentin Chary
Hard to say because this comment doesn't show the code that was tried.

My proposed change
(https://issues.apache.org/jira/secure/attachment/12842717/0001-streaming-add-a-way-to-configure-the-number-of-conne.patch)
should open multiple connections per hosts: this fixes blocking writes
on a single connection or CPU-bound (de)-serialization.


On Mon, Dec 12, 2016 at 2:04 AM, Nate McCall  wrote:
> I have not dug too deeply yet, but how would you compare/reconcile
> your proposed changes with this comment:
> https://issues.apache.org/jira/browse/CASSANDRA-4663?focusedCommentId=15342248&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15342248
>
> On Thu, Dec 8, 2016 at 4:10 AM, Corentin Chary  
> wrote:
>> Currently the StreamPlan created for bootstrap (and rebuild) will only
>> create one connection per host. If you have less nodes than cores,
>> this is likely to be CPU bound (a CPU seems to be able to process
>> ~5MB/s).
>>
>> Is there any reason why something naive like
>> https://github.com/iksaif/cassandra/commit/8352c21284811ca15d63183ceae0b11586623f31
>> would not work ?
>>
>> I believe this is what is about
>> https://issues.apache.org/jira/browse/CASSANDRA-4663
>> See also: https://issues.apache.org/jira/browse/CASSANDRA-12229, but I
>> don't believe non-blocking I/O would change anything here.
>>
>> --
>> Corentin Chary
>> http://xf.iksaif.net



-- 
Corentin Chary
http://xf.iksaif.net