Re: AW: [VOTE] Release Ivy 2.5.0 based on RC1

2019-10-24 Thread Jaikiran Pai
Hello Jan,

On 24/10/19 1:31 AM, Jan Matèrne (jhm) wrote:
> Checked the bin.zip.
> Seems to be ok.
>
> Just a question: there is a file fr\jayasoft\ivy\ant\antlib.xml which seems 
> to be a copy of org\apache\ivy\ant\antlib.xml. Is it for BWC?
Yes, looks like it.
https://github.com/apache/ant-ivy/blob/master/build.xml#L263. It was
done way back in 2007 and I don't think anyone uses that reference
anymore. After this release, maybe we can stop copying and releasing
that file.
>
> Hello-Ivy-Example:
> - run with "ant -lib ..\..\..\ivy-2.5.0.jar run"
> --> Ivy starts
> --> Ivy vesion 2.5.0
> --> Problems with downloading the dependencies:
>
> [ivy:retrieve]  found commons-lang#commons-lang;2.6 in public
> [ivy:retrieve] You probably access the destination server through a proxy 
> server that is not well configured.
>
> [ivy:retrieve] :: problems summary ::
> [ivy:retrieve]  WARNINGS
> [ivy:retrieve]  Host repo1.maven.org not found. 
> url=https://repo1.maven.org/maven2/commons-cli/commons-cli/1.4/commons-cli-1.4.pom
> [ivy:retrieve]  Host repo1.maven.org not found. 
> url=https://repo1.maven.org/maven2/commons-cli/commons-cli/1.4/commons-cli-1.4.jar
> [ivy:retrieve]  module not found: commons-cli#commons-cli;1.4
> [ivy:retrieve]   local: tried
> [ivy:retrieve]
> C:\Users\Jan\.ivy2\local\commons-cli\commons-cli\1.4\ivys\ivy.xml
> [ivy:retrieve]-- artifact commons-cli#commons-cli;1.4!commons-cli.jar:
> [ivy:retrieve]
> C:\Users\Jan\.ivy2\local\commons-cli\commons-cli\1.4\jars\commons-cli.jar
> [ivy:retrieve]   shared: tried
> [ivy:retrieve]
> C:\Users\Jan\.ivy2\shared\commons-cli\commons-cli\1.4\ivys\ivy.xml
> [ivy:retrieve]-- artifact commons-cli#commons-cli;1.4!commons-cli.jar:
> [ivy:retrieve]
> C:\Users\Jan\.ivy2\shared\commons-cli\commons-cli\1.4\jars\commons-cli.jar
> [ivy:retrieve]   public: tried
> [ivy:retrieve]
> https://repo1.maven.org/maven2/commons-cli/commons-cli/1.4/commons-cli-1.4.pom
> [ivy:retrieve]-- artifact commons-cli#commons-cli;1.4!commons-cli.jar:
> [ivy:retrieve]
> https://repo1.maven.org/maven2/commons-cli/commons-cli/1.4/commons-cli-1.4.jar
>
> I dont have a proxy server I am aware of.
> I could access the url 
> https://repo1.maven.org/maven2/commons-cli/commons-cli/1.4/commons-cli-1.4.jar
>  via browser.
>
> Added a 'get' target which works:
> 
>  src="https://repo1.maven.org/maven2/commons-cli/commons-cli/1.4/commons-cli-1.4.jar";
>  dest="."/>
> 
>
> Another try:
>   ant -lib ..\..\..\ivy-2.5.0.jar -autoproxy run
> and that worked.

I gave this example a try with this released version and it went fine
without those warnings or errors. I suspect your Ivy cache probably had
already downloaded the metadata/resources previously using some other
"resolver"?


> So a +1 from me.
Thank you.
> Thanks for getting the release done.

This was on my TODO list for a very long time now. Glad that this is now
happening.

-Jaikiran



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[RESULT] Release Ivy 2.5.0 based on RC1

2019-10-24 Thread Jaikiran Pai
With +1s from:

Jaikiran Pai

Stefan Bodewig

Jan Matèrne

and no vetos, this vote now passes. I'll initiate the rest of the
process to complete this release process.

Thank you all for voting.

-Jaikiran

On 24/10/19 9:45 AM, Stefan Bodewig wrote:
> +1
>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Need help releasing IVY project in JIRA

2019-10-24 Thread Jaikiran Pai
It looks like I don't have relevant permissions in JIRA to release the
IVY project. Can someone with appropriate permissions at
https://issues.apache.org/jira/browse/IVY please rename the "master"
release https://issues.apache.org/jira/projects/IVY/versions/12343084 to
"2.5.0" and officially release it in JIRA?

Once done, please also create a new "master" release so that newer fixes
can be tracked against it.

-Jaikiran


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] ebourg opened a new pull request #106: Support SSH config file in the ssh tasks

2019-10-24 Thread GitBox
ebourg opened a new pull request #106: Support SSH config file in the ssh tasks
URL: https://github.com/apache/ant/pull/106
 
 
   Here is a PR improving the sshexec, sshsession and scp tasks to support the 
SSH config file (typically ~/.ssh/config). This file defines the username and 
key file to be used per host, if Ant could support it that would avoid 
duplicating the key information from the SSH config in the Ant builds.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] asf-ci commented on issue #106: Support SSH config file in the ssh tasks

2019-10-24 Thread GitBox
asf-ci commented on issue #106: Support SSH config file in the ssh tasks
URL: https://github.com/apache/ant/pull/106#issuecomment-546002026
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/Ant%20Github-PR-Linux/137/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] asf-ci commented on issue #106: Support SSH config file in the ssh tasks

2019-10-24 Thread GitBox
asf-ci commented on issue #106: Support SSH config file in the ssh tasks
URL: https://github.com/apache/ant/pull/106#issuecomment-546002694
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/Ant%20Github-PR-Windows/143/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



AW: Need help releasing IVY project in JIRA

2019-10-24 Thread jhm
done

Jan

> -Ursprüngliche Nachricht-
> Von: Jaikiran Pai [mailto:jaiki...@apache.org]
> Gesendet: Donnerstag, 24. Oktober 2019 13:42
> An: Ant Developers List
> Betreff: Need help releasing IVY project in JIRA
> 
> It looks like I don't have relevant permissions in JIRA to release the
> IVY project. Can someone with appropriate permissions at
> https://issues.apache.org/jira/browse/IVY please rename the "master"
> release https://issues.apache.org/jira/projects/IVY/versions/12343084
> to "2.5.0" and officially release it in JIRA?
> 
> Once done, please also create a new "master" release so that newer
> fixes can be tracked against it.
> 
> -Jaikiran
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: AW: Need help releasing IVY project in JIRA

2019-10-24 Thread Jaikiran Pai
Thank you Jan.

-Jaikiran

On 24/10/19 11:32 PM, Jan Matèrne (jhm) wrote:
> done
>
> Jan
>
>> -Ursprüngliche Nachricht-
>> Von: Jaikiran Pai [mailto:jaiki...@apache.org]
>> Gesendet: Donnerstag, 24. Oktober 2019 13:42
>> An: Ant Developers List
>> Betreff: Need help releasing IVY project in JIRA
>>
>> It looks like I don't have relevant permissions in JIRA to release the
>> IVY project. Can someone with appropriate permissions at
>> https://issues.apache.org/jira/browse/IVY please rename the "master"
>> release https://issues.apache.org/jira/projects/IVY/versions/12343084
>> to "2.5.0" and officially release it in JIRA?
>>
>> Once done, please also create a new "master" release so that newer
>> fixes can be tracked against it.
>>
>> -Jaikiran
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
>> commands, e-mail: dev-h...@ant.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[ANNOUNCE] Apache Ivy 2.5.0 released

2019-10-24 Thread Jaikiran Pai
The Apache Ivy project is pleased to announce its 2.5.0 release.

Apache Ivy is a tool for managing (recording, tracking, resolving and
reporting) project dependencies, characterized by flexibility,
configurability, and tight integration with Apache Ant.

Key features of this 2.5.0 release are:

    - The minimum runtime Java version required is now Java 7

    - Ivy now uses BouncyCastle OpenPGP API 1.59. Due to the non
backward compatibility of that library, earlier versions are not supported.

    - Ivy now uses HttpComponents HttpClient 4.5.x version with HTTP
backed resolvers. Users are expected to have this version of the library
(and its dependencies) in their runtime classpath if they want to use
such resolvers. The previous (similarly named but not the same)
commons-httpclient library is no longer used or supported.
(https://issues.apache.org/jira/browse/IVY-1563)


Other than this, there have been numerous issues that have been fixed
(since 2.4.0) and some enhancements too. The complete set of changes is
available in release notes here
https://ant.apache.org/ivy/history/2.5.0/release-notes.html

Migration note:

Users moving from 2.5.0-rc1 are highly recommend to use a fresh/new
local Ivy cache directory for this release, to avoid certain issues with
metadata files that might have been cached in the local directory, from
previous version of Ivy.

Issues should be reported to:
https://issues.apache.org/jira/browse/IVY

Download the release at:
https://ant.apache.org/ivy/download.cgi

More information can be found on the Ivy website:
https://ant.apache.org/ivy/

- Jaikiran, on behalf of Apache Ivy team




signature.asc
Description: OpenPGP digital signature


AW: AW: [VOTE] Release Ivy 2.5.0 based on RC1

2019-10-24 Thread jhm
> > Just a question: there is a file fr\jayasoft\ivy\ant\antlib.xml which
> seems to be a copy of org\apache\ivy\ant\antlib.xml. Is it for BWC?
> Yes, looks like it.
> https://github.com/apache/ant-ivy/blob/master/build.xml#L263. It was
> done way back in 2007 and I don't think anyone uses that reference
> anymore. After this release, maybe we can stop copying and releasing
> that file.


Done


> >
> > Hello-Ivy-Example:
> > - run with "ant -lib ..\..\..\ivy-2.5.0.jar run"
> > --> Ivy starts
> > --> Ivy vesion 2.5.0
> > --> Problems with downloading the dependencies:
> >
> > [ivy:retrieve]  found commons-lang#commons-lang;2.6 in public
> > [ivy:retrieve] You probably access the destination server through a proxy 
> > server that is not well configured.
> > Another try:
> >   ant -lib ..\..\..\ivy-2.5.0.jar -autoproxy run and that worked.
> 
> I gave this example a try with this released version and it went fine
> without those warnings or errors. I suspect your Ivy cache probably had
> already downloaded the metadata/resources previously using some other
> "resolver"?

Deleted %userprofile%/.ivy2 and it worked without the -autoproxy.


Jan



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] asfgit merged pull request #104: Correct a typo

2019-10-24 Thread GitBox
asfgit merged pull request #104: Correct a typo
URL: https://github.com/apache/ant/pull/104
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] janmaterne commented on issue #104: Correct a typo

2019-10-24 Thread GitBox
janmaterne commented on issue #104: Correct a typo
URL: https://github.com/apache/ant/pull/104#issuecomment-546226699
 
 
   Merged. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] jaikiran commented on a change in pull request #106: Support SSH config file in the ssh tasks

2019-10-24 Thread GitBox
jaikiran commented on a change in pull request #106: Support SSH config file in 
the ssh tasks
URL: https://github.com/apache/ant/pull/106#discussion_r338909104
 
 

 ##
 File path: src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHBase.java
 ##
 @@ -235,6 +259,37 @@ public void init() throws BuildException {
 this.port = SSH_PORT;
 }
 
+/**
+ * Load the SSH configuration file.
+ * @throws BuildException on error
+ */
+protected void loadSshConfig() throws BuildException {
+if (sshConfig != null) {
+if (!new File(sshConfig).exists()) {
+throw new BuildException("The SSH configuration file specified 
doesn't exist: " + sshConfig);
+}
+
+log("Loading SSH configuration file " + sshConfig, 
Project.MSG_DEBUG);
+ConfigRepository.Config config = null;
+try {
+config = OpenSSHConfig.parseFile(sshConfig).getConfig(host);
+} catch (IOException e) {
+throw new BuildException("Failed to load the SSH configuration 
file " + sshConfig, e);
+}
+
+host = config.getHostname();
+
+if (userInfo.getName() == null) {
 
 Review comment:
   Should this check perhaps happen before even trying to load the `sshConfig` 
file? So as to avoid the whole loading and parsing of the file?
   
   Perhaps load the file only if userInfo doesn't have the name or keyfile 
available?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: AW: AW: [VOTE] Release Ivy 2.5.0 based on RC1

2019-10-24 Thread Jaikiran Pai


On 25/10/19 12:13 PM, Jan Matèrne (jhm) wrote:
>>> Just a question: there is a file fr\jayasoft\ivy\ant\antlib.xml which
>> seems to be a copy of org\apache\ivy\ant\antlib.xml. Is it for BWC?
>> Yes, looks like it.
>> https://github.com/apache/ant-ivy/blob/master/build.xml#L263. It was
>> done way back in 2007 and I don't think anyone uses that reference
>> anymore. After this release, maybe we can stop copying and releasing
>> that file.
>
> Done

Thank you Jan.


>
>>> Hello-Ivy-Example:
>>> - run with "ant -lib ..\..\..\ivy-2.5.0.jar run"
>>> --> Ivy starts
>>> --> Ivy vesion 2.5.0
>>> --> Problems with downloading the dependencies:
>>>
>>> [ivy:retrieve]  found commons-lang#commons-lang;2.6 in public
>>> [ivy:retrieve] You probably access the destination server through a proxy 
>>> server that is not well configured.
>>> Another try:
>>>   ant -lib ..\..\..\ivy-2.5.0.jar -autoproxy run and that worked.
>> I gave this example a try with this released version and it went fine
>> without those warnings or errors. I suspect your Ivy cache probably had
>> already downloaded the metadata/resources previously using some other
>> "resolver"?
> Deleted %userprofile%/.ivy2 and it worked without the -autoproxy.
>
Happy to hear that.

-Jaikiran


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] jaikiran commented on issue #106: Support SSH config file in the ssh tasks

2019-10-24 Thread GitBox
jaikiran commented on issue #106: Support SSH config file in the ssh tasks
URL: https://github.com/apache/ant/pull/106#issuecomment-546228211
 
 
   @ebourg This looks good to me. Thank you for providing this patch - looks 
really useful. I just have relatively minor comment that I have added to this 
PR. Once we decide on that, I'll go ahead and merge this.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org