Re: ant git commit: Use isEmpty() in tasks
On 2018-04-06, wrote:
> http://git-wip-us.apache.org/repos/asf/ant/blob/73bda1fb/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
> --
> diff --git a/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
> b/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
> index 3ac33f5..7beac61 100644
> --- a/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
b/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
> @@ -65,7 +65,7 @@ public class BindTargets extends Task {
> }
> if (getOwningTarget() == null
> -|| !"".equals(getOwningTarget().getName())) {
> +|| getOwningTarget().getName().isEmpty()) {
> throw new BuildException("bindtargets only allowed as a
> top-level task");
> }
You've reverse the logic by accident.
This broke running the tests locally as well as in Jenkins, I've fixed
it now.
Stefan
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #:
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487214 In src/main/org/apache/tools/ant/Project.java: In src/main/org/apache/tools/ant/Project.java on line 1831: this changes the output in the case of `roots.length == 0`, the "build sequence ..." would now not be logged on that case. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #:
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487270 In src/main/org/apache/tools/ant/XmlLogger.java: In src/main/org/apache/tools/ant/XmlLogger.java on line 210: the debugging code will no longer work after the change, so we better remove it entirely. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #:
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487413 In src/main/org/apache/tools/ant/taskdefs/Concat.java: In src/main/org/apache/tools/ant/taskdefs/Concat.java on line 597: Even though the existing code causes a deprecation warning, the way the methods called each other was correct because of backwards compatibility. A subclass that has overridden `setForce` will get its method called in 1.10.3 if `setOverwrite` is invoked, after your change it no longer will. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #:
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487485 In src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java: In src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java on line 699: see https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#r28487413 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #:
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487664 In src/main/org/apache/tools/ant/util/LazyHashtable.java: In src/main/org/apache/tools/ant/util/LazyHashtable.java on line 32: This probably breaks backwards compatibility as `LazyHashtable` is not final and subclasses may exist. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Mass changes to various projects under Ant umbrella - should we be doing it?
Le 7 avr. 2018 à 14:13, Gintautas Grigelionis a écrit : > > I sense a personal attack using broad, generalised accusations :-) > Could we please stop the inflammatory comments and be more to the point? Please don’t. Nothing is personal here. Jaikiran used « we ». Even if you are the author of the majority of the patches, people are reviewing it, people are finding errors and fixing them afterwards, this is a community effort. Thus this is a community discussion. I have not been reading ant-dev lately, so I cannot comment much about the last patches. For a while now I have not been involved much, but probably the last reviews of patches bored me enough so I lost track of the dev community entirely. Nicolas - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Ivy release
The last thread about a release has been stuck in the discussion about which PR, patch or Jira needed to be tackled before releasing. I suggest we just move forward with the current master. I volunteer to build a 2.5.0-rc1. Nicolas - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Ivy release
2018-04-09 17:20 GMT+00:00 Nicolas Lalevée : > The last thread about a release has been stuck in the discussion about > which PR, patch or Jira needed to be tackled before releasing. I suggest we > just move forward with the current master. I volunteer to build a 2.5.0-rc1. > > Nicolas > +1; maybe consider merging the recent proposal by Greg [1] or PR#63/64. Gintas [1] https://github.com/apache/ant-ivy/commit/d06e3bc
Re: Mass changes to various projects under Ant umbrella - should we be doing it?
2018-04-09 16:48 GMT+00:00 Nicolas Lalevée : > I have not been reading ant-dev lately, so I cannot comment much about the > last patches. For a while now I have not been involved much, but probably > the last reviews of patches bored me enough so I lost track of the dev > community entirely. > > Nicolas > Sorry for being boring; glad to have you back. Gintas
Re: Mass changes to various projects under Ant umbrella - should we be doing it?
2018-04-08 16:13 GMT+00:00 Stefan Bodewig : > On 2018-04-07, Gintautas Grigelionis wrote: > > > Java is a language with the syntax that changes and tries to accomodate > new > > patterns that make programming more efficient. > > Some of the patterns you've been changign don't fall into this category > for me. Switching if/else blocks, colapsing ifs or removing parens from > longer boolean expressions because you happend to remember && binds > stronger than || is not something that makes reading and understanding > the code more efficient IMHO > > Code is read far more often than written - this is probably even more > true for open source code. If we wanted to optimize then my vote would > go to optimize for readablity and clarity. I'm not saying the existing > code is readable. Readability certainly is highly subjective, as is > "efficient programming". > Agreed. > > We should try to use these patterns everywhere because uniformity aids > > comprehension. > > Here we have to agree that we disagree. Small diffs are more important > than uniformity to me. > Agreed. > Old code is not a golden code, it's a rotten code. > > Now it is my turn to feel offended. Our old code certainly is not > golden. I certainly have written (and every day write) bad code, but > I've never written rotten code. > Sorry for the slip. > I don't believe woking well tested code rots. Code rot is something that > happends when code doesn't get adapted to changing environments or > requirements. This is not the case here. I wrote earlier that I was about to review the unit tests. I was particularly unhappy about the root-property hack for an ancient deficiency in Surefire. I consider my previous commits a sort of a groundwork for refactorisation of JUnit tests. Would you bear with me if I commit the changes to the tests? Given the previous discussion, I would accept a "no". Gintas
Re: Mass changes to various projects under Ant umbrella - should we be doing it?
> Le 9 avr. 2018 à 20:46, Gintautas Grigelionis a > écrit : > > 2018-04-09 16:48 GMT+00:00 Nicolas Lalevée : > >> I have not been reading ant-dev lately, so I cannot comment much about the >> last patches. For a while now I have not been involved much, but probably >> the last reviews of patches bored me enough so I lost track of the dev >> community entirely. >> >> Nicolas >> > > Sorry for being boring Again, it is not you. It is the « code cleaning ». And there is always boring stuff to do. We are discussing here how much we can handle, as a community. Nicolas - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Ivy release
+1. Thanks Nicolas. -Jaikiran On Monday, April 9, 2018, Nicolas Lalevée wrote: > The last thread about a release has been stuck in the discussion about which PR, patch or Jira needed to be tackled before releasing. I suggest we just move forward with the current master. I volunteer to build a 2.5.0-rc1. > > Nicolas > > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
[GitHub] ant pull request #:
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/4b14d85f11b9a7728dcd2d9420551fd28bf8f45e#commitcomment-28500962 In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java: In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java on line 99: I think you have dropped the `isJavaIdentifierStart` test for the first character. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
