Re: JDK 10: Release Candidate & JDK 11 Early Access builds available

2018-03-05 Thread Stefan Bodewig
Hi all

no surprises with Java10 in Ant land. Of course some of our tests that
use rmic -iiop/-idl have been broken on Java11 because of JEP320.

Starting with Ant 1.10.3 and 1.9.11 Ant is going to fail with a more
useful error message and tests have been adapted.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-03-05 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/5aa1e8eff81ad6005e62587cdaaa962fce1105ea#commitcomment-27927763
  
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java:
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java on 
line 476:
This the old way to do it, ExpectedException should be used instead.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-03-05 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/e06168ca78b819a21924f3716b99e3621b4855ef#commitcomment-27927813
  
It's not quite appropriate here, but we need a new release of Ivy... :cry: 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-03-05 Thread bodewig
Github user bodewig commented on the pull request:


https://github.com/apache/ant/commit/5aa1e8eff81ad6005e62587cdaaa962fce1105ea#commitcomment-27928590
  
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java:
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java on 
line 476:
combined with "expect this exception only when run on Java 11 and expect no 
exception otherwise"?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-03-05 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/5aa1e8eff81ad6005e62587cdaaa962fce1105ea#commitcomment-27929054
  
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java:
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java on 
line 476:
I meant "instead of `try { ...; fail ... } catch { ... }`"; you can still 
put expected exception rule inside an `if {} else {}` or use assume to get rid 
of that if/else.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: JDK 10: Release Candidate & JDK 11 Early Access builds available

2018-03-05 Thread Rory O'Donnell

Thanks for the feedback Stefan!



On 05/03/2018 11:52, Stefan Bodewig wrote:

Hi all

no surprises with Java10 in Ant land. Of course some of our tests that
use rmic -iiop/-idl have been broken on Java11 because of JEP320.

Starting with Ant 1.10.3 and 1.9.11 Ant is going to fail with a more
useful error message and tests have been adapted.

Stefan


--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin,Ireland


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant documentation

2018-03-05 Thread Gintautas Grigelionis
2018-03-02 13:13 GMT+01:00 Stefan Bodewig :

> On 2018-03-02, Gintautas Grigelionis wrote:
>
> > 2018-03-02 9:54 GMT+01:00 Stefan Bodewig :
>
> >> On 2018-03-01, Stefan Bodewig wrote:
>
>  On Thu, Mar 1, 2018 at 7:28 AM, Gintautas Grigelionis <
>  g.grigelio...@gmail.com> wrote:
>
> > I tried then to use the replacement tags as consistently as
> > possible in such a large body of text, but I realised that we
> > perhaps need a kind of a style guide. Would you like to discuss
> > it? Where would it best fit in the source code tree?
>
> >>> I'm not convinced I want to have any kind of rules keep people from
> >>> writing docs :-)
>
> >> This comment isn't fair and I should have known better, sorry.
>
> > I didn't even notice your remark, really :-)
>
> That's good. Sometimes I realize when I'm being a jerk as in this case,
> often I don't (and I appreciate people telling me when that happens).
>
> > All I wanted to say, keeping things visually consistent helps
> > understanding.  So, my simple set of rules is:
>
> >-  is for attributes
> >-  is for values
> >-  is for shell variable names/property name/CLI options and
> input
> >(should change that to , really)
> >-  is for everything else, like filenames etc
>
> Looks reasonable.
>

I feel a need to put this as a note somewhere in the manual. Also, target
attributes for hyperlinks must be reviewed, please see below for a snippet
of my browser dev console log :-(

Gintas

Mixed Content: The page at '' was loaded over HTTPS, but requested an
insecure resource ''. This content should also be served over HTTPS.
ide.html:1 Mixed Content: The page at 'https://rawgit.com/apache/
ant/master/manual/index.html' was loaded over HTTPS, but requested an
insecure resource 'http://jdee.sourceforge.net/'. This content should also
be served over HTTPS.
jdee.sourceforge.net/:8 Mixed Content: The page at '
https://rawgit.com/apache/ant/master/manual/index.html' was loaded over
HTTPS, but requested an insecure resource 'http://jdee.sourceforge.net/
toc.html'. This content should also be served over HTTPS.
jdee.sourceforge.net/:9 Mixed Content: The page at '
https://rawgit.com/apache/ant/master/manual/index.html' was loaded over
HTTPS, but requested an insecure resource 'http://jdee.sourceforge.net/
rootpage.html'. This content should also be served over HTTPS.
ide.html:1 Mixed Content: The page at 'https://rawgit.com/apache/
ant/master/manual/index.html' was loaded over HTTPS, but requested an
insecure resource 'http://ant.netbeans.org/'. This content should also be
served over HTTPS.
ide.html:1 Mixed Content: The page at 'https://rawgit.com/apache/
ant/master/manual/index.html' was loaded over HTTPS, but requested an
insecure resource 'http://ant.netbeans.org/'. This content should also be
served over HTTPS.
jdee.sourceforge.net/toc.html:63 Mixed Content: The page at '
https://rawgit.com/apache/ant/master/manual/index.html' was loaded over
HTTPS, but requested an insecure image 'http://jdee.sourceforge.net/
images/scoutsel.gif'. This content should also be served over HTTPS.
jdee.sourceforge.net/rootpage.html:17 Mixed Content: The page at '
https://rawgit.com/apache/ant/master/manual/index.html' was loaded over
HTTPS, but requested an insecure image 'http://jdee.sourceforge.net/
images/jdelogo.gif'. This content should also be served over HTTPS.
index.html:1 Refused to display 'https://www.jetbrains.com/idea/' in a
frame because it set 'X-Frame-Options' to 'deny'.
netbeans.org/projects/ant/ Failed to load resource: the server responded
with a status of 404 (Not Found)
data:,:1 Refused to display 'https://netbeans.org/projects/ant/' in a frame
because an ancestor violates the following Content Security Policy
directive: "frame-ancestors 'self'".
netbeans.org/projects/ant/ Failed to load resource: the server responded
with a status of 404 (Not Found)
data:,:1 Refused to display 'https://netbeans.org/projects/ant/' in a frame
because an ancestor violates the following Content Security Policy
directive: "frame-ancestors 'self'".
www.ibm.com/developerworks/offers/wsad2.html:1 Refused to apply style from '
https://www.ibm.com/us-en/' because its MIME type ('text/html') is not a
supported stylesheet MIME type, and strict MIME checking is enabled.