Bug#612447: have the problems been addressed?
On Mon, Nov 03, 2014 at 09:09:31PM +0100, Tomas Pospisek wrote: > Hello, > > in #612447 [1] you are describing a few problems with the back then new > design of the Debian page. > > I have tried to reproduce them and as far as I can see there have been > addressed (maybe I didn't understand a few of them?). > > Could you please recheck and possibly close the bug report? > *t > > [1] http://bugs.debian.org/612447 Looks fine to me. MfG Goswin -- To UNSUBSCRIBE, email to debian-www-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141104091525.GA8887@frosties
Bug#657557: [PATCH] Alternate patch for missing long descriptions
Package: www.debian.org
Followup-For: Bug #657557
Hi,
Cyril and I disagree about the cause for the missing description and
the fix for it. So someone impartial please look over both out patches
and see which makes more sense. In both cases the english translations
must be added to ddtplangs [Patch 1/4] from Cyril [1], I didn't
want to repost that.
Here is how I see the problem:
1) Originaly Packages.bz2 contained the long description and no
description-md5 field (still does for older releases).
2) Translations are indexed by the md5 of the original long description.
3) bin/parse-packages computes description-md5 and stores it in the
packages database.
4) When generating the webpages the description-md5 is used to lookup
the translated description with fallback to english and the
original description.
But in sid the Packages.bz2 files now contain a description-md5 field
and only the short description instead of the short and long
description. This cause the computation in (3) above to compute the
md5sum of only the short description and then the translation lookup
in (4) fails to find a translation and falls back to the original
description, which is only the short description.
Now my patch (attached) fixes this problem by only computing the
description-md5 field if it is missing in Packages.bz2. A simple one
line fix. The rest of the code already does all the right things and
looks up the translation correclty including falling back to 'en' as
needed. E.g.:
- http://localhost/sid/gcc ---
Package: gcc (4:4.6.2-4)
GNU C compiler
This is the GNU C compiler, a fairly portable optimizing compiler for C.
This is a dependency package providing the default GNU C compiler.
Tags: Software Development: Compiler, C Development, User Interface:
interface::commandline, role::metapackage, Role: Program, Application Suite:
suite::gnu, works-with::software:source
Other Packages Related to gcc
...
- http://localhost/de/sid/gcc
Paket: gcc (4:4.6.2-4)
Der GNU-C-Compiler
Dies ist der GNU-C-Compiler, ein recht portabler, optimierender C-Compiler.
Dies ist ein Abhängigkeitspaket, welches den Standard-GNU-C-Compiler zur
Verfügung stellt.
Markierungen: Software-Entwicklung: Compiler, C-Entwicklung,
Benutzer-Schnittstellen: interface::commandline, role::metapackage, Rolle:
Programm, Anwendungs-Suite: suite::gnu, works-with::software:source
Andere Pakete mit Bezug zu gcc
...
-- http://localhost/de/sid/3depict --
Paket: 3depict (0.0.9-1 und andere)
visualisation and analysis for single valued point data
This program provides a graphical interface for the scientific analysis of real
valued point data (x,y,z,value). This is primarily targeted towards Atom probe
tomography applications, but may prove useful to other applications as well.
Markierungen: Benutzer-Schnittstellen: X-Window-System, Rolle: Programm,
GUI-Baukasten: wxWidgets, Zweck: use::analysing, x11::application
Andere Pakete mit Bezug zu 3depict
--
3depict has no german translation so the english "translation" is used
as it should.
Correct me if I'm wrong but here is how I understand Cyrils patch: It
works by fixing the symptom instead of the problem. In [PATCH 2/4] it
checks if the Packages.bz2 file contains an description-md5 field, If
so it looks up the english translation for the package and replaces
the description with the english translation, thereby restoring the
long description for the package (line 146 with his patch). And now
that the long description has been restored the computation of
description-md5 a few lines later computes to the right value, the one
that is already present. And with the right description-md5 value the
translation lookup when generating the pages functions again. [PATCH
3/4] and [PATCH 4/4] then tidy things up and make it possible to do an
english only run for bin/parse-translations. The reason for this is
that with his patch bin/parse-packages requires an in-sync translation
database to function.
MfG
Goswin
1) http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=657557#29
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.1.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=de_DE (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash
diff --git a/bin/parse-packages b/bin/parse-packages
index a1c8d98..1cb2075 100755
--- a/bin/parse-packages
+++ b/bin/parse-packages
@@ -142,7 +142,7 @@ for my $suite (@SUITES) {
$descriptions[$did] = $descr;
$descriptions{$descr} = $did;
}
- $data{'description-md5'} = Digest::MD5::md5_hex($data{'description'}, "\n");
+ $data{'description-md5'} = Digest::MD5::md5_hex($data{'description'}, "\n") if (!exists($data{'description-md5'}));
$data{'description'} =
Bug#657557: [PATCH] Alternate patch for missing long descriptions
Cyril Brulebois writes:
> For the sake of getting my fellow packages/translations maintainers to
> get the whole picture since you insist so much on proposing a wrong
> solution and calling mine âpapering over the bugâ, I'll reply anyway.
Please don't make up quotes I never said. And thanks for finally
responding with more than "wrong" to support your case even if it
doesn't explain why long description in the package db are neccessary or
give an example what remains broken with just my patch.
> Goswin von Brederlow (22/02/2012):
>> Now my patch (attached) fixes this problem by only computing the
>> description-md5 field if it is missing in Packages.bz2. A simple one
>> line fix. The rest of the code already does all the right things and
>> looks up the translation correclty including falling back to 'en' as
>> needed.
>
> That's only if you're interesting in getting the translations back.
Which is what is done when generating the webpages so this seems rather
important to me.
> Now
> go read the block of code right above $data{'description-md5'}â¦
Let see:
# we add some additional data here
my $descr = "$data{'description'}\000$data{'package'}\000"
.($data{'tag'}||'');
Description in database format.
my $sdescr = $data{'description'};
$sdescr =~ s/\n.*//os;
Description in text format.
my $did = undef;
if (exists($descriptions{$descr})) {
$did = $descriptions{$descr};
} else {
$did = 1 + $#descriptions;
$descriptions[$did] = $descr;
$descriptions{$descr} = $did;
}
Reuse the same $did if the description already exists.
Ok, so without your patch this bit of code will share a $did if the
short description matches. That certainly differs from what it used to
do. So lets see what effect that has:
- http://localhost/sid/comixcursors -
Package: comixcursors (0.7.2-2)
transitional dummy package
ComixCursors is a set of mouse pointer themes for X11 in the style of
comic-book art.
This package is transitional to install the right-handed, translucent cursor
set, which is now in the \u2018comixcursors-righthanded\u2019 package.
Tags: Role: Application Data, Dummy Package, X Window System: Theme
Packages providing comixcursors
...
- http://localhost/sid/ttf-aoyagi-soseki -
Package: ttf-aoyagi-soseki (20070207-6)
transitional dummy package
This package is a dummy transitional package. It can be safely removed.
Tags: Culture: Japanese, Made Of: Font, Role: Standalone Data, Dummy Package
...
--
Oh wait, we always use the description from the translation file even if
it is the english "translation".
>> Correct me if I'm wrong but here is how I understand Cyrils patch: It
>> works by fixing the symptom instead of the problem. In [PATCH 2/4] it
>> checks if the Packages.bz2 file contains an description-md5 field, If
>> so it looks up the english translation for the package and replaces
>> the description with the english translation, thereby restoring the
>> long description for the package (line 146 with his patch).
>
> ⦠and this is needed so that storing the description in the database
> (what I pointed to above: $descr, $sdescr, etc.) happens properly,
> meaning: the long description, not the short one only.
True. Without your patch the long description is no longer stored in the
package database, only in the translations database.
What you haven't explained is why that is needed. Without your patch the
packages_descriptions.db (ever only used by bin/parse-packages) and
descriptions_packages.db (used in DoShow.pm and Search.pm) will have
bogus entries.
But the package pages show the translation and searching in the
descriptions also seems to properly look into the english translations.
E.g. searching for "It can be safely removed" gives among others:
--- http://localhost/search?searchon=all&keywords=It+can+be+safely+removed ---
...
Package gnash-opengl
sid (unstable) (oldlibs): dummy package for gnash-opengl removal
0.8.10-3: all
- http://localhost/sid/gnash-opengl -
Package: gnash-opengl (0.8.10-3)
dummy package for gnash-opengl removal
This package is a transitional package for gnash-opengl removal.
It can be safely removed when Gnash is installed.
Tags: User Interface: X Window System, Role: Dummy Package, Program, Interface
Toolkit: uitoolkit::gtk, use::playing, Supports Format: SWF, ShockWave Flash,
Works with: works-wit
Bug#717288: Debian Description Translation Project links are dead
Package: www.debian.org Severity: normal Hi, the links to the Debian Description Translation Project (http://ddtp.debian.net/) on http://www.debian.org/international/l10n/ddtp are dead. This could be a server outage or something worse (hopefully not). Anyone know what the status of the DDTP server is? MfG Goswin PS: If there is a better package to address this outage please forward this bug there. -- To UNSUBSCRIBE, email to debian-www-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130718215638.32228.15294.reportbug@frosties.localnet
Bug#542783: Please sort votes latest first
Package: www.debian.org Severity: normal Hi, on http://www.debian.org/vote/ there is a list of decided votes in the side bar. I believe it would be better to sort that list with the latest vote on top. MfG Goswin -- System Information: Debian Release: squeeze/sid APT prefers unstable-i386 APT policy: (1001, 'unstable-i386'), (500, 'unstable'), (400, 'experimental-i386'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.29.4-frosties-2 (SMP w/2 CPU cores) Locale: LANG=C, LC_CTYPE=de_DE (charmap=ISO-8859-1) Shell: /bin/sh linked to /bin/bash -- To UNSUBSCRIBE, email to debian-www-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
