Re: Tidy validation failed

2020-02-16 Thread Shlomi Fish
Hi Boyuan Yang,

On Fri, 14 Feb 2020 13:55:02 -0500
Boyuan Yang  wrote:

> Hi debian-www members,
> 
> 在 2020-02-14五的 15:49 +,Debian Webmaster写道:
> > *** /srv/www.debian.org/www/distrib/pre-installed.zh-cn.html
> > line 666 column 3 - Warning: plain text isn't allowed in  elements
> > line 659 column 3 - Info:  previously mentioned
> > 
> > --
> >  You received this mail for the language code zh-cn.
> >  Please edit webwml/english/devel/website/validation.data if this is not
> > accurate.
> >  Please also update webwml/english/devel/website/ with the new
> > coordinator(s) data.  
> 
> I have been receiving this error for days but have no idea on how to resolve
> the issue. The rendered HTML is indeed wrong but the source seems to be using
> valid grammar. Can anyone take a look into it?
> 

It seems to render into a valid HTML here (mageia v8 x86-64 ; latest wml from
https://github.com/thewml/website-meta-language ):

https://www.shlomifish.org/Files/files/text/pre-installed.zh-cn.html

Regards,

Shlomi

-- 

Shlomi Fish   https://www.shlomifish.org/
https://ccmixter.org/files/destinazione_altrove/49997 - “Paint The Sky”

Bugs are too afraid to reproduce on Chuck Norris’ computer. As a result, when
he uses Microsoft Windows, it behaves just like a Linux system.
— http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/

Please reply to list if it's a mailing list post - http://shlom.in/reply .



Re: Tidy validation failed

2020-02-16 Thread Holger Wansing
Hi,

Shlomi Fish  wrote:
> Hi Boyuan Yang,
> 
> On Fri, 14 Feb 2020 13:55:02 -0500
> Boyuan Yang  wrote:
> 
> > Hi debian-www members,
> > 
> > 在 2020-02-14五的 15:49 +,Debian Webmaster写道:
> > > *** /srv/www.debian.org/www/distrib/pre-installed.zh-cn.html
> > > line 666 column 3 - Warning: plain text isn't allowed in  elements
> > > line 659 column 3 - Info:  previously mentioned
> > > 
> > > --
> > >  You received this mail for the language code zh-cn.
> > >  Please edit webwml/english/devel/website/validation.data if this is not
> > > accurate.
> > >  Please also update webwml/english/devel/website/ with the new
> > > coordinator(s) data.  
> > 
> > I have been receiving this error for days but have no idea on how to resolve
> > the issue. The rendered HTML is indeed wrong but the source seems to be 
> > using
> > valid grammar. Can anyone take a look into it?

@Boyuan Yang:
I did not receive your mail from 14-02-2020 in my mailbox (don't know why), so 
I wasn't aware of that problem until today. Sorry


The problem is going down to a wrong formatting in one of my commits:
https://salsa.debian.org/webmaster-team/webwml/commit/deaf077937154ab490919e74435f78e874db5d69

which I corrected a day later with
https://salsa.debian.org/webmaster-team/webwml/commit/a09e18d7cf58fa154433c15f44e6c6a52b8ab7d3


But for some reason, the Chinese variant of that page does not get newly
build now, it still has the wrong formatting and the superfluous
Poland" />
within the Polish listing.


I remember that this happened in the past as well in some special
circumstances (however I did not found that in the debian-www list archive
now).
The point is: that page includes "english/distrib/pre-installed.data"
to inject the list content from the English folder into all languages
pages. Now a change happened in the English part (pre-installed.data) and the
Chinese page did not get the newly build trigger.


To trigger a new build of the Chinese page, we could do another commit for the
Chinese source code, and indeed I found something, that looks incorrect to me
in chinese/distrib/pre-installed.wml
(This spurious line is not the reason for the missing-build situation from 
above, but we should fix it, if it's wrong, anyway.)

Holger




diff --git a/chinese/distrib/pre-installed.wml 
b/chinese/distrib/pre-installed.wml
index 9de72418a35..c0387fa4f97 100644
--- a/chinese/distrib/pre-installed.wml
+++ b/chinese/distrib/pre-installed.wml
@@ -28,21 +28,22 @@
 #Information for hardware vendors
 硬體廠商的
 
 #
 #If you wish to be listed on this page, send mail to
 #mailto:webmas...@debian.org";>webmas...@debian.org
 #providing the following information:
 如果您希望被列入這個網頁的廠商名單中,請以英文撰寫
 寄電子郵件到
 mailto:preinstallvend...@debian.org";>preinstallvend...@debian.org
-並提供以下:
+並提供以下資訊:
+
 
 
 #company name
 公司名稱
 #URL
 網站 URL
 #e-mail address
 電子郵件地址
 #phone number (if accept international orders, include international 
dialing prefix)
 電話號碼(如果接受外國訂購,請加上國碼)



-- 
Holger Wansing 
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076



Re: Tidy validation failed

2020-02-16 Thread Boyuan Yang
在 2020-02-16日的 17:41 +0100,Holger Wansing写道:
> Hi,
> 
> Shlomi Fish  wrote:
> > Hi Boyuan Yang,
> > 
> > On Fri, 14 Feb 2020 13:55:02 -0500
> > Boyuan Yang  wrote:
> > 
> > > Hi debian-www members,
> > > 
> > > 在 2020-02-14五的 15:49 +,Debian Webmaster写道:
> > > > *** /srv/www.debian.org/www/distrib/pre-installed.zh-cn.html
> > > > line 666 column 3 - Warning: plain text isn't allowed in  elements
> > > > line 659 column 3 - Info:  previously mentioned
> > > > 
> > > > --
> > > >  You received this mail for the language code zh-cn.
> > > >  Please edit webwml/english/devel/website/validation.data if this is
> > > > not
> > > > accurate.
> > > >  Please also update webwml/english/devel/website/ with the new
> > > > coordinator(s) data.  
> > > 
> > > I have been receiving this error for days but have no idea on how to
> > > resolve
> > > the issue. The rendered HTML is indeed wrong but the source seems to be
> > > using
> > > valid grammar. Can anyone take a look into it?
> 
> @Boyuan Yang:
> I did not receive your mail from 14-02-2020 in my mailbox (don't know why),
> so 
> I wasn't aware of that problem until today. Sorry
> 
> 
> The problem is going down to a wrong formatting in one of my commits:
> https://salsa.debian.org/webmaster-team/webwml/commit/deaf077937154ab490919e74435f78e874db5d69
> 
> which I corrected a day later with
> https://salsa.debian.org/webmaster-team/webwml/commit/a09e18d7cf58fa154433c15f44e6c6a52b8ab7d3
> 
> 
> But for some reason, the Chinese variant of that page does not get newly
> build now, it still has the wrong formatting and the superfluous
>   Poland" />
> within the Polish listing.
> 
> 
> I remember that this happened in the past as well in some special
> circumstances (however I did not found that in the debian-www list archive
> now).
> The point is: that page includes "english/distrib/pre-installed.data"
> to inject the list content from the English folder into all languages
> pages. Now a change happened in the English part (pre-installed.data) and
> the
> Chinese page did not get the newly build trigger.
> 
> 
> To trigger a new build of the Chinese page, we could do another commit for
> the
> Chinese source code, and indeed I found something, that looks incorrect to
> me
> in chinese/distrib/pre-installed.wml
> (This spurious line is not the reason for the missing-build situation from 
> above, but we should fix it, if it's wrong, anyway.)

Thanks, now I know that we were hit by that old bug again. I'm going to
trigger a rebuild manually. All those existing grammar are valid, BTW.

-- 
Thanks,
Boyuan Yang



Re: Tidy validation failed

2020-02-16 Thread Holger Wansing
Hi,

Boyuan Yang  wrote:
> > To trigger a new build of the Chinese page, we could do another commit for
> > the
> > Chinese source code, and indeed I found something, that looks incorrect to
> > me
> > in chinese/distrib/pre-installed.wml
> > (This spurious line is not the reason for the missing-build situation from 
> > above, but we should fix it, if it's wrong, anyway.)
> 
> Thanks, now I know that we were hit by that old bug again. I'm going to
> trigger a rebuild manually. All those existing grammar are valid, BTW.

Sorry for asking again: what's the meaning behind this
並提供以下:
?
What is effectuated by that?


Moreover, there is a closing  tag missing after that line, you can
fix that as well, to trigger a rebuild.



Holger



-- 
Holger Wansing 
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076



Re: Tidy validation failed

2020-02-16 Thread Boyuan Yang
在 2020-02-16日的 18:38 +0100,Holger Wansing写道:
> Hi,
> 
> Boyuan Yang  wrote:
> > > To trigger a new build of the Chinese page, we could do another commit
> > > for
> > > the
> > > Chinese source code, and indeed I found something, that looks incorrect
> > > to
> > > me
> > > in chinese/distrib/pre-installed.wml
> > > (This spurious line is not the reason for the missing-build situation
> > > from 
> > > above, but we should fix it, if it's wrong, anyway.)
> > 
> > Thanks, now I know that we were hit by that old bug again. I'm going to
> > trigger a rebuild manually. All those existing grammar are valid, BTW.
> 
> Sorry for asking again: what's the meaning behind this
>   並提供以下:
> ?
> What is effectuated by that?

https://salsa.debian.org/webmaster-team/webwml/blob/8cda5906936c72d66336e7442f1e124135fe7045/chinese/bin/format_zh.pl#L43

It's a historical code that attempted to achieve automatic Chinese variant
transformation. Nowadays such transformation is largely handled by opencc [1]
but some old texts are still using it.

[1] https://tracker.debian.org/pkg/opencc

> Moreover, there is a closing  tag missing after that line, you can
> fix that as well, to trigger a rebuild.

Missing  tag is still valid under HTML 4.01 strict; this is the doctype
that www.debian.org is currently using. This is also valid in HTML5.

P.S. I guess we should be upgrading the default DOCTYPE to HTML5 someday.

P.P.S. I'm also a fan of XHTML-like grammar.

-- 
Thanks,
Boyuan Yang



Re: Tidy validation failed

2020-02-16 Thread Holger Wansing
Hi,

Boyuan Yang  wrote:
> 在 2020-02-16日的 18:38 +0100,Holger Wansing写道:
> > Sorry for asking again: what's the meaning behind this
> > 並提供以下:
> > ?
> > What is effectuated by that?
> 
> https://salsa.debian.org/webmaster-team/webwml/blob/8cda5906936c72d66336e7442f1e124135fe7045/chinese/bin/format_zh.pl#L43
> 
> It's a historical code that attempted to achieve automatic Chinese variant
> transformation. Nowadays such transformation is largely handled by opencc [1]
> but some old texts are still using it.

Ok, thanks for this explanation!

> [1] https://tracker.debian.org/pkg/opencc
> 
> > Moreover, there is a closing  tag missing after that line, you can
> > fix that as well, to trigger a rebuild.
> 
> Missing  tag is still valid under HTML 4.01 strict; this is the doctype
> that www.debian.org is currently using. This is also valid in HTML5.

Yes, currently it's not strictly needed, right.


Holger


-- 
Holger Wansing 
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076