Bug#473929: varkon: FTBFS: Nonexistent build-dependency: gcc-3.3
tag 473929 patch kthxbye Attached is a patch to use gcc-3.4 instead of gcc-3.3, because we need -fwritable-strings. It's still ugly, but there are new upstream varkon versions which presumably fix this. Fixing to use gcc 4 looks like a much larger patch. -- Tim Retout diff -u varkon-1.18A/debian/rules varkon-1.18A/debian/rules --- varkon-1.18A/debian/rules +++ varkon-1.18A/debian/rules @@ -18,7 +18,7 @@ dh_testdir mkdir -p bin - VARKON_ROOT=`pwd` make -C sources CC=gcc-3.3 + VARKON_ROOT=`pwd` make -C sources CC=gcc-3.4 touch build-stamp diff -u varkon-1.18A/debian/control varkon-1.18A/debian/control --- varkon-1.18A/debian/control +++ varkon-1.18A/debian/control @@ -2,7 +2,7 @@ Section: x11 Priority: optional Maintainer: Debian QA Group -Build-Depends: debhelper (>= 5), dpatch, libx11-dev, libgl1-mesa-dev, libglu1-mesa-dev, unixodbc-dev, gcc-3.3 +Build-Depends: debhelper (>= 5), dpatch, libx11-dev, libgl1-mesa-dev, libglu1-mesa-dev, unixodbc-dev, gcc-3.4 Standards-Version: 3.7.2 Package: varkon
Bug#473929: varkon: FTBFS: Nonexistent build-dependency: gcc-3.3
For bonus points, libxext-dev is missing from the Build-Depends if you want it to build in pbuilder. -- Tim Retout -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#449323: No crash
severity 449323 important kthxbye Rebuilding with debugging symbols (not easy - add 'debug' to the make call in debian/rules and remove the -DDEBUG from sources/GE/src/Makefile.linux to get it to build) and then adding 'gdb --args' to the shell script, it looks like varkon is exiting normally when the window is clicked. There's no crash. After selecting a job, you are probably meant to choose either a 2D or a 3D model from the dialog that appears. The package is not unusable, so I'm downgrading the severity to be non-RC. Fixing this myself might take a bit longer, because all the comments are in Swedish. There's a new upstream version, but I haven't tested whether it displays the same behaviour. -- Tim Retout -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#465376: varkon: bashism in /bin/sh script
There were two errors when I ran checkbashisms on the patched version.
Corrected patch attached.
--
Tim Retout
--- varkon-1.18A-new/debian/varkon.sh 2009-02-15 14:46:42.0 +
+++ varkon-1.18A/debian/varkon.sh 2009-02-17 01:21:08.0 +
@@ -20,8 +20,8 @@
while [ "$ans" != "y" -a "$ans" != "n" ] ; do
if [ "$ans" ] ; then echo "Please answer either \`y\' or \`n\'"; fi
echo "The directory where varkon stores the $2 does not exist."
- echo -e "\t$1"
- echo -n "Shall I create it? [Y|n] " > /dev/tty
+ printf "\t$1\n"
+ printf "Shall I create it? [Y|n] " > /dev/tty
read ans < /dev/tty
ans="`echo $ans | tr A-Z a-z`"
ans=${ans:-y}
@@ -92,7 +92,7 @@
}
# Check for root
-if [ $UID = 0 ]; then
+if [ $(id -ru) = 0 ]; then
# Check if variable and file $VARKON_INI exist
if [ -z $VARKON_INI ]; then
error "\$VARKON_INI not set"
@@ -180,10 +180,10 @@
while [ $change = 1 ] ; do
# Show the current configuration
echo
-echo -e "Configuration:\tcurrent (old)"
-echo -e "`if [ "$NEW_HTML_VIEWER" != "$HTML_VIEWER" ]; then echo -n '*'; else echo -n " "; fi`1 html_viewer:\t$NEW_HTML_VIEWER ($HTML_VIEWER)"
-echo -e "`if [ "$NEW_MBS_EDITOR" != "$MBS_EDITOR" ]; then echo -n '*'; else echo -n " "; fi`2 mbseditor:\t$NEW_MBS_EDITOR ($MBS_EDITOR)"
-echo -e "`if [ "$NEW_MBS_EMULATOR" != "$MBS_EMULATOR" ]; then echo -n '*'; else echo -n " "; fi`3 mbsemulator:\t$NEW_MBS_EMULATOR ($MBS_EMULATOR)"
+printf "Configuration:\tcurrent (old)\n"
+printf "`if [ "$NEW_HTML_VIEWER" != "$HTML_VIEWER" ]; then echo -n '*'; else echo -n " "; fi`1 html_viewer:\t$NEW_HTML_VIEWER ($HTML_VIEWER)\n"
+printf "`if [ "$NEW_MBS_EDITOR" != "$MBS_EDITOR" ]; then echo -n '*'; else echo -n " "; fi`2 mbseditor:\t$NEW_MBS_EDITOR ($MBS_EDITOR)\n"
+printf "`if [ "$NEW_MBS_EMULATOR" != "$MBS_EMULATOR" ]; then echo -n '*'; else echo -n " "; fi`3 mbsemulator:\t$NEW_MBS_EMULATOR ($MBS_EMULATOR)\n"
# Ask if user want to change anything
ans=""
@@ -336,7 +336,7 @@
# Source the system wide configuration
if [ -f $SYSINI ]; then
-source $SYSINI
+. $SYSINI
fi
# Check for "-h|-?|--help" in command options
@@ -395,7 +395,7 @@
# Source the user configuration
if [ -f $USERINI ]; then
-source $USERINI
+. $USERINI
fi
# Switch to configuration
Bug#514986: libmdbodbc doesn't work on Mono+Unixodbc
retitle 514986 SQLGetData() should return SQL_NO_DATA at end of data tags 514986 patch kthxbye -- Tim Retout -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
