Bug#518962: incorrect use of update-alternatives

[Nicolas Valcárcel]

Package: aterm
Version: 1.0.1-4
Severity: serious

Hi,

in aterm.postinst one can read:

# Add an alternative for aterm
update-alternatives --install /usr/bin/aterm aterm \
/usr/bin/aterm-xterm 30

which is incorrect because /usr/bin/aterm is a binary installed by
the terminator package and not a generic name.

P.S: please see Bug #509667 for more information.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=509667

-- 
Nicolas Valcárcel
Security Engineer
Custom Engineering Solutions Group
Canonical OEM Services
Mobile: +511 992 739 587
Key fingerprint = BCE4 27A0 D03E 55DE DA2D  BE06 891D 8DEE 6545 97FE
gpg --keyserver keyserver.ubuntu.com --recv-keys 654597FE


signature.asc
Description: This is a digitally signed message part

Bug#518962: Debdiff

[Nicolas Valcárcel]

Attaching debdiff fixing the problem.
-- 
Nicolas Valcárcel
Security Engineer
Custom Engineering Solutions Group
Canonical OEM Services
Mobile: +511 992 739 587
Key fingerprint = BCE4 27A0 D03E 55DE DA2D  BE06 891D 8DEE 6545 97FE
gpg --keyserver keyserver.ubuntu.com --recv-keys 654597FE
diff -u aterm-1.0.1/debian/aterm-ml.prerm aterm-1.0.1/debian/aterm-ml.prerm
--- aterm-1.0.1/debian/aterm-ml.prerm
+++ aterm-1.0.1/debian/aterm-ml.prerm
@@ -3,10 +3,10 @@
 # Script taken from Brian May's rxvt package
 
 if [ "$1" = remove ]; then
-	update-alternatives --remove aterm /usr/bin/katerm
-	update-alternatives --remove aterm /usr/bin/caterm
-	update-alternatives --remove aterm /usr/bin/gaterm
-	update-alternatives --remove aterm /usr/bin/taterm
+	update-alternatives --remove aterm /usr/bin/katerm || true
+	update-alternatives --remove aterm /usr/bin/caterm || true
+	update-alternatives --remove aterm /usr/bin/gaterm || true
+	update-alternatives --remove aterm /usr/bin/taterm || true
 	update-alternatives --remove x-terminal-emulator /usr/bin/katerm
 	update-alternatives --remove x-terminal-emulator /usr/bin/caterm
 	update-alternatives --remove x-terminal-emulator /usr/bin/gaterm
diff -u aterm-1.0.1/debian/aterm.prerm aterm-1.0.1/debian/aterm.prerm
--- aterm-1.0.1/debian/aterm.prerm
+++ aterm-1.0.1/debian/aterm.prerm
@@ -2,7 +2,7 @@
 # prerm for aterm
 
 if [ "$1" = remove ]; then
-	update-alternatives --remove aterm /usr/bin/aterm-xterm
+	update-alternatives --remove aterm /usr/bin/aterm-xterm || true
 	update-alternatives --remove x-terminal-emulator /usr/bin/aterm-xterm
 fi
 
diff -u aterm-1.0.1/debian/aterm.postinst aterm-1.0.1/debian/aterm.postinst
--- aterm-1.0.1/debian/aterm.postinst
+++ aterm-1.0.1/debian/aterm.postinst
@@ -2,9 +2,6 @@
 # postinst for aterm
 
 if [ "$1" = "configure" ]; then
-	# Add an alternative for aterm
-	update-alternatives --install /usr/bin/aterm aterm \
-		/usr/bin/aterm-xterm 30
 	# Add an alternative for x-terminal-emulator
 	update-alternatives --install /usr/bin/x-terminal-emulator \
 		x-terminal-emulator /usr/bin/aterm-xterm 20 \
diff -u aterm-1.0.1/debian/aterm-ml.postinst aterm-1.0.1/debian/aterm-ml.postinst
--- aterm-1.0.1/debian/aterm-ml.postinst
+++ aterm-1.0.1/debian/aterm-ml.postinst
@@ -2,16 +2,6 @@
 # postinst file for aterm-ml
 
 if [ "$1" = "configure" ]; then
-	# Add an alternative for aterm
-	update-alternatives --install /usr/bin/aterm aterm \
-		/usr/bin/katerm 25
-	update-alternatives --install /usr/bin/aterm aterm \
-		/usr/bin/caterm 20
-	update-alternatives --install /usr/bin/aterm aterm \
-		/usr/bin/gaterm 20
-	update-alternatives --install /usr/bin/aterm aterm \
-		/usr/bin/taterm 20
-
 	# Add an alternative for x-terminal-emulator
 	update-alternatives --install /usr/bin/x-terminal-emulator \
 		x-terminal-emulator /usr/bin/katerm 20 \
diff -u aterm-1.0.1/debian/changelog aterm-1.0.1/debian/changelog
--- aterm-1.0.1/debian/changelog
+++ aterm-1.0.1/debian/changelog
@@ -1,3 +1,9 @@
+aterm (1.0.1-5) unstable; urgency=low
+
+  * NMU: Fix incorrect use of update-alternatives. (Closes: #518962) 
+
+ -- Nicolas Valcárcel Scerpella   Mon, 09 Mar 2009 11:14:47 -0500
+
 aterm (1.0.1-4) unstable; urgency=low
 
   * QA upload.


signature.asc
Description: This is a digitally signed message part