Re: unnecessary adoption by QA-team
Hello Andreas, * Andreas Barth <[EMAIL PROTECTED]> [2004-08-07 22:40]: > > A ready package, that solve this bug is already available. > > Why did QA-group adopt this package instead to sponsor my upload? > > Well, finding a sponsor is sometimes rather difficult. I'm sorry, but > that's just the current situation. I know that it's rather frustrating > (and I can well remember the time where it was frustrating for me, and > I had to trap sponsors on IRC). I know that this answer is not as > nice as it should be, and I feel sorry for this. yes you are right. i think it is a pity. specially for new contributors of the debian project it can be very frustrating. bug i think if 50% of the current developers would sponsor 2 packages it doesnt have to be such a problem (maybe i am too optimistic) regards nico -- Nico Golde - [EMAIL PROTECTED] [EMAIL PROTECTED] | [EMAIL PROTECTED] | http://www.ngolde.de GPG: FF46 E565 5CC1 E2E5 3F69 C739 1D87 E549 7364 7CFF Is there life after /sbin/halt -p? signature.asc Description: Digital signature
Bug#242117: still not ready?
Hi, ist cabot still not ready for testing? Regards Nico -- Nico Golde - JAB: [EMAIL PROTECTED] | GPG: 0x73647CFF http://www.ngolde.de | http://www.muttng.org | http://grml.org pgpGsGXrSrQeO.pgp Description: PGP signature
cdrw-taper stable update for #496380
Hi, an insecure temporary file creation was reported to the cdrw-taper some time ago. This is Debian bug #496380. Unfortunately the vulnerability is not important enough to get it fixed via regular security update in Debian stable. It does not warrant a DSA. However it would be nice if this could get fixed via a regular point update[0]. Please contact the release team for this. This is an automatically generated mail, in case you are already working on an upgrade this is of course pointless. For further information: [0] http://www.debian.org/doc/developers-reference/pkgs.html#upload-stable Kind regards Nico -- Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgpFvRLvezBjw.pgp Description: PGP signature
xmcd stable update for #496416
Hi, an insecure temporary file creation was reported to the xmcd some time ago. This is Debian bug #496416. Unfortunately the vulnerability is not important enough to get it fixed via regular security update in Debian stable. It does not warrant a DSA. However it would be nice if this could get fixed via a regular point update[0]. Please contact the release team for this. This is an automatically generated mail, in case you are already working on an upgrade this is of course pointless. For further information: [0] http://www.debian.org/doc/developers-reference/pkgs.html#upload-stable Kind regards Nico -- Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgpMhCodRhhtf.pgp Description: PGP signature
Bug#404235: segfault patch for 404235
Hi,
the provided patch is actually not fixing the issue really.
I attached 2 patches for trr_update and trr_format which
should fix this.
Please test them before you upload the changes since I don't
use emacs and have no idea of the program.
But it would be a good idea to do a complete rewrite of the
code, its really ugly.
Kind regards
NIco
--
Nico Golde - http://www.ngolde.de
JAB: [EMAIL PROTECTED] - GPG: 0x73647CFF
Forget about that mouse with 3/4/5 buttons,
gimme a keyboard with 103/104/105 keys!
--- /home/nion/build/trr19-1.0beta5/trr_format.c 2006-12-29 17:54:11.0 +0100
+++ trr_format.c 2006-12-29 18:27:26.0 +0100
@@ -18,6 +18,7 @@
#include
#include
+#include
#include
#include
#include
@@ -40,27 +41,25 @@
main(int argc, char **argv){
- char textfile[256], formattedfile[256], lockfile[256], *tmpfname;
- char command[256], line[1024];
+ char textfile[_POSIX_PATH_MAX], formattedfile[_POSIX_PATH_MAX], lockfile[_POSIX_PATH_MAX], *tmpfname;
+ char command[_POSIX_PATH_MAX], line[_POSIX_PATH_MAX];
FILE *fd, *tmpfd;
int i;
struct passwd *pw = NULL;
-
/* ignore signals */
signal(SIGHUP, SIG_IGN);
signal(SIGINT, SIG_IGN);
signal(SIGQUIT, SIG_IGN);
signal(SIGTERM, SIG_IGN);
+ if(argc<2){
+fprintf(stderr, "no file specified..\n");
+exit(EXIT_FAILURE);
+ }
- strcpy(textfile, TEXT_DIR);
- strcat(textfile, argv[1]);
- strcpy(formattedfile, textfile);
- strcat(formattedfile, ".formed");
- strcpy(lockfile, textfile);
- strcat(lockfile, ".lock");
+ snprintf(line, sizeof(line), "%s%s%s.formed%s.lock", TEXT_DIR, argv[1], textfile, textfile);
- umask(18);
+ umask(022);
/* if previous process is formatting same target text,
wait for that process to finish formatting. */
@@ -91,7 +90,7 @@
/* format a text - fork and exec the processes so we can drop privileges */
switch( fork() ) {
case -1: /* Error */
- perror(fork);
+ perror("fork");
exit(1);
break;
case 0: /* Child */
@@ -100,9 +99,13 @@
/* Drop group privileges */
pw = getpwuid(getuid());
+if(!pw){
+fprintf(stderr, "You don't exist..go away\n");
+exit(EXIT_FAILURE);
+}
setgid(pw->pw_gid);
- sprintf(command, "%s -v '^[ \t]*$' %s | %s 's/\\([.?!;]\\) *$/\\1/' | %s 's/^ *\\(.*\\)$/\\1/' > %s",
+ snprintf(command, sizeof(command), "%s -v '^[ \t]*$' %s | %s 's/\\([.?!;]\\) *$/\\1/' | %s 's/^ *\\(.*\\)$/\\1/' > %s"
GREP, textfile, SED, SED, tmpfname);
system(command);
break;
@@ -111,15 +114,23 @@
}
tmpfd = fopen(tmpfname, "r");
+if(!tmpfd){
+perror("fopen");
+exit(EXIT_FAILURE);
+}
fd = fopen(formattedfile, "w");
+if(!fd){
+perror("fopen");
+exit(EXIT_FAILURE);
+}
-while(fgets(line, 1024, tmpfd))
+while(fgets(line, sizeof(line), tmpfd))
fputs(line, fd);
fclose(tmpfd);
fclose(fd);
unlink(tmpfname);
-
+free(line);
/* release lock */
unlink(lockfile);
return 0;
--- /home/nion/build/trr19-1.0beta5/trr_update.c 1996-07-03 06:52:08.0 +0200
+++ trr_update.c 2006-12-29 19:05:35.0 +0100
@@ -21,6 +21,7 @@
#include
#include
#include
+#include
#if defined(HAVE_STRING_H)
#include
@@ -45,10 +46,10 @@
#endif /* HAVE_FCNTL_H */
main(int argc, char **argv){
- char scorefile[256], lockfile[256], datestr[64];
- char line[256], savedline[256];
- const char *user, *scores, *step, *times, *ttime, *token;
- FILE *fd, *tmpf;
+ char scorefile[_POSIX_PATH_MAX], lockfile[_POSIX_PATH_MAX], datestr[64];
+ char line[_POSIX_PATH_MAX], savedline[_POSIX_PATH_MAX];
+ const char *user=NULL, *scores=NULL, *step=NULL, *times=NULL, *ttime=NULL, *token=NULL;
+ FILE *fd=NULL, *tmpf=NULL;
int score, tmpscore, i, myself, inserted;
long datev;
@@ -58,25 +59,34 @@
signal(SIGQUIT, SIG_IGN);
signal(SIGTERM, SIG_IGN);
- umask(18);
- strcpy(scorefile, RECORD_DIR);
+ snprintf(lockfile, sizeof(lockfile), "%s.lock", scorefile);
- /* create a new record file */
- if (argc == 2){
-strcat(scorefile, argv[1]);
+ if (argc<2) {
+ fprintf(stderr,"too few arguments\n");
+ exit(EXIT_FAILURE);
+ }
-if ((fd = fopen(scorefile, "w")) == NULL){
- perror(scorefile);
- exit(1);
-} else
+ umask(022);
+ snprintf(scorefile, sizeof(scorefile), RECORD_DIR "%s", argv[1]);
+
+ /* create a new record file */
+ if (argc == 2){
+
+ if ((fd = fopen(scorefile, "w")) == NULL){
+ perror(scorefile);
+ exit(1);
+ } else
fclose(fd);
-exit(0);
+ exit(0);
}
- /* upfate high score file */
- strcat(scorefile, argv[1]);
- strcpy(lockfile, scorefile);
- s
Bug#404235: segfault patch for 404235
Hey,
* Jens Seidel <[EMAIL PROTECTED]> [2006-12-30 18:19]:
> On Fri, Dec 29, 2006 at 07:08:29PM +0100, Nico Golde wrote:
> > +++ trr_format.c2006-12-29 18:27:26.0 +0100
> > main(int argc, char **argv){
> > - char textfile[256], formattedfile[256], lockfile[256], *tmpfname;
> > - char command[256], line[1024];
> > + char textfile[_POSIX_PATH_MAX], formattedfile[_POSIX_PATH_MAX],
> > lockfile[_POSIX_PATH_MAX], *tmpfname;
> > + char command[_POSIX_PATH_MAX], line[_POSIX_PATH_MAX];
>
> Please note that this will probably not work with the Hurd. This system
> tries to avoid all useless limitations and _POSIX_PATH_MAX is one of
> these. The proper solution is to create the buffers dynamically ...
Yes that would be better then I didnt do this cause the code
doesnt really need dinamically allocated buffers. Anyway the
patch should just show all the other problems that exist in
the code but I would suggest a documentation of secure
programming and a complete rewrite of the code to the
upstream author. Also the substitution of SED and GREP via
the makefile in the c-files and then calling system() is
really ugly.
Kind regards, happy new year
Nico
--
Nico Golde - http://www.ngolde.de
JAB: [EMAIL PROTECTED] - GPG: 0x73647CFF
Forget about that mouse with 3/4/5 buttons,
gimme a keyboard with 103/104/105 keys!
pgp0ALuNchK2T.pgp
Description: PGP signature
Bug#404235: trr19: segfault when no argument is given
Hi Arnaud, * Arnaud Fontaine <[EMAIL PROTECTED]> [2007-01-21 22:59]: > Your patch is wrong because you are using `char *textfile` in the first > snprintf without initializing it. I made a patch which fixes the bug and > works on the Hurd. As said I didnt test it, I just wrote it down very quick since I dont care about emacs stuff and just wanted to point out the issues. Kind regards Nico -- Nico Golde - http://www.ngolde.de JAB: [EMAIL PROTECTED] - GPG: 0x73647CFF Forget about that mouse with 3/4/5 buttons, gimme a keyboard with 103/104/105 keys! pgp6gorCSJWqX.pgp Description: PGP signature
Bug#404235: (no subject)
Hi, > Your patch is wrong because you are using `char > *textfile` in the first > snprintf without initializing it. I didnt check what you said when I replied last time. However what you say is wrong since there is no char pointer textfile in my patch, its an array which is initialized when snprintf is called. Nico -- Nico Golde - http://www.ngolde.de JAB: [EMAIL PROTECTED] - GPG: 0x73647CFF Forget about that mouse with 3/4/5 buttons, gimme a keyboard with 103/104/105 keys! pgpWPRS3StMZI.pgp Description: PGP signature
Bug#252760: FTBFS: architecture missing
Hi, I don't really understand your bugreport please help me a bit :) You write that the package fails to build from source (I guess on amd64) but you want amd64 to be added to the Architectures field. So does it build and work on amd64 or not? Kind regards Nico -- Nico Golde - http://ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgpBJa6rgHTuJ.pgp Description: PGP signature
Bug#252760: FTBFS: architecture missing
Hi, no it suggests them and since they are not needed to run mkrboot... Kind regards Nico -- Nico Golde - http://ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgpRZPpxY73wQ.pgp Description: PGP signature
Bug#273634: ffingerd: adds to xinetd.conf instead of creating file in xinetd.d
Hi, > As there exist a /etc/xinetd.d directory where services are added as separate > files, would it not be more appropriate to add the service configuration > here instead of in /etc/xinetd.conf? Why? Kind regards Nico -- Nico Golde - http://ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgpl5ZFq2tblv.pgp Description: PGP signature
Bug#348006: xfonts-artwiz - no german characters linke ä.ö.ü.ß
severity 348006 minor tags 348006 moreinfo thanks Hi, did you try the .de fonts in the artwiz package? Try them by using xfontsel I think they should work for you. I will close this bug in 1 month if I get no feedback by you. Cheers Nico -- Nico Golde - http://ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgp4mgounBV6C.pgp Description: PGP signature
Bug#435421: myphpmoney: can't install, remove or purge
Hi Christian, this is a ping, looks like you forogt about this item :) Kind regards Nico -- Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgpmke9JDJmJd.pgp Description: PGP signature
openmotif oldstable update for CVE-2004-0914, CVE-2005-0605, CVE-2005-3964
Hi, the following CVE (Common Vulnerabilities & Exposures) ids were published for openmotif some time ago. CVE-2004-0914[0]: | Multiple vulnerabilities in libXpm for 6.8.1 and earlier, as used in | XFree86 and other packages, include (1) multiple integer overflows, | (2) out-of-bounds memory accesses, (3) directory traversal, (4) shell | metacharacter, (5) endless loops, and (6) memory leaks, which could | allow remote attackers to obtain sensitive information, cause a denial | of service (application crash), or execute arbitrary code via a certain | XPM image file. NOTE: it is highly likely that this candidate will be | SPLIT into other candidates in the future, per CVE's content | decisions. CVE-2005-0605[1]: | scan.c for LibXPM may allow attackers to execute arbitrary code via a | negative bitmap_unit value that leads to a buffer overflow. CVE-2005-3964[2]: | Multiple buffer overflows in libUil (libUil.so) in OpenMotif 2.2.3, | and possibly other versions, allows attackers to execute arbitrary | code via the (1) diag_issue_diagnostic function in UilDiags.c and (2) | open_source_file function in UilSrcSrc.c. Unfortunately the vulnerabilities described above are not important enough to get them fixed via regular security update in Debian oldstable. It does not warrant a DSA. However it would be nice if they could get fixed via a regular point update. Please contact the release time for this. This is an automatically generated mail, in case you are already working on an upgrade this is of course pointless. You can see the status of this vulnerabilities on: http://security-tracker.debian.net/tracker/CVE-2004-0914 http://security-tracker.debian.net/tracker/CVE-2005-0605 http://security-tracker.debian.net/tracker/CVE-2005-3964 For further information: [0] http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2004-0914 [1] http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2005-0605 [2] http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2005-3964 Kind regards Nico -- Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgpBQO84etzxL.pgp Description: PGP signature
