Bug#1042911: Breaks Emacs 29.1 upgrade: muse-split.el:41:2: Error: Cannot open load file: No such file or directory, assoc
Nicholas D Steeves writes: > Hello, > > Would you like to fix this RC bug and adopt the package? > > https://bugs.debian.org/1042911 > > and the orphan bug is here: #1016558 > > Best, > Nicholas > Hi Nicolas, Thanks for reaching out! Looks like this was caused by the removal of the obsolete "assoc" package in Emacs 29.1 which had been deprecated since 24. I'll try to work on a fix later this week. -- Manphiz signature.asc Description: PGP signature
Bug#1042911: Breaks Emacs 29.1 upgrade: muse-split.el:41:2: Error: Cannot open load file: No such file or directory, assoc
control: tags -1 patch Manphiz writes: > Nicholas D Steeves writes: > >> Hello, >> >> Would you like to fix this RC bug and adopt the package? >> >> https://bugs.debian.org/1042911 >> >> and the orphan bug is here: #1016558 >> >> Best, >> Nicholas >> > > Hi Nicolas, > > Thanks for reaching out! Looks like this was caused by the removal of > the obsolete "assoc" package in Emacs 29.1 which had been deprecated > since 24. I'll try to work on a fix later this week. Hi Nicholas, I have now prepared a merge request to migrate away from assoc.el[1] and also forwarded the patch upstream. Also set the package as team maintained and add myself as an upload. PTAL. Thanks! [1] https://salsa.debian.org/emacsen-team/muse-el/-/merge_requests/3 -- Manphiz
Bug#1042911: Breaks Emacs 29.1 upgrade: muse-split.el:41:2: Error: Cannot open load file: No such file or directory, assoc
Nicholas D Steeves writes: > Hello, > > Manphiz writes: > >>> Nicholas D Steeves writes: >>> >> >> Hi Nicholas, >> >> I have now prepared a merge request to migrate away from assoc.el[1] and >> also forwarded the patch upstream. Also set the package as team >> maintained and add myself as an upload. PTAL. Thanks! > > Wow, that was fast! LTGM, with one caveat: You are an Uploader for this > package now, so please drop the "Team upload" line entirely. This makes > you the human maintainer for the package, so I have sent you an invitation > for salsa/gitlab maintainer permissions for muse-el. Thanks! Though I'm not really a user of muse-el, I'd like to keep it in a good shape as an exercise as an Emacs addon maintainer. It looks like there is not too much work thanks to Elisp being a fairly stable language :) > >> [1] https://salsa.debian.org/emacsen-team/muse-el/-/merge_requests/3 > > You will notice that there are two other MRs. Please double-check that > the bot did its work correctly, and please manually go through the > Debian Policy upgrade checklist, starting with the version muse-el uses, > and each version up to and including the one the bot proposed. If you > would like to take credit for this work, I recommend adding "and your > name" to the changelog entries the bot proposes. > > [ The name of the bot and your name ] > > In other words, I would like to give you permission to write to this > repo! Bots will often rebase their MRs to save you time, and I will > leave the decision of what gets merged first, and what gets rebased up > to you. Thanks for the tips! I checked the Debian Policy Upgrading Checklist[1] and agreed with Debian Janitor on the "no changes are needed" bit. And to avoid having to wait for the bot to do the rebase I've manually resolved the conflicts and rebased my MR on top of it as well. > > Let me know when your done, and we can talk about the next steps. Now all MRs are merged. Please advise the next steps. Thanks! > > Cheers, > Nicholas > [1] https://www.debian.org/doc/debian-policy/upgrading-checklist.html -- Manphiz signature.asc Description: PGP signature
Bug#1042911: Breaks Emacs 29.1 upgrade: muse-split.el:41:2: Error: Cannot open load file: No such file or directory, assoc
Nicholas D Steeves writes: > Hi, > > Reply follows inline. Can we move this discussion to #1016558 to not > bother Axel with our discussion? > > Manphiz writes: > >> Nicholas D Steeves writes: >>>>> Nicholas D Steeves writes: >>>>> >> Thanks! Though I'm not really a user of muse-el, I'd like to keep it in >> a good shape as an exercise as an Emacs addon maintainer. It looks like >> there is not too much work thanks to Elisp being a fairly stable >> language :) > > That's fine, thank you once again for adopting it, and yes, generally > everything is ok :) > >>>> [1] https://salsa.debian.org/emacsen-team/muse-el/-/merge_requests/3 >>> >> Thanks for the tips! I checked the Debian Policy Upgrading Checklist[1] >> and agreed with Debian Janitor on the "no changes are needed" bit. And >> to avoid having to wait for the bot to do the rebase I've manually >> resolved the conflicts and rebased my MR on top of it as well. >> > > You're welcome, and good call. > >>> Let me know when your done, and we can talk about the next steps. >> >> Now all MRs are merged. Please advise the next steps. Thanks! >> > > Wonderful! I also see you have a GPG key now. Have you generated > revocations certificates yet? > > https://wiki.debian.org/Keysigning#Step_2:_Generate_a_revocation_certificate Now I have one. Thanks for the tip! > > Next, where can I find your key? I have previously uploaded my GPG key to pgp.mit.edu[1]. > I'm assuming that you're committed to > maintaining this identity for the foreseeable future, and that you'd > like to build reputation for future involvement in Debian. It's not > required at the stage you're at, but it's recommended. > > https://wiki.debian.org/Keysigning#Step_3:_Make_your_public_key_public Please advise if https://keyserver.ubuntu.com is still recommended for prospective DMs. > > The subkey that I was able to download didn't include any identities. > > Other than that, this package isn't quite ready to upload, because there > are three unaddressed lintian warnings. > > https://wiki.debian.org/Lintian I have a few more commits[2] that should have fixed most of the lintian warnings. There is another INFO level warning: I: muse-el source: patch-not-forwarded-upstream [debian/patches/0005-convert-a-muse-init.el-example-to-UTF-8.patch] I wonder whether you would also like to forward this patch upstream. The rest warnings/infos are taken care of. PTAL. > > Best, > Nicholas > [1] http://pgp.mit.edu/pks/lookup?op=get&search=0x2DE965ED63825C93 [2] https://salsa.debian.org/emacsen-team/muse-el/-/commits/master -- Manphiz signature.asc Description: PGP signature
Bug#1042911: Breaks Emacs 29.1 upgrade: muse-split.el:41:2: Error: Cannot open load file: No such file or directory, assoc
Nicholas D Steeves writes: > On Sun, 6 Aug 2023 at 04:37, Manphiz wrote: >> Nicholas D Steeves writes: >> >> > Hi, >> > >> > Reply follows inline. Can we move this discussion to #1016558 to not >> > bother Axel with our discussion? > > I guess that's a no? Ah sorry totally missed this part. This will be the last message to #1042911. Will follow-up the rest in #1016558. > >> > Manphiz writes: >> >> Nicholas D Steeves writes: >> >>>>> Nicholas D Steeves writes: >> > >> > Wonderful! I also see you have a GPG key now. Have you generated >> > revocations certificates yet? >> > >> > >> > https://wiki.debian.org/Keysigning#Step_2:_Generate_a_revocation_certificate >> >> Now I have one. Thanks for the tip! > > You're welcome :) > >> > Next, where can I find your key? >> >> I have previously uploaded my GPG key to pgp.mit.edu[1]. > > Ah, that's where it was. I thought everyone had switched to > https://keys.openpgp.org/ these days (this is the default server on > Debian) after the end of the SKS network. Thanks for the reminder to > continue to check pgp.mit.edu as a fallback. > >> Please advise if https://keyserver.ubuntu.com is still recommended for >> prospective DMs. > > This is the first I've heard of that recommendation. I wonder if > people in #debian-mentors (OFTC) will also be surprised? I'd use > keyserver.ubuntu.com if I had a Launchpad account and maintained a > PPA, but honestly wouldn't bother. I started using keys.openpgp.org > since that's where various people expected to find my key haha. > >> I have a few more commits[2] that should have fixed most of the lintian >> warnings. > > LGTM > >> There is another INFO level warning: >> >> I: muse-el source: patch-not-forwarded-upstream >> [debian/patches/0005-convert-a-muse-init.el-example-to-UTF-8.patch] >> >> I wonder whether you would also like to forward this patch upstream. > > If you really want to, go ahead, but I'm not interested in the FSF's > identity verification for copyright assignment process, so this might > end up as a futile effort. In light of this, a "hey, we have a UTF8 > conversion patch...would you like to convert your copy to UTF8 either > with or without our patch" might be smoother. If you happen to have > have done FSF copyright assignment paperwork, please go ahead and > claim ownership of that trivial patch. > > I'm happy to sponsor from git when you finalise the changelog, but if > ever you want to get some hands-on experience with dput (or dput-ng), > then practise uploading to https://mentors.debian.net/. > > Best, > Nicholas > > On Sun, 6 Aug 2023 at 04:37, Manphiz wrote: >> >> Nicholas D Steeves writes: >> >> > Hi, >> > >> > Reply follows inline. Can we move this discussion to #1016558 to not >> > bother Axel with our discussion? >> > >> > Manphiz writes: >> > >> >> Nicholas D Steeves writes: >> >>>>> Nicholas D Steeves writes: >> >>>>> >> >> Thanks! Though I'm not really a user of muse-el, I'd like to keep it in >> >> a good shape as an exercise as an Emacs addon maintainer. It looks like >> >> there is not too much work thanks to Elisp being a fairly stable >> >> language :) >> > >> > That's fine, thank you once again for adopting it, and yes, generally >> > everything is ok :) >> > >> >>>> [1] https://salsa.debian.org/emacsen-team/muse-el/-/merge_requests/3 >> >>> >> >> Thanks for the tips! I checked the Debian Policy Upgrading Checklist[1] >> >> and agreed with Debian Janitor on the "no changes are needed" bit. And >> >> to avoid having to wait for the bot to do the rebase I've manually >> >> resolved the conflicts and rebased my MR on top of it as well. >> >> >> > >> > You're welcome, and good call. >> > >> >>> Let me know when your done, and we can talk about the next steps. >> >> >> >> Now all MRs are merged. Please advise the next steps. Thanks! >> >> >> > >> > Wonderful! I also see you have a GPG key now. Have you generated >> > revocations certificates yet? >> > >> > >> > https://wiki.debian.org/Keysigning#Step_2:_Generate_a_revocation_certificate >> >> Now I have one. Thanks
