News about unixcw?

2011-08-30 Thread Kamil Ignacak 

Hi Simon,

Recently I've started using cwcp program from unixcw package to learn 
Morse code. I find it very useful, but I have also noticed that the 
program has some problems. Some of them have been addressed by patches 
created by Kamal Mostafa 
(https://launchpad.net/~kamalmostafa/+archive/unixcw-fixes). I have 
implemented some changes in my local copy of cwlib myself as well.


I would like to ask you whether you still actively maintain this 
package, and if you accept any patches or other kind of help with the 
package.


I'm adding in CC some people who may be interested in any news about the 
package.


Have a nice day!

Best regards,
Kamil Ignacak


--
To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e5d1867.4050...@wp.pl

Re: News about unixcw?

2011-09-06 Thread Kamil Ignacak 

Hi Simon,

Thank you very much for the answer. In that case I will try to look 
further and see if anyone else is currently the main developer of the 
package already.


Kamal: could you please let me know if you consider yourself the owner 
of the package? If not then I would like to step in and take over this 
project. Please do let me know.


Best regards,
Kamil



On 06.09.2011 10:31, Simon Baldwin wrote:

Hi Kamil,

Thanks for the email, and your interest in Unixcw.

I haven't updated the package for a while now, and don't really expect
to do anything to it in the way of improvement in the foreseeable
future. I know that Kamal has created a few patches for it to help to
keep it up to date with current Linux releases, and I'm very grateful to
him for doing this. I guess the program is sort-of looking for a new
owner at present, and if somebody wanted to take it over I'd be fine
with that.

Best regards,

--S


----
*From:* Kamil Ignacak 
*To:* simon_bald...@yahoo.com
*Cc:* ka...@whence.com; packa...@qa.debian.org
*Sent:* Tuesday, 30 August 2011, 19:05
*Subject:* News about unixcw?

Hi Simon,

Recently I've started using cwcp program from unixcw package to learn
Morse code. I find it very useful, but I have also noticed that the
program has some problems. Some of them have been addressed by patches
created by Kamal Mostafa
(https://launchpad.net/~kamalmostafa/+archive/unixcw-fixes
<https://launchpad.net/%7Ekamalmostafa/+archive/unixcw-fixes>). I have
implemented some changes in my local copy of cwlib myself as well.

I would like to ask you whether you still actively maintain this
package, and if you accept any patches or other kind of help with the
package.

I'm adding in CC some people who may be interested in any news about the
package.

Have a nice day!

Best regards,
Kamil Ignacak





--
To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e6674fe.4020...@wp.pl

Re: News about unixcw?

2011-09-08 Thread Kamil Ignacak 

Hi Kamal,

Thank you for your reply.
Hereby I'm taking over this project. I will create a new project on one 
of websites hosting FLOSS projects (probably sf.net) within a week, and 
then decide about further steps. I will also check what exactly "sponsor 
a Debian upload of a new upstream package" means :)


I will start with original source tree (2.3-13), without your patches, 
as I hope to solve Debian bugs #567392 and #567394 by slightly changing 
the way the libcw generates tones. The next step would be adding ALSA 
support, and perhaps solve this problem:

http://lists.debian.org/debian-qa-packages/2010/11/msg00101.html

Best regards,
Kamil



On 07.09.2011 02:00, Kamal Mostafa wrote:

Hi Kamil and Simon-

On Tue, 2011-09-06 at 21:31 +0200, Kamil Ignacak wrote:

Hi Simon,

Thank you very much for the answer. In that case I will try to look
further and see if anyone else is currently the main developer of the
package already.

Kamal: could you please let me know if you consider yourself the owner
of the package? If not then I would like to step in and take over this
project. Please do let me know.


No, I don't consider myself the owner of the package.  Given Simon's
blessing there, I think you can feel free to start bringing it back to
life again.  Please note that its "orphaned" status in Debian, and the
large number of outstanding bug reports:
http://packages.qa.debian.org/u/unixcw.html

I am a Debian Developer and a member of the Debian Hams group, and I
would quite willing to adopt and sponsor a Debian upload of a new
upstream package of unixcw if you do improve upon it (and I could help
with packaging issues as well, but I'm afraid I'm too swamped to take on
a more active role in development for it).

Thanks in advance for your efforts!

  -Kamal




Best regards,
Kamil



On 06.09.2011 10:31, Simon Baldwin wrote:

Hi Kamil,

Thanks for the email, and your interest in Unixcw.

I haven't updated the package for a while now, and don't really expect
to do anything to it in the way of improvement in the foreseeable
future. I know that Kamal has created a few patches for it to help to
keep it up to date with current Linux releases, and I'm very grateful to
him for doing this. I guess the program is sort-of looking for a new
owner at present, and if somebody wanted to take it over I'd be fine
with that.

Best regards,

--S


--------
*From:* Kamil Ignacak
*To:* simon_bald...@yahoo.com
*Cc:* ka...@whence.com; packa...@qa.debian.org
*Sent:* Tuesday, 30 August 2011, 19:05
*Subject:* News about unixcw?

Hi Simon,

Recently I've started using cwcp program from unixcw package to learn
Morse code. I find it very useful, but I have also noticed that the
program has some problems. Some of them have been addressed by patches
created by Kamal Mostafa
(https://launchpad.net/~kamalmostafa/+archive/unixcw-fixes
<https://launchpad.net/%7Ekamalmostafa/+archive/unixcw-fixes>). I have
implemented some changes in my local copy of cwlib myself as well.

I would like to ask you whether you still actively maintain this
package, and if you accept any patches or other kind of help with the
package.

I'm adding in CC some people who may be interested in any news about the
package.

Have a nice day!

Best regards,
Kamil Ignacak









--
To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e6925c0.2060...@wp.pl

Bug#652618: cwdaemon: FTBFS, build-depends can no longer be fullfilled

2011-12-21 Thread Kamil Ignacak 

On 21.12.2011 21:26, Kamal Mostafa wrote:

The good news is that I kind of fixed it.  The bad news is, that I can't
test the resulting package.  Also just replacing the build-depens on
unixcw-dev with libcw3-dev didn't solved the issue, I guess that means
that the "Provides: unixcw-dev" of libcw3-dev is not true.


You're correct.  the renamed libcw3{-dev} packages don't properly
Provide unixcw{-dev}, but they should.  We'll fix that.
I'm by no means an expert on packaging, but since there were so many 
changes in libcw3, shouldn't we stress this by *not* providing 
unixcw{-dev} Debian package?




I had to do some further changes (see attached debdiff).  To my
understanding the calls cw_set_soundcard_sound and cw_set_console_sound
are no longer necessary, as libcw automatically picks the right one?


Lets ask the new upstream author/maintainer...  Kamil, can you comment
on that?  Did you eliminate those routines from the new libcw?

The two functions are missing from libcw3 because:
a) you can't have console output and soundcard output at the same time 
(this should be reflected in cwdaemon.c which at this point allows 
"b(oth)" option),
b) selection of sound output is made at library initialization time with 
call of cw_generator_new(, device name>);



2) Is the patch correct? Anyone can test it?
I've created my own patch (attached), only for cwdaemon.c, but I was 
unable to test it at the moment: my only machine with serial port is 
somewhere in my apartment, but bringing it back to life would take some 
time. Not in this week, for certain.
The patch is my best effort at the moment, but it may not work 100% 
correctly. I can't confirm its full correctness without tests.




And for the Debian Hamradio Maintainers:
3) Shouldn't libcw3-dev have a dependency on libasound2-dev?  Apparently
that's needed for successfull linking.
4) Are libcw's pc files correct?  As you can see, I also had to add also
to the CFLAGS and lib calls.
5) Wouldn't you like to adopt cwdaemon, if it's worth to be kept?


I do think cwdaemon is worth keeping, and I will adopt it.

Kamil and I will fix unixcw/libcw3 and then I will apply whatever
remaining bits of your patch to cwdaemon are still necessary.

IMHO the only things that should be fixed in libcw are:
 - dependency on libasound2-dev,
 - pc file.
Should I handle this? I could start doing this no sooner than next 
Tuesday (28.12).


One final note: when updating unixcw package I was careful enough to 
check what Debian packages depend on unixcw(-dev). "apt-cache rdepends" 
showed only programs from unixcw source package (cw, cwcp, xcwcp), so 
did "apt-cache search unixcw". This page doesn't mention unixcw either:

http://packages.debian.org/sid/cwdaemon

I would be happy to test libcw3 with some application not coming from 
unixcw source package, provided that it can be tested on a machine with 
fairly modern hardware requirements. My machine with serial port has 
been gathering dust for a long time, and will stop cooperating sooner or 
later :/


Best regards,
Kamil
--- before/cwdaemon-0.9.4/cwdaemon.c	2006-11-09 10:23:11.0 +0100
+++ after/cwdaemon-0.9.4/cwdaemon.c	2011-12-21 22:29:57.0 +0100
@@ -89,7 +89,7 @@
 #endif
 #include 

-#include 
+#include 
 #include "cwdaemon.h"

 /* network vars */
@@ -165,6 +165,9 @@
 cwdevice *cwdev;
 static void playmorsestring (char *x);

+static int set_libcw_output (void);
+static void close_libcw (void);
+
 /* catch ^C when running in foreground */
 static RETSIGTYPE
 catchint (int signal)
@@ -299,18 +302,52 @@
 	}
 }

-/* initialize unixcw */
+/* (re)set initial parameters of libcw */
 static void
-initmorse (void)
+reset_libcw (void)
 {
+	/* just in case if an old generator exists */
+	close_libcw ();
+
+	set_libcw_output ();
+
 	cw_set_frequency (morse_tone);
 	cw_set_send_speed (morse_speed);
-	cw_set_soundcard_sound (soundcard_sound);
-	cw_set_console_sound (console_sound);
 	cw_set_volume (morse_volume);
 	cw_set_gap (0);
 }

+static void
+close_libcw (void)
+{
+	cw_generator_stop ();
+	cw_generator_delete ();
+}
+
+/* set up output of libcw */
+static int
+set_libcw_output (void)
+{
+	int rv = 0;
+	if (soundcard_sound && !console_sound)
+   {
+		rv = cw_generator_new (CW_AUDIO_SOUNDCARD, NULL);
+	}
+	else if (!soundcard_sound && console_sound)
+	{
+		rv = cw_generator_new (CW_AUDIO_CONSOLE, NULL);
+	}
+	else
+	{
+		/* libcw can't do both soundcard and console,
+		   and it has to have one and only one sound
+		   system specified */
+		errmsg ("Sound output specified incorrectly");
+	rv = CW_FAILURE;
+	}
+	return rv == CW_FAILURE ? -1 : 0;
+}
+
 /* properly parse a 'long' integer */
 static int
 get_long(const char *buf, long *lvp)
@@ -371,7 +408,7 @@
 morse_volume = 70;
 console_sound = 1;
 soundcard_sound = 0;
-initmorse ();
+reset_libcw ();
 wordmode = 0;
 async_abort = 0;
 cwdev->reset (cwdev);
@@ -559,8 +596,7 @@
 if (valid_sdevice == 1)
 {
 	deb