Bug#468825: bfr: Please remove hardlinks from package

2008-03-01 Thread James Westby
Package: bfr
Version: 1.6-1

Hi,

The bfr package contains hardlinks. In fact it links together
the upstream changelog and the Debian changelog. This is causing
some issues trying to represent the package in a VCS, and it
would be great if an upload could be done that removed the links.

Thanks,

James





-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#468825: bfr: Please remove hardlinks from package

2008-04-30 Thread James Westby
severity 468825 serious
thanks

Hi,

It was pointed out to me that this actually violates Debian Policy,
section 4.8. I think this warrants a serious severity, but I'm not
absolutely sure that "may not" as used in that section is equivalent
to a "must".

Thanks,

James




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#506500: gnuift: Missing --install argument to libtoolize call

2008-11-21 Thread James Westby
Package: gnuift
Version: 0.1.14-9
Severity: normal
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu jaunty

Hi,

As shown at

  
http://launchpadlibrarian.net/19643691/buildlog_ubuntu-jaunty-i386.gnuift_0.1.14-9_FAILEDTOBUILD.txt.gz

this package can fail to build as the libtoolize call will remove
config.sub. Adding --install to the libtoolize call in debian/rules
will fix this.

Thanks,

James




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#507282: xmcd: Missing mode to open() calls with O_CREAT

2008-11-29 Thread James Westby
Package: xmcd
Version: 2.6-21
Severity: normal
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu jaunty ubuntu-patch

Hi,

open(2) states that a mode must be specified when the O_CREAT flag
is specified, there are a few cases where you package does not do
that.

Attached is a patch to specify a mode in those calls, please consider
applying it. The patch to cddb_open is a bit odd, as it doesn't
choose the flags itself. I patched the case where it is called with
O_CREAT by one caller, but it would take a bit of a re-work to have
the caller also specify the mode, or to add an explicit mode to
the open calls in cddb_local_open as well.

Thanks,

James
diff -u xmcd-2.6/cda_d/cda.c xmcd-2.6/cda_d/cda.c
--- xmcd-2.6/cda_d/cda.c
+++ xmcd-2.6/cda_d/cda.c
@@ -393,7 +393,7 @@
 	mypid = getpid();
 
 	for (;;) {
-		fd = open(dlock, O_CREAT | O_EXCL | O_WRONLY);
+		fd = open(dlock, O_CREAT | O_EXCL | O_WRONLY, 0644);
 		if (fd < 0) {
 			if (errno == EEXIST) {
 if ((fd = open(dlock, O_RDONLY)) < 0)
diff -u xmcd-2.6/cddb_d/cddb_int.c xmcd-2.6/cddb_d/cddb_int.c
--- xmcd-2.6/cddb_d/cddb_int.c
+++ xmcd-2.6/cddb_d/cddb_int.c
@@ -2072,7 +2072,7 @@
 
 	if (rw & O_WRONLY) {
 		/* Open file */
-		if ((fp->fd = open(dbp->dbfile, rw)) < 0) {
+		if ((fp->fd = open(dbp->dbfile, rw, S_IRUSR | S_IWUSR)) < 0) {
 			MEM_FREE(fp->cache);	
 			MEM_FREE(fp);	
 			return NULL;
--- xmcd-2.6.orig/libdi_d/libdi.c
+++ xmcd-2.6/libdi_d/libdi.c
@@ -2721,7 +2721,7 @@
 	mypid = getpid();
 
 	for (;;) {
-		fd = open(lockfile, O_CREAT | O_EXCL | O_WRONLY);
+		fd = open(lockfile, O_CREAT | O_EXCL | O_WRONLY, 0644);
 		if (fd < 0) {
 			if (errno == EEXIST) {
 if ((fd = open(lockfile, O_RDONLY)) < 0)


Bug#451631: adonthell: Fix to work with python2.5

2007-11-17 Thread James Westby
Package: adonthell
Severity: normal
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu hardy

The attached patch from Matthias Klose fixes the package to work with
python2.5. The latest version can also be grabbed from

http://patches.ubuntu.com/a/adonthell/extracted/04_python2.5.diff

It can be dropped in to debian/patches, and added to the end of
debian/patches/series, and it should apply cleanly.

Thanks,

James
--- ./src/py_adonthell_wrap.cc.orig	2007-01-16 17:38:05.0 +0100
+++ ./src/py_adonthell_wrap.cc	2007-01-16 17:39:17.0 +0100
@@ -1174,7 +1174,7 @@
 obj = pyobj;
 if (PyCFunction_Check(obj)) {
   /* here we get the method pointer for callbacks */
-  char *doc = (((PyCFunctionObject *)obj) -> m_ml -> ml_doc);
+  const char *doc = (((PyCFunctionObject *)obj) -> m_ml -> ml_doc);
   c = doc ? strstr(doc, "swig_ptr: ") : 0;
   if (c) {
 	c = SWIG_UnpackVoidPtr(c + 10, &vptr, ty->name);
@@ -28592,11 +28592,11 @@
 swig_type_info **types_initial) {
 size_t i;
 for (i = 0; methods[i].ml_name; ++i) {
-char *c = methods[i].ml_doc;
+const char *c = methods[i].ml_doc;
 if (c && (c = strstr(c, "swig_ptr: "))) {
 int j;
 swig_const_info *ci = 0;
-char *name = c + 10;
+const char *name = c + 10;
 for (j = 0; const_table[j].type; j++) {
 if (strncmp(const_table[j].name, name, 
 strlen(const_table[j].name)) == 0) {


Bug#452000: apt-spy: Build-Depends on obsolete libcurl3-openssl-dev

2007-11-19 Thread James Westby
Package: apt-spy
Version: 3.1-16

Hi,

apt-spy Build-Depends on libcurl3-openssl-dev, which is no longer a
package and is provided by libcurl4-openssl-dev. Rebuild tests of the
archive have presumably ensured that it builds with this, so it should
be safe to just move to the new package.

Thanks,

James





-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#376626: Please stop Build-Depending on automake

2006-07-03 Thread James Westby
Package: kdoc
Severity: wishlist
Tags: patch


The automake maintainer is working towards reclaiming
the automake package name, which currently rests on 
automake1.4, the oldest version of automake. Your package, 
kdoc, Build-Depends on automake, hence this bug 
report. Please see http://wiki.debian.org/AutomakeTransition 
for more information on this transition.

It appears that you package does not use the automake 
package in the build process. This is normal, as most 
package do not require automake at build time. The 
attached patch removes the build dependency.

Thanks,

James


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (600, 'testing'), (550, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-loser
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
diff -u kdoc-2.0a54/debian/changelog kdoc-2.0a54/debian/changelog
--- kdoc-2.0a54/debian/changelog
+++ kdoc-2.0a54/debian/changelog
@@ -1,3 +1,10 @@
+kdoc (2.0a54-3.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Remove the unneccesary Build-Depends on automake
+
+ -- James Westby <[EMAIL PROTECTED]>  Sun,  2 Jul 2006 23:24:55 +0100
+
 kdoc (2.0a54-3) unstable; urgency=low
 
   * QA upload.
diff -u kdoc-2.0a54/debian/control kdoc-2.0a54/debian/control
--- kdoc-2.0a54/debian/control
+++ kdoc-2.0a54/debian/control
@@ -1,5 +1,5 @@
 Source: kdoc
-Build-Depends-Indep: debhelper (>> 4.0.18), autoconf, automake, perl5
+Build-Depends-Indep: debhelper (>> 4.0.18), autoconf, perl5
 Section: devel
 Priority: optional
 Maintainer: Debian QA Group <[EMAIL PROTECTED]>


Bug#376718: Please stop Build-Depending on automake

2006-07-04 Thread James Westby
Package: kdoc
Version: 2.0a54-3
Severity: wishlist
Tags: patch


The automake maintainer is working towards reclaiming
the automake package name, which currently rests on 
automake1.4, the oldest version of automake. Your package, 
kdoc, Build-Depends on automake, hence this bug 
report. Please see http://wiki.debian.org/AutomakeTransition 
for more information on this transition.

It appears that you package does not use the automake 
package in the build process. This is normal, as most 
package do not require automake at build time. The 
attached patch removes the build dependency.

Thanks,

James


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (600, 'testing'), (550, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-loser
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
diff -u kdoc-2.0a54/debian/changelog kdoc-2.0a54/debian/changelog
--- kdoc-2.0a54/debian/changelog
+++ kdoc-2.0a54/debian/changelog
@@ -1,3 +1,10 @@
+kdoc (2.0a54-3.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Remove the unneccesary Build-Depends on automake
+
+ -- James Westby <[EMAIL PROTECTED]>  Sun,  2 Jul 2006 23:24:55 +0100
+
 kdoc (2.0a54-3) unstable; urgency=low
 
   * QA upload.
diff -u kdoc-2.0a54/debian/control kdoc-2.0a54/debian/control
--- kdoc-2.0a54/debian/control
+++ kdoc-2.0a54/debian/control
@@ -1,5 +1,5 @@
 Source: kdoc
-Build-Depends-Indep: debhelper (>> 4.0.18), autoconf, automake, perl5
+Build-Depends-Indep: debhelper (>> 4.0.18), autoconf, perl5
 Section: devel
 Priority: optional
 Maintainer: Debian QA Group <[EMAIL PROTECTED]>