Bug#647473: question about your patch
On Sun, Nov 6, 2011 at 6:23 AM, Holger Levsen wrote: > Hi Dave, > ...> + > +if [ "$1" = "remove" ] > +then > + rm -f /etc/xml/sgml-data.xml* || : > + rm -f /etc/sgml/sgml-data* || : > fi > > > This patch seems to remove configuration files unconditionally on "remove". > This seems wrong to me. Can you explain? ... After sgml-data installation, the following files appear under /etc: /etc/xml/sgml-data.xml /etc/xml/sgml-data.xml.bak /etc/sgml/sgml-data.cat /etc/sgml/sgml-data.cat.old Upon removal, the last 3 remain, and ultimately cause the piuparts failure. So, when removing the sgml-data package, I am removing sgml-data files from etc. Are you suggesting that i shouldn't use the wildcards? if not, what is the issue? -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caohcdnaconbj3pjp1jpcrs-+7ffymtgakqgvthg8hnytpve...@mail.gmail.com
Bug#647473: Fwd: question about your patch
-- Forwarded message -- From: Dave Steele Date: Sun, Nov 6, 2011 at 3:40 PM Subject: Re: question about your patch To: Holger Levsen On Sun, Nov 6, 2011 at 3:12 PM, Holger Levsen wrote: > > configuration files should only be removed on purge. > > Ah, I've been bitten by an rpm-ism. Is this right? --- sgml-data-2.0.6.orig/debian/postrm 2011-11-02 22:14:48.124000413 -0400 +++ sgml-data-2.0.7/debian/postrm 2011-11-06 15:26:05.03230 -0500 @@ -4,6 +4,8 @@ if [ "$1" = "purge" ] then + rm -f /etc/xml/sgml-data.xml* || : + rm -f /etc/sgml/sgml-data* || : rmdir -p --ignore-fail-on-non-empty /etc/sgml rmdir -p --ignore-fail-on-non-empty /etc/xml fi -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAOHcdNa4KAB4Mg=5Mo24pQxh2PZ0xV=izEQg=_hy5ghbwdh...@mail.gmail.com
Bug#647473: question about your patch
Fixed patch attached diff -ur sgml-data-2.0.6.orig/debian/changelog sgml-data-2.0.7/debian/changelog --- sgml-data-2.0.6.orig/debian/changelog 2011-11-02 22:14:48.124000413 -0400 +++ sgml-data-2.0.7/debian/changelog 2011-11-02 22:36:55.887998903 -0400 @@ -1,3 +1,11 @@ +sgml-data (2.0.7) unstable; urgency=low + + * QA upload. + * fix piuparts failure #647473 + * Lintian fixes + + -- David Steele Tue, 01 Nov 2011 22:30:09 -0400 + sgml-data (2.0.6) unstable; urgency=low * QA upload. diff -ur sgml-data-2.0.6.orig/debian/control sgml-data-2.0.7/debian/control --- sgml-data-2.0.6.orig/debian/control 2011-11-02 22:14:48.124000413 -0400 +++ sgml-data-2.0.7/debian/control 2011-11-02 22:22:33.715998883 -0400 @@ -2,7 +2,7 @@ Section: text Priority: optional Maintainer: Debian QA Group -Standards-Version: 3.8.3 +Standards-Version: 3.9.2 Build-Depends: debhelper (>= 5.0.0) Build-Depends-Indep: xml-core (>= 0.06) diff -ur sgml-data-2.0.6.orig/debian/postrm sgml-data-2.0.7/debian/postrm --- sgml-data-2.0.6.orig/debian/postrm 2011-11-02 22:14:48.124000413 -0400 +++ sgml-data-2.0.7/debian/postrm 2011-11-06 16:05:53.448000573 -0500 @@ -4,6 +4,8 @@ if [ "$1" = "purge" ] then +rm -f /etc/xml/sgml-data.xml /etc/xml/sgml-data.xml.old || : +rm -f /etc/sgml/sgml-data.cat /etc/sgml/sgml-data.cat.old || : rmdir -p --ignore-fail-on-non-empty /etc/sgml rmdir -p --ignore-fail-on-non-empty /etc/xml fi diff -ur sgml-data-2.0.6.orig/debian/rules sgml-data-2.0.7/debian/rules --- sgml-data-2.0.6.orig/debian/rules 2011-11-02 22:14:48.124000413 -0400 +++ sgml-data-2.0.7/debian/rules 2011-11-02 22:25:38.843993438 -0400 @@ -25,6 +25,9 @@ build: # nothing to be done +build-arch: build +build-indep: build + clean: $(checkdir) find . -name '*.bak' -o -name '*~' | xargs rm -f
Bug#647473: Usertags
User: debian...@lists.debian.org Usertags: piuparts piuparts.d.o -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caohcdnykbn8jarzdf5odnvrft6nujtvuhcnji2ymyrhqzd7...@mail.gmail.com
