Bug#167897: wavtools: Poor error messages when unable to open DSP

[Burton Windle]

Package: wavtools
Version: 1.3.2-8
Severity: normal

When wavp is unable to open the DSP, it gives somewhat-less-than-ideal
errors. IE, if someone is already using the DSP, it should say its busy,
and not just that it cannot initialize the DSP.


pen("/dev/dsp", O_WRONLY)  = -1 EBUSY (Device or resource busy)
ioctl(-1, SNDCTL_DSP_RESET, 0)  = -1 EBADF (Bad file descriptor)
ioctl(-1, SOUND_PCM_READ_BITS, 0xb9f8) = -1 EBADF (Bad file descriptor)
ioctl(-1, SNDCTL_DSP_CHANNELS, 0xb9f8) = -1 EBADF (Bad file descriptor)
ioctl(-1, SOUND_PCM_READ_RATE, 0xb9f8) = -1 EBADF (Bad file descriptor)
ioctl(-1, SNDCTL_DSP_GETBLKSIZE, 0x8049e60) = -1 EBADF (Bad file descriptor)
ioctl(-1, SNDCTL_DSP_SYNC, 0)   = -1 EBADF (Bad file descriptor)
write(2, "Cannot initialize DSP\n", 22Cannot initialize DSP

The same thing happens if the user doesn't have permission to write to
the DSP.. the kernel returns "permission denied", and so should the app
to the user.

-- System Information
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux razor 2.5.45 #2 Fri Nov 1 10:57:58 EST 2002 i686
Locale: LANG=C, LC_CTYPE=C

Versions of packages wavtools depends on:
ii  libc6 2.2.5-14.3 GNU C Library: Shared libraries an


CONFIDENTIALITY NOTICE: The information contained in this electronic message is 
legally privileged and confidential and intended only for the use of the 
individual or entity named above.  If the reader of this message is not the 
intended recipient, you are hereby notified that any dissemination, 
distribution, or copying of this e-mail or any of it’s components is strictly 
prohibited.  If you have received this email in error, please contact the 
sender at Campus USA Credit Union at (352) 335-9090.

Bug#167897: Patch

[Burton Windle]

Here is a quick patch that I whipped together to solve this bug. Please 
consider applying.

[EMAIL PROTECTED]:~/wavtools$ diff -u wavtools-1.3.2.orig/wav_play.c 
/tmp/wav_play.c
--- wavtools-1.3.2.orig/wav_play.c  2002-11-05 12:32:25.0 -0500
+++ /tmp/wav_play.c 2002-11-05 12:33:15.0 -0500
@@ -51,7 +51,14 @@
int i, p;

dsp_fd = open("/dev/dsp", O_WRONLY, 0);
+   if (dsp_fd<0) {
+   fprintf(stderr,"Cannot initialize DSP:");
+   perror("");
+   exit(0);
+         }
+





Burton Windle
Information Systems Specialist
Campus USA Credit Union
352-335-9090 x 1109

CONFIDENTIALITY NOTICE: The information contained in this electronic message is 
legally privileged and confidential and intended only for the use of the 
individual or entity named above.  If the reader of this message is not the 
intended recipient, you are hereby notified that any dissemination, 
distribution, or copying of this e-mail or any of it’s components is strictly 
prohibited.  If you have received this email in error, please contact the 
sender at Campus USA Credit Union at (352) 335-9090.