Bug#926175: apt-listchanges: only a single changelog is shown when multiple packages are updated

2021-06-27 Thread Brian Thompson
Every unexpected behavior is a potential bug. We shouldn't close this bug
yet.  Nicholas, are you still seeing this behavior?

-- 
Best regards,

Brian T


signature.asc
Description: PGP signature


Bug#926175: tag moreinfo 926175

2021-06-27 Thread Brian Thompson
tags 926175 moreinfo
thanks
-- 
Best regards,

Brian T


signature.asc
Description: PGP signature


Bug#990427: apt-listchanges: Invalid format text for mutt

2021-06-28 Thread Brian Thompson
Package: apt-listchanges
Version: 3.24
Severity: normal

Dear Maintainer,

After performing an installation of a previously uninstalled package,
apt-listchanges reported an error:

"Invalid format text for mutt"

The package still installed, but no changelog or NEWS was shown or
emailed out.

The expected behavior is that no error is thrown since the email_format
is set correctly, or if there is an error in my configuration (aside
from the email_format field), then that be pointed out instead.

-- Package-specific info:
==> /etc/apt/listchanges.conf <==
[apt]
frontend=pager
which=both
email_address=br...@hashvault.io
email_format=text
confirm=false
headers=true
reverse=false
titled=true
save_seen=/var/lib/apt/listchanges.db
no_network=false

[cmdline]
frontend=pager
email_address=br...@hashvault.io
email_format=text
which=both

[custom]
frontend=browser
browser=chromium


-- System Information:
Debian Release: 11.0
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-7-amd64 (SMP w/8 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages apt-listchanges depends on:
ii  apt2.2.4
ii  debconf [debconf-2.0]  1.5.75
ii  python33.9.2-3
ii  python3-apt2.2.0
ii  python3-debconf1.5.75
ii  sensible-utils 0.0.14
ii  ucf3.0043

apt-listchanges recommends no packages.

Versions of packages apt-listchanges suggests:
ii  chromium [www-browser]90.0.4430.212-1
ii  edbrowse [www-browser]3.7.7-2
ii  firefox-esr [www-browser] 78.11.0esr-1
ii  kitty [x-terminal-emulator]   0.19.3-1
ii  links [www-browser]   2.21-1+b1
ii  lynx [www-browser]2.9.0dev.6-2
ii  mlterm [x-terminal-emulator]  3.9.0-1
ii  palemoon [www-browser]29.2.0-1.gtk2
ii  postfix [mail-transport-agent]3.5.6-1+b1
ii  python3-gi3.38.0-2
ii  xfce4-terminal [x-terminal-emulator]  0.8.10-1
ii  xiterm+thai [x-terminal-emulator] 1.10-2+b2
ii  xterm [x-terminal-emulator]   366-1

-- debconf information:
* apt-listchanges/email-format: text
* apt-listchanges/confirm: false
* apt-listchanges/save-seen: true
* apt-listchanges/reverse: false
* apt-listchanges/email-address: br...@hashvault.io
* apt-listchanges/no-network: false
* apt-listchanges/which: both
* apt-listchanges/headers: true
* apt-listchanges/frontend: pager



Bug#989496: apt-listchanges: Error output if choosing to not continue after reading list of changes

2021-06-30 Thread Brian Thompson
Tia,

Thank you for reporting this bug.  I can confirm that this is an issue:

apt-listchanges: Do you want to continue? [Y/n] n
apt-listchanges: Aborting
E: Sub-process /usr/bin/apt-listchanges --apt || test $? -lt 10 returned an
error code (1)
E: Failure running script /usr/bin/apt-listchanges --apt || test $? -lt 10

I believe I have found the issue and have a fix ready to go.  I'll
set the status to pending.

-- 
Best regards,

Brian



Bug#986840: apt-listchanges fails to parse status files with ^M characters; should use apt_pkg.TagFile, not write its own parser

2021-07-01 Thread Brian Thompson
> As reported in
> https://bugs.launchpad.net/ubuntu/+source/apt-listchanges/+bug/1854772,
> apt-listchanges
> fails to parse status files that contain carriage return characters, as
> Python normalizes the line endings.

I'm tracking the downstream bug in Ubuntu as well as this one.

> Instead of writing its own ad-hoc parser, apt-listchanges should use
> apt_pkg.TagFile instead.

I did a little bit of digging into how to rewrite the parser with your
suggested changes.  I agree that apt-listchanges should not be using its
own parser, especially since a standardized one exists in apt_pkg.

Preliminarily, I have these changes in mind for
apt_listchanges.ControlParser.readfile() (spacing adjusted for brevity):

```python
...
try:
  with apt_pkg.TagFile(file) as tagfile:
for section in tagfile:
  self.stanzas += [ControlStanza(x) for x in section]
except: ...  
```

There also, at the very least, may need a change to be made to
apt_listchanges.DebianFiles.ControlParser.readdeb() as well.  I'm hoping 
that we can avoid rewriting some of the classes in
apt_listchanges.DebianFiles, namely ControlParser and ControlStanza.

If you have suggestions on how the change would look, please let me
know.

-- 
Best regards,

Brian T


signature.asc
Description: PGP signature


Bug#986840: apt-listchanges fails to parse status files with ^M characters; should use apt_pkg.TagFile, not write its own parser

2021-07-01 Thread Brian Thompson
Julian,

I didn't see that you cloned this bug and assigned it to dpkg and that
the bug is no longer in apt-listchanges.  I still think that your
original proposal for apt-listchanges is relevant and is a change worth
making.
-- 
Best regards,

Brian T


signature.asc
Description: PGP signature


Bug#939287: Add urgency level separators

2021-07-01 Thread Brian Thompson
On Tue, 03 Sep 2019 03:37:58 +0800 =?utf-8?B?56mN5Li55bC8?= Dan
Jacobson  wrote:
> Man page says 'The groups are sorted by the urgency of the most urgent
> change, and than by the package name.'
> 
> Alas, that looks like
> 
> A
> B
> C
> A
> B
> A
> B
> 
> to the user. So perhaps add
> 
> --urgency=high:
> A
> B
> C
> --urgency=medium:
> A
> B
> --urgency=low:
> A
> B
> 
> separators, so it would all make sense.

I like the change you proposed.  I don't think that would be too hard to
do given that the changes are already sorted in order.  This would
definitely improve readability IMO.
-- 
Best regards,

Brian T


signature.asc
Description: PGP signature


Bug#989496: Looking to change the subject

2021-07-05 Thread Brian Thompson
It was brought to my attention by David K. (thank you, David), that the
what you are seeing is intended functionality.  I proposed in the email
thread with David that we could improve the error message, since right
now it may be confusing to users that it is actually expected behavior.
A cleaner, clearer error message should resolve any confusion.

I will CC you Tia.

-- 
Best regards,

Brian T
B.S. Computer Science 2014 (Truman State University)
  Minor Stasitics
  Minor Chemistry
  Minor Mathematics


signature.asc
Description: PGP signature


Bug#869748: Cloned and assigned to aptitude

2021-07-05 Thread Brian Thompson
I cloned this bug and assigned it to the aptitude maintainers.

The bug number is #990747.

-- 
Best regards,

Brian T
B.S. Computer Science 2014 (Truman State University)
  Minor Stasitics
  Minor Chemistry
  Minor Mathematics


signature.asc
Description: PGP signature


Bug#989496: Tagging wontfix

2021-07-08 Thread Brian Thompson
Since this is expected behavior, I am tagging as "wontfix".

I don't think it's a good idea to suppress the error message.
apt-listchanges gives an "Aborting" message prior to throwing the error.

-- 
Best regards,

Brian T
B.S. Computer Science 2014 (Truman State University)


signature.asc
Description: PGP signature