Bug#1066246: lcm: FTBFS: emit_cpp.c:306:19: error: implicit declaration of function ‘_exit’ [-Werror=implicit-function-declaration]
: In function ‘sprintf’, inlined from ‘emit_package’ at emit_python.c:702:5: /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output 2 or more bytes (assuming 4097) into a destination of size 4096 30 | return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1, | ^~ 31 | __glibc_objsize (__s), __fmt, | ~ 32 | __va_arg_pack ()); | ~ emit_python.c: In function ‘emit_package’: emit_python.c:44:13: warning: ‘__builtin_strncpy’ output may be truncated copying between 0 and 4094 bytes from a string of length 4095 [-Wstringop-truncation] 44 | strncpy(dirpath, path, i); | ^ cc1: some warnings being treated as errors emit_lua.c: In function ‘emit_package’: emit_lua.c:762:33: warning: ‘__builtin___sprintf_chk’ may write a terminating nul past the end of the destination [-Wformat-overflow=] 762 | sprintf(package_dir, "%s%s%s", package_dir_prefix, pdname, | ^ In file included from /usr/include/stdio.h:906, from emit_lua.c:1: In function ‘sprintf’, inlined from ‘emit_package’ at emit_lua.c:762:5: /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output 2 or more bytes (assuming 4097) into a destination of size 4096 30 | return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1, | ^~ 31 | __glibc_objsize (__s), __fmt, | ~ 32 | __va_arg_pack ()); | ~ emit_lua.c: In function ‘emit_package’: emit_lua.c:45:13: warning: ‘__builtin_strncpy’ output may be truncated copying between 0 and 4094 bytes from a string of length 4095 [-Wstringop-truncation] 45 | strncpy(dirpath, path, i); | ^ make[3]: *** [Makefile:513: emit_cpp.o] Error 1 Here is a simple fix and I uploaded it to mentor: https://mentors.debian.net/package/lcm/ But jose.luis.rivero.partida has uploaded it with new upstream release 1.5.1 under the same mentor and the issue was fixed already also. https://mentors.debian.net/package/lcm/ see v1. So I am not sure situation how to deal with: if we upload 1.5.1 to unstale maybe we need SOANME bump first, this is disturb currently t64 transition, right? if we fix the FTBFS first within 1.3.1 the patch is fine. -- Regards, -- Bo YU diff -Nru lcm-1.3.1+repack1/debian/changelog lcm-1.3.1+repack1/debian/changelog --- lcm-1.3.1+repack1/debian/changelog 2023-12-07 04:48:38.0 +0800 +++ lcm-1.3.1+repack1/debian/changelog 2024-03-22 16:45:50.0 +0800 @@ -1,3 +1,10 @@ +lcm (1.3.1+repack1-8) unstable; urgency=medium + + * QA upload. + * Fix implicit-function-declaration error issue. (Closes: #1066246) + + -- Bo YU Fri, 22 Mar 2024 16:45:50 +0800 + lcm (1.3.1+repack1-7) unstable; urgency=medium * QA upload. diff -Nru lcm-1.3.1+repack1/debian/patches/0006-fix-implicit-function-declaration-issue.patch lcm-1.3.1+repack1/debian/patches/0006-fix-implicit-function-declaration-issue.patch --- lcm-1.3.1+repack1/debian/patches/0006-fix-implicit-function-declaration-issue.patch 1970-01-01 08:00:00.0 +0800 +++ lcm-1.3.1+repack1/debian/patches/0006-fix-implicit-function-declaration-issue.patch 2024-03-22 16:44:30.0 +0800 @@ -0,0 +1,27 @@ +Description: fix -Werror=implicit-function-declaration issue +Author: Bo YU +Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066246 +Forwarded: https://github.com/lcm-proj/lcm/issues/498 +Last-Update: 2024-03-22 +--- +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ +--- a/lcm-logger/lcm_logger.c b/lcm-logger/lcm_logger.c +@@ -8,6 +8,7 @@ + + #include + #include ++#include + + #include + +--- a/lcmgen/emit_cpp.c b/lcmgen/emit_cpp.c +@@ -11,6 +11,7 @@ + + #include + #include ++#include + + #include "lcmgen.h" + diff -Nru lcm-1.3.1+repack1/debian/patches/series lcm-1.3.1+repack1/debian/patches/series --- lcm-1.3.1+repack1/debian/patches/series 2023-12-06 08:27:57.0 +0800 +++ lcm-1.3.1+repack1/debian/patches/series 2024-03-22 14:50:00.0 +0800 @@ -4,3 +4,4 @@ 0004-doxygen-docs-go-to-a-subdir.patch 0005-I-default-to-java-1.6-instead-of-1.5.patch remove-epydoc +0006-fix-implicit-function-declaration-issue.patch signature.asc Description: PGP signature
Bug#1066658: sup: FTBFS: scm.c:316:9: error: implicit declaration of function ‘setproctitle’ [-Werror=implicit-function-declaration]
Tags: patch
Hi,
,On Wed, Mar 13, 2024 at 12:57:21PM +0100, Lucas Nussbaum wrote:
scm.c: In function ‘service’:
scm.c:316:9: error: implicit declaration of function ‘setproctitle’
[-Werror=implicit-function-declaration]
316 | setproctitle("Serving %s", remotehost());
| ^~~~
scm.c: In function ‘request’:
scm.c:448:16: warning: ignoring return value of ‘write’ declared with attribute
‘warn_unused_result’ [-Wunused-result]
448 | (void) write(netfile, &x, sizeof(int));
|^~~
scmio.c: In function ‘readfile’:
I have uploaded it to mentor to wait for sponsoring[0]. But there is one
debdiff if you can review it.
[0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068814
Thanks.
--
Regards,
--
Bo YU
diff -Nru sup-20100519/debian/changelog sup-20100519/debian/changelog
--- sup-20100519/debian/changelog 2020-08-05 19:53:16.0 +0800
+++ sup-20100519/debian/changelog 2024-04-11 16:41:22.0 +0800
@@ -1,3 +1,12 @@
+sup (20100519-4) unstable; urgency=medium
+
+ * QA upload.
+ * set std-ver to 4.7.0.
+ * Add 07_fix-implicit-function-declaration.patch to fix ftbfs issue.
+(Closes: #1066658)
+
+ -- Bo YU Thu, 11 Apr 2024 16:41:22 +0800
+
sup (20100519-3) unstable; urgency=medium
* QA upload.
diff -Nru sup-20100519/debian/control sup-20100519/debian/control
--- sup-20100519/debian/control 2020-08-05 19:48:03.0 +0800
+++ sup-20100519/debian/control 2024-04-11 16:03:18.0 +0800
@@ -3,7 +3,7 @@
Priority: optional
Build-Depends: debhelper-compat (= 13), libwrap0-dev
Maintainer: Debian QA Group
-Standards-Version: 4.5.0
+Standards-Version: 4.7.0
Package: sup
Architecture: any
diff -Nru
sup-20100519/debian/patches/07_fix-implicit-function-declaration.patch
sup-20100519/debian/patches/07_fix-implicit-function-declaration.patch
--- sup-20100519/debian/patches/07_fix-implicit-function-declaration.patch
1970-01-01 07:30:00.0 +0730
+++ sup-20100519/debian/patches/07_fix-implicit-function-declaration.patch
2024-04-11 15:59:50.0 +0800
@@ -0,0 +1,17 @@
+Description: fix implicit-function-declaration issue
+Author: Bo YU
+Bug: https://bugs.debian.org/1066658
+Last-Update: 2024-04-11
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/scm.c
b/scm.c
+@@ -195,6 +195,8 @@
+ #define INADDR_LOOPBACK (u_long)0x7f01 /* 127.0.0.1 */
+ #endif
+
++void setproctitle(const char *fmt, ...);
++
+ char scmversion[] = "4.3 BSD";
+ extern int silent;
+
diff -Nru sup-20100519/debian/patches/series sup-20100519/debian/patches/series
--- sup-20100519/debian/patches/series 2020-08-05 19:43:02.0 +0800
+++ sup-20100519/debian/patches/series 2024-04-11 15:01:34.0 +0800
@@ -4,3 +4,4 @@
04_fix_man.patch
05_unconst.patch
06_fix_ftbfs.patch
+07_fix-implicit-function-declaration.patch
signature.asc
Description: PGP signature
Bug#1014120: libowfat FTBFS: ln: failed to create hard link 'libowfat/buffer.h'
Hi, On Wed, Sep 14, 2022 at 10:50:36PM +0200, Bastian Germann wrote: I have tried to fix this but as I am not able to reproduce this locally I am at a loss here. Maybe someone else has an idea... Some days ago I want to fix the issue but can not to reprodule also. It was the new issue: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1017157 -- Regards, -- Bo YU signature.asc Description: PGP signature
Bug#1021896: close the reportbug
close 1021896 close -1 thanks -- Regards, -- Bo YU signature.asc Description: PGP signature
Bug#1022526: python-ssdeep: FTBFS: distutils.errors.DistutilsClassError: command class must subclass Command
Hi, On Sat, Nov 19, 2022 at 02:06:04AM +0200, Adrian Bunk wrote: Control: tags -1 fixed-upstream On Sun, Nov 13, 2022 at 10:04:04AM +0200, Stefano Rivera wrote: Hi Helmut (2022.11.04_11:36:41_+0200) > And no, updating it to 3.4 does not fix the ftbfs. Updating it to 3.4.1 might. It includes this commit: https://github.com/DinoTools/python-ssdeep/commit/fce02106c07ff56a84097dec0df02fb00ef69dc7 which moves the setuptools import above the first distutils import, which should resolve this issue. I can confirm that 3.4.1 does fix the build (but I am reluctant to update it myself). Is it ok to update for me? I have built it based on 3.4.1: https://salsa.debian.org/python-team/packages/python-ssdeep/-/tree/debian/main/ One question: If I put the packahe under Debian Python team, should to change maintainer to DPT from QA team? https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=952840 -- Regards, -- Bo YU signature.asc Description: PGP signature
Bug#1024798: dds2tar: ftbfs on due to 'debian/dds2tar/usr/bin': No such file or directory'
Source: dds2tar Version: 2.5.2-8 Severity: serious Tags: ftbfs The package has ftbfs issues due to: ``` make[1]: Entering directory '/<>' make install DESTDIR=`pwd`/debian/dds2tar make[2]: Entering directory '/<>' install -c dds2tar /<>/debian/dds2tar/usr/bin install: cannot create regular file '/<>/debian/dds2tar/usr/bin': No such file or directory make[2]: *** [Makefile:142: install] Error 1 make[2]: Leaving directory '/<>' make[1]: *** [debian/rules:12: override_dh_auto_install] Error 2 make[1]: Leaving directory '/<>' make: *** [debian/rules:6: binary-arch] Error 2 ``` The full buildd log is here: https://buildd.debian.org/status/fetch.php?pkg=dds2tar&arch=amd64&ver=2.5.2-8&stamp=1669243735&raw=0 I will try to fix the issue. -- Regards, -- Bo YU signature.asc Description: PGP signature
Bug#1027538: herisvm: FTBFS: dh_auto_build: error: exec (for cmd: mkcmake PREFIX=/usr MANDIR=/usr/share/man INFODIR=/usr/share/info SYSCONFDIR=/etc STRIPFLAG= LIBDIR=/usr/lib/x86_64-linux-gnu LIBEXECD
Source: herisvm Version: 0.9.0-2 Followup-For: Bug #1027538 Hi Lucas, I have rebuild the package on my local pc, but it works: ``` ... Build Architecture: amd64 Build Type: full Build-Space: 584 Build-Time: 11 Distribution: unstable Host Architecture: amd64 Install-Time: 23 Job: /home/vimer/build/rfs/nmu/37_herisvm/herisvm_0.9.0-2.dsc Lintian: info Machine Architecture: amd64 Package: herisvm Package-Time: 102 Source-Version: 0.9.0-2 Space: 584 Status: successful Version: 0.9.0-2 Finished at 2023-01-10T07:32:40Z Build needed 00:01:42, 584k disk space ``` I am not sure how to deal with the bug in such situation. I can close it but I think after your confirmation. -- Regards, -- Bo YU signature.asc Description: PGP signature
Bug#999937: tup: depends on obsolete pcre3 library
Source: tup Version: 0.7.11-1 Followup-For: Bug #37 Hi, The upstream has tried to switch pcre2[0], but the backporting is not easy, so maybe waiting a new release is good iead. [0]: https://github.com/gittup/tup/commit/f26bc1e8c0b87d9d351e062c7d27afbbdc53869d -- Regards, -- Bo YU signature.asc Description: PGP signature
Bug#1012624: Update golang-github-blevesearch-bleve dependency to bbolt
Source: golang-github-blevesearch-bleve Version: 0.5.0+git20170912.278.6eea5b78-5 Followup-For: Bug #1012624 Hi, The golang-github-blevesearch-bleve package seems to be orphaned from Debian go team view. BTW, the golang-github-blevesearch-bleve upstream had switched to bbolt from here [0] I think. [0]: https://github.com/blevesearch/bleve/blob/master/go.mod#L28 -- Best Regards, signature.asc Description: PGP signature
Bug#1015737: bcolz: please add support for riscv64
Source: bcolz
Version: 1.2.1+ds2-7
Severity: wishlist
Tags: patch
User: debian-ri...@lists.debian.org
Usertags: riscv64
X-Debbugs-Cc: debian-ri...@lists.debian.org
Dear bcolz Maintainer,
The bcolz package can be built on my real riscv64 hardware,
so could you add support for riscv64?
Bo
--
Best Regards
diff -Nru bcolz-1.2.1+ds2/debian/control bcolz-1.2.1+ds2/debian/control
--- bcolz-1.2.1+ds2/debian/control 2020-09-06 21:16:09.0 +
+++ bcolz-1.2.1+ds2/debian/control 2020-10-13 11:34:55.0 +
@@ -22,7 +22,7 @@
Homepage: https://github.com/Blosc/bcolz
Package: python3-bcolz
-Architecture: alpha amd64 arm64 armel armhf hurd-i386 i386 ia64 kfreebsd-amd64 kfreebsd-i386 mips64el mipsel powerpcspe ppc64el sh4
+Architecture: alpha amd64 arm64 armel armhf hurd-i386 i386 ia64 kfreebsd-amd64 kfreebsd-i386 mips64el mipsel powerpcspe ppc64el riscv64 sh4
Section: python
Depends: python3-pkg-resources,
${misc:Depends},
signature.asc
Description: PGP signature
Bug#1015924: pvm: ftbfs on riscv64("Unknown architecture!")
Source: pvm Version: 3.4.6-3.2 Severity: minor Tags: ftbfs, patch User: debian-ri...@lists.debian.org Usertags: riscv64 X-Debbugs-Cc: debian-ri...@lists.debian.org Dear pvm Maintainer, The pvm package has a ftbfs issue on riscv64: ``` ... dh clean debian/rules override_dh_auto_clean make[1]: Entering directory '/<>' Unknown architecture! Unknown architecture! echo "#!/bin/sh" > lib/pvmgetarch echo "echo " > lib/pvmgetarch chmod +x lib/pvmgetarch chmod +x debian/getpvmarch make PVM_ROOT=`pwd` clean ... ``` The full buildd log is here: https://buildd.debian.org/status/fetch.php?pkg=pvm&arch=riscv64&ver=3.4.6-3.2&stamp=1636477315&raw=0 The patch attached is to fix the issue and I can build it on riscv64 arch with it, so please consider to apply it to fix the issue, thanks. -- Regards, -- Bo YU diff -Nru pvm-3.4.6/debian/getpvmarch pvm-3.4.6/debian/getpvmarch --- pvm-3.4.6/debian/getpvmarch 2018-07-24 22:31:14.0 +0800 +++ pvm-3.4.6/debian/getpvmarch 2021-11-10 00:16:02.0 +0800 @@ -48,6 +48,9 @@ sh4) echo LINUXSH ;; + riscv64) + echo LINUXRISCV + ;; *) echo 'Unknown architecture!' 1>&2 exit 1; diff -Nru pvm-3.4.6/debian/patches/27-add-riscv64-support.patch pvm-3.4.6/debian/patches/27-add-riscv64-support.patch --- pvm-3.4.6/debian/patches/27-add-riscv64-support.patch 1970-01-01 07:30:00.0 +0730 +++ pvm-3.4.6/debian/patches/27-add-riscv64-support.patch 2021-11-10 00:16:02.0 +0800 @@ -0,0 +1,36 @@ +--- /dev/null b/conf/LINUXRISCV.def +@@ -0,0 +1,10 @@ ++ARCHCFLAGS = -DSYSVSIGNAL -DNOWAIT3 -DRSHCOMMAND=\"/usr/bin/rsh\" \ ++ -DNEEDENDIAN -DFDSETNOTSTRUCT -DHASERRORVARS \ ++ -DCTIMEISTIMET -DSYSERRISCONST -DHASREADLINE ++ARCHDLIB = ++ARCHDOBJ = ++ARCHLIB= -lreadline ++HASRANLIB = t ++AR = ar ++PVM_ARCH = LINUXRISCV ++MAKE = make +--- /dev/null b/conf/LINUXRISCV.m4 +@@ -0,0 +1,20 @@ ++divert(-1) ++undefine(`len') ++# ++# append an underscore to FORTRAN function names ++# ++define(`FUNCTION',`$1_') ++# ++# FORTRAN character strings are passed as follows: ++# a pointer to the base of the string is passed in the normal ++# argument list, and the length is passed by value as an extra ++# argument, after all of the other arguments. ++# ++define(`ARGS',`($1`'undivert(1))') ++define(`SAVE',`divert(1)$1`'divert(0)') ++define(`STRING_ARG',`$1_ptr`'SAVE(`, $1_len')') ++define(`STRING_ARG_DECL',`char * $1_ptr; int $1_len') ++define(`STRING_LEN',`$1_len') ++define(`STRING_PTR',`$1_ptr') ++divert(0) ++ diff -Nru pvm-3.4.6/debian/patches/series pvm-3.4.6/debian/patches/series --- pvm-3.4.6/debian/patches/series 2020-08-19 22:48:23.0 +0800 +++ pvm-3.4.6/debian/patches/series 2021-11-10 00:16:02.0 +0800 @@ -27,3 +27,4 @@ 26-groff-quote.patch -fallow-argument-mismatch-in-examples-Makefile.aimk -fallow-argument-mismatch-in-gexamples-Makefile.aimk +27-add-riscv64-support.patch signature.asc Description: PGP signature
Bug#1075694: xxkb: ftbfs with GCC-14
Hi, Thanks for reviewing the upload! On Sat, Nov 09, 2024 at 07:49:00AM +0800, YunQiang Su wrote: On Tue, 5 Nov 2024 11:25:58 +0800 Bo YU wrote: > * QA upload. > * Add 0004-fix-ftbfs-on-gcc-14.patch to fix the ftbfs issue. > (Closes: #1075694) > * Set std-ver to 4.7.0. > * Add Rules-Requires-Root on d/control. > * Add doc-base for xxkb. > * debian/rules: pass CFLAGS to dh_auto_build. Sorry for the useless entry of the chanelog, I have this with v2. It has a couple of problems: 1. it fails to run multiple times of `dpkg-buildpackage -B` due to that the generated Makefile is not cleaned. You may need to clean it. Okay, this time I have cleared it explicitly. But to my surprise is that this can not be reproduced by `pbuilder build --twice .dsc`, see the commnet on #1 with https://mentors.debian.net/package/xxkb/ from Phil. I was not able to retrigger this issue with `dpkg-buildpackage -B` on refresh chroot also. However, I got the impressive if wrong something in Makefile(generated by imakefile) will lead to fail to build. 2. The changelog entry `* debian/rules: pass CFLAGS to dh_auto_build.` is misleading. Ah, sorry, I should mention it ahead. I have updated it with v2 which is to drop the entry, see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1075694#21 3. Hardcode hardening options is not a good idea. You can do something like override_dh_auto_build: HARDEN_CFLAGS="`dpkg-buildflags --get CFLAGS` `dpkg-buildflags --get LDFLAGS`" \ dh_auto_build And in Imakefile CDEBUGFLAGS = -O2 -Wall -g $(HARDEN_CFLAGS) Hmm, I try it with your suggestion but unfortunately it does not work on my side. But I found another solution like this[0] to fix the issue and it seems it was more simpler. 4. It seems that it can support librsvg. Why is it not enabled? hmm, I am not sure about this. But when I try it on d/rules, I will get: ``` Package glib-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `glib-2.0.pc' to the PKG_CONFIG_PATH environment variable Package 'glib-2.0', required by 'virtual:world', not found Package 'gdk-pixbuf-xlib-2.0', required by 'virtual:world', not found Package 'librsvg-2.0', required by 'virtual:world', not found In file included from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33, from /usr/include/stdio.h:28, from xxkb.c:10: /usr/include/features.h:197:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] 197 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" | ^~~ gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. -fstack-protector-strong -fstack-clash-protection - Wformat -Werror=format-security -fcf-protection -Wl,-z,relro -Dlinux -D__amd64__ -D_POSIX_C_SOURCE=199309L - D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -DAPPDEFDIR=\"/etc/X11/a pp-defaults\" -DAPPDEFFILE=\"XXkb\" -DXT_RESOURCE_SEARCH -DSHAPE_EXT -DSVG_GRAPHICS `pkg-config --cflags glib-2.0 gdk-pixbuf-xlib-2. 0 librsvg-2.0` -Wdate-time -D_FORTIFY_SOURCE=2 -c -o resource.o resource.c Package glib-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `glib-2.0.pc' to the PKG_CONFIG_PATH environment variable Package 'glib-2.0', required by 'virtual:world', not found Package 'gdk-pixbuf-xlib-2.0', required by 'virtual:world', not found Package 'librsvg-2.0', required by 'virtual:world', not found In file included from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33, from /usr/include/string.h:26, 197 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"[35/1921] | ^~~ resource.c:33:10: fatal error: gdk-pixbuf-xlib/gdk-pixbuf-xlib.h: No such file or directory 33 | #include | ^~~ ``` I think it is not easy to fix the issue given so many outdated libraries. Another reason is that I am not sure it works or not even we support librsvg with the QA upload. I think we can send a reportbug to ask for enabling this if this is okay. So personally I would like to this QA upload with left the issue. Is that okay? I have update it on mentor also: ``` To access further information about this package, please visit the following URL: https://mentors.debian.net/package/xxkb/ Alternatively, you can download
Bug#1075694: xxkb: ftbfs with GCC-14
xxkb (1.11.1-3) unstable; urgency=medium
.
* QA upload.
* Add 0004-fix-ftbfs-on-gcc-14.patch to fix the ftbfs issue.
(Closes: #1075694)
* Set std-ver to 4.7.0.
* Add Rules-Requires-Root on d/control.
* Add doc-base for xxkb.
* debian/rules: clean up Makefile explicitly.
* debian/rules: update CDEBUGFLAGS to fix hardening issue.
Oops, I forget the debdiff about this, sorry for that.
diff -Nru xxkb-1.11.1/debian/changelog xxkb-1.11.1/debian/changelog
--- xxkb-1.11.1/debian/changelog2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/changelog2024-11-04 23:12:36.0 +0800
@@ -1,3 +1,16 @@
+xxkb (1.11.1-3) unstable; urgency=medium
+
+ * QA upload.
+ * Add 0004-fix-ftbfs-on-gcc-14.patch to fix the ftbfs issue.
+(Closes: #1075694)
+ * Set std-ver to 4.7.0.
+ * Add Rules-Requires-Root on d/control.
+ * Add doc-base for xxkb.
+ * debian/rules: clean up Makefile explicitly.
+ * debian/rules: update CDEBUGFLAGS to fix hardening issue.
+
+ -- Bo YU Mon, 04 Nov 2024 23:12:36 +0800
+
xxkb (1.11.1-2) unstable; urgency=medium
* QA upload.
diff -Nru xxkb-1.11.1/debian/clean xxkb-1.11.1/debian/clean
--- xxkb-1.11.1/debian/clean1970-01-01 07:30:00.0 +0730
+++ xxkb-1.11.1/debian/clean2024-11-04 23:12:36.0 +0800
@@ -0,0 +1 @@
+Makefile
diff -Nru xxkb-1.11.1/debian/control xxkb-1.11.1/debian/control
--- xxkb-1.11.1/debian/control 2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/control 2024-11-04 23:12:36.0 +0800
@@ -9,10 +9,11 @@
libxt-dev,
xutils-dev,
Maintainer: Debian QA Group
-Standards-Version: 4.6.1
+Standards-Version: 4.7.0
Homepage: http://sourceforge.net/projects/xxkb/
Vcs-Git: https://salsa.debian.org/debian/xxkb.git
Vcs-Browser: https://salsa.debian.org/debian/xxkb
+Rules-Requires-Root: no
Package: xxkb
Architecture: any
diff -Nru xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch
xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch
--- xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch 1970-01-01
07:30:00.0 +0730
+++ xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch 2024-11-04
23:12:36.0 +0800
@@ -0,0 +1,17 @@
+Description: fix ftbfs on gcc-14
+Author: Bo YU
+Bug: https://bugs.debian.org/1075694
+Last-Update: 2024-11-04
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/resource.c
b/resource.c
+@@ -622,7 +622,7 @@
+ if (filename)
+ stat = XrmCombineFileDatabase(filename, &db, True);
+ else
+- stat = NULL;
++ stat = 0;
+ if (stat == 0 && db == NULL) {
+ /* failed */
+ warnx("Unable to find configuration data");
diff -Nru xxkb-1.11.1/debian/patches/series xxkb-1.11.1/debian/patches/series
--- xxkb-1.11.1/debian/patches/series 2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/patches/series 2024-11-04 23:12:36.0 +0800
@@ -1,3 +1,4 @@
0001-debian-patch.patch
0002-Fix-manpage-semantics.patch
0003-Imakefile-enable-debug-flag.patch
+0004-fix-ftbfs-on-gcc-14.patch
diff -Nru xxkb-1.11.1/debian/rules xxkb-1.11.1/debian/rules
--- xxkb-1.11.1/debian/rules2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/rules2024-11-04 23:12:36.0 +0800
@@ -3,11 +3,19 @@
# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1
+export CFLAGS := $(shell DEB_BUILD_MAINT_OPTIONS=hardening=+all
dpkg-buildflags --get CFLAGS)
+export LDFLAGS := $(shell DEB_BUILD_MAINT_OPTIONS=hardening=+all
dpkg-buildflags --get LDFLAGS)
+
%:
dh $@
-execute_before_dh_auto_build:
+execute_after_dh_auto_clean:
+ dh_auto_clean
+ rm -f Makefile
+
+override_dh_auto_build:
xmkmf
+ $(MAKE) CDEBUGFLAGS="$(CFLAGS) $(LDFLAGS) $(CDEBUGFLAGS)"
override_dh_auto_install:
$(MAKE) install install.man DESTDIR=$(CURDIR)/debian/tmp/
diff -Nru xxkb-1.11.1/debian/watch xxkb-1.11.1/debian/watch
--- xxkb-1.11.1/debian/watch2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/watch2024-11-04 23:12:36.0 +0800
@@ -1,2 +1,2 @@
-version=3
+version=4
http://sf.net/xxkb/xxkb-(\d+(?:\.\d+)+)-src\.tar\.gz
diff -Nru xxkb-1.11.1/debian/xxkb.doc-base xxkb-1.11.1/debian/xxkb.doc-base
--- xxkb-1.11.1/debian/xxkb.doc-base1970-01-01 07:30:00.0 +0730
+++ xxkb-1.11.1/debian/xxkb.doc-base2024-11-04 23:12:36.0 +0800
@@ -0,0 +1,10 @@
+Document: xxkb
+Title: Debian xxkb Manual
+Author: Ivan Pascal
+Abstract: This manual describes what xxkb is
+ and how to use it.
+Section: Programming
+
+Format: HTML
+Index: /usr/share/doc/xxkb/3gr.html
+Files: /usr/share/doc/xxkb/3gr.html
signature.asc
Description: PGP signature
Bug#1075694: xxkb: ftbfs with GCC-14
Hi,
On Wed, Nov 13, 2024 at 09:53:33AM +0800, YunQiang Su wrote:
I guess that you missed the changes of d/rules?
- $(MAKE) CDEBUGFLAGS="$(CFLAGS) $(LDFLAGS) $(CDEBUGFLAGS)"
+ $(MAKE) DEB_CDEBUGFLAGS="$(CFLAGS) $(LDFLAGS)"
Sorry, my bad, I messed up this when generating a new debdiff with
re-download xxkb source code.
Syning it to mentors also, thanks for your time again.
--
Regards,
--
Bo YU
diff -Nru xxkb-1.11.1/debian/changelog xxkb-1.11.1/debian/changelog
--- xxkb-1.11.1/debian/changelog 2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/changelog 2024-11-12 23:36:05.0 +0800
@@ -1,3 +1,17 @@
+xxkb (1.11.1-3) unstable; urgency=medium
+
+ * QA upload.
+ * Add 0004-fix-ftbfs-on-gcc-14.patch to fix the ftbfs issue.
+(Closes: #1075694)
+ * Set std-ver to 4.7.0.
+ * Set standard of d/watch to 4.
+ * Add Rules-Requires-Root on d/control.
+ * Add doc-base for xxkb.
+ * debian/rules: clean up Makefile explicitly.
+ * Update 0003-*.patch and pass DEB_CDEBUGFLAGS to fix hardening issue.
+
+ -- Bo YU Tue, 12 Nov 2024 23:36:05 +0800
+
xxkb (1.11.1-2) unstable; urgency=medium
* QA upload.
diff -Nru xxkb-1.11.1/debian/control xxkb-1.11.1/debian/control
--- xxkb-1.11.1/debian/control 2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/control 2024-11-12 23:24:04.0 +0800
@@ -9,10 +9,11 @@
libxt-dev,
xutils-dev,
Maintainer: Debian QA Group
-Standards-Version: 4.6.1
+Standards-Version: 4.7.0
Homepage: http://sourceforge.net/projects/xxkb/
Vcs-Git: https://salsa.debian.org/debian/xxkb.git
Vcs-Browser: https://salsa.debian.org/debian/xxkb
+Rules-Requires-Root: no
Package: xxkb
Architecture: any
diff -Nru xxkb-1.11.1/debian/patches/0003-Imakefile-enable-debug-flag.patch xxkb-1.11.1/debian/patches/0003-Imakefile-enable-debug-flag.patch
--- xxkb-1.11.1/debian/patches/0003-Imakefile-enable-debug-flag.patch 2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/patches/0003-Imakefile-enable-debug-flag.patch 2024-11-12 23:29:50.0 +0800
@@ -6,16 +6,14 @@
Imakefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
-diff --git a/Imakefile b/Imakefile
-index 931ca42..36010b8 100644
--- a/Imakefile
+++ b/Imakefile
-@@ -24,7 +24,7 @@ CFLAGS += `pkg-config --cflags glib-2.0 gdk-pixbuf-xlib-2.0 librsvg-2.0`
+@@ -24,7 +24,7 @@
LOCAL_LIBRARIES += `pkg-config --libs glib-2.0 gdk-pixbuf-xlib-2.0 librsvg-2.0`
#endif
-CDEBUGFLAGS = -O2 -Wall
-+CDEBUGFLAGS = -O2 -Wall -g
++CDEBUGFLAGS = -O2 -Wall -g $(DEB_CDEBUGFLAGS)
SED = sed
ComplexProgramTarget(xxkb)
diff -Nru xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch
--- xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch 1970-01-01 07:30:00.0 +0730
+++ xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch 2024-11-12 23:22:16.0 +0800
@@ -0,0 +1,17 @@
+Description: fix ftbfs on gcc-14
+Author: Bo YU
+Bug: https://bugs.debian.org/1075694
+Last-Update: 2024-11-04
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/resource.c
b/resource.c
+@@ -622,7 +622,7 @@
+ if (filename)
+ stat = XrmCombineFileDatabase(filename, &db, True);
+ else
+- stat = NULL;
++ stat = 0;
+ if (stat == 0 && db == NULL) {
+ /* failed */
+ warnx("Unable to find configuration data");
diff -Nru xxkb-1.11.1/debian/patches/series xxkb-1.11.1/debian/patches/series
--- xxkb-1.11.1/debian/patches/series 2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/patches/series 2024-11-12 23:22:16.0 +0800
@@ -1,3 +1,4 @@
0001-debian-patch.patch
0002-Fix-manpage-semantics.patch
0003-Imakefile-enable-debug-flag.patch
+0004-fix-ftbfs-on-gcc-14.patch
diff -Nru xxkb-1.11.1/debian/rules xxkb-1.11.1/debian/rules
--- xxkb-1.11.1/debian/rules 2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/rules 2024-11-12 23:36:05.0 +0800
@@ -3,11 +3,19 @@
# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1
+export CFLAGS := $(shell DEB_BUILD_MAINT_OPTIONS=hardening=+all dpkg-buildflags --get CFLAGS)
+export LDFLAGS := $(shell DEB_BUILD_MAINT_OPTIONS=hardening=+all dpkg-buildflags --get LDFLAGS)
+
%:
dh $@
-execute_before_dh_auto_build:
+execute_after_dh_auto_clean:
+ dh_auto_clean
+ rm -f Makefile
+
+override_dh_auto_build:
xmkmf
+ $(MAKE) DEB_CDEBUGFLAGS="$(CFLAGS) $(LDFLAGS)"
override_dh_auto_install:
$(MAKE) install install.man DESTDIR=$(CURDIR)/debian/tmp/
diff -Nru xxkb-1.11.1/debian/watch xxkb-1.11.1/debian/watch
--- xxkb-1.11.1/debian/watch 2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/watch 2024-11-12 23:35:12.0 +0800
@@ -1,2 +1,2 @@
-version=3
+version=4
http://sf.net/xxkb/xxkb-(\d+(?:\.\d+)+)-src\.tar\.gz
diff -Nru xxkb-1.11.1/debian/xxkb.doc-base xxkb-1.11.1/debian/xxkb.doc-base
--- xxkb-1.11.1/debian/xxkb.doc-base 1970-01-01 07:30:00.0 +0730
+++ xxkb-1.11.
Bug#1075694: xxkb: ftbfs with GCC-14
Hi,
On Tue, Nov 12, 2024 at 06:40:42PM +0800, YunQiang Su wrote:
On Tue, 12 Nov 2024 17:22:12 +0800 Bo YU wrote:
> xxkb (1.11.1-3) unstable; urgency=medium
> .
> * QA upload.
> * Add 0004-fix-ftbfs-on-gcc-14.patch to fix the ftbfs issue.
> (Closes: #1075694)
> * Set std-ver to 4.7.0.
> * Add Rules-Requires-Root on d/control.
> * Add doc-base for xxkb.
> * debian/rules: clean up Makefile explicitly.
> * debian/rules: update CDEBUGFLAGS to fix hardening issue.
Oops, I forget the debdiff about this, sorry for that.
$(MAKE) CDEBUGFLAGS="$(CFLAGS) $(LDFLAGS) $(CDEBUGFLAGS)"
will override the options in Imakefile: -Wall is missing.
I don't think that it is a good idea.
Ah, I did not notice that. Thanks for pointing out this and I think the
patch you proposed is more robust.
Updated it again, thanks.
--
Regards,
--
Bo YU
diff -Nru xxkb-1.11.1/debian/changelog xxkb-1.11.1/debian/changelog
--- xxkb-1.11.1/debian/changelog2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/changelog2024-11-12 23:36:05.0 +0800
@@ -1,3 +1,17 @@
+xxkb (1.11.1-3) unstable; urgency=medium
+
+ * QA upload.
+ * Add 0004-fix-ftbfs-on-gcc-14.patch to fix the ftbfs issue.
+(Closes: #1075694)
+ * Set std-ver to 4.7.0.
+ * Set standard of d/watch to 4.
+ * Add Rules-Requires-Root on d/control.
+ * Add doc-base for xxkb.
+ * debian/rules: clean up Makefile explicitly.
+ * Update 0003-*.patch and pass DEB_CDEBUGFLAGS to fix hardening issue.
+
+ -- Bo YU Tue, 12 Nov 2024 23:36:05 +0800
+
xxkb (1.11.1-2) unstable; urgency=medium
* QA upload.
diff -Nru xxkb-1.11.1/debian/control xxkb-1.11.1/debian/control
--- xxkb-1.11.1/debian/control 2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/control 2024-11-12 23:24:04.0 +0800
@@ -9,10 +9,11 @@
libxt-dev,
xutils-dev,
Maintainer: Debian QA Group
-Standards-Version: 4.6.1
+Standards-Version: 4.7.0
Homepage: http://sourceforge.net/projects/xxkb/
Vcs-Git: https://salsa.debian.org/debian/xxkb.git
Vcs-Browser: https://salsa.debian.org/debian/xxkb
+Rules-Requires-Root: no
Package: xxkb
Architecture: any
diff -Nru xxkb-1.11.1/debian/patches/0003-Imakefile-enable-debug-flag.patch
xxkb-1.11.1/debian/patches/0003-Imakefile-enable-debug-flag.patch
--- xxkb-1.11.1/debian/patches/0003-Imakefile-enable-debug-flag.patch
2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/patches/0003-Imakefile-enable-debug-flag.patch
2024-11-12 23:29:50.0 +0800
@@ -6,16 +6,14 @@
Imakefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
-diff --git a/Imakefile b/Imakefile
-index 931ca42..36010b8 100644
--- a/Imakefile
+++ b/Imakefile
-@@ -24,7 +24,7 @@ CFLAGS += `pkg-config --cflags glib-2.0 gdk-pixbuf-xlib-2.0
librsvg-2.0`
+@@ -24,7 +24,7 @@
LOCAL_LIBRARIES += `pkg-config --libs glib-2.0 gdk-pixbuf-xlib-2.0
librsvg-2.0`
#endif
-CDEBUGFLAGS = -O2 -Wall
-+CDEBUGFLAGS = -O2 -Wall -g
++CDEBUGFLAGS = -O2 -Wall -g $(DEB_CDEBUGFLAGS)
SED = sed
ComplexProgramTarget(xxkb)
diff -Nru xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch
xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch
--- xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch 1970-01-01
07:30:00.0 +0730
+++ xxkb-1.11.1/debian/patches/0004-fix-ftbfs-on-gcc-14.patch 2024-11-12
23:22:16.0 +0800
@@ -0,0 +1,17 @@
+Description: fix ftbfs on gcc-14
+Author: Bo YU
+Bug: https://bugs.debian.org/1075694
+Last-Update: 2024-11-04
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/resource.c
b/resource.c
+@@ -622,7 +622,7 @@
+ if (filename)
+ stat = XrmCombineFileDatabase(filename, &db, True);
+ else
+- stat = NULL;
++ stat = 0;
+ if (stat == 0 && db == NULL) {
+ /* failed */
+ warnx("Unable to find configuration data");
diff -Nru xxkb-1.11.1/debian/patches/series xxkb-1.11.1/debian/patches/series
--- xxkb-1.11.1/debian/patches/series 2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/patches/series 2024-11-12 23:22:16.0 +0800
@@ -1,3 +1,4 @@
0001-debian-patch.patch
0002-Fix-manpage-semantics.patch
0003-Imakefile-enable-debug-flag.patch
+0004-fix-ftbfs-on-gcc-14.patch
diff -Nru xxkb-1.11.1/debian/rules xxkb-1.11.1/debian/rules
--- xxkb-1.11.1/debian/rules2022-11-21 00:04:37.0 +0800
+++ xxkb-1.11.1/debian/rules2024-11-12 23:28:25.0 +0800
@@ -3,11 +3,19 @@
# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1
+export CFLAGS := $(shell DEB_BUILD_MAINT_OPTIONS=hardening=+all
dpkg-buildflags --get CFLAGS)
+export LDFLAGS := $(shell DEB_BUILD_MAINT_OPTIONS=hardening=+all
dpkg-buildflags --get LDFLAGS)
+
%:
dh $@
-execute_before_dh_auto_build:
+execute_after_dh_auto_clean:
+ dh_auto_clean
+ rm -f Makefile
+
+override
Bug#1093947: libuser: to enable test again
Source: libuser Version: 1:0.64+git20241106~dfsg-2 Severity: normal Tags: patch Dear Maintainer, The upload with #1092349 to disable the test to fix FTBFS issue, but new dependency crypt-r modules just got upload to unstable[1] almost at the same moment. So now it can be enable test during build and I have tested it. If you have time please have a look at this, thanks! [0]: https://bugs.debian.org/1092349 [1]: https://bugs.debian.org/1092770 -- Regards, -- Bo YU diff -Nru libuser-0.64+git20241106~dfsg/debian/changelog libuser-0.64+git20241106~dfsg/debian/changelog --- libuser-0.64+git20241106~dfsg/debian/changelog 2025-01-24 04:51:18.0 +0800 +++ libuser-0.64+git20241106~dfsg/debian/changelog 2025-01-24 09:45:01.0 +0800 @@ -1,3 +1,10 @@ +libuser (1:0.64+git20241106~dfsg-3) unstable; urgency=medium + + * QA upload. + * Add python3-crypt-r on B-D to enable tests again. (Closes: #-1) + + -- Bo YU Fri, 24 Jan 2025 09:45:01 +0800 + libuser (1:0.64+git20241106~dfsg-2) unstable; urgency=medium * QA upload. diff -Nru libuser-0.64+git20241106~dfsg/debian/control libuser-0.64+git20241106~dfsg/debian/control --- libuser-0.64+git20241106~dfsg/debian/control2025-01-24 04:51:18.0 +0800 +++ libuser-0.64+git20241106~dfsg/debian/control2025-01-24 09:45:01.0 +0800 @@ -17,6 +17,7 @@ linuxdoc-tools, pkg-config, python3, + python3-crypt-r, Standards-Version: 4.6.2 Homepage: https://pagure.io/libuser/ Vcs-Git: https://salsa.debian.org/debian/libuser.git diff -Nru libuser-0.64+git20241106~dfsg/debian/rules libuser-0.64+git20241106~dfsg/debian/rules --- libuser-0.64+git20241106~dfsg/debian/rules 2025-01-24 04:51:18.0 +0800 +++ libuser-0.64+git20241106~dfsg/debian/rules 2025-01-24 09:45:01.0 +0800 @@ -39,8 +39,5 @@ --with-python=yes \ $(ENABLE_SELINUX) -# Disable because there are crypt_r / crypt module imports -override_dh_auto_test: - execute_after_dh_auto_install: find . -name '*.la' -delete signature.asc Description: PGP signature
