Processed: split
Processing commands for cont...@bugs.debian.org: > clone 633524 -1 Bug #633524 [ksh] ksh fc command calls /bin/ed (doesn't exist) Bug 633524 cloned as bug 803726 > reassign -1 mksh Bug #803726 [ksh] ksh fc command calls /bin/ed (doesn't exist) Bug reassigned from package 'ksh' to 'mksh'. No longer marked as found in versions ksh/93s+20080202-1. Ignoring request to alter fixed versions of bug #803726 to the same values previously set > retitle -1 mksh fc command calls /bin/ed (doesn't exist) Bug #803726 [mksh] ksh fc command calls /bin/ed (doesn't exist) Changed Bug title to 'mksh fc command calls /bin/ed (doesn't exist)' from 'ksh fc command calls /bin/ed (doesn't exist)' > End of message, stopping processing here. Please contact me if you need assistance. -- 633524: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=633524 803726: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=803726 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#803800: avbin: FTBFS with FFmpeg 2.9
Package: avbin Version: 7-5 Severity: important Tags: patch User: pkg-multimedia-maintain...@lists.alioth.debian.org Usertags: ffmpeg2.9 Dear Maintainer, your package fails to build with the upcoming ffmpeg 2.9. This bug will become release-critical at some point when the ffmpeg2.9 transition gets closer. Attached is a patch replacing the deprecated functionality. It also works with ffmpeg 2.8. Please apply this patch and forward it upstream, if necessary. These changes are non-trivial and should be runtime-tested. Best regards, Andreas diff --git a/debian/patches/ffmpeg_2.9.patch b/debian/patches/ffmpeg_2.9.patch new file mode 100644 index 000..7a2b010 --- /dev/null +++ b/debian/patches/ffmpeg_2.9.patch @@ -0,0 +1,58 @@ +Description: Replace deprecated FFmpeg API +Author: Andreas Cadhalpun +Last-Update: <2015-11-02> + +--- avbin-7.orig/src/avbin.c avbin-7/src/avbin.c +@@ -291,7 +291,7 @@ AVbinStream *avbin_open_stream(AVbinFile + stream->codec_context = codec_context; + stream->type = codec_context->codec_type; + if (stream->type == AVMEDIA_TYPE_VIDEO) +-stream->frame = avcodec_alloc_frame(); ++stream->frame = av_frame_alloc(); + else + stream->frame = NULL; + return stream; +@@ -336,16 +336,21 @@ int avbin_decode_audio(AVbinStream *stre + return AVBIN_RESULT_ERROR; + + AVPacket avpkt; ++int got_frame = 0; + av_init_packet(&avpkt); + avpkt.data = data_in; + avpkt.size = size_in; +-used = avcodec_decode_audio3(stream->codec_context, +- (int16_t *) data_out, size_out, ++used = avcodec_decode_audio4(stream->codec_context, ++ stream->frame, &got_frame, + &avpkt); + +-if (used < 0) ++if (used < 0 || !got_frame) + return AVBIN_RESULT_ERROR; + ++*size_out = av_get_bytes_per_sample(stream->codec_context->sample_fmt) ++* stream->codec_context->channels * stream->frame->nb_samples; ++memcpy(data_out, stream->frame->data[0], *size_out); ++ + return used; + } + +@@ -375,7 +380,7 @@ int avbin_decode_video(AVbinStream *stre + return AVBIN_RESULT_ERROR; + + +-avpicture_fill(&picture_rgb, data_out, PIX_FMT_RGB24, width, height); ++avpicture_fill(&picture_rgb, data_out, AV_PIX_FMT_RGB24, width, height); + + static int sws_flags = SWS_BICUBIC; + static struct SwsContext *img_convert_ctx; +@@ -385,7 +390,7 @@ int avbin_decode_video(AVbinStream *stre + stream->codec_context->pix_fmt, + width, + height, +- PIX_FMT_RGB24, ++ AV_PIX_FMT_RGB24, + sws_flags, NULL, NULL, NULL); + + sws_scale( img_convert_ctx, diff --git a/debian/patches/series b/debian/patches/series index 9bca9a1..b1a9242 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1 +1,2 @@ libav.patch +ffmpeg_2.9.patch
Bug#803726: my friend, Ed
Nicholas Bamber dixit: > Also I would have thought the fc functionality is an intrinsically interactive > piece of functionality. What sort of script would depend on the fc default > being 'ed'? And if a script did somehow interact with fc surely it would ed is an interactive editor ;) but, to answer the question, at the very least the testsuite would. > Perhaps using debconf the postinst could offer to copy /etc/skel/.kshrc to > users home directories We don’t do that in Debian. Cannot, really. Just stick it into the .kshrc file and assume users are clueful enough to copy that into their HOME manually if the account was created prior to installation of the package. I know mksh users do, as the shipped mkshrc is an extremely useful settings bundle and the shell’s very bare without it. bye, //mirabilos -- [00:02] gecko: benutzt du emacs ? [00:03] nö [00:03] nur n normalen mac [00:04] argl [00:04] ne den editor -- Vutral und gecko2 in #deutsch (NB: Editor? Betriebssystem.)
Bug#796635: Systemd job
Thanks for the review Felipe > Why did you preserve runlevel S? I don't think this really belongs in > recovery mode. Changed >> +;; >> + stop|restart|reload|force-reload) > > restart (and force-reload?) should probably re-run the recovery script. Changed. >> +Description=To recover nvi edit sessions. > > s/To r/R/ ? +1 > Also, the init script Provides: nviboot, so you should provide a link > from nviboot.service to nvi.service in /lib/systemd/system. I changed it so it provided nvi. That was the whole reason I changed the name afterall. >> ++if [ -n "$sessions_found" ] ; then >> ++echo "done." >> ++else >> ++echo "none found." >> ++fi > > This is a behavior change: previously the recover script would not > print any output. Maybe this should not be printed? The previous init script did print none found though. > Why do you invoke dh_systemd_enable manually? the --with=systemd above > should do it. > >> + dh_installinit -- start 70 S . > > start argument is obsolete now and just invokes `defaults`, so this > override can go. Because I didn't know what i was doing, oops. > However, this changes the name of the init script from nviboot to nvi. > This means you need to use dpkg-maintscript-helper to handle the > rename, and remove the old enablement links as well. If you want to do > this you might as well move it out of runlevel S ;) Moved out of runlevel S and it deletes nviboot correctly now. Thanks again, Bryan nvi_1.81.6-12.debdiff Description: Binary data
Bug#796635: Systemd job
On 2 November 2015 at 18:57, Bryan Quigley wrote: > Thanks for the review Felipe > >> Why did you preserve runlevel S? I don't think this really belongs in >> recovery mode. > Changed > >>> +;; >>> + stop|restart|reload|force-reload) >> >> restart (and force-reload?) should probably re-run the recovery script. > > Changed. > > >>> +Description=To recover nvi edit sessions. >> >> s/To r/R/ ? > +1 > >> Also, the init script Provides: nviboot, so you should provide a link >> from nviboot.service to nvi.service in /lib/systemd/system. > I changed it so it provided nvi. That was the whole reason I changed > the name afterall. OK. > >>> ++if [ -n "$sessions_found" ] ; then >>> ++echo "done." >>> ++else >>> ++echo "none found." >>> ++fi >> >> This is a behavior change: previously the recover script would not >> print any output. Maybe this should not be printed? > > The previous init script did print none found though. Maybe I'm worrying too much (I leave it to you to decide), but maybe people are using this in cronjobs or other scripted environments, and this changes the output. > >> Why do you invoke dh_systemd_enable manually? the --with=systemd above >> should do it. >> >>> + dh_installinit -- start 70 S . >> >> start argument is obsolete now and just invokes `defaults`, so this >> override can go. > > Because I didn't know what i was doing, oops. You removed the --no-start --no-restart-on-upgrade arguments to dh_systemd_start, are you sure you want to restart on package install/upgrade? > >> However, this changes the name of the init script from nviboot to nvi. >> This means you need to use dpkg-maintscript-helper to handle the >> rename, and remove the old enablement links as well. If you want to do >> this you might as well move it out of runlevel S ;) > > Moved out of runlevel S and it deletes nviboot correctly now. Cool. Except for 3 things: 1. Instead of adding the rm_connfile calls maually, you can use the dh_installdeb support. Check the manpage for details (basically, put the rm_conffile part only once in debian/nvi.maintscript). 2. This is not really a rm_conffile, but rather a mv_conffile (the script is renamed, not removed). 3. This will not preserve enable/disable modifications by the user. There is no simple solution for this (you need to check in preinst the state if differing from the default, and restore it in postinst for the new script name), so maybe just adding a note to NEWS.Debian suffices? Any modifications made to the init script will be lost anyways when using systemd as then only the service file will be used. Thanks for your work! -- Saludos, Felipe Sateler
