Bug#651819: "pkgconfig --libs enchant" specifies unnecessary libraries

2011-12-20 Thread Agustin Martin
On Mon, Dec 12, 2011 at 12:52:54PM +0100, Per Olofsson wrote:
> Package: libenchant-dev
> Version: 1.6.0-6
> Severity: minor
> 
> When I build lyx, dpkg-shlibdeps complains about it unnecessarily
> linking against libgmodule, libglib, and librt.
> 
> It turns out that lyx depends on these libraries because it uses
> enchant. Indeed:
> 
> $ pkg-config --libs enchant
> -pthread -lenchant -lgmodule-2.0 -lrt -lglib-2.0

Hi, Per

Those libs seem to come from 

Requires: glib-2.0 gmodule-no-export-2.0

entry in upstream enchant.pc.in

> It appears that enchant can be used without explicitly depending on
> the extra libraries. Please consider moving them to Libs.private in
> enchant.pc.

I guess you mean that lyx can use enchant without explicitly depending on
above libraries, enchant itself seems to heavily rely on glib-2.0.

I am not familiar with pkg-config and friends. Should something like
Requires.private help here? Or is better Libs.private as you suggest?

PS: I am not enchant maintainer, just have it under my radar because I
uploaded last QA. enchant itself is orphaned.

Regards,

-- 
Agustin



-- 
To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20111220121538.ga21...@agmartin.aq.upm.es



Bug#651819: "pkgconfig --libs enchant" specifies unnecessary libraries

2011-12-20 Thread Per Olofsson
Hi Agustin,

Thanks for responding.

2011-12-20 13:15, Agustin Martin skrev:
>> $ pkg-config --libs enchant
>> -pthread -lenchant -lgmodule-2.0 -lrt -lglib-2.0
> 
> Hi, Per
> 
> Those libs seem to come from 
> 
> Requires: glib-2.0 gmodule-no-export-2.0
> 
> entry in upstream enchant.pc.in

OK.

> 
>> It appears that enchant can be used without explicitly depending on
>> the extra libraries. Please consider moving them to Libs.private in
>> enchant.pc.
> 
> I guess you mean that lyx can use enchant without explicitly depending on
> above libraries, enchant itself seems to heavily rely on glib-2.0.

Yes, that's exactly what I mean. While enchant itself relies on glib,
the API it exposes doesn't require glib. So programs like lyx, which
uses the enchant API but not glib, doesn't need to link directly with
glib. This reduces the number of dependencies for lyx, which makes
various transitions (ABI, testing) easier.

> I am not familiar with pkg-config and friends. Should something like
> Requires.private help here? Or is better Libs.private as you suggest?

Yes, Requires.private would help. Not Libs.private, of course, sorry.

So, what I'm suggesting is to move glib and gmodule to a
Requires.private line.

-- 
Pelle



-- 
To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4ef0a023.5020...@debian.org



Processing of mined_2011.19.2-1_amd64.changes

2011-12-20 Thread Debian FTP Masters
mined_2011.19.2-1_amd64.changes uploaded successfully to localhost
along with the files:
  mined_2011.19.2-1.dsc
  mined_2011.19.2.orig.tar.gz
  mined_2011.19.2-1.diff.gz
  mined_2011.19.2-1_amd64.deb

Greetings,

Your Debian queue daemon (running on host franck.debian.org)


-- 
To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1rd1ow-rg...@franck.debian.org



mined_2011.19.2-1_amd64.changes ACCEPTED into unstable

2011-12-20 Thread Debian FTP Masters



Accepted:
mined_2011.19.2-1.diff.gz
  to main/m/mined/mined_2011.19.2-1.diff.gz
mined_2011.19.2-1.dsc
  to main/m/mined/mined_2011.19.2-1.dsc
mined_2011.19.2-1_amd64.deb
  to main/m/mined/mined_2011.19.2-1_amd64.deb
mined_2011.19.2.orig.tar.gz
  to main/m/mined/mined_2011.19.2.orig.tar.gz


Override entries for your package:
mined_2011.19.2-1.dsc - source editors
mined_2011.19.2-1_amd64.deb - optional editors

Announcing to debian-devel-chan...@lists.debian.org
Closing bugs: 630621 646479 


Thank you for your contribution to Debian.


-- 
To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1rd1y0-00020f...@franck.debian.org



Processed: Re: Bug#651819: "pkgconfig --libs enchant" specifies unnecessary libraries

2011-12-20 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tag 651819 +pending
Bug #651819 [libenchant-dev] "pkgconfig --libs enchant" specifies unnecessary 
libraries
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
651819: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=651819
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


-- 
To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/handler.s.c.132439956820696.transcr...@bugs.debian.org



Bug#651819: "pkgconfig --libs enchant" specifies unnecessary libraries

2011-12-20 Thread Agustin Martin
tag 651819 +pending
thanks

On Tue, Dec 20, 2011 at 03:48:03PM +0100, Per Olofsson wrote:
> 2011-12-20 13:15, Agustin Martin skrev:
> > I am not familiar with pkg-config and friends. Should something like
> > Requires.private help here? Or is better Libs.private as you suggest?
> 
> Yes, Requires.private would help. Not Libs.private, of course, sorry.
> 
> So, what I'm suggesting is to move glib and gmodule to a
> Requires.private line.

Hi Per, Hi Bastien

Thanks for the clarification. I have prepared a quilt patch with that change
and committed it to enchant collab-maint git repo

git://anonscm.debian.org/collab-maint/enchant.git

together with a lintian fix for an unrelated issue. 

I am cc'ing Bastien ROUCARIES, who has shown interest in the package in case
he has some other changes ready to go or something else to add.

If Bastien does not upload himself, I will prepare a new QA upload with
these changes. If no further problems appear we shoud also file a bug report
at upstream bug tracker.

Regards,

-- 
Agustin



-- 
To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20111220164556.ga11...@agmartin.aq.upm.es